#instantbird log on 07 25 2012

All times are UTC.

00:01:42 <-- jb has quit (Input/output error)
00:08:24 <instant-buildbot> build #291 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/291
00:12:08 <-- aleth has quit (Input/output error)
00:20:36 <-- timA has quit (Quit: Instantbird 1.1)
00:25:31 <-- FeuerFliege has quit (Ping timeout)
00:27:59 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:29:02 --> FeuerFliege has joined #instantbird
01:20:53 <-- Kaishi has quit (Quit: Kaishi)
01:30:52 <-- clokep_linux has quit (Ping timeout)
01:32:31 <instant-buildbot> build #259 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/259
01:45:21 <instant-buildbot> build #279 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/279
02:22:47 <-- wesj has quit (Ping timeout)
02:22:49 --> wesj has joined #instantbird
03:00:09 <instant-buildbot> build #567 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/567
03:47:19 --> Kaishi has joined #instantbird
03:53:44 <-- Kaishi has quit (Quit: Kaishi)
03:53:49 --> Kaishi has joined #instantbird
03:57:27 <-- Kaishi has quit (Quit: Kaishi)
04:15:46 <-- Gizmokid2005 has quit (Ping timeout)
04:24:08 --> Gizmokid2005 has joined #instantbird
04:51:23 <instant-buildbot> build #655 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/655
04:52:46 --> Optimizer has joined #instantbird
05:17:09 <-- Optimizer has quit (Ping timeout)
05:39:33 <-- EionRobb has quit (Quit: Leaving.)
05:45:26 --> meh has joined #instantbird
05:53:04 --> Optimizer has joined #instantbird
05:56:32 <-- Optimizer has quit (Ping timeout)
06:06:42 <instant-buildbot> build #560 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/560
07:43:55 --> EionRobb has joined #instantbird
08:03:18 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
08:03:23 --> Even has joined #instantbird
08:03:23 * ChanServ sets mode +o Even 
08:31:05 --> Even1 has joined #instantbird
08:31:38 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
08:32:12 --> Even1 has joined #instantbird
08:41:06 --> flo has joined #instantbird
08:41:07 * ChanServ sets mode +qo flo flo 
08:54:13 --> aleth has joined #instantbird
08:54:13 * ChanServ sets mode +h aleth 
08:58:32 <-- meh has quit (Ping timeout)
08:59:11 --> csimi has joined #instantbird
09:02:49 --> meh has joined #instantbird
09:04:58 --> Mic has joined #instantbird
09:04:59 * ChanServ sets mode +h Mic 
09:05:35 <-- aleth has quit (Quit: Au revoir)
09:08:05 <Mic> hi
09:08:31 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:08:51 --> Mic has joined #instantbird
09:08:51 * ChanServ sets mode +h Mic 
09:09:48 <-- gerard-majax has quit (Ping timeout)
09:13:34 --> mmkmou has joined #instantbird
09:13:43 <-- mmkmou has quit (Client exited)
09:13:49 --> mmkmou has joined #instantbird
09:16:36 <-- mmkmou has quit (Ping timeout)
09:19:53 --> mmkmou has joined #instantbird
09:28:15 --> sonny has joined #instantbird
09:40:31 <-- Mic has quit (Connection reset by peer)
10:11:37 --> gerard-majax has joined #instantbird
10:18:49 <-- meh has quit (Ping timeout)
10:20:16 --> clokep_wp7 has joined #instantbird
10:29:15 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:31:10 <clokep_wp7> Good morning!
10:32:58 <EionRobb> wp7 doesn't stand for windows phone 7 does it?
10:33:16 --> meh has joined #instantbird
10:39:27 <clokep_wp7> EionRobb: It does in fact. ;-)
10:40:47 <EionRobb> I am sorry for your loss.
10:41:34 <clokep_wp7> It's by far the best phone I've ever used. Beats the pants off iOS and Android.
10:43:20 <EionRobb> if you insist
10:43:30 <EionRobb> I rooted my widnows phone to install android on it with an ios theme :)
10:43:45 <EionRobb> makes it hard to explain to people when they ask what it is
10:47:12 <clokep_wp7> If you insist. Sounds like you're trying to confuse them. :-P
10:48:00 <clokep_wp7> I will admit that this IRC client sucks though. :-)
10:48:04 <EionRobb> do you develop apps for your wp7?
10:48:12 <EionRobb> does IB run on wp7? :)
10:51:58 <clokep_wp7> No, I don't and no, it doesn't.
10:53:00 --> Even has joined #instantbird
10:53:00 * ChanServ sets mode +o Even 
10:55:21 <-- mmkmou has quit (Ping timeout)
10:55:53 <-- clokep_wp7 has quit (Broken pipe)
10:59:50 --> mmkmou has joined #instantbird
11:01:33 <flo> anybody knows what's up with the pt-br locale?
11:01:39 <flo> there's still nothing in the repository
11:02:40 <-- EionRobb has quit (Connection reset by peer)
11:04:26 --> EionRobb has joined #instantbird
11:08:41 --> PsyCoil has joined #instantbird
11:08:49 <-- PsyCoil has quit (Quit: Instantbird 1.1)
11:10:47 * flo is welcoming a new translator for the hu locale.
11:13:24 <EionRobb> hu is it?    hahaha *sigh*
11:19:16 <flo> we currently have only 9 locales in a shippable state
11:21:56 <-- chrisccoulson has quit (Quit: Ex-Chat)
11:22:23 <flo> We shipped 1.1 in fr, pl and ru but these 3 locales are clearly not ready. Time to ping translators?
11:25:17 --> chrisccoulson has joined #instantbird
11:27:58 <-- meh has quit (Ping timeout)
11:38:06 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:38:21 --> clokep_work has joined #instantbird
11:38:21 * ChanServ sets mode +o clokep_work 
11:39:08 <clokep_work> flo: Oops. I never emailed him the whole list of people. :( The repo was set up and the credentials sent, I assume?
11:39:19 <flo> yes
11:39:31 <flo> I think he hasn't been added to the l10n mailing list
11:39:40 <flo> but we haven't sent anything to that list since that :)
11:59:20 * clokep_work is writing them an email now.
12:01:58 <flo> :)
12:06:52 <clokep_work> Would anyone like to read it before I send it or...?
12:07:15 <flo> if you want someone to read it I can, otherwise I trust you :).
12:15:45 <flo> the new hu localizer is already pushing to his repository https://hg.instantbird.org/l10n/hu/ ;)
12:16:11 <clokep_work> flo: Was there an email about the hu localization?
12:16:53 <flo> no
12:17:15 <flo> I've been chatting with the localizer over facebook chat
12:17:28 <clokep_work> Ah, interesting. :)
12:17:56 <flo> we met at MozCamp (Berlin) and he kept asking me when our infrastructure would be ready again for him to get the hu locale in order
12:20:01 <clokep_work> Ah-ha, nice. :)
12:20:05 <clokep_work> OK, email sent.
12:24:16 <-- EionRobb has quit (Quit: Leaving.)
12:38:12 --> Lalae has joined #instantbird
12:41:03 <-- Lalae has left #instantbird ()
12:47:45 --> mali has joined #instantbird
12:47:53 <clokep_work> Anyone have ideas for that email just sent to the contact list?
12:48:00 <clokep_work> They're getting a "Lost connection with server" for both moznet and freenode.
12:48:10 <clokep_work> Most likely it's something like "Make sure your firewall has 6667 open"?
12:49:34 <flo> or make sure you are using port 6697 if you checked "ssl"
13:27:43 <-- sonny has quit (Ping timeout)
13:47:31 <-- gerard-majax has quit (Ping timeout)
13:57:41 <-- mmkmou has quit (Ping timeout)
13:58:56 --> sonny has joined #instantbird
14:11:16 <clokep_work> Looks like Mozilla 17 might be painful...?
14:16:44 <flo> why?
14:17:18 <clokep_work> Sounds like Thunderbird is having a lot of issues right now.
14:17:31 <clokep_work> Changes for MSVC11?
14:17:59 <flo> VC11?
14:18:05 * flo hasn't read dev.planning in a while
14:18:16 * clokep_work has been reading #maildev. ;)
14:18:22 <clokep_work> And I looked over the bugs a bit.
14:18:32 <clokep_work> Apparently Windows 8 + MSVC 2011 changes a bunch of stuff.
14:18:49 <flo> I haven't heard of a VC10 -> 11 switch
14:19:00 <clokep_work> Not a switch, just compatibility.
14:19:21 <clokep_work> https://bugzilla.mozilla.org/show_bug.cgi?id=687213
14:44:33 <clokep_work> Ah apparently they're having different issues, never mind. :-D
14:45:01 <flo> yeah, they are having issues with anvil and piano trucks
14:49:57 --> mmkmou has joined #instantbird
14:56:44 <clokep_work> Ouch.
15:14:11 <-- FeuerFliege has quit (Ping timeout)
15:19:07 --> gerard-majax has joined #instantbird
15:20:07 --> wnayes has joined #instantbird
15:39:07 --> igorko has joined #instantbird
15:47:22 --> myk has joined #instantbird
15:49:48 --> FeuerFliege has joined #instantbird
15:51:34 * flo is reading XEP54 and 153 again :(
15:52:18 --> Optimize1 has joined #instantbird
15:52:46 <-- Optimize1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:53:41 --> Optimize1 has joined #instantbird
15:55:47 <-- Optimize1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:55:52 --> Optimizer has joined #instantbird
15:58:37 <-- myk has quit (Ping timeout)
15:58:41 --> myk has joined #instantbird
16:03:19 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:10:07 <-- gerard-majax has quit (Ping timeout)
16:23:22 <clokep_work> Anything good in there?
16:28:06 <flo> it's boring ;)
16:28:29 <clokep_work> Are they better or worse than reading RFCs? :P
16:28:38 <flo> better
16:28:47 <flo> it's HTML with "some" color
16:28:55 <clokep_work> Then I envy you. ;)
16:29:06 <clokep_work> I usually read the text version of RFCs too because they're local...
16:29:19 <flo> but reading RFCs is your hobby, so you probably ended up liking it
16:29:50 <clokep_work> :P
16:29:58 <clokep_work> Not my hobby, I've just read a lot now. :)
16:31:02 <flo> yeah, you may have read more IRC RFCs than anybody else on earth :)
16:31:24 --> aleth has joined #instantbird
16:31:25 * ChanServ sets mode +h aleth 
16:37:06 * clokep_work isn't sure if that's a good thing or not. ;)
16:47:00 --> rosonline has joined #instantbird
16:48:52 <rosonline> Hi. I'm new in this chat. Where is billysanca?
16:50:09 <clokep_work> rosonline: He's not on IRC.
16:50:18 <clokep_work> But welcome. :) I sent you that email.
16:50:18 <flo> rosonline: hello :).
16:50:24 <rosonline> Hello
16:50:39 * clokep_work has a meeting.
16:50:48 <rosonline> I received a message of the Instantbird forum
16:51:03 <rosonline> about the brazilian translations
16:53:52 <-- myk has quit (Ping timeout)
16:54:42 <rosonline> Nick rosonline
16:56:02 <flo> rosonline: do you have any question about it? :)
16:56:04 <aleth> rosonline, clokep_work: can probably help you when his meeting is over ;)
16:57:07 <rosonline> Ok
16:57:25 <rosonline> I'll join at this translations work
16:57:47 <aleth> Great :)
16:57:49 <rosonline> but i need to explain.
16:58:13 <rosonline> How or who can help me
16:58:18 <flo> I think FeuerFliege may also be able to help
16:58:57 <aleth> rosonline: You have seen this? https://wiki.instantbird.org/Instantbird:Translation
16:58:59 <flo> rosonline: have you read the information on the wiki already?
16:59:14 <rosonline> yes. Quickly...
17:00:44 * FeuerFliege was summoned
17:00:53 <FeuerFliege> hi,
17:00:53 --> Kaishi has joined #instantbird
17:01:33 <rosonline> Hi
17:01:42 <FeuerFliege> how can I help you?
17:01:46 <rosonline> I'm read the Wiki page.
17:01:58 <flo> FeuerFliege: he's a new translator for the pt-BR locale :)
17:02:07 --> myk has joined #instantbird
17:02:12 <rosonline> But i need to explain about the translations
17:02:18 <rosonline> Yes, i am
17:04:26 <rosonline> I downloaded the Tortoise HG for my Ubuntu.
17:04:32 <rosonline> and now?
17:06:54 <FeuerFliege> Ok, I am no expert on linux, but the Tortoise should work quite the same as on windows. Let me start my VM, so that I can follow each step.
17:07:15 <rosonline> ok
17:08:59 <FeuerFliege> The first thing to do is to clone the repository.
17:09:02 --> Lalae has joined #instantbird
17:09:07 <-- mmkmou has quit (Client exited)
17:10:01 <rosonline> Yes.
17:10:15 <rosonline> What is the link?
17:10:55 <Kaishi> Anyone have any experience with OI running on AMD Opteron processors? I'm trying to decide if upgrading from my 6128 to something in the 62XX series would be worthwhile
17:11:41 <aleth> rosonline: Have you configured your HG so it knows your email address?
17:12:20 <aleth> (just asking because it's the sort of thing one easily forgets)
17:12:26 <rosonline> No
17:12:45 <rosonline> I unknowed this step
17:13:08 <aleth> I can't tell you how because I don't use it myself, but I think there are instructions on the wiki page
17:19:02 <-- Lalae has left #instantbird ()
17:22:52 <aleth> yes, go to "Configuring Tortoise HG" and start from there.
17:25:38 <flo> aleth: the cut textbox highlight that you noticed yesterday is getting fixed https://bugzilla.mozilla.org/show_bug.cgi?id=776884 ;)
17:25:54 <aleth> flo: that was quick :)
17:26:23 <flo> aleth: it's a one character change ;)
17:36:14 <-- sonny has quit (Ping timeout)
17:40:47 * FeuerFliege vanishes to the kitchen … 
17:41:01 --> meh has joined #instantbird
17:46:01 <clokep_work> rosonline: Right, so in terms of organize about translating pt-BR I'm hoping that billysanca will handle that...but he hasn't replied yet. He's replied to my previous emails in 24 hours though. :)
17:53:11 <-- rosonline has quit (Input/output error)
17:58:22 --> timA has joined #instantbird
18:00:37 <instantbot> florian@instantbird.org requested feedback from clokep@gmail.com for attachment 1755 on bug 1556.
18:00:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1556 nor, --, ---, florian, NEW, Download the user's vCard before uploading an avatar
18:00:42 <-- Kaishi has quit (Quit: Kaishi)
18:01:26 <flo> for some reason, it was really difficult to motivate myself to write that patch.
18:01:50 <flo> anyway, time to go home!
18:01:52 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:02:17 <-- myk has quit (Ping timeout)
18:04:36 --> myk has joined #instantbird
18:12:57 <-- FeuerFliege has quit (Ping timeout)
18:13:59 <-- mali has quit (Ping timeout)
18:17:38 --> FeuerFliege has joined #instantbird
18:18:04 <-- FeuerFliege has quit (Input/output error)
18:19:01 --> FeuerFliege has joined #instantbird
18:26:30 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
18:27:09 <FeuerFliege> no response from the locales managers of fr, pl and ru, yet :(
18:37:47 <clokep_work> :-/ That's unfortunate.
18:48:44 <-- timA has quit (No route to host)
18:49:05 --> timA has joined #instantbird
18:50:04 * timA is now known as IRCMonkey26669
18:50:05 <-- IRCMonkey26669 has quit (Connection reset by peer)
18:50:06 --> timA1 has joined #instantbird
18:50:40 * timA1 is now known as timA
18:57:44 --> meh has joined #instantbird
19:05:28 <-- timA has quit (Ping timeout)
19:05:57 --> timA has joined #instantbird
19:06:46 * timA is now known as timA|lunch
19:11:58 <-- FeuerFliege has quit (Ping timeout)
19:12:47 <aleth> maybe they're all on holiday...
19:25:21 --> PsyCoil has joined #instantbird
19:25:24 <-- PsyCoil has quit (Quit: PsyCoil)
19:44:19 <-- meh has quit (Quit: mannaggia)
19:51:32 --> meh has joined #instantbird
20:04:18 * timA|lunch is now known as timA
20:06:26 <wnayes> I'm debating a couple ways to go about the mIRC log importing (https://etherpad.mozilla.org/7G3iRRMGMz), if anyone has any thoughts on either I would be happy to hear them!
20:14:18 --> instantbird has joined #instantbird
20:15:27 <-- instantbird has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:16:05 <-- igorko has quit (Ping timeout)
20:18:42 --> instantbird has joined #instantbird
20:18:49 * instantbird is now known as Tonnes2
20:19:48 --> igorko has joined #instantbird
20:20:34 <-- GeekShadow has quit (Ping timeout)
20:26:44 --> flo has joined #instantbird
20:26:45 * ChanServ sets mode +qo flo flo 
20:28:35 <-- flo has quit (Ping timeout)
20:35:30 --> flo has joined #instantbird
20:35:30 * ChanServ sets mode +qo flo flo 
20:37:10 * timA is now known as timA|mtg
20:43:09 * timA|mtg is now known as timA
20:45:18 --> Kaishi has joined #instantbird
20:46:33 <-- Tonnes2 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:01:05 <-- Kaishi has quit (Quit: Kaishi)
21:01:08 --> Kaishi has joined #instantbird
21:02:01 <instantbot> New Core - General bug 1606 filed by aletheia2@fastmail.fm.
21:02:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1606 nor, --, ---, nobody, NEW, Update to Mozilla 17
21:08:20 --> EionRobb has joined #instantbird
21:08:49 <clokep_work> Thanks aleth.
21:12:38 <instantbot> New Core - General bug 1607 filed by aletheia2@fastmail.fm.
21:12:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1607 nor, --, ---, nobody, NEW, Update to Mozilla 18
21:13:11 <clokep_work> No URL in that one?
21:13:40 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:14:43 <aleth> clokep: I noticed even the FF17 one doesn't actually exist yet.
21:16:17 <flo> wnayes: http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsISeekableStream.idl
21:17:57 <flo> wnayes: and lots of examples: http://mxr.mozilla.org/comm-central/search?string=nsISeekableStream&find=\.js%24&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
21:24:36 <wnayes> flo: That looks useful, thanks :).
21:25:58 <-- Optimizer has quit (Ping timeout)
21:34:05 <-- timA has quit (Quit: Instantbird 1.1)
21:34:06 <wnayes> nsIPartialFileInputStream (http://mxr.mozilla.org/comm-central/source/mozilla/netwerk/base/public/nsIFileStreams.idl#119) could be the answer too.
21:34:09 --> timA has joined #instantbird
21:36:11 <-- timA has quit (Quit: Instantbird 1.1)
21:36:17 --> timA has joined #instantbird
21:37:18 <-- timA has quit (Quit: Instantbird 1.1)
21:37:22 --> timA has joined #instantbird
21:38:10 --> GeekShadow has joined #instantbird
21:39:04 <flo> wnayes: that one seems less popular, the only usage in JS is a unit test: http://mxr.mozilla.org/comm-central/search?string=nsIPartialFileInputStream
21:40:15 * timA is now known as tabraldes
21:40:31 --> FeuerFliege has joined #instantbird
21:40:41 * tabraldes is now known as timA
21:42:10 <-- FeuerFliege has quit (Ping timeout)
21:44:14 <wnayes> flo: I probably want to avoid that one then. Either way, I'm hoping that it won't be too frustrating to read line-by-line and manage offsets.
21:45:01 <flo> I don't see why reading these files would be difficult
21:45:57 <flo> you just read until you find the end of a session, at that time you give the conversation to the logger and store the position to be able to resume from there if the user restarts the application
21:50:56 <wnayes> Yeah, I'm hoping that storing the position is straightforward. I'll try to get just the line by line reading down before the logging logic.
21:51:53 --> rosonline has joined #instantbird
21:52:22 <wnayes> I'm still unsure about the logger API changes (https://etherpad.mozilla.org/logger-api-changes).
21:58:52 <flo> I'm confused by the content of that pad
21:59:48 <wnayes> flo: Yeah... maybe a few too many thoughts have been dumped in there.
22:00:57 <flo> I don't see any interface (idl) proposal in there
22:01:56 <wnayes> Right now I'm thinking I need a Conversation object implementation without UI display. Then feed it information (similar to fake.js) and get notifications to the logger working to handle the log writing.
22:02:42 <flo> that logger.js file is a mess :(
22:05:00 <-- igorko has quit (Client exited)
22:07:47 <flo> I still don't understand bug 1530 :(
22:07:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, aletheia2, ASSI, Autoscroll subtly broken after moz13 update
22:09:17 <aleth> Which part don't you understand?
22:10:32 <flo> all of it.
22:10:50 <flo> I added dump calls to dump the relevant data in my debug build, but I don't even understand the steps to reproduce
22:11:05 <aleth> You did say it didn't happen very often on OSX.
22:11:24 <aleth> Let me see if I still have my dump log somewhere...
22:11:27 <flo> it happened to me at least half a dozen times today
22:11:56 <aleth> Basically the issue is that scroll events can happen while messages are being added initially
22:12:06 <flo> the interesting values are those involved in that test: http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#222
22:12:27 <aleth> Because during this initial add scrolling is turned off, we don't want updateAutoScrollEnabled to be called during that time
22:12:48 <flo> the conversations where I've seen this have never been put on hold.
22:13:12 <aleth> It's possible that may be something else then.
22:13:41 <aleth> My patch only fixes what I could reproduce ;)
22:14:47 <flo> I wonder if it could be a race between time bubble's code tweaking margins and the auto-scroll test
22:15:03 <aleth> Could be. That didn't show up when I added dumps though.
22:15:07 <flo> have you ever seen this bug with a non-time-bubble theme?
22:15:19 <aleth> The bug I fixed, yes.
22:16:05 <aleth> Though I did wonder what was sending those scroll events, I could never figure that out.
22:16:35 <aleth> The patch in that bug only solves the problem for restoring-from-hold, obviously.
22:16:43 <aleth> I didn't realize there was more :-S
22:17:17 <flo> the bug that annoys me is: "I've been talking with Even for a while, and at some point I scroll in the scrollback to find a quote or read again a message. Then I scroll to the bottom of the conversation. And I discover that Even has actually sent a few messages only when I send a message myself and don't see it, because I need to scroll to see it and re-enable the autoscroll."
22:18:18 <flo> hmm, could messages arriving while auto-scroll is disabled mess things up?
22:18:34 <flo> I don't really see why
22:22:33 <aleth> That's odd, because manual scrolling should certainly trigger updateAutoScrollEnabled.
22:23:07 <aleth> But the only way I figured out what was happening on restore was by adding lots of dump statements...
22:23:20 <flo> it does the second time (when I scroll manually because I don't see my new message)
22:23:26 <aleth> It's surprising how many scroll events there are
22:23:50 <flo> hmm, it's possible that I'm scrolling with a 3 fingers gesture on my touchpad, which would be a section scroll
22:24:11 <flo> could it be that we missed an updateAutoScrollEnabled call in the section scroll code?
22:24:13 <aleth> it sounds like this._scrollingIntoView is set when it should not be
22:24:23 <aleth> (possibly)
22:25:05 <aleth> flo: I think it's explicitly there
22:25:58 <-- timA has quit (Quit: Instantbird 1.1)
22:26:28 <flo> btw, when you say there are many scroll events. You have seen that time bubbles causes one each time the margin changes, right?
22:26:43 <aleth> Yes
22:28:01 <aleth> I can't see atm how it is possible to section scroll to the end and not have autoscroll reset
22:29:11 <aleth> Because that is not dependent on any events
22:29:38 <flo> another way to look at it: we know it's a regression.
22:29:40 <flo> what has changed?
22:29:58 <flo> wasn't there some blog posts on planet a while ago about enabling smooth scrolling?
22:30:01 <aleth> My suspicion was that more events were being fired for some reason
22:30:27 <aleth> This being the one log I still have http://pastebin.instantbird.com/53207
22:30:33 <flo> if when the scrollIntoView there's a smooth scrolling, that could mean that the values we measure immediately after calling scrollIntoView are wrong
22:30:41 <aleth> The bug only arises on the second scroll event during restoring from hold
22:31:23 <flo> "more events being fired" -> isn't the principle of smooth scrolling that it scrolls several times by a small amount?
22:31:50 <aleth> Could be. But doesn't IB have smooth scrolling on by default anyway?
22:32:07 <aleth> At least I can't remember turning it on :-/ maybe that was the change...
22:32:14 <flo> "on the second scroll event during restoring from hold" does that mean "when adding a new message while we haven't finished to scroll the previous one into view because of smooth scrolling"?
22:32:42 <flo> hmm, the checkbox is off for me in the pref window :(
22:32:48 <aleth> No, because this is while the initial messages are being added and scrolling to new messages is turned off
22:33:21 <flo> isn't it turned back on for the last message?
22:33:32 <aleth> Only at the very end
22:34:06 <aleth> What happens in the bug, as you can see, is that autoscroll is turned off before that happens due to the events interceding.  So we then don't scroll to the end anyway.
22:37:13 <aleth> I am still puzzled by what you are reporting, especially if you used section scroll.
22:37:58 <aleth> aha!
22:38:55 <flo> I'm not sure I used section scroll
22:39:12 <aleth> hmm no that wouldnt work
22:39:20 <flo> it's something I frequently do, but it may very well be that the cases where I experienced the bug are the cases where I didn't use section scroll
22:40:01 <aleth> It's possible my patch might help if it was NOT section scroll, because of the cleanup in addMsg
22:41:09 <aleth> i.e. no updateAutoScrollEnabled calls triggered by adding a message
22:42:54 <aleth> Because that seemed a potential cause of problems if a new message was added quickly enough to turn off autoscroll in that case
22:42:54 <flo> I don't see how that would help.
22:43:20 <flo> it's the opposite
22:43:42 <aleth> Yes
22:43:42 <flo> that call is here in case we are adding a new message and for some reason autoscroll was off the but scrollbar was nearly at the bottom
22:44:12 <aleth> All I mean is it is an unnecessary source of updateAutoScroll calls that was removed. I don't understand the interaction which is causing the problem
22:44:23 <flo> adding a message should never turn auto-scroll off.
22:44:31 <aleth> Exactly
22:44:38 <flo> and anyway, we called this._updateAutoScrollEnabled() only if auto-scroll was already off
22:45:14 <aleth> That's why it is unnecessary afaik\
22:45:52 <flo> the point of _updateAutoScrollEnabled is to re-enable auto-scroll ;)
22:46:01 <aleth> Sure
22:50:04 <aleth> (adding a message should never change the autoscroll setting, is a less confusing way of explaining the change)
22:50:06 * flo will sleep on it.
22:50:27 <flo> aleth: "(adding a message should never change the autoscroll setting, is a less confusing way of explaining the change)" I clearly disagree with that, so r- ;)
22:50:53 <aleth> Good, examples welcome ;)
22:51:28 <aleth> I might well have missed some of the thinking behind the original code...
22:51:42 <flo> if we miss some scroll events for some reason, it's useful to re-enable the auto-scroll at the time we add a message
22:51:47 <flo> it's definitely been useful in the past at lerast
22:51:50 <flo> *least
22:52:07 <aleth> But it isn't helping you at the moment, is it?
22:52:28 <aleth> So that does not seem a good place for this workaround
22:53:04 <flo> it's not saving us because the test at http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#222 doesn't pass, for a reason that we have yet to discover
22:53:26 <flo> aleth: the whole autoscroll code is a hack anyway
22:54:20 <flo> having to keep in a boolean whether autoscroll was enabled before or not is very unfortunate. It would be really better if things could work without this.
22:55:05 <-- Kaishi has quit (Quit: Kaishi)
22:55:48 <aleth> yes... tricky though. Really the memory is to distinguish user-triggered scrolling from the rest
22:57:02 <aleth> Hmm, I might try a patch just getting rid of it and seeing what breaks.
22:57:33 <flo> getting rid of the boolean?
22:58:57 <aleth> just autoscroll if the scrollbar is "at the bottom", no booleans or scrollingintoview stuff
22:59:44 <flo> but you would keep the onresize event handler?
22:59:49 <aleth> probably breaks on window resize etc 
22:59:52 --> timA has joined #instantbird
23:00:05 <aleth> Something like that.
23:00:32 <aleth> But there is probably a good reason why the code is the way it is :-/
23:00:52 <flo> there's certainly a good reason for why each of the hack was added
23:01:15 <flo> but it's possible some less powerful hacks should have been removed when more powerful ones have been added
23:02:01 <aleth> I am a bit concerned that overoptimistic 'optimization' might break on slower machines
23:02:26 <flo> aaaah, I remember why we need the _autoScrollEnabled boolean
23:02:50 <flo> it's for long long messages that can't fit in a small small chat window.
23:03:15 <aleth> ah!
23:03:24 <flo> we scroll the beginning of the message into view (because showing only the end of a message is completely pointless), but when the next message appears, we still want to show it
23:03:35 <aleth> Yes, that makes sense now.
23:04:19 <aleth> Probably also the reason for that if clause I removed :-S
23:04:23 <aleth> So that has to go back in.
23:04:43 <flo> and that also explains the scrollingIntoView boolean: if we are scrolling up of more than 10px, we shouldn't disable the auto-scroll if it was because of a scrollintoview call to show the begining of a long message
23:05:10 <aleth> Hmm, no, we should be fine without the if clause.
23:05:23 <aleth> Right.
23:05:58 <flo> I'm not sure what you are talking about
23:06:18 <aleth> The updateAutoScrollEnabled call I removed.
23:06:28 <aleth> I still don't see why it was necessary.
23:06:54 <flo> so we scroll the new message into view if either the current scrollbar position is the result of a previous scrollintoview call, or the current scrollbar position is less than 10px of the bottom.
23:07:17 <flo> I still don't see why you think it hurts
23:08:20 <aleth> I don't think it hurts.
23:09:28 <aleth> I just don't have a case for where it helps either
23:09:59 <flo> "the current scrollbar position is the result of a previous scrollintoview call (that's the |this._autoScrollEnabled| part of the test), or the current scrollbar position is less than 10px of the bottom (that's the |this._updateAutoScrollEnabled()| part of the test)."
23:10:57 <aleth> Yes, but how did the scrollbar get to less than 10px from the bottom without autoScroll being turned on already via an event...
23:11:27 <aleth> I'm no longer arguing for removing it, as it doesn't hurt (I took it out only to simplify the code)
23:13:28 <flo> "how did the scrollbar get to less than 10px from the bottom without autoScroll being turned on already via an event..." it shouldn't. But I don't want to trust these events.
23:16:16 <aleth> Still trying to come up with an explanation for your problem :-/
23:17:05 <EionRobb> magic
23:19:05 <flo> so if for some reason we receive more scroll events than we should, this._scrollingIntoView doesn't help us any more and browserScroll may disable the autoscroll
23:20:07 <aleth> yes, that's exactly what I fixed for the restoring-from-hold case. But you said you had scrolled to the bottom, in which case browserScroll will in fact enable it.
23:20:49 <flo> it's off by default for me
23:21:13 <flo> ignore that, I was replying to a very old message :-/
23:21:39 <-- chrisccoulson has quit (Ping timeout)
23:21:52 <flo> there could be a race if the message is inserted exactly while I'm scrolling.
23:22:02 <flo> (if we assume I didn't use section scroll)
23:22:04 --> sonny has joined #instantbird
23:22:12 <aleth> you mean, if you scroll while a message is being added.
23:22:47 <flo> yeah, if the scrollbar isn't refreshed until I stop scrolling, even though the content has changed
23:24:13 --> clokep_linux has joined #instantbird
23:27:52 <flo> Good night
23:27:53 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:38:49 --> chrisccoulson has joined #instantbird
23:40:02 <aleth> clokep_linux: still no hard drive? ;)
23:40:07 <-- chrisccoulson has quit (Client exited)
23:40:10 --> chrisccoulson has joined #instantbird
23:47:04 <clokep_linux> aleth: I got the hard drive this morning (13 hours after I put in the support call).
23:47:10 <clokep_linux> Windows 8 is installing right now.
23:47:22 <aleth> Not bad!
23:57:30 <-- myk has quit (Ping timeout)