#instantbird log on 07 17 2012

All times are UTC.

00:02:21 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:19:50 --> wesj1 has joined #instantbird
00:20:33 <-- wesj1 has quit (Quit: wesj1)
00:20:48 --> wesj1 has joined #instantbird
00:22:14 <-- wesj1 has quit (Quit: wesj1)
00:55:43 <-- EionRobb has quit (Connection reset by peer)
00:56:21 --> EionRobb has joined #instantbird
01:39:38 --> wesj1 has joined #instantbird
01:54:42 <-- wesj1 has quit (Ping timeout)
01:55:09 --> wesj1 has joined #instantbird
02:12:40 <-- wesj1 has quit (Ping timeout)
02:50:31 --> clokep has joined #instantbird
02:50:31 * ChanServ sets mode +o clokep 
03:03:42 <instant-buildbot> build #559 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/559
03:19:08 <clokep> flo: FWIW I'd say commit them automatically.
03:23:10 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
03:38:42 --> Optimizer has joined #instantbird
03:54:38 <-- Gizmokid2005 has quit (Ping timeout)
03:58:39 --> Gizmokid2005 has joined #instantbird
04:04:20 <-- Optimizer has quit (Ping timeout)
04:04:55 --> Optimizer has joined #instantbird
04:49:34 <-- Optimizer has quit (Ping timeout)
05:03:16 <-- Suiseiseki has quit (Ping timeout)
05:07:53 <instant-buildbot> build #647 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/647
05:22:27 <-- EionRobb has quit (Ping timeout)
05:22:40 --> wesj1 has joined #instantbird
05:24:50 <-- wesj1 has quit (Quit: wesj1)
05:26:10 --> FireFly_TB has joined #instantbird
05:27:36 <-- FireFly_TB has quit (Quit: FireFly_TB)
05:27:49 --> Suiseiseki has joined #instantbird
05:29:29 <-- skeledrew has quit (Connection reset by peer)
05:29:31 --> skeledrew has joined #instantbird
05:29:34 --> FireFly_TB has joined #instantbird
05:31:23 <-- FireFly_TB has quit (Quit: FireFly_TB)
05:31:59 --> FireFly_TB has joined #instantbird
06:06:25 <instant-buildbot> build #552 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/552
06:24:40 --> jb has joined #instantbird
06:27:42 --> jb1 has joined #instantbird
06:27:49 <-- jb has quit (Connection reset by peer)
06:50:07 <-- jb1 has quit (Ping timeout)
06:53:24 --> jb has joined #instantbird
06:58:34 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
06:58:46 --> Even1 has joined #instantbird
07:12:06 <-- jb has quit (Quit: jb)
07:12:19 --> jb has joined #instantbird
07:36:32 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
07:40:02 <-- SM0TVI has quit (Ping timeout)
07:44:14 <-- jb has quit (Connection reset by peer)
07:44:16 --> jb1 has joined #instantbird
07:47:03 --> Lalae has joined #instantbird
07:48:10 --> SM0TVI has joined #instantbird
08:04:43 --> aleth has joined #instantbird
08:04:43 * ChanServ sets mode +h aleth 
08:13:19 <-- Lalae has left #instantbird ()
08:17:50 --> sonny has joined #instantbird
08:20:55 --> Mic|web has joined #instantbird
08:21:13 <Mic|web> Hello
08:37:05 --> Mic|debug has joined #instantbird
08:37:16 --> bp has joined #instantbird
08:37:31 <-- bp has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
08:37:51 <Mic|debug> Nice, my first successful build on Windows :)
08:38:21 <Mic|debug> I've built on Linux before but that's only half as exciting as on Windows ;)
08:53:11 <-- Mic|debug has quit (Input/output error)
08:53:58 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
08:58:10 <-- jb1 has quit (Ping timeout)
09:03:29 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:03:33 --> Even has joined #instantbird
09:03:33 * ChanServ sets mode +o Even 
09:16:19 --> mmkmou has joined #instantbird
09:19:53 --> flo has joined #instantbird
09:19:53 * ChanServ sets mode +qo flo flo 
09:23:07 <-- sonny has quit (Ping timeout)
09:38:56 --> Mic has joined #instantbird
09:38:56 * ChanServ sets mode +h Mic 
09:46:36 <-- aleth has quit (Input/output error)
09:55:19 <flo> hello :)
09:57:59 <Mic> What should happen if I double click a Twitter participant?
09:58:14 <Mic> I'm getting an error at the moment :(
09:58:34 <flo> "Method not implemented"
09:58:39 <flo> it's a quite accurate error ;)
09:58:56 <flo> I think we should start a private conversation, so that's DM in Twitter's language :)
09:59:09 <flo> but the other option would be to show the participant's public timeline
09:59:18 <Mic> I expected to see the users tweets
09:59:28 <Mic> Ah, that's #2 then
10:00:12 --> FeuerFliege has joined #instantbird
10:01:56 <instantbot> New Core - Twitter bug 1596 filed by benediktp@ymail.com.
10:01:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1596 enh, --, ---, nobody, NEW, Implement 'default action' for Twitter participants
10:09:54 <flo> DM would be consistent with what we do on IRC
10:10:14 <flo> but showing someone's timeline would also be quite useful
10:10:31 --> sonny has joined #instantbird
10:11:20 <flo> what would the input box do when looking at somebody's timeline?
10:12:44 <flo> sending an @ message (ie a public message directed to that person) would make sense I think, but would the @username be displayed in the UI or added automatically upon sending? I think it should be visible, but how would we ensure the user doesn't remove it from the textbox?
10:20:54 --> clokep has joined #instantbird
10:20:54 * ChanServ sets mode +o clokep 
10:30:28 <clokep> Mic: Congrats. :)
10:31:27 <flo> I was surprised to see that blog post is more than a year old
10:31:33 <flo> time flies :-S
10:35:31 <clokep> Yes. :)
10:36:55 <clokep> It should probably be made a wiki page though. ;)
10:43:43 --> jb has joined #instantbird
10:44:59 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:52:52 <-- chrisccoulson has quit (Ping timeout)
10:54:54 <-- jb has quit (Quit: jb)
10:57:25 --> jb has joined #instantbird
11:00:27 <-- jb has quit (Input/output error)
11:00:31 --> jb has joined #instantbird
11:42:29 <-- FireFly_TB has quit (Ping timeout)
11:42:29 <-- FeuerFliege has quit (Ping timeout)
11:51:11 --> clokep_work has joined #instantbird
11:51:11 * ChanServ sets mode +o clokep_work 
12:39:55 --> Optimizer has joined #instantbird
12:41:43 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
13:02:19 --> chrisccoulson has joined #instantbird
13:03:25 <clokep_work> wnayes: // TODO: Surely there is a better way to keep two values without split()?
13:03:25 <clokep_work> this._preparationQueue.push(aAccountId + "," + aImporterId);
13:03:40 <clokep_work> Why not just this._preparationQueue.push([aAccountId, aImporterId]);?
13:09:04 <-- mmkmou has quit (Ping timeout)
13:19:54 <instantbot> clokep@gmail.com denied review for attachment 1730 on bug 1547.
13:19:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1547 nor, --, ---, nobody, NEW, Check for open conversations when adding a buddy
13:24:36 <instantbot> clokep@gmail.com requested review from florian@instantbird.org for attachment 1734 on bug 785.
13:24:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=785 nor, --, ---, aletheia2, ASSI, Close tab option doesn't work properly when using the tab drop down button
13:27:43 <-- jb has quit (Input/output error)
13:27:47 --> jb has joined #instantbird
13:27:48 <-- jb has quit (Input/output error)
13:27:56 --> jb has joined #instantbird
13:28:07 <-- jb has quit (Input/output error)
13:28:13 --> jb has joined #instantbird
13:28:14 <-- jb has quit (Input/output error)
13:28:51 --> jb has joined #instantbird
13:31:22 <instantbot> florian@instantbird.org granted review for attachment 1734 on bug 785.
13:31:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=785 nor, --, ---, aletheia2, ASSI, Close tab option doesn't work properly when using the tab drop down button
13:37:11 <clokep_work> Do we have a "getting involved" page or something like that?
13:37:18 <clokep_work> Ah, we do... http://www.instantbird.org/#getinvolved
13:40:22 <flo> we should really have a donate button somewhere
13:42:56 <clokep_work> Yes. :(
13:44:51 <-- sonny has quit (Ping timeout)
13:45:13 <flo> the US version of the paypal website says that people using "donate" buttons don't even have to have a paypal account
13:45:24 <flo> the french version says they need to login to their paypal account
13:45:33 <clokep_work> :-S That's confusing.
13:46:23 <flo> I'm not sure if people giving money want to be anonymous or not
13:46:47 <flo> but I suspect we have to know who gave it if we don't want to be in trouble with the French tax authorities :-S
13:48:44 <clokep_work> Right, but that doesn't mean it needs to be posted like on a website somewhere.
13:49:01 <flo> but it means people have to login
13:49:42 <clokep_work> Ah-ha. I see.
13:50:01 <clokep_work> If you do it via the French website, maybe it forces people to log-in?
13:50:56 <flo> possibly
13:51:40 <flo> I wonder if paypal will charge us the conversion between dollars and euros each time someone donates something, or only once when we move the money back to the instantbird bank account
13:55:11 <clokep_work> Mic: So I don't know what to do with bug 1511 still, not sure if you ever looked at it again. (Maybe now that you can build...?)
13:55:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts
13:55:19 <flo> setting up a paypal account wiht a donae button could be something to do for the 1.2 release
13:55:29 <clokep_work> Yes, that sounds reasonable. :)
13:55:58 <flo> I wonder when 1.2 is likely to happen
13:56:22 --> mmkmou has joined #instantbird
13:57:54 <flo> even though it looks completely unrelated, I don't see myself focusing on any serious Instantbird work until I have a decent internet access and a kitchen sink and a shower at home. :-S
14:04:39 <-- jb has quit (Ping timeout)
14:06:25 --> sonny has joined #instantbird
14:06:56 <instantbot> clokep@gmail.com granted feedback for attachment 1729 on bug 1569.
14:06:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1569 enh, --, ---, nobody, NEW, Add someone as a buddy directly from an open conversation
14:11:14 --> FireFly_TB has joined #instantbird
14:11:15 --> FeuerFliege has joined #instantbird
14:12:07 <clokep_work> :( It'd be great if we could release 1.2 soon. :-/
14:12:58 <-- FireFly_TB has quit (Ping timeout)
14:12:58 <-- FeuerFliege has quit (Ping timeout)
14:16:38 --> aleth has joined #instantbird
14:16:38 * ChanServ sets mode +h aleth 
14:18:06 <flo> I will likely be in vacations in August (roughly, 11 to 19 I think)
14:18:17 <flo> so I think 1.2 should really get out of the door before that
14:18:37 <flo> that leaves us 3,5 weeks
14:21:01 <clokep_work> I agree, I think it's doable.
14:23:49 <-- meh has quit (Input/output error)
14:30:16 <clokep_work> My plan is to work on some more blockers whenever I'm actually home...
14:33:02 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 †1809))
14:34:16 <flo> once things are setup correctly, I would like to dedicate an hour or so "early" (ie before going to work) in the morning when nobody is online to do productive Instantbird work
14:34:31 <flo> or at least handle the well overdue reviews...
14:36:37 <aleth> Moving and getting everything set up always takes a lot more time than one thinks...
14:37:05 <flo> I don't have any time estimate, so it's unlikely to take more time :)
14:37:18 <clokep_work> Ah-ha, we're all annoying to flo. ;)
14:37:45 <flo> clokep_work: I wouldn't say "annoying"
14:38:02 <clokep_work> :) I understand though.
14:38:09 <clokep_work> That's part of why I get to work so early.
14:38:20 <clokep_work> I do like 90% of my work in the first 2.5 hours.
14:38:21 <flo> clokep_work: but to really work efficiently, it's better to avoid interruptions or distractions (and it's always tempting to go see what that red tab is about ;))
14:38:51 <flo> clokep_work: even if you arrive early, we are already here to talk to you :-P
14:40:12 --> SM0TVI has joined #instantbird
14:43:09 <clokep_work> flo: Yes, you're very distracting. ;)
14:43:21 <flo> I usually say "hello" :-P
14:44:03 <clokep_work> aleth: We should use "contacts" everywhere is the distinction I believe. ;)
14:45:00 <aleth> clokep_work: Then a lot of strings should be changed in IB :-S Too late for 1.2 now...
14:45:03 <clokep_work> aleth: Also I'd say you can create the new tag and make it editable (like when you create a new file in Windows) instead of having the dialog. :)
14:45:16 <clokep_work> aleth: Yes. I don't know if we have a bug on file for it or not.
14:46:54 --> meh has joined #instantbird
14:47:27 <aleth> clokep_work: That would be the non-modal alternative, but it's not that pretty either in this case imho.
14:48:07 <aleth> Anyway, that whole bug is for 1.3 as it requires string changes.
14:49:03 <aleth> Some sites use flattr for donations, did that ever take off?
14:49:11 <clokep_work> aleth: Yes, I agree. Just discussing some alternatives. :)
14:50:52 <aleth> clokep_work: It's not an alternative that works though if the context menu is not on the buddy list.
14:51:15 <aleth> Unless you put an editbox within a context menu? ;)
14:51:40 <clokep_work> aleth: Why not?
14:51:51 <aleth> Can that be done?
14:52:22 --> jb has joined #instantbird
14:52:29 <clokep_work> Can what be done?
14:52:39 <clokep_work> I don't see why "it's not an alternative" if it's not on the buddy list.
14:52:45 <aleth> Putting an editbox inside a context menu?
14:52:51 <clokep_work> That would be really ugly.
14:52:59 <clokep_work> I don't see why what I suggested couldn't be done though.
14:52:59 <aleth> That's what I thought too.
14:53:45 <aleth> The contact might well be closed. Where do you enter the new tag? Do you pop up the contact list (which might be somewhere completely different on-screen) and give it focus? 
14:53:52 <aleth> s/contact/contact list
14:54:30 <aleth> Even if it's not closed, the focus just jumps completely unpredictably across windows.
14:55:01 <clokep_work> I wouldn't call it unpredictable.
14:55:40 <aleth> I would find it very odd as a user. I might even think nothing happened when I clicked Add Tag
14:57:07 <clokep_work> Depends how it was handled.
14:57:12 <clokep_work> I think it's better than a dialog.
15:00:20 <aleth> I think in that case I'd prefer no "add tag" option in the context menu on tabs
15:01:28 <aleth> unless you have a really good way of handling it ;)
15:02:10 * clokep_work hates UI.
15:02:22 * flo hates menus
15:02:24 <clokep_work> aleth: Any blockers you're interested in looking at? :-D
15:02:42 <aleth> clokep_work: I looked at some, they are still waiting for review...
15:02:51 <clokep_work> Ah?
15:02:51 <flo> yeah, I'm afraid I'm blocking him :(
15:03:04 <clokep_work> Any I can look at?
15:03:13 * clokep_work goes to browse through flo's queue.
15:04:49 <aleth> The problem I see is that most of the remaining bugs without patches are XMPP bugs
15:05:13 <aleth> I don't feel confident to tackle those
15:06:29 <clokep_work> Yeah. I don't either. :-/
15:10:11 * clokep_work wonders if sonny knows some XMPP who would be interested in making Instantbird an awesome XMPP client. :)
15:10:32 <sonny> some XMPP guy?
15:11:29 <sonny> no but I know someone that is interested in XMPP support on TB
15:11:37 <instantbot> clokep@gmail.com requested review from clokep@gmail.com for attachment 1403 on bug 1107.
15:11:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1107 nor, --, ---, aletheia2, ASSI, Contact list section header styling for Linux
15:16:42 <clokep_work> sonny: Well that works too. :)
15:17:36 <sonny> clokep_work: I could merge the IB xmpp implem with mine
15:17:42 <sonny> if you are interested in BOSH/WebSocket support
15:18:03 <sonny> and looking for someone to maintain the implementation
15:18:28 <sonny> but I won't have time to take care of the IB specifics
15:20:15 <clokep_work> I think we're talking about the protocol implementation stuff.
15:20:24 <clokep_work> Which is shared between Thunderbird and Instantbird.
15:21:35 <sonny> well if you are interested in BOSH/WebSockets support, why not
15:21:49 <sonny> otherwise it probably won't makes sense
15:22:19 <clokep_work> I'm not sure, flo would know better.
15:22:44 <sonny> BOSH/WebSockets support is great behind shitty proxies
15:22:47 <clokep_work> Is WebSockets support just using WebSockets instead of raw sockets? Or is there actually a different implementation of the protocol?
15:23:03 <sonny> just using WebSockets instead of raw sockets
15:23:43 <sonny> how do you deal with XML, AFAIK the IB implem doesn't use E4X
15:23:47 <sonny> ?
15:24:24 --> wnayes has joined #instantbird
15:25:02 <clokep_work> No, we don't use E4X.
15:25:08 <clokep_work> Seemed like a bad idea since it's being removed. ;)
15:26:26 <clokep_work> Yeah it's using SAX.
15:26:32 <clokep_work> http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp-xml.jsm#286
15:29:47 <sonny> I use the DOMParser
15:30:10 <sonny> I wish E4X would be alive :(
15:30:13 <clokep_work> wnayes: I left you a message earlier.
15:30:25 <clokep_work> Apparently there's something called JXON that is "similar"?
15:30:41 <sonny> the lack of interested in E4X killed XML on the Web 
15:31:10 <sonny> yeah they are plenty of JSON based format representation for XML
15:31:14 <sonny> but the problem is parsing the XML
15:32:04 <wnayes> clokep_work: Yeah I just read that. The reason I used a string initially was that I was trying different ways to pass the info I needed around though aSubject of the observation notice. Now that I put everything in aData an array would be cleaner. :)
15:32:35 <clokep_work> Ah, OK. :) Yeah my idea wouldn't work via fancier methods like that.
15:41:02 <clokep_work> aleth: "Ideally there would be a method for each account that returns any open conversations matching a userName (that could then normalize the userName appropriately). I can't see us adding such a method for each protocol though?" I'm really thinking we need to add this.
15:41:10 <clokep_work> We've had an issue with similar things in the past I believe.
15:46:39 <aleth> There definitely is a gap in the system here.
15:47:49 <aleth> An alternative way of looking at it would be that there should never be an open non-MUC conversation without a buddy set. But then you'd need some mechanism for getting rid of such temporary buddies...
15:48:14 <aleth> In a way that would be cleaner though.
15:50:12 <aleth> Either way means making messy changes to libpurple though I guess :-/
16:19:57 --> PsyCoil has joined #instantbird
16:23:18 <-- PsyCoil has quit (Quit: Instantbird 1.1)
16:25:42 --> PsyCoil has joined #instantbird
16:32:07 <-- PsyCoil has quit (Quit: Instantbird 1.1)
16:34:01 --> PsyCoil has joined #instantbird
16:35:41 <clokep_work> aleth: Why would it involve changes to libpurple?
16:38:20 <aleth> clokep_work: Hmm, I suppose the "temporary buddies" option could be done without. If you somehow manually add a temporary account buddy before asking for the new conversation...
16:38:42 <aleth> Tricky though when a new conversation is triggered by the account itself (eg an incoming message)
16:39:07 <aleth> I can't see how one would handle that case.
16:45:26 <-- PsyCoil has left #instantbird ()
16:45:53 <-- aleth has quit (Input/output error)
16:50:26 <clokep_work> aleth: I think you mean modifying purplexpcom, which is very different than modfiying libpurple.
16:52:06 --> Kaishi has joined #instantbird
16:54:33 --> FeuerFliege has joined #instantbird
16:55:31 --> FireFly_TB has joined #instantbird
16:56:41 --> PsyCoil has joined #instantbird
17:04:01 --> gerard-majax has joined #instantbird
17:22:28 --> igorko has joined #instantbird
17:26:24 <-- Optimizer has quit (Ping timeout)
17:26:59 --> Optimizer has joined #instantbird
17:28:42 <-- PsyCoil has left #instantbird ()
17:30:01 --> Lalae has joined #instantbird
17:30:15 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:43:41 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 †1809))
17:48:16 --> SM0TVI has joined #instantbird
17:52:45 <-- igorko has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:53:33 <-- meh has quit (Ping timeout)
18:00:00 <-- Kaishi has quit (Quit: Kaishi)
18:02:38 <-- Lalae has left #instantbird ()
18:07:10 --> meh has joined #instantbird
18:08:08 --> Mnyromyr has joined #instantbird
18:09:49 <-- jb has quit (Connection reset by peer)
18:14:07 <-- flo has quit (Input/output error)
18:21:55 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:56:15 <-- FireFly_TB has quit (Quit: FireFly_TB)
19:14:30 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:15:54 <-- wesj has quit (Input/output error)
19:16:07 --> wesj has joined #instantbird
19:31:34 --> sonny has joined #instantbird
19:34:01 <clokep_work> Mic: Btw I haven't had any issues with Session Restore yet.
19:34:08 <clokep_work> I do wish it remember what was "on hold". :)
19:36:54 <-- sonny has quit (Ping timeout)
19:54:43 --> jb has joined #instantbird
20:00:58 <-- Mnyromyr has quit (Ping timeout)
20:03:11 <-- skeledrew has quit (Client exited)
20:03:18 --> Mnyromyr has joined #instantbird
20:03:21 --> skeledrew has joined #instantbird
20:11:08 <-- Mnyromyr has quit (Ping timeout)
20:11:30 <GeekShadow> yo
20:11:45 <clokep_work> Hello.
20:12:38 * GeekShadow is testing IB 1.1 on Win8
20:12:43 <GeekShadow> running good so far
20:12:58 <GeekShadow> also glad to see it supported fine my IRC proxy :)
20:13:30 --> Mnyromyr has joined #instantbird
20:15:06 <clokep_work> Well the IRC code was entirely rewritten for 1.2. ;)
20:15:18 <clokep_work> Were you expecting it to not work with your proxyf or some reason?
20:17:16 <GeekShadow> not really
20:17:21 <GeekShadow> just wondering
20:19:53 <clokep_work> Alright.
20:20:04 <-- Mnyromyr has quit (Ping timeout)
20:25:09 --> Mnyromyr has joined #instantbird
20:28:20 <-- clokep_work has quit (Input/output error)
20:29:26 --> Kaishi has joined #instantbird
20:43:51 <-- jb has quit (Ping timeout)
21:04:34 <-- Optimizer has quit (Ping timeout)
21:25:04 <-- meh has quit (Ping timeout)
21:27:13 --> EionRobb has joined #instantbird
21:35:10 --> aleth has joined #instantbird
21:35:11 * ChanServ sets mode +h aleth 
21:38:35 --> meh has joined #instantbird
21:44:57 <-- Suiseiseki has quit (Ping timeout)
21:49:28 --> Suiseiseki has joined #instantbird
22:00:32 --> clokep has joined #instantbird
22:00:33 * ChanServ sets mode +o clokep 
22:06:59 <aleth> clokep: You can see from what you would have to do for JS-IRC that modifying only purplexpcom would not be enough.
22:07:16 <clokep> aleth: How so?
22:07:32 <clokep> Did you look at the libpurple API to see if it does some of the things we need it to?
22:07:59 <aleth> An incoming DM calls getConversation (irc.js) which creates a new conversation. None of this goes via imAccounts
22:15:15 <aleth> The only potentially relevant thing in libpurple is purple_normalize_nocase(), and I assumed that if it actually was relevant there would be an equivalent in the JS protocol IDL
22:16:31 <aleth> i.e. it's not clear if the "strings" it's for are only account names
22:18:32 <clokep> aleth: Even so you can just have purplexpcom return a function which "works" for all the libpurple stuff (i.e. your fallback of just doing toLowerCase()).
22:20:07 <-- Mnyromyr has quit (Ping timeout)
22:20:19 <aleth> Hmm. So you don't mind the ugliness as long as it's hidden down in purplexpcom? ;)
22:20:47 <clokep> I'd prefer not having the ugliness at all, but if there's a more "correct" way to do it for our JS accounts, I think that''d be good. :)
22:21:46 <aleth> For the JS accounts personally I would add a new method as described and then modify getConversationByNameAndAccount to use it.
22:24:19 <aleth> But I'd be interested to know if you agree that closing the existing conversation (once we have it) and opening a new one is the cleanest way to go
22:24:37 <clokep> I'm not sure how the UX would be of that. :-/
22:24:39 --> sonny has joined #instantbird
22:24:46 <clokep> I'd rather it all of a sudden just has the buddy info. ;)
22:25:17 <aleth> You can't tell the difference from the UI ;)
22:26:41 <aleth> Adding in the buddy retrospectively sounds cleaner, but in practice it's a mess, as I tried to explain
22:27:24 <-- Suiseiseki has quit (Quit: Leaving)
22:28:06 --> Suiseiseki has joined #instantbird
22:28:18 <clokep> You can't tell the difference from the UI? Is the log kept? Does it have to reload it all if it's a huge conversation?
22:29:08 <aleth> The log is kept, but a new log is started. I can't see a way around that however you do it. Nothing is reloaded.
22:29:53 <clokep> (By "log" I mean the previous conversation btw. Not necessarily the "log file" itself.)
22:30:13 <aleth> Sure. The browser doesn't care that a new conversation has started somewhere down in the core.
22:30:20 <aleth> If you really want to test the UI experience just apply the patch and see ;)
22:30:38 <clokep> Oh? Interesting.
22:30:40 <clokep> Hah, yes. I know.
22:30:44 <clokep> I'll do it soon.
22:31:10 <aleth> Some feedback would definitely be appreciated.
22:31:38 <aleth> If you think that patch is hackish, you should have seen the earlier ones trying to add in the buddy ;)
22:34:13 <clokep> Hahahah.
22:34:27 <clokep> OK I'll try it soon, promise. :)
22:34:39 <aleth> (Btw thats why replaceConv is needed - it doesn't reinitialize the convbrowser)
22:46:13 --> Mnyromyr has joined #instantbird
22:50:30 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1745 on bug 1471.
22:50:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1471 nor, --, ---, nobody, NEW, Log viewer content is missing context menu
22:54:52 --> DGMurdockIII has joined #instantbird
23:02:44 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:03:00 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:06:00 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:07:02 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
23:14:43 <-- wesj has quit (Input/output error)
23:15:53 <-- Gizmokid2005 has quit (Ping timeout)
23:16:16 --> flo has joined #instantbird
23:16:16 * ChanServ sets mode +qo flo flo 
23:16:39 --> Gizmokid2005 has joined #instantbird
23:16:55 <flo> aleth: I'm not exactly sure of what you are trying to do as I haven't read all the comments in the bug, but closing a prpl conversation and reopening it is an action that can be seen by the remove contact; so it's something you really really want to avoid
23:17:08 <flo> (and the conv on hold feature was in part to avoid closing prpl conversations too often)
23:17:42 <aleth> flo: seen by which contact?
23:17:51 <flo> s/remove/remote/
23:17:59 <flo> sorry :(
23:18:15 <aleth> ah.
23:18:47 <aleth> Yes, that could be a dealbreaker :(
23:19:25 <flo> it's potentially visible at least on MSN and XMPP
23:19:30 <aleth> When I tested it I couldn't see anything, but that may be protocol dependent
23:19:53 <flo> on JS-XMPP I don't send the conversation closed signal to the server though :-D
23:20:16 <flo> libpurple's MSN prpl used to display a system message when the remove contact closed his window
23:21:01 <flo> that system message has been dropped because it wasn't reliable (sometimes it was just caused by a server issue, or a timeout of a network connection)
23:22:04 <aleth> Maybe you could take a look at that bug once 1.2 is out? (It's not 1.2-wanted and it looks like it might be even more tricky to fix in that case)
23:22:50 <aleth> I didn't expect anything would be visible as the account remains online of course.
23:24:05 <EionRobb> flo: it would also happen if the remote buddy minimised the conversation window (on the official client)
23:28:07 <flo> Good night
23:28:09 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:45:52 <-- aleth has quit (Input/output error)
23:46:56 --> wesj has joined #instantbird