#instantbird log on 06 27 2012

All times are UTC.

00:01:38 <aleth> I'm glad all those reconnection bugs are done... lots of itsy bitsy stuff and no fun new feature...
00:01:38 * wnayes finally got a password through the GTalk importer :D
00:02:05 <aleth> :)
00:02:08 <clokep> wnayes: Congrats. :-D
00:02:11 <clokep> How awful is the algorithm?
00:03:51 <wnayes> There was just a lot of awkward things to do in JS (integer overflows, etc.)
00:04:37 <clokep> Yeah...that stuff is awkward in JS. It's really weakly typed. :(
00:04:41 <clokep> Did you use typed arrays?
00:04:50 <clokep> Bah I can just read the code later.
00:04:53 <clokep> Don't answer my stupid questions. :P
00:05:17 <wnayes> I ended up not, if that would have helped I feel foolish now :)
00:05:41 <clokep> They're for dealing w/ binary data, but I don't think they can do matha t all.
00:06:11 * aleth suspects wnayes wrote a FORTRAN interpreter in JS just to do this ;)
00:07:25 <wnayes> If they can handle arithmetic overflow better than the 'bignumber >>> 0' to get a 32-bit integer trick, I should consider rewriting some parts. :)
00:08:47 * clokep wonders if Mook_as woul dknow.
00:08:57 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:09:10 * Mook_as hasn't used typed arrays
00:09:23 <Mook_as> that seems to be mostly used by people playing with canvas + 3d
00:09:25 * clokep is let down.
00:11:23 <wnayes> There was a very odd part where (I think) the null byte and a byte after it from the encrypted password string in memory were used. I had to hard-code that bit, and I sure hope it works in all cases :/
00:15:19 <aleth> That's odd. Why read beyond the end of the string? Some kind of poor man's random number seed?
00:16:52 <clokep> That's like really poor man's. :P
00:17:21 <aleth> Very :P
00:18:08 <clokep> wnayes: Let me know when the code is up?
00:18:57 <wnayes> clokep: I'll need to clean up the dozens of dumps() and comments first. :)
00:19:16 <clokep> :)
00:19:34 <clokep> wnayes: YOu might want to try w/ different length passwords / unicode / etc first. :)
00:19:50 <instant-buildbot> build #285 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/285
00:20:13 <Mook_as> you can always dump the code to hg first, and clean up later?
00:20:31 <Mook_as> (assuming you'd be rebasing / amending instead of just merging, or something)
00:21:16 <wnayes> Yeah. Is unicode allowed in GTalk passwords? I'm not sure how that would work...
00:21:44 <clokep> I think it is.
00:22:26 <Mook_as> it's got a textbox, right? try pasting it in? :)
00:23:02 <clokep> For added fun, paste non printables. ;)
00:23:28 <wnayes> Mook_as: The client doesn't save the pw key in the registry until a successful login.
00:23:36 <wnayes> Time to change my password :)
00:23:46 <Mook_as> wnayes: I assume there's some password-changing facility
00:24:52 <clokep> wnayes: Do you have a billion random accounts yet like the rest of us? :P
00:25:10 <clokep> Mine are practically disposable haha.
00:25:52 <wnayes> Not yet at least, it was easy to get by with fake setups in Pidgin, mIRC, etc.
00:26:10 <clokep> Yeah I have at least like 6 gmail accounts...
00:26:25 <clokep> And like clokep* on irc.mozilla.org ;)
00:26:32 <Mook_as> just get a random free domain name and get google apps for the domain
00:26:45 * Mook_as has one that stopped resolving... and will never resolve again...
00:31:56 <-- meh has quit (Ping timeout)
00:43:10 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:44:14 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 1698 on bug 1477.
00:44:15 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1709 on bug 1477.
00:44:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1477 enh, --, ---, clokep, ASSI, Authenticate with NickServ
00:44:49 <-- aleth has quit (Input/output error)
01:05:38 <-- Mook_as has quit (Quit: Mook_as)
01:05:47 <-- Bollebib has quit (Quit: Instantbird 1.1)
01:13:36 --> meh has joined #instantbird
01:17:57 <-- Tomek has quit (Quit: Instantbird 1.1)
01:51:12 <instant-buildbot> build #253 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/253
02:03:41 --> Mook has joined #instantbird
02:04:44 <instant-buildbot> build #273 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/273
02:06:03 <-- Kaishi has quit (Quit: Kaishi)
02:09:50 <-- clokep has quit (Ping timeout)
02:13:52 <-- SM0TVI has quit (Ping timeout)
02:17:45 <-- Mook has quit (Ping timeout)
02:21:47 --> Mook has joined #instantbird
02:22:47 --> SM0TVI has joined #instantbird
02:33:32 --> DGMurdockIII has joined #instantbird
03:01:23 <-- Mook has quit (Ping timeout)
03:04:51 --> Mook has joined #instantbird
03:12:41 <instant-buildbot> build #546 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/546
03:39:07 <-- EionRobb has quit (Quit: Leaving.)
03:57:49 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 13.0.1/20120614114901])
04:09:13 --> Tomek has joined #instantbird
04:33:14 --> NmN has joined #instantbird
04:33:17 <-- NmN has quit (Quit: NmN)
05:08:14 <instant-buildbot> build #636 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/636
05:37:39 --> FeuerFliege has joined #instantbird
05:38:55 --> FireFly_TB has joined #instantbird
05:43:18 --> fyd has joined #instantbird
05:43:32 <fyd> hi
05:43:40 <fyd> i just installed instantbird
05:43:55 <fyd> i have the latest thunderbird, i need to integrate both
05:44:14 <fyd> use instantbird in my thunderbird interface. can any one help me with that
05:44:19 <fyd> can't find the option anywhere
05:49:38 <-- fyd has quit (Quit: http://www.mibbit.com ajax IRC Client)
06:04:42 <-- Tomek has quit (Quit: Instantbird 1.1)
06:06:48 <instant-buildbot> build #532 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/532
07:06:57 <-- Mook has quit (Quit: Mook)
07:11:17 --> barlas has joined #instantbird
07:12:57 <barlas> Hey
07:15:22 <barlas> Most of the 'We Recommend' addons don't work with current stable realease.
07:16:46 --> gerard-majax has joined #instantbird
07:17:43 <barlas> On Google Talk, I renamed display name of some of my contacts, and IIRC, the changes also show up on other clients I use (Kopete and kde-telepathy mainly), but they don't show up in Instantbird.
07:22:35 --> sonny has joined #instantbird
07:31:14 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
07:31:17 --> sonny has joined #instantbird
07:40:06 --> Lalae has joined #instantbird
07:40:17 <-- Lalae has left #instantbird ()
07:57:35 --> FireFly_TC has joined #instantbird
07:58:24 <-- FireFly_TC has quit (Quit: FireFly_TC)
08:00:32 --> Optimizer has joined #instantbird
08:02:39 --> jb has joined #instantbird
08:05:55 --> flo has joined #instantbird
08:05:56 * ChanServ sets mode +qo flo flo 
08:05:58 <-- jb has quit (Connection reset by peer)
08:06:00 --> jb has joined #instantbird
08:08:42 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
08:08:49 --> Optimizer has joined #instantbird
08:35:00 --> aleth has joined #instantbird
08:35:00 * ChanServ sets mode +h aleth 
08:35:07 <-- aleth has quit (Quit: aleth)
08:35:20 --> aleth has joined #instantbird
08:35:20 * ChanServ sets mode +h aleth 
08:49:31 <instantbot> New Core - IRC bug 1552 filed by aletheia2@fastmail.fm.
08:49:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1552 min, --, ---, nobody, NEW, Handle 329: RPL_CREATIONTIME
09:01:04 <-- jb has quit (Connection reset by peer)
09:01:07 --> jb has joined #instantbird
09:02:33 <barlas> Hi aleth
09:02:43 <aleth> hi barlas
09:03:05 <barlas> aleth: You are a dev, right?
09:03:24 <aleth> you're right about the recommended add-ons, thats bug 1070
09:03:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1070 nor, --, ---, nobody, NEW, Ensure recommended add-ons are actually suitable for the latest version
09:03:37 <aleth> yes
09:03:42 <barlas> aleth: You were here? Didn't you join after that?
09:03:47 <barlas> Or is this channel logged?
09:03:49 <aleth> We have logs :D
09:03:54 <barlas> Ah
09:03:56 <aleth> (link in the topic)
09:04:00 <barlas> I guess instantbot is to blame for that
09:04:15 <barlas> Heh, missed that
09:06:06 <barlas> What about that contact's display names
09:06:17 <-- Optimizer has quit (Ping timeout)
09:06:32 <barlas> Second thing that I mentioned.
09:07:27 <aleth> I have not come across that (but I don't use gtalk). flo, is this a known bug?
09:08:26 <aleth> Generally, if you find something you think is a bug, just file it. We can always dupe it if necessary.
09:08:56 <barlas> I agree with your comment on bug 1070, my thoughts were if the recommended exentsions - which are supposed to be the best one - are not working, how would any other will work.
09:08:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1070 nor, --, ---, nobody, NEW, Ensure recommended add-ons are actually suitable for the latest version
09:09:30 <aleth> barlas: Yes, it does not make a good impression :( 
09:09:34 <barlas> I think at the very least, the 'recommended' tag should be romoved from those extensions that are not working.
09:09:36 --> Optimizer has joined #instantbird
09:13:32 <-- FeuerFliege has quit (Ping timeout)
09:13:32 <-- FireFly_TB has quit (Ping timeout)
09:18:28 --> Lalae has joined #instantbird
09:19:24 <Lalae> hello guys! sorry to bother again! I was wondering if it's normal that IB doesn't notify me when someone adds me on msn
09:19:49 --> mmkmou has joined #instantbird
09:19:57 <Lalae> (I looked at the bug list but I didn't find anything...could be I didn't look well :P)
09:20:34 <aleth> I can't see a bug open for it either... please file it?
09:23:35 <Lalae> sure
09:24:33 <flo> aleth, barlas: never heard of that Gtalk display name issue. Note that the Gtalk implementation has completely changed between 1.1 and the current nightlies, so if you are on 1.1, you may want to test a nightly before filing a bug :).
09:25:18 <aleth> Oh, I forgot he was on 1.1. Should have suggested that.
09:40:39 * flo wonders if aleth has looked at the new patch in bug 1477
09:40:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1477 enh, --, ---, clokep, ASSI, Authenticate with NickServ
09:41:28 <aleth> flo: not yet
09:42:16 <flo> I'm quite confused about it :-S
09:43:07 <instantbot> New Core - General bug 1553 filed by eleonora.pastori@gmail.com.
09:43:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1553 nor, --, ---, nobody, UNCO, Instantbird doesn't notify you when a new contact adds you on msn
09:43:33 <barlas> Actually I updated to nightly
09:44:43 <flo> ooooh, Australis on Mac (Thunderbird)
09:46:39 * flo enjoys the new Escape shortcut :)
09:50:32 <barlas> I am not 100% sure if other clients show me names I have set or the default ones, will file a bug after checking that.
09:51:11 <flo> barlas: bonus point if you can show us the XMPP stanza containing the display names that aren't used ;)
09:51:19 <flo> by "show us" I mean "paste in the bug"
09:51:34 <barlas> Ok
09:51:59 <flo> if you set the loglevel to 2, all XMPP stanza will be visible in the error console
09:52:51 <barlas> flo: Is there any way I can do that in nightly or will I have to compile it myself?
09:53:26 <flo> if that = "set the loglevel to 2", you can do it from the advanced configuration editor, from the last pane of the preference dialog
09:53:47 * flo thinks we should teach instantbot to tell people about loglevel
09:57:55 <barlas> Ok, got it.
09:58:32 <barlas> On signing in, when xmpp gets the roster, it shows the names I have set, here is an example:
09:58:44 <flo> in the bug
09:58:48 <barlas> ok, it doesn't let me copy :(
09:58:48 <flo> or pastebin, plase :)
09:58:50 <flo> *please
09:59:05 <barlas> I was just going to mentiond the tag
09:59:13 <barlas> I would file a bug then.
09:59:18 <flo> you should be able to copy a message from the error console
09:59:24 <flo> from the context menu
09:59:34 <barlas> Maybe a complete message, but no way to select part of it.
10:00:37 <flo> we would want the complete stanza
10:02:27 --> clokep has joined #instantbird
10:02:27 * ChanServ sets mode +o clokep 
10:03:27 <barlas> It would be for Core or UI?
10:04:05 <barlas> Ok, Core.
10:04:12 <barlas> There is no nightly  version in Version.
10:04:38 <flo> Core, XMPP
10:04:48 <flo> barlas: Trunk for the version
10:08:18 <barlas> ok
10:24:40 <barlas> There is a small chance I might be wrong about other clients showing the names I've set on GTalk, but I can't test it right now, should I post it anyway for you to look at or wait until I can test it?
10:25:07 <clokep> I was surprised that my own name wasn't downloaded when I added myself to GTalk the other day on my work machine. ;)
10:26:05 <clokep> Which part of the nickserv bug is confusing flo?
10:28:36 <barlas> http://pastebin.ca/2164994
10:29:40 <flo> clokep: It's the patch, not the bug that confuses me
10:30:06 <flo> clokep: I don't understand most of the return false I see. I assumed "return false" means "display the message normally", is this right?
10:30:17 <clokep> Yes.
10:30:49 <flo> so why isn't the queue of delayed messages always emptied before returning false?
10:33:00 <clokep> What?
10:33:48 <clokep> We only empty it when we've successfully authenticatec (we drop the queue on the floor and don't care about it) or if we haven't heard that we've successfully authenticated, then we push all the messages back through the system.
10:33:57 <clokep> And then remove them all after they've gone through.
10:34:06 <clokep> Or maybe we don't remove them all...but w eshould.
10:35:54 <flo> clokep: so if nickserv tells you your password is wrong, why don't we empty the queue to display the messages immediately?
10:35:59 <clokep> flo: There should be a |delete this.nickservMessageQueue;| after the every call on it.
10:36:36 <clokep> flo: Because that seemed to complicate the code w/ little gain.
10:37:07 <flo> I guess I just don't understand the simplified code then :-D
10:37:31 <flo> oh, btw, what's "this" in this context? :)
10:37:52 <clokep> For message handlers? It's the account.
10:38:53 <flo> ok
10:39:14 <flo> so when you have the "password incorrect" message and you return false? Won't that display the "password incorrect" message to the user before the messages that are in the queue?
10:39:37 <clokep> The message gets added into the queue before we check if the message was received though.
10:39:45 <clokep> Line 116 of the file.
10:40:45 <clokep> Those lines can be removed, I think.
10:41:32 <flo> didNotReceivePassCommand is still a confusing name
10:42:28 <flo> so lines 121-131 are just useless?
10:42:45 <clokep> They are now, yes.
10:42:55 <flo> ok
10:43:03 <flo> I guess that's why I didn't understand the patch :)
10:43:14 <clokep> OK.
10:43:42 <clokep> If you really want to have it so we immediately display message upon receiving a fail auth we can do that.
10:44:04 <flo> I don't really mind the 1s delay
10:45:09 <flo> shouldn't we avoid delaying the "This nickname is registered. Please choose a different nickname, or identify" prompt if we haven't sent a password through PASS?
10:45:22 <flo> (if the user hasn't filled the password field for the account
10:45:24 <flo> )
10:47:49 <clokep> So you mean just a If (!this.password) return false at the top?
10:48:04 <flo> I'm just asking/thinking out loud
10:48:09 <flo> I'm not sure we have to care about this
10:48:14 <clokep> That probably makes sense, yes.
10:48:15 <flo> a 1s delay in the prompt doesn't seem terrible
10:48:23 <clokep> Right.
10:48:44 <flo> if we care about that case, we probably also care about stopping the timer if we receive a "password incorrect" message
10:48:47 <clokep> I'd rather keep the 1s delay, someone might have another means of authenticating (an extension or something).
10:48:56 <flo> so I guess, it's up to you :)
10:49:26 <flo> ah, that (the possible authenticating add-on) makes sense :)
10:51:55 <clokep> :)
10:52:10 <clokep> I'll upload a new patch later.
10:58:18 <clokep> Lalae: So nightlies are available in the link in the topic message. http://nightly.instantbird.im
10:58:39 <Lalae> thanks
11:03:00 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:11:21 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:11:24 --> aleth has joined #instantbird
11:11:24 * ChanServ sets mode +h aleth 
11:38:16 --> FireFly_TB has joined #instantbird
11:38:45 --> FeuerFliege has joined #instantbird
11:43:30 --> clokep_work has joined #instantbird
11:43:30 * ChanServ sets mode +o clokep_work 
11:47:06 <-- Optimizer has quit (Ping timeout)
11:50:12 --> Optimizer has joined #instantbird
11:52:20 <Optimizer> sometimes when I enter something to a channel, instantbird tells me that you have been disconnected
11:52:24 <Optimizer> and then i reconnects
11:52:38 <Optimizer> the thing that I entered, is displayed in Instant bird conversation window
11:52:42 <Optimizer> as if it wen to the server
11:52:45 <Optimizer> but it did not
11:53:00 <Optimizer> So , in such situations, IB should resend the message
11:54:45 <clokep_work> Optimizer: Can you please provide a protocol when talking about things like this.
11:54:57 <Optimizer> IRC
11:55:06 <Optimizer> i only use IB for IRC
11:55:28 <clokep_work> How am I supposed to know that? :P
11:55:39 <Optimizer> was just telling :P
11:56:49 <-- Lalae has quit (Ping timeout)
11:58:10 <clokep_work> I'm not sure if I agree that Instantbird should resend it though. :-/
11:58:57 <aleth> Optimizer: You will need to provide better STR. If you are disconnected when you send, you are prevented from sending and get a system message instead.
11:59:24 <aleth> So what you describe sounds like the disconnect happened after the send
11:59:31 <Optimizer> no
11:59:33 <Optimizer> its more like
11:59:42 <Optimizer> IB got to know of the disconnect while sending
11:59:55 <Optimizer> before that it thought that its connected
12:00:09 <aleth> So... is there anything in the error console?
12:00:37 <aleth> This is a kind of unusual situation as far as I know.
12:01:02 <Optimizer> it happens to me many times
12:01:07 <Optimizer> like say a heavy download is in progress
12:01:16 <Optimizer> i am connected right now
12:01:21 <Optimizer> and suddenly loose connection
12:01:33 <Optimizer> before IB can tell me that I am disconnectedm I type something
12:01:43 <Optimizer> and press enter, so IB tells me then
12:01:58 <Optimizer> IMO, in such situation, the message should be resent
12:02:16 <aleth> So the message appears in the channel, but hasnt been sent?
12:02:22 <clokep_work> Do you have a not-so-great connection?
12:02:32 <Optimizer> yup
12:02:33 <clokep_work> Sounds like your ping timing out (which of course we don't know about until we try to send data).
12:02:34 <aleth> Please take a look in the error console next time.
12:02:36 <Optimizer> yes
12:02:41 <Optimizer> 1mbps only
12:02:42 <Optimizer> :(
12:02:57 <Optimizer> yes I know that ping timeouts
12:02:58 <clokep_work> That's not /that/ bad. ;) But if you're downloading a lot I guess you could have network issues...
12:03:01 <Optimizer> my main request is
12:03:10 <Optimizer> the data should be automatically resent
12:04:49 <flo> 1mbps is more than enough to use IRC + download whatever you want
12:05:07 <aleth> The bandwidth shouldn't be causing this.
12:05:22 <Optimizer> i did not say thats the cause :P
12:05:31 <flo> if IRC data isn't received and things are getting lost when there's another connection sucking all the bandwidth, your router is messed up.
12:06:04 <Optimizer> hmm ?
12:08:41 <-- Optimizer has quit (Ping timeout)
12:10:09 --> Optimizer has joined #instantbird
12:10:17 <Optimizer> 5:41:00 PM - Optimizer: I don't think that its a problem at all
12:10:17 <Optimizer> 5:41:00 PM - Your account is disconnected.
12:10:18 <Optimizer> 5:41:04 PM - Your account has been reconnected.
12:10:21 <Optimizer> see, again
12:10:41 <Optimizer> Timestamp: 6/27/2012 5:41:00 PM
12:10:41 <Optimizer> Error: Connection reset.
12:10:41 <Optimizer> Source File: jar:file:///C:/Program%20Files%20(x86)/Instantbird/omni.ja!/components/irc.js
12:10:41 <Optimizer> Line: 502
12:10:41 <Optimizer> Source Code:
12:10:41 <Optimizer> irc
12:10:46 <Optimizer> error console has this error
12:11:22 <Optimizer> I think that this is not a bug, what the bug is that the data is not sent, but is visible in the conversation window, as if it is sent
12:12:44 <flo> Optimizer: and you don't have a system message saying it couldn't be sent?
12:12:51 <Optimizer> no
12:13:07 <Optimizer> did you receive "I don't think that its a problem at all" twice ?
12:13:21 <flo> Optimizer: look at instantbot's logs if you want to know what we received
12:13:47 <Optimizer> yes, i am, so you only got once
12:13:53 <Optimizer> while my window is showing twice
12:14:32 <flo> clokep_work: do we have any way to know that the socket was reported as 'reset' before the data was actually sent?
12:15:43 <flo> I hope we can somehow get some progress information about what was in the outgoing stream at the time the connection was reset :-S
12:15:57 <clokep_work> flo: It's possible we might be able to, but nothing checks that.
12:16:06 <clokep_work> We just blindly show the outgoing messages and hope they got sent.
12:16:23 <clokep_work> (Which is fairly standard for IRC IIRC.)
12:16:42 <Optimizer> :D
12:17:11 <clokep_work> It would be nice if the server notified us (i.e. echoed our messages back to us), but that's not how IRC works...
12:17:22 <Optimizer> well, I think you should check if the thing did not get sent and resend it upon connecting again, or rather tell that message was not sent
12:17:24 <flo> yeah, I don't mind the other IRC clients being similarly sucky or not on this point; I'm interested in what we can do :)
12:17:32 <Optimizer> resending automatically would be the choice I prefer
12:18:09 <clokep_work> I think I'd prefer just notifying (the reason being, other stuff might have happened while you were disconnected...i.e. what happens if you disconnect 6 hours later, the message would be out of context, etc.)
12:18:15 <clokep_work> But I could possibly be convinced otherwise.
12:18:32 <flo> I don't think we want to resend
12:18:32 <clokep_work> Optimizer: File a bug, we can at least hopefully check if the socket is open before we blindly show it in the message window.
12:18:46 <flo> but showing that the message wasn't sent would be quite nice
12:19:19 <Optimizer> clokep_work: how about if you reconnect instantly, then automatically resend
12:19:24 <Optimizer> and not otherwise
12:19:35 <clokep_work> Define "instantly". ;)
12:19:45 <Optimizer> 5 seconds ?
12:20:02 <Optimizer> see the three lines I pasted, I was reconnected in 1 second
12:20:17 <clokep_work> Maybe (although I mostly agree with flo)...I think putting the text back in the textbox could be OK.
12:20:19 <Optimizer> sry 5
12:20:46 <Optimizer> yes that would also do
12:20:52 <Optimizer> mibbit also does that
12:22:41 <flo> I don't see why you would be in a similar situation with mibbit
12:22:51 <flo> you are communicating with the mibbit server, not the IRC server
12:23:04 <Optimizer> with mibbit if the connection is lost
12:23:06 <flo> so the mibbit server can cache messages that arrived while you were briefly disconnected from mibbit
12:23:11 <Optimizer> the typed thing remains in the textbox
12:23:44 <aleth> Quite apart from the IB behaviour, it is strange that this is frequently happening to you, considering your bandwidth
12:23:59 <Optimizer> true
12:24:12 <flo> suckiness of the connection isn't necessarily related to bandwidth
12:24:14 <Optimizer> and the very last time, I was doing nothing with my bandwidth
12:24:42 * flo remembers fixing lots of JS-proto bugs happening with sucky connections a few weeks or months ago ;)
12:25:02 <aleth> Sure, but he mentioned large downloads...
12:25:47 <clokep_work> flo: Are we string frozen?
12:25:59 <flo> clokep_work: we haven't announced anything
12:26:00 <Optimizer> but this time nothing was being downloaded
12:26:26 <clokep_work> flo: Right, but are we expecting to change strings anymore? :-D
12:26:29 <flo> clokep_work: I think I more or less wanted us to try today's nightly a bit to decide if we need to backout any of the changes pushed yesterday
12:26:40 <clokep_work> Fair enough!
12:27:02 <flo> so, I don't expect to land new strings at this point, but it's still 'possible'.
12:27:22 <aleth> Optimizer: Can you file a bug about this? Maybe it's possible to improve things if the socket can report back more than it does atm
12:27:38 * clokep_work is happy his review queue is empty!
12:27:40 <Optimizer> ok
12:28:07 <flo> clokep_work: mine isn't empty ;)
12:28:21 <clokep_work> flo: I try to keep yours as full as possible. ;)
12:28:33 <flo> clokep_work: that's so nice of you ;)
12:29:34 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1686 on bug 1296.
12:29:35 <instantbot> clokep@gmail.com cancelled feedback?(aletheia2@fastmai l.fm) for attachment 1686 on bug 1296.
12:29:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1296 enh, --, 1.2, clokep, RESO FIXED, Unhandled IRC whois response messages 307 671 317
12:29:57 <Optimizer> if you want, I can review some of the patches in flo's review queue
12:30:06 <Optimizer> r+ to everyone!!
12:30:09 <Optimizer> :P
12:30:24 <flo> Optimizer: I'm happy letting you r- the patches that I know won't fly
12:30:34 <flo> provided you find meaningful reasons for the r-s ;)
12:31:04 <Optimizer> not enough Optimized ?
12:31:09 <Optimizer> hows that for a reason :P
12:32:29 <flo> bah, there's only bug 1338 where I know for sure it will be r-
12:32:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1338 nor, --, ---, nobody, NEW, Connect button is disabled after an account spends more than half a second in the disconnecting stat
12:32:52 <flo> aleth: and the reason is that I really don't see why you need 2 timers
12:33:07 <flo> aleth: but I haven't r-'ed in the bug because it's not clear in my mind yet what needs t be done
12:33:13 <flo> that code is quite confusing :(
12:33:37 <aleth> flo: It is... I may have missed something as I don't know it well.
12:33:41 <clokep_work> I only have one bug which actually needs a review I think...
12:33:48 <aleth> But there aren't two timers, so I am confused too ;)
12:33:57 <flo> aleth: the point of the disable timer is that we want to prevent double clicks
12:34:06 <aleth> Sure.
12:34:26 <flo> so if the disconnect buttons stays visible and disabled for more than half a second, there's no reason to keep the "connect" button disabled for half a second after we have finished disconnecting
12:34:37 <flo> clokep_work: is this the SIPE one?
12:35:20 <clokep_work> flo: No, the Twitter one.
12:35:27 <aleth> flo: So what you don't like is that the "connect" button reenabling is done via the same mechanism? 
12:35:29 <flo> ah :)
12:35:43 <clokep_work> The SIPE one needs to be updated again most likely. ;)
12:35:52 <flo> aleth: I don't understand why you call setTimeout from the timer callback
12:36:33 <aleth> "When disconnecting, we want the Connect button to be enabled only after a delay AND when the account has actually
12:36:34 <aleth> disconnected"
12:36:46 <aleth> The bug arises because IRC disconnects are not always fast enough.
12:37:09 <aleth> So sometimes we have to wait some more.
12:37:28 <flo> no, we don't have to "wait
12:37:28 <flo> "
12:38:11 <flo> I think I have an idea for a simpler patch
12:38:24 <aleth> I am confused now ;)
12:38:38 <flo> I've got Tb stuff to do though ;)
12:38:54 <aleth> The "real" solution is the account.xml rewrite but that's not going to happen before 1.2
12:42:23 <flo> yeah...
12:42:32 <flo> I hope I'll get to it soon, and request review from you ;)
12:44:27 <flo> I basically have to finish today all the Tb patches I hope to land before going in vacations
12:44:36 <instantbot> New Core - IRC bug 1554 filed by scrapmachines@gmail.com.
12:44:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1554 nor, --, ---, nobody, UNCO, If a message is not sent to the IRC server, it should remain in the text box
12:45:09 <aleth> flo: ouch... sounds like the vacations will be for catching up on sleep ;)
12:45:37 <clokep_work> Sounds like vacation would be a good time for people to fill up review queues. ;)
12:46:24 <flo> bug 1546 sounds like something we should resolve before announcing the string freeze
12:46:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1546 nor, --, ---, nobody, NEW, license.html not distributed with Instantbird
12:46:50 <flo> errr
12:47:01 <flo> I meant bug 1536
12:47:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1536 nor, --, ---, nobody, NEW, Add an exception in filter.py for the topProtocol.prpl-*.description strings
12:47:16 <-- FireFly_TB has quit (Ping timeout)
12:47:16 <-- FeuerFliege has quit (Ping timeout)
12:47:38 <flo> bah, just when I wanted to ping him :-/
12:48:56 <clokep_work> :(
12:49:02 <clokep_work> Yes, that should be. I forgot about that bug.
12:50:06 <barlas> flo: You work on Thunderbird too?
12:50:29 <flo> barlas: yes
12:52:39 <barlas> Nice
12:53:13 <clokep_work> Optimizer: I don't think we would just silently drop the message, we'd probably add a system message "The following could not be sent: <blah blah>."
12:53:42 <Optimizer> lets see what u guys do
12:58:32 <flo> clokep_work: btw, when using sort by status, I've noticed that it's surprising that the selected contact isn't resorted when the selection is visible (the selection is visible only when the richlistbox is focused)
12:58:54 <flo> clokep_work: I'm not sure how easy it would be to tweak this
12:59:09 <clokep_work> flo: Interesting. Is the issue that it's selected or that it doesn't move then? :)
12:59:30 <clokep_work> I mean that the selection isn't shown or that it's not restorted.
12:59:34 <flo> clokep_work: well, we explicitly prevent reordering of selected contacts, because we assume the user may be interacting with it
12:59:46 <flo> but if the richlistbox isn't focused, we should assume the contact isn't selected
13:00:00 <barlas> richlistbox?
13:00:02 <clokep_work> Mmhmm.
13:00:24 <clokep_work> barlas: A XUL element that contains a list where each item can hold any type of element.
13:00:41 <clokep_work> flo: Right, so is this actually a bug in the standard sorting too...just that it's not really visible?
13:00:53 <barlas> When talking about Instantbird, which one would that be? The contact list?
13:00:54 <flo> http://lxr.instantbird.org/instantbird/source/instantbird/content/group.xml#259
13:01:08 <flo> clokep_work: seems we just need to add an additional check on line 259
13:01:28 <clokep_work> barlas: The contact list, the participate list, etc.
13:01:32 <clokep_work> We're currently talking about the contact list.
13:01:43 <clokep_work> flo: I'll file a bug.
13:02:13 <flo> probably just want "(contactElt.hasAttribute("selected") && this.parentNode.focused)"
13:02:18 <flo> if that works :)
13:02:21 <instantbot> clokep@gmail.com cancelled review? for attachment 1088 on bug 976.
13:02:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=976 enh, --, ---, clokep, ASSI, Support Microsoft Office Communicator protocol (SIPE)
13:02:31 <instantbot> clokep@gmail.com cancelled review? for attachment 1089 on bug 976.
13:02:40 <flo> ooh, my review queue is getting shorter :)
13:03:01 <clokep_work> I just figured we didn't need three patches all w/ r? when they're really one patch. ;)
13:03:08 <clokep_work> But I shold probably update the SIPE code anyway.
13:04:07 <-- sonny has quit (Ping timeout)
13:06:17 <instantbot> New Instantbird (UI) bug 1555 filed by clokep@gmail.com.
13:06:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1555 min, --, ---, nobody, NEW, Only prevent reordering of contacts when the contact list is focused
13:08:54 <flo> clokep_work: thanks :)
13:09:45 <clokep_work> flo: Thanks for testing my extension! :)
13:09:58 <flo> I didn't mean to imply it was the extension's fault
13:10:01 <clokep_work> I'm actually using it at work now cause I really don't care about people if they aren't available.
13:10:27 <flo> :)
13:10:46 <clokep_work> It's fine, I just wasn't sure when you first said it if it was from the extension or not. :)
13:11:36 <flo> I just noticed it because I have the add-on installed, because the selected contact becoming away/idle is much more likely than the selected contact changing its display name
13:11:59 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
13:13:28 --> Tomek has joined #instantbird
13:15:37 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1114 on bug 976.
13:15:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=976 enh, --, ---, clokep, ASSI, Support Microsoft Office Communicator protocol (SIPE)
13:15:42 <clokep_work> Right, of course. :)
13:18:01 <clokep_work> flo: Bonjour taught me a bit more about make, pkg-config, etc. so I should be able to make that patch a lot better.
13:18:21 --> FireFly_TB has joined #instantbird
13:18:56 --> FeuerFliege has joined #instantbird
13:19:24 <clokep_work> flo: Do we use "messenger." prefs for Instantbird only? Or are they meant for chat?
13:19:52 <flo> I don't have a good answer to that question :)
13:20:09 <flo> but I wouldn't r- a chat/ patch because it contains messenger.* prefs
13:20:15 <flo> (if that answers your question)
13:20:51 <clokep_work> flo: No, my question is whether https://bugzilla.mozilla.org/show_bug.cgi?id=755718 should use the same prefs as Instantbird.
13:21:30 <flo> it shouldn't
13:21:37 <flo> and it's not in chat/
13:21:49 <clokep_work> OK.
13:21:54 <clokep_work> I know it's not in chat.
13:22:01 <flo> and it's really about playing the biff sound
13:22:09 <clokep_work> Just feel like there's some duplicated effort going on there.
13:22:10 <clokep_work> Alright.
13:22:22 <flo> biff = check for new emails (in Tb's context)
13:22:54 <flo> clokep_work: I just feel that this sucks, because users would probably want to have different sounds for emails and IMs...
13:23:03 <flo> but I can't offer any better without new strings
13:23:49 <clokep_work> Right. :(
13:24:07 <clokep_work> So I have sounds on at work (since I shut off the taskbar flashing and I listen to music usually.)
13:24:14 <clokep_work> And I have to say...the new IM sound is pretty awful. :(
13:24:28 <clokep_work> Reminds me of the xkcd segfault comic. ;)
13:24:33 <flo> (and don't get me started on what I think of doing all the polish work several weeks after the string freeze ;))
13:24:59 <flo> "the new IM sound is pretty awful" the ib or tb one?
13:25:04 <clokep_work> Ib.
13:25:14 <flo> it's the one from Pidgin, so yes, it's awful :-P
13:25:39 <clokep_work> The unfortunate thing is that you're using all your time in the aurora period to get fixes in there and comm-central trunk isn't really being upgraded...so that'll go to aurora and then you'll be like a period behind...
13:25:43 * flo feels like ecaron would have met much less resistance if he tried to change the sounds, rather than the icons
13:26:03 <clokep_work> :)
13:26:06 <clokep_work> Yes.
13:26:12 <flo> clokep_work: yeah, so the next strings can't be there before Tb 17...
13:26:52 <clokep_work> Right. :(
13:27:02 * clokep_work wonders how far we've drifted Instantbird from c-c again...
13:27:18 <flo> far enough that I'll need another update before Tb 15 is released
13:28:21 <clokep_work> Right. And has string changes I'm sure...
13:28:56 <flo> we won't take the string changing patches...
13:29:09 <flo> I wonder how hard we should push to have ib in comm-central
13:31:12 <clokep_work> flo: Hard soon I think...
13:31:29 <flo> do we need to make libpurple an add-on first?
13:34:54 <flo> ah, Irving keeps being unhappy at my notification patches :-|
13:37:37 <clokep_work> flo: Do we necessarily? Is it an issue of putting GPL code in that repo or?
13:37:46 <flo> yes
13:37:51 <clokep_work> OK.
13:38:07 <flo> I think the commit policy of {mozilla,comm}-central requires that everything needs to be MPL2 compatible
13:38:15 <clokep_work> It's unfortunate that our colors are very similar. :P
13:38:27 <flo> exceptions are possible, but need to be approved by licensing@mozilla.org (=Gerv), and unlikely to be obtained
13:38:48 <clokep_work> Makes sense. :)
13:39:04 <clokep_work> So we would need to put that code i na separate repo and make the build stuff work OK.
13:39:13 <flo> yes
13:39:17 <flo> but that should be possible
13:39:24 <flo> it's done for venkman and inspector already, right? :)
13:40:01 <clokep_work> Supposedly. ;)
13:40:32 <Optimizer> so u guys can't divert from MPL ?
13:40:33 <Optimizer> :D
13:40:51 * flo wonders what's funny about it
13:41:27 * clokep_work wonders why we would want to.
13:42:59 <Optimizer> you can't make exceptions
13:43:02 <Optimizer> like flo said
13:43:44 * flo things Optimizer should re-read the above conversation
13:43:47 <flo> *thinks
13:51:32 <clokep_work> Optimizer: The problem is that GPL can't make exceptions. :P
13:52:33 <-- FireFly_TB has quit (Ping timeout)
13:52:33 <-- FeuerFliege has quit (Ping timeout)
13:59:24 <-- Optimizer has quit (Ping timeout)
14:01:38 --> Optimizer has joined #instantbird
14:03:17 --> FireFly_TB has joined #instantbird
14:03:51 --> FeuerFliege has joined #instantbird
14:04:16 <-- Optimizer has quit (Ping timeout)
14:08:23 --> Optimizer has joined #instantbird
14:08:42 <clokep_work> "updated twitter logos; Just a graphic change, so I don't think this needs code-review." Isn't that not fully true as it touches chat/ which affects Instantbird? :-S
14:09:19 <clokep_work> (Or more that it touches chat and bwinton isn't a peer of chat ;))
14:10:04 <flo> yeah...
14:10:05 <-- meh has quit (Ping timeout)
14:10:15 <flo> although he asked me first on IRC yesterday
14:10:24 <clokep_work> True.
14:10:31 <clokep_work> I can not know that. ;)
14:10:50 <flo> so what do you want to do?
14:11:20 <flo> (in this specific case we could celebrate that we are getting this for free though ;))
14:12:27 <clokep_work> Yeah, I know. I was thinking of just putting an r+ on it and saying "Even though there's no code changes this needs approval from a chat/ peer as chat/ is used in other application as well."?
14:12:43 <clokep_work> s/application/applications/
14:14:17 <flo> maybe the word "approval" is a bit strong, but feel free to go ahead :)
14:16:06 <flo> FeuerFliege: did you mean to attach a patch to bug 1536?
14:16:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1536 nor, --, ---, nobody, NEW, Add an exception in filter.py for the topProtocol.prpl-*.description strings
14:17:46 <clokep_work> Or we can just shut up and be happy we're getting it for free, yes. ;)
14:18:06 <flo> or just add a "thanks"
14:19:44 --> mmkmou has joined #instantbird
14:25:44 <flo> maybe "rubber stamp" instead of approval? :)
14:26:14 <instantbot> bugi@media.fjmail.de requested review from florian@instantbird .org for attachment 1710 on bug 1536.
14:26:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1536 nor, --, ---, nobody, NEW, Add an exception in filter.py for the topProtocol.prpl-*.description strings
14:26:53 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
14:27:25 <instantbot> florian@instantbird.org granted review for attachment 1710 on bug 1536.
14:28:30 <clokep_work> flo: That makes sense. Is that a flag?
14:28:43 <flo> clokep_work: not really
14:28:51 --> aleth has joined #instantbird
14:28:51 * ChanServ sets mode +h aleth 
14:29:06 <flo> it's just the word people usually use when taking about a review that needs a flag, but not a really code review
14:29:34 --> meh has joined #instantbird
14:31:01 <flo> FeuerFliege: is bugi@media.fjmail.de the address I should use for the commit?
14:31:18 <flo> FeuerFliege: last time I used do.not.deliver@gmx.de
14:31:52 <-- aleth has quit (Input/output error)
14:31:59 <FeuerFliege> flo: you can use bugi@media.fjmail.de.
14:32:13 <flo> ok
14:33:22 <FeuerFliege> I got the domain fjmail.de recently and reorganized my email addresses.
14:34:05 <instantbot> florian@instantbird.org set the Resolution field on bug 1536 to FIXED.
14:34:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1536 nor, --, 1.2, bugi, RESO FIXED, Add an exception in filter.py for the topProtocol.prpl-*.description strings
14:36:18 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/683576cf6f00 - Florian Janßen - Bug 1536 - Add an exception in filter.py for the topProtocol.prpl-*.description strings, r=fqueze.
14:38:41 --> zen_monkey has joined #instantbird
14:39:23 <clokep_work> Yay for closing blockers? :-D
14:40:29 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
14:43:04 --> mmkmou has joined #instantbird
14:43:05 <FeuerFliege> clokep_work: I have a few questions about bug 1108: 
14:43:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
14:43:22 <clokep_work> FeuerFliege: First of all. I need to apologize. I got really confused during part of that bug.
14:43:36 <clokep_work> You definitely don't need a way to decode the folders afterward, it's only one way. :)
14:43:43 <clokep_work> Sorry about that. :-[
14:43:51 <FeuerFliege> clokep_work: :)
14:44:14 <FeuerFliege>   you said ‚seems a bit excessive to rename every conversation that could
14:44:14 <FeuerFliege> potentially contain one of these though‘ 
14:45:01 <FeuerFliege> but since reservedNames is an array indexOf() should only find exact matches.
14:45:23 <clokep_work> You're right. I read it the opposite direction.
14:46:06 <clokep_work> Could probably use a comment there. ;)
14:47:55 <FeuerFliege> and I don‘t understand what you meant with this comment: http://pastebin.instantbird.com/47902
14:49:52 <clokep_work> FeuerFliege: A equal statement is: |function encodeReservedChars(match) "%" + match.charCodeAt(0).toString(16)|
14:52:33 <FeuerFliege> ok, I just used the example here: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/String/replace#section_11
14:55:27 <clokep_work> FeuerFliege: That's fine, I'm just offering a way to reduce some of the syntax that fl o and I prefer.
14:55:46 <clokep_work> There's nothing /wrong/ with what you wrote, it's just a style thing.
14:58:01 <flo> I still need to handle https://bugzilla.mozilla.org/show_bug.cgi?id=754824#c7 :(
14:58:35 <clokep_work> Would have been nice of him to respond...
14:58:45 <flo> would have been way too easy
14:58:57 <flo> the problem is... I'm almost sure he is (mostly?) right
14:59:03 <-- barlas has quit (Client exited)
14:59:54 <flo> and thinking about conversions between raw bytes of UTF8 and UTF16 makes my head hurt ;)
15:00:49 <flo> and I would like to have unit tests for that, but I really don't know how I could test it
15:00:59 <flo> (appart from just duplicating the whole convertion code in a test file...)
15:01:56 <FeuerFliege> clokep_work: I frankly didn’t know you can shorten a function like that, thank you.
15:03:38 <clokep_work> FeuerFliege: Yeah, I figured as much. I find it a handy shortcut for one-line functions. :)
15:12:00 <-- Optimizer has quit (Ping timeout)
15:12:18 --> aleth has joined #instantbird
15:12:19 * ChanServ sets mode +h aleth 
15:15:02 <clokep_work> FeuerFliege: So knowledge of that bug actually helped a colleague the other day who couldn't check out a git repo on Windows because it included a folder called "aux" and he had no idea what was going on. :)
15:15:48 --> Optimizer has joined #instantbird
15:17:39 <clokep_work> So thanks. ;)
15:20:44 <FeuerFliege> no problem, I first noticed this with Thunderbird: It refused to show a folder called Con. It took me longer than it should to figure out what was going on.
15:21:22 <clokep_work> Did they ever fix it?
15:21:40 <clokep_work> I'd be curious of the bug #, if so.
15:21:43 <flo> it was well known that Start->Run con\con in Windows 98 caused a BSOD though ;).
15:23:37 <-- gerard-majax has quit (Ping timeout)
15:25:05 --> wnayes has joined #instantbird
15:35:34 <-- zen_monkey has quit (Connection reset by peer)
15:43:03 <-- FireFly_TB has quit (Ping timeout)
15:43:03 <-- FeuerFliege has quit (Ping timeout)
15:43:07 --> zen_monkey has joined #instantbird
15:49:53 --> wesj has joined #instantbird
15:56:53 <-- Tomek has quit (Quit: Instantbird 1.1)
16:02:19 <flo> clokep_work: http://pastebin.instantbird.com/47916 how does this feel?
16:05:22 * flo found a random unattended laptop in the meeting room, and there's an Instantbird instance running on it :)
16:33:29 <clokep_work> flo: That looks OK. I think I personally would have aligned the lines of that last bullet point differently.
16:34:38 <flo> I changed the aligment a bit for the patch I attached to https://bugzilla.mozilla.org/show_bug.cgi?id=754824
16:35:06 <flo> and you may want to read the comment I added in the bug if you want to check that I actually looked up the documentation rather than relying on what that previous commenter said
16:37:28 <instantbot> New Core - XMPP bug 1556 filed by florian@instantbird.org.
16:37:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1556 nor, --, ---, nobody, NEW, Download the user's vCard before uploading an avatar
16:37:31 <flo> is that bug blocking 1.2? :-(
16:37:54 <-- Optimizer has quit (Ping timeout)
16:41:20 --> Optimizer has joined #instantbird
16:46:16 <clokep_work> flo: I read it already.
16:46:24 <flo> :)
16:46:34 <clokep_work> I read them in my email usually.
16:46:40 --> Mook_as has joined #instantbird
16:47:20 <clokep_work> Do you want me review on that too or is asuth's enough?
16:47:34 <flo> you can add a flag if you want
16:47:52 <clokep_work> Nope. :) I don't want to be responsible for anything UTF related.
16:48:14 <flo> but I know I asked you here, so I won't feel guilty for landing it without your formal review :)
16:49:48 <Mook_as> ugh, surrogates
16:50:13 <flo> Mook_as: that brings you some bad memories? ;)
16:51:07 <Mook_as> yes. rather recent, actually.
16:51:15 <Mook_as> on account of writing a text editor and all...
16:51:35 <flo> Mook_as: it's the third time I write that stupid function, so... :)
16:53:11 <Mook_as> I'd probably not write it as a nested ternary expression, but https://bugzilla.mozilla.org/attachment.cgi?id=637159&action=diff looks about right, though I wonder why you'd need that
16:54:20 <flo> Mook_as: I need it in gloda to handle search results that sqlite gives as byte indexes, rather than character indexes
16:54:44 <flo> Mook_as: and we also need it for IRC, to check that the messages we are sending aren't longer than the max allowed length
16:55:01 <flo> we suspect IRC servers also count in bytes and aren't UTF8-aware
16:55:55 <Mook_as> yeah, IRC servers are not encoding-aware (for the most part)
16:56:04 <Mook_as> some have been hacked up to allow funny nicks, but I think that's about it
16:56:49 <flo> I would have really preferred not needing that of course ;)
16:57:01 <flo> and I would have preferred to not know how UTF8 works :)
16:57:35 <Mook_as> I'd have preferred all non-UTF8 encodings (including UTF16) to stop existing :)
16:57:38 <-- jb has quit (Ping timeout)
16:57:56 <-- meh has quit (Ping timeout)
17:00:31 <clokep_work> :)
17:01:44 <clokep_work> I wish I didn't know anything about UTF-8 or 16 or any other encoding.
17:01:53 <clokep_work> Good thing I was able to not understand it and let fl o fix my code! :-D
17:02:06 * clokep_work feels like he needs a tab-compelte shortcut to randomly add a space into someone's nick...
17:04:03 <flo> "I was able to not understand it and let fl o fix my code!" really? :-S
17:04:18 <flo> alt+tab :-P
17:04:31 <flo> sounds like that shortcut isn't used for anything :-P
17:07:29 <clokep_work> Are you serious w/ Alt+Tab?
17:07:33 * wnayes is thinking that Google passwords cannot have unicode (http://support.google.com/a/bin/answer.py?hl=en&answer=33386)
17:07:59 <clokep_work> flo: The stuff w/ the encoding/decoding the network streams...
17:08:16 <clokep_work> wnayes: Good to know. :)
17:10:16 <clokep_work> wnayes: Also I looked over some of your code, looks like you had fun. ;)
17:10:29 <flo> clokep_work: I was serious because I tried it on Mac and it currently doesn't do anything. But when I typed it I remembered some people on strange OSes may use it for something else
17:10:46 <clokep_work> "strange OSes"?!
17:10:58 <clokep_work> That's like a core Windows shortcut I use probably every 2 - 3 minutes.
17:11:08 <Mook_as> clokep_work: psst, I think you can use /kick
17:11:20 * clokep_work uses /block ;)
17:11:36 <flo> clokep_work: I just meant an OS where file names as simple as "aux" don't work ;)
17:12:14 <clokep_work> Shush.
17:18:00 * clokep_work suggest Ctrl+Shift+Alt+Tab. :P
17:18:24 <clokep_work> Doh, that's a Windows shortcut. :(
17:18:31 * aleth suggests a modal dialog that says "You are about to ping flo. Are you sure? y/n" :P
17:23:34 <Mook_as> flo: http://pastebin.mozilla.org/1680977
17:26:21 <-- aleth has quit (Input/output error)
17:26:38 --> meh has joined #instantbird
17:27:49 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:29:39 <Mook_as> oh, I guess I didn't need posix semantics
17:41:35 <-- wnayes has quit (Ping timeout)
17:50:13 * clokep_work wonders how difficult it would be to give aleth a "try" server on his Linux box...
17:52:41 --> wnayes has joined #instantbird
18:01:57 <-- Mook_as has quit (Ping timeout)
18:04:04 --> Mook_as has joined #instantbird
18:05:12 <Mook_as> hmm, for IRC, how does it deal with nick collisions and nickserv passwords?
18:05:31 <Mook_as> over on freenode (due to my disconnect), I got auto-renamed to Mook_as1 - but a manual /nick doesn't re-identify
18:05:40 <clokep_work> Yes.
18:05:46 <clokep_work> Because we send it with the PASS command.
18:06:05 <clokep_work> So you get renamed and fail to reauthenticate because Mook1 isn't registered.
18:06:21 <Mook_as> right; but how do I make it re-auth after I fix my nick? :)
18:06:33 <clokep_work> This is what happens: we send <password>, we send <nick>, we're told <nick> is in use, we try <nick>1, it works.
18:06:55 <clokep_work> You can't.
18:07:03 <clokep_work> Because we don't send the password to the NickServ itself.
18:07:32 <Mook_as> oh, we don't? that's surprising, since on connect I get two messages about passwords being useless
18:07:49 <clokep_work> What messages?
18:07:57 <Mook_as> Mook_as1 is not a registered nickname.
18:08:01 <Mook_as> (as a PM from nickserv)
18:08:11 <clokep_work> We send the password as part of the PASS command, which gets forwarded to NickServ, but we don't directly talk to NickServ.
18:08:22 <clokep_work> Yes, well if it's not registered...why would you expect it to auth you? :P
18:08:28 <Mook_as> ah, I see. I wonder why I get that twice then :)
18:09:01 <clokep_work> With a patch I'm working on, you won't see it when you successfully auth.
18:11:43 --> FireFly_TB has joined #instantbird
18:13:31 <-- FireFly_TB has quit (Ping timeout)
18:26:50 --> FireFly_TB has joined #instantbird
18:27:11 --> FeuerFliege has joined #instantbird
18:30:52 --> Lalae has joined #instantbird
18:31:24 <-- Lalae has left #instantbird ()
18:32:22 <-- FireFly_TB has quit (Ping timeout)
18:32:31 <-- FeuerFliege has quit (Ping timeout)
19:04:30 --> igorko has joined #instantbird
19:15:09 --> aleth has joined #instantbird
19:15:09 * ChanServ sets mode +h aleth 
19:23:45 --> FireFly_TB has joined #instantbird
19:24:18 --> FeuerFliege has joined #instantbird
19:28:24 --> Tomek has joined #instantbird
19:43:16 <instantbot> bugi@media.fjmail.de requested review from clokep@gmail.com for attachment 1711 on bug 1108.
19:43:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
19:43:50 --> Mnyromyr has joined #instantbird
19:50:36 <-- micahg has quit (Quit: Ex-Chat)
20:01:31 --> micahg has joined #instantbird
20:01:51 <-- devfil has quit (Ping timeout)
20:02:47 --> jb has joined #instantbird
20:05:07 <-- mmkmou has quit (Ping timeout)
20:05:15 <-- Optimizer has quit (Ping timeout)
20:07:45 --> flo has joined #instantbird
20:07:46 * ChanServ sets mode +qo flo flo 
20:08:57 --> Optimizer has joined #instantbird
20:10:28 --> mmkmou has joined #instantbird
20:11:35 --> devfil has joined #instantbird
20:23:27 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:23:53 <flo> wnayes: is there any part of your code that you would really like me to review before I go in vacations (ie 'soon')?
20:24:12 <-- jb has quit (Quit: Instantbird 1.1)
20:25:07 <wnayes> flo: I was thinking it would be good to figure out the executeSoon situation before you left.
20:35:57 <flo> http://hg.instantbird.org/users/wnayes/file/a71f28014c54/chat/importers/googletalk/googletalk.js#l105 looks like it wants to be |let pass = [aPassword.charCodeAt(i) for (i in aPassword)];|
20:40:24 * clokep_work dislikes that syntax.
20:40:45 <Mook_as> aPassword.split("").map(function(c)c.charCodeAt(0)) ?
20:41:02 <Mook_as> (actually, that looks uglier...)
20:42:04 <flo> clokep_work: I dislike it too, but a for loop with a manual initialization and incrementation of i is even uglier ;)
20:42:29 <flo> wnayes: I'm sure this causes a JS strict warning: http://hg.instantbird.org/users/wnayes/file/a71f28014c54/chat/importers/googletalk/googletalk.js#l247
20:42:41 <flo> _getCurrentUser doesn't always return a value
20:43:06 <flo> do you have JS strict warnings enabled in the build you use for testing? If not you should go to about:config and enable them :)
20:43:44 <wnayes> They may have gotten turned off when I made a new dev profile.
20:44:11 <flo> do you really care if the environment variable exists or not?
20:44:19 <-- zen_monkey has quit (Quit: Saliendo)
20:45:03 * clokep_work probably doesn't have that one either. :(
20:45:29 <clokep_work> flo: Yeah, I agree the loop is uglier. It just takes me 20 seconds to parse that line every time I see it, it's "backwards" to me.
20:46:26 <wnayes> flo: It should always exist on WINNT and it looks like get() returns an empty string if missing, so the exists() could be removed.
20:46:42 <flo> clokep_work: I don't fully parse it. I just see the [] with charCodeAt and for inside, and I assume it does the usual thing (ie create an array with each character)
20:47:56 <flo> wnayes: yes, I was asking if you care about the difference between an environment variable set to an empty string vs not set
20:48:09 <flo> in most cases I would assume you don't
20:48:47 <flo> I won't pretend to understand the code decoding the gtalk password ;)
20:49:28 <wnayes> Those values would likely be empty when GTalk saves the password to disk if they are ever empty from get(), so it could still work.
20:49:32 <flo> if each importer folder has only a .js and a .manifest file, you may want to get rid of the folders, and just put all the files in getCurrentUser
20:49:41 <flo> arg I meant to paste: http://hg.instantbird.org/users/wnayes/file/a71f28014c54/chat/importers/
20:49:52 <-- Optimizer has quit (Ping timeout)
20:51:08 --> Optimizer has joined #instantbird
20:51:22 <wnayes> flo: That would make sense, though today I was thinking the AIM ones might benefit from being split into separate importer files (old aim, aim 7.x, new aim). I suppose both folders and files could coexist too :)
20:52:02 <flo> yes, they could
20:52:14 <flo> are these importers going to share much code, or are they completely different?
20:53:31 <wnayes> the old AIM would have log support and registry reading for credentials, the newer ones don't have logs and store user info in files.
20:54:41 <flo> wnayes: what's going to happen if http://hg.instantbird.org/users/wnayes/file/a71f28014c54/chat/importers/wlm/wlm.js#l50 is never called?
20:54:44 <Mook_as> looks like you might want to use NPGetUser to get the user, instead of via the environment, or something
20:54:59 <flo> would you want to add a try { } finally { } to ensure it's always called?
20:57:41 <Mook_as> hmm, or possibly GetUserName with a combination of LookupAccountName to get the domain too
20:57:48 <wnayes> flo: I'm not sure anything would happen (never had that until the code worked already) but it would be good to have some error catching.
20:58:45 <flo> http://hg.instantbird.org/users/wnayes/file/a71f28014c54/chat/importers/pidgin/pidgin.js#l80 I would say a gtalk account is an XMPP account with @gmail.com OR @gmail.com, or 'connect server' set to talk.google.com
20:59:21 <flo> the second @gmail.com was supposed to be @googlemail.com
20:59:48 <wnayes> Mook_as: I originally thought I had to do something like that, but from what I understand the environment variables should always be on WINNT, and it was a lot of js-ctypes work.
21:01:03 <flo> wnayes: http://hg.instantbird.org/users/wnayes/file/a71f28014c54/chat/importers/pidgin/pidgin.js#l84 always a line break before "else"
21:01:14 <Mook_as> yeah, that probably works most of the time, but I don't trust things like that :p
21:02:15 <flo> Mook_as: because if you are called Mook you are likely to call ./instantbird.exe with crap in the environment just to torture poor soc students? ;)
21:03:54 <flo> http://hg.instantbird.org/users/wnayes/file/a71f28014c54/chat/importers/pidgin/pidgin.js#l92 Isn't there a .firstChild you can use insted of childNodes[0] ?
21:05:07 <flo> and alias[0].childNodes[0].nodeValue will throw if alias[0] is just <alias/> in the XML file, right?
21:05:33 <flo> would alias[0].textContent return what you want?
21:06:00 <wnayes> flo: I'll have to check :)
21:06:24 <flo> I mentioned the alias as an example, there are other instances of the same code in the file ;)
21:08:00 <flo> wnayes: so what do you proposed for the executeSoon mess?
21:09:10 <flo> please, not something that involves an executeSoon call in each importer
21:09:53 <flo> and please also try to reduce the indent level
21:10:08 <flo> the function used at http://hg.instantbird.org/users/wnayes/file/a71f28014c54/chat/importers/pidgin/pidgin.js#l49 looks a lot like it could have a name and be a method of pidginImporter
21:11:12 <wnayes> flo: moving the executeSoon call into imImporter.js (for each |importer.findAccounts(this)| call)? http://hg.instantbird.org/users/wnayes/file/a71f28014c54/chat/components/src/imImporters.js#l33
21:14:28 <-- clokep_work has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:15:27 --> EionRobb has joined #instantbird
21:23:52 <flo> wnayes: maybe wrap lines 28-31 there in an executeSoon call?
21:25:18 <flo> although I must admit I don't even remember why I/we thought firing notifications immediately would be an issue for the UI.
21:28:32 <flo> pff, displaying logs is super slow :(. Some of my #instantbird logs take almost 10s to display
21:28:50 * flo would like to put a profiler at that to know what's so slow about it
21:35:44 <wnayes> flo: The UI creates richlistitems when getting existing-account-found, and changes a few properties when account-search-finished. I'm no expert on race conditions though :). Maybe the initial UI call would only need executeSoon? http://hg.instantbird.org/users/wnayes/file/a71f28014c54/instantbird/content/accountWizard.js#l80
21:46:32 <flo> wnayes: maybe you can get away without the executeSoon call if you reorder that code a bit
21:47:02 <flo> line 77-80 should be at the end of the function I think
21:49:46 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:54:27 <GeekShadow> hello
21:54:33 <GeekShadow> flo, are you using buildbot for IB ?
21:54:53 <GeekShadow> I looked a bit the documentation this afternoon, it's a bit complex to set up no ?
21:55:42 <flo> GeekShadow: hello
21:55:45 <flo> we use buildbot, yes
21:55:54 <flo> Even took care of setting it up for us :)
21:56:17 <flo> and he greatly dislikes buildbot as a consequence ;)
21:57:00 <GeekShadow> he = you ?
21:57:19 <flo> he = Even
21:58:07 <GeekShadow> oh, I understood the word, not the name :p
21:58:22 <flo> you need to install the show nick add-on
21:58:37 <-- Mnyromyr has quit (Ping timeout)
22:06:19 --> Mnyromyr has joined #instantbird
22:09:28 <flo> Good night
22:10:18 <wnayes> flo: Good night, thanks for looking at the importer code :)
22:13:22 <-- Tomek has quit (Quit: Instantbird 1.1)
22:18:13 <flo> wnayes: you are welcome :)
22:18:15 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
22:36:07 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:51:59 <-- igorko has quit (Client exited)
22:54:15 --> mmkmou has joined #instantbird
22:56:42 <instantbot> bugi@media.fjmail.de requested feedback from florian@instantbi rd.org for attachment 1713 on bug 483.
22:56:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=483 min, --, ---, bugi, ASSI, Instantbird default theme has no preview image
22:57:48 <-- mmkmou has quit (Ping timeout)
22:57:54 <instantbot> bugi@media.fjmail.de requested feedback from idechix@instantbi rd.org for attachment 1712 on bug 483.
23:02:02 --> mmkmou has joined #instantbird
23:06:10 <instantbot> bugi@media.fjmail.de set the Resolution field on bug 1531 to FIXED.
23:06:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1531 min, --, ---, bugi, RESO FIXED, [de] l10n: Google Mail -> GMail
23:12:14 <aleth> Is there a way to prod bug 763872 along or is there a reason it is stuck on r??
23:20:16 <-- FireFly_TB has quit (Input/output error)
23:20:43 <-- FeuerFliege has quit (Connection reset by peer)
23:27:44 --> clokep has joined #instantbird
23:27:44 * ChanServ sets mode +o clokep 
23:30:28 --> Tomek has joined #instantbird
23:32:04 --> DGMurdockIII has joined #instantbird
23:37:21 <clokep> Hello!
23:39:51 <Mook_as> hello!
23:40:08 <aleth> Hello!
23:41:26 * clokep hopes he made sense on that bug...
23:44:12 <aleth> The creationtime one?
23:44:16 <clokep> Instantbird was mentioned in http://dutherenverseauborddelatable.wordpress.com/2012/06/27/reintroducing-os-file/
23:44:18 <clokep> Yes.
23:44:36 <aleth> Yes. And I agree, lets just do return true and get rid of the noise.
23:44:59 * clokep wonders if that handles illegal file names...
23:45:09 <clokep> OK. I'll give you a patch once I start boiling water...
23:45:51 <aleth> Btw unreal does it too.
23:47:48 <clokep> Yeah. :)
23:48:21 <clokep> aleth: So I have something you'll appreciate, but I need to make it into a picture...
23:58:25 <aleth> I wonder if OS.File would be good for the logs
23:58:57 <EionRobb> how is OS.File better than the w3c fileapi stuff?