All times are UTC.
00:00:24 <flo> adding bonjour.properties moves 17 strings around in the other locale files of purple/ 00:00:33 <flo> that's unfortunate, but not too terrible 00:00:45 <flo> however if I fix the real bug, it's possible half the strings, or even more, will be moved around 00:01:04 <instantbot> New Core - General bug 1544 filed by clokep@gmail.com. 00:01:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1544 min, --, ---, nobody, NEW, Although configuration of STATIC_PRPLS 00:02:25 <clokep> That sounds more annoying. :P 00:06:54 * flo tried to explain what needs to be done for prpl.manifest 00:07:21 <flo> clokep: yeah, it will be annoying at the time we fix the bug :-/ 00:07:31 <flo> but the resulting order should make more sense, and be stable 00:07:40 <clokep> :) File a bug on that too? ;) 00:08:06 <flo> yeah... 00:11:44 <instantbot> New Instantbird (UI) bug 1545 filed by florian@instantbird.org. 00:11:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1545 min, --, ---, nobody, NEW, The order of strings in each purple/locales/en-US/*.properties file should be independent of the con 00:15:48 * flo wonders if the Bonjour patch is going to be ready for check-in in a few minutes of if he should go to bed now 00:16:03 <clokep> flo: No. 00:16:05 <clokep> Sorry. :( 00:16:12 <flo> what's blocking you? 00:16:34 <clokep> Waiting for my build to finish right now. I was doing a few things at once before. 00:16:42 <clokep> (Needed to clean up from dinner and such.) 00:23:04 <flo> but wasn't that build done a few minutes ago, when you just missed a line in prpl.manifest? :-S 00:25:03 <clokep> Yes, I ran the wrong thing and am building too much. :-[ 00:26:12 <flo> :( 00:26:29 <clokep> I can give you my patch w/ the extra prpl.manifest change, but it's not fully tested. 00:28:02 <flo> maybe you can attach it so that I can check if I have other review comments? :) 00:28:50 <flo> you have done the change to package-manifest for linux? 00:29:29 <instantbot> clokep@gmail.com cancelled review?(mook.moz+bugs.insta ntbird@gmail.com) for attachment 1674 on bug 944. 00:29:31 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1680 on bug 944. 00:29:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, clokep, ASSI, Support for Bonjour 00:29:46 <clokep> flo: No...I haven't. 00:29:47 <clokep> I'll do that now. 00:29:57 <clokep> I knew there was something you said earlier I had forgotten! 00:29:59 <flo> ok, so it's really not ready ^^ 00:31:32 <flo> bah, I'm stupid, it's not ready anyway because we need Even to install the bonjour sdk on the Windows slave; and maybe libavahi on the linux slave 00:32:14 <clokep> Ah, right. :) 00:32:36 <clokep> Go to sleep and I'll put up a tested patch you can read in the morning! 00:32:48 <flo> do you still want to test for test -f "$PURPLE_BONJOUR_SDK"/lib/win32/dnssd.lib in configure? 00:32:48 <clokep> And I'll CC Even to the bug if he's not already. :) 00:33:05 <clokep> Probably not, no. :) 00:33:26 <clokep> Silly that we need the SDK for just a header file then? 00:33:42 <flo> maybe email Even asking him to install the bonjour SDK (give him the link, or even the file if it's small) in C:\Program Files\Bonjour SDK in the VM? 00:33:53 <flo> (that will avoid having to read all the bug, that is already long ^^) 00:34:01 <clokep> Yes of course. 00:34:13 <clokep> His bugmail email? 00:34:20 <flo> what's the license of that header file? 00:34:28 <flo> is it Apache licensed? 00:35:16 <clokep> Looks like roughly a BSD 3-clause? 00:35:35 <clokep> flo: http://pastebin.instantbird.com/47030 00:35:38 <clokep> (Just the license. :)) 00:35:55 <flo> uh, "APPLE_LICENSE_HEADER_START" :-S 00:36:17 <flo> ah, it may not be the same file I was looking at :) 00:36:40 <clokep> That's from dns_sd.h. 00:36:43 <clokep> What file were you looking at? 00:36:50 <flo> http://opensource.apple.com/source/mDNSResponder/mDNSResponder-58.8/mDNSShared/dns_sd.h 00:37:13 <clokep> Interesting. 00:38:04 <flo> I'm wondering if we could put that header directly in the protocols/bonjour/ folder 00:38:46 <flo> would be great, but I'm not sure how we could avoid using that file instead of the system one for Mac 00:39:39 <flo> the file I have in /usr/include/dns_sd.h is likely the same as yours though :) 00:40:05 <flo> it even as an #elif defined(_WIN32) #include <windows.h> 00:41:19 <flo> *has 00:41:28 <clokep> Interesting. 00:41:44 <clokep> We could put it in a win32 folder? 00:41:51 <clokep> That we include only on Windows? 00:42:45 <flo> I'm pretty sure the file I have is exactly the same as yours :) 00:42:52 <flo> but yes, putting it in a win32 folder sounds good 00:42:59 <flo> or less dangerous at least :) 00:43:16 <clokep> OK. I'll do that then and get you a new patch. 00:43:22 <clokep> And get rid of all my configure changes. :P 00:43:34 <flo> the file from the MacOSX10.4u SDK is different though 00:44:02 <clokep> Ah-ha. 00:44:05 <flo> clokep: you still need the avahi checks, don't you? 00:44:09 <clokep> flo: Yes. 00:44:15 <flo> (we don't support 10.4 any more anyway) 00:44:15 <clokep> But I can get rid of the Windows checks then. 00:45:09 <flo> why are you changing the "PROTOCOLS += null" line? 00:45:19 <flo> that tab didn't seem to hurt 00:47:23 <clokep> I don't know why I did that. 00:47:33 <clokep> If I even did it on purpose. 00:48:32 <flo> I think the makefile can be simplified a bit 00:54:29 * clokep wonders about all these "Bonjour Logo licensing agreement" documents on Apple's site. :-S 00:55:09 <flo> what about something like this: http://pastebin.instantbird.com/47035 00:57:12 <clokep> flo: Yes, that looks reasonable. 00:58:25 <flo> I think I've covered all the review comments I had 00:58:48 <clokep> Alright. 00:58:57 <clokep> Thanks. :) 01:00:28 --> Suiseiseki has joined #instantbird 01:02:49 <-- mmkmou has quit (Ping timeout) 01:10:12 <flo> pff, how long does it take before buildbot queues the onCommit builds :-( 01:10:27 <instant-buildbot> build #250 of macosx-onCommit is complete: Exception [exception interrupted] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/250 blamelist: aleth <aletheia2@fastmail.fm>, Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com> 01:11:10 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/6519febff7ea - Patrick Cloke - Bug 1310 - Do not log channel keys when sending the JOIN command, r=aleth. 01:11:11 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/bc4562961d42 - Florian Quèze - Bug 736437 - Chat accounts without protocol plugin aren't correctly handled, r=clokep,bienvenu. 01:11:12 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8ba81ec876ed - Patrick Cloke - Bug 1519 - /invite doesn't work, r=aleth. 01:11:13 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/3fcf847202dc - aleth - Bug 1046 - Account window shows up on disconnect/reconnect, r=fqueze. 01:11:14 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9134c46bae1b - Patrick Cloke - Bug 1534: Allow using a custom username for IRC, r=Mook. 01:12:49 <clokep> If it wasn't assumed...I'll close those all. :) 01:14:06 * flo is trying the l10n buildbot 01:14:07 --> Lalae has joined #instantbird 01:14:32 <-- Lalae has left #instantbird () 01:19:14 <flo> it worked! 01:19:23 <flo> I've received a feedback email :) 01:19:37 <clokep> :) 01:19:40 <clokep> Congrats. 01:19:44 <clokep> My Bonjour build worked too! 01:19:50 <clokep> But I haven't retested the changes on Linux. 01:20:19 <flo> clokep: "Congrats." I haven't done anything ;) 01:20:53 <clokep> Do you want me to take it back? :P 01:21:55 <flo> now I'm trying again with a real push to the fr repository, rather than forcing buildbot to built 01:22:36 <flo> I thought that would work, but it doesn't :-D 01:22:49 <flo> the changeset is listed on http://buildbot-l10n.instantbird.org/waterfall, but there's no pending build 01:23:20 <clokep> :-/ 01:23:32 <flo> it seems Even's suspicion of what the problem with that l10n buildbot was is quite right 01:23:48 <flo> jobs aren't queued/started automatically on pushes, even though it's clear by hg notifies buildbot 01:24:31 <flo> I think it's the last piece of infrastructure that needs fixing before localizers can start working 01:28:06 <clokep> :) 01:29:54 <flo> I should also resolve that filter.py bug, but it's less critical 01:30:37 <instantbot> clokep@gmail.com set the Resolution field on bug 1534 to FIXED. 01:30:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1534 min, --, 1.2, clokep, RESO FIXED, Allow using a custom username for IRC. 01:31:12 <flo> Good night! 01:31:49 <instantbot> clokep@gmail.com set the Resolution field on bug 1046 to FIXED. 01:31:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1046 min, --, 1.2, aletheia2, RESO FIXED, Account window shows up on disconnect/reconnect 01:32:19 <instantbot> clokep@gmail.com set the Resolution field on bug 1519 to FIXED. 01:32:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1519 nor, --, 1.2, clokep, RESO FIXED, /invite doesn't work 01:33:09 <instantbot> clokep@gmail.com set the Resolution field on bug 1310 to FIXED. 01:33:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1310 min, --, 1.2, clokep, RESO FIXED, Do not log channel keys when sending the JOIN command 01:33:46 <instant-buildbot> build #282 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/282 01:58:00 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1680 on bug 944. 01:58:01 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1681 on bug 944. 01:58:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, clokep, ASSI, Support for Bonjour 02:45:36 <instant-buildbot> build #542 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/542 02:57:45 <instantbot> clokep@gmail.com requested review from the wind for attachment 1682 on bug 1496. 02:57:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1496 nor, --, ---, clokep, ASSI, test_ctcpFormatToText and test_mIRCColor aren't executed 02:59:26 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1682 on bug 1496. 03:28:06 <instantbot> mook.moz+bugs.instantbird@gmail.com granted review for attachment 1681 on bug 944. 03:28:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, clokep, ASSI, Support for Bonjour 03:31:33 <instant-buildbot> build #270 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/270 03:47:08 <clokep> Does the bottom of our help dialog link to a file that doesn't exist? (license.html)? 03:49:33 <clokep> Sorry, the "about" dialog, not the help dialog. 03:56:07 <instantbot> New Instantbird (UI) bug 1546 filed by clokep@gmail.com. 03:56:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1546 nor, --, ---, nobody, NEW, license.html not distributed with Instantbird 04:00:00 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1681 on bug 944. 04:00:01 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1683 on bug 944. 04:00:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, clokep, ASSI, Support for Bonjour 04:02:11 --> Tomek has joined #instantbird 04:13:17 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 04:37:02 <-- Tomek has quit (Quit: Instantbird 1.1) 05:29:45 --> NmN has joined #instantbird 05:47:24 <instant-buildbot> build #633 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/633 06:07:38 <instant-buildbot> build #529 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/529 07:44:42 --> FireFly_TC has joined #instantbird 08:00:40 --> Optimizer has joined #instantbird 08:25:34 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:41:45 <flo> clokep: I don't know, but clicking the "license" link in the about dialog gives me this error: Timestamp: 08:41:45 <flo> Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIHandlerInfo.launchWithURI]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://mozapps/content/handling/dialog.js :: onAccept :: line 254" data: no] ::( 09:00:55 <instantbot> florian@instantbird.org denied review for attachment 1683 on bug 944. 09:00:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, clokep, ASSI, Support for Bonjour 09:02:56 --> meh has joined #instantbird 09:08:49 --> Even2 has joined #instantbird 09:08:56 <-- Even2 has quit (Quit: Even2) 09:09:03 --> Even2 has joined #instantbird 09:31:12 --> Lalae has joined #instantbird 09:45:34 <-- Lalae has left #instantbird () 10:18:45 --> jb has joined #instantbird 10:31:52 <instantbot> florian@instantbird.org denied review for attachment 1682 on bug 1496. 10:31:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1496 nor, --, ---, clokep, ASSI, test_ctcpFormatToText and test_mIRCColor aren't executed 10:47:32 <-- FireFly_TC has quit (Ping timeout) 11:15:02 --> aleth has joined #instantbird 11:15:03 * ChanServ sets mode +h aleth 11:18:22 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:18:32 --> aleth has joined #instantbird 11:18:32 * ChanServ sets mode +h aleth 11:23:48 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:25:11 --> aleth has joined #instantbird 11:25:11 * ChanServ sets mode +h aleth 11:35:26 --> devfil has joined #instantbird 11:50:55 --> Tonnes has joined #instantbird 12:10:37 --> Optimizer has joined #instantbird 12:16:03 --> Tomek has joined #instantbird 12:16:35 --> FireFly_TC has joined #instantbird 12:18:19 <-- FireFly_TC has quit (Ping timeout) 12:40:46 <-- micahg has quit (Ping timeout) 12:45:22 --> micahg has joined #instantbird 12:57:57 <-- GeekShadow has quit (Ping timeout) 13:03:07 --> GeekShadow has joined #instantbird 13:12:11 --> clokep has joined #instantbird 13:12:11 * ChanServ sets mode +o clokep 13:17:22 <-- chrisccoulson has quit (Ping timeout) 13:34:35 <-- clokep has quit (Ping timeout) 13:39:10 <-- jb has quit (Ping timeout) 13:39:20 --> clokep has joined #instantbird 13:39:20 * ChanServ sets mode +o clokep 13:49:20 <-- Optimizer has quit (Ping timeout) 13:49:55 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1684 on bug 944. 13:49:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, clokep, ASSI, Support for Bonjour 13:51:53 <clokep> Good morning. :) 13:52:53 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 13:52:57 --> aleth has joined #instantbird 13:52:57 * ChanServ sets mode +h aleth 13:53:00 --> Optimizer has joined #instantbird 14:12:35 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1685 on bug 1496. 14:12:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1496 nor, --, ---, clokep, ASSI, test_ctcpFormatToText and test_mIRCColor aren't executed 14:13:38 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 14:13:42 --> aleth has joined #instantbird 14:13:42 * ChanServ sets mode +h aleth 14:15:12 --> igorko has joined #instantbird 14:23:01 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 14:23:10 --> clokep has joined #instantbird 14:23:11 * ChanServ sets mode +o clokep 14:23:39 <aleth> Looks like bonjour might make it into 1.2 after all at this rate ;) 14:23:58 <-- meh has quit (Ping timeout) 14:24:25 --> meh has joined #instantbird 14:29:19 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 1660 on bug 1296. 14:29:20 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1686 on bug 1296. 14:29:20 <clokep> Yes, if I stop doing stupid things in makefiles. :-D 14:29:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1296 enh, --, ---, clokep, ASSI, Unhandled IRC whois response messages 307 671 317 14:29:49 <instantbot> clokep@gmail.com requested feedback from aletheia2@fastmai l.fm for attachment 1686 on bug 1296. 14:31:13 <clokep> Uhh...that was supposed to be review, not feedback from aleth. :( Oops. 14:31:20 <clokep> Just mark the right flag when you review it? ;) 14:34:41 <aleth> I really don't like those strings ("unknown connection" just sounds confusing to me... and I can imagine "unknown nickname? but clearly the user has a nick?"). But I'm not going to block it if you and flo think they are OK. 14:35:04 <aleth> It's possible there is no really good way of doing it with the current tooltip format 14:35:55 <clokep> I don't like them either. 14:38:59 <aleth> This was the best I came up with https://bugzilla.instantbird.org/show_bug.cgi?id=1296#c13, and it's not great either. 14:39:02 <instantbot> Bug 1296 enh, --, ---, clokep, ASSI, Unhandled IRC whois response messages 307 671 317 14:43:33 <clokep> Yeah. 14:43:43 <clokep> I wonder if we should just separate them and know that it sucks. :( 14:43:57 <aleth> Possibly. 14:45:07 <clokep> Although I do agree w/ flo that the reason is "Can I trust talking to this person?" (as in..."Is this person who I think they are?") 14:45:26 <clokep> There isn't an easy answer to that though. :-D 14:45:49 <aleth> I agree with that too... but like you say, I'm not sure the protocol really supports it 14:46:44 <aleth> I mean, if it did you'd say "Identity: not verified" or "Identity: uncertain"... 14:47:32 <aleth> I suggested "Identified by" because it simply lists the things in favour of "yes its who you think" 14:48:28 <-- meh has quit (Connection reset by peer) 14:48:38 --> meh has joined #instantbird 15:01:32 <Optimizer> why does instantbot adds a space in b/w the emails ? 15:04:37 <flo> Optimizer: it doesn't really "adds a space", it just fails to remove the \n from the bug mail 15:04:48 <Optimizer> oh 15:14:27 <-- Optimizer has quit (Ping timeout) 15:14:47 --> Optimizer has joined #instantbird 15:16:29 <-- Optimizer has quit (Ping timeout) 15:20:01 --> Optimizer has joined #instantbird 15:23:58 <-- clokep has quit (Ping timeout) 15:28:45 <-- Optimizer has quit (Ping timeout) 15:32:22 --> Optimizer has joined #instantbird 15:40:16 <-- Optimizer has quit (Ping timeout) 15:43:35 --> Optimizer has joined #instantbird 15:43:44 --> sonny1 has joined #instantbird 15:45:19 <-- sonny1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 15:45:20 --> sonny has joined #instantbird 15:45:26 <-- Tomek has quit (Ping timeout) 15:48:38 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 15:48:41 --> sonny has joined #instantbird 15:49:24 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 15:49:48 --> clokep has joined #instantbird 15:49:48 * ChanServ sets mode +o clokep 15:51:41 --> sonny has joined #instantbird 15:54:49 <-- Optimizer has quit (Ping timeout) 15:55:59 <-- sonny has quit (Ping timeout) 15:58:16 --> Optimizer has joined #instantbird 16:00:33 <-- igorko has quit (Connection reset by peer) 16:06:28 --> sonny has joined #instantbird 16:23:11 --> igorko has joined #instantbird 16:26:58 --> mmkmou has joined #instantbird 16:37:07 <-- gerard-majax has quit (Ping timeout) 16:40:26 --> gerard-majax has joined #instantbird 16:44:12 --> sonny1 has joined #instantbird 16:45:17 <-- sonny has quit (Ping timeout) 17:00:38 <-- meh has quit (Ping timeout) 17:03:24 --> Tomek has joined #instantbird 17:07:24 <-- NmN has quit (Quit: Instantbird 1.1) 17:21:17 --> FireFly_TB has joined #instantbird 17:21:40 --> FeuerFliege has joined #instantbird 17:30:30 <-- Optimizer has quit (Ping timeout) 17:33:46 --> Optimizer has joined #instantbird 17:35:01 --> meh has joined #instantbird 17:44:03 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 17:44:16 --> aleth has joined #instantbird 17:44:16 * ChanServ sets mode +h aleth 18:29:32 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:35:54 <-- mmkmou has quit (Ping timeout) 18:41:43 <-- devfil has quit (Client exited) 18:42:04 <-- sonny1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:43:53 --> sonny has joined #instantbird 19:03:02 <-- FireFly_TB has quit (Ping timeout) 19:03:02 <-- FeuerFliege has quit (Ping timeout) 19:04:31 <-- Optimizer has quit (Ping timeout) 19:05:07 --> flo has joined #instantbird 19:05:07 * ChanServ sets mode +qo flo flo 19:08:06 --> Optimizer has joined #instantbird 19:37:01 <Optimizer> the perfect mac book pro is supposedly 3800 usd 19:39:10 --> DGMurdockIII has joined #instantbird 19:54:07 <clokep> "perfect" == "upgrade everything possible"? :P 19:54:30 <Optimizer> inside the laptop, yes 19:54:52 <Optimizer> not upgrading to those bs extras apple try to sell 19:55:04 <Optimizer> like a whole extra tv screen 1000 usd 19:55:17 <Optimizer> and 3 diff types of external hdd options 19:58:49 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 20:00:53 <DGMurdockIII> hey when are we going to be able to be able to be able to block people on instinbird 20:01:12 <DGMurdockIII> instantbird 20:02:39 <clokep> When someone writes the code to do it. 20:12:28 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 21:03:01 <-- gerard-majax has quit (Ping timeout) 21:09:00 --> mmkmou has joined #instantbird 21:20:10 --> EionRobb has joined #instantbird 21:31:58 --> FeuerFliege has joined #instantbird 21:32:00 --> FireFly_TB has joined #instantbird 21:33:40 <-- FireFly_TB has quit (Ping timeout) 21:33:40 <-- FeuerFliege has quit (Ping timeout) 21:38:59 <-- igorko has quit (Connection reset by peer) 21:55:37 <flo> clokep: is Bonjour ready for landing, or do we need to figure out the license.html file before? 21:56:18 <clokep> flo: It's probably just copying the license into license.html? 21:56:57 <flo> no, license.html is a toolkit file 21:57:50 <flo> isn't the license we need identical to about:license#apple ? 21:59:36 <clokep> Oh, is it in there already? I didn't realize Toolkit used code from Apple at all. 21:59:43 <-- aleth has quit (Input/output error) 21:59:52 <clokep> It's not identical, no. 21:59:57 --> aleth has joined #instantbird 21:59:57 * ChanServ sets mode +h aleth 22:00:18 <clokep> There's a third clause. 22:01:19 <clokep> But it's very similar to the Apple/Mozilla NPRuntime License. ;) 22:01:43 <flo> but not identical 22:02:24 <flo> I'm not sure if we can add a hack to add a section to that file, or if we will have to fork it 22:02:37 <flo> hmm, maybe we can just add a patch, and apply it with the patch command? :-D 22:02:57 <flo> instead of the sed commands I currently have :) 22:03:06 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 22:03:09 --> aleth has joined #instantbird 22:03:09 * ChanServ sets mode +h aleth 22:05:22 <clokep> That sounds like a good idea! 22:07:40 <instantbot> florian@instantbird.org granted review for attachment 1684 on bug 944. 22:07:41 <flo> so it's time to land it I guess :) 22:07:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, clokep, ASSI, Support for Bonjour 22:08:30 <flo> and I should try to avoid forgetting to land the converted strings in the libpurple-l10n repository :) 22:16:28 <clokep> flo: Are the libavahi dev files aren't installed the Linux nightly will fail unless you also commit a --disable-bonjour. 22:16:52 <flo> I assume s/Are/If/ ? 22:16:59 <clokep> Yes. 22:17:10 <clokep> That went from a question to a statement as I wrote it. :-D 22:17:13 <flo> I have no idea of whether they are installed or not 22:17:31 <flo> but we will know tomorrow if aleth doesn't have an update offered ;) 22:18:15 <clokep> Hah, OK. :) 22:18:35 <flo> http://hg.instantbird.org/l10n/libpurple/ :) 22:22:26 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/fa358638ac2b - Patrick Cloke - Bug 944 - Support for Bonjour, r=fqueze,Mook. 22:23:04 <flo> I wanted to review wnayes' code during the week-end, but I haven't even started :-/ 22:23:14 <flo> I need to do it during the next 3 days 22:23:57 --> devfil has joined #instantbird 22:24:08 <clokep> I haven't looked at the UI code at all, I don't know if you have. 22:24:18 <flo> I'll probably have other things to worry about Thursday (I need to move my stuff out of the university room I currently have, and it's the day I sign the contract at the notary's place, and finally get the day of my house) 22:24:57 <flo> and I'll take Friday off to fix a few things on the AMI before the long drive (17hours) that I have ahead for Saturday and Sunday 22:25:12 <flo> s/day/keys/ 22:25:26 <clokep> Congrats. :) 22:26:07 <flo> thanks 22:26:36 <flo> it feels strange to finally get the keys, and then immediately go away spend a week at the other end of the country 22:27:29 <clokep> Haha, it'll be waiting for you when you get back. :) 22:31:54 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 22:32:00 --> aleth has joined #instantbird 22:32:00 * ChanServ sets mode +h aleth 22:34:19 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 22:34:22 --> aleth has joined #instantbird 22:34:22 * ChanServ sets mode +h aleth 22:38:04 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 23:12:08 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 13.0.1/20120614114901]) 23:22:06 <instant-buildbot> build #251 of macosx-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/251 blamelist: Patrick Cloke <clokep@gmail.com> 23:23:01 <clokep> :-/ 23:23:04 <clokep> That's not good... 23:23:21 <flo> but buildbot is blaming you, so it's not my fault ;) 23:23:44 <flo> yeah, it's your fault :-P 23:23:58 <flo> too bad I haven't tested the configure script :( 23:24:06 <flo> (didn't want to force my whole build to rebuilt) 23:24:32 <clokep> :( 23:24:43 <clokep> It looks like http://hg.instantbird.org/instantbird/rev/fa358638ac2b#l2.25 didn't work. 23:24:47 <flo> and I just read the project of contract that the notary sent me Friday. Several errors that need to be fixed before signing -> r- ! 23:25:19 <clokep> Hahah, I don't think the notary will understand that. ;) 23:25:24 <flo> where's the if "${OS_TARGET}" = "WINNT" || "${OS_TARGET}" = "Darwin"; syntax coming from? O_o 23:25:51 <clokep> I thought I saw it somewhere in their? 23:26:06 <clokep> I never claimed to know how to write configure stuff. ;) 23:26:24 <clokep> Right I saw it in places like http://lxr.instantbird.org/instantbird/source/configure.in#1886 23:26:29 <flo> didn't mook pretend he reviewed that part? 23:26:41 <flo> I'm glad it's only a third my fault \o/ 23:27:06 <flo> that line is completely different 23:27:31 <clokep> It looks very very similar to me. 23:27:37 <flo> it's not 23:28:03 <clokep> Can you explain what it's doing then that's different? 23:28:08 <flo> but I'll try to find an example of code you can copy paste 23:28:10 <clokep> I see a handful of places in that file that it seems to be using || for or. 23:28:54 <flo> and for the shell script course, I would prefer doing it when it's not 1:30am (and I still need to sign-up for an insurance contract for the house this evening, before driving back to Lille (~1hour) ;)) 23:29:26 <clokep> Alright. 23:30:22 <flo> I think it would be cleaner to use a case ... in syntax 23:30:29 <flo> see an example at http://lxr.instantbird.org/instantbird/source/configure.in#1823 23:30:36 <flo> or http://lxr.instantbird.org/instantbird/source/configure.in#1750 23:30:59 <clokep> The | is an or? So it would be WINNT|Darwin? 23:31:02 <flo> or http://mxr.mozilla.org/comm-central/source/ldap/sdks/c-sdk/configure#4912 23:31:13 <flo> it's the shell script equivalent of switch/case/break ;) 23:31:32 <flo> yes, | is or 23:32:12 <instant-buildbot> build #271 of win32-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/271 blamelist: Patrick Cloke <clokep@gmail.com> 23:32:17 <instant-buildbot> build #283 of linux-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/283 blamelist: Patrick Cloke <clokep@gmail.com> 23:33:43 <flo> "checking for avahi-client avahi-glib... Package avahi-client was not found in the pkg-config search path." from the linux log :( 23:37:34 <clokep> OK I'm testing it on Windows w/ configure now... 23:38:41 <-- mmkmou has quit (Ping timeout) 23:38:54 --> mmkmou has joined #instantbird 23:39:25 <clokep> Alright htat passed... 23:42:42 <clokep> So http://pastebin.instantbird.com/47183 passes configure on both Windows and Linux, but I didn't do a full rebuild, just verified that autoconf.mk seems correct. 23:43:39 --> Kaishi has joined #instantbird 23:44:06 <-- mmkmou has quit (Ping timeout) 23:48:48 --> mmkmou has joined #instantbird 23:49:13 --> chrisccoulson has joined #instantbird 23:55:02 <flo> if the insurance website could stop returning error 500, that would help! 23:55:59 <flo> clokep: that patch seems OK with me 23:56:22 <flo> it's what I would have preferred you to write, but I didn't r- for that because it was only a coding style issue 23:56:34 <flo> I hadn't noticed your test syntax was messed up :) 23:56:57 <clokep> Yeah, there was a lot of revisions...sorry about that. :( 23:57:05 <clokep> Would you like that attached to the bug? 23:57:26 <flo> well, I'm not so sure it's ok actually 23:57:33 <clokep> In the future feel free to comment on my coding style in languages I don't really know! 23:57:40 <clokep> Oh? :( 23:57:57 <flo> I don't see why we would not check for libavahi in freebsd or other posix non-linux OSes 23:58:09 <clokep> So you want a * for the last thing? 23:58:09 <flo> before it was just an else, now it's testing for "Linux" 23:58:24 <clokep> I think I saw one of the examples seemed to use that as a wild card... 23:58:38 <flo> "In the future feel free to comment on my coding style in languages I don't really know!" yeah, but it's also something (the coding style of configure.in) that I don't really know ;)) 23:58:48 <clokep> :) Fair enough. 23:58:49 <flo> clokep: "So you want a * for the last thing?" yeah, I would prefer that 23:59:03 <flo> it's the equivalent of 'default:' in a switch/case I think :) 23:59:26 <clokep> Shell scripting has awful syntax btw. 23:59:56 * flo agrees