All times are UTC.
00:33:06 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 00:36:31 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 02:10:59 <instant-buildbot> build #632 of win32-nightly-default is complete: Failure [failed shell] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/632 02:54:52 <instant-buildbot> build #541 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/541 03:56:43 --> clokep has joined #instantbird 03:56:43 * ChanServ sets mode +o clokep 03:57:52 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 03:57:56 --> clokep has joined #instantbird 03:57:56 * ChanServ sets mode +o clokep 03:59:20 <clokep> wnayes: Yes that will do it. :) Both end up in the components folder. 04:07:56 <-- clokep has quit (Ping timeout) 04:12:57 <-- wesj has quit (Input/output error) 04:49:34 <-- skeledrew has quit (Ping timeout) 05:28:01 <-- flo has quit (Ping timeout) 05:28:40 --> flo has joined #instantbird 05:28:40 * ChanServ sets mode +qo flo flo 05:50:32 --> pvagner has joined #instantbird 06:23:01 <-- pvagner has quit (Connection reset by peer) 07:49:56 <-- meh has quit (Ping timeout) 08:11:00 --> meh has joined #instantbird 08:43:47 --> jb has joined #instantbird 08:51:46 <-- jb has quit (Ping timeout) 09:00:30 --> Optimizer has joined #instantbird 09:05:43 <-- Optimizer has quit (Ping timeout) 09:09:53 --> Optimizer has joined #instantbird 09:15:07 <-- Optimizer has quit (Ping timeout) 09:15:19 --> Even2 has joined #instantbird 09:16:14 --> skeledrew has joined #instantbird 09:18:48 --> Optimizer has joined #instantbird 09:42:35 --> Lalae has joined #instantbird 09:42:50 <-- Lalae has left #instantbird () 10:02:56 --> Bollebib has joined #instantbird 10:08:35 --> gerard-majax has joined #instantbird 10:09:38 --> aleth has joined #instantbird 10:09:39 * ChanServ sets mode +h aleth 10:22:15 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1663 on bug 1538. 10:22:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1538 min, --, ---, aletheia2, ASSI, Don't reset nick at reconnect if the last nick change was user initiated 10:26:17 <instantbot> New Core - IRC bug 1540 filed by aletheia2@fastmail.fm. 10:26:18 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1664 on bug 1540. 10:26:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1540 nor, --, ---, aletheia2, ASSI, Handle 432: Erroneous nickname 10:30:33 <-- chrisccoulson has quit (Quit: Ex-Chat) 11:21:24 --> clokep has joined #instantbird 11:21:24 * ChanServ sets mode +o clokep 11:39:20 <instantbot> clokep@gmail.com denied review for attachment 1663 on bug 1538. 11:39:21 <clokep> aleth: I had been planning to do those bugs this morning. :P 11:39:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1538 min, --, ---, aletheia2, ASSI, Don't reset nick at reconnect if the last nick change was user initiated 11:41:57 <aleth> My morning is earlier than your morning :P 11:45:53 <clokep> Yes, it is. :) 11:48:26 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1665 on bug 1538. 11:48:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1538 min, --, ---, aletheia2, ASSI, Don't reset nick at reconnect if the last nick change was user initiated 11:51:11 --> FeuerFliege has joined #instantbird 11:52:05 <clokep> aleth: Looks good, I need to test it first though. :) 11:52:06 --> FireFly_TB has joined #instantbird 11:52:19 <aleth> Test them together... 11:56:05 <clokep> I'm going to test the nick one first and then the other one. 11:57:14 <aleth> All I meant is that you need the nick one to test half of the 432 one, obviously 11:59:05 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:59:16 --> aleth has joined #instantbird 11:59:16 * ChanServ sets mode +h aleth 12:58:29 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 12:58:30 --> aleth has joined #instantbird 12:58:30 * ChanServ sets mode +h aleth 13:16:23 <instantbot> clokep@gmail.com granted review for attachment 1665 on bug 1538. 13:16:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1538 min, --, ---, aletheia2, ASSI, Don't reset nick at reconnect if the last nick change was user initiated 13:17:53 <clokep> aleth: Btw I'm not going to thoroughly review the other patch until I know why we need changes to the ircMessage stuff. 13:18:42 <aleth> Sure, it's not nice that that change is required. I couldn't see a more minimalist way to modify the regexp though 13:25:20 <instantbot> aletheia2@fastmail.fm denied review for attachment 1664 on bug 1540. 13:25:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1540 nor, --, ---, aletheia2, ASSI, Handle 432: Erroneous nickname 13:26:30 <aleth> Server-specific trouble detected... ;) 13:32:12 <clokep> I need to read the RFC and says if it must be exactly one space in between or not. 13:34:13 <aleth> My patch is no good because some servers (freenode) are better than the ones I tested this morning and insert a * for the blank parameter. For those no exception is needed of course. 13:34:42 <clokep> That's the kind of thing you should include in the bug! :p 13:35:02 <aleth> I only just found out :-/ 13:35:35 <clokep> Alright. 13:35:36 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1666 on bug 1310. 13:35:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1310 min, --, ---, clokep, ASSI, Do not log channel keys when sending the JOIN command 13:36:09 <-- skeledrew has quit (Ping timeout) 13:36:11 <clokep> Easy one for ya. :) 13:37:08 <instantbot> clokep@gmail.com set the Resolution field on bug 1493 to DUPLICATE of bug 1457. 13:37:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1493 enh, --, ---, nobody, RESO DUPLICATE, Support multiple name/connectedFrom/connectedTo whowas entries 13:37:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1457 min, --, ---, nobody, NEW, Make use of all WHOWAS 312/314 response pairs 13:38:01 <aleth> heh. 13:38:34 <clokep> Duping yourself. :P 13:38:38 <clokep> I've done that before too haha. 13:39:27 <aleth> Just shows I wasn't too interested in fixing it I guess :P 13:39:51 <clokep> aleth: bug 1311 was fixed by bug 385, right? 13:39:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1311 nor, --, ---, nobody, NEW, Failing to join password protected channel using "/join #channel password" 13:39:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, 1.2, aletheia2, RESO FIXED, Rejoin IRC channels after reconnect 13:40:10 <clokep> Yes, it was... 13:40:15 --> skeledrew has joined #instantbird 13:40:56 <aleth> Mic should retest it though just in case. 13:41:25 <instantbot> clokep@gmail.com set the Resolution field on bug 1311 to FIXED. 13:41:27 <aleth> I never actually connected to a passworded channel, just tested that the passwords were sent as they should be. 13:41:37 <clokep> I tested it when I tested your patch. :P 13:41:43 <aleth> :) 13:42:14 <aleth> How do you set up a password-protected channel btw? 13:43:28 <instantbot> aletheia2@fastmail.fm granted review for attachment 1666 on bug 1310. 13:43:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1310 min, --, ---, clokep, ASSI, Do not log channel keys when sending the JOIN command 13:43:45 <clokep> aleth: /mode +k <key 13:43:54 <clokep> Which we get an error about btw right now. I forgot to file that. :( 13:43:56 <clokep> I'm going to do it now. 13:45:31 <instantbot> New Core - IRC bug 1541 filed by clokep@gmail.com. 13:45:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1541 nor, --, ---, nobody, NEW, MODE fails to handle when a key is set and we are in the room 13:46:06 <clokep> aleth: I hate that that's part of the MODE command. :( 13:46:21 <aleth> The saga continues :( 13:46:31 <-- FeuerFliege has quit (Ping timeout) 13:46:49 <-- FireFly_TB has quit (Ping timeout) 13:50:13 * clokep finds it ironic that we have a /time message that we don't handle the response of... 13:50:46 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1667 on bug 1540. 13:50:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1540 nor, --, ---, aletheia2, ASSI, Handle 432: Erroneous nickname 14:04:25 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1667 on bug 1540. 14:04:26 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1668 on bug 1540. 14:04:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1540 nor, --, ---, aletheia2, ASSI, Handle 432: Erroneous nickname 14:04:43 <aleth> not again... 14:06:17 <flo> lots of IRC patches flying around ;) 14:06:55 <-- Optimizer has quit (Ping timeout) 14:08:36 --> Optimizer has joined #instantbird 14:10:05 <clokep> flo: What was our reasoning for putting the NOTICE command to the server tab? 14:12:44 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1668 on bug 1540. 14:12:45 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1669 on bug 1540. 14:12:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1540 nor, --, ---, aletheia2, ASSI, Handle 432: Erroneous nickname 14:14:56 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1669 on bug 1540. 14:14:57 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1670 on bug 1540. 14:14:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1540 nor, --, ---, aletheia2, ASSI, Handle 432: Erroneous nickname 14:15:18 <aleth> Sorry for the bugspam there. Had two tabs open for the same bug without realizing it... 14:15:20 * clokep will check that one tomorrow. ;) 14:22:08 <aleth> Hopefully the comment is clear now. 14:29:08 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1671 on bug 1519. 14:29:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1519 nor, --, ---, clokep, ASSI, /invite doesn't work 14:36:08 <-- Tonnes has quit (Quit: ChatZilla 0.9.88.2 [Firefox 13.0.1/20120614114901]) 14:36:17 <clokep> I think I'm done for now. ;) 14:43:20 <instantbot> aletheia2@fastmail.fm denied review for attachment 1671 on bug 1519. 14:43:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1519 nor, --, ---, clokep, ASSI, /invite doesn't work 14:43:57 <aleth> If you want to do the other half in a separate bug, you can r+ that instead :) 14:44:05 <clokep> Bleh bleh. 14:44:07 <clokep> I'll just do it. 14:52:28 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1672 on bug 1519. 14:52:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1519 nor, --, ---, clokep, ASSI, /invite doesn't work 14:52:37 <clokep> Was fairly easy. ;) 15:10:23 <-- Optimizer has quit (Connection reset by peer) 15:10:27 --> Optimizer has joined #instantbird 15:10:27 --> FireFly_TB has joined #instantbird 15:10:28 --> FeuerFliege has joined #instantbird 15:20:00 --> DGMurdockIII has joined #instantbird 15:34:05 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 13.0.1/20120614114901]) 15:42:43 <flo> clokep: do we really put *all* NOTICE in the server tab? :-S 15:52:38 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 15:52:55 --> flo has joined #instantbird 15:52:55 * ChanServ sets mode +qo flo flo 15:52:58 <clokep> flo: We put all messages that come from the server, yes. 15:53:27 <flo> clokep: if these are server messages, why are you surprised that we put them in the server tab? 15:53:29 * flo is confused :-S 15:57:03 <clokep> flo: Because this one is actually applicable to an individual room? 15:57:28 <flo> is the room name provided? 15:57:38 <flo> and do we have a way to detect it? :) 15:59:34 <clokep> The name is provided, yes. But it's part of the text of the message, which makes me think that message isn't standard. :( 15:59:48 <instantbot> aletheia2@fastmail.fm denied review for attachment 1672 on bug 1519. 15:59:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1519 nor, --, ---, clokep, ASSI, /invite doesn't work 16:00:06 <flo> what's the message? 16:00:09 * flo doesn't have the context 16:00:17 <flo> (I haven't read all the bugmail that arrived today) 16:00:55 <clokep> flo: https://bugzilla.instantbird.org/show_bug.cgi?id=1519#c2 16:03:02 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1673 on bug 1519. 16:03:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1519 nor, --, ---, clokep, ASSI, /invite doesn't work 16:03:53 <flo> clokep: I think the annoying messages that made us put NOTICEs in the server tab were the messages from *.mozilla.org telling us we are connected over SSL 16:04:03 <instantbot> aletheia2@fastmail.fm granted review for attachment 1673 on bug 1519. 16:04:12 <clokep> flo: I think you're right. 16:05:46 <aleth> It'd be fairly straightforward to check if the first parameter of NOTICE was a channel name, and forward it accordingly. 16:06:36 <aleth> I suppose it wasn't obvious at the time this could happen... 16:08:44 <clokep> aleth: The first parameter? Check again. ;) 16:09:14 <clokep> Ah, I guess you might be able to do that... 16:09:19 <clokep> Hmmm... 16:09:29 <clokep> So you mean if it's ever a channel (instead of directed directly to you), put it in the channel? 16:09:53 * clokep wonders what's with the @ sign in front of #testib2. 16:09:57 <aleth> Yes, and if it turns out to produce noise we will notice. 16:10:13 <aleth> That user prefix was what confused me too at first... 16:10:43 <clokep> Yeah, I assume it's a user prefix... 16:16:20 <clokep> I'll file a separate bug aleth. :) 16:21:28 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1674 on bug 944. 16:21:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, clokep, ASSI, Support for Bonjour 16:22:29 <instantbot> clokep@gmail.com requested review from mook.moz+bugs.insta ntbird@gmail.com for attachment 1674 on bug 944. 16:23:10 <aleth> Oh, nice :) clokep 1 build system 0 ;) 16:23:16 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 16:23:31 --> aleth has joined #instantbird 16:23:31 * ChanServ sets mode +h aleth 16:26:08 --> Lalae has joined #instantbird 16:26:49 <clokep> aleth: It took a lot of effort and I (unfortunately) know something about autoconf now. 16:31:54 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 16:31:59 --> aleth has joined #instantbird 16:31:59 * ChanServ sets mode +h aleth 16:35:16 <-- Lalae has left #instantbird () 16:37:09 <-- aleth has quit (Input/output error) 16:37:13 --> aleth has joined #instantbird 16:37:13 * ChanServ sets mode +h aleth 16:38:22 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 16:38:24 --> aleth has joined #instantbird 16:38:24 * ChanServ sets mode +h aleth 16:38:47 <-- aleth has quit (Input/output error) 16:38:49 --> aleth has joined #instantbird 16:38:49 * ChanServ sets mode +h aleth 16:39:17 --> DGMurdockIII has joined #instantbird 16:46:49 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 16:46:54 --> aleth has joined #instantbird 16:46:54 * ChanServ sets mode +h aleth 16:48:23 --> chrisccoulson has joined #instantbird 16:51:54 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 16:51:58 --> aleth has joined #instantbird 16:51:58 * ChanServ sets mode +h aleth 16:56:25 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 13.0.1/20120614114901]) 17:06:54 <-- Even2 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 17:09:44 --> DGMurdockIII has joined #instantbird 17:10:42 * jwir3|away is now known as jwir3 17:28:38 --> wnayes has joined #instantbird 17:39:35 <clokep> Looks like some good stuff in the checkin-needed list. :) 17:59:32 <-- meh has quit (Ping timeout) 18:13:51 --> meh has joined #instantbird 18:17:43 <flo> hmm, what do we need to bonjour to work on mac? 18:19:39 <flo> *for Bonjour 18:23:01 <clokep> flo: The build bits. 18:23:13 <clokep> I assume Bonjour is installed and you get the "SDK" with xcode. 18:23:16 <flo> are you sure? 18:23:31 <flo> isn't the libpurple code depending on libavahi, rather than Bonjour? 18:23:34 <clokep> But Pidgin doesn't include a Makefile for Mac so...was hard to tell. :( 18:23:46 <clokep> flo: It uses libavahi on linux and Bonjour on Windows. 18:23:54 <clokep> I don't know what it would use on Mac actually. 18:23:56 <flo> or is the code for Windows likely to work on mac? 18:24:13 <clokep> I'd hope so. As long as it can find the proper headers. 18:24:18 <clokep> I didn't check if it's win32 specific or not though. 18:24:56 * clokep goes to check mac ports 18:25:23 <clokep> :( https://trac.macports.org/browser/trunk/dports/net/pidgin/Portfile seems to pass the --disable-avahi flag. 18:25:44 <clokep> Adium does something different for Bonjour btw (they don't use the libpurple code). Not sure what they do though. 18:27:38 <clokep> flo: Looks like the fink port uses avahi on mac too http://fink.cvs.sourceforge.net/fink/dists/10.4/stable/main/finkinfo/crypto/pidgin.info?view=markup 18:27:43 <flo> $ locate dns_sd.h 18:27:43 <flo> /Developer/SDKs/MacOSX10.4u.sdk/usr/include/dns_sd.h 18:27:44 <flo> /Developer/SDKs/MacOSX10.5.sdk/usr/include/dns_sd.h 18:27:45 <flo> /usr/include/dns_sd.h 18:27:48 <clokep> So...no I'm not sure it's just the build bits. :) 18:27:48 <flo> seems like it could work :) 18:27:56 <clokep> Ah, cool! 18:28:12 <flo> would need to avoid building the dns_sd_proxy.c file that's definitely win32 only 18:28:20 <flo> and maybe define LINK_DNS_SD_DIRECTLY 18:28:36 <flo> to avoid all the defines of dns_sd_proxy.h 18:29:57 <flo> seems like we would want to build mdns_win32.c on Mac too 18:30:02 <clokep> mdns_win32.c includes a reference to "Win32SessionImplData" which...sounds unlikely to exist on non-Windows. 18:30:09 <flo> that file should have been named mdns_bonjour.c then ;) 18:30:35 <clokep> :( Bah it's definitely win32 though. 18:30:49 <flo> it's defined at line 40 ;) 18:30:58 <clokep> Oh wait...yeah. 18:30:59 <clokep> Haha. :) 18:31:13 <flo> just after the comment "/* data used by win32 bonjour implementation */" 18:31:14 <flo> stupid naming... 18:31:40 <clokep> Yeah. I mean if Apple made their SDK properly, you should be able to run the same code on both Windows and Mac... 18:34:06 <flo> we can hope so :) 18:36:56 <clokep> :) 18:37:07 <flo> clokep: what is PURPLE_AVAHI used for in your patch? 18:37:27 <clokep> flo: It's possible it's left over from a previous iteration. 18:37:43 <flo> it seems so 18:38:35 <clokep> flo: Yes, it seems left over. 18:39:46 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:39:57 --> aleth has joined #instantbird 18:39:57 * ChanServ sets mode +h aleth 18:41:08 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1670 on bug 1540. 18:41:09 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1675 on bug 1540. 18:41:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1540 nor, --, ---, aletheia2, ASSI, Handle 432: Erroneous nickname 18:41:15 <flo> clokep: we can link that prpl into libpurple statically, right? :) 18:41:40 <clokep> flo: I think you asked for it not to be (in the case that Bonjour itself wasn't installed, which can definitely happen on Windows). 18:41:45 <clokep> I don't know what happens in this situation, mind you. :) 18:41:54 <flo> I asked that before reading the code 18:42:17 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:42:20 <flo> the whole point of dns_sd_proxy.{c,h} is to avoid failing in that case 18:42:21 --> aleth has joined #instantbird 18:42:21 * ChanServ sets mode +h aleth 18:42:51 <instantbot> New Core - General bug 1542 filed by clokep@gmail.com. 18:42:52 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1676 on bug 1542. 18:42:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1542 nor, --, ---, clokep, ASSI, Use pkg-config instead of hard coded paths 18:42:59 <clokep> Oh? Then yes, we should do it statically I think. 18:43:12 <flo> so how can I test? 18:43:17 <flo> (I've a connected bonjour account ;)) 18:44:16 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:44:19 --> aleth has joined #instantbird 18:44:19 * ChanServ sets mode +h aleth 18:44:28 <flo> clokep: have you tested the prpl? Do you know how it works? Is it adding buddies automatically? 18:44:45 <clokep> flo: I tested it between my two machines. I /believe/ it adds the buddies automatically. 18:44:51 <clokep> I can test again, let me spin up my remote session. 18:45:56 <clokep> flo: Yes it adds them automatically. 18:45:57 <flo> wow, it just works! 18:46:02 <flo> let's ship it! :) 18:46:09 <clokep> :) 18:46:15 <clokep> OK! 18:46:26 <flo> so I guess you need me to convert libpurple strings for it? :-/ 18:46:33 <flo> (we aren't string frozen yet, right? ;)) 18:46:33 <clokep> Yes, I do. :( 18:46:37 <clokep> Nope! 18:47:02 <flo> if I knew all I had to do was to change 2 lines to your makefile, I would have done it a long time ago :) 18:47:32 <flo> still r- for the left over variable in autoconf.mk.in though ;) 18:48:35 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:48:35 <flo> and I'm not even kidding when I say 2 lines :) 18:48:40 --> aleth has joined #instantbird 18:48:40 * ChanServ sets mode +h aleth 18:50:29 <clokep> I was hoping you had just removed that variable. :-D 18:50:39 <clokep> flo: Want to give me the two lines so I can give you a full patch? 18:51:09 <flo> of course! 18:51:18 <flo> I was commenting in the bug 18:51:29 <clokep> That works. :) 18:53:16 <flo> about building statically, I think we should consider it 18:53:18 <instantbot> florian@instantbird.org denied review for attachment 1674 on bug 944. 18:53:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, clokep, ASSI, Support for Bonjour 18:53:23 <flo> on mac and Windows it's very likely to work 18:53:37 <flo> (except we will need Even to install the bonjour sdk on the windows build slave) 18:53:54 <flo> on linux, I haven't read the code, so I don't know how it will behave is libavahi isn't on the system 18:54:49 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:54:54 --> aleth has joined #instantbird 18:54:54 * ChanServ sets mode +h aleth 18:55:26 <clokep> Right. 18:55:28 <flo> so I think it's quite unreasonable to add a prpl for 1.2 at this point, but I could find some use for Bonjour, so... :-] 18:55:37 <clokep> It's by default in Ubuntu. 18:55:47 * clokep looks the other way. 18:55:57 <flo> there are other non-ubuntu distributions though 18:56:02 <clokep> I know. 18:56:22 <clokep> Just giving a sample point. :) 18:58:22 <flo> I'm afraid it needs to be dynamically linked on Linux 18:58:41 <clokep> flo: No changes to configure.in? 18:58:44 <flo> you can check by renaming the library on your ubuntu, and see if Instantbird can still load libpurple 18:59:03 <flo> AC_SUBST(PURPLE_AVAHI) ... ;) 18:59:09 <flo> uh, broken auto-scroll again :( 18:59:33 <flo> what's PURPLE_AVAHI_HEADER= ? 19:00:14 <flo> are the ifs indented in other parts of the configure file? 19:00:41 <clokep> AC_SUBST(PURPLE_AVAHI)? Just to remove it? 19:00:49 <clokep> I think some ifdefs are and some aren't, but I'll check. 19:01:29 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 19:01:33 --> aleth has joined #instantbird 19:01:34 * ChanServ sets mode +h aleth 19:03:12 --> igorko has joined #instantbird 19:03:40 <clokep> ifs seem to be indented, yes. 19:06:51 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 19:06:54 --> aleth has joined #instantbird 19:06:55 * ChanServ sets mode +h aleth 19:10:54 <clokep> flo: These are my current changes: http://pastebin.instantbird.com/46986 do they look OK for Mac? 19:17:50 <-- skeledrew has quit (Ping timeout) 19:19:56 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 19:19:59 --> aleth has joined #instantbird 19:19:59 * ChanServ sets mode +h aleth 19:21:42 --> skeledrew has joined #instantbird 19:22:42 <-- Optimizer has quit (Ping timeout) 19:25:56 --> Optimizer has joined #instantbird 19:33:53 <clokep> flo: So you want me to try linking it statically on ubuntu and renaming libavahi then? 19:37:49 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 19:37:56 --> aleth has joined #instantbird 19:37:56 * ChanServ sets mode +h aleth 19:39:55 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 13.0.1/20120614114901]) 19:45:28 <-- igorko has quit (Connection reset by peer) 20:13:16 <-- FeuerFliege has quit (Ping timeout) 20:13:16 <-- FireFly_TB has quit (Ping timeout) 20:19:46 <flo> clokep: your configure changes will "AC_MSG_ERROR([Could not find avahi-client" on Mac 20:21:42 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 20:24:06 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 20:24:11 --> aleth has joined #instantbird 20:24:11 * ChanServ sets mode +h aleth 20:26:25 --> DGMurdockIII has joined #instantbird 20:50:36 <-- Optimizer has quit (Ping timeout) 20:53:55 --> Optimizer has joined #instantbird 21:04:07 <-- Bollebib has quit (Ping timeout) 21:04:24 --> igorko has joined #instantbird 21:10:58 <-- Optimizer has quit (Ping timeout) 21:14:19 --> Optimizer has joined #instantbird 21:17:51 <-- Optimizer has quit (Ping timeout) 21:21:24 --> Optimizer has joined #instantbird 21:34:13 <-- Optimizer has quit (Ping timeout) 21:37:33 --> Optimizer has joined #instantbird 21:44:19 --> Mic has joined #instantbird 21:44:19 * ChanServ sets mode +h Mic 21:45:16 <-- meh has quit (Ping timeout) 21:51:02 --> meh has joined #instantbird 21:51:36 <clokep> Right. :) The changes to the makefile wouldn't work either... 21:52:51 <flo> what's broken in the makefile? 21:53:28 <Optimizer> can you guys suggest me some laptop to buy ? 21:53:38 <clokep> I was missing an "if" after my 'end". ;) 21:53:39 <Optimizer> this is the only active channel :P 21:58:28 <flo> clokep: ah... 21:58:54 <flo> clokep: I assumed (mistakenly apparently :-D) that you tried it at least on your OS before pastebining 21:59:03 <flo> Optimizer: a macbook pro :-P 21:59:18 <Optimizer> no, 1400 usd budget at max 21:59:20 <Optimizer> :( 21:59:30 <flo> macbook air then :-P 21:59:32 <Optimizer> and i want a decent screen size 21:59:46 <Optimizer> macbook air 13 is 1800 iirc 21:59:59 <Optimizer> no apple for me 22:00:08 <flo> the website says "13-inch from $1,199.00" 22:00:12 <-- igorko has quit (Connection reset by peer) 22:00:39 <Optimizer> hmm 22:00:48 <Optimizer> that's config is not so good 22:00:54 <Optimizer> its* 22:01:07 <Optimizer> plus hdd space is low in airs 22:01:15 <flo> the macbook pro starts at $1,199.00 22:01:24 <flo> and the 15" is at $1,799.00 22:01:30 <clokep> Optimizer: I prefer Lenovo X or T series if you want Windows, Macbook Pros are really good quality too. 22:01:45 <clokep> Ah, 13" is too small? Forget the X series then. :) 22:01:49 <-- IRCMonkey49108 has quit (Ping timeout) 22:02:15 <Optimizer> th eproblem is lower range apple have very low config 22:02:16 <flo> clokep: I think he said the 11" macbook air is too small, 22:02:20 <Optimizer> like screen size and i3 22:02:35 <Optimizer> i want ivy i7 with 15" 22:03:26 <Optimizer> have you guys heard of samsung laptops ? 22:03:30 <Optimizer> 7 series 22:03:48 <-- aleth has quit (Input/output error) 22:03:58 --> aleth has joined #instantbird 22:03:58 * ChanServ sets mode +h aleth 22:04:16 * flo won't buy any laptop that isn't a macbook at this point 22:04:51 <flo> (and preferably not buy any laptop at all, if MoCo can provide me one :)) 22:06:06 <Optimizer> is macbook so good ? 22:07:17 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 22:07:21 --> aleth has joined #instantbird 22:07:22 * ChanServ sets mode +h aleth 22:07:39 <flo> Optimizer: it's addictive... 22:07:57 <Optimizer> due to Mac OS X or hardware itself ? 22:08:06 <flo> the hardware 22:08:21 <Optimizer> oh 22:08:23 <flo> Mac OS X is good. But Ubuntu too :). 22:08:31 <Optimizer> may be when i start earning big 22:08:56 <flo> I wouldn't consider a mac for a desktop machine though :). 22:10:22 <clokep> Yeah I have a few friends that only buy Macs now too. 22:10:49 * clokep is waiting for his static Bonjour Linux build to finish... 22:10:56 <clokep> Except that laptop is really old and takes forever to build. :( 22:11:09 <Optimizer> heh 22:11:22 <Optimizer> how is hp spectre ? 22:11:26 <Optimizer> any ideas ? 22:12:17 <clokep> HP is the one brand I recommend...no one ever buy. :) 22:14:04 <Optimizer> but the problem with hp is that the third generation laptops have 128 gig ssd, and normal configs, and the high config laptops have 2nd generation 22:14:07 <Optimizer> intel chips 22:15:22 <meh> if I had money, I'd buy a Dell Latitude E6420 XFR 22:15:37 <Optimizer> lemmi check 22:16:15 <Optimizer> its only tough and expensive 22:16:19 <Optimizer> meh! 22:16:28 <meh> yeah, the perfect laptop 22:16:37 <meh> it even has a handle! 22:16:48 <meh> now I only have a 3 years old Dell Latitude E6400 ATG 22:17:01 <Optimizer> who would carry such a heavy metal ! 22:17:21 <meh> me 22:17:29 <meh> this one is always with me 22:23:43 <flo> my macbook is almost 4 years old... :-S 22:28:46 <Optimizer> after all sorting , I am left with hp envy, samsung series 7 22:29:05 <Optimizer> the only thing left is to go to the market and find out what are my actual options 22:29:14 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 22:33:15 <instantbot> florian@instantbird.org granted review for attachment 1658 on bug 1046. 22:33:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1046 min, --, ---, nobody, NEW, Account window shows up on disconnect/reconnect 22:39:19 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1677 on bug 1538. 22:39:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1538 min, --, ---, aletheia2, ASSI, Don't reset nick at reconnect if the last nick change was user initiated 22:39:40 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1677 on bug 1538. 22:42:21 --> FeuerFliege has joined #instantbird 22:44:07 <-- FeuerFliege has quit (Ping timeout) 22:46:27 <clokep> Hmm...my static build failed, unable to find symbols... 22:48:14 <-- Optimizer has quit (Connection reset by peer) 22:50:04 <clokep> aleth: If you're going to do something like that...don't you really just need to store the acount nick, not the name parts whatever...? 22:50:33 <aleth> clokep: That was my question in the comment, if that would be better (since it never changes) 22:50:45 <clokep> Yes. 22:50:49 <clokep> It would simplify that code a lot. 22:51:24 <aleth> I think I agree with flo that it makes sense to reset the nick when manually disconnecting the account. 22:51:46 <clokep> Right, I don't disagree. 22:51:46 <flo> clokep: avahi symbols? 22:52:42 <flo> I'm trying to review the patch in bug 1496 22:52:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1496 nor, --, ---, clokep, ASSI, test_ctcpFormatToText and test_mIRCColor aren't executed 22:53:11 <clokep> flo: Do you have questions? 22:55:19 <clokep> flo: http://pastebin.instantbird.com/47015 are the errors, Ah it's whiel linking libpurple, all I changed was adding "bonjour" to http://lxr.instantbird.org/instantbird/source/config/autoconf.mk.in#18 22:58:16 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1677 on bug 1538. 22:58:17 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1678 on bug 1538. 22:58:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1538 min, --, ---, aletheia2, ASSI, Don't reset nick at reconnect if the last nick change was user initiated 22:59:07 <instantbot> florian@instantbird.org denied review for attachment 1586 on bug 1496. 22:59:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1496 nor, --, ---, clokep, ASSI, test_ctcpFormatToText and test_mIRCColor aren't executed 22:59:59 <flo> clokep: you need the EXTRA_LIBS += @AVAHI_LIBS@ bit in the libpurple Makefile if it's statically linked into libpurple 23:00:37 <clokep> flo: Ah, thank you. :) And I should remove it from the bonjour Makefile in that case? 23:00:59 <flo> I think it's irrelevant when creating a static library 23:01:07 <flo> but you probably need a test ;) 23:01:26 <flo> you don't want to add that bit to the libpurple makefile if bonjour is disabled or avahi isn't found on the system 23:02:18 <flo> clokep: but actually, if we need to link libpurple.so to avahi, we are adding a dependency on libavahi to load libpurple 23:02:34 <flo> so we already have the answer to what we were wondering: we shouldn't link statically into libpurple for Linux 23:02:52 <clokep> Right. :) 23:03:09 <flo> so you need to add a line in the package manifest with ifdefs to avoid windows and mac ;) 23:03:14 <clokep> Should we never link it statically then, or should I add an ifdef and link it statically for Mac / Windows? 23:03:35 <flo> ifdef! 23:03:51 <clokep> OK! And the reason to link it statically is...memory efficiency? 23:04:19 <flo> btw, STATIC_PRPLS shouldn't be hardcoded in autoconf.mk.in 23:04:24 <flo> it should be possible to configure that from configure ;) 23:04:44 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 23:04:52 <flo> clokep: faster startup, because of less disk I/O required to initialize libpurple 23:05:13 <clokep> flo: Can I consider that not part of this bug? :P 23:05:31 <flo> clokep: I was saying that to help you ;) 23:05:43 <flo> ie you can add bonjour to that list from configure, and AC_SUBST the result 23:05:46 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1678 on bug 1538. 23:05:47 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1679 on bug 1538. 23:05:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1538 min, --, ---, aletheia2, ASSI, Don't reset nick at reconnect if the last nick change was user initiated 23:06:27 <flo> clokep: adding command line flags to the configure script to configure which prpls are statically linked is definitely out of the scope of the bonjour bug :) 23:06:49 <clokep> You mean, make the list somewhere in configure.in, and inside the Darwin and WINNT ifdefs for Bonjour add bonjour into the list? 23:07:01 <flo> yeah 23:07:24 <clokep> Sounds reasonable. :) 23:07:25 <flo> autoconf.mk.in is really not a good place to hardcode default values 23:08:13 <flo> if we want to hardcode default configuration values, the correct place is http://lxr.instantbird.org/instantbird/source/instantbird/confvars.sh 23:09:25 <clokep> So the default values for this should go there or in configure.in? :) 23:10:57 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 23:11:03 --> aleth has joined #instantbird 23:11:03 * ChanServ sets mode +h aleth 23:11:43 <flo> clokep: ideally I think it should be in confvars.sh (and probably include bonjour), and configure should remove it for linux where it's not supported 23:12:06 <flo> clokep: but if you just move the current string to configure.in and += bonjour on non-linux, I will r+ anyway 23:12:21 <flo> as moving the default to confvars.sh is not really in the scope :) 23:12:25 <clokep> Hmmm....Windows has a bunch of EXTRA_LIBS also, those would need to be added to the libpurple library makefile? 23:13:04 <-- aleth has quit (Input/output error) 23:13:07 --> aleth has joined #instantbird 23:13:07 * ChanServ sets mode +h aleth 23:13:09 <flo> is $(PURPLE_BONJOUR_SDK)/lib/win32/dnssd.lib useful? 23:13:17 <flo> ie does the plugin build ok without that? 23:13:54 <flo> ws2_32.lib is already in libpurple's makefile 23:14:26 <clokep> Yes, I see that one. I do not think it builds w/o that no. 23:14:54 <flo> and I would be curious to see what Netapi32 is used for (can you build without it and pastebin the error messages so that we see the list of symbols imported from it? :)) 23:15:27 <flo> clokep: I would expect it to build without linking to dnssd.lib. If it doesn't we probably shouldn't link it statically to libpurple 23:16:09 <clokep> Yes, give me a few minutes please. :) 23:16:09 <flo> I would think the dnssd.lib in EXTRA_LIBS is required only if you define LINK_DNS_SD_DIRECTLY 23:16:25 <clokep> Oh? Maybe. I thought I ran into issues though. 23:16:26 <flo> which we did on Mac, but not windows afaik 23:17:58 <clokep> Right. OK I'll see what I can do. 23:32:03 <clokep> flo: http://pastebin.instantbird.com/47022 23:32:07 <clokep> That's without netapi. 23:32:42 <flo> and without the dnssd.lib? :) 23:33:06 <clokep> Building now... 23:34:24 <flo> clokep: these 3 functions appeared with Windows 2000, so it's ok to link to them, you can put the netapi in the libpurple makefile without worrying :) 23:34:29 <flo> thanks for checking :) 23:34:55 <clokep> flo: OK. :) Thanks for checking. I put it in an ifdef PURPLE_BONJOUR. 23:35:05 <clokep> SHould we attempt to check if we are actually statically linking it or is that OK? 23:35:24 <clokep> (And it built w/o linking to dnssd.lib btw...testing it in a moment) 23:35:35 <flo> cool 23:35:53 <flo> so checking that we are statically linking bonjour before linking to netapi would be better 23:36:16 <flo> but if you just want to do it all the time, that's OK with me, as long as you add a comment saying that it's for bonjour that netapi is required 23:36:16 <clokep> Any chance you could help me w/ that Make foo a bit then? Can I use a filter-out to do that? 23:37:08 <clokep> OK. 23:37:17 <clokep> Hmm...my build doesn't have prpl-bonjour when I open it. :-S 23:37:24 <flo> clokep: here is something for you: http://pastebin.instantbird.com/47023 23:37:36 <clokep> Not many strings! :) 23:37:38 <clokep> Thanks. 23:39:24 <flo> clokep: "Hmm...my build doesn't have prpl-bonjour when I open it. :-S" sounds like not what you wanted ;) 23:40:24 <clokep> Yes, doesn't sound like what I wanted at all. :P 23:40:52 <flo> can you look in static_proto_init.c to see if it includes the bonjour initialization? 23:41:03 <flo> if not, just rm it and re-run make in the libpurple folder :) 23:41:30 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 13.0.1/20120614114901]) 23:43:45 <clokep> It seems to iterate over STATIC_PRPLS http://lxr.instantbird.org/instantbird/source/purple/libpurple/Makefile.in#243 23:44:17 <flo> that doesn't answer my question 23:44:38 <clokep> There is no static_proto_init.c? 23:44:44 <flo> it's in the objdir 23:45:00 <clokep> Oh. 23:45:39 <clokep> It has extern gboolean purple_init_bonjour_plugin(); in it 23:45:41 <flo> it's some of the magic I did with the makefile to allow all prpls to be linked statically (even though libpurple hasn't supported that build configuration for years, if at all ;)) 23:45:48 <clokep> And purple_init_bonjour_plugin(); 23:46:09 <clokep> Ahh, I see. :) 23:46:14 <flo> could it be that you are missing a manifest? 23:46:23 <clokep> Possibly. 23:47:35 --> mmkmou has joined #instantbird 23:48:09 <flo> clokep: look in http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/prpl.manifest#1 23:49:07 <flo> this is where we declare the prpls that are statically linked into libpurple (and hence can't be discovered when registering XPCOM components) 23:49:28 <clokep> Ah, and that's not built off of STATIC_PRPLS? 23:49:29 <clokep> Lame. 23:49:32 <flo> it seems this file should be in purple/libpurple/ and you will need to preprocess it :( 23:49:35 <clokep> Yes that's the issue then. 23:50:04 <flo> clokep: "Ah, and that's not built off of STATIC_PRPLS?" unfortunately, it's the prpl ids, not the directory names 23:50:12 <flo> so you need a line for aim and one for icq, not an oscar line 23:50:43 <flo> but we should find a way to generate it automatically 23:50:47 <flo> it's not trivial though :-/ 23:50:55 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 23:51:53 <clokep> Ah, I see. :( 23:52:08 <flo> I think I see how we can automate it 23:52:21 <flo> but it will require some makefile hacking that's IMHO out of the scope for that bug 23:52:29 <clokep> I agree. 23:52:37 <clokep> We should file bugs on all this other stuff we've noticed though. :) 23:52:38 <flo> just add bonjour all the time for now 23:53:12 * clokep is slightly bothered by that file kind of being in alphabetical order but not really. 23:54:00 <flo> an, now I remember what I was trying to do! 23:54:20 <clokep> Sorry to sidetrack you. :( 23:54:26 <flo> ah, it's not easy :( 23:54:56 <flo> the issue I'm trying to fix is the fact that adding the bonjour prpl changed the orders of a few strings in most other .properties files 23:55:04 <flo> I really dislike that behavior 23:55:58 <flo> but the cause is that I'm using a single .pot file for the whole libpurple/ tree 23:55:58 <clokep> (o_O) That's interesting... 23:56:44 <flo> the strings are ordered (I think) by the order in which they appear in the source code 23:57:19 <instantbot> New Core - General bug 1543 filed by clokep@gmail.com. 23:57:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1543 min, --, ---, nobody, NEW, Automate creation of prpl.manifest 23:57:41 <clokep> Yeah, that sounds plausible. 23:57:45 <flo> so for example, if bonjour (starting with a "b" it's sorted before "oscar") uses strings that used to be needed only for oscar, now these strings will appear before in the oscar.properties file 23:58:38 <flo> yeah, that's what happens 23:58:46 <flo> that's silly 23:59:04 <flo> I should rewrite the convert script to order the strings independently for each .properties file