All times are UTC.
00:05:06 <-- aleth has quit (Input/output error) 00:15:22 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 â 1809)) 00:17:17 <clokep> wnayes: We can discuss tests at some point if you'd like. 00:17:18 --> SM0TVI has joined #instantbird 00:23:18 <-- myk has quit (Input/output error) 00:35:14 --> Suiseiseki has joined #instantbird 00:36:19 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 00:36:30 --> clokep has joined #instantbird 00:36:31 * ChanServ sets mode +o clokep 00:43:10 <wnayes> clokep: I was planning to start on some tests for Pidgin soon and see what anybody thought of them tomorrow or so (I have a couple ideas of what to try) 00:43:35 <clokep> wnayes: OK. :) 00:43:43 <clokep> If you can access the internal object for tests I think that's fine. 00:43:56 <clokep> (I.e. you don't have to /just/ go through the interface to test stuff out.) 00:48:16 <wnayes> I'll see what I can access from the tests (not too optimistic about non-interface exposed methods being available though) 00:48:53 <clokep> I might need to introduce you to wrappedJSObject. ;) 00:49:17 <clokep> But I'd say see what you can do! Check out tests in m-c and such, see how they do it, etc. 00:49:23 <clokep> And then we'll talk. :) 01:14:11 <-- Mook_as has quit (Quit: gone) 01:27:46 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 02:11:10 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 02:12:41 --> Tomek has joined #instantbird 02:20:01 <-- Tomek has quit (Quit: Instantbird 1.1) 02:20:06 --> Tomek has joined #instantbird 02:20:16 <-- Even has quit (Ping timeout) 02:21:16 --> Even has joined #instantbird 02:21:16 * ChanServ sets mode +o Even 02:27:52 <-- Tomek has quit (Quit: Instantbird 1.1) 03:00:40 <instant-buildbot> build #528 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/528 03:18:01 <instant-buildbot> build #517 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/517 03:41:52 --> Mook has joined #instantbird 04:00:24 <-- wnayes has quit (Ping timeout) 04:30:55 --> FireFly_TB has joined #instantbird 04:31:35 * jwir3 is now known as jwir3|away 05:04:17 <instant-buildbot> build #619 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/619 05:14:59 <-- FireFly_TB has quit (Ping timeout) 05:16:33 <-- Suiseiseki has quit (Ping timeout) 05:18:36 --> gerard-majax has joined #instantbird 05:21:43 --> FireFly_TB has joined #instantbird 05:23:08 --> Suiseiseki has joined #instantbird 05:32:25 <-- gerard-majax has quit (Ping timeout) 05:32:59 --> gerard-majax has joined #instantbird 05:35:21 <-- gerard-majax has quit (Ping timeout) 05:50:31 <Mook> boo, GenericAccountPrototype.getString will throw, instead of returning undefined or something, on missing strings 05:52:45 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603]) 05:55:12 --> FeuerFliege has joined #instantbird 06:24:35 --> Optimizer has joined #instantbird 07:19:11 --> gerard-majax has joined #instantbird 07:21:02 <-- gerard-majax has quit (Ping timeout) 07:31:17 --> gerard-majax has joined #instantbird 07:32:34 --> jb has joined #instantbird 07:47:32 --> sonny has joined #instantbird 07:53:25 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 07:53:32 --> Even has joined #instantbird 07:53:32 * ChanServ sets mode +o Even 07:53:37 <-- Even has quit (Quit: Even) 07:53:41 --> Even has joined #instantbird 07:53:41 * ChanServ sets mode +o Even 07:59:00 <-- jb has quit (Ping timeout) 08:07:39 --> jb has joined #instantbird 08:16:30 --> Even1 has joined #instantbird 08:16:40 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:16:51 --> Even1 has joined #instantbird 08:17:40 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:17:47 --> Even1 has joined #instantbird 08:32:25 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:32:35 --> Even1 has joined #instantbird 08:33:02 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:33:11 --> sonny has joined #instantbird 08:36:40 --> aleth has joined #instantbird 08:36:40 * ChanServ sets mode +h aleth 08:37:05 <-- aleth has quit (Input/output error) 08:37:16 --> aleth has joined #instantbird 08:37:16 * ChanServ sets mode +h aleth 08:59:17 <-- gerard-majax has quit (Ping timeout) 08:59:45 --> gerard-majax has joined #instantbird 09:00:05 --> flo has joined #instantbird 09:00:05 * ChanServ sets mode +qo flo flo 09:00:29 <flo> Good morning :) 09:01:04 <flo> aleth: http://i.imgur.com/EAbxf.png does this ruler seem centered? (I have the impression it's missing 1px of bottom margin) 09:02:14 <flo> and a closer look seems to confirm this 09:02:44 <aleth> :( 09:03:09 <aleth> Are we running into some strange OS-dependence here? 09:03:25 <aleth> That's not what it looks like for me. 09:04:38 <flo> it may be more or less visible depending on the color of the bubble borders 09:05:21 <flo> or do system messages have a different shadow? 09:06:07 <aleth> That's possible, that it's the fact that it's after a system message that is causing the effect 09:06:19 <aleth> This is what it looks like for me (not after a system message) http://i.imgur.com/TKjQs.png 09:07:11 <flo> aleth: the pixel count is the same on your screenshot 09:07:32 <flo> the difference may be only in the way the eyes perceive the shadow when it's of the same color as the border 09:08:11 <flo> I'm not too worried about this anyway, it's just a tiny (1px!) detail :) 09:08:18 <aleth> That sounds reasonable 09:08:39 <flo> and I think I noticed only because I'm paying attention to that ruler, as I know we changed it recently 09:08:41 <aleth> I would have been really surprised if the pixel counts differed. 09:08:55 <flo> I would be surprised if any real user complained because of this :) 09:08:58 <aleth> I was thinking more along the lines of the box-shadow gradient differing... 09:09:32 <aleth> But you're right, it looks to be an optical effect. http://i.imgur.com/oDwFE.png 09:09:34 <flo> the shadow seems the same 09:09:39 <aleth> That matches your screenshot I think 09:10:34 <aleth> Though it looks less pronounced somehow. 09:17:49 <-- skeledrew has quit (Ping timeout) 09:17:58 <aleth> This pretty much explains it I think http://i.imgur.com/D98SS.png 09:18:29 <aleth> On OSX, at least in that particular situation, the system message bubble border merges with the background much more 09:19:22 <flo> yeah 09:21:10 --> mmkmou has joined #instantbird 09:24:03 --> Tomek has joined #instantbird 09:28:24 <-- mmkmou has quit (Ping timeout) 09:31:43 --> mmkmou has joined #instantbird 09:32:37 <aleth> Does it look OK to you otherwise? With the narrower margin above/below the ruler than before... 09:38:30 <flo> aleth: it's a clear improvement compared to before :) 09:44:45 <-- gerard-majax has quit (Ping timeout) 09:48:42 <flo> I don't see any code calling http://lxr.instantbird.org/instantbird/source/instantbird/modules/ibCore.jsm#180 09:50:55 <flo> ah, we observe "quit-application-granted" and clean up the chat core/ automatically 09:51:10 <flo> http://lxr.instantbird.org/instantbird/source/instantbird/modules/ibCore.jsm#180 is just dead code then 09:51:56 <flo> is anybody interested in double checking, and r+ing the removal? 09:53:46 <flo> the removal = http://pastebin.instantbird.com/45573 09:57:03 <aleth> I can't find anything calling it either, so r+ from me I guess :) 10:01:07 --> clokep has joined #instantbird 10:01:08 * ChanServ sets mode +o clokep 10:01:53 <-- Tomek has quit (Quit: Instantbird 1.1) 10:02:48 --> gerard-majax has joined #instantbird 10:12:20 <-- clokep has quit (Ping timeout) 10:12:48 --> clokep has joined #instantbird 10:12:48 * ChanServ sets mode +o clokep 10:15:21 --> pvagner has joined #instantbird 10:15:33 <clokep> I've been having a lot of trouble with getting stuck with an idle status recently. :( 10:17:55 <flo> Even1: ^^ 10:18:56 <-- gerard-majax has quit (Ping timeout) 10:19:13 --> gerard-majax has joined #instantbird 10:21:06 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 10:26:23 <clokep> Sounds like they should have Mercurial pidgin up today. 10:28:24 <flo> I'm looking at that facebook chat bug 10:30:55 <-- gerard-majax has quit (Ping timeout) 10:31:35 --> gerard-majax has joined #instantbird 10:39:37 <-- wesj has quit (Ping timeout) 10:42:57 --> wesj has joined #instantbird 10:45:54 <flo> the fix for bug 1203 is just http://pastebin.instantbird.com/45576 10:45:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1203 maj, --, ---, florian, ASSI, No longer able to log into Facebook Chat via Instantbird since patches enabling JS XMPP 10:46:04 <flo> well, if we want to just match what libpurple does 10:46:20 <flo> I would like to know where this is specified though 10:46:35 <flo> to see if we should also make the username lowercase for the PLAIN auth method 10:47:26 <flo> note: debugging this while being able to compare libpurple vs js-xmpp was super easy. Guessing the issue would otherwise have been very hard :-) 10:48:01 <clokep> Weird... 10:49:42 <clokep> This implies it: http://xmpp.org/extensions/xep-0078.html#usecases-auth maybe, but not sure what type of auth that is. 10:50:16 <clokep> The other question is, is that a real XMPP thing or just a stupid Facebook thing? 10:50:46 <flo> yeah... I would like to understand the situation before checking in a random change 10:50:55 <flo> but that very clearly fixes the bug (ie I can connect the account after changing that) 10:51:59 <clokep> :) 10:52:37 --> meh has joined #instantbird 10:53:14 <clokep> Maybe see what revision that line was changed at? 10:53:26 <flo> which line? 10:54:21 <clokep> The one in libpurple 10:54:33 <clokep> If it was fixed after the fact, there might be a bug report? 10:55:47 <flo> http://tools.ietf.org/html/rfc6120 section 6.3.7 "an XMPP client SHOULD assume that the authentication identity for such a SASL mechanism is a simple user name equal to the localpart of the user's JID." 10:56:29 <flo> I would like to find where libpurple converts the string to lowercase first :) 10:57:12 <aleth> Is there an official xmpp channel in which you could ask? 10:58:57 <flo> http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/jabber/jutil.c#423 10:59:10 <flo> there's a comment above: /* JID is made of only ASCII characters--just lowercase and return */ 10:59:59 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:00:24 <aleth> http://www.ietf.org/rfc/rfc3920.txt "A node identifier MUST be formatted such that the Nodeprep profile of [STRINGPREP] can be applied to it without failing. Before comparing two node identifiers, a server MUST (and a client SHOULD) first apply the Nodeprep profile to each identifier." 11:00:24 <aleth> ftp://ftp.isi.edu/in-notes/rfc3454.txt "These tables map from uppercase to lowercase characters." 11:00:58 <aleth> ^^ just from google, not sure if still current 11:08:33 <flo> "Nodeprep will case fold to lowercase for US-ASCII characters such as A, C, E, and F." in http://xmpp.org/extensions/xep-0106.html 11:11:32 <flo> so it seems in http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#840 we need to make at least the node and the domain lowercase 11:23:23 --> Andrey has joined #instantbird 11:26:00 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1603 on bug 1203. 11:26:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1203 maj, --, ---, florian, ASSI, No longer able to log into Facebook Chat via Instantbird since patches enabling JS XMPP 11:28:06 <flo> our _normalizeJID method (just above: http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#833) was already calling toLowerCase ^^ 11:36:01 <-- gerard-majax has quit (Ping timeout) 11:41:27 --> clokep_work has joined #instantbird 11:41:27 * ChanServ sets mode +o clokep_work 11:47:06 <clokep_work> flo: Is it me or do you not do anything w/ the JID after calculating it? 11:47:58 <clokep_work> I think you forgot a result.jid = jid? 11:49:41 <-- sonny has quit (Ping timeout) 11:50:35 <-- Optimizer has quit (Ping timeout) 11:52:31 --> gerard-majax has joined #instantbird 11:54:04 --> sonny has joined #instantbird 11:54:15 --> Optimizer has joined #instantbird 12:11:01 --> jb1 has joined #instantbird 12:11:35 <-- gerard-majax has quit (Ping timeout) 12:11:44 <-- jb has quit (Ping timeout) 12:12:41 <flo> clokep_work: right 12:12:53 <flo> it's surprisingly hard to write that trivial patch 12:13:16 <flo> I changed it twice already because in some places I wrote resource.<property name> instead of result (and that caused JS errors of course) 12:13:49 --> gerard-majax has joined #instantbird 12:15:39 <instantbot> florian@instantbird.org cancelled review?(clokep@gmail.com) for attachment 1603 on bug 1203. 12:15:40 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1604 on bug 1203. 12:15:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1203 maj, --, ---, florian, ASSI, No longer able to log into Facebook Chat via Instantbird since patches enabling JS XMPP 12:19:43 <instantbot> clokep@gmail.com granted review for attachment 1604 on bug 1203. 12:19:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1203 maj, --, ---, florian, ASSI, No longer able to log into Facebook Chat via Instantbird since patches enabling JS XMPP 12:19:52 * clokep_work was tempted to ask for a comment above the parseJID method describing what it does. ;) 12:21:04 <-- Andrey has quit (Quit: ) 12:25:37 <clokep_work> Another blog comment: http://blog.instantbird.org/2012/05/status-update-may-23-2012/comment-page-1/#comment-1634 12:28:52 --> Even1 has joined #instantbird 12:29:08 <-- gerard-majax has quit (Ping timeout) 12:29:25 --> gerard-majax has joined #instantbird 12:30:29 <flo> would be nice to support SIP voice calls 12:30:38 <flo> even more useful than XMPP ;) 12:30:52 <flo> s/XMPP/XMPP voice calls/ 12:31:23 <-- gerard-majax has quit (Ping timeout) 12:31:57 --> gerard-majax has joined #instantbird 12:35:17 <-- Suiseiseki has quit (Ping timeout) 12:36:37 <clokep_work> Yeah. Does libpurple even support that? 12:36:47 <flo> no 12:36:56 <flo> but that's not really relelvant 12:37:52 <flo> my ISP (free.fr) offers an SIP account to all its customers, with free calls to landing lines in 80 countries. That's potentially very useful, and could deprecate physical phones ;) 12:39:07 <aleth> I wonder if there is some b2g library being written supporting that (for use over wifi) 12:39:51 <clokep_work> That's quite possible. 12:40:03 <clokep_work> I think SIP/SIMPLE is actually a fairly simple (ah-ha!) protocol, and documented. 12:40:07 <flo> there are interesting things in the WebRTC project 12:40:10 <clokep_work> So it would be a good candidate for uplift I think. 12:40:13 --> Suiseiseki has joined #instantbird 12:44:08 <-- gerard-majax has quit (Ping timeout) 12:45:36 --> gerard-majax has joined #instantbird 12:47:58 <aleth> Currently the WebTelephony API does not support SIP 12:48:13 <clokep_work> What does it support? :P 12:48:38 <flo> crashing? :) 12:49:27 <aleth> It supports the phone's radio... 12:49:55 <aleth> (if you have the right phone, I guess) 12:51:07 <clokep_work> Ah, so it supports like actual phone calls. 12:51:12 <aleth> Yes. 12:51:32 <aleth> Then there's WebSMS for text messages... 12:52:33 <clokep_work> Interesting. 12:52:44 <clokep_work> But that still uses the phone system backbone, right? 12:52:56 <aleth> Yes, it only runs on a phone atm 12:59:51 <flo> aleth: should I check-in https://bugzilla.instantbird.org/attachment.cgi?id=1601 ? 13:01:35 <aleth> It's definitely better than the status quo, so I'd prefer it... Not sure what clokep_work and Mic think of it though 13:01:59 <aleth> I suppose we could always add back the underline later if need be 13:02:32 <flo> or say we will do it after a week or two to see if it still annoy people then, and eventually forget to do it :-P 13:02:46 <flo> I don't remember for which bug I used that strategy 13:03:02 <aleth> The only way to really test these kind of small changes is to use them for a while... 13:03:45 <flo> should I mark all the other attachments as obsolete? 13:04:17 <aleth> I'd keep the screenshots. 13:04:25 <instantbot> florian@instantbird.org granted review for attachment 1601 on bug 1505. 13:04:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1505 enh, --, 1.2, aletheia2, RESO FIXED, [Bubbles] Change link color in system messages 13:06:09 <flo> another patch that doesn't apply, yay :-/ 13:06:55 <aleth> huh, that one wasn't edited by hand 13:07:56 * flo gives up fixing it, and applies the patch by hand 13:07:57 <-- mmkmou has quit (Ping timeout) 13:07:57 <clokep_work> aleth: The paths are wrong. 13:08:07 <clokep_work> flo: I have a macro to replace aleth's paths... 13:08:25 <flo> clokep_work: I used cd instantbird/themes && patch -p6 and that works well 13:08:51 <flo> the problem is, the patch is based on a revision that obviously isn't the one we checked into our repository ;) 13:09:02 <-- jb1 has quit (Ping timeout) 13:09:04 <clokep_work> Ah-ha. 13:09:12 --> Lalae has joined #instantbird 13:09:14 <clokep_work> Easy enough to hand edit that one though. :-D 13:09:23 <aleth> Ah, I see :( Sorry. 13:09:29 <-- Lalae has left #instantbird () 13:09:40 <aleth> It's because we changed 40 -> 30 before landing in the previous patch 13:09:49 <flo> ahah, it applied! :) 13:10:34 <flo> there's also something wrong with the empty line before |p.event a:hover| 13:11:15 <aleth> There seem to be occasional whitespace mismatches between git and hg where I wish I knew the option to set to make it go away 13:11:23 <flo> the correct patch is http://pastebin.instantbird.com/45584 13:11:45 <flo> aleth: your patches also have the trailing white space removed, which makes editing them with emacs difficult 13:12:02 <flo> the context lines should all start with a space 13:12:03 --> mmkmou has joined #instantbird 13:12:07 <aleth> Yes. 13:12:12 <flo> and the empty context lines in your patch are just empty 13:12:17 * aleth goes check his git config 13:12:18 <flo> so emacs can't recount the lines correctly 13:12:25 <aleth> OK, thanks 13:13:03 <clokep_work> aleth: I know there's a bunch of options for whitespace in git. 13:13:22 <clokep_work> (I find the most annoying one the default that tries to check out in your local line ending and always commit unix line endings...) 13:13:27 <aleth> clokep_work: Yes, it's a bit confusing (to me at least)... I am just using the defaults 13:13:54 <clokep_work> For that one, I would suggest using the one that keeps them as is. 13:16:47 <-- meh has quit (Ping timeout) 13:18:51 * flo still dislikes the patches from bug 1096 13:18:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1096 nor, --, ---, aletheia2, ASSI, Add "Visible tags..." entry to contacts listbox background context menu too 13:21:02 <aleth> You never said why though... 13:21:36 <aleth> It helps people like https://bugzilla.instantbird.org/show_bug.cgi?id=1096#c3 13:21:41 <instantbot> Bug 1096 nor, --, ---, aletheia2, ASSI, Add "Visible tags..." entry to contacts listbox background context menu too 13:23:48 <flo> aleth: I don't really know 13:24:03 <flo> I just have a feeling that this patch will cause one or more follow ups ;) 13:24:15 <aleth> That's OK with me ;) 13:25:00 <flo> what happens if there's no account? 13:27:49 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e209b56ace45 - aleth - Bug 1505 - [Bubbles] Change link color in system messages - make links visible only when hovered, r=fqueze. 13:27:50 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/384f68e4381d - Florian Quèze - Remove dead code in the ibCore.jsm (the uninit method was never called), r=aleth over IRC. 13:27:51 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/fd5e9bf51bf6 - Florian Quèze - Bug 1203 - Fix logging in to Facebook Chat when the username contains uppercase letters, r=clokep. 13:27:52 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8db9777d814b - aleth - Bug 1507 - Target selector not disabled when there is only one account to select from, r=clokep. 13:28:14 <instantbot> florian@instantbird.org set the Resolution field on bug 1203 to FIXED. 13:28:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1203 maj, --, 1.2, florian, RESO FIXED, No longer able to log into Facebook Chat via Instantbird since patches enabling JS XMPP 13:29:26 <aleth> you mean, if there are no tags? 13:29:32 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 13:29:40 <flo> aleth: right 13:29:47 <flo> and no buddy, nothing 13:30:38 <instantbot> clokep@gmail.com set the Resolution field on bug 1507 to FIXED. 13:30:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1507 min, --, 1.2, aletheia2, RESO FIXED, Target selector not disabled when there is only one account to select from 13:30:57 <aleth> The visible tags list will be empty. Whether that causes errors I don't know. 13:31:49 <aleth> I'm not sure I tested that, it's too long ago. 13:32:00 <clokep_work> I didn't test that. 13:34:15 <flo> also, is https://bugzilla.instantbird.org/attachment.cgi?id=1188&action=diff just trying to avoid the context menu for the section headers? Wouldn't it be easier to just add a check in the context menu code, and shouldDisplay = false? 13:34:55 <aleth> Is that easier? 13:35:14 <flo> maybe... 13:35:17 <flo> it avoids duplication 13:35:49 <clokep_work> I thought this way was cleaner, but I guess it does have some duplication, yeah. 13:37:02 <aleth> The no-accounts case should definitely tested, so I might as well change that too 13:37:15 <aleth> as I have to apply the patches again anyway... 13:37:25 <flo> yeah 13:37:35 <flo> or wait for me to test it and figure out why I dislike it :-D 13:38:37 <flo> no account is really "no tag with visible contacts" 13:38:46 <flo> ie completely empty list 13:38:51 <aleth> Yes 13:48:34 <clokep_work> Btw I got Bonjour working with pkg-config last night: https://bitbucket.org/clokep/instantbird-patches/src/44c2b63083bc/pkg-config 13:50:51 <instantbot> New Instantbird (UI) bug 1512 filed by aletheia2@fastmail.fm. 13:50:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1512 min, --, ---, nobody, NEW, Provide visual feedback when selecting a tag to be "visible" that contains no online buddies 13:54:43 <clokep_work> Is that actually confusing or just possibly? 13:54:56 <aleth> I don't know, I'm not a new user... 13:55:42 <aleth> I just spun it out from a concern that fl o noted in the context menu bug 13:55:47 <flo> the new users, the blank windows are confusing 13:55:54 --> jb has joined #instantbird 13:55:59 <flo> *for new users 13:56:15 <aleth> The bug I just filed is more about users-new-to-tags 13:58:34 <-- pvagner has quit (Ping timeout) 13:59:28 <-- Optimizer has quit (Ping timeout) 14:04:06 <aleth> Should there be a message instead of a blank contact list? "No buddies are online" or "No buddies have been added yet"... 14:07:36 <-- jb has quit (Ping timeout) 14:13:07 <flo> probably 14:13:34 <flo> bug 611 I think 14:13:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=611 enh, --, ---, nobody, NEW, Handle the "blank slate" gracefully 14:13:38 --> jb has joined #instantbird 14:13:46 <aleth> Ah, it's already filed :) 14:17:49 <aleth> Well, now I have seen what an empty context menu looks like :P 14:18:32 <aleth> There is no context menu, but there is a spot of shadow... 14:25:20 <flo> I forgot to warn that it was bugspam day ;) 14:25:33 <clokep_work> I noticed. :P 14:25:47 * clokep_work wonders if syncing of chat/ to c-c/ is necessary again soon. 14:25:59 <flo> it is 14:26:23 <flo> I'll work on porting the accessibility fixes I checked in for Tb too 14:28:10 * clokep_work wonders how hard bug 1231 is... 14:28:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1231 nor, --, ---, nobody, NEW, 'Display Formatting of incoming messages', not implemented in JS-XMPP 14:28:41 <flo> the "find motivation" part is the difficult one 14:29:47 <clokep_work> Is formatting in XMPP just sent as HTML? 14:29:58 <flo> yes 14:30:01 <flo> it's a subset of XHTML 14:30:45 * clokep_work would have expected it to work already then... 14:36:18 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1605 on bug 1262. 14:36:22 * flo would like a quick review to commit and forget that patch :) 14:36:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1262 nor, --, ---, florian, NEW, [Accessibility] Make (default?) messagestyle themes accessible 14:36:38 <flo> aah, bugspam day continues :) 14:36:45 <flo> all approval-aurora requests granted :) 14:36:55 <-- gerard-majax has quit (Ping timeout) 14:37:40 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1606 on bug 1096. 14:37:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1096 nor, --, ---, aletheia2, ASSI, Add "Visible tags..." entry to contacts listbox background context menu too 14:38:17 --> mmkmou has joined #instantbird 14:39:09 --> gerard-majax has joined #instantbird 14:39:13 <instantbot> clokep@gmail.com granted review for attachment 1605 on bug 1262. 14:39:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1262 nor, --, ---, florian, NEW, [Accessibility] Make (default?) messagestyle themes accessible 14:40:59 --> meh has joined #instantbird 14:41:53 <flo> clokep_work: I could have checked in that specific part to instantbird without additional review 14:42:14 <flo> but I still wanted an r+ for the other parts, so I included all the accessibility changes in the same attachment 14:42:17 <flo> thanks for the review! m) 14:42:19 <flo> *:) 14:53:07 <-- gerard-majax has quit (Ping timeout) 14:53:39 --> gerard-majax has joined #instantbird 14:55:04 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1597 on bug 1505. 14:55:05 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1595 on bug 1505. 14:55:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1505 enh, --, 1.2, aletheia2, RESO FIXED, [Bubbles] Change link color in system messages 14:58:06 --> Optimizer has joined #instantbird 15:01:01 <clokep_work> flo: Yes, I figured that. I just thought I had seen it fly past at some point. :) 15:10:05 <-- gerard-majax has quit (Ping timeout) 15:15:16 <clokep_work> The review queue isn't totally insane anymore. :) 15:18:54 <flo> https://bugzilla.mozilla.org/attachment.cgi?id=633105&action=diff :-S 15:21:17 <-- devfil has quit (Client exited) 15:22:39 <clokep_work> flo: My favorite part is the percent encoding of the map of params. ;) 15:22:46 <clokep_work> (Which are already percent encoded) 15:23:03 --> devfil has joined #instantbird 15:23:06 <flo> mine was the encoding of the aMethod 15:23:19 <flo> % encoding the string "GET" or "POST"... seriously? ;) 15:23:51 <clokep_work> r- it! 15:24:10 <flo> it won't get r+ (it breaks at least dropbox) 15:24:44 <clokep_work> Do we have a different oauth.jsm in chat/ now, or is it the same? 15:24:58 <flo> we have twitter.js ;) 15:25:04 <clokep_work> Ah-ha, right. :) 15:28:08 <clokep_work> Probably will need to be split out at some point though if we need it for Facebook/WLM stuff. 15:29:55 <flo> sure 15:31:03 <clokep_work> (I.e. it'd be nice to just use the same file as them. :P) 15:31:10 * clokep_work shuts up and stops speculating. 15:31:14 <flo> not if they keep breakingit ;) 15:31:37 <-- Optimizer has quit (Ping timeout) 15:33:04 * flo wants unit tests for that crappy oauth thing :( 15:33:57 --> Optimizer has joined #instantbird 15:35:13 <clokep_work> Is there a test suite for it? 15:35:19 <clokep_work> Ah Adium sources are up on pidgin.im: http://hg.pidgin.im/dev/adium/adium/ 15:35:20 <flo> I don't know 15:39:00 --> igorko has joined #instantbird 15:53:43 <clokep_work> There's http://wiki.oauth.net/w/page/12238556/TestCases ... but not realy a full suite. 15:57:06 <flo> that patch isn't so stupid actually 15:57:32 <flo> it's close to what's described in https://dev.twitter.com/docs/auth/creating-signature in "Creating the signature base string" 15:58:32 <clokep_work> Still doesn't need to percent encode the method. 15:58:37 <flo> yeah 15:58:47 <clokep_work> And seems like we should be percent encoding the params after joining them? 15:58:52 <flo> and should probably remove the percentEncode at line http://mxr.mozilla.org/comm-central/source/mail/base/modules/oauth.jsm#113 16:00:04 <clokep_work> Right...which...do you even need to do half those things on that line then? Probably not... 16:00:22 <flo> I don't really see how the patch produces a different result though 16:00:36 <flo> except on how the urlSpec string is treated 16:00:46 <flo> but I don't think they put ( ) characters in there 16:01:36 <clokep_work> They should be escaped already I would imagine. 16:01:51 <flo> we remove everything that's after the "?" in that string 16:02:30 <flo> so I don't see why they would have () characters in the URL 16:05:40 <-- Optimizer has quit (Ping timeout) 16:07:49 --> Optimizer has joined #instantbird 16:08:50 <clokep_work> Do we have a release checklist? 16:09:01 * clokep_work realizes we need to update the list of contributors, most likely. 16:09:33 <flo> https://wiki.instantbird.org/Instantbird:release_process 16:13:03 --> myk has joined #instantbird 16:19:54 <-- jb has quit (Ping timeout) 16:49:49 <-- myk has quit (Ping timeout) 16:54:02 --> Even2 has joined #instantbird 16:55:00 <-- meh has quit (Ping timeout) 16:57:18 <-- FireFly_TB has quit (Ping timeout) 16:57:18 <-- FeuerFliege has quit (Ping timeout) 16:59:22 --> Mnyromyr has joined #instantbird 17:05:00 --> Mook_as has joined #instantbird 17:14:22 --> meh has joined #instantbird 17:20:11 --> myk has joined #instantbird 17:20:42 --> Tomek has joined #instantbird 17:20:58 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 17:21:07 --> myk has joined #instantbird 17:21:37 <-- myk has quit (Input/output error) 17:21:42 --> myk has joined #instantbird 18:00:40 --> gerard-majax has joined #instantbird 18:07:15 <-- Kaishi has quit (Quit: Kaishi) 18:09:29 --> FeuerFliege has joined #instantbird 18:09:59 --> FireFly_TB has joined #instantbird 18:11:38 <-- FireFly_TB has quit (Quit: FireFly_TB) 18:19:02 <-- Mook_as has quit (Quit: Mook_as) 18:19:26 --> Mook_as has joined #instantbird 18:32:56 --> FireFly_TB has joined #instantbird 18:35:45 --> wnayes has joined #instantbird 18:40:17 <-- Gizmokid2005 has quit (Ping timeout) 18:41:56 --> Gizmokid2005 has joined #instantbird 18:51:08 <-- FireFly_TB has quit (Quit: FireFly_TB) 18:51:17 --> TestFliege has joined #instantbird 18:51:21 <-- TestFliege has quit (Quit: TestFliege) 18:54:19 <-- Tomek has quit (Quit: Instantbird 1.1) 19:02:42 --> FireFly_TB has joined #instantbird 19:13:59 <-- Gizmokid2005 has quit (Ping timeout) 19:15:56 --> Gizmokid2005 has joined #instantbird 19:16:40 <wnayes> I wrote up something on a couple of xpcshell test issues I'm having. If someone has any suggestions or fixes, they would be appreciated: https://etherpad.mozilla.org/3PMlo5lMor 19:19:02 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 19:22:37 <-- sonny has quit (Ping timeout) 19:26:42 --> sonny has joined #instantbird 19:37:56 --> dietrich has joined #instantbird 19:38:21 <dietrich> flo: heyo. is the demo limi just did something i can install now? 19:38:36 <flo> dietrich: it's a try server build 19:38:48 <dietrich> ah ok, so not add-on 19:38:51 <flo> dietrich: you could test it, but I'm pretty sure you wouldn't want to use it right now 19:38:56 <dietrich> hehe 19:39:07 <flo> (can only open one conversation at once ;)) 19:39:12 <dietrich> it looks great so far, nice work 19:39:29 <flo> it could look way better if I had had more time to spend on it 19:40:07 <dietrich> he said you created a pure-js equivalent of libpurple?! 19:40:29 <flo> dietrich: well, it's the same back-end shared between Instantbird, Thunderbird, and the Firefox demo 19:40:46 <flo> dietrich: we have XMPP (so Google Talk and Facebook chat), IRC and Twitter in JS 19:41:16 <dietrich> cool 19:41:16 <flo> and Instantbird has libpurple wrapped in a C++ xpcom component for the other legacy protocols, but I can't ship it in Tb/Fx as libpurple is GPL'ed 19:41:17 <instantbot> c++ sucks 19:41:29 <dietrich> instantbot++ 19:41:39 <flo> We have plans to ship libpurple and its xpcom component in an add-on though 19:41:45 <dietrich> ah interesting 19:41:51 <-- Gizmokid2005 has quit (Ping timeout) 19:41:52 <flo> (it's just a packaging change, compared to what we have for Instantbird already ;)) 19:42:23 <flo> and the airmozilla stream totally sucks over here, so I'll probably miss the Junior/iPad demo (although I admit it isn't the one I was the most interested in) 19:43:52 <dietrich> it's interesting. content-focus is very good. minimalist controls w/o major functionality loss. 19:43:56 --> Gizmokid2005 has joined #instantbird 19:43:58 <dietrich> (for casual browsing, that is) 19:51:36 <clokep_work> flo: Is this the thing we talked about a few weeks ago? Was there a demo or code I missed somewhere? :P 19:51:57 <flo> clokep_work: were you looking at air mozilla? 19:52:11 <clokep_work> flo: I've been in the lab for the last bit of today. 19:53:34 * aleth couldn't get the stream to work properly 19:54:32 <flo> aleth: yeah, it's terrible :( 19:54:46 <flo> aleth: were you trying the flash version (which is completely down) or the webm version? 19:55:08 <aleth> I tried flash, and then something which wanted to use RTSP, then gave up 19:56:07 <clokep_work> wnayes: Did you add http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#71? 19:57:05 <clokep_work> "rtsp" WTF program opens that? 19:57:36 <aleth> Exactly. I /think/ it's an ancient realplayer format? 19:58:12 <wnayes> clokep_work: In the constructor of pidginImporter. I can access the functions I want from the importer, but errors happen when the importer tries .getService() calls, etc. 19:58:14 <clokep_work> Did we ever decide whether they post those anywhere after the fact? :) 19:59:31 <flo> aleth: I would try vlc for strange video formats ;) 19:59:43 <aleth> flo: Yes, that's what I used ;) 20:00:07 <aleth> Just got some stuttering though 20:00:43 <clokep_work> :( 20:05:40 <clokep_work> I've always found the UX around AIr Mozilla to be god awful. 20:05:44 <clokep_work> Which is why I totally ignore it. 20:06:38 <-- gerard-majax has quit (Ping timeout) 20:07:56 <-- Gizmokid2005 has quit (Ping timeout) 20:10:26 --> Gizmokid2005 has joined #instantbird 20:14:51 --> DGMurdockIII has joined #instantbird 20:20:24 <-- Gizmokid2005 has quit (Ping timeout) 20:22:27 --> Gizmokid2005 has joined #instantbird 20:25:15 <-- Gizmokid2005 has quit (Ping timeout) 20:29:26 --> Gizmokid2005 has joined #instantbird 20:32:08 <-- Gizmokid2005 has quit (Ping timeout) 20:34:26 --> Gizmokid2005 has joined #instantbird 20:53:40 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 20:54:35 <-- Gizmokid2005 has quit (Ping timeout) 20:56:26 --> Gizmokid2005 has joined #instantbird 20:58:14 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d4015a1d51f1 - Florian Quèze - Bug 1262 - [Accessibility] Add aria attributes to conversation views and contact groups, r=clokep. 21:05:19 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org) 21:07:56 <-- Optimizer has quit (Ping timeout) 21:11:08 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 21:11:27 --> Optimizer has joined #instantbird 21:25:11 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 21:35:14 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1607 on bug 1460. 21:35:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1460 min, --, ---, aletheia2, ASSI, Do not send blank lines / empty messages 21:50:48 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 21:58:31 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1608 on bug 1498. 21:58:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1498 nor, --, ---, aletheia2, ASSI, "this.buddy is undefined" on merging two IRC buddies 22:02:51 <-- FeuerFliege has quit (Ping timeout) 22:03:08 <-- FireFly_TB has quit (Ping timeout) 22:04:47 --> jb has joined #instantbird 22:05:15 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 22:11:24 --> FireFly_TB has joined #instantbird 22:17:52 <-- jb has quit (Ping timeout) 22:25:17 --> flo has joined #instantbird 22:25:17 * ChanServ sets mode +qo flo flo 22:25:23 <flo> wnayes: has anybody helped you yet with your tests? 22:26:13 <flo> clokep: this is confusing: http://i.imgur.com/rgtZJ.png 22:26:40 <wnayes> flo: No, I've been trying different ideas but I'm basically stumped at this point. :( 22:28:09 <flo> ok 22:28:16 <flo> I'm confused by what you are doing in http://hg.instantbird.org/users/wnayes/file/1b87e4cbe47c/chat/importers/pidgin/test/test_pidginFindAccounts.js 22:29:10 <flo> when you have |function foo() { some code }|, and then |foo.prototype = { some object }|, foo.prototype is touched only if you do at some point |new foo();| 22:30:03 <wnayes> I was thinking the test could act as an observer to test findAccounts() 22:30:49 <flo> you need an observer object somewhere 22:30:58 <flo> and it's that object that you pass to findAccounts instead of "this" 22:31:28 <flo> or you can even write directly importer.findAccounts({observer: function() { test code... }}); if you like 22:32:40 <flo> also, is the observer notified synchronously or asynchronously? 22:33:59 <wnayes> OK, I'll try that :) I'm assuming it is notified asynchronously due to the executeSoon(). 22:35:50 <flo> ok, never mind, the add_test and run_next_test functions handle asynchronous tests :) 22:35:53 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1609 on bug 1509. 22:35:55 * flo is RTFMing at the same time ;) 22:35:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1509 nor, --, ---, aletheia2, ASSI, Drop target does not reappear after detaching all but one merged buddies 22:36:51 <wnayes> http://hg.instantbird.org/users/wnayes/file/1b87e4cbe47c/chat/importers/pidgin/test/test_pidginGetPurpleDirectory.js has been bothering me more, I don't know why a .getService() call would work in the test method but not in the importer object. 22:37:03 <flo> aleth: shouldn't we reinsert it when there's only one buddy left, rather than null-check around the error? 22:37:36 <flo> wnayes: where's the place in the importer object where it fails? 22:37:46 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1610 on bug 1509. 22:37:49 <aleth> flo: ^^ 22:38:26 <flo> "What do you think?" I think I'll need to try it 22:38:35 <flo> aleth: is the reinsertion animated? 22:38:37 <aleth> Yup ;) 22:38:54 <aleth> flo: Yes, it's animated 22:39:10 <wnayes> flo: http://hg.instantbird.org/users/wnayes/file/1b87e4cbe47c/chat/importers/pidgin/pidgin.js#l135 when trying to get the environment variables service (also fails when removing that section and .getService() is called on the directory service). Yet those calls would not error out when pasted in the main test method body. 22:40:29 <instantbot> florian@instantbird.org requested review from florian@instantbird .org for attachment 1608 on bug 1498. 22:40:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1498 nor, --, ---, aletheia2, ASSI, "this.buddy is undefined" on merging two IRC buddies 22:41:13 <aleth> Yes, please check those, as I don't really know that code. 22:42:17 <flo> wnayes: is there any very trivial way I can try this on my debug build? 22:42:27 * flo would like to go to bed soon ;) 22:43:46 <wnayes> flo: Do you have a debug build of my repository? 22:43:56 <flo> I don't have your repository at all 22:45:13 <wnayes> I can't think of any trivial way then :) 22:46:30 --> mmkmou has joined #instantbird 22:48:31 <flo> you are 100% sure it's the Components.classes["@mozilla.org/process/environment;1"].getService(Components.interfaces.nsIEnvironment) calls that throws? 22:49:10 <Mook_as> and it's the one in your file, not some other file? 22:50:41 <wnayes> I'm not 100% sure about much with these tests so far, the error is pasted in the etherpad: https://etherpad.mozilla.org/3PMlo5lMor 22:50:57 <flo> wnayes: I don't I really believe it; your error message mentions resource://gre/modules/Services.jsm, so you are most likely accessing something from Services. 22:52:46 <flo> the simple test you have now (just testing importer._getPurpleDirectory()) shouldn't trigger this yet, but I see some of your importer code uses Services.core.getProtocolById 22:52:48 <Mook_as> what gecko version are you guys on again? 13? 22:53:05 <flo> that requires the core service to be initialized, so Services.core.init needs to have been called before 22:53:21 <flo> and that fails in xpcshell, because nsIXULAppInfo isn't defined in xpcshell 22:53:52 <flo> you will need a hack like this http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/test/test_purplexpcom.js#9 to work around this issue 22:53:56 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1611 on bug 1509. 22:53:56 <flo> Mook_as: 12 22:53:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1509 nor, --, ---, aletheia2, ASSI, Drop target does not reappear after detaching all but one merged buddies 22:54:12 <Mook_as> that sounds right, then, line55 is appinfo getter 22:54:48 <wnayes> flo: It could be Services.appinfo.OS in the _getPurpleDirectory() doing it too, thanks for the tip :) 22:55:04 <flo> Mook_as: I think these error messages from Services.jsm really suck 22:55:32 <flo> Mook_as: I've though several times already that it would be nice to rewrite some of the services.jsm code to show in the error message the name of the service it failed to get 22:55:37 <flo> *thought 22:56:32 <flo> wnayes: great! So you are unblocked for both of your tests? :) 22:57:10 <Mook_as> wouldn't it be better to make getService suck less, rather than Services.jsm suck less? 22:57:16 --> Kaishi has joined #instantbird 22:57:31 <flo> Mook_as: how would you define "make getService suck less"? 22:57:43 <wnayes> flo: I'll try the core.init() trick and see what happens. 22:58:16 <flo> I don't think you need core.init yet 22:58:26 <flo> (unless you need a Services.core.getProtocolById call) 22:58:34 <flo> but you need the XULAppInfo stub 22:59:37 <-- myk has quit (Ping timeout) 23:01:24 <Mook_as> flo: make nsJSCID::getService report errors better? 23:01:43 <flo> what's nsJSCID? 23:01:54 <Mook_as> the thing implementing Components.classes[*] 23:02:05 <Mook_as> (that is, one item in the dict) 23:02:30 <flo> ah, so there's only one implementation? 23:07:04 <wnayes> flo: Looks like that did the trick for both, Thanks! :D 23:07:23 <wnayes> The core.init wasn't needed, as you said. 23:09:10 <flo> you are welcome :) 23:10:57 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1611 on bug 1509. 23:10:58 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1612 on bug 1509. 23:10:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1509 nor, --, ---, aletheia2, ASSI, Drop target does not reappear after detaching all but one merged buddies 23:19:27 * flo wonders how oauth.jsm got messed up 23:19:40 <flo> the POST parameters aren't taken into account for the signature :-S 23:27:48 <-- mmkmou has quit (Ping timeout) 23:41:55 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 23:53:02 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 23:57:44 --> skeledrew has joined #instantbird