#instantbird log on 06 12 2012

All times are UTC.

00:05:07 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:17:18 --> clokep has joined #instantbird
00:17:19 * ChanServ sets mode +o clokep 
00:18:42 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 14.0/20120605113340])
00:24:54 <-- Tonnes has quit (Quit: ChatZilla [Firefox 13.0/20120601045813])
00:25:06 * clokep gets confused when you guys start talking about themes... :-S
00:26:47 <instantbot> clokep@gmail.com set the Resolution field on bug 1375 to FIXED.
00:26:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1375 min, --, 1.2, aletheia2, RESO FIXED, Followup: Unread ruler CSS and Bubbles margin improvements
00:35:03 <-- Mook_as has quit (Quit: Mook_as)
00:49:02 <-- Tomek has quit (Quit: Instantbird 1.1)
00:51:02 <aleth> Did you ever set the checkin-needed flag on that Nickserv patch?
00:52:38 <clokep> aleth: It shouldn't be set.
00:52:58 <aleth> Ah OK. I thought you'd decided on no further changes...
00:53:13 <clokep> No. I'm not sure still. :-/
00:56:19 <clokep> flO: Did you see http://groups.google.com/group/mozilla.dev.platform/browse_thread/thread/7058437ee20757f3#?
01:18:16 <clokep> Mook: I think this will work http://pastebin.instantbird.com/45325
01:26:32 <-- aleth has quit (Input/output error)
01:30:01 <instant-buildbot> build #241 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/241
01:40:51 <instantbot> clokep@gmail.com set the Resolution field on bug 1101 to WONTFIX.
01:40:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1101 enh, --, ---, nobody, RESO WONTFIX, Add an "auto-perform" box
01:44:05 <instant-buildbot> build #260 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/260
01:58:27 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
02:25:53 <clokep> If anyone wants to read a rambling post about how I designed the IRC protocol stuff: http://clokep.blogspot.com/2012/06/irc-auto-performs.html
02:44:48 --> Derpeh has joined #instantbird
02:44:54 <Derpeh> Anybody here?
02:45:10 <Derpeh> I have an Instantbird question.
02:45:34 <clokep> What's up Derpeh.
02:45:38 <clokep> Go ahead and ask.
02:49:06 <Derpeh> Does Instantbird support group chat for Google Talk?
02:49:15 <Derpeh> If so, how do I initate a chat with more than one person?
02:49:18 <clokep> Does Google Talk even support group chats? :)
02:49:18 <instantbot> clokep@gmail.com requested feedback from the wind for attachment 1590 on bug 1139.
02:49:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1139 nor, --, ---, nobody, NEW, fewer false positives for emoticon detection
02:49:31 <clokep> I didn't think the protocol supported it....
02:49:32 <Derpeh> Yes, Google Talk supports group chats.
02:49:42 <Derpeh> It has for a few years now.
02:49:51 <clokep> File > Join Chat.
02:50:12 <Derpeh> Yeah, I saw that option. But how does it work?
02:51:08 <Derpeh> I enter a room name and put talk.google.com for the server, but nothing happens.
02:51:57 <clokep> Yeah, I'm looking, one second.
02:54:39 <clokep> Derpeh: So it seems you can join one by using groupchat.google.com as the server and the chat name private-chat-xxxxxxxx, but I'm not sure how to initiate one...
02:54:41 <Derpeh> Looks like I would have to initiate a group chat from the actual Gmail chat client and then paste the Room ID in there.
02:55:01 <clokep> Yeah...that's what it seems like.
02:55:06 <Derpeh> Would be nice to eventually have this feature available natively ala Digsby.
02:55:59 <clokep> File a bug please.
02:56:12 <clokep> I'm wondering if they use a funky way of starting chats. :(
02:56:39 <EionRobb> yeah they do, you can do it in libpurple's xmpp ;)
02:57:31 <clokep> EionRobb: "Yeah they do" meaning they do something proprietary to initiate chats?
02:57:42 <clokep> That's unfortunate (and kind of defeats the purpose of using XMPP....)
02:58:05 <clokep> instantbot: uuid
02:58:06 <instantbot> f805a7e1-6841-4c3a-9309-f7e032620ed0 (/msg instantbot cid for CID form)
02:58:44 <clokep> Derpeh: Ah, you can do it...you just have to use "private-chat-<uuid>" as a room name.
02:58:45 <EionRobb> is there an XEP for creating chat rooms on the fly?
02:59:01 <clokep> EionRobb: I have no idea, I just used the join menu in Instantbird and it worked.
02:59:09 <clokep> Is that not how you normally create them?
02:59:41 <EionRobb> my point is there's not a "normal" way of doing it :)
02:59:46 <EionRobb> google just has their special way of doing it
03:00:00 <clokep> Alright...? 
03:00:03 <clokep> I don't know a lot about XMPP.
03:00:14 <clokep> IRC you just join and it makes the room. :-D I was assuming XMPP does the same.
03:01:38 <-- Derpeh has quit (Quit: Leaving)
03:02:04 <clokep> Guess he didn't want to file a bug. :)
03:02:11 <clokep> Anyway, bed time for me (an hour ago :().
03:02:33 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
03:34:16 <instant-buildbot> build #242 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/242
04:01:55 --> Tomek has joined #instantbird
04:15:24 <-- Tomek has quit (Quit: Instantbird 1.1)
04:37:26 <instant-buildbot> build #525 of linux-nightly-default is complete: Failure [failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/525
04:47:58 --> Mook_ib has joined #instantbird
04:48:55 <-- Mook_ib has quit (Quit: Mook_ib)
04:48:58 --> Mook_ib has joined #instantbird
04:50:11 <-- Mook_ib has quit (Quit: Mook_ib)
04:51:24 <instant-buildbot> build #617 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/617
04:52:15 --> pvagner has joined #instantbird
05:04:49 <-- Suiseiseki has quit (Ping timeout)
05:07:10 --> Suiseiseki has joined #instantbird
05:27:14 --> Mook_ib has joined #instantbird
05:30:13 <-- Mook_ib has quit (Quit: Mook_ib)
05:30:21 --> Mook has joined #instantbird
05:30:57 <Mook> \o/ https://github.com/mook/irrogatur seems to work. (the IRC nick thing.)  thanks, clokep!
05:31:38 <-- Mook has quit (Quit: Mook)
05:46:00 --> TestFliege has joined #instantbird
05:46:24 <-- TestFliege has quit (Input/output error)
05:46:51 --> FireFly_TB has joined #instantbird
05:49:30 <-- EionRobb has quit (Ping timeout)
05:50:54 --> FeuerFliege has joined #instantbird
05:54:13 --> EionRobb has joined #instantbird
06:03:31 <-- EionRobb has quit (Quit: Leaving.)
06:06:41 --> EionRobb has joined #instantbird
06:08:23 <-- EionRobb has quit (Ping timeout)
06:41:46 <-- Kaishi has quit (Quit: Kaishi)
07:10:21 --> jb has joined #instantbird
07:17:27 --> sonny has joined #instantbird
07:25:30 --> Mad_Maks has joined #instantbird
08:00:17 --> gerard-majax has joined #instantbird
08:29:21 --> Even2 has joined #instantbird
08:42:06 --> EionRobb has joined #instantbird
08:42:16 <instantbot> florian@instantbird.org granted feedback for attachment 1590 on bug 1139.
08:42:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1139 nor, --, ---, nobody, NEW, fewer false positives for emoticon detection
08:46:21 --> flo has joined #instantbird
08:46:21 * ChanServ sets mode +qo flo flo 
08:59:04 <flo> hello :)
08:59:12 <flo> is there anything we should do for these gtalk group chats?
09:21:36 --> Optimizer has joined #instantbird
09:24:12 <-- Optimizer has quit (Ping timeout)
09:28:09 --> Optimizer has joined #instantbird
09:28:10 --> mmkmou has joined #instantbird
09:41:40 <-- flo has quit (Input/output error)
09:41:43 --> flo has joined #instantbird
09:41:43 * ChanServ sets mode +qo flo flo 
09:45:25 <-- Optimizer has quit (Ping timeout)
09:48:49 --> Optimizer has joined #instantbird
09:50:31 --> Mic has joined #instantbird
09:50:31 * ChanServ sets mode +h Mic 
09:52:11 <-- Optimizer has quit (Ping timeout)
09:53:58 --> Optimizer has joined #instantbird
09:54:25 <Mic> Hi
09:58:45 <flo> have we ever fixed the issue of the first item in the list of logs of the log viewer never appearing selected?
10:02:29 <Mic> I think aleth had a patch. No idea if it was ever checked in or even r+ed?
10:02:45 <flo> I just found the real cause of the issue
10:03:00 <Mic> http://hg.instantbird.org/instantbird/rev/20c735606a4c
10:03:32 <flo> that's ugly :(
10:03:52 * flo blames the reviewer ;)
10:11:58 <flo> my fix works \o/
10:12:10 <Mic> aleth: yes, the code for messagestyle-themes can be pretty ugly (imo)
10:18:01 --> clokep has joined #instantbird
10:18:01 * ChanServ sets mode +o clokep 
10:18:18 <Mic> Hi clokep
10:21:02 <flo> hello :)
10:21:04 <clokep> Hello.
10:25:25 <-- EionRobb has quit (Quit: Leaving.)
10:26:12 <Mic> About AIO queues: I have got two of my add-ons sitting in the queues since I can't review them myself, anybody volunteers? ;)
10:26:25 <clokep> Mook: I left a comment on https://github.com/mook/irrogatur/commit/610506c3681ae156adef7df44458c089023b25a9
10:26:48 <flo> Mic: do you mean "volunteer to become an AMO editor"?
10:27:48 <Mic> Do you really need an editor for that? I can imagine anyone who's admin would do too? ;)
10:28:32 <flo> Mic: do you think we have many admins? ;)
10:29:06 <Mic> I'd say n >= 2 at least? ;)
10:31:11 <-- skeledrew has quit (Ping timeout)
10:31:56 --> skeledrew has joined #instantbird
10:34:26 <flo> filed https://bugzilla.mozilla.org/show_bug.cgi?id=763872
10:34:38 <flo> is it normal that I feel guilty for not even trying to create a test? :-S
10:35:00 * flo dislikes working with mochitests
10:38:29 <clokep> Mochitests are painful I gather?
10:38:39 * clokep thinks there's too many types of tests. :(
10:38:51 <flo> it's not writing the test itself, but getting the environment setup
10:39:22 <flo> compiling Firefox again, verifying that the existing tests work correctly on my machine (usually they don't, for some obscure reason)
10:39:37 <flo> (lots of bad excuses ;))
10:40:53 <clokep> Ah-ha
10:40:55 <clokep> Makes sense.
10:41:04 <clokep> That's why I never wrote tests for the Lightning stuff I did. :)
10:42:09 <flo> yeah... all of that is cheap if you work on that code everyday
10:42:52 <flo> but if you do on average a patch every 6 months, getting the environment back in working conditions and remembering how to work on the specific kind of tests that's needed takes more time than creating the patch itself :-/
10:48:28 * flo wonders if Mic indents to take bug 1265
10:48:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1265 enh, --, ---, nobody, NEW, Optimize CSS and JS of messagestyle themes
10:48:31 <clokep> Right. :(
10:48:52 <clokep> Mic: I can probably review some of your stuff if you'd like, but I'm not a reviewer. :)
10:50:11 * flo thinks clokep could be made an admin
10:50:25 <Mic> flo: eventually yes ;)
10:50:39 <flo> that way I wouldn't have to look at these dictionaries to set their target locale :-P
10:50:53 <Mic> I'm thinking about it everytime I'm looking at theme codes ;)
10:51:01 <Mic> *code
10:51:20 <flo> every time I look at it I think someone should do it, but I would rather look somewhere else ;)
10:52:22 <flo> as long as that "someone" doesn't cause as many regressions as https://bugzilla.mozilla.org/show_bug.cgi?id=747415
10:52:47 * Mic just did "some" search/replaces in Footer.html of the Bubbles theme and the resulting patch is in *one* hunk. Top to bottom. :D
10:52:58 <flo> :-D
10:53:09 <flo> are you cleaning up the coding style too while you are at it?
10:53:22 <flo> like rgb(255,255,255) -> rgb(255, 255, 255) ?
10:53:44 <Mic> variable names, coding style, things like the className vs classList-thing.
10:53:56 * clokep goes to work.
10:54:03 <clokep> flo: I can do those dictionaries if you'd like.
10:54:20 <flo> Mic: the clean-up I would really like in bubbles is avoiding the pointless timers
10:54:31 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:55:17 <flo> the generator for the timer lengths always starts as if the most recent message had been from now, which is not necessarily true when restoring a conversation on hold.
10:55:31 <Mic> I want to get rid of as much as possible of the system message grouping code. I think some could be converted to CSS.
10:57:17 <flo> clokep: was it intentional that current nightlies write "flo +qo" instead of the "+qo flo" that libpurple wrote in mode system messages?
10:58:36 <flo> and couldn't we write that sentence in real English instead of displaying cryptic mode letters? how would "mode (clokep +o) by ChanServ." -> "ChanServ made clokep a channel operator." sound?
11:29:39 --> aleth has joined #instantbird
11:29:39 * ChanServ sets mode +h aleth 
11:35:45 --> clokep_work has joined #instantbird
11:35:45 * ChanServ sets mode +o clokep_work 
11:37:21 <Even1> Mic: I fixed the permissions issue on addons. you should be able to edit them now.
11:37:29 <clokep_work> flo: You speak of bug 1420, I believe.
11:37:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1420 nor, --, ---, nobody, NEW, Add discoverable explanations for the possible modes
11:37:49 <Even1> you should have an "Edit item" on the addon when reviewing and a specific menu in "Admin Tools" called addon manager that will let you search addons and choose to edit them.
11:38:05 <Even1> At least I beleive it is fixed. It would be great if you could check this out :)
11:38:07 <clokep_work> And I have no idea if I swapped the order purposefully. :) Did we check whether they are supposed to be swapped? (Does the string have them swapped?) Or did I just put the params into the string in the wrong order.
11:38:33 <Even1> (needs a logout/login sequence if you're already logged in)
11:40:05 <aleth> flo: Cool, you found the real cause of the listbox selection bug :)
11:41:00 <clokep_work> Thanks Even1!
11:41:27 <aleth> That should eventually enable the removal of quite a few hacks in the IB code (not just in the log viewer)
11:43:13 <Mic> Thanks, Even1. It worked to add the greek dictionary to the page in question.
11:43:39 <clokep_work> flo: I would like to handle that btw (1420), we just need to actually start mapping between server daemons and what they support.
11:44:03 <clokep_work> Although, not for many of the easier ones, I suppose. :) (channel op, etc.)
11:45:14 <Mic> I see an "edit item" link on the "Review Add-on" page now, so it seems to work as you expected. Thanks again!
11:48:52 * aleth wishes he had been able to find the real cause of the listitem binding bug...
11:57:01 <instantbot> New Instantbird (UI) bug 1505 filed by aletheia2@fastmail.fm.
11:57:02 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1591 on bug 1505.
11:57:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1505 enh, --, ---, nobody, ASSI, [Bubbles] Change link color in system messages
11:57:49 <clokep_work> aleth: Want to attach a screenshot? :)
11:59:01 <aleth> clokep_work: You asked for this without seeing it first? :P
11:59:32 <clokep_work> aleth: No, but I want a screenshot in the bug. :)
12:00:50 <-- chrisccoulson has quit (Quit: Ex-Chat)
12:01:23 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:01:25 --> Mic has joined #instantbird
12:01:25 * ChanServ sets mode +h Mic 
12:02:17 --> chrisccoulson has joined #instantbird
12:04:51 <Mic> aleth, clokep_work: have you tried what happens if someone disables "Underline links" in the options? The color is almost the same so I guess it will be almost impossible to tell if something is a link without hovering it.
12:05:52 <clokep_work> Mic: Sounds like you'd like to steal that review. ;)
12:06:21 <aleth> Mic: That the color is almost the same is kind of the point. Anyone who disables "underline links" has a preference for unobtrusive URLs anyway, so I am not concerned about that.
12:08:42 <aleth> Trying it out, I find URLs are still recogniseable, though it's subtle.
12:08:58 <clokep_work> Would making it a bit darker help and still be unobtrusive?
12:09:25 <Mic> brb
12:09:26 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:09:45 --> Mic has joined #instantbird
12:09:45 * ChanServ sets mode +h Mic 
12:10:54 <aleth> The darker you make it, the more obtrusive it gets. Personally I don't see the need, but it's up to you. I think it's a plus that the links don't stand out so much in system messages.
12:11:27 <Mic> Might depend on the display setting - it's indistinguishable from other text here
12:11:53 <aleth> That's possible, that it depends on the monitor a bit...
12:12:19 <Mic> This one certainly hasn't tweaked settings, it's a random computer in a library..
12:13:24 <aleth> So you could tweak the darkness until you just notice... 
12:13:55 <aleth> But I do think the point of the change is that you practically don't notice those URLS until you pay attention to them.
12:14:29 <Mic> Being gray makes them a lot less unobstrusive compared with ... #00F or whatever they have by default.
12:15:04 <clokep_work> aleth: I disagree, I think it's so they're not obnoxious blue.
12:15:33 <clokep_work> I'm OK with the current patch or a little bit darker, though. (I don't think it's worth much bikeshedding.)
12:15:34 <aleth> Well, if you don't mind tweaking the value until you are happy, please go ahead :)
12:15:54 <aleth> Since Mic seems to have a "good" display for testing this...
12:16:27 <Mic> Not my bug :P
12:16:27 <aleth> I'm not wedded to any particular value. It just looked good to me on the particular monitor here.
12:17:14 <Mic> "New Bug: IB should show a display calibration screen on first run" ;)
12:17:17 <clokep_work> It looks OK on this monitor, a little difficult to tell apart, but the line is still there...
12:19:51 <aleth> clokep_work: I think |color: hsl(0, 0%, 30%);| may be a good value
12:20:33 <clokep_work> "blah blah blah (or did you mean blah blah?): blah blah" is really hard to not match a smiley on while still matching other situations...I think you need to do paren matching for it...
12:21:07 <flo> why do we care that links are noticeable in system messages?
12:21:19 <instantbot> clokep@gmail.com granted review for attachment 1591 on bug 1505.
12:21:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1505 enh, --, ---, nobody, ASSI, [Bubbles] Change link color in system messages
12:21:34 <flo> I expected the patch to use the exact same color as for the rest of the text, and even wondered if we should remove the underline until the link is hovered/active
12:21:57 <clokep_work> flo: I disagree, I think you want them to be noticeable, but not to draw your attention away from the rest of the conversation.
12:22:01 <flo> but I don't care too much either way, as long as it's not that horrible blue... :)
12:22:04 <-- Optimizer has quit (Ping timeout)
12:23:36 <flo> aleth: what are the other cases you have in mind where we added workarounds for that selection bug?
12:26:04 --> Optimizer has joined #instantbird
12:29:44 <-- Mad_Maks has quit (Client exited)
12:31:22 <aleth> flo: I'm not sure I can remember all of them and I'm not sure it's exactly the same thing, but:
12:31:22 <aleth> http://lxr.instantbird.org/instantbird/source/instantbird/content/accounts.js#348
12:32:37 <flo> not the same thing
12:32:39 <aleth> Hmm, I can't find the case I had in mind :-/
12:32:43 <flo> but it looks like we should revisit that some day :)
12:32:53 <flo> aleth: I think the same bug happens in the buddy list too
12:33:00 <flo> but it's a richlistbox, so I don't think my patch would help
12:33:00 <aleth> I think there is at least one other instance, but lxr is not helping me atm
12:33:09 <aleth> That might be it.
12:33:43 <flo> aleth: the nicklist !
12:33:50 <flo> but I don't think we ever worked around it
12:35:23 <instantbot> aletheia2@fastmail.fm granted review for attachment 1593 on bug 1505.
12:35:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1505 enh, --, ---, nobody, ASSI, [Bubbles] Change link color in system messages
12:36:46 <aleth> flo: Yup... that's not a problem though as by default nothing is selected there.
12:37:03 <aleth> The account manager maybe?
12:37:14 <aleth> (richlistbox I assume)
12:37:14 <flo> richlistbox too
12:56:41 <aleth> flo: Does your patch also apply to listitem-iconic? In which case there may be some additional properties to copy.
12:57:01 <aleth> ("image")
12:57:04 <flo> do we use them?
12:57:09 <aleth> Sure
12:57:21 <aleth> (in the nicklist at least)
12:58:28 <Mic> I can't remember seeing this problem on the participant list btw
12:59:11 <aleth> No, but if we selected the first item by default, we would (not that I think we should!)
12:59:44 <aleth> I was just thinking generically about the patch though.
13:00:03 --> Lalae has joined #instantbird
13:00:09 <-- Lalae has left #instantbird ()
13:11:11 <Mic> clokep_work: maybe you should go and hear a talk about smilies in parantheses? http://xkcd.com/541/ ;)
13:11:30 <Mic> (I already feel bad for pinging you with this)
13:12:16 <clokep_work> Mic: Haha, yes. :)
13:12:19 <clokep_work> I forgot about thato ne.
13:14:02 <Mic> bye
13:14:04 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
13:16:50 <flo> we may need to port some changes from https://bugzilla.mozilla.org/show_bug.cgi?id=668869 :-S
13:21:04 <clokep_work> Are you looking at upgrading to Moz 13 or just came across that?
13:22:04 <aleth> I thought moz13 was planned for 1.2 anyway?
13:22:24 <flo> clokep_work: it was discussed in #maildev a few minutes ago
13:22:56 <flo> clokep_work: well, https://bugzilla.mozilla.org/show_bug.cgi?id=762621 is the one that was discussed; and I wondered if we need that file (we currently don't have it at all) and if we need to add a line for libpurple there
13:25:49 <clokep_work> Ah, I see.
13:26:01 <clokep_work> aleth: I meant was he doing it now. ;) (But I assumed not.)
13:27:53 <flo> nope, it's a rainy week-end activity ;)
13:32:12 <-- chrisccoulson has quit (Quit: Ex-Chat)
13:34:36 <-- pvagner has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
13:34:57 --> pvagner has joined #instantbird
13:37:21 --> chrisccoulson has joined #instantbird
13:39:38 <flo> aleth: where do you see a setter in the listitem-iconic binding?
13:43:23 --> Tomek has joined #instantbird
13:43:24 <aleth> flo: I didn't dig into the code, but was not sure how the xbl:inherits properties were implemented.
13:43:36 <flo> completely unrelated
13:43:43 <flo> xbl:inherits is about DOM attributes
13:43:47 <flo> that bug is about JS properties
13:43:58 <aleth> So the DOM image attribute has no setter?
13:44:01 <aleth> (in JS)
13:44:04 <flo> no
13:44:20 <aleth> OK. Sorry about that then
13:44:35 <flo> the only other potentially annoying value that I haven't handled is http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/listbox.xml#1054
13:44:50 <flo> but the bug exists only if the property is set from the listitem binding
13:44:51 <aleth> I was worried because "label" also appears in that list
13:45:12 <aleth> Ah, for listitem-checkbox
13:45:28 <flo> and the only place where listitem touches it is from a keypress event handler: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/listbox.xml#834
13:45:46 <flo> I don't think there's any risk of that happening before the listitem bindings are attached
13:46:20 <flo> aleth: the "label" I was fixing is http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/listbox.xml#943
13:46:44 <flo> and it's not super useful, as it's never set from the listbox binding
13:46:54 <flo> I just handled it because it was trivial
13:47:48 <aleth> Right.
13:53:55 <instantbot> New Instantbird (UI) bug 1506 filed by leena.heino@uta.fi.
13:53:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1506 nor, --, ---, nobody, UNCO, ability to send re-request authorization messages to buddies
13:55:08 <flo> Looks confusing
13:55:16 <flo> I don't see how the second sentence in the description is related to the rest
13:56:49 <aleth> A wrong guess of what the target selector is for?
13:57:27 <-- pvagner has quit (Ping timeout)
14:23:25 <flo> I'm looking at https://bugzilla.mozilla.org/show_bug.cgi?id=735998
14:23:37 <flo> do we have any code anywhere to unescape HTML special chars?
14:24:00 <-- Optimizer has quit (Ping timeout)
14:27:49 --> Optimizer has joined #instantbird
14:48:14 --> jb1 has joined #instantbird
14:48:52 <-- jb has quit (Ping timeout)
14:51:05 <flo> Is there a better solution than http://pastebin.instantbird.com/45393 that I may ahave missed?
14:51:09 <flo> -a
14:52:55 <flo> someone says https://bugzilla.mozilla.org/show_bug.cgi?id=756277 (the XHR bug breaking the twitter OAuth dialog) appeared in Moz13, so now I'm scared to update :-D
14:56:44 <-- meh has quit (Ping timeout)
15:08:51 --> wnayes has joined #instantbird
15:13:35 <clokep_work> flo: I don't think there's a better solution, no.
15:17:32 --> meh has joined #instantbird
15:19:04 <-- gerard-majax has quit (Ping timeout)
15:21:50 <instantbot> New Instantbird (UI) bug 1507 filed by aletheia2@fastmail.fm.
15:21:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1507 nor, --, ---, nobody, NEW, Target selector not disabled when there is only one account to select from
15:25:06 <clokep_work> All this authorization stuff is really annoying. :-S
15:25:32 <aleth> I don't understand what it is really.
15:26:49 <-- Optimizer has quit (Ping timeout)
15:27:35 --> igorko has joined #instantbird
15:30:49 <flo> aleth: it seems like XMPP jargon ;)
15:30:50 --> Optimizer has joined #instantbird
15:31:02 <flo> aleth: I think 1507 is a dupe, but I'm not 100% sure :)
15:31:17 <flo> clokep_work: ok, I'll attach that patch then :)
15:32:34 <-- Even2 has quit (Ping timeout)
15:33:53 --> Even2 has joined #instantbird
15:37:36 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1594 on bug 1507.
15:37:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1507 nor, --, ---, aletheia2, ASSI, Target selector not disabled when there is only one account to select from
15:40:54 <flo> bug 1324
15:40:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1324 min, --, ---, nobody, NEW, Account target selector does not always recognize when a  buddy has no alternative protocols
15:41:10 <aleth> Huh. I eve n filed it :(
15:41:49 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1324 to DUPLICATE of bug 1507.
15:41:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1507 nor, --, ---, aletheia2, ASSI, Target selector not disabled when there is only one account to select from
15:42:43 <-- meh has quit (Ping timeout)
15:43:49 <flo> aleth: is this updated correctly if the user merges another buddy into that contact?
15:44:25 <-- Even2 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:45:01 <aleth> flo: No. Was that the reason for the wrongness?
15:45:16 <-- igorko has quit (Ping timeout)
15:45:25 <flo> aleth: maybe?
15:45:54 <flo> aleth: I don't think that case has ever been really tested, so I would expect broken behaviors when merging buddies that have an active conversation :-/
15:47:08 --> meh has joined #instantbird
15:50:08 --> igorko has joined #instantbird
15:50:59 <aleth> So that's a separate bug then?
15:51:18 <aleth> A brief test didn't uncover any issues apart from the obvious one.
15:51:44 <flo> maybe :)
15:51:54 <flo> I wouldn't block your change on that
15:52:05 <aleth> Well, I should check if there is an obvious notification to listen for
15:52:06 <flo> as you are likely to uncover several different issues if you start testing that
15:53:32 <-- Optimizer has quit (Ping timeout)
15:54:05 <aleth> Bug 742 seems potentially related
15:54:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=742 enh, --, ---, nobody, NEW, Change conversation target automatically when buddies' availability changes
15:54:42 <aleth> Though I've never had problems with that.
15:56:06 --> Optimizer has joined #instantbird
15:59:54 <flo> that one doesn't involve a change to the list of buddies; just of the status of some buddies
16:00:33 <-- Optimizer has quit (Ping timeout)
16:01:29 <instantbot> New Instantbird (UI) bug 1508 filed by aletheia2@fastmail.fm.
16:01:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1508 nor, --, ---, nobody, NEW, Notify conversations when a contact has a buddy attached or detached from it
16:02:02 --> Mnyromyr has joined #instantbird
16:03:54 <-- igorko has quit (Ping timeout)
16:04:07 --> Optimizer has joined #instantbird
16:04:22 <instantbot> New Instantbird (UI) bug 1509 filed by aletheia2@fastmail.fm.
16:04:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1509 nor, --, ---, nobody, NEW, Drop target does not reappear after detaching all but one merged buddies
16:08:12 --> wesj has joined #instantbird
16:09:55 <flo> aleth: the difficult part is: how do you separate the prplConversations from 2 buddies when they are no longer from the same contact?
16:10:11 <flo> (and the opposite: what if you had 2 conversation tabs, but they are now from the same contact?)
16:10:41 <aleth> Yes, I was just wondering about that. 
16:12:09 <aleth> I think the latter case we don't need to care about. For the former I would suggest always retaining the contact containint the buddy the conversation is connected to at the moment. When the conversation is disconnected, I suppose it doesn't matter which is picked.
16:12:47 <flo> in the later case, what if you use the target selector, and make both conversations be for the same buddy?
16:13:02 <flo> having 2 conversation tabs in the same window for the same buddy seems quite broken to me ;)
16:13:06 <aleth> Right. :(
16:13:25 <aleth> I'm not sure it's more broken than merging two tabs just like that.
16:13:53 <aleth> But two open conversations for the same buddy ... might break things
16:14:02 --> myk has joined #instantbird
16:14:42 <-- flo has quit (Ping timeout)
16:15:09 <aleth> Anyway, it seems to me checking in bug 1507 is a clear win, while bug 1508 is desirable but difficult.
16:15:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1507 nor, --, ---, aletheia2, ASSI, Target selector not disabled when there is only one account to select from
16:15:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1508 nor, --, ---, nobody, NEW, Notify conversations when a contact has a buddy attached or detached from it
16:16:00 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:16:05 --> Even1 has joined #instantbird
16:16:29 <aleth> The problematic instances you list are problematic now already I think... :-/
16:16:35 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:19:18 <-- Optimizer has quit (Ping timeout)
16:22:53 --> Optimizer has joined #instantbird
16:25:51 --> EionRobb has joined #instantbird
16:27:39 <-- EionRobb has quit (Ping timeout)
16:34:17 --> flo has joined #instantbird
16:34:17 * ChanServ sets mode +qo flo flo 
16:36:52 <-- Optimizer has quit (Ping timeout)
16:40:58 --> Optimizer has joined #instantbird
16:45:02 <instantbot> clokep@gmail.com denied review for attachment 1537 on bug 1108.
16:45:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
16:50:16 <aleth> That didn't turn out to be the easiest first bug...
16:50:57 <-- meh has quit (Ping timeout)
16:52:37 <clokep_work> Nope. :)
16:54:10 <flo> aleth: http://log.bezut.info/instantbird/today#m387 yes, that's why I said "I wouldn't block your change on that"
16:54:31 <aleth> flo: It took me a while to catch up with you there ;)
16:54:51 <flo> as long as we agree on the conclusion... :)
16:55:58 <aleth> Ah, the linux nightly didn't get updated. That's why last night's patch looked broken to me... ;)
16:56:48 --> devfil has joined #instantbird
16:57:22 <clokep_work> aleth: I'll review it when I get home. :)
16:58:19 --> Mook_astb has joined #instantbird
16:58:56 <Mook_astb> clokep_work: unfortunately, I only get an XPCOM-wrapped prplIAccount, so I can't use .getString
17:01:53 <-- Mook_astb has quit (Quit: Mook_astb)
17:02:12 --> Mook_as has joined #instantbird
17:02:57 <Mook_as> (but thanks for the comments! code review is always good)
17:03:17 <clokep_work> Uhh...you should not.
17:03:25 <clokep_work> Everything is in JavaScript land.
17:03:30 <clokep_work> There's no XPCOM involved.
17:04:06 <Mook_as> hmm, odd; when I played with it, it was all xpcom
17:04:46 <Mook_as> oh, hmm, actually, I might have done it wrong, actually... duh, yes, I have. I was using a xpcom-wrapped repl.
17:05:11 <Mook_as> (Services.accounts.getAccountById(6) or some such, which doesn't reflect the thing I get in the IRC handler)
17:05:14 <clokep_work> I think the issue is that you went to the imAccount, instead of just using "this". the imAccount is XPCOM wrapped.
17:05:49 <Mook_as> actually, whatever I originally had didn't go for the imAccount, and it has undefined .id and .password
17:05:57 <Mook_as> the imAccount bit was a workaround for that
17:06:07 <clokep_work> Ah, I see.
17:06:46 <clokep_work> For the password you have to hit the imAccount: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#1037
17:07:15 <clokep_work> But the preferences you can't hit it: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#864
17:07:42 <Mook_as> yeah, I'll check if .getString works once I get home and poke more at it.
17:08:38 <clokep_work> Cool. :)
17:08:55 <clokep_work> Probably would have been helpful if I had wrote my blog entry before last night for ya. ;)
17:09:21 <Mook_as> for some reason, the cleanup wasn't being done correctly, though. I think that's an AddonManager problem (shutdown not being called), and not a IRC protocol problem.
17:09:57 <clokep_work> The unregistering of the handler?
17:10:05 <clokep_work> I know I tested it briefly at one point but probably not very well. :-/
17:10:36 <Mook_as> yeah; I ended up having multiple old versions hooked up and not disabled as I update the extension. (bootstrapped ftw)
17:12:14 <clokep_work> Yup! :) Bootstrapping is funky when you try to edit the extension as it's running hah.
17:12:31 <Mook_as> oh, I installed from xpis anyway
17:14:46 <Mook_as> note to self: write extension to map Ctrl+1 or Alt+1 to the placeholder "conversations" view
17:21:03 <clokep_work> Ah, OK.
17:21:16 <clokep_work> aleth: So any ideas about bug 1477 then?
17:21:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1477 enh, --, ---, clokep, ASSI, Authenticate with NickServ
17:31:48 --> meh has joined #instantbird
17:33:49 --> pvagner has joined #instantbird
17:36:13 <-- Optimizer has quit (Ping timeout)
17:37:10 --> Optimizer has joined #instantbird
17:38:08 <-- pvagner has quit (Ping timeout)
17:49:08 <-- flo has quit (Ping timeout)
17:49:17 --> flo has joined #instantbird
17:49:17 * ChanServ sets mode +qo flo flo 
17:49:43 <-- jb1 has quit (Quit: Instantbird 1.1)
17:52:59 <-- Optimizer has quit (Ping timeout)
17:53:13 --> Optimizer has joined #instantbird
17:53:16 * clokep_work would appreciate thoughts on bug 1477 from flo and aleth when they get a chance.
17:53:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1477 enh, --, ---, clokep, ASSI, Authenticate with NickServ
17:53:20 <clokep_work> (Or anyone else really.)
17:54:06 <Mook_as> I glanced at it. and then decided I hate the IRC protocol and how underspecified it is.
17:54:34 <clokep_work> This isn't even part of the protocol is the issue. :(
17:54:43 <clokep_work> I just added a new comment though, which is what I was referring to. :)
17:55:04 <Mook_as> well, the fact that it doesn't really say how to identify services :p
17:56:50 <Mook_as> comment 6 seems reasonable, yeah, though positively identifying services might be hard
18:00:17 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:03:49 <clokep_work> Right, comment 3 talks about it a bit.
18:04:00 <clokep_work> If you can 100% positively identify it, then the bug is easy...
18:04:23 <Mook_as> and then it becomes a fun game of "how do I set up my IRC client to pretend to be a service"
18:04:34 <clokep_work> Right. :(
18:08:50 <-- Mook_as has quit (Quit: Mook_as)
18:09:12 --> Mook_as has joined #instantbird
18:16:02 <-- Optimizer has quit (Ping timeout)
18:16:16 <-- chrisccoulson has quit (Quit: Ex-Chat)
18:16:17 --> Optimizer has joined #instantbird
18:17:04 --> chrisccoulson has joined #instantbird
18:44:20 * jwir3 is now known as jwir3|lunch
18:55:14 <-- Tomek has quit (Quit: Instantbird 1.1)
18:58:00 <aleth> "Stuart Parmenter 2006-08-17 15:12:39 PDT Don't see any reason to fix this until XBL2" them fateful words...
18:58:28 <clokep_work> Hah, XBL2. Yay> :P
18:58:32 <clokep_work> What's that from?
18:58:39 <aleth> https://bugzilla.mozilla.org/show_bug.cgi?id=250123
18:59:00 <aleth> another one of the cluster of listbox binding bugs
19:00:15 <aleth> huh, it even mentions the unsatisfactory workaround I also found at the end...
19:00:45 <clokep_work> Ah I ran into that bug too in one of my extensions.
19:03:14 <Mook_as> yeah, I just use a mix of ensureElementIsVisible and .getAttribute("value")
19:24:33 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:24:40 --> aleth has joined #instantbird
19:24:41 * ChanServ sets mode +h aleth 
19:25:35 <-- Mnyromyr has quit (Ping timeout)
19:27:14 * jwir3|lunch is now known as jwir3
19:27:26 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:27:29 --> aleth has joined #instantbird
19:27:29 * ChanServ sets mode +h aleth 
19:27:54 --> Mnyromyr has joined #instantbird
19:35:56 <-- Optimizer has quit (Ping timeout)
19:39:15 --> Optimizer has joined #instantbird
19:45:50 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:45:56 --> myk has joined #instantbird
19:46:08 <-- Mnyromyr has quit (Ping timeout)
19:46:15 <clokep_work> myk: Are you still having issues with AIM?
19:46:33 <clokep_work> I believe they've been fixed (I haven't had any issues in the past bit).
19:47:15 <myk> clokep_work: yes, in fact i just restarted instantbird because of them
19:47:36 <clokep_work> myk: What nightly are you on?
19:47:51 <myk> clokep_work: version 1.2a1pre (20120507041146)
19:48:17 <clokep_work> myk: Well you're a month behind, so I wouldn't expect it to be fixed in that version. ;)
19:48:36 <myk> clokep_work: the last time i tried to update, i got a server error; trying again now
19:48:53 --> Mic has joined #instantbird
19:48:53 * ChanServ sets mode +h Mic 
19:48:55 <clokep_work> Oh? Hmm...I couldn't hit the server recently and ended up just downloading a build, but that was only one day.
19:49:01 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:49:09 --> myk has joined #instantbird
19:49:55 <myk> ok, now i'm on version 1.2a1pre (20120604041134); and check for updates found another one from yesterday
19:49:57 <aleth> clokep_work: "NickServ PRIVMSG <you> :Password accepted - you are now recognized." is not sent if you identified via PASS though, even if PASS is passed to NickServ by the server, right?
19:50:51 --> Mnyromyr has joined #instantbird
19:51:10 <-- myk has quit (Input/output error)
19:51:19 --> myk has joined #instantbird
19:51:43 <myk> ok, now i'm on the latest build: version 1.2a1pre (20120611041133)
19:51:57 <myk> clokep_work: i'll let you know if i still see the problem!
19:52:22 <clokep_work> myk: Anything after a week ago should be fine (since http://hg.instantbird.org/instantbird/rev/2ed5407c4a6a)
19:52:28 <clokep_work> I'm hoping that the AIM issue is a dup of that bug. :)
19:52:32 <clokep_work> Thanks!
19:52:37 <clokep_work> aleth: No, that is sent.
19:52:53 <clokep_work> But it's sent /after/ we're queried for a password.
19:53:00 <aleth> I must have missed it in my mozilla.org log then.
19:54:25 <clokep_work> I'm fairly certain it is at least.
19:54:29 * clokep_work can't check right now.
19:54:42 <clokep_work> It probably comes when you get blasted near the MOTD.
19:54:50 <aleth> My original suggestion was meant to be: wait after the password query until it is clear whether the PASS password led to an authentifcation confirmation being sent or not. 
19:54:54 <aleth> But then that probably involves timers
19:55:42 --> flo has joined #instantbird
19:55:42 * ChanServ sets mode +qo flo flo 
19:55:47 <aleth> (because I guess it's possible the password is just swallowed)
19:55:50 <aleth> So I think you've probably found the best possible solution
19:57:48 <-- Optimizer has quit (Ping timeout)
19:59:11 <aleth> clokep_work:  I just rechecked and it turns out "Password accepted" is sent. Just much later than I would have expected. My bad.
20:01:30 --> Optimizer has joined #instantbird
20:02:56 <flo> clokep_work: so what's wrong with using a timer to wait for a "password accepted" message?
20:03:10 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:03:32 <flo> I meant to ask m yk too about the AIM issue, thanks for beating me to it! :)
20:03:42 <flo> fwiw, I haven't been able to reproduce the AIM issue since the fix
20:04:02 <flo> so I'm quite confident it's fixed
20:04:08 <-- Optimizer has quit (Ping timeout)
20:04:09 <clokep_work> Me neither. :)
20:08:08 --> Optimizer has joined #instantbird
20:08:38 --> EionRobb has joined #instantbird
20:08:59 <clokep_work> flo: I don't have a problem using timers, but it's a PITA because I need to send the messages back through the handlers again, but this time let them fall through to whatever handles have a lower priority.
20:12:03 <flo> the part I don't understand in your proposal in the bug was the part about sending the password in a private message to "nickserv" if you know it's the nickserv service, except you know you can't know this for sure (so you actually don't know at all)
20:12:19 <flo> aleth: bug 250123 annoys me :(
20:13:25 <clokep_work> flo: It was to avoid hanging onto messages...
20:13:45 <clokep_work> I have a patch not in the bug that uses timers and such.
20:13:53 <clokep_work> I'll see abou tfinishing it up, see if you guys like that one better.
20:13:58 <flo> you mean to avoid relying on the strings that may be localized?
20:13:59 <aleth> flo: the fact that there's a well-known and longstanding issue there and it's just been ignored since 2004 because XBL is no longer cool is a bit annoying, yes
20:14:29 <flo> aleth: the fact that I'm going to have to argue to defend this simple patch annoys me actually :)
20:14:45 <aleth> I hope you don't have to
20:14:53 <aleth> Your patch is straighforward :)
20:15:07 <-- Optimizer has quit (Ping timeout)
20:17:02 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:18:37 --> Optimizer has joined #instantbird
20:22:12 <flo> ok, let's see if that comment convinces him :)
20:23:39 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:26:27 <aleth> Should I add a comment about the known workarounds for bug 250123 not working for this case anyway?
20:26:55 <flo> clokep_work: what do you mean with "Put this on the line above." in bug 1537?
20:28:13 <clokep_work> instantbot: bug 1537 bug 1437
20:28:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1437 min, --, nobody, NEW, Remove Welcome screen from Account wizard
20:28:37 <clokep_work> UHhh...bug 1357?
20:28:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1357 nor, --, ---, aletheia2, RESO FIXED, Add unread ruler to section scroll
20:28:44 * clokep_work is guessing at this point...
20:29:43 <flo> bug 1108
20:29:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
20:29:48 <flo> I copied the attachment number :(
20:30:00 <clokep_work> Ah, I should have been able to guess that one. :(
20:30:39 <clokep_work> flo: Don't we usually do functions like: |function blah(aParam) {|? No line break?
20:32:22 <flo> no
20:32:32 --> Mic has joined #instantbird
20:32:32 * ChanServ sets mode +h Mic 
20:32:40 <flo> we do function blah(param)\n{\n...\n}\n
20:32:59 <clokep_work> Really? Because all the IRC code puts it on the same line.
20:33:00 <flo> or ... blah: function(param) {\n...\n},\n
20:33:09 <flo> ie there's a line break for function but not for methods
20:33:41 <clokep_work> As does the XMPP code.
20:33:56 <clokep_work> The Twitter code does not, howeever.
20:34:59 <clokep_work> flo: So our code seems to be fairly split on that then.
20:35:07 <clokep_work> I don't care which way it is btw, I just really thought that was our style.
20:35:13 <flo> clokep_work: only line 20 is wrong in twitter.js
20:36:01 <flo> I see irc.js doesn't have that line break
20:36:11 <flo> it doesn't bother me too much as long as the file is consistent :)
20:36:16 <clokep_work> Alright.
20:36:42 <-- clokep_work has quit (Quit: Home.)
20:38:50 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:39:15 <flo> I'm puzzled by https://bugzilla.mozilla.org/show_bug.cgi?id=763872#c5
20:39:30 <Mic> What's the motivation to treat functions and methods differently here?
20:39:49 <Mic> Just Mozilla coding-style, maybe?
20:40:24 <-- EionRobb has quit (Quit: Leaving.)
20:41:35 <Mic> I'm fine as long as nobody asks to format code like that: https://developer.mozilla.org/en/DOM/element.classList#JavaScript_shim_for_other_implementations ;)
20:41:40 <flo> Mic: I don't really know where it comes from
20:41:47 <flo> mostly that I used the line break, but it looks ugly for methods
20:50:31 --> Tomek has joined #instantbird
20:57:11 <-- wesj has quit (Input/output error)
21:02:39 <Mic> Good night
21:02:54 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:19:58 --> EionRobb has joined #instantbird
21:21:13 --> myk1 has joined #instantbird
21:21:28 <-- myk1 has quit (Input/output error)
21:24:00 <flo> there's a presentation on air mozilla Thursday that may be interesting: https://air.mozilla.org/ "Product Design at Mozilla 14 June 2012, 19:00 UTC Learn about Search Tabs, Presence, Junior, and more."
21:33:06 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:37:24 --> wesj has joined #instantbird
21:48:21 <-- Tomek has quit (Quit: Instantbird 1.1)
21:49:25 --> Tomek has joined #instantbird
21:58:30 * jwir3 is now known as jwir3|away
22:07:32 --> clokep has joined #instantbird
22:07:32 * ChanServ sets mode +o clokep 
22:19:24 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
22:21:07 <clokep> Hello!
22:21:56 <Mook_as> hello?
22:25:31 <aleth> Presence?
22:25:33 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ef2c0ff1bc8a - Florian Qu├Ęze - Bug 735998 - HTML entities in the latest tweet should be decoded before it is used as the topic of the timeline conversation, r=clokep.
22:25:34 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f73b70977541 - aleth - Bug 1505 - [Bubbles] Change link color in system messages, r=clokep.
22:28:31 <clokep> Presence!
22:29:07 <instantbot> clokep@gmail.com set the Resolution field on bug 1505 to FIXED.
22:29:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1505 enh, --, 1.2, aletheia2, RESO FIXED, [Bubbles] Change link color in system messages
22:29:13 <clokep> aleth: Pretty much knowing whether someone is online or not (I think).
22:30:33 <aleth> Was a buzzword a few years back I think.
22:30:46 <flo> aleth: what does XMPP mean? ;)
22:30:49 <aleth> So I was surprised it's back...
22:31:17 <flo> but, yes, it's the "presence" part of the presentation that may be interesting for us
22:31:21 <aleth> :D
22:32:48 <clokep> aleth: So I realized today that you have like 3 or 4 reviews hanging on me, Sorry.
22:36:44 <aleth> Well, some are forwards, so no worries...
22:36:51 <aleth> They're all small ones though
22:40:38 <flo> what's the plan for bug 1113?
22:40:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1113 nor, --, ---, nobody, NEW, Twitter should start from the last read tweet
22:41:31 <clokep> There isn't one AFAIK.
22:41:32 <flo> it's the only bug in the sw:1.2 list for which I don't see clearly what the next action is
22:42:19 <aleth> I don't think there is an action for that one.
22:42:27 <aleth> Implement "show context" and "infinite scroll".
22:42:49 <clokep> It seems to me that the prplIAccount needs to know when the conversation is active. :( Which doesn't seem good to me.
22:43:15 <aleth> (The complaint seemed to be "it's too hard to see tweets I missed", so that will be fixed by those two things)
22:43:44 <clokep> Although I agree with aleth that that seems the best solution.
22:43:58 <clokep> (That way the protocol always just downloads what's "new" and the UI lets you see what's "old".)
22:44:46 <aleth> We should only ever download a tweet once, otherwise it messes up the logs (see recent bugfix)
22:44:47 <flo> aleth: the complain is: "I have to read all tweets before restarting when instantbird prompts for an update, otherwise I don't know which tweets I haven't read"
22:45:06 <flo> aleth: so really, the bug is loosing the "unread" information for some messages
22:45:11 <aleth> flo: You could say that for any protocol though
22:45:28 <clokep> Havint the back log up to the last unread marker seems reasonable. ;)
22:45:39 <aleth> Session restore could restore the unread marker?
22:45:45 <flo> aleth: but it's logical for protocols where you are supposed to not have the backlog when you connect
22:45:48 <aleth> ^^ Mic ;)
22:46:03 <flo> aleth: on twitter we explicitly download tweets that were posted while we weren't connected
22:46:47 <aleth> Sure, I've ran into the problem too. But I think it doesn't require a separate workaround
22:47:21 <flo> so you think it's wontfix?
22:47:26 <aleth> Another part of the problem is you can't open the twitter logs after restart until new tweets arrive
22:47:35 <aleth> Which is also a separate bug
22:47:47 <flo> I'm not sure if I'm more annoyed be twitter marking as read messages that obviously aren't, or XMPP reshowing as unread the same messages over and over again in MUCs each time I reconnect
22:48:07 <aleth> I think it's not quite wontfix, more that it will be fixed by a combination of other things being done
22:48:08 <flo> aleth: you can open it from the join chat dialog
22:48:22 <aleth> flo: yes, but not the logs directly
22:48:38 <aleth> It's not quite intuitive
22:48:38 <clokep> flo: I hate seeing the same things in MUCs over and over. :(
22:48:41 <flo> I don't think any of the mentioned bugs really fix the issue
22:49:01 <flo> clokep: I think all XMPP messages have a unique id, so we could probably detect duplicates
22:49:08 * flo blames the maintainer of JS-XMPP :-P
22:49:26 <flo> our XMPP MUC handling really needs work
22:49:34 <flo> well, s/work/love/
22:49:51 <aleth> If twitter remembered the last "read" tweet somehow, it would still have to scroll to it in the logs, rather than download it again.
22:50:52 <aleth> So it's bug 958 with a calculable number of context messages, if you like
22:50:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows
22:51:24 <flo> aleth: with messages from the log that aren't marked as read when reopening the conversation
22:51:55 <flo> btw, do we still hope to take that bug for 1.2 or have we given up?
22:52:09 <aleth> I don't know what Mic's plans are
22:52:20 <aleth> It seemed almost done
22:52:30 <clokep> flo: It'll be nice, but we're not holding for it.
22:53:14 * clokep is going to the airport. ;) Will be back.
22:53:42 <flo> clokep: what I mean is: if we take it at this point, it's likely to make the release slip while we fight regressions (if any are found)
23:04:01 <-- FireFly_TB has quit (Quit: FireFly_TB)
23:05:08 <flo> Good night
23:05:09 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:07:21 --> Kaishi has joined #instantbird
23:20:09 <-- clokep has quit (Ping timeout)
23:32:37 <-- chrisccoulson has quit (Quit: Ex-Chat)
23:34:05 --> chrisccoulson has joined #instantbird
23:40:30 --> clokep has joined #instantbird
23:40:30 * ChanServ sets mode +o clokep 
23:41:17 <clokep> flo: Right. Then it's Instantbird next.
23:43:24 --> FireFly_TB has joined #instantbird
23:45:49 <-- chrisccoulson has quit (Ping timeout)