#instantbird log on 06 08 2012

All times are UTC.

00:03:16 <instant-buildbot> build #270 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/270
00:09:33 <-- FireFly_TB has quit (Ping timeout)
00:16:47 --> FireFly_TB has joined #instantbird
00:19:53 <-- aleth has quit (Input/output error)
00:27:43 <-- jb has quit (Ping timeout)
00:28:03 <-- jb1 has quit (Ping timeout)
00:29:01 <-- EionRobb has quit (Quit: Leaving.)
00:34:12 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:44:05 --> jb has joined #instantbird
00:48:06 <Mook_as> wow, old messages are never removed? (in tbird, at least...) I still have stuff from #developers from 7.5 hours ago from #developers
00:49:50 --> EionRobb has joined #instantbird
00:54:28 <-- Mook_as has quit (Quit: gone)
01:18:41 <-- FireFly_TB has quit (Ping timeout)
01:25:41 <instant-buildbot> build #239 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/239
01:31:03 <-- jb has quit (Ping timeout)
01:46:37 --> Mook has joined #instantbird
01:49:05 <instant-buildbot> build #258 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/258
03:14:57 <instant-buildbot> build #520 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/520
03:59:36 <-- Suiseiseki has quit (Quit: Quit)
04:27:45 --> jb has joined #instantbird
04:31:42 <-- jb has quit (Ping timeout)
04:57:58 <instant-buildbot> build #613 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/613
05:05:47 --> DGMurdockIII has joined #instantbird
05:26:00 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 14.0/20120605113340])
05:52:47 <instant-buildbot> build #510 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/510
06:27:24 <-- EionRobb has quit (Quit: Leaving.)
06:47:48 --> Mic has joined #instantbird
06:47:48 * ChanServ sets mode +h Mic 
06:48:23 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
06:48:35 --> Mic has joined #instantbird
06:48:36 * ChanServ sets mode +h Mic 
06:54:15 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
06:54:27 --> Mic has joined #instantbird
06:54:27 * ChanServ sets mode +h Mic 
06:55:36 <Mic> Mook, yes. For IB, this is bug 301.
06:55:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=301 enh, --, ---, nobody, NEW, Remove old messages
06:55:52 --> FeuerFliege has joined #instantbird
06:56:00 <Mook> danke
06:56:26 <Mic> Your german is excellent ;)
06:57:33 <Mook> yes! I know all of... three words, I think. and can't pronounce any of them! :D
06:57:39 --> FireFly_TB has joined #instantbird
06:58:47 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
06:59:08 <Mic> It never hurts knowing "thank you" in other languages ;)
06:59:26 <Mic> Well, maybe except for klingon, where I suspect it could be an insult...
07:00:54 --> DGMurdockIII has joined #instantbird
07:06:00 <-- Mook has quit (Quit: zzz)
07:06:58 <-- chrisccoulson has quit (Quit: Ex-Chat)
07:13:04 --> EionRobb has joined #instantbird
07:22:37 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 14.0/20120605113340])
07:38:02 <-- gerard-majax has quit (Ping timeout)
07:47:02 --> chrisccoulson has joined #instantbird
07:58:45 <-- FireFly_TB has quit (Ping timeout)
07:59:34 --> aleth has joined #instantbird
07:59:34 * ChanServ sets mode +h aleth 
07:59:45 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
07:59:53 --> aleth has joined #instantbird
07:59:53 * ChanServ sets mode +h aleth 
07:59:58 <-- Mic has quit (Ping timeout)
08:09:00 --> TestFliege has joined #instantbird
08:14:35 <-- TestFliege has quit (Quit: TestFliege)
08:16:44 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1427 to FIXED.
08:16:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1427 enh, --, ---, clokep, RESO FIXED, Fix up order and formatting of of IRC tooltips.
08:26:16 --> gerard-majax has joined #instantbird
08:43:08 --> FireFly_TB has joined #instantbird
08:49:51 --> Mic has joined #instantbird
08:49:51 * ChanServ sets mode +h Mic 
08:59:05 --> sonny has joined #instantbird
08:59:20 <Mic> aleth: another crazy idea: what about completing channel names after /join? ;)
09:01:19 --> flo has joined #instantbird
09:01:20 * ChanServ sets mode +qo flo flo 
09:01:46 <aleth> Mic: Not a bad idea actually, but it depends on obtaining/handling the channel list in the first place, which I think clokep has planned for some point in the future ;)
09:02:14 <Mic> And a way to know what to complete after what ...
09:03:24 <aleth> the # may help here ;)
09:04:10 <Mic> Or that it is following /join. (i.e. different sources for completion for different commands)?
09:04:35 <Mic> From the channel list, participant list, ..
09:05:27 * flo restarts on an up to date nightly instead of the debug build
09:05:37 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:05:41 <aleth> Maybe, but I think it's good not to try to be /too/ clever
09:07:05 <-- gerard-majax has quit (Ping timeout)
09:07:14 --> flo has joined #instantbird
09:07:14 * ChanServ sets mode +qo flo flo 
09:09:54 <flo> I hope my crashes yesterday with the debug build were just bad luck
09:11:33 --> mmkmou has joined #instantbird
09:12:26 <flo> I'm happy to see a patch in https://bugzilla.mozilla.org/show_bug.cgi?id=756277 :)
09:13:07 --> Mic|web has joined #instantbird
09:15:44 <Mic> oops, /me accidently tried to set a key for #instantbird :D
09:15:54 <Mic> Thank god, I'm no op ;)
09:16:37 <flo> aleth, Mic: fwiw, I would really like us to complete everything all the time
09:16:38 --> FeuerFliege has joined #instantbird
09:16:48 <flo> complete status message with previously frequently used messages
09:16:57 <flo> complete channel/conversation names
09:17:19 <flo> complete long words based on the vocabulary that the user frequently uses
09:17:39 <Mic> Maybe we even have that on a wiki-page already.
09:17:54 <Mic> We certainly talked about that (including the latter) once.
09:18:21 <FeuerFliege> hi
09:18:25 <Mic> Hi FeuerFliege
09:19:39 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
09:49:00 <-- Mic has quit (Connection reset by peer)
09:50:31 --> gerard-majax has joined #instantbird
10:05:13 <-- FeuerFliege has quit (Ping timeout)
10:05:13 <-- FireFly_TB has quit (Ping timeout)
10:05:40 --> meh has joined #instantbird
10:08:37 --> FireFly_TB has joined #instantbird
10:08:49 --> FeuerFliege has joined #instantbird
10:14:23 --> Optimizer has joined #instantbird
10:43:46 <aleth> No crashes yet :)
10:56:47 <-- Optimizer has quit (Ping timeout)
11:00:42 --> Optimizer has joined #instantbird
11:28:31 <instantbot> New Instantbird (UI) bug 1494 filed by florian@instantbird.org.
11:28:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1494 nor, --, ---, nobody, NEW, Port Bug 739644 - provide an indication that an item is expanded or collapsed to group.xml
11:44:54 <-- EionRobb has quit (Quit: Leaving.)
12:04:37 --> Mic has joined #instantbird
12:04:37 * ChanServ sets mode +h Mic 
12:07:22 --> jb has joined #instantbird
12:12:46 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:14:10 --> Mic has joined #instantbird
12:14:11 * ChanServ sets mode +h Mic 
12:14:17 <-- Mic has quit (Quit: Mic)
12:14:21 --> Mic has joined #instantbird
12:14:21 * ChanServ sets mode +h Mic 
12:19:17 <-- jb has quit (Ping timeout)
12:27:43 --> Mic2 has joined #instantbird
12:29:44 <-- Mic2 has left #instantbird ()
12:31:15 --> jb has joined #instantbird
12:34:39 --> jb1 has joined #instantbird
12:44:02 <Mic> Optimizer: I looked at "Mibbit" again and the only reason I rejected the review request is that linking to rooms doesn't work correctly when it is not an IRC room (most common case will be Twitter hashtags on the timeline) that will turn into links that won't work.
12:44:25 <Mic> Adding a check for the protocol-id should be easy though.
12:44:26 <Optimizer> oh, so how to overcome that ?
12:55:26 <Mic> Something like that: http://pastebin.instantbird.com/44890
12:56:48 --> deomega1 has joined #instantbird
12:56:52 <Mic> In this case nothing is loaded unless you're in an IRC channel.
12:57:09 <Mic> (from what I saw).
12:57:28 <deomega1> Mic: just fyi.. I have had no problems with the addon  so far.
12:57:31 <deomega1> good morning
12:57:56 <Mic> The license headers and the plist-file look like they're copied from somewhere, you might want to put your name somewhere (or remove the one of other themes/extensions;)
12:58:00 <Mic> Good morning deomega1
13:09:20 <Optimizer> :D
13:09:31 <Optimizer> okay I will change the license headers
13:10:52 <Optimizer> Mic: If I do the change that you specified, then the nick highlighting will also not work
13:11:01 <Optimizer> is nick highlighting also limited to irc ?
13:11:41 <Mic> Yes, it won't work either and no I don't think it needs/should be limited to IRC.
13:12:42 <Mic> My suggestion was the simplest I could think of as you have a single text modifier that includes the channel linkification. 
13:14:50 <-- gerard-majax has quit (Ping timeout)
13:15:42 <Mic> deomega1: I'm adding support for some simple preferences at the moment. You'll be able to turn off e.g. the account connection stuff or restoring conversations (in case that you're only interested in status and status message).
13:16:37 <deomega1> great.  I am interested in status message yes, but  I am also important in it remembering my  conversation windows size and positions
13:16:56 <deomega1> those are the two  things for me
13:17:09 <Mic> That's a while off. I looked into the windows stuff already and it's not as easy as I hoped ;)
13:17:38 <deomega1> ah, ok.  Happy for what you have done so far anyway
13:17:48 <deomega1> very thankful
13:18:30 <Mic> Thanks :)
13:19:15 <Optimizer> btw deomega1 are you using my addon ?
13:19:32 <deomega1> Optimizer:  which one?
13:19:36 <Optimizer> mibbit
13:20:15 <Optimizer> or you were referring to your own addon while saying this to Mic  just fyi.. I have had no problems with the addon so far.
13:21:16 <deomega1> oh,  for message style.. I am sorry but no.  I am kinda hooked on or need addons that has the user icon next to the message
13:21:35 <deomega1> sorry i was  speaking to mic about his addon.. session restore
13:23:54 <Optimizer> oh
13:29:00 <deomega1> i see pictures before i see names :).. so when i glance, i know who's window i am speaking in,.. in the windows that are tall.  but  also helps a lot for the twitter feeds.  ne glance and u know who the tweet is from.
13:31:38 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
13:31:47 --> Mic has joined #instantbird
13:31:47 * ChanServ sets mode +h Mic 
13:33:02 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
13:33:08 --> Mic has joined #instantbird
13:33:09 * ChanServ sets mode +h Mic 
13:33:32 <-- Mic has left #instantbird ()
13:34:11 --> Mic has joined #instantbird
13:34:12 * ChanServ sets mode +h Mic 
13:34:34 <-- Mic has left #instantbird ()
13:47:22 --> Mic has joined #instantbird
13:47:22 * ChanServ sets mode +h Mic 
13:47:32 <-- Optimizer has quit (Ping timeout)
13:50:54 --> Optimizer has joined #instantbird
13:56:40 <-- jb1 has quit (Ping timeout)
13:56:50 <-- jb has quit (Ping timeout)
13:57:11 <-- Kaishi has quit (Quit: Kaishi)
13:57:15 --> Kaishi has joined #instantbird
13:58:18 <-- Mic has left #instantbird ()
14:10:06 <-- Optimizer has quit (Ping timeout)
14:13:28 --> Optimizer has joined #instantbird
14:13:30 --> devfil has joined #instantbird
14:14:54 --> Mic has joined #instantbird
14:14:54 * ChanServ sets mode +h Mic 
14:15:38 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
14:16:56 <-- Optimizer has quit (Ping timeout)
14:20:20 --> Optimizer has joined #instantbird
14:23:01 <-- Optimizer has quit (Ping timeout)
14:26:38 --> Optimizer has joined #instantbird
14:27:04 <-- Mic has left #instantbird ()
14:29:50 --> Bollebib has joined #instantbird
14:35:15 <-- Optimizer has quit (Ping timeout)
14:38:44 --> Optimizer has joined #instantbird
14:43:00 <-- meh has quit (Ping timeout)
14:45:01 <-- Optimizer has quit (Ping timeout)
14:45:12 --> Mic has joined #instantbird
14:45:12 * ChanServ sets mode +h Mic 
14:47:00 --> Optimizer has joined #instantbird
14:53:30 --> jb has joined #instantbird
14:53:45 <-- jb has quit (Input/output error)
14:53:46 --> jb has joined #instantbird
15:02:25 --> meh has joined #instantbird
15:04:22 <-- Optimizer has quit (Ping timeout)
15:07:43 --> Optimizer has joined #instantbird
15:10:14 --> mmkmou has joined #instantbird
15:14:03 --> jb1 has joined #instantbird
15:14:36 <-- Kaishi has quit (Input/output error)
15:23:17 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:35:39 <flo> when running ./thunderbird-bin --help, I've noticed a new command line option that I didn't know:
15:35:45 <flo>   -new-instance      Open new instance, not a new window in running instance.
15:37:05 --> wnayes has joined #instantbird
15:39:06 <-- Optimizer has quit (Ping timeout)
15:42:54 --> Optimizer has joined #instantbird
15:46:13 <instantbot> New Core - General bug 1495 filed by wnayes@gmail.com.
15:46:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1495 enh, --, ---, nobody, NEW, Create an account import wizard - GSoC 2012
15:46:38 <wnayes> Will put up the discussion from yesterday soon :)
15:47:10 <-- Optimizer has quit (Ping timeout)
15:50:33 --> Optimizer has joined #instantbird
15:52:30 <aleth> re the -P command line issues I was having: it seems the syntax now requires a space between P and the profile name in -P <profile>
15:57:30 <flo> aleth: I think the space has always been required
15:58:25 <aleth> My startup scripts used to work without ;) which doesn't mean they were correct
15:59:42 <instantbot> New Core - IRC bug 1496 filed by florian@instantbird.org.
15:59:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1496 nor, --, ---, nobody, NEW, test_ctcpFormatToText and test_mIRCColor aren't executed
16:02:33 --> myk has joined #instantbird
16:14:49 <-- Even1 has quit (Ping timeout)
16:17:38 <-- jb has quit (Quit: jb)
16:18:12 --> Even1 has joined #instantbird
16:18:37 <instantbot> wnayes@gmail.com denied review for attachment 1574 on bug 1495.
16:18:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1495 enh, --, ---, wnayes, ASSI, Create an account import wizard - GSoC 2012
16:19:10 --> jb has joined #instantbird
16:30:25 <instantbot> florian@instantbird.org set the Resolution field on bug 335 to WORKSFORME.
16:30:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=335 min, --, ---, nobody, RESO WORKSFORME, Going offline should stop reconnection timers
16:30:31 <flo> 1.2 list-- ;)
16:31:09 <flo> and I've found a Tb bug that looks like a good excuse to fix some of the mishandlings of imAccounts.js
16:31:25 <flo> https://bugzilla.mozilla.org/show_bug.cgi?id=742673
16:34:45 <-- wnayes has quit (Ping timeout)
16:34:55 <aleth> already fixed :) or at least partly...
16:37:47 <flo> https://bugzilla.mozilla.org/show_bug.cgi?id=762171 annoys me. I can't really decide if there's likely something I should check there by downloading a Tb13 release and trying to reproduce, of if it's just a case of gentoo screwing things up :-S.
16:38:20 --> wnayes has joined #instantbird
16:39:56 <aleth> "Steps to reproduce: finished tb" what does that mean?
16:40:00 <flo> aleth: this is the patch I currently have: http://pastebin.instantbird.com/44910
16:40:20 <aleth> Gentoo isone where everyone does their own build, right? Hard for you to test...
16:40:44 <flo> aleth: that means the report is annoying from the first line of it ;). But he meant "I saw this message in my terminal at shutdown, and I thought you may be interested in knowing it."
16:41:14 <aleth> Why not consider it unconfirmed until someone reproduces?
16:41:14 <flo> aleth: not only they do their own build, but they all tweak their own build configuration...
16:41:57 <flo> because something attempting to open a chat tab at shutdown on a release where chat is supposed to be pref'ed off sounds scary :)
16:42:29 <aleth> Oh, I see. I thought he had pref'd it on. Didn't look at the small print...
16:43:42 <flo> so about the patch I've just pastebined: I wonder if this is enough, or if I should add another check before the call to _startReconnectTimer
16:45:32 <aleth> Add a second check with a LOG message, then it will be interesting if it shows up. Probably better to be on the safe side for little cost.
16:45:35 <flo> that would be guarding against broken prpls disconnecting the account with an error when we call .disconnect() on them
16:48:59 <aleth> Yes, something would have to go wrong for it to happen. In which case one is probably grateful to have a warning for debugging.
16:50:55 <flo> and I wonder if we should call cancelReconnection when the account was connecting at the time we switched to offline
16:52:38 <aleth> I thought that was for when it is between connection attempts?
16:52:52 <aleth> But if disconnect doesn't kill the timer, maybe
16:53:49 <aleth> And it doesn't kill the timer.
16:55:11 <flo> the corner case I'm thinking about is: we tried to reconnect a bunch of times, so the next attempt will be in ~an hour. Then we go offline. Then we go back online. Going online will force a reconnection attempt. But if it fail, we could do the next attempt in ~an hour. That seems wrong
16:55:17 <flo> does this make sense?
16:55:25 <aleth> You could simply remove the "else" in line 36 of your patch?
16:56:01 <flo> and stop testing for this._reconnectTimer?
16:56:11 <aleth> Ah no, sorry. But you see what I meant I guess
16:56:25 <aleth> Yes
16:56:37 <flo> we will have a timer only when we are disconnected and waiting for the next attempt
16:57:27 <flo> wait, so my corner case was actually if there was an ongoing connection attempt at the time we went offline
16:57:42 <aleth> Yes
16:57:56 <aleth> The question is, is it certain no timer exists yet in that case
16:58:13 --> Mook_astb has joined #instantbird
16:58:34 --> Mic has joined #instantbird
16:58:35 * ChanServ sets mode +h Mic 
16:59:40 <flo> aleth: my patch now looks like this: http://pastebin.instantbird.com/44911
17:00:28 <aleth> So if we go offline, everything is reset. That seems good.
17:01:30 <flo> it may call cancelReconnection slightly too often, but that method is cheap and harmless
17:01:46 <flo> but the code seems less error prone
17:01:56 <aleth> Yes, its much more robust that way
17:02:45 <flo> ok, I'll attach it like this and wait for clokep to come back from his week-end to review it :)
17:03:00 <aleth> another step closer to 1.2 :)
17:03:26 <flo> maybe
17:03:44 <aleth> hopefully...
17:03:46 <flo> hmm, I wonder if there isn't another bug in https://bugzilla.mozilla.org/show_bug.cgi?id=742673
17:05:33 <aleth> I just tried testing that on IB and I may have found another bug
17:06:15 <aleth> Start instantbird with -status offline, and the status is indeed displayed as offline. But autojoin accounts do connect, autojoin channels connect, and you can send messages to them,.
17:06:38 <flo> ah, that's not the bug I was finding
17:07:02 <flo> the "start offline" the reporter talks about in that bug is the checkbox of the profile manager
17:07:15 <aleth> Ah.
17:09:16 <-- meh has quit (Ping timeout)
17:09:19 <flo> but your bug is valid too :)
17:09:22 <flo> wanna fix it? :)
17:09:47 <aleth> Going to file it first ;)
17:10:01 <instantbot> New Core - General bug 1497 filed by aletheia2@fastmail.fm.
17:10:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1497 nor, --, ---, nobody, NEW, "-status offline" command line parameter doesn't stop accounts from connecting
17:10:13 <aleth> I wonder if anyone ever uses that flag...
17:10:52 <flo> if someone uses an add-on to remember the previous status, the effect will be the same, won't it?
17:11:16 <aleth> Depends on how it's done I suppose
17:11:35 <flo> I think you want to change this check a little bit: http://mxr.mozilla.org/comm-central/source/chat/components/src/imCore.js#271
17:12:19 <aleth> Right.
17:12:50 <Mic> aleth: the shortcuts in the Windows 7 jumplist use this flag to change the status.
17:13:02 <flo> Mic: the flag works
17:13:16 <aleth> The status is changed, it's just ignored for that purpose
17:13:16 <flo> Mic: the problem is we don't check which status we have at startup before processing auto-login
17:14:52 <flo> aleth: btw, should we also check that in imAccounts.js:connect?
17:15:56 <aleth> flo: Won't it throw after your latest patch lands?
17:16:07 <flo> my patch throws if necko is offline
17:16:11 <aleth> Ah no, Services.io.offline won't be true
17:16:27 <flo> because prpls will technically have all sorts of difficulties attempting to connect accounts while there's no socket thread ;)
17:16:39 <aleth> Seems a good idea to check for that too then.
17:17:00 <aleth> (that = status offline)
17:18:06 <flo> so that will fix your bug, but isn't clean ;)
17:18:16 <aleth> I think doing both is better.
17:18:42 <aleth> Nothing really should be calling connect when offline.
17:18:59 <aleth> Unless you think that's a good place to handle that...
17:19:05 <flo> but then when you switch back from offline, shouldn't you process autologin automatically?
17:19:21 <aleth> Won't that still happen?
17:19:35 <aleth> If I switch from offline to available, my autoconnect accounts do autoconnect
17:19:37 <flo> http://lxr.instantbird.org/instantbird/search?string=processAutoLogin
17:19:46 <flo> aleth: they *re*connect
17:19:49 <flo> that's different
17:19:59 <aleth> Oh, I didn't realize that :-/
17:20:47 <flo> if there's no status observer (set at http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#581) they won't reconnect
17:20:58 <flo> so maybe calling connect with status = offline shouldn't fail then?
17:21:07 <flo> but just return before that line: http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#604
17:21:30 <flo> but in that case there's no reason for it to fail with necko is offline either
17:21:32 <flo> hmm
17:22:18 <aleth> Hmm. 
17:22:41 <flo> uh, and why do we set the status observer even if the account doesn't have a valid prpl? :-S
17:22:49 <flo> that makes no sense
17:22:52 <aleth> Something is odd there
17:22:57 <aleth> I'm confused
17:23:03 <aleth> gtg for now though...
17:23:12 <flo> the handling of the various offline status have always been messy and confusing
17:23:18 <flo> yeah, I'll go home too :)
17:23:22 <flo> will think about it
17:23:37 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:23:41 --> meh has joined #instantbird
17:26:34 <-- meh has quit (Ping timeout)
17:28:41 --> meh has joined #instantbird
17:32:13 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:40:46 <-- jb1 has quit (Ping timeout)
17:40:46 <-- jb has quit (Ping timeout)
17:43:56 <-- skeledrew has quit (Ping timeout)
17:43:56 <-- deomega1 has quit (Ping timeout)
17:47:21 --> skeledrew has joined #instantbird
17:47:36 --> deomega1 has joined #instantbird
17:55:28 --> jb has joined #instantbird
18:01:27 --> jb1 has joined #instantbird
18:03:48 --> DGMurdockIII has joined #instantbird
18:04:13 <-- Even1 has quit (Ping timeout)
18:07:31 --> Even1 has joined #instantbird
18:09:44 --> Lalae has joined #instantbird
18:10:14 <-- Lalae has left #instantbird ()
18:10:21 <-- Mook_astb has quit (Quit: Mook_astb)
18:10:38 --> Mook_astb has joined #instantbird
18:11:18 --> Mnyromyr has joined #instantbird
18:15:12 <-- jb1 has quit (Ping timeout)
18:15:43 <-- jb has quit (Ping timeout)
18:27:07 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
18:28:15 --> jb has joined #instantbird
18:39:24 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:46:02 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 14.0/20120605113340])
18:47:57 --> DGMurdockIII has joined #instantbird
19:00:07 <-- Optimizer has quit (Ping timeout)
19:20:16 --> Suiseiseki has joined #instantbird
19:25:32 <-- jb has quit (Ping timeout)
19:31:29 <-- sonny has quit (Client exited)
19:48:43 <-- mmkmou has quit (Ping timeout)
19:50:05 <-- Bollebib has quit (Ping timeout)
20:12:03 --> Lalae has joined #instantbird
20:12:26 <-- Lalae has left #instantbird ()
20:28:49 <-- FeuerFliege has quit (Connection reset by peer)
20:28:49 <-- FireFly_TB has quit (Quit: FireFly_TB)
20:35:55 <instantbot> New Instantbird (UI) bug 1498 filed by aletheia2@fastmail.fm.
20:35:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1498 nor, --, ---, nobody, UNCO, "this.buddy is undefined" on merging two IRC buddies
21:29:03 --> FireFly_TB has joined #instantbird
21:29:27 <-- FireFly_TB has quit (Connection reset by peer)
21:30:09 --> flo has joined #instantbird
21:30:09 * ChanServ sets mode +qo flo flo 
21:39:42 --> Bollebib has joined #instantbird
21:39:53 <flo> I'm glad the fix from https://bugzilla.mozilla.org/show_bug.cgi?id=756277 works :)
21:41:21 <-- Mook_astb has quit (Quit: Mook_astb)
21:41:49 --> jb has joined #instantbird
21:42:43 <aleth> This is what I came up with so far http://pastebin.instantbird.com/44933
21:43:16 <aleth> (and then no changes to imCore.js)
21:43:18 --> Kaishi has joined #instantbird
21:43:54 <aleth> Oh nice, and you didn't even have to fix it yourself ;)
21:45:27 --> jb1 has joined #instantbird
21:48:49 <flo> aleth: I don't know that code at all, so that would have taken months ;)
21:49:16 <-- jb has quit (Quit: jb)
21:50:11 --> jb has joined #instantbird
21:52:01 <flo> aleth: I thought about it a bit more while driving. I don't think we can fix & clarify the situation without relatively important changes
21:52:27 <flo> I think we should keep the "connect"/"disconnect" buttons enabled in the account manager even when the status is OFFLINE
21:52:27 <-- jb1 has quit (Ping timeout)
21:52:52 <-- jb has quit (Ping timeout)
21:52:56 <flo> and clicking "connect" while offline would just change the message from "Not connected" to "Will be connected when leaving the offline status"
21:53:19 <flo> (would be better if we could find a shorter wording)
21:53:33 <aleth> That kind of fits with my patch above: That will work OK when offline, it will then connect when we next go online
21:54:00 <aleth> (unless I have missed something)
21:54:08 <flo> aleth: but disconnect should also work when the account is already disconnected because we are offline ;)
21:54:11 <aleth> What you are describing seems part of the account.xml redesign
21:54:24 <flo> it's a change of the core behavior
21:55:07 <flo> the current behavior around the offline status is very poorly defined, so the implementation is confusing because we keep addressing specific small annoyances instead of implementing something that makes sense overall
21:55:43 <flo> it's too bad that I "discover" that after the Tb string freeze :(
21:55:44 <aleth> flo: "but disconnect should also work when the account is already disconnected because we are offline" I don't understand, disconnect already removes the observer
21:55:57 --> deomega1 has joined #instantbird
21:56:01 <aleth> I agree the current behaviour seems poorly defined
21:56:09 <flo> oh right :)
21:56:30 <flo> aleth: but it shouldn't call this._ensurePrplAccount.disconnect if the account is already disconnected
21:56:54 <aleth> Right. That should be added.
21:57:22 <aleth> disconnect needs a similar if clause to the one I just added to connect
21:57:29 <flo> and it's not really clear to me how these changes can work without string changes
21:57:51 <aleth> Well, without the string changes, the user is less well informed, but it will work...
21:58:32 <flo> the "this._ensurePrplAccount;" at the begining seems like code obfuscation to me ;)
21:58:43 <flo> have you looked up how that method is implemented? :)
21:58:48 <aleth> Yes.
21:58:52 <aleth> It's not nice, I agree
21:58:53 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:59:03 --> deomega1 has joined #instantbird
21:59:06 <flo> you can just do a null check instead :)
21:59:29 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:59:30 <aleth> Just didn't want to duplicate that code...
22:00:56 <flo> aleth: and we also need another new string in the account manager for the cases where we are currently in the offline status, and another one for when necko is offline
22:01:15 <flo> the current "because you started offline" is quite confusing if it's not true or if the user has switched to online since that :)
22:01:40 <aleth> Good idea.
22:01:59 <aleth> Like we differentiated in conversation.xml when the user tries to send while offline
22:02:10 <aleth> http://pastebin.instantbird.com/44939
22:02:39 <-- myk has quit (Ping timeout)
22:03:43 --> myk has joined #instantbird
22:04:05 <aleth> Those account manager changes could just be added to the todo list in bug 1219...
22:04:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1219 tri, --, ---, nobody, NEW, Cleanup the account.xml binding
22:06:30 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
22:06:52 <flo> aleth: if the behavior without the string changes is still consistent, yes
22:07:04 <aleth> "This account will connect as soon as possible." as a string?
22:07:31 <flo> what does that mean?
22:07:51 <flo> that we have stacked 1k idle sockets and the new sockets for this connection are waiting in line? ;)
22:08:02 <aleth> :D
22:08:11 <aleth> no, for "Will be connected when leaving the offline status"
22:08:40 <flo> I'm surprised by how much faster Firefox 13 feels compared to the previous version.
22:08:41 <aleth> actually the best thing would be two strings
22:08:59 <aleth> flo: I agree, today I updated to FF 15 and again it is quite impressive
22:09:08 <flo> gmail especially, but also scrolling in general
22:09:09 <aleth> More responsive.
22:09:49 <flo> but I've noted several times that Fx12 started getting really slow after eating 800MB of memory, because at that point all GC and CC executions started to take more than 100ms on my machine
22:09:53 <aleth> Kudos to the snappy team (I guess)
22:10:36 <flo> Fx13 is currently at 460MB and hasn't reached 600MB ever since I upgraded to it Tuesday
22:11:20 <flo> (I tend to restart Firefox only for updates, or when it gets unbearably slow, which with fx12 typically happened when it was at 1Gb of memory used)
22:11:31 <flo> aleth: snappy, but also memshrink! ;)
22:12:07 <aleth> Right, I remember there was a big change around FF12-13... since then I rarely see >400M
22:12:24 <aleth> Which is quite impressive considering how many tabs I have...
22:12:55 <aleth> But I restart more often, so I wouldn't run into the leak issues you may have encountered
22:13:33 <flo> but when I see Firefox with dozens of tabs at 460MB, and Ib with 5 conversation tabs + a dozen conversations on hold at 130MB, I feel that something is inefficient on our side ;).
22:14:06 <flo> I think they fixed a quite severe leak on Gmail recently :).
22:14:30 <flo> not sure if it's been approved for 13 or if it will be a pleasant surprise in a few weeks :)
22:15:08 <flo> aleth: where are you going to attach that patch?
22:15:24 <aleth> That bug I filed earlier, I guess
22:15:31 <flo> ok
22:15:41 <aleth> I'll just add your change to socket.jsm, then put it up
22:16:13 <flo> I'm still a bit concerned by the situation "I started offline, then when online, then when I go to the account manager I see a notification bar saying my accounts aren't connected because blahblah"
22:16:49 <flo> something still feels wrong in that case
22:17:31 <aleth> What's the precise scenario?
22:17:41 <aleth> status offline, then online?
22:17:56 <flo> no
22:17:59 <flo> necko offline
22:18:06 <flo> then online
22:18:27 <flo> I'm feeling that http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#777 (777-781) should disappear
22:18:32 <flo> that we should process the autologin in that case
22:18:51 <flo> and just accounts will automatically be connected whenever the network is available
22:19:01 <aleth> Yes
22:19:04 <aleth> I missed that.
22:19:06 <aleth> Good catch.
22:19:10 <aleth> That's the behaviour I wanted.
22:19:44 <flo> but then, that AUTOLOGIN_START_OFFLINE value is meaningless, isn't it?
22:20:36 <flo> and then we should get rid of the "you started offline" case in the account manager, and replace it with "currently no network connection"
22:20:51 <aleth> True.
22:21:03 <flo> and we are back to ... needs strings
22:21:27 <flo> (although I guess for Tb15 using the strings that mentions "offline", even if it talks about startup, would be quite OK)
22:23:18 <aleth> It definitely needs changed strings to be really clear. But I suppose we can see with IB how confusing it looks without.
22:23:34 <aleth> Makes that redesign more urgent...
22:26:42 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1575 on bug 1497.
22:26:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1497 nor, --, ---, nobody, NEW, "-status offline" command line parameter doesn't stop accounts from connecting
22:27:00 <flo> aleth: and also way more interesting ;)
22:27:41 <flo> rewriting the code without improving anything in the behavior is boring ;)
22:27:48 <aleth> :)
22:28:13 <flo> but if you can make the behavior much better and the code half the previous length, it feels great :)
22:28:36 <aleth> It's the best when you can fix a bug and the code is much more elegant after...
22:28:49 <aleth> Not all bugs are like that unfortunately.
22:29:04 <flo> you have that situation when we have already fixed too many bugs
22:29:25 <flo> and then instead of fixing bugs, you start fixing the situation that caused the bug to creep in in the first place :)
22:29:47 <flo> too bad a fast firefox doesn't increase the speed of bugzilla servers ;)
22:29:57 <aleth> yes...
22:30:13 <aleth> In fact it makes bugzilla feel slower :P
22:30:40 <flo> where is the { opened in |if (Services.io.offline) {| closed?
22:31:23 <flo> (I was also wondering that on your pastebin)
22:31:39 <aleth> :(
22:31:43 <aleth> copy/paste error
22:32:52 <flo> that makes me wonder how much you have tested this patch ;)
22:33:03 <aleth> I have not tested this patch at all
22:33:32 <flo> that's what I thought! ;)
22:33:44 <aleth> I was getting to that...
22:35:01 <flo> and an empty line before if (!Services.io.offline && ...) in the connect method maybe?
22:35:34 <aleth> There is one already
22:35:41 <flo> or is there one already that has been eaten by bugzilla? :(
22:35:42 <aleth> (bugzilla may swallow it)
22:36:34 <flo> I wonder why bugzilla displays line numbers if they aren't even right :-S
22:36:35 <aleth> A brief test of the issue in the bug... and it seems to work well :)
22:37:11 <aleth> It's really confusing sometimes.
22:37:37 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1575 on bug 1497.
22:37:38 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1576 on bug 1497.
22:37:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1497 nor, --, ---, aletheia2, ASSI, "-status offline" command line parameter doesn't stop accounts from connecting
22:39:31 <-- DGMurdockIII has quit (Ping timeout)
22:39:47 <aleth> This is the kind of behaviour change that does need testing in nightlies I think. I'm not sure there aren't edge cases I haven't thought of yet.
22:39:52 <flo> it feels ok for the core changes
22:40:02 <flo> but it also feels like it really misses comments
22:40:05 <flo> both in the code and in the bug
22:40:15 <aleth> I was about to write one for the bug
22:40:21 <flo> in 6 weeks we will have no idea of why we made these changes
22:41:09 <aleth> Since it's a behaviour change, the appropriate place for the comment seems the bug
22:41:15 <flo> how difficult would it be to separate the pure bugfix from the behavior change?
22:41:49 <aleth> Not difficult really.
22:42:05 <aleth> Though I am not sure they work well when separated.
22:42:32 <aleth> The behaviour change is the additional final if clause in connect and disconnect
22:43:56 <flo> and the removal of one value for the autologinstatus ;)
22:44:06 <aleth> Yes.
22:44:37 <-- chrisccoulson has quit (Quit: Ex-Chat)
22:44:45 --> chrisccoulson has joined #instantbird
22:44:55 <flo> how would it feel to land only the bugfix now
22:45:12 <flo> and land the behavior changes with the account manager cleanup?
22:45:24 <flo> (it will come soon now that we have built some motivation for it, won't it?)
22:46:07 <-- Tonnes has quit (Ping timeout)
22:46:12 <aleth> Then you'd better file a separate bug for the bugfix. The behaviour changes *are* what fixes that bug
22:46:59 --> Tonnes has joined #instantbird
22:48:05 <flo> would the bug on bmo fit for the bugfix?
22:48:22 <aleth> I thought you said that was a separate issue again?
22:48:29 <flo> https://bugzilla.mozilla.org/show_bug.cgi?id=742673
22:49:27 <flo> I'm really not sure of what that bug is exactly about :-/
22:49:33 <aleth> Nor am I
22:49:40 <aleth> I vote for a fresh bug for clarity
22:50:01 <aleth> Then when it's all landed, ask the original reporter to test again...
22:50:48 <flo> ok with me
22:52:11 <flo> I don't remember if the cleanup account.xml bug is clear or not. what I want is: a single description tag or all the states, and a single button for connect and disconnect, so that we can accidentally put the disabled attribute on the wrong button because of a race condition
22:54:51 <aleth> And then there will definiitely no longer buttons that will be disabled when they shouldnt be ;)
22:55:29 <flo> not sure why you are saying that
22:55:57 <aleth> bug 1338
22:56:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1338 nor, --, ---, nobody, NEW, Connect button is disabled after an account spends more than half a second in the disconnecting stat
22:56:28 <flo> sure, it will fix that bug :)
22:56:49 <flo> I was just wondering if you were saying that we wouldn't disable any button any more because we can now click connect/disconnect even when offline
22:56:50 <aleth> Do you have a good title for that new bug?
22:57:07 <flo> we still want to disable the button for half a second to avoid unwanted double clicks
22:58:06 <aleth> Yes, that makes sense.
22:58:34 <flo> "Avoid attempting to connect accounts while offline"?
23:01:34 <instantbot> New Core - General bug 1499 filed by aletheia2@fastmail.fm.
23:01:35 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1577 on bug 1499.
23:01:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1499 nor, --, ---, nobody, ASSI, Avoid attempting to connect accounts while offline, and disconnect connecting accounts when going of
23:02:25 <aleth> A shorter title than ^^ would be better...
23:03:38 <-- wesj has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:07:43 <flo> clokep will have a lot of bugmail at the end of the week-end ;
23:07:43 <flo> )
23:07:59 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1576 on bug 1497.
23:08:00 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1578 on bug 1497.
23:08:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1497 nor, --, ---, aletheia2, ASSI, "-status offline" command line parameter doesn't stop accounts from connecting
23:08:47 <aleth> You may want to add to/modify the comments in those bugs
23:08:57 <aleth> I may have forgot something...
23:10:16 <flo> shouldn't bug 1499 throw in connect: if Services.io.offline?
23:10:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1499 nor, --, ---, nobody, ASSI, Avoid attempting to connect accounts while offline, and disconnect connecting accounts when going of
23:10:28 <flo> (even if the next patch removes it a few seconds later)
23:10:37 <flo> (I'm not sure we will take the next patch for Tb15)
23:11:05 <aleth> Maybe. Won't it throw in sockets.jsm or the libpurple equivalent anyway?
23:11:23 * aleth is lazy and doesn't feel like changing those two patches again 
23:13:03 <flo> the problem is (for IRC at least) it will throw after the reportConnecting call in irc.js
23:13:13 <aleth> ah.
23:13:17 <flo> so the account will be stuck on Connecting...
23:13:34 <flo> it's something I was trying to address when we started that discussion ;)
23:13:56 <aleth> I knew there was a reason I disliked separating out patches...
23:14:25 <flo> I suspected it wasn't that easy ;)
23:15:29 <flo> nobody has complained about the oauth dialog not showing up in instantbird, but I wonder if we should take the XHR patch for 1.2 "just in case"
23:15:51 <aleth> keeping things in sync...
23:17:09 <flo> that would required backporting to moz13 in this case ;)
23:19:13 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1577 on bug 1499.
23:19:14 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1579 on bug 1499.
23:19:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1499 nor, --, ---, nobody, ASSI, Avoid attempting to connect accounts while offline, and disconnect connecting accounts when going of
23:21:48 <aleth> bah, shouldn't have hand edited that.
23:22:06 <-- myk has quit (Ping timeout)
23:22:08 --> myk has joined #instantbird
23:23:58 <aleth> I suspect some line counts will be off in that patch... but you'll notice when applying.
23:25:49 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1578 on bug 1497.
23:25:50 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1580 on bug 1497.
23:25:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1497 nor, --, ---, aletheia2, ASSI, "-status offline" command line parameter doesn't stop accounts from connecting
23:26:24 <aleth> There, that generated some copious amounts of bugspam.
23:45:38 --> EionRobb has joined #instantbird
23:48:37 <-- myk has quit (Ping timeout)
23:50:23 <-- Suiseiseki has quit (Quit: Leaving)
23:51:13 --> myk has joined #instantbird
23:55:21 <-- Bollebib has quit (Quit: Instantbird 1.1)
23:55:36 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)