All times are UTC.
00:00:32 <clokep> Mook_as: You guys don't have like off today in Canada because of the Stanley Cup Final? :P 00:01:41 <Mook_as> nah, the local team's already out of the running 00:02:06 <Mook_as> otherwise, yeah, we'd be getting out to avoid the riots... :p 00:02:10 <clokep> Yeah, I'm rooting for the Kings (or maybe against the Devils.) 00:02:15 <clokep> Hahah. 00:02:27 <clokep> I'm (unfortunately) an Islanders fan so...they're always out early. :) 00:06:00 <-- myk has quit (Ping timeout) 00:08:23 --> jb has joined #instantbird 00:10:59 <instant-buildbot> build #269 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/269 00:31:32 <-- Bollebib has quit (Quit: Instantbird 1.1) 00:31:59 * clokep just tried to do ctrl+shift+w to bring back a closed tab. :( 00:49:30 <Mook_as> hmm, I forget how to send a path on gtalk. ctrl+enter, shift+enter, neither seemed to be able to stop interpreting the string /c/mozilla-build/wget/wget.exe as a command 00:50:58 <clokep> Mook_as: // in the front. 00:51:21 <clokep> Or /say <blah blah> 00:51:29 <Mook_as> oh, right, /say 00:51:42 <Mook_as> (my workaround was to stick a space in front; that works for now) 00:52:31 <clokep> That's honestly what I usually do. :) 00:52:48 <clokep> (Mook_as You can also do /help to see all comands btw!) 00:53:15 <Mook_as> okay; going home; see you later :D 00:53:17 <-- Mook_as has quit (Quit: gone) 00:55:19 <-- EionRobb has quit (Ping timeout) 00:55:28 --> EionRobb has joined #instantbird 01:11:08 <-- Suiseiseki has quit (Ping timeout) 01:13:11 --> Suiseiseki has joined #instantbird 01:31:11 <instant-buildbot> build #238 of macosx-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/238 blamelist: Patrick Cloke <clokep@gmail.com> 01:35:44 * clokep is confused about whether that error is his fault or not. :-/ 01:55:59 <-- mmkmou has quit (Ping timeout) 02:04:53 <instant-buildbot> build #257 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/257 02:05:06 --> Mook has joined #instantbird 02:07:16 * clokep takes that to me it's not his fault. ;) 02:16:35 <-- jb has quit (Ping timeout) 03:01:31 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 03:25:50 <instant-buildbot> build #519 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/519 04:01:29 --> jb has joined #instantbird 04:18:58 <-- jb has quit (Ping timeout) 04:59:20 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603]) 05:05:21 <instant-buildbot> build #612 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/612 05:05:38 <-- EionRobb has quit (Ping timeout) 05:06:03 --> EionRobb has joined #instantbird 05:52:52 <instant-buildbot> build #509 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/509 06:14:19 <-- EionRobb has quit (Quit: Leaving.) 06:18:03 --> EionRobb has joined #instantbird 07:12:26 <EionRobb> you chaps seen the stats collected so far? http://pidgin-stats.alwaysdata.net/collectstats/display/ 07:22:20 --> sonny has joined #instantbird 07:31:09 --> Even has joined #instantbird 07:31:09 * ChanServ sets mode +o Even 07:43:45 <-- Kaishi has quit (Quit: Kaishi) 07:57:55 --> Mic has joined #instantbird 07:57:55 * ChanServ sets mode +h Mic 07:58:02 <-- Mic has quit (Input/output error) 07:58:14 --> Mic has joined #instantbird 07:58:14 * ChanServ sets mode +h Mic 08:00:13 <-- gerard-majax has quit (Ping timeout) 08:06:32 <-- sonny has quit (Client exited) 08:07:57 --> sonny has joined #instantbird 08:29:49 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:34:30 --> gerard-majax has joined #instantbird 08:37:26 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:37:31 --> Even1 has joined #instantbird 08:37:36 <-- Even1 has quit (Quit: Even1) 08:37:41 --> Even1 has joined #instantbird 08:39:48 --> aleth has joined #instantbird 08:39:48 * ChanServ sets mode +h aleth 08:41:30 --> Optimizer has joined #instantbird 08:42:37 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:42:45 --> aleth has joined #instantbird 08:42:45 * ChanServ sets mode +h aleth 08:42:46 --> Bollebib has joined #instantbird 08:47:56 --> flo has joined #instantbird 08:47:56 * ChanServ sets mode +qo flo flo 08:49:19 <-- Optimizer has quit (Ping timeout) 08:49:50 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:51:01 --> flo has joined #instantbird 08:51:01 * ChanServ sets mode +qo flo flo 08:53:13 <flo> so when I opened my laptop (and so neck went back from offline), all the sockets that failed to be created yesterday evening were created at once 08:53:34 <flo> and the amount of messages scrolling through the error console was insane :-( 08:54:23 <flo> and with my default profile on the debug build with logging enabled, after ~1 minute, I already have ~400 sockets handled by the socket transport service 08:54:52 <aleth> 400? Is that reasonable for your session? 08:54:59 <flo> no :) 08:55:08 * aleth was wondering how many tabs you had... 08:55:14 <flo> what's especially unreasonable is that the number never decrease 08:55:23 <flo> only one for #instantbird ;) 08:55:30 <flo> + 1 conversations on hold 08:55:41 <flo> but we have only one socket per XMPP or IRC account... 08:56:00 <aleth> Hmm, sounds like you may have found partial STR? 08:56:52 <flo> for the connected accounts, I have: 1 netsoul, 1 gtalk, 3 irc (2 moznet, 1 freenode), 2 AIM, 3 MSN, 1 yahoo, 1 facebook, and 2 twitter 08:58:09 <flo> "-1340452864[6358a0]: calling PR_Poll [active=18 idle=459]" 08:58:28 <flo> 18 sounds like a reasonable number of sockets 08:58:46 <flo> so why do sockets become idle instead of being removed? :-S 08:58:54 <aleth> Yes 08:59:11 <aleth> And why are they created in the first place, within 1 minute? 08:59:32 * flo suspects bug 1344 again 08:59:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1344 nor, --, 1.2, florian, RESO FIXED, stop using XPCOM proxies in purpleSockets 08:59:54 <flo> aleth: "And why are they created in the first place, within 1 minute?" for that it's easy to suspect extreme inefficiency on the part of the MSN prpl 09:00:20 <aleth> That sounds testable... 09:00:31 <flo> from what I remember of the last time I looked at sockets when working on purpleSockets for Ib 0.1, connecting an MSN account opens ~15 sockets + 1 per buddy in the list to fetch the buddy icon 09:00:40 <aleth> :( 09:01:04 <aleth> MSN-XMPP keeps sounding better :D 09:01:38 <flo> but they should be closed immediately after the server has replied, and not opened all at once (the icon requests are queued, and the 15 sockets during the connection/authentication are also things that are added then removed, then readded, ...) 09:01:43 <aleth> Though I suppose for now it's a good source of idle sockets ;) 09:01:56 <flo> hmm, what I called "socket" above was actually socket watchers 09:02:08 <flo> (each time libpurple asks us to notify it when a socket becomes ready) 09:02:18 <flo> so sometimes it may remove it and readd it 09:03:25 <flo> iirc the max # of sockets we can have in the socket transport service at once is around 1000 09:03:50 <flo> after all the initial connections are done, the number of sockets we have increases only slowly 09:04:36 <flo> so it's possible that it takes a few hours to reach 1000 09:04:57 <aleth> That would fit with the reported behaviour 09:05:01 <flo> so yeah, it sounds like I have a beginning of an explanation for part of the mess we are seeing 09:05:22 <flo> but the bug also happened on Tb at least once :-S. 09:07:41 <flo> each time I disconnect a JS-prpl, that removes 1 socket from the active count, and doesn't touch the idle count 09:08:40 <flo> that's also true when disconnecting libpurple accounts 09:08:59 <flo> I've disconnected all my accounts bug flo@moznet and I now have: calling PR_Poll [active=1 idle=533] 09:09:37 <aleth> Seems like idle socket watchers never get destructed 09:09:53 --> Tomek has joined #instantbird 09:10:51 <flo> I think I'll quit, and restart my build with purpleSocket logging enabled too (I currently have only nsSocketTransportService) and connect only one account at a time, to see if there's a specific guilty prpl. 09:11:27 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 09:11:40 --> Optimizer has joined #instantbird 09:13:29 --> flo has joined #instantbird 09:13:29 * ChanServ sets mode +qo flo flo 09:13:32 <aleth> You could count the "Stop listening" messages in the log? 09:14:28 <flo> so now with only flo@moznet connected, I have 1 active, 0 idle 09:15:31 <flo> if I add my gtalk account, I have 2 active 09:16:06 <flo> if I connect netsoul, I have 3 active, 127 idle (uh!) 09:16:49 <flo> connecting an AIM account makes the count go to 6 active, 164 idle 09:18:33 <-- Optimizer has quit (Ping timeout) 09:18:49 <flo> + 1 MSN -> 7 active, 205 idle 09:19:06 --> mmkmou has joined #instantbird 09:21:57 --> Optimizer has joined #instantbird 09:22:25 <flo> ok, going to restart on my normal nightly, and keep only a libpurple account to debug this on the debug build 09:22:29 <-- flo has quit (Input/output error) 09:24:34 --> flo has joined #instantbird 09:24:35 * ChanServ sets mode +qo flo flo 09:29:47 <flo> if anybody wants to look, here's a log of connecting an AIM account, and disconnecting it. http://queze.net/goinfre/socket.log 09:29:57 <flo> I think the socket count should be down to 0 at the end of this log 09:33:16 <-- Gizmokid2005 has quit (Ping timeout) 09:34:00 --> Gizmokid2005 has joined #instantbird 09:37:56 <aleth> so, RemoveFromIdleList only removes one at a time 09:38:39 <aleth> Which implies it's not called often enough... 09:38:41 <flo> aleth: also, sockets are always added to the idle list before becoming active 09:40:06 <aleth> Yes, is that not expected? 09:40:20 <flo> it is; it just makes the log a little bit more difficult to read 09:42:02 <aleth> The log messages of socket.jsm aren't in the log 09:42:18 <flo> how is socket.jsm related? 09:42:30 <flo> it's an AIM account 09:42:47 <flo> the logged messages are from http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleSockets.cpp and http://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsSocketTransportService2.cpp 09:43:32 <aleth> I somehow thought socket.jsm was always intermediate :-/ 09:43:49 <aleth> But yeah, that makes no sense for libpurple 09:48:31 <flo> hmm, I wonder how long it would take me to craft a libpurple test prpl that connects only one socket, and closes it as soon as it's connected, and do nothing else 09:48:40 <flo> the log would be easier to read with only one socket in it ;) 09:53:18 <EionRobb> doesn't the xmpp prpl only have one socket? 09:53:52 <flo> EionRobb: probably 09:53:58 <flo> what I actually mean is a single call to purple_input_add 09:55:19 <aleth> There are 31 purpleSockets created but only 8 destructed 09:55:37 <flo> ah? 09:55:41 <aleth> it seems the idle list simply reflects that 09:56:34 <aleth> (unless I have missed an alternate destruct... log message) 09:56:45 <flo> aleth: there are 31 SOCKETADD and 31 SOCKETCANCEL calls, so the prpl isn't faulty here 09:57:02 <flo> (those are the only 2 things that can directly be called by libpurple) 09:57:32 <aleth> I was counting "Creating purple*" and "destructing purple*" 09:57:46 <flo> ok :) 09:58:08 <flo> and we end up with 27 idle socket watchers 09:58:25 <aleth> 31-(8/2) 09:58:26 <aleth> firts 09:58:30 <aleth> *fits 09:58:55 <flo> yes, there's a destructing purpleSocket and a destructing purpleSocketInternal message 09:59:02 <aleth> Yes. 09:59:33 <flo> hmm, it's strange that we are "sometimes" able to destroy them :-S 10:02:54 --> jb has joined #instantbird 10:08:13 <flo> ok, I see what's wrong 10:08:18 <flo> I don't have a fix yet though 10:08:30 <aleth> still :) 10:12:46 <-- Optimizer has quit (Ping timeout) 10:14:50 <flo> and here is the fix: http://pastebin.instantbird.com/44751 :) 10:16:16 --> Optimizer has joined #instantbird 10:16:21 <flo> (the socket count (both active and idle) goes down to 0 after disconnecting the account when this fix is applied) 10:17:02 <flo> there may be thread safety issues though, I need to inspect the ways that variable is used 10:17:56 --> clokep has joined #instantbird 10:17:56 * ChanServ sets mode +o clokep 10:18:49 <aleth> I don't understand what that variable does 10:20:09 <aleth> But this suggests it won't hurt http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleSockets.cpp#213 10:21:39 <flo> I don't understand what this suggests :-S 10:21:58 <flo> purpleSocketInternal::Run runs on the socket thread 10:22:05 <flo> my patch runs on the UI thread 10:22:49 <aleth> Yes, and you are seting mPollFlagsInternal = 0 when mCanceled = true for that thread. 10:23:08 <aleth> But I don't understand the code, so hey... 10:23:09 <flo> it's that code path I want to avoid 10:23:25 <flo> look at line 210 ;) 10:25:17 <aleth> yeah... the 28 times we reach line 213... 10:27:36 <aleth> Ars technica headline on TB13: "Mozilla is monetizing Thunderbird by integrating third-party services." 10:27:51 <flo> :) 10:30:41 <clokep> Are they saying that in a good way? Bad way? Or just informational way? 10:30:49 <clokep> flo: Sounds like you're making some progress on that then. :) 10:31:00 <aleth> clokep: http://arstechnica.com/information-technology/2012/06/personalized-e-mail-feature-in-thunderbird-13-lets-users-register-a-domain-name 10:31:20 <flo> clokep: it's pretty clear at this point that bug 1344 caused a bad regression 10:31:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1344 nor, --, 1.2, florian, RESO FIXED, stop using XPCOM proxies in purpleSockets 10:31:32 <flo> but I still don't understand why it would break twitter on Tb :-S 10:32:09 <clokep> Could that have been a different bug? 10:33:53 <clokep> " More recent projects like the effort to add a built-in instant messaging client have been slow to land." :( 10:34:07 <clokep> "Impressive projects like the Gmail-inspired conversation layout are stuck in beta and seem to have stalled." Uhh....isn't that just an add-on? 10:34:39 <flo> it's an add-on because its code sucks 10:34:46 <flo> but people expected it would land at some point 10:34:52 <aleth> At least someone is impatient for IM ;) 10:36:01 <flo> that article seems pretty good 10:38:02 <clokep> Oh really? I didn't realize they wanted that to land eventually... 10:38:10 <clokep> The article is good, don't read the comments though. :-S 10:38:24 <clokep> Half of themare like "Bah, I'm uninstalling Thunderbird now!" 10:38:55 <aleth> Probably just like comments on browser reviews... 10:40:20 <clokep> Yeah, or on YouTube. ;) 10:41:18 <flo> clokep: "they" is undefined in your sentence ;) 10:42:08 <clokep> flo: So I realized all the Makefiles inside of purple/ still have tri-licenses on them. 10:42:43 <clokep> I assume we'd want to switch those. 10:46:43 <flo> the comments aren't that stupid on that article ;) 10:47:07 <flo> clokep: if you want to do that, go ahead :) 10:48:31 <clokep> I'll file a bug. ;) 10:48:37 <clokep> (And do it at some point...) 10:48:43 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 10:55:35 <-- EionRobb has quit (Connection reset by peer) 10:56:01 --> EionRobb has joined #instantbird 11:06:52 <-- jb has quit (Ping timeout) 11:07:13 <-- EionRobb has quit (Quit: Leaving.) 11:10:54 --> FireFly_TB has joined #instantbird 11:11:07 <flo> ok, I have a patch changing more lines, but that doesn't cause thread safety issues 11:21:40 --> FeuerFliege has joined #instantbird 11:24:36 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1572 on bug 1355. 11:24:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1355 maj, --, ---, florian, ASSI, unable to establish any network connection until a restart of the application 11:25:23 <flo> btw, I find the new code of that method much more readable 11:28:01 --> clokep_work has joined #instantbird 11:28:01 * ChanServ sets mode +o clokep_work 11:36:57 <instantbot> New Core - General bug 1491 filed by clokep@gmail.com. 11:37:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1491 tri, --, ---, nobody, NEW, MPL 2.0 for random purple/ files 11:42:30 <instantbot> clokep@gmail.com granted review for attachment 1572 on bug 1355. 11:42:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1355 maj, --, ---, florian, ASSI, unable to establish any network connection until a restart of the application 11:44:27 * clokep_work wonders how many bugs we can dup into that one. :-S 12:00:28 <-- chrisccoulson has quit (Quit: Ex-Chat) 12:00:36 --> deomega1 has joined #instantbird 12:04:03 <-- Tomek has quit (Client exited) 12:08:26 <-- Optimizer has quit (Ping timeout) 12:12:06 --> Optimizer has joined #instantbird 12:12:40 --> Tomek has joined #instantbird 12:31:33 --> chrisccoulson has joined #instantbird 12:33:15 --> Lalae has joined #instantbird 12:33:28 <-- Lalae has left #instantbird () 12:40:23 <clokep_work> flo: Was the Mac build failing anything to do w/ my check-in? 12:42:40 <flo> clokep_work: that's possible, but not very important 12:47:35 <clokep_work> OK! 12:55:23 <aleth> two nice articles on how FF got its current logo: http://www.hicksdesign.co.uk/journal/branding-firefox and http://www.actsofvolition.com/archive/2004/february/brandingmozilla 12:56:53 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 12:58:27 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/2ed5407c4a6a - Florian Quèze - Bug 1355 - unable to establish any network connection until a restart of the application, r=clokep. 12:58:33 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 12:58:54 --> flo has joined #instantbird 12:58:54 * ChanServ sets mode +qo flo flo 12:59:12 <aleth> flo: There's also a clokep patch in checkin-needed afaik 13:00:42 <flo> I'll stay on the debug build with logging enabled for the rest of the day to see if I notice other issues 13:02:17 <flo> aleth: I'll try to think about it this evening 13:02:39 <flo> I just wanted to be completely sure I wouldn't forget the socket patch, as I would really like us to start testing builds with it asap :) 13:03:16 <aleth> Yes :) It's great at least one of those nasty bugs without STR is hopefully gone 13:03:26 <flo> 2 this week ;) 13:03:38 <flo> there was also the aContactA is null one ;) 13:04:28 <flo> I hope (which is kind of strange) that I'll have a flacky connection this evening, to see if it still misbehaves :) 13:04:51 <aleth> You might run into the connection timeout issue... 13:05:10 <flo> yeah... or not :) 13:05:20 <aleth> here's hoping ;) 13:05:26 <flo> it's possible that the timeout never happened because the socket was never actually created 13:06:23 <aleth> I wonder if bug 335 is fixed too by this... but then again it's a really old bug 13:06:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=335 min, --, ---, nobody, NEW, Going offline should stop reconnection timers 13:06:37 <flo> it's currently stable at "[active=18 idle=0]" 13:06:54 <flo> aleth: definitely not, we need to fix this one 13:07:20 <flo> but that one isn't scary; we just need to look at the code in imAccounts.js and fix it 13:07:26 <aleth> So that's not a libpurple issue? 13:07:39 <aleth> I had assumed it must be due to the date on it 13:07:40 <flo> 335 is our bad 13:08:06 <flo> it's a bug that we had at the time our account handling was in C++ in purpleAccount.cpp 13:08:07 <instantbot> c++ is e-- ah, nevermind. 13:09:03 <flo> it's just more visible now because there's also a bug in socket.jsm 13:09:23 <flo> purpleAccount::Connect used to return early if we were offline 13:09:42 <flo> it still does actually: http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleAccount.cpp#464 13:09:56 <flo> but it's just a safety check; that situation shouldn't happen 13:10:17 <flo> socket.jsm should have the same check 13:17:53 <aleth> Sounds like you have it fixed, bar the typing :) 13:19:04 <flo> no :) 13:21:27 <instantbot> florian@instantbird.org set the Resolution field on bug 1355 to FIXED. 13:21:27 <flo> fixing the problem in socket.jsm is trivial 13:21:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1355 maj, --, 1.2, florian, RESO FIXED, unable to establish any network connection until a restart of the application 13:21:53 <flo> but it shouldn't happen in the first place, and the imAccounts.js code around status change is a bit complicated, so I would need to really focus on it to produce a patch 13:23:13 <flo> the socket.jsm change will just give us a nicer error message in places where we currently fail with "Component returned failure code: 0x804b0010 (NS_ERROR_OFFLINE) [nsISocketTransportService.createTransport]" nsresult: "0x804b0010 (NS_ERROR_OFFLINE)" location: "JS frame :: resource:///modules/socket.jsm :: <TOP_LEVEL> :: line 443" 13:27:36 <-- Bollebib has quit (Quit: Instantbird 1.1) 13:31:22 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1187 on bug 1096. 13:31:23 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1187 on bug 1096. 13:31:24 <aleth> Spreading the load a bit... 13:31:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1096 nor, --, ---, nobody, NEW, Add "Visible tags..." entry to contacts window background context menu too 13:31:53 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1188 on bug 1096. 13:32:09 <-- Tomek has quit (Client exited) 13:38:47 <-- mmkmou has quit (Connection reset by peer) 13:59:46 * flo feels lazy, and uses the checkin-needed keyword on https://bugzilla.mozilla.org/show_bug.cgi?id=762088 14:03:00 --> clokep_work has joined #instantbird 14:03:00 * ChanServ sets mode +o clokep_work 14:06:23 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 14:10:10 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 14:11:22 --> sonny has joined #instantbird 14:11:24 <-- Optimizer has quit (Ping timeout) 14:12:17 --> Optimizer has joined #instantbird 14:15:47 <-- Optimizer has quit (Ping timeout) 14:17:27 <-- chrisccoulson has quit (Quit: Ex-Chat) 14:18:18 --> Optimizer has joined #instantbird 14:19:16 <clokep_work> aleth: I think those changes look good. I'll try them out soon. 14:26:03 --> Bollebib has joined #instantbird 14:38:24 --> meh has joined #instantbird 14:40:04 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 14:40:12 --> meh has joined #instantbird 14:41:26 --> jb has joined #instantbird 14:42:12 <flo> https://bugzilla.mozilla.org/show_bug.cgi?id=762171#c2 uh, gentoo :( 14:42:58 --> Tomek has joined #instantbird 14:43:53 <clokep_work> :( 14:49:32 <aleth> The new XMPP icon looks a lot like the MSN icon, especially when greyed out. But the MSN icon will be updated eventually anyway... 14:50:06 <clokep_work> aleth: Yes, but it's the "real" XMPP icon: http://xmpp.org/ 14:50:23 <aleth> clokep_work: Sure, I wasn't complaining :) 14:51:25 <aleth> Whenever JS-MSN happens, the same guy is bound to add the new WLM icon for it... 14:51:47 <clokep_work> andreasn I think did them, yup! :-D 14:51:48 <flo> why? :) 14:51:53 <clokep_work> aleth: Want to work on that? ;) 14:52:08 <aleth> not atm... 14:53:05 <flo> clokep_work: I wondered the same thing (about GPL headers). 14:53:12 <flo> but these headers are long, aren't they? 14:53:29 --> Kaishi has joined #instantbird 14:53:34 --> mmkmou has joined #instantbird 14:54:57 <-- Tomek has quit (Quit: Instantbird 1.1) 14:58:03 <clokep_work> flo: They're longish, but our repo is a mix of licenses so it really should be clear that those are GPL'd. 14:58:41 <flo> maybe :) 14:58:59 <flo> (I don't really mind either way) 14:59:01 <clokep_work> If I fix the script to add it, will you complain? :P 14:59:17 <flo> no 15:03:08 <clokep_work> OK. ;) Will fix all that stuff next week then. 15:11:52 <-- gerard-majax has quit (Ping timeout) 15:14:33 <instantbot> New Core - General bug 1492 filed by aletheia2@fastmail.fm. 15:14:34 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1573 on bug 1492. 15:14:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1492 min, --, ---, nobody, NEW, Rename purpleConversation -> prplConversation where appropriate 15:16:01 --> Tomek has joined #instantbird 15:16:44 <clokep_work> Looks good. :) 15:17:02 <clokep_work> I don't think any add-ons would use that notification...although it's possible. 15:27:14 --> chrisccoulson has joined #instantbird 15:38:50 <-- meh has quit (Quit: Lost terminal) 15:39:43 --> meh has joined #instantbird 15:48:29 <-- Kaishi has quit (Quit: Kaishi) 15:52:17 --> wnayes has joined #instantbird 15:57:20 --> jb1 has joined #instantbird 16:00:35 <-- jb1 has quit (Quit: jb1) 16:04:50 <aleth> Odd that moz12 ua.css references a CSS attribute (column-fill) that was only implemented in gecko14 according to MDN 16:05:11 <aleth> At least that means the warning will go away on its own ;) 16:11:31 --> igorko has joined #instantbird 16:15:35 <-- Optimizer has quit (Ping timeout) 16:15:54 --> Optimizer has joined #instantbird 16:18:12 <-- jb has quit (Ping timeout) 16:18:51 --> gerard-majax has joined #instantbird 16:25:16 --> jb has joined #instantbird 16:31:24 <-- igorko has quit (Connection reset by peer) 16:35:26 <-- skeledrew has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 16:35:37 --> skeledrew has joined #instantbird 16:39:08 <-- meh has quit (Ping timeout) 16:46:08 <-- chrisccoulson has quit (Quit: Ex-Chat) 16:46:34 <-- FeuerFliege has quit (Ping timeout) 16:47:06 <-- FireFly_TB has quit (Ping timeout) 16:50:38 <-- aleth has quit (Input/output error) 16:54:41 <-- jb has quit (Ping timeout) 16:56:08 --> chrisccoulson has joined #instantbird 16:57:54 --> meh has joined #instantbird 16:59:31 --> myk has joined #instantbird 17:00:24 <-- skeledrew has quit (Ping timeout) 17:00:34 --> jb has joined #instantbird 17:01:23 <-- chrisccoulson has quit (Quit: Ex-Chat) 17:01:47 <-- clokep_work has quit (Quit: Going home.) 17:03:05 --> jb1 has joined #instantbird 17:04:36 <-- jb has quit (Ping timeout) 17:05:00 <-- jb1 has quit (Ping timeout) 17:09:28 --> chrisccoulson has joined #instantbird 17:10:52 --> Mad_Maks has joined #instantbird 17:11:43 <-- Mad_Maks has quit (Quit: Instantbird -- http://www.instantbird.com) 17:12:51 --> Mad_Maks has joined #instantbird 17:21:05 <-- Mad_Maks has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 17:21:14 --> Mad_Maks has joined #instantbird 17:22:39 --> Mook_astb has joined #instantbird 17:22:57 <-- Mook_astb has quit (Quit: Mook_astb) 17:23:08 --> Mook_astb has joined #instantbird 17:24:48 --> jb has joined #instantbird 17:24:54 --> FireFly_TB has joined #instantbird 17:24:55 --> FeuerFliege has joined #instantbird 17:28:33 <-- Mook_astb has quit (Quit: Mook_astb) 17:31:30 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 17:32:50 --> jb1 has joined #instantbird 17:34:23 <-- jb has quit (Ping timeout) 17:38:21 --> jb has joined #instantbird 17:41:54 <-- jb has quit (Ping timeout) 17:45:26 --> jb has joined #instantbird 17:49:22 --> clokep has joined #instantbird 17:49:22 * ChanServ sets mode +o clokep 17:49:33 <-- sonny has quit (Ping timeout) 17:52:08 <-- jb has quit (Ping timeout) 17:54:06 --> sonny has joined #instantbird 17:56:44 --> jb has joined #instantbird 17:59:45 --> Mook_as has joined #instantbird 18:00:29 <Mook_as> hmm, finding the fact that IRC channels (dunno if it's MUCs in general) _always_ scroll to the bottom on switching to them to be really annoying (in tbird, I guess) 18:01:09 <clokep> Doesn't happy in IB it seems....? 18:01:37 <clokep> Ah maybe it only happens if a message was received though... 18:02:38 <Mook_as> well, of course I'm only switching to channels where I'm going to be reading things :p 18:07:52 <clokep> Shhh. 18:07:57 <clokep> ping instantb 18:08:08 <clokep> instantbot: uuid 18:08:09 <instantbot> 5f45e1d7-6809-4684-a1bf-b9165b85f03a (/msg instantbot cid for CID form) 18:08:20 * clokep isn't fast enough to test that hah. 18:08:23 * clokep needs to go. 18:08:24 <clokep> Bye! :) 18:08:26 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:11:53 <-- jb has quit (Ping timeout) 18:12:15 --> jb has joined #instantbird 18:17:33 <Mook_as> heh, JSObject::setNewTypeUnknown should probably not get an emoticon at the :s 18:20:14 <-- jb has quit (Quit: jb) 18:21:03 <Mook_as> and yeah, we should be able to suppress join/leave messages in places like #developers. (chatzilla calls this conference mode, I think) 18:25:39 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:25:45 --> Even has joined #instantbird 18:25:45 * ChanServ sets mode +o Even 18:34:51 <Mook_as> also, I guess since the whois info only shows up from the participants list, we can't see info for past messages (for people who've left after they said something) 18:36:59 --> aleth has joined #instantbird 18:36:59 * ChanServ sets mode +h aleth 18:38:59 <aleth> Mook_as: You can get WHOWAS info via /whois <nick> 18:39:18 <aleth> Mook_as: (or /whowas <nick>) 18:40:17 <aleth> Mook_as: At one point I was going to write an add-on to reopen conversations scrolled to the unread ruler, but I never got around to it. 18:40:48 <Mook_as> well, I still have no unread ruler due to some open bug on the tbird side ;) 18:41:14 <aleth> Mook_as: Nobody has implemented it for TB ;) 18:41:33 <aleth> Do you use TB solely for the IM part? 18:41:46 <Mook_as> yep. well... 18:42:00 <aleth> Why? 18:42:03 <Mook_as> I use tb-on-windows for mail/rss, and tb-on-linux for IRC? 18:42:23 <Mook_as> oh, I just wanted to try out how it's going; it's being my chatzilla-replacement at the moment. 18:42:25 <aleth> Ah. I thought it might be the single-window thing 18:42:40 <Mook_as> it is! I wouldn't want to actually use IB for IRC :) 18:43:05 <aleth> I wonder how hard it would be to take the TB interface and implement it as an add-on for IB 18:43:51 <aleth> Then you could have the best of both ;) 18:44:12 <Mook_as> yeah, that'd actually be nice 18:44:22 <Mook_as> except I'd also want multiple servers in one window... :p 18:45:04 <aleth> That's just tabs, right? 18:45:37 <Mook_as> but the point is to have unread count of all channels I'm in on screen at the same time 18:45:42 <Mook_as> so I know when to switch to them 18:46:22 <aleth> Sounds like you have a little project ahead of you :P 18:47:06 <Mook_as> I just need infinite time to do it in :p 18:47:35 <aleth> Maybe... but flo has already done most of the work for you ;) 18:48:02 <Mook_as> and I'm grateful for that; but... :p 18:48:11 <aleth> Yeah, I know... 18:48:22 * aleth needs infinite scroll for his todo list 18:51:49 --> jb has joined #instantbird 18:55:58 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:56:43 <-- jb has quit (Ping timeout) 18:57:03 <-- jb1 has quit (Ping timeout) 18:58:08 <-- Mad_Maks has quit (Client exited) 18:59:29 --> flo has joined #instantbird 18:59:29 * ChanServ sets mode +qo flo flo 19:02:14 <-- flo has quit (Ping timeout) 19:22:16 --> flo has joined #instantbird 19:22:16 * ChanServ sets mode +qo flo flo 19:22:36 <flo> hello from Instantbird 1.0 in French :) 19:24:40 <Mook_as> but that was in English ;) 19:24:56 <flo> I tried to reconnect my debug build on the default profile, but after freezing for a while (only the error console wasn't frozen; and messages were scrolling very quickly there, I couldn't read) it crashed :-S 19:25:38 <flo> I restarted it, and it crashed during a poll call (apparently polling on an invalid file descriptor) 19:25:49 <flo> and then emacs crashed too 19:25:56 <aleth> oh joy :( 19:26:45 --> Mnyromyr has joined #instantbird 19:27:18 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 19:27:41 <flo> I'm not sure of what the next step is now :-S 19:28:15 <aleth> Could it be that it was just the logging that made it crash? 19:28:24 <flo> and I can't even blame the internet connection, it hasn't disconnected me a single time this evening :) 19:29:19 <flo> the crash was actually -1340452864[6358a0]: Assertion failure: rv > 0, at /Users/florian/buildhg/hg.instantbird.org/mozilla/nsprpub/pr/src/md/unix/unix.c:3775 19:31:34 <-- FireFly_TB has quit (Ping timeout) 19:31:34 <-- FeuerFliege has quit (Ping timeout) 19:34:02 <aleth> I wonder why there is no mozilla convention that source files have at the top a single line comment explaining what the file is for :-/ 19:35:04 <flo> can you explain in a single line what most files do? 19:35:27 <aleth> No, but you can give a rough indication 19:36:01 --> FireFly_TB has joined #instantbird 19:36:03 <aleth> Let's be honest, currently the filename fulfils that job, and that's even shorter 19:37:47 <aleth> OK, maybe it wouldn't make much of a difference, I don't know. 19:38:40 <flo> You didn't specify < 80 columns, so your single line constraint is actually easy to fulfil :) 19:40:08 <flo> hmm "JavaScript Error: "aFunction.apply is not a function" {file: "resource:///modules/imXPCOMUtils.jsm" line: 76}]' when calling method: [nsITimerCallback::notify]" :-S 19:40:54 <flo> instantbird tells me that my previous startup crashed, so it disabled auto-login 19:40:55 <wnayes> flo: Yesterday clokep mentioned it would be a good idea to have some sort of code review on the importer work. I'm not sure how you would want to go about that, but I uploaded a patch of the changes since starting: http://www.tc.umn.edu/~nayes006/gsoc2012/files/ImporterPatchJune7.patch 19:40:55 <flo> that's lovely :) 19:41:17 <aleth> In your patch https://hg.instantbird.org/instantbird/rev/2ed5407c4a6a, what if you move the if (mPollFlagsInternal) block above the if (mCanceled) block? 19:41:43 <aleth> i.e. why is the order that way round? 19:42:06 <flo> aaarg! 19:42:08 <flo> no nick completion at all in 1.0 : 19:42:09 <flo> ( 19:42:14 <aleth> wnayes: wow, looks like progress :) 19:42:24 <flo> aleth: why would you want to put that before the if(mCanceled) test? 19:43:17 <aleth> So mPollFlagsInternal is reset in any case? 19:43:36 <aleth> But I'm not saying that's the way it should be, still trying to understand the code 19:43:38 <flo> mPollFlagsInternal is irrelevant if the watched is already canceled 19:44:16 <flo> a socket is idle when mPollFlags is 0, and becomes active when it has a non-null value 19:44:36 <aleth> But the existing code is careful to set it to zero even if canceled 19:44:57 <aleth> Maybe unneccessarily so 19:45:07 <flo> when the socket transport service tells us the socket is ready for what we were waiting (= we should now read or write something), we set mPollFlags to 0, store the previous value of mPollFlags in mPollFlagsInternal, and notify libpurple 19:45:10 <aleth> (it = mPollFlagsInternal) 19:45:27 <flo> when libpurple is done doing its stuff, we set mPollFlags back the its previous value (which was temporarily stored in mPollFlagsInternal) 19:45:35 <flo> does that clarify things? 19:46:23 <aleth> OK 19:47:04 <flo> aleth: mPollFlagsInternal != 0 means "we need to make the socket active". The code after the if (mPollFlagsInternal) test used to set it to 0 in all cases so that we wouldn't re-enter that code path 19:47:30 --> flo1 has joined #instantbird 19:49:01 <flo1> and this time everything seems to work OK :-S 19:50:32 <aleth> OK, so that code was just really confusingly structured before ;) 19:52:48 <flo1> it was! 19:53:09 <aleth> wnayes, flo: Would it be a good idea to file an "Import wizard" bug to which these WIP patches can be attached? 19:53:44 --> skeledrew has joined #instantbird 19:54:00 <flo1> I think so. If it turns out that it doesn't help, it wouldn't hurt either :) 19:54:16 <flo1> oh, the green dock badge :) 19:54:26 * flo is now known as flo-fr 19:54:31 * flo1 is now known as flo 19:54:46 * flo-fr sets mode +o flo 19:55:16 <aleth> ^^ a nice test of various recent patches :D 19:55:46 <flo> is there any reason why current instantbird writes "mode (flo +o)" and old versions used to write "mode (+o flo)"? 19:56:13 <aleth> You'd have to ask clokep why he ordered the string that way... 19:57:27 <flo> I wonder if I should be worried by theses crashes 19:57:57 <flo> the only idea that I have to clarify things would be to restart with valgrind 19:58:11 <flo> but my debug build is already so slow when compiling Tb in the background :-/ 19:59:08 <flo> wnayes: where does that throbber.gif file come from? 19:59:58 <flo> wnayes: jar.mn files is one of the rare places where you are allowed (and even encouraged) to use tabs :) 20:00:08 <flo> see instantbird/themes/jar.mn at the end of your patch 20:01:18 <wnayes> flo: the throbber.gif was from something mozilla related (added it awhile ago, can't really remember but I'm quite sure it came from an official mozilla site) 20:01:47 <wnayes> Tried to get those to be tabs, obviously didn't get every one :) 20:04:09 <flo> wnayes: I asked that about the throbber file becaue I'm almost sure it has been replaced a long while ago by an animated PNG file instead of a GIF file that doesn't support alpha transparency ;) 20:05:36 <wnayes> flo: I know I haven't seen it for awhile in Firefox :) Might not be in the final UI anyways. 20:06:50 <flo> yeah, it's not an important comment anyway :) 20:07:46 <flo> wnayes: what is this code supposed to do http://pastebin.instantbird.com/44802 ? 20:08:22 <flo> for |this.proto = undefined;| it seems you wanted |delete this.proto;|, for |optElement = undefined;| I really don't know what you tried to do 20:09:18 <flo> |if (this.proto == undefined)| looks like it wanted to be |if (!this.proto)| 20:09:42 <wnayes> resetValues() was what I came up with to basically reset the wizard when pressing "Add another account" on the summary page 20:10:01 <aleth> wnayes: Why do you need the executeSoon call in the start method? 20:10:59 <aleth> wnayes: |delete| will reset to the value specified in the prototype 20:11:42 <flo> |/* Cancel the running search for accounts */| add a . at the end of the sentence :) 20:12:24 <flo> aleth: I suspect there's no (interesting) prototype in that case; it's UI code :) 20:12:40 <flo> (and proto means protocol here, not prototype :)) 20:13:11 <wnayes> aleth: The executeSoon was what flo suggested to prevent possible race conditions when the importers call the observing UI. 20:13:12 <aleth> I did realize he wasn't deleting the __proto__ ;) 20:13:48 <flo> wnayes: any reason for naming "start" the method doing the same thing as the "findAccounts" of the other interface? 20:14:14 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 20:14:22 <aleth> I just thought it might come in handy when resetting values 20:14:23 <aleth> wnayes: That makes sense, thanks 20:15:06 <wnayes> flo: I suppose they could both be the same :) 20:15:33 <flo> wnayes: I prefer findAccounts 20:15:44 <flo> it's a little more descriptive of what's going to happen ;) 20:19:49 <flo> I don't understand why the imIModifiedPreference interface has both methods to get and to set the value of the pref 20:20:41 <aleth> wnayes: https://mxr.mozilla.org/mozilla-central/source/mobile/xul/themes/core/images/throbber.png 20:20:47 <flo> what are the set* methods for in imIExistingAccount ? 20:21:06 <aleth> or https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/media/throbber.png ;) 20:21:17 <-- chrisccoulson has quit (Quit: Ex-Chat) 20:22:00 <Mook_as> I think you mean chrome://global/skin/media/throbber.png ;) 20:22:33 <aleth> well, yeah :P 20:22:41 <-- Optimizer has quit (Ping timeout) 20:22:56 <wnayes> The ExistingAccounts store an array of ModifiedPreferences, which they create when the importer calls the set* methods. 20:23:03 <flo> Mook_as: that avoids the problem of the tab in jar.mn ;) 20:23:26 <aleth> The point of finding them on mxr was that they would already be there... 20:23:40 <wnayes> The set* methods on the ModifiedPreferences are called from the set methods of the ExistingAccounts, and the get* methods are used in the UI when creating the accounts. 20:23:52 <flo> wnayes: my question was why are they exposed on the interface :) 20:24:41 --> chrisccoulson has joined #instantbird 20:24:56 <flo> the object representing an existing account comes directly from the importer, so the importer has access to all of it, even what's not exposed in the interface 20:25:25 <flo> wnayes: so typically, what you want to expose in the interface is what either the UI or the importers service will want to call 20:29:11 <wnayes> flo: Alright, I think that makes sense. Still getting used to what needs to be in the interfaces and what doesn't. :) 20:33:35 <flo> have you done some C++ before? 20:34:12 <flo> if so, think of the interface as what would be public: in the class ;) 20:34:53 <wnayes> No C++ I'm afraid, but that makes sense. 20:35:48 <flo> would "im-import-plugin" sound better than "im-importer-plugin"? (really not sure) 20:36:10 <flo> wnayes: heh, instantbot will love you ;) 20:37:34 <wnayes> Being that the get* methods are called by the UI, they would still be found in the interface (of ModifiedPreference)? 20:38:07 <flo> yes 20:39:08 <flo> by the way, why do you need the imIModifiedPreference at all? What makes the prplIPref interface unusable in this context? 20:41:08 <flo> http://pastebin.instantbird.com/44808 it seems the notification names on line 2 and 3, and line 5 and 10 would really want to be the same ;) 20:42:05 <wnayes> It seems that it stores only the default values. Though maybe a .value property can be just added on? There's a lot of flexibility with Javascript objects I'm not used to yet :) 20:42:54 <flo> wnayes: but you need only one value, don't you? 20:43:27 <flo> the UI can get the default value from importedAccount.protocol.getOptions() (or whatever that actually is; I haven't looked up the exact names) 20:44:56 <flo> |this.notifyObservers(this, "account-search-finished", aData);| I don't think you want to forward aData in this case (the aData value from the last imported completing his search is probably not relevant to the UI) 20:45:14 <flo> (that's just theoretical anyway, as I suspect that aData will always be null) 20:45:55 <flo> "\ No newline at end of file" this is bad ; 20:45:56 <flo> ) 20:46:20 <wnayes> flo: You're saying use the default value to store the new value in a PrplPref? That could work but I didn't know how correct it would be :) 20:47:28 <wnayes> The notifications in that paste could be the same, although I thought it would be more relevant to the UI that an existing account was found as opposed to including a detail that an importer found an account. 20:47:53 <flo> wnayes: back to aleth's comment/question about executeSoon: it's a good pratice to always add a comment explaining why we need an executeSoon or setTimeout call, as these tend to be workaround for obscure bugs, and it's nice to have a way to know if the reason why it was added still exists when later cleaning up the code 20:48:46 <flo> wnayes: why can't the importer notify the importer service with the "existing-account-found" string? 20:49:03 <flo> and with "account-search-finished" 20:50:27 <wnayes> flo: That would work. I'll add that comment too. I'm afraid I need to run some errands for my parents now. Thanks for looking over this, maybe we can continue the review tomorrow? :) 20:50:45 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 20:50:48 <flo> wnayes: why is there an executeSoon call in pidgin.js's start method? 20:51:06 <flo> wnayes: you can read instantbot's log, can't you? ;) 20:51:37 <wnayes> I will, didn't know if you would rather have me here to answer anything about it :) 20:52:08 <flo> you may want to file a bug and then attach your existing patch, and copy paste (the relevant parts of) our discussion, so that you can then reply in a way that's readable 20:52:46 <flo> I may not look at all the code tonight, I'm very tired, so I think I'll go to bed soon 20:53:04 <wnayes> Sounds good, thanks and good night :) 20:54:01 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 20:59:39 <flo> I don't see you you use NetUtil.readInputStreamToString followed by xmlParser.parseFromString instead of something like xmlParser.parseFromStream(stream, null, stream.available(), "text/xml"); 21:00:28 <flo> |for (var i = 0; i < accounts.length; ++i) {| var -> let. You seem to have lots of lines that could throw inside that loop if the xml file isn't structured strictly like you expect 21:00:37 <-- meh has quit (Quit: brb) 21:00:42 <flo> you may want to do some error checking, or add a try/catch 21:04:20 --> meh has joined #instantbird 21:04:34 <flo> now looking in jsImporterHelper.jsm 21:05:15 <flo> "existingAccount" -> "ExistingAccount" (upper case for the first later of a constructor name) 21:05:45 <flo> this._autoLogin = false; (and the next 3 lines in the constructor) -> move that to the prototype 21:06:05 <flo> only objects and array need to be initialized in the constructor to avoid issues when sharing them between instances 21:07:48 <flo> the dateModified setter and getter seem useless. When you have both a getter and a setter (ie you aren't using the getter as a way to make the property read only) and the only thing they do is forward to a property of the object, that property could be used directly 21:08:39 <flo> so instead of having |_time: 0, get dateModified() this._time, set dateModified(aDate) this._time = aDate,| you can have only |dateModified: 0,| in the prototype 21:08:56 <flo> that comment applies for the dateModified, autoLogin, password and alias properties 21:09:47 --> EionRobb has joined #instantbird 21:11:13 <flo> the code in existingAccount.setBool (and setInt and setString) is a bit complicated, and seems duplicated between the 3 methods. I haven't made the effort of fully understanding it because I think you will refactor it anyway if you start using the prplIPref interface directly 21:12:06 <flo> you may want to use the ClassInfo helper from imXPCOMUtils.jsm instead of implementing getInterfaces yourself 21:12:46 <flo> I'm not reviewing modifiedPreference 21:14:38 <flo> and I haven't really looked at the UI parts of the patch 21:17:12 <flo> overall you seem to have made great progress :) 21:17:47 <flo> and I think it was a good idea to request some code feedback at this point, as changing names would be more annoying if you had more code 21:47:33 --> Kaishi has joined #instantbird 21:50:07 <flo> Good night 21:50:10 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 21:54:39 <-- chrisccoulson has quit (Ping timeout) 21:57:09 --> jb has joined #instantbird 21:58:58 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ef344ab33302 - Patrick Cloke - Bug 1427 - Fix up order and formatting of IRC tooltips, r=aleth. 22:00:43 --> FireFly_1 has joined #instantbird 22:02:24 <-- FireFly_1 has quit (Ping timeout) 22:05:33 <-- flo-fr has quit (Ping timeout) 22:10:36 --> jb1 has joined #instantbird 22:10:57 --> chrisccoulson has joined #instantbird 22:11:27 <-- Tomek has quit (Client exited) 22:12:54 <instantbot> New Core - IRC bug 1493 filed by aletheia2@fastmail.fm. 22:12:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1493 enh, --, ---, nobody, NEW, Support multiple name/connectedFrom/connectedTo whowas entries 22:18:12 <-- jb has quit (Ping timeout) 22:18:15 <-- jb1 has quit (Ping timeout) 22:27:25 --> jb has joined #instantbird 22:27:45 --> jb1 has joined #instantbird 23:21:33 <-- FireFly_TB has quit (Connection reset by peer) 23:21:38 --> FireFly_TB has joined #instantbird 23:26:38 <-- Bollebib has quit (Quit: Instantbird 1.1) 23:44:09 <-- meh has quit (Quit: I don't want to live on this planet anymore.)