All times are UTC.
00:16:44 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 00:21:35 <-- Even has quit (Ping timeout) 00:25:11 <-- Bollebib has quit (Quit: Instantbird 1.1) 00:33:02 --> Even has joined #instantbird 00:33:02 * ChanServ sets mode +o Even 00:45:16 <-- Mook_as has quit (Quit: gone) 01:00:17 <instant-buildbot> build #267 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/267 01:18:37 <-- Tomek has quit (Quit: Instantbird 1.1) 01:22:49 * jwir3 is now known as jwir3|dinner 01:25:48 <instant-buildbot> build #235 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/235 01:45:23 <-- skeledrew has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 01:45:30 --> skeledrew has joined #instantbird 02:08:54 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1560 on bug 1427. 02:08:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1427 enh, --, ---, clokep, ASSI, Fix up order and formatting of of IRC tooltips. 02:09:29 <clokep> I think that one will make Mic happy. ;) 02:13:51 <clokep> JS-XMPP doesn't have tooltips, right? 02:50:31 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 03:08:13 <instant-buildbot> build #255 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/255 03:18:40 <instant-buildbot> build #517 of linux-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/517 03:20:47 <-- pvagner has quit (Ping timeout) 03:30:33 <instant-buildbot> build #236 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/236 04:27:15 --> deomega1 has joined #instantbird 04:27:35 <deomega1> Thank you MIC for session restore! 04:28:04 <deomega1> itis not remember w all windows positions as yet, but thank you for this step very much. 04:28:28 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 04:28:32 --> deomega1 has joined #instantbird 04:28:48 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 04:30:39 --> deomega1 has joined #instantbird 04:31:20 <deomega1> my apologies.. i see the todo section in the boostrap thingie :)... way to go Mic! 04:31:34 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 05:03:11 <-- Tonnes has quit (Quit: ChatZilla 0.9.88.2 [Firefox 12.0/20120420145725]) 05:03:48 --> Tonnes has joined #instantbird 05:05:16 <-- Tonnes has quit (Quit: ChatZilla 0.9.88.2 [Firefox 12.0/20120420145725]) 05:33:58 <instant-buildbot> build #610 of win32-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/610 06:15:39 <-- Suiseiseki has quit (Ping timeout) 06:16:14 --> FeuerFliege has joined #instantbird 06:16:23 --> FireFly_TB has joined #instantbird 06:17:15 --> Suiseiseki has joined #instantbird 06:23:49 <-- EionRobb has quit (Quit: Leaving.) 06:25:53 <-- FireFly_TB has quit (Quit: FireFly_TB) 06:26:02 --> FireFly_TB has joined #instantbird 06:45:42 <-- FireFly_TB has quit (Quit: FireFly_TB) 06:45:58 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 07:20:27 --> Bollebib has joined #instantbird 07:26:50 <-- Even has quit (Input/output error) 07:29:37 --> EionRobb has joined #instantbird 07:32:17 --> FireFly_TB has joined #instantbird 07:44:05 <-- FireFly_TB has quit (Quit: FireFly_TB) 07:44:18 --> TestFliege has joined #instantbird 07:53:38 --> gerard-majax has joined #instantbird 08:09:37 <-- wesj has quit (Ping timeout) 08:09:38 --> wesj has joined #instantbird 08:16:29 --> Tomek has joined #instantbird 08:32:13 <-- Kaishi has quit (Quit: Kaishi) 08:42:54 --> FeuerFliege has joined #instantbird 08:44:10 <-- SM0TVI has quit (Connection reset by peer) 08:45:59 --> SM0TVI has joined #instantbird 08:56:32 --> flo has joined #instantbird 08:56:32 * ChanServ sets mode +qo flo flo 08:56:50 <-- TestFliege has quit (Input/output error) 08:58:41 --> FireFly_TB has joined #instantbird 09:06:27 --> Optimizer has joined #instantbird 09:09:35 <-- gerard-majax has quit (Quit: Ex-Chat) 09:11:24 --> mmkmou has joined #instantbird 09:15:06 <-- wesj has quit (Ping timeout) 09:15:38 --> wesj has joined #instantbird 09:24:14 --> gerard-majax has joined #instantbird 09:34:18 --> pvagner has joined #instantbird 09:41:41 <-- GeekShadow has quit (Ping timeout) 09:43:34 --> jb has joined #instantbird 09:44:37 --> GeekShadow has joined #instantbird 09:54:08 <flo> I haven't read it all as it's long, but https://bugzilla.mozilla.org/show_bug.cgi?id=278860 seems like what was discussed yesterday about the missing profile 10:00:53 <-- mmkmou has quit (Ping timeout) 10:00:56 --> mmkmou has joined #instantbird 10:07:24 --> chrisccoulson has joined #instantbird 10:10:16 <-- Optimizer has quit (Ping timeout) 10:17:40 --> clokep has joined #instantbird 10:17:40 * ChanServ sets mode +o clokep 10:26:42 * clokep hopes that wasn't too harsh. 10:28:05 <clokep> Windows nightly failed to upload? 10:28:28 <clokep> "No space left on device"? Fun. :) 10:28:33 <flo> clokep: the hard disk where we store nightlies on the server was full 10:28:57 <flo> I rm'ed all the partial update mar files of nightlies before June 1st 2012. That free'd 5.5GB 10:29:12 <clokep> Nice. :) 10:29:15 <flo> so we have have ~40 days to find a better solution now 10:30:55 <-- skeledrew has quit (Ping timeout) 10:31:22 <clokep> Is there physical space for another hard drive? :-D 10:31:34 --> skeledrew has joined #instantbird 10:32:11 <flo> we don't have physical access to that server 10:32:37 <flo> but we have another much better server currently hosting only AIO 10:32:44 <clokep> Ah, I see. 10:32:47 <flo> and I think it has ~1TB of free space 10:33:10 <flo> so a good solution would be to finally migrate to that decent server, instead of keeping stuff on the old one 10:33:22 <flo> but we haven't been very motivated by that recently ;) 10:36:54 <clokep> Yeah, those aren't the fun things. 10:37:17 <flo> an alternative solution is to take offline to old nightlies from 2008 and 2009 10:38:04 <clokep> Right, which I don't think we'd ever look through for regressions. 10:38:12 <flo> I'm opposed to just deleting them, but burning them to DVDs so that they can still be "somehow" accessed if we need them to find a regression range and removing them from our online storage would be OK with me 10:38:15 <clokep> (Honestly you could probably take off 2010 too.) 10:38:41 <clokep> I probably have enough room on my backup server that I could put them there too if you want a duplication. 10:39:07 <flo> I think there's already a backup on the hard disk of the mac build slave 10:40:57 <clokep> Alright. Well if need be, I probably have room. 10:43:19 <flo> are there cheap cloud storage providers? 10:43:47 <flo> it would be nice to just be able to mount a new "network disk" and stuff there all the old crap we want to keep around but don't really need 10:44:57 <clokep> I don't know. :( The only cloud I know of is Amazon. ;) 10:45:05 * clokep doesn't trust putting things in the "cloud". :-X 10:45:36 <flo> they are currently on a dedicated server for which we don't have physical access, so it's in the cloud minus the duplication ;) 10:46:56 <clokep> Hah, true. :) 10:49:47 <-- jb has quit (Ping timeout) 10:56:02 * clokep will be back! 10:56:04 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:33:04 --> Mic has joined #instantbird 11:33:04 * ChanServ sets mode +h Mic 11:38:39 <instantbot> New Instantbird (UI) bug 1482 filed by benediktp@ymail.com. 11:38:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1482 min, --, ---, nobody, NEW, "Account Manager" menu-item and its shortcut do nothing if account wizard is opened 11:41:32 <-- EionRobb has quit (Quit: Leaving.) 11:41:42 --> EionRobb has joined #instantbird 11:43:24 <-- EionRobb has quit (Ping timeout) 11:44:16 --> clokep_work has joined #instantbird 11:44:16 * ChanServ sets mode +o clokep_work 11:48:46 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:52:29 --> Mic has joined #instantbird 11:52:30 * ChanServ sets mode +h Mic 11:53:27 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:58:46 <Mic> j #mictest2 12:01:30 <flo> Mic: it's not really clear what you were trying to do in that bug. Why were there other windows above the wizard? Why was another instantbird window focused? 12:02:00 <flo> That bug sounds a bit like "the contacts window shouldn't be displayed until the account wizard is closed during the first startup on a new profile" 12:02:50 <Mic> I had a new profile, lots of other Windows on my desktop and in the taskbar and I focused the contacts list and used the shortcut. 12:03:46 <Mic> That would have helped in this situation, yes. 12:05:28 <Mic> (but I would still say that it's not good that _nothing_ happens when the menuitem or shortcut is used while the wizard is open) 12:06:12 --> aleth has joined #instantbird 12:06:12 * ChanServ sets mode +h aleth 12:08:38 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 12:08:51 --> mmkmou has joined #instantbird 12:09:18 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1403 to FIXED. 12:09:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1403 min, --, ---, nobody, RESO FIXED, /nick response not shown in IRC conversations 12:12:30 <instantbot> New Core - IRC bug 1483 filed by benediktp@ymail.com. 12:12:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1483 nor, --, ---, nobody, NEW, Empty lines sent on IRC 12:12:50 <clokep_work> Mic: That's a dup. 12:13:34 <Mic> See comment 1 ;) 12:13:38 <flo> Mic: for some reason I thought you were talking about the shortcut from the conversation window. If the menuitem (which is way more discoverable) doesn't work either, it's obviously worse :-S 12:16:24 <instantbot> clokep@gmail.com set the Resolution field on bug 1483 to DUPLICATE of bug 1460. 12:16:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1483 nor, --, ---, nobody, RESO DUPLICATE, Empty lines sent on IRC 12:16:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1460 min, --, ---, nobody, NEW, Check whether messages to be sent end with blank lines 12:18:35 <clokep_work> Mic: Those seem like the same bugs? :) 12:18:37 <Mic> Thanks 12:19:30 <aleth> Mic: Did you see the new messages zip or do you need the link? 12:19:44 <Mic> aleth: thanks, I'm already at it 12:20:08 <aleth> Great :) 12:27:50 --> gerard-majax_ has joined #instantbird 12:29:08 <-- gerard-majax has quit (Ping timeout) 12:29:26 <instantbot> aletheia2@fastmail.fm denied review for attachment 1560 on bug 1427. 12:29:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1427 enh, --, ---, clokep, ASSI, Fix up order and formatting of of IRC tooltips. 12:30:01 <-- gerard-majax_ has quit (Ping timeout) 12:31:42 --> gerard-majax has joined #instantbird 13:01:10 <clokep_work> aleth: Why do you say tooltip.serverValue doesn't have to do with tooltips? :-S 13:01:27 <aleth> clokep_work: I think you misunderstood what I meant. 13:02:45 <aleth> Of course it is in the tooltip, but on the right hand side of the column, not on the left. So there is no kFields entry "serverValue". All I'm saying is group the kFields entries together in irc.properties too, ideally in the same order. 13:04:15 <aleth> No functional difference, just for clarity. 13:04:49 <clokep_work> Ah, I see. I thought you were saying to totally rename it to something else. 13:05:23 <aleth> No... I just assume you will be adding more strings which also go on the "values" side, so grouping them seems better for the l10alizer 13:07:04 <instantbot> benediktp@ymail.com granted review for attachment 1561 on bug 1074. 13:07:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1074 nor, --, ---, aletheia2, ASSI, Default message styles lack context message support 13:07:34 <Mic> I created a patch based on the latest zip file you uploaded. 13:08:19 <aleth> Yay :) Thanks! 13:08:33 <Mic> :) 13:08:51 <aleth> I agree the JS and CSS in some of the themes could use some tightening up, but that seemed outside the scope of the bug. 13:09:18 <Mic> Let's hope I didn't mess something up. I seem to have a gift for that ;) 13:09:54 --> Lalae has joined #instantbird 13:09:57 <aleth> At least your diff doesn't seem to have any changes that are purely whitespace ;) 13:10:24 <-- Lalae has left #instantbird () 13:10:40 <clokep_work> :) 13:11:20 <aleth> I don't understand where those came from, and I'm not too interested in investigating... 13:11:42 <aleth> Possibly pastebin, like fl o suggested 13:13:54 <Mic> :o, so many colors on the buildbot waterfall 13:14:15 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 13:16:38 <clokep_work> flo: Did you look at bug 1427? Do you have an opinion about abstracting that code or is it OK to be in both Twitter & IRC? 13:16:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1427 enh, --, ---, clokep, ASSI, Fix up order and formatting of of IRC tooltips. 13:18:06 <flo> clokep_work: we are sure whoisInformation will never contain a hasOwnProperty field? :) 13:18:07 <aleth> clokep_work: I was wondering if something like kFields shouldn't be in jsProto 13:18:16 <flo> are the fields from our code or received from the server? 13:18:26 <flo> I think the former, but just wanted to double check :) 13:18:45 <clokep_work> flo: The fields are from our code. 13:19:05 <clokep_work> The values only are from the server. 13:19:15 <clokep_work> (Unlike Twitter, where it's all just JSON from the server.) 13:19:41 <flo> I don't really see what could be abstracted here 13:19:59 <flo> seems mostly implementation details 13:20:28 <clokep_work> Just the style + the loop, but OK. I wasn't sure. 13:21:00 <aleth> You could make adding a kFields table a requirement for JS protos I suppose 13:21:19 --> Lalae has joined #instantbird 13:21:22 <aleth> But that wouldn't really save any code. 13:23:03 <clokep_work> OK, then the current code seems good. 13:23:07 <clokep_work> I'll fix up the l10n stuff. 13:31:58 --> deomega1 has joined #instantbird 13:32:36 <flo> debug builds crashing at startup are annoying :( 13:32:44 <-- Lalae has left #instantbird () 13:46:14 --> Optimizer has joined #instantbird 14:05:48 <-- Optimizer has quit (Ping timeout) 14:06:03 --> Optimizer has joined #instantbird 14:08:36 <-- aleth has quit (Input/output error) 14:15:04 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 14:19:43 --> aleth has joined #instantbird 14:19:43 * ChanServ sets mode +h aleth 14:19:58 --> mmkmou has joined #instantbird 14:35:09 <-- FireFly_TB has quit (Quit: FireFly_TB) 14:45:49 --> jb has joined #instantbird 14:47:44 <-- FeuerFliege has quit (Ping timeout) 14:48:44 --> Mad_Maks has joined #instantbird 14:57:22 --> igorko has joined #instantbird 15:17:58 <-- Optimizer has quit (Ping timeout) 15:25:57 --> Optimizer has joined #instantbird 15:32:47 --> wnayes has joined #instantbird 15:41:42 <-- wnayes has quit (Connection reset by peer) 15:42:20 --> wnayes has joined #instantbird 15:43:19 <-- igorko has quit (Connection reset by peer) 15:43:36 --> myk has joined #instantbird 15:51:16 <-- GeekShadow has quit (Ping timeout) 15:59:09 <-- myk has quit (Ping timeout) 15:59:38 --> myk has joined #instantbird 16:04:59 <-- gerard-majax has quit (Ping timeout) 16:10:11 --> Mnyromyr has joined #instantbird 16:11:05 --> GeekShadow has joined #instantbird 16:12:27 <wnayes> It would be great if someone could take a look at a couple of questions/issues that have come up: https://etherpad.mozilla.org/MLqILUZmlv 16:29:25 <clokep_work> Hopefully flo can pitch in a bit more about the different objects. I don't know the account wizard superw ell. :-S 16:29:48 <flo> I knew it 4 years ago ;) 16:35:13 --> Mook_as has joined #instantbird 16:36:24 --> igorko has joined #instantbird 16:39:16 <-- wnayes has quit (Ping timeout) 16:39:45 --> wnayes has joined #instantbird 16:41:37 --> jb1 has joined #instantbird 16:43:56 <wnayes> flo: Would you be opposed to not having an 'add another account' button in the summary page? 16:44:51 <-- jb1 has quit (Quit: jb1) 16:45:14 --> jb1 has joined #instantbird 16:49:39 <flo> wnayes: not sure, but I'm quite opposed to you wasting time, energy and motivation on silly UI details at this point. The main goal of your UI changes at this point should be to make it possible to test your importers. It doesn't matter if it's not polished :) 16:51:38 <wnayes> flo: Understood, the preferences issue was what I was more focused on (and will be useful to have working when writing the importers :) ) 16:52:22 <flo> (I'm reading the pad now) 16:53:32 <flo> "It doesn't matter if it's not polished :)" although I can totally understand that it's sometimes more pleasurable to work with something that already looks good even though it doesn't fully work yet :) 16:55:52 <flo> aleth: so the idea of the "create another account" button is to avoid people not noticing that they can configure more than one account in Instantbird 16:56:15 <-- jb1 has quit (Quit: jb1) 16:56:16 --> igorko1 has joined #instantbird 16:56:27 <flo> aleth: also, it's quite possible in the future to no longer display the account manager after closing the account wizard, if the wizard was opened automatically because it's the first start 16:56:39 <-- igorko1 has quit (Quit: Instantbird 1.1) 16:56:51 <aleth> flo: Right. I don't mind keeping that button, but I don't think there is any reason for "Back" to be able to undo that step. 16:57:01 <flo> aleth: the account manager window where the user doesn't need to do anything at all has already been identified several times as being in the way of new users 16:58:28 <flo> aleth: well, I kinda agree with you there. But then we need to offer a way to change details of accounts that are already in the summary, but not yet created 16:59:22 <flo> btw, that pad would have been a perfect use case for Google Wave 16:59:23 <aleth> flo: I don't like the idea of more and more accounts piling up in a summary. Why not have a summary after the import has finished, create those accounts, and then (next page) offer to add some new accounts too? 16:59:36 <flo> (it's hard to track what's new/unread, and what was there already at the previous time I looked) 16:59:50 <aleth> Yes... 17:00:10 <flo> aleth: the idea was that clicking "Finish" is the only way to actually create accounts; and that closes the dialog 17:00:54 <aleth> That's why I suggested having no "add more accounts" button there. 17:01:12 <aleth> But I think if you show it _after_ the user clicks "Finish" it would work. 17:02:05 <aleth> It's not like anyone will add some new accounts and then want to go back and modify some importer details. At least I don't think it's necessary to support that 17:02:52 <aleth> Otherwise you end up duplicating the account manager in the summary page, don't you? 17:03:00 <flo> you mean "finish" doesn't close the wizard? 17:03:32 <flo> yes, minus the "connect" / "disconnect" buttons 17:03:50 <aleth> Whatever you call it, it creates the imported accounts. And then (if you want) one asks the user to pick between "add new account" and "done" 17:03:52 <flo> but we already almost have this situation when displaying the list of detected accounts that can be imported 17:03:58 <clokep_work> wnayes: Btw don't try to reinvent the wheel whenever possible. :) 17:05:29 <aleth> You only have that situation if you allow editing the imported accounts before creating them. Instead one could simply import them (or not, depending on user choice) and leave the possibility for modifications to the account manager. 17:05:54 <aleth> But I'm not sure if that's a good or bad idea... 17:06:34 <aleth> Just usually, e.g. if I import a file into a word processor, I don't get the opportunity to edit it before importing it. 17:06:41 <flo> aleth: you have to edit them when the same account exists on 2 different clients with different settings, don't you? 17:07:29 <flo> aleth: but you get the opportunity to edit it before printing it ;) (which is here "connecting it automatically") 17:07:31 <aleth> flo: Do you have to edit them, or should the import wizard ask you questions to resolve the conflict (if you choose to import both) 17:08:41 --> Kaishi has joined #instantbird 17:08:49 <wnayes> The dateModified attribute of conflicting accounts was also a planned way to decide what settings/importer would be suggested default. 17:08:58 <flo> it should decide automatically what makes the most sense (= which account configuration seems the most recent) ; let the user specify otherwise (= I prefer importing settings from that client); and let the user tweak the result 17:09:29 <aleth> flo: You're probably right... but in that case I think the summary page from which you can edit the pending accounts should look/work/act as close to the account manager as possible. 17:10:00 <flo> isn't that the plan? 17:10:20 <flo> I think the last time I saw a screenshot/mockup from wnayes; they looked pretty similar 17:10:43 <aleth> I don't know ;) What I mean is, then the XBLs should be reused too 17:10:53 <aleth> as far as possible... 17:11:39 <flo> aleth: the xbl of the account manager should be rewritten (bug 1219) even if we don't reuse it, because it's currently in a pretty poor state 17:11:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1219 tri, --, ---, nobody, NEW, Cleanup the account.xml binding 17:11:50 <aleth> I mentioned that in the etherpad ;) 17:11:52 <flo> I think it's the oldest piece of code we still have 17:13:24 --> gerard-majax has joined #instantbird 17:15:58 <aleth> I still think it's probably OK to separate the "import" step from the "add any new accounts?" step. In particular as you will jump to the latter directly if no importable accounts are found. 17:16:32 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 17:16:37 --> FeuerFliege has joined #instantbird 17:17:25 <wnayes> I've got a good idea of what to do to get preferences working with the importers, thanks for all the advice! 17:17:52 <clokep_work> You're welcome. :) 17:18:23 <-- FeuerFliege has quit (Ping timeout) 17:18:34 <wnayes> The UI will be a task for another day :) 17:19:23 <clokep_work> The backend is the fun part anyway. ;) 17:30:47 * jwir3|dinner is now known as jwir3 17:35:33 --> FireFly_TB has joined #instantbird 17:38:12 <flo> clokep_work: thanks for the quick review! :) 17:38:30 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 17:38:33 <-- jb has quit (Ping timeout) 17:45:21 <-- Mad_Maks has quit (Client exited) 17:46:24 <-- Bollebib has quit (Ping timeout) 17:46:55 <clokep_work> flo You're welcome. 18:34:23 <-- Kaishi has quit (Quit: Kaishi) 18:41:48 <-- myk has quit (Input/output error) 19:02:38 --> aleth has joined #instantbird 19:02:38 * ChanServ sets mode +h aleth 19:15:59 --> flo has joined #instantbird 19:15:59 * ChanServ sets mode +qo flo flo 19:16:33 <-- FireFly_TB has quit (Ping timeout) 19:16:33 <flo> I think I have a fix for bug 1377! \o/ 19:16:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1377 nor, --, ---, nobody, NEW, aContactA/B errors when buddies sign in or out 19:21:38 <-- igorko has quit (Connection reset by peer) 19:28:49 <aleth> :) never been able to reproduce that properly 19:30:56 <flo> it "works" only with closed groups, or very very bad luck. 19:32:08 <flo> I haven't had an opportunity to verify that my fix actually fixes the bug, but I have a convincing explanation of what caused the bug, and the patch removes code duplication, so I think we can take it anyway as a clean up :) 19:33:29 <aleth> It can always be reopened ;) 19:33:35 <flo> clokep_work: what would you think of an add-on to "ignore" some people on IRC, where "ignore" would just display their messages in the same color as context messages, or even as system messages? :-D 19:34:50 <aleth> If they are system messages they will even collapse nicely :D 19:35:19 <flo> ahah 19:35:51 <flo> aleth: I would want to collapse messages from other people taking to that person too 19:35:57 <flo> so that the whole conversation is collapsed :-D 19:36:21 <aleth> nice :D 19:36:45 * flo goes back to writing an explanation in a bug comment 19:36:59 <flo> explaining clearly is actually more difficult than the fix 19:42:56 <clokep_work> flo: Would be reasonable as an add-on, yes. 19:43:39 --> igorko has joined #instantbird 19:46:34 <clokep_work> flo: Great news about that bug. :) I assume a review is coming my way? :P 19:47:21 <flo> clokep_work: yeah, as soon as I finish that comment 19:47:27 <flo> except if aleth wants to take it over 19:47:42 <aleth> I think clokep_work knows that code much better 19:47:46 <clokep_work> That's fine w/ me. :) 19:47:49 * Mook_as needs an addon to make specific people never highlight him :D 19:48:00 <clokep_work> Mook_as: I'd like that too in fact. 19:48:07 <clokep_work> (Or put a timeout on it?) 19:48:14 <clokep_work> You can only ping me once every 5 minutes. 19:48:24 <Mook_as> yeah, I need to figure out how to add hooks in there 19:48:46 <clokep_work> I think those are there already. 19:49:41 <flo> Mook_as: I don't think you can get highlighted from system messages 19:50:19 <aleth> Yes, I remember fixing it that way 19:50:27 <aleth> (it was discussed) 19:50:30 <Mook_as> oh, this is independent from your thing 19:56:18 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 20:00:29 <flo> ah, I think I just found a simpler alternative fix 20:00:45 <flo> we should probably take both :) 20:01:48 <clokep_work> If they clean up the code, yes, please. 20:03:47 <instantbot> New Core - Twitter bug 1484 filed by aletheia2@fastmail.fm. 20:03:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1484 nor, --, ---, nobody, NEW, Incorrect shutdown leads to the same tweets being fetched twice 20:04:33 <flo> clokep_work: yeah, both remove code duplication :) 20:06:19 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1562 on bug 1377. 20:06:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1377 nor, --, ---, florian, NEW, aContactA/B errors when buddies sign in or out 20:09:52 <clokep_work> I need to try that tonight before I can be sure it's OK. 20:09:58 --> FeuerFliege has joined #instantbird 20:09:58 <clokep_work> Do you have STR the issue by any chance? :-D 20:10:08 --> FireFly_TB has joined #instantbird 20:11:12 <flo> clokep_work: no, I've not even tried to run a build with that patch :) 20:11:19 <flo> (I will before commiting it of course) 20:11:35 <flo> but it's really trivial removal of code duplication 20:12:04 <flo> and for the steps to reproduce, they are relatively easy to make up: you need to be reordering contacts in a closed group. 20:12:29 <clokep_work> OK, that's what I thought. 20:12:33 <clokep_work> Yeah, it looks good. 20:12:41 <clokep_work> I'm just not comfortable enough w/ that code to give an r+ without trying it. 20:13:38 <flo> I'm less comfortable with the code it removes (which I know is broken, hard to understand, and duplicated) than with the code the patch inserts :) 20:15:01 <flo> and I even added a quite descriptive comment ;) 20:15:38 <aleth> aNoFading is for future use? 20:15:54 <flo> aleth: it's for use from group.xml 20:18:21 <clokep_work> aleth: Feel free to do a review if you'd like (I can superreview it if you want. :P) 20:19:25 <flo> ahah https://hg.instantbird.org/instantbird/rev/f9a904fc3bcf 20:19:27 <aleth> No, I really don't know that code well enough... just thought I'd take a look. It looks like a good change fwiw 20:19:43 <flo> I'm not sure I would have thought of calling finishRemoveNode from the destructor :) 20:20:10 <flo> hmm https://hg.instantbird.org/instantbird/rev/c52ff748f62c 20:20:16 <flo> I'll need to go look at that bug 20:21:24 <flo> so I wrote that crappy code, and you (clokep_work) r+'ed over IRC 20:21:27 <flo> https://bugzilla.instantbird.org/show_bug.cgi?id=1178#c10 20:21:30 <instantbot> Bug 1178 maj, --, 1.2, florian, RESO FIXED, Regression: renamed contacts disappear from list 20:22:21 <clokep_work> Oops. O:-) 20:23:27 <flo> but it was already messy before: https://hg.instantbird.org/instantbird/rev/ca16aba596fb :-S 20:25:28 <flo> anyway, let's fix it and forget that mess :) 20:25:50 <flo> the old code with removeNode and finishRemoveNode was really messy 20:26:03 <flo> it's surprising how just renaming a method simplifies things 20:29:34 <clokep_work> Yup! 20:29:38 <clokep_work> I'll review it when I'm home. 20:30:39 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 20:34:16 <flo> yeah, no rush, we've been able to live with this regression for 3 months, so it can wait another few hours :) 20:34:26 <flo> deomega1: will be happy once it's fixed though :) 20:36:59 <deomega1> lol.. i do not know what that will be that is fixed :) 20:37:34 <flo> deomega1: I found this evening a fix (2 actually) for the bug that made the sort by status add-on unusable. 20:38:49 <deomega1> ohhhhhhhh. THANK YOu. that is pretty awesome, becaus eit is really avery nice addon 20:40:49 <deomega1> And that thing that mic has done.. the session restore.. simply beautiful... I saw his to-do list so I know he will be addressing the multiple windows being remembered 20:43:09 <deomega1> have a great evening.. did not realize i have had this window open all day 20:43:11 --> DGMurdockIII has joined #instantbird 20:43:30 <flo> deomega1: is it a problem that it's there? ;) 20:43:34 <flo> as long as it's quiet :) 20:44:25 --> Mad_Maks has joined #instantbird 20:45:35 <flo> so now that I can look at the patch I really wanted to do this evening :) 20:46:03 <flo> *now that I've finished taking the opportunity of using the valuable info DOMi gave me 20:46:18 <-- Mad_Maks has quit (Client exited) 20:47:01 * jwir3 is now known as jwir3|lunch 20:48:27 <deomega1> flo: not a problem really.. good point 20:48:42 <deomega1> especially since it minimizes to the contact list 20:50:11 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1563 on bug 1484. 20:50:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1484 nor, --, ---, aletheia2, ASSI, Incorrect shutdown leads to the same tweets being fetched twice 20:50:20 <-- igorko has quit (Connection reset by peer) 20:57:34 <flo> aleth: are you really sure that a setChatPref call is cheap? 20:58:14 <aleth> I thought you said it was, a couple of months ago... but I may be misremembering something 20:58:35 <flo> Chat -> Char of course 20:58:57 <flo> aleth: I said get*Pref is cheap. I'm not sure set*Pref is 20:59:15 <aleth> Is the disk write not async? 21:00:07 <flo> I'm not sure 21:00:41 * Mook_as thought it was mainly in-memory and not flushed immediately 21:01:05 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1563 on bug 1484. 21:01:06 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1564 on bug 1484. 21:01:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1484 nor, --, ---, aletheia2, ASSI, Incorrect shutdown leads to the same tweets being fetched twice 21:01:29 <flo> Mook_as: so it's flushed with a timer? 21:02:07 <aleth> That would be nice... 21:02:53 <Mook_as> all I know is, in some cases if you crash at the right spot, it wouldn't flush :p 21:03:12 <flo> Mook_as: I know that too :-P 21:03:28 <flo> Mook_as: but I don't know how it's actually implemented 21:04:22 --> mmkmou has joined #instantbird 21:04:28 <Mook_as> Magic⢠21:04:39 <flo> Mook_as: nope 21:04:46 <flo> Magic is reserved for Instantbird features 21:04:53 <flo> Mozilla features can only be Awesome ;) 21:05:03 <Mook_as> SplendidMagicâ¢? 21:05:06 <aleth> Awesome⢠21:05:22 --> jb has joined #instantbird 21:06:27 --> jb1 has joined #instantbird 21:07:58 <-- jb has quit (Ping timeout) 21:07:58 <-- jb1 has quit (Input/output error) 21:08:00 --> jb has joined #instantbird 21:11:26 <-- FireFly_TB has quit (Ping timeout) 21:11:49 <-- FeuerFliege has quit (Ping timeout) 21:12:03 --> clokep has joined #instantbird 21:12:03 * ChanServ sets mode +o clokep 21:14:07 <-- mmkmou has quit (Ping timeout) 21:14:27 --> EionRobb has joined #instantbird 21:18:14 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1564 on bug 1484. 21:18:15 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1565 on bug 1484. 21:18:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1484 nor, --, ---, aletheia2, ASSI, Incorrect shutdown leads to the same tweets being fetched twice 21:18:32 <clokep> The obligatory three patches from aleth I see. ;) 21:18:47 <aleth> :D 21:18:58 <aleth> Well, it's in response to flo's comment... 21:19:30 --> FireFly_TC has joined #instantbird 21:20:17 <instantbot> clokep@gmail.com granted review for attachment 1562 on bug 1377. 21:20:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1377 nor, --, ---, florian, NEW, aContactA/B errors when buddies sign in or out 21:20:46 <flo> so the patch I really wanted to make this evening has an even better diffstat: 7 files changed, 5 insertions(+), 113 deletions(-) :) 21:21:13 <aleth> sounds efficient ;) 21:21:29 <flo> http://pastebin.instantbird.com/44528 21:21:55 <flo> some code we upstreamed into the platform, that's in moz11 (https://bugzilla.mozilla.org/show_bug.cgi?id=697546) 21:22:13 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 21:22:50 <clokep> :) 21:22:58 * clokep was expecting it to be using the DOMParser. 21:23:02 <flo> clokep: Tb doesn't have contact animations 21:23:15 <clokep> flo: OK. :) 21:23:22 <flo> clokep: isn't that included in the moz12update changeset? 21:23:38 <clokep> Ah, I think you're right. 21:23:48 <-- Optimizer has quit (Ping timeout) 21:24:11 <flo> clokep: but we can probably benefit more from it by removing a few ugly hacks :) 21:24:26 <flo> do we still need the hidden window to always be an HTML document? 21:24:52 <clokep> Probably not. 21:24:54 <flo> http://lxr.instantbird.org/instantbird/source/chat/modules/hiddenWindow.jsm is horrible ;) 21:24:58 --> jb1 has joined #instantbird 21:24:58 <clokep> But I don't know exactly how that's used. 21:25:11 <clokep> Ah, you were able to help out glazou with that code too. ;) 21:25:13 <aleth> What's the hiddenWindow? 21:25:23 <clokep> (FWIW That' change could be r+ me, but I obviously can't test. 21:25:26 <flo> http://lxr.instantbird.org/instantbird/search?string=getHiddenHTMLWindow we still use it in 3 places 21:25:36 <flo> clokep: I tested it :) 21:25:40 <aleth> is this for when you need a window for technical reasons? 21:26:10 <flo> aleth: I don't really understand why it's needed on non-Mac OSes 21:27:00 <flo> but some code of the platform assumes that there's always at least one DOM window account, so there's an invisible window that's created early at startup, and is the last one to go away at shutdown 21:27:21 --> Optimizer has joined #instantbird 21:27:24 <flo> on Mac, it's needed to attach the menu items that we want to display in the menu bar when no window is opened 21:27:59 <flo> aleth: accessing that window used to be very useful for add-ons to share variables/objects between windows before JS modules had been invented 21:28:21 <flo> (JS XPCOM components already existed, but were more difficult to create than they are now) 21:28:25 <aleth> So it exists on all OS, but is only needed on OSX these days. 21:29:08 <flo> yeah... 21:29:26 <flo> so to make things complicated, on Mac it's a xul window (to have xul menus), and on other OSes, it's an empty HTML document 21:30:24 <-- jb has quit (Quit: jb) 21:31:48 <-- Optimizer has quit (Ping timeout) 21:34:43 <flo> hmm, I guess I can check-in https://bugzilla.mozilla.org/show_bug.cgi?id=761688 now for Instantbird, even though it's not yet in comm-central 21:35:01 --> Optimizer has joined #instantbird 21:35:16 <clokep> aleth: Did you test this patch? 21:35:32 <aleth> I tested the first patch. 21:36:42 <clokep> Ah you missed a . at one point. 21:37:12 <aleth> ah yes :( 21:38:21 <aleth> But if that's all that's wrong with it that won't be too bad ;) I don't know the twitter code really. 21:38:38 <clokep> It's not too too complicated. :) 21:39:13 <aleth> Mainly I couldn't see anything else that called displayTweet, but I may have missed something. 21:41:27 <flo> clokep: are we fixing bug 1338 (also visible in Thunderbird), or rewriting that messy code (bug 1219)? 21:41:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1338 nor, --, ---, nobody, NEW, Connect button is disabled after an account spends more than half a second in the disconnecting stat 21:41:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1219 tri, --, ---, nobody, NEW, Cleanup the account.xml binding 21:41:38 <flo> I'm asking because it seems we have 2 bugs for the same thing in the sw:1.2 list ;) 21:42:11 <clokep> flo: We should probably rewrite the code, but if the other bug is very trivial then.... 21:42:22 <aleth> If you fix 1219 pretending it's 1338 you can say it's for TB ;) 21:42:39 * jwir3|lunch is now known as jwir3 21:42:48 <flo> uh :( 21:42:57 <flo> 1219 will need string changes 21:43:17 <flo> (moving some strings from a .dtd to a .properties) 21:46:09 <flo> the only really annoying thing in that list is the socket issue :( 21:46:24 <flo> (I include AIM not sending messages reliably in that socket issue) 21:47:51 <instantbot> clokep@gmail.com denied review for attachment 1565 on bug 1484. 21:47:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1484 nor, --, ---, aletheia2, ASSI, Incorrect shutdown leads to the same tweets being fetched twice 21:48:14 <wnayes> Is there anyplace that the protocol options for each prpl-id are listed (such as 'server', 'encryption' for AIM, etc.)? 21:48:23 <instantbot> clokep@gmail.com granted review for attachment 1566 on bug 1484. 21:49:01 <clokep> wnayes: Are you asking if you can just see them listed somewhere or do you want to access a list of them via code? 21:49:12 <clokep> aleth: Check over that patch please and make sure it still seems good. 21:49:17 <clokep> If so, mark checkin-needed? 21:49:36 <flo> there used to be some debug code to dump a list of all options 21:49:50 <flo> I haven't used it for years though 21:50:06 <wnayes> clokep: It would be nice to have a list of them for the importers, I had some code spit out the AIM ones but I wanted to make sure this wasn't already available someplace. 21:51:08 <clokep> wnayes: No, they're not available some place. 21:52:05 <aleth> clokep: Thanks! 21:52:11 <clokep> The code to get all of them could probably be useful though. :) 21:53:04 <wnayes> I might try to put together a wiki page listing them then, as they could be useful for anyone wanted to work on the importers. 21:54:41 <clokep> Yes, and include the code! :) 21:55:05 <-- Tomek has quit (Quit: Instantbird 1.1) 21:55:58 <wnayes> clokep: Is there a way to view dump() results in Windows? (That might be useful for this :)) 21:56:26 <clokep> wnayes: I usually dump stuff to the error console personally. 21:56:34 --> Kaishi has joined #instantbird 21:56:43 <clokep> Components.utils.reportError generally is what I use. 21:56:48 <-- chrisccoulson has quit (Ping timeout) 21:57:12 <clokep> I think dump goes to the console though, but you might need a debug build. 21:57:28 <wnayes> OK, I've been using that too but I figured it would be inconvenient to copy/paste each entry from the error console. 21:57:41 <flo> wnayes: http://lxr.instantbird.org/instantbird/source/instantbird/content/debug/debug.js#54 21:57:48 <clokep> "each entry"? Just have it iterate over all of them. :P 21:58:07 <Mook_as> I think you need browser.dom.window.dump.enabled set to true, and start with ./instantbird | cat ? 21:58:37 <aleth> Mook_as: he's asking about Windows... 21:58:44 <flo> isn't there a -console command line parameter to give at startup on window for a console to exist? 21:58:47 <Mook_as> yeah, I do it in msys 21:58:52 <Mook_as> you won't need |cat otherwise 21:59:00 <clokep> flo: I think there is, yes. 21:59:11 <Mook_as> yeah, but -console makes it hard to deal with on exit :( 21:59:26 <flo> yeah, that's painful :( 21:59:27 <aleth> Windows understands ./ ? 21:59:41 <clokep> In msys it does. ;) 21:59:42 <flo> aleth: bash does 21:59:42 <Mook_as> msys bash :p 21:59:50 <aleth> ahah 22:00:29 <flo> aleth: it's possible ./ works in the default microsoft shell btw 22:00:35 <flo> aleth: | definitely doesn't though :) 22:01:31 <Mook_as> | works, but there's no cat 22:02:38 <clokep> wnayes: Are you working on a "real" importer now then or the test one still? :-D 22:03:10 <flo> Mook_as: really? When have they added that? 22:03:21 <wnayes> clokep: I think I'll be able to start on one very soon, accounts are now working with the importer changing settings. 22:03:28 <Mook_as> umm, some pre-windows version of DOS? 22:03:30 <clokep> flo: I think it always has? 22:03:42 <Mook_as> `| more` was used often in those days 22:03:58 <clokep> wnayes: Awesome. :) Congrats. 22:04:12 <aleth> wnayes: :) 22:04:22 <flo> Mook_as: I'm probably not old enough then :) 22:04:40 <Mook_as> I don't think I'm much older than you are :p 22:04:49 <flo> you are! 22:05:30 <flo> that crap (DOS, command line prompts, anything related to programming) is completely inaccessible until you can read and understand English. 22:05:53 <flo> I'm almost sure your English reading skills are way older than mine ;) 22:06:02 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 22:07:00 <Mook_as> actually... English isn't my first language :p 22:07:08 <Mook_as> (and I guess I look vaguely like http://images.wikia.com/killbill/images/c/c0/PaiMeiPromo.jpg ) 22:07:20 <-- Optimizer has quit (Connection reset by peer) 22:07:23 <flo> Mook_as: that's why I said "almost" ;) 22:07:50 <flo> Mook_as: that's definitely the color of your hair :-P 22:08:00 <Mook_as> and yeah, I'm pretty sure my DOS-using days predates my English-understanding days! 22:08:13 <Mook_as> it's amazing what you could do if you want to play games... XD 22:08:43 <flo> the first pc at home was in 1992 22:09:08 <flo> but I was mostly using my father's atari 22:09:54 <Mook_as> the first one I touched was, IIRC, an i386... atari predates me. 22:11:16 <wnayes> flo: The debug code was useful, Thanks. It must have predated opt.typeList though, as I had to tweak it a bit. :) 22:11:32 <flo> wnayes: feel free to send patches :) 22:11:42 <flo> wnayes: that debug code is awfully old 22:13:01 --> chrisccoulson has joined #instantbird 22:14:06 <-- chrisccoulson has quit (Client exited) 22:14:12 --> chrisccoulson has joined #instantbird 22:16:39 <flo> Mook_as: the atari ST started directly with a desktop, there wasn't anything similar to a command line UI (except if you really wanted it I guess) 22:16:53 <flo> so no | more for me ;) 22:17:20 * clokep remembers using the command line to launch doom. ;) 22:17:27 <clokep> And some incredibly hard Jurassic Park game... 22:19:44 --> Bollebib has joined #instantbird 22:32:45 <-- GeekShadow has quit (Ping timeout) 22:47:18 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1567 on bug 1427. 22:47:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1427 enh, --, ---, clokep, ASSI, Fix up order and formatting of of IRC tooltips. 22:57:42 <clokep> Bleh my builds are funky. Conversations are weird... 22:57:51 <clokep> I think the mozilla upgraded didn't funny things... 23:01:33 <-- Bollebib has quit (Ping timeout) 23:05:41 <flo> Good night 23:05:42 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 23:05:57 <clokep> 'night! 23:06:09 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0a1aa7e2827a - Florian Quèze - Bug 1377 - aContactA/B errors when buddies sign in or out, r=clokep. 23:06:11 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a26ec4a13add - aleth - Bug 1074 - Default message styles lack context message support, r=Mic 23:06:12 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/027f06cf53a2 - aleth - Bug 1484 - Incorrect shutdown leads to the same tweets being fetched twice, r=clokep. 23:06:13 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e9086f2ce535 - Florian Quèze - Bug 761688 - Call removeController in convbrowser.xml only if it has actually been inserted, r=clokep. 23:06:14 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/33220609b0fc - Florian Quèze - Remove nsDockTile now that it's part of the platform (upstreamed in bug 697546), r=clokep. 23:07:22 <wnayes> :) https://wiki.instantbird.org/Protocol_Preferences 23:08:05 <instantbot> clokep@gmail.com set the Resolution field on bug 1484 to FIXED. 23:08:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1484 nor, --, 1.2, aletheia2, RESO FIXED, Incorrect shutdown leads to the same tweets being fetched twice 23:08:55 <instantbot> clokep@gmail.com set the Resolution field on bug 1074 to FIXED. 23:09:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1074 nor, --, ---, aletheia2, RESO FIXED, Default message styles lack context message support 23:09:02 <clokep> wnayes: Looks good. :) 23:09:36 <instantbot> clokep@gmail.com set the Resolution field on bug 1377 to FIXED. 23:09:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1377 nor, --, 1.2, florian, RESO FIXED, aContactA/B errors when buddies sign in or out 23:10:47 <instantbot> aletheia2@fastmail.fm denied review for attachment 1567 on bug 1427. 23:10:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1427 enh, --, ---, clokep, ASSI, Fix up order and formatting of of IRC tooltips. 23:10:56 <clokep> wnayes: No google talk in that list? 23:11:14 <aleth> That looks useful! 23:12:56 <wnayes> clokep: Must have missed it. There is now :) 23:13:26 <clokep> :) 23:15:57 <clokep> aleth: Any ideas what to do about the server info bit? 23:16:20 <aleth> Just check if serverName and serverLocation are set before using the values. 23:16:46 <clokep> OK. And I changed the comment to say that it's some generic information, not necessarily a location... 23:17:05 <clokep> That seem like enough for an r+? :) 23:17:24 <aleth> I should think so :) 23:17:41 <aleth> I wonder if we should do more with 313 than just setting ircOp to true 23:18:05 <aleth> i.e. ":is a Network Service" seems useful information to add to whois 23:18:30 <aleth> (That would be a different bug though of course) 23:19:14 <aleth> Is every Network Service even an ircop? (I don't know) 23:19:18 --> GeekShadow has joined #instantbird 23:19:19 <clokep> It tells you it's a service! But probably isn't supported on all networks. 23:19:26 <clokep> I mean, not necessarily...but probably. 23:20:29 <aleth> Currently the WHOIS entry does not say it's a service, only that it's an IRC op. 23:20:41 <aleth> Does that make a difference? 23:20:43 <-- EionRobb has quit (Connection reset by peer) 23:20:48 * aleth confused 23:21:10 --> EionRobb has joined #instantbird 23:21:16 <clokep> They mean different things. The response of 313 means they're an IRC operator. the note text is being used to tell us different. 23:21:51 <aleth> Ah :-/ 23:22:31 <clokep> 313 doesn't mean they're a service. 23:22:31 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1568 on bug 1427. 23:22:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1427 enh, --, ---, clokep, ASSI, Fix up order and formatting of of IRC tooltips. 23:22:43 <aleth> Is it worth filing a bug for that? Or is it totally nonstandard usage of 313? 23:22:56 <aleth> (in which case, blame mozilla.org) 23:23:15 <clokep> moznet uses a fairly standard ircd, they run unreal I think. 23:23:43 <-- jb1 has quit (Ping timeout) 23:23:49 <clokep> We need to figure out someway to figure out who is a service. :( Part of that NickServ bug too. 23:24:10 <aleth> It just seems like currently our whois entry is incorrect for that case. 23:24:28 <clokep> It's not really /wrong/... 23:24:33 <clokep> They still are an IRC op. 23:24:46 <aleth> yeah... 23:26:56 <instantbot> aletheia2@fastmail.fm granted review for attachment 1568 on bug 1427. 23:26:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1427 enh, --, ---, clokep, ASSI, Fix up order and formatting of of IRC tooltips. 23:27:58 <clokep> Thanks aleth. :) 23:39:44 <-- Kaishi has quit (Quit: Kaishi) 23:40:20 <aleth> I can't believe twitter called their font "Awesome" 23:40:30 --> FeuerFliege has joined #instantbird 23:40:36 --> FireFly_TB has joined #instantbird 23:41:41 <clokep> Do they? Hahah. 23:42:10 <aleth> http://fortawesome.github.com/Font-Awesome/ 23:42:16 <-- FeuerFliege has quit (Ping timeout) 23:42:23 <-- FireFly_TB has quit (Ping timeout) 23:44:16 <clokep> Hah, nice. 23:47:26 <-- chrisccoulson has quit (Quit: Ex-Chat) 23:48:34 --> chrisccoulson has joined #instantbird 23:49:10 <instant-buildbot> build #268 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/268 23:55:26 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)