#instantbird log on 06 02 2012

All times are UTC.

00:00:07 <aleth> You occasionally see the issue even on #instantbird with 20 participants
00:01:37 <aleth> But yeah, adding them dynamically would do the trick I guess
00:02:15 <flo> your screen is that small?
00:02:24 --> FireFly_TB has joined #instantbird
00:02:35 <aleth> No, but I don't always have the window the same size
00:02:43 <aleth> Plus I've experimented around this bug ;)
00:02:59 <flo> I can display 31 nicks before a scrollbar appears
00:03:10 <flo> anyway, good night
00:03:19 <flo> it's too late for crazy ideas that actually work ;)
00:03:33 <aleth> or still work in the morning ;)
00:03:53 <aleth> Anyway, no more ChanServ tomorrow will be nice :)
00:04:19 <flo> I would like to be able to tell why my Instantbird takes 10 to 20% of the CPU and 140MB of RAM
00:04:23 <-- Mook_astb has quit (Ping timeout)
00:04:41 <flo> I'm sure if I could tell where all these resource go, we could optimize a large part of it
00:04:56 <clokep> Sounds like we need to implement some of the memory stuff?
00:05:21 <aleth> I don't think I've ever seen IB use that much CPU
00:05:51 <aleth> Do you suspect there are leaks?
00:05:52 <flo> it doesn't happen to me these days as I don't use my machine offline much, but when I used my laptop in trains or to take notes in courses, it also really annoyed me that Instantbird took some CPU even when all the accounts were disconnected
00:06:18 <instant-buildbot> build #261 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/261
00:06:28 <flo> aleth: the amount of error messages sent to my error console is probably wasteful
00:06:54 <flo> but the "all accounts offline" case frustrates me, because there's no reason to do anything at all in that case
00:07:31 <flo> clokep: I hope the "compartement per global" stuff that landed for Moz15 will make about:memory useful for us
00:08:11 <flo> aleth: leaks are possible, but I don't think they are large
00:08:32 <flo> as my Ib process tends to take ~100MB less than an hour after starting, and very slowly increase over time
00:08:44 <aleth> I've not seen IB use increasing amounts of memory
00:09:00 <flo> so no new messages are added to your conversations?
00:09:00 <aleth> Not noticeably, anyway
00:09:50 <aleth> Well yes, it might go up from 80 to 100 M or so... that doesn't seem too unreasonable
00:10:10 <clokep> I'm usually < 100 MB...but that's not much compared to 500 MB for Firefox. :)
00:10:32 <flo> clokep: I restart my Firefox when it reaches 1GB
00:10:50 <flo> and Firefox takes 500MB a few minutes after starting
00:11:04 <flo> but I use so many tabs that I don't blame it for using several hundred MB after starting
00:11:12 <flo> the increase is annoying though
00:11:47 <clokep> :)
00:11:56 <aleth> Every g+ button uses 1.5M ;)
00:12:09 <flo> are there g+ buttons on my tabs?
00:12:35 <aleth> They are on websites... I guess fb like buttons are similar
00:13:00 <clokep> +, like, tweet!
00:14:15 <flo> I would need to reinstall abp then
00:14:27 <flo> but I didn't expect these buttons on my lxr/mxr/dxr tabs ;)
00:14:39 <flo> or bmo/bio tabs
00:14:54 <flo> or etherpad.m.o
00:15:32 <clokep> Nothing there for fun? :p
00:15:32 <flo> and now instantbird is at 190MB :-S
00:16:18 <flo> some ebay tabs (right now, but not during the day)
00:17:07 <flo> and often tabs from a forum of AMI owners
00:17:18 <flo> but I don't think they have such pointless buttons there
00:18:07 <clokep> http://i.imgur.com/l57Cl.png :-S
00:18:26 <clokep> The contact is showing up as the AIM contact, which is clearly offline, but there is an away GTalk contact...
00:18:54 <flo> seems wrong :(
00:19:17 <clokep> Yup.
00:19:26 <clokep> I have no actual STR though.
00:19:41 <clokep> I do have lots of "aContactB is undefined" though...
00:20:14 <flo> I have them too
00:20:21 <flo> this is what I have in my about:memory: http://pastebin.mozilla.org/1653729
00:21:31 <flo> the part that bugs me is "78.37 MB (100.0%) -- explicit" out of "173.20 MB -- resident"
00:21:54 <clokep> "heap-unclassified"?
00:21:55 <-- FireFly_TB has quit (Ping timeout)
00:21:57 * clokep wonders if that's libpurple...
00:22:47 <flo> hmm, Firefox seems to have similar numbers (521.52 MB (100.0%) -- explicit,   949.02 MB ── resident), maybe that's OK :-S
00:23:11 <flo> in my Firefox: ├──211.12 MB (40.48%) ── heap-unclassified
00:23:14 <flo> that's large! :-D
00:23:52 <flo> but it wouldn't be very useful to report things for a release version, so many things have already been improved since that... :)
00:26:13 <clokep> Yeah, only 23% of my heap is unclassified.
00:26:45 <flo> on Instantbird "├──23.79 MB (30.36%) -- heap-unclassified"
00:27:13 <-- myk has quit (Ping timeout)
00:36:17 <flo> Good night (for real this time)
00:37:04 <clokep> Goodnight. :)
00:51:47 <-- wesj has quit (Input/output error)
00:54:30 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:56:26 --> clokep has joined #instantbird
00:56:26 * ChanServ sets mode +o clokep 
01:08:24 <-- instant-buildbot has quit (Ping timeout)
01:09:56 --> instant-buildbot has joined #instantbird
01:09:56 * ChanServ sets mode +v instant-buildbot 
01:11:14 --> FireFly_TB has joined #instantbird
01:30:42 <instant-buildbot> build #232 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/232
01:47:28 <instant-buildbot> build #251 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/251
01:58:04 <-- FireFly_TB has quit (Ping timeout)
02:17:54 --> Mook has joined #instantbird
02:43:38 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603])
02:52:00 --> Mook has joined #instantbird
02:56:07 <-- aleth has quit (Input/output error)
03:00:56 <instant-buildbot> build #514 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/514
03:16:03 <clokep> Mook: Thanks for filing that bug.
03:18:55 <Mook> no problem; now to figure out why memoserv is pinging me every 15 minutes
03:19:30 <Mook> I mean, it _could_ be because I'm disconnecting.... but nothing's showing up in the server tab
03:20:13 <Mook> btw, if I'm talking about irc-in-tb, is this channel more appropriate, or #thunderbird?
03:21:05 <clokep> Mook: Either here or in #maildev.
03:21:12 <clokep> If it's UI stuff...#maildev is probably more appropriate.
03:21:32 <clokep> If it's backend stuff...where ever I am is fine. ;) (or aleth knows a bit about it too).
03:21:35 <Mook> okay. I don't suppose you happen to know how I can get monospaced fonts? :p
03:21:42 <clokep> MemoServ will ping you whenever you come back from being away too.
03:22:05 <Mook> ah; I must be triggering the screen saver
03:22:18 <clokep> Tools > Options > Display > Formatting > Fonts?
03:22:20 <clokep> Maybe? :-D
03:22:52 <Mook> Oooh, yes. except that applies to everything, not just IRC :p
03:22:58 <clokep> Yes. :)
03:23:07 <clokep> The Chat tab has something about setting yourself idle every 5 minutes.
03:23:37 <clokep> Disabling that would have memoserv be less annoying...although you won't be set to idle ever. :P
03:23:47 <clokep> Feel free to file a bug about MemoServ...
03:24:03 <clokep> (Tough though because we don't have any mail notification system yet...)
03:24:45 <clokep> wnayes: At some point I wonder if we should go over style with you, just to ensure you don't write lots of code that needs to be restyled.
03:27:55 * Mook wonders how much work it would be to turn ib into a bouncer and decouple the display
03:28:20 <clokep> Probably not much.
03:28:27 <clokep> Where would you display stuff then?
03:28:49 <Mook> either on a different machine, or out-of-process (for android)
03:29:41 <clokep> We discussed that ti would be neat to forward messages to another instance at one point...
03:30:07 <clokep> You could just capture all the notifications to display messages and then through them in some queue that lets you get the message however.
03:30:11 <Mook> yep, in my case leaving my linux machine running and display on my windows laptop
03:30:27 <Mook> (or json it and slap it on a web server)
03:30:31 <clokep> email, other IM network, push it over SSH, snailmail, smoke signals, idk what.
04:03:49 <Mook> ooh, irc: Unhandled IRC message: :concrete.mozilla.org 329 Mook #instantbird 1306707752
04:13:52 <clokep> Yes?
04:14:07 <clokep> It's just a warning. ;)
04:18:26 <clokep> Mook: Do you know how often I want the Python style split function?
04:18:32 <clokep> Since you mentioned it I keep trying to use it...
04:18:56 <clokep> The limit flag in JavaScript is rather useless...
04:24:20 <Mook> yep, exactly
04:24:36 <Mook> oh, and for the warning: it would be nice if it didn't spew it on stdout/stderr, whichever it was :)
04:27:00 <clokep> It goes to the error console...?
04:27:11 <clokep> Does it go to stdout too?
04:27:18 <Mook> that's where I copied it from
04:27:23 <Mook> wouldn't have noticed otherwise
04:29:05 <clokep> Hmmm...I see.
04:35:27 <instant-buildbot> build #607 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/607
04:37:49 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
04:38:06 --> clokep has joined #instantbird
04:38:07 * ChanServ sets mode +o clokep 
05:02:19 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
05:12:29 <-- Mook has quit (Quit: Mook)
06:03:13 <instant-buildbot> build #501 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/501
07:28:58 <-- jb has quit (Ping timeout)
08:15:52 --> jb has joined #instantbird
08:28:04 <-- jb has quit (Ping timeout)
08:30:35 --> jb has joined #instantbird
08:36:13 <-- gerard-majax has quit (Ping timeout)
08:42:42 <-- meh has quit (Ping timeout)
08:43:19 --> Optimizer has joined #instantbird
08:53:00 --> gerard-majax has joined #instantbird
08:54:54 <-- jb has quit (Ping timeout)
09:25:59 --> Tomek has joined #instantbird
09:29:39 --> Even has joined #instantbird
09:29:39 * ChanServ sets mode +o Even 
09:31:52 <-- chrisccoulson has quit (Ping timeout)
09:55:46 --> meh has joined #instantbird
09:59:33 --> Mic|web has joined #instantbird
10:09:29 <-- Optimizer has quit (Ping timeout)
10:11:59 <Mic|web> Hello
10:12:52 --> Optimizer has joined #instantbird
10:24:07 <-- Optimizer has quit (Ping timeout)
10:27:32 --> Optimizer has joined #instantbird
10:35:11 --> Lalae has joined #instantbird
10:36:54 <-- Lalae has left #instantbird ()
10:38:10 <-- Optimizer has quit (Ping timeout)
10:39:10 <-- skeledrew has quit (Client exited)
10:39:23 --> skeledrew has joined #instantbird
10:41:10 --> Optimizer has joined #instantbird
10:45:10 <-- Optimizer has quit (Ping timeout)
10:46:33 <Mic|web> Very strange, now it's working again to disable and reenable a restartless extension to reload it from disk. That worked a while ago, later I got cached results (not updated on reload when something was changed) and now it's working again.
10:46:45 <Mic|web> I won't complain ;)
10:48:40 --> Optimizer has joined #instantbird
10:53:50 <Mic|web> flo: what's the meaning of the aDefaultChatName parameter for getChatRoomDefaultFieldValues?
10:58:47 <-- Optimizer has quit (Ping timeout)
11:02:11 --> Optimizer has joined #instantbird
11:04:46 <-- Optimizer has quit (Ping timeout)
11:08:49 <flo> Mic|web: getChatRoomDefaultFieldValues returns a prplIChatRoomFieldValues, aDefaultChatName is an optional string that can be parsed by the prpl to initialize the fields
11:09:02 --> Optimizer has joined #instantbird
11:13:26 <-- Optimizer has quit (Ping timeout)
11:16:46 --> Optimizer has joined #instantbird
11:19:22 <-- Kaishi has quit (Quit: Kaishi)
11:21:48 <-- Optimizer has quit (Ping timeout)
11:31:27 --> Optimizer has joined #instantbird
11:53:05 <-- Optimizer has quit (Ping timeout)
12:12:37 --> aleth has joined #instantbird
12:12:37 * ChanServ sets mode +h aleth 
12:13:35 <-- aleth has quit (Input/output error)
12:13:47 --> aleth has joined #instantbird
12:13:47 * ChanServ sets mode +h aleth 
12:16:15 * aleth just joined freenode channels without having to close ChanServ tabs :)
12:18:58 <aleth> So much nicer to have the welcome message under the topic! http://i.imgur.com/Aewsc.png
12:19:16 --> clokep has joined #instantbird
12:19:16 * ChanServ sets mode +o clokep 
12:19:20 <meh> that's a nice theme
12:19:40 <meh> how I wish I could handle light themes :(
12:22:16 <clokep> meh: Make a dark version? :P
12:22:25 <meh> clokep, but then it wouldn't be as nice
12:22:30 <clokep> Why not?
12:22:42 <meh> clokep, http://i.imgur.com/Aewsc.png
12:22:55 <meh> dark it wouldn't be as nice
12:23:17 <aleth> It's just the KDE default actually.
12:23:21 <aleth> Well, with a different font.
12:23:58 <aleth> Or do you mean the bubbles style?
12:24:03 <meh> I mean everything
12:24:11 <clokep> I don't see how you can just assert "Dark wouldn't be as nice"
12:24:38 <aleth> I'm sure it's possible to make a good-looking dark message style with bubbles
12:24:50 <aleth> You'd have to play around a bit...
12:25:02 <meh> clokep, because it'd have to be black to not be ugly on this monitor
12:25:08 <meh> I can see the pixels unless it's black
12:26:12 <clokep> Bah, I don't feel like arguing.
12:26:21 <meh> lol
12:26:22 <meh> neither do I
12:26:26 <meh> let's make love
12:34:56 * aleth wonders why Mook is using TB if its just for IM, and not IB
12:36:04 <aleth> I added some links etc to the wiki, https://wiki.instantbird.org/Instantbird:Coding_Guidelines and https://wiki.instantbird.org/Instantbird:Bugfix , hope that's appropriate
12:36:10 --> Optimizer has joined #instantbird
12:44:32 <Mic|web> :O
12:44:41 * Mic|web just automatically re-joined an AIM MUC :)
12:45:42 <aleth> http://hg.instantbird.org/instantbird/rev/20da6cb12aad doesn't seem to work for me :(
12:46:20 <aleth> Double-clicking a nick still selects the hour part of the message time too.
12:52:00 <aleth> Maybe it was not meant to fix that?
12:52:47 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:52:52 --> aleth has joined #instantbird
12:52:52 * ChanServ sets mode +h aleth 
12:54:06 <instantbot> aletheia2@fastmail.fm granted review for attachment 1546 on bug 1477.
12:54:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1477 enh, --, ---, clokep, ASSI, Authenticate with NickServ
12:56:16 --> mmkmou has joined #instantbird
12:58:19 <clokep> aleth: WFM.
12:58:24 <flo> I'm not convinced either that we really need a pref for nickserv
12:59:52 <clokep> flo: There should eventually be other methods of authentication as well (SASL and Ident).
12:59:55 <aleth> clokep: You don't see something like this when double-clicking a nick? http://i.imgur.com/oIp6e.png
13:00:15 <clokep> aleth: No.
13:00:23 <clokep> It selects the nick (and the space after it :().
13:00:29 <aleth> :-/
13:00:41 <flo> aleth: you need to update your theme :-P
13:00:49 <flo> you aren't using the default one I think ;)
13:00:54 <aleth> flo: Heh, you're right.
13:00:57 <aleth> Sorry.
13:01:11 <aleth> I forgot it was a patch to the message style.
13:26:07 <Mic|web> Soemthing for the daring: https://addons.instantbird.org/en-US/instantbird/addon/322
13:26:59 <Mic|web> It's definitely not ready, but it should be able to restore MUCs now (unfortunately I can't try with IRC here (proxy problems:( )) but it worked with AIM/ICQ MUCs already.
13:27:34 <instantbot> New Instantbird (UI) bug 1479 filed by aletheia2@fastmail.fm.
13:27:35 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1549 on bug 1479.
13:27:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1479 min, --, ---, nobody, ASSI, [Tab complete] Remove trailing ": " suffix when pressing backspace before undoing completion
13:28:18 <clokep> aleth, flo: I replied in the NickServ bug giving some more information on the things I tried.
13:28:26 <clokep> It might convince you. If not, we can talk about it more.
13:28:37 <clokep> Mic|web: How are you storing the chat room fields?
13:29:45 <aleth> Mic|web: You will be making deOmega very happy ;)
13:29:49 <clokep> Ah, it's restartless? :)
13:29:49 <Mic|web> clokep: I don't. I'm storing the chat name and use it as parameter for getChatRoomDefaultFieldValues. Worked fine for the cases where I could check.
13:30:06 <clokep> Ah, OK.
13:30:08 <Mic|web> I'll try with IRC this evening
13:30:15 <clokep> That should work for most protocols.
13:30:20 <clokep> It should work for IRC unless there's a key.
13:31:07 <clokep> I'd try...but won't my auto-joins join anyway?
13:32:25 <Mic|web> Yes, I suggest you empty the list when trying the extension
13:32:31 <aleth> clokep: Ah, I was hoping for something like SERVLIST :( Wishful thinking...
13:32:46 <clokep> aleth: It exists...it just doesn't seem to be used. :-D
13:40:13 <Mic|web> I'm really curious if it'll work well with IRC :)
13:40:17 <Mic|web> bbl
13:40:45 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
13:53:37 <flo> aleth: it seems the tab complete behavior is getting more and more complicated
13:54:07 <flo> would be really nice to have unit tests, to be sure (instead of just believing) that we don't break other corner cases when adding more code to fix the current annoying details :)
13:55:39 <flo> aleth: why has the |return;| been moved and duplicated?
13:56:32 <aleth> flo: I think the behaviour is pretty stable now actually. This is just a detail.
13:56:43 <aleth> My bad about the return.
13:56:47 <flo> yeah, it's totally a detail :)
13:56:50 <flo> an annoying one though!
13:57:03 <aleth> Unit tests would require moving the whole thing to a module, right?
13:57:04 <flo> I would have filed it if I knew it would be easily fixable :)
13:57:09 <aleth> I've been wondering whether to do that.
13:57:10 <flo> probably, yes
13:57:22 <flo> I would like if you could do it :)
13:57:39 <flo> porting all your patches to Thunderbird's fork of conversation.xml would be a pain
14:00:08 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1549 on bug 1479.
14:00:09 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1550 on bug 1479.
14:00:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1479 min, --, ---, nobody, ASSI, [Tab complete] Remove trailing ": " suffix when pressing backspace before undoing completion
14:00:39 <flo> bah, we mid-aired :-S
14:03:29 <flo> I'm wondering how much more difficult to understand the code would be if we unified the 2 parts that seem duplicated now
14:03:53 <aleth> I couldn't see a way to unify it that would not make it harder to read.
14:04:11 <flo> aleth: what's |if (this._completions[0].slice(-2) == ": ")| actually testing?
14:04:14 <aleth> This way you can visually easily compare the two, as I kept it parallel.
14:04:16 <flo> isn't this going to be always true?
14:06:00 <aleth> It should always be true, but I prefer to test it in case something about the suffixes changes in the main tab complete code in the future.
14:06:10 <flo> the 1 2 and -2 magic constants aren't really nice either
14:06:40 <aleth> You could have suffix constants and then use .length() on them I suppose.
14:06:57 <aleth> Whether that is more legible, I don't know?
14:08:34 <flo> it seems 1 and 2 are actually oldSuffix.length - newSuffix.length
14:08:41 <aleth> Yes
14:09:45 <aleth> I thought the 2 was obvious from the context, but if you'd prefer constants I can change that
14:10:40 <flo> just to be clear, I'm ok with taking the patch as is, it looks good.
14:10:50 <flo> I'm just wondering if we can make it even better, or less fragile
14:11:15 <flo> (when there are magic constants it's very easy to forget to change one when changing something in the expected behavior later)
14:11:15 <aleth> The point of |if (this._completions[0].slice(-2) == ": ")| was to avoid fragility actually.
14:11:20 <aleth> True.
14:11:58 <flo> I'll try something, you'll tell me if it's better or not :)
14:17:03 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
14:17:06 --> aleth has joined #instantbird
14:17:06 * ChanServ sets mode +h aleth 
14:21:05 <aleth> Hmm. A related question - I wonder if the ": " should in fact be localized?
14:21:15 <flo> aleth: http://pastebin.instantbird.com/44083
14:22:00 <flo> aleth: it should, but until someone complains, I'm ok with pretending I haven't noticed ;)
14:22:20 <aleth> ok :D
14:22:36 <flo> that would add a significant amount of complexity, wouldn't it?
14:23:20 <flo> + it should be in the locale the user is writing, not necessarily the same as the UI's locale
14:23:46 <flo> so using the same locale as the one of the current dictionary would make more sense
14:24:04 <aleth> Are there any examples of alternative suffixes?
14:24:26 <aleth> I would have to go through the existing code carefully, in particular if the suffix length could vary. 
14:24:35 <aleth> Currently we only vary the suffix by protocol.
14:25:42 <clokep> flo: That's a bit more readable. ;)
14:26:33 <aleth> I am not sure it is easier to read, but I'll go with the majority ;)
14:26:46 <clokep> It has comments...
14:27:01 <aleth> So did mine ;P
14:27:13 <flo> aleth: add unit tests before trying to localize the suffix ;)
14:27:31 <aleth> flo: I wasn't proposing to do it right now ;)
14:27:34 <flo> clokep: the comment are aleth's comment, just grouped together because I dropped the else clause
14:28:06 <aleth> I might do it when moving the whole thing to a module.
14:29:10 <flo> clokep: so, is there anything wrong with always sending the PASS command, and eating NickServ messages that we recognize?
14:29:33 <aleth> flo: I'll attach a new patch which is intermediate.
14:30:22 <clokep> flo: I think so, yes.
14:30:45 <flo> clokep, aleth: I think for readability, what would really help is a comment explaining what we are attempting to do
14:31:11 <clokep> You still get a message that you're not authed, we wouldn't be able to eat that one. Sure you could eat the other ones, but how do we know that they're in response to auto-sent messages and not in response to the user manually doing something.
14:31:37 <clokep> flo: I agree! A nice block comment at the top saying all the different situations and the expected results.
14:31:40 <flo> saying something like "if there are multiple nicks, the string will look like "nick1, nick2: " and we want "nick1: nick2 " instead. If there's only one nick, we want "nick1: " -> "nick1"
14:31:57 <flo> aleth: by the way, do we want "nick1" or "nick1 "?
14:32:46 <aleth> Currently for multiple nicks we have a trailing space, but I was just about to remove that.
14:33:11 <flo> aleth: sounds like a good idea
14:33:15 <flo> would be more consistent
14:33:27 <aleth> It's a leftover from when we always added a space.
14:33:30 <flo> then you can drop my "newSuffix" variable
14:33:37 <aleth> Yes :)
14:34:33 <flo> too bad it's the "newPrefix" variable that I dislike the most :-/
14:34:46 <aleth> I'm going to remove it too.
14:35:37 <flo> I'm wondering if the patch you are going to attach looks like what I almost have in my editor
14:35:53 <-- Optimizer has quit (Ping timeout)
14:36:30 <flo> clokep: "You still get a message that you're not authed, we wouldn't be able to eat that one. […]" I have a hard time believing this statement, given that I wrote code in nickservkiller v2 to do exactly that :-P
14:37:01 <clokep> flo: But you did it in a fragile way.
14:37:11 <flo> iirc I eat it and then display it 1s later if we haven't received an "ok, you are auth'ed" message from nickserv
14:38:02 <clokep> Right, that would be fine.
14:38:17 <flo> what's fragile?
14:38:26 <flo> the 1s magic constant? :)
14:38:44 <clokep> I didn't realize you were waiting 1s, I thought you were just destroying it.
14:38:54 <flo> it's possible I'm not
14:38:57 --> Optimizer has joined #instantbird
14:39:15 <flo> now that I think about it more, it's possible I just put the conversation on hold immediately, and destroyed the conversation when receiving the "OK" message
14:39:49 <flo> I don't remember if my current version of the add-on prevents from writing pointless nickserv conversation log files
14:40:07 <clokep> Give me a few minutes to work out the 1s delay.
14:40:57 <flo> clokep: if sending the PASS command, do we have to do it early in the connection?
14:41:15 <flo> or could we do it only if we haven't received any expected nickserv message?
14:41:19 <clokep> flo: It has to be the first thing. :)
14:41:28 <flo> uh :(
14:41:37 <flo> how do SASL auth work?
14:42:03 <flo> can we know before it's time to send the PASS command if the server supposes some SASL mechanisms that we may want to use?
14:42:17 <-- Tomek has quit (Quit: Instantbird 1.1)
14:42:30 <clokep> I don't know exactly.
14:42:40 <clokep> I think it does it with the CAPAB command (which we don't support right now).
14:42:46 <clokep> Which I think is after the PASS stuff.
14:43:07 <flo> is SASL really useful?
14:43:23 <clokep> Certain servers only support SASL.
14:43:45 <clokep> CAP is sent before the login attempt.
14:43:51 <clokep> (Before the PASS command.)
14:44:06 <clokep> I think...
14:44:53 <flo> so we could detect it?
14:46:07 <clokep> Could be useful for some things we've wanted to do. :) https://bugzilla.mozilla.org/show_bug.cgi?id=760802
14:46:12 <clokep> Yes.
14:46:56 <clokep> Ident is done after sending PASS, but before you're actually connected I think.
14:47:04 <clokep> (We want Ident btw, Freenode uses it...)
14:48:20 <flo> apparently freenode sometimes require SASL http://developer.pidgin.im/ticket/13270
14:48:23 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1550 on bug 1479.
14:48:24 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1551 on bug 1479.
14:48:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1479 min, --, ---, nobody, ASSI, [Tab complete] Remove trailing ": " suffix when pressing backspace before undoing completion
14:48:26 <flo> is SASL and ident 2 names for the same thing?
14:48:34 <clokep> No.
14:49:12 <aleth> Argh, a typo. Sorry.
14:49:16 <clokep> SASL is originally RFC 2222, Ident is RFC 1413.
14:49:33 <aleth> How come that didn't throw a warning...
14:49:35 <flo> RFC is clokep's second language :-P
14:49:38 <clokep> Ident requires running a server that listens on a port and does weird things...
14:49:47 * clokep has a Firefox keyword search for RFC. :-[
14:49:57 <aleth> clokep knows all the RFC numbers by heart :P
14:50:08 <clokep> rfc xxxx brings you do http://tools.ietf.org/html/rfcxxxx
14:50:45 <flo> aleth: yeah, he has eaten too many of them, and now he wants to eat NickServ's messages instead of RFCs ;)
14:50:58 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1551 on bug 1479.
14:50:59 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1552 on bug 1479.
14:51:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1479 min, --, ---, nobody, ASSI, [Tab complete] Remove trailing ": " suffix when pressing backspace before undoing completion
14:51:24 --> go8765 has joined #instantbird
14:51:35 <clokep> aleth: I'm looking at my list of IRC docs right now: https://bitbucket.org/clokep/instantbird-patches/src/43c9f7c1d13c/irc-docs#cl-3064
14:52:54 * aleth is not sure whether to be impressed or horrified. Probably both.
14:53:47 <flo> aleth: clokep has assembled a collection of technical docs about IRC like I do for the AMI ;)
14:54:06 <flo> clokep: I didn't know your patch queue was online :)
14:54:31 <clokep> flo: Yeah, I've been pushing it online, figured it's a good way to back it up.
14:54:40 <flo> :)
14:54:56 <flo> or share between several development machines
14:54:59 <clokep> Plus now you get to see everything I'm theoretically working on. ;)
14:55:11 <clokep> Yes, I originally did it so I could do the Bonjour stuff on both my Windows and my Linux machines. :)
14:55:44 <aleth> clokep: Should we somehow recommend to the user she use NickServ, if we think it exists? Or just assume anyone who needs it will know what it is already?
14:56:22 <flo> clokep: is there are any crazy IRC extension to support typing notifications in private conversations?
14:56:31 <clokep> flo: I don't think so. :)
14:56:35 <clokep> (Surprisingly.)
14:56:38 <clokep> Would you like me to write one?
14:57:04 <flo> I think it's the last piece that's missing to make IRC look like a decent IM protocol
14:57:14 <aleth> I find typing notifications annoying. Half the time the guy at the other end changes his mind.
14:57:33 <aleth> OK, maybe not half...
14:57:55 <clokep> Definitely only 42% of the time.
14:58:20 <flo> aleth: what's wrong with changing one's mind?
14:58:22 <clokep> flo: If you see I actually have two patches in my mq that deal with documentation too. ;) Quite the collection.
14:59:02 <aleth> flo: Nothing, but if IB has drawn my attention to it because I think a message is about to appear, and then there isn't one, I find it annoying ;)
15:00:20 <clokep> flo: Is the delay on setTimeout in ms or s?
15:00:32 <aleth> clokep: I can imagine assembling that list was quite a lot of work in itself...
15:00:55 <clokep> aleth: A lot of it was assembled about two years ago...I randomly come across other documents still though. :(
15:01:03 <clokep> Some of them were only available via wayback machine too.
15:02:03 <aleth> At least flo only has to hack one AMI where he knows what's inside ;)
15:02:15 <flo> clokep: ms
15:02:58 <clokep> aleth: The hardest thing to find was a reference for the SED command...I ended up just reading the EPIC source.
15:03:01 <clokep> flo: TY.
15:03:07 <flo> aleth: only one AMI because it would be hard to convince my parents to let me store more than one in their garage ;)
15:03:39 <flo> clokep: and then you decided SED isn't really useful, right? ;)
15:04:21 <-- go8765 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:04:34 <clokep> flo: I have it in another repository. :)
15:04:39 <clokep> IRC extras...
15:04:43 <clokep> I don't think it's online...
15:05:35 --> Mic has joined #instantbird
15:05:36 * ChanServ sets mode +h Mic 
15:06:25 <flo> aleth: latest patch looks great :)
15:06:27 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:06:36 --> Mic has joined #instantbird
15:06:36 * ChanServ sets mode +h Mic 
15:06:51 <Mic> :)
15:07:17 <Mic> Works fine with IRC channels :)
15:07:34 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:07:38 <clokep> Now it's up: https://bitbucket.org/clokep/irc-extras, doesn't have the SED stuff though, that's in an MQ.
15:07:39 --> Mic has joined #instantbird
15:07:39 * ChanServ sets mode +h Mic 
15:08:42 <-- Mic has quit (Input/output error)
15:08:51 --> Mic has joined #instantbird
15:08:51 * ChanServ sets mode +h Mic 
15:10:35 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:11:27 --> testib has joined #instantbird
15:13:30 <flo> aleth: "ale<tab>" -> "aleth: "; "aleth: clok<tab>" -> "aleth, clokep: "; "aleth, clokep: <backspace>" -> ""aleth, clokep" :(
15:13:44 <flo> I would have expected "aleth: clokep"
15:14:04 <clokep> Me too.
15:14:17 <flo> and "aleth, clokep<backspace>" -> "aleth: clok"
15:14:20 <aleth> uh.
15:14:34 <clokep> Time to write tests!
15:15:50 <flo> right.
15:16:01 <flo> I think 1.2 is the last version of Instantbird without tests for each new features ;)
15:16:39 <aleth> Sounds like a good idea.
15:17:02 <aleth> But the most important test would be a "IB can startup and connect to something" test
15:17:51 <aleth> ah, I see what happened, I was testing with the previous version of the patch :(
15:20:28 <flo> aleth: "But the most important test would be a "IB can startup and connect to something" test" we currently test "the core can load, and there's at least one protocol in the list"
15:20:37 <flo> I think it's better than nothing for a start ;)
15:21:36 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1552 on bug 1479.
15:21:38 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1553 on bug 1479.
15:21:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1479 min, --, ---, nobody, ASSI, [Tab complete] Remove trailing ": " suffix when pressing backspace before undoing completion
15:23:29 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
15:24:05 <flo> is it too crazy to try the libpurple update + the moz12 update + the moz13 update + fixing the l10n mess during the same week-end?
15:24:14 --> Mic has joined #instantbird
15:24:14 * ChanServ sets mode +h Mic 
15:24:16 <aleth> flo: I didn't realize that was already implemented :)
15:24:52 <aleth> flo: Not if the weather isn't great ;)
15:24:53 <flo> aleth: what I would really like to test, as it has given us lots of headaches in the past, is "can the new build start on a Windows machine where Visual Studio isn't installed?"
15:24:56 <flo> but it's difficult :(
15:25:27 <-- Mic has quit (Input/output error)
15:25:33 --> Mic has joined #instantbird
15:25:34 * ChanServ sets mode +h Mic 
15:26:15 <aleth> looks like Mic is restoring sessions ;)
15:26:37 <Mic> Actually I updated the extension here to the latest version I have.
15:26:55 <clokep> flo: I don't think it's too crazy, push extra nightlies out and have us test them, if need be, after each update.
15:27:09 <flo> I think the moz13 update isn't a good idea
15:27:23 <flo> would force a release -> beta -> release change in client.py
15:27:34 <clokep> libpurple + moz12 + l10n is reasonable. :)
15:27:34 <flo> should wait until tuesday for that one
15:27:44 <clokep> Ah, is it realized on Tuesday?
15:27:46 <aleth> another 6 weeks up already? :-/
15:27:54 <clokep> Sorry I never have any idea what the "current" Firefox version is. :-S
15:29:10 * clokep is now known as clokep_
15:30:06 <aleth> ^^ is that a convention I am unaware of?
15:30:59 <clokep_> ?
15:31:05 <aleth> (the trailing _ )
15:31:15 <flo> clokep_: I know when we are rushing to push strings before the freeze for Tb ;)
15:31:42 <clokep_> aleth: It's my "I'm not on my home or work computer or phone" convention. ;)
15:31:57 <clokep_> Now also my "I'm testing NickServ with a different instance of Instantbird convention." ;)
15:32:36 <clokep_> (_wp7 is my phone one if you didn't know....)
15:33:52 <aleth> ah, a Windows phone user! Haven't tried one of those myself yet...
15:34:28 <clokep_> They're nice. I love mine.
15:38:46 * clokep_ dislikes this version of the NickServ patch more and more...
15:39:07 <flo> clokep_: which one?
15:39:19 <clokep_> flo: The one that doesn't have an extra option...
15:40:33 <clokep_> I don't see a good way to do some of the things w/o making assumptions...
15:44:05 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
15:45:25 --> Mic has joined #instantbird
15:45:25 * ChanServ sets mode +h Mic 
15:56:31 <-- testib has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:03:01 <-- Mic has quit (Input/output error)
16:03:03 --> testib has joined #instantbird
16:08:42 * clokep_ really wishes there was some way to just be like "Yes, I know we're using a NickServ, it's nick is <blah>"
16:09:21 <flo> ah, the FIREFOX_13_0_RELEASE tag already exists
16:11:02 <aleth> clokep_: How about, when the IRC account wizard is redone, we store along with the SSL port details what default authentification to use?
16:11:18 <aleth> That should fix the problem for the most common servers.
16:11:18 <clokep_> aleth: I suggested that in the bug. ;)
16:11:27 <clokep_> But yes, that was my hope.
16:11:36 <aleth> OK :) I'm behind on the bugmail...
16:11:57 <clokep_> It's OK. I think that would be a good second choice, I'd rather just /know/ what it exists thoguh.
16:12:07 <aleth> yeah :-/
16:12:25 <aleth> After all, it can tell us about MONITOR/WATCH/etc
16:12:50 <-- meh has quit (Ping timeout)
16:12:53 <clokep_> flo, aleth: How awful would it be to just try to handle the nick "NickServ" as if it's always the NickServ (with maybe some basic check that the user or host name includes the string "services")?
16:13:34 <flo> and do you send the password with PASS, or to nickserv?
16:13:34 <aleth> As long as it's hard to spoof...
16:15:07 <flo> http://pastebin.instantbird.com/44090 :(
16:15:14 <flo> and that's just moz12
16:15:25 <clokep_> Ouch. :(
16:15:41 <clokep_> Yeah fixing those up is a pain, you gotta apply them one at a time, fix the rejects and recreate the patch.
16:15:47 <clokep_> (Unless there's a better way to do it?)
16:16:04 <clokep_> aleth: I don't know how hard it is to spoof. :( Usually it's fairly built into the server backbone.
16:16:25 <clokep_> QuakeNet uses a bot "Q" instead of NickServ.
16:16:47 <flo> this one seems easy at least: tools/patches/part-of-bug-711908-remove-trailing-comma-breaking-linux-build.patch already applied
16:17:33 <aleth> But I couldn't log in to QuakeNet as "NickServ" and harvest passwords, because of the "services" check in 312/313?
16:17:38 --> Mic has joined #instantbird
16:17:38 * ChanServ sets mode +h Mic 
16:17:58 <clokep_> What do you mean '"services" check in 312/313'?
16:19:29 <aleth> In the WHOIS response
16:19:44 --> Lalae has joined #instantbird
16:19:45 <clokep_> Ah, theoretically, but that's kind of a weak assumption.
16:20:07 <clokep_> Well...it's not totally unreasonable since it means that you're either an IRC op or a Server.
16:20:11 <clokep_> So sending to you should be OK.
16:20:23 <clokep_> I don't know how closed down networks are to more servers joining. :)
16:22:06 <aleth> Are there instances where there is a NickServ password that differs from the server password?
16:22:27 * flo downloads iceweasel 12's package
16:22:38 <clokep_> aleth: I think there can be. I don't know for sure.
16:22:50 <aleth> wtfbridge.h ??
16:23:21 * Mic wants a way to load missed logs from logs.bezut.info into his history.
16:23:47 <flo> Mic: that will be even more important once they'll be indexed ;)
16:24:10 <Mic> Currently I'm trying session restore with a patch for bug 958. It's nice :)
16:24:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows
16:24:14 <-- Lalae has left #instantbird ()
16:24:29 * aleth hopes 958 will land soon
16:24:44 * flo hopes we will release soon
16:24:55 <aleth> Not necessarily in that order ;)
16:25:05 <flo> ?
16:25:15 <Mic> When is the release scheduled?
16:25:25 <flo> Mic: :-D
16:25:27 <aleth> Is 958 blocking 1.2?
16:25:32 <flo> aleth: no
16:25:39 <aleth> That's what I meant
16:25:41 <flo> aleth: the regressions it will create will, though
16:25:42 <clokep_> Mic: A while ago. :P
16:25:52 <aleth> All the IRC blockers are fixed afaik.
16:25:54 <flo> Mic: 3 months after 1.1 I think
16:25:56 <Mic> No, it's wanted (and I don't feel I want to rush it in)
16:26:15 <flo> 1.1 was in october
16:26:22 <Mic> :(
16:26:47 <clokep_> aleth: So a lot of custom servers are password protectd.
16:26:55 <clokep_> (Like ones for me and my friends, etc.)
16:28:00 <clokep_> But you probably wouldn't also have NickServ running on those?
16:28:01 <clokep_> But who knows.
16:28:08 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
16:28:17 --> Mic has joined #instantbird
16:28:17 * ChanServ sets mode +h Mic 
16:28:19 <clokep_> (That is also a concern btw --> What if you need a password for both NickServ and PASS?)
16:28:22 <aleth> I can't see a use case, was just wondering if there had to be two password fields
16:28:50 <aleth> Which would be ugly.
16:29:12 <clokep_> Theoretically...yes...:(
16:29:41 <flo> add-ons? ;)
16:30:03 <aleth> :) 
16:30:24 <flo> I have a feeling you are optimizing strange edge cases instead of making the common case nice :-/
16:31:00 <flo> maybe "optimizing" is a bit too strong
16:31:08 <flo> more "bothering with"
16:31:58 <aleth> What he is bothering with is "under what circumstances do I trust I can send the password to NickServ" I think
16:32:12 <clokep_> aleth: Yes, that's what I'm concerned with.
16:32:25 <clokep_> And my original solution was "have the user tell me".
16:33:30 <flo> clokep_: what if I assume users don't have a clue?
16:33:37 <aleth> Which causes no problems because the default PASS also sends the password to NickServ? Or does that have any drawbacks? (i.e. if that fails the user can switch manually).
16:33:43 <clokep_> flo: I agree that's an issue. :(
16:34:04 <clokep_> aleth: It doesn't work on every server + NickServ windows pop up.
16:34:13 <flo> I'm still not sure of what the problem is with sending the password with PASS
16:34:28 <flo> but actually, I'm not even sure any more of what you are trying to fix
16:34:33 <aleth> clokep_: the former was "if that fails" and the latter I hope is fixed now?
16:35:03 <flo> are you trying to tell nickserv to shut up (and deprecate the nickserv killer add-on), or to rework completely the auth to prepare support for SASL and whatever other things exist in rare situations?
16:35:12 <clokep_> flo: There isn't really a problem, except that some servers don't support it.
16:35:25 <clokep_> flo: I'm trying to handle NickServ, which includes shutting it up and automatically authenticating.
16:36:06 <flo> but we already automatically auth with PASS ;)
16:36:54 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:37:00 <aleth> clokep_: What if we eat the nickserv messages unless PASS authentification fails?
16:37:27 <aleth> Best of both worlds - then suggest to the user in a system message to switch to Nickserv authentification
16:37:51 <aleth> If that makes any sense.
16:38:13 <flo> aleth: how do you know PASS failed?
16:38:27 <aleth> flo: Nickserv will ask you to identify yourself.
16:38:47 <flo> if a non-official NickServ tells you it wants your password, how do you make the difference with a failing auth?
16:38:58 <clokep_> That's what I'm saying...
16:39:06 <flo> btw, how do we know if the password is wrong?
16:39:10 <aleth> You don't send the password to NickServ unless the user has specifically enabled it
16:39:20 <clokep_> aleth: That's kind of the patch I have going now though.
16:39:29 <clokep_> We receive a response from NickServ if it's wrong.
16:39:38 <aleth> clokep_: Pretty much - just with NickServKiller built into the PASS case.
16:40:36 <clokep_> Yes...I was already doing that. ;)
16:40:45 <clokep_> I say we table this discussion for now, don't check in the patch that's there yet.
16:40:49 <clokep_> I want to think about it more, sleep on it.
16:44:40 --> Bollebib has joined #instantbird
16:44:40 <flo> sounds reasonable
16:45:54 <flo> bah, it's this changeset that breaks me http://hg.mozilla.org/releases/mozilla-release/rev/429503206f26 :(
16:46:31 <clokep_> Hopefully that doesn't break building on whatever it is we're on. :(
16:46:37 <flo> and apparently if I revert it, it won't be possible to build from OSX10.7
16:47:09 --> meh has joined #instantbird
16:48:51 --> mmkmou has joined #instantbird
16:48:56 <flo> that looks better http://pastebin.instantbird.com/44097
16:55:54 <clokep_> Let me know when you need a review.
17:04:03 <flo> for the update?
17:07:11 <clokep_> Yes, if you need to change anything.
17:07:20 <clokep_> If it's not just refreshing patches, I mean.
17:07:46 <clokep_> Oh ha, you already attached those to the bug. :)
17:07:55 <flo> the patches can now apply cleanly
17:08:09 <flo> I've just started a build on my fast linux mahcine
17:08:20 <flo> should know soon (<20 minutes) if it builds OK
17:08:40 <flo> the long wait will be to know if it builds on Mac PPC :-/
17:09:20 <flo> as I'll need to either build an universal build locally (each build takes 90 minutes, so that will require at least 3 hours on my macbook) or push and let the slave do its onCommit
17:17:46 <flo> not sure if that patch can be helpful to anybody, but at least it will be easy to find it again in the future if I need it on a new machine (or for Thunderbird :))
17:18:44 <instantbot> florian@instantbird.org granted review for attachment 1553 on bug 1479.
17:18:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1479 min, --, ---, nobody, ASSI, [Tab complete] Remove trailing ": " suffix when pressing backspace before undoing completion
17:27:00 <instantbot> New Instantbird (UI) bug 1480 filed by clokep@gmail.com.
17:27:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1480 min, --, ---, nobody, NEW, Move the tab complete code into a module
17:33:38 <-- mmkmou has quit (Ping timeout)
17:38:56 <-- Optimizer has quit (Ping timeout)
17:42:25 <flo> so my linux debug build finished successfully :)
17:46:19 <clokep_> Yay!
17:46:38 <aleth> :)
17:50:15 * clokep_ just found an easy capability to provide :)
17:50:58 <flo> is it both easy and useful? :)
17:52:57 <clokep_> It's somewhat useful.
17:53:00 <clokep_> Fixes a bug in the protocol
17:53:28 <clokep_> It lets the server know you want to know every mode applied to someone (so I might be @+clokep to show I'm an op and a half-op).
17:53:36 <clokep_> So even if someone takes away my op status I'm still a half-op.
17:59:04 <flo> are you really half-op? :-S
18:00:32 <clokep_> It's probably not the way we have it set up.
18:01:00 <clokep_> I'm not sure exactly how it works.
18:01:02 <clokep_> I only skimmed it.
18:03:38 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1556 on bug 1424.
18:03:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1424 min, --, ---, aletheia2, ASSI, Warning: GenericConvChatPrototype _init "setting a property that has only a getter"
18:11:24 <instantbot> clokep@gmail.com granted review for attachment 1556 on bug 1424.
18:11:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1424 min, --, ---, aletheia2, ASSI, Warning: GenericConvChatPrototype _init "setting a property that has only a getter"
18:11:46 <aleth> In the interest of reducing the 1.2 queue ;)
18:16:19 <flo> my ppc build failed :(
18:25:03 --> Mic has joined #instantbird
18:25:03 * ChanServ sets mode +h Mic 
18:30:16 --> Mnyromyr has joined #instantbird
18:34:43 <aleth> Mic: Was there a problem I should look at with applying that message style patch, or didn't you get around to it yet?
18:36:55 <Mic> No, it's really just the apply-this-patch problem, not something you need to fix.
18:37:19 <Mic> hmm, do you have it applied somewhere?
18:41:30 <Mic> If yes, then maybe zipping and uploading it somewhere might be the quickest solution? (instead of download/installing git + figuring out how to use their patch tool)
18:41:32 <aleth> No, but I probably could
18:41:42 <aleth> Let me see
18:41:54 * aleth checks what's in his queue
18:49:01 <clokep_> Yeah it might be easier to just zip the whole thing, throw it on top and then let Mercurial tell you the actual diff.
18:58:24 <Mic> bbl
18:58:29 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:08:44 <aleth> argh, I applied the wrong patch :(
19:13:42 <aleth> I wish this had been done before it got bitrotted again :(
19:13:53 --> Mook has joined #instantbird
19:41:04 <aleth> Mic: http://dl.dropbox.com/u/4108552/messages.zip
19:50:33 <flo> Mic: we haven't sent anything to localizers yet, so even if our list of blocker bug was empty, we couldn't release before at least 10 days
19:50:49 <flo> I think that would be enough to catch severe regressions from bug 958 if it landed soon
19:50:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows
19:55:02 --> Optimizer has joined #instantbird
19:58:28 * flo retries the PPC build
19:59:16 <aleth> I wonder how many PPC users IB has...
19:59:46 <aleth> or was one of the buildslaves PPC?
20:00:02 <flo> probably 0? :)
20:00:12 <flo> our mac build slave is an old PowerMac G5
20:00:41 <flo> http://en.wikipedia.org/wiki/Power_Mac_G5
20:03:55 <flo> a machine built somewhere between 2003 June, and 2005 October apparently
20:04:09 <flo> (it's a dual processor or 2.0Ghz each)
20:04:35 <aleth> sounds like a pretty robust machine
20:04:53 <flo> yeah, a pretty robust, heavy and expensive machine
20:05:08 <flo> it still works quite well after 7 years!
20:06:54 --> Tomek has joined #instantbird
20:07:02 <flo> I bought it in 2008 when we setup buildbot, and it still works :)
20:08:58 <flo> "probably 0? :)" when I said that, but we had at least twice people "surprised" by the fact that Instantbird 1.0+ doesn't support Mac OS X 10.4 ...
20:13:11 <aleth> may it keep building :)
20:14:00 <flo> we will probably need to replace it after 1.2
20:14:15 <aleth> due to the mozilla build changes?
20:14:58 <flo> I'm afraid OS X 10.8 will more or less force us to sign builds
20:15:13 <flo> which could be done at best from OS X 10.6, but more likely only from 10.7+
20:15:20 <flo> and 10.5 is the latest version that runs on PPC
20:15:49 <flo> (10.8 is expected to be released in 9 days, June 11th ;))
20:15:53 <clokep_> But on the bright side it means our version of Mozilla will be a lot less patched I believe. :)
20:18:23 <flo> I would like Mozilla to send us a couple of the mac mini that they retire because they are too old/slow to stay in their build farm
20:19:13 <flo> but if that can't happen, I guess I'll just have to buy one...
20:19:45 <flo> (I would like to have more than one, so that we can have at least 2 slaves per OS, and use some for unit tests)
20:20:51 <aleth> That would be nice... mac mini sounds ideal
20:21:04 <aleth> Doesn't even take up space.
20:21:30 <clokep_> Mac Minis are pretty awesome I have to say.
20:21:37 * clokep_ is now known as clokep
20:23:09 <flo> clokep: they are also pretty expensive :-/
20:27:05 <clokep> :(
20:29:46 <flo> 599 Euros in France (~ $743)
20:30:06 <clokep> Yeah that's a lot. :(
20:30:22 <clokep> Speaking of that frame computer though, the new lenovo coming out is pretty sweet. I kind of want it...but have no use for it. :-D
20:30:29 * clokep only buys Lenovos...
20:30:42 <-- Mook has quit (Quit: Mook)
20:39:24 --> gpsychosis has joined #instantbird
20:49:42 <-- gerard-majax has quit (Ping timeout)
20:51:57 --> gerard-majax has joined #instantbird
20:59:14 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:07:00 <flo> PPC build finished successfully! \o/
21:07:23 <clokep> Woooo!
21:07:42 <flo> I'm not sure if I can just push the update, or if I should wait for the other half to finish, and the the merge of the 2 parts of the universal build
21:07:45 <clokep> I'd buy you a drink, but you don't drink. ;) Your loss. :P
21:07:57 <clokep> Hmmm...has that been an issue before?
21:08:24 <flo> at one of the update it failed at the very latest step because one file that was supposed to be identical between the 2 halves wasn't
21:08:45 <flo> and i generally expect anything that can fail to fail if it's not tested;)
21:09:12 <flo> "but you don't drink." I wonder where you got that from (even though it's mostly true)
21:09:20 <aleth> moz12 is ready :)
21:09:35 <flo> I haven't tested make package either
21:09:46 <flo> maybe I should build a non-debug linux build and try to package it
21:10:02 <flo> (even though testing on a 64bit build isn't very relevant :-D)
21:10:12 <clokep> Bah. :-S So many platforms.
21:10:31 <clokep> We should just start building 64-bit Windows too! :P
21:10:40 <clokep> (And you mentioned it at some point. I don't know when.)
21:10:43 <flo> isn't that one completely pointless?
21:11:02 <clokep> Oh, absolutely! :-D Although I did get in a huge argument about that on getsatisfaction at one point...
21:11:05 <flo> probably when discussing with Mook what it would take to make me r+ a completely (and obviously) crappy patch
21:12:21 <clokep> Yes, probably. :)
21:12:43 <flo> bah, my linux mozconfig still has --disable-tests :(
21:12:55 <clokep> Sounds like there's enough little issues that we should wait until the Mac builds finish before pushing thouhg.
21:13:21 <flo> bah, the worst thing that can happen is we don't have a mac nightly tomorrow, right?
21:13:32 <clokep> Yes.
21:13:39 <clokep> Are there other changes being pushed too?
21:13:47 <clokep> (Anything important that we care if we have to wait another day for?)
21:14:43 <flo> bug 1479 and bug 1424 are ready to push
21:14:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1479 min, --, ---, nobody, ASSI, [Tab complete] Remove trailing ": " suffix when pressing backspace before undoing completion
21:14:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1424 min, --, ---, aletheia2, ASSI, Warning: GenericConvChatPrototype _init "setting a property that has only a getter"
21:16:08 <clokep> Will you miss those a lot if you need to wait another day or two for them? :)
21:16:31 <flo> clokep: I don't update my nightlies during the week-end
21:16:39 <flo> I still miss the fix for double clicking a nick in bubble ;)
21:16:52 <clokep> So the answer to my question is "no"? :-D
21:16:57 <flo> I basically update only when I'm going back from offline
21:18:29 <flo> the sad thing about updating mozilla 2 cycles after its development is over, is that we lose all enthusiasm about that version way before we get it
21:19:05 <flo> I was looking forward to updating to moz12 to get the DOM parser for HTML and get rid of one of our stupid hiddenWindow hack
21:19:22 <flo> but now I want 15 to have the compartement per global thing in about:memory :)
21:22:07 <clokep> Hah, yes. :)
21:22:42 <flo> we could have asked wnayes to work on bug 1219 during the bounding period :-S
21:22:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1219 tri, --, ---, nobody, NEW, Cleanup the account.xml binding
21:23:16 <flo> do we have a plan for bug 1113?
21:23:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1113 nor, --, ---, nobody, NEW, Twitter should start from the last read tweet
21:26:12 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 1547 on bug 1359.
21:26:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1359 nor, --, 1.2, clokep, RESO FIXED, Abstract the shared methods between ircChannel and ircConversation
21:26:38 <clokep> flo: No...:(
21:26:53 <flo> it's sad that there are so many XMPP enthusiasts out there, yet nobody "owns" our XMPP code
21:27:11 <flo> (owns in the sense of being interested to hack it to "make other clients obsolete" ;))
21:27:29 <aleth> It's possibly the fault of DNSSRV
21:27:37 <aleth> Wasn't there some rumour b2g wanted it?
21:27:46 <aleth> That might get something moving...
21:27:58 <flo> I wouldn't bet on that
21:28:42 <flo> aleth: but really, that DNSSRV story is non-sense. If we really wanted it we could ship it as a binary XPCOM component until the necko people get their acts together ;)
21:29:01 <flo> there's some easily reusable code around for that
21:29:41 <aleth> I just doubt any XMPP enthusiast is going to be enthusiastic while it's fb-and-gtalk only
21:30:23 <flo> I think you have a good point here :)
21:30:42 <flo> I've never managed to fix the code to send buddy icons
21:30:54 <flo> I wasn't very proud of that :-/
21:32:52 <aleth> Maybe in 1.3 ;)
21:34:22 <flo> aleth: isn't it actually 1.2-blocking?
21:34:28 <flo> it's a regression compared to 1.1, isn't it?
21:36:00 <aleth> I don't know, I don't use gtalk/fb
21:36:01 <flo> I'll hopefully have more time to finish these details once Tb15 is string frozen
21:36:13 <flo> it doesn't matter for fb, as everything is read only
21:36:33 <aleth> Right.
21:36:56 <aleth> I think IB 1.2 could probably string freeze soon too
21:37:24 <aleth> (looking at the list of wanted bugs)
21:37:28 <-- clokep has quit (Input/output error)
21:37:40 <flo> we can think about it
21:37:45 <flo> I definitely need to update libpurple before
21:37:50 <aleth> Sure.
21:38:29 <aleth> and the whole l10n mess...
21:38:43 <aleth> I don't really know how much work that entails.
21:38:50 <flo> I'm still really annoyed by bug 1355 and bug 1422
21:38:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1355 maj, --, ---, nobody, NEW, unable to establish any network connection until a restart of the application
21:38:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1422 maj, --, ---, nobody, NEW, Connection timeouts don't seem to work
21:38:55 <flo> almost sure they are regressions
21:39:03 <aleth> But they shouldn't need strings...
21:39:08 <flo> but no steps to reproduce, no way to really understand what's going on :(
21:39:12 <flo> yeah :)
21:39:14 <aleth> Yes :(
21:39:44 <flo> fixing the l10n mess would probably be 3-4 hours of focused (and motivated! :() work
21:40:28 <flo> so if the rain announced by the weather forecast today is real enough that I've got to cancel my plans with the AMI tomorrow, it could maybe get done tomorrow afternoon
21:42:14 <aleth> it does sound like it requires some bad weather ;)
21:44:54 <flo> http://pastebin.instantbird.com/44131 this is the output from the part of |make distribution| that uses the package manifest
21:45:05 <flo> I'm wondering if I should be concerned by any of these warnings
21:46:07 <aleth> jetpack maybe not, but necko_wifi?
21:46:32 <aleth> Well, I have no idea :P
21:47:35 <flo> necko_wifi is disabled by our mozconfig
21:47:37 <flo> it's not a new one
21:47:53 <flo> but what happened to mozglue? Has it been renamed?
21:48:24 <flo> proxyObject, well, we know XPCOM proxies are gone with moz12
21:48:47 <aleth> #ifdef MOZ_SHARED_MOZGLUE ?
21:48:51 <flo> I think the .chk files are now generated later in the process
21:49:04 <aleth> (that's in the FF package manifest)
21:50:19 <aleth> added this year https://hg.mozilla.org/mozilla-central/rev/30b1cb696452
21:50:32 --> Optimizer1 has joined #instantbird
21:50:37 <aleth> No idea which FF version that would be though
21:51:07 <-- Optimizer1 has quit (Input/output error)
21:51:12 <-- Optimizer has quit (Ping timeout)
21:51:35 <flo> let's see http://pastebin.instantbird.com/44132
21:51:40 --> Optimizer has joined #instantbird
21:53:52 <flo> I'm glad I looked!
21:54:07 <flo> several changes have a nice potential for bustage
21:55:52 <aleth> nicely avoided :)
22:09:57 <flo> here are the changes I just made: http://pastebin.mozilla.org/1654356
22:13:00 <aleth> what's nspr4?
22:13:35 <aleth> some Windows DLL?
22:13:56 <flo> and I've jsut added an ifdef for necko_wifi to no longer see that warning
22:14:16 <flo> I think for moz15 packaging errors become fatal (which is a good idea indeed!), so let's fix the obvious ones :)
22:14:30 <aleth> :)
22:14:30 <flo> aleth: nspr is netscape's equivalent of glib
22:14:43 <aleth> ah ok. 
22:14:48 <flo> aleth: a low level C library providing some platform abstraction
22:14:48 <aleth> Thanks.
22:15:04 <flo> which 10+ years later is mostly crappy code that everybody dislikes
22:15:11 <flo> but almost everything depends on it
22:15:16 <aleth> heh... and everything depends on?
22:16:31 <flo> ah, my i386 mac build failed
22:17:32 <flo> http://pastebin.instantbird.com/44137
22:18:32 <aleth> :(
22:27:57 <flo> so apparently it's a crazy hack so that it's possible to build on 10.7 with the 10.6 SDK in a way that can run on 10.5
22:28:02 <-- gpsychosis has quit (Quit: Instantbird 1.1)
22:36:25 <-- Tomek has quit (Quit: Instantbird 1.1)
22:53:13 <flo> rebuild from scratch, including ppc :(
22:56:16 <-- Bollebib has quit (Quit: Instantbird 1.1)
23:07:03 <flo> hmm, I'm in the "can't tweet" situation again :-S
23:08:13 <flo> can't send AIM message either
23:08:26 <flo> I would like to be able to tell for sure that both are the same bug, but I'm really not sure :/
23:13:16 <flo> it will take several hours before my new universal build will be ready. I've checked that things look ok in my linux64 packaged build. I'll push the changes now and we will see tomorrow if I broke everything or not
23:22:04 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0c3f8e1700b1 - aleth - Bug 1424 - Warning: GenericConvChatPrototype _init "setting a property that has only a getter", r=clokep.
23:22:05 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8b8724360bf6 - aleth - Bug 1479 - [Tab complete] Remove trailing ": " suffix when pressing backspace before undoing completion, r=fqueze.
23:22:06 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/86599b6abbeb - Florian Quèze - Bug 1390 - Update to Mozilla 12.
23:23:43 <flo> Good night
23:31:31 <-- Optimizer has quit (Ping timeout)
23:31:32 --> Optimizer1 has joined #instantbird