#instantbird log on 05 31 2012

All times are UTC.

00:16:27 <-- myk has quit (Ping timeout)
00:21:49 --> EionRobb has joined #instantbird
00:41:10 <-- Mook_as has quit (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 10.0.2/20120215223356])
01:43:22 <instantbot> New Core - IRC bug 1472 filed by clokep@gmail.com.
01:43:23 <instantbot> clokep@gmail.com requested feedback from the wind for attachment 1536 on bug 1472.
01:43:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1472 enh, --, ---, nobody, NEW, Handle a ChanServ notice
02:30:20 <douglaswth> 
02:30:45 <douglaswth> oops
02:55:21 <instant-buildbot> build #511 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/511
03:01:45 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
04:46:58 <-- Suiseiseki has quit (Quit: Quit)
04:47:44 <instant-buildbot> build #604 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/604
04:55:48 --> pvagner has joined #instantbird
05:28:40 --> TestFliege has joined #instantbird
05:28:53 <-- TestFliege has quit (Input/output error)
05:29:23 --> FireFly_TB has joined #instantbird
05:46:32 --> FeuerFliege has joined #instantbird
05:47:00 <-- EionRobb has quit (Quit: Leaving.)
06:03:08 <instant-buildbot> build #499 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/499
06:30:09 --> Suiseiseki has joined #instantbird
06:33:31 <-- Suiseiseki has quit (Quit: Quit)
06:57:20 --> gerard-majax has joined #instantbird
07:49:30 --> Tomek has joined #instantbird
07:49:49 <-- Tomek has quit (Quit: Instantbird 1.1)
07:50:00 --> meh has joined #instantbird
07:54:46 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
07:57:57 --> FeuerFliege has joined #instantbird
08:16:54 --> Curlified has joined #instantbird
08:17:26 <Curlified> Hi, just wondering if there are any plans for whois support?
08:17:40 --> Suiseiseki has joined #instantbird
08:24:08 --> Tomek has joined #instantbird
08:28:52 <-- Suiseiseki has quit (Ping timeout)
08:31:51 --> Suiseiseki has joined #instantbird
08:38:44 <-- Suiseiseki has quit (Quit: Quit)
08:42:41 --> aleth has joined #instantbird
08:42:42 * ChanServ sets mode +h aleth 
08:47:10 --> Suiseiseki has joined #instantbird
08:59:48 --> flo has joined #instantbird
08:59:48 * ChanServ sets mode +qo flo flo 
09:12:42 --> Mic|web has joined #instantbird
09:15:27 --> mmkmou has joined #instantbird
09:21:14 <FireFly_TB> Curlified: hi
09:22:05 <Curlified> FireFly_TB: Morning
09:22:15 <FireFly_TB> the command /whois is already supported by the nightlies.
09:23:00 <Curlified> FireFly_TB: Hmm any reason it's saying it isn't in earlybird then?
09:24:29 <FeuerFliege> Curlified: earlybird is the aurora channel which is about 6 weeks behind the nightly channel (called Daily for Thunderbird)
09:25:58 <FeuerFliege> and I don’t know how fast changes from instantbird make it to Daily (but I think that’s pretty fast)
09:26:00 --> Optimizer has joined #instantbird
09:26:10 <FeuerFliege> hi Optimizer
09:26:20 <Optimizer> hi 
09:26:54 <Curlified> FeuerFliege: Ahh I always thought earlybird was a nightly build >.>
09:27:07 <Curlified> FeuerFliege: Don't suppose you know where I can download the daily?
09:28:30 <Optimizer> Hi FeuerFliege, were you waiting for me for some reason ?
09:28:52 <FeuerFliege> Curlified: https://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/
09:29:46 <FeuerFliege> latest-comm-central or latest-comm-central-l10n if you want a localized one
09:30:30 <Curlified> FeuerFliege: Okie dokie, thanks :)
09:30:31 <FeuerFliege> but you should know that it may be less stable
09:30:49 <FeuerFliege> Optimizer: no, just saw you enter :)
09:31:08 <Optimizer> ) okay
09:33:27 <-- Curlified has quit (Client exited)
09:35:02 <FeuerFliege> :) ← smiley test
09:39:56 <flo> FeuerFliege: are smileys broken in Tb's current nightly?
09:40:10 <FeuerFliege> no
09:40:21 <FireFly_TB> :)
09:40:42 <flo> I expect they are since the relicensing, but it's possible a new nightly hasn't been produced yet
09:40:54 <Optimizer> recently I installed firefox nightly from nightly.mozilla.org as the update procedure was breaking for me everyday
09:41:05 <Optimizer> since then when I click on any link, nothing happens
09:41:12 <Optimizer> in IB Nightly
09:42:43 --> FireFly_Daily has joined #instantbird
09:43:18 <-- FireFly_Daily has quit (Quit: FireFly_Daily)
09:43:30 --> FireFly_Daily has joined #instantbird
09:45:07 <FeuerFliege> Optimizer: redefine Fx as standard programm
09:45:37 <Optimizer> standard ?
09:45:54 <-- FireFly_Daily has quit (Quit: FireFly_Daily)
09:45:57 <Optimizer> how and where ?
09:46:24 --> FireFly_Daily has joined #instantbird
09:46:34 <FireFly_Daily> :)
09:47:23 <Mic|web> Optimizer: Options -> Advanced -> General -> Check if Nightly is default browser.
09:47:34 <FeuerFliege> flo: I updated Daily and it is still working (Application Build ID 20120530030520)
09:47:54 <-- FireFly_Daily has quit (Quit: FireFly_Daily)
09:47:58 <Optimizer> oh , thanks
09:48:00 <flo> so the 20120531 Nightly isn't ready yet :)
09:48:11 <Optimizer> but still if Nightly was not the default, some other must've been
09:48:12 <Optimizer> like IE
09:48:26 <Optimizer> why does the link not open in IE then ?
09:49:52 <aleth> Optimizer: For example, the OS URL handler may be pointing to an incorrect path, if you installed nightly somewhere else than your previous Firefox
09:50:11 <Optimizer> oh
09:50:11 <Optimizer> hmm
09:50:17 <Optimizer> I think it might have been
09:51:01 <Optimizer> The new Fx I installed got installed inside the installation directory of the current nightly under an updated folder
09:51:22 <Optimizer> so the default browser url must have been under that updated folder
09:51:31 <FeuerFliege> Optimizer:  If the option Mic mentioned is already set, remove the check, make another browser standard, restart Fx and set the option again.
09:51:39 <Optimizer> But I then manually moved from updated to the parent directory
09:52:11 <Optimizer> no its fine, just by making Fx default
09:57:03 <flo> the diffstat for gerv's patch is  430 files changed, 1421 insertions(+), 10882 deletions(-)
09:58:25 <Optimizer> which bug ?
09:58:36 <flo> https://bugzilla.mozilla.org/show_bug.cgi?id=759808
09:58:42 <Optimizer> or did you changed to MPL2 ?
09:58:55 <Optimizer> change*
09:58:59 <Optimizer> yup
09:59:04 <Optimizer> I guessed right
09:59:40 <Optimizer> this is firefox's bug
09:59:49 <Optimizer> when will you guys change ?
10:00:00 <flo> have you read the summary of the bug?
10:00:06 <Optimizer> my bad
10:00:07 <Optimizer> D
10:00:19 <Optimizer> why is it under mozilla then ?
10:00:37 <flo> Optimizer: if you just sent ":D" then we received "D", and you should update your instantbird nightly ;)
10:00:38 <Optimizer> bugzilla.mozilla.org
10:00:58 <Optimizer> why did that happen ?
10:01:22 <flo> the whole relicensing effort is tracked on BMO so it was probably easier for gerv to file in BMO
10:01:40 <Optimizer> why did the smiley change happen ?
10:01:57 <flo> because you should update your nightly
10:02:20 <Optimizer> no I mean why did the smiley change happen in a newer nightly ?
10:02:49 <flo> because in new nightlies we tend to fix bugs ;)
10:03:10 <Optimizer> if it was still working in old nightly, what kin dof bug it was ?
10:03:37 <Optimizer> link ?
10:03:57 <flo> it doesn't work in your nightly, you sent "D"
10:04:26 <Optimizer> but heer it shows the smiley correctly
10:04:33 <Optimizer> here*
10:04:38 <flo> ...
10:04:45 <Optimizer> smile://:D
10:04:52 <Optimizer> this is what I get if I copy apste
10:04:57 <flo> http://log.bezut.info/instantbird/today#m105
10:05:19 <flo> what's difficult about updating?
10:05:38 <Optimizer> no difficulty, can;t you point me to the bug link so that I can know of it ?
10:05:42 <Optimizer> I am updating as we speak
10:06:03 <aleth> Optimizer: http://hg.instantbird.org/instantbird/shortlog
10:06:22 <flo> https://hg.instantbird.org/instantbird/rev/ee30357e62a1
10:08:02 <Optimizer> so it was always broken ? while the IB still displayed the smiley correctly ?
10:08:21 <aleth> No, it was a regression.
10:08:25 <Optimizer> oh
10:08:40 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:08:57 --> Optimizer has joined #instantbird
10:10:02 --> Even1 has joined #instantbird
10:10:12 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:10:20 --> Even1 has joined #instantbird
10:19:11 --> clokep has joined #instantbird
10:19:11 * ChanServ sets mode +o clokep 
10:20:25 <flo> clokep: good morning :)
10:21:06 <clokep> flo: Hello.
10:21:26 <flo> if there's no objection, I'm going to check-in gerv's patch soon
10:25:07 <clokep> flo: I don't have any objection, I haven't fully caught up on the thread yet though. :)
10:25:33 <Optimizer> :D
10:25:59 <clokep> Hmm...OK. flo looks OK.
10:26:23 <flo> I look OK? :)
10:26:35 <Optimizer> does my :D looks ok ?
10:26:42 <flo> Optimizer: yes
10:27:02 <flo> Optimizer: http://log.bezut.info/instantbird/today#m143 you can check it yourself ;)
10:28:42 <clokep> It only differs if it's the first and only word though. ;)
10:31:59 <clokep> flo: That should definitely check if it's a NOTICE message, yes. :)
10:32:15 <flo> :)
10:32:53 <flo> clokep: some other random concerns I had but forgot to write in the bug: is it ok to write a message from "ChanServ" in the conversation when ChanServ isn't in the list of participants?
10:33:07 <flo> if not, should we make it a system message instead? (similar to the topic)
10:33:12 <clokep> flo: Why would it not be?
10:33:29 <clokep> (You know on IRC you can technically receive messages from people who aren't in the room too!)
10:33:39 <clokep> If the channel mode allows it.
10:33:44 <flo> some code used to greatly dislike messages from non-participants, but I think we fixed it
10:34:02 <flo> well, ok then :)
10:34:23 <clokep> Personally, I would prefer to keep it from ChanServ.
10:34:32 <flo> ok
10:34:42 <flo> whatever we do, it's better than in a separate tab :)
10:35:09 <clokep> Unfortunately I couldn't find real documentation about what kind of messages get sent out. :(
10:35:16 <flo> have we verified that it's formatted in exactly the same way on different servers? I tested only on moznet
10:35:38 <clokep> No.
10:35:47 <flo> I think we will want to test at least freenode before checking this in :)
10:35:58 <clokep> I'm fairly certain that moznet uses anope for services. But I couldn't find a way to verify this.
10:37:13 <flo> clokep: is line 9 a good enough confirmation? http://pastebin.instantbird.com/43740
10:38:24 <clokep> flo: Yes, that's a good confirmation. :)
10:38:43 <clokep> What commant created that?
10:38:52 <clokep> Ah, help register.
10:43:25 <clokep> Right, so I was split between making a "servicesBase" object and a "servicesAnope" object or something like that (and expecting to have to make a new services object for each different one).
10:44:42 * Mic|web just used scratchpad for the first time and it seems to do its job well enough :)
10:45:37 <flo> clokep: I don't have a strong opinion on the way you organize these files. It just seems that the current patch is overkill if nickserv isn't handled too :)
10:45:40 <Mic|web> And now I'm curious how well IB will cope with a log with 30k messages ;)
10:45:51 <-- Tomek has quit (Ping timeout)
10:46:00 <flo> but if you want to silence chanserv first with some preparation for nickserv, and then nickserv in another patch, that's fine with me :)
10:46:17 <flo> Mic|web: you mean, how long you will wait before it's fully displayed?
10:46:46 <Mic|web> Sort of ;)
10:48:03 <clokep> flo: Yes, it's a bit of over abstraction to handle one case. :-D
10:48:10 <clokep> But that was my plan, yes.
10:48:44 --> Tomek has joined #instantbird
10:50:41 <clokep> flo: I also wonder whether those messages can be localized. :-S
10:51:06 <Mic|web> I'm surprised how well it works when all messages are displayed.
10:51:08 <flo> you mean the [ ] ?
10:51:18 <flo> Mic|web: already finished? :)
10:51:38 <Mic|web> Yes, scrolling sometimes isn't smooth (but is most of the time) and searching worked fine too
10:51:40 <clokep> flo: Just in general all the messages they have. :)
10:51:55 <-- Optimizer has quit (Ping timeout)
10:51:56 <Mic|web> Even "highlight[ing] all" search results
10:57:31 <clokep> Most of it is localized it seems: http://anope.git.sourceforge.net/git/gitweb.cgi?p=anope/anope;a=tree;f=lang;h=50474e96eb847551b01972c36b40719814747dd2;hb=HEAD
10:58:15 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:12:28 --> Optimizer has joined #instantbird
11:18:36 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/57e8d1da63f8 - Gervase Markham - Bug 759808 - MPL 2 upgrade: Instantbird, r=fqueze.
11:18:37 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/3f9722c19f85 - Florian Quèze - Send a MessagesDisplayed event from convbrowser.xml each time messages are displayed (port chat/ changes from bug 754914 and bug 759699), r=clokep.
11:18:38 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b707ece76191 - Florian Quèze - Update the tools/createheader.sh script for MPL2.
11:51:26 --> clokep_work has joined #instantbird
11:51:26 * ChanServ sets mode +o clokep_work 
11:56:06 --> Mnyromyr has joined #instantbird
11:58:16 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
12:00:05 <clokep_work> Lots of bugmail....
12:10:43 <-- mmkmou has quit (Ping timeout)
12:11:57 <flo> and a lot of red on the Thunderbird tree :(
12:12:29 <clokep_work> From the MPL upgrade?
12:12:41 <flo> I don't know, I haven't seen the logs yet
12:12:55 <flo> but after my push
12:21:25 <clokep_work> Ah.
12:21:33 <clokep_work> Hopefully it's not your fault. :-D
12:22:05 --> mmkmou has joined #instantbird
12:31:11 --> DGMurdockIII has joined #instantbird
12:40:42 * clokep_work likes that w/ that commit gerv is our third biggest contributor. ;)
12:41:11 <flo> how do you count that?
12:41:17 <clokep_work> Using hg churn.
12:41:48 <clokep_work> http://pastebin.instantbird.com/43754
12:41:55 <clokep_work> Note that I aliased florian to florian @ ....
12:42:06 <clokep_work> Which probably isn't fully right as in SVN I'm sure all commits were "by" you.
12:42:17 <clokep_work> Whether you did them or not. :)
12:42:28 <flo> I probably did most of them
12:43:03 <clokep_work> Yeah, so I figured it was reasonable.
12:43:08 <flo> if I didn't, there's probably "p=<author>" or "Patch by <author>" in the commit message
12:43:41 <flo> I'm surprised mook has more than aleth
12:43:45 <clokep_work> If you want to see commits: http://pastebin.instantbird.com/43757 (although that's on ohloh too, with a nicer interface...)
12:44:05 <clokep_work> He had that bug of moving lots of code around and splitting up files.
12:44:21 <flo> clokep_work: leeraccount@yahoo.de is Mic's old address
12:44:38 <flo> ah, right, the purpleInit* cleanup :)
12:45:38 <clokep_work> Which is still open. ;)
12:45:50 --> Lalae has joined #instantbird
12:46:04 <-- Lalae has left #instantbird ()
12:46:23 <clokep_work> With Mic aliased: http://pastebin.instantbird.com/43758
12:47:02 <flo> mitchell.field and mitch_1_2 are also the same person
12:47:16 <flo> but that won't change the results much :)
12:47:40 <clokep_work> You didn't do a really intense conversion and find all the "Patch by" or "p=" and fix the authors before moving to Mercurial? ;)
12:48:22 <flo> I spent more energy saying "stfu" to people saying "why not git?" while we were doing the hg conversation ;)
12:48:31 <flo> mostly kidding, of course :)
12:49:04 <clokep_work> (But not really.)
12:50:06 <flo> I actually didn't work on that conversion (I have a hard time typing that word, my fingers complete to conversation automatically when I start typing convers... :-D), even handled it :)
12:50:13 <flo> and the svn repository was mess
12:54:56 <clokep_work> Ah, I know how that is. :)
12:55:14 * clokep_work wishes he could convince people to use Mercurial instead of git at work...
12:58:20 <clokep_work> flo: So you were asking what's "blocking" me. The bug that's really annoying me is bug 1359, as the patch keeps bitrotting in my MQ. (aleth keeps changing things in there. :P) It's been OK the past week or so, but I'd really like to get that in soon.
12:58:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1359 nor, --, ---, clokep, ASSI, Abstract the shared methods between ircChannel and ircConversation
12:58:32 <clokep_work> I think the way I have in the patch there now is very reasonable and clean.
12:58:38 <clokep_work> But the patch definitely needs to be updated.
12:58:53 <flo> but you already have an up to date patch in mq?
13:00:15 <clokep_work> No, I just pushed it to the end of my queue.
13:00:50 <clokep_work> It's a PITA to update though, so I wanted to see if the style worked before I put the effort in to fixing it.
13:11:53 <flo> clokep_work: the style works. The copyPropertiesToPrototype(aThis, aPrototype) function is confusing
13:13:07 <flo> the name says it copies "to the prototype", but the "aPrototype" parameter is actually the source
13:14:09 <clokep_work> flo: I guess it should be called "copyPrototype"?
13:14:12 <flo> what about |function copySharedBaseToPrototype(aBase, aPrototype)
13:14:15 <flo> ]
13:14:25 <flo> s/]/|/
13:14:41 <clokep_work> Which is the source, which is the sink in this case? :)
13:15:06 <-- Optimizer has quit (Ping timeout)
13:15:24 <flo> the call would be copySharedBaseToPrototype(GenericIRCConversation, ircConversation.prototype);
13:16:11 <clokep_work> Alright, any reason to not just put the .prototype in the loop?
13:16:31 <flo> why do you want to duplicate it for each iteration? :)
13:16:55 <clokep_work> Ah, I was looking at it as /not/ duplicating it when calling the method twice.
13:17:07 <flo> yeah, I guessed that :)
13:17:28 <flo> somehow it seemed clearer for me to pass a prototype for the aPrototype parameter
13:17:33 <flo> but either way works :)
13:17:45 <clokep_work> Yeah, it makes the name more meaning full at least. Hah.
13:18:41 --> Optimizer has joined #instantbird
13:19:07 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1456 on bug 1359.
13:19:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1359 nor, --, ---, clokep, ASSI, Abstract the shared methods between ircChannel and ircConversation
13:19:13 <clokep_work> flo: Thanks for looking at that though. :)
13:19:35 <flo> np, sorry for not prioritizing it more :-|
13:19:53 <clokep_work> It's OK. :) It seemed like a silly bug, but I was tired of rewriting the same code. ;)
13:21:00 <instantbot> florian@instantbird.org granted feedback for attachment 1456 on bug 1359.
13:31:42 <-- Optimizer has quit (Ping timeout)
13:35:08 <FeuerFliege> clokep_work: about bug 1108: Do you prefer to encodeURI everything instead of just replacing the reserved characters?
13:35:10 --> Optimizer has joined #instantbird
13:35:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
13:35:32 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
13:36:04 <FeuerFliege> I reworked the function: http://pastebin.instantbird.com/43719
13:38:03 <aleth> FeuerFliege: I'm not sure exactly, but you may have to also do something like this, to use regexp on arbitrary filenames http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#523
13:39:36 <-- Optimizer has quit (Ping timeout)
13:39:51 <clokep_work> FeuerFliege: I think it might make more sense / be more cross platform.
13:40:15 <clokep_work> What do you think aleth?
13:41:13 <FeuerFliege> aleth: that are far more escaped characters than required
13:41:32 <aleth> FeuerFliege: Those are all possible /regex/ special characters
13:42:57 <aleth> clokep_work: On the face of it, it sounds simpler and more standardized, yes. But I don't know if there are any gaps.
13:43:23 <flo> clokep_work: I need the patch from bug 1446 in comm-aurora too, right?
13:43:26 <aleth> FeuerFliege: Ah, sorry for the confusion. You are right, you don't need to worry about that.
13:43:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1446 nor, --, 1.2, aletheia2, RESO FIXED, Reset nick when reconnecting and ensure conversations are notified of nick changes
13:43:37 <clokep_work> aleth: Yeah, I'm kind of on both...
13:43:45 --> Optimizer has joined #instantbird
13:44:53 <aleth> clokep_work: Should it be this one? http://www.w3schools.com/jsref/jsref_encodeuricomponent.asp
13:45:29 <aleth> (e.g. can there be ? or : in channel names?)
13:45:35 --> mmkmou has joined #instantbird
13:47:01 <clokep_work> flo: I think so.
13:47:19 <clokep_work> aleth: Why would it matter if those are in channel names? They would still get encoded?
13:47:23 <FeuerFliege> aleth: yes, if we use encodeURI we have too use the encodeURIComponent
13:47:39 <aleth> clokep_work: only if you use encodeURIComponent
13:48:26 <clokep_work> aleth: OK, I'm not sure what you're saying then...
13:50:00 <clokep_work> FeuerFliege: Do you think it makes sense to just worry about the specific subset of characters or to use the encode function?
13:51:05 <FeuerFliege>  encodeURIComponent seems like an overkill
13:52:41 <aleth> But you wouldn't have to worry about things like unicode etc (if that's an issue)
13:53:20 <FeuerFliege> aleth: unicode is allowed in filenames
13:53:33 <aleth> On every OS? OK.
13:54:30 <FeuerFliege> aleth: at least for windows and linux/unix
13:55:16 <clokep_work> FeuerFliege: The changes you're making are manually encoding it though, right? So if we were to find an issue, we could actually switch to using the real functions and it should be backward comptaible?
13:56:56 <FeuerFliege> clokep_work: It should be. But I don’t know what decodeURI does if unicode characters are in the string
13:58:11 <FeuerFliege> I just saw encodeURIComponent isn’t sufficient, too. * is not encoded :(
13:58:18 <FeuerFliege> https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/encodeURIComponent
13:59:09 <clokep_work> OK, then we'll go with what you have.
14:00:48 <clokep_work> Please put up a new patch in the bug and I'll review it. Also I think I'd prefer something different then "cleanName" as the function name, maybe encodeName (and then we would need a decodeName function too).
14:03:49 --> jb has joined #instantbird
14:04:58 <clokep_work> flo: That's a lot of stuff landing on aurora. :(
14:05:35 <flo> clokep_work: and not very relevant 4 days before the merge to beta :(
14:05:51 <flo> as IM-in-Tb will be pref'ed off in Tb14beta
14:06:21 <flo> but we spent enough time preparing that set of aurora-compatible changesets that I preferred landing it anyway :)
14:06:28 <flo> I just hope that won't completely break the aurora tree
14:11:19 <clokep_work> Ye,s that would be bad. :)
14:15:11 <flo> any idea of what to do for https://bugzilla.mozilla.org/show_bug.cgi?id=759994 ?
14:15:20 <flo> (the bug is filed for Tb, but that also applies to Ib)
14:15:45 <aleth> Add the date to the tooltip?
14:16:06 <flo> can we easily add it only when it's older than today?
14:17:14 <flo> hmm, there's currently no timestamp tooltip at all in Tb
14:17:36 <aleth> Doesn't the Date object provide suitable methods?
14:18:44 <clokep_work> I think it'd be nice if the date wasn't from today fif it just added the date. :0
14:19:15 <flo> "it" = ? where ?
14:21:13 <clokep_work> Where the time is shown in Bubbles. ;)
14:21:16 <clokep_work> Which doesn't help Tb.
14:21:18 <clokep_work> But also in the tooltip.
14:23:04 <flo> do we have a bug on file for the annoyance of selecting the hours too when double clicking on a nick in bubble to copy it?
14:23:41 <clokep_work> I don't think so.
14:24:04 * flo is lazy and will just pastebin the patch instead of attaching it then :-P
14:24:14 <aleth> There is a bug for that
14:24:16 <aleth> somewhere...
14:24:38 <flo> I just know we already discussed it several times, and spent more time discussing it than fixing it would have required
14:25:00 <flo> I think this is all we need to fix it: http://pastebin.instantbird.com/43767
14:26:46 <aleth> More efficient, too
14:27:30 --> jb1 has joined #instantbird
14:28:08 <clokep_work> flo: Looks fine to me. :)
14:29:17 <flo> ok, which nick should I put in the r= comment? :)
14:30:17 <clokep_work> I'm OK taking responsibility. :P
14:46:10 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
14:54:32 <-- Optimizer has quit (Ping timeout)
14:57:58 --> Optimizer has joined #instantbird
14:59:04 <-- Even1 has quit (Ping timeout)
14:59:42 --> Even1 has joined #instantbird
15:00:28 <-- clokep_work has quit (Ping timeout)
15:03:50 --> clokep_work has joined #instantbird
15:03:50 * ChanServ sets mode +o clokep_work 
15:06:43 <-- Optimizer has quit (Ping timeout)
15:10:22 --> Optimizer has joined #instantbird
15:12:22 <-- chrisccoulson has quit (Ping timeout)
15:12:40 --> chrisccoulson has joined #instantbird
15:16:33 <-- Optimizer has quit (Ping timeout)
15:18:02 --> Optimizer has joined #instantbird
15:35:48 <-- Even has quit (Input/output error)
15:48:59 <-- gerard-majax has quit (Ping timeout)
15:55:35 <-- Optimizer has quit (Ping timeout)
15:59:43 --> Optimizer has joined #instantbird
16:02:03 --> wnayes has joined #instantbird
16:29:59 --> gerard-majax has joined #instantbird
16:31:46 --> myk has joined #instantbird
16:39:40 <-- jb has quit (Quit: jb)
16:40:35 <-- gerard-majax has quit (Ping timeout)
16:43:02 <-- jb1 has quit (Quit: Instantbird 1.1)
17:14:00 --> Mook_astb has joined #instantbird
17:17:42 <wnayes> flo: I wrote down a couple of questions related to moving forward on the UI/Interface interaction: https://etherpad.mozilla.org/3Vi2EoM9aP
17:18:00 <flo> clokep_work: yeah, that twitter behavior is always surprising to me when I configure a twitter account on a new profile
17:18:33 <clokep_work> flo: Yes, I'm sure it was for me when we were developing Twitter.
17:18:38 <clokep_work> Now...I don't worry about it. :P
17:18:56 <clokep_work> I hope my response got across the "Yeah, we should fix this. I'll review it. It's not high priority."
17:19:29 <flo> I almost wontfixed it :-P
17:19:33 <-- Mook_astb has quit (Quit: Mook_astb)
17:19:37 --> Mook_astb has joined #instantbird
17:19:55 <flo> but yeah, dropping some old mentions sounds like what we should do
17:20:43 <flo> but there are corner cases: what about an account that follows only one low traffic person?
17:20:52 <flo> but receives lots of mentions?
17:21:01 <clokep_work> It would only want to be done on the first connect.
17:30:29 <clokep_work> wnayes: I kind of replied.
17:31:57 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:32:49 <flo> wnayes: I've got to go (I'll be back online in ~2 hours; but I think you may have all your questions answered by clokep or others before I get back ;))
17:32:50 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:35:58 <wnayes> clokep_work: Thanks, I may have explained the first one better now :)
17:38:02 <clokep_work> OK.
17:40:49 <-- aleth has quit (Input/output error)
17:41:00 <wnayes> Compiling with that change now :) Takes a lot longer on Windows than on Linux (even with pymake)
17:41:54 --> aleth has joined #instantbird
17:41:54 * ChanServ sets mode +h aleth 
17:41:55 <clokep_work> wnayes: What are you running to rebuild?
17:42:38 <wnayes> pymake -sj4 -f client.mk build
17:44:40 <clokep_work> wnayes: There's no reason to rebuild everything.
17:44:50 <clokep_work> Just run pymake -sj4 -C objdir/<whatever you want to rebuild>
17:45:01 <clokep_work> So I usually run mozmake -C objdir/chat/protocols/irc
17:45:16 <clokep_work> And you can do mozmake -C objdir tier_app to rebuild "Instantbird" and not Mozilla stuf.
17:47:52 <wnayes> clokep_work: That sounds like it will be a lot faster :) On linux I would finish a build like that in 1-2 minutes so it never really bothered me, but Windows takes a good 5-10 min.
17:48:52 <clokep_work> wnayes: You have a good computer then. ;)
17:49:21 <clokep_work> tier_app for me is about 1 - 2 minutes on Windows.
17:49:32 <clokep_work> chat/ or instantbird/ is instantaneous.
17:51:49 <wnayes> It looks like using this.account fixed things :)
17:53:23 <clokep_work> wnayes: Does it make sense why?
17:54:38 <wnayes> Must just be something related to how value is handled?
17:56:37 <clokep_work> So value of the richtextbox is the text value of it.
17:56:53 <clokep_work> So I think when you try to set it to some arbitrary thing it's returning the string casted version to you.
17:57:08 <clokep_work> And when you cast arbitrary objects to strings it just gives you some description of the underlying object.
18:14:58 <wnayes> clokep_work: for some reason rebuilding tier_app didn't rebuild changes to the UI, but just -C objdir/instantbird did the trick :)
18:16:20 <clokep_work> wnayes: Hmmm....honestly...I'm not sure if it does or not, I very rarely work on UI. :-D
18:31:29 * jwir3 is now known as jwir3|lunch
18:35:28 --> gerard-majax has joined #instantbird
18:43:20 <instantbot> bugi@media.fjmail.de requested review from clokep@gmail.com for attachment 1537 on bug 1108.
18:43:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
18:43:50 <-- FeuerFliege has quit (Input/output error)
18:43:55 <-- FireFly_TB has quit (Quit: FireFly_TB)
18:46:03 <instantbot> clokep@gmail.com cancelled feedback? for attachment 1502 on bug 1108.
18:46:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
19:06:50 <-- chrisccoulson has quit (Quit: Ex-Chat)
19:15:13 --> chrisccoulson has joined #instantbird
19:21:27 --> flo has joined #instantbird
19:21:27 * ChanServ sets mode +qo flo flo 
19:22:32 --> gpsychosis has joined #instantbird
19:23:01 <-- gpsychosis has quit (Quit: Instantbird 1.1)
19:30:17 * jwir3|lunch is now known as jwir3
19:34:21 <-- Mook_astb has quit (Quit: Mook_astb)
19:34:26 --> Mook_astb has joined #instantbird
20:22:08 <-- Optimizer has quit (Ping timeout)
20:26:21 --> Optimizer has joined #instantbird
20:31:58 <-- gerard-majax has quit (Ping timeout)
20:32:01 --> FireFly_TB has joined #instantbird
20:42:21 <-- Optimizer has quit (Ping timeout)
20:45:48 --> Optimizer has joined #instantbird
20:50:31 <wnayes> flo: Do you think the account wizard should have separate summary pages depending on importing/adding an account (keeping the old one for adding and making a new one for importing?)
20:50:57 <flo> no :)
20:51:12 <flo> it would be ideal if it could list all the accounts that are about to be created; whatever their origin
20:51:25 <flo> and that summary page could contain an "add another account" button
20:54:28 <wnayes> Alright, lots to look into for that change then :). Do you think "account.js" can/shoud be adapted to provide the Properties functionality of the found accounts as well as regular accounts too?
20:54:30 <-- Optimizer has quit (Ping timeout)
20:58:00 --> Optimizer has joined #instantbird
20:59:32 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:02:24 --> EionRobb has joined #instantbird
21:03:16 <-- Optimizer has quit (Ping timeout)
21:05:26 --> Optimizer has joined #instantbird
21:10:46 <flo> wnayes: aren't they the same?
21:10:56 <flo> ah, you meant the existing crappy properties dialog
21:11:18 <flo> well, maybe.
21:11:36 <flo> I would like to remove that dialog completely eventually, but that's probably out of the scope of your project :)
21:13:54 <flo> wnayes: so yes, if it's reasonably easy to adapt, go for it :)
21:15:17 --> skeledrew has joined #instantbird
21:15:50 <wnayes> I haven't gotten there quite yet but likely in the next few days :)
21:16:50 <flo> what are you working on now?
21:17:33 <flo> I guess I could find part of the answer to that question in the etherpad you linked to a few hours ago
21:17:49 <flo> (I assumed clokep had answered all your questions, so I didn't look at it again when coming back online)
21:19:03 <wnayes> He answered most, except maybe if there should be a getImporter(aImporterId) in the service-though maybe since I fixed the initial issue I was having that getting the importer like that won't be necessary.
21:19:55 <flo> wnayes: the value is set to the richlistbox item with a setAttribute call: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/richlistbox.xml#150
21:20:07 <flo> it's not a JS property, but a DOM attribute, so it can only be a string
21:21:44 <-- Optimizer has quit (Ping timeout)
21:22:23 --> Optimizer has joined #instantbird
21:23:19 <wnayes> Ah, I see. Everything's been working with a custom property now :)
21:24:28 <flo> http://hg.instantbird.org/users/wnayes/file/1a4a12640bd6/chat/importers/jsTest/jsTestImporter.js#l17 calls the observer synchronously
21:24:44 <flo> is this an acceptable behavior 
21:24:45 <flo> ?
21:25:10 --> dmigod has joined #instantbird
21:27:08 <wnayes> Definitely not if it was doing a long operation :) Earlier you said each importer would handle threading its own way so I didn't look into it for the test importer.
21:31:00 <flo> but calling the observer synchronously means that if the code calling start expected to do something immediately after calling start, that won't happen until after the observer has been notified
21:31:06 <flo> there's a potential for race conditions
21:34:10 <wnayes> would a setTimeout() be sufficient for those calls?
21:34:49 --> Bollebib has joined #instantbird
21:39:33 --> Lalae has joined #instantbird
21:40:01 <-- Lalae has left #instantbird ()
22:05:22 <flo> wnayes: use executeSoon from imXPCOMUtils.jsm instead of setTimeout
22:05:58 <flo> setTimeout is when you want something to execute after a specified amount of time
22:06:14 <flo> executeSoon is to execute it immediately after all ongoing synchronous processing
22:06:18 <wnayes> I found that a few minutes ago :) Seems I also cannot use "this" in any of those calls.
22:09:48 <aleth> wnayes: You probably need bind()
22:10:14 <aleth> https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Function/bind
22:12:10 <wnayes> aleth: Thanks, seems to be referring to the errors I'm having.
22:13:53 <aleth> Quite often just adding .bind(this) will be enough
22:16:12 <flo> uh, http://crash-stats.instantbird.com/report/index/a8fe91e9-89be-4d65-8ec2-51cea2120525 :(
22:23:14 <flo> and MSN is still as crashy as usual
22:40:01 <-- dmigod has quit (Client exited)
23:02:02 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:16:52 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
23:20:30 --> myk1 has joined #instantbird
23:20:30 <-- myk has quit (Connection reset by peer)
23:28:36 <-- Bollebib has quit (Quit: Instantbird 1.1)
23:30:29 * myk1 is now known as myk
23:41:30 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:45:10 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)