#instantbird log on 05 28 2012

All times are UTC.

01:00:34 --> FireFly_TB has joined #instantbird
01:02:23 <-- FireFly_TB has quit (Ping timeout)
01:23:50 --> skeledrew has joined #instantbird
01:26:17 <instant-buildbot> build #227 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/227
01:49:03 <instant-buildbot> build #248 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/248
02:20:17 --> wnayes has joined #instantbird
02:59:26 <instant-buildbot> build #509 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/509
03:14:39 <-- wnayes has quit (Quit: Instantbird - http://www.instantbird.com)
03:34:26 --> NmN has joined #instantbird
04:26:59 <instant-buildbot> build #602 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/602
05:22:44 <-- EionRobb has quit (Quit: Leaving.)
05:23:06 --> EionRobb has joined #instantbird
05:24:51 <-- EionRobb has quit (Ping timeout)
05:55:12 --> pvagner has joined #instantbird
06:03:19 <instant-buildbot> build #496 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/496
07:01:54 --> Optimizer has joined #instantbird
07:02:33 --> EionRobb has joined #instantbird
07:05:40 <-- EionRobb has quit (Ping timeout)
07:07:51 <-- Optimizer has quit (Ping timeout)
07:35:49 --> sonny has joined #instantbird
08:03:24 --> Optimizer has joined #instantbird
08:03:45 --> FeuerFliege has joined #instantbird
08:04:04 --> FireFly_TB has joined #instantbird
08:30:33 --> Even has joined #instantbird
08:30:33 * ChanServ sets mode +o Even 
08:32:47 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
08:33:09 --> FeuerFliege has joined #instantbird
08:33:19 <-- FireFly_TB has quit (Quit: FireFly_TB)
08:33:39 --> FireFly_TB has joined #instantbird
08:48:55 <-- Optimizer has quit (Ping timeout)
08:52:48 --> Optimizer has joined #instantbird
09:06:01 <-- Optimizer has quit (Ping timeout)
09:11:42 <-- FeuerFliege has quit (Ping timeout)
09:11:42 <-- FireFly_TB has quit (Ping timeout)
09:15:18 --> Optimizer has joined #instantbird
09:15:59 --> FireFly_TB has joined #instantbird
09:16:00 --> FeuerFliege has joined #instantbird
09:29:43 --> Mic has joined #instantbird
09:29:43 * ChanServ sets mode +h Mic 
09:48:31 <-- Even has quit (Ping timeout)
09:49:18 <Mic> Hi
09:50:01 <-- FireFly_TB has quit (Ping timeout)
09:50:01 <-- FeuerFliege has quit (Ping timeout)
09:50:33 <Mic> The chat room fields that were used to join a chat aren't stored anywhere, are they?
09:55:35 --> Mic2 has joined #instantbird
09:56:42 <-- Mic2 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:59:58 <-- Optimizer has quit (Ping timeout)
10:00:12 --> Optimizer has joined #instantbird
10:02:47 <-- Optimizer has quit (Ping timeout)
10:03:36 --> Tomek has joined #instantbird
10:03:51 --> Optimizer has joined #instantbird
10:04:41 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
10:15:18 --> FireFly_TB has joined #instantbird
10:15:21 --> FeuerFliege has joined #instantbird
10:19:56 <Optimizer> who is Benedikt
10:20:23 <FeuerFliege> Optimizer: Mic
10:20:52 <Optimizer> Oh
10:22:19 <Optimizer> how can I reply to the review mail ?
10:25:20 <FeuerFliege> addon or bug?
10:25:51 <-- NmN has quit (Quit: Instantbird 1.1)
10:26:13 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:28:14 <-- Optimizer has quit (Ping timeout)
10:31:38 --> Optimizer has joined #instantbird
10:54:40 --> FeuerFliege has joined #instantbird
11:21:31 <-- FeuerFliege has quit (Input/output error)
11:21:44 --> FeuerFliege has joined #instantbird
11:31:00 --> aleth has joined #instantbird
11:31:01 * ChanServ sets mode +h aleth 
11:35:01 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:35:55 --> FeuerFliege has joined #instantbird
11:42:29 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:42:38 --> aleth has joined #instantbird
11:42:38 * ChanServ sets mode +h aleth 
13:01:50 --> clokep has joined #instantbird
13:01:50 * ChanServ sets mode +o clokep 
13:03:12 <clokep> Mic: You mean do we store them in the conversation object or anything like that?
13:03:23 <clokep> We do not, IIRC correctly.
13:04:00 <clokep> The whole way auto-joins work is suboptimal too, since there is only a text field for it.
13:09:07 <instantbot> clokep@gmail.com set the Resolution field on bug 1463 to FIXED.
13:09:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1463 enh, --, 1.2, aletheia2, RESO FIXED, [Tab complete] List possible completions only on second tab press when pinged
13:10:12 --> Mic has joined #instantbird
13:10:12 * ChanServ sets mode +h Mic 
13:11:49 <Mic> Optimizer: you can e.g. tell me here (ping me anyways if I'm not here, it makes it easier to find on the logs)
13:12:43 <Optimizer> I have reuploaded the version
13:13:03 <Mic> Oh, you're fast :)
13:13:35 <Mic> Isn't my nickname shown in the review-email by the way? I certainly have set one on AI, it appears for my add-ons at least.
13:13:41 <Mic> *on AIO
13:14:44 <Mic> clokep: that is exactly what I was hoping for (a chatRoomFields-field on the conversation object).
13:15:38 <Mic> I figured that out  by looking at the idl and js-irc implementation though :(
13:21:16 <-- Optimizer has quit (Ping timeout)
13:21:31 <clokep> Mic: Yes, it's not there. If we need it, we can add it though. :)
13:25:04 --> Optimizer has joined #instantbird
13:37:36 <Mic> Auto-join could live w/o such a field by the way, it would be good enough if the UI would serialize and store this information somehow (it's got all the information already). In my case it would be useful though since I'm trying to restore any already existing conversation.
13:38:54 <aleth> Mic: Yes, I think the combination of session restore and auto-rejoin on reconnect would make autojoin obsolete.
13:40:06 <Mic> Maybe I just need it because I try putting sesson restore on top of what we have, might be unnecessary if we actually built it in.
13:41:05 <aleth> If the (current) autojoin field was purely internal and held the currently open channels, that would implement auto-rejoin on reconnect I think.
13:41:34 <-- Optimizer has quit (Ping timeout)
13:42:13 <aleth> I think session restore is wanted as a built-in feature, isn't it?
13:42:49 <Mic> I'd say so
13:45:25 --> Optimizer has joined #instantbird
13:49:23 --> Mic1 has joined #instantbird
13:50:01 <-- Mic has quit (NickServ (GHOST command used by Mic1))
13:50:01 <-- Mic1 has quit (Input/output error)
13:50:04 --> Mic has joined #instantbird
13:50:04 * ChanServ sets mode +h Mic 
14:04:34 <-- pvagner has quit (Ping timeout)
14:13:33 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
14:16:40 --> Mic has joined #instantbird
14:16:40 * ChanServ sets mode +h Mic 
14:20:14 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
14:23:53 --> Lalae has joined #instantbird
14:24:08 <-- Lalae has left #instantbird ()
14:26:58 --> gpsychosis has joined #instantbird
14:27:18 <-- gpsychosis has quit (Quit: Instantbird 1.1)
14:30:48 --> pvagner has joined #instantbird
14:36:25 <-- Optimizer has quit (Ping timeout)
14:47:53 --> Optimizer has joined #instantbird
14:50:55 <-- pvagner has quit (Ping timeout)
14:51:27 <-- FireFly_TB has quit (Quit: FireFly_TB)
14:51:37 <-- FeuerFliege has quit (Input/output error)
14:53:16 --> pvagner has joined #instantbird
14:58:29 <-- pvagner has quit (Ping timeout)
15:02:12 --> pvagner has joined #instantbird
15:09:24 <-- pvagner has quit (Ping timeout)
15:10:03 --> FireFly_TB has joined #instantbird
15:10:33 <flo> being pinged in a channel (on hold) with 2000+ unread message is frustrating
15:11:39 <flo> (half a minute of wait before seeing what people are telling you)
15:11:43 <flo> at least we don't freeze any more :)
15:12:20 --> FeuerFliege has joined #instantbird
15:12:56 <flo> clokep: I'm wondering if I should r- https://bugzilla.mozilla.org/attachment.cgi?id=627670&action=diff or not
15:13:52 <flo> ie, is it wrong to rename the iconBaseURI in a way that make it differ from the prplid?
15:14:08 <flo> (changing the prplid would be unacceptable without writing migration code; as we have already discussed)
15:15:35 <-- clokep has quit (Ping timeout)
15:15:43 <aleth> And the proposed change to xmpp.manifest still contains prpl-jabber -- bug or just confusing?
15:16:46 <flo> aleth: that's the prplid
15:16:53 <flo> (and I wrote that part ;))
15:17:25 <aleth> So you'd see prpl-jabber in some contexts and prpl-xmpp in others? Confusing ;)
15:21:35 <flo> you will never see any of them unless you are a developer
15:21:50 <aleth> I realize that :P
15:22:54 <aleth> I'm kind of surprised they didn't ask you to change the prpl-prefix at some point (or isn't it originally short for the purple in libpurple?)
15:30:59 <flo> aleth: it's the other way, "purple" in "libpurple" comes from "prpl" which is the abbreviation of "protocol plugin"
15:32:03 <aleth> aha! :)
15:35:24 <Optimizer> my IB never froze
15:36:51 <flo> Optimizer: that seems like a good thing ;)
15:37:41 <FeuerFliege> flo: The IB nightlies based on gecko 11, right?
15:37:52 <flo> yes
15:41:29 <-- Optimizer has quit (Ping timeout)
15:43:55 <FeuerFliege> thx
15:45:06 --> Optimizer has joined #instantbird
15:46:00 <flo> we need to update it though, so that should change "soon"
15:46:29 <flo> it seems that until we drop Mac PPC I'm the only one who can work (or at least finish) these updates :(
15:53:31 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:53:58 --> FeuerFliege has joined #instantbird
15:55:01 --> wnayes has joined #instantbird
16:02:26 --> clokep has joined #instantbird
16:02:26 * ChanServ sets mode +o clokep 
16:02:42 <clokep> flo: Yes, it should be named in the same way. r-
16:03:37 <clokep> Yes, I had asked for it to be called xmpp instead of jabber. :(
16:03:50 <flo> clokep: if it should always be named the same way, that baseIconURL getter seems pointless. Why isn't it implemented in jsProtoHelper?
16:03:52 <clokep> I'm still unsure of whether we should just write the migration code for it now or...
16:04:07 <clokep> flo: We probably just never got around to doing it.
16:04:18 <flo> it's just moving one line ;)
16:05:34 <clokep> flo: I can review the patch for that, if you'd like. ;)
16:09:43 <flo> aaah, http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#706
16:09:59 <flo> it's because by default we want jsProtoHelper to work for protocol add-ons that don't provide icons
16:10:14 <flo> (like Omegle I think :))
16:11:14 <FeuerFliege> height 3 px and a stronger color is nice for the unread-ruler.
16:13:35 <clokep> Ah, yeah that's why. :)
16:18:13 <wnayes> I was wondering what anyone's thoughts were on the welcome screen changes I made yesterday: http://www.tc.umn.edu/~nayes006/gsoc2012/files/WizardWelcomeScreen.png
16:18:16 --> Mic has joined #instantbird
16:18:16 * ChanServ sets mode +h Mic 
16:20:03 <flo> isn't there a risk of people clicking "next" (even if it's labeled "skip") too quickly, and not even notice that it says "5 accounts found"? :-/
16:20:09 <clokep> wnayes: I don't really like the last screen personally.
16:20:17 <clokep> For exactly the reason flo just stated. :)
16:20:27 * clokep goes to have some of that watermelon flo seems to want.
16:20:59 <flo> no _work today?
16:21:30 <clokep> flo: No, it's a US holiday.
16:22:08 <flo> aaaah, I thought it was only in France!
16:22:36 <flo> (I thought bienvenu said it was "another obscure French holiday" when Jb mentioned it at a meeting :-D)
16:23:21 <clokep> It's Memorial Day in the US. What holiday is it in France?
16:23:26 <Mic> wnayes: replace it with the list of account directly instead of asking the user to click (and maybe miss it if they're not observant)
16:23:55 <Mic> +?
16:24:39 <Mic> clokep: in Germany it's "Whit Monday" (as it seems to be called) today.
16:25:32 <flo> clokep: a religious holiday
16:25:44 <clokep> Ah, I see.
16:25:59 <-- Kaishi has quit (Quit: Kaishi)
16:26:00 <flo> clokep: Pentecost Monday
16:26:02 --> Kaishi has joined #instantbird
16:26:22 <flo> ah, "Whit Monday" says Google Translate
16:26:26 <flo> as, Mic said already :)
16:26:58 <Mic> My dictionary offered your translation too, I just had to choose one of them ;)
16:27:32 <flo> ah, yeah, mine is in the list of alternative translations :)
16:27:55 <flo> anyway "Lundi de Pentecôte" in French ;)
16:28:10 <wnayes> I don't know how the account list could be received on the welcome page without having a lot of commotion occur, which is why I thought a link (or other form of navigation) made sense
16:28:47 <flo> wnayes: what about replacing "Skip" with "Next" when accounts are found?
16:28:51 <-- Optimizer has quit (Ping timeout)
16:29:57 <clokep> Pentecost is the proper translations.
16:30:06 <wnayes> The thing with that change is I'm thinking a search will likely finish in ~1-2s
16:30:37 <flo> clokep: Pentecost is on Sunday though ;).
16:30:47 <clokep> Right.
16:31:36 <clokep> What about adding another button, which is skip. Keeping the "Next" button as disabled until the search finishes and then having "next" go to the rest of the import stuff?
16:32:15 <flo> wnayes: "I'm thinking a search will likely finish in ~1-2s" is this just a random guess?
16:32:16 --> Optimizer has joined #instantbird
16:33:22 <wnayes> flo: Yeah :) I would think somewhere in the region of instantaneously to a few seconds, if only a basic "do accounts exist" search occurs.
16:34:23 <wnayes> If loading logs in happened at this time then there might be quite a wait. Which is why I was thinking that converting logs would occur after the accounts were selected on a following screen.
16:34:34 <flo> how cluttered does it look if we disable "next" until the search is finished, and add another "skip" button, as clokep suggested?
16:34:56 <flo> wnayes: converting logs can likely take an hour or two :-P
16:35:11 <flo> (if the user has several years of history including some busy irc channels)
16:35:19 <Mic> Can we add a skip button there (i.e. do wizards support this)?
16:36:10 <wnayes> The Skip would have to be enabled as the extra1 button, and have the functionality written in. I think having both would make sense though.
16:36:49 <Mic> Ah, good to know :)
16:38:27 <Mic> I find the mockup to be a bit crowded, by the way
16:38:49 <Mic> (i.e. too much text and elements for so little space)
16:40:09 <flo> Mic: I find the large (2px) border really ugly on these images, but it's irrelevant :)
16:41:02 <flo> I think for a "welcome" page I would like to see less text and the logo of the application
16:41:46 <Mic> "Account discovery" might be a better title for this step?
16:42:20 <wnayes> Mic: I think that is a reasonable critique. I thought the box in the center would highlight the importing activity, preventing it from being overlooked. Maybe the title in the box being removed would free a lot of space.
16:42:27 <flo> wnayes: if this actual code that works, or edited images to provide mockups?
16:43:34 <wnayes> flo: The last 2 have modified status labels in the box :) Otherwise the skip button code works and the first window appears as is in the repo.
16:44:56 <flo> ok, so the UI works but there's no import code yet, right? :)
16:45:46 <wnayes> Right :) I figured some feedback would make sense before pushing forward.
16:46:38 <flo> in that case, I would advise that you keep it like it's on your screenshot for now (it's definitely good enough to let us test the other parts of your project in the future) and start some work on the back-end (did you have more questions about the interfaces, or were they ready?)
16:47:00 <flo> I think we will want to revisit this part of the UI once we have a good estimate (and no more only a guess) of how much we need to make the user wait
16:47:56 <wnayes> flo: Makes sense - and I was just going to start asking questions about the interfaces :).
16:49:35 --> DGMurdockIII has joined #instantbird
16:49:38 <wnayes> I guess my first one would be: do you think it would make sense to also use the nsIObserver interface between the importer service and the importers (instead of having the importers call addAccount(),importFinished() on the service)?
16:50:41 <flo> that would make sense, yes. You would then have interfaces that look and work mostly like our interfaces for the contacts service.
16:51:04 <flo> in that case you want an observe method in the imIImportersService interface
16:53:20 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 13.0/20120523114940])
16:55:52 <flo> clokep: do we have an easy way to run all our tests without running all the mozilla tests too?
16:57:40 <flo> the only way I've found for now is |make -C chat/protocols/irc/ xpcshell-tests| which is obviously not future proof
16:57:59 <clokep> flo: That's what I do, yes.
16:58:12 <clokep> I don't know if we have an easy way of just running Instantbird tests, no. :(
17:01:12 <wnayes> flo: I think I'll use that approach then :) I was also wondering how you would suggest having a reference back to the importer within an importedAccount (so the UI can differentiate and display the client where the account came from). Would having a string of the importer id be all that is needed, or would having "attribute imImporter importer" in the interface make more sense?
17:02:14 <flo> "attribute imImporter importer" seems better. (it's a *readonly* attribute)
17:02:41 <flo> clokep: I'm looking for a way to have |make distribution| fail when xpcshell tests are broken
17:03:17 <flo> I felt really stupid Friday when checking in something that broke a test and nobody had noticed until I pushed it to comm-central ;)
17:03:38 <clokep> flo: I see. Would adding xpcshell.ini to chat/test which calls the IRC one make sense?
17:03:58 <clokep> Theny ou can run xpcshell-tests in chat at the top level?
17:04:12 <clokep> (I think you can do things like that....)
17:04:19 <clokep> Yes, I don't blame you. :( Sorry about that.
17:06:05 <flo> " I don't blame you." but I still feel guilty for it until I can confidently say it will never happen again ;)
17:07:05 <FeuerFliege> Will IB make use of the TB chat l10n?
17:08:24 <flo> I'm not sure yet, but it seems relatively unlikely
17:08:34 <flo> (as that would force us to string freeze at the exact same times)
17:09:14 <FeuerFliege> flo: right
17:10:44 <flo> we will probably point our translators to the Tb chat l10n so that they can reuse as many strings as possible though :)
17:12:42 --> gerard-majax has joined #instantbird
17:13:59 <flo> clokep: hmm, we have http://lxr.instantbird.org/instantbird/source/instantbird/test/xpcshell.ini
17:15:30 <Mic> flo: your feedback in bug 958 would be appreciated by the way. If it is more extensive and would need more time than you can spare during these days just say so..
17:15:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows
17:17:19 <clokep> flo: Right. I wonder if there should be a toplevel one at chat/?
17:24:03 <flo> Mic: it seems like it would work fine (as long as we assume that if the system's clock is completely messed up it's the user's fault/problem).
17:24:20 <flo> the getConversation call will block on disk I/O
17:24:33 <flo> do we need to add a way to limit how many files we will open?
17:24:56 <flo> how badly do things break if a file we try to open contains only unparsable junk?
17:25:34 <flo> (failing to display previous messages if there's junk on the disk is OK; breaking the conversation to the point that displaying the current unread messages is impossible would be seriously annoying)
17:28:09 <instantbot> florian@instantbird.org granted feedback for attachment 1452 on bug 958.
17:28:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows
17:29:54 <Mic> Thanks a lot!
17:30:49 <flo> you are welcome, thanks for pushing this forward! :)
17:32:54 <Mic> bbl
17:32:55 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
17:35:51 --> igorko has joined #instantbird
17:42:01 <flo> clokep: I think we just need to port http://hg.mozilla.org/comm-central/diff/f3d345164ea8/mail/app/Makefile.in and then we should be able to just run make xpcshell-tests in the objdir
17:42:51 <flo> purple/purplexpcom/src/test/test_purplexpcom.js is in the mood of failing though :-S
17:44:07 <flo> that test is completely outdated :-S
17:45:34 <clokep> :(
17:45:50 <clokep> Well that won't make the TB trees burn. :)
17:48:09 <flo> yeah, be once I fix it, it will make our tree burn if libpurple can't start ;)
17:49:40 <flo> s/be/but/
17:56:01 <flo> TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: resource://gre/modules/Services.jsm :: <TOP_LEVEL> :: line 55"  data: no] :(
17:56:08 <flo> completely useless error message :(
17:56:21 <flo> apparently I can't init Services.core from the xpcshell
17:57:27 <flo> hmm, no this isn't right
17:57:59 <clokep> Oh? How come?
17:58:44 <flo> clokep: http://pastebin.instantbird.com/43460
17:59:10 <flo> would be so much better if services.jsm could at least tell us what failed
17:59:42 <clokep> Yes, that seems rather useless. :(
18:01:29 <flo> ah, line 55 is http://mxr.mozilla.org/mozilla-central/source/toolkit/content/Services.jsm#22
18:02:05 <flo> (22 with MPL2 ;))
18:02:22 <flo> so nsIXULAppInfo doesn't exist for xpcshell
18:02:25 <flo> I guess that makes some sense
18:04:07 <clokep> Yes, but is frustrating. :(
18:04:19 <flo> so the problem is http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#806
18:04:46 <-- FeuerFliege has quit (Ping timeout)
18:04:46 <-- FireFly_TB has quit (Ping timeout)
18:05:48 <flo> uh, the interface exists though :(
18:09:48 <flo> there are mozilla-central tests taht use Services.appinfo though http://dxr.lanedo.com/mozilla-central/toolkit/mozapps/extensions/test/xpcshell/test_update_compatmode.js.html#l32
18:09:51 <flo> I don't understand :-S
18:12:42 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
18:12:44 <-- Kaishi has quit (Quit: Kaishi)
18:16:54 <flo> apparently the solution is to implement it in the head http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/extensions/test/xpcshell/head_addons.js#29
18:19:27 <clokep> That seems like an awful hack. :(
18:20:27 <flo> I think I'll copy from http://mxr.mozilla.org/comm-central/source/mail/steel/mac/test_platform.js
18:24:52 --> DGMurdockIII has joined #instantbird
18:26:16 <wnayes> flo: Do you think I'm ready to move on to the javascript implementation of the interfaces? (http://hg.instantbird.org/users/wnayes/file/491ee280e999/chat/components/public/imIImportersService.idl)
18:26:17 <flo> clokep: here is what I have to fix that test: http://pastebin.instantbird.com/43461
18:29:17 <flo> wnayes: I'm not sure I like the current names of the notifications, and there's still something missing in the imIImporterAccount interface for the advanced settings of the accounts, but I don't think this should block you :)
18:29:28 <flo> it will be easy to add more things for the settings when needed
18:29:40 <flo> and the notification names would be easy to change with a search&replace
18:31:17 <wnayes> flo: I was thinking I could get to the settings from protocolId => prplProtocol -> .getOptions()
18:31:26 <wnayes> I didn't know how much was needed in the interface
18:32:40 <flo> wnayes: you will get the list of settings and the default values from that
18:32:57 <flo> wnayes: what you need in imIImportedAccount is a way to show that settings the account have
18:33:03 --> FeuerFliege has joined #instantbird
18:33:08 --> FireFly_TB has joined #instantbird
18:35:19 <wnayes> flo: A nsISimpleEnumerator of prplIPref?
18:36:54 <-- SM0TVI has quit (Connection reset by peer)
18:37:39 <wnayes> I also was thinking there would need to be a method to compare two imImportedAccounts to check whether they are the same account.
18:38:13 <flo> clokep: my plan is to push http://pastebin.instantbird.com/43462 then check that the onCommit build fails (on Mac at least) and then check in your fix for the IRC test, and check that it succeeds
18:38:20 <flo> any issue with this?
18:38:39 --> SM0TVI has joined #instantbird
18:38:47 <flo> wnayes: isn't this something that the UI would do?
18:39:36 <wnayes> flo: I figured the UI could, didn't know if it should be some sort of helper function in a component or module
18:39:45 <flo> if account1.name == account2.name (should that be normalizedName? I'm not sure where we would get the normalize method from though :-/) and account1.protocolId == account2.protocolId, they are the same
18:40:35 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:42:23 <DGMurdockIII> i have a gustionwhy do you still have ffreenode as the irc server pre filled in when you adding irc to instantbird 
18:44:56 <DGMurdockIII> not saying bad idea i would eather like you to have a drop down list that people can chost from and if it now on in the list they can click box right above the and then you would there would be a link shown under the box where they could submit the server to be included in future verson
18:45:10 <DGMurdockIII> that what i really like to see
18:45:30 <DGMurdockIII> or just change it for the mozilla server
18:45:59 <-- clokep has quit (Ping timeout)
18:47:45 <aleth> DGMurdockIII: Yes, something like that is wanted, see bug 1426 
18:47:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1426 nor, --, ---, nobody, NEW, IRC Account wizard somewhat confusing for users new to IRC
18:48:47 <aleth> The dropdown list idea is also mentioned there.
18:54:46 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/dfb14c0d81d8 - Florian Quèze - Run our xpcshell tests during 'make distribution' on our buildbot slaves.
18:54:47 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4835e3585991 - Florian Quèze - Fix test_purplexpcom.js for compatibility with bug 759.
18:56:54 --> Mic has joined #instantbird
18:56:55 * ChanServ sets mode +h Mic 
19:00:27 <DGMurdockIII> aleth:  that a bug of a crash
19:01:31 <aleth> Sorry, I don't understand? No crash, just a discussion of possible enhancements
19:01:55 <Mic> aleth filed this bug, I guess he knows what he's talking about in there ;)
19:02:35 <aleth> It should possibly be retitled, but I'll leave that to whoever decides to act on it
19:04:28 <Mic> wnayes: does the importer service also do the job  of setting up the accounts or is that done from elsewhere?
19:05:23 <wnayes> Mic: I was thinking the UI would handle that, as it currently adds an account as is.
19:05:52 <Mic> OK, thanks. 
19:06:22 <Mic> I was just curious
19:07:08 <Mic> Well, I was thinking it might be something like: 
19:09:00 <Mic> Importer Service + Importers tell the UI: we found accounts A, B, C, D, E.
19:09:00 <Mic> UI responds -> OK, user wants accounts B, C, E  -> Importer Service sets up accounts B, C, E
19:10:44 <flo> Mic: it needs to be done by the UI because we would like the user to be able to tweak some settings before leaving the account wizard
19:13:54 <-- Optimizer has quit (Ping timeout)
19:14:17 --> Optimizer has joined #instantbird
19:15:39 <Mic> What about feeding the imported accounts (with tweaked settings if needed) back to the importer service for the task then, maybe?
19:18:42 <Mic> Nevermind, it seemed nicer to me if it was handled in one place and UI code would be just for user interaction.
19:22:01 --> clokep has joined #instantbird
19:22:01 * ChanServ sets mode +o clokep 
19:22:58 <wnayes> Mic: I think that makes sense and either way would work (if ImportedAccounts are keeping track of changed preferences).
19:27:04 <clokep> flo: that plan makes sense.
19:32:08 --> mmkmou has joined #instantbird
19:32:54 <-- mmkmou has quit (Broken pipe)
19:38:26 <clokep> Sounds like you're making good progress wnayes. :)
19:39:49 <wnayes> clokep: I think so :). I'm well into the javascript implementation of the interfaces now.
19:45:02 <-- gerard-majax has quit (Ping timeout)
19:46:17 <aleth> Sounds like something similar to code-signing is coming to Windows 8 (among other things) http://arstechnica.com/information-technology/2012/05/no-cost-desktop-software-development-is-dead-on-windows-8/
20:07:21 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 13.0/20120523114940])
20:12:24 <Mic> "Every application will have to go through the Windows store, and will be subject to Microsoft's approval." -> MS = evil.
20:15:53 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
20:23:35 --> Mook_astb has joined #instantbird
20:24:49 <-- FireFly_TB has quit (Quit: FireFly_TB)
20:24:59 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:20:32 <-- Tonnes has quit (Connection reset by peer)
21:26:27 --> EionRobb has joined #instantbird
21:38:35 <-- Mook_astb has quit (Quit: Mook_astb)
21:38:43 --> Mook_astb has joined #instantbird
21:58:57 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
22:10:24 <instant-buildbot> build #228 of macosx-onCommit is complete: Failure [failed shell_1]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/228  blamelist: Florian Qu?ze <florian@instantbird.org>
22:12:29 <-- Optimizer has quit (Connection reset by peer)
22:12:58 <-- Tomek has quit (Quit: Instantbird 1.1)
22:18:32 <flo> clokep: it failed, but in a disappointing way :(
22:18:39 <flo> "arch: posix_spawnp: /private/var/buildbot/macosx-s1/macosx/obj-instantbird/ppc/mozilla/dist/bin/xpcshell: Bad CPU type in executable"
22:23:47 <clokep> flo: Any idea what it means? :-D
22:24:04 <flo> it means that universal mac builds suck
22:24:47 <flo> something somewhere in what xpcshell tries to execute is compiled for x86, and we have a ppc slave
22:25:26 <flo> I don't see any obvious reason for that though :(
22:33:59 <clokep> Bah. :(
22:38:45 <flo> I would propose readding the --disable-tests on mac buildbot mozconfigs only, and checking in the fixed test so that we can see tomorrow if it works fine on Linux/Windows
22:39:01 <flo> (we already have the confirmation that failing in xpcshell tests correctly fails the build on buildbot)
22:39:21 <clokep> I think that that makes sense.
22:44:20 <flo> is the "// Dummy function." comment still accurate?
22:44:56 <clokep> What bug # is this?
22:45:09 * clokep is cooking and might be slow to respond.
22:45:31 <flo> https://bugzilla.instantbird.org/attachment.cgi?id=1529
22:46:23 <clokep> No, not really.
22:47:04 <flo> should I remove it?
22:47:36 <clokep> Please.
22:51:59 <-- chrisccoulson has quit (Quit: Ex-Chat)
22:52:31 --> aleth has joined #instantbird
22:52:31 * ChanServ sets mode +h aleth 
22:59:49 --> chrisccoulson has joined #instantbird
23:00:19 <instantbot> florian@instantbird.org granted review for attachment 1529 on bug 1468.
23:00:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1468 nor, --, ---, clokep, ASSI, Fix failing test from bug 1446
23:00:32 <flo> Good night
23:00:33 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:05:02 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ce19d6a4e4dc - Florian Quèze - Disable tests on the mac buildbot mozconfigs, as they fail on the PPC builder.
23:05:04 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8b2bae87ca15 - Patrick Cloke - Bug 1468 - Fix failing test from bug 1446, r=fqueze.
23:13:51 <instantbot> clokep@gmail.com set the Resolution field on bug 1468 to FIXED.
23:13:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1468 nor, --, 1.2, clokep, RESO FIXED, Fix failing test from bug 1446
23:17:09 <-- wnayes has quit (Quit: Instantbird - http://www.instantbird.com)
23:20:28 <-- aleth has quit (Input/output error)
23:54:14 <-- meh has quit (Quit: I don't want to live on this planet anymore.)