#instantbird log on 05 25 2012

All times are UTC.

00:00:20 --> wnayes has joined #instantbird
00:13:32 --> EionRobb has joined #instantbird
00:33:52 <-- wesj has quit (Input/output error)
00:40:02 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:48:52 --> clokep has joined #instantbird
00:48:52 * ChanServ sets mode +o clokep 
00:49:02 <-- clokep has quit (Connection reset by peer)
00:49:41 --> clokep has joined #instantbird
00:49:41 * ChanServ sets mode +o clokep 
00:57:40 <clokep> flo: There's a bug on file about the name of the conversation not matching the target or whatever of a merged contact.
00:57:46 <clokep> (I filed it. ;))
01:01:21 <-- Mook_astb has quit (Quit: Mook_astb)
01:26:26 <instant-buildbot> build #225 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/225
01:30:35 <-- devfil has quit (Client exited)
01:42:08 <-- wnayes has quit (Quit: Instantbird - http://www.instantbird.com)
02:07:31 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1526 on bug 1466.
02:07:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1466 nor, --, ---, clokep, ASSI, Clearing the topic doesn't update the UI and instead displays the previous topic in a system message
02:20:14 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
02:30:19 --> NmN has joined #instantbird
03:03:25 <-- EionRobb has quit (Ping timeout)
03:07:16 --> EionRobb has joined #instantbird
04:51:29 --> pvagner has joined #instantbird
05:04:19 --> FeuerFliege has joined #instantbird
05:04:34 <-- gerard-majax has quit (Ping timeout)
05:09:42 <-- EionRobb has quit (Connection reset by peer)
05:10:15 --> EionRobb has joined #instantbird
05:19:35 <instantbot> New Instantbird (UI) bug 1467 filed by knut@torgersens.net.
05:19:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1467 nor, --, ---, nobody, UNCO, Not possible to copy status field
06:02:41 <instant-buildbot> build #493 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/493
06:35:20 --> jb has joined #instantbird
06:38:33 <-- jb has quit (Quit: jb)
06:52:18 <-- FeuerFliege has quit (Ping timeout)
07:32:21 --> FeuerFliege has joined #instantbird
07:34:02 <-- FeuerFliege has quit (Ping timeout)
07:34:21 --> meh has joined #instantbird
07:43:00 --> FireFly_TD has joined #instantbird
07:47:18 --> Even has joined #instantbird
07:47:18 * ChanServ sets mode +o Even 
07:57:54 <-- FireFly_TD has quit (Quit: FireFly_TD)
07:59:16 --> FeuerFliege has joined #instantbird
08:00:37 --> FireFly_TB has joined #instantbird
08:05:48 --> sonny has joined #instantbird
08:20:33 --> Mic has joined #instantbird
08:20:33 * ChanServ sets mode +h Mic 
08:21:52 <Mic> We haven't got new nightlies today - the build slaves are offline as it seems.
08:27:55 <-- pvagner has quit (Quit: Instantbird -- http://www.instantbird.com)
08:32:58 --> pvagner has joined #instantbird
08:39:01 --> jb has joined #instantbird
08:49:58 --> gerard-majax has joined #instantbird
08:51:43 <-- gerard-majax has quit (Ping timeout)
08:58:55 --> Lalae has joined #instantbird
08:59:13 <-- Lalae has left #instantbird ()
09:04:32 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
09:04:37 --> mmkmou has joined #instantbird
09:05:06 --> Mic has joined #instantbird
09:05:06 * ChanServ sets mode +h Mic 
09:05:43 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
09:05:50 --> Mic has joined #instantbird
09:05:50 * ChanServ sets mode +h Mic 
09:05:54 <-- Mic has quit (Quit: Mic)
09:05:56 --> Even1 has joined #instantbird
09:06:46 --> gerard-majax has joined #instantbird
09:20:59 --> flo has joined #instantbird
09:20:59 * ChanServ sets mode +qo flo flo 
09:21:07 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:21:33 --> Mic has joined #instantbird
09:21:33 * ChanServ sets mode +h Mic 
09:21:45 --> flo has joined #instantbird
09:21:45 * ChanServ sets mode +qo flo flo 
09:23:58 <flo> hello :)
09:24:32 <flo> I see a new "mode (#instantbird +ntr) by concrete.mozilla.org." system message when entering here. Is it expected?
09:35:57 --> Optimizer has joined #instantbird
09:41:12 <-- gerard-majax has quit (Ping timeout)
09:41:56 --> jb1 has joined #instantbird
09:42:12 <flo> ah, Ludovic is reopening the "creating IRC accounts does crazy things" can of worms: https://bugzilla.mozilla.org/show_bug.cgi?id=758527 :)
09:42:36 <-- jb1 has quit (Quit: jb1)
10:04:03 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:04:34 <-- meh has quit (Ping timeout)
10:07:39 --> meh has joined #instantbird
10:24:54 --> clokep has joined #instantbird
10:24:54 * ChanServ sets mode +o clokep 
10:25:17 <flo> clokep: hello :)
10:25:29 <clokep> Good morning flo.
10:25:39 <flo> do you expect/want some feedback from aleth specifically for bug 1466, or can I just r+ and check-it in?
10:25:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1466 nor, --, ---, clokep, ASSI, Clearing the topic doesn't update the UI and instead displays the previous topic in a system message
10:25:55 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 1526 on bug 1466.
10:25:55 <clokep> flo: You could check it in if it worked. :-D
10:25:58 <flo> I think I would like to include it in my next 'sync chat/ with comm-central' set of changesets
10:26:05 <clokep> I'm fixing it now though.
10:26:23 <flo> bah, you attach non working patches? :-S
10:29:58 <-- Mic has quit (Ping timeout)
10:30:15 --> Mic has joined #instantbird
10:30:15 * ChanServ sets mode +h Mic 
10:34:09 <clokep> flo: It works...just the message is wrong in a case.
10:34:21 <clokep> And I didn't realize it until this morning.
10:38:22 <clokep> flo: When are you planning to do another sync?
10:38:31 <flo> half an hour ago :)
10:38:48 <flo> more likely, when it's ready ;)
10:39:17 <flo> but I would like to port the fixes I produced yesterday, especially the one causing the hangs sooner rather than later
10:39:40 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
10:42:52 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1527 on bug 1466.
10:42:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1466 nor, --, ---, clokep, ASSI, Clearing the topic doesn't update the UI and instead displays the previous topic in a system message
10:43:10 <clokep> flo: Makes sense.
10:44:53 <clokep> And yes, the mode message was added.
10:44:55 <flo> bah, with a string change? :(
10:44:58 <clokep> I'm not sure I totally like it or not.
10:45:13 <clokep> Yes. The tense was wrong with the other string.
10:46:09 <flo> is this a fix for a recent regression that we would otherwise want on aurora?
10:46:37 <clokep> I don't think so...
10:46:44 <clokep> I think the regression isn't on aurora.
10:46:51 <clokep> Unless you ported that. :)
10:46:56 --> Tomek has joined #instantbird
10:47:02 <flo> nothing is on aurora yet
10:47:16 <flo> but I'll update the patch of things for aurora
10:48:14 <flo> clokep: any reason for adding a topic variable, but then using aMessage.params[2] ?
10:48:59 <clokep> flo: It seemed to make the formatting nicer.
10:49:24 <clokep> (Namely the line right below it fits on one line now.)
10:49:32 <clokep> I could change it if you like. I have the function open. ;)
10:49:39 <flo> my question is: why not _("message.topic", conversation.name, topic) ?
10:49:43 <clokep> So for aurora, I wouldn't take bug 1369 or it's regressions.
10:49:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1369 enh, --, 1.2, clokep, RESO FIXED, Support WATCH and MONITOR for IRC
10:49:52 <clokep> flo: Because I forgot to change that one. :)
10:51:06 <flo> sounds like a good idea to avoid that bug for aurora, right :)
10:51:50 <flo> are you going to attach a new patch soonish with the "topic" variable used, or should I edit it before testing it? :)
10:52:25 <clokep> Edit it please, I'm getting ready for work.
10:52:45 <flo> ok! :)
11:03:04 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:09:35 <-- meh has quit (Ping timeout)
11:15:53 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 1527 on bug 1466.
11:15:54 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1528 on bug 1466.
11:15:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1466 nor, --, ---, clokep, ASSI, Clearing the topic doesn't update the UI and instead displays the previous topic in a system message
11:18:51 --> meh has joined #instantbird
11:20:46 <flo> apparently we will have to port https://bugzilla.mozilla.org/attachment.cgi?id=626817&action=diff
11:24:35 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:48:06 --> clokep_work has joined #instantbird
11:48:06 * ChanServ sets mode +o clokep_work 
11:48:48 --> Mic|web has joined #instantbird
11:52:41 <instantbot> clokep@gmail.com granted review for attachment 1528 on bug 1466.
11:52:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1466 nor, --, ---, clokep, ASSI, Clearing the topic doesn't update the UI and instead displays the previous topic in a system message
11:54:13 <-- Optimizer has quit (Ping timeout)
11:54:49 <clokep_work> That doesn't seem too bad to port. We should file a bug to track that though...
11:58:09 --> Optimizer has joined #instantbird
12:16:02 <flo> clokep_work: I'm not completely decided, but I thought I would just add the new changesets in the same bug as before, as the aurora patch there hasn't landed yet
12:21:03 <clokep_work> flo: If you would like to, it would be cleaner to use a separate bug, but more of a pain for checking in the patches I guess. :)
12:21:11 <-- pvagner has quit (Quit: Instantbird -- http://www.instantbird.com)
12:24:30 <flo> and a third bug for aurora?
12:26:17 <clokep_work> Or leave the aurora patches separate in the two bugs.
12:26:37 <clokep_work> Is bug 1467 a dup of bug 525?
12:26:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1467 nor, --, ---, nobody, UNCO, Not possible to copy status field
12:26:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=525 enh, --, ---, nobody, NEW, Buddy info tooltip is non-interactive
12:26:55 <flo> not really
12:27:07 <flo> even though it would probably be difficult to fix one without the other :)
12:29:32 <FeuerFliege> hi
12:31:11 --> pvagner has joined #instantbird
12:35:40 --> jb1 has joined #instantbird
12:47:06 <-- jb1 has quit (Quit: jb1)
12:49:43 <-- Tomek has quit (Ping timeout)
12:53:59 --> Tomek has joined #instantbird
12:56:24 <-- Tomek has quit (Quit: Instantbird 1.1)
12:58:20 <-- Optimizer has quit (Ping timeout)
12:59:38 --> jb1 has joined #instantbird
13:00:17 --> Even has joined #instantbird
13:00:17 * ChanServ sets mode +o Even 
13:00:44 <-- jb has quit (Ping timeout)
13:04:45 <Mic|web> hmm, hmm :)
13:05:17 <Mic|web> My first restored conversation window just opened at start :)
13:06:27 <flo> congrats! :)
13:08:14 <flo> clokep_work: is bug 1376 something we should seriously look into?
13:08:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1376 nor, --, ---, nobody, NEW, Tab text is wrong for a merge contact
13:08:55 <clokep_work> flo: We probably should. I think it's a regression from 1.1 btw (or maybe from 1.0).
13:09:08 <clokep_work> I...don't know that code at all. I remember looking to see if ther ewas anything obvious.
13:09:17 <clokep_work> I always get very lost in UI code. :(
13:09:30 <clokep_work> Mic|web: Awesome! :) How nasty is the code?
13:09:30 <flo> that part of the code may not be the easiest
13:09:57 <flo> ordering of notifications fired when changing the target can be tricky
13:10:45 <clokep_work> Ah, I see.
13:10:52 <clokep_work> I didn't realize that mattered. :)
13:12:30 <flo> it's also possible we messed up in some places the conversation's current target with the conversation's contact...
13:21:43 <clokep_work> That sounds likely actually.
13:23:09 --> TestFliege has joined #instantbird
13:23:56 <Mic|web> clokep_work: the code's not that nice yet but I think I can improve some parts.
13:28:59 <Mic|web> Currently it re-connects accounts, sets status and status message + *tries* to get the conversations right ;)
13:29:49 <clokep_work> :)
13:30:06 <clokep_work> Well if you want a code review (even just as an extension for now), feel free to let me know.
13:30:17 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/90609e9d4546 - Patrick Cloke - Bug 1466 - Clearing the topic doesn't update the UI and instead displays the previous topic in a system message, r=fqueze.
13:30:41 <flo> so the changesets that I'm porting to comm-central are: http://pastebin.instantbird.com/43343
13:31:32 <flo> I'm a bit sad that I keep adding more things to the 1.2-* lists :(
13:32:58 <Mic|web> clokep_work: sure, thanks for the offer! :)
13:35:44 <clokep_work> Mic|web: Of course. :) I'd really like to see it added into Instantbird one day!
13:36:04 <clokep_work> flo: Looks right. :)
13:36:45 --> Optimizer has joined #instantbird
13:51:08 <-- meh has quit (Ping timeout)
14:00:33 --> meh has joined #instantbird
14:04:12 <-- mmkmou has quit (Client exited)
14:21:32 <flo> clokep_work:  no objection to landing the new attachment of bug 753807 in comm-central I suppose?
14:24:35 <clokep_work> flo: No, I'm fine w/ it.
14:24:53 <flo> it feels strange to me to land patches when I already know they cause regressions
14:25:07 <flo> but at least I'm landing the regression fixes at the same time, so nobody will experience them ^^
14:25:13 <-- pvagner has quit (Quit: Instantbird -- http://www.instantbird.com)
14:29:05 <-- Kaishi has quit (Quit: Kaishi)
14:30:21 --> jb has joined #instantbird
14:35:56 <clokep_work> The only other option would be to squash them together...but that's more work. :-D
14:36:46 <flo> yeah, and would make the history more confusing after merging BIO into BMO
14:37:04 <clokep_work> I agree.
14:42:44 <FeuerFliege> in Earlybird the order of "message.mode" (» mode (nick +mode) by foo«) seems wrong. It’s » mode (+mode nick) by foo « 
14:43:25 <FeuerFliege> instantbird gets it right …
14:47:39 --> igorko has joined #instantbird
14:47:47 <clokep_work> FeuerFliege: I think a patch landed recently that flopped the two values when creating the message.
14:48:03 <clokep_work> If Instantbird gets ir right...Thunderbird will eventually get it right. ;)
14:58:15 --> wnayes has joined #instantbird
15:03:19 <instantbot> florian@instantbird.org set the Resolution field on bug 1466 to FIXED.
15:03:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1466 nor, --, 1.2, clokep, RESO FIXED, Clearing the topic doesn't update the UI and instead displays the previous topic in a system message
15:07:47 <flo> clokep_work: for aurora, does that seem right? https://etherpad.mozilla.org/3mvnTYpCyT
15:08:35 <-- FireFly_TB has quit (Ping timeout)
15:08:35 <-- FeuerFliege has quit (Ping timeout)
15:08:35 <-- TestFliege has quit (Ping timeout)
15:09:12 --> TestFlie1 has joined #instantbird
15:09:16 --> FeuerFliege has joined #instantbird
15:10:58 --> mmkmou has joined #instantbird
15:11:33 <clokep_work> flo: Yes
15:12:51 --> FireFly_TC has joined #instantbird
15:16:44 --> jb2 has joined #instantbird
15:17:08 <-- jb has quit (Ping timeout)
15:24:14 <clokep_work> flo: Was it easier to get the patches properly done this time? Were you able to just pull / convert again to get only the chat/ dir from Instantbird?
15:24:38 <flo> hg convert above the previous repository, yes
15:24:47 <flo> it was easier mostly because I wasn't wondering how to do it :)
15:28:08 <flo> it also feels strange to request approval for removing empty lines and readding them ;)
15:28:38 <clokep_work> Yeah one of my patches got messed up. :(
15:30:43 <flo> that aurora patch doesn't want to apply
15:32:10 <flo> it's bug 1447 that doesn't apply
15:32:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1447 nor, --, 1.2, clokep, RESO FIXED, Stop requesting WHOIS information when offline
15:35:26 <clokep_work> ...That patch is like extremely simple hah.
15:35:27 <flo> it depends on bug 1332
15:35:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1332 nor, --, 1.2, aletheia2, RESO FIXED, Implement /whois and /whowas commands
15:35:39 <flo> which contains string changes
15:35:41 <clokep_work> Ah, I see.
15:35:55 * flo will hand edit the patch
15:36:24 <flo> the problem is that line: https://hg.instantbird.org/instantbird/rev/07ece750914b#l2.103
15:36:36 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:40:05 <flo> and now it dislikes http://pastebin.instantbird.com/43346 from bug 1446
15:40:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1446 nor, --, 1.2, aletheia2, RESO FIXED, Reset nick when reconnecting and ensure conversations are notified of nick changes
15:41:19 <clokep_work> :( Sorry.
15:41:29 <clokep_work> Tough when a lot of these touch the same code.
15:41:51 * flo thinks your aren't the one to blame
15:42:03 <flo> it's just that we got the rapid release cycle backwards for Tb :(
15:43:07 <flo> this time it conflicts with bug 1321 it seems
15:43:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1321 min, --, 1.2, aletheia2, RESO FIXED, Display name is lower case for IRC DMs
15:44:09 <Mic|web> clokep_work: that's not meant as a review request, only if you're curious: http://pastebin.instantbird.com/43347
15:44:39 <-- wnayes has quit (Quit: Instantbird - http://www.instantbird.com)
15:46:06 <-- Optimizer has quit (Ping timeout)
15:46:17 --> Optimizer has joined #instantbird
15:47:14 --> Optimizer1 has joined #instantbird
15:47:57 --> wnayes has joined #instantbird
15:48:03 <-- Optimizer has quit (Ping timeout)
15:48:22 <clokep_work> Mic|web: Lots of code. :)
15:49:13 <flo> so the problems were only https://hg.instantbird.org/instantbird/rev/81717e6f64bd#l1.108 and https://hg.instantbird.org/instantbird/rev/81717e6f64bd#l1.117
15:49:15 <clokep_work> Doesn't look awful though, just a lot of cases to cover.
15:49:43 <flo> I hope removing lines 1.117-1.120 won't prevent the patch from working as expected 
15:50:24 <Mic|web> Yes, it's not that bad anymore. The helper function you see at top definitely helped to cut down the number of lines. (It's got some problems of its own but I plan to fix that sooner or later)
15:50:45 <Mic|web> One thing is that I can't restore MUCs yet :(
15:51:40 <Mic|web> And the case that the extension is started while the application is already running isn't handled nicely either yet. 
15:53:22 --> Even has joined #instantbird
15:53:22 * ChanServ sets mode +o Even 
15:54:02 <clokep_work> Restoring MUCs is probably a PITA because of the ChatRoomFields thing.
15:54:19 --> deomega1 has joined #instantbird
15:54:43 <deomega1> good day, someone asked me this.. any ideas?  :::::::
15:55:04 <deomega1> does instantbird support having more than one user... swithching user?
15:55:45 <deomega1> they want to install it on a desktop computer with multiple users
15:56:14 <Mic|web> Do these users have separate user accounts on the OS?
15:57:16 <deomega1> no
15:57:56 <clokep_work> You can open different profiles (just like Firefox or Thunderbird).
15:58:08 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:58:56 <clokep_work> By starting Instantbird with the -P <profile name> flag.
15:59:26 <clokep_work> I.e. |instantbird.exe -P| will bring up the profile manager and |instantbird.exe -P deomega1| would start the profile named deomega1.
15:59:40 <clokep_work> (You could make short cuts or whatever of course to different profiles.)
16:01:02 <flo> hmm, nicely red: https://tbpl.mozilla.org/?tree=Thunderbird-Trunk&rev=48e511314828 :)
16:01:04 <deomega1> ok,  there is not an  option to  have IB not remember your user id and pasword and thereby   forcing it to start up with alog in screen and when you log in, it then pulls teh applicable account?
16:01:44 <deomega1> a simple no to that question would suffice 
16:01:51 <deomega1> so i coud then  work with them on the suggestion
16:02:22 <flo> if you want to have a password prompt at startup, you can use a master password to protect all the other passwords
16:02:36 <flo> that would ensure they don't mistakenly connect with the profile of someone else
16:04:41 <deomega1>  ok, thank you  very much
16:04:42 <clokep_work> flo: You break something? :P
16:04:54 <flo> not me :)
16:05:23 <flo> the bustage comes from mozilla-central and mconley has already pushed the fix
16:07:16 <-- igorko has quit (Ping timeout)
16:09:21 --> wesj has joined #instantbird
16:09:47 * jwir3|away is now known as jwir3
16:16:11 <deomega1> so, every time t iB is launched, it will ask for teh password is masterpassword is enabled?
16:16:39 <flo> sure
16:16:49 <deomega1> that sounds very good
16:17:24 <flo> and if you launch instantbird.exe -P once, you can uncheck the "do not ask at startup" checkbox, and it will ask which profile should be used at each startup
16:18:52 <deomega1> that is very good.  thanks again
16:22:13 * flo has just pushed to comm-beta for the first time
16:23:51 --> myk has joined #instantbird
16:25:04 <wnayes> flo: I was wondering if you could take a look at the importer interfaces sometime (http://hg.instantbird.org/users/wnayes/file/bc1d7d2dab33/chat/components/public/imIImportersService.idl) and see where I need to go from here.
16:28:21 <flo> ah, you prefer the protocolId as a string?
16:28:31 <flo> (I don't mind either way)
16:29:02 <wnayes> would that way just mean I pull the settings info based on that?
16:29:40 <flo> can you rephrase or specify what the 2 "that" in your sentence refer to? :)
16:31:04 <wnayes> I would need to use the protocolId in the ImportedAccount to grab the protocol settings as opposed to including the entire protocol in the interface (this is the part of the interface I'm least familiar with :) )
16:32:42 --> Mook_as has joined #instantbird
16:35:06 <flo> wnayes: so what are the addObserver/removeObserver methods in imIImportersService for?
16:36:06 <flo> I would have put the |in nsIObserver aObserver| as a parameter of void findAccounts()
16:36:23 <-- jb2 has quit (Quit: jb2)
16:36:36 <flo> (that makes the assumption that only one object at once wants to observer the notifications from imIImporterService)
16:37:01 <flo> the alternative is just sending notifications globally through nsIObserversService
16:37:05 <wnayes> I thought that was what you meant by use the nsIObserver interface. I see what you mean though.
16:38:10 <flo> "imported-account-found" the account isn't really "imported" yet, when you send the notification it has just been detected
16:38:23 <flo> what about "existing-account-detected"?
16:38:46 --> Mook_astb has joined #instantbird
16:38:48 <flo> you also definitely need to send back to the UI a notification when all importers have finished detecting accounts
16:38:58 <-- Mook_astb has quit (Quit: Mook_astb)
16:39:42 <Mook_as> hmm, updated thunderbird, and now it won't connect
16:39:46 <wnayes> So the notification comments should be kept and moved above findAccounts()?
16:40:00 --> Mook_astb has joined #instantbird
16:40:11 <flo> Mook_as: error messages?
16:40:20 <flo> wnayes: yeah :)
16:40:20 <Mook_astb> nevermind, it worked :p
16:40:46 <Mook_astb> (it was just Error: Connection closed by server. )
16:40:58 <-- Mook_as has left #instantbird ()
16:41:16 <flo> Mook_astb: freenode?
16:41:18 --> jb has joined #instantbird
16:43:11 <Mook_astb> nope, moznet (this one)
16:43:23 <Mook_astb> you  can tell by the fact that I'm _astb again ;)
16:43:48 * flo doesn't like unfriendly servers that close the connection
16:45:11 * Mook_astb wonders what's with the *** in http://i.minus.com/iPqIb5aIIi6Y7.png
16:45:32 <flo> Mook_astb: I saw that too yesterday. No idea!
16:45:43 <Mook_astb> at least it shows up for every /me
16:45:53 <flo> file a bug? :)
16:46:20 <Mook_astb> hmm. wrong bugzilla account :p
16:47:07 <flo> ok, ok...
16:47:58 <Mook_astb> (and I don't have one for ib @ work anyway, just @bmo)
16:49:07 <flo> Mook_astb: Thunderbird is on BMO :-P
16:49:35 <Mook_astb> right. that's the one with the wrong (@as) bugzilla account :)
16:49:37 <flo> but I'm filing it for you
16:49:45 <Mook_astb> thanks! please CC :mook
16:49:56 <flo> uh, you have a bmo account for _as and one for _home?
16:51:55 <flo> and it seems I'll need to fully recompile my debug Thunderbird before being able to test anything in it :(
16:54:12 <Mook_astb> yeah, I have a personal bmo account, an _as bmo account, and a now-dead songbird bmo account :)
16:54:47 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:54:53 <Mook_astb> (and there's incestuous watching involved across the accounts so I just get multiple mail)
16:55:46 <flo> I considered creating a separate account for my moco-related activities, but it's just easier to have everything under the same account
16:56:07 <flo> that's why I use a @queze.net address rather than @ib.org or @moco.com
16:56:24 <Mook_astb> yeah, for me it was mostly pretending to keep work and personal stuff separate. (obviously, that's not working _that_ well, since I'm in this channel... XD )
16:56:39 <flo> but it's for work reason ;)
16:56:51 <flo> to get better tools ;)
16:58:42 <flo> ah, I managed to make my debug build start
17:04:23 <-- meh has quit (Ping timeout)
17:06:55 <wnayes> flo: I wrote up a summary of how the interfaces would work (to my understanding :)) and included some questions: https://etherpad.mozilla.org/sFWtyY2rXh
17:07:51 <flo> clokep_work: any idea of why test_tryNewNick.js is broken?
17:13:51 * Mook_astb wonders if we'll have Services.* namespace collisions in the future
17:14:34 <flo> Mook_astb: likely!
17:14:43 <flo> do you also abuse it at _as? :)
17:14:51 <-- NmN has quit (Quit: Instantbird 1.1)
17:15:07 <Mook_astb> no, we're mostly window-oriented, so we just have a giant global object (ko.*)
17:15:32 <Mook_astb> it doesn't hurt that most of our code predates jsms, much less Services.* ;)
17:18:02 --> meh has joined #instantbird
17:26:00 <clokep_work> flo: I saw that in #maildev.
17:26:06 <clokep_work> No idea what would make it start failing now...
17:26:15 <clokep_work> I'll take a look at it though. :)
17:26:49 <flo> it fails in Instantbird too, so you won't need a c-c tree ;)
17:27:02 <clokep_work> flo: I have a c-c tree too actually, but good to know.
17:27:08 <clokep_work> I wonder which one fails...hm....
17:27:18 <flo> it's in the build log
17:27:30 <flo> test_tryNewNick.js | null == clokep1
17:28:06 <flo> hmm, I wonder if I could add a local pre-push hg hook to always check that tests work before pushing
17:28:24 <flo> that would suck, but less than having unit tests that don't catch regressions because nobody runs them
17:29:24 <clokep_work> wnayes: I added some comments.
17:30:02 <clokep_work> That would be handy. :) I honestly don't run tests very often. :-[
17:30:15 <flo> I think I knew that already by now ;)
17:30:23 <clokep_work> :(
17:30:34 <clokep_work> How difficult would it be to enable them on our buildbots?
17:30:36 <flo> and you also know that I don't run them either ;)
17:30:47 <flo> clokep_work: we should have to be buildbot slaves that are online when we commit
17:31:07 <clokep_work> What?
17:31:12 <flo> but yeah, I think we should also run the tests before running mack packages for the nightlies
17:31:19 <flo> uh
17:31:32 <flo> *we would have to have buildbot slaves that are online
17:32:10 <clokep_work> Ahhh, I see.
17:33:24 <flo> Mook_astb: I even added a patch for your bug ;)
17:33:39 <Mook_astb> hmm, did the last-read-marker line thing land in tbird? I'm not seeing anything like it
17:33:58 <flo> Mook_astb: I think it did, but it requires changes in mail/ to become visible
17:34:15 <clokep_work> flo: Want to pop onto that ehterpad?
17:34:17 <Mook_astb> ah, that explains it. back to my manually highlighting the last read line :)
17:34:35 <flo> "florian: clokep_work: np" I think Mark has an IRC client whose completion could be improved ;)
17:34:52 <flo> Mook_astb: you really do that?!
17:34:53 * Mook_astb wonders why that screenshot is marked as a patch
17:35:06 <clokep_work> flo: Colloquy 2.3 (4630) - Mac OS X 10.6.8 (Intel) - http://colloquy.info
17:35:06 <Mook_astb> yep!
17:35:07 <flo> because I click that "patch" box too often to even notice
17:35:31 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:35:33 <Mook_astb> actually, s/highlighting/selecting/ is more accurate, but I think you know what I meant
17:35:46 <flo> yeah
17:38:23 <flo> Good evening
17:38:24 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:40:09 <-- jb has quit (Ping timeout)
17:40:23 <-- jb1 has quit (Ping timeout)
17:41:41 <clokep_work> wnayes: Does that make sense?
17:42:02 <wnayes> clokep_work: Yeah, thanks for looking over those questions :)
17:43:47 <clokep_work> I guess it doesn't really matter /too/ much if it's in the UI or the service anyway, it's easy enough to C&P code and move it somewhere else. ;)
17:45:44 <wnayes> The issue with conflicts is that the user would need to decide which account to chose anyways, so I reasoned that the UI would just keep conflicting ImportedAccounts separate but display a way of choosing between them.
17:47:58 <wnayes> "Merge" might have been an incorrect term to use in that case. As I'm seeing it now two similar ImportedAccounts would never be merged but rather chosen between in the UI.
17:49:00 <clokep_work> Hmm....OK.
17:49:11 <clokep_work> Yes that would need to be done by the UI. :)
17:49:54 --> Tomek has joined #instantbird
18:03:47 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:07:16 <-- Optimizer1 has quit (Ping timeout)
18:35:27 --> Mic has joined #instantbird
18:35:27 * ChanServ sets mode +h Mic 
18:40:14 <Mic> Hi
18:40:28 <-- Tomek has quit (Quit: Instantbird 1.1)
18:42:42 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:56:19 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
18:56:24 <-- TestFlie1 has quit (Quit: TestFlie1)
19:29:53 <-- chrisccoulson has quit (Quit: Ex-Chat)
19:36:01 <-- EionRobb has quit (Quit: Leaving.)
19:37:06 --> chrisccoulson has joined #instantbird
19:38:39 --> Lalae has joined #instantbird
19:39:11 <-- Lalae has left #instantbird ()
19:43:59 --> clokep has joined #instantbird
19:43:59 * ChanServ sets mode +o clokep 
19:47:19 --> igorko has joined #instantbird
19:49:01 <-- Suiseiseki has quit (Ping timeout)
19:54:14 --> Optimizer has joined #instantbird
20:00:10 --> Suiseiseki has joined #instantbird
20:05:59 <clokep> Mic: Btw when you have something testable, let me know. :)
20:06:47 --> Mic has joined #instantbird
20:06:47 * ChanServ sets mode +h Mic 
20:08:54 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:09:23 <-- wnayes has quit (Quit: Instantbird - http://www.instantbird.com)
20:14:20 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
20:14:29 --> Mic has joined #instantbird
20:14:29 * ChanServ sets mode +h Mic 
20:15:19 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
20:15:26 --> Mic has joined #instantbird
20:15:26 * ChanServ sets mode +h Mic 
20:16:50 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
20:24:58 <-- igorko has quit (Ping timeout)
20:26:26 --> igorko has joined #instantbird
20:27:20 <instantbot> New Core - IRC bug 1468 filed by clokep@gmail.com.
20:27:22 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1529 on bug 1468.
20:27:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1468 nor, --, ---, clokep, ASSI, Fix failing test from bug 1446
20:34:53 <clokep> Mook_astb: Is there a way to check where AC_CHECK_HEADER is actually checking for a file to be? It's failing in my autoconf script and I swear the file is where it wants it to be. :-D
21:09:44 <-- Optimizer has quit (Ping timeout)
21:13:19 --> Optimizer has joined #instantbird
21:17:24 <-- igorko has quit (Connection reset by peer)
21:19:04 <-- Optimizer has quit (Connection reset by peer)
21:19:09 --> Kaishi has joined #instantbird
21:27:12 <-- myk has quit (Ping timeout)
21:30:44 --> myk has joined #instantbird
21:47:14 --> flo has joined #instantbird
21:47:14 * ChanServ sets mode +qo flo flo 
21:47:59 <flo> clokep: on linux you could easily find out with strace
21:52:34 <clokep> flo: Well, I think I found the issue, I think avahi's glib-malloc.h can't find glib.h (which it includes), but I'm not sure how to tell it where it is...
21:52:43 <clokep> (This is all on *nix btw)
21:53:07 <clokep> (Also, I got my T-shirt. :))
21:54:25 <-- meh has quit (Ping timeout)
21:59:30 <clokep> :-S OK, now it's building fine...
21:59:41 <clokep> Maybe I just needed to fully rm my objdir.
22:00:37 <flo> clokep: do you understand https://bugzilla.mozilla.org/show_bug.cgi?id=758688 ?
22:01:01 <flo> "I got my T-shirt." oh, that was fast! :)
22:01:11 <flo> they fedex'ed it? :)
22:01:25 <flo> which one is it?
22:02:15 <clokep> flo: Yes, they FedExed it. 2 day. I'll take a picture.
22:02:40 <clokep> flo: No, I don't understand that...it's trying to ensure it closes the DB?
22:03:12 <flo> apparently yes
22:03:26 <flo> the code looks good. I just don't really understand why we suddenly need it
22:04:13 <clokep> Hmm....we'll see which Twitter account this uses...
22:04:19 <clokep> Right, I don't either.
22:04:41 <clokep> https://skydrive.live.com/?cid=1b9f013d2e038824&resid=1B9F013D2E038824!142&id=1B9F013D2E038824!142&sff=1 is the shirt I got.
22:05:05 <clokep> (You also get the bonus of seeing part of my kitchen table and part of my coffee table. ;))
22:05:21 <flo> looks good :)
22:05:31 <flo> I hoped I would see some of the watermelon you haven't shared with us ;)
22:05:50 <flo> (just kidding of course :))
22:05:58 <clokep> Hahah. I don't think that would post to Twitter well.
22:06:28 <flo> did they ship it from mountain view?
22:06:38 <flo> (Anne Marie is in Paris obviously)
22:08:14 <clokep> They shipped it from somewhere in CA. The return address is Paul Bogonovich in Mountain View, yes.
22:08:36 <flo> ok :)
22:11:30 <flo> the documentation says "It is illegal to use call this method if any asynchronous statements have been executed on this connection." http://dxr.lanedo.com/mozilla-central/storage/public/mozIStorageConnection.idl.html#l38
22:13:42 <clokep> Do we execute async statements?
22:14:41 <flo> http://lxr.instantbird.org/instantbird/search?string=executeAsync
22:17:11 * clokep takes that as a yes.
22:23:51 <flo> does this comment make sense? "why is this needed at all? I've never seen any documentation saying that it's required to call either close or asyncClose on all connections before shutdown, so I (apparently mistakenly) assumed that connections were closed automatically in a destructor after the JS garbage collector has dropped the last reference to the connection (I would expect that to happen at shutdown when the JS scope were the connection i
22:24:16 <clokep> flo: You got cut off by the IRC limit.
22:24:18 <flo> s/were/where/
22:24:42 <flo> I was surprised I could paste a message that was that long, but it said I still had 22 characters :-S
22:25:02 <flo> "were the connection is held in a global variable is destroyed).""
22:25:09 <clokep> "it said you still had 22 characters"? We have a count somewhere?
22:25:17 <flo> yeah
22:25:27 <clokep> Where?!
22:25:31 <flo> the remaining character count appears in the status bar when less than 200 characters are left
22:25:34 <flo> like for twitter
22:25:59 <clokep> I see...
22:26:03 <clokep> Yes that makes sense.
22:26:13 <clokep> And message lengths are confusing for IRC.
22:26:35 <clokep> It's a max message length of 512 characters...when being sent /out/ and being received.
22:26:45 <clokep> So your send message is "PRIVMSG #instantbird :Blah blah"
22:27:10 <flo> and I suspect it's a mess with UTF8 characters ;)
22:27:22 <clokep> But my received message is "flo@blah!blah PRIVMSG #instantbird :Blah blah"
22:27:26 <flo> ok, I'm posting that comment then; I hope I won't look too much like a fool :)
22:27:40 <clokep> So to fully figure out how many characters are left you need your own full host name + the length of the longest nick in the room.
22:27:55 <clokep> Wait, no. Not the longest nick in the room, the length of the channel name. :)
22:28:12 <clokep> flo: You won't, you're asking for an explanation, perfectly within your rights as a reviewer.
22:30:49 <flo> yeah, counting is difficult...
22:31:26 <flo> that doesn't mean we shouldn't attempt to do it though :)
22:31:31 <clokep> Oh right, and it's bytes, not characters.
22:31:34 <clokep> I agree. :)
22:31:38 <clokep> The API doesn't support it right now. ;)
22:31:51 <flo> the API doesn't support counting for twitter either
22:32:02 <clokep> Ah, true. :(
22:32:06 <flo> as we need to have the actual message to detect urls, ...
22:32:27 <flo> and that's probably even more difficult than counting on IRC ;)
22:32:38 <clokep> True.
22:32:46 <flo> but for IRC, do we really want to count, or just split the long messages?
22:32:55 <clokep> Split, most likely.
22:32:57 <clokep> Do it silently.
22:32:58 <flo> another way our count is wrong on IRC is when the message contains line breaks ;)
22:33:12 <clokep> And err on the side of caution (i.e. if the limit is 512, just split at like 400 or something).
22:33:30 <flo> well, I'm not sure ;). If it's a bit too long, split. If someone pasted a large amount of junk, it's probably a mistake and we shouldn't send
22:33:42 <clokep> No, we should ask if they want to pastebin it. :P
22:33:51 <flo> yeah :)
22:33:56 <flo> pastebin... :)
22:34:17 <clokep> We should also add a filter so if it looks like error console output we auto-pastebin it. :P
22:34:56 <flo> I wonder what attracted the attention of 2 more people in https://bugzilla.mozilla.org/show_bug.cgi?id=756277
22:35:50 <clokep> Does that affect Instantbird too?
22:36:10 <flo> only twitter I think
22:36:25 * clokep is wondering if it should block the Instantbird bug. :P
22:36:54 <flo> would that have more effect than the whole Thunderbird team saying it's an horrible bug? :-D
22:37:11 <clokep> Probably not. :)
22:37:16 * clokep wonders what's next on his todo list...
22:37:39 <clokep> flo: So if I get Bonjour working on both Windows & Linux, would you be able to look at the build bits of it for Mac?
22:37:42 <flo> adding a test for that : set of bugs
22:38:02 <flo> sure (if I don't have to specify when I'll get to it :-/)
22:39:21 <clokep> Hah! Well there's other things with higher priority. :)
22:39:50 <clokep> I ran into an issue though.
22:41:54 <flo> getting our acts together about our testing story will probably be one of my long term priorities
22:44:35 <-- myk has quit (Ping timeout)
22:45:47 <clokep> Yes.
22:45:50 <clokep> I plan to add some more.
22:45:52 <clokep> Anyway, I have to get going.
22:45:57 <clokep> But Linux Bonjour build is going now.
22:46:01 <clokep> Will test it later.
22:46:08 <clokep> Goodnight!
22:46:15 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:01:45 --> myk has joined #instantbird
23:22:24 <-- FeuerFliege has quit (Input/output error)
23:27:04 <-- FireFly_TC has quit (Quit: FireFly_TC)
23:45:19 <-- chrisccoulson has quit (Quit: Ex-Chat)