#instantbird log on 05 22 2012

All times are UTC.

00:02:16 * aleth is now known as aleth-2
00:03:18 <clokep> aleth-2: I think it's a race condition between the boolean pref being set and connecting the account.
00:03:53 <clokep> But I'm not really sure. :(
00:04:21 <aleth-2> It would be great if you have the cause :)
00:04:39 <aleth-2> I've just found another bug in the change nick handling :-S
00:06:19 <aleth-2> Not sure if it's fixable.
00:10:50 <aleth-2> Btw you know how whowas usually returns a sequence of 312/314 pairs? Was it a conscious decision to ignore all but the last one received?
00:12:22 * aleth-2 is now known as aleth-3
00:12:23 <-- myk has quit (Input/output error)
00:12:44 <clokep> aleth-3: I doubt it was.
00:12:59 <aleth-3> Not sure it's worth fixing.
00:13:13 <aleth-3> Should I file a bug just to document the fact?
00:14:03 <clokep> Do you know if that's like an "OK" thing for the server to do based on the RFC?
00:14:05 <clokep> Just file it I guess.
00:15:59 <instantbot> New Instantbird (UI) bug 1456 filed by clokep@gmail.com.
00:16:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1456 nor, --, ---, nobody, NEW, Changing SSL should change the port to the SSL port
00:16:31 <clokep> aleth-3: Shold I not review bug 1446 right now?
00:16:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1446 nor, --, ---, aletheia2, ASSI, Reset nick modified due to nick collision when disconnecting the account
00:17:21 <aleth-3> clokep: You can review what is there, the problem I found is a bit tricky and could be followup.
00:17:38 <clokep> aleth-3: OK. Let me look at it.
00:18:30 <instantbot> New Core - IRC bug 1457 filed by aletheia2@fastmail.fm.
00:18:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1457 min, --, ---, nobody, NEW, Make use of all WHOWAS 312/314 response pairs
00:19:41 <instantbot> clokep@gmail.com requested feedback from the wind for attachment 1506 on bug 1447.
00:19:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1447 nor, --, ---, aletheia2, ASSI, Stop requesting WHOIS information when offline
00:24:45 <instantbot> aletheia2@fastmail.fm denied feedback for attachment 1506 on bug 1447.
00:24:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1447 nor, --, ---, aletheia2, ASSI, Stop requesting WHOIS information when offline
00:25:04 <aleth-3> ^^ not sure whether that should be feedback+ or -
00:25:23 <clokep> Isn't that probably what happens in the Twitter case, etc.?
00:25:30 <clokep> I don't see why we care.
00:25:39 <aleth-3> No, Twitter returns a tooltip I think.
00:26:26 <clokep> Hmmmm...
00:26:45 <aleth-3> Like I said I'm not sure it's an issue, but it needs considering so no later notifications end up in the wrong place.
00:29:11 <clokep> Yeah.
00:30:32 <aleth-3> Of course you could have requestBuddyInfo check for connectedness instead of sendMsg...
00:30:44 <-- FeuerFliege has quit (Ping timeout)
00:31:06 <-- FireFly_TB has quit (Ping timeout)
00:31:51 <aleth-3> Right, I'm filing that nick change bug I found earlier separately.
00:32:53 <clokep> OK!
00:32:59 <clokep> Your current patch looks good I think.
00:33:29 <aleth-3> It has some duplication, but I think moving the message writing around adds even more.
00:33:49 <aleth-3> Especially as not all updateNicks should write a message...
00:33:56 <clokep> By duplication do you mean "code duplication" or duplication as in the same code will get executed multiple times?
00:34:05 <aleth-3> code duplication
00:34:16 <aleth-3> well, for writing messages it would be multiple execution too
00:34:35 --> FeuerFliege has joined #instantbird
00:34:39 --> FireFly_TB has joined #instantbird
00:34:44 <clokep> I'm not so worried about the multiplication, I'm more concerned about keeping the code simple. :)
00:35:03 <aleth-3> If it seems legible to you, then it's OK.
00:35:11 <aleth-3> I agree clarity is the important thing here!
00:36:42 <clokep> OK.
00:36:51 <instantbot> clokep@gmail.com granted review for attachment 1498 on bug 1446.
00:36:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1446 nor, --, ---, aletheia2, ASSI, Reset nick modified due to nick collision when disconnecting the account
00:39:32 <instantbot> New Core - IRC bug 1458 filed by aletheia2@fastmail.fm.
00:39:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1458 min, --, ---, nobody, NEW, DM conversation partner nick change is not reported by the server unless nick is also a participant 
00:40:33 <instantbot> clokep@gmail.com set the Resolution field on bug 1445 to DUPLICATE of bug 1442.
00:40:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1445 nor, --, ---, nobody, RESO DUPLICATE, Messages are cut off before first [Space] on freenode server
00:40:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1442 maj, --, 1.2, clokep, RESO FIXED, IRC messages that need a : for the last parameter broken
00:41:00 <-- BYK has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:41:26 <aleth-3> Thanks for the review! I can show you the WIP I had with moving more of the logic to updateNick if you like, it is uglier (especially for DM conversations).
00:42:03 <clokep> Sure, can you pastebin it (or just attach it to the bug). I'd at least like to see it. :)
00:45:29 <instantbot> New Core - Twitter bug 1459 filed by bugi@media.fjmail.de.
00:45:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1459 nor, --, ---, nobody, NEW, Name of twitter’s log directory is localized
00:48:11 <instantbot> clokep@gmail.com set the Resolution field on bug 1459 to DUPLICATE of bug 1088.
00:48:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1459 nor, --, ---, nobody, RESO DUPLICATE, Name of twitter’s log directory is localized
00:48:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1088 nor, --, 1.2, florian, RESO FIXED, Twitter timeline's normalizedName shouldn't be localized
01:04:30 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
01:11:28 <-- FireFly_TB has quit (Input/output error)
01:12:52 <-- aleth-3 has quit (Input/output error)
01:14:47 --> chrisccoulson has joined #instantbird
01:19:19 <-- Kaishi has quit (Input/output error)
01:30:04 --> Kaishi has joined #instantbird
01:30:58 <-- Kaishi has quit (Quit: Kaishi)
01:32:35 --> Kaishi has joined #instantbird
01:32:57 <-- Kaishi has quit (Quit: Kaishi)
01:33:01 --> Kaishi has joined #instantbird
01:35:07 <-- Kaishi has quit (Quit: Kaishi)
01:35:08 --> Kaishi has joined #instantbird
01:35:48 <-- Kaishi has quit (Quit: Kaishi)
01:35:52 --> Kaishi has joined #instantbird
01:36:53 <-- gpsychosis has quit (Quit: Instantbird 1.1)
01:37:39 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1508 on bug 1454.
01:37:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, clokep, ASSI, normalizedName for JS-IRC is wrong
01:43:40 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
02:53:18 <instant-buildbot> build #504 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/504
03:51:28 --> NmN has joined #instantbird
03:51:56 <-- NmN has quit (Quit: Instantbird 1.1)
04:31:57 <instant-buildbot> build #597 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/597
05:52:58 <-- EionRobb has quit (Quit: Leaving.)
05:53:32 --> EionRobb has joined #instantbird
05:55:13 <-- EionRobb has quit (Ping timeout)
06:02:48 <instant-buildbot> build #490 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/490
06:33:24 --> sanket_ has joined #instantbird
06:33:56 <sanket_> How can I use "libpurple" plugins with instantbird ?
06:37:08 --> Tomek has joined #instantbird
06:38:03 <sanket_> I am testing a plugin which I am currently writing for libpurple (pidgin).
06:46:36 --> meh has joined #instantbird
06:54:07 --> EionRobb has joined #instantbird
06:54:58 <-- Tomek has quit (Quit: Instantbird 1.1)
07:02:32 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
07:04:46 --> meh has joined #instantbird
07:11:47 <-- sanket_ has quit (Ping timeout)
08:01:32 --> jb has joined #instantbird
08:12:33 --> Mic has joined #instantbird
08:12:33 * ChanServ sets mode +h Mic 
08:12:36 <-- Mic has quit (Connection reset by peer)
08:13:00 --> Mic has joined #instantbird
08:13:00 * ChanServ sets mode +h Mic 
08:34:26 <Mic> Hi
08:35:14 <-- gerard-majax has quit (Ping timeout)
08:35:24 <-- jb has quit (Quit: jb)
08:35:54 --> Optimizer has joined #instantbird
08:40:00 <-- harisund has quit (Ping timeout)
08:41:35 --> harisund has joined #instantbird
08:55:40 --> mmkmou has joined #instantbird
08:56:27 <instantbot> benediktp@ymail.com cancelled review?(florian@instantbird .org) for attachment 1500 on bug 1449.
08:56:28 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 1509 on bug 1449.
08:56:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1449 enh, --, ---, benediktp, ASSI, Make initialization state of Core available and send notification when initialization finishes.
09:09:34 --> jb has joined #instantbird
09:13:17 <Optimizer> mic: If I upload the restarless add-on , will it get approved ?
09:14:02 <Mic> I looked at the code you pastebined yesterday and it certainly won't work in an bootstrapped add-on :(
09:14:03 --> FeuerFliege_Daily has joined #instantbird
09:14:10 <-- FeuerFliege_Daily has quit (Client exited)
09:14:28 --> FireFly_TB has joined #instantbird
09:15:03 <Optimizer> no no
09:15:06 <Optimizer> I have changed
09:15:42 <Optimizer> except for the theme, the JS and text modifier gets unloaded on addon disable/uninstall without having to restart IB
09:16:29 --> Even1 has joined #instantbird
09:16:30 <Optimizer> just that due to how IB works, text modifier will continue to work until all the conversation windows are closed
09:16:34 <-- Even1 has quit (Quit: Even1)
09:16:42 --> Even1 has joined #instantbird
09:17:13 --> FeuerFliege has joined #instantbird
09:23:45 <Optimizer> Mic ?
09:26:59 <Mic> I've modified a theme to be restartless and am testing with it.
09:30:07 <-- mmkmou has quit (Ping timeout)
09:31:52 <Optimizer> it will be applies without needing a restart
09:32:09 <Optimizer> but when you remove the addon, it will not get de-aplied
09:32:15 <Optimizer> until you restart IB
09:33:32 --> aleth has joined #instantbird
09:33:32 * ChanServ sets mode +h aleth 
09:33:41 <Mic> You get all sorts of error messags, warnings and info messages on the console if you disable/remove it and start a new conversation/open the preference dialog.
09:33:48 --> mmkmou has joined #instantbird
09:35:53 <Mic> I think it's experimental and you can well upload it as such for people who like to try it/play around with it but for something that I'd review to become public, I'd stick with a non-restartless one until we fixed the existing problems.
09:38:09 <Optimizer> well then I am happy with it being restartless
09:38:28 <Optimizer> so I will leave the non restartless version as is on AIO
09:41:38 <Mic> OK, just send a review request then
09:49:15 <-- mmkmou has quit (Client exited)
09:50:32 --> mmkmou has joined #instantbird
09:55:38 --> Lalae has joined #instantbird
09:55:45 --> flo has joined #instantbird
09:55:45 * ChanServ sets mode +qo flo flo 
09:55:56 <-- Lalae has left #instantbird ()
10:00:12 <Optimizer> Mic: done!
10:12:51 <instantbot> aletheia2@fastmail.fm granted review for attachment 1508 on bug 1454.
10:12:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, clokep, ASSI, normalizedName for JS-IRC is wrong
10:18:39 --> clokep has joined #instantbird
10:18:39 * ChanServ sets mode +o clokep 
10:19:07 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:21:38 <instantbot> aletheia2@fastmail.fm denied review for attachment 1508 on bug 1454.
10:21:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, clokep, ASSI, normalizedName for JS-IRC is wrong
10:24:24 <-- FireFly_TB has quit (Ping timeout)
10:24:24 <-- FeuerFliege has quit (Ping timeout)
10:31:34 <-- skeledrew has quit (Ping timeout)
10:32:11 --> skeledrew has joined #instantbird
10:33:46 --> gerard-majax has joined #instantbird
10:39:25 <-- EionRobb has quit (Quit: Leaving.)
10:39:42 --> EionRobb has joined #instantbird
10:41:12 --> sonny has joined #instantbird
10:41:19 <clokep> aleth: Why was that an r-? Because the comment was missing or for whatever was w/ the tooltip?
10:43:24 <aleth> The requestBuddyInfo calls from outside JS-IRC itself need checking (and possibly changing), and for the comments. I get the impression it's worth sorting out and documenting the normalize... usage. Not really a proper r- (I first r+'d it)
10:43:51 <clokep> OK.
10:43:57 <clokep> I think most of the usages /do/ have comments, I just failed to read them.
10:44:44 <aleth> Maybe it would be helpful not just to have a comment next to each definition, but also a compare-and-contrast list somewhere. Since this seems to come up fairly often.
10:45:15 <aleth> Not sure where that would best go though...
10:49:24 <clokep> I don't know why most of those are "normalized" unfortunately. :( I'll need input from flo.
10:50:21 <aleth> There was something to do with XMPP I think as well, and of course fixing bug 1434 might also change things somewhere along the line
10:50:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1434 nor, --, ---, nobody, NEW, Adding two buddies with the same nick, but on different IRC accounts leads to strange behaviour
10:50:52 <aleth> Not sure if that will intersect the "normalized" names.
10:57:00 <clokep> Right.
10:57:05 <clokep> These bugs aren't fun to debug though. :(
10:57:10 <clokep> Anyway I need to go.
10:57:10 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:59:38 <-- chrisccoulson has quit (Quit: Ex-Chat)
11:00:47 <aleth> Definitely not fun :-/
11:00:56 <aleth> Though I think the lack of documentation is part of that.
11:03:33 --> chrisccoulson has joined #instantbird
11:09:14 <flo> aleth: I suspect the lack of documentation is mostly that we inherited libpurple behaviors instead of designing something for ourselves
11:09:30 <GeekShadow> flo: it was Nicolas Brimbeuf who worked on IB comete project ?
11:09:53 <flo> GeekShadow: that's possible, why?
11:13:00 <flo> GeekShadow: yes (I've just checked in my emails)
11:16:50 <GeekShadow> ok, no I was wondering if it was the guy you talk about some months ago, he is supposed to work now on a Nightingale project
11:17:36 <flo> "supposed to" seems accurate, if he hasn't change is methods ;)
11:17:42 <flo> *changed
11:34:56 <flo> uh, bug 1455!
11:35:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1455 maj, --, ---, nobody, NEW, Instantbird with fresh profile hangs on attempting to add IRC account
11:35:09 <flo> the behavior is the same as https://bugzilla.mozilla.org/show_bug.cgi?id=735688
11:35:50 <flo> it seems the connection is killed when closing the account wizard
11:38:49 <flo> this is what I see in my terminal: http://pastebin.instantbird.com/43146
11:39:19 <aleth> Interesting. I was wondering if it wasn't connecting "too early" (otherwise why does _connectionInfoChanged get called)
11:39:22 <flo> I don't understand yet why we send a "QUIT" on the socket before the domain name has even been resolved though
11:40:13 <aleth> Huh. That's odd.
11:40:15 <flo> and apparently we receive a bogus onStopRequest call (line 90) when the window is closed (line 92)
11:40:44 <flo> but the socket isn't actually closed, and we receive later a Ping Timeout from the server (line 95)
11:41:09 <flo> crazy behavior...
11:41:39 <flo> also, the same account seems to be dealing with 2 sockets / connections at once
11:42:26 <flo> see lines 25-27 duplicated with lines 30-32
11:45:19 <flo> aleth: by the way, I can't reproduce the hang on Mac
11:45:41 <flo> but I'm ok with assuming it's caused by the 2 sockets mixed with each other
11:50:34 <flo> hmm, apparently it's the day for debugging strange bugs. My debug Thunderbird with an empty profile doesn't even want to show me the "Chat" tab
11:52:45 <-- Mic has quit (Ping timeout)
11:53:06 <flo> well, the profile is named "empty" but doesn't seem that empty after looking at its content :)
11:54:37 --> clokep_work has joined #instantbird
11:54:37 * ChanServ sets mode +o clokep_work 
11:57:59 <clokep_work> Haha flo, I did that yesterday. (I have a profile named "clean" that apparently had a half dozen or so accounts in it, plus a bunch of extensions installed.)
11:58:12 <clokep_work> Took me a while to figure out why closing the window kept minimizing to the taskbar. ;)
11:58:27 <flo> so it seems I found a real gloda bug
11:59:42 <flo> my Thunderbird has a half broken startup, and the very first exception I catch (out of almost a dozen) is "aDBFile is not defined" at http://mxr.mozilla.org/comm-central/source/mailnews/db/gloda/modules/datastore.js#1452
12:01:13 --> Mic has joined #instantbird
12:01:13 * ChanServ sets mode +h Mic 
12:02:41 <flo> seems https://bugzilla.mozilla.org/show_bug.cgi?id=754780
12:08:21 <-- Optimizer has quit (Ping timeout)
12:09:33 <aleth> flo: Hopefully at least it is getting a little clearer what is causing the various mysterious problems
12:11:27 --> Tomek has joined #instantbird
12:13:05 --> Optimizer has joined #instantbird
12:20:02 --> deomega1 has joined #instantbird
12:20:25 <deomega1> good morning.    I am having that problem again regarding  my contacts beng missing
12:20:39 <deomega1> Timestamp: 5/22/2012 7:13:26 AM
12:20:39 <deomega1> Error: contactElt.destroy is not a function
12:20:39 <deomega1> Source File: chrome://instantbird/content/group.xml
12:20:39 <deomega1> Line: 292
12:21:53 <flo> do you know easy steps to reproduce this error?
12:22:01 <flo> (hello :))
12:22:32 <deomega1> hi..   
12:23:13 <deomega1> I do not even know.. I  have been noticing ths issue since I started using  the  2 step google login option
12:23:35 <flo> do you have add-ons that could be changing things to the contact list window?
12:23:38 <deomega1> where yu have to generate a code for each program that will be  connecting to your account
12:24:22 <deomega1> hmm, the only addon that I have added that is new is  cloke's  prioritize
12:24:27 <flo> do you have the add-on to sort contacts by status rather than by name?
12:24:35 <deomega1> yes
12:24:37 <deomega1> yes
12:24:51 <deomega1> hmmm
12:24:57 <flo> the error you have is at http://lxr.instantbird.org/instantbird/source/instantbird/content/group.xml#292
12:25:10 <flo> it seems related to sorting contacts
12:25:29 <flo> clokep_work: you may want to look at that lxr link to see if you can guess an obvious cause :)
12:25:34 <-- Optimizer has quit (Ping timeout)
12:26:10 <deomega1> that is teh cause for real per this  code i am seeing
12:26:44 <deomega1> ..
12:26:46 <deomega1> sorry
12:26:59 <flo> deomega1: I would suggest you disable that add-on to see if the problem disappears
12:27:19 <deomega1>  let order = aContactB.statusType - aContactA.statusType;
12:27:23 <deomega1> that line was highlighted
12:27:27 <deomega1> yes, i will do that
12:27:56 <flo> so that line was highlighted for another error?
12:28:04 <flo> can we have that error message too? :)
12:28:34 <deomega1> http://pastebin.com/a1fbFpg9
12:28:42 <clokep_work> flo: I don't see any obvious cause...my addon doesn't really touch that stuff, just overwrites the sort method and the observer.
12:28:59 <clokep_work> Can we use pastebin.instantbird.org? I can't get on pastebin here.
12:29:02 --> Optimizer has joined #instantbird
12:29:43 <clokep_work> (PS My code is at https://bitbucket.org/clokep/sort-by-status/src/tip/ if someone wants to check it out)
12:30:23 <flo> clokep_work: the error is Error: aContactB is undefined Source File: chrome://sortbystatus/content/group.xml Line: 27
12:30:37 <flo> that feels familiar, although we never identified the cause :(
12:31:07 <deomega1> http://pastebin.instantbird.com/43153
12:31:27 <deomega1> the ======== i placed to separate teh entries
12:31:31 <deomega1> i need to restart it
12:32:08 <deomega1> the last two entries are the same, i just decided to enter the full one  at the end
12:32:46 <clokep_work> flo: Yes, we've randomly seen that. :(
12:32:54 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:33:12 --> deomega1 has joined #instantbird
12:33:23 <deomega1> that resolved it... disabling the addon
12:33:43 <-- Optimizer has quit (Ping timeout)
12:33:50 <clokep_work> The add-on actually doesn't have anything to do with that error though, if the contact element doesn't exist the standard sorting algorithm will fail too.
12:33:58 <deomega1> and i restarted a number of times and it did not fix..  but doing so after disabling teh addon has fixed it
12:34:03 <clokep_work> Unless it's because I'm sorting under a different condition.
12:34:20 <clokep_work> (But if so, then there's something funky with the way we remove contacts and stuff, I'd think.)
12:34:43 <deomega1> i will restart again  without teh adon and see what happens
12:34:49 <deomega1> then  enable teh addon and restart and see
12:34:52 <flo> clokep_work: there definitely is something wrong in the way we remove contacts
12:35:01 <flo> clokep_work: but I don't have steps to reproduce
12:35:14 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:35:18 <clokep_work> deomega1: Isn't the add-on restartless? ;)
12:35:27 <clokep_work> flo: Yes, me neither. :(
12:35:32 <flo> I just sometimes see after switching my status to offline that some groups don't disappear (and when closing them, typically (1) appears)
12:35:38 <aleth> Is this code right? http://lxr.instantbird.org/instantbird/source/instantbird/content/group.xml#291
12:35:51 <aleth> Should destroy() be called in that case?
12:35:56 --> deomega1 has joined #instantbird
12:36:05 <flo> why not?
12:36:08 <deomega1> i hate to say it but it seems to definitely be teh addon
12:36:08 <aleth> i.e. if we have just set collapsed, shouldn't we not call destroy?
12:36:28 <flo> destroy() is removing the observers
12:36:42 <deomega1> i  did what i stated above and  the problem   reappeared when teh addon was enabled
12:36:52 <aleth> OK
12:37:02 <flo> after we have started the collapse animation, it's too late to reuse that <contact> element even if the contact comes back online
12:37:34 <flo> aleth: wait, I'm wondering if you haven't just found the issue
12:37:35 --> Optimizer has joined #instantbird
12:37:55 <flo> clokep_work: could it be that sorting fail if there are currently-collapsing contacts?
12:38:20 <flo> hmm, that wouldn't explain why I often have this error in a closed group :-S
12:38:37 <aleth> Because there is no return after removeChild?
12:38:50 <deomega1> please acknowledge if you guys are finished with me, so i can move on .  thanks
12:38:54 <aleth> (Not sure if there should be one)
12:39:32 <flo> aleth: shouldn't it fail all the time if the problem was that obvious?
12:39:33 <deomega1> i do not want to set up my layout if i have to restart again
12:39:40 <aleth> deomega1: Thanks for reporting this!
12:39:57 <deomega1> ok, great.  Thanks guys.
12:40:06 <deomega1> have a great one
12:40:24 <flo> deomega1: thanks for reporting the errors! :)
12:40:50 <aleth> flo: Probably. I don't know that code, so I can just go hmm
12:41:51 <deomega1> lol.. i was not really looking for  cheers lol.. just wanted to make sure you did not want me to do any further steps before I do my layout.  You are welcome :)
12:41:55 <clokep_work> That code confuses me a lot every time I look at it. :(
12:42:21 <aleth> Ignoring collapsed or collapsing contacts for sort purposes might help though (rather than index +- 1)
12:42:24 <flo> yeah, it's horrible :(
12:44:14 <aleth> No, I'm just also confused by it I think.
12:45:12 <flo> so connecting a freenode ssl IRC account on Thunderbird freezes it
12:53:31 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:53:43 --> FireFly_TB has joined #instantbird
12:55:00 <flo> so, after killing Thunderbird and restarting it, the account manager opens with the message saying it has disabled auto-login because the previous attempt crashed
12:55:09 <flo> if I click "connect now", Tb freezes again
12:55:11 <flo> I attached gdb
12:55:34 <-- FireFly_TB has quit (Ping timeout)
12:55:41 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:56:06 <flo> the gdb stack looks like this: http://pastebin.instantbird.com/43154
12:56:42 <-- Mic has quit (Connection reset by peer)
12:57:18 <clokep_work> aleth: normalize on the ircAccount has nothing to do with that bug. :-S and getNormalizedChatBuddyName is a different bug.
12:58:14 <aleth> clokep_work: I know it has nothing to do with it, but a list of "normalize*" items should include it I think for future users that do not know.
12:58:46 <clokep_work> I'm confused at what this list is that you're talking about, I was planning to just add comments to the code in the idl files.
12:59:07 <flo> clokep_work: so it seems that socket.isAlive is blocking for SSL sockets :S
12:59:24 <aleth> I think it would be helpful to also list the lot of them (maybe on the wiki if not in the code) to differentiate what they are for all in one place.
13:00:01 <aleth> Just to have less confusion in the future.
13:01:10 <aleth> But yes, it's beyond the scope of that bug.
13:02:00 <clokep_work> Ah, OK. I must have misunderstood that from what I read then.
13:02:13 <clokep_work> Yes, documenting would be nice, I suppose.
13:02:31 <clokep_work> First I'd like to figure out what they do. :-D
13:03:07 <clokep_work> flo: Blocking as in it actually sends data over the wire to check whether the connection is still alive? :(
13:03:23 <flo> Blocking as in we don't return to the UI thread at all.
13:03:39 <clokep_work> (O_o)
13:03:43 <flo> what I don't understand is why after a second restart it doesn't block
13:04:00 <flo> it's probably blocking only during some steps of the SSL handshake :-S
13:05:35 <-- meh has quit (Ping timeout)
13:05:39 <clokep_work> flo: We can stop using it and keep track of a connect variable, which we manually shake back and forth.
13:07:48 <flo> so my account connected fine
13:07:52 <flo> I clicked "disconnect"
13:07:55 <flo> and then "reconnect"
13:08:19 <flo> and it fail with the error message "A crash occurred whiel connecting this account." :(
13:09:23 <flo> the real reason of the failed reconnection is the usual "Connection reset." on freenode SSL
13:10:58 <clokep_work> Bah.
13:18:30 <clokep_work> I don't suppose you see any easy fix? :-D
13:19:55 <flo> I'm still completely confused by what's happening 
13:20:16 <flo> the hang (caused by isAlive at an unfortunate time) seems completely unrelated to the other errors
13:23:34 <flo> clokep_work: it seems the freenode ssl issue doesn't happen when connecting another freenode SSL account?
13:24:23 <clokep_work> flo: I've seen it not happen with some accounts / servers, yes.
13:26:10 <flo> another super confusing log when connecting a new IRC account (exactly the same configuration as the previous one: same nick, same port, etc...) http://pastebin.instantbird.com/43159
13:26:49 <flo> line 136 is great "Failed to convert NICK :toto from Unicode to UTF-8."
13:27:55 <flo> and then it sends "NICK :Guest47956" is 47956 a random number?
13:28:20 <clokep_work> Where do you see that?
13:28:34 <flo> line 191
13:29:00 <clokep_work> Uhhh...I don't think we have code to try a random number.
13:29:13 <clokep_work> Is it possible that we received from freenode to use that? :-S
13:29:27 <aleth> The freenode version of IRCMonkey?
13:29:27 <flo> we don't even have the word "Guest" in our code
13:30:14 <flo> maybe
13:30:27 <flo> but I don't see any logged message indicating we received a string containing "Guest"
13:33:00 <clokep_work> Right, that's why I'm confused.
13:33:15 <clokep_work> (Unless the isAlive call is blocking and we receive it, but it's not logged, is that possible?)
13:33:20 <flo> everything seems confusing today
13:33:28 <flo> clokep_work: no :)
13:33:53 <flo> maybe I'll wake up tomorrow and discover that all the confusing bugs have been fixed overnight? :)
13:33:57 <clokep_work> Was just hoping. :)
13:34:06 <-- Optimizer has quit (Ping timeout)
13:34:19 <clokep_work> I'm not even sure where to start debugging this stuff. :-S
13:34:50 <flo> I'm not sure yet how many different bugs I'm dealing with
13:35:11 <flo> so let's assume the hang is specific to using SSL
13:35:23 <flo> I should see the strange disconnect calls even with non-SSL, right? :)
13:36:23 <flo> bah, without SSL it connected fine :(
13:37:28 --> Optimizer has joined #instantbird
13:43:29 <aleth> Yes, GuestXXX on freenode appears to be like IRCMonkeyXXX on mozilla. Just as puzzled about where it was sent/received though.
13:48:21 <aleth> Something must have changed this._nickname before a (second) _connectionRegistration call happens.
13:48:39 <flo> so something seems wrong in http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#352
13:52:44 <flo> ah, my dear Thunderbird is frozen again :)
13:53:40 <clokep_work> I had some trouble following the logic in that function. :(
13:54:55 <-- Kaishi has quit (Quit: Kaishi)
13:55:01 <flo> I wonder if it should return early if this.firstConnectionState == Ci.imIAccount.FIRST_CONNECTION_UNKNOWN
13:55:16 <flo> clokep_work: which part is difficult?
13:55:39 <flo> It took me a few seconds to remember why that executeSoon is here, but it's relatively straight forward
13:56:16 <flo> (still, I think it should become a common practice to require a comment explaining why an executeSoon/setTimeout is needed during reviews)
13:56:51 <clokep_work> Yes. :) I was just confused as to where _pendingReconnectForConnectionInfoChange could be set.  I think I found it when I had looked though.
13:56:52 <aleth> Why is it there?
13:57:21 <flo> aleth: to ensure that we are calling the code only once when  several settings are changed at once
13:57:36 <flo> aleth: and waiting for all the changes to be applied before attempting to connect with new settings
13:57:59 <flo> like you know, if you want to check an "SSL" checkbox, and change a port number, that's 2 settings that are changed at once ;)
13:58:07 <aleth> Is the issue then that we try to connect before all settings are loaded?
13:58:42 <flo> aleth: I think that code should just never be called for new accounts
13:58:45 --> jb1 has joined #instantbird
13:58:46 <aleth> And then something goes wrong, leaving 2 sockets behind
13:59:16 <-- jb has quit (Ping timeout)
13:59:42 <flo> I don't know yet why we have the error message twice
13:59:50 <flo> but at least we know why disconnect() are called when it shouldn't be
14:00:57 <flo> maybe the second one is because I close the account wizard window? :-S
14:08:21 <-- aleth has quit (Input/output error)
14:08:41 --> aleth has joined #instantbird
14:08:42 * ChanServ sets mode +h aleth 
14:10:12 --> mmkmou has joined #instantbird
14:32:57 <clokep_work> Hmm...I should fix up my Instantbird bot framework and see if it's actually capable of running a bot like instantbot.
14:33:02 * clokep_work wants more hours in a day.
14:36:14 <flo> so our freeze is https://bugzilla.mozilla.org/show_bug.cgi?id=711786
14:36:34 <-- Optimizer has quit (Ping timeout)
14:38:59 <clokep_work> :(
14:39:08 <clokep_work> So the fix is to...not call that method? :P
14:39:32 <flo> or to apply the patch that's been collecting dust in https://bugzilla.mozilla.org/show_bug.cgi?id=711787 for 6 months
14:40:35 <clokep_work> Ah-ha, that would work too.
14:40:46 --> Optimizer has joined #instantbird
14:41:02 <clokep_work> But Thunderbird probably can't do that?
14:46:36 <flo> I commented in the bug
14:46:39 <flo> let's see what happens ^^
14:47:12 <clokep_work> flo: I think your second link there is wrong? It's the same as the one above it.
14:48:13 <flo> right, thanks!
14:56:33 <-- Optimizer has quit (Ping timeout)
14:56:46 <clokep_work> :) Hopefully someone cares hah
15:00:12 --> Optimizer has joined #instantbird
15:01:42 * clokep_work wonders if we could use https://bugzilla.mozilla.org/show_bug.cgi?id=757448 as well once on Mozilla 15 or whatever trunk is.
15:02:37 <-- EionRobb has quit (Ping timeout)
15:05:13 --> wnayes has joined #instantbird
15:12:31 --> FireFly_TB has joined #instantbird
15:16:55 <wnayes> Yesterday I wrote up a portion of my website for my project, which will have some useful links: http://www.tc.umn.edu/~nayes006/gsoc2012/index.php
15:17:40 <wnayes> I also modified the planned file changes since our discussion: http://www.tc.umn.edu/~nayes006/gsoc2012/files/codeChanges.txt
15:17:52 <clokep_work> wnayes: You make pretty websites. :P
15:19:15 <clokep_work> (The project source code link is wrong though?)
15:19:38 <wnayes> clokep_work: It hasn't been set up yet to my knowledge, just a placeholder so far.
15:19:50 <clokep_work> OK. :) Just making sure.
15:21:14 <clokep_work> wnayes: The updated file list looks pretty good. I also wonder if each one needs a Makefile.in, but that's not really important to add on there.
15:22:15 <flo> clokep_work: why not? (re: background updates)
15:23:01 <clokep_work> flo: Looks like it will, there's some UI changes too, didn't look at those.
15:24:54 <clokep_work> So do you know what's up next wnayes or were you looking for more guidance?
15:25:25 <-- FireFly_TB has quit (Ping timeout)
15:28:04 <wnayes> clokep_work: I would take suggestions :) Not sure what the best place to start would be.
15:29:58 <clokep_work> wnayes: Haha, well it looks like you mostly have an outline. :)
15:31:55 <clokep_work> (outline of the code changes that is).
15:32:34 <clokep_work> So maybe thinking about the types of information that can be retrieved and how they fit into Instantbird, etc.
15:32:48 <-- wesj has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:32:52 <clokep_work> Or the interface of what each importer needs to implement (but you probably need to knwo what information is there first :))
15:32:52 --> wesj has joined #instantbird
15:35:22 <wnayes> clokep_work: I think the first version of the importer will support accounts only, making things easier. Working on the interface would be a good idea though.
15:35:56 <flo> there are still lots of possible things to import for "accounts only"
15:36:04 <clokep_work> wnayes: OK, but it's probably worth looking at what can be imported to make sure you don't paint yourself into a corner.
15:36:07 <flo> the username + password are the obvious ones
15:36:16 <clokep_work> And yes, I meant more specifically than "accounts". :) As flo is suggesting.
15:36:20 <flo> but there could also be "is the account configured to connect automatically when the application starts?"
15:36:26 <flo> + all the protocol specific settings
15:41:01 <wnayes> For a client importer, each client can have many accounts/protocols. Is there a way this could be shared between the importers?
15:41:51 <wnayes> The definitions of what each protocol has for settings, etc.?
15:41:52 <clokep_work> I'm not sure of your question, can you reword it?
15:42:12 <clokep_work> Ah, well the importer can probably return an array of protocols.
15:42:29 <clokep_work> And each protocol defines itself what settings and such it can have.
15:42:37 <flo> should things be asynchronous, so that we can probe for different clients at once?
15:42:39 <clokep_work> Let me give you an example...
15:42:52 <flo> with each importer working from a different thread?
15:42:59 <clokep_work> That would be nice flo.
15:43:09 <clokep_work> wnayes: For IRC (JS account options are a lot easier to view...): http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#1100
15:43:25 <flo> if we want to do something like that, the importer wouldn't return accounts, but notify the main import component that an account has been found
15:44:21 <clokep_work> And could potentially just notify multiple times?
15:45:11 <wnayes> flo: That sounds like a good way to approach it
15:47:59 <flo> you may not want to both with the threads at first, but keep the idea of the importers notifying each time they have found an account
15:48:02 <flo> *bother
15:49:04 <flo> I hesitate for the hg repository between hg.instantbird.org/users/wnayes hg.instantbird.org/wnayes hg.instantbird.org/accountimport or something else
15:50:20 <clokep_work> users/wnayes sounds reasonable to me.
15:50:47 <wnayes> flo: user/wnayes works for me, any of those are fine :)
15:52:01 --> sanket_ has joined #instantbird
15:52:25 <-- Optimizer has quit (Ping timeout)
15:54:06 <-- gerard-majax has quit (Ping timeout)
15:54:08 --> Optimizer has joined #instantbird
16:01:50 --> myk has joined #instantbird
16:17:10 --> BYK has joined #instantbird
16:18:48 <-- Tomek has quit (Client exited)
16:20:42 --> meh has joined #instantbird
16:25:04 <-- BYK has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:25:15 <sonny> what is IRC server password ?
16:25:20 --> BYK has joined #instantbird
16:25:47 <clokep_work> sonny: What do you mean?
16:25:57 <clokep_work> Are you asking from a technical point or a UI point or?
16:26:07 <clokep_work> (technical meaning "protocol")
16:26:32 <sonny> technical
16:27:10 <clokep_work> The password field provided by Instantbird gets sent as part of the PASS command, which is usually used as a password to get into the server. Some networks (Freenode, Moznet, etc.) don't have a password so they forward the PASS command to NickServ for authentication.
16:28:09 <sonny> ah ok
16:28:16 <clokep_work> (And the PASS command I think is simply "PASS <password>".)
16:28:18 <clokep_work> Why do you ask?
16:28:23 <sonny> I'm trying to use the grove.io service from IB
16:29:11 <clokep_work> Is it not working? :)
16:29:33 <sonny> I can't join the channels
16:30:11 <-- BYK has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:30:22 <clokep_work> You can turn the logging level up to see what's being sent over the wire.
16:30:44 <sonny> yeah
16:30:51 <sonny> I don't know the IRC protocol at all
16:31:24 <clokep_work> purple.debug.loglevel=1 or 2 should do it.
16:31:37 <clokep_work> It's fairly simple, but if you pastebin a couple of things I can see what's up.
16:32:22 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:32:38 --> sonny has joined #instantbird
16:32:44 <clokep_work> I'm assuming you followed the directions at https://grove.io/help/irc/setup though?
16:32:59 <clokep_work> So you'd put your organization name as the password and have to manually authenticate after you log in.
16:33:52 <sonny> yes
16:38:09 <-- Suiseiseki has quit (Ping timeout)
16:39:16 <sonny> OK, SSL is required but doesn't works within IB
16:39:54 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:39:58 --> sonny has joined #instantbird
16:40:17 <clokep_work> Is their cert invalid?
16:41:23 <-- flo has quit (Ping timeout)
16:41:27 --> flo has joined #instantbird
16:41:27 * ChanServ sets mode +qo flo flo 
16:44:12 <clokep_work> sonny: If their cert is invalid we reject it right now (rather ugly, but the UI hasn't been fixed...)
16:44:28 <clokep_work> You can disable cert checking though via a pref (I forget the exact name, but I can check it...)
16:44:35 <sonny> already disabled
16:45:14 <clokep_work> Can't say I know what's going on then. :( You're on the right port I assume?
16:45:21 <sonny> yeah
16:45:28 <sonny> 6697
16:45:39 --> Tomek has joined #instantbird
16:45:51 <clokep_work> Out of ideas then, sorry.
16:45:53 <sonny> clokep_work: as far as I'm concerned, it doesn't really matter and I won't have the time to debug
16:46:04 <sonny> clokep_work: no problem, thanks
16:46:12 <clokep_work> sonny: Fair enough. Curious WTF they're doing. Maybe I'll check it out later.
16:47:27 <aleth> sonny: Can you log in with SSL and then use /msg NickServ ... to identify yourself?
16:47:37 <aleth> Or does it fail to connect?
16:51:30 <sonny> it fail to connected
16:51:45 <aleth> :(
16:52:36 <flo> "You can disable cert checking though via a pref " only for libpurple sockets, right? ;)
16:56:23 <-- Tomek has quit (Ping timeout)
16:58:42 <clokep_work> flo: Doh. You're right. :-D
17:02:46 --> Kaishi has joined #instantbird
17:11:36 --> Tomek has joined #instantbird
17:14:53 --> Suiseiseki has joined #instantbird
17:15:51 <-- Tomek has quit (Ping timeout)
17:18:33 <clokep_work> We should really fix tat though. :( I wonder how hard it would be to make the UI pop up to import the cert...
17:19:31 <flo> yeah, it's nice that you are volunteering to do it :)
17:21:20 <clokep_work> flo: I'm thinking about looking into it tonight now. :P
17:22:01 <flo> the SSL thing? really?
17:22:21 <clokep_work> What?
17:22:27 <clokep_work> No.
17:22:34 <clokep_work> The UI pop up for certs.
17:22:46 <flo> for SSL certs :)
17:22:51 <clokep_work> Yes.
17:22:56 <clokep_work> Why "really?"?
17:23:12 <sanket_> I had a small ques, can I run libpurple plugins (essential C files build from pidgin tree) into instantbird.
17:23:16 <flo> because the APIs for it are crazy
17:23:35 <clokep_work> sanket_: No, it's API compatible, but not ABI compatible.
17:23:38 <flo> sanket_: no, you have to put the source code files in instantbird's source code tree and build them from Instantbird
17:23:58 <clokep_work> flo: I think I saw a good example of it in c-c somewhere though...
17:24:01 <sanket_> Ah, ok. I have been working on this statistics collector plugin recently.
17:24:06 <clokep_work> (Maybe in the account provisioner code?)
17:24:18 <clokep_work> sanket_: Ah, is that a libpurple plug-in or a pidgin plugin?
17:24:20 <sanket_> (for pidgin/gsoc), and was wondering if a port to instantbird might work :-)
17:24:32 <sanket_> libpurple, that's why I bugged you guys :-)
17:24:39 <flo> sanket_: ah, what I said was only for libpurple protocol plugins
17:24:50 <clokep_work> Yes, EionRobb has been telling us about it.
17:24:52 <sanket_> Yep, it's not a prpl-plugin.
17:25:01 <clokep_work> Yeah, we only support protocol plugins. :(
17:25:02 <flo> sanket_: we also support non-libpurple protocol plugins, so a libpurple plugins wouldn't access all of them
17:25:20 <clokep_work> Wait, we do?
17:26:01 <flo> wnayes: http://hg.instantbird.org/users/wnayes/
17:26:03 <flo> does this seem ok?
17:26:14 <sanket_> flo, if I am getting you right your apprehension is that my plugin might *not* be able to collect all info, or I got you wrong ?
17:26:46 --> Lalae has joined #instantbird
17:27:02 --> gpsychosis has joined #instantbird
17:27:40 <flo> sanket_: you won't be able to collect all info, you possibly will want to use libpurple APIs that we don't offer (or have butchered, to reuse EionRobb's term ;)), and installing binary plugins is generally a pain
17:27:41 <sanket_> It'll be nice if we could know how many people are using instantbird/pidgin/finch/adium :-)
17:28:08 <sanket_> I'll take it as a no, lol :-)
17:28:20 <clokep_work> sanket_: Yes, it would. If the API to the website is easy enough we could probably trivially write an Instantbird extension to interact w/ it.
17:28:21 <flo> clokep_work: http://ftp.instantbird.com/instantbird/stats/
17:28:32 <clokep_work> (I assume you're sending XML or JSON or something...)
17:28:39 * clokep_work hopes for JSON.
17:28:41 <sanket_> Yep. XML.
17:29:01 <sanket_> Pidgin has extensive support for XML, prefs etc.
17:29:02 <flo> clokep_work: XML may be easier in a libpurple context
17:29:03 <clokep_work> flo: What am I looking at?
17:29:14 <clokep_work> flo: Yeah, I know. but JSON is just nicer. :-D
17:29:16 <flo> clokep_work: sorry, I wanted to send that link to sanket_
17:29:35 <clokep_work> flo: Sounds like a bug in the tab complete code: "Doesn't read my mind."
17:29:50 <sanket_> flo, what am I looking at ?
17:29:57 <-- Lalae has quit (Ping timeout)
17:30:29 <clokep_work> sanket_: It's unique update pings from Instantbird.
17:30:45 <clokep_work> I understand you're getting much more specific statistics though. :)
17:31:01 <sanket_> Unique, interesting. How do you define ``unique'' ?
17:31:23 <sanket_> A client contributes once, even if it updates 'n' times ?
17:31:41 <clokep_work> Uhhh...it's probably not really "unique", it should be close to unique /daily/ though.
17:31:49 --> Lalae has joined #instantbird
17:31:54 <clokep_work> It's just the hits from the apache log I think.
17:32:04 <clokep_work> So how many times have peopled checked for updates per day.
17:32:23 --> Tomek has joined #instantbird
17:32:35 <sanket_> For the interested, this is what I have managed to come up till now: http://pastebin.com/pH3DqsPY
17:32:38 <flo> sanket_: an installed client contributes at most once everyday
17:33:05 <flo> forced update checks (with the "Check for updates" menu item) aren't counted for the stats
17:33:20 * clokep_work will read that later.
17:33:37 <sanket_> But a rogue client could always create havoc, but I see that's not an issue with stats-collection engines.
17:33:54 <wnayes> flo: Thanks for getting that set up :)
17:34:11 <flo> wnayes: no problem
17:34:16 <flo> I hope everything works right :)
17:34:26 <clokep_work> sanket_: Do you have a blog or anything you'll be putting information up on?
17:34:26 <flo> I've got to go, I should be back online in the evening
17:34:30 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:35:51 <sanket_> http://www.sanketagarwal.com/blog/?cat=7
17:36:07 <clokep_work> Cool. I'll add it to my RSS feeds. :)
17:36:53 <sanket_> clokep_work, Thanks :)
17:40:04 <-- Tomek has quit (Ping timeout)
17:40:11 <-- Lalae has left #instantbird ()
17:46:04 <clokep_work> wnayes: Is your plan to just take a clone of hg.instantbird.org/instantbird and push it there and make changes?
17:47:04 <wnayes> clokep_work: I was thinking that would be the best option.
17:50:09 <clokep_work> :) OK.
17:52:30 --> Tomek has joined #instantbird
17:54:44 --> FireFly_TB has joined #instantbird
17:56:24 <-- FireFly_TB has quit (Ping timeout)
17:58:59 <wnayes> clokep_work: Anything special that should be done? Or is it as simple as hg push hg.instantbird.org/users/wnayes
17:59:32 <clokep_work> hg clone http://hg.instantbird.org/instantbird && hg update && hg push https://hg.instantbird.org/users/wnayes
17:59:34 <clokep_work> Should do it.
17:59:49 <clokep_work> wnayes: You can set up aliases though, so you can do "hg pull instantbird" and "hg push wnayes" or something.
17:59:57 <clokep_work> In the paths section of the hgrc for the repo.
18:00:07 * clokep_work isn't sure how familiar you are with Hg.
18:02:25 <wnayes> clokep_work: I would say I'm not as familiar with hg push as I am with hg pull :) I guess I was wondering if pushing the repository as is would add unnecessary changes, etc., or if having the full history would be desired.
18:02:54 <clokep_work> Having the full history might be unnecessary...but you'll want it there so you could always merge in upstream changes.
18:03:24 <-- jb1 has quit (Ping timeout)
18:15:35 <clokep_work> Do let us know if you have Hg questions btw, it's usually easy to Google for stuff, but I find it hard to find the right search words. :(
18:16:09 --> gerard-majax has joined #instantbird
18:24:04 <-- Kaishi has quit (Quit: Kaishi)
18:26:50 --> igorko has joined #instantbird
18:28:43 * jwir3 is now known as jwir3|lunch
18:40:38 <wnayes> clokep_work: I'm getting an "about: authorization failed" after a long wait when trying to push the new repo.
18:41:42 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
18:41:44 <wnayes> *"abort", rather. Tried twice manually entering auth, also tried configuring it in hgrc
18:44:08 <clokep_work> wnayes: What's the exact URL you're pushing to?
18:44:30 <wnayes> https://hg.instantbird.org/users/wnayes/
18:48:43 <clokep_work> wnayes: Hmm...I was hoping that you were missing a / at the end, that causes funny errors sometimes on our server.
18:49:07 <clokep_work> I wonder if flo added your password properly to the server or not, only other thing I can think of. :-D
18:50:02 * Optimizer likes that he does not have to get suited to a new style for IRC after shifting from Mibbit web chat to Instant Bird.
18:51:24 <clokep_work> Optimizer: Glad your extension works well. :)
18:51:36 <Optimizer> atleast on my IB
18:52:11 <clokep_work> wnayes: Are you using wnayes or your email to auth?
18:52:27 <clokep_work> It's probably the former.
18:53:34 <wnayes> clokep_work: I've tried both, takes quite awhile to see if anything works...
18:54:15 <clokep_work> :(
18:54:26 <clokep_work> Yeah, you'll need to wait until flo comes back then. Sorry.
18:54:46 <clokep_work> At least you don't have to wait to start working. ;)
18:55:01 <wnayes> I'm sure it will be resolved :)
18:55:15 <wnayes> I've been brainstorming on the importer interface a bit: http://www.tc.umn.edu/~nayes006/gsoc2012/files/imIImporterNotes.txt
18:57:02 <-- meh has quit (Ping timeout)
18:58:51 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:02:07 <clokep_work> wnayes: Just an idea, have you ever used etherpad? It's great for stuff like this: https://etherpad.mozilla.org/
19:02:31 <clokep_work> (Although if you want to keep it all on your site, I understand. :))
19:04:24 <clokep_work> wnayes: I agree that you might want to have two separate things: a "find if installed" and an actual "get (account) information" methods.
19:05:24 <clokep_work> Another thing not all importers might be able to do is importing of passwords btw.
19:06:08 * clokep_work thinks it's really easy to over abstract in interfaces. :-S
19:07:26 <wnayes> clokep_work: Etherpad looks neat. I wouldn't mind using that if it helps collaborate.
19:09:11 <wnayes> Probably will just start using the repo soon enough :)
19:10:59 <clokep_work> Of course! :)
19:13:49 <-- mmkmou has quit (Client exited)
19:15:22 <wnayes> clokep_work: I'm not sure how to future-proof the interface for when logs are added as well. Seems like there would need to be a separate method for that task.
19:16:18 --> Mnyromyr has joined #instantbird
19:17:13 <clokep_work> wnayes: It's possible. It's also possible we can just "not care" until support for logs is added.
19:17:45 <clokep_work> By separate method do you mean a seperate method to convert them or to find them?
19:19:37 --> flo has joined #instantbird
19:19:37 * ChanServ sets mode +qo flo flo 
19:19:41 <wnayes> I've been thinking of the tasks as being something done in one method, but I would agree that log details could wait.
19:19:54 <clokep_work> "the tasks"?
19:20:04 <clokep_work> I see a few different tasks, can you be more specific? :)
19:20:15 <wnayes> "convert them" and "find them" :)
19:20:24 <clokep_work> OK, that's what I was thinking too. ;)
19:21:27 --> meh has joined #instantbird
19:22:35 <clokep_work> It does sound like two different things, but that shouldn't really be an issue -- they could be made separate.
19:23:23 <clokep_work> I'm not being helpful. :) Sorry.
19:25:09 <clokep_work> Let's see what flo says. I think he has a better idea in his mind what's necessary.
19:26:41 <flo> do we care if the client is installed if no account is configured?
19:27:07 <flo> or were you thinking that in some cases we couldn't know (ie for digsby we would have to first ask the servers to detect accounts)?
19:28:21 <aleth> Are you planning to import contacts for the accounts too? (Obviously leave for later, but is that something you were thinking of offering? i.e. it might not just be logs that would be fetched at a second stage)
19:29:01 <wnayes> flo: I was thinking it would be a reasonable check for the UI to display the available clients, although finding them has to occur at a point soon after.
19:29:26 <flo> aleth: I'm not sure contact importing has to be done after closing the wizard. It could be fast enough that we can just do it
19:29:55 <flo> I'm not sure why/where the UI would display the detected clients
19:30:38 <clokep_work> (Except the case where we want to ask for permission, e.g. Digsby?)
19:32:21 <flo> the addObserver/removeObserver/notifyObservers methods feel like something you won't need. I don't know yet what you will need, but I don't see a good reasons for importers to want to report their status/findings to more than one object
19:32:34 <wnayes> flo: I guess I was still thinking in terms of how the Firefox wizard works, where the available clients are listed and can be chosen to consider in a search or not.
19:33:06 <flo> wnayes: in the firefox wizard I think you select one browser to import from
19:33:30 <flo> wnayes: but it's the same case as "we have found your AIM account with the screenname foobar in Pidgin, Trillian and AIM, where do you want to import it from?"
19:35:32 <flo> wnayes: I think you will have to define at least 3 interfaces, maybe imIImportersService, imIImporter and imIImportedAccount
19:36:48 <wnayes> flo: I was thinking a service would be required as well, but what would be the difference in an imIImportedAccount from a regular account?
19:37:10 <clokep_work> prplIAccount / imIAccount have implementation details, this would just be a datastore.
19:37:20 <flo> wnayes: that interface would expose the information required to create an account
19:37:35 <flo> a connect() method wouldn't make sense there for example
19:37:45 <clokep_work> (I.e. prplIAccount has a "connect" method I believe, while imIImportedAccount would just have the information necessary to build a imIAccount)
19:38:16 <clokep_work> s/I.e./E.g./
19:39:14 <wnayes> flo, clokep_work: Makes sense :) Would you agree that this is the first portion of the project to work on, or would having the UI more concrete be necessary?
19:40:04 <flo> wnayes: "this" = defining the idl interfaces?
19:40:35 <wnayes> flo: Yes
19:40:59 * jwir3|lunch is now known as jwir3
19:41:39 <flo> I agree that having idl interfaces that make sense is probably required before letting you dive deep in the code
19:42:07 <flo> having to rewrite some code that already worked because we need to change the interface significantly is frustrating :)
19:42:35 <flo> having clearer ideas of how the UI will look is probably required to define the idl interfaces correctly though
19:43:15 <clokep_work> So perhaps some mock ups of the UI w/ the interfaces defined to support those is the first step? ;)
19:43:18 <flo> so what I don't know is how much time it makes sense to let you spend on this, rather than just producing mockups and draft interfaces ourselves/myself and seeing if they make sense to you
19:43:37 <wnayes> flo: That's what I was thinking, having a better understanding of the UI would reduce rewriting the interfaces.
19:44:35 <flo> I know it would probably be easier/faster for me to just spend an hour to draft something (both the UI and the idl) than to explain all the requirements and send feedback everyday about iterations of it; but I don't have a clear estimate of how important it is to let you do that part for the rest of the project to be enjoyable and feel like your own :)
19:44:59 <flo> I don't want to steal your project :)
19:45:11 <flo> *the fun parts of your project
19:46:15 <flo> (oh, by the way, I don't pretend that I could get the UI/idl right the first time; I just think we could get closer faster)
19:46:34 <wnayes> flo: Maybe I could have a go at some mockups today, and then see how close we are from there?
19:46:46 <flo> if you like :)
19:48:45 <wnayes> I think that would be a reasonable use of time, if they are way off then we might have to try something else :)
19:49:07 <flo> ok :)
19:49:16 <flo> I'm trying to push to your repository
19:49:45 <flo> I also got an "authorization failed" error, after 6 warnings about not verifying the certificate
19:57:08 <flo> wnayes: http://hg.instantbird.org/users/wnayes/rev/38a8d92457c0 :)
19:57:10 <flo> it works now
19:57:20 <flo> apparently I typoed while editing the password file
19:57:28 <wnayes> flo: Great, thanks!
19:57:35 <flo> (I'll rolback that test commit soon of course)
19:58:31 <flo> bah, no, I hadn't typoed while adding the password, but when sending it to you
19:58:38 <flo> I forgot the last character in the copy/paste :-/
19:58:52 <wnayes> Would you agree that I should push a clone of the main instantbird up as a base?
19:59:23 <flo> sounds like a good idea. except if you want me to do it directly on the server
20:00:16 <flo> (that's probably lots of revisions to push)
20:00:36 <clokep_work> It's not like it's m-c. ;)
20:00:52 <flo> clokep_work: heh :)
20:01:29 <wnayes> flo: I can push it since I've already pulled and tried to earlier :)
20:01:32 <clokep_work> I've been downloading bundles of m-c whenever I need it now...
20:01:38 <flo> wnayes: ok
20:01:44 * jwir3 is now known as jwir3|away
20:01:59 <flo> clokep_work: maybe we should edit client.py to do that by default instead of cloning?
20:02:57 <flo> clokep_work: I usually clone from another machine in the local network ;)
20:03:16 --> Mic has joined #instantbird
20:03:16 * ChanServ sets mode +h Mic 
20:03:39 <-- Mic has quit (Connection reset by peer)
20:03:51 --> Mic has joined #instantbird
20:03:51 * ChanServ sets mode +h Mic 
20:04:23 <Mic> Great, only one crash before I successfully joined this time :S
20:04:47 <clokep_work> flo: Maybe, but we'd have to have it make an hgrc and stuff too since it doesn't have a URL.
20:04:57 <clokep_work> *any default URL set up.
20:05:02 <-- meh has quit (Ping timeout)
20:05:06 <clokep_work> Plus it still takes a long time to unpack the files.
20:05:12 <clokep_work> But maybe less now with MPL 2!
20:05:23 <flo> clokep_work: we already have similar hacks on the buildbot slaves
20:05:35 <flo> we keep a clone of mozilla-central in a different directory, and then clone it locally
20:05:56 <clokep_work> Oh? Interesting.
20:06:33 <clokep_work> I was actually wondering whether I could build a comm-central build from a mozilla-central I had downloaded already, but it wasn't located under /mozilla...but then I grew lazy and just copied. :)
20:07:17 <wnayes> flo: The push went through this time :) Looks like everything is there now.
20:07:33 <flo> cool :)
20:09:22 --> meh has joined #instantbird
20:11:18 <clokep_work> meh: Did you ever have any luck with your TorChat?
20:11:47 <meh> clokep_work, nope, i am waiting for some bugs to be resolved
20:11:55 <meh> but i don't know which ones specifically
20:11:59 <flo> Mic: what was the crash? Do you usually crash with nightlies these days? :-S
20:12:06 <meh> stuff that has to do with bootstraped protocol addons
20:12:07 <clokep_work> meh: Bugs in Instantbird?
20:12:19 <meh> clokep_work, yes
20:12:23 <clokep_work> Why does it matter if it's bootstrapped or not?
20:12:38 <clokep_work> flo: I've noticed more crashes the past few days actually. No crash reporter either.
20:12:39 <meh> because i want it to be bootstraped :<
20:12:46 <clokep_work> Mostly "hangs" though, so maybe it's this SSL deal.
20:13:18 <clokep_work> meh: Uhh...OK...but if it can't be right now (and no one is working to make that possible), wouldn't it make more sense to just make it and once it's possible to make it bootstrapped just make the minor changes to do that?
20:14:11 <meh> eh, but i'm a noob at extension development, i never know from where to start :(
20:14:56 <clokep_work> That's probably something we can help w/! ;)
20:15:02 <clokep_work> Although I'm leaving right now, so...not right now. :-D
20:15:33 <flo> clokep_work: if it hangs it's not a crash
20:15:39 <clokep_work> The master branch of https://bitbucket.org/clokep/lj-talk/ is a protocol added as an extension.
20:16:07 <flo> and yes, if your nightly hangs while you have an SSL IRC account connected, it's definitely that isAlive crap
20:16:19 <-- clokep_work has quit (Quit: Bye!)
20:21:11 <Mic> flo: yes, I do. I guess I'm the generator of all the wdmaud crashes on crash-stats ;)
20:21:38 <Mic> And that doesn't include the crashes where the crashreporter doesn't even occur (which is more common than not! :( )
20:22:36 --> DGMurdockIII has joined #instantbird
20:23:06 <DGMurdockIII> can you guys please add ability to bloack users soon
20:23:14 <DGMurdockIII> poepole
20:23:50 <DGMurdockIII> or is flo anti spam plugin ready
20:24:43 <flo> what is wdmaud.drv supposed to do? Is it the audio driver?
20:26:57 <Mic> Not the audio driver itself iirc but still audio related.
20:27:44 <flo> do the crashes go away if you disable sounds?
20:28:27 <DGMurdockIII> wdmaud.drv is a WDM Audio driver mapper from Microsoft Corporation belonging to Microsoft® Windows® Operating System wdmaud.drv is a system process that is needed for your PC to work properly.
20:29:07 <DGMurdockIII> http://answers.microsoft.com/en-us/windows/forum/windows_7-hardware/how-to-reinstall-wdmauddrv/d5db2bc7-b773-486f-93fe-2314e576cc56
20:31:04 <DGMurdockIII> flo is you anti-spam addon abalie for me to try 
20:31:12 <DGMurdockIII> flo: is you anti-spam addon abalie for me to try 
20:31:12 <flo> no
20:31:31 <DGMurdockIII> i get soo many spam from boys
20:31:37 <DGMurdockIII> bots*
20:31:38 <flo> DGMurdockIII: but a good anti-spam add-on would prevent your last 2 messages from pinging me :-P
20:31:54 <DGMurdockIII> i did not mean to do that
20:32:08 <DGMurdockIII> you are still working on you addon*
20:32:23 <DGMurdockIII> or was it you who was doing it in the first place
20:33:50 <flo> I think I just offered some code demonstrating how one could do it
20:33:56 <flo> I wasn't really working on that
20:34:13 <flo> although some AIM spammers sometimes remind me that I would need to do something to silence them :)
20:38:35 <DGMurdockIII> you shold look at the pidgin anti-spam addon and port that one to instantbird then just keep improving it
20:39:43 <DGMurdockIII> http://sourceforge.net/projects/pidgin-bs/
20:42:16 <Mic> Good night
20:42:36 <flo> DGMurdockIII: I tend to think that telling people what they should do is rude :-P
20:43:33 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
20:47:41 <-- chrisccoulson has quit (Quit: Ex-Chat)
20:51:22 <DGMurdockIII> ok
20:51:32 <DGMurdockIII> it just a suggestion
20:52:13 --> chrisccoulson has joined #instantbird
21:05:52 --> EionRobb has joined #instantbird
21:08:12 <-- Optimizer has quit (Ping timeout)
21:08:47 --> clokep has joined #instantbird
21:08:48 * ChanServ sets mode +o clokep 
21:10:55 <aleth> I've noticed a strange pattern to the (SSL connect?) hangs on startup with the current nightlies
21:11:14 <aleth> It seems to happen exactly every second startup.
21:11:31 <aleth> I think the reason is that after it has hung once, the next time it does not immediately connect
21:11:38 --> Optimizer has joined #instantbird
21:11:44 <aleth> (it shows up the "your last connection attempt failed" warning)
21:12:50 <clokep> Yes.
21:12:54 <aleth> I haven't been able to come up with a good reason why that delay in connecting should make a difference
21:13:36 <aleth> The connect sequence triggered should be the same, after all?
21:14:03 * jwir3|away is now known as jwir3
21:14:54 <aleth> They finally landed the MDN search bug fix :)
21:14:54 <Optimizer> I cannot see logs of chat b/w me and a nick who is now offline ?
21:15:00 <aleth> No more duplicate results
21:15:20 <aleth> Optimizer: bug 1238
21:15:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1238 nor, --, ---, nobody, NEW, No way to view logs for which no buddy or current conversation exists
21:15:46 <Optimizer> (
21:15:51 <Optimizer> any hacky way ?
21:15:51 <aleth> If the nick is your buddy, you can "show offline buddies" and then view the logs
21:16:56 <aleth> Otherwise, reading the log in the log dir by hand is the only way atm :-/
21:18:30 <-- Optimizer has quit (Ping timeout)
21:19:14 --> Optimizer has joined #instantbird
21:19:16 <Optimizer> where is the log directory ?
21:19:39 <aleth> Tools -> Preferences -> Privacy
21:19:47 <clokep> http://instantbird.com/faq.html#logfolder
21:25:17 <-- Optimizer has quit (Ping timeout)
21:28:04 <flo> aleth: the cause of the hangs is known: using IRC over SSL
21:29:01 <aleth> The isAlive issue, I gathered that. I'm a bit puzzled as to when exactly it happens though. Have you figured it out?
21:29:11 --> Optimizer has joined #instantbird
21:29:53 <flo> aleth: it happens randomly when using isAlive on an SSL socket
21:29:56 <aleth> Maybe it's not important to know since a patch for the isAlive issue seems to exist
21:30:04 <flo> it's a thread safety issue
21:32:26 <aleth> Right.
21:38:46 <-- Optimizer has quit (Ping timeout)
21:39:59 <-- Tomek has quit (Quit: Instantbird 1.1)
21:42:03 --> Optimizer has joined #instantbird
21:46:54 <instantbot> clokep@gmail.com cancelled review?(clokep@gmail.com) for attachment 1490 on bug 1447.
21:46:55 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1510 on bug 1447.
21:46:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1447 nor, --, ---, clokep, ASSI, Stop requesting WHOIS information when offline
21:49:18 <flo> so bug 1446 readds empty lines in ircBase.jsm?
21:49:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1446 nor, --, ---, aletheia2, ASSI, Reset nick modified due to nick collision when disconnecting the account
21:50:57 <clokep> Yes.
21:51:39 <instantbot> aletheia2@fastmail.fm granted review for attachment 1510 on bug 1447.
21:51:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1447 nor, --, ---, clokep, ASSI, Stop requesting WHOIS information when offline
21:53:14 <clokep> Thanks for the quick review. :) When I actually looked at it it was fairly simple since we always end up back at that method!
21:54:15 <aleth> Yes :) Is there an IDL comment where one should add "this function must be callable when the account is disconnected" or can that be taken as read?
21:54:27 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
21:54:56 <-- Optimizer has quit (Ping timeout)
21:54:56 <clokep> I think it should be assumed. I just didn't consider it.
21:55:36 <aleth> flo: The empty lines were removed by accident last week
21:56:30 <flo> isn't that patch going to add lots of system messages?
21:56:51 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:56:55 <aleth> Only where they are currently missing, unless I missed something
21:57:12 <flo> assuming jb and jb1 are connected, and my default nick is jb, wouldn't it write for each reconnect "You are now known as jb" then "You are now known as jb1" and finally "you are now known as jb2"?
21:58:28 --> Optimizer has joined #instantbird
21:59:07 <-- myk has quit (Ping timeout)
22:00:03 <aleth> I don't think so, but let me look again for the reason
22:02:03 --> myk has joined #instantbird
22:02:03 <clokep> flo: Yes, that happens.
22:02:22 <aleth> Not the first one I think though. Only the subsequent changes.
22:03:27 <clokep> It does. I just tried.
22:03:49 <clokep> If you try to log into moznet right now as clokep it'll go through all of them until it finds one that works.
22:03:54 <clokep> And notify you every time.
22:04:07 <clokep> IF you have a conversation over.
22:04:24 <aleth> Yes, if a conversation is open so you already have a nick
22:04:47 <clokep> Yes...
22:05:10 <-- Optimizer has quit (Ping timeout)
22:05:15 <clokep> Still an issue.
22:05:33 <clokep> I think the fix is just not to call changeBuddyNick inside of tryNewNick
22:06:42 <aleth> So the question is "can one only display the last change"?  I doubt it because the server doesn't send you a message when your nick change succeeded, right?
22:06:54 <flo> clokep: but you wouldn't want the "you are now known as clokep" first message either, right?
22:06:57 <aleth> You have to call changeBuddynick at some point or the conversations will still use the wrong nick..
22:07:24 <clokep> aleth: When the login is completed, you check if the nick has changed and then call changeBuddyNick.
22:07:27 <clokep> So in the 001 handler.
22:08:21 <-- wnayes has quit (Ping timeout)
22:08:53 <aleth> Ah, the 001 is subsequent? I missed that.
22:09:03 <aleth> Not sure why :-/
22:09:18 <clokep> Bleh well.
22:09:21 <clokep> OK.
22:10:06 <clokep> I think it is, but I'm not positive. :-/
22:11:25 <clokep> aleth: http://pastebin.instantbird.com/43200
22:11:36 <clokep> You can't finish connecting until youu have a unique nick.
22:12:02 <aleth> Great, so one can improve this!
22:12:11 <clokep> So during tryNewNick, if the account is already connected, it should call the changeNick method, otherwise you need to just set the nickname.
22:12:24 <aleth> I know why I missed it: I tested nick clashes in the connected state via "/nick xxx"
22:12:25 <clokep> Good find flo. :)
22:12:34 <clokep> Yes, me too.
22:13:04 --> wnayes has joined #instantbird
22:13:44 <aleth> Patch is slightly bitrotted anyway :-/
22:15:58 <flo> not completely sure if that comment means r-
22:16:04 <flo> re bug 1447
22:16:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1447 nor, --, ---, clokep, ASSI, Stop requesting WHOIS information when offline
22:16:40 <clokep> flo: What?
22:16:44 --> mmkmou has joined #instantbird
22:16:52 <clokep> Oh. I see.
22:17:11 <clokep> OK. I'll change it to match that behavior then.
22:17:32 <aleth> Isn't that a libpurple bug though?\
22:17:50 <flo> no
22:17:59 <flo> is there a comment implying that the notification will always happen?
22:18:07 <flo> if there is one it needs fixing
22:18:37 <flo> anyway, now I know why this is actually r-: firing the notification synchronously during the requestBuddyInfo call could produce unexpected behaviors
22:19:19 <flo> if you really wanted to send that notification I think you would want to wrap it in an executeSoon cal
22:19:20 <flo> l
22:19:33 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1511 on bug 1447.
22:19:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1447 nor, --, ---, clokep, ASSI, Stop requesting WHOIS information when offline
22:19:36 <aleth> Isn't it a problem if the observer is never removed? It might fire at a much later stage when e.g. the tooltip no longer exists
22:20:07 <flo> aleth: it's a problem if the observer isn't removed in an onpopuphidding event handler
22:20:32 <flo> aleth: http://lxr.instantbird.org/instantbird/source/instantbird/content/buddytooltip.xml#468
22:21:02 <flo> so no, no problem :)
22:24:09 <instantbot> florian@instantbird.org granted review for attachment 1511 on bug 1447.
22:24:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1447 nor, --, ---, clokep, ASSI, Stop requesting WHOIS information when offline
22:24:27 <flo> well, sorry for r-'ing both patches that had checkin-needed ;)
22:25:08 <aleth> Good find about the tryNewNick when offline :)
22:25:10 <aleth> Just review some more if you are looking for checkins ;)
22:25:24 * clokep would suggest bug 318
22:25:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly
22:26:57 <flo> aleth: I wasn't really looking for check-ins, but for quick actions I could perform before going to bed to unblock people ;)
22:27:49 <flo> aleth: it turns out that has already taken ~40 minutes to only check-in a trivial early return ;)
22:31:46 <flo> are we sure _setMode is never called with an empty string?
22:32:25 <clokep> Probably not.
22:32:47 <clokep> If you need to go to bed, feel free! :) I don't wanna keep you up.
22:34:07 <flo> splice is happy with -1 as the first parameter?
22:36:01 <flo> the typo you said you have fixed isn't fixed :P
22:38:56 <clokep> It's fixed for me locally. :(
22:39:33 <flo> clokep:  you have this comment "// Keep if this is secret (@), private (*) or public (=)." and 2 lines above the same  comment with a "TODO" prefix
22:40:19 <clokep> Yes.
22:40:25 <clokep> It's wrong. :(
22:40:56 <flo> the change in ircCommands.jsm means that the mode command is currently quite broken, right?
22:42:03 <clokep> Yes.
22:42:20 <clokep> I hate that command. :(
22:42:36 <flo> clokep: I think that command hates you in return ;)
22:44:01 <instantbot> florian@instantbird.org granted review for attachment 1509 on bug 1449.
22:44:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1449 enh, --, ---, benediktp, ASSI, Make initialization state of Core available and send notification when initialization finishes.
22:45:11 <-- aleth has quit (Input/output error)
22:45:38 --> aleth has joined #instantbird
22:45:39 * ChanServ sets mode +h aleth 
22:46:01 <flo> clokep: other than the typo and the broken comment, I think I would be willing to try this in nightlies
22:46:25 <flo> I haven't carefully reviewed it, but I think aleth has.
22:48:44 <clokep> flo: OK.
22:52:08 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1482 on bug 318.
22:52:09 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1512 on bug 318.
22:52:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly
22:57:42 <instantbot> florian@instantbird.org granted review for attachment 1503 on bug 1071.
22:57:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1071 enh, --, ---, benediktp, ASSI, Improve look of contact drop target
23:00:16 <clokep> flo: Good news... http://blog.mozilla.org/bhearsum/archives/297 you can choose to run just some unsigned apps.
23:02:20 <flo> that last sentence is cut off :-S
23:03:32 --> Lalae has joined #instantbird
23:03:41 <clokep> Yes.
23:04:08 <instantbot> florian@instantbird.org granted review for attachment 1512 on bug 318.
23:04:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly
23:05:15 <flo> clokep: Hunk #3 succeeded at 262 with fuzz 2 (offset 0 lines). Already bitrotted? Or you have hand edited it? :)
23:05:39 <clokep> flo: I probably have other patches applied locally in my queue, forgot to move it to the front before making that patch, sorry. :)
23:06:19 <flo> no problem, it applied :)
23:06:44 * clokep notes his mq is really long right now. :(
23:06:47 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4e2cb72c9a2f - Patrick Cloke - Bug 318 - Check if topic on IRC channels is editable and make UI respond accordingly, r=aleth,fqueze.
23:06:48 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/53d6f99b35a3 - Benedikt Pfeifer - Bug 1071 - Improve look of contact drop target, r=fqueze.
23:06:49 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d43ef47d5e8c - Patrick Cloke - Bug 1447 - Stop requesting WHOIS information when offline, r=fqueze.
23:06:50 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8bca26ec274e - Benedikt Pfeifer - Bug 1449 - Make initialization state of Core available and send notification when initialization finishes, r=fqueze.
23:08:01 <instantbot> clokep@gmail.com set the Resolution field on bug 318 to FIXED.
23:08:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, 1.2, clokep, RESO FIXED, Check if topic on IRC channels is editable and make UI respond accordingly
23:08:09 <flo> clokep: is it a good or a bad thing? :)
23:08:31 <instantbot> clokep@gmail.com set the Resolution field on bug 1071 to FIXED.
23:08:31 <clokep> Means I'm not finishing things. :(
23:08:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1071 enh, --, 1.2, benediktp, RESO FIXED, Improve look of contact drop target
23:09:11 <instantbot> clokep@gmail.com set the Resolution field on bug 1447 to FIXED.
23:09:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1447 nor, --, 1.2, clokep, RESO FIXED, Stop requesting WHOIS information when offline
23:09:32 <instantbot> clokep@gmail.com set the Resolution field on bug 1449 to FIXED.
23:09:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1449 enh, --, 1.2, benediktp, RESO FIXED, Make initialization state of Core available and send notification when initialization finishes.
23:09:42 <flo> a lot of bugmail for a single bug closed (for 308)
23:10:43 <clokep> Yeah...meta bugs I need to go through and file real issues on.
23:11:33 <instantbot> clokep@gmail.com denied review for attachment 1498 on bug 1446.
23:11:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1446 nor, --, ---, aletheia2, ASSI, Reset nick modified due to nick collision when disconnecting the account
23:11:38 <flo> and I'm down to 18 unread bugmail conversations
23:11:43 <clokep> )
23:11:45 <clokep> Nice.
23:12:05 <flo> (the unread ones generally involve something I've got to do, like a review request, or a denied review)
23:12:18 <flo> clokep: you should update your nightly, right?
23:12:22 <flo> you just sent ")" ;)
23:12:40 <clokep> Yeah I'm probably a little behind.
23:12:45 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:12:52 --> clokep has joined #instantbird
23:12:52 * ChanServ sets mode +o clokep 
23:13:11 <clokep> It still doesn't seem to be working...
23:13:14 <clokep> (
23:17:09 <flo> boo
23:17:17 <flo> anyway, good evening/night!
23:17:18 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:17:23 <clokep> Good night!
23:19:10 <aleth> Sometimes logging onto mozilla.org doesn't get further than "irc: onStartRequest". I wonder whether they don't like it if you have too many nick clashes within some period...
23:19:58 <aleth> test
23:20:16 <clokep> So I can send smilies from my own build, but not from my nightly?
23:20:24 <clokep> But I'm up to date. :-S
23:20:44 <aleth> It's possible to provoke "irc: ERR_NOTEXTTOSEND: No text to send for PRIVMSG." by ending a line with Ctrl-Return Return
23:21:11 <clokep> aleth: That sounds like a bug. :)
23:21:24 <clokep> (With a very easy fix, but still...)
23:21:26 <aleth> It does. A tiny one.
23:22:42 <aleth> clokep: --no-remote?
23:23:00 <clokep> aleth: -no-remote I think.
23:23:59 <clokep> aleth: Can you send just a happy face?
23:24:06 <aleth> :)
23:24:18 <clokep> OK it works for you...maybe I'm on an older nightly then.
23:26:40 <instantbot> New Core - IRC bug 1460 filed by aletheia2@fastmail.fm.
23:26:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1460 min, --, ---, nobody, NEW, Check whether messages to be sent end with blank lines
23:26:48 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:42:35 --> wnayes has joined #instantbird
23:52:06 <-- Lalae has quit (Quit: Instantbird 1.1)
23:53:29 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1513 on bug 1446.
23:53:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1446 nor, --, ---, aletheia2, ASSI, Reset nick modified due to nick collision when disconnecting the account
23:58:28 <instant-buildbot> build #256 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/256
23:58:31 <clokep> aleth: What if the account isn't connected in tryNewNick?
23:59:02 <clokep> Ah, I see what you did.
23:59:05 <aleth> Then we catch the final new nick in the 001 handler.
23:59:07 <clokep> You just send thew newNick.