#instantbird log on 05 21 2012

All times are UTC.

00:20:59 <-- Tomek has quit (Quit: Instantbird 1.1)
01:19:37 <-- aleth has quit (Input/output error)
01:21:35 <instant-buildbot> build #244 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/244
01:26:46 <instant-buildbot> build #223 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/223
02:35:00 --> clokep has joined #instantbird
02:35:00 * ChanServ sets mode +o clokep 
02:55:44 <instant-buildbot> build #503 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/503
02:58:27 --> NmN has joined #instantbird
03:02:39 <instantbot> clokep@gmail.com denied review for attachment 1491 on bug 1446.
03:02:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1446 nor, --, ---, aletheia2, ASSI, Reset nick modified due to nick collision when disconnecting the account
03:06:20 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
03:57:48 <-- SM0TVI has quit (Connection reset by peer)
04:27:57 <instant-buildbot> build #596 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/596
05:38:59 <-- EionRobb has quit (Quit: Leaving.)
05:40:50 <instantbot> New Instantbird (UI) bug 1451 filed by cronic8350@gmail.com.
05:40:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1451 min, --, ---, nobody, UNCO, Instantbird wont close
05:56:30 --> SM0TVI has joined #instantbird
06:03:30 <instant-buildbot> build #489 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/489
06:03:34 --> meh` has joined #instantbird
06:04:01 <-- meh has quit (Ping timeout)
06:32:32 --> Optimizer has joined #instantbird
07:33:29 <-- Optimizer has quit (Ping timeout)
07:34:36 --> jb has joined #instantbird
07:35:18 --> Optimizer has joined #instantbird
07:37:02 <-- jb has quit (Quit: jb)
07:37:53 --> jb has joined #instantbird
07:47:26 <-- Optimizer has quit (Ping timeout)
07:52:23 --> Even has joined #instantbird
07:52:23 * ChanServ sets mode +o Even 
07:52:46 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
07:52:53 --> Even has joined #instantbird
07:52:53 * ChanServ sets mode +o Even 
07:57:00 --> Optimizer has joined #instantbird
08:15:25 <-- gerard-majax has quit (Ping timeout)
08:26:34 --> Even1 has joined #instantbird
08:27:17 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
08:27:24 --> Mic has joined #instantbird
08:27:24 * ChanServ sets mode +h Mic 
08:27:27 --> Even1 has joined #instantbird
08:27:39 --> mmkmou has joined #instantbird
08:29:42 <Mic> Hello.
08:32:03 <Optimizer> (none of the main persons is online, so I am responding) Hello!
08:34:41 <Mic> I saw you uploaded your Mibbit theme. If you think it's ready for the public, you can request review on it so the editors see and can review it.
08:35:23 <Mic> (I think that you're familiar with this already, though;)
08:35:51 <Optimizer> haven't I already ?
08:35:55 <Optimizer> I thought I did 
08:36:45 <Mic> The UI of AIO is crappy, I wouldn't be surprised if you thought you did and AIO thought differently ;)
08:37:30 <Mic> No, it's not in the list yet.
08:37:59 <Optimizer> how to do then ?
08:40:04 <Mic> Look for "Change status" in your developer tools-page for this add-on (and user-reviews do not matter).
08:40:59 <Mic> (I meant that the user reviews are mentioned in the list of the requirements but don't matter. You can request review anyways)
08:45:56 <Optimizer> message themes can be restartless ?
08:47:58 <Optimizer> Mic: ^ ?
08:49:23 --> FireFly_TB has joined #instantbird
08:50:05 <Mic> Good idea, I think the "skin" directive in the manifest could actually work.
08:50:44 <Optimizer> nice
08:50:49 <Optimizer> then imma make it restarless
08:50:50 <Optimizer> P
08:50:58 <Mic> Could you try and let us know if it installed fine? Uninstalling could have problems since the pref window caches the list of themes but that can be fixed if it turns out to work.
08:51:14 <Optimizer> okay
08:51:18 <Optimizer> just a sec
08:52:58 <Optimizer> i mean a few minutes
08:53:15 <Mic> It's OK.
08:53:30 <Mic> I'll be away for a while anyways.
08:56:46 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
08:56:53 --> Optimizer has joined #instantbird
08:58:29 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
08:59:32 --> Mic has joined #instantbird
08:59:32 * ChanServ sets mode +h Mic 
08:59:52 <Mic> Awesome, I just changed my Google Talk emoticons theme to be restartless :)
09:01:14 <Mic> It even uninstalls fine :)
09:01:24 --> FeuerFliege has joined #instantbird
09:01:37 <Mic> There's an issue when you install/uninstall/disable while the pref window is open but so what?
09:04:04 <Optimizer> yes message themes can be restartles
09:04:09 <Optimizer> I am having another problem
09:04:16 <Optimizer> my theme has many javascript functions 
09:04:19 <Optimizer> event handlers
09:04:26 <Optimizer> so I have to enumerate on windows
09:04:34 <Optimizer> but I am now getting one problem
09:05:01 <Optimizer> since I cannot overlay using manifest in a restartless function, the global getBrowser() is no longer available to me
09:06:43 <Optimizer> where can I get that function ? 
09:06:57 <Mic> You can look here to get an idea: https://github.com/douglaswth/inputhistory/blob/master/bootstrap.js#L137
09:07:37 <Mic> We're talking about javascript in chrome context (i.e. not located inside one of your theme files)?
09:08:14 <Optimizer> see, earlier i used to overlay an xul
09:08:24 <Optimizer> which used to insert the script into the xul
09:08:32 <Optimizer> thus I had access to getBrowser() function
09:09:05 <Optimizer> now I enumerate on windows (like in the link you provided) and thus the getBrowser() is not accessible
09:09:17 <Optimizer> as it resided in the xul, in which I inserted my script
09:09:27 <Optimizer> am I sounding logical ?
09:09:41 <Optimizer> brb
09:09:43 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:09:57 --> Optimizer has joined #instantbird
09:11:00 --> gerard-majax has joined #instantbird
09:11:48 <Optimizer> and thus I am getting this warning on install : Timestamp: 5/21/2012 2:41:15 PM
09:11:49 <Optimizer> Warning: WARN addons.xpi: Exception running bootstrap method shutdown on messagestyle-mibbit@addons.instantbird.org: ReferenceError: getBrowser is not defined
09:11:49 <Optimizer> Source File: resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/Girish%20Sharma/AppData/Roaming/Instantbird/Profiles/16r3f1iw.default/extensions/messagestyle-mibbit@addons.instantbird.org.xpi!/bootstrap.js -> jar:file:///C:/Users/Girish%20Sharma/AppData/Roaming/Instantbird/Profiles/16r3f1iw.default/extensions/messagestyle-mibbit@addons.instantbird.org.xpi!/chrome/content/helper.js
09:11:49 <Optimizer> Line: 234
09:12:34 <Optimizer> Mic: you there ?
09:12:58 <instantbot> New Websites - addons.instantbird.org (Remora) bug 1452 filed by benediktp@ymail.com.
09:13:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1452 enh, --, ---, raynaudquentin, NEW, Convert messagestyle and emoticon themes to be restartless
09:13:12 <Mic> Don't paste that much stuff here, please. Pastebin's much better suited for this.
09:13:30 <Optimizer> okay, sorry
09:14:04 <Mic> What's the problem you're trying to solve with the chrome script? Or could you pastebin it too?
09:14:18 <Optimizer> okay
09:14:31 <Optimizer> going to pastebin and doing stuff is PITA until I make an addonf or that
09:15:54 <Optimizer> I am calling this function on Domcontentloaded event : http://pastebin.instantbird.com/43032
09:17:27 <Optimizer> I think window.getBrowser() will work now
09:17:59 --> flo has joined #instantbird
09:17:59 * ChanServ sets mode +qo flo flo 
09:19:06 <instantbot> New Instantbird (UI) bug 1453 filed by benediktp@ymail.com.
09:19:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1453 enh, --, ---, nobody, NEW, Update the list of messagestyle- and emoticon-themes when necessary
09:19:49 --> Tomek has joined #instantbird
09:21:56 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:22:11 --> Optimizer has joined #instantbird
09:22:37 <Mic> I need to go, remind me if I forget looking at your code, please
09:22:47 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
09:23:54 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:24:02 --> Optimizer has joined #instantbird
09:26:41 --> EionRobb has joined #instantbird
09:29:42 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:29:55 --> Optimizer has joined #instantbird
09:39:20 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:39:54 --> Optimizer has joined #instantbird
09:46:33 * flo is confused by bug 1451.
09:46:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1451 min, --, ---, nobody, UNCO, Instantbird wont close
09:46:41 <flo> it seems to be talking about the systray icon on Win7
09:48:52 <Optimizer> I have made my add-on work restartless
09:49:11 <Optimizer> but cannot unload it upon disabling/uninstalling
09:49:17 <Optimizer> the scripts still apply
09:49:58 <Optimizer> and the theme also still apply
09:53:46 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:54:01 --> Optimizer has joined #instantbird
09:56:10 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:56:27 --> Optimizer has joined #instantbird
09:57:13 <-- chrisccoulson has quit (Quit: Ex-Chat)
09:57:51 <Optimizer> Ah finally, the add-on's JS gets removed on disabling without restart
09:57:57 --> chrisccoulson has joined #instantbird
09:58:14 <Optimizer> but the theme will only unload on window restart
09:58:28 <Optimizer> is that okay for a restartless addon ? flo ?
09:58:40 <flo> what do you mean with "window restart"?
09:58:52 <Optimizer> close the conversation window
09:58:56 <Optimizer> and then open it again
09:59:07 <Optimizer> not just the tab, the whole window
09:59:17 <Optimizer> oh wait
09:59:26 <Optimizer> even then also the theme is still present
09:59:51 <flo> maybe look at my comments in bug 1453 and bug 302?
09:59:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1453 enh, --, ---, nobody, NEW, Update the list of messagestyle- and emoticon-themes when necessary
09:59:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=302 enh, --, ---, nobody, NEW, Dynamic theme switching
10:00:07 <flo> there are changes we need to make to the application itself for restartless themes to work
10:00:59 <Optimizer> hmm
10:01:14 <Optimizer> so will my add-on get approval as of now ?
10:01:32 <Optimizer> atleast the theme is applied without restart
10:01:49 <Optimizer> (although you need to choose from the options>themes panel)
10:02:00 <flo> you mean on AIO? I suspect it depends on how Mic feels about themes that can be installed but not uninstalled without restarts :)
10:02:30 <flo> I suspect it may get confusing for updates, but I don't really have a strong opinion either way
10:02:56 <flo> I think we should fix the issues in the application to make restartless themes easy; whether we can accept themes that can only install without restart for now; I don't know :)
10:03:04 --> clokep has joined #instantbird
10:03:04 * ChanServ sets mode +o clokep 
10:03:27 <Optimizer> Mic is also interested in restartless message themes
10:04:32 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:04:49 --> Optimizer has joined #instantbird
10:06:59 <Optimizer> flo: So I am applying for review on AIO
10:07:11 <Optimizer> flo: Lets see what Mic does
10:07:35 --> Mic has joined #instantbird
10:07:35 * ChanServ sets mode +h Mic 
10:08:21 <clokep> Can restartless extensions not do overlays?
10:08:32 <Optimizer> clokep: in firefox, not
10:08:53 <clokep> OK, well anything that applies to Firefox applies to us.
10:09:15 <flo> clokep: they can do overlay, but not from chrome.manifest
10:09:25 <clokep> Ah OK.
10:09:28 <Optimizer> overlaying means that when an xul is being loaded, we insert things at the right place and time
10:10:03 <Optimizer> flo: yes, from JS we can overlay anything
10:10:56 <Optimizer> if I have a conversation window open with some chat in it
10:11:06 <Optimizer> and I apply addTextModifier to it
10:11:13 <Optimizer> wont I see the changes directly ?
10:11:30 <Optimizer> on the already present chat
10:11:35 <flo> no
10:12:03 <flo> that method will just add a function that will be called each time new text is displayed
10:12:56 <Optimizer> okay, so I have the addTextModifier to highlight nick names right now
10:13:09 <Optimizer> and now I disable the addon (restartless)
10:13:17 <Optimizer> call your name : flo
10:13:23 <Optimizer> it is still highlighted
10:14:00 <Optimizer> close the conv window, re open, now highlighting is gone
10:14:31 <Optimizer> similar happens when I enable the add-on now
10:17:40 <clokep> Are you ever removing the text modifier (if that's possible)?
10:17:48 <Optimizer> yes I am
10:17:55 <Optimizer> when the window is reopened
10:17:57 <Optimizer> the changes apply
10:18:45 <Optimizer> because the whole conversation text is pushed in the window at that time, and then it takes account of any text modifier present or not
10:19:24 <Optimizer> so basically there is no way to remove/add text modifier in the opened window while the window is open.
10:20:42 <flo> the text modifiers seem to be per conversation rather than per window
10:21:02 <Mic> flo: I think so, I think they're loaded from the conversation binding iirc
10:22:06 <Mic> Is making it restartless worth the trouble?
10:22:28 <Mic> I mean there are things that need fixing for restartless themes before.
10:22:43 <Mic> See fl o's comments in the bugs I filed and bug 302 too.
10:22:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=302 enh, --, ---, nobody, NEW, Dynamic theme switching
10:22:48 <Mic> bbl
10:24:34 <clokep> aleth: Sorry for the confusing reviews by the way, I'm just not totally happy w/ the way that code is laid out yet...but I'm not sure exactly how it should be made better.
10:24:35 <Optimizer> this bug will also make the be default theme switching dynamic ?
10:24:44 <Mic> And isn't it worth to be split off into a separate extension, so it can be used with any theme people might like to use?
10:24:51 <Optimizer> by*
10:25:20 <Optimizer> like without any add-on also, the theme switching needs the conversation window to be reopened
10:25:50 <Mic> I meant the clickable links and nicknames in the conversation would be good to have even when one doesn't like to use the mibbit theme.
10:26:02 <Mic> And now I'm really gone btw ;)
10:26:16 <Mic> *clickable channel links
10:26:20 <Optimizer> oh
10:26:29 <Optimizer> I can fork that into a diff addon
10:26:39 <Optimizer> and anyways
10:26:43 <Optimizer> with the addon installed
10:26:48 <Optimizer> just choose any other them
10:26:51 <Optimizer> theme* :P
10:27:03 <Optimizer> the text modifier will still work
10:28:24 <Optimizer> so Mic: should I submit the add-on (restartless) ?
10:33:31 <clokep> Optimizer: I think that that's up to you (although Mi c might have an opinion).
10:33:44 <Optimizer> hmm, askinf Mic thus
10:33:47 <Optimizer> asking*
10:34:02 <Optimizer> that will he approve 
10:37:40 <-- EionRobb has quit (Quit: Leaving.)
10:42:49 <-- Optimizer has quit (Ping timeout)
10:54:57 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:57:50 <-- Mic has quit (Ping timeout)
11:01:36 --> Mic has joined #instantbird
11:01:36 * ChanServ sets mode +h Mic 
11:02:12 --> Optimizer has joined #instantbird
11:05:48 <Mic> I need to try what happens when a restartless theme is removed. If something breaks in that case, I'd prefer a normal extension for now.
11:08:47 <Optimizer> nothing breaks
11:09:05 <Optimizer> just that the theme does not unloads
11:09:19 <Optimizer> you converted your theme to be  a restartless also na ?
11:15:18 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
11:29:21 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:41:00 --> mmkmou has joined #instantbird
11:42:45 <-- mmkmou has quit (Ping timeout)
11:43:01 --> aleth has joined #instantbird
11:43:01 * ChanServ sets mode +h aleth 
11:47:18 --> mmkmou has joined #instantbird
11:47:26 --> clokep_work has joined #instantbird
11:47:26 * ChanServ sets mode +o clokep_work 
11:52:31 <FeuerFliege> hi
11:54:28 <-- jb has quit (Quit: jb)
11:57:00 <clokep_work> Hello FeuerFliege.
11:57:40 --> Lalae has joined #instantbird
11:57:59 <FeuerFliege> Do you know what normalizedName() does?
11:58:22 <clokep_work> In what context? :)
11:58:31 <-- Lalae has left #instantbird ()
11:58:54 --> jb has joined #instantbird
11:58:59 <aleth> Someone should tell Lalae how to remove something from the autojoin list ;)
11:59:06 <-- jb has quit (Quit: jb)
11:59:16 <FeuerFliege> e.g. aAccount.protocol.normalizedName
11:59:16 <aleth> Hi :)
11:59:29 --> jb has joined #instantbird
11:59:44 <-- jb has quit (Quit: jb)
11:59:58 --> jb has joined #instantbird
12:00:13 <FeuerFliege> it is often used but i couldn’t find out what is does.
12:00:46 <clokep_work> "it is often used"...OK, but where are you looking? Can I have an example?
12:00:59 <FeuerFliege> http://lxr.instantbird.org/instantbird/source/chat/components/src/logger.js#71
12:03:08 <aleth> clokep_work: Re the review, of course the logic is changed a bit, that's what fixes the bugs ;) But I'll see if I can clarify it a bit more. 
12:04:00 <clokep_work> FeuerFliege: I think it's just the name with special characters removed.
12:04:15 <clokep_work> aleth: I know that's why it's changed, what I mean is that it's now CONFUSING.
12:04:34 <clokep_work> I had a lot of trouble following what it's doing, why it's checking the same boolean multiple times, etc.
12:04:37 <aleth> clokep_work: Yes, I got that :P
12:05:04 <aleth> It's also why in the previous patch I didn't change changeBuddyNick, btw.
12:05:14 <aleth> But I think you're right that ultimately this way will be better.
12:06:49 <clokep_work> Yeah I originally didn't think it was necessary, but I'm thinking it'll make the logic a lot simpler. :(
12:07:17 <clokep_work> I think I originally didn't print the messages in there btw so that I wouldn't be building the message every time, but I doubt we really need to care about that efficiency, especially when it cleans the code up a lot.
12:07:46 <aleth> I knew it would be a bit more complicated, which is why initially I didn't go that route, but I think it will be more robust in the end.
12:08:02 <clokep_work> (Btw, kind of related, there's the case of where who you're talking to in a private message changes their nick...we don't handle that at all anymore since the target of the conversation is changing, but it'd probably make sense to auto switch it if you know...)
12:08:09 <clokep_work> Yes, I agree. :)
12:08:24 <clokep_work> If it makes sense to add an "updateNick" to the ircConversation, feel free to do that too.
12:08:52 <aleth> It already has one.
12:09:09 <aleth> And I think that case is handled, but I'll check.
12:11:16 <clokep_work> Ah, I see!
12:12:06 <clokep_work> I think it's only used when we're changing our own nick.
12:12:14 <clokep_work> (Or only when they're changing their nick?)
12:12:20 <aleth> When they are changing theirs.
12:12:26 <clokep_work> Yeah, theirs.
12:12:40 <aleth> Bug 1403 (which I fixed in that patch along the way) is when you change yours.
12:12:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1403 min, --, ---, nobody, NEW, /nick response not shown in IRC conversations
12:12:58 <clokep_work> Yeah, I saw that. :)
12:17:24 <clokep_work> I think this is one of those bugs of the variety of "Oh, this is like a 5 minute fix...three hours later..."
12:18:44 <aleth> Yes, definitely.
12:19:13 <aleth> I kept discovering new little bugs with each patch too :-/
12:21:49 <FeuerFliege> clokep_work: You mean something like encodeURI() ? It seems to have stopped working. In May 2011 instantbird used names without special characters for log directories, but now nothing(?) is removed or replaced. I tested #foo&bar, #foo→bar, #foo'bar and even #foo°§ℓ»«$€„. The resulting folders are named exactly like that. 
12:22:57 <clokep_work> FeuerFliege: Do you know when it changed? May 2011 to May 2012 is a rather large difference. :)
12:22:59 <flo> FeuerFliege: if this change of behavior happened recently and only for IRC (and Gtalk/Facebook Chat), it's probably a bug ;)
12:23:11 <clokep_work> Yea, I was just wondering that.
12:25:17 --> Mic has joined #instantbird
12:25:17 * ChanServ sets mode +h Mic 
12:25:52 <FeuerFliege> no i don’t know exactly. I just found a old profile with „flo%7cneo2@irc.freenode.net“ as folder name. The logs of this folder are from 2011-05-30 and 2011-05-31
12:27:02 <clokep_work> The current normalize is supposed just remove anything that isn't a-z0-9: http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#59
12:27:05 <clokep_work> (For JS accounts)
12:27:54 <-- mmkmou has quit (Ping timeout)
12:27:59 <flo> clokep_work: by the way, mconley usually works from the Toronto office ;)
12:28:41 <FeuerFliege> clokep_work: but that is “normalize“ not ”normalizedName“
12:29:15 <clokep_work> flo: Hah, well then he gets up really late. :P
12:29:33 <clokep_work> FeuerFliege: http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#705
12:31:00 <flo> clokep_work: what do you mean with "really late"? I don't think mozilla developers come into their office before 9am (which is already very early for geeks)
12:31:18 <flo> clokep_work: and I think today is a holiday in Canada
12:31:26 --> mmkmou has joined #instantbird
12:34:12 <clokep_work> flo: I thought he came in more around 10, but who knows. :) Everything seems "really late" to me, I'm at work before most of my friends get up.
12:34:57 <flo> but you seem to work in the middle of the night ;)
12:35:13 <clokep_work> OK OK, I'm the weird one. :P
12:38:18 * clokep_work wonders what time wnayes will "come to work" today. ;)
12:39:21 <flo> is it the official start date for the coding period?
12:39:39 <Mic> GSoC officially starts today, if I'm not mistaken
12:40:19 <Mic> Ah yes, flo's wording might be more correct ;)
12:40:59 <clokep_work> Yup.
12:41:18 --> Lalae1 has joined #instantbird
12:44:07 <clokep_work> Lalae1: You can remove chats from your auto-join list if you don't want to have them pop up every time. :)
12:46:39 <flo> aleth: that test will always return true
12:46:43 <Lalae1> I know, thanks :)
12:47:30 <aleth> flo: Because the object is not removed if it is still bound to a handler?
12:47:32 <-- Lalae1 has left #instantbird ()
12:48:01 --> Lalae has joined #instantbird
12:48:37 <aleth> Lalae: You can stop IB from autojoining #Instantbird every time btw!
12:48:46 <clokep_work> I just said that. ;)
12:48:51 <clokep_work> And she responded :P
12:49:08 <aleth> I missed that, sorry :)
12:49:23 <clokep_work> It's fine. I'm just in a bad mood as I'm writing C++ code that's seg faulting all over the place.
12:49:24 * instantbot frowns at clokep_work
12:49:33 <Lalae> thank you guy but it's not a problem, I just clik "close conversation" and here we go :)
12:49:36 * aleth is doing too many things at the same time
12:50:17 <aleth> clokep_work: Segfaulting C++ would put anyone into a bad mood.
12:51:28 <flo> especially on OSes where it's not possible to clearly identify the cause :-P
12:53:20 <clokep_work> flo: Actually I got the MSVC debugger working (at work at least) with MATLAB and it works really well...
12:53:38 <clokep_work> Except that it also takes down Matlab when I segfault, so I constantly end up restarting it...
12:54:04 <clokep_work> So I can actually debug things in Instantbird now if I get crashes. ;) ... well hopefully...
12:54:52 <flo> clokep_work: by "clearly identify the cause" I meant having valgrind logs telling you what bad thing happened to the memory ;)
12:56:38 <clokep_work> Ah, yes. Neer mind. :0
12:56:47 <clokep_work> I thought you just meant that dbg doesn't run (well?).
12:56:51 <clokep_work> Anyway I'll be back later. ;)
12:58:50 <flo> the MSVC debugger is quite good for some use cases (especially understanding how some pieces of code work), but not very helpful for random segfaults
13:12:08 <-- aleth has quit (Input/output error)
13:12:50 --> aleth has joined #instantbird
13:12:50 * ChanServ sets mode +h aleth 
13:19:40 <Mic> Does this look OK for bug 1449: http://pastebin.instantbird.com/43053 ?
13:19:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1449 enh, --, ---, nobody, NEW, Make initialization state of Core available and send notification when initialization finishes.
13:21:05 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
13:38:13 <-- GeekShadow has quit (Ping timeout)
13:40:32 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1498 on bug 1446.
13:40:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1446 nor, --, ---, aletheia2, ASSI, Reset nick modified due to nick collision when disconnecting the account
13:41:47 <flo> Mic: why are you moving the |this._initialized = true;| ?
13:45:43 <-- Optimizer has quit (Ping timeout)
13:46:38 --> Optimizer has joined #instantbird
13:51:16 <-- Optimizer has quit (Ping timeout)
13:56:10 --> Optimizer has joined #instantbird
13:56:53 <Mic> It seemed 'more right' to me to move it at the end and set it when everything has finished (and group it with sending the notification).
13:57:26 <Mic> If there's anything wrong with it, I'll revert that.
13:58:20 <Mic> Are you concerned about sideeffects that this might have or about introducing an unnecessary change?
13:58:22 <flo> I think there used to be a reason for it to be set specifically where it was set, but that reason may no longer be applicable
13:58:52 <flo> when all this code was in C++, lots of other parts of the code would return early if the code service wasn't initialized
13:59:01 <flo> *core service
13:59:07 <-- Lalae has quit (Ping timeout)
14:03:19 <flo> Mic: what's the use case for your new notification? Didn't you want to use it to register restartless prpls?
14:03:52 <-- Optimizer has quit (Ping timeout)
14:04:01 <flo> if so, it should definitely be before the processAutoLogin call
14:06:09 <Mic> No, I want to use it to re-connect accounts after a restart.
14:06:57 <flo> so it should really be after autologin has been processed?
14:07:32 --> Optimizer has joined #instantbird
14:09:55 <Mic> Do you think it would help someone to have it before (I think I'd be fine with either case) it?
14:10:36 <Mic> Ah, move the bracket to the end of the line please ;)
14:11:59 <flo> it's difficult to think about this without having use cases in mind
14:14:44 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1496 on bug 1450.
14:14:45 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1499 on bug 1450.
14:14:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1450 nor, --, ---, aletheia2, ASSI, Only remove unread ruler when switching away from a tab if tab has been visible for a certain time
14:17:40 <Mic> Maybe before might be better since if someone wants to wait for the auto-logins to finish, he can still observe "autologin-processed"?
14:18:12 <flo> I was thinking this too
14:19:20 <clokep_work> :-S I fear I've been giving bad reviews
14:20:05 <flo> is that worse than no review at all? I fear I've waited for too long in lots of bugs ;)
14:22:30 <clokep_work> Right. :)
14:28:41 --> mmkmou has joined #instantbird
14:32:24 <FeuerFliege> I don’t get why normalizedName doesn't strip any special characters in logger.js. But this may caused by my lack of code reading skills :)
14:32:27 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 1500 on bug 1449.
14:32:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1449 enh, --, ---, benediktp, ASSI, Make initialization state of Core available and send notification when initialization finishes.
14:33:47 <-- jb has quit (Ping timeout)
14:34:07 <clokep_work> FeuerFliege: Did you try putting in any debug statements?
14:35:28 <aleth> FeuerFliege: It may be the JS-IRC normalize() in irc.js does not strip those characters?
14:36:06 <aleth> (if you were testing with IRC mainly)
14:36:08 <clokep_work> aleth: I don't think we overwrite that function (I checked briefly, but didn't really play w/ it).
14:36:23 <aleth> clokep_work: I think normalizedName is overridden
14:37:15 <aleth> http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#350
14:37:21 <aleth> http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#242
14:37:45 <clokep_work> aleth: I think it uses the one on the protocol object, but maybe I'm wrong.
14:37:47 <aleth> But I haven't followed the code path from the logger either.
14:38:00 <aleth> FeuerFliege: Maybe add some dump() statements to find out? ;)
14:38:05 <clokep_work> Or maybe it uses all of them. I didn't read the logger code.
14:38:34 <FeuerFliege> aleth: I’ll try
14:38:35 <flo> so it's http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#532
14:38:39 <flo> what did libpurple do?
14:38:53 <clokep_work> Oh, bleh... http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#64 yeah I probably overwrite that incorrectly then.
14:43:10 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
14:47:27 --> GeekShadow has joined #instantbird
14:56:36 <clokep_work> FeuerFliege: Can you file a bug about this please (unless you did already?)
14:57:07 <FeuerFliege> I will file it.
14:57:27 <clokep_work> Thanks. :)
15:01:48 <-- NmN has quit (Quit: Instantbird 1.1)
15:12:32 --> jb has joined #instantbird
15:28:37 --> wnayes has joined #instantbird
15:30:58 <instantbot> New Core - General bug 1454 filed by bugi@media.fjmail.de.
15:31:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, nobody, NEW, logger.js uses wrong normalizedName()
15:31:42 <-- jb has quit (Quit: jb)
15:32:50 <instantbot> bugi@media.fjmail.de requested feedback from the wind for attachment 1502 on bug 1108.
15:32:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
15:33:41 * FeuerFliege BBQ yammi
15:34:05 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:34:41 <-- FireFly_TB has quit (Quit: FireFly_TB)
15:34:50 * wnayes is happy to start working on the account importer project today :)
15:35:42 <flo> )
15:35:51 --> FireFly_TB has joined #instantbird
15:35:56 <-- FireFly_TB has quit (Quit: FireFly_TB)
15:36:08 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:36:17 --> aleth has joined #instantbird
15:36:18 * ChanServ sets mode +h aleth 
15:40:49 <wnayes> flo: In my project outline, I set aside quite a few days for planning the details of the project. Currently I'm thinking it would not be a bad idea if I began work on some of the code a bit sooner :)
15:41:24 <flo> wnayes: I think there were some UX details that needed to be clarified
15:41:46 <flo> but it's quite possible that some parts of the coding work can start without the UI being fully defined
15:42:36 <-- wnayes has quit (Ping timeout)
15:43:11 <flo> if you want to start working on back-end code (like some helper code check if some files exist on the system, or if some registry entries exist, etc...) that has no reason to be blocked by UX discussions :)
15:43:35 <aleth> wnayes: Have you seen the wiki page the other candidate for the project made?
15:44:19 <clokep_work> The interface design probably needs to be thought of a bit fairly early on.
15:44:45 <flo> I think wnayes already spent some time thinking about it while preparing his proposal :)
15:45:02 <flo> but we need to review it carefully to ensure we agree not only overall, but also in the details
15:45:21 <clokep_work> Right, we need to make sure it makes sense and that there weren't other details to discuss!
15:49:43 --> wnayes has joined #instantbird
15:50:16 <wnayes> sorry about that, there was a power outage planned for today
15:50:50 <flo> clokep_work: do you see something changed on http://crash-stats.instantbird.com/query ? :)
15:51:03 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
15:51:45 <clokep_work> flo: We can actually filter by version?!
15:51:52 <clokep_work> I'm assuming I can than kEven for this? :)
15:51:54 <flo> )
15:52:01 <flo> right :)
15:53:15 <wnayes> aleth: I have seen that wiki page, lots of details there :)
15:53:42 <wnayes> here was the project page I submitted: http://www.tc.umn.edu/~nayes006/gsoc/instantbird.php
15:55:46 <clokep_work> Right. It has a bit of thought into an interface, it seems (in a round about way).
15:56:24 <flo> I don't understand what's the expected user interaction with http://www.tc.umn.edu/%7Enayes006/gsoc/instantbird_accountsWizardSelect.png
15:57:18 <clokep_work> flo: You'd want more of a "Yes, import my accounts!" and it just finds them all?
15:57:45 <flo> I would like it to list only clients that have been used on the system before
15:57:51 <aleth> Checkboxes not radiobuttons?
15:58:08 <flo> "aleth: Checkboxes not radiobuttons?" <- exactly what I was typing
15:58:23 <flo> (although I was writing a longer sentence to say the same thing)
15:58:34 <wnayes> flo: I think I wrote something about that near the image, I was planning to have only the available clients listed
15:58:46 <wnayes> I would agree on the checkbox idea though :)
15:59:07 <flo> right, you wrote "When the wizard is opening, a simple scan for currently installed messaging clients will run. Based on the results, only the detected clients will be shown to the user." before that image
16:00:02 <flo> I think I would like the list in http://www.tc.umn.edu/%7Enayes006/gsoc/instantbird_wizardUserSelect.png to look much more like the account manager
16:00:19 <-- meh` has quit (Quit: I don't want to live on this planet anymore.)
16:01:04 <clokep_work> Also, something else with that list (brain dumping here, disregard perhaps?), account conflicts need to be taken into account, including if you've already added an account.
16:01:15 <flo> wnayes: would you like to spend time discussing the UI/UX, or would you prefer that I create some mockups of what I would do, so that you can focus instead on the code?
16:02:02 <flo> clokep_work: sure. Something I had in mind; that would actually deserve radioboxes I think :).
16:02:34 <aleth> That would be on the second page I guess
16:02:56 --> myk has joined #instantbird
16:03:16 <aleth> Maybe have the first page organised by clients-to-scan, the second organised by protocol?
16:03:32 --> meh has joined #instantbird
16:03:33 <wnayes> flo: I think discussing UI/UX is valuable, but some mockups would help visualize the ideas :)
16:03:43 <flo> aleth: why do you want a list of clients to scan?
16:03:57 <aleth> That's what he has on his first page atm if I understand correctly
16:04:13 <flo> I think the only reason to ask the user before scanning is if we need to contact some servers in the process (for Digsby, etc...)
16:04:43 <flo> and I don't think wnayes wanted to focus on these difficult cases
16:04:47 --> Mic has joined #instantbird
16:04:47 * ChanServ sets mode +h Mic 
16:05:01 <aleth> The user could prevent some conflicts at that stage ("oh, I know I have AIM installed, but I haven't used it in years. I use Pidgin now")
16:05:03 <wnayes> aleth: The initial scan would simply detect the presence of the clients, and would not be user prompted (as in the proposal).
16:06:09 <aleth> wnayes: Right, and then the user selects from which clients to read account data
16:06:18 <aleth> (or did I get that wrong)
16:06:55 <aleth> fl o's idea is to skip that step and just scan for all the accounts you can get
16:07:31 <wnayes> aleth: Right, I think that would handle the conflict you described.
16:08:58 --> wesj has joined #instantbird
16:09:50 <clokep_work> wnayes: aleth But what if I used AIM, switched to Pidgin (OK...they have the same accounts), but I'd /really/ like my logs from both...
16:09:52 <Mic> aleth: wouldn't you still have to import logs from the older client in a case like that with AIM/Pidgin?
16:10:01 <clokep_work> Mic: Ah, great minds. ;)
16:10:02 <Mic> clokep++
16:10:34 <clokep_work> So I think you want to handle the conflict after trying to import from both clients. (Where hopefully the account information is the same anyway.)
16:10:53 <flo> what about importing from both, and asking if there's a real conflict? (different password stored in the different clients)
16:11:19 <flo> bah, clokep++ I guess :-D
16:12:19 <-- meh has quit (Quit: ole')
16:13:41 <wnayes> The idea behind http://www.tc.umn.edu/~nayes006/gsoc/instantbird_wizardUserSelect.png was that the user would have the ability to grab account info only from one account and log data from another, as an example.
16:14:15 <clokep_work> Right...I guess, what we're asking is how much more difficult would it be to do this "automatically"?
16:14:39 <clokep_work> I don't really have tools to do a mock up...bah one second.
16:20:41 --> meh has joined #instantbird
16:21:33 <clokep_work> Bah: Sorry for my awful drawing skills: http://imgur.com/qtut6
16:24:21 <flo> can logs conflict?
16:25:36 <clokep_work> flo: No, you're right, it should probably only show a list of conflicted information and automatically import everything from the others.
16:25:54 <clokep_work> (The other option, by the way is to just try both and see which works. :-D)
16:26:15 <flo> if we could find a last modified date for the information, that would be nice too ;)
16:30:35 <-- Optimizer has quit (Ping timeout)
16:30:54 --> Optimizer has joined #instantbird
16:32:06 <clokep_work> Are we starting to see the necessary information we'll need then?
16:33:33 <clokep_work> (I guess that's directed toward wnayes :-D)
16:37:08 <wnayes> clokep_work: I think the discussion has been productive so far :) Deciding on exactly how much the wizard will handle conflicts vs. the user having control is a tough topic.
16:37:58 --> EionRobb has joined #instantbird
16:38:16 <flo> wnayes: what about "the wizard handles everything automatically if the user clicks 'next', and lets the user configure if a 'details'/'advanced'/whatever button is clicked"?
16:39:41 <-- EionRobb has quit (Ping timeout)
16:40:24 <wnayes> flo: I think that sounds good. Would this be right at the wizard launch or only when conflicts arise?
16:40:54 <flo> "this" = ?
16:42:26 <wnayes> flo: misread a bit, was thinking you meant more of a page that would ask if everything should be automatic or configured.
16:42:54 <wnayes> In this case, it wouldn't be at launch :)
16:46:11 <Mic> Idea: if you can read logs you could use the dates of the latest logs to estimate when the associated account was connected for the last time in a client.
16:47:49 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
16:50:24 <wnayes> I wrote up a possible outline of what files need to be written/where they could go: http://www.tc.umn.edu/~nayes006/gsoc/codeChanges.txt
16:50:47 <wnayes> I'm less familiar with the chat/ directory, so feel free to suggest a different layout :)
16:52:33 --> meh has joined #instantbird
16:52:50 <clokep_work> wnayes: I think chat/importers or something like that would make more sense, but that's still not great.
16:52:57 <flo> wnayes: .manifest files are usually to register xpcom components (or to register packages in the chrome registry), modules don't need them
16:53:17 <clokep_work> Also what do you mean by "The main account importer logic"? :)
16:53:39 --> FireFly_TB has joined #instantbird
16:53:47 <flo> that could well be a component for chat/components/src/
16:54:33 --> FeuerFliege has joined #instantbird
16:54:48 <flo> you will probably have at least one JS module to share code between the various importers though
16:54:59 <clokep_work> And chat/components/public will need an idl about what each importer needs to implement.
16:55:17 <wnayes> clokep_work: I was thinking UI would interact with a main importer component, which would handle all of the clients
16:55:35 <flo> I'm not sure if that will be a new wizard, or part of the current accountWizard.xul file
16:55:58 <flo> if you can't import anything, you will want to fallback to the current wizard, won't you?
16:58:47 <Mic> How would you start the import wizard?
16:59:08 <flo> when the profile is empty
16:59:11 --> myk1 has joined #instantbird
16:59:12 <-- myk has quit (Connection reset by peer)
16:59:24 <flo> or if you want to open it from some menu, give an argument to the window
17:00:02 <flo> the magic textbox thing is great when it works, but when it doesn't, it's really a pain :(
17:00:58 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
17:01:22 <wnayes> flo: I didn't think of adding it to the current wizard, as I thought of the two activities as separate tasks.
17:01:56 <flo> during the first start-up, what would you display?
17:05:12 <wnayes> In that case, a page asking the user whether they would like to import/configure new accounts. I guess my main concern was bloating the accountWizard code and having to handle more of the back/next disconnects :)
17:05:20 <FeuerFliege> I would like if at first start-up a scan is performed. If other IMs found → import wizard else account wizard
17:05:51 <-- gerard-majax has quit (Ping timeout)
17:06:07 <flo> if we can go from one to the other, we are in the same window...
17:06:34 <flo> (on Mac closing/opening a modal dialog is animated, so you can't hope that closing a wizard and opening a different one immediately will be invisible)
17:09:06 <wnayes> flo: What FeuerFliege said makes sense. Startup is an interesting case as both use cases could be wanted, while at a later time only one might be (window arguments could change initial displayed page I suppose)
17:09:20 --> Kaishi has joined #instantbird
17:09:26 <clokep_work> I think that doing it as part of the same wizard makes sense yes, when you get to the end of the import wizard you probably want an "Add other accounts" button which goes to the top protocols page.
17:10:19 <flo> would you want an "add another account" button after configuring a new account?
17:11:06 <clokep_work> Possibly.
17:11:12 <clokep_work> I'm not sure. :)
17:11:12 <flo> the summary step should probably list both imported accounts and accounts the user created
17:11:45 <flo> do we want to import the logs before closing the wizard, or can we do it in the background after we are already starting to connect the accounts?
17:12:22 --> Lalae has joined #instantbird
17:12:59 <clokep_work> In the background would be nicer probably.
17:13:08 <clokep_work> But you'd have to worry about closing Instantbird, etc. before it's done.
17:13:09 <-- Lalae has left #instantbird ()
17:14:08 <flo> or saving somewhere the list of the import task that need to be completed in the background
17:14:20 <flo> *tasks
17:20:47 <wnayes> flo: Having background tasks sounds interesting, but would it be within the scope of a summer project?
17:21:06 <flo> why not?
17:21:39 <flo> also, you don't have to do everything yourself within 2 months ;)
17:21:51 <wnayes> I guess I'm not sure how much time it would involve to implement something like that.
17:22:08 <flo> you can ask for help. If some parts are a bit too challenging we can do more than just discussing ideas and reviewing code ;)
17:22:59 <flo> wnayes: I think in the context of the summer project, you will want to ensure that you have something in a shippable state by the end of the summer
17:23:53 <flo> so I would advise you to not bother with importing logs at all for the very first version (which hopefully you will have finished half way through the summer :))
17:24:50 <flo> also, from my point of view, the challenging part about importing logs is parsing them; especially when it's very likely that information will be missing (I can tell you for sure that Pidgin txt logs are not machine parsable without doing some speculation)
17:25:14 <flo> whether the computation is done while the wizard is visible or later in the background won't change much the complexity
17:25:53 <clokep_work> Right, an iteration could be done where it's not in the background, then that code gets moved to a background task later on.
17:26:42 <wnayes> flo: Makes sense :) I was also wondering how you would want me to organize this project (mercurial, git, online someplace, etc.)?
17:28:00 <wnayes> A large mq patch doesn't seem like the way to go ;)
17:28:02 <clokep_work> My thoughts had been a Mercurial queue (synched to hg.instantbird.org or your own place or whatever) or even a branch.
17:28:34 <clokep_work> You could do them as separate patches and not fold them together until the end. ;)
17:28:49 <flo> I think we have several different user targets: 1. Users who may not remember their credentials used for previous clients (or not even understand that they don't have to register new accounts when switching to another client). 2. Users who would try Instantbird but only with a single account because they are too lazy to configure them all, and then don't see the true potential of the application. 3. Advanced users who worry about keeping all t
17:28:56 <flo> they have quite different needs I think :)
17:30:15 <flo> wnayes: you probably want to use mercurial in some way. Whether it's on a mercurial repository hosted on hg.instantbird.org, on bitbucket, or on your own server is probably up to you (as long as it's publicly visible)
17:30:39 <flo> either with mq, or a branch of our main repository.
17:33:39 <wnayes> Would a branch in http://hg.instantbird.org/experiments/ work? I think something on hg.instantbird.org would be the way to go.
17:34:05 <flo> I can create a separate repository for you
17:34:33 <clokep_work> Bonus points if it sync to instantbird automatically? :P
17:35:21 <flo> clokep_work: are you sure that's possible?
17:35:33 <flo> wouldn't conflicts need to be handled by hand anyway?
17:36:46 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:37:20 <clokep_work> Yeah, I don't think it is flo.
17:37:57 <clokep_work> I don't expect many conflicts from it though. :)
17:48:43 <wnayes> flo: A separate repository would probably be better than a branch. I think that will be a good way to keep the project organized and visible to everyone.
17:50:25 --> gerard-majax has joined #instantbird
18:01:02 --> Mic has joined #instantbird
18:01:02 * ChanServ sets mode +h Mic 
18:04:05 * myk1 is now known as myk
18:11:22 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
18:12:17 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
18:13:29 --> Mic has joined #instantbird
18:13:29 * ChanServ sets mode +h Mic 
18:14:29 <-- Mic has quit (Input/output error)
18:15:03 --> Mic has joined #instantbird
18:15:03 * ChanServ sets mode +h Mic 
18:21:59 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 1503 on bug 1071.
18:22:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1071 enh, --, ---, benediktp, ASSI, Improve look of contact drop target
18:22:25 <clokep_work> If anyone is curious, MPL 2 landed on Mozilla, so if you pull it'll be a lot of changes...
18:22:40 <clokep_work> And seems like gerv is looking to do c-c "soon", so we'll need to merge chat/ changes from ther ein.
18:25:43 --> meh has joined #instantbird
18:27:46 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :()
18:28:59 --> Mnyromyr has joined #instantbird
18:38:30 <clokep_work> Mic: Thta looks nice. :)
18:38:54 <-- mmkmou has quit (Client exited)
18:40:11 * jwir3 is now known as jwir3|lunch
18:44:41 <aleth> Mic: That looks so much better than what we have now :)
18:53:33 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
18:54:40 --> meh has joined #instantbird
18:59:14 <-- FireFly_TB has quit (Quit: FireFly_TB)
18:59:34 --> FeuerFliege_Daily has joined #instantbird
19:00:26 <-- FeuerFliege_Daily has quit (Quit: FeuerFliege_Daily)
19:00:36 --> FeuerFliege_Daily has joined #instantbird
19:00:40 <-- FeuerFliege_Daily has quit (Quit: FeuerFliege_Daily)
19:00:55 --> FireFly_TB has joined #instantbird
19:03:17 --> DGMurdockIII has joined #instantbird
19:13:05 <-- Tonnes has quit (Connection reset by peer)
19:16:09 <-- FireFly_TB has quit (Quit: FireFly_TB)
19:17:20 --> FireFly_TB has joined #instantbird
19:18:12 <aleth> With a completely new profile, I just experienced this._proxyCancel is null errors when 1) creating a twitter account 2) cancelling the Oauth window 3) deleting the twitter account. Trying to add an IRC account at this stage leads to an account that says "Disconnecting..." and can't be connected. 
19:18:25 <aleth> Thought I'd mention this as potential STRs for these known bugs
19:21:44 <-- FireFly_TB has quit (Ping timeout)
19:21:53 <-- FeuerFliege has quit (Ping timeout)
19:21:54 <-- meh has quit (Quit: hahaha)
19:22:19 <aleth> In fact I'm also seeing  this._proxyCancel is null errors if I create a new profile and try to add an SSL IRC account. Again it just says "Disconnecting..."
19:22:46 <aleth> At this point IB hangs and must be terminated manually.
19:23:27 * jwir3|lunch is now known as jwir3
19:23:57 --> Tonnes has joined #instantbird
19:25:28 --> FeuerFliege has joined #instantbird
19:26:35 --> meh has joined #instantbird
19:27:02 --> FireFly_TB has joined #instantbird
19:27:07 * aleth is now known as aleth-2
19:27:30 * aleth-2 is now known as aleth
19:27:43 <-- aleth has quit (Input/output error)
19:29:56 --> aleth has joined #instantbird
19:29:56 * ChanServ sets mode +h aleth 
19:36:41 <-- Optimizer has quit (Ping timeout)
19:40:05 --> Optimizer has joined #instantbird
19:41:50 <aleth> log.bezut.info is down?
19:43:14 <clokep_work> aleth: WFM.
19:45:02 --> Mic has joined #instantbird
19:45:03 * ChanServ sets mode +h Mic 
19:47:08 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
19:50:08 --> meh has joined #instantbird
20:03:08 <-- Optimizer has quit (Ping timeout)
20:04:44 --> BYK has joined #instantbird
20:06:29 --> Optimizer has joined #instantbird
20:10:06 <-- FeuerFliege has quit (Ping timeout)
20:10:06 <-- FireFly_TB has quit (Ping timeout)
20:38:10 --> gpsychosis has joined #instantbird
20:42:42 <Mic> flo: http://pastebin.instantbird.com/43082 -> are these comments OK now? Or would you prefer something more generic like "core services" with no mention of the specific parts?
20:44:42 <clokep_work> Mic is that true? Can you still use things with prpl-quit is received?
20:44:50 <clokep_work> I thought at that point you have to stop calling those services immediately?
20:44:56 <clokep_work> (As they've been destroyed already.)
20:45:21 <Mic> That's one thing why I'm asking flo ;) Judging from the code I'd say yes, though.
20:45:56 <Mic> http://lxr.instantbird.org/instantbird/source/chat/components/src/imCore.js#308
20:46:51 <clokep_work> Really? Judging from the code I'd say you CAN'T use anything, as they immediately get uninitialized after notifying everyone.
20:47:03 <clokep_work> (It's not like the core service waits for the observers to tell it that it's OK to continue.)
20:47:39 <Mic> Doesn't notifyObservers imply waiting for the observers to return?
20:48:15 <clokep_work> I don't know.
20:48:35 <clokep_work> Never really looked at the implementation of it, I always assumed it was async. But I don't know why. :)
20:50:11 <Mic> Neither did I but I assumed it to not be async ;)
20:50:49 <clokep_work> Hahah, the documentation doesn't actually say.
20:51:11 * clokep_work has no idea why he thinks it async and not sync...
20:51:34 <Mic> I guess we need Mook now? ;)
20:51:57 <clokep_work> Hmm...I think flo said it's a holiday in Canada.
20:53:51 <-- Optimizer has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:54:12 <Mic> Is that the right place, maybe: http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/nsObserverService.cpp#137 ?
20:56:23 <Mic> + http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/nsObserverList.cpp#90
20:57:06 <clokep_work> Yeah, I had checked that, but wasn't confident it didn't do crazy things in the observe method. :)
20:57:17 <clokep_work> I have a feeling you're right and it's sync though.
20:57:53 <Mic> Let's wait what flo's got to say on this :)
20:59:18 <-- gpsychosis has quit (Ping timeout)
21:00:24 --> EionRobb has joined #instantbird
21:26:22 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:27:00 --> flo has joined #instantbird
21:27:00 * ChanServ sets mode +qo flo flo 
21:28:34 <flo> Mic: seems ok.
21:28:45 <flo> Services.obs.notifyObservers is definitely synchronous
21:30:02 <flo> http://log.bezut.info/instantbird/today#m604 sounds pretty bad :(
21:32:31 <-- Tomek has quit (Quit: Instantbird 1.1)
21:36:49 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:37:11 <flo> Good night
21:37:13 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:38:33 --> Tomek has joined #instantbird
21:40:27 * jwir3 is now known as jwir3|coffee
21:41:36 --> aleth has joined #instantbird
21:41:36 * ChanServ sets mode +h aleth 
21:48:53 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 13.0/20120516113045])
21:49:50 * Mic is seeing something like bug 523.
21:49:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=523 min, --, ---, nobody, RESO WORKSFORME, Strange glitch when creating a new account
21:50:19 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
21:52:13 <instantbot> New Core - General bug 1455 filed by aletheia2@fastmail.fm.
21:52:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1455 maj, --, ---, nobody, NEW, Instantbird with fresh profile hangs on attempting to add IRC account
21:54:34 <instantbot> benediktp@ymail.com cleared the Resolution 'WORKSFORME' from bug 523.
21:54:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=523 min, --, ---, nobody, REOP, Strange glitch when creating a new account
22:00:31 <aleth> Mic: Maybe give that bug a more specific title?
22:01:22 <Mic> aleth: I can confirm bug 1455 btw
22:01:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1455 maj, --, ---, nobody, NEW, Instantbird with fresh profile hangs on attempting to add IRC account
22:01:47 <aleth> It's not good :(
22:02:22 <aleth> So I guess it's OS-independent.
22:05:12 <Mic> Good night
22:05:21 * jwir3|coffee is now known as jwir3
22:05:25 <-- Mic has quit (Connection reset by peer)
22:17:19 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
22:27:24 --> Lalae has joined #instantbird
22:27:40 <-- Lalae has left #instantbird ()
22:35:44 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:38:52 --> FeuerFliege has joined #instantbird
22:38:52 --> FireFly_TB has joined #instantbird
22:40:37 <-- FireFly_TB has quit (Ping timeout)
22:40:37 <-- FeuerFliege has quit (Ping timeout)
22:47:18 --> clokep has joined #instantbird
22:47:18 * ChanServ sets mode +o clokep 
22:48:04 <-- Tomek has quit (Quit: Instantbird 1.1)
22:53:10 <clokep> aleth: Changing to SSL doesn't change the port because we have no way to link things like that. :(
22:53:54 <clokep> I'm using SSL on my account though and it works fine. I'm not sure why this would behave differently than a new profile. :(
22:54:27 <aleth> clokep: Yes, I understand it would be tricky to make better, or I would have filed a separate bug. Best left as part of the general IRC account wizard overhaul.
22:54:41 <clokep> I disagree. ;) But OK.
22:54:47 <aleth> I'm using SSL too. Nevertheless the STR work
22:54:58 <aleth> You have an idea for how to fix it quicker?
22:55:07 <aleth> Then you should file it ;)
22:55:48 <clokep> I don't have an idea, it's just an entirely unrelated issue (and applies to other account types).
22:55:52 <clokep> I'll file it after I eat.
22:56:04 <clokep> I believe you that the STR work, I'm just confused by them. :-S
22:56:13 <aleth> Me too :(
22:59:37 <clokep> I wonder if ticking the option on and off in a working profile will ake it stop...
23:06:40 <aleth> I mean, I don't even understand why it is disconnecting anything?
23:09:26 <clokep> aleth: So I got two _proxyCancel is null things, and then it connected.
23:09:30 <clokep> But that wasn't a totally clean profile.
23:11:48 <aleth> Sounds like there might be a race condition involved somewhere?
23:28:31 --> gpsychosis has joined #instantbird
23:42:04 --> FireFly_TB has joined #instantbird
23:43:41 * clokep forgets how to get a stack trace in JS... :-S
23:47:23 <aleth> Components.Exception.stack ?
23:48:12 <aleth> ah, no
23:48:27 <clokep> Components.stack gives you the stack, but I thought there was an easy way to just print the whole stack.
23:49:04 <clokep> Ah, here it is. :) https://developer.mozilla.org/en/Debugging_JavaScript#Call_stack
23:49:28 --> FeuerFliege has joined #instantbird
23:49:46 <aleth> ah, nice
23:55:14 <-- chrisccoulson has quit (Quit: Ex-Chat)