All times are UTC.
00:05:04 <instantbot> aletheia2@fastmail.fm denied review for attachment 1473 on bug 1369. 00:05:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1369 enh, --, ---, clokep, ASSI, Support WATCH and MONITOR for IRC 00:07:21 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 00:07:58 <instantbot> New Core - IRC bug 1433 filed by aletheia2@fastmail.fm. 00:08:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1433 nor, --, ---, nobody, NEW, Switching status from OFFLINE to UNAVAILABLE actually sets status to AVAILABLE 00:09:01 <clokep> aleth: You prefer that style for the if statement...because requesting it removes it anyway? 00:09:10 <aleth> Yes, exactly. 00:09:21 <aleth> It's a nit. 00:09:46 <clokep> OK, just making sure there wasn't a "real" reason for it. 00:10:27 <aleth> When exactly does the "Other Contacts" tag appear in IB? 00:12:56 <clokep> aleth: When you "x" out of one of the other tags. 00:13:12 <aleth> Right. 00:14:16 <aleth> Ah, I confused myself because my dev profile has a Contacts and a Buddies tag for some reason. 00:18:57 <instantbot> clokep@gmail.com requested feedback from florian@instantbi rd.org for attachment 1475 on bug 944. 00:18:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, nobody, NEW, Support for Bonjour 00:19:18 <clokep> That might excite flo tomorrow. ;) 00:19:54 <aleth> Nice :) 00:20:04 <aleth> Another protocol! 00:21:13 * clokep grumbles that he had to create an Apple Developer account... 00:24:24 <aleth> Is there some strange licence you need to use it? 00:24:52 <clokep> I just don't like making accounts. ;) 00:25:02 <clokep> There's a license on using it, but it's liberal enough, redistributing it is a no-no though. 00:25:33 <instantbot> New Core - IRC bug 1434 filed by aletheia2@fastmail.fm. 00:25:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1434 nor, --, ---, nobody, NEW, Adding two buddies with the same nick, but on different IRC accounts leads to strange behaviour 00:25:36 <aleth> So it's for an add-on? 00:27:44 * aleth reads the bonjour bug 00:32:14 <clokep> No, why? 00:52:55 <clokep> aleth: I think that's the same bug as we've seen previously...but made even worse because the accounts are on different networks, not the same user from multiple accounts. 00:54:03 <aleth> They are the same person though, I think we can assume that. (Or at least that case should definitely work) 00:54:57 <clokep> They're not necessarily the same person. ;) 00:55:08 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 00:55:10 <clokep> (Not sure if you know, but I do sit on freenode too, so my nick is available to test stuff there.) 00:55:11 <aleth> Sure, but it would be nice if it at least works when they are ;) 00:55:34 <aleth> Right. 00:55:34 <clokep> Yes. :) 00:55:53 <aleth> I'm not 100% sure I haven't messed up my profile in the process of testing this bug a couple of times. 00:56:46 <clokep> Your real profile? :( Sorry. 00:56:56 <aleth> No, thankfully not the real one :) 00:57:18 <clokep> I recycle my dev profiles every six months probably. 00:57:18 <aleth> What I mean is I am not sure exactly what goes wrong where. I could just describe STR. 00:57:22 <clokep> And I have 3 of them so... 00:57:41 <aleth> Oh, you have a nightly/aurora/beta rotation? :P 00:58:24 <clokep> Haha, kind of. :) 00:58:34 <clokep> I have a "clean" profile, a dev profile and an irc profile. :) 00:58:42 <clokep> My dev one has lots of accounts, my irc one has only irc accounts. 00:58:50 <aleth> Makes sense... 00:58:56 <aleth> nn 00:59:00 <clokep> Goodnight! 00:59:06 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 01:04:31 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1476 on bug 1369. 01:04:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1369 enh, --, ---, clokep, ASSI, Support WATCH and MONITOR for IRC 01:09:25 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 01:19:11 <-- Mook_as has quit (Quit: gone) 01:57:12 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 02:09:24 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 13.0/20120509070325]) 02:47:45 <instant-buildbot> build #497 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/497 03:00:53 * jwir3 is now known as jwir3|zzz 04:29:57 <instant-buildbot> build #591 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/591 04:32:02 <-- pvagner has quit (Ping timeout) 04:41:05 <-- Kaishi has quit (Quit: Kaishi) 04:41:10 --> Kaishi has joined #instantbird 04:44:45 --> FireFly_TB has joined #instantbird 04:55:18 --> pvagner has joined #instantbird 05:00:35 --> FeuerFliege has joined #instantbird 05:52:16 <-- EionRobb has quit (Quit: Leaving.) 06:03:10 <instant-buildbot> build #484 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/484 06:05:08 <-- Kaishi has quit (Quit: Kaishi) 07:14:29 <-- FireFly_TB has quit (Quit: FireFly_TB) 07:18:13 --> FireFly_TB has joined #instantbird 07:27:00 <-- FeuerFliege has quit (Input/output error) 07:27:21 <-- FireFly_TB has quit (Quit: FireFly_TB) 07:37:06 --> gerard-majax has joined #instantbird 07:52:41 --> jb has joined #instantbird 07:58:02 --> Optimizer has joined #instantbird 07:58:33 <Optimizer> any addon developer here ? 08:01:33 --> Tomek has joined #instantbird 08:04:29 --> flo has joined #instantbird 08:04:29 * ChanServ sets mode +qo flo flo 08:06:35 <Optimizer> Hi flo 08:07:23 <flo> Optimizer: Hello (I'm in a meeting though) 08:07:28 --> EionRobb has joined #instantbird 08:07:30 <Optimizer> okay 08:08:58 <-- jb has quit (Quit: jb) 08:13:39 <-- Tomek has quit (Client exited) 08:17:10 <Optimizer> flo: please reply when you are free 08:20:41 --> jb has joined #instantbird 08:31:10 --> Even has joined #instantbird 08:31:10 * ChanServ sets mode +o Even 08:31:54 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:32:04 --> Even has joined #instantbird 08:32:04 * ChanServ sets mode +o Even 08:36:47 --> aleth has joined #instantbird 08:36:47 * ChanServ sets mode +h aleth 08:38:21 --> Tomek has joined #instantbird 08:40:25 <instantbot> aletheia2@fastmail.fm granted review for attachment 1476 on bug 1369. 08:40:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1369 enh, --, ---, clokep, ASSI, Support WATCH and MONITOR for IRC 08:44:20 --> gpsychosis has joined #instantbird 08:45:27 --> FireFly_TB has joined #instantbird 08:56:02 --> mmkmou has joined #instantbird 08:57:32 <flo> Optimizer: I'm no longer in a meeting (that doesn't mean I don't have things to do though ;)) 08:59:40 <Optimizer> So I can;t query you stuff ? 09:02:32 <flo> feel free to ask questions, any time. :) 09:02:43 <flo> I'm likely not the only one who can reply anyway ;) 09:03:12 <Optimizer> actually youa re 09:03:16 <Optimizer> are* 09:03:19 <Optimizer> in your extension 09:03:28 <Optimizer> shownick 09:03:34 <Optimizer> I was tweaking it to match my requirements 09:03:52 <Optimizer> is there any wiki so that I can get to know some global functions ? 09:04:27 <flo> global function of what? 09:05:23 <Optimizer> let tabbrowser = getBrowser(); let addConv = tabbrowser._addConversation; let newAddConv = function() { let convBinding = addConv.apply(tabbrowser, arguments); if (convBinding.hasAttribute("chat")) { let nicks = new nickListWatcher(convBinding.buddies); 09:06:13 <Optimizer> so these are some of the lines 09:06:25 <Optimizer> here what lind of array is the convBinding.buddies ? 09:06:43 <Optimizer> is there any documentation for these things ? 09:06:57 <flo> we usually just read the code 09:07:12 <flo> http://lxr.instantbird.org/instantbird/ helps a lot to navigate and find things 09:07:59 <aleth> Some useful information: https://wiki.instantbird.org/Developer 09:08:21 <flo> Optimizer: the buddies object (which isn't an array) is at http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1406 09:10:00 <-- jb has quit (Quit: jb) 09:12:18 --> jb has joined #instantbird 09:16:09 <Optimizer> okay so reading the code is a little difficult 09:16:18 <flo> that's why you can ask questions :) 09:16:27 <Optimizer> so first question 09:16:35 <Optimizer> what attributes the nicks array holds ? 09:16:37 <Optimizer> one is color 09:16:46 <Optimizer> (by reading the shownick code) 09:17:06 <flo> Optimizer: when asking questions, try to link to the code you are asking a question about 09:17:12 <flo> nobody here knows the shownick code 09:17:27 <flo> we all have to look at it again before understanding what you are talking about ;) 09:17:48 <Optimizer> but you know right ? 09:17:55 <Optimizer> its your extension 09:18:08 <flo> Optimizer: do you know all the code you wrote several years ago? 09:19:12 <aleth> Optimizer: This should make it easier to point at the code: http://hg.instantbird.org/addons/file/26129a5def76/shownick/content 09:19:56 <aleth> You will soon find your way around :) 09:20:23 --> FeuerFliege has joined #instantbird 09:21:00 <Optimizer> thanks aleth 09:21:12 <Optimizer> flo: I was referring to this line http://hg.instantbird.org/addons/file/26129a5def76/shownick/content/shownick.js#l113 09:21:52 <aleth> Btw I suspect your pastebin add-on idea is easier to implement than the nick highlight idea (but I may be wrong) 09:22:36 <flo> the nick highlight idea is easy if you do it in a message theme 09:23:05 <aleth> Oh, for a single message style? OK. 09:23:52 <Optimizer> I just want to know how the nicks object look like, I know that it is something like nick = {color: #color, ...} , 09:24:12 <flo> Optimizer: follow the code to see where it comes from :) 09:24:18 <flo> http://hg.instantbird.org/addons/file/26129a5def76/shownick/content/shownick.js#l113 09:24:30 <flo> self is defined at http://hg.instantbird.org/addons/file/26129a5def76/shownick/content/shownick.js#l101 09:24:49 <Optimizer> it comes from convBinding.buddies 09:25:00 <flo> right 09:25:23 <flo> I gave you a link to where that object is defined already: http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1406 09:25:32 <aleth> That's the list of participants in a chat, from the conversation binding 09:26:05 <aleth> As you can see from the code flo is pointing at ;) 09:26:30 <aleth> Following the code, you could have a look at the addBuddy method too. 09:26:52 --> mikk_s has joined #instantbird 09:27:30 <Optimizer> now that helped 09:27:37 <Optimizer> thanks flo and aleth 09:28:42 <-- mikk_s has quit (Quit: Instantbird 1.1) 09:43:53 <instantbot> florian@instantbird.org cancelled feedback?(florian@instantbi rd.org) for attachment 1475 on bug 944. 09:43:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=944 enh, --, ---, nobody, NEW, Support for Bonjour 09:46:12 --> meh has joined #instantbird 09:49:08 <flo> uh, bug 1434 :'( 09:49:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1434 nor, --, ---, nobody, NEW, Adding two buddies with the same nick, but on different IRC accounts leads to strange behaviour 09:54:13 <flo> I didn't know https://dev.twitter.com/docs/streaming-apis/parameters#follow 09:56:03 <flo> "Status deletion notices [...] Client code must honor these messages by clearing the referenced Tweet from memory and any storage or archive" I've never understood why twitter expects consumers of its API to remove delete tweets that have already been received. 10:10:50 <flo> I looked quickly at the patch in bug 1369 10:10:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1369 enh, --, ---, clokep, ASSI, Support WATCH and MONITOR for IRC 10:10:57 <flo> I won't pretend to understand all of it 10:12:06 <flo> I just have a coding style nit. var blahblah = { ... }*;* <-- ; at the end of the assignment 10:16:06 --> clokep has joined #instantbird 10:16:07 * ChanServ sets mode +o clokep 10:17:19 <-- EionRobb has quit (Quit: Leaving.) 10:28:34 <-- Optimizer has quit (Quit: http://www.mibbit.com ajax IRC Client) 10:29:10 <clokep> flo: I'll add that an upload a new patch...I always forget when semi-colon's are needed. :( 10:30:23 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 10:35:55 <instantbot> clokep@gmail.com granted review for attachment 1477 on bug 1369. 10:35:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1369 enh, --, ---, clokep, ASSI, Support WATCH and MONITOR for IRC 10:44:32 --> Even has joined #instantbird 10:44:32 * ChanServ sets mode +o Even 10:44:40 <-- Even has quit (Quit: Even) 10:44:48 --> Even has joined #instantbird 10:44:48 * ChanServ sets mode +o Even 10:53:08 --> Optimizer has joined #instantbird 10:57:24 <-- FireFly_TB has quit (Quit: FireFly_TB) 10:58:57 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:00:57 <-- FeuerFliege has quit (Ping timeout) 11:01:10 <aleth> flo: well, that does point towards a new answer to the shelved question about what getNormalizedChatBuddyName should return for IRC ;) 11:01:44 <aleth> I don't think I ever quite realized chat buddies were only identified by name and protocol, not by name and account. What was the reason for that design decision? 11:09:33 <-- Optimizer has quit (Quit: http://www.mibbit.com ajax IRC Client) 11:31:03 --> deomega1 has joined #instantbird 11:32:11 <deomega1> good day. Have you guys found that with teh twitter feature.. if you ad a keyword, you have to restart IB for it to become effective? And if you remove a keyword, you have to restart again for it to be effective? 11:33:58 <flo> aleth: the reason is that if you have the same buddy in the server side buddy if of several different AIM accounts, they get merged automatically 11:37:36 <aleth> Hmm. So a special case became the default behaviour? 11:37:40 <aleth> clokep: This bug 1434 IRC behaviour, is it a regression? 11:37:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1434 nor, --, ---, nobody, NEW, Adding two buddies with the same nick, but on different IRC accounts leads to strange behaviour 11:39:13 <aleth> deomega1: disconnecting and reconnecting the twitter account from the account manager doesn't do it? 11:41:05 --> clokep_work has joined #instantbird 11:41:05 * ChanServ sets mode +o clokep_work 11:42:34 <clokep_work> aleth: I have no idea if that's a regression 11:43:49 <clokep_work> deomega1: Disconnecting/reconnecting should pick up the tracked keywords again. 11:44:00 <clokep_work> I think there's a bug about actually changing it when it gets changed though. 11:44:35 <deomega1> clokep_work: ok, yes, that works indeed. thanks 11:44:36 <flo> aleth: not a regression 11:44:48 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:45:01 <flo> aleth: IRC is the special case, isn't it? 11:45:07 <clokep_work> deomega1: No problem. :) Thanks for verifying! 11:45:16 <flo> the normalized name is supposed to be unique across all accounts of the protocol 11:46:44 <clokep_work> deomega1: bug 677 is the one I was talking about though. 11:46:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=677 nor, --, ---, nobody, NEW, Reopen Twitter stream when "track" preference changes 11:52:31 --> Even has joined #instantbird 11:52:32 * ChanServ sets mode +o Even 11:54:24 <deomega1> clokep_work: yes that is correct. thank you. 11:54:43 <clokep_work> aleth: So is that a dup of bug 1370? 11:54:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1370 tri, --, ---, clokep, ASSI, Fix JS-IRC's usage of normalizedChatBuddy getter 11:54:53 <clokep_work> / a dup with more information. :_D 11:55:34 <flo> isn't that completely unrelated? 11:55:48 <flo> one is about buddies in the buddy list, and the other about chat buddies 11:56:13 <clokep_work> Oh, you're right. :( 12:07:17 <aleth> flo: Thanks. 12:07:37 * flo wonders what he has done 12:08:04 <aleth> Just answered a question earlier ^^ while I was away 12:11:26 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 12:38:32 <aleth> https://bugzilla.mozilla.org/show_bug.cgi?id=742644 should be committed on IB too I think 12:38:51 <aleth> Maybe it's already in the checkin-needed list, I don't know 12:39:05 <flo> It's alreadly commited, but I think I forgot to hg push yesterday 12:52:04 <aleth> Some checkins soon would be good, otherwise I am worried the IRC patches might start to bitrot each other. 12:56:11 <flo> I hadn't noticed there was so many of them 12:56:22 <flo> bug 1369 is the only one I had in mind 12:56:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1369 enh, --, ---, clokep, ASSI, Support WATCH and MONITOR for IRC 13:10:23 <-- jb has quit (Quit: jb) 13:10:55 --> jb has joined #instantbird 13:15:06 <clokep_work> Hopefully those all apply. :( 13:22:28 * bear-afk is now known as bear|buildduty 13:27:18 <instantbot> New Websites - update.instantbird.org (Updates) bug 1435 filed by florian@instantbird.org. 13:27:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1435 nor, --, ---, nobody, NEW, Block updates from Instantbird 1.1 to 1.2 for Windows 2000 and Windows XP < SP2 users 13:29:33 --> FeuerFliege has joined #instantbird 13:30:33 <-- mmkmou has quit (Client exited) 13:31:13 <-- FeuerFliege has quit (Ping timeout) 13:37:53 <-- jb has quit (Quit: jb) 13:38:29 --> jb has joined #instantbird 13:42:15 <-- pvagner has quit (Ping timeout) 13:42:23 <-- jb has quit (Quit: jb) 13:42:44 --> jb has joined #instantbird 13:43:40 <-- jb has quit (Quit: jb) 13:44:03 --> jb has joined #instantbird 13:45:55 <-- gpsychosis has quit (Quit: Instantbird 1.1) 13:53:21 <-- jb has quit (Quit: jb) 13:59:09 <flo> https://bugzilla.instantbird.org/attachment.cgi?id=1446&action=diff looks like its instantbird/ part would need to be ported to Tb's UI :-( 14:09:26 --> Lalae has joined #instantbird 14:10:06 <-- Lalae has left #instantbird () 14:10:45 --> jb has joined #instantbird 14:12:19 --> zen_monkey has joined #instantbird 14:14:18 <clokep_work> That's unfortunate. :( 14:32:43 --> mmkmou has joined #instantbird 14:42:48 <-- gerard-majax has quit (Ping timeout) 15:13:34 <-- jb has quit (Ping timeout) 15:18:20 --> igorko has joined #instantbird 15:31:55 --> jb has joined #instantbird 15:40:42 <flo> uh, checkin-needed with an r? still pending is ocnfusing :-S 15:43:43 <-- jb has quit (Ping timeout) 15:44:24 <aleth> Someone didn't remove checkin-needed when they asked for additional changes? ;) 15:49:37 <flo> and stupidly put review comments only on IRC it seems ;) 15:49:52 <-- Gizmokid2005 has quit (Ping timeout) 15:49:53 <flo> aleth: btw, any reason for not using bind at https://bugzilla.instantbird.org/attachment.cgi?id=1462 ? 15:50:25 --> Gizmokid2005 has joined #instantbird 15:50:52 <flo> that code seems ok though; I'm just surprised you came up with that solution 15:51:10 <clokep_work> Review comments on IRC are annoying to track sometimes. :( 15:51:31 <flo> ah, it's to match _keyEventHandler, ok 15:51:53 <flo> clokep_work: yeah :( Sorry for being lazy 15:51:56 <aleth> flo: I followed the style of _keyEventHandler 15:53:31 <clokep_work> flo: I find it really useful when I'm like going to fix it /now/, but otherwise... 15:53:49 <flo> clokep_work: it's nicer to have some kind of direct interaction 15:54:14 <aleth> One can copy and paste from IRC to the bug if one remembers in time. 15:54:23 <flo> it avoids writing an explanation that's either too long (if when mentioning the line the patch author immediately sees what's wrong) or too short (if the patch author really doesn't see what we are talking about) 15:54:50 --> wesj has joined #instantbird 15:54:54 <flo> aleth: yes. It's hard because of lots of unrelated things being talked about in the middle (or even just system messages) though 15:55:09 <aleth> True, it can get noisy. 15:55:25 <flo> aleth: at some time I considered creating an add-on to copy to the clipboard only my messages out of the selection 15:55:48 <aleth> Or filter a subconversation between 2 people 15:56:13 <flo> yes, it wouldn't be as easy to select who the interesting people are, it would require some UI 15:56:32 <aleth> Yes... I was wondering about an add-on along those lines once, and couldn't see an easy way to do it 15:57:16 <flo> if we add a new dialog for that, it's easier 15:57:24 <flo> we can just check/uncheck the name of participants 15:57:27 <aleth> In a way it's also close to Optimizer's project ;) 15:57:32 <flo> and check/uncheck some messages 15:57:54 <flo> aleth: in a way yes. But it wouldn't share a single line of code 15:58:01 <aleth> Sure. 15:58:04 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/3abdc0efb06d - Patrick Cloke - Bug 1369 - Support WATCH and MONITOR for IRC, r=aleth. 15:58:06 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/1167b92422a8 - aleth - Bug 1380 - Unread ruler confusing when coming back to conversation with no new messages, r=Mic. 15:58:07 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/6c18f57a02da - aleth - Bug 1308 - "Adding a chat buddy twice" errors (JS-IRC sending bad chat-buddy-add notifications), r=clokep. 15:58:08 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9b88948399c6 - Florian Quèze - Bug 754824 - fix charCodeToByteCount to correctly handle UTF8 characters coded on 4 bytes, r=asuth, r=clokep over IRC. 15:58:09 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e92b8aded5e7 - Florian Quèze - Bug 742644 - IRC's username empty text ('and server') in the Chat Account Wizard is confusing, r=clokep, ui-r=bwinton. 15:58:31 <aleth> Hmm, yes, or you could have a context menu entry on a bubble, "hide this participant" 15:58:39 <instantbot> florian@instantbird.org set the Resolution field on bug 1380 to FIXED. 15:58:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1380 min, --, 1.2, aletheia2, RESO FIXED, Unread ruler confusing when coming back to conversation with no new messages 15:58:52 <aleth> or "show only messages with"... 15:58:56 --> jb has joined #instantbird 15:59:10 <instantbot> florian@instantbird.org set the Resolution field on bug 1308 to FIXED. 15:59:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1308 nor, --, 1.2, aletheia2, RESO FIXED, "Adding a chat buddy twice" errors (JS-IRC sending bad chat-buddy-add notifications) 15:59:22 <aleth> I think my idea at the time was making use of the ability to do multiple selections in the participant list 16:00:01 <instantbot> florian@instantbird.org set the Resolution field on bug 1369 to FIXED. 16:00:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1369 enh, --, 1.2, clokep, RESO FIXED, Support WATCH and MONITOR for IRC 16:01:00 <flo> aleth: I think in the way I'm imagining it right now, you would select the text of the conversation as usual, and click a "filtered copy" context menu item. 16:01:13 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1309 to FIXED. 16:01:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1309 nor, --, 1.2, nobody, RESO FIXED, Error: Removing or updating a nick that is not in the room 16:01:25 <aleth> A context menu on the selection? That's probably an even better idea. 16:01:28 <flo> a dialog would appear with a previous of what's going to be copied, and a checkbox next to the name of each participant, and maybe next to each message 16:02:54 <aleth> Just checkboxes for the participants plus one for system messages would already be great, and then you wouldn't have to complicate things by displaying the messages again 16:03:28 <clokep_work> aleth: YOu might want to see the messages, you might not remember who actually said useful things. :) 16:03:44 * clokep_work is excited for WATCH/MONITOR. 16:03:54 <clokep_work> Means we'll see away messages on moznet with buddies. ;) 16:04:33 <flo> clokep_work: we will? It sounds even more exciting! 16:04:40 <flo> I definitely haven't fully read that patch ;) 16:05:04 <clokep_work> Yes, we will. WATCH tells you if a buddy is available, away, or offline. If it's away we fetch the away message. 16:05:07 * aleth is a bit disgruntled by last night's r+ one bug, find 2 new ones 16:05:27 <aleth> WATCH/MONITOR will be cool. 16:05:33 <clokep_work> aleth: Did you look at bug 1433 at all? 16:05:35 <flo> aleth: what are these bugs about? 16:05:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1433 nor, --, ---, nobody, NEW, Switching status from OFFLINE to UNAVAILABLE actually sets status to AVAILABLE 16:05:46 <aleth> Also in DMs you'll see the away message as the status. 16:06:08 <clokep_work> aleth: I vaguely recall this being a core bug and not an IRC bug though...? :( 16:06:12 <flo> aleth: even when not in the buddy list? 16:06:15 <aleth> clokep_work: No, haven't had a chance. 16:06:22 <aleth> flo: No, that's bug 613 16:06:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=613 min, --, ---, nobody, NEW, Presence information for IRC private messages from people not on the buddy list 16:07:33 <aleth> clokep_work: If it's a core bug, it still needs fixing... as the UI gives wrong information. 16:08:41 * flo wonders if he needs to re-review wnayes' patch or can just assume it's fine 16:08:45 <aleth> I suspect it's IRC though. You connect and then there is no code to send AWAY 16:09:04 <clokep_work> aleth: You're right. 16:09:12 <clokep_work> I only send it when I receive the message after I'm connecting. 16:09:21 <clokep_work> Should be a fairly trivial fix. 16:09:25 <clokep_work> Patches accepted? ;) 16:10:06 <flo> so you need to look for the current account's status at the time you are calling reportConnected? 16:10:31 <clokep_work> Something like that, yes. 16:11:41 <flo> bah, I have a comment :( 16:11:48 <flo> changing the accountProtocolInfo.label string should also change its id 16:13:31 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1362 to WORKSFORME. 16:13:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1362 nor, --, ---, nobody, RESO WORKSFORME, JS-IRC does not set buddy status to "unavailable" when buddy away. 16:13:52 --> myk has joined #instantbird 16:14:52 <clokep_work> aleth: I was just wondering about closing that bug...I wasn't sure if we should close it or not, but I certainly have no other ideas for if we're not using WATCH. :( 16:16:01 <aleth> clokep_work: Yes :( I gathered from the discussion in the bug that while we could set Unavailable when receiving 'Away' from Whois, that's basically too random and won't survive the next ISON call. 16:16:04 <flo> should I just add a "2" to that string id, and check the patch in? 16:17:06 <aleth> If it's a simple fix, that sounds good. He'll still see it and then he doesn't have to go through another couple of days of cycle, and can move on to the next thing 16:17:23 <aleth> Bug 173, is that WONTFIX? 16:17:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=173 enh, --, ---, nobody, NEW, Use specific away status icons (do not disturb, on the phone, busy, etc.) 16:17:51 <flo> yes. Would be a nice add-on, blahblah ;) 16:18:29 --> EionRobb has joined #instantbird 16:19:09 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 173 to WONTFIX. 16:19:20 <aleth> Going down the 'away' bugs chain... ;) 16:19:52 * jwir3|zzz is now known as jwir3 16:20:10 <aleth> Bug 573, isn't that effectively fixed? 16:20:10 <-- EionRobb has quit (Ping timeout) 16:20:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=573 enh, --, ---, nobody, NEW, Change away from modal dialogs to something less obtrusive 16:20:34 <aleth> Can't remember the last time IB threw a modal dialog at me ;) 16:20:51 <flo> aleth: the last time you deleted an account? 16:21:02 <flo> or a contact 16:21:14 <aleth> I haven't, but that's actually a situation where modal arguably is OK 16:21:15 <flo> (2 actions that I never perform ;)) 16:21:28 <flo> well, the bug argues that it's not 16:21:45 <flo> and while I agree, it doesn't seem like these cases are worth much effort 16:22:57 <aleth> The most important case was fixed by you a while ago (authorisation requests) 16:23:05 <aleth> but I can't remember the bug number 16:23:12 <flo> I forgot to file a bug about it :( 16:23:39 <flo> we don't keep a list of pending authorization requests, so when the buddy list is closed (only possible on mac), the pending authorization requests aren't redisplayed when reopneing the list 16:26:18 <instantbot> florian@instantbird.org granted review for attachment 1470 on bug 1391. 16:26:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1391 enh, --, ---, wnayes, ASSI, Suggest popular protocols during account creation 16:26:58 <instantbot> florian@instantbird.org set the Resolution field on bug 1391 to FIXED. 16:27:17 <flo> aleth: there's already a checkbox "do not show again" for the account deletion 16:27:43 <flo> and I'm late already! Talk to you all later :) 16:27:44 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 16:28:06 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/30564a208a4e - Will Nayes - Bug 1391 - Suggest popular protocols during account creation, r=fqueze. 16:28:12 --> FeuerFliege has joined #instantbird 16:28:35 <clokep_work> aleth: Joining a chat room is a modal dialog, no? 16:28:42 <-- FeuerFliege has quit (Input/output error) 16:29:17 --> FeuerFliege has joined #instantbird 16:29:24 <aleth> Yes, that does need redesign. Add Buddy too, possibly. 16:29:34 <aleth> Well, I wanted to close that bug altogether ;) 16:29:46 <aleth> Too much of a catch-all. 16:30:02 <clokep_work> If you close it, you have to file the bugs which are part of it. :P 16:30:44 <aleth> Replacing "Join chat" has been discussed many times... 16:31:34 <aleth> I'm not sure what is added by filing a generic "join chat sucks" bug 16:32:18 <clokep_work> I didn't mean a generic one, but a way forward. W eshould file one at one point, but doesn't have to be right now. 16:33:13 <aleth> There are already specific bugs filed about Join Chat 16:34:02 <aleth> A way forward is more complicated... 16:34:31 <clokep_work> Ah, are there? OK. 16:34:34 --> Mook_as has joined #instantbird 16:34:58 --> Mic has joined #instantbird 16:34:58 * ChanServ sets mode +h Mic 16:35:03 <aleth> They are more along the lines of "should remember history" etc 16:36:07 <Mic> Man, you guys are hard-working. I wonder how I could possibly catch up with the bugmail :D 16:36:32 <clokep_work> Mic: More of I fixed a bug which fixes a lot of random things. ;) 16:36:45 <aleth> Mic: I suspect you filed some of those bugs actually ;) 16:38:02 <aleth> Oops, so we both missed a typo in bug 318 16:38:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly 16:38:21 <aleth> Ah no, I didn't look at that patch 16:38:30 * aleth is in the clear 16:39:03 <clokep_work> Yeah, that one is on me. :) 16:40:21 --> wnayes has joined #instantbird 16:43:22 <clokep_work> Congratulations wnayes. :) 16:43:37 <clokep_work> aleth: I have to say...I hit tab sometimes now just assuming it's going to complete random words that definitely aren't nicks. :( 16:44:16 <aleth> clokep_work: Maybe I should add a Markov chain based on your previous messages :D 16:45:29 <wnayes> clokep_work: Thanks! It was good to see the review granted email this morning; couldn't have done it without everyone's advice :) 16:46:01 <aleth> Thanks for fixing this wnayes! :) 16:46:04 <clokep_work> aleth: I have a Markov chain thing that will reply to you based onw hat you say, I think...It does something with Markov chains. ;) 16:46:24 <clokep_work> wnayes: :) Great work so far! 16:46:41 <aleth> It'll be pretty much the first thing any user sees :) until you add the import wizard that is ;) 16:49:08 <wnayes> I'm thinking a bug related to XPCOM would be the next logical step, as this one covered the workings of XUL/XBL/CSS/Localization. 16:49:53 <aleth> Or fix something that annoys you about IB ;) 16:51:21 <clokep_work> wnayes: That would probably make sense. Let me think if I know of any that deal with XPCOM... 16:51:34 <aleth> You could always pick more than one bug and work on them in parallel... depending on what you have time for 16:51:50 <clokep_work> (When does the "official" GSoC period start, anyway?) 16:52:03 <aleth> clokep_work: I wonder if there is something XPCOM related on the 1.2 list? 16:52:10 --> opti has joined #instantbird 16:52:22 <Mic> aleth: afaik no 16:52:39 <opti> please pass on the link to the source code of instant bird 16:53:02 <aleth> opti: https://wiki.instantbird.org/Developer 16:53:06 <Mic> Opti: try the wiki, section "Developer", you should find most of the needed things there 16:53:10 <Mic> aleth: :) 16:54:04 <wnayes> clokep_work: May 21st 16:54:11 <opti> the source code 16:54:55 <aleth> opti: you just follow the links :P https://wiki.instantbird.org/Instantbird:Compiling#Get_the_source 16:55:07 <opti> thanks :) 16:55:11 <opti> in a hurry 16:55:19 <opti> as I am about to complete the mibbit like message theme 16:55:24 <clokep_work> wnayes: OK. :) 16:55:49 <aleth> opti: OK :) Don't forget to test with the latest IB nightly build too... 16:56:12 <opti> what version of gecko are those using ? 16:56:36 <Mic> Nightlies are Gecko 11.0 16:56:58 <opti> nice 16:57:07 <opti> is there tab closing animations ? :D 16:57:23 <aleth> wnayes: I'm actually not sure there are any specific XPCOM bugs. Anything in the core (using protocols) would go via XPCOM though. 16:57:42 <-- jb has quit (Ping timeout) 16:58:08 <opti> any idea on where can i find the file "chrome://instantbird/content/menus.js" in the source code 16:58:14 <clokep_work> Those are all implementing XPCOM instances, I'm trying ot think if we have anything that's tweaking them at all. 16:58:23 <clokep_work> opti: instantbird/content/menus.js I think. 16:58:40 <aleth> opti: Generally, go to http://lxr.instantbird.org/instantbird/ and use "file search" 16:58:45 <clokep_work> (Or maybe.... find . -name menus.js) 16:58:49 <opti> found it 16:59:38 <Mic> What part of XPCOM would be interesting? An own interface (and how to define it) or implementing an existing interface? 16:59:54 <clokep_work> Mic: Whatever happened to that nice mockup of implementing a taskbar preview with things to change statuses, etc? 17:00:02 <clokep_work> Was that real code? An extension or just a mockup? 17:00:05 * clokep_work would like that. :) 17:01:36 --> FireFly_TB has joined #instantbird 17:02:01 <Mic> I had code that worked (if you enabled it after IB had started (-> restartless), because I hadn't figured out how to wait for the main window to appear back then;) 17:02:15 <Mic> A handler for e.g. irc-links would be too much for so little time, I guess? 17:02:18 <aleth> I think anything touching accounts or protocols will be useful and involve XPCOM interfaces, so wnayes could just pick a bug he finds interesting 17:02:27 <Mic> That would need to implement an existing interface. 17:02:32 <wnayes> Mic: My project will likely involve some work with accessing the filesystem through XPCOM, etc., and mainly implementing existing interfaces. 17:02:32 <clokep_work> Mic: Yes. 17:03:04 <clokep_work> wnayes: Oh you'll need to design a couple of interfaces too! (With our help, of course. :)) 17:03:15 <clokep_work> So you can define what an importer can do and how it gets called. 17:05:03 <wnayes> clokep_work: Ah, cool! 17:05:03 <clokep_work> Mic: Actually implementing a handler for some links would probably be a fairly self-contained thing...now that I think of it. 17:05:09 <clokep_work> Doesn't deal with the file system, though. 17:05:25 <Mic> And if you limit the task to join-when-account-connected, it could be not that hard either 17:05:27 <aleth> And it's disconnected from the core stuff 17:05:47 <aleth> (whether that is a + or - I don't know) 17:06:58 <aleth> Oh, actually, I'm not sure about that. It might be more tricky than it looks 17:07:13 <aleth> e.g. if it's an IRC link and there is no account set up for that server. 17:07:23 <Mic> Is "dealing with the file system" that important? It's not really XPCOM related, I would say? 17:08:31 <-- opti has quit (Quit: http://www.mibbit.com ajax IRC Client) 17:08:55 <aleth> Session restore would touch a lot of XPCOMs, but might be too much for 3 days 17:09:14 <aleth> Definitely a worthwhile feature though. 17:09:25 <aleth> bug 307 17:09:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=307 enh, --, ---, nobody, NEW, Restoring session after restart 17:09:37 <Mic> aleth: would it? I've started a bit on this (as extension) and didn't need much but the right notifications so far. 17:09:53 <aleth> Mic: But you know your way around the code already 17:10:17 <aleth> I can't judge how much extra time that implies 17:10:36 <Mic> I'm not sure how that affects the need for xpcom? ;) 17:11:17 <aleth> Mic: You have to collect the data you want to store... 17:12:28 <clokep_work> That's not really XPCOM at all. 17:12:42 <clokep_work> AFAIK it can all be done in the JS layer, save stuff to prefs, etc. 17:12:54 <aleth> It's XPCOM in that you will use the existing interfaces 17:13:07 --> jb has joined #instantbird 17:13:09 <clokep_work> Sure. 17:13:12 <aleth> I can't think of any bugs that will actually involve changing existing XPCOMs 17:13:33 <Mic> aleth: about the irc-links: I didn't mean something that's ready to land after three days, rather something like "join the channel if there's an account for this server and it is connected already". That means: implementing a component that suffices as command line handler and a bit of parsing and joining code that's not completely useless? 17:14:51 <aleth> wnayes: Are there any itches you'd like to scratch? What's the most annoying IB 'feature' (or lack of it) you've found so far? 17:16:49 <-- jb has quit (Ping timeout) 17:18:11 <wnayes> aleth: I am having a peculiar bug in Windows, although it seems very specific to my install. None of the context menus show up in any of the recent versions (1.1, nightlies) in my Win7 install, however I figured it must be something specific to my configuration as I just checked that they work on my parents' PC. 17:18:15 <clokep_work> (Mic: What you're saying could be for any protocol too, btw. AIM or whatever...) 17:18:38 <clokep_work> Some of which have better definitions of what constitutes a link. ;) 17:19:06 <clokep_work> wnayes: My guess would be graphic acceleration issues with your graphics card, but I'm pulling that out of nowhere. :) 17:19:53 <Mic> clokep_work: I was thinking about IRC-links since these are the only ones that I've actually seen in the wild. 17:19:54 <wnayes> Could a custom Win7 visual theme could be the culprit? No errors have ever shown, etc. 17:20:09 --> jb has joined #instantbird 17:20:17 <clokep_work> Yeah, that could probably do it too. Does it work in Tb/Fx? 17:20:31 <aleth> It certainly isn't a bug that has been filed yet. 17:21:09 <wnayes> clokep_work: Haven't used Thunderbird on this PC but have been using Firefox since I got it, with no issues. 17:23:22 * clokep_work shrugs. 17:23:23 <clokep_work> Out of ideas. :( 17:23:28 <aleth> Do tooltips work? 17:24:48 <wnayes> aleth: Can't recall, I've been using Linux with IB primarily and the issue got pushed to the back of my mind. I figured it was just something peculiar to my setup. 17:29:02 --> gerard-majax has joined #instantbird 17:31:37 --> BYK has joined #instantbird 17:34:18 --> mikk_s has joined #instantbird 17:38:54 <-- jb has quit (Quit: jb) 17:40:35 <clokep_work> wnayes: So, I can't really think of anything off the top of my head. The best I can do is what aleth suggested...poke around, find things that annoy you or browse Bugzilla. :) 17:43:56 <wnayes> clokep_work: Will do, I'm sure I'll find something pretty soon. 17:45:41 <clokep_work> If a bug doesn't make sense, blah, blah you want to know whatever needs to be done, please ask. 17:47:39 <clokep_work> Our bugs aren't always coherent I've found. :( 17:47:52 <clokep_work> (At least not without the background of what was also said on IRC haha.) 17:48:28 <aleth> And some are feature requests that may not be wanted in the exact form stated in the bug. 17:50:35 <aleth> The list of remaining 1.2-wanted bugs is here, but I don't know how suitable any of those are https://bugzilla.instantbird.org/buglist.cgi?quicksearch=1.2 17:59:05 <clokep_work> aleth: I think that bug is the issue we've been having with lots of our connections doing strange things. 17:59:08 <clokep_work> Not the reconnection timers. 18:03:40 <-- mikk_s has left #instantbird () 18:18:45 <-- igorko has quit (Connection reset by peer) 18:20:42 <Mic> After reading bugmail I actually understood that last comment ;) 18:23:23 <clokep_work> :) 18:25:13 <-- Tomek has quit (Quit: Instantbird 1.1) 18:37:31 <wnayes> Hmm, I'm going to need to patch my latest patch :( It seems removing the protoLabel broke the summary page... 18:38:20 <clokep_work> :( File a bug please. :) 18:41:28 <clokep_work> Bonus points if you attach a patch too. :-D 18:42:22 <aleth> Extra bonus if it lands before breaking tomorrow's nightly :D 18:42:51 <instantbot> New Instantbird (UI) bug 1436 filed by wnayes@gmail.com. 18:42:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1436 nor, --, ---, nobody, UNCO, Summary page empty due to Top Protocols page modifications 18:44:30 * jwir3 is now known as jwir3|lunch 18:45:00 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :() 18:49:49 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:54:41 <wnayes> clokep_work: Should I set you as the patch reviewer? I'm not sure if flo will be back before the next nightly build. 18:57:16 --> Mnyromyr has joined #instantbird 19:00:16 <clokep_work> wnayes: Sure. 19:00:31 <clokep_work> (By the way, if you don't know...just guess and someone will fix it if it's wrong. :)) 19:00:44 <instantbot> wnayes@gmail.com requested review from clokep@gmail.com for attachment 1478 on bug 1436. 19:00:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1436 nor, --, ---, nobody, UNCO, Summary page empty due to Top Protocols page modifications 19:07:51 <clokep_work> wnayes: Does that code even work for both the top protocol list and non-top protocol list? :-S 19:07:56 <clokep_work> I can't test right now unfortunately. 19:10:02 <wnayes> clokep_work: The wizard references several labels like that when building the summary page, it was removed in the original patch because it appeared to never be referenced. 19:10:31 <wnayes> The label is only used to supply the "Protocol:" string to the summary page 19:10:32 * jwir3|lunch is now known as jwir3 19:11:12 <clokep_work> Hmm....OK. I'll need to look at it closer (or flo should be back soon). 19:13:24 <clokep_work> I guess I'm confused as to why we're not loading it from the bundle directly instead of making a label and then reading it from there. 19:17:19 <wnayes> The patch I uploaded just restores it to how it worked prior. The string could be also placed in accountWizard.properties, though I thought it might be confusing placed separately in that file. 19:18:38 <clokep_work> Right I guess that makes sense. 19:19:08 <-- chrisccoulson has quit (Quit: Ex-Chat) 19:24:39 --> chrisccoulson has joined #instantbird 19:32:02 <-- zen_monkey has quit (Ping timeout) 19:35:34 --> BYK1 has joined #instantbird 19:36:23 <-- BYK has quit (Ping timeout) 19:39:27 <wnayes> clokep_work: I added an alternate patch with the behavior I described above. Both work but it just depends whether the label should be reverted back to or not. 19:39:41 --> zen_monkey has joined #instantbird 19:45:12 * bear|buildduty is now known as bear-afk 19:48:41 <clokep_work> wnayes: I saw, thanks. 19:49:20 <clokep_work> Personally I like that one better. ;) 19:58:52 --> Mic has joined #instantbird 19:58:52 * ChanServ sets mode +h Mic 19:58:54 <-- Mic has quit (Connection reset by peer) 19:59:14 --> Mic has joined #instantbird 19:59:14 * ChanServ sets mode +h Mic 19:59:25 <-- Mic has quit (Connection reset by peer) 19:59:39 --> Mic has joined #instantbird 19:59:39 * ChanServ sets mode +h Mic 20:04:27 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :() 20:10:03 * bear-afk is now known as bear|buildduty 20:23:30 --> Mic has joined #instantbird 20:23:30 * ChanServ sets mode +h Mic 20:32:49 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1480 on bug 1433. 20:32:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1433 nor, --, ---, aletheia2, ASSI, Switching status from OFFLINE to UNAVAILABLE actually sets status to AVAILABLE 20:33:46 --> FeuerFliege has joined #instantbird 20:35:00 <-- mmkmou has quit (Client exited) 20:39:29 <clokep_work> aleth: I think that patch is fine. I'll test it when I'm home. 20:39:44 <aleth> Seemed straightforward. 20:41:02 <clokep_work> Yeah. Just trying to remember why I had this !isAway check... 20:44:54 <clokep_work> aleth: The server is OK w/ you sending AWAY again with a different message? 20:45:01 <aleth> Seems to work fine. 20:45:08 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :() 20:45:38 <aleth> I didn't check any RFC though. 20:45:58 <clokep_work> I just did, doesn't say anything about it. 20:46:01 <clokep_work> So seems like it'd work. 20:46:23 <clokep_work> "The AWAY command is used either with one parameter, to set an AWAY message, or with no parameters, to remove the AWAY message." 20:46:47 <aleth> Right. So that can't really cause any problems. 20:47:09 <aleth> Your method makes sure no empty string is sent. 20:47:22 <clokep_work> Right. :) 20:47:30 <clokep_work> That was a pain. :( If you can't tell from the absurd logic there. 20:47:39 <aleth> Yeah, I gathered ;) 20:48:01 <aleth> My first thought was "why is this so long?" 20:48:56 <clokep_work> Although honestly I'm not sure what's different about those first two checks in the preferences. :-S 20:49:50 <aleth> In case the user has for some reason set the pref to ""? 20:50:35 <aleth> Guess you were being extra careful ;) 20:50:51 <clokep_work> Ah-ha! The get*Default*Branch, is the difference. :) 20:50:57 <aleth> Yup. 20:51:26 <clokep_work> Yeah, it uses the status text, then that localized preference, then if that's set to empty it loads the default localized preference, and if /that/'s set to empty we use the hardcoded "Away" string. :) 20:51:48 <aleth> What if malware has overwritten those 4 bytes with zeros? 20:52:06 <clokep_work> Then you never get marked as away. 20:52:09 <aleth> ;) 20:52:20 <clokep_work> (Although I feel like you'd segfault then...) 20:52:33 --> Mic has joined #instantbird 20:52:33 * ChanServ sets mode +h Mic 20:54:25 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 20:56:22 --> EionRobb has joined #instantbird 20:58:39 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :() 20:59:44 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 21:02:04 --> jb has joined #instantbird 21:07:31 --> Mic has joined #instantbird 21:07:31 * ChanServ sets mode +h Mic 21:08:57 * bear|buildduty is now known as bear-afk 21:10:07 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :() 21:10:28 --> Mic has joined #instantbird 21:10:28 * ChanServ sets mode +h Mic 21:10:34 <-- Mic has quit (Connection reset by peer) 21:10:46 --> Mic has joined #instantbird 21:10:46 * ChanServ sets mode +h Mic 21:12:48 --> Tomek has joined #instantbird 21:14:04 <-- jb has quit (Quit: jb) 21:15:32 --> jb has joined #instantbird 21:20:41 <-- jb has quit (Quit: jb) 21:24:30 --> flo has joined #instantbird 21:24:30 * ChanServ sets mode +qo flo flo 21:34:41 <Mic> flo: welcome back 21:35:49 <FireFly_TB> woohoo! Twitter Auth-Window just opened in TB 21:37:08 <Mic> http://pastebin.instantbird.com/42126 :( 21:38:02 <Mic> That's a problem I see when trying to connect an account at start-up, I'm suspecting I'm trying to access the accounts service before it's initialized :( 21:38:43 <flo> FireFly_TB: any idea of what was different this time? 21:38:52 <Mic> This connect 21:38:57 <flo> bug 1436 looks like a reason to want to add some unit tests :-S 21:39:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1436 nor, --, ---, wnayes, ASSI, Summary page empty due to Top Protocols page modifications 21:39:33 <Mic> (This connect is done by an add-on) 21:39:51 <flo> Mic: "trying to access the accounts service before it's initialized" it seems this is what you are doing, yes :-S 21:41:11 <Mic> There's no good notification to tell when it's safe to do that, if I'm not mistaken :( Maybe we could add something like "prpl-initialized" (similar to "prpl-quit" that tells when it goes away?)? 21:42:48 <flo> Does your add-on need to be compatible with 1.1, or is it ok to do something that works only on trunk? 21:43:05 <Mic> trunk is ok 21:43:54 <flo> on trunk Services.core.init() no longer throws if called several times 21:44:06 <flo> so you can just call it yourself before doing something with accounts 21:44:15 <FeuerFliege> flo: no, not a clue. I have just tried it with another profile and no auth window appeared ⦠I have no idea what is blocking or triggering the window 21:44:35 <flo> all of this is on Linux, right? 21:44:52 <Mic> flo: thanks 21:45:15 <flo> Mic: how is that add-on code executed by the way? 21:45:26 <flo> (another option may be to just use an executeSoon call) 21:45:55 <-- FireFly_TB has quit (Input/output error) 21:47:17 <instantbot> aletheia2@fastmail.fm requested feedback from florian@instantbi rd.org for attachment 1452 on bug 958. 21:47:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows 21:47:20 <Mic> It's called from the startup method of a restartless add-on. 21:49:58 <flo> oh, ok. So you aren't doing anything crazy with xpcom startup notifications :) 21:50:17 <FeuerFliege> good night 21:50:25 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 21:51:29 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :() 21:51:46 --> Mic has joined #instantbird 21:51:46 * ChanServ sets mode +h Mic 21:53:05 <Mic> Good night 21:53:08 <-- Mic has quit (Quit: Who is Peer and why is he resetting our connections? :() 21:53:55 <aleth> Btw that ^^ was just me passing on the feedback? flag 21:54:38 <flo> aleth: what's http://hg.mozilla.org/comm-central/diff/e7b24610db13/chat/locales/en-US/irc.properties#l1.35 21:55:11 <aleth> A whois entry system message 21:55:18 <flo> see https://bugzilla.mozilla.org/show_bug.cgi?id=753807#c12 21:55:52 <aleth> :( 21:55:59 <aleth> I got that character off MDN :-/ 21:56:37 <aleth> from its localization docs... 21:56:47 <flo> interesting! 21:57:02 <flo> isn't the l10n doc written by Pike himself? :) 21:57:13 <aleth> Heh :D 21:57:23 <aleth> Let me see if I can find it again 21:57:30 <flo> that would be great :) 21:57:51 <aleth> https://developer.mozilla.org/en/Frequently_Asked_Localization_Questions 21:58:14 <aleth> I would have documented what it was if I had come up with it myself ;) 21:59:13 <-- zen_monkey has quit (Quit: Saliendo) 21:59:28 <flo> https://developer.mozilla.org/index.php?title=en/Frequently_Asked_Localization_Questions&action=history :-D 21:59:33 <aleth> Indeed :D 21:59:56 <flo> are you already commenting in that bug? :) 22:00:01 <aleth> No 22:00:12 <aleth> I'll leave it to you... 22:00:15 <flo> really? 22:01:22 <aleth> Unless you want me to 22:01:27 <flo> I'll handle bug 1436 first 22:01:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1436 nor, --, ---, wnayes, ASSI, Summary page empty due to Top Protocols page modifications 22:01:37 <flo> seems more important to get done this evening 22:01:42 <aleth> Yeah... 22:07:33 <flo> I can't decide which of the 2 versions of the fix in the bug I prefer, so I'm writing a third one 22:07:58 <aleth> classic solution :) 22:10:15 <instantbot> florian@instantbird.org cancelled review?(clokep@gmail.com) for attachment 1478 on bug 1436. 22:10:16 <instantbot> florian@instantbird.org requested review from the wind for attachment 1481 on bug 1436. 22:10:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1436 nor, --, ---, wnayes, ASSI, Summary page empty due to Top Protocols page modifications 22:10:41 --> Kaishi has joined #instantbird 22:10:53 <flo> wnayes: would you like to review that patch? 22:12:55 --> DGMurdockIII has joined #instantbird 22:13:11 <wnayes> flo: I had a third patch exactly like that ready after submitting the first two, thought I'd wait to see what you thought of the first two :) 22:15:58 <flo> so I assume that means you like that patch? 22:16:15 <wnayes> wasn't sure whether accounts.properties or accountWizard.properties was the place to put it 22:16:35 <wnayes> flo: Looks good to me :) 22:17:13 <flo> wnayes: well, it's not completely clear, but let's not make the code even more confusing by taking strings from different string bundles inside a single function ;) 22:17:30 <flo> wnayes: can you put the r+ flag on the bug? 22:17:31 <aleth> wnayes: Do you know how to mark it r+? 22:17:41 <flo> I may need to give you the editbugs permissions on bugzilla for that 22:17:51 <-- Mook_as has quit (Ping timeout) 22:20:58 <flo> wnayes now has editbugs. 22:21:09 <wnayes> flo: Thanks :) 22:23:00 <wnayes> aleth: not seeing where to mark it yet 22:23:42 <aleth> It's a bit hidden - click "Details" next to the patch on the bug page, then select r+ from the dropdown 22:24:10 <wnayes> aleth: Thanks, just found it :) 22:24:32 <instantbot> wnayes@gmail.com granted review for attachment 1481 on bug 1436. 22:24:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1436 nor, --, ---, wnayes, ASSI, Summary page empty due to Top Protocols page modifications 22:25:08 --> Mook_as has joined #instantbird 22:27:25 <instantbot> florian@instantbird.org set the Resolution field on bug 1436 to FIXED. 22:27:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1436 nor, --, 1.2, florian, RESO FIXED, Summary page empty due to Top Protocols page modifications 22:28:27 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ac5bbbf0dddd - Florian Quèze - Bug 1436 - Summary page empty due to Top Protocols page modifications (fix regression from bug 1391), r=wnayes. 22:32:24 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 22:33:26 <flo> aleth: bah, Pike wrote that 6 years ago; that's less fun :( 22:37:42 --> clokep has joined #instantbird 22:37:42 * ChanServ sets mode +o clokep 22:37:58 * jwir3 is now known as jwir3|away 22:39:23 <aleth> "I have no recollection of writing this documentation"? ;) 22:39:39 <aleth> yeah, I guess the code he is pointing at is only 4 years old, so... 22:45:03 <clokep> I like that exchange. ;) 22:56:32 <aleth> flo: Fancy reviewing bug 1375? It's the last of the unread ruler patches. 22:56:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1375 min, --, ---, aletheia2, ASSI, Followup: Unread ruler CSS and Bubbles margin improvements 22:57:35 <aleth> With the last iteration it is also clearer how it works, I think. 23:03:04 <-- Kaishi has quit (Quit: Kaishi) 23:03:09 --> Kaishi has joined #instantbird 23:05:25 <-- clokep has quit (Ping timeout) 23:06:03 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 23:07:32 --> clokep has joined #instantbird 23:07:32 * ChanServ sets mode +o clokep 23:11:17 <flo> aleth: that patch does seem clearer than the previous one I looked at in the same bug, but it's too late to really concentrate on that code and understand it, so reviewing it now would basically just be flipping the flag, not a serious review ;) 23:17:51 <flo> good night 23:32:25 <aleth> clokep: Why did you remove the blank lines in https://bugzilla.instantbird.org/attachment.cgi?id=1461&action=diff&context=patch&collapsed=&headers=1&format=raw ? 23:32:59 <aleth> or is there some strange whitespace/EOL incompatibility? 23:33:00 <clokep> aleth: I don't think I did it purposefully... 23:33:43 <aleth> I've noticed the bugzilla diff viewers gets blank lines wrong occasionally. 23:34:12 <clokep> Yes. :( Probably why I didn't notice. 23:34:24 <Mook_as> https://bugzilla.instantbird.org/attachment.cgi?id=1461 won't get it wrong, though :p (and it's still there) 23:34:27 <clokep> Although I usually look at the patches in Komodo anyway. 23:35:30 <aleth> Not that it breaks anything... 23:35:36 <aleth> Just odd. 23:35:48 <clokep> Sorry. :( 23:35:54 * clokep waits for Komodo to update... 23:36:02 <Mook_as> sorry :( 23:36:24 <clokep> It's really slow...was 7.1 release or is that just because I'm on some nightly channel? 23:36:26 * clokep is looking for release notes... 23:36:53 <Mook_as> umm, nightly 23:37:03 <Mook_as> 7.1 is still a while, I think 23:37:14 <clokep> That's what I thought. :) 23:42:21 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1454 on bug 318. 23:42:22 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1482 on bug 318. 23:42:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly 23:44:18 <aleth> The title of that bug kind of sells it short ;) 23:44:36 <clokep> What do you mean? 23:44:40 <clokep> Like the size of that patch? :) 23:44:53 <clokep> (Feel free to read it over if you'd like!) :) 23:45:00 <aleth> And all the extra mode stuff... 23:45:05 <aleth> Not again :P 23:45:06 <clokep> Yes, shhh... 23:45:14 <clokep> I hate the mode command a lot. :( 23:45:59 <aleth> We should make instantbot respond to it 23:46:33 <aleth> He could compare /mode to ++ 23:46:44 <aleth> (missing C there) 23:49:37 <clokep> Mook_as: Do you know how hard it would be to make a protocol build off of a configure flag / if there's docs / examples to adding a flag to mozconfig? 23:50:40 * clokep has no idea where to start. :-S 23:52:33 <Mook_as> I imagine it'd look a little like http://lxr.instantbird.org/instantbird/source/configure.in#6592 23:52:44 <Mook_as> but... not exactly a minimal example 23:53:17 <Mook_as> need to also add something like http://lxr.instantbird.org/instantbird/source/config/autoconf.mk.in#52 23:53:34 <Mook_as> then you can just use it in makefiles, http://lxr.instantbird.org/instantbird/source/purple/libpurple/Makefile.in#95 23:54:37 <clokep> OK. :) That's what I was thinking... 23:55:01 <clokep> Well...minus the autoconf.mk...What is that file for? 23:55:12 <Mook_as> that's the configure.in -> makefile bridge 23:55:30 <Mook_as> (the @foo@ gets replaced by configure, so it can be used by the makefiles later) 23:55:45 <clokep> Ahhhh, I see. 23:56:02 <clokep> So configure modifies that file, which is then included in the makefiles, or something like that. 23:56:58 <Mook_as> yep! 23:57:12 <Mook_as> turns into autoconf.mk of course, in your objdir 23:57:26 <Mook_as> reading it might tell you more. probably not, though, it's pretty clear :) 23:58:15 <clokep> Yeah, I think that makes sense. :) 23:58:42 <instant-buildbot> build #254 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/254