#instantbird log on 04 23 2012

All times are UTC.

00:31:05 --> Kaishi has joined #instantbird
01:48:02 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
02:42:17 <-- EionRobb has quit (Quit: Leaving.)
02:42:48 --> EionRobb has joined #instantbird
02:45:43 <-- EionRobb has quit (Quit: Leaving.)
02:46:38 --> EionRobb has joined #instantbird
02:53:45 <instant-buildbot> build #473 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/473
04:49:25 <instant-buildbot> build #564 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/564
05:47:57 <-- Kaishi has quit (Quit: Kaishi)
05:48:01 <-- EionRobb has quit (Quit: Leaving.)
05:48:11 --> EionRobb has joined #instantbird
05:49:54 <-- EionRobb has quit (Ping timeout)
06:02:48 <instant-buildbot> build #461 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/461
07:06:01 --> pvagner has joined #instantbird
07:10:55 --> jb has joined #instantbird
07:11:13 --> je has joined #instantbird
07:59:21 --> Mic has joined #instantbird
07:59:21 * ChanServ sets mode +h Mic 
08:02:55 <Mic> Hi
08:09:50 <-- je has quit (Quit: je)
08:10:16 --> jc has joined #instantbird
08:12:35 <-- Even1 has quit (Quit: Instantbird -- http://www.instantbird.com)
08:12:42 --> Even1 has joined #instantbird
08:13:51 <-- Mic has quit (Input/output error)
08:22:54 <-- Even has quit (Quit: Instantbird -- http://www.instantbird.com)
08:28:13 --> Even has joined #instantbird
08:28:14 * ChanServ sets mode +o Even 
08:28:23 <-- Even has quit (Quit: Instantbird -- http://www.instantbird.com)
08:28:34 --> Even has joined #instantbird
08:28:34 * ChanServ sets mode +o Even 
08:30:47 --> chrisccoulson has joined #instantbird
08:35:00 --> Tomek has joined #instantbird
08:35:59 --> mmkmou has joined #instantbird
08:36:29 --> myk has joined #instantbird
08:38:16 --> gpsychosis has joined #instantbird
08:38:34 <-- gerard-majax has quit (Ping timeout)
08:38:59 <gpsychosis> Hi there, I'm a little too lazy to check for these things in wikis and repos, but I was wondering if there was a way to do two things:
08:39:07 <gpsychosis> a) sort contacts within tags by online status
08:39:17 <gpsychosis> b) have separate visual themes for different accounts
08:40:47 * gpsychosis says while sifting through wikis and repos
08:42:24 <gpsychosis> god I love this client though
08:42:26 <gpsychosis> what a breath of fresh air
08:42:52 <-- jc has quit (Quit: jc)
08:44:06 --> NmN has joined #instantbird
08:49:53 --> jc has joined #instantbird
08:55:47 <-- myk has quit (Ping timeout)
08:57:23 <-- Tomek has quit (Quit: Instantbird 1.1)
08:59:49 --> Mic|web has joined #instantbird
09:00:05 <Mic|web> Hi gpsychosis,
09:00:10 <gpsychosis> hello
09:00:24 <gpsychosis> I found a report on Bugzilla that requested this last year
09:00:29 <gpsychosis> but it ended unresolved
09:00:38 <Mic|web> About which one?
09:00:41 <gpsychosis> or it was decided that it was extension fodder, though I couldn't find the extension
09:00:45 <gpsychosis> sorting contacts
09:00:49 <gpsychosis> a)
09:00:54 <Mic|web> Ah, I think someone created one.
09:01:08 <gpsychosis> Could you point me in the right direction, Mic|web?
09:01:23 <gpsychosis> Oh wow, looks like tab-complete is in here, won't be adding that extension then
09:01:25 <Mic|web> You can wait for "clokep" (also "clokep_work") who comes frequently here. I think he was the one.
09:01:36 <Mic|web> You're using the nightly builds then?
09:02:35 <gpsychosis> nope
09:02:39 <gpsychosis> Just the stable
09:02:39 --> aleth has joined #instantbird
09:02:39 * ChanServ sets mode +h aleth 
09:02:55 <gpsychosis> 1.1
09:03:07 <gpsychosis> Didn't know that it included tab-complete for nicks
09:04:11 <Mic|web> hhe, I can't remember. When using nightly builds feature are changing so continuously ;)
09:04:29 <gpsychosis> Mic|web: do you know if I can use DCC with InstantBird?
09:04:47 <gpsychosis> that would make it effectively the most bitchin' XChat replacement ever
09:05:04 <Mic|web> No, that's not possible (yet?) Maybe there's an enhancement request in Bugzilla.
09:05:25 <gpsychosis> okay. So what about the separate themes per protocol, though?
09:05:29 <aleth> DCC, is that file transfer?
09:05:30 <Mic|web> http://log.bezut.info/instantbird/111111/#m181
09:05:33 <gpsychosis> yes, aleth
09:05:48 <Mic|web> So you should ask clokep.
09:06:00 <gpsychosis> I kinda glazed over that, Mic|web 
09:06:01 <aleth> gpsychosis: I think an alternative (better) way of doing file transfer is planned for the future. 
09:06:13 <aleth> Not sure exactly when it will be implemented though...
09:06:15 <gpsychosis> aleth: does that mean it already does file transfer?
09:06:25 <aleth> No, not at the moment.
09:06:45 <Mic|web> gpsychosis: the problem with file transfers is that it is so unreliably working with proxies and behind routers. We want something that always works, atleast one fallback that does
09:07:24 <gpsychosis> Surely a placeholder that uses the same methods as most IRC clients would be in order, though?
09:07:26 <gpsychosis> Not that I'm complaining
09:07:41 <gpsychosis> high standards are a precious thing
09:08:12 <gpsychosis> So, the visual theme thing is my other concerm.
09:08:14 <Mic|web> per-account-messagestyles is something we don't really want since we think that it is only important to reach someone and networks (protocols) are only the means and not important in themselves
09:08:31 <aleth> It would make a nice add-on though!
09:08:41 <aleth> gpsychosis: If you felt like writing one... ;)
09:08:43 <gpsychosis> Mic|web: my reasoning is that the simple timestamp format does not work very well with Twitter
09:08:57 <gpsychosis> I'd have to learn the appropriate scripting language, wouldn't I?
09:09:05 <gpsychosis> Where's the dev documentation?
09:09:07 <aleth> Javascript
09:09:22 <Mic|web> gpsychosis: would you mind filing a bug that "the simple timestamp format doesn't work well with Twitter"?
09:09:23 <gpsychosis> I hear JS is pretty simple stuff
09:09:32 <aleth> https://wiki.instantbird.org/Developer
09:09:35 <gpsychosis> Well, it works as expected, Mic|web 
09:09:48 <gpsychosis> It's just a brainf**k
09:09:52 --> flo has joined #instantbird
09:09:52 * ChanServ sets mode +qo flo flo 
09:09:55 <gpsychosis> but it's perfect with IRC
09:10:33 <Mic|web> If you think there's a problem, just file it. Make you include which messagestyle you were using.
09:10:49 <gpsychosis> It's not a problem so much as an enhancement
09:10:53 <gpsychosis> there's a category for those, right?
09:11:01 <Mic|web> Yes, there is.
09:11:35 <gpsychosis> I just really feel like IRC needs a dense visual style, whereas Twitter needs a segregated visual style
09:11:42 <aleth> It does sound more like best implemented by an add-on to me though
09:11:53 <aleth> It might be a popular one of course ;)
09:12:02 <gpsychosis> Well, I'd better get to learning JavaScript
09:12:12 <gpsychosis> This might be what gets me into coding
09:12:28 <gpsychosis> I've been struggling with Python for a couple months, having no reason to use it
09:13:11 --> gerard-majax has joined #instantbird
09:13:21 <aleth> Learning by doing is always a good approach :)
09:13:46 <Mic|web> gpsychosis: wanting a feature was how I got involved in Instantbird development. I started with a really simple extension. :)
09:14:11 <gpsychosis> Groovy.
09:14:12 <Mic|web> You can always come here and ask for help if you run into problems during the process
09:14:22 <gpsychosis> I probably will.
09:14:38 <gpsychosis> Also, I ended up reinstalling InstantBird after I found out I couldn't manage my Tags
09:14:48 <Mic|web> :O
09:14:59 <gpsychosis> That probably needs to go somewhere
09:15:05 <Mic|web> (It's "Instantbird" by the way, like "Thunderbird")
09:15:13 <gpsychosis> Thanks for that
09:15:25 <Mic|web> I'm away now, enjoy using Instantbird!
09:29:05 <aleth> gpsychosis: If there really is a problem with tag management, please file a bug!
09:29:15 <gpsychosis> Well, the feature doesn't exist at all
09:29:30 <gpsychosis> I'm still filing my message style enhancement request
09:29:45 <gpsychosis> I'll get on it, though
09:32:48 <instantbot> New Core - Twitter bug 1387 filed by florian@instantbird.org.
09:32:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1387 nor, --, ---, nobody, NEW, The 'Copy Link to Tweet' action should be in the context menu even when the twitter account is disco
09:33:09 <gpsychosis> https://bugzilla.instantbird.org/show_bug.cgi?id=1072
09:33:12 <instantbot> Bug 1072 enh, --, ---, nobody, NEW, Tags should be editable and/or removable
09:33:15 <gpsychosis> > aleth
09:33:39 <flo> aleth: JavaScript strict warning: chrome://chat/content/convbrowser.xml, line 565: reference to undefined property this._lastScrollHeight
09:34:24 <aleth> gpsychosis: Ah, that's what you meant. OK.
09:34:27 <gpsychosis> actually you have a comment in there
09:34:30 <gpsychosis> just noticed
09:34:41 <gpsychosis> probably not worth me confirming as well
09:34:54 <aleth> Just cc yourself if you want to be informed of developments
09:35:11 <aleth> flo: is that in reference to one of my patches?
09:35:24 <instantbot> New Instantbird (UI) bug 1388 filed by gpsychosis@gmail.com.
09:35:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1388 enh, --, ---, nobody, UNCO, Separate visual message styles for different protocols or accounts
09:35:33 <flo> aleth: not really, but I suspect you know that code more than I do these days :)
09:36:16 <aleth> Do you have any STR?
09:38:47 <-- mmkmou has quit (Ping timeout)
09:39:45 <flo> no, just noticed that in my terminal
09:39:56 <flo> I haven't even looked at the code to see what's around
09:40:24 --> mmkmou has joined #instantbird
09:41:57 --> sonny has joined #instantbird
09:51:08 <-- jc has quit (Quit: jc)
09:52:43 <-- jb has quit (Quit: Instantbird 1.1)
10:00:18 * aleth just learned this is valid JS: "let undefined = false;" :-/
10:01:47 <flo> aleth: uh, really?
10:02:05 <flo> can you set it to true? Does it mess things up?
10:07:40 <aleth> Ah, it seems the mozilla implementation is clever enough to have undefined as read-only
10:07:55 <aleth> I had seen an example where it was set to 42...
10:11:21 <aleth> however, you can do |let k = { undefined: true };| 
10:14:03 <flo> aleth: you will still need k.undefined to access that value, and it's the same as let k = {}; k["undefined"] = true. There's no reason to forbid that.
10:14:42 <aleth> Sure. Apparently undefined was not read-only in older FF versions though...
10:17:34 <aleth> And I guess it could be confusing if you set k[x] = true; and x was undefined, and you ignore the warning?
10:19:49 <aleth> "re-assigning values to the undefined variable is very bad practice, and in fact its not allowed by ECMA 5" ;)
10:20:23 --> clokep has joined #instantbird
10:20:23 * ChanServ sets mode +o clokep 
10:21:28 <flo> clokep: Good morning :)
10:24:45 <Mic|web> Hi
10:25:26 <clokep> Good morning.
10:25:32 <Mic|web> clokep: there was a question about sorting contact by status and you said you had a WIP for this. Do you still have it and/or does it work ?
10:25:38 <clokep> gpsychosis: DCC is not supported right now.
10:25:38 <Mic|web> *contacts
10:25:46 <clokep> Yeah I just read the logs.
10:25:52 <clokep> I have it somewhere...
10:25:55 <gpsychosis> Thanks for your response, clokep
10:26:02 <gpsychosis> I was just about to log off.
10:26:19 <gpsychosis> It's alright, though, I appreciate that you want to implement a quality file transfer solution
10:26:37 <clokep> Let me make sure it works. ;)
10:26:45 <clokep> (The sorting by status...)
10:26:54 <clokep> I don't suppose you know the bug #?
10:27:17 <gpsychosis> I'm studying JavaScript and will probably help to develop either the implementation of contact sorting or the separate message styles per account/protocol I requested
10:27:30 <gpsychosis> I don't know the bug # offhand
10:27:34 <gpsychosis> I was just about to go to sleep
10:27:36 <gpsychosis> closed the tabs
10:28:31 <Mic|web> :O Instantbot allows to list several bugs at once.
10:28:43 <Mic|web> Bugs 1,2,3
10:29:09 <Mic|web> hmm, do I need to ping him for that? :(
10:29:16 <Mic|web> instantbot: bugs 1,2,3
10:29:20 <instantbot> 3 bugs found
10:29:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1 nor, P5, idechix, NEW, Make bugzilla.instantbird.org look like other instantbird websites
10:29:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2 nor, --, florian, RESO FIXED, Load accounts even when the prpl can't be loaded
10:29:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=3 maj, P5, romain, RESO FIXED, report startup failures in an understandable way
10:29:34 <clokep> Bug 701 ;)
10:29:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=701 enh, --, ---, nobody, NEW, Sort buddies by status
10:29:40 <clokep> I'll upload the extenison there in a second.
10:29:57 <gpsychosis> Excellent. I'll try it out when I wake up.
10:30:02 <gpsychosis> Thanks, clokep
10:30:10 <flo> gpsychosis: good night :)
10:30:17 <gpsychosis> cheers, flo
10:30:23 * flo is wondering what gpsychosis's timezone is
10:30:23 <gpsychosis> bang-up job on this client of yours
10:30:29 <gpsychosis> EST :V
10:30:52 <gpsychosis> bizarro-EST
10:30:53 <gpsychosis> more like
10:31:01 <clokep> EST? :P I'm EST...I just woke up!
10:31:02 <flo> :-D
10:31:09 <gpsychosis> Yeah...
10:31:16 <flo> clokep: I think he meant geek-EST ;)
10:31:25 <clokep> gpsychosis: There's an extension attached to bug 701 now to sort by status, but it requires nightly builds.
10:31:28 <gpsychosis> Maybe I should just stay up and charge through CodeAcademy's JS lessons
10:31:51 <gpsychosis> Is there a risk to losing my configuration files if I use those?
10:31:52 <clokep> Just switch to a 28 hour day...
10:31:58 <gpsychosis> I probably should if I'm going to be developing for it
10:32:30 <gpsychosis> I'll just back 'em up.
10:33:10 <clokep> FYI We don't do DCC because Instantbird doesn't do file transfer, so it wouldn't help for the protocol to support it if there's no UI for it. :) But feel free to file a bug (there isn't one on file AFAIK)
10:33:34 <gpsychosis> I don't feel like it's that important
10:33:49 <gpsychosis> I'd just be using it for scanlation leeching
10:35:16 <gpsychosis> I'll just grab a few hours of sleep and get right back to JS, then. Might as well idle and seed, too. Cheerio!
10:36:36 <clokep> Goodnight!(?)
10:37:04 <aleth> clokep: So that bug can be resolved fixed? :)
10:37:41 <clokep> aleth: Once I upload it to AIO.
10:37:44 <-- mmkmou has quit (Ping timeout)
10:38:01 <flo> if we decide something is for an add-on, and the add-on has been developed, is it resolved FIXED, WORKSFORME, or WONTFIX?
10:38:08 <flo> (or even INVALID)
10:38:20 <clokep> flo: I was thinking the same thing. :)
10:38:23 <clokep> I think it's WONTFIX.
10:38:24 <Mic|web> RESOLVED ADDON? ;)
10:38:39 <flo> wontfix sounds good
10:38:55 <aleth> RESOLVED YOUFIX? ;)
10:40:47 * clokep is confused that that extension has a bootstrap.js but doesn't seem restartless. :-S
10:40:53 <aleth> That's more for when the add-on hasn't been developed I guess...
10:41:01 <clokep> Ah....seems to be because I use a style tag in the chrome.manifest, Idk if that's supported...
10:41:22 <Mic|web> 1.2-wanted on a WONTFIX but seems strange.
10:41:25 <Mic|web> *bug
10:41:47 <aleth> I just put the 1.2-wanted so clokep wouldn't forget to upload the add-on before release
10:42:02 <clokep> Do we really not have a bug for separate themes per protocol?
10:42:27 <Mic|web> clokep: I also thought it would be a dupe but I couldn't find one
10:42:47 * clokep resolves WONTFIX. ;)
10:43:34 <flo> ahah :)
10:43:59 <flo> at some point I wanted a way to have different themes for some specific contacts
10:44:54 <flo> the idea was to reduce the likely hood of sending something to the wrong person by having very different appearances for the few important people that the user talks to almost daily
10:45:24 <clokep> Yeah, makes sense.
10:45:38 <clokep> My biggest problem w/ it is actually developing a UI to support the feature.
10:45:46 <flo> probably for an add-on anyway ;)
10:46:23 --> mmkmou has joined #instantbird
10:54:11 <clokep> Yes, probably!
11:00:00 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
11:05:04 <-- NmN has quit (Ping timeout)
11:41:35 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
11:49:00 <-- mmkmou has quit (Client exited)
11:54:19 --> mmkmou has joined #instantbird
12:02:06 --> clokep_work has joined #instantbird
12:02:06 * ChanServ sets mode +o clokep_work 
12:16:16 <instantbot> New Instantbird (UI) bug 1389 filed by aletheia2@fastmail.fm.
12:16:17 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1381 on bug 1389.
12:16:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1389 min, --, ---, nobody, NEW, Warning: reference to undefined property this._lastScrollHeight
12:19:17 --> NmN has joined #instantbird
12:32:50 --> waynenguyen has joined #instantbird
12:43:46 --> ig0rk0 has joined #instantbird
12:44:29 <ig0rk0> hi
12:44:34 <ig0rk0> clokep_work: PING
12:44:40 <ig0rk0> oops
12:47:04 <ig0rk0> ah, nevermind...
12:47:54 <clokep_work> ig0rk0: Do you have a question? ;) If so just ask it.
12:49:10 <ig0rk0> wanted to ask about sorting addon but than i got that it\s not about participiants sorting but about buddies
12:50:14 <clokep_work> Yeah, it's for contacts. I don't think participants have any "status" really associated with them half the time...
12:50:30 --> jb has joined #instantbird
12:59:45 <flo> I think at this point we should be removing [1.2-wanted] annotations, not adding more :-S
13:00:51 <flo> aleth: why the typeof check rather than the in operator?
13:04:49 <-- ig0rk0 has quit (Ping timeout)
13:06:14 --> Mic|web has joined #instantbird
13:08:04 <aleth> why not? in would work as well I guess
13:08:19 <-- skeledrew has quit (Quit: Instantbird -- http://www.instantbird.com)
13:11:04 <flo> aleth: because I think we have used |in| in lots of similar casese
13:11:07 <flo> *cases
13:11:12 <Mic|web> aleth: what about if(this._lastScrollHeight && (...blabla..))
13:11:33 <aleth> Mic|web: I wasn't sure it couldn't ever be zero
13:11:35 --> skeledrew has joined #instantbird
13:11:43 <-- skeledrew has quit (Quit: Instantbird -- http://www.instantbird.com)
13:11:56 <aleth> flo: Feel free to change it then :)
13:12:08 <flo> aleth: ok
13:13:05 <aleth> I thought usually we did as Mic suggested...
13:16:45 --> logiclord has joined #instantbird
13:29:11 <-- mmkmou has quit (Ping timeout)
13:30:01 <Mic|web> logiclord: you had a question about interfaces not long ago. Has it been answered already?
13:30:19 <logiclord> Mic|web: No
13:30:59 <logiclord> http://pastebin.com/2XnwQhQM
13:31:11 <logiclord> It shows an array of  [xpconnect wrapped (nsISupports, nsIClassInfo,  prplIConversation, prplIConvIM)]  I am not able to figure out how to  access prplIConversation  object for an element
13:31:15 <logiclord> ?
13:31:48 <-- jb has quit (Quit: jb)
13:33:53 <-- pvagner has quit (Ping timeout)
13:34:59 <Mic|web> Try yourObject.prplConversation.blabla() instead of yourObject.blabla()
13:35:11 <Mic|web> I hope I remembered that correctly ;)
13:35:36 <flo> why wouldn't yourObject.blabla() work?
13:37:41 <logiclord> when I try this._purpleConversations[0].prplIConversation it showns  [xpconnect wrapped  prplIConversation)] :-/
13:37:55 <logiclord> considering 0th element exist when i try
13:37:57 <flo> logiclord: I think we are confused by your question; it would help if you could pastebin the code that doesn't produce the result you expect
13:38:09 <logiclord> flo: okay
13:38:16 * clokep_work was in the middle of replying to that and went to a meeting...:(
13:38:21 <flo> logiclord: right, and what's wrong with that?
13:38:29 --> jb has joined #instantbird
13:38:31 <Mic|web> prplConversation instead of prplIConversation btw
13:39:02 <logiclord>  flo: I was trying to dump it as json :-/ 
13:39:03 <logiclord> using
13:39:11 <logiclord> JSON.stringify and all
13:39:16 <logiclord> for experimentation 
13:39:56 <flo> logiclord: it's not a JS object, but an XPCOM component implementing an interface
13:39:57 <logiclord> Mic|web: typo there 
13:40:21 <flo> so I wouldn't expect JSON.stringify to work on it
13:40:50 <logiclord> flo: Yes I came to know when I saw XP connect but  is there any mechanism to do something similar ?
13:41:31 <flo> what is "something similar" in this context?
13:42:01 <flo> there are ways to dump things, but not to "unserialize" to get back the same object from the dump
13:42:41 <logiclord> dumping object as json format 
13:42:57 <flo> but if you are doing this to keep a record of conversations so that you can reopen them later, what you want to do is probably keep only the name of the conversation and the account used, or whatever you need to identify which log files corresponds to that conversation
13:43:13 <logiclord> flo : let me explore  them ?
13:43:29 <logiclord> flo: yes aim was that only 
13:44:23 <flo> logiclord: just for the sake of learning, there may be code doing something very similar to what you were attempting to do around http://lxr.instantbird.org/instantbird/source/chat/components/src/logger.js#98
13:44:27 <-- NmN has quit (Quit: Instantbird 1.1)
13:44:43 <flo> but I don't think you would want to duplicate that
13:45:30 <logiclord> flo : araen't these conversation logs like messages etc ?
13:46:05 <flo> another vague question that I don't understand
13:46:44 * flo wonders if clokep_work has seen https://bugzilla.mozilla.org/show_bug.cgi?id=747743 yet
13:47:40 <logiclord>  flo: I mean do we store details required to restart conversation ? 
13:48:28 <flo> well, the log viewer redisplays conversations
13:48:42 * bear-afk is now known as bear
13:49:24 <logiclord> I see we save serialize procedure http://lxr.instantbird.org/instantbird/source/chat/components/src/logger.js#146 :-/
13:49:51 <clokep_work> flo: So I can review things and stuff for chat on BMO, but obviously I can't check them in...so do you just handle that? I see that bugs seem to randomly be checked in by random people. :-S
13:50:12 <flo> what's random?
13:50:14 <clokep_work> I ask because one of my fixes I was told (fairly harshly IMO) to format my patch properly before attaching it.
13:50:40 --> Tomek has joined #instantbird
13:50:43 <flo> ah
13:51:20 <flo> so usually it's up to the patch author to check-in the fix, or to the reviewer if the reviewer knows the author likely doesn't have an hg account
13:51:44 <flo> or to some release drivers if something is important for a release (like Standard8 handling lots of aurora checkins very quickly)
13:51:58 <clokep_work> OK. So theoretically if I review your stuff or you review my stuff I don't really need to worry about it this much.
13:52:19 <clokep_work> And that change makes sense.
13:52:24 <flo> the other possibility is: none of the involved people has commit access or is willing to spend time to do check-ins, and then just adding the "checkin-needed" keyword works
13:52:28 <clokep_work> There's too many string options for idlf iles. :(
13:52:52 <clokep_work> I think something else I reviewed for you wasn't checked in yet either. ;)
13:53:27 <flo> but then the patch is checked in by volunteers who have commit access, but don't know anything about the bug, and having to read all the thread of comments to know who are the reviewers, which attachment should be included, etc... is quite painful, so it's way better for them (who are just volunteers spending time check-ing in patches they don't care about) to have the commit messages in the attachment
13:53:37 <-- logiclord has left #instantbird ()
13:53:49 <clokep_work> Alright, makes sense. :) THanks.
13:54:15 <flo> clokep_work: "I think something else I reviewed for you wasn't checked in yet either. ;)" what's that?
13:54:20 <flo> I'm about to do check-ins ;)
13:54:38 <clokep_work> I think the one about telling the docshell it's content?
13:54:58 <flo> uh, have I ever written that patch?
13:54:59 <Mic|web> clokep_work: I started using "hg commit + hg export" to get nice patchs with a commit message not long ago
13:55:01 <clokep_work> bug 740502
13:55:46 <clokep_work> Mic|web: Yes, I saw. :) I know how to do it, was just not sure when it's necessary, if i should r- things that don't have it, etc.
13:56:01 <flo> that bug is fixed for both comm-central and comm-aurora
13:56:10 <clokep_work> flo: Yes, I'm just crazy then. :(
13:56:11 <clokep_work> Sorr.y
13:56:29 <flo> not having a commit message included isn't a reason for r-
13:56:45 <clokep_work> I didn't think so, I just wanted to make sure. :)
13:56:54 <clokep_work> Anyway I have a meeting bbl.
13:56:57 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
13:57:52 --> jc has joined #instantbird
13:58:10 <-- jb has quit (Ping timeout)
13:58:14 <Mic|web> clokep: sort-by-status seems to work from what I've seen here.
13:58:21 --> jb has joined #instantbird
14:00:54 --> logiclord has joined #instantbird
14:12:07 <logiclord> flo : how about saving in xml format ?
14:14:24 <flo> what about it?
14:15:33 <logiclord> saving required details in xml will help in parsing ?
14:15:53 <flo> no ?
14:16:35 <logiclord> okay just exploring options
14:16:59 <flo> I'm still not sure of why so many people think XML is a magic helpful solution
14:17:35 <logiclord> flo: may be they hope ... there will be some library to easily help and parse info
14:17:50 <flo> can't be easier than JSON ;)
14:18:36 <logiclord> flo: I agree :)
14:21:02 --> mmkmou has joined #instantbird
14:21:57 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com)
14:24:18 --> mmkmou has joined #instantbird
14:35:32 <Mic|web> logiclord: here's a small example what you can do with the list of conversations: http://pastebin.instantbird.com/31593
14:35:53 <Mic|web> If you remove the linebreaks it will even work on your error console.
14:43:35 <logiclord> Mic|Web thanks
14:43:37 <aleth> logiclord: You seem to be worrying about serializing entire objects for which there is an idl, rather than just saving the information you need in order to restore?
14:44:05 <logiclord> aleth could u point me to idl ?
14:44:17 <aleth> No, my point is the latter is much easier!
14:45:16 <aleth> Just look at what data you need to open a conversation... usually just name and account I would think.
14:46:38 <flo> logiclord: http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl
14:46:50 <logiclord> aleth: so you think just store in a normal file ?
14:47:09 <logiclord> flo: already had a look :)
14:47:33 <Mic|web> logiclord: he's saying that you should only store the information that you actually need to restore.
14:48:07 <Mic|web> i.e. a list of the accounts that were connected. All you'll need for that is the id of the account.
14:48:08 <aleth> And store that in whatever format is easiest for you :)
14:48:14 <aleth> Probably JSON I would guess
14:48:35 <logiclord> Mic|Web yes I will remove unnecessary details.... I was experimenting with object dumps
14:48:36 <flo> a JSON string in a preference maybe? :)
14:48:49 <logiclord> flo: yes JSON 
14:49:14 <Mic|web> When trying to restore, you take the id, throw if at the accounts service to fetch the account
14:49:22 <Mic|web> and call the connect method for it.
14:50:50 <-- mmkmou has quit (Ping timeout)
14:51:53 <logiclord> Mic|Web I ws thinking to use http://lxr.instantbird.org/instantbird/source/chat/components/src/imConversations.js#386
14:52:00 <aleth> You probably ultimately want to save a list of open windows, containing a list of its open tabs, containing for each the information you need to reconnect.
14:52:12 <logiclord> addConversation
14:53:01 <logiclord> aleth if we could save aPurpleConversations in service I thought Ui will automatically be created from addConversation
14:53:50 <logiclord> http://lxr.instantbird.org/instantbird/source/chat/components/src/imConversations.js#353 purpleConversation list
14:53:59 <aleth> logiclord: Yes. I'm not sure what's the best way, but I thought you also wanted to save window position etc
14:54:27 --> mmkmou has joined #instantbird
14:54:28 <aleth> But of course you can only move a window once it has been created, so you are right.
14:54:37 <logiclord> aleth : That's a preference
14:54:49 <logiclord> if i found a way
14:54:51 <aleth> And maybe a second step...
14:54:53 <Mic|web> Don't try to do all at once.
14:55:06 <logiclord> aleth: yes
14:55:11 <aleth> Yes, sorry, didn't want to add any confusion
14:56:41 <aleth> Mic|web: That pastebin is nice, have you added it to your example add-on?
14:57:51 <logiclord> I have one more doubt should I change current source code ... like add a step to save details via current function or add new function ?
14:59:26 <Mic|web> logiclord: trying to store the conversation is wrong in my opinion.
14:59:47 <logiclord> Mic|web then ?
15:00:14 <Mic|web> I'd rather store the id of the contact, then call http://lxr.instantbird.org/instantbird/source/chat/components/public/imIContactsService.idl#55 to get the contact and call "createConversation" on it
15:01:29 <aleth> logiclord: I'd say add it in whatever way seems best to you, then you can always get feedback on a WIP.
15:01:37 <logiclord> Mic|web will this work in all scenarios like irc rooms ?
15:03:39 <Mic|web> I think you'd need to distinguish here but from what I can tell it will be far easier and less fragile than what you're trying to do
15:04:16 <logiclord> Mic|web then I will explore that route as well 
15:04:59 <aleth> Mic|web: You'd also need to distinguish DM conversations via IRC for which the conversation partner is not stored as a buddy
15:06:10 <-- logiclord has left #instantbird ()
15:08:22 <Mic|web> This shows the account id and contact id: http://pastebin.instantbird.com/31605
15:09:41 <Mic|web> And this opens a conversation to one of those contacts, only using the id of it: http://pastebin.instantbird.com/31616
15:09:44 <aleth> Hmm, maybe that is actually already set for DMs
15:09:54 <aleth> I'm not sure.
15:10:01 <-- Tomek has quit (Ping timeout)
15:18:20 <flo> Mic|web: how broken will that method be if a real contact is created in the meantime?
15:18:49 <flo> Mic|web: I think we would want the account id and the buddy id
15:19:53 --> logiclord has joined #instantbird
15:20:11 <Mic|web> I don't think I understand the first line of this?
15:20:53 <flo> Mic|web: a contact id that's < 0 means that it's a dummy contact that doesn't exist in the blist database.
15:21:43 <flo> Mic|web: we create a real contact only when there's something to save about it: either a local alias, more than one tag, or several buddies
15:22:04 <Mic|web> bug how should something happen in the meantime between shutdown and restart?
15:22:10 <Mic|web> *but
15:26:08 <flo> Mic|web: if you are restoring at startup, it can't happen. If you are restoring at the time the account gets reconnected, it's another story
15:26:17 <flo> (or if sync ever gets introduced during startup)
15:26:19 <flo> (or whatever)
15:26:41 <flo> I just have a feeling that storing ids or dummy contacts is fragile :)
15:28:04 <Mic|web> I
15:28:50 <Mic|web> I'm sure you know a lot about edge-cases here.
15:29:56 <flo> probably too much ;)
15:30:28 <Mic|web> And frankly I don't care if it is the contact id or a buddy id and the account ...
15:30:32 <flo> it's painful when knowing that some rare edge cases will need to be dealt with in the future gets in the way of getting things done for the general case ;).
15:44:01 <-- logiclord has quit (Ping timeout)
15:44:12 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
15:46:26 --> logiclord has joined #instantbird
15:49:37 <-- waynenguyen has quit (Ping timeout)
15:55:57 <-- mmkmou has quit (Ping timeout)
16:03:33 --> mmkmou has joined #instantbird
16:22:36 --> myk has joined #instantbird
16:34:24 * bear is now known as bear-afk
16:41:32 --> Kaishi has joined #instantbird
16:45:26 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:49:03 --> Mook_as has joined #instantbird
16:56:21 <-- myk has quit (Quit: Instantbird -- http://www.instantbird.com)
16:57:01 --> clokep_work has joined #instantbird
16:57:01 * ChanServ sets mode +o clokep_work 
16:57:35 <-- gerard-majax has quit (Ping timeout)
17:05:22 * bear-afk is now known as bear
17:25:09 <-- Even has quit (Quit: Instantbird -- http://www.instantbird.com)
17:41:46 <clokep_work> Sounds like you guys have been busy. ;)
17:55:25 --> myk has joined #instantbird
17:56:10 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com)
17:58:42 <-- Kaishi has quit (Quit: Kaishi)
18:01:31 <-- jb has quit (Ping timeout)
18:01:40 <-- jc has quit (Ping timeout)
18:03:49 --> pvagner has joined #instantbird
18:37:10 <-- myk has quit (Quit: Instantbird -- http://www.instantbird.com)
18:37:17 --> myk has joined #instantbird
18:55:31 <-- logiclord has quit (Quit: Leaving.)
19:03:55 --> Mnyromyr has joined #instantbird
19:04:08 --> flo has joined #instantbird
19:04:08 * ChanServ sets mode +qo flo flo 
19:07:53 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
19:08:26 --> flo has joined #instantbird
19:08:26 * ChanServ sets mode +qo flo flo 
19:12:49 <clokep_work> Good evening flo. :)
19:15:45 * bear is now known as bear-afk
19:33:10 <gpsychosis> Christ, it's evening already
19:34:16 <clokep_work> Only in France. ;)
19:35:19 <gpsychosis> Sunny Toronto can expect snow and slush this week
19:35:28 <gpsychosis> Might as well be evening
19:35:34 <gpsychosis> it's chilly as
19:40:21 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1381 on bug 1389.
19:40:22 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1382 on bug 1389.
19:40:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1389 min, --, ---, aletheia2, ASSI, Warning: reference to undefined property this._lastScrollHeight
19:41:32 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1382 on bug 1389.
19:41:33 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1383 on bug 1389.
19:42:55 <flo> one should always wait a few minutes before looking at aleth's new patches ;)
19:43:31 <aleth> it's the trivial changes where mistakes creep in ;)
19:44:28 <flo> bustage often comes from (apparently) trivial changes requested by reviewers that are so trivial that the patch author doesn't test the new version of the patch, in the hope that attaching the new iteration quickly will help get a fast r+ while the reviewer still has some attention on that code ;)
19:45:03 <clokep_work> Yes. :(
19:48:15 <flo> that why we (should) have unit tests ;)
19:48:46 <flo> *that's
19:49:12 <aleth> For basic things like successfully opening a conversation...
19:49:59 <aleth> Probably not easy to write a test for though.
19:50:51 * bear-afk is now known as bear
19:51:31 <flo> we have lots of bad excuses for not doing it ;)
19:55:41 <flo> http://google-opensource.blogspot.fr/2012/04/students-announced-for-google-summer-of.html
19:56:05 * jwir3 is now known as jwir3|lunch
19:57:45 <clokep_work> Saw that already. :) Some intersting projects.
19:59:59 <clokep_work> The site is really SLOWWWW right now though.
20:00:10 <aleth> It's just Loading...
20:00:17 <flo> yeah
20:00:23 <flo> so Pidgin is mentoring 4 students?
20:00:40 <clokep_work> Yes, seems like it.
20:00:55 <clokep_work> I can't believe the Android one is accepted. :-S Isn't ther elike code out there to do that already?
20:01:10 <flo> I think so
20:01:27 <flo> + we could (probably) trivially build purplexpcom for android
20:01:49 <clokep_work> EionRobb is mentoring one. ;)
20:01:49 <flo> I have a hard time believing the usage statistic collection one is accepted ;)
20:02:08 <flo> it seems both super easy and spyware-y
20:02:23 <clokep_work> Yes. :-/
20:02:31 <flo> ah? I don't see the mentors listed there
20:02:57 * clokep_work does..
20:03:09 <clokep_work> On the chart page, not the individual page.
20:03:14 <clokep_work> (The one that lists all the projects)
20:03:38 <clokep_work> I guess Gadu-Gadu updates would be nice? :P Maybe we have bug reports we should throw that way. ;)
20:04:00 <flo> which project is he mentoring?
20:04:22 <clokep_work> The usage stats.
20:04:29 <flo> I still don't see the mentors. Maybe I need to log out for that?
20:04:32 <flo> bah... :-D
20:05:01 <flo> I guess we have that feature already :-P
20:07:04 <clokep_work> I guess so. :)
20:07:21 <clokep_work> There's both a websocket and network monitor one listed under Mozilla?
20:15:40 <flo> I feel guilty each time I look at the review queue :(
20:16:33 <Mook_as> heh, http://www.google-melange.com/gsoc/project/google/gsoc2012/dknn/11001 http://www.google-melange.com/gsoc/project/google/gsoc2012/catalinb/38002 http://www.google-melange.com/gsoc/project/google/gsoc2012/pielas/12001 will be fun
20:19:05 <clokep_work> :-S Are those different?
20:23:14 <flo> if I remember correctly, bug 1385 only needs to be tried and checked in if I can't find any mishandled edge case, right?
20:23:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1385 nor, --, ---, aletheia2, NEW, [Tab complete] Smart Undo and Cycle through alternative completions
20:24:25 <clokep_work> That sounds correct (from watching that conversation fly by...)
20:24:29 <aleth> The code is all reviewed, yes
20:27:09 <flo> patching file conversation.xml
20:27:09 * jwir3|lunch is now known as jwir3
20:27:09 <flo> Hunk #1 FAILED at 509.
20:27:10 <flo> Hunk #2 succeeded at 622 (offset 4 lines).
20:27:10 <flo> 1 out of 2 hunks FAILED -- saving rejects to file conversation.xml.rej
20:27:11 <flo> :(
20:28:15 <aleth> Strange. That whole patch is so recent there can't have been any changes since.
20:28:51 <flo> https://hg.instantbird.org/instantbird/log/tip/chat/content/convbrowser.xml
20:28:59 <flo> the most recent change to that file is bug 860
20:29:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, 1.2, aletheia2, RESO FIXED, Add reading position marker line to conversations
20:29:18 <flo> ah, hmm, there may be preprocessor directives in that file
20:38:03 --> EionRobb has joined #instantbird
20:39:50 <-- gpsychosis has quit (Ping timeout)
20:44:54 --> Tomek has joined #instantbird
20:52:56 <aleth> flo: What was wrong with the patch? Some whitespace issue maybe?
20:53:39 <flo> aleth: the ifdefs I think
20:53:48 <flo> I haven't applied it yet, got distracted
20:59:58 --> gpsychosis has joined #instantbird
21:07:55 <clokep_work> Goodnight! :)
21:08:11 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:14:28 <-- chrisccoulson has quit (Quit: Ex-Chat)
21:19:55 --> chrisccoulson has joined #instantbird
21:20:33 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com)
21:20:49 --> aleth has joined #instantbird
21:20:49 * ChanServ sets mode +h aleth 
21:23:03 * bear is now known as bear-afk
21:23:18 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:28:57 <flo> aleth: it's http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#511 that sucks
21:30:12 <aleth> :( Yes, that's unfortunate.
21:30:23 <Mook_as> that should be using accel, right?
21:31:01 <flo> accel exists on the event object?
21:31:36 <Mook_as> no, you need to read the pref for it
21:32:26 <-- Tomek has quit (Ping timeout)
21:32:52 <-- flo has quit (Ping timeout)
21:33:10 <Mook_as> ui.key.accelKey it looks like
21:33:53 --> Tomek has joined #instantbird
21:33:55 <aleth> fwiw mxr code also uses ifdefs https://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/content/aboutSessionRestore.js#175
21:34:17 <Mook_as> that doesn't mean it isn't wrong ;)
21:34:21 <aleth> Mook_as: ah, https://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsMenuFrame.cpp#1120
21:43:37 --> flo has joined #instantbird
21:43:37 * ChanServ sets mode +qo flo flo 
21:47:35 <flo> I'm testing that completion patch right now
21:47:48 <flo> already found one wrong behavior :-P
21:49:54 <flo> aleth: do you have a build with it around so that you can try to follow steps to reproduce and tell me if they are good enough or if you need something more detailed?
21:50:21 <aleth> flo: just a minute
21:51:03 <aleth> ok
21:51:30 --> adev has joined #instantbird
21:51:31 <flo> hmm, I'm not sure any more that it's wrong :-S
21:52:29 <flo> no, it's not wrong, I was just confused :)
21:53:35 <flo> hmm, I have another one now
21:54:50 <flo> not sure it's worth fixing
21:56:19 <flo> aleth: if you have "<nick1>, " and then start typing a nick and complete it, if you backspace, the "," that you had initially will change into ":" and if you backspace again it will change back to ","
21:57:17 <aleth> Yes
21:58:00 <aleth> Isn't that ok though?
21:58:08 <flo> maybe
21:58:11 <aleth> At any rate I am not sure what the expected behaviour would be here
21:58:11 <flo> it's surprising
21:58:21 <flo> but that seems a silly sequence of actions anyway
21:59:00 <aleth> Another surprising one is if you want to delete the space after a completed nick - it now deletes the whole completion of course.
21:59:01 --> Kaishi has joined #instantbird
21:59:20 <aleth> I couldn't see a good way round that one. 
21:59:20 <flo> why would you do that though?
21:59:37 <flo> or is it for when it's at the end of the message?
21:59:40 <aleth> I don't think you would - but if that's what you want to do, you will also be surprised.
22:00:01 <aleth> I encountered it when I had to get rid of the space for reviewing clokep's patch
22:01:36 <Mook_as> I don't suppose you can make that two undo actions? (that is, ctrl+z puts the nick back, ctrl+z again puts the space back)
22:01:36 <-- Kaishi has quit (Quit: Kaishi)
22:01:39 --> Kaishi has joined #instantbird
22:01:46 <Mook_as> (I didn't read or test the patch, perhaps you already do that!)
22:01:52 <-- Kaishi has quit (Quit: Kaishi)
22:01:57 --> Kaishi has joined #instantbird
22:03:05 <Kaishi> I wish instantbird would stop trying to resize my buddy list for me.  my task bar is at the top of my screen, but on a completely different monitor from Instantbird, so I want it to span the whole height value.  It always adds a gap, each time I start it.
22:03:24 <aleth> You might reach a point where it becomes a bit unintuitive. There is no "problem" in the sense that you can't immediately redo
22:06:21 <flo> Kaishi: is the gap at the top or at the bottom?
22:06:48 <aleth> Kaishi: Is this on Windows? Is it a recent change?
22:06:59 --> mmkmou has joined #instantbird
22:08:22 <Kaishi> Windows, and no, it's always been this way.  I just felt like bringing it up >_<
22:09:43 <Kaishi> flo: gap at the bottom, about as wide as the taskbar.  I'm assuming it's a "don't go behind the taskbar" thing, but the taskbar isn't there.  Taskbar is on a completely different monitor
22:09:55 <flo> there was been a similar sounding fix recently (https://hg.instantbird.org/instantbird/rev/9d673c16ad45)
22:10:09 <aleth> That's why I asked...
22:10:20 <flo> *has been
22:10:25 <flo> aleth: I know :)
22:10:35 <aleth> Kaishi: You are on the latest nightly, right?
22:10:42 <Kaishi> mhmm!
22:10:49 <Kaishi> just updated minutes ago
22:11:06 <flo> aleth: but the fix is for new profiles only
22:11:46 <flo> I'm afraid what's causing Kaishi trouble is in C++ somewhere in the mozilla platform :-/
22:11:47 <instantbot> c++ is e-- ah, nevermind.
22:12:23 <Kaishi> So there's no fix possible at this point?
22:12:34 <flo> aleth: ok, I can't find anything really wrong with that patch, so I would say, let's try it on nightlies :)
22:12:43 <flo> Kaishi: that's not what I said.
22:12:59 <flo> I'm just thinking that it may be more difficult than the fix that I just mentioned that was trivial.
22:13:23 <aleth> flo: Great :) I think Mook_as's suggestion would only make sense if Undo was via ctrl-z rather than backspace.
22:14:07 <Mook_as> aleth: yeah, that's what I meant :)
22:14:18 <flo> aleth: I think his suggestion makes some sense, but that the problem its trying to fix isn't important enough to delay this further
22:14:22 <Mook_as> (now, what I _said_ might be... hilariously wrong)
22:14:34 <aleth> Maybe I misunderstood the idea
22:14:42 <aleth> But we can always followup.
22:14:54 <Mook_as> yep, agreed re: not delaying
22:15:11 <flo> could be nice to have 2 undo steps when there was both a completion and a : -> , change
22:15:30 <aleth> But there are 2 undo steps?
22:16:06 <aleth> First the change gets reverted, then the completion
22:16:28 <aleth> The issue you found was when it looked like there was a change when in fact there wasn't
22:16:33 <flo> aleth: I meant two undo steps when pressing Ctrl+z
22:17:01 <instantbot> florian@instantbird.org granted review for attachment 1375 on bug 1385.
22:17:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1385 nor, --, ---, aletheia2, NEW, [Tab complete] Smart Undo and Cycle through alternative completions
22:17:05 <flo> some people may expect ctrl+z to undo the completion, and not think or backspace
22:17:12 <aleth> Oh, you mean adding a Ctrl-z handler, I see.
22:17:20 <flo> not a handler
22:17:37 <aleth> Good idea.
22:17:40 <flo> just doing the change to the content of the textbox in 2 steps, so that you have 2 changes in the undo stack
22:18:24 <flo> the idea seems nice, but I'm not sure it's really worth spending time on it
22:18:36 <aleth> You know, I had never noticed until this moment that ctrl-z did anything other than delete the current textbox entry in IB :D
22:18:46 <flo> but bugs are cheap (except if you feel you have to fix them because you filed then)
22:19:06 <aleth> That's a nice feature I never knew existed ;)
22:20:05 <flo> I suspect time spent messing with that textbox would be more useful if invested in adding some previous messages history
22:20:23 <flo> so that ctrl+up/down redisplayed the previously sent messages, or something like that
22:20:35 <aleth> There's an add-on for that.
22:20:57 <aleth> If you press Ctrl-Z a few times it seems you already get something fairly similar
22:21:27 <aleth> But the add-on does it nicer.
22:21:41 <flo> that's by accident :-D
22:22:05 <flo> but it's convenient, so we never 'fixed' it
22:22:11 <aleth> :)
22:22:24 <flo> it shouldn't be possible to 'undo' the emptying of the textbox when a message was sent
22:22:37 <aleth> It is a bit counterintuitive...
22:23:15 <flo> oh, there are 4 checkin-needed bugs
22:37:36 <flo> is there an obvious reason for https://bugzilla.instantbird.org/attachment.cgi?id=1370&action=diff to not apply?
22:38:21 <flo> ah, yes, the other patch I've just commited :(
22:38:35 <aleth> You applied bug 1370 first?
22:38:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1370 tri, --, ---, clokep, ASSI, Fix JS-IRC's usage of normalizedChatBuddy getter
22:38:51 <aleth> Ah no, that's not the one I meant
22:39:02 <aleth> But you've found the problem anyway
22:39:07 <flo> no, the mode one
22:39:11 <aleth> yes
22:39:58 <aleth> checkin-backlogs bite ;)
22:40:09 <flo> uh, I messed up a commit before :(
22:41:38 * jwir3 is now known as jwir3|away
22:48:27 <-- adev has left #instantbird ()
22:49:00 <flo> Good night :)
22:49:01 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
22:56:18 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/51fe07176223 - Benedikt Pfeifer - Bug 835 - Addon manager doesn't persist size and position, r=clokep.
22:56:19 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9a1f7b32a36b - Benedikt Pfeifer - Bug 1356 - [Message style selector] Warning: Undefined property this._name, r=clokep.
22:56:20 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9196673434de - aleth - Bug 1385 - [Tab complete] Smart Undo and Cycle through alternative completions, r=fqueze.
22:56:21 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ef44e7b31270 - Patrick Cloke - Bug 1305 - /mode messages don't work on JS-IRC - follow-up to handle more cases, r=aleth.
22:56:22 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ec52c0464439 - Patrick Cloke - Bug 1378 - Avoid sending empty nicks when changing modes with tab complete, r=aleth.
22:56:23 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e02893adbfed - Florian Quèze - Bug 747743 - Mojibake in context menus on the chat conversation, r=clokep.
22:57:12 <aleth> checkin bonanza!
22:57:19 <aleth> what on earth is mojibake
22:57:49 <aleth> some l10n thing I guess...
22:59:22 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 835 to FIXED.
22:59:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=835 tri, --, ---, benediktp, RESO FIXED, Addon manager doesn't persist size and position
22:59:33 <Mook_as> garbage characters, basically, on displaying things
22:59:53 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1356 to FIXED.
22:59:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1356 min, --, ---, benediktp, RESO FIXED, [Message style selector] Warning: Undefined property this._name
23:00:34 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1385 to FIXED.
23:00:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1385 nor, --, ---, aletheia2, RESO FIXED, [Tab complete] Smart Undo and Cycle through alternative completions
23:01:14 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1371 to FIXED.
23:01:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1371 min, --, ---, nobody, RESO FIXED, Fast undo for multiple nick completions
23:01:54 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1305 to FIXED.
23:01:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1305 nor, --, 1.2, clokep, RESO FIXED, /mode messages don't work on JS-IRC
23:02:09 --> clokep has joined #instantbird
23:02:09 * ChanServ sets mode +o clokep 
23:02:36 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1378 to FIXED.
23:02:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1378 min, --, 1.2, clokep, RESO FIXED, Avoid sending empty nicks when changing modes with tab complete
23:02:55 <clokep> Thanks for closing those. :)
23:03:44 <-- Tomek has quit (Client exited)
23:04:02 <aleth> not in the most efficient way ;)
23:06:33 <aleth> I thought it would clear the whiteboard flags and set the milestone automatically...
23:09:19 <clokep> Nope.
23:09:33 <clokep> IT's kind of a pain. :P
23:14:28 <aleth> 1.2-wanted is still at 22 bugs?
23:14:31 <aleth> How is that possible
23:15:43 <aleth> ah, a bunch of stuff there is basically fixed
23:18:27 <-- Even1 has quit (Ping timeout)
23:19:14 <clokep> Because we keep adding to the list. :P
23:19:18 <clokep> And it's "wanted" not "blocking"
23:19:25 <clokep> A lot of them were 1.0...and 1.1...
23:19:50 <aleth> Does anything there look really major?
23:20:21 <aleth> (in terms of work)
23:21:29 <clokep> Some might be, yes.
23:22:07 --> Even1 has joined #instantbird
23:22:20 <aleth> There is the mystery one like bug 1292 and the very hopeful bug 1021
23:22:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1292 nor, --, ---, nobody, NEW, Freenode SSL reconnection issues
23:22:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1021 maj, --, ---, clokep, ASSI, Replace unsupported libpurple QQ with libqq-pidgin
23:22:56 <clokep> Yes.... that's moslty done.
23:23:12 <aleth> Really? Nice...
23:23:40 <clokep> Well, we're using it. But we need to support captchas better.
23:23:43 <aleth> I thought that would be the toughest on the list
23:24:58 <clokep> Is bug 1182 not done?
23:25:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, aletheia2, REOP, "Reference to undefined property" JS warnings
23:26:25 <aleth> Oh sure.
23:26:36 <aleth> I think I have around 10 patches waiting for review
23:27:05 <aleth> That one I believe was even reviewed at some point, not sure why it's hanging around
23:27:27 <clokep> Are any from me?
23:27:50 <aleth> I don't think so. No more IRC ones atm
23:31:08 <aleth> flo's review queue must be massive with the TB stuff as well...
23:31:57 <clokep> That's not terrible.
23:32:35 <-- myk has quit (Ping timeout)
23:32:58 <aleth> Anyway, feel free to review any if you feel like it ;)
23:35:26 <clokep> aleth: Do you know how to make the warning appear that https://bugzilla.instantbird.org/attachment.cgi?id=1165&action=diff fixes?
23:39:14 <aleth> Umm... I probably did at the time. 
23:40:27 <aleth> There is a discussion/review of it in the IRC logs somewhere
23:41:55 <aleth> But I can't seem to find it
23:42:30 <clokep> :( OK. I give up then.
23:42:40 <-- Even1 has quit (Ping timeout)
23:43:31 <aleth> Ah, check your logs for Feb 10
23:44:31 <clokep> aleth: http://log.bezut.info/instantbird/120210/#m18?
23:44:59 <aleth> http://log.bezut.info/instantbird/120210/#m64
23:45:30 <aleth> and I see the words "toronto" which probably explains why it never got r+
23:46:02 <clokep> Yes.
23:46:09 <clokep> Sounds plausible. :)
23:47:17 <clokep> fyi: Thunderbird IM bugs in review. ;) https://bugzilla.mozilla.org/request.cgi?action=queue&requester=&product=Thunderbird&type=all&requestee=&component=Instant+Messaging&group=type
23:47:46 <aleth> not so bad then, or good, depending on your point of view ;)
23:48:42 <clokep> Yup...
23:54:56 <clokep> aleth: Only one bug that check-in? Really? :P
23:56:18 <clokep> Slowing down I think. ;)
23:58:46 <instantbot> clokep@gmail.com granted review for attachment 1165 on bug 1182.
23:58:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, aletheia2, REOP, "Reference to undefined property" JS warnings