#instantbird log on 04 20 2012

All times are UTC.

00:19:19 <instantbot> New Instantbird (UI) bug 1386 filed by rjones@eggycrew.com.
00:19:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1386 enh, --, ---, nobody, UNCO, Lack of basic options for sounds
00:20:43 --> clokep has joined #instantbird
00:20:43 * ChanServ sets mode +o clokep 
00:28:56 <-- sonny has quit (Quit: Instantbird -- http://www.instantbird.com)
00:39:09 <clokep> Tomek: I don't think dual booting / using the same profile is even supported in Firefox (and there's a good amount of information out there from Googling)
00:39:14 <clokep> I don't think it should be in the FAQ.
00:40:32 <clokep> Kaishi: It's always been there, but it disappears when you make the window small.
00:40:39 <Mook_as> well, it could go in the FAQ, with the answer being "not supported, don't do it".
00:47:40 <-- Mook_as has quit (Quit: gone)
01:07:16 <-- aleth has quit (Input/output error)
01:12:25 <-- Kaishi has quit (Quit: Kaishi)
01:40:06 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
02:56:34 <instant-buildbot> build #470 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/470
03:50:16 <-- EionRobb has quit (Ping timeout)
03:52:35 --> Kaishi has joined #instantbird
03:54:07 --> EionRobb has joined #instantbird
04:03:08 <-- EionRobb has quit (Ping timeout)
04:07:24 --> EionRobb has joined #instantbird
04:25:33 <instant-buildbot> build #561 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/561
04:32:08 <-- EionRobb has quit (Quit: Leaving.)
04:37:12 --> EionRobb has joined #instantbird
05:28:04 <-- EionRobb has quit (Quit: Leaving.)
05:38:18 * bear-afk is now known as bear
06:02:39 <instant-buildbot> build #458 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/458
06:39:04 --> Keso has joined #instantbird
07:51:04 <-- Gizmokid2005 has quit (Ping timeout)
07:54:24 --> EionRobb has joined #instantbird
07:54:48 --> Gizmokid2005 has joined #instantbird
08:00:13 <-- Even1 has quit (Quit: Instantbird -- http://www.instantbird.com)
08:00:19 --> Even1 has joined #instantbird
08:00:22 <-- Even1 has quit (Quit: Even1)
08:00:28 --> Even1 has joined #instantbird
08:02:34 --> Tomek has joined #instantbird
08:08:55 <-- Even has quit (Quit: Instantbird -- http://www.instantbird.com)
08:09:06 --> Even has joined #instantbird
08:09:06 * ChanServ sets mode +o Even 
08:09:13 <-- Even has quit (Quit: Even)
08:09:21 --> Even has joined #instantbird
08:09:22 * ChanServ sets mode +o Even 
08:10:57 <-- Gizmokid2005 has quit (Ping timeout)
08:11:49 --> Gizmokid2005 has joined #instantbird
08:13:35 <-- Keso has quit (Quit: Instantbird 1.1)
08:22:19 --> aleth has joined #instantbird
08:22:19 * ChanServ sets mode +h aleth 
08:43:20 <-- Tomek has quit (Quit: Instantbird 1.1)
08:48:49 <-- gerard-majax has quit (Ping timeout)
08:53:15 --> mmkmou has joined #instantbird
08:59:49 --> flo has joined #instantbird
08:59:49 * ChanServ sets mode +qo flo flo 
09:06:33 <flo> hello :à
09:06:35 <flo> *:)
09:07:05 <flo> the next mozilla merge is so close that we should probably start thinking about updating to moz12 soon
09:11:14 <aleth> Huh, where did those 6 weeks go
09:20:40 <flo> they went to the bugmail folder ;)
09:24:40 --> jb has joined #instantbird
09:29:05 --> gerard-majax has joined #instantbird
09:43:35 --> jb1 has joined #instantbird
09:59:24 <-- jb has quit (Ping timeout)
09:59:42 <instantbot> florian@instantbird.org denied review for attachment 1374 on bug 1385.
09:59:44 <-- jb1 has quit (Ping timeout)
09:59:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1385 nor, --, ---, aletheia2, NEW, [Tab complete] Smart Undo and Cycle through alternative completions
10:00:50 --> jb has joined #instantbird
10:01:01 <aleth> ah, something to do for the lunch break ;)
10:01:25 <flo> :)
10:01:40 <flo> you mean I'll have another review to do after the lunch break? ;)
10:02:02 <aleth> Depends on what you commented I guess ;)
10:02:15 <flo> coding style nits only
10:02:30 <flo> but enough that I would rather have another patch before applying it to my debug build
10:05:00 <flo> I should really get rid of the '[imIAccount::loadBuddy]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)' error, I'm tired of seeing it :-/
10:08:56 <aleth> flo: What do you think of this variation? http://pastebin.instantbird.com/30257
10:09:24 <flo> I wasn't sure the %= operator actually existed
10:09:27 <aleth> I don't have a preference really, but it saves a line break.
10:09:37 <flo> but if it works, go for it
10:09:59 <flo> ok, it does, obviously :)
10:10:42 <flo> don't forget to do this change at the 2 places where that code exists in your patch, not only where I mentioned it :)
10:12:20 <aleth> sure
10:14:51 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1375 on bug 1385.
10:14:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1385 nor, --, ---, aletheia2, NEW, [Tab complete] Smart Undo and Cycle through alternative completions
10:18:06 <flo> lunch break already over?
10:18:41 <aleth> no
10:18:52 <aleth> you might have to review another patch if you want to fill it I guess ;)
10:19:15 <flo> or try it and find edge cases ;)
10:19:32 --> clokep has joined #instantbird
10:19:32 * ChanServ sets mode +o clokep 
10:19:39 <aleth> Yup... discover the Undo of Doom
10:20:10 <flo> "this._hasBuddy(c) &&" and "!this.buddies[c].hasAttribute("inactive"), this);" couldn't fit on a single line?
10:20:22 <aleth> Not if you are strict about your 80 characters
10:20:54 <flo> I'm not. If it's 82 or 83 it's not a disaster :)
10:21:07 <aleth> 85
10:22:07 <aleth> Just change it when you add it to your debug build if you like. Personally I tend to not mind anything below 90 if it helps legibility...
10:22:20 <flo> yeah
10:22:57 <flo> the goal of the 80 column rule is to improve legibility, so if respecting it makes the code look awful, we aren't respecting the intent of the rule anyway ;)
10:23:52 --> Tomek has joined #instantbird
10:24:05 <flo> looks good, but it would not really be reasonable to try now as I'm supposed to be doing Tb work ;)
10:24:15 <flo> I did the review while my code was compiling ;)
10:31:48 <clokep> I guess compiling is good for something. :)
10:33:27 <flo> when hacking on Thunderbird I touch a lot of code that wouldn't pass my review :-S
10:33:38 <flo> http://mxr.mozilla.org/comm-central/source/mailnews/base/content/folderWidgets.xml#619 for example
10:34:05 <flo> it gets the list of accounts in a O(n^2) way for no apparent reason
10:34:29 <flo> (it calls the accountManager.accounts getter for each account, which will iterate the whole list to return an iterator on it...)
10:36:01 <clokep> :( File bugs on it?
10:36:09 <flo> I'm patching it already
10:36:10 <clokep> That probably would take mor etime than just fixing it. :(
10:36:18 <flo> (for a different reason)
10:36:19 <-- EionRobb has quit (Connection reset by peer)
10:44:34 <flo> oh, and before I first touched that code, it was calling the incomingServer getter twice too :) http://hg.mozilla.org/comm-central/rev/f4b337e10b51#l4.31
10:45:12 <flo> not as bad as calling in a loop something that iterates the whole list though :)
10:52:54 <clokep> Ouch.
10:59:06 --> Mic|web has joined #instantbird
11:00:10 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
11:05:11 <Mic|web> Hi
11:06:49 <-- Gizmokid2005 has quit (Ping timeout)
11:07:18 --> Gizmokid2005 has joined #instantbird
11:32:59 --> sonny has joined #instantbird
11:36:42 <-- Tomek has quit (Quit: Instantbird 1.1)
11:41:01 --> clokep_work has joined #instantbird
11:41:01 * ChanServ sets mode +o clokep_work 
11:49:36 --> jb1 has joined #instantbird
12:03:04 <-- jb has quit (Connection reset by peer)
12:03:27 <-- jb1 has quit (Connection reset by peer)
12:04:18 --> jb has joined #instantbird
12:04:54 --> jc has joined #instantbird
13:21:00 * flo has just wasted at least half an hour debugging something that wasn't actually caused by his patch
13:21:45 <flo> I have a fix though (https://bugzilla.mozilla.org/show_bug.cgi?id=747362) so I hope nobody will waste time on the same bug again :)
13:41:35 <clokep_work> :( Be careful, they might make you write a test. ;)
13:44:19 <flo> I'll offer my patch to aceman ;)
14:02:30 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:03:47 --> clokep_work has joined #instantbird
14:03:47 * ChanServ sets mode +o clokep_work 
14:08:40 --> NmN has joined #instantbird
14:09:14 <-- myk has quit (Ping timeout)
14:12:19 <-- jc has quit (Quit: jc)
14:12:38 --> jc has joined #instantbird
14:17:53 * clokep_work hates when people give awful descriptions for bugs...
14:26:07 <Mic|web> aleth: the gradients at the bottom of context messages flickers when I move the mouse over context messages. It doesn't happen for content messages though. Have you seen something like this yourself?
14:27:08 <Mic|web> Umm, this happens with "Paper Sheets". The patch is the one from bug 1074.
14:27:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1074 nor, --, ---, aletheia2, ASSI, Default message styles lack context message support
14:29:19 <flo> clokep_work: I tend to dislike all bugs about sounds
14:29:46 <flo> clokep_work: people complaining about sounds all seem to know what they want, but I've yet to find a bug report about sounds that really makes sense :)
14:30:32 <aleth> Mic|web: Umm... I have no idea. Last time I looked at that was 6 months ago.
14:31:02 <clokep_work> flo: Yes, he seems to say two conflicting things in it. :(
14:31:09 <clokep_work> And apparently there's like 40 billion options with sounds.
14:31:12 * clokep_work dislikes options. :P
14:31:25 <aleth> I'll take a look, from the code it doesn't appear there should be anything other than a desaturate filter like for Bubbles.
14:32:18 <flo> clokep_work: people requesting options, and other clients adding lots of different options for a feature that should be simple (it's just playing a stupid sound!) is a good indication that something around that feature sucks and that a problem needs to be solved ;)
14:33:40 <flo> clokep_work: especially, all the reports about "I don't need to hear a sound because ..." sound like "your current sounds suck, fix them please".
14:34:07 <clokep_work> Yes.
14:34:21 <clokep_work> I have to agree it probably makes sense to not play sounds when the window is focused?
14:34:24 <aleth> flo: There does seem to be a cluster of requests around (in effect) "only play a sound when a tab first gets the unread or attention flag"  and "where do I customize the sound itself". 
14:34:29 <clokep_work> Although just because it's focused doesn't mean I'm confused on the computer. :)
14:34:32 <flo> (bug 503)
14:34:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=503 enh, --, ---, nobody, NEW, Improving Sounds
14:35:11 * aleth has all sounds turned off and won't comment further
14:35:20 <flo> aleth: I think the real problem is that people don't enjoy hearing the sounds Instantbird plays.
14:35:28 <-- Kaishi has quit (Quit: Kaishi)
14:35:30 <flo> aleth: sounds are off for me too
14:36:10 <aleth> If clokep and Mic have sounds off too, that probably explains why the feature hasn't had much love :P
14:36:35 <clokep_work> aleth: I had sounds off when it was crashing my machine...I stopped realizing they were off. ;)
14:36:44 <clokep_work> I did turn them back on though (only IM events, not buddy sounds).
14:36:54 <clokep_work> But yes, they suck. I hate them when I have music on in particular.
14:37:13 <flo> aleth: I think everybody working from a laptop in rooms where there are potentially other people has sounds off
14:39:18 <flo> clokep_work: another pattern for sucky bug reports is the word "basic" before "feature" or even better "option" ;)
14:40:24 <clokep_work> if (report.match(/.*basic.*/)) report.sendTo("/dev/null")
14:42:31 <flo> clokep_work: "Currently you cannot change the username, it has to do with the way libpurple stores and persists account information." libpurple's fault again? :-D
14:43:24 <clokep_work> flo: I wanted to blame someone else. :)
14:44:15 <aleth> Mic|web: I see what you mean. That's very strange.
14:44:37 <Mic|web> OK, so it's not just a bug on this computer :D
14:44:44 <aleth> It's like the hover makes the shadow effect appear
14:44:46 <Mic|web> I'll add it to my comment.
14:45:11 <aleth> What's odd is that I suspect that wasn't there when I submitted the patch... I mean, it's very noticeable
14:45:51 <clokep_work> aleth: Maybe a Mozilla updated funkiness?
14:46:09 <aleth> Yeah, could be.
14:47:00 <flo> I like the last comment on http://blog.instantbird.org/2012/02/status-update-february-25-2012/#comments :)
14:47:30 <flo> that comment, asking for an anti-spam, is completely off topic on that post, so an anti-spam would have deleted it ;)
14:47:48 <aleth> Mic|web: Even without hover, the shadow seems to be missing on some messages, but not others? Do you see a pattern to that?
14:48:10 <clokep_work> flo: I don't think he got my comment on that bug. :(
14:48:27 <clokep_work> Even his issue is a proposed solution...I wanted the overall "Why does this piss you off"
14:48:49 <flo> clokep_work: most people have no idea of the difference between "a problem" and "a solution" when it comes to UX
14:49:21 <aleth> lol
14:49:27 <flo> clokep_work: or maybe we are the problem, because we don't want to understand his request
14:49:30 <aleth> I like the comment before last...
14:49:47 <flo> I just read the comment a second time and now the problem is obvious
14:50:07 <flo> clokep_work: "Other IM programs have [...] Instantbird [...] does not"
14:50:45 <flo> clokep_work: I think the problem is not a matter of sounds, but some variation of "I'm frustrated because I'm migrating and can't setup things to work exactly like I used to"
14:51:26 <clokep_work> Probably.
14:51:54 <Mic|web> aleth: no, no obvious pattern there.
14:57:15 --> myk has joined #instantbird
15:05:59 <aleth> Instantbird is in ur webcam, watching ur activities :P
15:18:46 <flo> what is this referring to?
15:21:02 <Mic|web> I'd say clokep's answer on the sounds-bug
15:23:57 <-- myk has quit (Ping timeout)
15:27:34 <Mic|web> aleth: here's a screenshot of the "Dark"-change I suggested. http://i.imgur.com/YMKdC.png
15:31:38 <clokep_work> Mic|web: Thanks for reviewing that btw, this is certainly better feedback than I could provide. :)
15:32:53 --> myk has joined #instantbird
15:36:02 <flo> Mic|web: does it look as bad on your screen as it looks on that image?
15:36:29 <flo> there's some anti-aliasing effect that makes the font really ugly
15:39:33 <aleth> Mic|web: Does the font on the normal messages appear greenish to you on that image too?
15:40:55 <aleth> Thanks for testing all those styles, now I have to remember what I did...
15:41:28 <Mic|web> The font looks greenish yes.
15:41:47 <Mic|web> flo: what are you complaining about? The antialiasing of the font or something in the scope of the bug?
15:42:25 <flo> the font that's green for normal messages, and dotted for context messages (I'm exaggerating a little bit)
15:43:47 <aleth> Your suggestion for the background sounds good, I will test it
15:44:39 <aleth> The papersheets problem is weird :-/ Probably a bug in the JS that I didn't touch but becomes apparent on hover now...
15:47:03 <-- myk has quit (Ping timeout)
15:48:36 <Mic|web> "Paper Sheets" looks trange in general imo ;)
15:48:52 <flo> it looks like something I would rm ;)
15:49:03 <flo> but some people use it 
15:49:59 <aleth> Mic|web: yeah, the only one of those styles I might ever use is Simple
15:51:05 <Mic|web> Bubbles (or Simple), for me
16:03:36 --> myk has joined #instantbird
16:25:40 <-- jb has quit (Connection reset by peer)
16:25:52 <-- jc has quit (Connection reset by peer)
16:29:31 --> jb has joined #instantbird
16:29:31 --> jc has joined #instantbird
16:45:01 <-- mmkmou has quit (Client exited)
16:48:20 * bear is now known as bear-afk
16:49:18 <clokep_work> I used Simple until flo made Time Bubbles, then I tried that and liked it. :)
16:52:11 * aleth uses Bubbles-Light, which is basically Bubbles...
16:54:25 <Mic|web> bye
16:54:27 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:56:44 <flo> Good evening :)
16:56:45 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
16:58:56 <-- gerard-majax has quit (Ping timeout)
17:05:54 --> Mook_as has joined #instantbird
17:29:25 --> igorko has joined #instantbird
17:42:25 * bear-afk is now known as bear
17:45:17 <-- igorko has quit (Connection reset by peer)
17:51:30 --> gerard-majax has joined #instantbird
17:58:03 <-- NmN has quit (Ping timeout)
17:59:37 --> NmN has joined #instantbird
17:59:44 --> Mnyromyr has joined #instantbird
18:00:17 <-- NmN has quit (Quit: Instantbird 1.1)
18:15:04 --> mmkmou has joined #instantbird
18:17:53 --> Mic has joined #instantbird
18:17:53 * ChanServ sets mode +h Mic 
18:24:59 <-- mmkmou has quit (Ping timeout)
18:31:14 --> Tomek has joined #instantbird
18:50:59 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:59:17 <-- myk has quit (Quit: Instantbird -- http://www.instantbird.com)
19:11:43 --> igorko has joined #instantbird
19:13:20 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
19:13:32 --> Mic has joined #instantbird
19:13:32 * ChanServ sets mode +h Mic 
19:34:41 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
19:34:49 --> Mic has joined #instantbird
19:34:49 * ChanServ sets mode +h Mic 
19:46:07 --> clokep has joined #instantbird
19:46:08 * ChanServ sets mode +o clokep 
20:05:53 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1208 on bug 1074.
20:05:54 <instantbot> aletheia2@fastmail.fm requested review from benediktp@ymail.com  for attachment 1377 on bug 1074.
20:05:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1074 nor, --, ---, aletheia2, ASSI, Default message styles lack context message support
20:09:02 <-- igorko has quit (Connection reset by peer)
20:30:37 --> flo has joined #instantbird
20:30:37 * ChanServ sets mode +qo flo flo 
20:35:17 --> myk has joined #instantbird
20:38:54 <-- chrisccoulson has quit (Quit: Ex-Chat)
20:40:57 * clokep hates this patch...
20:43:55 --> chrisccoulson has joined #instantbird
21:04:58 --> Kaishi has joined #instantbird
21:10:57 --> qheaden has joined #instantbird
21:25:12 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1378 on bug 1305.
21:25:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1305 nor, --, 1.2, clokep, REOP, /mode messages don't work on JS-IRC
21:27:39 <aleth> clokep: Time spent fixing bug: 2 minutes. Time spent parsing incorrect input: 2 hours ? :P
21:28:08 <clokep> aleth: Yeah, pretty much.
21:28:18 <clokep> I was hoping that would take me like 30 minutes...2 hours later...
21:29:00 <flo> clokep: well, you also underestimate the time it takes to do reviews ;)
21:29:09 <flo> it took me 55 minutes yesterday, instead of the estimated 20
21:29:30 <clokep> Yes. So apparently whenever I say things just multiple it by 3 - 4 times. :)
21:31:28 <flo> clokep: it took me 6 times the time I expected to go from 0.1.3 to 0.2, and we dropped some features planned for 0.2...
21:32:56 <clokep> Yeah. :(
21:42:29 <aleth> clokep: Do you plan to handle the response (221) in a separate patch?
21:42:40 <clokep> aleth: Yes.
21:42:41 <aleth> s/the/a possible
21:42:45 <aleth> ok
21:43:07 <clokep> It's jsut about not making the command suck so much
21:47:59 * qheaden is anxious about April 23rd.
21:48:10 <qheaden> Hopefully Instantbird projects will be accepted.
22:02:34 <aleth> It's weird when you have tested something, but it hasn't landed yet - and then you think it's broken if you absentmindedly try to use it ;)
22:03:40 <flo> aleth: is that a review ping? ;)
22:04:05 <aleth> No, wasn't intended that way
22:04:27 <aleth> But feel free :)
22:06:10 <clokep> It was the passive aggressive review ping.
22:06:20 <clokep> So passive aggressive aleth did it without knowing!
22:06:51 <aleth> now that's passive for you!
22:08:25 * clokep wants to set up his new router but doesn't want to log offline. :-S
22:09:09 <Mook_as> set it up behind your old one?
22:09:45 <clokep> Mook_as: Pretty sure they'll try to be the same IP address.
22:12:31 <clokep> I do have another computer too, but I attempted to install Ubuntu on it and I think the NIC isn't working...
22:26:35 <instantbot> aletheia2@fastmail.fm granted review for attachment 1378 on bug 1305.
22:26:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1305 nor, --, 1.2, clokep, REOP, /mode messages don't work on JS-IRC
22:26:59 <clokep> Thanks.
22:29:22 <aleth> Now you see what I was referring to ^^
22:34:48 * bear is now known as bear-afk
22:39:19 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:39:52 <-- qheaden has quit (Quit: I've got to go. See ya!)
22:39:53 <clokep> Yes. :-/ I thought I tested one of those. :(
22:50:48 <-- clokep has quit (Ping timeout)
22:52:04 <-- Tomek has quit (Quit: Instantbird 1.1)
22:56:50 <flo> good night :)
22:56:57 <Mic> Good niht
23:30:38 * jwir3 is now known as jwir3|away
23:34:08 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:36:55 <-- aleth has quit (Input/output error)
23:38:05 --> aleth has joined #instantbird
23:38:05 * ChanServ sets mode +h aleth