All times are UTC.
00:39:04 <-- Mook_as has quit (Quit: gone) 00:39:48 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 01:06:19 <-- sonny has quit (Quit: Instantbird -- http://www.instantbird.com) 01:09:23 <-- myk has quit (Ping timeout) 01:21:11 <-- Even has quit (Connection reset by peer) 01:38:51 <-- Suiseiseki has quit (Quit: Quit) 01:49:20 --> Suiseiseki has joined #instantbird 02:10:20 <-- clokep has quit (Connection reset by peer) 02:42:05 <instant-buildbot> build #460 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/460 03:37:36 <-- BYK has quit (Quit: Instantbird -- http://www.instantbird.com) 04:32:02 <instant-buildbot> build #551 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/551 05:50:19 <-- EionRobb has quit (Quit: Leaving.) 06:02:36 <instant-buildbot> build #450 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/450 06:26:27 --> EionRobb has joined #instantbird 06:42:45 <-- Eveo has quit (Quit: Instantbird -- http://www.instantbird.com) 06:42:58 --> Even has joined #instantbird 06:42:58 * ChanServ sets mode +o Even 07:00:57 --> Tomek has joined #instantbird 07:01:24 --> gerard-majax has joined #instantbird 07:13:41 <-- Tomek has quit (Quit: Instantbird 1.1) 07:37:44 --> jb has joined #instantbird 07:39:25 --> pvagner has joined #instantbird 07:58:06 --> jc has joined #instantbird 07:58:26 <-- jb has quit (Ping timeout) 08:05:54 --> Even1 has joined #instantbird 08:06:01 <-- Even1 has quit (Quit: Instantbird -- http://www.instantbird.com) 08:06:10 --> Even1 has joined #instantbird 08:35:55 --> sonny has joined #instantbird 08:42:54 --> NmN has joined #instantbird 09:04:40 <-- NmN has quit (Ping timeout) 09:13:27 <-- EionRobb has quit (Quit: Leaving.) 09:16:34 --> flo has joined #instantbird 09:16:34 * ChanServ sets mode +qo flo flo 09:19:42 <flo> hello :) 09:20:12 --> myk has joined #instantbird 09:43:03 --> aleth has joined #instantbird 09:43:03 * ChanServ sets mode +h aleth 10:06:13 <-- chrisccoulson has quit (Client exited) 10:08:54 --> chrisccoulson has joined #instantbird 10:09:56 --> NmN has joined #instantbird 10:20:23 --> clokep has joined #instantbird 10:20:24 * ChanServ sets mode +o clokep 10:23:32 <clokep> Good morning. 10:50:45 <clokep> Any opinions: http://pastebin.instantbird.com/27693 11:01:56 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 11:07:10 <aleth> So native == boring? 11:07:33 <-- NmN has quit (Ping timeout) 11:07:45 <aleth> I guess one might encourage the guy to write a theme? 11:09:13 <aleth> Just took a look at a digsby screenshot: no idea what is "shiny" about it 11:09:59 <aleth> I suspect a better icon would go a long way as far as IB is concerned, if we ever find one... 11:16:17 --> mario has joined #instantbird 11:18:00 <mario> hi, i am mario - hacking my own app with mozilla platform too - i just learned about instantbird today and i was wondering how you guys replicated the whole mozilla plattform (includ. addons server, mercurial, build process etc.) is there a good source to read to do the same, or can anybody help me on that? (btw: great job w. instantbird) 11:19:03 <flo> clokep: that probably means (s)he missed an emoticon selector in the main conversation UI :-P 11:20:07 <flo> mario: there's some good documentation about the build that was written by Songbird folks. 11:20:16 <flo> *build process 11:20:29 <flo> for mercurial, I don't know what you are asking 11:20:50 <flo> and for the add-on servers, it will be very very painful, as the original code sucks. 11:21:06 <mario> how did you the plugin-server part? 11:21:17 <aleth> There was a post yesterday on planet about how AMO is now much easier to install 11:21:38 <aleth> but I'm not sure how far that goes... 11:21:45 <flo> aleth: that doesn't mean you can stop it from saying "Mozilla foundation" and "Firefox" in all pages easily though ;) 11:22:03 <flo> mario: spent a lot of time on it. 11:22:21 <mario> did you forked the original code? or did your own? 11:22:53 <flo> we forked 11:23:25 <flo> our fork is at https://hg.instantbird.org/websites/remora/ but I really wouldn't advise starting from that :) 11:23:33 <flo> as the base of our fork is completely outdated 11:23:43 <flo> mario: out of curiosity, what does your xulrunner app do? :) 11:25:10 <flo> mario: for build system documentation, start with https://developer.mozilla.org/en/How_mozilla%2527s_build_system_works and https://developer.mozilla.org/en/Creating_XULRunner_Apps_with_the_Mozilla_Build_System 11:25:13 <mario> flo: its a kind of instant-messaging for application in the cloud - enables applications to share data over the wire and gave a very good desktop integration. the project is called ezperanto and should bring the power of modern apis to the end-user. (so data get context-extracted by your own program not by google or somebody :D) 11:25:37 <mario> flo: i am pretty far with the build system 11:26:11 <mario> flo: got small problems with generating the update packages (.mar) complete and partials and how to setup a process that stages the updates automatically. 11:26:28 <flo> "small problems" :-D 11:26:46 <flo> the update system isn't easy ;) 11:26:50 <mario> flo: precomplete gets generated, but in the wrong folder⦠blabla 11:27:42 <mario> flo: yes, looks like. but you guys managed to do this right? -> so its not impossible :D - but it lacks on good articles and resources about that, right? 11:28:49 <flo> even not-good articles don't exist 11:29:32 <mario> is instantbird a company, or a project or what is it? may be we can work together⦠:D 11:29:55 * flo goes away for lunch 11:29:57 <flo> back later 11:30:02 <mario> flo: ok 11:36:43 --> NmN has joined #instantbird 11:46:53 --> clokep_work has joined #instantbird 11:46:54 * ChanServ sets mode +o clokep_work 11:49:50 <clokep_work> mario: http://www.instantbird.com/about.html might help. 11:50:09 <clokep_work> But pretty much it started a few years ago by flo (and some others?) and is developed by volunteers. 11:50:16 <clokep_work> aleth: Yeah Idk what "shiny" means either. 11:53:25 <-- NmN has quit (Ping timeout) 11:56:20 <mario> clokep_work: doesn't help much - got the german version, is only a team or something? :D 11:59:12 <clokep_work> Are you in Germany? (o_O) 11:59:23 <clokep_work> I don't know if there's a way to force the English version. 11:59:27 <clokep_work> It's a bunch of people, yes. 12:02:22 <clokep_work> (Actually it seems http://www.instantbird.com/en-US/about.html might force English?) 12:02:30 <clokep_work> I can't test as it comes up in English for me automatically. :-D 12:02:46 <aleth> I doubt the German version is much different 12:03:21 <aleth> It shouldn't be ;) 12:17:00 * bear-afk is now known as bear 12:17:40 <aleth> clokep_work: re the chatbuddyname method, one could have two methods: getCompleteChatBuddyName and getNormalizedChatBuddyName. Would that clarify what they are for? 12:18:44 <clokep_work> aleth: I think so, although "Complete" is probably a misnomer, it's more of like "getNetworkNameForChatBuddyNameOrSomethingCrazyThatXMPPDoes" ;) 12:19:08 <aleth> I wonder what the maxlength on method names is :P 12:19:28 * jc is now known as jb 12:19:58 <aleth> getNormalizedChatBuddyName was already a bit long... 12:20:16 <flo> aleth: don't you mean that we should just add a comment above the requestBuddyInfo method in the idl file saying that the notification will contain a normalized username? 12:21:27 <aleth> I don't really have an opinion on what the best way to resolve this is 12:21:51 <aleth> Especially as it has to work across protocols... 12:22:29 <aleth> The issue seems to be that there will be no method in the interface to obtain that normalized username 12:25:06 <-- jb has quit (Quit: jb) 12:25:41 --> jb has joined #instantbird 12:27:03 --> jc has joined #instantbird 12:27:23 <-- jb has quit (Ping timeout) 12:50:36 <-- myk has quit (Ping timeout) 12:54:30 --> NmN has joined #instantbird 12:59:21 <-- NmN has quit (Quit: Instantbird 1.1) 13:13:33 * bear is now known as bear-afk 13:37:51 * bear-afk is now known as bear 13:45:42 <-- Kaishi has quit (Quit: Kaishi) 13:46:24 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 14:04:22 --> Mic|web has joined #instantbird 14:04:27 <Mic|web> hi 14:12:55 <flo> Mic|web: hello :) 14:18:46 <clokep_work> Hello! 14:26:00 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client) 14:39:14 * bear is now known as bear-afk 15:00:46 * bear-afk is now known as bear 15:11:08 <-- pvagner has quit (Ping timeout) 15:11:09 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 â 1809)) 15:11:21 --> logiclord has joined #instantbird 15:11:41 <logiclord> getting error http://pastebin.com/F7LUvsf0 15:13:06 <flo> have you already checked out an older version in the same folder? 15:13:45 <clokep_work> Probably need to |cd mozilla && hg update -C && cd .. && python client.py checkout|? 15:14:06 <flo> but anyway, I think you can go in ~/fresh_instantbird/instantbird/mozilla and execute hg update -r FIREFOX_11_0_RELEASE --clean 15:14:16 <flo> yeah, what clokep_work said :) 15:15:34 <logiclord> thanks it worked :) 15:16:15 <logiclord> btw 1.1 had some build issues on my system. I have created log this time ~7 MB 15:17:26 --> aleth has joined #instantbird 15:17:26 * ChanServ sets mode +h aleth 15:17:34 --> SM0TVI has joined #instantbird 15:21:46 * bear is now known as bear-afk 15:26:09 <-- mario has quit (Quit: mario) 15:29:58 * bear-afk is now known as bear|tablet 15:38:59 --> Tomek has joined #instantbird 15:39:28 * bear|tablet is now known as bear 15:47:19 <-- gerard-majax has quit (Ping timeout) 15:54:34 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 16:00:07 <flo> uh, I shouldn't have checked in that line http://mxr.mozilla.org/comm-central/source/mail/build.mk#77 :( 16:00:55 * bear is now known as bear|buildduty 16:00:59 <clokep_work> Did someone actually notice? ;) 16:01:12 <flo> am I someone? 16:01:43 <-- Even1 has quit (Quit: Instantbird -- http://www.instantbird.com) 16:01:52 <flo> by the way, do you have anything to propose for the way to handle chat bugs in the future? 16:04:28 <clokep_work> flo: I have a draft email going...but it's not really a proposal... 16:06:23 <flo> I wasn't far from replying to David that duplicating the check-ins is as painful as duplicating the bugs, and that we really should put Instantbird in comm-central... but there's probably some more social engineering needed before stating that :) 16:13:35 <clokep_work> flo: Replied! 16:13:39 <clokep_work> But I'm going to eat lunch. :) 16:13:42 <flo> I was already reading it :) 16:26:42 * jc is now known as jb 16:31:56 --> mmkmou has joined #instantbird 16:34:49 --> aleth has joined #instantbird 16:34:49 * ChanServ sets mode +h aleth 16:35:53 <-- logiclord has quit (Quit: Leaving.) 16:36:15 <-- mmkmou has quit (Ping timeout) 16:39:42 --> mmkmou has joined #instantbird 16:43:04 <-- mmkmou has quit (Ping timeout) 16:44:27 --> Even1 has joined #instantbird 16:46:08 <clokep_work> Cool. 16:46:30 <clokep_work> I hope it makes sense. :-D 16:46:35 --> mmkmou has joined #instantbird 16:49:57 <-- mmkmou has quit (Ping timeout) 16:53:40 --> mmkmou has joined #instantbird 16:57:04 <-- mmkmou has quit (Ping timeout) 16:58:33 --> BYK has joined #instantbird 17:00:51 --> mmkmou has joined #instantbird 17:02:11 <-- BYK has quit (Client exited) 17:03:26 <-- mmkmou has quit (Ping timeout) 17:05:13 * bear|buildduty is now known as bear-afk 17:07:08 --> mmkmou has joined #instantbird 17:09:14 --> BYK has joined #instantbird 17:12:11 <-- mmkmou has quit (Ping timeout) 17:15:38 --> mmkmou has joined #instantbird 17:19:27 --> logiclord has joined #instantbird 17:19:50 <logiclord> https://lxr.instantbird.org/ Over capacity! 17:19:58 <-- mmkmou has quit (Ping timeout) 17:20:29 <clokep_work> Even or flo ^ ^ 17:21:04 <flo> nobody cares 17:21:09 <flo> just remove the s in https 17:21:50 <flo> but if a documentation page anywhere points to that address, it would be nice to know which one, so that we can fix it 17:21:52 <logiclord> btw build on my system works fine now :) 17:21:58 <flo> cool :) 17:22:51 <clokep_work> Ah, right. :( 17:23:00 <flo> "nobody cares" what I meant is, nobody cares if lxr is encrypted or not, as there's no private data in there 17:23:32 <logiclord> flo : link was somewhere :-/ .. just got from my history 17:23:34 --> mmkmou has joined #instantbird 17:23:34 <clokep_work> logiclord: Congrats you got it to build OK. 17:23:47 <logiclord> thanks 17:25:33 * aleth discovers FF just deletes its databases when they become corrupt :( 17:26:04 <-- mmkmou has quit (Ping timeout) 17:26:40 <clokep_work> aleth: It doesn't rename it and create a new one? 17:26:45 <clokep_work> At least potentially allowing recovery? 17:27:29 <aleth> If it was clever it would restore from sync 17:28:33 <aleth> Oh, it keeps the corrupt one. But what is anyone going to do with it? 17:28:35 <clokep_work> Sounds like it's time to file a bug. ;) 17:29:10 <aleth> Yes... but the sync guys haven't even implemented syncing tab groups yet... so I am not hopeful 17:29:40 <aleth> Then again maybe that's one of those "more tricky than it looks at first" features 17:29:54 --> mmkmou has joined #instantbird 17:30:31 <logiclord> removeConversation is called only when user closes window or when instantbird closes (like in case of restart) http://lxr.instantbird.org/instantbird/source/chat/components/public/imIConversationsService.idl ? 17:31:17 <clokep_work> logiclord: http://lxr.instantbird.org/instantbird/search?string=removeConversation 17:32:21 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com) 17:35:33 <logiclord> LOG(("destroy_conv uiop called")); will be shown in error console ? 17:35:50 --> Mook_as has joined #instantbird 17:36:12 <clokep_work> Only if the LOG function is declared. 17:36:41 <clokep_work> imXPCOMUtils.jsm declares some logging utilities I believe. 17:36:56 <clokep_work> If I'm just trying to like dump debug stuff out, I usually use Components.utils.reportError(<str>) 17:37:06 <clokep_work> (Which can be abbreviated as Cu.reportError in most of our files...) 17:37:28 <logiclord> is defined as macro #define LOG(args) PR_LOG(gPurpleInitLog, PR_LOG_DEBUG, args) 17:37:43 <clokep_work> Ah, you're in a C file? 17:37:48 <aleth> logiclord: Or use dump(), that's the most useful for quick debugging 17:38:15 <logiclord> aleth : dump shows in error console ? 17:38:38 <logiclord> http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleInitConv.cpp#103 17:38:58 <aleth> logiclord: dump prints to the console 17:39:06 <aleth> (not the error console) 17:39:35 <aleth> i.e. you will see it in your terminal, and can save it, pipe it, etc. 17:40:04 <logiclord> got it ... i thought tool->error console 17:40:45 <aleth> You can also use alert() in JS to open a dialog box with your message in it: that halts execution until you click ok 17:41:33 <logiclord> JS in cpp :-/ 17:41:38 <-- mmkmou has quit (Ping timeout) 17:41:55 <aleth> Are you working on libpurple? 17:42:11 <logiclord> ya tracking down removeconversation usage 17:42:50 <aleth> From C you can use printf 17:43:00 <aleth> But I guess you know that ;) 17:44:09 <logiclord> :) 17:44:48 <clokep_work> What are you trying to figure out? 17:45:53 --> mmkmou has joined #instantbird 17:47:34 <Mook_as> for the file you linked, export NSPR_LOG_MODULES=purpleInit:5 17:47:44 <Mook_as> though I think you need to build --enable-debug for that to show up 17:50:57 * bear-afk is now known as bear|buildduty 18:03:40 <-- mmkmou has quit (Ping timeout) 18:03:48 <-- jb has quit (Ping timeout) 18:07:54 --> mmkmou has joined #instantbird 18:10:31 * jwir3|away is now known as jwir3 18:13:01 <-- mmkmou has quit (Ping timeout) 18:16:55 --> mmkmou has joined #instantbird 18:17:02 --> qheaden has joined #instantbird 18:21:10 <-- mmkmou has quit (Ping timeout) 18:24:55 --> mmkmou has joined #instantbird 18:25:37 --> Mnyromyr has joined #instantbird 18:27:26 --> jb has joined #instantbird 18:28:20 <-- mmkmou has quit (Ping timeout) 18:32:29 --> mmkmou has joined #instantbird 18:37:13 --> myk has joined #instantbird 18:41:25 <-- logiclord has quit (Quit: Leaving.) 18:44:02 <-- jb has quit (Ping timeout) 18:44:16 <-- mmkmou has quit (Ping timeout) 18:48:27 --> mmkmou has joined #instantbird 18:49:47 --> pvagner has joined #instantbird 18:50:52 --> gerard-majax has joined #instantbird 18:57:41 --> flo has joined #instantbird 18:57:41 * ChanServ sets mode +qo flo flo 18:58:15 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 18:58:25 --> aleth has joined #instantbird 18:58:25 * ChanServ sets mode +h aleth 19:00:19 <-- mmkmou has quit (Ping timeout) 19:27:40 <-- qheaden has quit (Quit: I've got to go. See ya!) 19:57:16 * bear|buildduty is now known as bear-afk 20:06:24 * flo wonders if aleth remembers the content of the new patch in bug 860 20:06:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations 20:07:11 <aleth> flo: hopefully :) 20:09:41 <flo> all the elements with magic ids could benefit from some documentation 20:09:52 <flo> but I'm not sure where it would go 20:10:20 <aleth> I added a bunch of comments, but maybe there needs to be some additional section where they are collected? 20:10:49 <clokep_work> It could need some documentation on the wiki too about message styles. 20:11:08 <aleth> The only id the message styles would touch is the #unread-ruler hr 20:11:15 <flo> it's possible I got confused between all the different inser/remove points, but I think there's an error in the logic in removeUnreadRuler 20:11:19 <aleth> That one should be on the wiki once it lands. 20:12:22 <flo> aleth: well, the other ids may need to also be documented as things that themes should absolutely never have in their header or footer 20:12:33 <aleth> Oh, right. 20:12:58 <aleth> Or in fact just in case somebody notices them and looks for documentation. 20:26:00 * bear-afk is now known as bear|buildduty 20:31:55 --> mmkmou has joined #instantbird 20:33:23 <-- clokep_work has quit (Quit: Bye!) 20:34:48 <-- mmkmou has quit (Ping timeout) 20:37:52 --> EionRobb has joined #instantbird 20:38:27 --> mmkmou has joined #instantbird 20:39:18 <instantbot> florian@instantbird.org denied review for attachment 1275 on bug 860. 20:39:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations 20:41:12 <flo> aleth: seems like it won't be too hard to produce the next version of that patch ;) 20:41:28 <aleth> That sounds like good news :) 20:41:45 <flo> except if the code I wrote doesn't make sense 20:41:46 <flo> :) 20:41:54 <-- mmkmou has quit (Ping timeout) 20:42:21 <flo> and it took almost an hour to review it again :-/ 20:43:06 <aleth> Messing with existing messages is tricky :-/. I'm half surprised you didn't find any more hidden assumptions it was making... 20:43:46 <flo> it's possible I missed something ;) 20:44:03 <flo> well, you assume that all the magic ids you use are free ;) 20:44:07 <flo> but I think that's reasonable 20:44:53 <aleth> If we document them. Or I could give them stranger names... 20:45:29 <flo> nah, don't obfuscate more a code that's already difficult to understand :) 20:45:41 --> mmkmou has joined #instantbird 20:45:54 <flo> I pondered complaining about nextmessagesStart -> nextMessagesStart 20:46:00 <flo> but I see why you did that 20:46:32 <aleth> It would have to be next-messages-start on the id otherwise 20:46:44 <aleth> Which it could be of course. 20:47:23 <flo> and next-messages-end 20:47:45 <aleth> Would you prefer that? 20:48:02 <flo> yes, I think I prefer that, but it's not a strong enough preference to required it to get an r+ ;) 20:48:30 <aleth> Not a s/./. I mind making at all :) 20:51:02 <aleth> Is it a good precedent to have message styles use !important? That's why I used the #Chat> 20:51:38 <-- mmkmou has quit (Ping timeout) 20:54:24 <aleth> (Just a CSS style question) 20:55:50 <flo> it doesn't seem like an issue 20:56:37 <aleth> I'm not arguing with the change, just wondering if there was a deeper logic to it 20:56:57 <flo> my reasoning was just performance 20:57:06 <aleth> Oh OK :) 20:58:17 <flo> but I think there are a few possible cleanup/perf improvements in the CSS of our default message themes :( 20:58:37 <aleth> Mic was looking at some of them a while ago I think. 20:58:55 <aleth> Not sure if it resulted in patches yet. 20:59:28 <flo> he has patches for removing crappy JS animation code that are waiting in my review queue, so it's possible he waited for that to be checked in before further cleaning up the themes 21:01:47 <aleth> Anyway, thanks for the review :) I asked yesterday because I suspect it's a patch that could do with some time in nightlies just to be sure there are no glitches. 21:03:28 <flo> and it's painful to see such a patch bitrot ;) 21:04:37 <flo> thanks for fearlessly jumping into that not-as-easy-as-it-seems bug :) 21:16:48 * bear|buildduty is now known as bear-afk 21:19:29 --> mmkmou has joined #instantbird 21:25:32 <-- mmkmou has quit (Ping timeout) 21:27:20 <aleth> bah, it's bitrotted already :( 21:27:34 --> clokep has joined #instantbird 21:27:34 * ChanServ sets mode +o clokep 21:27:45 <aleth> Probably by that tab complete patch 21:27:47 <instantbot> florian@instantbird.org denied review for attachment 1279 on bug 1357. 21:27:49 <flo> :( 21:27:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1357 nor, --, ---, nobody, NEW, Add unread ruler to section scroll 21:28:19 <flo> ah, that one... 21:28:31 <flo> shouldn't be too difficult to fix though 21:29:04 --> mmkmou has joined #instantbird 21:29:13 <aleth> Right, that one had some style uncertainties 21:29:35 <flo> I was talking about the bitrot 21:29:43 <aleth> Oh right. 21:30:02 <aleth> That's not a problem, thankfully. 21:31:35 <-- mmkmou has quit (Ping timeout) 21:33:09 --> mmkmou has joined #instantbird 21:36:53 <clokep> Yay reviews. :P 21:37:23 <-- pvagner has quit (Ping timeout) 21:43:23 <-- mmkmou has quit (Ping timeout) 21:45:06 --> Kaishi has joined #instantbird 21:46:53 --> mmkmou has joined #instantbird 21:46:56 <flo> clokep: is params.reverse().unshift(aConv.name); really simpler than params = [aConv.name, params[0], params[1]]; ? 21:47:11 <flo> (assume I actually reversed 0 and 1 here) 21:47:19 <clokep> flo: No. 21:47:32 <clokep> I had the unshift and added the reverse. ;) 21:48:53 <flo> even in the params.unshift(aConv.nick) case I wonder if params = [aConv.nick, params[0]]; wouldn't be easier to read 21:49:11 <flo> but maybe not in that case :) 21:49:22 <clokep> Let me just make sure that params is definitely only that length. 21:49:47 <flo> there are tests for that in the code 21:49:57 <clokep> OK, then yes I think those are fine / simpler. 21:51:13 <-- mmkmou has quit (Ping timeout) 21:52:09 <flo> params.unshift(aConv.nick) is ok :) 21:52:39 <flo> but anyway, I'm bikeshedding, that patch looks ok 21:53:30 <clokep> Would you like me to fix those things and put up a new patch or? 21:55:21 --> mmkmou has joined #instantbird 21:55:22 --> clokep_js has joined #instantbird 21:55:41 <-- clokep_js has quit (Quit: Instantbird -- http://www.instantbird.com) 21:56:01 <flo> yeah, maybe 21:56:10 <instantbot> florian@instantbird.org granted review for attachment 1326 on bug 1305. 21:56:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1305 nor, --, ---, clokep, ASSI, /mode messages don't work on JS-IRC 21:58:12 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1333 on bug 860. 21:58:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations 22:02:23 <-- mmkmou has quit (Ping timeout) 22:02:36 <instantbot> clokep@gmail.com granted review for attachment 1334 on bug 1305. 22:02:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1305 nor, --, ---, clokep, ASSI, /mode messages don't work on JS-IRC 22:04:21 <flo> "// If only a mode is given, it's to set your own mode, we also have to provide our own nick." Is it your or our mode? :-P 22:05:24 <clokep> Bah. You couldn't say that two seconds ago? ;) 22:05:55 <clokep> "If only a mode is given, we want to set our own mode, we also have to provide our own nick."? 22:06:00 --> mmkmou has joined #instantbird 22:07:07 <flo> aleth: "// Remove any insert node this added and restore existing one." that comment seems wrong 22:07:24 <clokep> That seems confusing. :-S 22:07:31 <aleth> Uh, I thought I'd deleted it :( 22:08:10 <aleth> Ah, forgot to commit :( 22:08:18 <flo> clokep: what's confusing? Your comment or aleth's comment? :-P 22:08:27 <clokep> aleth's comment! 22:08:32 <clokep> Is that one better? 22:08:59 <flo> the "we also have to" part is confusing 22:09:36 <flo> clokep: what about "If only a mode is given, it's our own mode that we want to set so we have to provide our nick."? 22:10:21 <-- mmkmou has quit (Ping timeout) 22:10:26 <clokep> Yes. :) 22:10:44 <clokep> Any other comments/ 22:11:08 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1333 on bug 860. 22:11:08 <flo> if you dislike having to decide between "our" and "your", you can say the user's mode and the user's nick 22:11:09 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1335 on bug 860. 22:11:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations 22:11:29 <flo> but I'm not sure that's an improvement 22:12:06 <flo> clokep: "in this case." or "in these cases."? (end of the last comment) 22:12:33 <flo> (why is it so difficult to write comments that make sense and aren't confusing/ambiguous? :() 22:12:57 <clokep> Because we're programmers, not writers. ;) 22:13:09 <aleth> And sometimes one is trying to explain the wrong thing, from the point of view of the reader ;) 22:14:09 --> mmkmou has joined #instantbird 22:14:10 <flo> that reader seems annoying, and to always have the wrong point of view ;) 22:14:12 <instantbot> clokep@gmail.com granted review for attachment 1336 on bug 1305. 22:14:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1305 nor, --, ---, clokep, ASSI, /mode messages don't work on JS-IRC 22:14:20 <flo> too bad I'm that reader 22:14:22 * flo hides 22:14:39 <clokep> Mic: Is that omegle bug ready to be commited besides the s/gre// change? 22:15:54 <Mook_as> do you want resource://app/ instead in that case? 22:17:12 <flo> Mook_as: resource://app/ is just a longer version of resource:///, right? 22:17:23 <Mook_as> but more explicit :D 22:17:35 <-- mmkmou has quit (Ping timeout) 22:17:56 <Mook_as> and I think might not work right in xpcshell unit tests where they don't really have an app 22:17:56 <flo> I think we removed all of the //app at some point, so there was probably a reason for that change 22:18:39 <flo> Mook_as: hmm, isn't it taht /// is inside the omnijar and //app/ outside of it? 22:19:10 <Mook_as> they both look like inside of it to me 22:19:26 <Mook_as> (but I'm testing with firefox... so who knows) 22:19:39 <flo> I think we removed //app/ at the time of switching to moz2/ominijar 22:21:12 --> mmkmou has joined #instantbird 22:21:29 <flo> wow, 3 blockers with checkin-needed :) 22:21:36 <clokep> Yup! :) 22:22:05 <flo> feels like we are releasing soon ;) 22:22:14 <flo> i'll have no excuse to not fix that l10n mess 22:22:53 <-- mmkmou has quit (Ping timeout) 22:23:09 <clokep> :) 22:23:10 <aleth> Excellent :) 22:23:36 * clokep wonders how hard bug 1231 is... 22:23:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1231 nor, --, ---, nobody, NEW, 'Display Formatting of incoming messages', not implemented in JS-XMPP 22:24:02 <flo> there are unfiled similar blockers :( 22:24:26 <clokep> Do you have them on a list somewhere? :-/ 22:24:29 <flo> "[regression] ... isn't supported by JS-XMPP" :( 22:24:42 <aleth> oh :( 22:24:42 <flo> clokep: more or less 22:24:52 <aleth> clokep: Is there already a bug filed for implementing channel modes? 22:25:00 <flo> I still have the list of things I need to implement before feeling JS-XMPP is OK 22:25:15 <flo> and I've the list of things I'm tracking for IM-in-Tb https://etherpad.mozilla.org/tb-im-beta-fixup 22:25:28 <clokep> aleth: bug 627 is a good start. 22:25:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=627 nor, --, ---, nobody, NEW, IRC Channel Modes should affect the conversation UI 22:25:48 <aleth> OK 22:25:58 <clokep> The first step is just saving them, which isn't too hard I don't think. :) 22:26:08 <aleth> I just wasn't sure it wasn't originally part of the /mode one 22:26:23 --> mmkmou has joined #instantbird 22:26:31 <clokep> (aleth or bug 318) 22:26:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, nobody, REOP, Check if topic on IRC channels is editable and make UI respond accordingly 22:26:53 <aleth> Every time I look at the section scroll code again I have to think through it all over :-/ 22:27:15 <aleth> It seems to have a shorter half-life than other things... 22:27:19 <flo> clokep: in the list of not implemented things I have: sending the user's contact icon to the server, sending the user's display name to the server, saving tag changes on roster items, saving alias changes on roster items, receiving formatted messages. 22:27:45 <clokep> Ah, that's a lot. :( 22:27:57 <clokep> Every time I look at the XMPP code I realize I don't understand it very well. :-X 22:27:59 <flo> aleth: it's terribly difficult for me to understand too :( 22:28:08 <-- mmkmou has quit (Ping timeout) 22:29:16 <flo> clokep: well, that list can be shortened to: sending the user's vCard, saving roster item edits, receiving HTML. 22:29:43 <clokep> flo: Can you commit this? http://pastebin.instantbird.com/27854 :-D 22:30:05 <flo> clokep: in my list, but that's not really blocking, I also have a note that the current error handling of socket.jsm sucks 22:30:22 <clokep> flo: Actually, forget that. 22:30:25 <clokep> It doesn't do what I want... 22:30:45 <clokep> It doesn't show sent messages. :( 22:30:48 <flo> clokep: you want to get rid of the State: receiving, state: sending spammy messages? 22:30:55 <clokep> Yes. 22:31:15 * clokep wants a protocol console. ;) 22:31:34 <flo> what about displaying that in a conversation tab? 22:31:42 <flo> like a "server tab" ;) 22:32:52 <clokep> Nah, I don't like that. 22:33:07 --> mmkmou has joined #instantbird 22:33:08 <flo> why? 22:33:49 <flo> (I imagined it using a specific terminal looking message theme, and no emoticons) 22:34:18 <clokep> Yeah I guess that could work. 22:35:16 <flo> how come https://bugzilla.instantbird.org/attachment.cgi?id=1324 doesn't apply? :( 22:35:43 <clokep> flo: You need to do -p2 on it and apply from the IRC dir. 22:36:00 <clokep> irc.js ends up in the components dir duringa build. 22:36:02 <flo> clokep: come on... 22:36:19 <clokep> Perhaps it bitrotted? 22:36:57 <flo> http://pastebin.instantbird.com/27855 22:37:13 <flo> how has changed irc.js behind our back? :) 22:38:02 <flo> s/how/who/ 22:38:07 <instantbot> New Core - IRC bug 1372 filed by clokep@gmail.com. 22:38:08 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1337 on bug 1372. 22:38:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1372 tri, --, ---, clokep, ASSI, QUIT command with no message causes an error. 22:38:28 <clokep> My guess is aleth changed. :P 22:38:32 <clokep> changed it 22:41:58 <flo> I don't see any reason for that hunk to not apply :-S 22:42:19 <aleth> That was only from the other day :-/ 22:42:33 <clokep> I'm confused though...isn't that hunk not even desired? 22:42:39 <clokep> (The first one at least.) 22:42:53 <-- mmkmou has quit (Ping timeout) 22:44:12 <flo> clokep: the .rej format contains first the lines it tried to remove with the context it expected to find, and then the file it wanted to produce (with a + on the added lines) 22:44:30 <clokep> Ah, I see. 22:44:39 <clokep> :( 22:45:07 <flo> I applied that hunk by hand, I hope nothing will be broken 22:45:27 <aleth> Strange. Maybe some git vs hg oddness? 22:46:52 --> mmkmou has joined #instantbird 22:49:02 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1338 on bug 1326. 22:49:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1326 nor, --, ---, clokep, ASSI, " ERRMSG action :Unhandled CTCP command " from some users with empty /me on IRC 22:49:28 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 22:49:59 * clokep is trying to clean up some of these easy IRC bugs. 22:51:25 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1339 on bug 1357. 22:51:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1357 nor, --, ---, nobody, NEW, Add unread ruler to section scroll 22:51:44 <aleth> What is this, bugfix Thursday? ;) 22:51:46 <instantbot> florian@instantbird.org granted review for attachment 1335 on bug 860. 22:51:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations 22:52:11 <clokep> aleth++ 22:52:17 <clokep> I'm excited for the unread marker. :) 22:54:54 <flo> aleth: I'm checking it in, but I haven't tried it at all 22:55:03 <flo> I hope I won't be disappointed tomorrow :) 22:55:08 <aleth> flo: That's ... bold :D 22:55:28 <flo> you have tested it, haven't you? 22:55:38 <aleth> Oh yes. 22:55:48 <-- mmkmou has quit (Ping timeout) 22:56:15 * clokep is confused by these not fully initialized conversation bugs. 22:57:19 <flo> clokep: what are the user visible consequences of bug 1372? 22:57:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1372 tri, --, ---, clokep, ASSI, QUIT command with no message causes an error. 22:57:38 <clokep> flo: No quit message is shown for the user. 22:57:54 <flo> is the nick still removed from the list of participants? 22:58:02 <clokep> I don't think so. 22:58:19 <flo> so we have some brokenness if the nick rejoins? 22:58:45 <clokep> It's possible, yes. 22:59:27 --> mmkmou has joined #instantbird 23:00:05 <flo> what's the actual error message? 23:00:37 <clokep> I'm not sure of what your question is... 23:01:25 <clokep> flo: In the bug. 23:01:36 <flo> no, that's an exception thrown later 23:01:57 <flo> or a call to ERROR 23:02:06 <-- mmkmou has quit (Ping timeout) 23:02:08 <flo> ah, ok, sorry 23:02:16 <flo> I was just reading the first bug mail 23:02:25 <clokep> Yeah, I just added it. :) Didn't realize I hadn't copied that part in. 23:02:49 <flo> clokep: why don't you just test quitMsg rather than quitMsg.length which forces you to add || ""? 23:03:22 <clokep> flo: The error is before that. It's in the quitMsg.indexOf("Quit: ") 23:03:35 <clokep> I could change that to quitMsg && quitMsg.indexOf 23:05:25 <instantbot> aletheia2@fastmail.fm granted review for attachment 1338 on bug 1326. 23:05:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1326 nor, --, ---, clokep, ASSI, " ERRMSG action :Unhandled CTCP command " from some users with empty /me on IRC 23:06:36 <instantbot> florian@instantbird.org granted review for attachment 1337 on bug 1372. 23:06:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1372 tri, --, ---, clokep, ASSI, QUIT command with no message causes an error. 23:06:55 --> mmkmou has joined #instantbird 23:08:31 <flo> aleth: hmm, when is the unread ruler supposed to go away? 23:08:37 <flo> (I'm testing it finally :-D) 23:08:50 <aleth> Only when a new one appears or you switch tabs. 23:09:15 <flo> so if my window has only one tab, I'm out of luck? 23:09:31 <aleth> That's why it has to be unobtrusive. 23:10:11 <-- mmkmou has quit (Ping timeout) 23:10:14 <clokep> Shouldn't it happen if you unfocus the window too? 23:10:38 <flo> clokep: that's what I expected, but not what's implemented 23:11:11 <flo> split bubbles rejoining seems a bit magical :) 23:11:20 <aleth> I didn't want to do that because you might be multitasking and switching back and forth between apps, while not getting around to actually scrolling up. 23:11:50 <clokep> We can look at that in a follow up. 23:12:05 <aleth> Yes. 23:12:10 <flo> aleth: yeah, I think it's ok 23:12:25 <flo> aleth: the current behavior makes sense for real use cases; it's just for testing that it's surprising :) 23:12:38 <aleth> The use case I was thinking of was you have IB open, you come back to your computer, switch to your email first, and then want to scroll up to the first unread message. 23:13:19 <aleth> (for example) 23:14:11 --> mmkmou has joined #instantbird 23:14:31 <clokep> Hmm....yeah. 23:14:34 <aleth> I have a followup patch rotting somewhere which allows message styles to animate new messages when the tab is switched to. 23:14:39 <clokep> I'd lke to play with it and see how it is before making more comments. 23:15:04 <aleth> That's kind of separate from the ruler though as far as the user is concerned. 23:15:19 <flo> I think we will have follow up patches to improve the appearance in other default message themes 23:15:25 <aleth> Yes. 23:15:33 <aleth> At least I was expecting that would be the case... 23:15:53 <aleth> The default is meant to be visible in all styles without breaking anything. 23:18:48 <flo> trim returns a new string without changing the original? 23:19:16 <aleth> flo: trim does not affect the value of the string itself. 23:19:38 <flo> ok 23:19:46 <flo> clokep: isn't there a similar issue with empty regular messages? 23:20:18 <flo> clokep: to reproduce, type "a\n\nb" in the textbox and send 23:21:27 <clokep> I'm not sure. 23:21:58 <clokep> flo: It sounds it...I didn't get any errors back AFAIK. 23:22:29 <flo> clokep: the display is strange anyway 23:22:39 <clokep> Yes. 23:22:47 <clokep> We should strip them on send I think. 23:23:02 <flo> clokep: isn't your patch hiding the errors from https://bugzilla.instantbird.org/show_bug.cgi?id=1326#c1 ? 23:23:11 <instantbot> Bug 1326 nor, --, ---, clokep, ASSI, " ERRMSG action :Unhandled CTCP command " from some users with empty /me on IRC 23:24:04 <flo> another way to ask is: is it ok to flood the error console with errors if other users (with potentially broken or hacked clients) send us some crap? 23:26:40 <clokep> flo: It makes it so that we don't send empty action messages it doesn't do anything about when we receive a CTCP error message. 23:27:02 <clokep> Ah from Comment #1. 23:27:36 <clokep> I don't see where that other error comes from. :( 23:27:41 * clokep ACTION 23:28:11 <flo> clokep: I think it's an error while processing the error messages returned by some clients 23:28:35 <clokep> Ah, that's a separate bug. 23:28:47 <clokep> Yeah, I'll copy those down and file a new bug. 23:28:59 <flo> separate, but we are hiding the way to reproduce 23:29:59 <clokep> True. 23:30:52 <clokep> So what do we do when we receive an ERRMSG response? 23:30:53 <flo> mention in the bug that reverting that patch is required to reproduce :) 23:30:56 <-- mmkmou has quit (Ping timeout) 23:32:05 <flo> I don't know, but "Error: [object Object]" feels really wrong ;) 23:32:35 <aleth> A missing error message? 23:33:12 <clokep> Haha, yes. 23:33:26 <clokep> I want to say it's "Unhandled CTCP message"...but that's not what it is. :P 23:33:40 <clokep> We're handling it fine...the other user isn't hah. 23:34:43 --> mmkmou has joined #instantbird 23:34:54 <clokep> flo, aleth: How does http://pastebin.instantbird.com/27866 suit you? 23:37:30 <-- mmkmou has quit (Ping timeout) 23:37:31 <aleth> Much better :) I guess if aMessage.nickname is undefined it will let us know. 23:38:26 <flo> seems better if it works 23:39:03 <flo> I'm assuming you are sure aMessage.ctcp will never be null 23:40:05 <instantbot> New Core - IRC bug 1373 filed by clokep@gmail.com. 23:40:06 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1340 on bug 1373. 23:40:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1373 min, --, ---, clokep, ASSI, CTCP ERRMSG is handled poorly 23:40:12 <clokep> aMessage.ctcp can't be null for that function to be called. 23:40:22 <clokep> (We don't error check that in any of those methods) 23:41:03 <flo> clokep: you can see or remember that, but I couldn't with the context given in the patch ;) 23:41:20 <clokep> Yes, well I wrote all that code so. :) 23:42:27 --> mmkmou has joined #instantbird 23:45:46 <flo> you are lucky that it's still good enough to remember 23:45:56 <-- mmkmou has quit (Ping timeout) 23:48:19 <flo> so you want that checked in now so that you can close the bug without filing another one? 23:48:37 <clokep> You mean the bug I already filed? ;) 23:48:37 <flo> ah, no another one is already filed 23:48:44 <flo> I do! 23:48:47 <flo> :) 23:49:19 --> mmkmou has joined #instantbird 23:49:49 <flo> clokep: have you tested this patch? 23:51:55 <clokep> flo: No. 23:52:08 <clokep> I will now though. :) 23:54:02 <clokep> flo: WOrks fine! 23:54:09 <flo> cool :) 23:54:09 * clokep hopes he doesn't get banned from #openwebapps. O:-) 23:57:06 <flo> do you still need that channel? :-P 23:58:00 <clokep> Nope. :) I parted. ;) 23:58:25 <instantbot> florian@instantbird.org granted review for attachment 1340 on bug 1373. 23:58:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1373 min, --, ---, clokep, ASSI, CTCP ERRMSG is handled poorly 23:58:36 <aleth> Escape from #openwebapps :P 23:59:43 <-- mmkmou has quit (Ping timeout)