#instantbird log on 04 10 2012

All times are UTC.

00:18:15 * bear is now known as bear-afk
00:20:00 <-- aleth has quit (Input/output error)
00:21:59 <-- myk has quit (Input/output error)
00:22:23 <-- Eveo has quit (Ping timeout)
00:29:40 --> Eveo has joined #instantbird
00:49:25 <clokep> FYI: hg downtime planned for mozilla: http://groups.google.com/group/mozilla.dev.planning/browse_thread/thread/60b8b06665643f99#
00:55:22 <-- Mook_as has quit (Quit: gone)
01:00:26 <-- sonny has quit (Client exited)
01:17:58 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
01:18:06 --> clokep has joined #instantbird
01:18:06 * ChanServ sets mode +o clokep 
02:28:35 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
02:44:08 <instant-buildbot> build #458 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/458
03:19:48 * jwir3 is now known as jwir3|away
04:14:35 <-- Kaishi has quit (Quit: Kaishi)
04:14:40 --> Kaishi has joined #instantbird
04:39:26 <instant-buildbot> build #549 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/549
05:07:59 <-- Kaishi has quit (Ping timeout)
05:11:28 --> Kaishi has joined #instantbird
05:33:09 <-- Kaishi has quit (Quit: Kaishi)
05:33:43 <-- EionRobb has quit (Connection reset by peer)
06:02:38 <instant-buildbot> build #448 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/448
06:12:25 <-- BYK has quit (Client exited)
06:13:25 --> BYK has joined #instantbird
06:30:05 <-- BYK has quit (Quit: Instantbird -- http://www.instantbird.com)
07:38:59 --> jb has joined #instantbird
07:41:06 <-- Even has quit (Quit: Instantbird -- http://www.instantbird.com)
07:41:12 --> Even has joined #instantbird
07:41:12 * ChanServ sets mode +o Even 
07:41:18 <-- Even has quit (Quit: Even)
07:41:23 --> Even has joined #instantbird
07:41:23 * ChanServ sets mode +o Even 
07:42:01 --> chrisccoulson has joined #instantbird
08:06:19 <-- chrisccoulson has quit (Quit: Ex-Chat)
08:09:39 --> Evep has joined #instantbird
08:10:33 <-- Evep has quit (Quit: Instantbird -- http://www.instantbird.com)
08:10:44 --> Even1 has joined #instantbird
08:27:15 --> aleth has joined #instantbird
08:27:15 * ChanServ sets mode +h aleth 
08:39:47 <-- gerard-majax has quit (Ping timeout)
08:45:38 --> mmkmou has joined #instantbird
08:52:44 --> pvagner has joined #instantbird
08:58:11 --> EionRobb has joined #instantbird
08:58:15 --> flo has joined #instantbird
08:58:15 * ChanServ sets mode +qo flo flo 
09:11:27 --> chrisccoulson has joined #instantbird
09:13:27 <-- pvagner has quit (Connection reset by peer)
09:17:14 --> pvagner has joined #instantbird
10:00:12 <-- Even1 has quit (Connection reset by peer)
10:05:08 --> Even1 has joined #instantbird
10:32:49 --> clokep has joined #instantbird
10:32:49 * ChanServ sets mode +o clokep 
10:35:30 --> sonny has joined #instantbird
10:49:07 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
10:58:08 --> gerard-majax has joined #instantbird
11:12:42 <-- EionRobb has quit (Quit: Leaving.)
11:45:42 --> clokep_work has joined #instantbird
11:45:42 * ChanServ sets mode +o clokep_work 
11:46:17 <clokep_work> Good morning!
11:56:53 <-- jb has quit (Quit: jb)
11:59:14 --> jb has joined #instantbird
12:11:47 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com)
12:12:07 <-- jb has quit (Quit: jb)
12:12:44 --> jb has joined #instantbird
12:15:36 <-- jb has quit (Quit: jb)
12:16:31 --> jb has joined #instantbird
12:21:54 <-- waynenguyen has quit (Quit: Instantbird -- http://www.instantbird.com)
12:22:53 --> waynenguyen has joined #instantbird
12:23:06 * bear-afk is now known as bear
12:24:45 <clokep_work> Anyone here using SIP in Instantbird that might have some info on that mail the mailing list got?
12:27:11 --> Mic|web has joined #instantbird
12:28:50 <Mic|web> HI
12:33:19 <clokep_work> Hello mic.
12:33:31 <clokep_work> Bah, Mibbit fail. :(
12:43:46 <clokep_work> aleth: Well that part of the tab complete certainly works well...in that I expect it to "Just Work" now. ;)
12:44:58 <flo> that part is "give priority to active nicks"? :)
12:47:13 <clokep_work> Yup!
12:48:31 <-- jb has quit (Quit: jb)
12:48:53 --> jb has joined #instantbird
12:49:43 <-- jb has quit (Quit: jb)
12:50:02 --> jb has joined #instantbird
12:51:07 <aleth> clokep_work: Good :) (That's not one of the recent changes though.)
12:51:22 <clokep_work> aleth: I know, just figured I'd let you know it's been ingrained. ;)
12:51:34 <aleth> :)
12:51:38 <aleth> is it even in 1.1?
12:51:44 <flo> nope
12:52:09 <flo> the concept of active/inactive nicks was one of the first visible change for 1.2
12:52:42 <aleth> Oh right.
12:52:55 <flo> we should really release :)
12:53:29 <flo> now I would be annoyed to have to press more than <first letter><tab> to reply to someone :)
12:54:02 <aleth> Yes, these days it's annoying when someone has left the room because you have to type their name ;)
12:54:19 <flo> aleth: you have to double click their message ;)
12:54:38 <aleth> That works :)
12:55:16 <flo> aleth: I was very surprised yesterday when the completion refused to work for someone who had just talked to me. It took me some time to realize he wasn't in the participant list. That was an XMPP MUC, probably some presence stanza got lost :-S
12:57:45 <aleth> Probably not a part of JS-XMPP that has had much testing yet?
12:58:23 <flo> lots of details related to XMPP MUCs aren't fully implemented
12:58:25 <clokep_work> Testing? What's that? ;)
12:58:43 <flo> but I don't think that (the participant list) is supposed to not work
13:01:52 <instantbot> New Core - General bug 1367 filed by benediktp@ymail.com.
13:01:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1367 enh, --, ---, nobody, NEW, Suppress errors when running without libpurple
13:03:22 <flo> Mic|web: is shipping libpurple as an add-on one of your goals? :)
13:06:14 <Mic|web> It would need to be built for each release separately if I understood the binary-compatibility thing for components correctly?
13:06:32 <clokep_work> Yes, but we do that anyway.
13:06:51 <flo> Mic|web: I meant putting it in the extensions/ folder
13:07:04 <flo> so that it's part of the release, but possible to disable it from the add-on manager
13:07:55 <flo> (similar to dom inspector in debug builds currently)
13:08:13 <clokep_work> (Or everything in Songbird :P)
13:08:19 <Mic|web> hmm, what do we gain by that?
13:08:25 <clokep_work> (Or everything in SeaMonkey is probably a better example...)
13:08:52 <flo> clokep_work: isn't that only DOMi, ChatZilla and Venkman?
13:09:02 <clokep_work> Yeah, probably. Feels like a lot though. :)
13:10:02 <flo> Mic|web: completely separate build system that can be put in a separate hg repository, so that all the code in our main repository becomes MPL, and possible to import in comm-central (and client.py or whatever other magic will checkout the libpurple add-on code automatically when --enable-extension=libpurple is provided in the mozconfig)
13:10:18 <flo> Mic|web: mostly a dream at this point
13:10:19 <flo> :)
13:11:11 <Mic|web> Doesn't sound bad :)
13:11:36 <clokep_work> Maybe they'll switch to hg by that point too. :P
13:11:52 <flo> does that even matters? :-P
13:12:02 * bear is now known as bear-afk
13:12:26 <flo> we have forked so many of the libpurple files already... :-|
13:16:32 <clokep_work> I know...my point is that if they were to switch to hg, it'd be possible to do what we do for Mozilla (e.g. to actually keep patches to their files).
13:19:14 <flo> that would be possible already I think.
13:19:27 <flo> but the changes we do to libpurple are much more intrusive than the changes we do to Mozilla
13:19:40 <flo> we remove/replace/move around files
13:19:59 <flo> but I guess an hg patch queue could handle that
13:21:55 <clokep_work> True.
13:22:08 <clokep_work> We also include code form external sources (netsoul, maybe SIPE eventually).
13:22:19 <flo> and qq
13:22:45 <flo> netsoul would probably be easy to rewrite in JS if anybody cared
13:23:13 <flo> that protocol feels like it should be an add-on rather than built-in
13:23:17 <clokep_work> Suggest it to their CS department as a student project? ;)
13:23:43 <flo> clokep_work: it's a CS school, so I'm not sure there's a CS department :-P
13:23:48 <clokep_work> Is it safe to iterate a pointer that's input into a function?
13:24:04 <clokep_work> (i.e. is a copy of the pointer made that's local to the function?)
13:24:06 <clokep_work> in C++.
13:24:53 <flo> if the parameter is a pointer and not a reference to a pointer, it's a copy
13:25:05 <aleth> Yes, unless its a pointer to the pointer ;)
13:25:33 <clokep_work> Yeah, it's T *a, where T is expected to be a native type.
13:25:40 <clokep_work> Yay templated functions. ;)
13:27:00 <clokep_work> Thanks. :)
13:27:33 <Mic|web> Uhhh, low-level programming :P
13:28:55 * clokep_work wonders what Mic|web considers assembly. ;)
13:30:17 <Mic|web> 'worse' :P
13:33:59 <Mic|web> bbl
13:34:11 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
13:38:21 <-- waynenguyen has quit (Ping timeout)
13:47:14 --> Mic|web has joined #instantbird
13:53:03 <instantbot> clokep@gmail.com denied review for attachment 1321 on bug 1321.
13:53:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1321 min, --, ---, aletheia2, ASSI, Display name is lower case for IRC DMs
13:53:08 * bear-afk is now known as bear
13:53:12 * bear is now known as bear|buildduty
13:57:20 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com)
13:59:05 <-- pvagner has quit (Ping timeout)
14:01:05 --> mmkmou has joined #instantbird
14:17:19 --> aleth has joined #instantbird
14:17:19 * ChanServ sets mode +h aleth 
14:23:23 <-- jazper_ has quit (Ping timeout)
14:24:02 --> jazper- has joined #instantbird
14:25:17 <aleth> clokep_work: The reason _waitingForName got that name is because it is true when waiting for what is needed to set this.name ;)
14:25:49 <aleth> But maybe waitingForUserNick would be clearer
14:27:07 --> logiclord has joined #instantbird
14:35:39 <Mic|web> Hello logiclord 
14:36:44 <logiclord> Hi Mic
14:47:21 <-- aleth has quit (Input/output error)
14:58:25 --> jc has joined #instantbird
14:58:44 <-- jb has quit (Ping timeout)
15:00:33 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com)
15:05:38 * Mic|web is fixing Omegle. Again :(
15:11:52 <flo> what broke it?
15:12:32 <Mic|web> What didn't? ;)
15:13:02 <Mic|web> The category was renamed, jsProtoHelper and interfaces changed..
15:14:08 <Mic|web> doXHRequest split off into a module..
15:19:06 <clokep_work> aleth: So it's really the same thing as my other comment saying I dislike all the BuddyInfo vs. Whois stuff.
15:19:17 <clokep_work> Mic|web: File a bug, I'll review it.
15:33:13 * jwir3|away is now known as jwir3
15:33:35 <flo> Mic|web: all that sounds really old ;)
15:33:41 <clokep_work> aleth: And the reason I like waitingForNick...is because you're waiting for the nick to be used as the name...you're not waiting for the name. ;)
15:46:21 <Mic|web> :)
15:46:38 <Mic|web> I think I have it working again
16:00:18 <flo> I'm annoyed by https://bugzilla.mozilla.org/show_bug.cgi?id=740502. My trivial fix (http://pastebin.instantbird.com/27140) depends on https://bugzilla.mozilla.org/show_bug.cgi?id=713825 which was checked-in for Moz12
16:00:41 <-- jc has quit (Ping timeout)
16:00:51 <flo> clokep_work: any idea of how we can handle that?
16:02:07 <flo> Mic|web: Cu.import("resource://gre/modules/imXPCOMUtils.jsm"); is wrong.
16:02:12 <flo> remove the "gre" :)
16:03:07 <Mic|web> Strange since it's working nevertheless..
16:03:26 <Mic|web> -since
16:03:47 <flo> Mic|web: resource://gre/ is files from XULRunner. resource:/// is files from the application.
16:04:27 <flo> if your xul platform and your application are in the same folder, mixing them won't cause visible issues, but the code won't work on linux builds that are based on a xul sdk
16:04:38 <Mic|web> Ah! :)
16:04:59 * bear|buildduty is now known as bear-afk
16:06:00 <flo> Mic|web: why is this.base.connecting changed to this.reportConnected in onConnected?
16:06:13 <flo> reportConnected doesn't take arguments
16:07:30 <Mic|web> A typo, I'd say.
16:08:34 <flo> seems ok otherwise
16:09:00 <Mic|web> :)
16:12:39 <flo> "watching others discuss a topic you suggest" uh :-S
16:12:52 <flo> do the others know you are watching them?
16:13:44 <Mic|web> "Spy mode lets you ask a question and watch two strangers discuss it. (The strangers volunteer to be watched.) Ask anything you like, but try to keep questions open-ended and thought-provoking."
16:19:48 <flo> oh, there's also a "find strangers with common interests" thing
16:20:28 --> BYK has joined #instantbird
16:31:10 --> Kaishi has joined #instantbird
16:31:15 <-- Even1 has quit (Quit: Instantbird -- http://www.instantbird.com)
16:35:48 <-- gerard-majax has quit (Ping timeout)
16:37:27 --> Tomek has joined #instantbird
16:39:38 * BYK is now known as B1K
16:46:40 --> aleth has joined #instantbird
16:46:40 * ChanServ sets mode +h aleth 
17:01:09 --> Mook_as has joined #instantbird
17:03:54 <aleth> clokep_work: "And while you're changing things in this file...you can get rid of the |if (aAccount.hasBuddy(aName))| check if you'd
17:03:54 <aleth> like.)" <-- surely not, until bug 613 is fixed?
17:03:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=613 min, --, ---, nobody, NEW, Presence information for IRC private messages from people not on the buddy list
17:09:42 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
17:14:06 <clokep_work> aleth: No. That has nothing to do with bug 613, getBuddy just returns null if the buddy doesn't exist.
17:14:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=613 min, --, ---, nobody, NEW, Presence information for IRC private messages from people not on the buddy list
17:14:21 --> myk has joined #instantbird
17:15:22 <Mic|web> pff, how did the /gre/ get back into this patch again? I had that fixed already :S
17:15:52 <clokep_work> flo: That fix probably looks OK but I'll need to read some stuff fifrs.t
17:16:20 <aleth> clokep_work: Have you checked this.buddy being set to null rather than undefined is OK?
17:17:49 <clokep_work> aleth: It's set to null to start w/ ;)
17:18:08 <clokep_work> This is a comment that flo made on my original patch to fix that that we didn't fix before someone checked the patch into comm-central.
17:18:20 <clokep_work> It doesn't matter if you fix it or not, but if you're reorganizing anything up there anyway...
17:19:24 <aleth> clokep_work: Just asking to find out whether I have to check it ;)
17:21:11 --> gerard-majax has joined #instantbird
17:23:14 --> jb has joined #instantbird
17:23:16 <clokep_work> You could check if I'm right anyway. ;)
17:23:16 <-- jb has quit (Connection reset by peer)
17:23:34 <clokep_work> aleth: http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#487
17:23:35 <-- Kaishi has quit (Quit: Kaishi)
17:23:39 <aleth> You are... but there might have been subtleties
17:29:12 <instantbot> aletheia2@fastmail.fm requested review from the wind for attachment 1324 on bug 1321.
17:29:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1321 min, --, ---, aletheia2, ASSI, Display name is lower case for IRC DMs
17:31:21 <Mic|web> bye
17:31:27 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
17:34:17 * bear-afk is now known as bear|buildduty
17:34:44 <aleth> clokep_work: I agree about the naming not being ideal, but we are a bit constrained by what is already in the interface etc...
17:36:18 <clokep_work> Yes, that's fine. :) As long as they're not haphazardly named.
17:36:43 <aleth> The only alternative I see would be to get rid of any reference to whois in method names, which seems artificial too
17:37:12 <aleth> Or make the buddyInfo ones aliases and use whois internally I suppose.
17:37:46 <clokep_work> I'd rather keep it the way it is then.
17:39:22 <clokep_work> Hmm...I feel like your old patch had more line breaks...
17:47:38 <-- micahg has quit (Quit: Ex-Chat)
17:47:53 --> micahg has joined #instantbird
17:54:18 <clokep_work> aleth: I think we normally don't like to modify the input arguments to functions.
17:55:19 --> Mnyromyr has joined #instantbird
17:59:47 <-- logiclord has left #instantbird ()
18:04:00 <instantbot> clokep@gmail.com requested review from florian@instantbird.org for attachment 1324 on bug 1321.
18:04:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1321 min, --, ---, aletheia2, ASSI, Display name is lower case for IRC DMs
18:09:35 --> pvagner has joined #instantbird
18:15:16 <instantbot> New Core - IRC bug 1369 filed by clokep@gmail.com.
18:15:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1369 enh, --, ---, clokep, ASSI, Support WATCH and MONITOR for IRC
18:15:36 <-- pvagner has quit (Ping timeout)
18:30:44 --> flo has joined #instantbird
18:30:45 * ChanServ sets mode +qo flo flo 
18:33:30 <aleth> clokep_work: ah, that has to be changed then
18:34:41 <aleth> Actually there are more line breaks now?
18:35:22 <clokep_work> Oh? I was expecting one above // Adjust the whois table where necessary. and //Clear the whois table.
18:35:48 <clokep_work> But that was a style thing that Idk if we have any guidelines on. :)
18:36:12 <aleth> There is one in each case.
18:36:47 <aleth> Though the bugzilla diff viewer swallows it for some reason
18:37:01 <clokep_work> Yeah, I see it in the actual diff now.
18:37:31 <aleth> I've noticed that before, that the diff viewer is not precise about line breaks
18:37:44 <clokep_work> Yeah, strange. Well ignore that comment then. ;)
18:38:28 <clokep_work> Yeah so generally we don't modify any of the parameters passed in, although I don't think it matters for a string (only for an {}?)
18:38:36 <clokep_work> flo Would know. :)
18:39:09 <aleth> I thought {} gets passed like a pointer to the original object, strings not.
18:39:29 * jwir3 is now known as jwir3|lunch
18:39:29 <aleth> But that might be wrong as everything is an object ;)
18:39:37 <clokep_work> Yes, that's what I just said.
18:40:05 <aleth> Ah :)
18:43:58 <flo> "I think we normally don't like to modify the input arguments to functions." if it's in JS, it doesn't really matter.
18:44:09 <flo> well, except if it was an object/array of course
18:44:47 <clokep_work> flo: Yup! I just thought stylewise we tend to not do it.
18:44:58 * clokep_work feels something wrong when there's aFoo variable being set. ;)
18:45:58 <flo> clokep_work: if it's in the middle of a function, it feels wrong, yes. If it's in the first few lines to add a default value, I tend to think it's quite ok :)
18:46:53 <clokep_work> Why I gave it an r+ asked for your review. ;)
18:47:41 <flo> uh, fair enough :)
18:48:59 <clokep_work> :-D
18:49:54 <flo> aleth: have you found enough info to fix that nick added twice to the participant list?
18:50:29 <aleth> flo: I think so - I suggested a fix, but wasn't sure about whether that was acceptable
18:50:42 <flo> aleth: removing the message isn't a fix
18:50:53 <flo> if it's what you meant by "I suggested a fix" :)
18:52:12 <aleth> It was :D (It wouldn't cause any problems in this instance, but I did say it was lazy...) 
18:53:03 <flo> I guess if you are really lazy the easiest solution is to blame whoever wrote that part of the JS-IRC code ;)
18:53:17 * clokep_work hides.
18:53:27 <clokep_work> What bug # is this?
18:53:54 <aleth> bug 1308 
18:53:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1308 nor, --, ---, nobody, NEW, Errors on joining channel: "Adding a chat buddy twice"
18:55:08 <clokep_work> Yeah I didn't really get your comment.
18:55:31 <clokep_work> "In this case, the conversation binding initConversationUI method will already have added (some?) participants, the user's nick being the first in the instances I tested, and therefore appearing in the error message."
18:55:40 <clokep_work> I don't see where the problem is in there?
18:55:55 <flo> clokep_work: if I understood correctly, the problem is that the "chat-buddy-added" notification has in the aSubject list a nick (the user's nick) that was already in the list returned by the getParticipant call before the IRC server had finished returning the list of nicks
18:56:46 <aleth> flo: Yes.
18:56:53 <flo> that notification is supposed to have the list of added nicks, not the whole list of nicks
18:57:07 <clokep_work> Right...
18:57:18 <flo> so to fix it lazily I think you would stop inserting the user's nick immediately in the list, or filter the list included in the notification
18:57:28 <aleth> It's not just the users nick I think
18:57:38 <flo> aleth: ah?
18:57:48 <aleth> That just happens to be the first, and therefore appears in the error message
18:58:00 <flo> aleth: by the way, if there's a JS error in the middle of processing that list of nicks, the participant list is half broken, isn't it?
18:58:42 <aleth> flo: I don't think so in most cases, because initConversationUI has already added all the participants
18:59:00 <aleth> But I am not sure that is guaranteed, so it might break things, yes
18:59:28 <flo> aleth: if all the participants have already been added, the notification is completely bogus
18:59:58 <aleth> flo: I think clokep_work added the notification in case the server is slow to supply all nicks
19:00:14 <aleth> You can't be sure all the participants have been added when initConversationUI is called
19:00:37 <aleth> (afaik)
19:01:10 <flo> aleth: what's the +      if (hasOwnProperty(this._account.whoisInformation, nick)) test for?
19:01:21 <flo> (2 lines after this comment "// If we are waiting for the conversation name, set it.")
19:02:16 <flo> aleth: "You can't be sure all the participants have been added when initConversationUI is called" you are almost sure they aren't, the notification has always been there, for *newly added* nicks
19:03:06 <aleth> flo: It's there in case the conversation partner does not exist, then there is no whois info.
19:03:28 <aleth> Now you might say this should be handled elsewhere, but at the moment it isn't
19:03:51 <aleth> flo: Sure, I was only referring to the call in response to a 366 message
19:04:18 <flo> ah, ok, I misread that code :)
19:04:20 <aleth> Which like you say shouldn't be sending the notification for _all_ participants
19:04:30 <clokep_work> Why not?
19:04:42 <aleth> Because it causes this error ;)
19:04:49 <clokep_work> Why?
19:04:55 <flo> clokep_work: because that's now how the API is supposed to behave
19:04:58 <clokep_work> AFAIK we don't call that notification anywhere else.
19:05:01 <flo> it's a "chat-buddy-*added*" notification
19:05:25 <clokep_work> I understand that.
19:05:29 <flo> not a "chat-buddy-list-received" notification (this one if it existed would receive the full list)
19:05:30 <clokep_work> But I don't think we're adding them in other places.
19:05:45 <aleth> They are automatically added by initConversationUI in conversation.xml
19:05:50 <flo> clokep_work: the list seems to be initialized to the user's nick
19:06:10 <flo> aleth: you are confusing something from the UI and something from the IRC code now ;)
19:06:13 <clokep_work> "They" being what? We don't know about them until the conversation initializes.
19:06:40 <aleth> flo: The error message is from the UI code
19:07:03 <aleth> I think we mean the same thing anyhow.
19:07:47 <clokep_work> Alright, so the issue is that the UI code auto initializes yourself as in the room? Then why isn't there an error every time?
19:08:08 <aleth> http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1273
19:08:25 <flo> clokep_work: the UI initializes itself to the nicks returned by getParticipants() and then adds additional nicks received in chat-buddy-added notifications
19:08:32 <aleth> clokep_work: It's a matter of timing.
19:09:09 <aleth> Usually that chat-buddy-added notification goes nowhere.
19:09:17 <-- Tonnes has quit (Quit: ChatZilla [Firefox 11.0/20120312181643])
19:09:28 <clokep_work> "goes nowhere"? I doubt that.
19:09:39 <aleth> Well, doesn't reach the conversation binding.
19:09:44 <aleth> To be more precise.
19:09:55 <flo> clokep_work: it goes nowhere if the server has finished sending you the list of nicks before the conversation window has finished initializing itself
19:10:08 <aleth> Exactly.
19:10:13 <flo> so it's kind of a race between your local computer, your IRC server, and your bandwidth
19:10:17 * aleth must have formulated that comment really badly
19:10:26 <clokep_work> It doesn't seem like there's a good way to fix it besides filtering then, but that seems like a hack.
19:11:10 * clokep_work would have assumed it would have finished initializing before anything else can occur on it...
19:11:45 <flo> clokep_work: that would be too easy
19:11:52 <flo> (or your computer is way too fast)
19:12:16 <clokep_work> Yeah, probably.
19:12:38 <aleth> Or your server ;)
19:12:39 <clokep_work> Btw we also could move that notification to http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircBase.jsm#844
19:13:11 <clokep_work> There still could probably be a race condition...but the chance of it would be smaller.
19:15:17 <flo> aleth: in the ircConversation constructor, is aName supposed to be normalized or not?
19:15:45 <aleth> flo: it's not.
19:17:15 <flo> so why isn't it capitalized correctly?
19:17:33 <flo> (in the case of clicking in a nick of the nicklist)
19:17:35 <aleth> Because if the user types /msg fLo then it will be fLo
19:17:42 <flo> (in the /msg command case, I know it's the crap the user entered)
19:17:55 <aleth> For clicking on the nicklist, sure.
19:18:24 <aleth> (I think so at least)
19:18:51 <aleth> I haven't checked.
19:20:21 <clokep_work> I don't think it's normalized...but it's possible it gets normalized somewhere along the way...
19:20:33 <clokep_work> (It probably /shouldn't/ be though.)
19:21:34 <aleth> Yep, it seems to be normalized somewhere for some reason. Probably to strip out any user prefixes. Not that it matters at this point.
19:22:19 <flo> isn't it becasue of the normalizedChatBuddy getter that normalizes it for no good reason?
19:23:12 <flo> but I don't think I care too much about it :)
19:23:14 <aleth> Stripping the user prefixes is probably the good reason.
19:23:27 <aleth> (I am assuming clokep had one...)
19:24:54 <instantbot> florian@instantbird.org granted review for attachment 1324 on bug 1321.
19:24:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1321 min, --, ---, aletheia2, ASSI, Display name is lower case for IRC DMs
19:25:07 <clokep_work> aleth: Yes I should have an @. :P
19:25:19 <flo> aleth: I was assuming he just saw "normalized" in the name and decided applying the "normalize" function was a good way to not wonder more what that getter was supposed to do
19:25:20 <clokep_work> flo: Ah, I forgot about that. :( We should fix that...
19:25:40 <clokep_work> Yes, I forget whether their was a comment there in the idl or not.
19:25:56 <flo> I think you volunteered to add one :-P
19:26:14 <flo> after we discussed it and agreed the name was confusing
19:28:50 <clokep_work> Yeah. No bug was filed. :(
19:30:52 <instantbot> New Core - IRC bug 1370 filed by clokep@gmail.com.
19:30:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1370 tri, --, ---, clokep, ASSI, Fix clokep's lack of reading comments his stupid usage of normalizedChatBuddy getter
19:32:10 <aleth> That will make a colourful commit message ;)
19:32:21 <clokep_work> Especially with the typo in it. :(
19:32:26 <clokep_work>  / extra word
19:32:39 <flo> clokep_work: is it really a bug to return a normalized name, by the way?
19:33:03 <flo> (especially now that we can convert them back to what they should be with the whois info table)
19:33:50 <clokep_work> I think so.
19:34:15 <flo> I think if there's no user visible consequence, either way is OK
19:34:27 <clokep_work> I'd rather pass it unnormalized. :)
19:34:45 <aleth> What do other protocols do?
19:35:10 <clokep_work> My guess is: not suck as much as IRC.
19:35:25 <aleth> IRC is just an order of magnitude more complicated about everything.
19:35:45 <clokep_work> Haha, I can never decide whether IRC is simpler or more complicated. :(
19:36:10 <aleth> I think it probably started out simpler...
19:37:31 <flo> aleth: I suspect IRC is the most complicated protocol, until you look at any other protocol :-P
19:37:37 <clokep_work> Well it's a human readable text protocol which makes it very simple in a lot of ways.
19:37:51 <clokep_work> And it really doesn't support a large featureset.
19:37:57 <clokep_work> Not compared to like XMPP.
19:38:06 * clokep_work readies his voice/video over IRC spec. :-S :P
19:38:07 <flo> (I must admit Omegle was surprisingly simple, but it's not a really useful protocol)
19:38:08 <aleth> That could well be :D
19:39:22 <aleth> I just meant the feature set came in multiple variants as later bolt-ons ;)
19:40:14 <aleth> But maybe other protocols have that too.
19:40:35 <clokep_work> Ah yeah, in that sense...it's a pain in the ass.
19:40:43 <clokep_work> XMPP is probably worse...even though it has actual specs for everything.
19:42:19 <flo> is the Omegle plugin restartless?
19:42:26 <clokep_work> So do we have a solution for bug 1308? Or is it just "filter stuff before we send that message"?
19:42:28 <clokep_work> It could be...
19:42:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1308 nor, --, ---, nobody, NEW, Errors on joining channel: "Adding a chat buddy twice"
19:59:47 * clokep_work is having trouble thinking of a real way to fix that unless there's a way to tell the conversation is fully initialized...
20:05:31 * clokep_work just realized an assumption he made in irc.js is wrong. :(
20:05:38 <clokep_work> Also I think my code fails if there's no quit message.
20:09:03 * jwir3|lunch is now known as jwir3
20:11:16 <-- jazper- has quit (Connection reset by peer)
20:12:30 --> jazper- has joined #instantbird
20:29:47 --> EionRobb has joined #instantbird
20:32:19 <-- clokep_work has quit (Quit: Bye!)
21:05:04 --> qheaden has joined #instantbird
21:08:35 <-- gerard-majax has quit (Ping timeout)
21:09:32 <-- Tomek has quit (Quit: Instantbird 1.1)
21:25:14 <-- qheaden has quit (Ping timeout)
21:31:27 <-- chrisccoulson has quit (Quit: Ex-Chat)
21:33:17 --> chrisccoulson has joined #instantbird
21:36:09 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
21:44:52 * bear|buildduty is now known as bear-afk
22:03:09 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:07:39 <-- aleth has quit (Input/output error)
22:07:51 --> aleth has joined #instantbird
22:07:52 * ChanServ sets mode +h aleth 
22:31:10 * jwir3 is now known as jwir3|away
22:32:18 --> clokep has joined #instantbird
22:32:18 * ChanServ sets mode +o clokep 
22:34:46 <clokep> Hello.
22:55:22 --> clokep_js has joined #instantbird
22:55:41 <-- clokep_js has quit (Quit: Instantbird -- http://www.instantbird.com)
22:56:41 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1325 on bug 1370.
22:56:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1370 tri, --, ---, clokep, ASSI, Fix clokep's lack of reading comments and his stupid usage of normalizedChatBuddy getter
23:02:28 --> mmkmou has joined #instantbird
23:23:43 <clokep> bio running slow for anyone else?
23:24:52 <aleth> Not more than usual
23:25:45 <clokep> Alright...
23:30:30 <-- mmkmou has quit (Ping timeout)
23:36:47 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com)
23:41:58 --> mmkmou has joined #instantbird
23:43:23 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1209 on bug 1305.
23:43:24 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1326 on bug 1305.
23:43:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1305 nor, --, ---, clokep, ASSI, /mode messages don't work on JS-IRC
23:50:52 <-- EionRobb has quit (Ping timeout)
23:51:31 --> EionRobb has joined #instantbird
23:53:00 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1327 on bug 1306.
23:53:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1306 nor, --, ---, clokep, ASSI, Joining a password protected IRC channel via password set in autojoin doesn't work from Feb 28 night