All times are UTC.
00:06:23 <-- myk has quit (Ping timeout) 00:09:28 --> myk has joined #instantbird 00:10:29 --> clokep has joined #instantbird 00:10:30 * ChanServ sets mode +o clokep 00:12:05 <-- myk has quit (Ping timeout) 00:18:34 <instantbot> New Core - IRC bug 1362 filed by aletheia2@fastmail.fm. 00:18:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1362 nor, --, ---, nobody, NEW, JS-IRC does not set buddy status to "unavailable" when buddy away. 00:21:18 <instantbot> New Core - IRC bug 1363 filed by aletheia2@fastmail.fm. 00:21:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1363 nor, --, ---, nobody, NEW, JS-IRC does not set status on DM conversation partners that are not buddies 00:21:35 * Mic decided to call the 25 messages of context a funny number ;) 00:21:55 <clokep> aleth: Bug 1363 is a dup I think. 00:24:31 * bear is now known as bear-afk 00:24:43 <Mic> aleth: comment 1 sounds like a good idea 00:28:11 * clokep guesses he's not a talented IM folk. ;) 00:28:40 <-- Mook_as has quit (Quit: gone) 00:29:55 <aleth> Of course we don't get notified when someone goes away afaik, but we can make use of the info we do have, especially after bug 1321 lands. 00:29:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1321 min, --, ---, aletheia2, ASSI, Display name is lower case for IRC DMs 00:33:09 <instantbot> clokep@gmail.com set the Resolution field on bug 1363 to DUPLICATE of bug 613. 00:33:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1363 nor, --, ---, nobody, RESO DUPLICATE, JS-IRC does not set status on DM conversation partners that are not buddies 00:33:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=613 min, --, ---, nobody, NEW, Presence information for IRC private messages from people not on the buddy list 00:33:51 <-- Mic has quit (Input/output error) 00:34:02 <aleth> Heh, libpurple had the same bug... 00:34:19 <clokep> Yes. ;) 00:40:06 --> clokep_js has joined #instantbird 00:40:31 <-- clokep_js has quit (Quit: Instantbird -- http://www.instantbird.com) 00:42:07 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1303 on bug 1321. 00:42:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1321 min, --, ---, aletheia2, ASSI, Display name is lower case for IRC DMs 00:42:16 <-- Suiseiseki has quit (Ping timeout) 00:42:58 <instantbot> clokep@gmail.com granted review for attachment 1301 on bug 1321. 00:43:12 --> Suiseiseki has joined #instantbird 00:43:59 <instantbot> aletheia2@fastmail.fm granted review for attachment 1303 on bug 1321. 00:51:35 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1304 on bug 1346. 00:51:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 00:54:26 <clokep> aleth: You're awake still...you get review requests. ;) 00:57:17 <aleth> clokep: Yay, another bug fixed :) But I think I'll save the review for tomorrow ;) 00:57:25 <clokep> Alright. 00:57:32 <clokep> I think the issue is when the return of 303 is empty yes. 00:57:54 <aleth> Yep, I must have been tired already ;) 00:59:34 <clokep> It's OK. :) 00:59:34 <aleth> Much easier to fix than a race condition too! 00:59:37 <clokep> I'll look at it at some point... 00:59:45 <-- aleth has quit (Input/output error) 01:07:28 * clokep is now known as clokep_ 01:09:29 * clokep_ is now known as clokep 01:13:33 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1305 on bug 1303. 01:13:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1303 nor, --, 1.2, clokep, REOP, IRC contacts don't get their status updated 01:15:36 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 1304 on bug 1346. 01:15:37 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1306 on bug 1346. 01:15:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 01:34:19 <clokep> flo: So...bug 1219...? I can't figure out that binding at lal. :-/ 01:34:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1219 tri, --, ---, nobody, NEW, Cleanup the account.xml binding 02:05:13 <-- Suiseiseki has quit (Quit: Quit) 02:07:20 --> Suiseiseki has joined #instantbird 02:10:34 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 02:57:35 <instant-buildbot> build #453 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/453 03:14:20 <instant-buildbot> build #441 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/441 04:41:00 <instant-buildbot> build #537 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/537 05:23:54 <-- jazper- has quit (Ping timeout) 05:29:18 --> pvagner has joined #instantbird 05:50:29 --> jazper- has joined #instantbird 05:59:10 --> jb has joined #instantbird 06:23:44 --> EionRobb has joined #instantbird 06:28:53 <-- jb has quit (Ping timeout) 06:32:01 --> NmN has joined #instantbird 06:45:06 <-- Kaishi has quit (Quit: Kaishi) 07:14:30 --> jb has joined #instantbird 07:25:59 <-- Even has quit (Ping timeout) 07:57:04 <-- NmN has quit (Ping timeout) 08:02:59 <-- gerard-majax has quit (Ping timeout) 08:05:37 --> NmN has joined #instantbird 08:21:49 --> mmkmou has joined #instantbird 08:37:56 --> flo has joined #instantbird 08:37:56 * ChanServ sets mode +qo flo flo 08:52:35 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com) 08:52:47 --> flo has joined #instantbird 08:52:48 * ChanServ sets mode +qo flo flo 08:56:50 <flo> hello :) 09:20:32 --> aleth has joined #instantbird 09:20:33 * ChanServ sets mode +h aleth 09:21:11 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 09:21:20 --> aleth has joined #instantbird 09:21:20 * ChanServ sets mode +h aleth 09:31:43 <flo> clokep: "flo: So...bug 1219...? I can't figure out that binding at lal. :-/" what's difficult about it? 09:31:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1219 tri, --, ---, nobody, NEW, Cleanup the account.xml binding 09:33:10 <flo> Mic: kaze is the author of Komposer (an Nvu fork), and currently works on boot2gecko from the Paris office (so he works in the same office as j b; that's probably his closest link with Thunderbird). 09:34:54 <flo> aleth: I think ctrl-- currently doesn't work in the IM view in Tb. 09:35:05 <flo> but it's something that obviously needs to be fixed :) 09:35:22 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 09:35:37 --> aleth has joined #instantbird 09:35:37 * ChanServ sets mode +h aleth 09:36:08 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 09:36:23 --> aleth has joined #instantbird 09:36:24 * ChanServ sets mode +h aleth 09:45:45 <instantbot> aletheia2@fastmail.fm granted review for attachment 1305 on bug 1303. 09:45:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1303 nor, --, 1.2, clokep, REOP, IRC contacts don't get their status updated 09:47:15 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1307 on bug 1303. 09:51:05 <-- Eveo has quit (Quit: Instantbird -- http://www.instantbird.com) 09:51:11 --> Even has joined #instantbird 09:51:11 * ChanServ sets mode +o Even 09:56:13 --> gerard-majax has joined #instantbird 09:57:53 <instantbot> aletheia2@fastmail.fm denied review for attachment 1306 on bug 1346. 09:57:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 09:58:01 --> Tomek has joined #instantbird 10:03:16 <-- Tomek has quit (Quit: Instantbird 1.1) 10:04:07 <-- EionRobb has quit (Quit: Leaving.) 10:06:01 <aleth> clokep: Could you check bug 1142 is fixed on Windows too? Thanks 10:06:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1142 min, --, ---, nobody, NEW, Minimizing Contacts window instead of focusing it on single click 10:20:10 --> clokep has joined #instantbird 10:20:10 * ChanServ sets mode +o clokep 10:25:54 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1308 on bug 1346. 10:25:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 10:29:06 <instantbot> clokep@gmail.com denied review for attachment 1307 on bug 1303. 10:29:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1303 nor, --, 1.2, clokep, REOP, IRC contacts don't get their status updated 10:31:08 <instantbot> clokep@gmail.com set the Resolution field on bug 1142 to WORKSFORME. 10:31:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1142 min, --, ---, nobody, RESO WORKSFORME, Minimizing Contacts window instead of focusing it on single click 10:37:22 <instantbot> clokep@gmail.com granted review for attachment 1310 on bug 1303. 10:37:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1303 nor, --, 1.2, clokep, REOP, IRC contacts don't get their status updated 10:38:20 <-- gerard-majax has quit (Ping timeout) 10:38:48 <clokep> instantbot: Is talkative this morning. :) 10:38:51 <instantbot> clokep: Sorry, I've no idea what 'Is talkative this morning. :)' might be. 10:39:04 <clokep> (And yay, it auto-completed to instantbot instead of instant! :)) 10:39:23 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1311 on bug 1303. 10:39:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1303 nor, --, 1.2, clokep, REOP, IRC contacts don't get their status updated 10:39:43 --> gerard-majax has joined #instantbird 10:42:53 <aleth> clokep: I don't think the new regexp works either :( 10:43:05 <clokep> :-/ Why not? 10:43:10 <clokep> I tested it briefly... 10:43:15 <clokep> It might fail on really weird characters. :( 10:43:37 <aleth> I'll check it in detail in a bit. 10:43:56 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 10:44:18 --> clokep has joined #instantbird 10:44:19 * ChanServ sets mode +o clokep 10:44:19 <aleth> Yes, it fails for standard cases now. 10:44:41 <aleth> e.g. |/^(.+)(\d*)$/.exec("clokep1");| 10:45:20 <instantbot> clokep@gmail.com granted review for attachment 1311 on bug 1303. 10:45:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1303 nor, --, 1.2, clokep, REOP, IRC contacts don't get their status updated 10:45:45 <clokep> /^(.+?)(\d*)$/ works.. 10:46:15 <clokep> Would that pass review? :) 10:48:12 <aleth> That looks good to me :) I thought there might just be a typo, but you never know with regexp... 10:49:20 <clokep> Yes, they're tricky. 10:49:22 <clokep> But they let you fly. 10:50:00 <aleth> One edge case is that clokep01 will be incremented to clokep2. But I don't think that's worth worrying about. 10:50:40 <flo> uh, another edge case :( 10:51:15 <clokep> Arg... 10:51:16 <clokep> Wait. 10:51:17 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 1308 on bug 1346. 10:51:18 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1312 on bug 1346. 10:51:18 <clokep> Don't review that. 10:51:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 10:53:49 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 1312 on bug 1346. 10:53:50 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1313 on bug 1346. 10:53:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 10:54:47 <clokep> Sorry for the bugspam. :( 10:55:18 <flo> someone (a potential new Ib translator) just asked me "Is IB deprecated because TB13?" :-| 10:58:16 <clokep> :( 10:58:40 <flo> Maybe we should blog on the topic? :) 10:58:55 <clokep> I was just thinking that. 11:00:08 <aleth> Make 1.2 sound like it's close 11:00:25 <instantbot> aletheia2@fastmail.fm granted review for attachment 1313 on bug 1346. 11:00:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 11:02:11 <clokep> aleth: Wait...does that match clokep? 11:02:25 <clokep> No...it doesn't. 11:02:39 <aleth> Oh no :( 11:05:43 <flo> heh, if you want to play with edge cases, try to ensure it still works for the general case :) 11:06:31 --> go8765 has joined #instantbird 11:06:40 <clokep> Thanks. :P 11:06:47 <clokep> I have an idea for it now... 11:06:48 <aleth> clokep: /^(.+?0*)(\d*)$/ ? 11:06:50 * clokep is very late, bbs! 11:07:23 <-- go8765 has quit (Quit: Instantbird -- http://www.instantbird.com) 11:08:34 <-- clokep has quit (Ping timeout) 11:18:09 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1309 on bug 1362. 11:18:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1362 nor, --, ---, nobody, NEW, JS-IRC does not set buddy status to "unavailable" when buddy away. 11:18:53 --> jc has joined #instantbird 11:19:11 <-- jb has quit (Ping timeout) 11:26:37 <-- NmN has quit (Quit: Instantbird 1.1) 11:27:55 --> Tomek has joined #instantbird 11:39:45 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1314 on bug 1362. 11:39:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1362 nor, --, ---, nobody, NEW, JS-IRC does not set buddy status to "unavailable" when buddy away. 11:40:06 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1309 on bug 1362. 11:43:13 --> clokep_work has joined #instantbird 11:43:13 * ChanServ sets mode +o clokep_work 11:45:27 <clokep_work> flo: aleth Btw the reason I originally did the nick changing by incrementing the character: it doesn't increase the length of the string. 11:45:51 <clokep_work> So we need to take into account the max length of nicks also...? 11:58:45 <flo> uh :( 12:00:00 <instantbot> clokep@gmail.com denied review for attachment 1314 on bug 1362. 12:00:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1362 nor, --, ---, nobody, NEW, JS-IRC does not set buddy status to "unavailable" when buddy away. 12:00:57 <clokep_work> aleth: I hope those comments make sense. 12:00:59 <clokep_work> I need to run for a bit. 12:11:37 --> logiclord has joined #instantbird 12:15:15 * jc is now known as jb 12:15:53 <logiclord> flo : ping 12:23:48 <-- mmkmou has quit (Ping timeout) 12:25:29 --> mmkmou has joined #instantbird 12:30:15 --> chrisccoulson has joined #instantbird 12:33:12 <logiclord> submitted my proposal with all suggested changes... do have a look at melange. Thanks :) 12:34:40 <aleth> logiclord: flo is probably having lunch 12:36:57 <logiclord> i'll hang around 12:41:45 <flo> I'm around but in a meeting 12:42:08 <logiclord> I will wait :) 12:49:47 --> NmN has joined #instantbird 13:04:45 <clokep_work> aleth: Question about your patch when you have a second. 13:05:05 <clokep_work> "Because we also get info on the Away status of a nick when someone runs a whois, in particular on opening a DM by double-clicking a nick in the participant list." Does this NOT come as a 301 reply and it comes as something else then? 13:06:14 <clokep_work> I don't see how that statement has anything to do with my question...if we find out they're away, we should set them as away? But it's not really partying "setting whois info"... 13:07:00 <aleth> No, you are right, I never noticed that the whois response also used 301. 13:07:34 <aleth> So placing it in setWhois is indeed unnecessary. 13:08:09 <flo> bah, https://bugzilla.mozilla.org/show_bug.cgi?id=737497 :( 13:08:19 <flo> I guess I should search for all bugs filed by andreas in that component 13:08:45 <clokep_work> :) That's what I thought, so then it makes sense to do it in the 301 response so it doesn't run EVERY time we run setwhois. 13:08:52 <aleth> Definitely. 13:11:01 <aleth> I thought (without checking the actual output) that whois had separate response codes, RPL_WHOISxxx 13:11:52 * aleth in irc-protocol-being-unexpectedly-sensible shock 13:12:03 <-- jb has quit (Quit: jb) 13:12:41 <clokep_work> :) 13:12:43 --> jb has joined #instantbird 13:12:43 <clokep_work> It does somethings well. 13:12:54 <clokep_work> Btw I was looking for a ISON type thing for ISAWAY in the RFC earlier. 13:13:01 <clokep_work> It seems the usermode might get set to +a. 13:13:11 <clokep_work> But I haven't had time to check more. 13:18:05 <clokep_work> flo: Btw that bug about the message theme I'm probably going to stay away from. it's no use arguing with people who change what they're saying each comment. 13:18:38 <flo> apparently kaze has decided to stay away from it too ;) 13:19:23 <flo> anyway, as long as the instantbird message theme is something we like, whatever is put in the default Thunderbird one is irrelevant 13:19:37 <clokep_work> Yes. I agree. :) Just trying to point out crazy things people say. :P 13:20:57 <clokep_work> Although I'd really like it if Thunderbird stayed away from protocol specific hacks... 13:21:01 <clokep_work> But I don't care tha tmuch. ;) 13:21:28 <flo> I'm ok with helping them have a protocol specific appearance for each message, not for each conversation 13:21:40 <flo> it's possible we even already provide that :-D 13:23:29 <flo> http://lxr.instantbird.org/instantbird/source/chat/modules/imThemes.jsm#451 13:23:33 <flo> perfect, it's already possible 13:24:03 <flo> just add network="%service%" in each message, and add css for .bubble[network=Twitter] 13:24:39 * bear-afk is now known as bear 13:26:44 <clokep_work> So what you're saying is that we could add little icons for Twitter to retweet, etc? ;) 13:27:07 <flo> clokep_work: really? 13:27:09 <clokep_work> (It'd be nice to be able to do that, but through the actions API somehow...) 13:27:37 <flo> as far as I remember, the difficulty for that was inserting localized strings for the icons' tooltips 13:29:26 <clokep_work> Ah, perhaps. I don't remember exactly. 13:29:31 <clokep_work> flo: I was kidding. :) 13:31:23 <clokep_work> Also, about cleaning up accounts.xml...I couldn't find where the labels get shown/hidden, etc. But I was tired so maybe just being dumb. :) 13:34:02 <-- mmkmou has quit (Ping timeout) 13:34:10 <flo> or maybe that code just doesn't make sense 13:34:35 <flo> it's probably the oldest piece of Instantbird-specific code that still exists 13:35:40 <flo> likely written in August 2007 (the first public release was in october 2007) 13:37:41 --> mmkmou has joined #instantbird 13:39:39 <-- Tomek has quit (Quit: Instantbird 1.1) 13:44:10 <clokep_work> Ah, I see. 13:44:26 <clokep_work> Yeah I mean I looked at it and was having trouble following it. I'll need to dig deeper into it. 13:51:21 <clokep_work> aleth: So would it be reasonable to...ping ISON like we are...if we get back that they're online and we have them marked as away, then run a WHOIS on them, then on the end of the WHOIS response, we mark them as away or available? 13:53:59 <aleth> clokep_work: Sounds OK. But that would lead to a whois every minute for every IRC buddy that is away. Does that give problems with Max SendQ Exceeded? 13:54:24 <clokep_work> Possibly. 13:54:56 <clokep_work> I actually think we should mark when we last receive WHOIS info also and also request it every "xxx seconds". (Perhaps we can check it only every 5 minutes or something?) 13:55:08 <clokep_work> Unless we've received a message from them and NOT a 301. 13:55:11 <clokep_work> I think that's how it works... 13:56:00 <aleth> Didn't libpurple run in to problems with that approach? 13:56:01 <clokep_work> We could also request the usermode and check for it to be +a btw. 13:56:07 --> jc has joined #instantbird 13:56:13 <clokep_work> No. They were running a WHOIS on EVERYONE. 13:56:23 <aleth> oh dear :( 13:56:25 <clokep_work> Everyone in all the chats you're in. 13:56:30 <clokep_work> I think at least. 13:56:48 <aleth> Anyway, you're the expert on IRC, so I'll go with what you suggest here. 13:56:53 <clokep_work> The other option is to just set it lazily... 13:57:14 <-- jb has quit (Ping timeout) 13:57:17 <aleth> You mean as in the patch at present... plus marking available on send. 13:58:26 <clokep_work> Yes, although I'm not sure when it's best to mark them back as available. 13:58:39 <clokep_work> You mean each time we send a message, mark as "available" and wait for the 301 response? 13:59:00 <aleth> No, when we receive a message. 13:59:08 <aleth> It's got its own problems... people can speak when away, after all. 13:59:15 <clokep_work> Yes. :-/ 13:59:38 <aleth> The regular whois thing would be better, if it doesn't lead to the server kicking the client ;) 14:00:01 <aleth> (or usermode if that is better) 14:00:06 <clokep_work> So whenever we send a private message to them, we're supposed to receive a 301 in response if they're away. 14:00:18 <aleth> Yes, that's the part that is handled 14:00:27 <clokep_work> No it's not. 14:00:35 <aleth> Why, on 301 we set away. 14:00:35 <clokep_work> The /not/ receiving the 301 is not handled. 14:00:54 <aleth> Oh, I see what you mean now. 14:01:43 <aleth> It's not good to rely on that to set people back to available though. 14:01:50 <clokep_work> I agree. :( 14:02:04 <clokep_work> But it's one way we know they're available. ;) 14:02:14 <clokep_work> If we /don't/ receive a 301, then they're available, bang. Done. 14:02:22 <clokep_work> If we DO receive a 301, they're away. Done. 14:02:31 <aleth> But you have to send a message to find out. 14:02:33 <clokep_work> So that handles an "active" conversation. 14:02:51 <clokep_work> We need to handle an "inactive" conversation...which is pretty much you'd need to send WHOIS pings... 14:02:53 <flo> I haven't read the whole conversation, but I'm wondering if you aren't looking for more complicated solutions than the problem is worth 14:03:02 <aleth> It's kind of hard to handle the absence of a 301 imho. 14:03:24 <clokep_work> : shrugs : you wait 30 seconds, and assume if you haven't seen one you set them to available. ;) 14:04:32 <clokep_work> Which is making me realize we can handle hte ISON case slightly better too. 14:06:34 <aleth> Currently we don't even handle the case where a DM is sent to an offline contact :( 14:07:37 <clokep_work> There's a bug on that I think... 14:07:43 <aleth> flo: It's true the solution should not be too complicated, but there are a bunch of related bugs here. 14:08:21 <aleth> So the hope is to find something that fixes most of them most of the time ;) 14:08:23 <flo> aleth: "Currently we don't even handle the case where a DM is sent to an offline contact :(" that sounds more important ;) 14:09:28 <clokep_work> bug 1353 is what I was thinking of...probably not exactly the same. 14:09:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1353 nor, --, ---, nobody, NEW, No user feedback when sending a message in a conversation of an offline account 14:09:38 <clokep_work> But more of a "oh crap we don't handle a lot of error conditions". 14:11:24 <aleth> flo: Fixing bug 613 would probably make fixing that easy. That's what I meant by them all being related 14:11:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=613 min, --, ---, nobody, NEW, Presence information for IRC private messages from people not on the buddy list 14:12:07 <flo> I'm not sure you have to fix that to fix the regression though 14:12:24 <aleth> Well, you have to handle 401, somehow 14:13:53 <clokep_work> "401" is that a bug or a response code? 14:14:12 <aleth> The response code. 14:14:34 <aleth> You have to figure out what it is in response to, and/or propagate it to all the places where it could be relevant 14:14:40 <clokep_work> Yeah...that response is a pain. It's a catchall. 14:15:31 <aleth> If 613 was fixed you would simply set the status of the participant and the conversations could react accordingly. 14:16:04 <aleth> That handles all but where 401 is in response to "no such channel" (an extra pain) 14:16:04 <clokep_work> If you accurately know the status of the people, which I don't think you can. 14:17:40 <aleth> When you get 401, you know they are offline or don't exist at all. 14:18:30 <clokep_work> You know they're offline, yes. 14:19:16 <clokep_work> Yes so you receive RPL_AWAY, ERR_NOSUCHNICK or nothing in response to a private message. 14:23:28 <clokep_work> I need to think about it more... 14:23:57 <aleth> Anyway, what I meant was that fixing 613 would provide a place to propagate this kind of information /to/, which is a start 14:24:06 <aleth> But it's a tangle... 14:24:10 <clokep_work> Yup. 14:25:13 <aleth> Maybe adding temporary buddy objects (that don't appear in the contact list) is the way to go, I don't know. 14:26:13 <aleth> Then you would also get ISON info for them while you have a DM open 14:28:30 <clokep_work> Yes, we need to get ISON info from them somehow. 14:29:29 <aleth> And the convtop can just be set to that buddy as per usual 14:31:10 <-- chrisccoulson has quit (Ping timeout) 14:38:38 <flo> or redefine the expected behavior of the contact list system to automatically add people you talk to, and remove people you never interact with? 14:39:58 <clokep_work> aleth: So the easy way to handle this crap is to implement the WATCH command instead of ISON if it's supported. 14:40:27 --> NmN1 has joined #instantbird 14:40:30 <clokep_work> I'm trying to find a description of it... 14:40:36 <clokep_work> I know how to tell if it's supported or not. :P 14:41:28 <-- NmN has quit (Ping timeout) 14:42:46 <aleth> flo: Maybe with a tag "Recently spoken to"? And if a buddy is only in that tag they can be removed? I think as a general rule it would be bad to forget buddies. 14:43:16 <aleth> One could simply clear the content of that tag on startup for example 14:43:48 <flo> or remove those you haven't talked to for a while when the list gets longer than what we can reasonable poll for the status 14:44:04 <clokep_work> I hate auto-adding buddies to the buddy list. :-/ 14:44:34 <aleth> clokep_work: I agree any such tag should be at least hidden by default 14:45:19 <aleth> But it does act a bit like the "Favourites" tag suggestion that has been made before 14:45:54 <-- pvagner has quit (Ping timeout) 14:46:18 <clokep_work> Yes. 14:49:03 <aleth> Though I really dislike calling it "Favourites" :-/ 14:49:18 <clokep_work> Yes, it shuld definitely be "Favorites" ;) 14:49:28 <aleth> That's even worse :P 14:54:44 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 14:54:56 --> aleth has joined #instantbird 14:54:56 * ChanServ sets mode +h aleth 14:56:01 <aleth> clokep_work: WATCH sounds good, but does it actually notify of changes in Away status? 14:56:31 <aleth> maybe WHO +a would work for that? 14:57:29 <clokep_work> aleth: No, but it notifies of on/off. ;) 14:57:36 <clokep_work> And I'd love to find documentation for it but I can't... 14:58:29 <aleth> I wonder how widely supported it can be if there is no documentation :( 14:59:14 <clokep_work> moznet supports it. 15:00:05 <clokep_work> Unreal and bahamut (which is DALnet) support it at least. 15:03:44 <-- jc has quit (Quit: jc) 15:06:28 --> jb has joined #instantbird 15:16:18 <clokep_work> aleth: Will do what we want also and is very similar: http://hg.atheme.org/charybdis/file/f814266636f7/doc/monitor.txt 15:16:22 <clokep_work> But again, just online/offline. 15:25:42 <clokep_work> Found it. :) 15:29:30 <flo> logiclord: are there specific points that you expect feedback on? 15:30:57 <clokep_work> aleth: Ah, it supports away! 15:33:02 <aleth> clokep_work: Sounds great! I'll take a look at it later. (Would one have to keep ISON as a backup for servers that don't have it?) 15:34:29 <clokep_work> Yes. But I think we can not even try to handle away using ison then. 15:37:41 <-- gerard-majax has quit (Ping timeout) 15:44:56 <logiclord> flo : yes mainly regarding the timeline 15:45:55 <logiclord> I was wondering should I list out and study decryption procedure as mention currently or as we require for a client 15:46:18 <logiclord> some of them may take lots of time 15:53:11 * bear is now known as bear-afk 15:59:05 <-- wesj has quit (Input/output error) 15:59:08 --> wesj has joined #instantbird 16:09:17 --> myk has joined #instantbird 16:22:50 <flo> logiclord: as needed for the importers you are writing seems fine. 16:27:15 <logiclord> flo : okay :) ... so this makes my proposal complete 16:27:51 <logiclord> will try and continue with bugs 16:32:13 <-- NmN1 has quit (Quit: Instantbird 1.1) 16:39:58 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com) 16:40:51 <-- logiclord has quit (Ping timeout) 16:41:05 --> logiclord has joined #instantbird 16:53:23 * bear-afk is now known as bear 17:12:40 * clokep_work needs to remember to change the socket logger to the DEBUG function... 17:12:56 <clokep_work> logiclord: I think we probably have some marked as "good first bugs", not sure how boring those ones are... 17:15:20 <clokep_work> (There's also some other ones that we'd like but have no time to work on if you'd like suggestions. :P) 17:16:03 <aleth> Or just scratch your own itches ;) 17:16:19 <clokep_work> :) 17:19:10 <-- jb has quit (Ping timeout) 17:23:43 <-- myk has quit (Connection reset by peer) 17:23:43 --> myk has joined #instantbird 17:29:00 <logiclord> clokep_work : "good first bugs" in instantbird bugzilla ?? why boring ? 17:29:23 <clokep_work> logiclord: They tend to be fairly trivial. But could get you around the codebase a bit. 17:30:06 <clokep_work> Ugh, actually the bugs listed in that are probably not great first bugs...so I'd just look for something that seems interesting. 17:31:22 <logiclord> clokep_work : so how do I pick some gud one after getting around codebase 17:32:07 <clokep_work> logiclord: "just look for something that seems interesting" ;) 17:32:14 <aleth> Heh, pdf.js has some pdf tabs titled [object Object] 17:32:26 <clokep_work> Seriously though, find something that'll hold your attention, make you feel like your accomplshing something YOU'D like to use. 17:32:34 <clokep_work> It's pretty awesome to have a feature that you wrote yourself. :) 17:32:41 <aleth> logiclord: Some annoying little problem that needs adressing maybe... 17:32:50 <clokep_work> aleth: File a bug? :P 17:32:51 <aleth> (annoying to you) 17:33:11 <logiclord> more then bugs I tend to have feature requests :D 17:33:19 <clokep_work> logiclord: You can ask if we think it'll be reasonable for someone who doesn't know the ins and outs of the code though...but we can always point you to the places you'll need to modify anyway... 17:33:34 <clokep_work> logiclord: When we say "bug" it encompasses "bugs" "issues" feeature requests, etc. etc. 17:33:34 <aleth> logiclord: Those are also listed as bugs, usually 17:33:50 <clokep_work> A "bug" is just a container that holds any sort of problem with the software, including unimplementing things. 17:34:03 <aleth> clokep_work: I have :P 17:34:56 <logiclord> okay I will select interesting bugs and ask a suggestion as clokep_work mentioned 17:35:22 <logiclord> although sometimes I tend to mess with ugly ones 17:36:14 <clokep_work> Then feel free to grab those too! :P 17:36:26 <clokep_work> We're pretty easy to work with I think. 17:37:44 <aleth> For example one recent request by deOmega was session restore 17:38:10 <clokep_work> Or get rid of the log viewer and let you scroll back through conversations. ;) 17:38:16 <logiclord> aleth : like firefox ? 17:38:31 <aleth> clokep_work: just a little project there... 17:38:46 <logiclord> session restore seems interesting :) 17:38:51 <aleth> logiclord: bug 307 17:38:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=307 enh, --, ---, nobody, NEW, Restoring session after restart 17:40:23 <clokep_work> Wow that has a lot of duplicates. 17:40:40 <clokep_work> Could definitely be done in stages too (first, restore the state of accounts & conversation, then handle adding the history back, etc.) 17:41:23 <aleth> You'd have to look at how it intersects with the IRC auto-reconnect/auto-join issue as well 17:42:04 <logiclord> aleth : This will also help me in case of IRC 17:42:28 <aleth> Also possibly related, bug 958, which can be done independently and is 1.2-wanted 17:42:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, nobody, NEW, Show last messages (history) in new chat windows 17:42:32 <clokep_work> aleth: Thta's not specific to IRC at all. 17:42:39 --> BYK has joined #instantbird 17:42:44 <logiclord> just a clarification 17:42:51 <aleth> clokep_work: I didn't mean to suggest it was 17:43:07 <clokep_work> Sounded like it. :) 17:43:17 <logiclord> we expect IB to restore all all active chat windows/history in windows 17:43:22 <aleth> That wasn't my intention :-/ 17:43:36 <clokep_work> logiclord: Yes, something like that. 17:44:21 <clokep_work> flo: Does the rules.mk in the addons repo work with locales? I tried it and it seemed to jar them up but not include them in the XPI. :( 17:44:37 <aleth> logiclord: Anyway, pick your own place to start digging around! :) 17:44:54 <logiclord> I have some questions now 17:45:03 <logiclord> what about addons ?? 17:45:14 <clokep_work> What about them? 17:45:14 <logiclord> they may also expect similar restore behaviour ? 17:45:25 <clokep_work> What do you mean? 17:45:33 <logiclord> like something may be going on ? 17:45:53 <clokep_work> I'm not sure what you mean, can you give me a concrete example that oyu think might be occurring? 17:46:11 <clokep_work> aleth: Did we ever file a bug about the mintrayr code doing the funky thing w/ appearing in front of the options window when you toggle settings? 17:46:43 <aleth> clokep_work: No, it's only mentioned in a comment 17:47:15 <clokep_work> :-/ We should probably file that at some point. 17:47:16 <aleth> I can file a bug for it if you like 17:47:23 <clokep_work> Is the comment in a closed bug too? 17:47:31 <logiclord> okay leave addons 17:47:32 <aleth> Yes, so it's a good idea to file it 17:47:47 <logiclord> which part of code manage active chats ?? 17:47:53 <clokep_work> aleth: Yes, if you don't mind. :) I'd file it...but not really sureabout the specifics. 17:48:21 <clokep_work> logiclord: It's handle by the conversations service I think... (interface @ http://lxr.instantbird.org/instantbird/source/chat/components/public/imIConversationsService.idl) 17:49:46 <aleth> logiclord: Though it depends what you mean by "manage" 17:50:42 <aleth> Could you be more specific? 17:51:09 <logiclord> aleth : How do I get list of current sessions going on 17:51:10 <logiclord> e.g. 17:51:20 <logiclord> If i am using irc on 5 channels 17:51:28 <logiclord> gtalk on by 2 ids 17:51:35 <logiclord> yahoo by 1 17:52:03 <clokep_work> Well accoutns handled by the core service and conversations by the conversation service...I think... 17:52:10 <clokep_work> (Unless there's an accounts service too) 17:52:25 <clokep_work> Bah there is. :( 17:52:33 <logiclord> clokep_work: which accounts have those kind of service ? 17:52:58 <clokep_work> Uhh...the "Accounts Service" is part of instantbird which keeps track of all of your accounts and lets you access them, etc. 17:53:51 <-- myk has quit (Quit: Instantbird -- http://www.instantbird.com) 17:54:00 --> myk has joined #instantbird 17:54:21 <logiclord> so we can use Accounts Service and I expect it to have active chats ? 17:55:06 <clokep_work> logiclord: http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccountsService.idl#68 17:55:27 * clokep_work wonders if any of this stuff needs to be documented on MDN... 17:55:44 <aleth> You can also look at the list of conversations from the conversations service and then get the account for each one 17:57:17 <logiclord> okay I will first have a look at both these service 17:57:54 <aleth> Or you could look at conversation.xml and work back from there 17:58:17 <logiclord> conversation.xml save current conversations ? 17:58:41 <aleth> conversation.xml is the conversation binding 17:58:49 <aleth> There is one for each open conversation 17:59:15 <aleth> It's an XBL, contains the UI elements of the conversation etc 17:59:31 <logiclord> that's good 18:00:45 <aleth> You have seen lxr I guess? 18:01:00 <logiclord> yes 18:01:04 <aleth> OK. 18:03:21 --> Mic has joined #instantbird 18:03:21 * ChanServ sets mode +h Mic 18:03:25 <clokep_work> Hmmm...seems like the session restore code is browser only though. :-S 18:03:55 <logiclord> clokep_work: no harm in trying 18:04:25 <clokep_work> Mmhmm. I just don't know if we build that code or not. ;) 18:18:42 <clokep_work> Bah I wish I enjoyed doing CSS...I'd really like to update the look of received message tabs. :( 18:21:18 <Mic> clokep_work: what do you mean with "received message tabs"? 18:21:44 <clokep_work> The tabs of conversations when you've received messages? 18:21:48 <clokep_work> The titles go red or blue. 18:21:54 <clokep_work> And look all 90s. ;) 18:23:00 <Mic> Ah, yes, this bug. 18:23:14 <Mic> What do you have in mind, maybe I can give you a pointer? 18:23:26 <clokep_work> What it says in the bug. :P 18:23:38 <clokep_work> I'm just too lazy to afctually play with it and make it the way I'd like it to be. 18:23:59 <clokep_work> (Plus color discussions lead to a lot of bikeshedding ;)) 18:24:15 <clokep_work> (But pretty much I'd rather highlight the tab itself...blue or orange or whatever...) 18:24:26 <clokep_work> MAybe have it pulse or something when someone is typing, but that might be obnxious. 18:25:16 <Mic> You don't happen to remember the bug's number? 18:26:48 <-- logiclord has left #instantbird () 18:27:04 <clokep_work> It's one I filed. :P 18:27:05 <clokep_work> One sec 18:27:31 <clokep_work> bug 800 18:27:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=800 enh, --, ---, nobody, NEW, Tab style for message notifications could be better. 18:27:35 <Mic> I tried four or five different search terms and none was correct :S 18:27:38 <Mic> Thanks :) 18:33:49 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 18:33:59 --> Mic has joined #instantbird 18:33:59 * ChanServ sets mode +h Mic 18:39:07 <-- BYK has quit (Quit: Instantbird -- http://www.instantbird.com) 18:39:31 --> BYK has joined #instantbird 18:46:55 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 18:47:11 --> Mic has joined #instantbird 18:47:11 * ChanServ sets mode +h Mic 18:51:22 <Mic> clokep_work: something to play with: http://pastebin.instantbird.com/25964 (for your userChrome.css) 18:51:57 <Mic> Unread is blue, attention is red/orande. The gradient is taken from Firefox' app-tabs. 18:52:32 <Mic> Typing should be green, I only changed the color and haven't tested it. 18:55:22 <-- aleth has quit (Input/output error) 18:55:33 --> aleth has joined #instantbird 18:55:33 * ChanServ sets mode +h aleth 18:56:01 <clokep_work> Mic: Sweet, thanks. :) 18:56:11 <clokep_work> I couldn't even find that CSS (from Firefox) las time I looked.. 18:56:37 <clokep_work> Is attention == a ping in a MUC? 18:56:47 <clokep_work> And unread == a chat message || any message in a MUC? 18:57:33 <aleth> +1 for a nicer design for that :) 18:58:25 <Mic> clokep_work: yes to both 19:00:41 <clokep_work> That's gross. :( 19:00:50 <Mic> It doesn't look good when the highlighted tab is of the active/visible conversation but it's rather intended to explore the look 19:01:57 * aleth adds Mic's userChrome to see what it's like 19:03:03 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 19:03:18 --> Mic has joined #instantbird 19:03:19 * ChanServ sets mode +h Mic 19:04:21 --> chrisccoulson has joined #instantbird 19:08:44 <Mic> 21:07:03 - Mic: Who am I? 19:08:44 <Mic> 21:07:07 - instantbot: Sorry, I've no idea who you are. 19:08:44 <Mic> 21:07:08 - instantbot: firebot knew: you are Michal (Mic) Berman <mic@mozilla.com>, MoCo l10n/distributions co-ordinator 19:08:51 <Mic> Ah, good to know :D 19:11:21 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 19:11:36 <aleth> Hmm, it could be a little more subtle ;) 19:11:43 --> Mic has joined #instantbird 19:11:44 * ChanServ sets mode +h Mic 19:16:34 --> gerard-majax has joined #instantbird 19:24:18 <-- sonny has quit (Quit: Instantbird -- http://www.instantbird.com) 19:25:14 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 19:27:58 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 19:28:03 --> aleth has joined #instantbird 19:28:03 * ChanServ sets mode +h aleth 19:28:59 <-- clokep_work has quit (Quit: Bye!) 19:29:14 --> Mic has joined #instantbird 19:29:14 * ChanServ sets mode +h Mic 19:29:18 <-- Mic has quit (Quit: Mic) 19:29:50 --> Mic has joined #instantbird 19:29:50 * ChanServ sets mode +h Mic 19:31:36 <-- Mic has quit (Input/output error) 19:36:10 --> Mic has joined #instantbird 19:36:10 * ChanServ sets mode +h Mic 19:53:06 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 19:53:11 --> aleth has joined #instantbird 19:53:11 * ChanServ sets mode +h aleth 20:12:59 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 20:14:30 --> clokep has joined #instantbird 20:14:30 * ChanServ sets mode +o clokep 20:15:00 <-- clokep has quit (Input/output error) 20:16:14 --> clokep has joined #instantbird 20:16:15 * ChanServ sets mode +o clokep 20:24:24 <-- mmkmou has quit (Ping timeout) 20:27:51 <clokep> instantbot: Hello. :) 20:27:52 <instantbot> clokep 20:32:42 --> flo has joined #instantbird 20:32:42 * ChanServ sets mode +qo flo flo 20:34:25 <instantbot> New Instantbird (UI) bug 1364 filed by aletheia2@fastmail.fm. 20:34:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1364 min, --, ---, nobody, NEW, Deselecting "Always show tray icon" in Preferences brings Contact list to front 20:38:19 <instantbot> aletheia2@fastmail.fm cleared the Resolution 'WORKSFORME' from bug 1142. 20:38:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1142 min, --, 1.2, nobody, UNCO, Minimizing Contacts window instead of focusing it on single click 20:38:50 <aleth> Uh, didn't mean to clear that 20:39:21 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1142 to WORKSFORME. 20:41:28 --> Mic has joined #instantbird 20:41:28 * ChanServ sets mode +h Mic 20:41:42 <flo> Mic: firebot has a good memory :) 20:43:55 <-- aleth has quit (Input/output error) 20:44:01 --> aleth has joined #instantbird 20:44:01 * ChanServ sets mode +h aleth 20:55:54 <instantbot> New Core - IRC bug 1365 filed by benediktp@ymail.com. 20:55:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1365 nor, --, ---, nobody, NEW, Placeholder icon shown inconsistently for private conversations on IRC 20:56:58 <Mic> aleth: the highlight-styles could certainly use tweaking ;) 20:59:16 <instantbot> New Core - IRC bug 1366 filed by aletheia2@fastmail.fm. 20:59:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1366 nor, --, ---, nobody, NEW, Inform the user when attempting to send a message to an offline nick 21:00:03 <clokep> flo: Is there anyway to actually like print something out while running an xpcshell test? 21:00:31 <flo> dump doesn't work? 21:00:39 <flo> ah, xpcshell 21:00:41 <flo> print() I think 21:00:41 * bear is now known as bear-afk 21:01:39 <clokep> Hmm...OK. 21:03:25 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 21:03:30 --> aleth has joined #instantbird 21:03:30 * ChanServ sets mode +h aleth 21:03:44 <clokep> Yeah that works I think. 21:04:24 <aleth> Mic: I like the idea of coloring the tab though! 21:06:09 <clokep> aleth: My idea! :P 21:06:19 <clokep> flo: Well my tests made me find another edge case. :) 21:07:19 <flo> wasn't bug 1366 already filed? 21:07:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1366 nor, --, ---, nobody, NEW, Inform the user when attempting to send a message to an offline nick 21:08:38 <aleth> flo: I could only find a bug for sending to an offline account 21:09:05 <flo> ok 21:09:13 <aleth> But I may have missed one somewhere... 21:09:25 <flo> I must admit I'm more interested in that getting fixed than in knowing how many bugs we have filed on it :) 21:09:43 <aleth> Yes :) It's more tricky than it looks at first. 21:10:04 <flo> I know 21:10:27 <flo> if it was easy, I would have fixed it right away when I spent time answering a student's question and he was actually offline 21:12:10 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 21:12:21 --> Mic has joined #instantbird 21:12:21 * ChanServ sets mode +h Mic 21:15:02 <Mic> instantbot: ping 21:15:03 <instantbot> Mic: pong 21:20:42 --> Kaishi has joined #instantbird 21:25:38 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1315 on bug 1346. 21:25:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 21:26:02 * clokep can't wait till that bug is fixed. 21:30:59 <Mic> <insert clokeq-joke here>? ;) 21:31:17 <clokep> :P 21:31:28 <clokep> It's been much more of a headache than I thought it'd be... 21:31:43 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 21:31:45 --> clokep has joined #instantbird 21:31:45 * ChanServ sets mode +o clokep 21:32:08 * clokep needed to disable Vertical Tabs to see what Mic's userChrome hack actually looked like... 21:32:55 <Mic> I thought you already saw and judged it as "gross"? 21:32:55 <-- BYK has quit (Ping timeout) 21:33:46 <clokep> It looks a lot better without the vertical tabs actually. 21:33:48 <clokep> I like it. 21:33:51 <clokep> NEeds a little tweaking.. 21:33:55 <clokep> But overall pretty good. 21:33:56 <clokep> :P 21:35:16 <aleth> clokep: Out of interest, what was the edge case that broke the regex I suggested? 21:35:33 <clokep> aleth: It wasn't an edge case, it just didn't do what I wanted. 21:35:38 <clokep> Which is 009 --> 010. 21:35:49 <aleth> Ah, I see 21:36:15 <clokep> So yours would have worked and given 0010. 21:36:19 <aleth> bond007 thanks you on his 3rd promotion ;) 21:36:21 <clokep> Which is fine...but not what I wanted. :-D 21:36:33 --> BYK has joined #instantbird 21:38:02 * Mic is now known as Mic2 21:38:16 * Mic2 is now known as Mic 21:38:50 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 21:38:56 --> Mic has joined #instantbird 21:38:56 * ChanServ sets mode +h Mic 21:42:08 <-- myk has quit (Input/output error) 21:42:08 <-- wesj has quit (Input/output error) 21:42:09 --> myk has joined #instantbird 21:42:10 --> wesj has joined #instantbird 21:52:43 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird.org for attachment 1315 on bug 1346. 21:52:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 22:01:18 <-- chrisccoulson has quit (Ping timeout) 22:08:22 --> myl has joined #instantbird 22:08:30 <-- myk has quit (Ping timeout) 22:13:40 <flo> clokep: what happens if the nick was already at maxNicknameLength and composed only of the 9 character? 22:13:54 <clokep> What do you mean? 22:14:19 <clokep> You mean if the nick is abcdefghi? (which is nine chars) 22:14:44 <clokep> Then you end up with abcdefgh1 22:15:26 <flo> you seem to be assuming the format is abcd1234, so that if when adding one to the 1234 part the length is too long, you can save a character by removing the letter "d" 22:15:51 <clokep> No I'm not. 22:15:58 <aleth> flo: I thought nicks couldn't start with a number? 22:16:01 <flo> I'm asking what happens if the current nick is 99999...9 (maxNicknameLength times the 9 character) 22:16:13 <clokep> Then you're screwed. 22:16:50 <flo> :-D 22:17:11 <aleth> You can't set your nick to 999999... 22:17:26 * myl is now known as myk 22:17:27 <clokep> aleth: Is right: nickname = ( letter / special ) *8( letter / digit / special / "-" ) 22:17:44 <clokep> But if you do a99999999, we'll then try to set it to 100000000 22:17:52 <clokep> (assume those have the proper #s of 9s and 0s please :)) 22:17:59 <aleth> yeah, that's not so good :9 22:18:11 <flo> sure, they do have the proper number of 9s and 0s! 22:18:16 <clokep> :) 22:19:05 <clokep> flo: What would you like to do in that case? :P 22:19:47 <clokep> Keep the a and kill a 0 instead? 22:21:12 <aleth> a-99999999 :P 22:21:13 <flo> clokep: I think would kill the 1 22:21:41 <aleth> I agree, go back to zeros 22:21:44 <flo> clokep: but I was more trying to check that I understood the code correctly than saying you should handle that stupid case 22:21:57 <flo> it won't happen anyway 22:22:13 <aleth> What is a typical maxlength? 22:22:23 <clokep> moznet is 30. 22:22:26 <clokep> 9 is in the RFC. 22:22:36 <clokep> flo: Well...I accounted for it and added a test, do you want an updated patch? :P 22:22:51 <flo> an updated patch for what? 22:23:07 <flo> I have a few nits so yes, I'll want an updated patch 22:23:11 <clokep> Alright. 22:28:26 <flo> done 22:28:40 <flo> were you saying you have an updated patch that also handles that stupid edge case? 22:28:49 <clokep> Yes. 22:29:42 <flo> I assume your test all pass? :) 22:29:47 <flo> *tests 22:31:24 <clokep> Yes. 22:31:33 <clokep> And I added one more (a9999... which goes to a0000) 22:35:59 <Mic> flo: --len and len-- do the same as last argument in a for-loop, btw 22:36:24 <flo> Mic: that's why it's only a coding style nit 22:37:44 <clokep> flo: Ah, sorry I missed a dump statement. :( Thought I removed them all... 22:38:21 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 22:38:27 --> aleth has joined #instantbird 22:38:27 * ChanServ sets mode +h aleth 22:38:49 <flo> Mic: --a is |a = a - 1; return a;| and a-- is |var rv = a; a = a - 1; return rv;| Doing --a saves a temporary variable. But I seriously hope all compilers optimize out that temporary value if the resulting value isn't going to be used, so at this point it's only a coding style thing. 22:40:53 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1315 on bug 1346. 22:40:54 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1316 on bug 1346. 22:40:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 22:42:58 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 22:43:02 --> aleth has joined #instantbird 22:43:02 * ChanServ sets mode +h aleth 22:45:01 <clokep> Lots of bugs fixed in the past 24 hours. ;) 22:45:15 <flo> https://bugzilla.instantbird.org/attachment.cgi?id=1311 is a very nice improvement, but is quite unrelated to the bug where it's attached 22:45:21 <flo> that wouldn't be blocking 1.2 22:45:22 <Kaishi> does that mean I should upgrade my build now or after the next compile? 22:46:17 <aleth> flo: It's from before the origin of that bug was known. 22:46:32 <aleth> Along the way of narrowing things down... 22:47:32 <flo> aleth: that's not what the history in the bug seems to indicate, nor what I remember 22:48:08 <flo> aleth: but maybe you had already decided to do that fix in your head while trying to figure out this :) 22:48:11 <aleth> flo: You can't see it in the bug history, it's just the sequence in which I did things... 22:48:41 <clokep> flo: I had talked to aleth about doing that at one point. 22:48:45 <clokep> We just never wrote a patch for it. 22:49:15 <clokep> (Also the nicks patch just messed me up on that one...I wanted to do flo: aleth and I...but it did flo, aleth and I...) 22:49:16 <flo> aleth: by the way, won't that patch cause double notifications in some cases? 22:51:03 <flo> aleth: if I join a channel but was already marked as online? 22:52:07 <aleth> Does a notification get sent if the status doesn't change? 22:52:19 <flo> ah, it seems http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#299 is smart enough to remove them 22:52:30 <flo> ok, never mind :) 22:52:32 <aleth> I should have checked that, thanks. 22:54:03 <-- BYK has quit (Client exited) 22:54:45 <flo> aleth: arg, I've commited https://bugzilla.instantbird.org/attachment.cgi?id=1310 with r=fqueze in the commit message instead of r=aleth. Should I try to fix it or will you forgive me? :-/ 22:55:05 <aleth> Don't worry about it :) 22:55:28 <clokep> flo: Now you just get the blame if I messed the patch up. ;) 22:55:46 <flo> clokep: although you set the flag yourself in the bug :-P 22:56:39 <flo> +Components.utils.import("resource:///modules/Services.jsm"); is wrong :( 22:56:54 <aleth> clokep: We should keep rough track of when the tab complete patches help/hinder us, so we can decide what to keep/modify/ditch in a few weeks. 22:57:56 <clokep> It passed. :( 22:58:56 <flo> clokep: because you aren't using xulrunner 22:59:04 <clokep> Ah, OK...I fixed it though. 22:59:11 <clokep> (Just needed the gre.) 22:59:17 <flo> yep :) 22:59:31 <clokep> I didn't realize that was why you needed that actually. 23:00:18 <flo> I wondered if you were going to think about the gre. I pondered saying "the version from gre" instead of "the platform" in my comment 23:00:39 <clokep> I thought about it...then forgot when I wrote the code. :-D 23:00:54 <clokep> I fixed it and can pastebin a new one if that's the only issue you see. 23:01:05 <clokep> (Or I can attach a new one too if you'd like.) 23:01:07 <flo> looks great otherwise 23:01:31 <flo> ok attach it :) 23:01:53 <flo> it will save a confusing comment in the bug 23:02:21 <-- aleth has quit (Input/output error) 23:02:27 --> aleth has joined #instantbird 23:02:27 * ChanServ sets mode +h aleth 23:02:32 <clokep> Yup, fair enough. 23:03:41 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 23:03:46 --> aleth has joined #instantbird 23:03:46 * ChanServ sets mode +h aleth 23:05:39 <flo> anything to reply to https://twitter.com/darrencoen/status/188401790209888257 ? 23:06:31 <flo> Does the patch in bug 1321 means the tab title will flicker? 23:06:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1321 min, --, ---, aletheia2, ASSI, Display name is lower case for IRC DMs 23:06:53 <clokep> flo: Theoretically it might. 23:06:56 <clokep> I didn't see it while testing. 23:07:26 <flo> it seems strange to have to request it when the info is likely already somewhere (to display it in the nicklist) 23:07:45 <aleth> If it's already somewhere, you won't see it change. 23:07:52 <clokep> aleth: Not true. 23:08:03 <clokep> flo: You might not have it if you do /msg blah. 23:08:17 <clokep> aleth: We could check all the participants of all the conversations for that nick first. 23:08:21 <aleth> Oh, I see, you mean the nicklist of a chat. 23:08:26 <flo> clokep: but if I double click on a participant 23:09:04 <clokep> flo: Then it should have it automatically. 23:09:18 <flo> "it should" = with that patch? 23:09:57 <clokep> Yes, it won't flicker. 23:10:04 <clokep> It'll just request the info and set it to the same thing == no flicker. 23:10:26 <instantbot> florian@instantbird.org granted review for attachment 1317 on bug 1346. 23:10:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 23:11:06 <clokep> flo: If you'd like, I can look at that patch again soon. 23:11:08 <aleth> We could store the properly capitalized nicks in participant lists in the whois table too (as entries just consisting of nicks), that would potentially stop even more cases from noticeable changes. 23:11:29 <aleth> That would do no harm as any whois request will always update the info anyway. 23:11:43 --> mmkmou has joined #instantbird 23:12:11 <clokep> Yes, that could work. 23:12:29 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 1316 on bug 1346. 23:12:33 <aleth> I could add that... 23:12:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, clokep, ASSI, Replace alphabetic increment of last letter on nick collision 23:13:10 <flo> if they are currently not in the whois table, it may be worth adding them 23:15:50 <flo> is it a one or two lines change, or does it need some more thoughts? 23:16:16 <aleth> It should be an easy addition, but I'll have to look and see exactly where 23:16:57 <aleth> Could be done as a follow-up, or r- what is there. 23:21:25 <Mic> Good night 23:21:28 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 23:22:21 <flo> ok, r- 23:22:28 <instantbot> florian@instantbird.org denied review for attachment 1303 on bug 1321. 23:22:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1321 min, --, ---, aletheia2, ASSI, Display name is lower case for IRC DMs 23:22:42 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7d7de5899d69 - Patrick Cloke - Bug 1346 - Replace alphabetic increment of last letter on nick collision, r=aleth,fqueze. 23:22:43 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b1cea431c4a4 - Patrick Cloke - Bug 1303 - IRC contacts don't get their status updated when no IRC contact is online, r=fqueze. 23:22:44 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9d673c16ad45 - Benedikt Pfeifer - Bug 1360 - Contact list position on new profile wrong when Windows user has taskbar on top of the screen, r=fqueze. 23:22:45 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/54fccd250e03 - aleth - Bug 1303 - Update the status of IRC contacts immediately when we know they they joined or leaved a channel where we are, r=clokep. 23:24:03 <flo> Good night :) 23:30:25 <instantbot> clokep@gmail.com set the Resolution field on bug 1360 to FIXED. 23:30:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1360 min, --, 1.2, benediktp, RESO FIXED, Contact list position on new profile wrong when Windows user has taskbar on top of the screen 23:32:06 <instantbot> clokep@gmail.com set the Resolution field on bug 1303 to FIXED. 23:32:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1303 nor, --, 1.2, clokep, RESO FIXED, IRC contacts don't get their status updated 23:33:08 <instantbot> clokep@gmail.com set the Resolution field on bug 1346 to FIXED. 23:33:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, 1.2, clokep, RESO FIXED, Replace alphabetic increment of last letter on nick collision 23:35:26 <clokep> Bleh still a lot more to fix... 23:38:28 <clokep> aleth: I think it's reasonable to add entries to the whois table whenever we know information, so we'll have one datastore with the most up to date nick information. 23:42:23 <-- flo has quit (Ping timeout) 23:42:31 <aleth> Yes, it makes sense to use that. 23:42:44 <clokep> :) 23:42:58 * clokep just deleted ~10 patches sitting in his repo's root. 23:43:17 <aleth> Especially as we've been writing it to always request and complete it with new info when accessed :) 23:43:45 <clokep> Yup! :) 23:43:58 <aleth> But that's a good bunch of related bugs fixed now :) 23:45:02 <clokep> Yup! :) The nick thing should make jb happy. ;) 23:45:21 <clokep> Sorry that turned into such a confusing thing! 23:45:41 * clokep hates these things that seem trivial and have lots of edges. :( 23:46:03 <aleth> Yeah, it's annoying when that happens and your 5-minute fix stretches over days :-/ 23:49:06 <clokep> Bleh...I have a directory of docs on IRC? It now has 67 files in it. :( 23:49:28 <clokep> And a scary percentage of them start with "draft" ;) 23:51:29 <aleth> Do they contradict each other? :-/ 23:51:47 <clokep> Have you not seen my rant on IRC specifications? ;) 23:52:28 <clokep> (http://clokep.blogspot.com/2011/03/so-called-irc-specifications.html) 23:53:31 <aleth> uh. 23:54:01 <clokep> Short story: Yes, they contradict each other. Yes, they're partially implemented by different servers, clients. Yes, it sucks. 23:54:29 <instant-buildbot> build #239 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/239 23:54:51 <aleth> It's ... baroque. 23:55:06 <clokep> Anyway, time for me to go! Goodnight everyone. :) 23:55:17 <aleth> good night :0 23:55:19 <aleth> :)