#instantbird log on 04 03 2012

All times are UTC.

00:02:31 <instant-buildbot> build #236 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/236
00:18:39 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
00:22:49 <-- aleth has quit (Input/output error)
01:08:38 <-- myk has quit (Ping timeout)
01:23:45 --> deOmega1 has joined #instantbird
01:24:01 <deOmega1> hello
01:25:54 <instant-buildbot> build #204 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/204
01:26:04 <deOmega1> I find this to be an interesting read.  Wonder what you guys think and what are the likely plans to keep things in your favor:  http://forums.miranda-im.org/showthread.php?27370-Is-Miranda-losing-popularity
01:30:26 <-- Mook_as has quit (Quit: gone)
01:35:23 <instant-buildbot> build #225 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/225
01:35:42 <-- deOmega1 has quit (Quit: Instantbird -- http://www.instantbird.com)
02:04:02 --> Mautematico has joined #instantbird
03:01:56 <-- Mautematico has quit (Quit: Instantbird 1.1)
03:10:56 <instant-buildbot> build #450 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/450
03:22:52 <-- sonny has quit (Client exited)
03:57:17 --> NmN has joined #instantbird
04:01:27 <-- NmN has quit (Quit: Instantbird 1.1)
04:27:58 <instant-buildbot> build #534 of win32-nightly-default is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/534
04:54:57 --> logiclord has joined #instantbird
04:56:56 --> pvagner has joined #instantbird
04:59:09 <-- logiclord has left #instantbird ()
05:38:29 <-- EionRobb has quit (Quit: Leaving.)
06:02:22 <instant-buildbot> build #438 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/438
06:04:19 --> FeuerFliege has joined #instantbird
06:08:37 <-- pvagner has quit (Connection reset by peer)
06:49:08 <-- Kaishi has quit (Quit: Kaishi)
07:03:51 --> pvagner has joined #instantbird
07:28:33 --> jb has joined #instantbird
08:02:18 --> Eveo has joined #instantbird
08:52:44 --> mmkmou has joined #instantbird
09:01:02 <-- gerard-majax has quit (Ping timeout)
09:01:07 --> flo has joined #instantbird
09:01:08 * ChanServ sets mode +qo flo flo 
09:01:50 <flo> hello :)
09:33:21 --> gerard-majax has joined #instantbird
10:06:56 * flo wonders if clokep has something interesting to say in https://bugzilla.mozilla.org/show_bug.cgi?id=741561 (a complaint about poor error messages for JS-IRC connection failures)
10:09:43 <-- mmkmou has quit (Ping timeout)
10:12:13 --> NmN has joined #instantbird
10:16:06 --> clokep has joined #instantbird
10:16:06 * ChanServ sets mode +o clokep 
10:16:06 --> mmkmou has joined #instantbird
10:17:19 <clokep> flo: Interesting? Perhaps. PG...probably not. ;)
10:18:03 --> aleth has joined #instantbird
10:18:03 * ChanServ sets mode +h aleth 
10:18:58 <clokep> Sure we could use some more error handling code.
10:19:13 <clokep> But it's not quite as easy as he makes it seem.
10:22:06 <-- mmkmou has quit (Ping timeout)
10:27:44 --> NmN1 has joined #instantbird
10:28:11 <flo> "PG" sounds like something for the Pidgin channel
10:28:23 <flo> it took me years to understand what that meant in the topic of their channel :-D
10:28:26 <-- NmN has quit (Ping timeout)
10:29:19 <clokep> Hah, right. I guess internationally there's a different rating system.
10:32:30 <clokep> Did that conversation continue at all last night after I left in #maildev?
10:45:01 <flo> I don't know
10:45:41 <flo> no, it hasn't continued
10:46:15 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com)
10:46:25 --> aleth has joined #instantbird
10:46:26 * ChanServ sets mode +h aleth 
10:47:16 <flo> clokep: "Hah, right. I guess internationally there's a different rating system." I'm not sure if there's a standardized international system. In France there's just an age you need to at least have to be allowed to watch the movie.
10:50:04 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
10:53:40 <aleth> I doubt there could be anything standardized as the criteria vary as well from country to country...
10:54:08 --> NmN has joined #instantbird
10:54:13 <-- NmN1 has quit (Ping timeout)
11:00:19 <-- NmN has quit (Connection reset by peer)
11:00:23 --> NmN has joined #instantbird
11:02:49 <-- GeekShadow has quit (Ping timeout)
11:07:01 --> GeekShadow has joined #instantbird
11:17:55 <-- NmN has quit (Ping timeout)
11:18:14 --> NmN has joined #instantbird
11:19:39 <-- gerard-majax has quit (Ping timeout)
11:29:09 --> sonny has joined #instantbird
11:30:01 --> mmkmou has joined #instantbird
11:32:47 --> clokep_work has joined #instantbird
11:32:48 * ChanServ sets mode +o clokep_work 
11:43:39 <-- NmN has quit (Ping timeout)
11:44:33 --> ggx has joined #instantbird
11:51:16 <clokep_work> Yeah, well...I'll try to keep my comments child friendly. ;)
11:54:22 --> gerard-majax has joined #instantbird
11:57:22 <aleth> clokep_work: Just make your comments localizeable ;)
11:58:36 <clokep_work> flo: Not to be annoying, but is there anything further to do in aleth's /whois patch or did you just need to look over it one last time before checking it in?
11:59:23 <-- ggx has quit (Connection reset by peer)
11:59:41 <clokep_work> ("I haven't had time to look" is an acceptable answer! :))
12:00:25 <-- gerard-majax has quit (Ping timeout)
12:09:07 * clokep_work dislikes that bug about the switch statement.
12:10:21 --> gerard-majax has joined #instantbird
12:12:04 <instantbot> clokep@gmail.com set the Resolution field on bug 1298 to FIXED.
12:12:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1298 maj, --, 1.2, clokep, RESO FIXED, JS-IRC doesn't set the buddy attribute of private conversations
12:19:50 <flo> clokep_work: "I haven't had time to look" ;)
12:19:51 --> Tomek has joined #instantbird
12:20:12 <clokep_work> flo: OK! I'll keep bugging you periodically then. ;)
12:20:15 <flo> I can barely keep up with my bugmail flow these days :-/
12:20:29 <clokep_work> Understandable. :-/
12:20:36 <clokep_work> I have trouble w/ it now too.
12:22:14 <flo> and I'm more interested in the phone calls than in the bugmail these days :-S
12:22:33 <clokep_work> About "real life" things? ;)
12:22:52 <flo> yeah, about a specific place
12:26:09 <flo> clokep_work: you know why he added the scope blocks, right? :)
12:26:54 <clokep_work> I don't think they're really necessary when I looked briefly, but why?
12:33:08 <flo> so that the variables defined with let do not conflict if used in several different code blocks
12:33:52 <clokep_work> Ah. Right. Still looks bad though. :p
12:33:59 * clokep_work isn't sure if bug 1170 can be closed as not.
12:34:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1170 nor, --, ---, nobody, REOP, Auto-reply in IRC DMs when user status = away
12:39:33 <aleth> What code are you talking about?
12:39:53 <flo> clokep_work: if can only be closed if you file the opposite bug :-P
12:40:16 <clokep_work> Yeah...that's kind of what I thought. We could leave it as "The way we handle an IRC person being away sucks. :P"
12:40:18 <flo> displaying that auto-reply all the time was wrong; never displaying it is wrong too
12:40:18 <clokep_work> aleth: What?
12:40:44 <aleth> clokep_work: re the "scope blocks"?
12:41:06 <clokep_work> aleth: https://bugzilla.mozilla.org/show_bug.cgi?id=741072
12:41:39 <aleth> Ah, OK. I don't watch the TB bugs...
12:42:22 <aleth> clokep_work: Maybe retitle bug 1170 to something more actionable?
12:42:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1170 nor, --, ---, nobody, REOP, Auto-reply in IRC DMs when user status = away
12:42:58 --> jc has joined #instantbird
12:42:58 <flo> aleth: "I don't watch the TB bugs..." you are lucky :)
12:43:16 <-- jb has quit (Ping timeout)
12:43:47 <clokep_work> aleth: Maybe. I think I'll file the opposite. Just to "Keep It Clean".
12:44:08 <aleth> But then close the original one!
12:44:24 <flo> "I concern that it may be complexity. The best way I thought is restructure the part of making context menu for increasing flexibility and extension ability for add-on... But it's a pipe dream." uh :-S
12:44:52 <aleth> flo: TB bug filings sound like an avalanche of sorts atm ;)
12:46:48 <clokep_work> aleth: People are just saying crazy things in them. :(
12:46:56 <clokep_work> flo: Yes...I don't get that.
12:48:42 <aleth> That switch patch does seem an odd thing to choose to spend time on.
12:49:59 <instantbot> New Core - IRC bug 1358 filed by clokep@gmail.com.
12:50:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1358 nor, --, ---, nobody, NEW, IRC should notify of away message
12:50:29 <instantbot> clokep@gmail.com set the Resolution field on bug 1170 to INVALID.
12:50:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1170 nor, --, ---, nobody, RESO INVALID, Auto-reply in IRC DMs when user status = away
12:50:54 * clokep_work feels silly closing a bug and filing essentially the same bug. :(
12:51:17 <aleth> It makes sense, the previous discussion is obsolete.
12:51:48 <clokep_work> aleth: It's probably because someone said "Oh, this could be a switch statement! I can make that change without understanding any of the other code!" and went ahead and filed it. :-S
12:52:00 <clokep_work> A few bugs like that were filed by the same person at once.
12:52:08 <clokep_work> (e.g. the change to the Twitter URLs.)
12:59:43 <clokep_work> Part of the problem with that bug seems to be that he doesn't speak English very well too. :-/
13:01:01 <flo> I'm not really a fan of the context menu separator changes either ;)
13:02:11 <flo> clokep_work: "(and that I had discussed with Florian when initially reviewing this, I think)" have you reviewed that code?
13:05:51 <clokep_work> flo: I had looked over it when it was checked in (I don't think it was a formal review), but we were changing something related and I asked you about changing them to elseif.
13:08:28 <clokep_work> I can probably find the comment if you really want, but I think I have better uses for my time. ;)
13:08:46 <flo> don't bother :)
13:09:03 <flo> I was just checking that you weren't confusing this with the big IRC switch that was also discussed at some point :)
13:09:08 <clokep_work> I mean obviously I looked over the Ib version, but it's similar enough.
13:09:15 <clokep_work> Nope! Was code you wrote. :P
13:10:06 --> Kaishi has joined #instantbird
13:36:47 <-- pvagner has quit (Ping timeout)
13:58:00 --> waynenguyen has joined #instantbird
14:17:58 --> bear has joined #instantbird
14:42:04 <-- FeuerFliege has quit (Ping timeout)
15:06:30 <-- jc has quit (Connection reset by peer)
15:06:33 --> jc has joined #instantbird
15:46:19 <aleth> Didn't flo have a student working on session restore?
15:46:57 <flo> aleth: he didn't really "work" (and got a really poor grade :-P)
15:47:50 <aleth> No good news there for deOmega then...
15:59:32 --> myk has joined #instantbird
16:00:10 --> igorko has joined #instantbird
16:03:21 * jc is now known as jb
16:07:59 <-- wesj has quit (Input/output error)
16:08:03 --> wesj has joined #instantbird
16:08:11 <-- gerard-majax has quit (Ping timeout)
16:18:53 * bear is now known as bear-afk
16:27:26 --> gerard-majax has joined #instantbird
16:46:57 --> jc has joined #instantbird
16:47:14 <-- jb has quit (Ping timeout)
17:05:21 --> Mook_as has joined #instantbird
17:11:15 <-- gerard-majax has quit (Ping timeout)
17:18:43 <-- Tomek has quit (No route to host)
17:18:55 --> Tomek has joined #instantbird
17:27:27 * bear-afk is now known as bear
17:28:10 <bear> has someone from the instabird team joined the jdev@jabber.org mailing list?
17:28:48 <bear> I asked in that list about bug 735215 and they are responding that libpurple does support SRV and have questions about the js layer
17:29:40 <bear> who would I point some of the XMPP folks at to get some help for this - I feel this is a very solvable issue and I would really hate for instabird to deploy without core XMPP support
17:29:48 <flo> bear: Thunderbird doesn't use libpurple at all because it's GPLed
17:30:29 <flo> bear: Instantbird supports generic XMPP through libpurple
17:30:53 <-- jc has quit (Quit: jc)
17:31:04 <bear> so i'm in the wrong channel?
17:31:17 <flo> I've got to go, but feel free to ask questions here (I'll read the IRC log and others may have answers too :)).
17:32:26 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
17:33:39 --> Dagger has joined #instantbird
17:34:10 <Mook_as> fwiw, I think you're in the right channel
17:34:22 <Mook_as> and xmpp-in-chat-in-tbird is all JS.
17:34:35 <Mook_as> (no libpurple is involved, since it doesn't exist in chat-in-tbird)
17:34:53 <bear> thanks mook - i'm going to wander over to #maildev and ask some questions there
17:35:24 <Mook_as> sounds good. fwiw, flo is the main guy for all things chat-related :D
17:35:31 <bear> k
17:35:38 <Mook_as> (and instantbird-related)
17:35:46 <bear> I wonder if he has met/chatted with the buddycloud folk
17:35:55 <bear> they are also doing a client and server all in js for XMPP
17:38:58 <Mook_as> looking at the pretty picture on https://buddycloud.org/wiki/Developer_overview - they run a server somewhere? (the bottom right box)
17:41:27 <bear> it's a distributed system - but yes they do run a server
17:54:08 --> gerard-majax has joined #instantbird
17:56:17 <aleth> bear: JS-XMPP is already in TB (and IB), the problem is that SRV is not supported by mozilla yet (bug 14328)
17:56:38 <bear> ah
17:57:20 <bear> well that is much different (and sadder IMO)
17:57:24 <Mook_as> right, that's why gtalk works, IIRC (because it can be hard-coded, being well-known)
17:57:52 <aleth> You'll have to ask flo for the full story, but yes it is disappointing
17:58:00 <aleth> (as a patch exists)
17:58:08 <Mook_as> and sad was I had sample code to do a manual SRV query in JS, it just needed a DNS server... :p (I used google's I think)
18:05:03 <aleth> Bug 735215 :(
18:14:35 <clokep_work> bear: One second I'm catching up.
18:14:52 <bear> no worries :)
18:15:08 <clokep_work> So you can ask flo or me here or in #maildev (he's florian there).
18:15:16 <clokep_work> I prefer here since we log conversations and #maildev does not...
18:15:35 <bear> I just got a "tour" of the SRV DNS bug family
18:15:47 <bear> and realize why XMPP support is on hold
18:16:07 <clokep_work> Ah, OK. So you're kind of caught up then?
18:16:23 <clokep_work> So yes, Mozilla core doesn't support DNS SRV, so it's blocking us from really supporting generic XMPP.
18:16:30 <bear> yea - I came in thinking it was just a js issue and now realize you all are waiting on core moz changes
18:16:36 <clokep_work> Instantbird uses the libpurple jabber code to support XMPP, but Thunderbird can't use that.
18:16:47 <clokep_work> Yup.
18:16:53 <clokep_work> And I don't know what this jdev mailing list is...
18:17:07 <bear> jdev@jabber.org - it is the core xmpp dev support list
18:17:29 <bear> any question about xmpp will get fast answers there
18:17:36 <clokep_work> I see. Florian might be on it, I am not.
18:17:45 * bear is on the board for the XSF
18:17:53 <bear> so if you ever need an XMPP resource just let me know
18:18:56 <clokep_work> Thanks. :)
18:19:12 <clokep_work> I think our issue right now is political issues of getting DNS SRV support...
18:19:17 * bear nods
18:22:40 <clokep_work> Thanks for looking into it though. :) Have you tried out Instantbird / Thunderbird or how did you hear about the support for it?
18:25:57 <bear> I saw the yammer message about it
18:26:21 <bear> did not even *know* you guys were so close to having irc and xmpp support in tbird
18:26:42 <bear> so i'm running daily now - i just need to go get my one-time password for gtalk to sign on
18:29:33 --> Mnyromyr has joined #instantbird
18:30:03 <aleth> bear: Or use instantbird :)
18:30:19 <aleth> (if you don't want to use gtalk)
18:30:34 <bear> I already have 5 IM clients in various testing stages - adding more takes a lot of effort
18:30:41 <bear> but yea, I may just do that
18:31:25 <clokep_work> You can fairly easily get Instantbird or Thunderbird to enable generic XMPP anyway.
18:31:31 <clokep_work> YOu just need to change the component manifest I believe.
18:32:26 <-- Kaishi has quit (Quit: Kaishi)
18:33:08 <bear> later on I'll ask how to do that - right now i'm entering that phase of the day where west coast folks drag us east coast folks into meeting hell
18:35:29 <-- wesj has quit (Ping timeout)
18:35:32 <clokep_work> I'm entering that same part of the day... :(
18:40:34 <-- mmkmou has quit (Ping timeout)
18:41:33 --> Eveq has joined #instantbird
18:42:44 <-- Eveo has quit (Ping timeout)
18:46:45 --> flo has joined #instantbird
18:46:45 * ChanServ sets mode +qo flo flo 
18:48:50 <-- Eveq has quit (Quit: Instantbird -- http://www.instantbird.com)
18:53:00 --> Eveo has joined #instantbird
18:55:21 * flo thinks these east coast people complaining about meetings should just get people from Europe in their teams, to reduce the likelihood of having meetings at this time
18:59:23 <Mook_as> add in some asians and declare possible-meeting-time bankruptcy!
19:00:00 <bear> :)
19:06:49 <-- Eveo has quit (Quit: Instantbird -- http://www.instantbird.com)
19:08:00 <flo> bear: have you seen https://bugzilla.mozilla.org/show_bug.cgi?id=741550 in your tour of depressing bugs blocking generic XMPP support?
19:08:13 * bear looks
19:08:52 <-- GeekShadow has quit (Quit: leaving)
19:09:02 <bear> ugh
19:10:16 <flo> there's currently no (clean) way to connect necko to a host but expect a certificate for a different host
19:11:46 * jwir3 is now known as jwir3|lunch
19:12:03 <bear> yea, that is very common in SRV land
19:12:46 <aleth> I may be wrong but I think there was an IB bug for this too somewhere?
19:14:09 <aleth> bug 1115 ?
19:14:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1115 nor, --, ---, nobody, UNCO, SSL Handshake fails (-12276) on cert with CN and secondary entries
19:14:20 --> GeekShadow has joined #instantbird
19:15:24 <flo> aleth: I don't really know what that bug is about (otherwise it wouldn't be UNCONFIRMED I guess :))
19:15:38 <aleth> Hence the ? ;)
19:15:59 <aleth> Especially since that was with libpurple of course
19:22:34 <aleth> Is there a way to get the XBL bindings of the children of a node (or of a node) to reinitialize?
19:25:02 <aleth> (I.e. to (re)attach all the bindings to the elements)
19:25:13 <-- igorko has quit (Connection reset by peer)
19:25:20 <Mook_as> display:none and back, perhaps?
19:26:34 <aleth> Hmm, worth a try.
19:29:32 <aleth> Removing -moz-binding and then putting it back seems a bit hackish
19:31:15 <aleth> Mook_as: I don't think display:none will work as I've just discovered there is a related bug which is probably causing the issue I am trying to work around  in the first place :( bug 307098
19:33:54 * bear is now known as bear-afk
19:36:45 --> Mic has joined #instantbird
19:36:45 * ChanServ sets mode +h Mic 
19:37:10 <Mic> Hi
19:38:00 <aleth> Hi Mic
19:44:13 <clokep_work> aleth: Maybe describe what you're trying to do a bit more?
19:44:47 <aleth> clokep_work: Bug 1143 was annoying me again
19:44:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1143 nor, --, ---, nobody, NEW, New participants not correctly added to collapsed participant list
19:45:06 <aleth> I asked vaguely as I was interested in anything related that might help
19:45:14 <-- chrisccoulson has quit (Quit: Ex-Chat)
19:45:43 <Mook_as> yeah, I was attempting to intentionally invoke bug 307098 because that means toggling it back should cause the xbl to apply...
19:46:18 <Mook_as> (though I do like the "That's why we're working on introducing other binding methods" from 2005...)
19:46:55 --> chrisccoulson has joined #instantbird
19:47:11 <aleth> Mook_as: yes... I asked a different question about an XBL bug at one point and the response was along the lines of "this will be targeted in xbl 2" ;)
19:47:22 <Mook_as> hahahaha
19:48:10 <clokep_work> Someone actually posted about XBL 2 last week?
19:57:28 --> wesj has joined #instantbird
20:05:35 <-- wesj has quit (Input/output error)
20:06:28 --> wesj has joined #instantbird
20:10:50 <flo> I have some spare time now (say about an hour). Is there anything Instantbird-related that needs my attention this evening? (if nothing else, I think I'll look at that whois patch and the patch about pings/nick detection again)
20:11:25 <clokep_work> I'd love for the whois patch to be gandered at. :)
20:12:11 <clokep_work> And if you really run out of things to do...bug 1218 perhaps? :)
20:12:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1218 nor, --, ---, clokep, ASSI, Search API queries need some escaping
20:12:23 * aleth has a couple of things lined up to review... take your pick if you like
20:12:44 <flo> yeah, I know I have a long review queue
20:12:58 <aleth> The whois one is the most urgent as it blocks other things
20:13:01 <flo> I was more wondering if someone is really blocked/waiting by something :)
20:14:48 <clokep_work> Yeah, just that...and I think we've responded to all feedback for GSoC.
20:21:57 * bear-afk is now known as bear
20:22:34 --> EionRobb has joined #instantbird
20:23:19 <flo> uh, that whois patch already has r+ from me. Was there anything I needed to check? Or was it just a checkin-needed bug?
20:25:00 <flo> aleth: ^ ^
20:25:07 <clokep_work> flo: checkin needed I believe.
20:25:43 <aleth> flo: The only changes in the last revision were those you requested
20:26:30 * jwir3|lunch is now known as jwir3
20:26:36 <flo> ok
20:29:08 <-- clokep_work has quit (Quit: Bye!)
20:30:00 <flo> bitrotted :(
20:36:58 --> testib has joined #instantbird
20:39:54 <testib> aleth: are the spaces at the beginning of each line of the whois result really useful?
20:40:39 <aleth> flo: It looks strange without indentation from the timestamp. 
20:41:05 <aleth> Sadly, I know of no way to do a proper tabulator.
20:41:26 <testib> it looks strange with it too
20:41:34 <testib> (it = the indentation)
20:41:39 <aleth> It's definitely not perfect.
20:42:42 <aleth> Initially I had each line as a separate system message, but that's worse for other reasons.
20:43:26 <-- testib has quit (Quit: Instantbird -- http://www.instantbird.com)
20:44:05 --> testib has joined #instantbird
20:45:02 <testib> right, it doesn't look good either without the spaces
20:45:22 <aleth> At least with the spaces there is a clear grouping.
20:45:52 <aleth> But if you have a good idea for improving it that would be excellent
20:46:34 <testib> would it be better or worse if we underlined all the labels?
20:47:31 <aleth> Might make them look like links.
20:47:45 <aleth> But I didn't try that.
20:50:24 <flo> right. Ok, let's keep the spaces for now
20:51:05 <aleth> I would really have liked to set (two) tabulators, but I know no way of doing that.
20:54:03 <aleth> Maybe if "WHOIS info for xyz" was bold it would look more like a "title"?
20:55:29 <aleth> Probably doesn't make the indent look any better layouted though.
21:02:44 <flo> aleth: why "#Chat>#unread-ruler" in the css (bug 860)?
21:02:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations
21:02:56 <flo> are there cases where the ruler ends up in the middle of grouped messages?
21:03:24 <aleth> The CSS rule is like that so it overrides default rule the one from conv.css
21:03:31 <aleth> Is there a nicer way of doing that?
21:04:39 <flo> is conv.css applied before or after main.css?
21:04:53 <flo> why do you need this for Bubbles but not for Simple?
21:05:11 <aleth> I don't know, but I tried it without and had the problem.
21:05:17 <-- gerard-majax has quit (Connection reset by peer)
21:05:19 --> gerard-majax_ has joined #instantbird
21:05:22 <aleth> There is currently no styling other than default and the one for Bubbles.
21:06:01 --> clokep has joined #instantbird
21:06:01 * ChanServ sets mode +o clokep 
21:06:42 <flo> ah, I somehow read the rules in conv.css as being in simple; don't know why
21:06:55 <flo> I guess I should look at easier patches this evening :-|
21:07:06 <aleth> The other default styles could be improved in a followup.
21:07:33 <aleth> I was hoping the new 860 was actually clearer than the WIP ;)
21:08:03 <flo> that's possible. It's just my mind that isn't clearer ;)
21:11:18 <clokep> aleth: I also found the spaces funny in that patch but couldn't come up with a better idea as well. :(
21:11:50 <aleth> clokep: Yes :(
21:12:27 * gerard-majax_ is now known as gerard-majax
21:14:03 <flo> I'm wondering if bug 1329 could get in the way
21:14:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1329 nor, --, ---, nobody, NEW, Tab complete: prefer sender of the last ping
21:15:08 <aleth> It might. The problem is it didn't seem like sort of thing you can easily test though without using it for a while?
21:16:09 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:17:42 <aleth> I did that one in response to a request (I forget from whom), personally I could live without it.
21:19:28 <flo> that was from me
21:19:37 <flo> it's even possible I promised a quick review :-/
21:19:53 <aleth> Maybe put it in the nightly and we can try it for a week?
21:20:53 * clokep hates trying to recover files...
21:20:55 <aleth> I don't even think the other tab complete patch overlaps
21:21:46 <flo> I think I would use 3600 instead of 60 * 60
21:22:01 <flo> I think all readers know that 3600 = number of seconds per hour
21:22:30 <aleth> I thought if I put 3600 you might ask for a comment ;)
21:22:36 <flo> and could find some more nits, but they aren't really things I care about changing
21:22:47 <aleth> oh yeah!
21:22:55 <flo> aleth: I would have. But you already have the comment!
21:23:13 <aleth> Do I? Now that's excessive :D
21:23:34 <flo> :-D
21:26:18 <flo> shouldn't we s/lastping/lastPing/g?
21:26:30 <aleth> Also, it's hard to know whether an hour is too long.
21:26:46 <aleth> flo: yes, that would be better.
21:27:31 <aleth> And I just see a line from the other tab complete patch has crept in :-S
21:27:35 <flo> ah, so you wanted 60 minutes rather than an hour ;)
21:27:45 <flo> which one?
21:27:59 <aleth> let secondNick = false
21:28:40 <flo> ok, I was wondering what it was doing there, and then forgot it
21:28:48 <flo> probably not a great evening to do reviews :(
21:29:06 <aleth> Did you get the phonecall you were waiting for? 
21:29:47 <flo> I got lots of phonecalls in the last few days
21:30:18 <flo> and I'm finally going to go sign the contract to buy that house tomorrow evening
21:30:31 <aleth> oh, congratulations! :)
21:31:43 <flo> thanks
21:32:11 <clokep> Well if you need help running CAT-6 through it, I have experience. ;)
21:32:13 <flo> I just hope I won't have to regret it in the next few months :)
21:32:39 <flo> CAT-6?
21:33:04 <flo> wifi may be enough
21:33:37 <flo> and I think I'll need to setup a kitchen and a bathroom before the computer network :-D
21:35:37 <Mic> Good night
21:36:20 <flo> Mic: Good night! :)
21:36:24 <instantbot> florian@instantbird.org granted review for attachment 1237 on bug 1329.
21:36:25 * Mic is looking forward to see bug 860 fixed (and to try different styles;)
21:36:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1329 nor, --, ---, nobody, NEW, Tab complete: prefer sender of the last ping
21:36:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations
21:37:46 <clokep> flo: Yes, CAT-6. Gigabit LAN.
21:38:29 <flo> why would I need more than 100Mbps?
21:38:50 <Mic> Everyone needs as much bandwidth as possible.
21:38:51 <Mic> It is known.
21:38:58 <flo> I don't think my internet connection can get a faster than that
21:41:00 <flo> I just hope the website of the ISP that said that house can be connected to FFTH wasn't bogus :)
21:42:00 <aleth> Apparently factors like distance from your nearest node matter too and are hard to predict in advance
21:43:46 <aleth> Maybe not so much for FFTH? 
21:44:22 <flo> well, I'm not sure if that ISP is actually offering FFT*H* or fiber to whatever else
21:46:58 <-- clokep has quit (Input/output error)
21:53:50 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
21:55:47 <flo> the patch in bug 1330 isn't using the approach I would have used if I wanted to implement this feature
21:55:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1330 nor, --, ---, nobody, NEW, Tab complete: Be smart about multiple completions
21:56:46 <aleth> How would you have done it?
21:57:01 <flo> I think I would have saved the last text inserted by the completion, and then only changed the ": " to ", " if it still matched at the time of pressing tab again.
21:57:30 <flo> not sure yet which approach would work better :)
21:58:22 <flo> the down side of my approach is that it would match nicks that have been fully typed by hand. The up side is that false positives are impossible.
21:59:24 <aleth> s/would/wouldn't
21:59:42 <flo> yes
21:59:44 <aleth> I don't know if that would be better either.
22:00:01 <flo> is there going to be a false positive if I type "blah blah blah aleth: cloke<tab>"? Do we care?
22:03:12 <aleth> I think you'd get a false positive. I don't know if we care.
22:04:25 <aleth> You'd have to be careful to avoid that edge case with your method too.
22:05:58 <flo> I think my method was supposed to also work when double clicking a message
22:07:31 <aleth> You mean double-clicking two different messages? 
22:07:56 <flo> another idea: take the string before the ": " and .split(", ").every(function(n) completions.indexOf(n) != -1); to test if we are completing several nicks?
22:07:59 <flo> aleth: yes
22:08:17 <aleth> That's a different part of the code altogether though.
22:08:48 <aleth> flo: You mean, check if the sequence of nicks stretches right to the beginning of the line? One could do that.
22:09:01 <flo> yes
22:10:08 <aleth> I'm just grepping #instantbird logs to see if there is a single case of "blah blah flo: (nick)"
22:12:04 --> Kaishi has joined #instantbird
22:12:34 <flo> it seems quite easy to implement
22:12:47 <aleth> Sure, just add a loop
22:12:59 <flo> just remove the match call on let preceding = text.substring(0, wordStart - 2).match(/\S*?([\w-]+)?$/)[0]; and change the next line with the code I just showed
22:13:59 <aleth> .every is nice :)
22:14:30 <aleth> Good idea - do you want to add that before checking in or is there anything else?
22:15:45 <aleth> (apart from the double-clicking)
22:16:21 <flo> I'm not sure, I dislike the abundance of ternary operators in the last part of the patch, but I'm not sure I've something really better to propose
22:17:01 <aleth> Yeah. I had various if/then's before, and it was even less legible.
22:18:53 <aleth> cf https://bugzilla.instantbird.org/attachment.cgi?id=1235&action=diff
22:20:09 <flo> that version (at least the end part) is close to what I was thinking of suggesting
22:20:30 <flo> except |i = i + 2;| that really wanted to be |i += 2;|
22:21:53 <flo> but did you really mean |word = ", " + word;| or was it supposed to be |word = ": " + word;|?
22:22:09 <aleth> If you prefer that, I have no problems with it. There is a bug in that version though as far as I recall.
22:22:45 <aleth> I can't remember :-/
22:23:09 <flo> I think I prefer this version yes
22:23:30 <flo> but I think you meant ": ", otherwise you remove a comma and add it again ;)
22:23:55 <flo> ah well, it didn't matter, as you only use word.length anyway :)
22:23:58 <aleth> I think it doesn't matter
22:24:25 <flo> for readability only ;)
22:24:38 <aleth> The bug was that it changes completions (the array) and so the list of possible completions comes with commas
22:24:43 * jwir3 is now known as jwir3|away
22:25:04 <flo> and maybe add a comment like "// replace the trailing colon with a comma before the completed nick"
22:25:36 <flo> ah!
22:25:38 <aleth> The problem is fixing that bug while keeping the old if style would require an additional if 
22:25:55 <aleth> (after addString)
22:26:06 <flo> that's only for the second case, right?
22:26:09 <aleth> yes
22:26:15 <aleth> or a local variable of course
22:26:35 <flo> let completion = completions[0].substring(0, i); before the if, so that you don't need the i+=2 line at all
22:27:02 <aleth> yes, that's what I meant with local variable
22:27:12 <flo> ok, I like this better! :)
22:27:16 <aleth> OK :)
22:28:08 <flo> I will try to review the next iteration of the patch before forgetting completely the discussion we just had ;)
22:28:26 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a0d791471fe6 - aleth - Bug 1314 - Own nickname (for pings) detection broken, r=clokep,fqueze.
22:28:27 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/07ece750914b - aleth - Bug 1332 - Implement /whois and /whowas commands, r=clokep,fqueze.
22:28:28 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8a57df6e1529 - aleth - Bug 1329 - Tab complete: prefer sender of the last ping, r=fqueze.
22:31:23 <aleth> Re the double click, that's tricky, unless you want to duplicate part of the tab complete code in browserDblClick, or have it add the nick by sending keyboard events so tab complete is triggered
22:32:59 <aleth> The latter suggestion doesn't really work.
22:33:14 <aleth> (at least not with the present way it behaves)
22:34:44 <flo> don't worry with it for now :)
22:35:07 <aleth> It's an even rarer edge case imho.
22:36:29 <flo> + you are not making that case any worse with your patch; just not changing it.
22:37:39 <flo> Good night
22:37:41 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
22:37:43 <-- aleth has quit (Connection reset by peer)
22:38:10 --> aleth has joined #instantbird
22:38:10 * ChanServ sets mode +h aleth 
22:39:07 <-- testib has quit (Ping timeout)
22:43:17 --> mmkmou has joined #instantbird
22:43:51 <-- Suiseiseki has quit (Ping timeout)
22:45:04 <-- Tomek has quit (Quit: Instantbird 1.1)
22:47:08 --> Suiseiseki has joined #instantbird
22:55:54 --> FeuerFliege has joined #instantbird
22:57:34 <-- FeuerFliege has quit (Ping timeout)
23:03:52 <-- mmkmou has quit (Ping timeout)
23:08:15 --> mmkmou has joined #instantbird
23:25:59 <-- mmkmou has quit (Ping timeout)
23:29:21 --> mmkmou has joined #instantbird
23:30:11 * bear is now known as bear-afk
23:56:46 <myk> an AIM buddy of mine and i just realized that she isn't getting any of the messages i send to her through Instantbird
23:57:01 <myk> (version 1.2a1pre (20120329041135))
23:57:15 <myk> although i see all of her messages; known bug?
23:58:19 <aleth> That sounds bad :(
23:58:21 <aleth> I don't know. I remember flo mentioning /something/ about AIM recently, but I think it was resolved. Better file the bug...