All times are UTC.
00:00:08 <-- Mook_as has quit (Quit: gone) 00:10:56 <-- myk has quit (Ping timeout) 00:36:07 <instantbot> clokep@gmail.com granted review for attachment 1268 on bug 1332. 00:36:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1332 nor, --, ---, aletheia2, ASSI, Implement /whois and /whowas commands 00:36:27 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1278 on bug 1332. 00:42:14 <-- sonny has quit (Quit: Instantbird -- http://www.instantbird.com) 00:49:58 <aleth> clokep: There seem to be some unrelated changes in your version of the patch (in changeBuddyNick but also elsewhere I think) 00:50:50 <clokep> aleth: I was afraid of that. :( 00:51:03 <clokep> I checked over it briefly, but wasn't fully sure of what changes you had made... 00:51:21 <aleth> Diff against the original patch? 00:51:43 <clokep> Yeah maybe. 00:51:55 <aleth> It's kind of hard to tell without :( 00:52:06 <clokep> Will do. 00:52:41 <clokep> aleth: r- it please. 00:52:47 <clokep> I think the changes I had had to do with changing the nick btw. ;) 00:53:06 <aleth> Yep, I noticed ;) 00:54:00 <clokep> flo can just check yours in then (it wasn't too bad to apply, just had to strip the paths) 00:54:43 <instantbot> aletheia2@fastmail.fm denied review for attachment 1278 on bug 1332. 00:54:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1332 nor, --, ---, aletheia2, ASSI, Implement /whois and /whowas commands 00:55:58 <aleth> Paths... :( 00:56:11 <aleth> Anyway, I'm glad it's done. 00:56:34 <clokep> Yeah. I can apply a new patch tomorrow too if need be, but I'm going to bed in a few. 00:56:40 <aleth> Btw if you fix the nick update thing, have a look at the link to the interface I left for flo above, I think that's where it needs to go. 00:56:59 <clokep> Alright. 00:57:00 <aleth> gtg 00:57:03 <-- aleth has quit (Input/output error) 01:15:57 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 01:17:27 <instant-buildbot> build #224 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/224 01:26:20 <instant-buildbot> build #203 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/203 01:52:06 <-- Tomek has quit (Quit: Instantbird 1.1) 02:49:57 <instant-buildbot> build #445 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/445 04:29:55 <instant-buildbot> build #529 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/529 04:44:54 <-- EionRobb has quit (Quit: Leaving.) 05:14:10 <-- Kaishi has quit (Quit: Kaishi) 05:16:08 --> Kaishi has joined #instantbird 05:21:12 --> waynenguyen_1 has joined #instantbird 05:36:21 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.1 [Firefox 12.0/20120321033733]) 05:53:16 <-- waynenguyen_1 has quit (Quit: http://www.mibbit.com ajax IRC Client) 06:03:17 <instant-buildbot> build #433 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/433 06:05:40 --> FeuerFliege has joined #instantbird 06:28:31 --> waynenguyen_1 has joined #instantbird 06:34:36 --> pvagner has joined #instantbird 06:36:57 --> iLobster has joined #instantbird 06:40:18 <-- iLobster has quit (Quit: ChatZilla 0.9.88.1 [Firefox 11.0/20120312181643]) 06:56:18 --> EionRobb has joined #instantbird 06:58:10 --> gerard-majax has joined #instantbird 07:10:04 --> iLobster has joined #instantbird 07:10:12 <iLobster> Greetings 07:15:01 <iLobster> I have one strange problem last maybe week or so. Problem is with ICQ. After some time of been online when i send message to other ICQ user he/she do not recieve my messages. But i'm still able to recieve messages from this user. If i relogin to ICQ after that (it takes few minutes to do it in this case , not momentary) all work fine after it. 07:17:30 <iLobster> Is there any debug mode or mode in which instnatbird log more? 07:27:43 --> jc has joined #instantbird 07:56:33 <-- Even has quit (Quit: Instantbird -- http://www.instantbird.com) 07:56:39 --> Even has joined #instantbird 07:56:40 * ChanServ sets mode +o Even 07:56:45 <-- Even has quit (Quit: Even) 07:58:12 --> Even has joined #instantbird 07:58:12 * ChanServ sets mode +o Even 07:58:23 <Even> hi everyone 07:58:50 <Even> I just upated to the lastest nightly and after doing so Ib was crashing at each startup. A compelte reinstall solved the issue. 07:59:06 <Even> Has this happened to anyone else? 08:03:01 <iLobster> Confirm 08:26:24 --> chrisccoulson has joined #instantbird 08:30:33 --> mmkmou has joined #instantbird 08:34:21 <Even> Ok, I'll block the update then. 08:37:30 <Even> Done. 08:37:46 <Even> I blocked it only on Windows. 08:38:13 <Even> If anyone had the same issue on others OS, please report it there and I will block it everywhere. 08:45:36 <FeuerFliege> Even: deactivate sounds and it shouldnât crash 08:46:46 <Even> FeuerFliege: they where deacticvated 08:47:56 <FeuerFliege> Even: it worked for me, and i updated instantbird just an hour ago. 08:48:40 <Even> FeuerFliege: Ok, so the problem is not general. You are using Windows too ? 08:48:47 --> Mic|web has joined #instantbird 08:48:54 <FeuerFliege> win 7 64bit 08:48:54 <Even> (still, I prefer to let the update deactivated, this is bad) 08:49:04 <Even> k, same version as I do. 08:49:08 <Even> SP1 applied I assume ? 08:49:46 <FeuerFliege> yes 08:51:34 <FeuerFliege> brb 08:51:38 <-- FeuerFliege has quit (Quit: Instantbird -- http://www.instantbird.com) 08:52:10 --> FeuerFliege has joined #instantbird 08:53:17 <FeuerFliege> Iâve just checked, I am an the latest TB nightly (version 1.2a1pre (20120329042035)) 08:53:18 --> aleth has joined #instantbird 08:53:18 * ChanServ sets mode +h aleth 08:53:36 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 08:53:45 <-- FeuerFliege has quit (Quit: Instantbird -- http://www.instantbird.com) 08:53:45 --> aleth has joined #instantbird 08:53:45 * ChanServ sets mode +h aleth 08:53:50 <Mic|web> FeuerFliege: the sound-crash should be fixed in todays nightly: http://hg.instantbird.org/instantbird/rev/4bf7cc6e9f6d 08:53:50 --> FeuerFliege has joined #instantbird 08:54:27 <FeuerFliege> Strange, i activated sounds again, but no crash ⦠08:54:39 <Mic|web> FeuerFliege: the sound-crash should be fixed in todays nightly: http://hg.instantbird.org/instantbird/rev/4bf7cc6e9f6d 08:56:25 <FeuerFliege> Mic|web: then there must be an other reason, why Evenâs TB keeps crashing. 08:57:20 --> NmN has joined #instantbird 08:57:24 <Mic|web> http://log.bezut.info/instantbird/120329/#m58 sounds like a broken update package to me. 09:04:10 <-- waynenguyen_1 has quit (Quit: http://www.mibbit.com ajax IRC Client) 09:18:41 --> pvagnes has joined #instantbird 09:19:33 <-- pvagner has quit (Ping timeout) 09:23:00 --> pvagnet has joined #instantbird 09:23:01 <-- pvagnes has quit (Connection reset by peer) 09:32:16 <-- NmN has quit (Ping timeout) 09:33:28 --> flo has joined #instantbird 09:33:28 * ChanServ sets mode +qo flo flo 09:36:52 <flo> hello :) 09:37:01 <Mic|web> Hi flo 09:38:32 <-- EionRobb has quit (Quit: Leaving.) 09:45:27 --> sonny has joined #instantbird 09:47:25 --> clokep has joined #instantbird 09:47:25 * ChanServ sets mode +o clokep 09:49:09 <Mic|web> Hi clokep 09:50:16 <clokep> Hello Mic|web. 09:56:35 <flo> what's that update problem exactly? 10:02:24 <clokep> Sounds like a botched partial. 10:05:36 <iLobster> update - restart - crash - restart - crash - restart - crash... download nightly zip - unzip to program folder - start - good... and btw sounds was off long time ago 10:07:42 <flo> is the problem the partial, or the previous complete mar? 10:08:17 <flo> iLobster: do you know which file is different between the broken updated nightly and the freshly unzipped nightly? 10:09:39 --> Tomek has joined #instantbird 10:10:32 <iLobster> no, i was in a hurry and did not keep a broken state of the program 10:12:45 <iLobster> and now update is blocked as far as i know, so it will be hard to reproduce it i think 10:13:42 <iLobster> i'll check my 2nd pc, may it will crash on it... 10:16:04 <flo> Mic|web: isn't there a checkbox somewhere in the AIO add-on developer UI that let you make the source code of the add-on publicly browsable? (tried to look at https://addons.instantbird.org/en-US/instantbird/addon/315/ but didn't find the link to see the content of the add-on) 10:16:56 <Mic|web> You need to be logged in to see that link :( 10:17:17 <flo> even when it's public? :-S 10:17:39 <Mic|web> I made the source visible and could only see it when logged in, so yes, I'd say 10:17:41 <flo> If I'm logged in I'm admin with all privileges on that website, so I can't trust that what I see is what others will see too 10:18:07 <flo> and you are the author of the add-on so... 10:18:13 <flo> I hate that website :( 10:18:16 <iLobster> can not check, last update is blocked 10:19:08 <aleth> I can view the source when logged in. Nice idea Mic! 10:19:26 <Mic|web> I uploaded a new version with more comments two minutes ago. 10:19:42 <Mic|web> I think view source still shows the old code. 10:20:30 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 10:22:07 <Mic|web> instantbot: uuid 10:22:09 <instantbot> b05e20fe-9e6a-4b0a-9a55-04ba8fd690ec (/msg instantbot cid for CID form) 10:26:47 <Mic|web> Here's how to extend the "Minimal example" with an extra "protocol" (sorry, I'm not very creative today;): https://addons.instantbird.org/en-US/instantbird/addon/316/ 10:27:08 <-- gerard-majax has quit (Quit: Ex-Chat) 10:27:32 <Mic|web> Would be nice if someone could tell logiclord to look at the updated addon and this extension to it :) 10:29:24 --> gerard-majax has joined #instantbird 10:32:00 <Mic|web> And feedback / improvement suggestions would be welcome, of course :) 10:41:34 --> NmN has joined #instantbird 10:53:55 <-- Tomek has quit (Ping timeout) 10:56:33 --> clokep_work has joined #instantbird 10:56:33 * ChanServ sets mode +o clokep_work 11:00:22 <flo> is there an easy way to make instantbird start automatically when windows starts? Have we documented it in the FAQ? 11:00:47 <clokep_work> flo: I think you just ad the shortcut to the startup folder in the start menu. 11:00:50 <clokep_work> I don't think it's in the FAQ. 11:01:15 <flo> clokep_work: I know that's what I would do if I was on Windows, but I don't think that's user friendly without a step by step tutorial :-/ 11:03:21 * flo has just noticed that http://www.instantbird.com/fr/about.html advises to send an email to contact@ib.org for any question not answered in the FAQ, and doesn't even mention that english is the recommended language 11:12:20 <aleth> I wonder if it would be a good idea to ping ecaron (?) (who does the website?) about this change https://bugzilla.instantbird.org/show_bug.cgi?id=1290 11:12:24 <instantbot> Bug 1290 enh, --, ---, nobody, NEW, Improve main website navigation bar 11:12:40 <flo> nobody does the website 11:12:42 <flo> (:() 11:12:50 <flo> err, that was supposed to be ( :( ) 11:16:38 <aleth> :( Anyway, I added your comment to that bug, not completely the right place for it but that way it wont get lost 11:18:53 <Mic|web> bye 11:18:59 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client) 11:19:10 <aleth> Btw is there any reason why https://wiki.instantbird.org/Instantbird:Notifications:trunk shouldn't replace https://wiki.instantbird.org/Instantbird:Notifications ? 11:19:38 <flo> not really. Except if some of the notifications are better documented in the current page 11:19:48 <flo> + it's not really trunk, but more 1.1 that this page describes 11:20:59 <aleth> & it is hard to find unless you know it exists... would have saved me some digging through the code a while back 11:23:08 <aleth> Not being the author, it's hard to tell if something missing from the original page is missing for a reason ;) 11:23:48 <flo> is it possible to somehow have a diff? 11:25:41 <aleth> The wiki history would do a diff if you replaced the existing version with the new one? 11:26:00 <flo> aren't the tables built differently? 11:26:14 <aleth> A bit. It might fail. 11:26:59 <aleth> Probably it would be more useful to print both out and put them side by side... 11:29:49 <flo> are they even sorted in the same order? 11:35:06 <aleth> Looking at it, I don't think the built in diff would work well, they are too far apart. 12:22:41 <-- Kaishi has quit (Quit: Kaishi) 12:26:42 --> Kaishi has joined #instantbird 12:26:59 * jc is now known as jb 12:39:01 <-- pvagnet has quit (Connection reset by peer) 13:13:58 <-- iLobster has quit (Quit: ChatZilla 0.9.88.1 [Firefox 11.0/20120312181643]) 13:14:19 <-- FeuerFliege has quit (Input/output error) 13:14:24 --> FeuerFliege has joined #instantbird 13:47:27 <flo> aleth: I didn't understand what you said about not being able to fix that bug with nick changes 13:47:40 <flo> you need to add a nick setter, but only in the JS implementation, not in the idl file, right? 13:48:05 <flo> only the protocol plugin should be able to call it (as it's part of its own implementation), not the UI 13:49:23 <-- Kaishi has quit (Quit: Kaishi) 13:56:12 <aleth> flo: OK, thanks. I thought an idl in JS affected inheritance too (a way to make things private...). I must have had some other bug in my WIP then. 13:58:27 <aleth> Has anyone ever seen a "Error: Error running command QUIT with handler RFC 2812... quitMsg is undefined" error before? 14:09:07 <-- flo has quit (Ping timeout) 14:25:20 --> flo has joined #instantbird 14:25:20 * ChanServ sets mode +qo flo flo 14:25:50 <flo> my JS-IRC accounts got disconnected (without error message) again :( 14:39:06 --> jc has joined #instantbird 14:39:25 <-- jb has quit (Ping timeout) 14:53:34 <-- waynenguyen has quit (Quit: Instantbird -- http://www.instantbird.com) 15:12:14 --> waynenguyen has joined #instantbird 15:48:55 <-- gerard-majax has quit (Ping timeout) 15:50:50 --> myk has joined #instantbird 16:33:36 <-- waynenguyen has quit (Quit: Instantbird -- http://www.instantbird.com) 16:34:26 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 16:34:37 --> aleth has joined #instantbird 16:34:37 * ChanServ sets mode +h aleth 16:35:46 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com) 16:42:54 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 16:43:05 --> aleth has joined #instantbird 16:43:05 * ChanServ sets mode +h aleth 16:58:22 <instantbot> New Instantbird (UI) bug 1357 filed by aletheia2@fastmail.fm. 16:58:23 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1279 on bug 1357. 16:58:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1357 nor, --, ---, nobody, NEW, Add unread ruler to section scroll 16:59:04 --> Tomek has joined #instantbird 17:02:50 --> Kaishi has joined #instantbird 17:17:22 <FeuerFliege> hi 17:20:44 --> logiclord has joined #instantbird 17:23:04 <-- Kaishi has quit (Quit: Kaishi) 17:25:09 <FeuerFliege> flo: will the l10n changes pushed to hg.instantbird.org/l10n/en-US/ soon? 17:48:00 <-- Even has quit (Quit: Instantbird -- http://www.instantbird.com) 17:57:31 --> Kaishi has joined #instantbird 18:10:06 <-- Kaishi has quit (Quit: Kaishi) 18:10:31 <-- logiclord has quit (Quit: Leaving.) 18:17:48 <-- mmkmou has quit (Client exited) 18:18:08 <-- FeuerFliege has quit (Ping timeout) 18:19:19 <-- jc has quit (Quit: jc) 18:19:34 --> jb has joined #instantbird 18:19:34 <-- jb has quit (Connection reset by peer) 18:21:57 --> igorko has joined #instantbird 18:22:02 --> jb has joined #instantbird 18:22:23 --> Mook_as has joined #instantbird 18:33:52 --> gerard-majax has joined #instantbird 18:35:27 --> flo has joined #instantbird 18:35:28 * ChanServ sets mode +qo flo flo 18:37:03 <flo> Error: this._mucs[norm].incomingMessage is not a function Source File: resource:///modules/xmpp.jsm Line: 803 :-S 19:01:33 <-- jb has quit (Ping timeout) 19:04:45 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1280 on bug 1314. 19:04:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken 19:16:21 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1280 on bug 1314. 19:16:22 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1281 on bug 1314. 19:16:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken 19:16:43 <flo> aleth: I wonder if you have fixed the 2 review comments I was about to write 19:17:30 <aleth> Probably just one ;) 19:17:32 <flo> ah, halft of one it seems :-) 19:17:36 <flo> *half 19:18:44 <flo> I suspect you haven't tested this patch with nicks containing special characters 19:19:13 <flo> because $& seems strange as a replacement, I would expect $1 ;) 19:21:05 <flo> is the _pingRegexp: null default really useful? 19:21:19 --> mmkmou has joined #instantbird 19:21:20 <aleth> I tested the regexp, but not in action :-S 19:22:22 <aleth> The default is unnecessary. But so is the one for _nick I think so I followed that precedent 19:22:57 <aleth> Or is the one for _nick necessary to override the inherited one? 19:23:06 <aleth> (if there is one) 19:23:42 <-- chrisccoulson has quit (Quit: Ex-Chat) 19:23:54 <aleth> I guess I could drop the else too in writeMessage, that would save a line 19:24:24 <flo> what do you want to do instead (I'm trying to determine if I will write that comment or not :-D) 19:26:05 <-- NmN has quit (Quit: Instantbird 1.1) 19:26:05 <aleth> set containsNick to false before the if, possibly put the match into the if 19:27:04 <flo> ok, I'll write that comment 19:27:55 <aleth> :D 19:28:05 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com) 19:29:11 <aleth> I don't understand what's wrong about $& though? 19:29:22 --> chrisccoulson has joined #instantbird 19:30:06 <flo> does it work? 19:30:09 <flo> what does it mean? 19:30:53 <aleth> e.g. "he|l[(*lo".replace(/[-[\]{}()*+?.,\\^$|#\s]/g, "\\$&"); works 19:31:32 <aleth> What do you mean, what does it mean? It inserts the matched substring 19:31:46 * aleth is confused 19:32:26 <flo> I guess I'll go read the regexp doc again :-D 19:33:22 <aleth> It's quite possible I missed something... 19:34:07 <-- flo has quit (Ping timeout) 19:40:54 --> EionRobb has joined #instantbird 19:48:30 --> flo has joined #instantbird 19:48:30 * ChanServ sets mode +qo flo flo 19:49:59 <flo> it's sad that bugs happening with a flacky connection are so hard to reproduce with a working connection, and almost impossible to debug without a working connection :( 19:50:32 <flo> aleth: you can ignore my comment about $&, I didn't know it that existed, and & and 1 are so close on my keyboard that I thought it was a typo 19:50:34 <aleth> Oh, was that one of the failures-to-reconnect? :( 19:50:54 <flo> aleth: at least 3 different bugs at once 19:51:05 <flo> I had to restart instantbird before being able to connect anything again 19:51:13 <aleth> flo: After you left, I thought you might have missed the /g global 19:51:43 <aleth> But that seemed unlikely... 19:53:13 <flo> aleth: so the imSmiley regexp can be cleanup to remove the () and replace $1 with $& I guess :) 19:53:33 <aleth> Yup :) 19:55:59 <-- myk has quit (Quit: Instantbird -- http://www.instantbird.com) 19:55:59 <instantbot> florian@instantbird.org denied review for attachment 1281 on bug 1314. 19:56:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken 19:56:09 --> myk has joined #instantbird 20:01:43 <aleth> I think I'll keep the default value, as neither _nick nor _pingRegexp is ever deleted, so it's OK to document they will be around. 20:02:16 <aleth> Though I'm not entirely sure about that logic... 20:08:31 <flo> creating the regexp lazily has the advantage that it won't be created for conversations where it isn't used (twitter for example, that has a custom method to display messages) 20:08:41 <flo> but I don't really mind, either way :) 20:19:04 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 20:24:32 <aleth> flo: is !! a typo in your comment, or is that an operator I haven't heard of? 20:25:03 <Mook_as> it's two boolean nots (converts to a boolean) 20:25:04 <flo> it's twice the ! operator to normalize an expression (force it to be a boolean) 20:25:18 <Mook_as> also fun: ~~ to cast to int 20:25:31 <flo> Mook_as: ah, I didn't know this one! 20:25:42 <aleth> oh, neat! 20:39:37 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1282 on bug 1314. 20:39:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken 20:41:45 <flo> aleth: you want to be pinged by system messages? 20:42:13 <flo> what could be a use case? 20:42:16 <aleth> It would be rare, but it might happen... e.g. if you are kicked ;) 20:42:25 <flo> (if someone insults me in his quit message, I don't mind not knowing it) 20:43:13 <flo> will that message contain your nick? I think it writes "You have been kicked (<reason>)" 20:45:10 <aleth> Right, it's only when you see someone else being kicked that the nick is there... 20:46:34 <aleth> Feel free to change it if that's the only issue with the patch. 20:47:58 <aleth> I can't think of another use case. 20:50:18 <flo> when using the nick command, do you want to be pinged? 20:50:38 <flo> (the message says "you are know known as <new nick>" doesn't it? 20:50:56 <aleth> Yes, that will ping you with the current patch. 20:51:06 <aleth> I don't mind either way. 20:52:02 <aleth> Where are the system messages for twitter and XMPP? 20:53:12 <aleth> Ah, found them 20:56:35 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1282 on bug 1314. 20:56:36 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1283 on bug 1314. 20:56:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken 20:57:18 <flo> bah, I shouldn't try to write review comments on your patch until they are at least one day old :-D 20:57:30 --> FeuerFliege has joined #instantbird 20:58:47 <aleth> Sorry :D though actually nothing more would have happened on that patch if you hadn't commented... 20:59:57 <flo> ah, you didn't read Mic's comment before updating the patch? 21:00:16 <aleth> No, I didn't see it before :( 21:01:03 <aleth> I was just trying to save you the bother of having to edit before checking in... 21:01:45 <aleth> .test() is a useful thing to know about :) 21:06:26 <flo> I knew about test, but got somehow confused as you are using .replace with the other regexp (that confused me in the first place with $& :() and then I thought that maybe the regexp could be null, so I didn't mention it 21:10:32 <-- Tonnes has quit (Quit: ChatZilla 0.9.88.1 [Firefox 11.0/20120312181643]) 21:13:29 <aleth> Actually if _pingRegexp is undefined, (undefined).test() is always true. So you would get pinged a lot ;) 21:14:28 <flo> why is there a test method on undefined? 21:15:11 <flo> no, there isn't 21:16:44 <aleth> Did I misinterpret "Prior to Gecko 8.0 (Firefox 8.0 / Thunderbird 8.0 / SeaMonkey 2.5) , test() was implemented incorrectly; when it was called with no parameters, it would match against the value of the previous input (RegExp.input property) instead of against the string "undefined". This is fixed; now /undefined/.test() correctly results in true, instead of an error."? 21:18:18 <flo> the /a/ is the way to create a regexp matching "a" inline 21:18:33 <flo> it's not to put in italic the word in the doc 21:21:00 <aleth> Oh, OK :) Thanks. 21:21:27 <aleth> There are other display errors on that page, so I assumed it was intended to be italic 21:22:28 <aleth> I did wonder how undefined could have properties... 21:24:11 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1283 on bug 1314. 21:24:12 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1284 on bug 1314. 21:24:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken 21:26:42 <-- FeuerFliege has quit (Ping timeout) 21:27:38 <flo> looks good to me 21:27:41 <flo> do you think clokep would want to look at it before it lands? 21:29:15 <aleth> Possibly for the IRC part? 21:30:47 <aleth> I think he was maybe having second thoughts about what to do to nicks when they are already taken 21:31:07 <aleth> Btw the whois patch is r+ if you are about to land things 21:34:12 <flo> that patch was the only one that I was thinking of checking in before going to bed 21:34:23 <flo> (actually, I already have the twitter icon change commited locally) 21:36:09 <-- igorko has quit (Quit: Instantbird 1.1) 21:38:21 <flo> aleth: you have tested the irc part, right? 21:38:28 <aleth> flo: yes 21:40:04 <aleth> In fact I only tested the patch with irc... 21:41:19 <flo> but the part of the code in irc/ isn't used until you /nick 21:42:09 <aleth> Yes, but I did test that ;) 21:43:47 <flo> waitForBuddyInfo: function (aNick) { <-- where is the space between "function" and "(" coming from? 21:45:25 <aleth> Where is that in the ping patch? 21:46:00 <flo> use the findbar? :) 21:46:21 <aleth> I did :P 21:46:26 <aleth> Oh, you are in the whois patch now? 21:47:06 <aleth> There shouldn't be a space there of course. 21:49:48 <flo> message.unknownnick should be message.unknownNick I think 21:50:35 <aleth> The same for the error.* messages then 21:51:16 <flo> should the ": " string be localizable? 21:51:35 <flo> yes, the same for error messages 21:52:33 <aleth> Good question. Should it? 21:52:58 <flo> you write |elt.label + ": " + elt.value| 21:53:01 <flo> is elt.label localized? 21:53:38 <aleth> I should hope so! 21:54:09 <flo> so you have your answer, right? 21:54:15 <flo> it's a formatted string 21:55:15 <aleth> OK. 21:55:16 <flo> (in French there's always an unbreakable space before punctuation symbols like :;!?) 21:55:46 <aleth> Interesting. So it hurts you to see "flo: " in the nick completions? 21:56:22 <flo> it would hurt to see the space with a sentence in english around it! 21:56:23 <aleth> What should I call that string? 21:56:56 <flo> (and I use a nightly build, not a localized build anyway) 21:57:19 <flo> rtl locales may also want to swap the order of the label and the value 21:57:25 <aleth> It was just the first similar thing that came to mind... 21:57:42 <flo> I'm almost sure we already have a "%S:" string somewhere 21:57:59 <flo> I think it's for the summary of the account wizard 21:58:58 <aleth> So it should best be a string "%1$S : %2$S" (for en) into which the other localised string is then inserted 21:59:28 <flo> err, I thought you didn't want a space before : in en-US :-S 22:00:03 <aleth> Yes, I'll leave that out 22:00:19 <flo> hmm, maybe the spaces at the begining of the line are also part of the format, by the way 22:00:31 <flo> (as they would appear at the end for an rtl locale) 22:00:35 <aleth> I was going to put them in the string too 22:00:41 <aleth> Just leave the \n out. 22:01:10 <flo> I'm never completely sure of what I say about rtl locales, as I don't speak (nor read) any :-/ 22:01:46 <aleth> The whole thing was a good catch, just shows how little I know about l10n 22:02:38 <Mook_as> I think you're wrong about RTL locales, but correct about the need to format that 22:02:51 <Mook_as> (since for RTL locales the whole thing is rendered backwards) 22:03:13 <flo> I would really like "// TODO Only handled in the conversation for /whois so far." to be fixed! 22:03:27 <aleth> But not in this bug ;) 22:03:43 <flo> Mook_as: what was wrong in what I said exactly? :) 22:03:51 <flo> aleth: sure. But still, that bug sucks! 22:04:13 <aleth> It does. There are a couple of others like that :( Unhandled messages... 22:04:22 <Mook_as> I think the RTL locales would still end up using "%1$S: %2$S" (just doesn't look that way in visual order) 22:04:39 <aleth> Channel modes aren't handled at all atm afaik 22:04:43 <Mook_as> of course, I know zero RTL languages as well, so don't trust me! :p 22:05:35 <flo> we just need to flip a pref to switch to rtl (for any language), right? 22:06:09 <Mook_as> that switches, IIRC, the XUL layout, but not the text rendering? 22:06:22 <flo> Mook_as: I don't see how the string could be rendered backward 22:08:31 <flo> I'm not completely sure I need to know though :) 22:11:11 --> mmkmou has joined #instantbird 22:11:56 <flo> I'm not super happy with the _observedNicks values being initialized to empty arrays (I would have preferred a null default value, deleting _observedNicks if the last observed nick was removed, and testing for if (this._observedNicks) rather than if (this._observedNicks.length)) but I don't think that's really worth changing 22:12:28 <flo> of course I don't really like the code duplication between the 2 conversation types either, but heh... I think clokep has already said we will pretend we haven't seen this one :-) 22:13:19 <flo> and I don't have any other comment :) 22:14:04 --> Kaishi has joined #instantbird 22:20:38 <aleth> FWIW, _observedNicks was initialized to empty so _observedNicks.push() would not fail. 22:21:21 <aleth> I'm glad that patch is ok... it kept growing ;) 22:24:08 <flo> if it's null you would have to add a test there to create it in that case 22:24:44 <flo> if (this._observedNicks) this._observedNicks.push(nick); else this._observedNicks=[nick]; 22:28:15 <aleth> sure, it just seemed an if clause one could avoid. 22:29:01 <aleth> I'll try to remember the preference for the future. 22:31:52 <flo> Good night 22:31:54 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com) 22:37:42 <-- mmkmou has quit (Ping timeout) 22:48:11 --> clokep has joined #instantbird 22:48:12 * ChanServ sets mode +o clokep 22:51:06 * clokep is drowning in bugmail. 22:58:59 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1285 on bug 1332. 22:59:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1332 nor, --, ---, aletheia2, ASSI, Implement /whois and /whowas commands 23:01:53 * clokep is reading aleth's patches.... 23:02:54 <aleth> A lot today, one way or another... 23:05:56 <clokep> I had 11 Ib mails, 30 moz mails and 22 emails in my regular inbox...and that's just my clokep account. 23:06:20 <aleth> :-/ Is TB producing tons of mail then? 23:06:51 <clokep> Idk, I haven't gotten to that folder yet. ;) 23:06:54 <clokep> IB stuff is more impotant. 23:13:23 <instantbot> clokep@gmail.com denied review for attachment 1284 on bug 1314. 23:13:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken 23:15:07 <clokep> aleth: The r- was mostly for the IRC normalize stuff.. 23:16:29 <aleth> clokep: I don't think they should be normalized. You want the properly capitalized nick there, don't you? 23:16:41 <clokep> Why? 23:16:52 <clokep> You're trying to see if two things are equal...you should normalize them. 23:17:46 <aleth> Oh, I see what you mean now. Normalize in the if clause only. 23:18:46 <clokep> Ah, yes. Sorry. :( I left one extra line. 23:19:05 <clokep> But yeah, even though what you and server htink is your nick should be the same...who knows maybe there's servers out there which always do everything in lower case. :P 23:19:51 <aleth> Re the \d*, that's from the other bug, basically. It should be decided, yes. 23:21:00 <aleth> I have no idea where a global 'constant' regexp would go, so I'll leave that up to flo. 23:21:31 <clokep> aleth: Well a constant one would go at the top of the file (or right above that prototype definition) which would just be declared as a const. :) 23:21:38 <clokep> Globally...Idk what file it would go in. 23:21:43 <clokep> imXPCOMUtils is our catch-all I think. :( 23:22:16 <aleth> With 'constant' I just meant you wouldn't need a function, just the regexp for use in replace() 23:24:34 <Mook_as> /foo/ is compile-time, no? 23:24:47 <Mook_as> (as opposed to new RegExp("foo") ) 23:25:24 <clokep> aleth: I mean http://pastebin.instantbird.com/23589 23:25:24 <aleth> Mook_as: I think clokep just suggested it for ease of reuse. 23:25:34 <clokep> aleth: No, I suggested making it constant for efficiency. 23:25:41 <clokep> I suggested making it global for ease of reuse. ;) 23:25:52 <Mook_as> oh, shared and /g. that's gonna be fun 23:26:01 <clokep> Why? 23:26:07 --> mmkmou has joined #instantbird 23:26:09 <Mook_as> ah, replace is probably okay, just match that's nasty 23:34:50 * clokep is reading the whois patch again... 23:53:45 <-- sonny has quit (Client exited)