#instantbird log on 03 28 2012

All times are UTC.

00:01:21 <Mook_as> aleth: https://developer.mozilla.org/en/Using_nsCOMPtr
00:02:12 <aleth> Mook_as: uh, thanks!
00:02:40 * aleth clicks "Getting started" ;)
00:48:45 <qheaden> What Mozilla software, other than Firefox, provides the web console?
00:48:51 <qheaden> I'm guessing just Firefox.
00:50:10 <clokep> qheaden: It's just Firefox.
00:50:41 <-- waynenguyen has quit (Ping timeout)
00:50:46 <qheaden> Thanks./
00:51:19 <Mook_as> moving it to be app-neutral would be... challenging, I think
00:52:21 * qheaden quotes Mook_as in his proposal with a citation at the bottom. :P
00:53:00 <Mook_as> you may want to refer to https://bugzilla.mozilla.org/show_bug.cgi?id=568647as well
00:54:27 <qheaden> So they won't fix it huh?
00:56:14 <clokep> Doesn't sound like it.
00:56:21 <clokep> Doesn't mean you can't use any of the code though. :)
01:02:42 <-- aleth has quit (Input/output error)
01:04:20 <qheaden> clokep: I just sent you a new version of my proposal. This one is much more detailed.
01:04:54 <-- Mook_as has quit (Quit: gone)
01:06:19 * clokep notes his build finished 118 minutes later...
01:06:39 <clokep> qheaden: I see. I'll read it in the morning if you don't mind. :)
01:06:47 * clokep is reaching his point of not being able to think. ;)
01:07:03 <qheaden> clokep: Ha ha. No problem. Just email be back with your feedback on it.
01:08:49 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com)
01:27:11 <-- Tomek has quit (Ping timeout)
01:46:50 <-- Gizmokid2005 has quit (Ping timeout)
01:53:43 --> Gizmokid2005 has joined #instantbird
02:09:47 <-- myk has quit (Ping timeout)
02:25:20 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
02:31:59 <-- qheaden has quit (Quit: Leaving)
02:36:41 --> waynenguyen_1 has joined #instantbird
02:46:29 <-- jazper- has quit (Quit: )
02:46:36 --> jazper- has joined #instantbird
02:55:35 <instant-buildbot> build #444 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/444
04:15:30 <-- pvagner has quit (Ping timeout)
04:50:20 <instant-buildbot> build #528 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/528
04:51:45 <-- Kaishi has quit (Quit: Kaishi)
04:51:51 --> Kaishi has joined #instantbird
05:03:59 --> pvagner has joined #instantbird
05:07:27 <-- EionRobb has quit (Quit: Leaving.)
05:13:38 --> NmN has joined #instantbird
05:39:22 --> EionRobb has joined #instantbird
05:49:04 <-- Suiseiseki has quit (Quit: Quit)
05:49:40 --> Tomek has joined #instantbird
06:03:24 <instant-buildbot> build #432 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/432
06:19:39 --> Suiseiseki has joined #instantbird
06:23:24 --> FeuerFliege has joined #instantbird
06:24:46 <-- Tomek has quit (Ping timeout)
06:36:40 <-- Kaishi has quit (Input/output error)
07:29:46 --> jb has joined #instantbird
07:32:28 <-- pvagner has quit (Ping timeout)
07:36:24 --> pvagner has joined #instantbird
07:44:58 --> jc has joined #instantbird
07:52:24 <-- jc has quit (Quit: jc)
07:58:43 <-- NmN has quit (Quit: Instantbird 1.1)
08:08:43 --> gerard-majax has joined #instantbird
08:24:24 --> NmN has joined #instantbird
08:30:48 <instantbot> New Core - Eventloop bug 1355 filed by sztanpet@gmail.com.
08:30:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1355 maj, --, ---, nobody, UNCO, After extended period of time, MSN and checking for updates stop working
08:39:40 --> Evep has joined #instantbird
08:39:46 <-- Evep has quit (Quit: Evep)
08:39:55 --> Evep has joined #instantbird
08:46:29 <-- waynenguyen_1 has quit (Quit: http://www.mibbit.com ajax IRC Client)
08:58:05 --> flo has joined #instantbird
08:58:05 * ChanServ sets mode +qo flo flo 
08:59:44 --> aleth has joined #instantbird
08:59:44 * ChanServ sets mode +h aleth 
09:19:04 <-- EionRobb has quit (Quit: Leaving.)
09:20:00 --> mmkmou has joined #instantbird
10:20:17 --> clokep has joined #instantbird
10:20:17 * ChanServ sets mode +o clokep 
10:26:04 <flo> clokep: ok, there's probably no crappy DLL crashing us on your machine :).
10:26:27 <clokep> flo: Oh? Who's crappy code is crashing my machine then? ;)
10:26:49 <flo> I've just pushed a fix for that crash :)
10:29:30 <clokep> :)
10:29:35 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7f5dfa28bc4e - Florian Quèze - Bug 1354 - JS-protocols should close their conversations and remove their buddies when they are removed, r=clokep.
10:29:37 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4bf7cc6e9f6d - Florian Quèze - Fix Windows crash when playing a sound (since moz11 update 16ba4b39b811) by including gkmedias.dll in the package. Port of bug 709721 from mozilla-central.
10:30:04 <clokep> Ah I see, that was part of the "holy crap libxul is huge!" issue...
10:30:10 <flo> yeah...
10:30:39 <clokep> Glad you found it. :) I'll let you know tomorrow if it works. ;)
10:30:47 <flo> I'm glad I remembered that the sound decoders have been moved to a separate library on Windows only this morning while walking on the street :)
10:31:11 <flo> further debugging it could have wasted a lot of time
10:31:28 <clokep> :)
10:31:33 <instantbot> clokep@gmail.com set the Resolution field on bug 1354 to FIXED.
10:31:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1354 nor, --, 1.2, florian, RESO FIXED, JS-protocols should close their conversations and remove their buddies when they are removed
10:32:57 <clokep> (Btw I saw your email to Mark & David; makes sense. :) We'll see which one they like best.)
10:34:04 <flo> it seems for now they have selected the option I haven't mentioned: "wait and see" :-D
10:34:43 * clokep dislikes that option.
10:35:45 <flo> I need to like at the errors in https://bugzilla.mozilla.org/show_bug.cgi?id=738778
10:35:54 <flo> I dislike Irving's solution of adding a try/catch
10:36:02 <flo> s/like/look/
10:38:32 <clokep> :(
10:49:16 <clokep> So my debug builds keep crashing...The output is http://pastebin.instantbird.com/22679 not sure if it's helpful.
10:56:19 <flo> mine crashed in the same way
10:56:39 <flo> I just made that JS engine assertion non fatal and moved on
10:57:26 * clokep finds that disconcerting...
10:57:39 <clokep> Is that like literally removing _FATAL from it or something? :)
10:59:01 <flo> clokep: it's that awful: http://pastebin.instantbird.com/22682
10:59:14 <flo> ah, it's mac only
10:59:32 <flo> well, I'm sure you can find where to edit that code to make it non fatal on windows too
11:04:42 <clokep> I'm sure. :) THanks!
11:04:53 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com)
11:10:27 <flo> why aren't we showing the avatars of twitter accounts in tooltips of the participants list? :-S
11:11:08 <flo> do we need to add an attribute to prplIConvChatBuddy to let the tooltip get the url to the icon?
11:13:34 <flo> clokep: I hadn't noticed "WARNING: Moving XPConnect wrappedNative to new scope, but can't fixup __proto__: file .../mozilla/js/xpconnect/src/XPCWrappedNative.cpp, line 1608" in your log. I don't know what's causing that one
11:25:03 <aleth> The twitter participant list needs some work anyhow... people you follow should be present as inactive nicks imho
11:31:25 <flo> aleth: want to do that?
11:31:37 <aleth> Oh, it's on the list...
11:32:21 <flo> "the list"? O_o
11:33:17 <aleth> It only exists in my head ;)
11:34:01 <aleth> Would avatars fit into the current tooltip design? Do you mean instead of the twitter icon?
11:36:06 <-- NmN has quit (Ping timeout)
11:38:00 --> tqft_ has joined #instantbird
11:38:11 <-- pvagner has quit (Ping timeout)
11:41:03 --> pvagner has joined #instantbird
11:46:21 --> clokep_work has joined #instantbird
11:46:22 * ChanServ sets mode +o clokep_work 
11:47:34 <clokep_work> aleth: We use the same tooltips for participants and buddies, so if it can be shown in the buddy one it can be shown in the participate one. :)
11:47:47 <clokep_work> Why is it not shown in the participate one? I think it's hard coded to only be shown for buddies...
11:48:30 <aleth> I don't think I have any buddies with avatars, so I wouldn't know ;)
11:49:05 <aleth> Well, the MSN ones probably do, but that is broken for other reasons
11:55:02 --> sonny has joined #instantbird
12:20:58 <-- FeuerFliege has quit (Ping timeout)
12:26:30 --> danols1 has joined #instantbird
12:27:06 <-- danols has quit (Ping timeout)
12:32:15 <-- sonny has quit (Quit: Instantbird -- http://www.instantbird.com)
12:35:47 <flo> apparently Gerv doesn't like the "wait and see" approach ;)
12:37:55 --> Mic|web has joined #instantbird
12:41:59 --> NmN has joined #instantbird
12:42:53 --> sonny has joined #instantbird
12:50:37 <-- mmkmou has quit (Ping timeout)
12:52:57 --> mmkmou has joined #instantbird
13:01:22 <-- mmkmou has quit (Ping timeout)
13:02:49 --> mmkmou has joined #instantbird
13:08:34 <-- mmkmou has quit (Ping timeout)
13:13:41 <-- tqft_ has quit (Quit: ChatZilla [SeaMonkey 2.11a1/20120325153712])
13:17:10 <clokep_work> Yes. :) I see.
13:17:23 <clokep_work> I think half-ish of our bugs are chat bugs, the restare in Instantbird/libpurple stuff btw.
13:17:55 <flo> I think it would also be interesting to see how much code there is in each part
13:18:53 <flo> I'm not sure how much you all would like it if bio disappeared and was merged into bmo, but I personally would really like it a lot ;).
13:23:38 <clokep_work> It doesn't matter to me much either way. I'd appreciate if all our cross references, etc. were kept though.
13:24:19 <-- pvagner has quit (Connection reset by peer)
13:24:37 <clokep_work> flo: Well what I /don't/ want is for us to have to put /chat bugs into bmo and all other bugs onto bio. That's a bad UX. ;)
13:25:25 <flo> From my point of view, the less data I have to feel responsible for having a correct backup, the better
13:36:02 <clokep_work> :)
13:50:15 * Mic|web is surprised that there are so many dupes among so few bugs in the "Instant Messaging" component on bmo.
13:51:39 <flo> how many dupes are there?
13:52:14 <Mic|web> Five or six of ~50 bugs.
13:57:34 --> Kaishi has joined #instantbird
13:58:28 --> mmkmou has joined #instantbird
14:07:59 --> waynenguyen has joined #instantbird
14:13:36 <-- mmkmou has quit (Ping timeout)
14:27:50 --> mmkmou has joined #instantbird
14:35:22 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:36:56 --> danols_work has joined #instantbird
14:37:19 <danols_work> hi all my Instant Bird nighly started crashing on startup when connecting a freenode server
14:37:19 <-- danols_work has quit (Connection reset by peer)
14:38:53 <clokep_work> danols1: Are you on Windows?
14:39:38 <-- mmkmou has quit (Ping timeout)
14:46:43 --> logiclord has joined #instantbird
14:47:08 <clokep_work> Well if he comes back...there was an issue with sounds crashing Instantbird on Windows 7 which will hopefully be fixed tomorrow, if he has a crash report that would be helpful.
14:48:00 <logiclord> Hi all I have thought about architecture for account import wizard I have some doubts about xpcom 
14:48:33 <clokep_work> ...
14:48:47 <clokep_work> (I'm not really sure we have any choice about that anyway. ;) But what do you mean?)
14:49:27 --> Mic|web has joined #instantbird
14:50:10 <logiclord> I am confused about XPCOM modules ?? Do we need a module for every component or can we have multiple component via same module ??
14:50:47 <flo> what do you call "module"?
14:51:59 <logiclord>  A module is an object that  is used to register, unregister and provide factories for classes.  It  implements the nsIModule interface.  as per dev docs
14:52:07 <flo> after the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=737022 there are dozens of new JS warnings at startup :(
14:52:32 <flo> it seems like you are reading outdated doc :(
14:52:56 <flo> (that seems like the confusing part of XPCOM components that was removed for Mozilla 2.0)
14:53:44 <logiclord> :( actually I think I referred too many docs :( ... so do we use xpcomutils for this ?
14:54:40 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:55:02 <flo> yes. It may be easier if you just looked at some code examples
14:56:19 <flo> I wonder if http://lxr.instantbird.org/instantbird/source/chat/protocols/jsTest/jsTestProtocol.js is easy enough to understand for someone learning xpcom :-S
14:56:22 --> clokep_work has joined #instantbird
14:56:22 * ChanServ sets mode +o clokep_work 
14:56:49 <flo> http://lxr.instantbird.org/instantbird/source/chat/components/src/smileProtocolHandler.js is smaller
14:57:14 <flo> you also want to look at some idl interface files (there are lots of them in http://lxr.instantbird.org/instantbird/source/chat/components/public/)
14:57:19 <Mic|web> If you ignore the actual account implementation, the Facebook protocol component might be pretty short
14:59:14 <Mic|web> I meant this: http://hg.instantbird.org/instantbird/file/4bf7cc6e9f6d/chat/protocols/facebook/facebook.js#l76 with its registration code at http://hg.instantbird.org/instantbird/file/4bf7cc6e9f6d/chat/protocols/facebook/facebook.manifest
14:59:25 <Mic|web> Ignore me if that's too much "link-noise" for you ;) 
14:59:41 <-- logiclord has quit (Ping timeout)
15:00:09 --> jc has joined #instantbird
15:00:28 <-- jb has quit (Ping timeout)
15:02:47 --> logiclord has joined #instantbird
15:03:21 <logiclord> sry network problem :(
15:03:45 <logiclord> Yes I have downloaded instantbird code 
15:05:16 <logiclord> I was planning to have a main xpcom component which will handle import wizard (detect installed IM clients and instantiate all required xpcom component) and have most of the gui stuff
15:05:50 <logiclord> A standard interface for XPCOM components of IM clients
15:06:47 <logiclord> There will be a set of utility components like access registry (will be reused in many IM clients), keychains access etc
15:07:00 <logiclord> any feedback ?
15:09:13 <logiclord> I think using xpcom utlis will clearly ease efforts 
15:09:15 <clokep_work> The UI shouldn't be part of an XPCOM component...
15:10:01 <Mic|web> Neither the utility functions. They sound more like things to go into js-modules.
15:11:03 <logiclord> that it the place where I was confused :-/ 
15:11:33 <logiclord> so how should we handle UI ?
15:11:54 <logiclord> I mean XUL implementation ?
15:11:55 <Mic|web> We have xul, xbl, js for the UI
15:12:35 <clokep_work> logiclord: So for example we have a conversation.
15:12:47 <logiclord> okay
15:12:49 <clokep_work> This is implemented by an XPCOM component somewhere.
15:12:58 <clokep_work> And the interface to it is defined as imIConversation.
15:13:09 <flo> I think to look at XUL you may want to read the code of the current account wizard
15:13:12 <clokep_work> But then we have a conversation binding which includes a reference to the XPCOM component.
15:13:23 <flo> and maybe the account manager with the list of accounts to have an example of XBL
15:14:19 --> mmkmou has joined #instantbird
15:14:21 <-- mmkmou has quit (Client exited)
15:14:32 --> mmkmou has joined #instantbird
15:15:39 <logiclord> clokep_work I got your point
15:16:06 <logiclord> flo : will have a look at code and XBL docs as well
15:16:43 <logiclord> Basically I meant someone needs to manage the xul like when we should display X window that part will be done by main component 
15:17:12 <logiclord> anyways I will send a detailed email on this at contact id asap Thanks all :)
15:20:15 <logiclord> btw Is there any docs for available events in Instantbird ?
15:20:31 <Mic|web> Search for "notifications" on the wiki.
15:20:49 <Mic|web> The one with "trunk" in the article name is less outdated than the other :S
15:21:07 <logiclord> okay
15:21:54 * clokep_work is confused by "main component". :-S
15:22:47 <waynenguyen> logiclord: You may want to look at https://addons.instantbird.org/en-US/instantbird/addon/314 , it just currently doesn't have the UI. Hope that helps too 
15:23:46 <flo> hmm, so https://bugzilla.mozilla.org/show_bug.cgi?id=737466 is in chat/, should we review it? :-D
15:24:16 <-- logiclord has quit (Client exited)
15:25:02 <Mic|web> bbl
15:25:21 <clokep_work> flo: Yes. :)
15:26:30 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:32:37 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
15:36:39 --> Mic|web has joined #instantbird
15:46:37 <-- mmkmou has quit (Ping timeout)
15:51:10 --> logiclord has joined #instantbird
16:06:50 <-- aleth has quit (Input/output error)
16:08:36 --> myk has joined #instantbird
16:17:49 --> FeuerFliege has joined #instantbird
16:23:05 <-- Evep has quit (Input/output error)
16:26:36 <Mic|web> logiclord: btw I'm creating a sort of minimal example to show how different parts (like components, XUL+js for UI) work together
16:27:52 <logiclord> Mic : Thanks pls mail me :)
16:28:36 --> mmkmou has joined #instantbird
16:29:32 <clokep_work> Please post it publicly actually. ;)
16:35:41 <logiclord> yes that will really help 
16:36:30 <Mic|web> If it works, yes :D
16:37:01 <-- gerard-majax has quit (Ping timeout)
16:37:17 --> BYK has joined #instantbird
16:39:01 <-- BYK has quit (Ping timeout)
16:40:09 --> BYK has joined #instantbird
16:40:09 <-- BYK has quit (Quit: BYK)
16:44:04 --> BYK has joined #instantbird
16:46:40 --> DGMurdockIII has joined #instantbird
16:46:58 <DGMurdockIII> instantbird is crashing again
16:47:27 <DGMurdockIII> it started again after the last update with was very small
16:48:33 <DGMurdockIII> i meas like around 200- 300 kb
16:48:51 <clokep_work> DGMurdockIII: Are you on Windows?
16:48:55 <DGMurdockIII> yes
16:48:56 <-- FeuerFliege has quit (Ping timeout)
16:48:58 <clokep_work> Is it when you have sounds enabled?
16:49:20 <DGMurdockIII> no it hapens when i send a message
16:49:30 <DGMurdockIII> it just crashes
16:49:32 <clokep_work> ...do you have sounds enabled?
16:49:37 <DGMurdockIII> yews
16:49:45 <clokep_work> Does it work if you disable sounds.
16:49:52 <DGMurdockIII> i'll see
16:50:02 <clokep_work> If so, the fix wil lbe in tomorrow's nightly.
16:50:08 <DGMurdockIII> becse im getting same problem as you are 
16:50:38 <DGMurdockIII> yes it dose not crashes
16:51:00 <DGMurdockIII> before it would crash right away once i sent the message
16:51:37 <clokep_work> It will be fixed in tomorrow's nightly.
16:52:14 <DGMurdockIII> so i could turn sound on then and see if i still get the problem
16:53:06 <clokep_work> Assuming tonight's nightly works fine and after you update, yes. :)
16:53:48 --> aleth has joined #instantbird
16:53:49 * ChanServ sets mode +h aleth 
16:53:50 <DGMurdockIII> iit a good think this was found out now before 
16:56:42 <Mic|web> clokep_work: I'm struggling with some component stuff: http://pastebin.instantbird.com/22851
16:57:22 <Mic|web> Any ideas? I never created a component without using an already defined existing interface :(
17:06:20 <clokep_work> Mic|web: Does it make sense to do it without a defined interface?
17:10:32 <Mic|web> From what I read on MDN, it should be possible to do this, as long as you stick to JS only and access it using wrappedJSObject.
17:10:45 <Mic|web> I wanted to demonstrate how to use the category manager to get all components of a category and add some data to the UI by calling a method on each of them.
17:11:43 <clokep_work> Ah, I see.
17:11:49 <clokep_work> Hmm...I don't see any major gotcha.s
17:12:02 <clokep_work> Where does that error occur
17:12:18 <clokep_work> In the .getService() call?
17:12:27 <Mic|web> Yes
17:12:50 <clokep_work> Hmmm...
17:13:55 <clokep_work> The generateQI looks sketchy to me.
17:15:28 <instantbot> New Instantbird (UI) bug 1356 filed by aletheia2@fastmail.fm.
17:15:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1356 min, --, ---, nobody, NEW, [Message style selector] Warning: Undefined property this._name
17:16:05 <Mic|web> I tried with both an empty and no array in this call, neither worked.
17:16:25 <Mic|web> That's the documentation I followed: https://developer.mozilla.org/en/How_to_Build_an_XPCOM_Component_in_Javascript#Using_wrappedJSObject
17:17:24 <aleth> Do you need to define wrappedJSObject to this?
17:18:00 <aleth> Oh, sorry, it's there in your pastebin :S
17:18:25 * aleth should have scrolled up first
17:19:50 <Mic|web> clokep_work, aleth: thanks. I forgot adding the path before the components file name in the manifest. It works now.
17:19:51 * clokep_work has no idea.
17:20:20 <Mic|web> What a stupid error for such a stupid problem.
17:22:43 --> gerard-majax has joined #instantbird
17:25:38 <clokep_work> :(
17:25:41 <clokep_work> manifests are a pain.
17:34:56 --> Mook_as has joined #instantbird
17:49:55 <-- wesj has quit (Quit: Instantbird -- http://www.instantbird.com)
17:49:59 --> wesj has joined #instantbird
17:50:15 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1273 on bug 860.
17:50:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations
17:52:56 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com)
17:53:12 <Mic|web> clokep_work, logiclord: https://addons.instantbird.org/en-US/instantbird/addon/315/ 
17:53:32 <Mic|web> It adds a menu item in the tools menu that will show a new window with a label and a listbox with two items.
17:54:02 <Mic|web> The item names are taken from components of a certain category.
17:55:50 <logiclord> thanks Mic clokep_work
17:56:31 <logiclord> you all are just awesome 
17:57:44 <Mic|web> logiclord: it's left to you to add a "Protocol C" yourself now ;)
17:57:47 <-- NmN has quit (Quit: Instantbird 1.1)
17:58:26 <logiclord> Mic : Don't worry I am on it and it will be worth a read :)
17:58:35 <Mic|web> I hgope so ;)
17:58:39 <Mic|web> *hope
17:58:43 <Mic|web> Good evening
17:58:54 <logiclord> good night here 
17:58:59 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:04:25 <clokep_work> Cool mic.
18:08:22 <clokep_work> aleth: That's quite the patch!
18:09:52 <-- jc has quit (Ping timeout)
18:13:50 --> Tomek has joined #instantbird
18:14:23 <-- logiclord has quit (Quit: Leaving.)
18:22:58 --> Mnyromyr has joined #instantbird
18:46:44 --> mmkmou has joined #instantbird
18:48:32 <-- gerard-majax has quit (Client exited)
18:48:51 --> gerard-majax has joined #instantbird
18:49:20 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1273 on bug 860.
18:49:21 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1274 on bug 860.
18:49:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations
18:49:36 <aleth> clokep_work: Thanks! please try it out and let me know what you think...
18:53:45 --> igorko has joined #instantbird
18:55:05 --> FeuerFliege has joined #instantbird
18:58:57 <-- FeuerFliege has quit (Input/output error)
19:12:09 --> FeuerFliege has joined #instantbird
19:12:12 <-- FeuerFliege has quit (Connection reset by peer)
19:12:29 --> FeuerFliege has joined #instantbird
19:12:31 <-- FeuerFliege has quit (Connection reset by peer)
19:12:37 --> FeuerFliege has joined #instantbird
19:12:41 <-- FeuerFliege has quit (Connection reset by peer)
19:20:26 <-- igorko has quit (Ping timeout)
19:21:15 --> FeuerFliege has joined #instantbird
19:21:26 <FeuerFliege> hi
19:21:27 <-- FeuerFliege has quit (Connection reset by peer)
19:21:49 --> igorko has joined #instantbird
19:22:50 --> FeuerFliege has joined #instantbird
19:22:54 <-- FeuerFliege has quit (Connection reset by peer)
19:23:00 --> FeuerFliege has joined #instantbird
19:23:03 <-- FeuerFliege has quit (Connection reset by peer)
19:23:21 --> FeuerFliege has joined #instantbird
19:23:25 <-- FeuerFliege has quit (Connection reset by peer)
19:24:04 --> FeuerFliege has joined #instantbird
19:24:10 <-- FeuerFliege has quit (Connection reset by peer)
19:24:43 --> FeuerFliege has joined #instantbird
19:24:46 <-- FeuerFliege has quit (Connection reset by peer)
19:25:34 <-- gerard-majax has quit (Ping timeout)
19:31:34 <-- sonny has quit (Ping timeout)
19:31:58 --> WasabiBat has joined #instantbird
19:32:23 <-- danols1 has quit (Ping timeout)
19:32:29 * WasabiBat is now known as FeuerVogel
19:33:05 * FeuerVogel is now known as FeuerFliege
19:33:16 <clokep_work> flo: So bug 737466 is checkin-needed...we gotta make sure we track these well enough that we check them into Instantbird too if some random person comes along and checks it in..
19:33:39 <FeuerFliege> hi
19:34:18 <FeuerFliege> I guess you know that the latest nightlies keep crashing?! :(
19:34:29 <aleth> FeuerFliege: are you on windows and have sounds turned on?
19:35:53 --> sonny has joined #instantbird
19:37:03 <FeuerFliege> yes
19:37:05 <aleth> if so, try turning the sounds off for now, that should help... and it should be fixed tomorrow afaik.
19:37:19 <FeuerFliege> ok i‘ll try
19:37:32 <-- igorko has quit (Ping timeout)
19:38:18 <-- FeuerFliege has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:38:33 --> FeuerFliege has joined #instantbird
19:39:09 <FeuerFliege> Yep, no crash.
19:39:16 <FeuerFliege> thx
19:41:03 --> igorko has joined #instantbird
19:42:30 <-- FeuerFliege has quit (Quit: Instantbird -- http://www.instantbird.com)
19:49:02 <clokep_work> :)
20:05:19 --> EionRobb has joined #instantbird
20:09:27 <-- jwir3 has quit (Quit: Well, he was on his third drink before the wheels of the plane left the ground.)
20:09:46 --> jwir3 has joined #instantbird
20:25:48 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com)
20:37:28 <-- BYK has quit (Quit: Instantbird -- http://www.instantbird.com)
20:50:43 <-- igorko has quit (Ping timeout)
20:56:08 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1274 on bug 860.
20:56:09 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1275 on bug 860.
20:56:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=860 nor, --, ---, aletheia2, ASSI, Add reading position marker line to conversations
20:58:58 --> flo has joined #instantbird
20:58:58 * ChanServ sets mode +qo flo flo 
20:59:18 <clokep_work> Good evening flo. :)
21:00:31 <flo> clokep_work: still at work? :-O
21:00:40 <clokep_work> I'm
21:00:47 * clokep_work is working late today and early tomorrow. :-(
21:01:10 <flo> hmm, or it's only 5pm?
21:01:47 <flo> I guess I'm confused with what your timezone and usual work times are :-S
21:02:01 <clokep_work> I usually work 7:45 - 4:30. ;)
21:02:25 <clokep_work> I think DST is screwy right now between the US and the rest of the world though. :P
21:02:46 <Mook_as> and us poor idiots that follow US times :p
21:04:16 <clokep_work> Lemmings.
21:04:34 <flo> clokep_work: no, we changed our time last sunday. That period lasts only 2 weeks
21:05:17 <clokep_work> Oh.
21:05:20 * clokep_work :shrugs:
21:05:35 <clokep_work> I only missed it by a few days. :)
21:06:09 <flo> clokep_work: I tend to be in the office between 10:30 and 19:30 (or maybe that's 7:30 for you), so we have quite different working habits it seems ;)
21:06:34 <clokep_work> flo: But it aligns our schedules closer. ;)
21:06:39 <flo> right :)
21:07:44 <clokep_work> Seems like quite a few people were suffering from the sound crash though. :-/
21:07:56 <flo> my contact list currently doesn't display any contact, and the error console says "Error: aContactB is undefined Source File: chrome://instantbird/content/group.xml Line: 225", that doesn't seem good :(
21:08:16 <flo> have you heard of complaints, or just looked at crash-stats?
21:09:21 <flo> too many messages with "review" in the title in the bugmail folder :-/
21:09:24 <clokep_work> flo: We've gotten a few complaints here on IRC.
21:09:47 <clokep_work> I've gotten aContact(A|B) errors before but been unable to track them down. And haven't seen it in a while.
21:10:40 <flo> hmm, should we comment in https://bugzilla.mozilla.org/show_bug.cgi?id=737466 about that being in the chat/ module, or shut up? :)
21:11:28 <clokep_work> What do you mean? That bwinton isn't a peer? ;)
21:11:39 <aleth> flo: some of those are dupes ;)
21:11:49 <flo> clokep_work: right!
21:12:01 <clokep_work> flo: But we want the change anyway, right? :)
21:12:14 <clokep_work> Who gets ui-r for chat/? Do we have it? :-S
21:12:25 <flo> sure, otherwise I would be complaining loudly already ;)
21:12:52 <clokep_work> Haha. Then yes, we should make some noise. :)
21:12:53 <flo> I think ui-r in that context is bwinton for whatever's visible to Thunderbird users
21:13:00 <flo> but r is the owner of the code module
21:13:17 <clokep_work> Right.
21:14:02 <clokep_work> Want me to comment?
21:14:04 <clokep_work> :P
21:14:21 <flo> the creation of that new chat/ module hasn't been announced anywhere, so Andreas obviously had no way to know
21:14:27 <clokep_work> Yes. :-/
21:14:40 <clokep_work> I think commenting nicely about it is worth doing though.
21:15:14 <clokep_work> (Or just steal the review and flex your muscles. ;))
21:15:22 <Mook_as> flo: the easiest path is probably add an r+ and check it in :p
21:15:50 <Mook_as> (so make _some_ noise, but also help move it forward to show you're not blocking progress because of it)
21:16:15 <clokep_work> Yes, I didn't mean to block on it!
21:16:37 <flo> to be fair, Andreas is cc'ing me on all chat related bugs (I had to ask twice though :)) so I can't really pretend we don't know it's happening
21:17:14 <clokep_work> Yup. I'm being CC'd on the accessibility ones...
21:17:30 <flo> clokep_work: I don't know why, but that seems a good idea :)
21:17:53 <clokep_work> flo: I CC'd myself to a random one and that person has been CCing me on all of them. :)
21:17:59 <flo> clokep_work: these aren't even in the chat/ module though
21:18:03 <clokep_work> Yup!
21:18:18 <flo> probably using the "file similar bug" link then
21:18:32 <flo> (that copies the CC list of the original bug)
21:18:34 <clokep_work> Ah probably.
21:18:37 <clokep_work> Anyway time to go now.
21:18:39 <clokep_work> Goodnight. :)
21:18:49 <-- clokep_work has quit (Quit: Instant-wait for it...-bird!)
21:24:24 --> jc has joined #instantbird
21:32:24 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:35:05 <-- jc has quit (Ping timeout)
21:36:50 <flo> does this sound aggressive? "While I see no problem with this patch, I just wanted to add a quick note that the code in the chat/ folder, which is shared between Thunderbird and Instantbird, has a different ownership than the rest of the Thunderbird code (see https://wiki.mozilla.org/Modules/Chat). Ensuring that a peer of the chat module has seen changes before they checked-in would be appreciated. Thanks!"
21:36:58 <flo> (with an added r+ flag)
21:39:36 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1276 on bug 1314.
21:39:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken
21:41:16 <EionRobb> doesn't sound aggressive to me, flo
21:41:30 <aleth> To me neither.
21:41:48 <aleth> s/before they checked-in/before they are checked in
21:44:58 <flo> ok, I sent it! :)
21:46:21 <-- Tomek has quit (Ping timeout)
21:48:55 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1276 on bug 1314.
21:48:56 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1277 on bug 1314.
21:48:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken
21:51:59 <flo> aleth: can a nick contain the | character?
21:52:20 <aleth> Yes :(
21:53:54 <flo> there's already some code to escape strings to create regexp with them somewhere
21:54:07 <flo> probably both in the emoticon detection code and in the show nicks add-on
21:54:15 <aleth> Oh good.
21:55:07 <aleth> Also [,] is legal in nicks...
21:55:07 <flo> + I think we shouldn't create the regexp for each message, but rather when the nick is set/changed
21:55:32 <aleth> Oh, is it expensive?
21:55:38 <flo> yes
21:55:41 <aleth> I suppose it might become so
21:56:05 <aleth> I had assumed applying the regex was the expensive part.
21:56:18 <flo> well, it's not super expensive, but for something that can be done lots of times...
21:56:29 <aleth> Might as well.
21:56:40 <flo> how expensive applying the regexp is totally depends on what the regexp contains
21:57:31 <aleth> That one isn't too bad.
21:57:43 <flo> (and you will need to apply a regexp to escape the special characters anyway)
21:59:52 <aleth> Yes, that'll actually be more costly.
22:25:52 <aleth> flo: What's the best way for GenericConvChatPrototype to notice that the user's nick has changed? Add a setter?
22:26:31 <flo> hmm, maybe, I don't know how that code works right now
22:27:16 <flo> yes, add a setter
22:33:09 --> mmkmou has joined #instantbird
22:36:45 <aleth> There's actually a bug in the current code :( Pings just break if the nick changes.
22:37:44 <aleth> Because the change never propagates down from the IRC account.
22:38:45 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1277 on bug 1314.
22:38:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1314 min, --, ---, aletheia2, ASSI, Own nickname (for pings) detection broken
22:42:49 <-- mmkmou has quit (Ping timeout)
22:44:08 <flo> ah, if you are touching the code that changes the nick, maybe you can take the opportunity to reset the nick after each disconnection? ;)
22:45:34 * Mook_as tries to remember if context messages do stalk matching
22:45:48 <-- flo has quit (Ping timeout)
22:46:26 --> mmkmou has joined #instantbird
22:47:40 <aleth> flo: I think it's elsewhere, but has it been filed?
22:52:01 --> danols has joined #instantbird
23:02:24 <-- mmkmou has quit (Ping timeout)
23:07:27 <aleth> flo: I don't think I can fix this ping issue. If I understand correctly, it requires a change to the interface (the nick should not be read-only, http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#140, or there should be a method added to call to change it). And I can't do/test that without a build environment afaik.
23:13:05 <-- chrisccoulson has quit (No route to host)
23:40:30 --> clokep has joined #instantbird
23:40:30 * ChanServ sets mode +o clokep 
23:45:21 <instant-buildbot> build #235 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/235
23:47:03 <clokep> flo: A similar patch to yours lets me run my debug build. :) Thanks.
23:51:09 --> Tomek has joined #instantbird