All times are UTC.
00:13:16 --> wesj has joined #instantbird 00:16:52 <-- myk has quit (Ping timeout) 00:19:07 <-- jc has quit (Ping timeout) 00:19:12 <-- jb has quit (Ping timeout) 00:25:06 <instant-buildbot> build #197 of macosx-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/197 blamelist: Florian Qu?ze <florian@instantbird.org> 00:32:28 <instantbot> New Core - IRC bug 1346 filed by aletheia2@fastmail.fm. 00:32:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1346 nor, --, ---, nobody, UNCO, Replace alphabetic increment of last letter on nick collision 00:34:41 <-- Mook_as has quit (Quit: gone) 00:44:11 --> Tonnes has joined #instantbird 00:50:54 <-- wesj has quit (Quit: Instantbird -- http://www.instantbird.com) 01:48:19 --> waynenguyen_1 has joined #instantbird 01:54:45 <-- aleth has quit (Input/output error) 01:57:37 <instant-buildbot> build #230 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/230 02:15:30 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 02:40:49 <-- waynenguyen_1 has quit (Quit: http://www.mibbit.com ajax IRC Client) 03:13:20 <instant-buildbot> build #422 of macosx-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/422 03:35:44 <instant-buildbot> build #218 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/218 03:56:33 <instant-buildbot> build #518 of win32-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/518 04:57:14 <instant-buildbot> build #434 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/434 05:14:54 --> Mautematico has joined #instantbird 05:15:26 <-- Mautematico has quit (Quit: Instantbird -- http://www.instantbird.com) 05:41:02 --> waynenguyen_1 has joined #instantbird 06:06:32 --> jc has joined #instantbird 06:10:24 <-- Kaishi has quit (Quit: Instantbird 1.1) 06:10:48 --> jb has joined #instantbird 06:26:33 <-- jc has quit (Ping timeout) 06:26:33 <-- jb has quit (Ping timeout) 06:32:12 <waynenguyen_1> Hi, I tried to call the Accounts component (as from here http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#915), but when I call Components.classes["@mozilla.org/chat/accounts-service;1"] it doesn not return anything. 06:32:19 <waynenguyen_1> I tried @instantbird.org/purple/accounts-service; as well, but it doesn't work either. 06:32:52 <waynenguyen_1> May I know how can I call this properly? 06:35:59 <-- Tomek has quit (Quit: Instantbird 1.1) 06:39:28 <-- skeledrew has quit (Ping timeout) 06:41:22 --> skeledrew has joined #instantbird 06:58:30 <-- skeledrew has quit (Client exited) 06:58:44 --> skeledrew has joined #instantbird 06:58:51 <-- skeledrew has quit (Client exited) 06:58:58 --> skeledrew has joined #instantbird 07:16:08 --> jb has joined #instantbird 07:16:19 --> jc has joined #instantbird 07:58:32 --> gerard-majax has joined #instantbird 08:06:43 --> pvagner has joined #instantbird 08:28:08 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e38b6dbd3130 - Florian Quèze - Add a patch needed to compile the JS engine on PPC. 08:28:09 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7ba67283f52a - Florian Quèze - Re-add patches that were removed for no obvious reason in 0dcfaed3a5e1. 08:28:51 --> NmN has joined #instantbird 08:51:54 <-- jb has quit (Quit: jb) 08:52:16 --> jb has joined #instantbird 08:54:06 <-- jb has quit (Connection reset by peer) 08:59:36 --> jb has joined #instantbird 08:59:40 <-- jb has quit (Quit: jb) 08:59:56 --> jb has joined #instantbird 09:08:21 --> Nitrox has joined #instantbird 09:13:41 --> mmkmou has joined #instantbird 09:21:27 <-- Nitrox has quit (Quit: Connection to internet lost) 09:26:55 <instant-buildbot> build #219 of win32-onCommit is complete: Exception [exception interrupted] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/219 blamelist: Florian Qu?ze <florian@instantbird.org> 09:33:31 --> MicTest has joined #instantbird 09:35:02 <-- waynenguyen_1 has quit (Quit: http://www.mibbit.com ajax IRC Client) 09:41:31 --> Mic has joined #instantbird 09:41:31 * ChanServ sets mode +h Mic 09:41:44 <Mic> Hi 09:42:16 <Even> hi 09:53:08 <Mic> waynenguyen: what did you try to do? Can you pastebin the code so I can have a look? 10:18:25 --> clokep has joined #instantbird 10:18:25 * ChanServ sets mode +o clokep 10:19:56 --> flo has joined #instantbird 10:19:57 * ChanServ sets mode +qo flo flo 10:20:06 <-- flo has quit (Input/output error) 10:20:08 --> flo has joined #instantbird 10:20:09 * ChanServ sets mode +qo flo flo 10:21:30 <clokep> waynenguyen: If you can use imServices.jsm that's usually a good idea. :) 10:25:29 <flo> hello :) 10:25:34 <clokep> Hi. 10:32:46 <flo> I hope the nightlies will succeed this time :-| 10:34:02 <Mic> Hi 10:35:16 --> aleth has joined #instantbird 10:35:17 * ChanServ sets mode +h aleth 10:35:44 <clokep> Sorry for removing those patches. ;( I thought I had checked that they weren't necessary in Moz10. :( 10:35:55 <clokep> Or I just totally messed up and removed random things. 10:38:28 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 10:38:42 --> aleth has joined #instantbird 10:38:42 * ChanServ sets mode +h aleth 10:43:11 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 10:44:32 <flo> clokep: 2 of them have been integrated with a target milestone of moz11, the third isn't in mozilla-central yet 10:45:30 <flo> Mic: has somebody ever written that bug 328 isn't wanted? 10:45:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=328 enh, --, ---, nobody, NEW, Account access bar 10:47:15 <aleth> What is that for? 10:54:51 <Mic> flo: no, in contrary. It even made it into the wanted-list (in the pre-1.0 era, though). I just wondered if that's the current opinion on it. 11:02:29 --> Keso has joined #instantbird 11:02:38 <Keso> hi 11:02:54 <-- MicTest has quit (Quit: Instantbird 1.2a1pre) 11:03:29 <Keso> guys when I click File->set status-> offline why instantbird does not disconnect me from IM services ? 11:05:52 <flo> aleth: it's to show protocol icons in the status bar of the contact window so that you can quickly see to which networks you are connected. Especially useful if there are connection errors (we can show a warning sign above the protocol icon in that case). 11:06:59 <flo> Keso: It should. Can you give more details? (which version you are using? is this for all your accounts or only some of them? etc...) 11:06:59 <aleth> Ah, is that what the blist status bar was intended for? 11:07:06 <flo> aleth: yes 11:07:31 --> je has joined #instantbird 11:07:43 --> jf has joined #instantbird 11:08:00 <-- jc has quit (Ping timeout) 11:08:11 <instant-buildbot> build #519 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/519 11:08:41 <Keso> flo: IB 1.1, Gecko 7.0.1 going through http proxy, and it's for all my accounts (ICQ, gmail, fb) 11:08:43 <-- jb has quit (Ping timeout) 11:08:56 <flo> are there errors in the error console? 11:09:27 <Keso> flo: will try now, maybe it will disconnect me from irc ;) 11:09:43 <flo> anybody interested in testing testing the new Windows moz10-based nightly? 11:09:49 <flo> it's just finished building 11:10:34 <aleth> I've seen no problems with the Linux nightly :) 11:10:49 <Keso> flo: no errors, and right now I should be offline (my circle on photo(which is not set) is grey but status says Available 11:11:01 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 11:11:17 <flo> do you have add-ons? 11:11:21 <Keso> flo: and all accounts are connected 11:11:26 --> aleth has joined #instantbird 11:11:27 * ChanServ sets mode +h aleth 11:11:47 <Keso> flo: I have extension minimal but can remove it as I'm not using it 11:11:55 <aleth> Keso: wfm 11:12:35 * Keso going restart instant bird (removed extension minimal brb) 11:12:39 <flo> Keso: that's only a message theme, right? It shouldn't affect the status in anyway 11:12:58 <Keso> flo: yes message theme but to be sure. and btw I'm still on XP 11:13:00 <-- Keso has quit (Quit: Instantbird 1.1) 11:13:20 <aleth> I wonder if it has something to do with the proxy 11:14:13 --> Keso has joined #instantbird 11:14:17 <Keso> re 11:18:40 <-- Mic has quit (Quit: Instantbird 1.2a1pre) 11:19:19 --> Mic has joined #instantbird 11:19:19 * ChanServ sets mode +h Mic 11:21:04 <Mic> The latest nightly starts and connects to various networks. Nothing is obviously broken for me. 11:22:06 --> sonny has joined #instantbird 11:22:32 <Keso> flo: back with clean install 11:24:31 <flo> Mic: cool :) 11:26:28 <-- je has quit (Input/output error) 11:26:42 <-- jf has quit (Quit: jf) 11:26:50 <flo> so jb has reached j*f* 11:27:32 <flo> maybe the code finding a new nick doesn't reset to the original nick after a disconnectiong? 11:27:34 <flo> -g 11:28:41 <Keso> flo: any comments to setting offline status ? 11:28:58 <flo> Keso: that should disconnect all your accounts. 11:29:16 <Keso> flo: ok so where to fill bug? 11:29:36 <flo> bugzilla.instantbird.org 11:29:52 <flo> we will need steps to reproduce to be able to fix it though 11:35:01 --> jb has joined #instantbird 11:35:42 <flo> we may need to port http://hg.mozilla.org/comm-central/rev/995678d4c911 and http://hg.mozilla.org/comm-central/rev/7ec79765fce9 11:36:15 <flo> and we should also bump the minimum supported Windows version 11:36:18 <Keso> flo: well for me it's simple, when I set up my status to offline I'm still online 11:36:26 <flo> as we are building with VS2010 which requires XP SP2 11:36:36 <flo> Keso: but that's only for you 11:38:40 <Keso> flo: aha, so considering I'm on XP and going through HTTP proxy can make a difference, I can check at home without proxy 11:40:29 <flo> clokep: I remember I had something to do with http://pastebin.instantbird.com/19521 (it's been sitting in a tab for days) but I don't remember what. Did I need to review/comment on it? Was it ready for check-in? :-S 11:43:03 <Keso> flo: btw feature req. would be nice to have possibility to change status on right click in status bar (what do you think?) 11:43:25 <flo> which status bar? 11:43:48 <Keso> flo: changing status (eg. available, away, offline) 11:44:21 <Keso> flo: damn not status bar but in system tray 11:44:39 <Keso> flo: I'm thinking faster than I'm able to write 11:45:54 --> jc has joined #instantbird 11:46:58 <flo> I would probably want that if I used the systray icon 11:51:58 <Mic> bye 11:52:20 <Keso> flo; if win 7 doesn't have system tray then forget, it's obsolete 11:52:31 <flo> Mac definitely doesn't ;) 11:52:38 <Mic> We have a status changer on the taskbar items there 11:52:44 <Mic> (on Win7) 11:52:50 <Mic> bye, now ;) 11:52:51 <Keso> flo: not everybody are on Mac :) 11:52:54 <-- Mic has quit (Input/output error) 11:59:24 <-- jc has quit (Ping timeout) 11:59:46 <-- jb has quit (Ping timeout) 12:01:52 --> jb has joined #instantbird 12:04:57 <-- Even has quit (Quit: Instantbird -- http://www.instantbird.com) 12:05:02 --> Even has joined #instantbird 12:05:03 * ChanServ sets mode +o Even 12:08:32 --> Mad_Maks has joined #instantbird 12:09:32 --> jc has joined #instantbird 12:14:46 <-- NmN has quit (Quit: Instantbird 1.1) 12:15:25 --> clokep_work has joined #instantbird 12:15:25 * ChanServ sets mode +o clokep_work 12:18:07 <clokep_work> flo: We should probably port those, they should help some of the annoying behavior about when we bump versions, etc. getting extra taskbar buttons. 12:19:26 <clokep_work> flo: That pastebin is the version of bug 1291 with no string changes. 12:19:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1291 min, --, ---, clokep, ASSI, Source displayed in "entered the room" system messages for JS-IRC is too verbose 12:19:32 <clokep_work> Which AFAIK is ready for check-in. 12:19:59 <clokep_work> Keso: The status icon lets you change status I believe. 12:20:05 <clokep_work> Either aleth or I wrote the patch for it. 12:21:04 <clokep_work> Bug 750. 12:21:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=750 enh, --, 1.2, clokep, RESO FIXED, Expand Tray Icon context menu with commonly used actions 12:21:09 <clokep_work> Ah, it's for Instantbird 1.2. :( My bad. 12:21:17 <clokep_work> Well, it's done already though! :) 12:22:55 <aleth> Keso: Before you file a bug, it might be worth checking whether you can reproduce the offline problem with the latest nightly. Not that I have a reason to expect it will be different... 12:24:22 <flo> aleth: that code has been completely rewritten between 1.1 and the current nightlies anyway ;) 12:27:58 * clokep_work expects it to be different then. ;) 12:58:56 --> NmN has joined #instantbird 13:09:47 <instant-buildbot> build #423 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/423 13:13:56 <-- jb has quit (Quit: jb) 13:15:15 --> jb has joined #instantbird 13:18:19 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com) 13:18:35 --> flo has joined #instantbird 13:18:35 * ChanServ sets mode +qo flo flo 13:23:56 <clokep_work> aleth: Did my suggestion in the nick conflict bug make sense by the way? 13:24:09 <clokep_work> (It's an attempt to avoid getting clokep11111 instead of clokep btw...) 13:26:04 <aleth> Yes, I actually meant the same I think but wasn't clear enough. 13:26:30 <clokep_work> OK. :) 13:26:58 <clokep_work> And yeah, fl o and I briefly discussed how the way I implemented it looks beautiful in code but sucks in practice. :P 13:27:07 <clokep_work> ANd then you end up with jg or whatever he was. 13:27:25 <clokep_work> So thanks for filing the bug! 13:27:32 <aleth> Yes, that's what reminded me to file it ;) 13:27:44 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 13:40:17 <-- Mad_Maks has quit (Client exited) 13:43:15 <-- NmN has quit (Quit: Instantbird 1.1) 13:43:20 --> NmN has joined #instantbird 13:49:53 <Keso> clokep_work: status icon? 13:51:44 <clokep_work> Keso: Excuse me? 13:52:00 <clokep_work> Sorry, I meant "Tray icon" 13:52:02 <clokep_work> Not status icon. :) 13:53:48 <Keso> clokep_work: aha, but you can't win xp when I do left click on icon in bring me instantbird main window, when I do right click I have only two options restore and exit 13:54:10 --> logiclord has joined #instantbird 13:54:11 <clokep_work> Keso: As I said, it was fixed for Instantbird 1.2. 13:54:20 <clokep_work> Trust me, it's there. 13:54:23 <clokep_work> I wrote the patch. ; 13:54:24 <clokep_work> ;) 13:54:40 <clokep_work> I referenced the bug earlier, you can see it's fixed & checked in. 13:56:46 <Keso> clokep_work: aha, give me link to last build :) 13:57:54 <clokep_work> Keso: See the topic. 14:00:41 --> je has joined #instantbird 14:00:57 <-- jb has quit (Ping timeout) 14:01:00 --> jf has joined #instantbird 14:01:17 <-- jc has quit (Ping timeout) 14:04:59 <waynenguyen> hi 14:05:41 <waynenguyen> Mic: I tried to add an account, here is my code: http://pastebin.instantbird.com/20727, the error is Services.Accounts is undefined 14:05:47 <waynenguyen> clokep_work: I tried to use imServices.jsm as well, but it appears that the local imServices.jsm doesn't have the account-service. (I inspect the file locally and compare to http://lxr.instantbird.org/instantbird/source/chat/modules/imServices.jsm.) 14:07:44 <clokep_work> waynenguyen: http://lxr.instantbird.org/instantbird/source/chat/modules/imServices.jsm#43 seems to be Services.accounts (lowercase A) 14:07:45 --> Tomek has joined #instantbird 14:08:23 <clokep_work> I would try something like http://pastebin.instantbird.com/20728 14:13:52 <Keso> clokep_work: btw for corporate users like me, would be fantastic to have, maybe addon, for click on/off proxy server 14:14:28 * Keso off for latest build 14:14:33 <clokep_work> The way we interact with libpurple proxies in general kind of sucks. 14:14:34 <-- Keso has quit (Quit: Instantbird 1.1) 14:15:01 <waynenguyen> clokep_work: The error console says Services.accounts is undefined either. 14:15:42 <clokep_work> Does Services exist? 14:15:56 <clokep_work> Is there an error above that saying that the file failed to import? 14:16:35 --> Keso has joined #instantbird 14:16:36 <Keso> re 14:17:10 <Keso> I can't log in to any account with 1,2a1pre 14:18:00 <Keso> a.. it looks I can but it takes longer time, connected to icq, gtalk and facebook maybe will start soon 14:18:18 <Keso> but definitelly I can't connect to irc.mozilla.org via http proxy 14:19:41 <waynenguyen> clokep_work: Yes it is, Services.core works. I tried to inspect imServices.jsm (locally) and it seems the definition of Services.accounts is missing 14:20:11 <Keso> I think it's due missing proxy support 14:20:52 <instantbot> clokep@gmail.com denied review for attachment 1258 on bug 1332. 14:20:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1332 nor, --, ---, aletheia2, ASSI, Implement /whois and /whowas commands 14:21:06 <clokep_work> waynenguyen: What version of Instantbird are you running? 14:21:15 <Keso> flo: so I do think someone forget to build proxy support into facebook and gmail type of accounts 14:21:38 <clokep_work> Keso: They should support the proxy that is set in Tools > Options. 14:22:15 <waynenguyen> clokep_work: I'm running version 1.1 14:22:22 <Keso> clokep_work: I have it set up 14:22:44 <clokep_work> waynenguyen: It might not exist in 1.1, I'm not sure. If it's not in that file, then it doesn't seem to be. :) 14:22:54 <clokep_work> Keso: Then file a bug please. 14:23:09 <Keso> clokep_work: but when I clock on properties in accounts dialog there is no mention about proxy (in gmail/facebook account type) 14:23:16 <clokep_work> I think it was tested, I know flo tested it for IRC. 14:23:30 <Keso> clokep_work: and it's show in icq account type 14:23:32 <clokep_work> Yes, because it uses the general proxy that is set. 14:23:54 <waynenguyen> clokep_work: I see, I just check the nightly version and it has the .accounts :) 14:23:59 <clokep_work> The libpurple accounts all have their own proxy information, the ones we rewrote in JavaScript do not, they use the same proxy as Mozilla. 14:26:48 <-- waynenguyen has quit (Quit: Instantbird -- http://www.instantbird.com) 14:27:05 <Keso> clokep_work: but it's not working for irc as well 14:27:38 <Keso> clokep_work: which bug category I have to fuill core or instantbird UI ? 14:28:00 <clokep_work> Core. 14:28:15 --> waynenguyen has joined #instantbird 14:28:17 <clokep_work> IRC, GChat and Facebook all use JavaScript protocols. 14:29:08 <Keso> clokep_work: ok 14:30:12 <clokep_work> They were tested at some point, but it's possible they don't work in every situation. 14:30:20 <clokep_work> Please give as much detail about your proxy set up as you can. :) 14:30:32 <clokep_work> (Whether it's socks or what not...etc.) 14:31:18 <Keso> clokep_work: well only I know it's http based and was working with stable release 14:31:38 <clokep_work> Uh...OK...? 14:31:52 <clokep_work> You must have set it up though, so you can say the settings? 14:32:10 <clokep_work> (Obviously the URl isn't necessary if it's a corporate one, etc. but the other settings might be helpful.) 14:36:06 <waynenguyen> clokep_work: It works now :) 14:36:20 <waynenguyen> Thanks 14:37:08 <clokep_work> waynenguyen: No problem. Didn't realize that wasn't in Instantbird 1.1. :( 14:37:23 <Keso> clokep_work: I just put hostname and port that's it 14:38:08 <clokep_work> As an HTTP proxy. OK. 14:38:38 <Keso> clokep_work: yep 14:40:56 <-- gerard-majax has quit (Ping timeout) 14:41:32 <Keso> clokep_work: btw facebook account says only one thing into error console but irc is more verbal 14:43:17 <instantbot> New Core - XMPP bug 1347 filed by keso@kotelna.sk. 14:43:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1347 nor, --, ---, nobody, UNCO, XMPP doesn't accept proxy settings 14:43:38 <Keso> that's mine 14:43:52 <Keso> clokep_work: if you have a time take a look and let me know if more info needed 14:47:09 <Keso> clokep_work: because I will have to install older version now to keep me connected :) 14:51:24 <-- Tomek has quit (Quit: Instantbird 1.1) 14:54:04 <logiclord> flo : ping 14:54:27 <clokep_work> logiclord: I think flo is AFK right now, it's better if you just ask your question and he (or someone else) will just get back to you. 14:55:15 <logiclord> clokep_work: l wanted to follow up on my emailed proposal 14:55:41 <clokep_work> Yes, I saw it. 14:55:51 <clokep_work> Had a lot of good research in it. :) 14:56:01 <logiclord> ya it took me 2 days 14:56:20 --> Keso1 has joined #instantbird 14:56:24 <logiclord> but It also uncover some of the possible issues in the project 14:56:31 <-- Keso has left #instantbird () 14:56:57 <logiclord> like we can't get our hands on some of the decryption like yahoo messenger 14:59:45 * Keso1 is now known as Keso 15:01:25 <clokep_work> Right, it might not be possible to do them all. 15:01:39 <clokep_work> For the project to be successful, we don't have to do them all. 15:01:52 <clokep_work> But we should try to do as many (especially of popular ones!) as we can. 15:05:21 <logiclord> pidgin, miranda and empathy will work but 15:05:34 <logiclord> Digsby and Trillian is still doubtful 15:06:04 <Keso> btw is there a plugin like OTR for pidgin for IB? 15:06:31 <logiclord> since their don't store anything on local disk everything on server 15:06:46 <clokep_work> Keso: No. 15:06:58 <clokep_work> There's a bug on file, and the hooks are there to allow it. But no one made the add-on. 15:07:42 <Keso> I wasn't using it to much but sometimes in some companies you don't want to be tracked ;) 15:08:24 <clokep_work> I understand. 15:09:21 <Keso> clokep_work: another thing, is there possibility to order "Tags" in main window? It's alphabetically right now 15:09:59 <clokep_work> Uhhh...I think it can be done via an add-on. I think we have the hooks in there. 15:11:01 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 15:13:06 <flo> Keso: I'm confused by what you wrote about proxies. 15:13:21 <flo> I don't see how an HTTP proxy could accept IRC or XMPP connections 15:13:39 <flo> and we definitely support socks proxies for these accounts (I'm currently connected through a socks proxy) 15:14:08 <Keso> flo: well I'm running IB 1.1 right now. I'm connecting to my accounts via HTTP proxy. I did install of 1.2pre1 and I can't log in 15:14:20 <Keso> flo: same setup nothing changed 15:14:28 <Keso> flo: only ICQ connect 15:14:46 <flo> the proxy settings aren't configured in the same way 15:15:03 <flo> but I still don't see how an HTTP proxy could be used for IRC ;) 15:15:39 <Keso> flo: well don't ask me, for me it was supprise too when I was able to connect via IB to irc.mozilla.org 15:15:59 <Keso> and definitelly I'm behind proxy 15:16:11 <flo> don't you have a socks proxy too? 15:17:04 --> igorko has joined #instantbird 15:17:06 <Keso> flo: don't know never used, my setup right now in IB is Other.. HTTP hostname and port 80 15:18:03 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org) 15:18:11 --> igorko has joined #instantbird 15:18:53 <Keso> flo: and in accounts windows when I do account properties then I see I'm connected via HTTP hostname.oracle.com:80 15:19:31 <Keso> flo: and when I install 1.2pre1 there is no mention about proxy in accounts properties 15:20:19 <flo> we are moving out of per-account proxy settings 15:20:22 --> clokep_work has joined #instantbird 15:20:22 * ChanServ sets mode +o clokep_work 15:20:35 <flo> the proxy settings (for accounts implemented in JavaScript) are like for Firefox 15:21:07 <Keso> flo: yes I know, I did main setup in options ->advanced-networks 15:32:41 <-- je has quit (Quit: je) 15:33:09 <logiclord> clokep_work flo : I think I should create a wiki page then and carry discussion updates there.. and then catch you on irc 15:33:31 <flo> sounds like a good idea :) 15:33:50 <flo> as clokep_work said, for a successful SoC project, you don't have to implement support for all the clients at once. 15:34:09 <logiclord> but i wanted to cover as many as possible 15:34:16 <flo> so don't worry too much if there's a client or two for which it's not possible to have satisfying results 15:34:25 <logiclord> I have one more temporary issue 15:36:14 <logiclord> I have windows and ubuntu 15:36:22 <logiclord> how to work for mac :-/ 15:36:30 --> jb has joined #instantbird 15:37:03 <logiclord> should I install something in virtual box 15:37:47 <flo> it's hard to install Mac OS X in a VM 15:38:29 <flo> I think in your email you mentioned something about AIM for Mac. Does that still exists? I thought people wanting AIM on Mac just used iChat 15:38:42 <clokep_work> Adium is Mac only I think too, so that could be hard. 15:38:42 <logiclord> flo yes 15:38:52 <logiclord> It shows on website 15:39:31 <logiclord> flo : Actually I have already setup os x snow leopard in virtual box 15:39:36 <logiclord> but its a bix slow 15:40:07 <logiclord> *bit 15:42:53 <clokep_work> Also your question earlier about being unable to decrypt Yahoo...didn't you say that the algorithm is available in the DLL? Well if they have Yahoo installed, they'll have that DLL and theoretically you could use it to decrypt the password. 15:43:36 --> aleth has joined #instantbird 15:43:36 * ChanServ sets mode +h aleth 15:52:46 --> myk has joined #instantbird 15:55:43 --> wesj has joined #instantbird 15:56:26 <-- wesj has quit (Quit: Instantbird -- http://www.instantbird.com) 15:56:26 <logiclord> clokep_work: that was before 7th version 15:56:34 --> wesj has joined #instantbird 15:56:52 <logiclord> flo : or i could even buy a mac mini :) 15:57:11 <flo> right 15:57:23 <flo> don't worry too much about Mac. Most of the users are on Windows. 15:57:57 <clokep_work> Yup! :) 15:58:04 <flo> I think a large part of the project will be creating the UI for it, and writing the code that's shared between all the importers. 15:58:46 <logiclord> flo: should I create some mock-ups ? 15:59:19 <flo> you can, if you like mock-ups/if they help you imagine what you will work on :) 15:59:45 <flo> the less UI we need for it the better ;). 16:00:13 <logiclord> flo: I was thinking to create an import wizard kind of thing 16:00:33 <flo> I think it should be in the same wizard as the current account wizard 16:01:02 <flo> just when you open it during the first time you use Instantbird, it will probe for existing accounts, and if some are found, propose to use them 16:01:52 <flo> things that aren't clear to me yet: do we need to make the user wait while we probe for existing clients, or can this be fast enough (< 100ms) that it's not noticeable? 16:02:09 <flo> do we need to ask the user for permission to probe for other clients in the system, or can we just do it? 16:03:03 <waynenguyen> flo: I think for the waiting part, a progress bar would be good. 16:03:04 <flo> if probing involves using the user's credentials to fetch info from a remote server, I think we have to ask before attempting to do it 16:03:22 <-- igorko has quit (Connection reset by peer) 16:03:27 <logiclord> flo : speed depends on performance of decryption algorithms 16:03:32 <flo> waynenguyen: what I would like is if we could just do it in the background while the user reads a "welcome" message 16:03:44 <flo> logiclord: and of disk I/O... 16:03:52 <logiclord> yes 16:04:04 <flo> and of how many clients we probe for :) 16:04:20 <waynenguyen> flo: I see 16:04:33 <logiclord> yes we do need to ask permissions especially in linux and mac.. keychains access etc 16:04:35 <flo> waynenguyen: but I'm not sure if it's possible 16:05:02 <-- pvagner has quit (Ping timeout) 16:05:08 <flo> logiclord: I think it's different to ask for permission to decode the passwords, or to ask for permissions to just probe for other clients 16:05:21 <logiclord> file access may also be needed 16:05:40 <flo> if there's no other client or no account configured on them, it would be nicer if we could just shut up and proceed with the normal account wizard 16:06:17 <logiclord> flo : i think user should have option to do imports at a later stage 16:06:33 <flo> logiclord: I agree 16:06:54 <logiclord> give me some time till tomorrow 16:06:56 <waynenguyen> flo: I think it's possible, considering a user can have max to 50(?) accounts on the machine. 16:06:57 <flo> logiclord: but I think the most obvious benefit of the import feature is if we can do it "magically" during the first start-up 16:07:04 <logiclord> and I will get all these ideas at one place 16:07:08 <flo> to have an awesome first user experience 16:07:15 <logiclord> flo : agreed 16:08:01 <logiclord> will drop an email containing wiki link 16:11:38 <waynenguyen> flo: btw I mostly finish the extension to import usernames/passwords from Firefox to Intantbird :) But now it's done automatically (no UI). 16:17:49 --> igorko has joined #instantbird 16:17:54 <clokep_work> flo: Bug 737466 should we mkae that change in Instantbird as well? 16:18:08 <flo> if it's about the twitter icon, yes 16:18:14 <flo> but wait for Andreas to produce the patch ;) 16:18:25 <clokep_work> Yup! :) 16:18:29 <flo> isn't that icon in chat/ anyway? ;) 16:18:33 <clokep_work> Yes! 16:28:25 <igorko> hi 16:28:39 <igorko> guys What "Map sauvйe existante" does mean? 16:28:52 <igorko> need to translate few french sequences 16:29:12 <flo> that's not french 16:29:23 <clokep_work> translate.google.com? 16:29:32 <flo> except "existante" (which is basically the same word as in English) 16:32:32 <igorko> sauvйe -> sauvee or something like that- It has non ASCII characters 16:32:41 <igorko> and it's French ;) 16:33:00 <igorko> translate.google.com gives such suck 16:33:09 <clokep_work> translate.bing.com? ;) 16:33:10 <igorko> some* 16:38:06 <-- NmN has quit (Quit: Instantbird 1.1) 16:38:26 <clokep_work> aleth: Btw if I say crazy things in my review comments feel free to call me out on it. :) 16:39:33 <-- Keso has quit (Ping timeout) 16:39:34 <aleth> Did you say anything crazy? Thanks for the feedback :) For things like comments, usually the author is not the best judge of what is needed... 16:40:12 <clokep_work> I don't know. :) Usually the one saying crazy things is not the best judge of what's crazy. ;) 16:40:22 <aleth> :D 16:47:00 --> Mook_as has joined #instantbird 16:55:58 <-- flo has quit (Input/output error) 16:56:52 --> flo has joined #instantbird 16:56:52 * ChanServ sets mode +qo flo flo 16:58:23 <-- jb has quit (Quit: jb) 16:58:35 <-- flo has quit (Ping timeout) 17:00:25 --> flo has joined #instantbird 17:06:02 <-- flo has quit (Input/output error) 17:06:10 --> flo has joined #instantbird 17:06:10 * ChanServ sets mode +qo flo flo 17:12:45 --> jb has joined #instantbird 17:28:21 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 17:34:44 * jwir3 is now known as jwir3|away 17:43:19 <-- igorko has quit (Ping timeout) 17:56:48 --> igorko has joined #instantbird 17:58:36 --> Tomek has joined #instantbird 17:58:38 <-- Tomek has quit (Connection reset by peer) 18:00:15 --> Tomek has joined #instantbird 18:06:48 --> gerard-majax has joined #instantbird 18:11:55 <-- gerard-majax has quit (Quit: Ex-Chat) 18:12:10 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com) 18:16:13 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com) 18:27:15 <-- jb has quit (Quit: jb) 18:27:20 <-- jf has quit (Connection reset by peer) 18:27:35 <-- logiclord has quit (Quit: Leaving.) 18:29:22 --> Kaishi has joined #instantbird 18:39:31 --> gerard-majax has joined #instantbird 18:39:38 --> aleth has joined #instantbird 18:39:38 * ChanServ sets mode +h aleth 18:43:07 <-- gerard-majax has quit (Ping timeout) 18:44:56 --> gerard-majax has joined #instantbird 19:04:54 <-- Kaishi has quit (Quit: Instantbird 1.1) 19:07:51 --> Kaishi has joined #instantbird 19:08:16 <-- igorko has quit (Connection reset by peer) 19:08:22 --> igorko has joined #instantbird 19:12:49 <Kaishi> On the latest nightly, I'm getting a connection reset on IRC. Error console points to irc.js 19:13:44 <Kaishi> line 348 even 19:14:01 <Kaishi> oh, well, that's the "connection reset" message 19:14:02 <Kaishi> oops 19:15:13 <Kaishi> Ah, and only with SSL enabled 19:15:25 <Kaishi> do the nightlies check certificates different from release? 19:16:44 <Mook_as> for IRC? yes. 19:16:52 <Kaishi> yes 19:17:02 <Kaishi> do I need to add the cert to a mozilla-specific share? 19:17:04 <Mook_as> (since it no longer uses libpurple for IRC, it uses the Mozilla stack, which does things its way) 19:17:14 <Kaishi> right, that's what I was thinking 19:17:30 <Kaishi> I'm going to import some public keys :3 19:17:40 <Mook_as> Toos, options, advanced, encryption, something like that? 19:18:23 <Kaishi> yeah, already there 19:18:44 <clokep_work> Kaishi: What server are you trying to connect to? 19:18:56 <clokep_work> But yes, we unfortunately don't have the UI to pop up and ask you to import the certs yet. :( 19:19:00 <Kaishi> freenode is one of them 19:19:12 <Kaishi> Naw, that's fine. I don't need a UI for that (the public might but not me) 19:19:23 <Kaishi> I jumped straight to that being the issue, seen stuff like it before. 19:19:32 <clokep_work> Freenode shouldn't have out of date certs, I've never had an issue connecting to them with SSL. :-/ 19:19:38 <clokep_work> Glad you figured it out though. 19:19:49 <Kaishi> confirming now, with a different IRC 19:19:50 <Kaishi> hmm 19:19:52 <clokep_work> (Freenode *DOES*, however, seem to have really crappy SSL support. :P) 19:20:02 <Kaishi> cert was imported into the share successfully >_> 19:21:01 --> Mic has joined #instantbird 19:21:01 * ChanServ sets mode +h Mic 19:21:16 <Mic> Good evening 19:21:29 <Kaishi> is there any way to configure this so actually show me the cert errors? 19:23:38 <clokep_work> What do you mean? 19:24:13 <Kaishi> actually, I got it 19:24:40 <Kaishi> I had imported it without trusting the roles because I imported a root cert into the servers share, and it was assigned to the root share automatically, with no trust 19:24:41 <Kaishi> so 19:24:42 <Kaishi> good 19:24:43 <Kaishi> lol 19:24:57 <Kaishi> Fixed by removing it all and adding back in the right share. 19:26:34 <Kaishi> could it be that the certs in the moz shares are old? not getting anything from freenode. I can import their root CA cert myself but I never needed to before. 19:26:49 <Kaishi> (I did have to import certs for other IRC servers though) 19:27:14 <clokep_work> I don't have to import the root freenode cert. 19:27:22 <clokep_work> I'd more of guess the server you're hitting has something funky on it. 19:27:57 <Kaishi> maybe, but even still, 19:28:03 <Kaishi> I'm not getting in 19:28:17 <Mook_as> yeah, I don't have to do anything funny with freenode either. (but I'm cheating and looking at their IRC server in firefox...) 19:28:21 <Kaishi> I'm hitting their pool, not a specific server 19:28:37 <Mook_as> (i.e. I'm looking at https://chat.freenode.net:6697/ XD ) 19:29:42 <Kaishi> UI question / proposal: 19:29:56 <Kaishi> ability change the IRC server line in the connection properties for the account? 19:30:03 <Kaishi> That would be super helpful 19:30:29 <Kaishi> you could lock the domain and just let the sub-domain be changed. 19:30:47 <Kaishi> gotta head out, back later :) 19:30:47 <clokep_work> I thikn that would be more confusing than anything. 19:30:55 <clokep_work> Plus you'd have to be able to get a list of servers... 19:31:07 <Kaishi> true, but that's what some geeks do >_> 19:31:17 <clokep_work> What is what some geeks do? 19:31:18 <Kaishi> probably not necessary but if I change which pool server I want to use. 19:31:49 <Kaishi> Some geeks look up the list of servers or pools, and then assign a specific one until it breaks, change only when necessary 19:32:04 <Kaishi> If I want to change it, I need to create a whole new account on the list 19:32:56 <Kaishi> I could probably go into my actual profile XML (or equivalent, unsure if it's XML or not) and change it by hand 19:33:06 <clokep_work> Right... 19:33:07 <Kaishi> really must be going though, thanks! 19:33:10 <clokep_work> I understand that part. 19:33:20 <-- Kaishi has quit (Quit: Kaishi) 19:33:25 <clokep_work> But my point is that Instantbird would need to know the list of servers, there's no like standard way of publishing that informaiton... 19:34:06 <Mook_as> I think he just wanted it to be user-editable 19:34:07 <aleth> Kaishi: I'm having no trouble with freenode and SSL on port 7000 19:34:25 <clokep_work> Yes, that's unfortunately how our account types work though. :-/ 19:50:18 --> flo has joined #instantbird 19:50:18 * ChanServ sets mode +qo flo flo 19:59:52 --> mmkmou has joined #instantbird 20:02:00 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 20:26:20 * jwir3|away is now known as jwir3 20:38:22 <-- mmkmou has quit (Ping timeout) 20:42:37 --> mmkmou has joined #instantbird 20:44:20 <-- mmkmou has quit (Ping timeout) 20:48:34 --> mmkmou has joined #instantbird 20:50:16 <-- mmkmou has quit (Ping timeout) 20:59:38 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1265 on bug 1332. 20:59:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1332 nor, --, ---, aletheia2, ASSI, Implement /whois and /whowas commands 21:08:10 <flo> I wonder why google groups has decided logiclord's latest email was spam 21:10:50 <-- flo has quit (Ping timeout) 21:11:04 <Mook_as> wow, google groups ever decides _anything_ is spam? perhaps it got better, but when I admined the songbird one it was horribly spammy. 21:11:36 <Mic> aleth: regarding Bubbles-light: "This message style respects the font setting from the Content tab in Preferences. (To obtain the same font as that of the default Bubbles style, select Lucida Grande or Sans.)" - I didn't find any changes related to that in the diff between the Bubbles theme that we ship and yours. 21:11:50 <aleth> Mic: not any more :D 21:11:59 <aleth> That patch landed last week I think... 21:12:47 <Mic> OK, you can update the add-on description then. I just reviewed both of your add-ons that were waiting. 21:12:55 <aleth> Thanks Mic! 21:13:03 <aleth> I'll update the description after 1.2 is out I think. 21:13:21 <aleth> Good catch. 21:14:57 <aleth> I'd forgotten about that change since I made it so long ago... 21:16:32 --> flo has joined #instantbird 21:16:32 * ChanServ sets mode +qo flo flo 21:22:46 <Mic> aleth: ah, was that the patch I broke by hand-editing it. I think so... 21:23:10 <Mic> Obviously there is a question mark missing somewhere in my last message ;) 21:24:15 <aleth> Yes, it was the one you split in two. 21:24:45 <flo> Mook_as: it decides ~60 messages a day are spam on the instantbird-contact mailing list 21:25:21 <flo> and let lots of spam messages go through, and they end up in the spam folder of the gmail accounts of each us ;) 21:25:55 <Mook_as> maybe it's decided based on other groups - and there are a bunch of spam-only groups? :p 21:27:33 <flo> by the way, I very rarely look in the spam reports of the google group (as gmail often decides these reports are spam anyway) 21:27:44 <flo> so if something ends up in the group's spam, it's usually lost 21:31:10 <flo> are we updating to moz11 tomorrow? Any volunteer to work on it? :-P 21:36:41 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 1254 on bug 1291. 21:36:42 <instantbot> florian@instantbird.org granted review for attachment 1266 on bug 1291. 21:36:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1291 min, --, ---, clokep, ASSI, Source displayed in "entered the room" system messages for JS-IRC is too verbose 21:37:03 --> clokep has joined #instantbird 21:37:03 * ChanServ sets mode +o clokep 21:38:54 <flo> clokep: I'm pushing that patch without testing it at all (my debug build is broken) 21:39:12 <flo> I need to rebuild it from scratch with moz10 21:40:39 <clokep> flo: "that patch"? 21:40:49 <flo> bug 1291 21:40:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1291 min, --, ---, clokep, ASSI, Source displayed in "entered the room" system messages for JS-IRC is too verbose 21:40:57 <clokep> Ah OK. 21:41:15 <clokep> That's fine. 21:41:20 <clokep> Blame is on me if it breaks. 21:50:18 <Mic> flo: did you notice that cloke p started using "[checkin-needed]" in the whiteboard field? 21:50:44 <flo> Mic: yes 21:51:01 <flo> I'm working on that list right now ;) 21:51:35 <clokep> I assumed you had been getting the emails flo. :) 21:52:02 <flo> all these bugs had a star on the bugmail thread already ;) 21:52:19 <flo> but if you do that consistently, I won't need to star emails with an r+ any more 21:52:21 <flo> :) 21:52:35 <Mic> I just wanted to make sure you knew - this flag isn't particularly useful if the one doing the check-ins doesn't know that it is used ;) 21:53:32 <flo> I wonder how difficult it would be for aleth to fix the paths in his patches before uploading them 21:54:43 <clokep> I don't know...if I have an extremely hard time applying a patch that will get a r+ I try to upload a "new" version made from the repo. 21:55:18 <aleth> Is there a list of the mappings somewhere? Then maybe I could write a script. 21:56:31 <flo> not really 21:57:11 <Mic> aleth: you aren't using Mercurial at all at the moment, are you? 21:57:31 <aleth> Mic: I'm not using the repo, that's the problem 21:57:48 <clokep> I know you can't build...but can you use the repo? 21:58:04 <aleth> I can't get hg 21:58:35 <clokep> Ah, OK. 21:58:52 <aleth> Even if I could, it wouldn't really help with the patch problem. 21:59:09 <aleth> Per file, I can find out the correct path via lxr as well of course. 21:59:26 <aleth> But that's not automated... 21:59:49 <clokep> It's not terrible except in the case of themes... 22:00:08 <Mook_as> I imagine http://www.gerv.net/software/patch-maker/ _might_ be useful. 22:00:11 <aleth> Ah, that one. 22:00:21 <Mook_as> (that's the old solution in the mozilla suite days) 22:00:33 <aleth> I think that's the only message style patch 22:00:53 <aleth> But the js-irc paths are probably wrong too 22:01:21 <flo> aleth: they are wrong, but the patch is possible to apply with the right incantations :) 22:01:50 <flo> I used for example: cd chat/protocols/irc/ ; patch -p2 < ../../../attachment.cgi\?id\=1248 ; cd - 22:02:16 <flo> usually I only need patch -p1 < <patchfile> 22:02:52 <flo> or hg import --no-commit if there are changes to binary files or adds/removes/moves 22:03:25 <aleth> flo: So as long as it's not a patch across many different subdirs it's straightforward 22:04:09 <flo> it's more typing :) 22:04:45 <flo> so when the patch only touches one line, it's tempting to go edit that line in the file instead of applying the patch 22:05:12 <aleth> Whatever is easier ;) 22:05:21 <flo> let's see if I can still apply the patch from bug 1344 22:05:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1344 nor, --, ---, florian, ASSI, stop using XPCOM proxies in purpleSockets 22:07:12 <-- chrisccoulson has quit (Quit: Ex-Chat) 22:09:01 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org) 22:10:24 <-- sonny has quit (Quit: Instantbird -- http://www.instantbird.com) 22:12:02 --> sonny has joined #instantbird 22:17:02 --> chrisccoulson has joined #instantbird 22:19:00 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d8f6bac791f9 - aleth - Bug 1328 - /msg <nick> should open an empty conversation tab: Follow-up to 2ea0ec22990e to fix the case of trailing whitespace after a nick, r=clokep. 22:19:02 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/2a8cd922d029 - Patrick Cloke - Bug 1291 - Source displayed in "entered the room" system messages for JS-IRC is too verbose, r=fqueze. 22:19:03 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a52a4269c6a1 - aleth - Bug 1293 - Tooltip improvements for IRC: tweak the order of tooltip lines, r=clokep. 22:19:04 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/75f70f625cd6 - aleth - Bug 1327 - Commands are "not supported" when missing parameters or returning false, r=clokep. 22:19:05 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/62fad134aa55 - Florian Quèze - Bug 1344 - stop using XPCOM proxies in purpleSockets. 22:21:54 <flo> boo, I forgot bug 1308 because it wasn't in the checkin-needed list :( 22:21:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1308 nor, --, ---, nobody, NEW, Errors on joining channel: "Adding a chat buddy twice" 22:23:03 * jwir3 is now known as jwir3|away 22:23:47 <clokep> :( 22:23:48 <clokep> Sorry. 22:23:53 <clokep> I felt like I was missing one... 22:29:33 <flo> uh, my request list is too long :( 22:30:12 <flo> and I'm almost sure some patches in there looked good and had no reason to wait for further comments :( 22:34:07 <-- sonny has quit (Client exited) 22:35:29 <clokep> I'll close those bugs in a few minutes btw. 22:38:16 <instantbot> clokep@gmail.com set the Resolution field on bug 1328 to FIXED. 22:38:19 <flo> thanks :) 22:38:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1328 min, --, 1.2, aletheia2, RESO FIXED, /msg <nick> should open an empty conversation tab 22:38:56 <instantbot> clokep@gmail.com set the Resolution field on bug 1291 to FIXED. 22:39:01 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/5c12cc9e43d4 - aleth - Bug 1308 - Errors on joining channel: 'Adding a chat buddy twice': improve the error message to help debugging, r=fqueze. 22:39:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1291 min, --, 1.2, clokep, RESO FIXED, Source displayed in "entered the room" system messages for JS-IRC is too verbose 22:39:57 <instantbot> clokep@gmail.com set the Resolution field on bug 1293 to FIXED. 22:40:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1293 enh, --, 1.2, clokep, RESO FIXED, Tooltip improvements for IRC 22:41:08 <instantbot> clokep@gmail.com set the Resolution field on bug 1327 to FIXED. 22:41:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1327 nor, --, 1.2, aletheia2, RESO FIXED, Commands are "not supported" when missing parameters or returning false 22:41:58 <instantbot> clokep@gmail.com set the Resolution field on bug 1344 to FIXED. 22:42:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1344 nor, --, 1.2, florian, RESO FIXED, stop using XPCOM proxies in purpleSockets 22:48:34 <clokep> aleth: ping, you here to talk about that patch briefly or should I put things in the bug? 22:48:49 <aleth> clokep: go ahead :) 22:49:24 <clokep> You need to make sure to recreate _observedNicks in the constructor or else all ircChannels will share the same array as it's in the prototype (I believe...) 22:49:25 <aleth> In hindsight I'm not sure all the error messages end up in the server tab. I assumed they did because of the lack of msg.source being set 22:49:46 <clokep> If it uses the errorMessage function it should. 22:50:17 <clokep> In unInit: I think you me if (*!*this._observedNicks.length) 22:50:34 <clokep> Oh wait. 22:50:37 <clokep> No...I get it now, never mind. :) 22:50:46 <clokep> Remove the observer only if it exists... 22:50:55 <aleth> Huh, is that true about the shared prototype? :-O 22:51:10 <clokep> I think so. flo or Mook_as? 22:51:12 <aleth> That sounds like something I should know. 22:51:35 <Mook_as> link to code? 22:51:59 <clokep> Mook_as: https://bugzilla.instantbird.org/attachment.cgi?id=1265&action=diff 22:52:02 <Mook_as> but yes, if Foo.prototype.bar = [];, all instances of Foo will share one .bar until you reassign explicitly 22:52:06 <clokep> irc.js 22:52:22 <Mook_as> https://bugzilla.instantbird.org/attachment.cgi?id=1265&action=diff#a/components/irc.js_sec1 ? 22:52:29 <clokep> Yes. 22:52:33 <clokep> The _observedNicks field. 22:52:51 <Mook_as> yep, you need to create a new one in the constructor (or possibly init if you felt like it) 22:52:55 <aleth> What about http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#195 in that case? 22:53:12 <clokep> It's only for arrays or objects I believe. 22:53:31 <Mook_as> that's fine, because you're not using methods on the boolean 22:53:35 <Mook_as> (/properties) 22:53:47 * aleth is confused 22:53:54 <Mook_as> (i.e. the problem is more .push() in https://bugzilla.instantbird.org/attachment.cgi?id=1265&action=diff#a/components/irc.js_sec3 ) 22:54:26 <clokep> Mook_as: Quick unrelated question, what happens if you attempt to set an observer multiple times? 22:54:35 <clokep> (I.e. addObserver is called multiple times.) 22:54:44 <Mook_as> clokep: typically, only one is registered 22:54:46 <aleth> That's not a problem, I checked. 22:54:57 <clokep> OK. 22:55:22 <clokep> aleth: What is a problem though...is in observe: You remove the observer even if there are still nicks left in this._observedNicks. 22:55:23 <Mook_as> it's underspeced, however, so it's an implementation detail... 22:55:41 <aleth> clokep: This is true :( 22:55:57 <clokep> (And I would prefer not adding the observer unless the length of that array is zero.) 22:56:02 <clokep> Just to make it clear. :) 22:56:39 <Mook_as> s/is/is not/ ? 22:56:59 <clokep> No, "is" is correct. 22:57:17 <clokep> (If the array length is zero it implies there is no observer...) 22:57:20 <Mook_as> okay. since I didn't read the whole patch, that's very plausible :) 22:57:28 <Mook_as> ah, I see what you mean 22:57:42 <clokep> aleth: in writeWhois, please specify RFC *2812* errors 401 and 406. 22:58:02 <clokep> Not that anyone cares about IRC RFCs, but still. :) 22:58:02 <-- Mic has quit (Broken pipe) 22:58:17 --> Mic has joined #instantbird 22:58:17 * ChanServ sets mode +h Mic 22:59:46 <Mook_as> especially not people implementing servers and clients, it seems ;) 22:59:58 <clokep> I think that's it...the only other partial comment I might have is to prefix all the results with \n isntead of postfixing them. 23:00:02 <clokep> It saves you a hanging \n at the end. 23:00:14 <clokep> (Plus removes the one from the msg declaration) 23:00:28 <clokep> Mook_as: I wrote Instantbird directly from the RFC pretty much. :) 23:00:52 <Mook_as> you're the exception that proves the rule? :p 23:01:05 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 23:01:14 --> Mic has joined #instantbird 23:01:14 * ChanServ sets mode +h Mic 23:01:15 <clokep> Yup! 23:01:35 <aleth> JS-IRC. The client that cares. 23:02:46 <aleth> What's the logic between prototype objects being shared, but prototype booleans not? What about e.g. strings? 23:03:32 <aleth> I thought everything was an object... 23:03:34 <Mook_as> prototype booleans _are_ shared 23:03:50 <Mook_as> the thing is, to change the boolean, you clobber it with a different assignment, foo.bar = true; 23:04:06 <Mook_as> (so it now refers to a different object, the literal true) 23:05:24 <aleth> But if you look at http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#195, it looks like _left is supposed to be different in each instance? 23:05:41 <aleth> Is a copy created when you assign it? 23:05:47 <Mook_as> sure, but nobody _really_ cares that all the falses are the same false :) 23:05:57 <aleth> OK. 23:06:10 <Mook_as> pretty much, yeah - it's more that names and instances are completely separate 23:06:42 <Mook_as> var a = {}; a.a = a; 23:06:52 <Mook_as> in C/C++ terms, it's like having a pointer... 23:09:05 <aleth> I'm just surprised there's a difference between this._a = ["hello"] and this._a.push("hello") (where _a: [] as default) 23:10:03 <Mook_as> yeah, new array there. 23:10:28 <aleth> OK. 23:11:25 <aleth> Thanks Mook_as 23:11:37 <Mook_as> you're welcome 23:12:07 <clokep> You can blame Brandon I guess. 23:12:10 <clokep> (Brendon?) 23:12:21 <Mook_as> Brendan? 23:12:28 <clokep> Brendan. 23:12:29 <clokep> Yes. :) 23:12:38 <aleth> In a way it's powerful... just very implicit 23:12:38 <Mook_as> it's also pretty common, I think... 23:12:59 <Mook_as> well, not the prototype bit, I guess. possibly blame self on that, though I've never tried to learn it 23:13:02 * clokep still blames him for not requiring ;s. ;) 23:13:56 * Mook_as agrees 23:16:23 <aleth> Thankfully s/RFC/RFC 2812 gives a line of exactly 80 characters :P 23:16:51 <aleth> Mook_as: Do you know of a way to do multiple inheritance? 23:17:06 <Mook_as> nope! 23:17:25 <Mook_as> hacks mostly involve copy-things-over-in-the-constructor 23:17:30 <-- Tomek has quit (Quit: Instantbird 1.1) 23:17:45 <Mook_as> though I guess these days if you're feeling really adventurous you can try making a Proxy-based one 23:18:27 <Mook_as> (... but the Proxy API is changing, to direct proxies) 23:18:46 <clokep> aleth: I wouldn't worry muvch about that, I'll accept a patch that doesn't do it. But we'll file a follow up for it! 23:19:29 <aleth> clokep: I'm not so much worried, it's just annoying to have to change everything twice ;) 23:21:08 <clokep> Haha. :) 23:21:10 <clokep> touche. 23:22:02 <clokep> I have an idea of how to do it anyway I think... 23:25:42 <aleth> :) 23:26:18 <clokep> And I don't think I can explain it right now. ;) The gin has taken over. :P 23:29:03 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1265 on bug 1332. 23:29:04 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1267 on bug 1332. 23:29:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1332 nor, --, ---, aletheia2, ASSI, Implement /whois and /whowas commands 23:30:02 <Mic> pff, I marked all this bugspam as read only a minute ago.. ;) 23:30:36 <aleth> Sorry Mic, that patch keeps getting longer ;) 23:34:56 <clokep> aleth: I think this looks good. 23:34:59 <clokep> I need to try it though. 23:35:23 <aleth> I'm off now anyway 23:35:38 <clokep> Thanks. :) 23:40:19 --> Kaishi has joined #instantbird 23:46:38 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1267 on bug 1332. 23:46:40 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1268 on bug 1332. 23:46:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1332 nor, --, ---, aletheia2, ASSI, Implement /whois and /whowas commands 23:46:56 * aleth dislikes discovering little bugs while heading off 23:47:59 <aleth> Funny how that happens... 23:48:44 <clokep> Yes. :) 23:49:27 <-- aleth has quit (Input/output error) 23:55:03 <Mic> Good night 23:55:07 <clokep> Goodnight Mic. 23:55:27 <-- Mic has quit (Input/output error)