#instantbird log on 02 27 2012

All times are UTC.

00:10:04 --> mmkmou has joined #instantbird
00:12:41 <-- mmkmou has quit (Ping timeout)
00:17:37 <-- Tomek has quit (Quit: Instantbird 1.1)
01:17:45 <-- Tonnes has quit (Ping timeout)
01:20:32 --> Tonnes has joined #instantbird
01:37:25 --> clokep has joined #instantbird
01:37:25 * ChanServ sets mode +o clokep 
01:41:10 <clokep> flo: Yes I think freenode's servers have funky settings, as I said moznet reconnects fine.
01:47:47 <clokep> flo: My next patch is going to disable SSl as the default.
01:47:52 <clokep> I think that's the way to go.
01:52:02 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
02:07:39 <-- Tonnes has quit (Ping timeout)
02:10:00 --> Tonnes has joined #instantbird
02:21:09 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1203 on bug 507.
02:21:10 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1204 on bug 507.
02:21:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=507 enh, --, ---, clokep, ASSI, Implement IRC in JavaScript
03:09:46 --> Even3 has joined #instantbird
03:09:59 <-- Even1 has quit (Ping timeout)
03:37:48 --> Plop has joined #instantbird
03:54:29 <instant-buildbot> build #408 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/408
04:23:55 <-- Tonnes has quit (Ping timeout)
04:41:50 --> ricardofmoreira has joined #instantbird
04:54:15 <-- ricardofmoreira has quit (Quit: Ex-Chat)
05:08:26 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
05:28:03 <instant-buildbot> build #495 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/495
05:49:44 --> jb has joined #instantbird
06:52:15 <instant-buildbot> build #400 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/400
07:02:39 --> Tonnes has joined #instantbird
07:13:51 --> skeledrew has joined #instantbird
08:23:20 --> MadWookiee has joined #instantbird
08:47:05 <-- Plop has quit (Ping timeout)
08:51:26 <-- MadWookiee has quit (Ping timeout)
08:51:30 --> MadWookiee has joined #instantbird
08:54:09 <-- Even2 has quit (Quit: Instantbird 1.2a1pre)
08:54:15 --> Even1 has joined #instantbird
08:56:29 <-- MadWookiee has quit (Ping timeout)
08:58:18 --> MadWookiee has joined #instantbird
09:06:29 <-- MadWookiee has quit (Connection reset by peer)
09:09:13 --> MadWookiee has joined #instantbird
09:18:33 --> chrisccoulson has joined #instantbird
09:32:19 --> mmkmou has joined #instantbird
09:48:24 --> flo has joined #instantbird
09:48:24 * ChanServ sets mode +qo flo flo 
10:00:20 <flo> "00:14:41 - testib [<i>testib!~Instantbi@</i>] entered the room." :(
10:00:48 --> aleth has joined #instantbird
10:00:48 * ChanServ sets mode +h aleth 
10:02:05 <-- Even has quit (Quit: Instantbird 1.2a1pre)
10:02:15 --> Even has joined #instantbird
10:02:15 * ChanServ sets mode +o Even 
10:06:03 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
10:06:11 --> aleth has joined #instantbird
10:06:11 * ChanServ sets mode +h aleth 
10:06:41 <flo> "file.append(this._conv.normalizedName + (this._conv.isChat ? ".chat" : ""));" means we won't be able to find twitter timeline logs any more. Not sure if we should add an ugly special case for that :-S
10:09:06 <aleth> Why do you need to append .chat in the first place? Can't it be a flag inside the file?
10:10:17 <aleth> Though I suppose that's just as much of a change :-/
10:15:55 <aleth> It should be backwards compatible I think.
10:40:44 <flo> aleth: mostly so that you don't end up mixing private conversations with MUCs for protocols where both contact names and MUC names share the same format
10:41:12 <flo> aleth: we definitely don't want to have to open each file in a folder to list the logs of previous similar conversations
10:42:42 <flo> I don't see how we can easily fix that <i> thing on "entered the room" messages :-/
10:43:26 <aleth> Right. I didn't realize you meant the folder names rather than the file names.
10:47:07 <flo> I'm tempted to just remove the <i> tag from the string and give up on the hostname being italic
11:17:51 --> clokep has joined #instantbird
11:17:51 * ChanServ sets mode +o clokep 
11:18:03 <flo> clokep: hello :)
11:18:30 <clokep> Hello flo.
11:18:31 <flo> what do you think of http://pastebin.instantbird.com/14158 ?
11:18:58 <flo> would you prefer that we instead add the .chat from the irc code? (so as to not have the twitter-specific case in logger.js)
11:19:38 <flo> any simple idea to not show the <i> in the conversation window but still have the italic formatting?
11:20:10 <flo> (and by the way, sorry for throwing so many questions at you when you just wake up :))
11:20:40 <clokep> I thought of the Twitter issue btw...
11:20:53 <clokep> One second.
11:21:19 <clokep> flo: Is that pastebin diff reversed?
11:21:25 <clokep> (Is the --- supposed to be the +++?)
11:21:29 <flo> yes
11:21:41 <clokep> OK. :)
11:21:57 <flo> it's easy to get the order of the parameters to interdiff wrong :)
11:23:16 <clokep> I think I'd prefer if we could migrate the Twitter case instead of special casing it, I don't really want to add the ".chat" to the IRC code, it's an artifact of the logging code to me.
11:24:43 <flo> what do you mean with "migrate" exactly?
11:25:26 <clokep> Move the folder from "@clokep timeline" to "@clokep timeline.chat"
11:25:49 <clokep> Bah I just checked and I have 3 folders in my profile for it..."twitter timeline", "clokep timeline" and "@clokep timeline" :(
11:25:52 <flo> I think the real problem here is that twitter abuses a MUC object for its timeline
11:25:58 <clokep> Oh and clokeptimeline
11:26:23 <clokep> Ah, my bad there isn't one with a space.
11:26:57 <clokep> Yes, it is.
11:27:03 <clokep> Then I'm OK special casing it. :)
11:27:08 <flo> + at some point "timeline" was localized ;)
11:27:27 <flo> it should probably become <name>.timeline with timeline not localized
11:27:38 <flo> I think we already prevented the localization of it at some point
11:29:03 <clokep> Yes, I believe you fixed that.
11:29:10 <clokep> OK, I'll r+ the special case then. :)
11:29:25 <clokep> And not having the <i>...
11:29:34 <clokep> At one point I thought that worked, but hmmm....
11:30:26 <clokep> I won't be broken up just removing them, I dislike having them available to localizers anyway.
11:40:05 <-- MadWookiee has quit (Ping timeout)
11:41:45 <flo> it worked until I HTML-escaped the messages
11:42:08 <flo> when the <i> in these messages worked, it also worked in messages of the conversation...
11:42:17 <clokep> Right.
11:42:29 * clokep wonders if the IRC italic flag would work.
11:43:36 <clokep> Or just remove it, yeah. :)
11:55:55 <clokep> flo: We could also add a "getLogFileName" to the imIConversation object if we want to special case Twitter...
11:59:14 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
12:20:33 <-- Even has quit (Connection reset by peer)
12:29:05 --> MadWookiee has joined #instantbird
12:29:51 --> Even has joined #instantbird
12:29:51 * ChanServ sets mode +o Even 
12:37:41 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
12:44:08 <-- Even has quit (Connection reset by peer)
12:52:29 --> clokep_work has joined #instantbird
12:52:29 * ChanServ sets mode +o clokep_work 
12:55:57 <-- jb has quit (Ping timeout)
12:57:30 <flo> clokep_work: so if I understood correctly, you said to just take what's in the pastebin?
12:59:01 <clokep_work> flo: Yes, r+ from me.
12:59:04 <flo> ok
12:59:17 <clokep_work> Unless it'll be included in the IRC patch. :P
12:59:20 <flo> I'll retry with my debug profile, and land it after that if I don't find more issues
12:59:21 <clokep_work> Then you don't need my IRC.
12:59:34 <flo> uh, what?
13:00:06 <-- flo has quit (Quit: Instantbird 1.2a1pre)
13:00:30 --> flo has joined #instantbird
13:00:31 * ChanServ sets mode +qo flo flo 
13:01:29 * flo is on JS-IRC
13:01:41 <flo> errr, what's that?
13:01:46 <clokep_work> What's what?
13:02:45 <flo> http://i.imgur.com/szrnP.png
13:04:36 <clokep_work> Uhh...that's interesting.
13:06:22 <clokep_work> The /me command must use a slightly different code path. :-/
13:06:40 --> jb has joined #instantbird
13:07:04 <flo> probably slightly broken too ;)
13:08:44 <clokep_work> Yes...
13:09:19 --> florian has joined #instantbird
13:09:19 * ChanServ sets mode +qo florian florian 
13:09:25 * florian tests
13:09:34 <flo> it's only for outgoing messages
13:09:52 <clokep_work> Yes, that's what I'd expect one second.
13:10:27 <flo> "14:09:19 - florian [florian!Instantbir@moz-87C33FDA.kimsufi.com] entered the room." is this expected? Why is the nick there?
13:11:35 <clokep_work> I'm not sure what you mean.
13:11:40 <clokep_work> Yes, that's expected.
13:12:04 <flo> why [florian!Instantbir@moz-87C33FDA.kimsufi.com] ? I think libpurple showed [Instantbir@moz-87C33FDA.kimsufi.com]
13:13:46 <clokep_work> flo: This is the corrected actionCommand method for ircCommands.jsm: http://pastebin.instantbird.com/14178
13:13:50 <clokep_work> (Untested, of course.)
13:14:40 <flo> why isn't aConv directly usable?
13:16:05 <clokep_work> Because writeMessage is an IRC implementation detail, it's not part of the interface.
13:16:19 <flo> but to get the nick?
13:16:38 <clokep_work> Or you mean this? http://pastebin.instantbird.com/14179
13:16:52 <flo> that's what I was about to write
13:17:04 <clokep_work> Yeah, that will work too. :)
13:17:06 <flo> although I don't think that can work for private messages
13:17:11 <clokep_work> I forgot nick was on the interface.
13:17:21 <clokep_work> How come?
13:17:27 <flo> nick is on prplIConvChat
13:18:38 --> jb1 has joined #instantbird
13:19:05 <flo> isn't what we want rather getAccount(aConv)._nickname ?
13:19:11 <clokep_work> flo: http://pastebin.instantbird.com/14180
13:19:13 <flo> (of course with an |account| variable)
13:19:36 <-- jb has quit (Ping timeout)
13:19:46 <flo> we got the same idea it seems :)
13:19:56 <flo> account._nickname.nick? really?
13:20:22 <clokep_work> http://pastebin.instantbird.com/14181
13:20:39 <flo> ok
13:20:40 <clokep_work> Sorry, I'm writing this in pastebin. Not the nicest enivonrment. :)
13:20:51 <flo> it's just s/name/_nickname/ compared to the existing code
13:21:10 <flo> I won't copy your change of removing the semi colon at the end of the account line ;)
13:22:02 <clokep_work> Thanks. :)
13:22:31 <clokep_work> If libpurple prints out just the second 2/3rds of that line, we can change it to that.
13:22:32 <flo> I'm still confused by the "entered the room" messages
13:22:42 <clokep_work> I think I just directly use the "source" attribute of the message.
13:22:55 <flo> I don't see why they are formatted like: <nick> [<nick>!<source>] entered the room."
13:22:57 <clokep_work> And diddn't closely look at what libpurple does.
13:23:23 <clokep_work> Does that mean you're confused at what the code is doing or why I chose to display it that way?
13:24:15 <flo> that means I suspect the parsing code is somehow broken and puts "nick!source" in the source JS value
13:25:12 <clokep_work> No.
13:25:15 <clokep_work> The parsing code is NOT broken.
13:25:21 <clokep_work> That is ALL part of the source.
13:25:35 <clokep_work> source = nick!user@host
13:25:44 <flo> ok...
13:26:00 <flo> do we have an easy way to display the user@host part in that message?
13:26:20 <clokep_work> aMessage.user + "@" aMessage.host? ;)
13:26:40 <clokep_work> (Btw "source" is a term I pretty much made up, it's generated from the "prefix" defined in the RFC.)
13:26:44 <flo> 100% sure neither will ever be empty? :)
13:27:16 <clokep_work> No, they're optional.
13:27:25 <clokep_work> Both are optional.
13:27:34 <flo> O_o
13:27:36 <clokep_work> Probably why I just stuck the entire source in there, there has to at least be a nick.
13:28:02 <flo> if we don't know any additional info, we should just not display the [<info>] part
13:28:09 <clokep_work> prefix     =  servername / ( nickname [ [ "!" user ] "@" host ] ) from http://tools.ietf.org/html/rfc2812#section-2.3.1
13:28:33 <flo> ok
13:30:20 <flo> http://i.imgur.com/B1MZr.png doesn't look good (it's how I noticed something wasn't as usual :-D)
13:30:35 <clokep_work> I agree, it's strange. :-/
13:30:55 <-- florian has left #instantbird (ok, one flo here is enough)
13:32:10 <clokep_work> You really want |let source = (aMessage.user ? aMessage.user : "") + (aMessage.user && aMessage.host ? "@" : "") + (aMessage.host ? aMessage.host : "")
13:32:13 <clokep_work> Or something like that.
13:33:24 <clokep_work> (I'm not against adding that to the message object if you can come up with a good name for that. ;))
13:33:25 <flo> |aMessage.host ? aMessage.host : ""| can be shortened to |aMessage.host || ""|
13:33:33 <flo> source ?
13:33:35 <clokep_work> Ah, right. :)
13:33:39 <flo> is the source used for anything else?
13:33:50 <clokep_work> Yes, it is also used only when there is a server name.
13:34:39 <clokep_work> (It's possible we should call what is currently source prefix, change source to mean what you want and if the nick/user/host is not matched, then store prefix as servername.)
13:34:45 <clokep_work> I thought about doing this at one point, but decided not to.
13:36:15 <flo> I'm even more confused now. I think I'll let you sort it out in a follow up ;)
13:36:40 <clokep_work> OK. :) I like that.
13:37:01 <-- flo has left #instantbird ()
13:37:49 --> flo has joined #instantbird
13:37:49 * ChanServ sets mode +qo flo flo 
13:38:57 * flo tests again
13:39:01 <flo> ah :)
13:39:59 <flo> ok, that fix works
13:40:13 * clokep_work wonders what fix...
13:40:45 <flo> the fix for the /me username
13:41:04 <flo> "13:37:01 <-- flo has left #instantbird ()" why is there no quit message at http://log.bezut.info/instantbird/today#m201 ?
13:42:10 <clokep_work> :(
13:42:28 <flo> or why is it "has left conversation" instead of "has quit"?
13:42:49 <flo> probably something not in the right order in the shutdown sequence
13:45:22 <clokep_work> Or we're displaying the wrong thing.
13:45:31 <clokep_work> Did you actually receive a quit message or a part message?
13:45:48 <flo> I just pressed Command+Q
13:49:21 <clokep_work> I meant on the receiving side. :)
13:49:32 <clokep_work> e.g. with another account connected.
13:49:53 <clokep_work> But yes, I got that you left also.
13:50:17 <clokep_work> It shouldn't part conversations unless the conversations are closed when you press Command+Q before the application is quit?
13:50:32 <flo> the receiving side is instantbot ...
13:50:34 <clokep_work>  / the account is disconnected
13:51:08 <flo> the conversation probably receives an .unInit call, not a .close call in that case
13:55:38 <clokep_work> Hmmm...I see.
13:55:58 <clokep_work> Would the account receive a disconnect than an unInit call?
13:57:32 <flo> I don't know
13:57:47 <flo> but the problem is probably on the conversation, not the account
14:18:33 <flo> ok, time to land I think
14:18:35 <flo>  47 files changed, 3841 insertions(+), 4685 deletions(-)
14:22:18 <instantbot> florian@instantbird.org granted review for attachment 1204 on bug 507.
14:22:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=507 enh, --, ---, clokep, ASSI, Implement IRC in JavaScript
14:26:32 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/920499b108a1 - Patrick Cloke - Bug 507 - Implement IRC in JavaScript, r=fqueze.
14:30:24 <instantbot> florian@instantbird.org set the Resolution field on bug 507 to FIXED.
14:30:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=507 enh, --, 1.2, clokep, RESO FIXED, Implement IRC in JavaScript
14:32:19 <flo> bugspam in lots of dependent bugs ;)
14:33:18 <-- skeledrew has quit (Ping timeout)
14:37:28 <clokep_work> :-D
14:37:32 <clokep_work> Bah, 19 unread emails hahah.
14:38:17 <clokep_work> bug 188 should magically be fixed now btw.
14:38:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=188 nor, --, ---, clokep, ASSI, Private IRC messages using "/msg" don't appear in chat window
14:38:50 <flo> it's fixed, yes
14:39:07 <flo> not sure how magically so :-)
14:39:21 <clokep_work> I meant with no additional work. :)
14:39:21 --> Even has joined #instantbird
14:39:21 * ChanServ sets mode +o Even 
14:39:29 <-- Even has quit (Quit: Instantbird 1.2a1pre)
14:39:38 --> Even has joined #instantbird
14:39:38 * ChanServ sets mode +o Even 
14:40:54 <clokep_work> I guess I should file some follow ups.
14:41:23 <clokep_work> Is that now WORKSFORME or FIXED. ;)
14:42:00 <flo> FIXED if you can point to the bug where a commit fixed it. (I suspect you can)
14:44:01 <instantbot> clokep@gmail.com set the Resolution field on bug 188 to FIXED.
14:44:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=188 nor, --, ---, clokep, RESO FIXED, Private IRC messages using "/msg" don't appear in chat window
14:49:02 <clokep_work> flo: Do we also do bug 1149 currently?
14:49:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1149 min, --, ---, nobody, NEW, Automatically use public alias as "real name" in IRC
14:49:24 <flo> I think so, but I haven't verified recently
14:52:35 <clokep_work> OK. :)
14:54:06 <-- jb1 has quit (Ping timeout)
14:56:51 --> testtb has joined #instantbird
14:57:17 <clokep_work> We do: |this._realname = this.imAccount.statusInfo.displayName;|
14:57:22 <testtb> hey
14:57:49 <flo> clokep_work: I think you can resolve it as fixed :)
14:58:10 * testtb is now known as florian-tb
14:58:23 --> jb has joined #instantbird
14:58:26 <instantbot> clokep@gmail.com set the Resolution field on bug 1149 to FIXED.
14:58:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1149 min, --, 1.2, clokep, RESO FIXED, Automatically use public alias as "real name" in IRC
14:59:53 * clokep_work goes to add IRC under purplexpcom.
15:00:23 <flo> what about adding "chat" next to UI and purplexpcom?
15:00:45 <clokep_work> We could do that.
15:01:03 <clokep_work> I don't think I have permissions to do that.
15:01:30 <flo> or rename "purplexpcom" to "core" and have a "libpurple" component
15:01:30 --> skeledrew has joined #instantbird
15:01:37 <clokep_work> Ah I do, was just on the wrong menu.
15:02:02 <clokep_work> I think I like that better...
15:02:11 <flo> what's the easier to understand for a newbie? core or back-end?
15:02:29 <clokep_work> I think "Core"?
15:03:20 <flo> http://i.imgur.com/cedZt.png
15:06:10 <clokep_work> flo: Very nice! :)
15:06:17 <clokep_work> Can you  move a component between products in Bugzilla?
15:06:32 <flo> I don't know
15:16:05 <clokep_work> Apparently the way to move a component is: http://bzr.mozilla.org/bmo/4.0/annotate/head:/contrib/reorg-tools/movecomponent.pl
15:19:00 <flo> I don't really read perl ;)
15:21:02 <clokep_work> I'll probably just make new components and mass move the bugs.
15:21:13 <flo> how many are there?
15:21:25 <flo> (or what are you trying to move?)
15:21:25 <clokep_work> Twitter and XMPP need to be moved.
15:21:28 <clokep_work> So not a big deal.
15:21:39 <flo> from/to ?
15:23:29 <clokep_work> from purplexpcom to Core.
15:24:44 <flo> ah
15:24:53 <flo> I thought you jsut wnated to rename purplexpcom to Core
15:25:59 <clokep_work> Ah, that would work too. :)
15:27:59 <flo> during my reviews I should have said something about irc.js containing 2 comments mentioning Instantbird
15:29:23 --> aleth has joined #instantbird
15:29:23 * ChanServ sets mode +h aleth 
15:29:57 <clokep_work> I'll fix them in a followup.
15:30:22 <flo> + what they say seems just wrong, as I had you change that behavior between 2 of the patches :-/
15:33:07 <flo> clokep_work: http://pastebin.instantbird.com/14200
15:34:17 --> igorko has joined #instantbird
15:36:29 <clokep_work> flo: That looks OK, you should probably change the \r\n to be a just \n too.
15:36:49 <flo> sure :)
15:37:02 <flo> or to just a comma
15:37:17 <clokep_work> Yeah.
15:39:52 <flo> hmm, why the removal of the target milestone on bug 1149?
15:39:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1149 min, --, ---, clokep, RESO FIXED, Automatically use public alias as "real name" in IRC
15:40:12 <flo> same for bug 188
15:40:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=188 nor, --, ---, clokep, RESO FIXED, Private IRC messages using "/msg" don't appear in chat window
15:40:51 <-- Tobin has quit (Quit: And the rain will kill us all / If we throw ourselves against the wall / But no one else can see / The preservation of the martyr in me)
15:41:01 --> Tobin has joined #instantbird
15:41:21 <clokep_work> flo: Because you can't move to a new component without clearing the target milestone. :(
15:41:24 <clokep_work> I've added them back.
15:41:40 <flo> it's bugspam day :)
15:47:23 <clokep_work> Yes, it is. :-/
15:47:34 * clokep_work wonders if GTalk and Facebook should have separate Components from XMPP?
15:48:09 <flo> if we expect more than a handful of bugs in each of them, yes
15:48:13 <flo> I don't think we currently need them
15:48:28 <clokep_work> OK. :)
15:52:00 <-- igorko has quit (Ping timeout)
15:57:53 <clokep_work> We'll probably need to retriage some of those IRC issues tomorrow, see if they still exist.
15:58:20 <flo> if we aren't busy with new issues tomorrow :)
15:59:06 <clokep_work> I'm assuming you already handled what was pastebinned for those comments? I don't need to file a bug for that.
15:59:18 <flo> right
16:01:56 --> igorko has joined #instantbird
16:10:10 <clokep_work> flo: What are the tooltip improvements? :P
16:13:43 <flo> I would like to see the "is connected with SSL" and "is identified" information as they are important for security (it's the only way to know you are actually talking to the person owning the nick)
16:14:38 <flo> and I think we can simplify the tooltip significantly to make them readable by someone who isn't a computer programmer ;)
16:14:47 <clokep_work> Probably. :)
16:15:07 <clokep_work> The reason I didn't include those btw is that they're not in the spec and I didn't yet look into how supported they are, etc.
16:15:27 <clokep_work>  / I didn't think about whether I want ircBase to include non-speced stuff or stuff like that...
16:15:29 <flo> you don't need to justify yourself :)
16:16:17 <flo> example of simplifications: drop the "Server" line
16:17:20 <clokep_work> Mmhmm.
16:17:35 <flo> merge "Real Name" and "Username"  into a single line labeled "Name" containing both: <name1> (<name2>)
16:17:35 <flo> (not sure which one should be displayed first, as the way they are used doesn't seem consistent across clients; but the difference between them is mostly irrelevant to users)
16:17:46 * clokep_work wants to start working on his IRC Extras add-on. :)
16:18:02 <flo> I think the "Host name" line is also non-sense for a "normal" user.
16:18:12 <clokep_work> I agree.
16:18:13 <flo> I would be a bit frustrated to drop it though, as I like reading it
16:18:32 <flo> maybe we can change the label though
16:18:37 <clokep_work> Pretty much anything you tell me to drop I'm going to put into an add-on that essentially tries to display as much information as possible.
16:18:41 <flo> "Connected from" seems more understandable than "Host name"
16:18:59 <clokep_work> (Not just about tooltips, in general.)
16:19:24 <clokep_work> (And I didn't mean that to sound aggressive! I agree, most users don't care about this stuff, but I do...now. :P)
16:19:58 <flo> ""Connected from" seems more understandable than "Host name"" do you think that would help?
16:20:07 <clokep_work> Yes.
16:20:23 <flo> if we can make the line understandable, maybe we don't need to drop it :)
16:21:43 <clokep_work> Well, it's really "Connected to" not "Connected from".
16:21:48 <clokep_work> It's the server they're connected to.
16:22:10 <flo> I was talking about the "Host name" line
16:23:12 <clokep_work> Ah, sorry.
16:23:12 <flo> I also think that changing the order of the lines could help
16:23:16 * clokep_work was thinking server...
16:24:40 <flo> ah, I think I know 714733 too now :)
16:28:23 <flo> these tooltips need a more serious redesign anyway...
16:28:35 <flo> but I think we can take care of the low hanging fruits for 1.2 :)
16:28:39 <flo> (at least for IRC)
16:29:35 <clokep_work> Yes.
16:29:41 <clokep_work> IU think there's a bug about redesiging the tooltips
16:29:55 <flo> I think I even filed a dup of it at some point :)
16:31:13 <-- igorko has quit (Connection reset by peer)
16:31:50 <aleth> I see from the massive amount of bugspam that JS-IRC has landed :)
16:32:02 <aleth> Congratulations! Looking forward to seeing it in action :D
16:33:45 <clokep_work> Thanks aleth. :)
16:33:47 <clokep_work> Me too.
16:33:51 <clokep_work> Hopefully there's not too many bugs!
16:34:26 <clokep_work> Everyone should feel free to go fix their favorite IRC bug now. :P
16:34:42 <flo> my favorite irc bug is already fixed
16:35:10 <flo> the code as currently landed is able to display mixed UTF8 and iso8859-1 messages successfuly
16:35:28 <flo> and doesn't show auto-reply messages at all, so I won't be annoyed any more by it being shown after each message :-P
16:35:54 <flo> anyway, I've got to go. Good luck for the next nightly (and my Thunderbird try server build with IRC :-S)
16:35:56 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)
16:37:30 <-- florian-tb has quit (Ping timeout)
16:41:15 <clokep_work> I guess that means we're not having a meeting today. :P
16:45:16 <clokep_work> (We still can if people are around. I should be here...)
16:48:38 --> wesj has joined #instantbird
16:53:39 --> igorko has joined #instantbird
17:27:51 --> myk has joined #instantbird
17:55:00 --> Mook_as has joined #instantbird
17:56:15 <-- myk has quit (Ping timeout)
17:56:20 --> myk has joined #instantbird
17:56:57 <Mook_as> \o/, that is all.
17:57:48 <clokep_work> Mook_as: Now you can finish your patch for invites. ;)
17:58:02 <Mook_as> hehe
17:58:12 <Mook_as> but I don't actually use invites anymore... :p
17:58:51 <clokep_work> Ah, so...never mind.
17:58:57 <clokep_work> You can go add some other obscure feature then. :P
18:00:05 <Mook_as> yeah, I'm sure I 'll end up doing that
18:00:34 <Mook_as> hopefully by testing {moznet=unreal, freenode, rizon, and whatever oftc uses}
18:01:44 <clokep_work> What does rizon use?
18:02:13 <Mook_as> I assume their own bastardized server; everybody else at that scale seems to have one
18:02:20 <clokep_work> Yes.
18:02:26 <clokep_work> Freenode runs ircd-seven now I think.
18:03:37 <clokep_work> rizon uses "Plexus IRCd", "coded specifically with Rizon in mind" based on Hybrid though.
18:04:17 <clokep_work> And oftc uses a custom daemon. :(
18:04:21 <clokep_work> Silly, silly.
18:04:41 <clokep_work> (Although it's called "oftc-hybrid" which imples to me it's based off hybrid.)
18:08:41 * Mook_as needs to figure out how to script instantbird now
18:08:52 <clokep_work> Script it to do what?
18:09:19 <Mook_as> things like /nickserv identify on connect... or reconnect... or whenever nickserv feels like being annoying :p
18:12:28 <clokep_work> Ah.
18:12:39 <clokep_work> I want to just handle services in general so you don't have to script stuff. :P
18:12:45 <clokep_work> There's a bug filed somewhere for it.
18:15:44 <Mook_as> I also have odd things in Cz like "this guy should _never_ be able to hightlight me", though I guess that's more extension-land (and perhaps cross-protocol)
18:38:10 <-- MadWookiee has quit (Quit: Instantbird 1.1)
18:46:28 <clokep_work> You might be able to do that in Highlight. :)
18:56:07 --> gerard-majax has joined #instantbird
18:57:21 <-- mmkmou has quit (Ping timeout)
19:04:39 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
19:08:18 <-- gerard-majax has quit (Ping timeout)
19:11:06 <-- Tobin has quit (Quit: And the rain will kill us all / If we throw ourselves against the wall / But no one else can see / The preservation of the martyr in me)
19:11:15 --> Tobin has joined #instantbird
19:18:26 <-- skeledrew has quit (Ping timeout)
19:49:46 --> Mnyromyr has joined #instantbird
19:56:40 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:06:06 --> clokep_work has joined #instantbird
20:06:06 * ChanServ sets mode +o clokep_work 
20:23:02 <-- igorko has quit (Connection reset by peer)
20:25:39 <-- myk has quit (Quit: Instantbird 1.1)
20:25:43 --> myk has joined #instantbird
20:27:27 <-- myk has quit (Ping timeout)
20:28:03 --> myk has joined #instantbird
20:33:16 --> igorko has joined #instantbird
20:33:29 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
21:03:48 --> Plop has joined #instantbird
21:04:58 --> flo has joined #instantbird
21:04:58 * ChanServ sets mode +qo flo flo 
21:09:05 --> aleth has joined #instantbird
21:09:05 * ChanServ sets mode +h aleth 
21:16:13 <flo> sorry for skipping the "meeting"
21:16:56 <flo> I didn't remember it, like almost every week, but usually I forget it in front of my computer :-D
21:18:35 <clokep_work> flo: It's OK, no one seems to have been around today anyway. :)
21:23:21 --> jb1 has joined #instantbird
21:23:32 <clokep_work> Do we have anything to discuss? :-D
21:23:51 <-- jb has quit (Ping timeout)
21:25:04 <flo> I think we have already discussed IRC for a long while during the last few days
21:25:50 <flo> the switch to moz10 may need some discussion, but it's mostly a matter of just doing it
21:25:51 <aleth> 1.2 seems a big step closer with JS-IRC landed (fingers crossed)
21:27:12 <flo> the sw:1.2 list doesn't seem shorter to me though :-/
21:27:15 <-- jb1 has quit (Ping timeout)
21:27:27 <clokep_work> I think we actually made it longer. :(
21:27:42 <clokep_work> A couple of the IRC things are fairly simple and I'll try to do them tonight. :)
21:28:12 <-- Mnyromyr has quit (Input/output error)
21:28:14 <flo> I'm not worried by things like bug 1291
21:28:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1291 min, --, ---, clokep, ASSI, Source displayed in "entered the room" system messages for JS-IRC is too verbose
21:28:26 <clokep_work> I tested Mozilla 10 with those two patches I posted and things seemed to work...but I only briefly tested it.
21:29:15 <flo> usually the difficult part of upgrading mozilla is figuring out how to make it build for PPC ;)
21:29:19 <aleth> You are planning to redo the tooltips before 1.2? There are a lot of bugs connected to that...
21:29:26 <flo> no
21:29:43 <aleth> Just asking because 1293 is on the list
21:29:53 <clokep_work> instantbot: bug 1293
21:29:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1293 enh, --, ---, clokep, ASSI, Tooltip improvements for IRC
21:30:00 <flo> that bug is just about making IRC whois results more readable
21:30:13 <clokep_work> It has nothing to do with the tooltip binding, just the information IRC provides to it.
21:30:21 <aleth> ah ok.
21:30:27 <flo> turning our crappy tooltips into something that we are proud to show screenshots of is for another release
21:30:36 --> Mnyromyr has joined #instantbird
21:30:44 <aleth> I was surprised.
21:31:14 <clokep_work> By that bug?
21:31:17 <flo> anyway, I don't even read the 1.2-wanted list any more at this point :(
21:31:41 --> mmkmou has joined #instantbird
21:32:03 <aleth> clokep_work: Just the title, didn't realise it was a smaller thing.
21:32:05 <flo> although I'll try to get fixed before 1.2 all those that have mostly correct patches in my review queue of course
21:33:05 <clokep_work> :)
21:33:28 <flo> I guess that bug is more a todo than a real bug report. (the problem isn't clearly defined, etc...)
21:33:52 <-- mmkmou has quit (Ping timeout)
21:33:55 <flo> I suspect developers are allowed to do that providing they intend to provide the fix themselves :)
21:34:07 --> mmkmou has joined #instantbird
21:34:09 <clokep_work> It's already assigned. :P
21:34:14 <flo> (and there's general agreement that it's an improvement)
21:34:42 <clokep_work> Btw, we might have an influx of SSL errors again if people are connecting to IRC servers w/ self signed certs.
21:36:02 <flo> it's sad to ship with known crashers, but I'm not sure bug 1017 really blocks
21:36:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1017 cri, --, 1.2, florian, REOP, Shutdown crash [@ purple_blist_node_set_ui_data ]
21:36:50 <flo> right. That ssl self-signed certs mess sucks :(
21:37:07 <clokep_work> Did we ever figure out the shutdown crash on Windows? (Is that that ^ ^ crash?)
21:38:08 <flo> the shutdown crash that happened all the time was fixed
21:38:21 * clokep_work still crashes every time.
21:38:27 <flo> we currently have a shutdown crash in the JS engine that happens relatively frequently but not all the time
21:38:33 <flo> clokep_work: do you still send crash reports all the time?
21:38:36 <clokep_work> Ah, yeah. That gets me every time.
21:38:37 <clokep_work> Yes.
21:38:54 <clokep_work> I had been putting my name in them, but nto the past few days (if they even went through with the weird proxy crap I had on vacation).
21:39:01 <flo> http://crash-stats.instantbird.com/query/query?product=Instantbird&version=ALL%3AALL&date=&range_value=1&range_unit=weeks&query_search=signature&query_type=exact&query=&build_id=&process_type=all&do_query=1
21:40:32 <clokep_work> Seems like it's the JS engine one I get yes.
21:40:44 <clokep_work> (i.e. the #1 crasher)
21:41:10 <flo> that sucks :(
21:41:49 <flo> #1 crasher for something that is only in nightlies really sucks, as it will be even bigger if we release
21:42:27 <flo> http://crash-stats.instantbird.com/report/index/fe6fe676-3e8b-487e-abce-245a32120224 ouch :(
21:43:05 <flo> we have one report for the top mac crasher on a nightly that already contains the fix for it :(
21:43:15 <clokep_work> :-/
21:43:27 <aleth> :(
21:43:36 * clokep_work is curious if updating to Moz10 will fix the JS engine crasher. :-D
21:43:40 <clokep_work> Or if disabling angle would. :-/
21:43:40 <aleth> Are these inherited from mozilla? possibly fixed by moz 10?
21:44:29 <flo> clokep_work: it wouldn't
21:45:40 <flo> when I looked (recently; less than 2 weeks ago) for it in the mozilla crash database, they had reports for this JS engine crash for all versions including what was currently in aurora (or maybe even nightly)
21:46:08 <clokep_work> :-/ I wonder what's up that I always get it then.
21:46:14 <clokep_work> I'll try to launching in safemode tonight maybe.
21:46:15 <flo> I think our main problem is "how come something becomes a top crasher for Instantbird but is a very uncommon crash for Firefox?"
21:46:17 <-- chrisccoulson has quit (Ping timeout)
21:46:32 <clokep_work> Right.
21:47:00 <flo> maybe we are just very unlucky
21:47:05 <aleth> Might just be an artifact of FF being much larger
21:47:12 <flo> or maybe it's because we don't build with exactly the same configuration
21:47:29 <flo> I suspect turning on PGO would be likely to affect that JS engine crash
21:47:49 <flo> aleth: I don't understand your point
21:48:31 <aleth> flo: I just meant, maybe FF sees a much larger range of crashes, most of which can't arise in IB
21:49:20 <aleth> or did you mean the absolute number of crashes for that one was lower for FF?
21:49:35 <clokep_work> Yes.
21:50:23 <clokep_work> I had posted in the Mozilla bug about that JIT crash as too (just pointing to Instantbird getting it and linking back to our crash stacks, etc.) and got a reply of pretty much "Who cares? It's rare in Firefox."
21:51:26 <flo> aleth: for the mac top crasher, the absolute number of crash in Firefox+Thunderbird+SeaMonkey was less than what we received.
21:52:01 <flo> aleth: for the JS engine crash, iirc Firefox had ~500 reports; we have ~70
21:52:24 <flo> crashes that don't have thousands of reports for Firefox aren't significant
21:52:24 <aleth> Right.
21:53:01 <flo> (unless they happen frequently for a platform developer's machine, who is then likely to fix his own itch)
21:53:48 <clokep_work> If there's actually a way for me to debug that, I can try. But if it involves me using gdb or VS to debug it I'll need a lot of help. :-/
21:55:59 <flo> a crash in JIT'ed code probably also involved being able to read assembler code ;)
21:56:10 <flo> *involves
21:56:40 <clokep_work> I think the extent of assembly I know is "no operation". ;)
21:56:55 <flo> that part shouldn't crash I think :)
21:57:32 * clokep_work hopes Thunderbird starts crashing with this bug. :-X
21:57:48 <aleth> Heh.
21:58:12 <flo> I'm not sure even Thunderbird gets much love for that :-/
21:58:40 <flo> or did you mean it was a likely consequence of bug 714733?
21:58:53 <clokep_work> I just meant to get more attention to it.
21:59:26 <clokep_work> Well I'll try to take a look at some of the bugs on that 1.2 list and put up some more patches. ;)
21:59:36 <clokep_work> (I think I have one or two on there that are r? also.)
22:00:59 <clokep_work> Ah, time to go. :)
22:01:09 <-- clokep_work has quit (Quit: \o/)
22:02:15 <flo> I think that double "Quit:" will quickly annoy me
22:02:28 <flo> it's something I fixed in the libpurple plugin at the time :-/
22:02:37 <Mook_as> hmm, are we, by any chance, leaking JS-ish things near shutdown?
22:02:45 <Mook_as> (just wondering if that would affect crash volumes)
22:02:58 <flo> Mook_as: Thunderbird does
22:03:11 <flo> I don't think we do
22:03:30 <Mook_as> (the top result for the crash is me, btw; just look for the guy with the ATI video card on Win7)
22:04:09 <flo> or are you talking about different leaks than the ones showed at shutdown if XPCOM_MEM_LEAK_LOG was defined?
22:04:43 --> chrisccoulson has joined #instantbird
22:04:47 <flo> Mook_as: maybe you can add "Mook" to the comment field of your crash reports so that we don't have to look for the ATI video card? ;)
22:05:17 <Mook_as> I'll try to remember next time, yeah :)
22:05:56 <Mook_as> I'm just thinking that, since it's GC-triggered, perhaps there were things that were left to the last ditch GC that actually got cleaned up there that caused problems
22:07:08 <aleth> Would being able to display about:memory be useful here?
22:07:18 <flo> if that assumption is right (ie it's not a JS bug, but something doing crap in the GC's memory when released during shutdown) then it could just be bug 1017
22:07:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1017 cri, --, 1.2, florian, REOP, Shutdown crash [@ purple_blist_node_set_ui_data ]
22:08:11 <Mook_as> hmm, sounds like painful debugging ahead, then.
22:08:15 <flo> I guess having a clean (from valgrind's point of view) shutdown on Linux could only help with the Windows crasher
22:08:18 * Mook_as thinks about debug CRT memory checking
22:09:08 --> Tomek has joined #instantbird
22:29:18 <-- Tomek has quit (Quit: Instantbird 1.1)
22:39:54 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:42:08 <-- Plop has quit (Ping timeout)
22:49:25 --> Plop has joined #instantbird
22:55:27 * jwir3 is now known as jwir3|away
23:05:16 <flo> Good night! :)
23:05:20 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com)