All times are UTC.
00:00:15 --> micahg has joined #instantbird 00:08:45 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 00:10:41 <-- chrisccoulson has quit (Ping timeout) 00:10:48 <-- gerard-majax has quit (Ping timeout) 00:13:53 --> aleth has joined #instantbird 00:13:53 * ChanServ sets mode +h aleth 00:16:01 <-- micahg has quit (Ping timeout) 00:18:35 --> gerard-majax has joined #instantbird 00:24:20 --> chrisccoulson has joined #instantbird 00:25:34 --> clokep has joined #instantbird 00:25:34 * ChanServ sets mode +o clokep 00:31:55 --> micahg has joined #instantbird 00:31:56 <clokep> I'll look back over aleth's patch too after I finish reading this conversation. 00:34:48 <aleth> Some of my comments in the conversation aren't quite right. I didn't remember a couple of things I'd tried earlier immediately. 00:35:05 <clokep> I'll wait till you reply in the bug. 00:36:05 <clokep> (If it's easier to not reorg, feel free to ignore that part. :)) 00:36:47 <aleth> Regarding the minimize issue though, is flo right about that? The mintrayr C code is something I tried to avoid as much as possible ;) but looking at it, at first glance I can't see why it didn't cause problems during testing 00:37:14 <clokep> I didn't look at that yet. 00:37:20 <clokep> I just read the idl and it didn't seem to imply that... 00:37:29 <clokep> It's possible the tray code avoids generating multiple icons per window? 00:37:32 <clokep> (Or Windows does. :P) 00:37:42 <aleth> Something is avoiding it. 00:37:48 <aleth> Maybe not by design :P 00:37:58 <aleth> Anyway, I'll post amended patches, probably not tonight 00:45:13 <clokep> ...got something else going on? :P 00:45:27 * clokep is hoping to get an updated IRC patch up. 00:46:42 <-- micahg has quit (Ping timeout) 00:53:39 <-- mmkmou has quit (Ping timeout) 01:02:20 --> micahg has joined #instantbird 01:16:15 <-- zen_monkey_ has quit (Ping timeout) 01:16:56 <-- chrisccoulson has quit (sand.mozilla.org gravel.mozilla.org) 01:16:56 <-- gerard-majax has quit (sand.mozilla.org gravel.mozilla.org) 01:20:33 <instant-buildbot> build #186 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/186 01:34:20 --> chrisccoulson has joined #instantbird 01:53:42 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1176 on bug 507. 01:53:43 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1181 on bug 507. 01:53:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=507 enh, --, ---, clokep, ASSI, Implement IRC in JavaScript 02:01:28 <-- Mook_as has quit (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.2.13/20101203074205]) 02:44:14 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 02:57:08 * jwir3 is now known as jwir3|away 02:57:40 --> Mook has joined #instantbird 03:02:41 <-- Even has quit (Ping timeout) 03:08:31 --> Even has joined #instantbird 03:08:31 * ChanServ sets mode +o Even 03:32:38 <-- devfil has quit (Client exited) 03:42:04 <instant-buildbot> build #402 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/402 03:47:27 <-- clokep has quit (Quit: Instantbird 1.2a1pre) 04:16:15 <-- Gizmokid2005 has quit (Ping timeout) 04:16:23 --> Gizmokid2005 has joined #instantbird 04:23:15 <-- micahg has quit (Ping timeout) 04:39:09 --> micahg has joined #instantbird 05:00:22 <instant-buildbot> build #488 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/488 05:56:27 <-- micahg has quit (Ping timeout) 06:12:20 --> micahg has joined #instantbird 06:27:30 <-- micahg has quit (Ping timeout) 06:27:53 --> micahg has joined #instantbird 06:29:45 <-- micahg has quit (Quit: Ex-Chat) 06:32:58 --> micahg has joined #instantbird 06:52:14 <instant-buildbot> build #394 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/394 07:10:24 <-- micahg has quit (Connection reset by peer) 07:10:38 --> micahg has joined #instantbird 07:10:52 --> sztanpet has joined #instantbird 07:14:30 <-- micahg has quit (Ping timeout) 07:15:21 <-- sztanpet has quit (Quit: Instantbird 1.2a1pre) 07:15:25 --> sztanpet has joined #instantbird 07:15:49 <-- sztanpet has quit (Quit: Instantbird 1.2a1pre) 07:15:51 --> sztanpet has joined #instantbird 07:16:04 <-- sztanpet has quit (Quit: Instantbird 1.2a1pre) 07:16:22 --> micahg has joined #instantbird 07:54:43 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603]) 08:15:36 --> jb has joined #instantbird 08:20:11 <-- chrisccoulson has quit (Client exited) 08:20:30 --> chrisccoulson has joined #instantbird 08:36:10 --> MadWookiee has joined #instantbird 09:00:43 --> aleth has joined #instantbird 09:00:43 * ChanServ sets mode +h aleth 09:01:05 --> sztanpet has joined #instantbird 09:02:20 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 09:02:30 --> aleth has joined #instantbird 09:02:30 * ChanServ sets mode +h aleth 09:02:42 <sztanpet> hi, im using the 1.2 dev version and just wondering if its a known problem or not transmitting typing notifications even tho i disabled it 09:06:09 <aleth> sztanpet: Hi! I don't think that's a known problem. 09:06:36 <sztanpet> i noticed it with gtalk 09:06:39 <aleth> You have them turned off in Preferences -> Privacy -> Status and your conversation partners receive them anyway? 09:06:49 <sztanpet> exactly 09:07:29 <aleth> Could you file a bug on the issue on http://bugzilla.instantbird.org/ ? Then you will get an email when the issue is resolved. 09:07:36 <aleth> Thanks for letting us know! 09:09:44 <-- Even3 has quit (Quit: Instantbird 1.2a1pre) 09:09:48 --> Even2 has joined #instantbird 09:13:18 <sztanpet> thanks for instantbird! 09:13:33 <aleth> Glad you like it :) 09:13:53 <sztanpet> should i attach my profile with the bug btw? 09:14:18 <sztanpet> dont know how to strip passwords 09:14:30 <aleth> You don't have to. If there are any questions about your precise config people can get back to you. Do put in the exact version of Instantbird you are using. 09:14:40 <sztanpet> yup, okay 09:15:10 <-- Even2 has quit (Connection reset by peer) 09:15:14 <instantbot> New purplexpcom - General bug 1281 filed by sztanpet@gmail.com. 09:15:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1281 min, --, ---, nobody, UNCO, Sending typing notifications even tho the option for it is disabled 09:15:29 <aleth> Thanks! :) 09:23:31 --> Even2 has joined #instantbird 09:28:53 <sztanpet> thank you! bye 09:28:56 <-- sztanpet has quit (Quit: Instantbird 1.2a1pre) 09:49:50 --> flo has joined #instantbird 09:49:50 * ChanServ sets mode +qo flo flo 10:00:18 <flo> "It's amazing how quickly you forget why you did your own code a particular way." it's the reason why it's important: 1. To provide quick reviews (sorry... :() 2. To include comments in the code ;). 10:00:37 <flo> err, I meant to start this with "aleth: "... 10:03:43 <flo> so I fix 2 blockers and someone finds & reports another one... it will take some time till we are able to release if we continue like this... ;) 10:10:30 <aleth> C'est la vie ;) 10:11:40 <aleth> Having a problem persisting an attribute on the blist window. I added the attribute to the persist= line in blist.xul. But nothing gets saved to localstore.rdf. Is there some cache that needs clearing? (I tried deleting that file) 10:12:27 <flo> no 10:12:46 <flo> you set the attribute with .setAttribute("name", "value"); right? 10:12:57 <aleth> No, directly. 10:13:07 <flo> then you set a JS property, not a DOM attribute 10:13:19 <aleth> Ah, right. :) Thanks 10:15:11 <-- flo has quit (Quit: Instantbird 1.2a1pre) 10:15:15 --> flo has joined #instantbird 10:15:15 * ChanServ sets mode +qo flo flo 10:15:34 <flo> ah, so now my "real name" is set correctly :) 10:16:59 <instantbot> florian@instantbird.org set the Resolution field on bug 1205 to FIXED. 10:17:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1205 nor, --, 1.2, florian, RESO FIXED, Non-ASCII characters not correctly encoded in account aliases, account options, and user display nam 10:17:02 <aleth> Oh yes :) In the tooltip... 10:17:19 <aleth> Now I get "window.setAttribute is not a function" 10:17:40 --> gerard-majax has joined #instantbird 10:20:02 <flo> bugzilla is slow :( 10:20:15 <aleth> Do I need to set the attribute on the document? 10:20:18 <flo> aleth: window.documentElement.setAttribute 10:20:32 <flo> or maybe window.document.documentElement.setAttribute 10:21:01 <flo> ok, the latter 10:21:11 <aleth> Thanks 10:22:06 <instantbot> florian@instantbird.org set the Resolution field on bug 1251 to FIXED. 10:22:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1251 nor, --, 1.2, florian, RESO FIXED, Can't accept/add buddies with JS-XMPP (regression for GTalk accounts) 10:22:23 <-- gerard-majax has quit (Ping timeout) 10:26:26 --> mmkmou has joined #instantbird 10:27:45 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 10:34:43 --> gerard-majax has joined #instantbird 10:34:46 <-- micahg has quit (Client exited) 10:42:29 --> Mic has joined #instantbird 10:42:30 * ChanServ sets mode +h Mic 10:42:30 --> micahg has joined #instantbird 10:56:59 <-- Mic has quit (Connection reset by peer) 10:57:59 <flo> anybody feeling like reviewing http://pastebin.instantbird.com/13567 ? 10:58:22 <-- gerard-majax has quit (Ping timeout) 10:59:07 <flo> I'm always confused by this account.css file containing only 2 css rules to fix menulist theming, and useful only in the joinchat/addbuddy dialogs. The use case in account.xul is a leftover of before I added the account wizard (which was probably 2 months before releasing 0.1 !) 10:59:31 <flo> (that css file is: http://lxr.instantbird.org/instantbird/source/instantbird/themes/account.css#82) 10:59:35 <-- MadWookiee has quit (Ping timeout) 10:59:46 --> MadWookiee has joined #instantbird 11:14:27 <-- mmkmou has quit (Ping timeout) 11:16:59 --> aleth has joined #instantbird 11:16:59 * ChanServ sets mode +h aleth 11:17:43 --> mmkmou has joined #instantbird 11:21:09 <aleth> flo: The new menulist.css is not in your pastebin, but I suppose you'll do that with hg mv or similar. I like the change, because account.css vs accounts.css was confusing :) 11:21:31 <flo> aleth: look at the last 3 lines of the pastebin 11:22:40 <aleth> Heh, I thought that was the todolist :P 11:23:02 <aleth> while it was actually generated output 11:23:46 <flo> and now I'm annoyed (again) by utilities.js 11:24:06 <aleth> There was some mozilla reason for needing it? 11:25:13 <flo> it's just old pre-0.1 junk too ;) 11:26:07 <aleth> Future archaeologists will love it ;) 11:26:46 <flo> I'm not sure if the 2 or 3 pre-0.1 builds that existed are archived publicly anywhere 11:28:43 <-- mmkmou has quit (Ping timeout) 11:28:49 --> clokep has joined #instantbird 11:28:49 * ChanServ sets mode +o clokep 11:33:37 <flo> Thunderbird has http://mxr.mozilla.org/comm-central/source/mailnews/base/util/iteratorUtils.jsm 11:33:47 <flo> maybe we should include that in Instantbird too 11:37:57 <clokep> Would be nice if we could just import it. :P 11:38:21 <flo> you mean if it was in mozilla-central ? 11:39:30 <clokep> Yes. 11:39:36 <flo> file a bug? :) 11:39:57 <flo> or maybe we can ask in #maildev first 11:43:18 <clokep> Maybe. :p 11:46:28 <clokep> We'll sitll need to wait until moz13 or whatever before it's available in m-c for us. :( 11:47:07 --> mmkmou has joined #instantbird 11:47:17 <flo> trying to depress me? heh :-P 11:50:26 <clokep> Haha, sorry. 11:50:32 <clokep> We can always add it as a patch. :P 11:50:48 <clokep> Bye! 11:50:55 <-- clokep has quit (Quit: Instantbird 1.2a1pre) 11:51:22 <-- MadWookiee has quit (Ping timeout) 11:58:39 <flo> ooh, mozilla-central now has a JS module for reading .plist files (toolkit/content/PropertyListUtils.jsm) 11:58:51 <flo> (added in https://bugzilla.mozilla.org/show_bug.cgi?id=710259) 12:13:22 --> MadWookiee has joined #instantbird 12:16:52 --> waynenguyen has joined #instantbird 12:22:04 <instantbot> pingu8007@gmail.com set the Resolution field on bug 1226 to DUPLICATE of bug 1205. 12:22:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1226 nor, --, ---, nobody, RESO DUPLICATE, Double Byte Character Set become blocks 12:22:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1205 nor, --, 1.2, florian, RESO FIXED, Non-ASCII characters not correctly encoded in account aliases, account options, and user display nam 12:22:55 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1182 on bug 869. 12:22:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=869 nor, --, ---, aletheia2, ASSI, Contacts window forgets screen position when closed 12:25:31 <aleth> Re that patch, I was wondering whether to put window.document.documentElement into a variable in the object to avoid duplication. 12:25:43 <flo> please do! :) 12:25:57 * flo was about to r- without looking further for that reason ;) 12:26:13 <flo> well, maybe not a variable in the object 12:26:38 <flo> but a local variable in each function that needs it more than once 12:28:15 <aleth> It's only needed twice each time. That's why I hesitated -- the question is would this._windowElt be better? 12:28:22 <flo> aleth: in the toggle method, you removed the "// When the tray icon isn't always visible" comment. 12:28:25 <aleth> (for example) 12:28:33 <flo> it was there to explain what the "!this._icon" case is 12:28:44 <aleth> I thought you wanted it gone :P 12:28:58 <aleth> I misunderstood. 12:29:02 <flo> no, I wanted the non sense line added to that comment by the previous patch gone :-P 12:29:29 <flo> shouldn't the change to persist= be ifdef'ed too? 12:30:12 <flo> just something like |let docElt = window.document.documentElement;| would simplify the code I think 12:30:35 <aleth> I can do that, but it would itself be duplicated across the file... 12:30:55 <flo> aleth: I suspect if you edited or got rid of that comment, the reason is that the existing comment wasn't clear enough for you to understand it, so feel free to improve it :) 12:31:18 <flo> I will live with that 12:31:21 <aleth> flo: I thought the persist= change didn't need an ifdef because the attribute is not stored unless it exists aafaik. 12:31:23 <flo> just don't do the call twice in a row :) 12:31:28 <aleth> :D 12:32:11 <flo> "It's only needed twice each time." there's a third call for the hasAttribute check ;) 12:32:45 <flo> away for lunch 12:34:20 --> clokep_work has joined #instantbird 12:34:20 * ChanServ sets mode +o clokep_work 12:34:35 <clokep_work> bug 1281 saddens me. :( 12:34:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1281 nor, --, ---, nobody, NEW, Sending typing notifications even tho the option for it is disabled 12:35:14 <clokep_work> I dislike our protocols needing to decide when to do things (e.g. the connect/disconnect changes from bug 1199) 12:35:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1199 enh, --, 1.2, clokep, RESO FIXED, Only notify prplIAccounts of status changes when enabled 12:39:49 <clokep_work> That .plist module is pretty slick. :) 12:45:20 --> jtso has joined #instantbird 12:53:15 <aleth> Hmm, I am going to have to look at this again :( I think I've found a little bug in the existing mintrayr code. 12:56:29 <clokep_work> It wouldn't surprise me. :P What's the issue? 12:57:45 <aleth> I'm not sure it's actually a bug, but: Open Preferences, put the buddy list behind the Preferences window (for example), then toggle "Always show tray icon". 12:57:55 * clokep_work wonders if there are any extra upstream improvements to mintrayr... 12:58:05 <clokep_work> What happens? 12:58:22 <aleth> The buddy list window is brought to the front as you remove the tick 13:00:24 <clokep_work> Ah, interesting. 13:00:34 <clokep_work> Sounds like a bug, yes. Do we call focus/restore in that case? 13:01:52 <aleth> No, it's not explicitly done. Anyway, I'll look at it later. 13:05:15 <-- Even1 has quit (Quit: Instantbird 1.2a1pre) 13:07:49 <jtso> hi, is intantbird going to join gsoc this year? 13:10:46 <clokep_work> Hey jtso. Last year we did it through Mozilla (they were nice enough to give us one of their slots even though we're not directly related to them!). 13:11:21 <clokep_work> There's a spot on their brainstorming page for us again at https://wiki.mozilla.org/Community:SummerOfCode12:Brainstorming#Instantbird so we'll put some ideas in there. :) 13:13:53 <clokep_work> Are you interested in applying? :) 13:17:10 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 13:17:10 <jtso> clokep_work: oh cool, thanks. yeah, i have looked a bit on last year brainstorming page. 13:17:22 --> aleth has joined #instantbird 13:17:23 * ChanServ sets mode +h aleth 13:17:57 <clokep_work> Awesome. :) Any in particular you like? 13:18:27 <clokep_work> Ah, I need to step away from my desk. Feel free to hang around on IRC though and ask any questions, give feedback, etc.! Nice meeting you. 13:22:33 <jtso> Nice meeting you too, Thanks a bunch 13:23:10 <aleth> jtso: There was some very preliminary discussion for this year here http://log.bezut.info/instantbird/120214/#m221 13:26:47 <jtso> thanks 13:31:28 --> waynenguyen_ has joined #instantbird 13:41:15 <-- waynenguyen_ has quit (Quit: Quit) 13:46:38 <-- jtso has quit (Quit: http://www.mibbit.com ajax IRC Client) 13:48:05 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1182 on bug 869. 13:48:06 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1183 on bug 869. 13:48:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=869 nor, --, ---, aletheia2, ASSI, Contacts window forgets screen position when closed 13:49:31 --> waynenguyen_ has joined #instantbird 13:59:54 <-- waynenguyen_ has quit (Quit: Quit) 14:05:33 --> jb1 has joined #instantbird 14:06:03 <-- jb has quit (Ping timeout) 14:09:08 <-- mmkmou has quit (Ping timeout) 14:10:51 --> Tomek has joined #instantbird 14:17:47 --> mmkmou has joined #instantbird 14:20:13 --> gerard-majax has joined #instantbird 14:21:44 <-- MadWookiee has quit (Ping timeout) 14:21:56 <-- gerard-majax has quit (Connection reset by peer) 14:23:53 --> MadWookiee has joined #instantbird 14:23:53 --> gerard-majax has joined #instantbird 14:24:27 --> Mic has joined #instantbird 14:24:27 * ChanServ sets mode +h Mic 14:30:15 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1162 on bug 1252. 14:30:16 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1184 on bug 1252. 14:30:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1252 nor, --, ---, aletheia2, ASSI, First listitem in log viewer never shows that it is selected 14:34:54 <flo> aleth: does it work with executeSoon instead of setTimeout? 14:36:00 <flo> it's just one line, so you may want to inline it rather than importing imXPCOMUtils.jsm which would override the standard setTimeout 14:36:01 <flo> http://lxr.instantbird.org/instantbird/source/chat/modules/imXPCOMUtils.jsm#120 14:36:39 <Mic> aleth, flo: if I'm not mistaken, this is the place that makes the difference for Linux: https://mxr.mozilla.org/mozilla-central/source/xpfe/appshell/src/nsXULWindow.cpp#998 14:36:48 <clokep_work> You could import imXPCOMUtils into a scope to not override setTimeout. 14:37:23 <Mic> What about patching that for us, instead of creating the store/load functionality ourselves again. 14:37:46 <aleth> Mic: good luck with that. 14:38:11 <flo> Mic: if that works, it will be cleaner! :) 14:38:15 <Mic> I thought we were patching Mozilla code somewhere else already? 14:38:20 <aleth> We've already discussed this... 14:38:45 <flo> Mic: we just need to #if 0 that? :) 14:38:48 <Mic> I'm not talking about upstreaming it, aleth. 14:39:00 <Mic> flo: that's what I was thinking 14:39:22 <flo> we could try upstreaming it with an about:config pref (I wouldn't bet on it getting accepted, but it could happen I think) 14:39:23 <aleth> Oh, you would modify it for IB only? I didn't know you did things like that 14:39:34 <flo> aleth: we unfortunately have to 14:39:55 <flo> aleth: look in http://lxr.instantbird.org/instantbird/source/tools/patches/ for a set of sad examples ;) 14:40:48 <aleth> Heh. I could have pointed to that bit of code ages ago... 14:40:55 <flo> aleth: although doing that for a linux-only change isn't great, as these patch are usually not applied in distribution packages which run instantbird based on the system xulrunner... 14:41:00 <aleth> But yeah, it's sad that you have to do that. 14:41:20 <aleth> Why don't you do the same for your DNSSRV patch? 14:41:29 <flo> aleth: I need it in Thunderbird 14:42:00 <aleth> flo: Sure, but then JS-XMPP would already be more thoroughly tested in IB at least... 14:42:27 <flo> aleth: I suspect most XMPP accounts used with ib are either gtalk or facebook anyway ;) 14:44:46 <aleth> flo: executeSoon works too. Does that stick it in a queue? 14:45:19 <flo> aleth: executeSoon puts it at the end of what's going to be processed before waiting for another event 14:45:52 <aleth> Great, lets use that, just needs testing on Windows then. 14:46:02 <flo> it's more or less equivalent to a setTimeout of exactly 0 (setTimeout won't let you set 0ms, it replaces small values with the minimum acceptable value defined somewhere, which is 6ms these days I think) 14:46:04 <aleth> I hate randomly picking 100ms. 14:46:48 <flo> why are you putting the findbar.close = ... hack inside the timeout ? 14:46:58 <aleth> flo: Might it cause problems on slow machines with such a short delay? 14:47:19 <aleth> flo: I added a comment to explain: findbar.open requires the browser to be set, which requires a log to be selected. 14:47:20 <flo> executeSoon is not a short delay, it's no delay at all. 14:47:30 <flo> it's "do it as soon as you are done with what you are currently doing" 14:47:30 <aleth> flo: yes, that's why I ask 14:47:42 <flo> it doesn't depend on the speed of the machine :) 14:48:08 <aleth> Maybe the comment needs to be longer... 14:48:10 <flo> (except if you expect some magic to happen on a separate thread at the same time, but if you expect that, you are screwed anyway :)) 14:49:09 <aleth> I suppose I am a little uncomfortable because I don't know exactly why there was a problem in the first place. 14:49:41 <flo> yeah, using executeSoon is still a hack, it's just less ugly than setTimeout 14:52:11 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1184 on bug 1252. 14:52:12 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1185 on bug 1252. 14:52:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1252 nor, --, ---, aletheia2, ASSI, First listitem in log viewer never shows that it is selected 14:53:33 <-- Tomek has quit (Ping timeout) 14:53:36 --> Tomek has joined #instantbird 14:55:36 <aleth> Damn, I wish I had known you applied IB-specific patches to mozilla - I needn't have spent all that time on the mintrayr workaround then :( 14:55:56 <clokep_work> aleth: But now that you know it I'm redirecting all reviews of it to you. 14:56:12 <flo> :-D 14:56:15 <aleth> Oh no... :P 14:56:22 <flo> double punishment ;) 14:57:56 <clokep_work> (I'm only half kidding. ;) Any patches /I/ do in it will be r? you. :)) 14:58:42 <flo> I was sure you weren't kidding :) 14:59:05 * aleth mutters something about tray icons 14:59:30 <flo> so when are you going to file a bug to get rid of that code completely? ;) 15:00:58 <clokep_work> aleth: I have nightmares about tray icons. 15:01:08 <clokep_work> flo: When Windows 8 is released. ;) 15:01:09 <aleth> I think it'll be a while until all OS have a decent tray replacement ;) 15:03:45 <flo> clokep_work: you can't even imagine how I hate that code... 15:04:55 <flo> I had different work-in-progress tray icon codes twice between 0.2a1 and 1.0 and gave up out of extreme frustration :-D 15:05:22 <aleth> Understandable... 15:07:02 <-- Mic has quit (Quit: Instantbird 1.2a1pre) 15:09:28 <clokep_work> I also have two work-in-progress tray icon codes based on c-types. :) 15:22:59 <clokep_work> flo: Btw was that response to GSoC appropriate or is there something else we should point to? 15:23:06 <clokep_work> (Wish he had hung around though! :() 15:23:12 <flo> it was great :) 15:24:42 <clokep_work> OK! I wasn't really sure of the deal w/ Mozilla so... 15:24:58 <flo> I'm not completely sure either 15:25:10 <flo> but it's likely going to be like last year 15:27:18 <clokep_work> OK! 15:27:48 <clokep_work> Not sure if you have/are planning to look at the IRC code I put up again soon, but I'll be traveling the second half of this week; so if it were to land I won't be putting out fires. :) 15:28:31 <flo> second half starts tomorrow? 15:29:05 <flo> (yes, I was planning to look at it again soon. Either later today or tomorrow) 15:29:20 <clokep_work> Yes, tomorrow. 15:29:32 <clokep_work> I'll have Internet access and stuff, but skiing with my family so... 15:29:48 <flo> yeah, so better things to do than looking at code 15:30:53 <clokep_work> Yup! :) 15:31:10 <clokep_work> Well hopefully there's snow. :P 15:33:08 <flo> so Wednesday through Saturday? Sunday? 15:33:15 <clokep_work> Saturday most likely. 15:33:35 <flo> so it should land Monday then? 15:36:19 <clokep_work> If it passes review Monday would probably be best for me. 15:36:42 <flo> are all the XXXFLo comments gone? 15:36:47 <flo> I haven't looked at the code recently 15:38:45 <clokep_work> Yes. 15:39:09 <clokep_work> At least I didn't see any. I don't remember if I actually ran a grep on the directory or not. 15:39:27 --> igorko has joined #instantbird 15:39:32 <flo> I guess what I should review then is the an interdiff of (previous patch + my interdiff review applied) and your new patch 15:42:52 <clokep_work> :) 15:48:55 <-- Tomek has quit (Connection reset by peer) 15:50:01 --> Tomek has joined #instantbird 16:09:24 <flo> in a test profile I have a gtalk account "testinstantbird@gmail.com@gmail.com/Instantbird" :-S 16:09:42 <flo> have I really configured an account that stupidly? Or is there a serious bug we need to catch? :-S 16:10:23 <clokep_work> :-/ Is that even a valid account name or should we reject that? 16:10:45 <flo> I don't know :) 16:11:05 <flo> I've probably typed "testinstantbird@gmail.com" as username in Ib 1.1 where there's still the user splits... 16:12:07 <flo> JavaScript strict warning: resource:///modules/jsProtoHelper.jsm, line 246: reference to undefined property this._buddy 16:12:08 <flo> hmm 16:13:22 * jwir3|away is now known as jwir3 16:14:22 <flo> so there's a bug, not sure yet if it's in jsProtoHelper of JS-XMPP when we have a conversation with a buddy and that buddy is deleted from the blist. 16:15:16 <flo> conversation.buddy should become null, and some kind of status update notification should be fired on the conversation so that the UI reflects that the status is now unknown 16:15:33 --> myk has joined #instantbird 16:15:34 <flo> but we don't do any of that, and the conv keeps a reference to an uninitialized accountBuddy 16:15:52 <clokep_work> :-/ 16:16:14 <flo> for now I'll blame the users who continue talking to people that they have deleted from their contact list :-P 16:18:43 <clokep_work> Haha, it's kind of a strange thing to do, yes. 16:20:04 <flo> ah, I haven't commited yet the account.css -> menulist.css rename 16:20:57 * flo is confused between the buddy lists of his 4 IM clients 16:21:24 <flo> I thought we were doing a multi-protocol client to avoid that mess, but I end up with 4 instances of it running at once :-D 16:22:23 <clokep_work> I hate when I close my real Instantbird. :( 16:22:37 <clokep_work> Can we like make debug builds bright red or something? 16:22:37 <flo> it's the reason why we have different brandings :) 16:22:49 <flo> my debug builds all have the hallowing branding :) 16:23:05 <flo> *Halloween 16:23:50 <clokep_work> Mine does too in fact! 16:23:55 <clokep_work> But Windows groups them all together. :( 16:24:08 <flo> ah, you want a mac :) 16:24:19 <flo> does it do that for Firefox too? 16:24:22 <clokep_work> Yes. 16:24:37 <clokep_work> It has to do with the AppId or something I think. 16:24:40 <clokep_work> I forget. 16:24:58 <flo> I thought the app id was different for debug 16:25:02 <clokep_work> I always have trouble finding Instantbird on friend's computers that don't have nightly builds. :P 16:25:55 <flo> I almost never see the release branding either, except on the website 16:29:46 <-- Tomek has quit (Quit: Instantbird 1.1) 16:43:20 <clokep_work> flo: Think you can poke Even at some point about bug 1186? :) 16:43:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1186 maj, --, ---, clokep, ASSI, "Redirect Loop" error for addons.instantbird.org 16:43:34 * clokep_work is tired of seeing it as open... 16:43:52 --> wesj has joined #instantbird 16:44:05 <flo> I'll try 16:44:17 <flo> I think I've already done it a few times though 16:44:51 <clokep_work> Alright. :( 16:45:03 <clokep_work> Do I need to start making bribes? :P 16:45:14 <flo> it's too bad I didn't think to do it saturday evening though 16:45:43 <flo> we met face to face for the first time in a long while... 16:45:54 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1185 on bug 1252. 16:45:55 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1186 on bug 1252. 16:45:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1252 nor, --, ---, aletheia2, ASSI, First listitem in log viewer never shows that it is selected 16:46:19 <clokep_work> Ah, you could have actually poked him! 16:46:28 <clokep_work> It's fine. I'm sure he'll get around to it eventually. :) 16:46:42 <flo> the bug doesn't seem very exciting 16:46:55 <flo> but it would be nice to fix it before the seamonkey project disappears :) 16:50:44 <clokep_work> Haha. 16:57:35 <instantbot> florian@instantbird.org granted review for attachment 1186 on bug 1252. 16:57:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1252 nor, --, ---, aletheia2, ASSI, First listitem in log viewer never shows that it is selected 16:58:31 <clokep_work> :) 17:01:09 <flo> ok, I think I'm done with the stuff I needed to finish before looking again at IRC today 17:02:15 <flo> so, to see your changes, I need to compare "Patch v2.2 + interdiff review" to "Patch v4" 17:03:15 <clokep_work> Yes. 17:05:23 <flo> which gives 12 files changed, 214 insertions(+), 216 deletions(-) 17:05:53 <aleth> Looks like there has been quite a bit of rewriting ;) 17:06:15 <flo> aleth: the whole patch is 40 files changed, 3727 insertions(+), 4663 deletions(-) 17:06:32 <flo> so a change of 200 lines is comparatively quite small :) 17:06:55 <aleth> Yes, I had a look a while back... it's huge. And 2 years of work according to the bug :) 17:08:51 <flo> I had a local change, the values are actually: 11 files changed, 213 insertions(+), 213 deletions(-) 17:09:26 <flo> and the interdiff is http://pastebin.instantbird.com/13595 17:11:41 * flo reads 17:14:12 <flo> "The topic for %1$S was removed." $S is enough if there's only one parameter 17:14:36 <flo> especially as the comment above it is "%S is the conversation name." 17:20:03 <-- mmkmou has quit (Ping timeout) 17:20:38 <flo> "// Convert the byte offsets and lengths into character indexes." should be removed, it's unrelated to the code you reused :) 17:20:43 --> mmkmou has joined #instantbird 17:23:42 <flo> |setTimeout(this.gotDisconnected.bind(this), 5 * 1000);| looks dangerous 17:25:12 <flo> clokep_work: I'm assuming it doesn't take 5s to disconnect, but we will mark the account as disconnected only after the server has replied. What happens if in less than 5 seconds the server replies, we mark the account as disconnected, and the user reconnects the account? 17:28:00 <-- mmkmou has quit (Ping timeout) 17:29:21 --> mmkmou has joined #instantbird 17:31:13 <flo> // If the user left, mark the conversation as no longer being active. conversation.left = true; (in function leftRoom). Isn't there a notification that needs to be sent to the conversation in that case? 17:32:15 <flo> http://lxr.instantbird.org/instantbird/search?string=update-conv-chatleft 17:34:57 <flo> maybe this could be done in jsProtoHelper in a left setter? 17:38:38 <flo> you removed the code using "message.topicSetter", but it's still in the properties file 17:39:57 <flo> this._motd = [aMessage.params[1].slice(2,-2)]; 17:40:02 <flo> a space is missing after the comma 17:43:45 <flo> nit: "// Use the brandShortName as the client version." I would remove the first "the" from that sentence, as brandShortName here is a variable name, not "branch short name" :) 17:46:17 <flo> That's all the comments I have while reading the interdiff 17:53:21 <clokep_work> flo: Yes I thought the setTimeout was dangerous too, but I wasn't sure of a better way to do it. 17:53:31 <clokep_work> I want to be able to send the quit message to the server and give it a chance to respond. 17:53:53 <clokep_work> I guess I should save the result of the setTimeout and then kill it if I receive a response from the server? 17:56:21 <flo> exactly! :) 17:56:48 <flo> should this be skipped in the case where we are "disconnecting" because we are offline? 17:57:11 <flo> (ie the socket thread has already been killed, so it's too late to send anything) 17:57:23 <flo> I'm not exactly sure in which case this can happen 18:00:15 <clokep_work> I'm not sure when that can happen either. 18:00:26 <clokep_work> I think if you fail to send things during the socket it will disconnect you forcefully anyway. 18:00:27 <-- jb1 has quit (Ping timeout) 18:01:36 <flo> clokep_work: if you put your laptop to sleep, when it wakes up you are offline, aren't you? 18:01:52 --> Mook_as has joined #instantbird 18:01:58 <flo> the server is unlikely to receive what you could attempt to send in that case anyway :) 18:03:15 <flo> ok, time to try it 18:04:15 <clokep_work> True. 18:04:21 <clokep_work> I'll need to play w/ that a bit more then. :) 18:04:57 <flo> JS-XMPP / the socket.jsm code doesn't work very well in that case :-/ 18:05:29 --> testib has joined #instantbird 18:05:58 <flo> ah, the username length is limited to 10 characters? :( 18:06:12 <clokep_work> I don't remember if I forcefully limit it or not. 18:06:13 <clokep_work> :-/ 18:06:24 * clokep_work wishes he had lxr for this patch. :P 18:06:30 <flo> testib's username is "Instantbir" 18:06:36 <testib> things seem to work :) 18:07:05 <clokep_work> Ah, yeah. I think that's the server. 18:07:20 <-- testib has quit (Quit: Instantbird <http://www.instantbird.org>) 18:08:03 <flo> the account manager doesn't like accounts that spend more than half a second in the disconnecting state 18:08:55 <clokep_work> :-/ 18:09:18 <flo> would "Instantbird -- http://www.instantbird.org" look nicer as a default quit message? 18:09:57 <flo> clokep_work: by "doesn't like", I meant the "connect" button stays disabled 18:10:18 --> testib has joined #instantbird 18:10:35 <Mook_as> the alternative quit message would certainly get around the fact that >) is an emoticon by default in chatzilla 18:11:12 <testib> so it seems I'm in here 18:11:23 <testib> but the tab says I've left that chat 18:11:58 <flo> either we miss notification to update the conversation when rejoining, or conversation.left is still set to true 18:12:09 <flo> I'll go look at that with DOM Inspector 18:12:56 <clokep_work> flo: It says you left after reconnecting? It didn't update the icon? 18:12:56 <flo> ok, conversation.left is still set to true after rejoining a chat room 18:13:01 <clokep_work> Mook_as: That sounds like a CZ bug. :P 18:13:07 <flo> clokep_work: it didn't update the icon 18:13:36 <flo> clokep_work: I don't really like seeing the < > on my screen, and that's not ChatZilla's fault :) 18:13:55 <clokep_work> :) We can change that message, I'm not married to it. 18:14:17 * clokep_work sets mode +v testib 18:14:22 <clokep_work> That worked fine, right? 18:14:28 <flo> if I attempt to send "/msg flo hey", I get JavaScript error: , line 0: uncaught exception: [Exception... "'[JavaScript Error: "params is not defined" {file: "resource:///modules/ircCommands.jsm" line: 73}]' when calling method: [imICommand::run]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: file:///Users/florian/buildhg/obj-instantbird-dbg/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/ 18:14:32 <flo> and it's not sent 18:14:41 <clokep_work> Bleh. :( 18:14:48 <testib> clokep_work: the mode change worked fine, yes :) 18:15:53 <flo> so, what's the server tab for? 18:15:55 <clokep_work> Good. :) I was having some trouble w/ that at one point. 18:16:08 <clokep_work> The server tab shows the MotD and some other messages. 18:16:16 <flo> how can I send a who/whowas command? 18:16:26 <clokep_work> You can't. 18:16:30 <-- gerard-majax has quit (Ping timeout) 18:16:41 <clokep_work> You can send a whois command by mousing over on the participant list. 18:16:45 <flo> so what should I do with that nice textbox I have in that server tab? 18:17:13 <flo> clokep_work: the whois result are displayed only in my terminal, not in the tooltip :( 18:17:15 <clokep_work> You can send commands, join chats, etc. 18:17:28 <clokep_work> They worked for me last time I checked... 18:17:43 <flo> it maybe be confused by previous things I tested 18:17:47 <flo> let me restart 18:17:50 <-- flo has kicked testib from #instantbird 18:18:05 --> testib has joined #instantbird 18:18:10 <-- testib has quit (Quit: testing) 18:18:37 --> testib has joined #instantbird 18:19:47 <flo> clokep_work: this is the terminal output when hovering "flo" http://pastebin.instantbird.com/13601 18:20:47 <flo> ah, the error console is a bit more helpful 18:21:00 <flo> Error: this._account is undefined Source File: file:///.../components/irc.js Line: 474 18:21:59 <flo> that line is: | if (!hasOwnProperty(this._account.whoisInformation, nick))| 18:22:19 <flo> it seems |this| is already the account in that context 18:24:19 <-- testib has quit (Quit: Instantbird <http://www.instantbird.org>) 18:24:22 --> testib has joined #instantbird 18:24:24 <-- testib has quit (Input/output error) 18:24:44 --> testib has joined #instantbird 18:25:07 <flo> the encoding is still messed up 18:25:11 <flo> (grrr) 18:26:40 <-- testib has quit (Quit: Instantbird <http://www.instantbird.org>) 18:27:18 --> jb has joined #instantbird 18:28:15 <-- skeledrew1 has quit (Ping timeout) 18:28:22 --> skeledrew has joined #instantbird 18:28:27 --> testib has joined #instantbird 18:29:21 <clokep_work> Yeah, it probably would be. 18:29:39 <flo> so, why is my proxy not used, even though socket.jsm is supposed to fully handle it? 18:29:40 <clokep_work> I must have moved that somewhere. :( Sorry. 18:30:19 <clokep_work> I don't remember, do I need to pass anything in when I do that? 18:30:30 <flo> no :) 18:30:32 <clokep_work> "do that" = instantiates the socket 18:30:35 <flo> it's supposed to just work 18:30:45 <clokep_work> Yeah, that's what I thought too. :/ 18:30:57 <flo> it obviously doesn't work though 18:31:13 <flo> I guess I'll need to debug that 18:31:41 <flo> do you think you are going to handle all these comments before or after skying? 18:31:50 <flo> *skiing 18:33:50 <clokep_work> Hopefully I'll handle them tonight, unless I decide to leave tonight... 18:34:09 <flo> I'll be back in ~ 2 hours 18:34:11 <-- flo has quit (Quit: Instantbird 1.2a1pre) 18:36:02 <-- testib has quit (Ping timeout) 18:54:12 <-- MadWookiee has quit (Quit: Instantbird 1.1) 19:06:47 --> gerard-majax has joined #instantbird 19:10:03 <-- mmkmou has quit (Ping timeout) 19:12:26 --> mmkmou has joined #instantbird 19:13:49 <-- skeledrew has quit (Ping timeout) 19:15:22 --> skeledrew has joined #instantbird 19:22:25 * jwir3 is now known as jwir3|lunch 19:31:28 <-- micahg has quit (Ping timeout) 19:35:02 --> micahg has joined #instantbird 19:43:08 --> devfil has joined #instantbird 19:48:28 <-- Suiseiseki has quit (Ping timeout) 19:51:29 <-- jb has quit (Ping timeout) 19:52:50 --> Suiseiseki has joined #instantbird 19:57:07 --> flo has joined #instantbird 19:57:07 * ChanServ sets mode +qo flo flo 20:03:50 --> jb has joined #instantbird 20:06:16 <-- jb has quit (Ping timeout) 20:08:55 * jwir3|lunch is now known as jwir3 20:12:05 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 20:12:15 --> aleth has joined #instantbird 20:12:15 * ChanServ sets mode +h aleth 20:13:49 <clokep_work> I guess we need to brainstorm some GSoC ideas more formally at some point 20:15:24 <-- mmkmou has quit (Ping timeout) 20:16:11 <flo> would be nice to have ideas ready by Friday 20:16:16 --> mmkmou has joined #instantbird 20:16:19 <clokep_work> Ah, what's Friday? 20:16:30 <flo> (ready = ready to put on the brainstorm wiki page) 20:17:10 <flo> I know we (the Thunderbird team) will discuss ideas on Friday 20:17:44 <flo> I don't remember what the real deadline is, but I guess it's better if we don't do it at the last minute 20:17:54 <flo> (and we can still add more ideas later if we find more :)) 20:18:03 <-- mmkmou has quit (Ping timeout) 20:18:06 <clokep_work> Yup! :) I'll try to think of some soon. 20:18:48 --> mmkmou has joined #instantbird 20:24:03 <clokep_work> You said it needs to benefit Mozilla in general, right? 20:27:48 <flo> that was for last year 20:28:12 <flo> for this year, I suspect Instantbird projects that can benefit Mozilla in general are almost Thunderbird projects... 20:28:24 <flo> so we may try to push a little bit the boundary :) 20:29:12 <clokep_work> Ah-ha! :) 20:29:49 <clokep_work> Idk, really the only things that come to me are voice and/or video and other collaboration stuff (both XMPP and IRC support whiteboarding). 20:29:59 <clokep_work> And MSN might too? 20:34:13 <flo> IRC supports whiteboarding? really? 20:34:31 <flo> support for identica maybe? Sounds a bit too easy :-S 20:36:23 <clokep_work> No, that's too easy. 20:36:51 <clokep_work> I'm not sure why it surprises you that someone wrote a CTCP extension for whiteboarding. ;) 20:37:02 <clokep_work> I think only one client implements it, but there's a spec. 20:37:12 <aleth> A mozpad within IB? Would that be "whiteboarding"? 20:37:45 <flo> if no (actually used) other client implements it, is there a point in implementing it? 20:37:46 <clokep_work> aleth: That would be a nice protocol option too, but I'm not sure if it'd be really easy or really hard. ;) 20:38:03 <clokep_work> flo: Probably not. I'd like to do it for funa t some point though. :) 20:38:05 <aleth> It'd be useful for us ;) 20:38:16 <clokep_work> aleth: Whiteboarding includes arbitrary shapes in my mind though. 20:39:49 --> Plop has joined #instantbird 20:41:04 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org) 20:43:46 <clokep_work> And session restore too, but that is probably too small of a project? 20:45:13 <flo> right, session restore doesn't seem very difficult 20:46:08 <clokep_work> I could probably hack that on my trip up tomorrow if I wasn't driving. :P 20:46:43 <aleth> Google Afternoon of Code? ;) 20:46:55 <aleth> wonder what you get for that... 20:47:26 <clokep_work> A headache for coding in the car. :P 20:47:34 <clokep_work> Account Import Wizard from last year is still wanted. 20:53:53 <flo> clokep_work: yeah, it's hard to code while driving :( 20:55:19 <clokep_work> Yes, makes me wish I took mass transit to work everyday sometimes 20:59:45 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1187 on bug 1096. 20:59:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1096 nor, --, ---, nobody, NEW, Add "Visible tags..." entry to contacts window background context menu too 21:03:37 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 21:05:38 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre) 21:08:33 <-- waynenguyen has quit (Ping timeout) 21:09:33 --> waynenguyen has joined #instantbird 21:14:39 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 21:14:47 --> aleth has joined #instantbird 21:14:48 * ChanServ sets mode +h aleth 21:18:32 <-- micahg has quit (Ping timeout) 21:19:54 --> mmkmou has joined #instantbird 21:22:23 <-- mmkmou has quit (Ping timeout) 21:25:10 --> mmkmou has joined #instantbird 21:28:35 <-- flo has quit (Quit: Instantbird 1.2a1pre) 21:34:25 --> micahg has joined #instantbird 21:38:54 <-- mmkmou has quit (Ping timeout) 21:40:58 --> mmkmou has joined #instantbird 21:43:11 <-- mmkmou has quit (Ping timeout) 21:47:05 <-- micahg has quit (Ping timeout) 21:55:46 --> clokep has joined #instantbird 21:55:47 * ChanServ sets mode +o clokep 21:59:25 --> mmkmou has joined #instantbird 22:02:58 --> micahg has joined #instantbird 22:03:46 <-- mmkmou has quit (Ping timeout) 22:04:01 --> mmkmou has joined #instantbird 22:06:10 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1188 on bug 1096. 22:06:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1096 nor, --, ---, nobody, NEW, Add "Visible tags..." entry to contacts window background context menu too 22:15:04 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre) 22:15:16 --> mmkmou has joined #instantbird 22:24:20 <-- mmkmou has quit (Ping timeout) 22:25:31 --> mmkmou has joined #instantbird 22:32:30 <-- mmkmou has quit (Ping timeout) 22:52:05 --> mmkmou has joined #instantbird 22:53:34 <-- Tonnes has quit (Quit: ChatZilla 0.9.88 [Firefox 9.0.1/20111220165912]) 23:00:16 <aleth> Shouldn't bug 429 be closed? 23:00:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=429 enh, --, ---, nobody, NEW, edit username 23:00:47 <-- Even has quit (Quit: Instantbird 1.2a1pre) 23:03:41 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 318 to DUPLICATE of bug 698. 23:03:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, nobody, RESO DUPLICATE, Check if topic on IRC channels is editable and make UI respond accordingly 23:03:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=698 nor, --, 0.3a2, florian, RESO FIXED, Provide a way to merge contacts 23:04:23 <clokep> aleth: It's not positive that bug 429 isn't valid. Why would you close it? 23:04:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=429 enh, --, ---, nobody, NEW, edit username 23:04:29 <clokep> Uhhh...I don't think those are dups. 23:06:06 <aleth> Oh dear. A typo :( 23:10:08 <aleth> clokep: I assumed the username was part of the account name and so to change that you'd better delete the account and start over. But I'll go with your opinion as I don't know much about account interna ;) 23:11:27 <clokep> It is part of it. :-/ 23:11:34 <clokep> It's just not clear to me that we don't want to allow it. 23:11:39 <clokep> (I don't think we do..but it's an issue.) 23:12:29 <clokep> aleth: I disagree that those are dups. 23:12:56 <clokep> One is about making it more obvious, the other is about disabling it when you don't have the right permissions. 23:14:15 <aleth> But you put exactly that as a comment in bug 798, and it's part of "making it more obvious" when you can that you know when you can't ;) 23:14:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=798 enh, --, ---, nobody, NEW, Make editable topic more discoverable 23:15:35 <aleth> But I'll undupe them if that's more helpful. 23:16:24 <clokep> Yeah I guess. 23:16:32 <clokep> Leave them duped, it'll probably be handled at the same time anyway. 23:17:19 <aleth> I think I should have kept the other one, it had a better title :( 23:18:14 --> jb has joined #instantbird 23:19:47 <-- micahg has quit (Ping timeout) 23:20:00 <clokep> Ha. 23:20:34 --> jb1 has joined #instantbird 23:21:25 <-- jb has quit (Ping timeout) 23:29:36 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 23:30:04 --> Tonnes has joined #instantbird 23:31:26 --> aleth has joined #instantbird 23:31:26 * ChanServ sets mode +h aleth 23:35:37 --> micahg has joined #instantbird 23:37:15 <-- jb1 has quit (Ping timeout) 23:37:20 <clokep> aleth: Yeah Idk how to make it show it's editable. :( But somehow... 23:50:17 <aleth> clokep: Like I said in the bug, I'm not sure it's necessary to do anything special, if the "usual things you would try" are made to work (clicking, context menu). 23:50:43 <clokep> True. :) 23:50:51 <clokep> I do wish links were clickable in it though. :( 23:50:57 <clokep> That's a separate issue though. 23:51:09 <aleth> Yes, that would be nice 23:52:31 <clokep> Get on it. ;) 23:53:23 <aleth> The hard part is figuring out when a user has the permissions to edit it. 23:54:02 <aleth> Of course if JS-IRC provides a neat little boolean... ;) 23:55:50 <aleth> Hmm, XMPP MUCs behave strangely atm. 23:56:24 <clokep> We'd have to add a flag to the chat or something., yes. 23:56:31 <aleth> Maybe they have no topic, ever. 23:57:43 <aleth> And /topic doesn't say "I can't change the topic" either atm