#instantbird log on 02 20 2012

All times are UTC.

00:23:57 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
00:40:34 <-- micahg has quit (Ping timeout)
00:42:02 --> aleth has joined #instantbird
00:42:02 * ChanServ sets mode +h aleth 
00:56:32 --> micahg has joined #instantbird
01:26:37 --> Mook has joined #instantbird
01:54:12 <-- zen_monkey has quit (Ping timeout)
02:23:00 <Mook> hmm, allevet is completely broken on nightlies anyway
02:31:08 <-- Suiseiseki has quit (Ping timeout)
02:33:14 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
02:40:33 --> Suiseiseki has joined #instantbird
03:41:22 <instant-buildbot> build #401 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/401
03:46:51 <-- micahg has quit (Ping timeout)
04:02:46 --> micahg has joined #instantbird
04:17:49 <-- micahg has quit (Ping timeout)
04:20:49 --> clokep has joined #instantbird
04:20:49 * ChanServ sets mode +o clokep 
04:33:56 --> micahg has joined #instantbird
04:55:09 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
05:12:36 <instant-buildbot> build #487 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/487
05:19:58 <-- micahg has quit (Ping timeout)
05:35:57 --> micahg has joined #instantbird
06:06:18 <-- skeledrew has quit (Quit: Instantbird 1.2a1pre)
06:06:28 --> skeledrew has joined #instantbird
06:13:15 --> zen_monkey has joined #instantbird
06:52:16 <instant-buildbot> build #393 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/393
07:30:23 <-- zen_monkey has quit (Ping timeout)
07:48:38 --> Mad_Maks has joined #instantbird
07:57:18 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603])
08:12:19 <-- chrisccoulson has quit (Client exited)
08:13:17 --> chrisccoulson has joined #instantbird
08:19:21 --> MadWookiee has joined #instantbird
08:36:21 --> skeledrew1 has joined #instantbird
08:37:24 <-- skeledrew has quit (Ping timeout)
08:49:15 <-- gerard-majax has quit (Ping timeout)
08:55:33 --> jb has joined #instantbird
09:07:16 <-- Tobin has quit (Quit: And the rain will kill us all / If we throw ourselves against the wall / But no one else can see / The preservation of the martyr in me)
09:44:55 <-- waynenguyen has quit (Ping timeout)
09:47:33 <-- Even1 has quit (Quit: Instantbird 1.2a1pre)
09:47:45 --> Even1 has joined #instantbird
09:50:08 --> aleth has joined #instantbird
09:50:08 * ChanServ sets mode +h aleth 
09:54:55 --> mmkmou has joined #instantbird
09:58:53 <-- micahg has quit (Ping timeout)
10:13:29 --> chrisccoulson_ has joined #instantbird
10:14:44 <-- chrisccoulson has quit (Ping timeout)
10:14:54 --> micahg has joined #instantbird
10:15:31 --> waynenguyen has joined #instantbird
10:17:12 <-- waynenguyen has quit (Ping timeout)
10:20:33 --> gerard-majax has joined #instantbird
10:30:04 --> flo has joined #instantbird
10:30:04 * ChanServ sets mode +qo flo flo 
10:30:35 <flo> hello :)
10:32:38 * chrisccoulson_ is now known as chrisccoulson
10:54:37 --> Mic has joined #instantbird
10:54:37 * ChanServ sets mode +h Mic 
11:01:48 <Mic> I like that: http://log.bezut.info/instantbird/120212/#m120 :)
11:11:06 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
11:11:33 --> Mic has joined #instantbird
11:11:33 * ChanServ sets mode +h Mic 
11:13:31 <flo> the stanza exchanged between instantbird and the gtalk servers around buddy additions are quite confusing, and I suspect it's not really my fault
11:14:14 <flo> the gtalk server seems to send 4 roster pushes in a row, with (in this order): subscription="to", subscription="both", subscription="to", subscription="both". :-S
11:14:56 <flo> each time we get a roster push for a buddy, we request the buddy's vcard
11:15:22 <flo> so we request it 4 times (before receiving the first reply :-/)
11:16:57 <flo> the gtalk server sends it for the first 3 requests, and replies <error xmlns="jabber:client" code="500" type="wait"><resource-constraint xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/> for the 4th
11:18:00 <flo> I wonder if we should somehow cache that we have requested a vcard for a buddy but not received a response yet, so we shouldn't be requesting it again.
11:18:50 <flo> there may be a risk of never getting it if somehow the first request never receives any answer :-/
11:22:32 <flo> and if the contact is removed, we receive 4 roster pushes too. subscription=to, then none, to, and none again
11:28:02 --> clokep has joined #instantbird
11:28:02 * ChanServ sets mode +o clokep 
11:31:29 <-- micahg has quit (Ping timeout)
11:33:06 <aleth> flo: Is there someone at Google you can talk to about that? it sounds very odd
11:37:07 <flo> I don't know anybody who would be likely to change this, no
11:37:25 <flo> there are probably some kind of /dev/null-like bug trackers
11:38:26 <aleth> There is not even an Issues section on the gtalk dev google code site
11:39:18 <flo> probably because it doesn't have any issue ;)
11:39:27 <aleth> Ah, that might be it ;)
11:41:46 <aleth> The "ask other developers" link goes here :P https://groups.google.com/group/google-talk-open
11:43:11 <flo> aleth: by the way, your comment in bug 663 was quite good ;)
11:43:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=663 enh, --, ---, nobody, RESO INVALID, Implement alerts tab on buddy list for notifications and alerts
11:45:15 <-- MadWookiee has quit (Ping timeout)
11:45:57 <flo> and thanks for closing all these old bugs :)
11:47:29 --> micahg has joined #instantbird
11:53:20 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
11:53:31 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
11:53:35 --> clokep has joined #instantbird
11:53:35 * ChanServ sets mode +o clokep 
11:53:37 <-- clokep has quit (Connection reset by peer)
11:56:52 <aleth> Btw, bug 839 is another one which I think should be closed, but I wasn't sure in what way exactly. Maybe someone else can do it ;)
11:56:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=839 nor, --, ---, nobody, UNCO, User data (name and icon) not fetched or shown in contact list upper part
12:02:13 --> MadWookiee has joined #instantbird
12:04:22 <flo> I'm not sure about this one. It's poorly phrased (or not phrased at all :-S) but there may seem to be a valid request hidden in there
12:06:24 --> Mic has joined #instantbird
12:06:24 * ChanServ sets mode +h Mic 
12:06:25 --> Tomek has joined #instantbird
12:06:34 <aleth> Could be, in which case some follow up question is required. The part about separate-avatar-per-account is clearly not wanted
12:07:09 <flo> yeah...
12:07:39 <aleth> Maybe it's "if I have no icon set but one of my connected accounts has a vcard for me, use that to set it"?
12:08:09 <-- Tomek has quit (Ping timeout)
12:08:09 <flo> I think that's what he wanted, yes
12:08:59 --> Tomek has joined #instantbird
12:10:33 <aleth> Is that desired behaviour for IB? I mean, in that case either the bug should be confirmed or wontfix
12:11:51 <flo> desirable if we could get it for free, probably. Is it worth spending time implementing it? I'm not sure
12:12:20 <aleth> I guess the tricky part is that if a user then changes the icon, she might assume it is also changed on the account servers
12:12:46 <Mic> Aren't we doing that already?
12:13:16 <flo> we try to, but I don't think it works consistently across all supported protocols
12:14:04 <aleth> At any rate, in that case there is no conflict. I'll confirm it then... you never know, someone might want to fix it one day
12:14:44 --> Tomek1 has joined #instantbird
12:15:11 <-- Tomek has quit (Ping timeout)
12:16:48 <flo> aleth: the problems I see is that people will expect the most recently set icon to take over, but the list of configured accounts may not be the same on all clients where an account is used
12:18:36 <aleth> I don't see a way to avoid conflicts in all circumstances either. But I doubt the proposed behaviour would make things worse.
12:18:50 <flo> right, it wouldn't be worse :)
12:20:36 <aleth> Btw Mic there was a bug discussion over the weekend where clokep and I suspected you'd know the answer ;)
12:21:20 <Mic> The input-box-padding-bug I guess?
12:21:29 <-- Tomek1 has quit (Ping timeout)
12:22:22 <aleth> Yup.
12:23:27 <Mic> It looks like on his screenshot for me but I never thought it is broken (or even noticed that something could/should be different there).
12:24:12 <Mic> bbl (lunch)
12:34:12 --> Tomek has joined #instantbird
12:40:00 --> clokep_work has joined #instantbird
12:40:00 * ChanServ sets mode +o clokep_work 
12:50:56 <-- Tomek has quit (Ping timeout)
12:57:21 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1110 to DUPLICATE of bug 634.
12:57:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1110 enh, --, ---, nobody, RESO DUPLICATE, Control text color of outgoing messages without effecting any other text
12:57:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=634 nor, --, ---, nobody, NEW, Richtext formatting for outgoing messages
13:06:45 <clokep_work> Only 39 more. ;)
13:08:15 <aleth> Yup. And someone in the know could do bug 1267 easily ;)
13:08:18 <clokep_work> The big problem with bug 839 is trying to resolve conflicts from all the accounts. :-/
13:08:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1267 min, --, ---, nobody, UNCO, Rename "MSN" to "Windows Live Messenger" and use the new logo
13:08:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=839 min, --, ---, nobody, NEW, Use icon from new accounts to set the user's avatar if none is set
13:08:50 <aleth> clokep_work: I moved it to the account wizard so it is separate from the conflicts issue.
13:10:31 <aleth> It's basically "if the user adds an account and hasn't set his icon (or name I guess), be helpful it that data is available"
13:10:34 <aleth> s/it/if
13:17:48 <clokep_work> So you cheated. ;)
13:18:41 <clokep_work> Idk about #1267, I agree it'd be good to keep it up to date, but I'm hesitant to rename something like that from libprpl, although we do modify it a bit already so...
13:18:49 * clokep_work defers to flo's opinion there. ;)
13:20:41 <aleth> clokep_work: it's a cheat, but it's one that would make the reporter happy :D
13:21:50 <Mic> How difficult is the rename? Is it just a search and replace, most likely?
13:21:59 <flo> I don't mind modifying it from libpurple
13:22:07 <flo> the problem is do most people understand "WLM" or "MSN"?
13:22:43 <flo> I don't have the answer :)
13:23:16 * clokep_work adds "WLM over XMPP" to that list. ;). :P
13:24:32 <aleth> I have never seen WLM as an acronym. The icon is more arguable.
13:25:12 <flo> if we switch to a 2 lines display of the most common networks, the icon will be bigger
13:25:48 <flo> and we can write "Windows Live Messenger" as the title on the first line, and "formerly known as MSN" on the description line
13:26:16 <aleth> Windows Live Messenger (MSN)
13:27:04 <clokep_work> Gross. :-/
13:27:18 <aleth> but clear ;)
13:27:44 <aleth> whereas formerly known as sounds like Prince
13:30:16 <aleth> well, either does the job really
13:36:00 <clokep_work> So...
13:36:19 <clokep_work> You want, "Windows Live Messenger, the network formerly known as <MSN icon>"?
13:51:05 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
13:51:43 --> Mic has joined #instantbird
13:51:43 * ChanServ sets mode +h Mic 
13:55:20 <Mic> What about offering options for the user icon on a panel? This could include all detected icons from different networks maybe, so the user can pick one?
13:56:03 <flo> and a way to make a new icon from the webcam!
13:56:07 <Mic> https://wiki.instantbird.org/File:IbUserIconSelector.png
14:07:53 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
14:18:44 --> Mic has joined #instantbird
14:18:44 * ChanServ sets mode +h Mic 
14:21:42 <Mic> I rearrangedthe items and updated the screenshot. Webcam is in there now ;)
14:22:49 <flo> This is what I'm currently debugging: http://i.imgur.com/M8873.png
14:23:07 <flo> what bothers me is that it tends to look like this: http://i.imgur.com/lOebT.png :(
14:24:45 <Mic> Cool, but why isn't it moving the button to the line below?
14:24:58 <Mic> *buttons
14:25:43 <flo> Mic: any idea of how I can make it do that?
14:26:23 <Mic> We had an own binding for the topic bar once and it seemed to resize as necessary?
14:27:06 <flo> it does resize
14:27:33 <flo> but the minimum acceptable width is the width of the first word of the text + the width of all buttons
14:36:51 <Mic> hmm, sorry, I don't know.
14:40:35 <clokep_work> The contact list is kind of an awful place to display things like that because most people seem to keep it narrow. :(
14:41:09 <flo> yeah, we should just add a events tab!
14:41:15 <flo> (just kidding of course :))
14:42:13 <flo> I think opening a conversation from the potential new contact with a message containing the actions would be better
14:42:24 <flo> but we currently don't have a good way to display buttons on a message...
14:42:29 <flo> so it seems that would be more work
14:42:38 <clokep_work> :-/ Right.
14:43:30 * clokep_work just got a 65x performance increase in his code!
14:44:35 <clokep_work> I think that that's the logical way to do it right now though flo. Even if it doesn't always look that great. :-/
14:45:15 <flo> my concern is that if the window is narrow enough, buttons are completely invisible (and the horizontal scrollbar isn't really discoverable)
14:46:24 <flo> hmm, I think the JS-XMPP part works now :)
14:49:24 <Mic> hmm, yes. The "Change"-button of Instantbird 0.2 didn't flow to a second line either if the windows was very narrow.
14:49:42 <clokep_work> Mic: And that's a nice screenshot, you should attach that to that bug. ;)
14:52:57 * flo is attempting crazy CSS hacks on that damn notification bar
14:54:13 <clokep_work> What's the opinion on bug 837?
14:54:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=837 nor, --, ---, nobody, UNCO, Give new tabs opened via IRC commands focus
14:54:29 <clokep_work> Pretty much if a user interacts to join a chat, should we focus it right away?
14:55:08 <flo> I think we should
14:55:25 <clokep_work> I agree.
14:55:48 <flo> I also think releasing a few times before fixing this would be quite OK ;)
15:02:14 <flo> http://i.imgur.com/njU9x.png
15:03:04 <flo> or course it's http://i.imgur.com/YfcSx.png that I meant to upload
15:07:20 <Mic> Nice, how did you do that?
15:07:23 <Mic> Via CSS?
15:07:30 <Mic> word-wrap or something?
15:07:38 <flo> yes, CSS
15:07:45 <flo> word-wrap doesn't work :(
15:08:07 <flo> if I could get it to work I wouldn't have a scrollbar when the window is narrower than "testinstantbird@gmail.com"
15:09:00 <flo> Mic: the "solution" (it's rather a hack :-/) was to put display: inline-block (list-item also works) on the hbox that contains both the description and the buttons
15:09:53 <flo> and the icon didn't like that; it was on its own line, so I added a display:none on it. But it was pointless and a waste of space, so I'm not too sad that it's gone :)
15:11:47 <flo> it's not perfect, but I think it will be usable for now
15:11:57 <flo> and it's definitely nicer than the modal dialog we currently have :)
15:14:50 <Mic> Indeed.
15:15:43 <aleth> That's a *lot* nicer than a modal dialog! :)
15:16:24 <aleth> Putting the buttons in a float didn't work?
15:16:50 <flo> a float in XUL? :-S
15:16:50 <clokep_work> flo: What happens if you get multiple request at once? Do they queue?
15:17:16 <flo> clokep_work: notification bars pile up requests, you see at most one at a time
15:17:31 <aleth> flo: ah, there is no equivalent? ok...
15:18:08 <flo> aleth: I'm not sure. I've just never seen that
15:19:01 <flo> and they are even canceled correctly :) (when disconnecting the account)
15:19:47 <Mic> If you want something to float somewhere, then put it on a panel? ;)
15:20:20 <flo> we couldn't cancel modal dialogs, so the old code just replaced with NULL the callback so that nothing would be done when the user decided which button to click in the dialog for a canceled request
15:20:51 <flo> (and even before that, it used to just crash, that was our top crasher up to 0.1.<something> :))
15:24:54 <flo> who's interested in reviewing that patch?
15:25:52 <clokep_work> I can probably take a gander at it.
15:26:36 <flo> hmm, I haven't tested at all the C++ code (I just know that it compiles)
15:26:37 * instantbot frowns at flo
15:26:58 <flo> I guess I should try that
15:27:07 <flo> with a libpurple-XMPP account :)
15:28:53 <flo> hmm, libpurple saves the value of the ask= attribute
15:34:03 <flo> the C++ code works too :)
15:36:06 <clokep_work> :) !
15:36:45 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1178 on bug 1251.
15:36:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1251 nor, --, ---, florian, NEW, Can't accept/add buddies with JS-XMPP (regression for GTalk accounts)
15:42:40 * aleth is going to read http://blog.astithas.com/2012/02/debugging-javascript.html this evening
15:45:04 <-- mmkmou has quit (Ping timeout)
15:46:18 <flo> I'm not completely sure of what's left to do in bug 507
15:46:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=507 enh, --, ---, clokep, ASSI, Implement IRC in JavaScript
15:50:25 --> mmkmou has joined #instantbird
15:56:49 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
15:57:43 <clokep_work> flo: The connecting/disconnecting logic.
15:57:47 <clokep_work> I'm not sure what your concerns are.
15:58:35 <flo> the last time I tried your patch, I think there were some cases were the account manager was stuck on the "disconnecting" state (ie reportDisconnecting was called, but reportDisconnected was never called after that)
15:58:46 <flo> if it's not that, then I don't remember what it is :)
15:58:59 <flo> but it could very well be interactions with the offline status, as that tends to be annoying :)
15:59:41 --> jb1 has joined #instantbird
16:00:14 <-- jb has quit (Ping timeout)
16:02:18 <flo> I just tried to reproduce bug 1205 to see how the data is stored
16:02:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1205 nor, --, ---, nobody, NEW, Cyrillic support in alias and buddy list broken
16:02:28 <flo> Instantbird 1.1 stores these values in UTF8
16:03:05 <flo> my current debug build stores them in the local encoding (iso8859-1 for me)
16:10:11 <flo> bah, apparently JS code is supposed to call getComplexValue(null, Components.interfaces.nsISupportsString) and setComplexValue(null, Components.interfaces.nsISupportsString, value) when the value is expected to contain non-ASCII characters
16:10:17 <flo> crappy pref API... :(
16:11:20 <aleth> Huh. When strings are not strings.
16:13:13 <flo> I guess on some protocols account names can also contain non ascii strings
16:13:43 --> zen_monkey has joined #instantbird
16:15:20 <aleth> QQ, possibly?
16:16:23 <clokep_work> Bleh. :( That's annoying.
16:16:36 <flo> aleth: yeah, that's what I had in mind
16:19:33 --> igorko has joined #instantbird
16:19:40 <flo> http://pastebin.instantbird.com/13466 this fixes the display name
16:19:43 <flo> awful :(
16:21:22 <aleth> Is it worth writing a wrapper to store all pref strings as ComplexValue instead? :(
16:28:34 <aleth> The command line interface in http://vimeo.com/35951775, is that a standard mozilla component? You don't see much of it there, but it looks potentially awesome
16:30:06 <aleth> Ah, https://wiki.mozilla.org/DevTools/Features/GCLI
16:36:44 <-- igorko has quit (Connection reset by peer)
16:48:06 <instantbot> clokep@gmail.com granted review for attachment 1178 on bug 1251.
16:48:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1251 nor, --, ---, florian, NEW, Can't accept/add buddies with JS-XMPP (regression for GTalk accounts)
16:50:28 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1179 on bug 1205.
16:50:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1205 nor, --, ---, florian, ASSI, Cyrillic support in alias and buddy list broken
16:56:42 <instantbot> clokep@gmail.com granted review for attachment 1179 on bug 1205.
16:56:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1205 nor, --, ---, florian, ASSI, Cyrillic support in alias and buddy list broken
16:57:02 <flo> clokep_work: I replied to your comment
16:57:15 <clokep_work> I saw. :)
17:02:32 <flo> so I should do it for http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#651 tooM
17:02:35 <flo> ?
17:03:34 <flo> and http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#190 will need to be adapted to match
17:04:20 <clokep_work> I don't know if we should for sure or not.
17:04:27 <clokep_work> Just thought I'd bring it up.
17:10:09 <flo> we should do it if we expect JS-protocols to have preferences with non-ASCII values
17:11:14 <flo> the only down side is, if existing users have non-ascii values for the track keyword Twitter preference, the change will break it
17:14:10 <flo> clokep_work: I can remove the else if you want
17:15:39 <clokep_work> flo: Please do.
17:15:55 <clokep_work> Or we can say protocols should handle it themselves. ;)
17:16:01 <flo> are we doing a meeting 15 minutes ago? :)
17:16:09 * clokep_work is going to lunch in a second.
17:16:13 <flo> clokep_work: they can't.
17:16:49 <flo> (at least, they can't without breaking the imIAccount/prplIAccount split)
17:16:49 <clokep_work> I think it's a good change to make, would a non-ASCII value even work right now in Twitter tracked keywords?
17:16:58 <flo> maybe?
17:17:13 * aleth can have a meeting 
17:18:25 <aleth> Doesn't it just depend on whether twitter supports non-ascii keywords?
17:19:00 <flo> bah, if we create a twitter account with "connect now" checked, we open 2 OAuth dialog :(
17:19:03 <clokep_work> It also depends on how we're encoding them and passing them.
17:19:24 <aleth> Btw flo just a heads up, I noticed on the weekend some r+ patches of mine hadn't landed, not sure whether you saw it in the log
17:19:34 <flo> I saw
17:20:15 <flo> why does that dialog prompt me to remember my password?
17:20:33 --> Mook_as has joined #instantbird
17:20:48 <clokep_work> We changed the default of whether passwords were optional or not.
17:20:56 <flo> clokep_work: tracking "été" on twitter works
17:21:00 <clokep_work> Probably need to mark Twitter has having it optional.
17:21:05 <clokep_work> *as
17:21:14 <flo> clokep_work: twitter is marked as noPassword
17:21:36 <flo> if we don't change anything for JS-proto prefs, then the values will be stored in the local encoding
17:21:38 <clokep_work> Oh. :(
17:21:39 <flo> for French it works
17:21:53 <flo> I'm not sure it would work for Chinese characters though
17:21:58 <aleth> é is ASCII I think
17:22:37 <clokep_work> I don't know if it would work.
17:22:44 <flo> aleth: it fits on a single byte in iso8859-1, but it's not in US-ASCII (or at least, it needs 2 bytes in UTF8)
17:22:59 <clokep_work> It would break if you move to a different computer w/ a different encoding though, right?
17:23:01 <aleth> oh, one of those :-/
17:23:10 <flo> clokep_work: possibly
17:23:18 <flo> but we have never guaranteed that case would work
17:23:49 <flo> what would definitely break is a JS-protocol replacing a libpurple-protocol for the same protocol id, and expecting to read the previously set preferences
17:24:07 <clokep_work> Ah, I see.
17:24:16 <clokep_work> Sounds like we should leave it as is then.
17:24:17 <flo> for example, if JS-IRC wanted to read the "real name" pref of libpurple-IRC, that would break
17:24:18 <aleth> What if the wrapper function uses a try?
17:24:34 <flo> aleth: what's throwing?
17:25:32 <aleth> Oh. I see.
17:26:33 <flo> wait, isn't it broken already?
17:27:17 <flo> it seems the JS code saves these prefs even for libpurple accounts
17:27:22 <flo> as it's now done in imAccount
17:27:37 <flo> but purplexpcom/libpurple reads them as UTF8
17:28:41 <flo> http://lxr.instantbird.org/instantbird/source/instantbird/content/account.js#200 is broken too, so it's not visible
17:29:03 <clokep_work> :-(
17:29:24 <flo> this may explain why my Real Name is currently broken on IRC
17:30:00 <flo> it seems hard to fix this and keep the code as nice as it currently is in http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#190
17:30:48 <clokep_work> Yeah, we could just special case Strings then.
17:33:53 --> testib has joined #instantbird
17:34:21 <flo> testib's username and real name seem broken
17:36:49 <-- testib has quit (Quit: Instantbird 1.2a1pre)
17:42:13 --> testib has joined #instantbird
17:42:44 <-- testib has quit (Quit: Instantbird 1.2a1pre)
17:42:52 --> testib has joined #instantbird
17:42:58 --> igorko has joined #instantbird
17:43:30 <-- testib has quit (Quit: Instantbird 1.2a1pre)
17:44:03 --> testib has joined #instantbird
17:44:58 <-- testib has quit (Quit: Instantbird 1.2a1pre)
17:45:37 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
17:47:05 <flo> bah, http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccount.idl#131 is wrong too :(
17:59:00 --> testib has joined #instantbird
17:59:29 <flo> ah, this looks better :)
18:10:28 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre)
18:16:35 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1180 on bug 1205.
18:16:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1205 nor, --, ---, florian, ASSI, Cyrillic support in alias and buddy list broken
18:22:20 <-- jb1 has quit (Ping timeout)
18:28:00 <-- flo has quit (Quit: Instantbird 1.2a1pre)
18:29:53 <-- testib has quit (Ping timeout)
18:31:26 <-- gerard-majax has quit (Ping timeout)
18:33:11 --> Even2 has joined #instantbird
18:33:33 <-- Even2 has quit (Quit: Instantbird 1.2a1pre)
18:33:40 --> Even2 has joined #instantbird
18:36:31 <instantbot> clokep@gmail.com granted review for attachment 1180 on bug 1205.
18:36:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1205 nor, --, ---, florian, ASSI, Cyrillic support in alias and buddy list broken
18:52:51 --> aleth has joined #instantbird
18:52:51 * ChanServ sets mode +h aleth 
19:02:26 <-- micahg has quit (Quit: Ex-Chat)
19:14:14 --> micahg has joined #instantbird
19:20:16 --> gerard-majax has joined #instantbird
19:21:21 <-- gerard-majax has quit (Quit: Ex-Chat)
19:21:22 --> gerard-majax_ has joined #instantbird
19:22:19 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1206 to INVALID.
19:22:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1206 nor, --, ---, nobody, RESO INVALID, Newly added contacts disappears until instantbird restart
19:27:46 * gerard-majax_ is now known as gerard-majax
19:30:50 <-- MadWookiee has quit (Quit: Instantbird 1.1)
19:34:22 --> zen_monkey_ has joined #instantbird
19:35:14 <-- zen_monkey has quit (Ping timeout)
19:35:18 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 706 to WONTFIX.
19:35:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=706 enh, --, ---, nobody, RESO WONTFIX, Automatically resize buddy list
19:37:04 <-- micahg has quit (Ping timeout)
19:39:29 --> devfil has joined #instantbird
19:42:07 --> flo has joined #instantbird
19:42:07 * ChanServ sets mode +qo flo flo 
19:44:49 <flo> aleth: re bug 1206, the description seems to indicate that "show offline contacts" is enabled
19:44:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1206 nor, --, ---, nobody, RESO INVALID, Newly added contacts disappears until instantbird restart
19:45:20 <aleth> Oh :( How did I miss that?
19:45:41 <flo> the phrasing is a bit odd, so English doesn't seem to be the reporter's native language
19:45:43 <aleth> Does the bug report make any sense to you then?
19:46:01 <flo> well
19:46:10 <flo> I think I know what he's describing
19:46:47 <flo> when adding a buddy, libpurple always adds the buddy to the blist first, then tries to send the message to the server, and if that fails for some reason, removes the buddy from the list
19:46:49 <instantbot> aletheia2@fastmail.fm cleared the Resolution 'INVALID' from bug 1206.
19:46:51 <aleth> Why would a contact disappear when offline?
19:46:55 <aleth> Ah \
19:47:07 <flo> we used to have a case where libpurple did that when no invitation message was provided
19:47:13 <aleth> So it's libpurple being strange
19:48:05 <flo> the report seems to be mostly about ICQ, but at the end there's something saying it's the same with XMPP/Jabber
19:48:22 <flo> I wouldn't be very surprised if we had that kind of brokeness with ICQ, but with XMPP it's a bit more surprising
19:48:48 <flo> or maybe the libpurple XMPP plugin deletes the buddy if the contact has deleted it or refused the authorization request
19:49:02 <aleth> But he says after restart it was OK?
19:49:14 <flo> ahah!
19:49:59 <flo> could be a problem with the "Other contacts" special tag (if some tags are hidden)
19:50:53 <aleth> Why would a buddy disappear from a tag but then be present on restart
19:51:05 <flo> could also be an animation bug (when the authorization is granted, the XMPP contact likely receives a vcard containing a display name to replace the email address, so it's expected that the contact disappears and reappears at another place in the list of the same group, as it's moved for alphabetical sorting
19:51:30 <flo> hmm, and that's completely broken right now, by the way :-D
19:52:12 <flo> (bug 1178)
19:52:16 <aleth> Hmm that could explain it
19:52:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1178 maj, --, ---, nobody, NEW, Regression: renamed contacts disappear from list
19:52:29 <clokep_work> That was my guess. ;)
19:52:43 <flo> the XMPP part could be a dup of that bug
19:53:03 --> micahg has joined #instantbird
19:53:19 <flo> oh well, if the ICQ contact is still there after a restart, it's not libpurple removing it
19:53:26 <flo> it may have received a display name too
19:53:35 <flo> in which case, the whole bug is a confusing dup of bug 118
19:53:38 <aleth> Could be similar
19:53:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=118 min, --, 0.3a2, florian, RESO FIXED, Extensions should be able to register commands.
19:53:38 <flo> *1178
19:56:08 <aleth> But 118  would have been fixed in 1.1
19:57:17 <aleth> Even in 1.0
20:00:40 <-- micahg has quit (Ping timeout)
20:05:29 --> Mnyromyr has joined #instantbird
20:09:17 <-- flo has quit (Ping timeout)
20:16:11 --> micahg has joined #instantbird
20:20:31 --> flo has joined #instantbird
20:20:32 * ChanServ sets mode +qo flo flo 
20:33:41 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
20:38:18 <flo> hmm, I have a contact who was marked available on his conversation tab, but wasn't visible in the contact list
20:38:26 <flo> not even when showing offline contacts
20:38:42 <flo> closing the contacts window and reopening it (we can do that on Mac ;)) made it reappear
20:38:46 <-- micahg has quit (Ping timeout)
20:38:58 <flo> I wonder what could be causing that
20:39:33 <clokep_work> flo: I think bug 1178 will do that.
20:39:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1178 maj, --, ---, nobody, NEW, Regression: renamed contacts disappear from list
20:40:10 <flo> hmm
20:40:13 <flo> maybe we should fix it then! :)
20:40:45 <flo> and yes, it's possible as there are 2 grouped buddies in that contact, and they don't start with the same letter
20:41:03 <flo> so if the 2nd buddy is marked online before the first one, the contact doesn't appear at the correct place at first
20:41:07 --> micahg has joined #instantbird
20:42:41 <clokep_work> We should! :)
20:45:00 <-- micahg has quit (Ping timeout)
20:59:11 <-- devfil has quit (Ping timeout)
20:59:53 --> Tomek has joined #instantbird
21:00:51 <-- Tomek has quit (Connection reset by peer)
21:01:18 --> Tomek has joined #instantbird
21:01:26 --> micahg has joined #instantbird
21:05:00 <clokep_work> flo: Will that authorization bug possibly fix bug 1240?
21:05:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1240 maj, --, ---, nobody, UNCO, Invites from Google Talk (in Google App account) are lost by Instantbird
21:06:24 <flo> afaik it hasn't been reproduced, so it's possible it was just a temporary server issue
21:07:04 <flo> I know other people who have had issues adding Gtalk contacts, and Instantbird wasn't directly responsible for that
21:08:16 <clokep_work> Oh OK.
21:29:24 <-- zen_monkey_ has quit (Ping timeout)
21:30:01 --> devfil has joined #instantbird
21:35:27 <-- Mad_Maks has quit (Quit: Instantbird 1.2a1pre)
21:41:00 <flo> we should update Mozilla before releasing, shouldn't we?
21:42:08 --> mmkmou has joined #instantbird
21:42:32 <clokep_work> I think so at this point.
21:42:37 <clokep_work> To 10.0.2.
21:43:32 <Mook_as> esr or no esr?
21:43:50 <flo> it's too bad we can just jump to 12 to have the text/html DOMParser :-/
21:44:05 --> zen_monkey_ has joined #instantbird
21:44:48 <clokep_work> Well I mean we can...but it'll push off release. :P
21:45:15 <flo> yeah, that would be way too far :(
21:47:47 --> aleth has joined #instantbird
21:47:47 * ChanServ sets mode +h aleth 
21:51:45 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
21:57:01 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
22:08:16 <-- chrisccoulson has quit (Ping timeout)
22:10:20 --> chrisccoulson has joined #instantbird
22:10:40 <-- chrisccoulson has quit (Connection reset by peer)
22:10:42 --> chrisccoulson has joined #instantbird
22:19:21 <flo> aleth: I've just looked at these 2 bugs
22:19:45 <flo> bug 1252 annoys be because I don't understand why the patch would fix an issue I don't understand either ;)
22:19:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1252 nor, --, ---, aletheia2, ASSI, First listitem in log viewer never shows that it is selected
22:20:16 <aleth> Yes, I understand that feeling :)
22:20:26 <flo> for bug 869, I wonder why "and when the tray icon isn't always visible" has been added to a comment. That sentence becomes non sense with that :(
22:20:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=869 nor, --, ---, aletheia2, ASSI, Contacts window forgets screen position when closed
22:21:18 <flo> I also don't understand why it's suddenly no longer necessary to call methods from this._icon
22:22:11 <aleth> However, after trying to find testcases for listbox issues all probably caused by when the XBL actually binds, and seeing the number of open mozilla bugs related to that issue, I thought it probably wasn't worth trying to understand it better
22:23:13 <flo> aleth: if you are sure it's a problem related to binding attachment, you can force it by forcing the layout (we have that hack in several places)
22:24:09 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:24:34 <aleth> flo: If it was straightforward, an ensureVisible on the listitem should fix it, but it doesnt. But could you link to the code you are referring to?
22:24:57 <aleth> Re the other bug, you are right, that comment should go. It was copy and pasted in the reorganisation clokep asked for.
22:26:09 <aleth> If I understood clokep correctly, the trayService call is merely more general than the direct way via this._icon.
22:26:16 <flo> aleth: http://lxr.instantbird.org/instantbird/source/instantbird/content/blist.js#486 By requesting the getBoundingClientRect, we force the layout engine to apply CSS rules (and so attach XBL bindings) immediately to compute the element's size
22:27:31 <aleth> flo: Sounds similar to the ensureVisible attempt, but I'll give it a go. I do think you can see from the patch "half" the reason why it works.
22:28:12 <flo> calling minimize on the tray service seems to create a new icon (if I read http://lxr.instantbird.org/instantbird/source/instantbird/components/mintrayr/trayToolkit.cpp#408 correctly)
22:28:43 <flo> calling restore on the service instead of the icon seems ok, it just forwards the call to the icon
22:30:19 <flo> aleth: honestly, the biggest problem I see with that (the listitem one) patch is that there's no comment indicating what's the hack, where it begins, where it ends, what it works around, ... so we can be sure the next refactoring will break it
22:30:26 <aleth> flo: That's interesting. I was only worried about the restore part.
22:30:33 <flo> I would really prefer understanding the situation though :)
22:33:42 <flo> aleth: any reason for not testing window.windowState == STATE_MINIMIZED at the begining of the method, and handling that case completely separately?
22:34:23 <flo> if I understood correctly, if the window is minimized to the taskbar instead of to the systray, you want to show it, but it's completely unrelated to the systray icon
22:34:48 <flo> what about just calling window.restore() ?
22:35:44 <-- mmkmou has quit (Ping timeout)
22:36:10 --> mmkmou has joined #instantbird
22:39:13 <flo> aleth: https://developer.mozilla.org/en/XUL/Events#Window_activation_events isn't sizemodechange a more interesting event?
22:40:11 <flo> I wonder if instead of putting the position in JS value you could put it in attributes of the window, and persist these attributes, so that you can also restore the position onload
22:40:20 <flo> the position would then persist across restarts
22:43:03 <aleth> I don't quite understand your first concern. What's the problem with that clause exactly? 
22:44:53 <-- mmkmou has quit (Ping timeout)
22:47:28 <aleth> i.e. any reason for handling it separately?
22:48:58 <aleth> What do you mean by "persist those attributes"?
22:49:47 <aleth> Isn't sizemodechange going to fire more often, unnecessarily for our purposes?
22:51:22 <flo> deactivate will be fired each time you select another window
22:51:43 <flo> sizemodechange will fire only if you minimize/maximize/restore
22:52:05 <flo> "I don't quite understand your first concern. What's the problem with that clause exactly? " that I can't understand it!
22:53:29 <aleth> Oh. It is there for the case that the user has not selecte minimize-to-tray, minimizes to the taskbar, but then tries to restore the window via the tray.
22:54:16 <flo> I guessed that
22:54:26 <aleth> That's what I thought from your comment ;)
22:54:42 <flo> but if the window hasn't been minimized to the tray, why are you calling trayMagicStuff.restore instead of window.restore?
22:56:02 <aleth> It just seemed less confusing in this context to handle it together, and doesn't do any harm afaik. Seems I was wrong ;)
22:57:04 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/bce36aedaa74 - Florian Quèze - Bug 1251 - Implement adding/removing buddies in JS-XMPP, r=clokep.
22:57:05 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/69ff22bff5e3 - Florian Quèze - Bug 1205 - Propertly UTF8 encode string preferences, r=clokep.
22:57:06 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/46f3a0c1a1ea - Florian Quèze - Fix the test for anchors without href in convbrowser.xml.
22:57:07 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/aeeb3eb04a8e - Florian Quèze - Bug 1251 - part 2 - Show buddy authorization requests for JS-XMPP, r=clokep.
22:58:20 <flo> putting conditions for completely unrelated cases in the same test without even a comment seems quite confusing to me
22:58:30 <flo> not sure if others agree
22:59:33 <flo> but whatever, I'm not completely opposed to the existing code (if a comment explains what it does / which situations can happen)
22:59:57 <flo> I'm not sure the change to the minimize call is right though
23:00:23 <aleth> I don't mind separating it out. What is puzzling me at the moment is why that minimize call didn't cause any trouble in testing. Trying to understand the C part 
23:01:23 <aleth> When you said "persisting attributes" did you mean in a new pref?
23:02:21 <Mook_as> persist= in localstore.rdf?
23:02:34 <Mook_as> err, persist= attribute on the xul, which gets stored in localstore.rdf
23:02:39 --> mmkmou has joined #instantbird
23:03:24 <aleth> Mook_as: This is new to me. Sounds good
23:03:52 <Mook_as> stuff like https://developer.mozilla.org/en/XUL/Attribute/persist
23:04:02 <aleth> Yes, found it
23:04:07 <Mook_as> note that if you're playing with window state stuff, you _definitely_ want to test on the mac
23:04:21 <aleth> Mook_as: This is only needed for Linux
23:04:24 <Mook_as> it was buggy on the branch I was using; I can't remember if it got fixed
23:05:10 <aleth> flo: I'll take another look at that listbox issue, and at least add a comment if that ClientRect trick turns out not to work
23:06:21 <instant-buildbot> build #219 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/219
23:06:22 <flo> Mook_as: aleth's current code is in ifdefs to only be there on Linux, so I'm not too scared about the behavior on Mac :)
23:06:28 <-- mmkmou has quit (Ping timeout)
23:06:30 <Mook_as> :D
23:06:39 <flo> and yes, I meant with persist=
23:06:53 <flo> we already persize the size and position, but the persisted position doesn't work on linux
23:07:12 <Mook_as> and some people will claim it isn't supposed to work there (the window manager should know best)
23:07:19 <flo> I was thinking you could probably persist the position in other values, and restore that position "by hand" onload
23:07:57 <flo> Mook_as: should we care about how pissed of these people will be? :)
23:08:19 <flo> they are Linux users not using either Gnome or KDE, right?
23:08:25 --> mmkmou has joined #instantbird
23:08:34 <aleth> flo: Yes, it's a nice idea. I hadn't considered fixing persisting across restarts (less urgent as my window manager actually handles that, but this is KDE specific)
23:08:38 <flo> and not using a tiling window manager either
23:08:49 <aleth> There are so many window managers...
23:09:05 <flo> one per crazy user? :)
23:09:20 <aleth> That could be a lower bound ;)
23:10:54 <flo> still, there are probably less Linux window manager than Windows viruses ;)
23:11:39 <Mook_as> flo: no, because they're used to broken behaviour :p
23:13:04 <aleth> I dunno, the more obscure window managers tend to be pretty individualistic... you're not going to choose the hassle of getting them to run unless you really want it
23:13:39 <Mook_as> and some of the crazier WMs support scripting anyway, so they can write their way out :p
23:13:47 <-- micahg has quit (Ping timeout)
23:13:58 <-- mmkmou has quit (Ping timeout)
23:14:10 <flo> aleth: unless you wrote it yourself :)
23:15:16 <flo> Good night :)
23:15:17 <-- flo has quit (Quit: Instantbird 1.2a1pre)
23:16:10 --> Even3 has joined #instantbird
23:16:22 --> Tomek1 has joined #instantbird
23:17:09 <-- chrisccoulson has quit (sand.mozilla.org gravel.mozilla.org)
23:17:09 <-- aleth has quit (sand.mozilla.org gravel.mozilla.org)
23:17:09 <-- devfil has quit (sand.mozilla.org gravel.mozilla.org)
23:17:09 <-- Tomek has quit (sand.mozilla.org gravel.mozilla.org)
23:17:09 <-- gerard-majax has quit (sand.mozilla.org gravel.mozilla.org)
23:17:09 <-- Even2 has quit (sand.mozilla.org gravel.mozilla.org)
23:17:09 <-- Tonnes has quit (sand.mozilla.org gravel.mozilla.org)
23:17:09 <-- Even has quit (sand.mozilla.org gravel.mozilla.org)
23:19:10 --> Even has joined #instantbird
23:19:10 * ChanServ sets mode +o Even 
23:19:15 --> aleth has joined #instantbird
23:19:15 * ChanServ sets mode +h aleth 
23:19:41 --> Tonnes has joined #instantbird
23:20:04 --> mmkmou has joined #instantbird
23:21:18 --> devfil has joined #instantbird
23:22:04 <-- Tomek1 has quit (Quit: Instantbird 1.1)
23:22:23 <-- mmkmou has quit (Ping timeout)
23:22:59 --> chrisccoulson has joined #instantbird
23:23:24 --> gerard-majax has joined #instantbird
23:25:43 --> mmkmou has joined #instantbird
23:29:41 --> micahg has joined #instantbird
23:41:33 <instant-buildbot> build #207 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/207
23:44:19 <-- micahg has quit (Ping timeout)
23:53:50 <aleth> flo: Sorry for a mistaken reply earlier. It's amazing how quickly you forget why you did your own code a particular way. I'll post better responses in the bugs tomorrow.