#instantbird log on 02 01 2012

All times are UTC.

00:00:20 <-- EionRobb has quit (Connection reset by peer)
00:00:48 --> EionRobb has joined #instantbird
00:02:58 <clokep> Which exists for Windows.
00:09:32 <-- Tomek has quit (Quit: Instantbird 1.1)
00:11:59 <-- clokep has left #instantbird (Instantbird!)
00:12:14 --> clokep has joined #instantbird
00:12:14 * ChanServ sets mode +o clokep 
00:13:11 <flo> congrats :)
00:14:11 <clokep> Woo!
00:25:25 <-- Tonnes has quit (Ping timeout)
00:28:47 --> Tonnes has joined #instantbird
00:56:53 <-- Tobin has quit (Quit: And the rain will kill us all / If we throw ourselves against the wall / But no one else can see / The preservation of the martyr in me)
01:06:44 <-- Mook_as has quit (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner])
01:14:48 <-- flo has quit (Quit: Instantbird 1.2a1pre)
01:26:40 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
01:29:04 --> Tobin has joined #instantbird
02:15:23 <-- Even2 has quit (Quit: Instantbird 1.2a1pre)
02:25:37 <clokep> Hmmm...I still have a bunch of broken things. :-/
02:25:44 <clokep> But I've fixed a bunch. :)
03:13:11 <-- Tonnes has quit (Ping timeout)
03:13:14 <instant-buildbot> build #383 of linux-nightly-default is complete: Failure [failed hg_1]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/383
03:15:17 --> Tonnes has joined #instantbird
03:21:20 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
04:33:39 <-- timA has quit (Quit: Instantbird 1.2a1pre)
04:45:15 <-- Even has quit (Ping timeout)
04:45:52 --> Even has joined #instantbird
04:45:52 * ChanServ sets mode +o Even 
05:05:27 <instant-buildbot> build #468 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/468
05:05:48 <-- EionRobb has quit (Quit: Leaving.)
05:24:49 <-- wesj has quit (Quit: Instantbird 1.2a1pre)
05:30:16 --> eson57 has joined #instantbird
05:31:19 <eson57> Good morning guys!  :)
05:33:08 <eson57> How come my Options/Privacy tab is blanc when I use Swedish language?
05:34:17 <eson57> Cant find any updates in repository
05:41:02 <eson57> http://log.bezut.info/
05:41:41 <eson57> ooops... sorry  :)
05:46:59 --> Mook has joined #instantbird
06:13:12 <-- Tonnes has quit (Ping timeout)
06:14:40 --> Tonnes has joined #instantbird
06:45:46 <-- Tonnes has quit (Ping timeout)
06:47:12 --> Tonnes has joined #instantbird
06:52:40 <instant-buildbot> build #374 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/374
07:09:42 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603])
07:50:37 <-- gerard-majax has quit (Ping timeout)
07:54:36 <-- Even has quit (Quit: Instantbird 1.2a1pre)
07:54:54 --> Even has joined #instantbird
07:54:54 * ChanServ sets mode +o Even 
07:55:12 <-- Even has quit (Quit: Instantbird 1.2a1pre)
07:56:17 --> Mad_Maks has joined #instantbird
08:08:50 <-- Tonnes has quit (Ping timeout)
08:11:15 --> Tonnes has joined #instantbird
08:24:11 --> MadWookiee has joined #instantbird
08:49:53 <-- Tonnes has quit (Ping timeout)
08:51:54 --> Tonnes has joined #instantbird
08:56:39 --> gerard-majax has joined #instantbird
09:13:37 --> Even has joined #instantbird
09:13:37 * ChanServ sets mode +o Even 
09:13:52 <-- Even has quit (Quit: Instantbird 1.2a1pre)
09:14:02 --> Even has joined #instantbird
09:14:02 * ChanServ sets mode +o Even 
09:26:55 --> Mic has joined #instantbird
09:26:55 * ChanServ sets mode +h Mic 
09:27:12 <Mic> Hi
09:27:54 <Mic> eson57: this options tab was changed recently to include a section about passwords stored with the password manager.
09:28:26 <Mic> If you're language package doesn't include the new labels yet, it will break
09:28:52 <Mic> I'm assuming here that you're using nightly builds of Instantbird.
09:30:27 <Mic> ohh .. you're the translator for the swedish locale. I didn't remember that. Well, so: there's new strings on this tab :)
09:31:19 <eson57> Hi Mic
09:31:36 <-- Mad_Maks has quit (Quit: Instantbird 1.2a1pre)
09:32:21 <Mic> Hej
09:32:45 <eson57> Swedish?
09:33:19 <Mic> No, but I studied a year at a swedish university :)
09:33:30 <eson57> I understand there is new strings, but why dont I get any updates?
09:33:35 <eson57> ahaa
09:34:57 <Mic> I think the file security.dtd was also renamed to privacy.dtd
09:35:21 <eson57> TortoiseHG says "no changes found" when I try to sync
09:35:23 <Mic> http://hg.instantbird.org/instantbird/diff/6dbe0da3ffc4/instantbird/locales/en-US/chrome/instantbird/preferences/privacy.dtd
09:35:24 <Mic> http://hg.instantbird.org/instantbird/diff/6dbe0da3ffc4/instantbird/locales/en-US/chrome/instantbird/preferences/security.dtd
09:36:14 <Mic> hmm
09:36:53 <Mic> No idea about TortoiseHG but maybe you can still try from the command line? You're familiar with that?
09:37:56 <eson57> I know how to use the command line... but not in this specific matter
09:40:21 <Mic> Go to the folder and try "hg pull" and then "hg update"
09:40:37 <Mic> Assuming you have no local changes, this should work fine
09:41:47 <Mic> I can't tell how TortoiseHG will react though? :S
09:42:54 --> mmkmou has joined #instantbird
09:44:28 <eson57> pulling from https://hg.instantbird.org/l10n/sv-SE/
09:44:28 <eson57> searching for changes
09:44:28 <eson57> no changes found
09:45:20 <eson57> same when pulling from en-US
09:46:16 <Mic> Sorry, I think you'll need to wait for someone else.. :(
09:46:59 <eson57> ok... I will mount files in my editor and compare once more... just to make sure
09:56:25 <-- mmkmou has quit (Ping timeout)
10:01:42 --> Tomek has joined #instantbird
10:05:23 --> flo has joined #instantbird
10:05:24 * ChanServ sets mode +qo flo flo 
10:06:23 <flo> hello :)
10:07:42 <flo> eson57: if you haven't pushed anything, it shouldn't be a surprise that there's nothing new in the sv-SE repository
10:08:13 <flo> the script updating the en-US repository automatically is currently broken, so the new strings don't appear there
10:13:41 --> mmkmou has joined #instantbird
10:14:04 <eson57> flo: ok... so what can I do? Just wait?
10:14:56 <flo> Mic gave you this link where you can see what has changed in the English file: http://hg.instantbird.org/instantbird/diff/6dbe0da3ffc4/instantbird/locales/en-US/chrome/instantbird/preferences/privacy.dtd
10:15:41 <eson57> ok, thanks
10:19:25 <-- Tonnes has quit (Ping timeout)
10:22:29 --> Tonnes has joined #instantbird
10:37:23 --> jb has joined #instantbird
10:38:58 <-- eson57 has quit (Quit: Instantbird 1.2a1pre)
11:11:17 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
11:14:46 --> clokep has joined #instantbird
11:14:46 * ChanServ sets mode +o clokep 
11:15:20 <flo> clokep: hello :)
11:15:58 <flo> I added a dump before the nsIScriptableUnicodeConverter.ConvertToUnicode call to see which imput causes an error. It seems to be when there's a non ascii character in the strings :(.
11:16:23 <flo> I have the error with
11:16:23 <flo> rawMessage = :lindbohm.freenode.net 372 testib :- Dénis Lindbohm (1927-2005) was a Swedish author and one of the 
11:17:11 <clokep> Oh?
11:17:25 <clokep> Bah, I hate character sets.
11:17:57 --> eson57 has joined #instantbird
11:18:08 <flo> I generally dislike them too. Even more when I need to handle them in JS and things are magically converted without us knowing anything about them :)
11:18:27 <flo> but I'm wondering if we shouldn't bypass the unicode converter completely for UTF-8
11:18:41 <flo> I don't see how converting from UTF-8 to UTF-8 could be a useful operation
11:21:19 <eson57> I fixed the Swedish translation... but didn´t recieve a new xpi, like I chould
11:21:24 <clokep> I had that same thought a few minutes ago. :)
11:22:14 <flo> Even, what's up with http://buildbot-l10n.instantbird.org/waterfall ? :-(
11:24:07 <flo> eson57: I suspect the feedback email would complain about the "    22 " here https://hg.instantbird.org/l10n/sv-SE/rev/3d7ac0a1a76a#l1.24
11:26:01 <eson57> ok... sorry. I´l give it another try.
11:31:00 <-- Tonnes has quit (Ping timeout)
11:31:29 <flo> clokep: are you intending to attach a new patch soon, or should I continue looking at the existing one?
11:32:20 <-- Even1 has quit (Ping timeout)
11:32:20 --> Tonnes has joined #instantbird
11:34:27 <clokep> flo: I didn't get too far last night and I"ll be going to work soon...
11:34:33 <clokep> The changes I made last night:  - Moved the icons instead of removing + adding them.
11:34:34 <clokep>  - Fixed the naming of ircCTCP.jsm
11:34:36 <clokep>  - Added the missing test file.
11:34:36 <clokep>  - Added the passwordOptional flag.
11:34:36 <clokep>  - A few instances of purple --> prpl.
11:34:36 <clokep>  - Fixed MODE message.
11:35:11 <flo> ok
11:35:32 <clokep> I was trying to track down the broken topic message yesterday....but couldn't. :(
11:35:39 <clokep> I feel ike part of my l10n stuff might be messed up.
11:37:06 <clokep> But it's more likely my new formatting functions.
11:38:01 <flo> broken = not displayed, or is there something else more broken?
11:38:58 <clokep> The topic is displayed, but not the message htat it was set.
11:39:09 <clokep> (Which should probably be done by Instantbird and not by the protocol btw.)
11:39:58 --> Even1 has joined #instantbird
11:43:51 <flo> Error: aTag is undefined Source File: resource:///modules/ircUtils.jsm Line: 66
11:44:22 <clokep> Yeah, I'm not sure how that's possible though.
11:44:27 <clokep> Need to test it more.
11:44:31 <clokep> But I have to get ready for work.
11:44:37 <clokep> Would you like my new patch so far?
11:45:07 <flo> yes :)
11:45:44 <flo> I'll at least look at the interdiff, so that I don't comment on things that are already fixed :)
11:46:47 <flo> Error: this._modes is undefined Source File: components/irc.js Line: 229 <-- seems like a typo. You have a _mode: [], default value in the prototype, but use _mode*s*
11:47:27 <flo> hmm, there's a mix of _mode and _modes used actually
11:47:29 <clokep> I fixed that already.
11:47:32 <clokep> Oh.
11:47:38 <clokep> Well I fixed the definition to be modes.
11:48:08 <flo> I don't think you need it in the prototype by the way, as you create a new array for it in the constructor
11:48:37 <clokep> Yeah, but don't we like to have it there so you can delete this.modes and it'll reset?
11:48:54 <flo> that won't work
11:49:06 <flo> you don't want a shared array between all the participant instances
11:50:03 <flo> + you never seem to delete it :)
11:52:18 <clokep> Yes, I do never delete it. :P
11:53:30 <instantbot> clokep@gmail.com cancelled review? for attachment 1145 on bug 507.
11:53:31 <instantbot> clokep@gmail.com requested review from the wind for attachment 1147 on bug 507.
11:53:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=507 enh, --, ---, clokep, ASSI, Implement IRC in JavaScript
11:54:22 <clokep> I don't have an interdiff because I fixed the way the patch was made to not include garbage. :(
11:54:43 <flo> which unrelated changes have you excluded exactly? :-P
11:55:17 <clokep> I ran clokep@CLOKEP-X201 ~/instantbird-irc$ hg diff -X *xmpp* -X *twitter* -X *instantbird\content* -X .hgignore > bug507.diff
11:55:22 <flo> (but don't be late because of me keeping asking questions ;))
11:56:11 <flo> clokep: it seems that didn't work too well ;)
11:56:31 <clokep> :( Possibly not.
11:56:39 <clokep> I checked for twitter though!
11:56:53 <flo> https://bugzilla.instantbird.org/attachment.cgi?id=1147&action=diff#a/chat/protocols/twitter/twitter.js_sec1
11:56:55 <clokep> Gah I must have the syntax wrong.
11:57:03 <clokep> Yeah, yeah. Sorry again. :-/
11:57:07 <flo> don't worry :)
11:57:21 <clokep> I'll be back in an hour.
11:57:30 <clokep> Feel free to just spitball questions.
11:57:39 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
11:58:22 <eson57> fixed the incorrect string, but still no xpi   :(
11:58:38 <flo> eson57: buildbot doesn't work correctly
11:58:57 <flo> Even, Even1: do you know why the l10n buildbot doesn't seem to even try to do something?
11:59:00 <eson57> ok
12:42:48 --> aleth has joined #instantbird
12:56:21 --> clokep_work has joined #instantbird
12:56:21 * ChanServ sets mode +o clokep_work 
13:28:30 <clokep_work> aleth: Is your nick registered & do you identify every time / kick if you're not identified?
13:57:00 <flo> the problem with the quit messages was trivial
13:58:16 <clokep_work> What was it?
13:58:46 <flo> it was just that the aMessage.nickname parameter was missing :).
13:58:58 <clokep_work> Ah-ha.
13:59:12 <clokep_work> It was supposed to be aMessage.params[0]?
13:59:24 <flo> that's the second parameter, isn't it?
13:59:56 <flo> you want %1 has left the room (Quit: %2) (I'm simplifying here, it's more complicated to get the ": " right)
14:00:14 <clokep_work> Yes.
14:00:53 <clokep_work> Well IRC strings are ":<source> <command> <param 1>[ <param 2>]*[ :<param n>]
14:01:21 <flo> I just copied what the part message does ;)
14:01:34 <clokep_work> Haha. :)
14:01:52 <flo> do you expect to display a topic changed message when joining a room?
14:02:03 <clokep_work> Yes, that's broken.
14:02:10 <clokep_work> What I was talking about this morning.
14:02:17 <flo> ok, I'll debug that soon then :)
14:02:26 <clokep_work> It's where those error statements were. ;)
14:02:31 <clokep_work> Response 332 and 333.
14:02:38 <flo> but maybe I should start by fixing all those errors I have in my console
14:02:46 <flo> the _mode warning saved me a lot of time :)
14:04:11 <flo> Error: Unhandled IRC message: :adams.freenode.net 333 testib #test LuX 1264585024 Source File: components/irc.js Line: 307 <- isn't that a regular message?
14:04:50 <flo> there's something broken in the encoding :-/
14:05:17 <flo> when I send "héhé" from JS-IRC, my libpurple irc receives "héhé", but when I send "héhé" from libpurple, I receive "héhé" in JS-IRC
14:05:29 <flo> (that's UTF8 encoded in UTF8)
14:06:09 <clokep_work> :(
14:06:19 <clokep_work> I was quite confused when writing the encoding stuff.
14:06:29 <clokep_work> What do you mean "isn't that a regular message"?
14:06:48 <flo> what does ":adams.freenode.net 333 testib #test LuX 1264585024" mean? It doesn't seem like a topic
14:07:02 <clokep_work> It's the time the topic was changed.
14:07:05 <clokep_work> 332 is the actual topic.
14:07:10 <flo> oh, ok! :)
14:07:27 <clokep_work> It's 333 <who you are> <what channel> <who last changed the topic> <when they last changed it>
14:07:35 <flo> does the rfc specifies in which timezone these timestamps are?
14:07:47 <clokep_work> Surely you jest.
14:08:02 <clokep_work> 333 is actually not in the RFC.
14:08:05 <clokep_work> It's non-standard.
14:08:14 <clokep_work> (Pretty sure I have a comment in there for that. ;))
14:08:32 <flo> are IRC and encodings in the same category of awesome things? ;)
14:08:40 <clokep_work> Yes. :)
14:08:41 <flo> for now I'm looking at my error console
14:08:49 <clokep_work> But at least I understand IRC. :(
14:09:22 <flo> :)
14:09:33 <flo> I think I also dislike socket erros :)
14:09:40 <flo> *errors
14:09:47 <flo> what's your plan for the server tab?
14:10:12 <flo> when I started typing a review comment in the bug this morning, I had this in the textbox: "- The messages displayed in the "server tab" with the "notification" flag but not "system" look broken. But do we need that server tab at all? Or maybe there should be an advanced account setting to enable it? (or an about config pref to globally enable it for all IRC accounts at once)"
14:10:41 <clokep_work> I don't know. I don't dislike showing the MotD, but no one ever changes it. :P
14:11:23 <flo> isn't it usually a large amount of nonsense?
14:11:40 <-- jb has quit (Quit: Instantbird 1.2a1pre)
14:14:18 <clokep_work> Yes. :)
14:14:26 <clokep_work> So I'd probably make it an option to show it or not for each account.
14:14:39 <clokep_work> Can that be handled as a follow up?
14:15:06 <flo> as long as the default behavior is not showing crap, adding a way to show it can be a follow up, yes
14:16:44 --> jb has joined #instantbird
14:18:38 <clokep_work> I meant can I handle the entire thing in a followup. :)
14:19:22 <flo> I don't think it would take you more than 10 minutes to turn off that noisy server tab ;)
14:20:45 <clokep_work> Alright.
14:20:49 <clokep_work> Just make a comment about it somwhere.
14:20:58 <flo> sure
14:21:10 <flo> I'm trying to fix the broken things for now :)
14:21:19 <flo> and it's a pretty good way to familiarize myself with the code
14:21:32 <flo> it's less boring that reading from line 1 to the end of each file
14:22:44 --> Draighth has joined #instantbird
14:23:39 <clokep_work> Yeah, I planned it that way to give you something to do. ;)
14:23:56 <flo> that's so nice of you ;)
14:27:15 <flo> CTCP_TAGS_EXP matches the | character
14:28:53 <clokep_work> Ah, is that what's breaking it? :(
14:29:00 <flo> yeah
14:29:16 <flo> dump("CTCP_TAGS_EXP = " + CTCP_TAGS_EXP.toSource() + "\n");
14:29:17 <flo> prints: CTCP_TAGS_EXP = /[||||]/
14:29:41 <flo> are the special characters you want to match non printable?
14:30:00 <clokep_work> Yes.
14:30:26 <flo> shouldn't .toSource convert them to \x<whatever> still? :-S
14:30:27 <clokep_work> flo: const CTCP_TAGS_STRING = "[" + Object.keys(CTCP_TAGS).join("|") + "]"; is wrong.
14:30:51 <clokep_work> It should either be "(" + Object.keys(CTCP_TAGS).join("|") + ")" or "[" + Object.keys(CTCP_TAGS).join("") + "]";
14:30:55 <clokep_work> I'm not sure which one.
14:31:19 <flo> I'll try the second one
14:31:28 <clokep_work> Yeah, I think that's the one it should be.
14:32:37 <flo> removing that | is enough to make the topic message appear
14:32:46 <flo> I'm not sure the regexp works though
14:32:55 <flo> any idea of how I can test that this code works?
14:33:07 <flo> or is this what your unittest is for? :)
14:33:23 <clokep_work> flo: I have unit tests for that. :P
14:33:40 <flo> hmm, did they pass? :-P
14:34:02 <clokep_work> Yes, but none of them tested for a string with | in it.
14:34:09 <flo> ok :)
14:34:16 <clokep_work> Feel free to add one...;)
14:34:45 <flo> there's no good reason for that character to break again in the future
14:35:07 <flo> so if we want to make the test more robust, we should probably add a test for all special characters commonly used in JS
14:35:47 <clokep_work> Yeah...or just take nonsensical strings of characters.
14:35:56 <clokep_work> I have little background in unit testing btw.
14:36:39 <flo> you won't be blamed for trying ;)
14:37:00 <flo> tests that test something even though not all the cases are already so much better than no tests at all :)
14:37:28 <clokep_work> :) That was my thinking too!
14:37:42 <clokep_work> (Btw the tests in there are the examples from any documentation that exists + variations...)
14:37:53 <clokep_work> Or just things I made up to test certain situations I saw.
14:41:32 <flo> we should turn on xpcshell tests on our buildbot slaves
14:42:18 <-- eson57 has left #instantbird ()
14:43:49 <flo> 15:43:41 - testib [~testib@2a01:e35:2e9b:c420:223:6cff:fe84:a95e] entered the room.
14:44:02 <flo> it seems I'm connecting to freenode through IPv6
14:45:08 <flo> by the way, what's the value between ~and @? Could we put brandshortname there to "compete" with ChatZilla, Miranda and Adium? ;)
14:46:00 * clokep_work sees both a ~ and @ in that line.
14:46:03 <clokep_work> I'm not sure what you're asking. :P
14:46:47 <flo> <nickname> [~<some string>@<IP address/hostname] entered the room
14:46:51 <flo> what's "some string" here?
14:47:25 <clokep_work> That's their user name.
14:47:59 <flo> where is that set? my session on the OS is certainly not testib ;)
14:48:12 <clokep_work> It's set in the advanced prefs.
14:48:30 <clokep_work> It doesn't automatically use the user's username from the OS, although that was the idea behind it.
14:50:01 <flo> it's empty for me in the advanced prefs
14:50:14 <flo> could we set "instantbird" (brandshortname) as the default value?
14:50:16 <clokep_work> If it's empty, we resend the nick. ;)
14:50:18 <clokep_work> No.
14:50:21 <clokep_work> It has to be set by the user.
14:50:42 <flo> so why are all other clients displaying their name there?
14:51:13 <flo> (except Pidgin)
14:51:19 <clokep_work> I've never seen that.
14:51:23 <clokep_work> Let me re-read the spec.
14:51:32 <clokep_work> I think it explicitly says that it's supposed to be set bt the user.
14:51:35 <flo> at least ChatZilla, Mibbit, Adium and Miranda do it
14:51:42 <clokep_work> But if not, then we can set it to brandshortname.
14:51:55 <flo> well, the user has set it by selecting his client ;)
14:52:23 <flo> + it would be nice to know when people enter that they are (likely) using Instantbird
14:52:39 <flo> currently we know it when they quit, it's a bit late to tell them something about it :)
14:53:22 <clokep_work> You could CTCP version them all when they join like Silver does in #chatzilla. ;)
14:53:44 <flo> ...
14:53:54 <flo> that defeats the marketing value
14:55:56 <clokep_work> I know. :)
14:56:06 <clokep_work> OK, so I can't find that information anywhere..so I might be crazy.
14:56:33 <flo> you attempted to find something in these specs, so you probably are :-P
14:57:11 <-- mmkmou has quit (Ping timeout)
14:57:20 <clokep_work> Yes. :)
14:57:27 <clokep_work> What IRC thinks of character sets btw: http://tools.ietf.org/html/rfc2812#section-2.2
14:59:20 <flo> the part about IRC's Scandinavian origin looks so much like an April fools joke :(
15:00:45 <flo> the problem with 333 messages is that you do conversation.setTopic(null, aMessage.params[2]);
15:01:01 <flo> so   setTopic: function(aTopic, aTopicSetter) { (in irc.js) is called with aTopic == null
15:01:09 <flo> and at the next line you do ctcpFormatToText(aTopic)
15:01:19 <flo> ctcpFormatToText expects a string, not null
15:04:04 <flo> can we just put the ctcpFormatToText call in ircBase.jsm in the 332 handler, and remove the custom setTopic method of the ircChannel prototype?
15:18:10 --> testib has joined #instantbird
15:18:46 <flo> do we really want that line? "16:18:10 - The topic for #instantbird was set by clokep_work at Thu Jan 05 2012 15:56:28 GMT+0100 (CET)."
15:18:52 <testib> hello :)
15:21:43 --> mmkmou has joined #instantbird
15:23:53 <-- testib has left #instantbird ()
15:24:23 <flo> uh, left the room? I Command+Q'ed, that should display Quit I think
15:26:22 --> testib has joined #instantbird
15:26:37 <-- testib has quit (Quit: Instantbird <http://www.instantbird.org>)
15:27:10 --> Mic has joined #instantbird
15:27:10 * ChanServ sets mode +h Mic 
15:28:29 <flo> clokep_work: if I disconnect my account and then reconnect it, the channel icon changes back to normal like if the channel had been re-joined automatically. But it hasn't, and if I try to send a message I receive Error: Unhandled IRC message: :gravel.mozilla.org 404 testib #instantbird :No external channel messages (#instantbird)
15:34:21 --> igorko has joined #instantbird
15:40:56 <clokep_work> flo: Alright. I'll need to test that.
15:41:21 <clokep_work> flo: I don't know if that's the only place that setTopic gets called from.
15:41:26 <clokep_work> Which is why I overrode the handler.
15:41:38 <clokep_work> (And I don't know if we really want the line about when it was set, but it's useful sometimes."
15:41:51 <flo> there are only 2 calls, one from 332 and one from 333
15:42:51 <flo> I don't understand the c.usageContext undefined warning
15:42:52 <clokep_work> Alright.
15:43:05 <clokep_work> I looked into it briefly yesterday, couldn't find how that's possible. :-/
15:43:24 <flo> I suspect it's somehow related to xpconnect wrappers
15:44:02 <clokep_work> Ah, maybe.
15:44:09 <flo> if I add a dump to print the name before each command is filtered, it prints: omponents/imCommands.js, line 205: reference to undefined property c.name, but then it prints the correct name... :(
15:46:21 <clokep_work> Bah. :(
15:47:03 <clokep_work> And yes, that stuff about the scandanavian casing sounds like a joke. :P That's "corrected" via ISUPPORT though.
15:54:55 <instantbot> New purplexpcom - General bug 1254 filed by benediktp@ymail.com.
15:55:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1254 enh, --, ---, nobody, NEW, Facebook Chat: add support for 'mobile' flag/status
15:56:13 --> myk has joined #instantbird
15:56:22 <clokep_work> Mic: We're not given that information I believe.
15:56:54 <flo> I think mobile users are not shown as online
15:58:42 * jwir3|away is now known as jwir3
15:58:46 <flo> clokep_work: if I disconnect an account and then click "connect", I fails with a "Lost connection with server" error message
15:59:52 <flo> hmm, I see that only with freenode, not moznet
16:01:25 <flo> *it fails
16:04:47 <-- myk has quit (Ping timeout)
16:05:40 <clokep_work> :-/
16:07:05 <flo> hmm, it seems the usage of the unicode converter for UTF8 to UTF8 was right, and removes the double UTF8 encoding I complained about earlier
16:07:39 <flo> aaah, so the failure I had on the freenode MOTD was because the freenode server don't use UTF8 by default!
16:07:44 --> myk has joined #instantbird
16:09:49 <instantbot> New Instantbird (UI) bug 1255 filed by benediktp@ymail.com.
16:09:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1255 nor, --, ---, nobody, NEW, Wrong account status message shown after disconnecting account whose password was removed
16:13:48 <clokep_work> Bah. I wonder what it uses then.
16:15:20 <flo> most likely iso8859-1 :-S
16:15:36 <flo> but the MOTD seems to be random, and not always include non-ascii characters (that would be too easy)
16:16:30 <clokep_work> Are you always getting the same server?
16:16:36 <clokep_work> Each one will have a different MOTD, etc.
16:16:37 <flo> no
16:17:51 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
16:20:07 <clokep_work> It must be nice that the XMPP specs just define the protocol as UTF-8. :P
16:20:31 <flo> do we have a way to detect the encoding of a string?
16:22:50 <clokep_work> No, Mook linked us to his songbird code.
16:22:56 <flo> pff, this isn't scriptable http://mxr.mozilla.org/comm-central/source/mozilla/intl/chardet/public/nsICharsetDetector.h#52 :(
16:23:03 <flo> have you kept the link? :)
16:23:29 <clokep_work> flo: Ye.s..somewhere...
16:23:30 <clokep_work> Give me a minute.
16:24:49 <clokep_work> flo: http://log.bezut.info/instantbird/120104/#m253
16:30:17 <flo> that code makes me sad (mostly because I don't have any really better idea :()
16:30:42 <clokep_work> It'd be nice if all that charset detector code was scriptable (complete?)
16:30:55 <flo> right
16:31:02 <flo> it would also be nice if it was reliable ;)
16:32:19 <flo> I wonder if we can come up with something that "mostly work", like "try UTF8, if it's not utf8, try iso-8859-1, if it's not that, just replace all the non ascii characters with '?'"
16:32:40 <flo> (iso-8859-1 in this context could be localized to be set to the likely non-UTF8 encoding for the UI's locale)
16:32:54 <clokep_work> Right.
16:33:09 <clokep_work> How gross is the way Mook was doing it? :-/
16:33:14 <flo> for French text it's almost sure that anything that isn't UTF8 is iso-8859-1, but that assumption wouldn't be right for other areas
16:33:20 <flo> clokep_work: not scriptable.
16:33:54 <clokep_work> Right.
16:41:10 <flo> the changes I currently have: http://pastebin.instantbird.com/11121
16:41:16 <flo> I'll be offline for a few hours
16:41:18 <-- flo has quit (Quit: Instantbird 1.2a1pre)
16:43:06 --> Plop has joined #instantbird
16:43:40 <clokep_work> flo: Why the change to line 186?
16:44:39 <-- myk has quit (Quit: Instantbird 1.1)
16:44:46 --> myk has joined #instantbird
16:47:00 <clokep_work> Besides that everything else looks good. Thanks! :)
16:55:23 <-- myk has quit (Connection reset by peer)
16:57:21 <-- Draighth has quit (Connection reset by peer)
16:58:04 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre)
17:04:55 --> myk has joined #instantbird
17:14:42 <-- Even has quit (Quit: Instantbird 1.2a1pre)
17:19:04 --> wesj has joined #instantbird
17:21:45 <-- myk has quit (Ping timeout)
17:26:42 <-- Even1 has quit (Quit: Instantbird 1.2a1pre)
17:26:46 --> Even has joined #instantbird
17:26:46 * ChanServ sets mode +o Even 
17:32:29 --> Draighth has joined #instantbird
17:44:10 --> myk has joined #instantbird
17:47:15 <-- gerard-majax has quit (Ping timeout)
17:57:04 --> Mook_as has joined #instantbird
18:04:36 <-- myk has quit (Ping timeout)
18:23:01 <-- MadWookiee has quit (Quit: Instantbird 1.1)
18:26:13 * jwir3 is now known as jwir3|lunch
18:37:36 --> Mnyromyr has joined #instantbird
19:00:36 --> myk has joined #instantbird
19:12:00 --> timA has joined #instantbird
19:24:04 <-- igorko has quit (Ping timeout)
19:24:21 --> igorko has joined #instantbird
19:30:01 <aleth> clokep_work: My nick is registered, libpurple does whatever it does on login, and NickServKiller kills any messages. Why do you ask?
19:32:29 <clokep_work> aleth: Just curious. ;)
19:32:50 <Mook_as> man, JS is weird sometimes. for ([k, {foo: f, bar: b}] in Iterator(data = [{foo: 1, bar: 2}, {foo: 3, bar:4}])) print(k + " / " + f + " / " + b); is a valid statement.
19:33:08 <aleth> Can't remember why I registered it actually
19:33:36 <clokep_work> Mook_as: That's really intense.
19:34:00 <aleth> For memoserv maybe
19:34:49 <aleth> Mook_as: Is there an obfuscated JS contest yet?
19:35:22 <clokep_work> Apparently Gecko 12 will support a Map and a Set JS objects.
19:36:26 <Mook_as> unless it gets disabled before release (because the spec isn't finalized yet).
19:37:50 <aleth> ''{ is lowercase ['?! someone give clokep a medal for working with that spec :D
19:39:59 <Mook_as> looks about right, 0x5b + 0x20 = 0x7b
19:40:32 <Mook_as> so ^ is upper case ~, and fun things like that?
19:40:52 <Mook_as> (and, err, ! may be upper case A :p )
19:41:16 <aleth> Upper^2 case a :P
19:41:37 <clokep_work> aleth: Yes. :-/
19:41:49 <clokep_work> The fun part comes if you look at ISUPPORT and the server then gets to tell you if they do that or not.
19:41:57 <clokep_work> (Or if they just do standard ASCII upper/lower case)
19:42:03 <clokep_work> Or if they do some other crazy one I forget.
19:51:25 --> ecaron has joined #instantbird
19:51:30 <clokep_work> (And yes, I support that at line 106 of https://bugzilla.instantbird.org/attachment.cgi?id=1147&action=diff#a/chat/protocols/irc/ircISUPPORT.jsm_sec1 ;))
19:53:26 <Mook_as> I think calling String.toLowerCase() is wrong if you want to support only ASCII
19:53:37 <Mook_as> (dealing with characters with accents are... interesting)
19:55:27 <aleth> Mook_as: I thought that was toLocaleLowerCase?
19:56:08 <Mook_as> "Å".toLowerCase() ?
19:59:33 <clokep_work> What's the answer? :P
20:00:05 <Mook_as> I am naively thinking that, per the comments, it should remain uppercase A-with-a-circle-thinger?
20:00:22 <clokep_work> I would think so per the comments as well.
20:00:33 <clokep_work> Which it doesn't...
20:00:41 <clokep_work> I'll need to re-read the spec though. :P
20:01:28 <Mook_as> right, JS toLowerCase does the Right Thing
20:01:40 <Mook_as> (where as the comments ask for the Wrong Thing)
20:01:46 <clokep_work> Yes. :(
20:01:50 <clokep_work> You know of an easy way to do that?
20:02:07 <clokep_work> (i.e. the "wrong" thing :P)
20:02:11 --> flo has joined #instantbird
20:02:11 * ChanServ sets mode +qo flo flo 
20:03:22 <Mook_as> str.split("").map(function(c)c.charCodeAt(0)).map(function(n) n >= 97 && n <= 122 ? n - 0x20 : n).map(function(n)String.fromCharCode(n)).join("")?
20:03:39 <Mook_as> (you may want to use more lines and stuff, of course)
20:06:03 <clokep_work> Yeah, that was the one I was hoping to avoid...but I think it's the only way.
20:06:27 <clokep_work> (Although doing it that way...it's easy to do the other methods. :)
20:06:42 <clokep_work> Just make a function that returns different functions for start & stop values.
20:07:08 <Mook_as> I'd just have a local function that takes start/stop and returns the string directly, but okay? :)
20:07:55 <Mook_as> oh, I see, that currently returns a function (in this.normalize)
20:08:05 <flo> clokep_work: which line 186?
20:08:12 <clokep_work> flo: In your diff.
20:08:17 <clokep_work> You removed a semicolon.
20:08:30 <clokep_work> But isn't it "good" in that case since it's a function without a block after it?
20:08:49 <clokep_work> Mook_as: Yeah, well either way works.
20:09:10 <flo> I read it like function() { return blahblah; };
20:09:22 <flo> semicolon go after instructions that are executed
20:11:32 <clokep_work> Alright.
20:13:18 <flo> pfff, I hit Command+Q instead of Command+R to reload a page
20:13:54 <flo> the Firefox UI disappeared and the application got frozen, and then disappeared after a few seconds during which I was wondering what happened / how I could cancel that
20:14:44 --> EionRobb has joined #instantbird
20:17:20 <clokep_work> :(
20:17:35 <clokep_work> I always found some short cuts to be very...poorly placed.
20:18:04 <flo> yeah, and where did that confirm prompt go? ;)
20:18:22 <flo> "Warn me when closing multiple tabs" is checked
20:18:47 <Mook_as> and it's hard to disable them. (I'd love to disable cmd+W in chatzilla...)
20:18:48 <flo> but I must admit session restore has worked very well! :)
20:19:02 <flo> Mook_as: maybe stop using chatzilla? ;)
20:19:12 <flo> I'd love to disable C-z in emacs
20:19:18 <Mook_as> flo: make ib good enough for my IRC use! :D
20:19:24 <flo> just between C-a and C-e, ideal for hitting it by mistake
20:19:29 <-- igorko has quit (Connection reset by peer)
20:19:37 <flo> Mook_as: if not, you know where to hack it ;)
20:19:42 <Mook_as> (almost there, I think - I need to go back and get unibrow working again, I think)
20:19:50 <Mook_as> flo: that's the problem - I'm too lazy! XD
20:20:20 <flo> what do you need unibrow for?
20:20:32 <flo> the contact list doesn't matter much for IRC, so you can just close that window I think
20:23:39 <Mook_as> hmm, I guess if there are other vertical-tabs-things it might work.
20:24:05 <clokep_work> Yes, Mook_as I mae a vertical tabs extension. :P
20:24:15 <flo> how many tabs do you need?
20:24:54 <Mook_as> I've got about... a dozen at the moment?
20:26:08 <-- Draighth has quit (Quit: Leaving.)
20:27:27 <-- jb has quit (Ping timeout)
20:29:47 <-- micahg has quit (Ping timeout)
20:32:36 * jwir3|lunch is now known as jwir3
20:45:48 --> micahg has joined #instantbird
20:51:33 <-- Plop has quit (Ping timeout)
20:53:42 --> Plop has joined #instantbird
20:55:25 <-- chrisccoulson has quit (No route to host)
20:58:25 --> chrisccoulson has joined #instantbird
20:59:08 <flo> the logic in http://mxr.mozilla.org/comm-central/source/mailnews/base/util/nsMsgUtils.cpp#2259 seems like something we may want to copy
21:03:41 <clokep_work> I don't suppose it can be made scriptable?
21:04:54 <flo> bah...
21:05:19 <flo> if we put it in a C++ component, we can make that component scriptable... :(
21:05:21 <instantbot> c++ sucks
21:11:03 <flo> http://log.bezut.info/instantbird/today#m457 is super complicated. Can't you just use something like http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#436 ?
21:17:13 --> jb has joined #instantbird
21:22:36 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:48:31 <Mook_as> oh, you're right, that works much better! "1234QWER!@#$qwer".replace(/[\x61-\x7a]/g, function(c)String.fromCharCode(c.charCodeAt(0) - 0x20));
21:52:37 <flo> I wonder if you are serious :-D
21:52:48 <flo> it's still awful :-D
22:12:11 <-- Tonnes has quit (Ping timeout)
22:13:48 --> Tonnes has joined #instantbird
22:20:37 <-- jb has quit (Quit: Instantbird 1.2a1pre)
22:36:25 --> gerard-majax has joined #instantbird
22:45:07 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:53:16 --> clokep has joined #instantbird
22:53:16 * ChanServ sets mode +o clokep 
23:01:04 <flo> instantbot no longer announces new attachments?
23:01:07 <instantbot> flo: Sorry, I've no idea what 'no longer announces new attachments' might be.
23:06:29 <flo> clokep: I hope my comments in the interdiff are helpful
23:06:41 <clokep> flo: They are. Thanks.
23:06:44 <clokep> Just got home so...
23:07:16 <flo> I'm wondering if we shouldn't get rid of the username account pref completely
23:07:23 <flo> (always use brandshortname)
23:07:33 <clokep> That's fine w/ me.
23:07:36 <flo> I've always been confused by libpurple's username and realname prefs
23:07:53 <clokep> Does that interdiff include the one posted to pastebin earlier?
23:08:01 <flo> yes
23:08:26 <flo> I'm creating it with this command: hg diff > irc-wip.patch && interdiff attachment.cgi\?id\=1147 irc-wip.patch > bug507-review-irc.js.patch
23:08:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=507 enh, --, ---, clokep, ASSI, Implement IRC in JavaScript
23:08:41 <flo> (but I've hand edited attachment 1147 to remove the irrelevant changes)
23:09:09 <clokep> Cool.
23:09:51 <-- Plop has quit (Ping timeout)
23:18:49 <clokep> :) And that patch applied cleany
23:19:18 <clokep> Wasn't expecting that!
23:31:02 <flo> are you used to my patches not applying? :-P
23:34:34 <clokep> No. :) You're must better at making patches then me. ;)
23:35:16 <-- Tonnes has quit (Ping timeout)
23:35:32 <flo> clokep: my secret is that I always look at the full diff in my terminal AND at hg diff --stat before showing it to anybody ;)
23:35:46 <flo> (and hg st before even creating a diff)
23:36:10 <clokep> Yeah, I guess I'm lazier. :-/
23:36:36 <flo> I suspect you have an horribly sucky terminal
23:36:59 <clokep> That's certainly a bit of it.
23:37:53 --> Tonnes has joined #instantbird
23:40:00 <clokep> flo: How would you like me to respond to this? Fix things and put up an interdiff or a full new patch or?
23:40:52 <flo> I don't really know
23:41:10 <flo> I guess a new full patch would be ok
23:41:25 <clokep> (I'll make sure it doesn't include Twitter & XMPP this time. :))
23:41:31 <flo> (have you finally figured out how to create an interdiff by the way?)
23:41:36 <clokep> I should learn how to use pbranches or mq. :-/
23:41:51 <clokep> How to create an interdiff? Well I probably could from the example you gave!
23:42:30 <flo> clokep: for these cases (twitter, xmpp, etc, ...) what I do is: hg diff chat/protocols/{twitter,xmpp} instantbird/content > ../WIP/<some name>.patch and then patch -p1 -R < ../WIP/<some name>.patch
23:42:56 <flo> if you don't have the command "interdiff" available, it'll be difficult ;)
23:43:12 <clokep> :( It's not available.
23:43:25 <Mook_as> post to patches on bugzilla and hope its interdiff works?
23:43:29 <Mook_as> s/to/two/
23:43:36 <flo> on linux it's typically in a packaged called diffutils or patchutils
23:43:39 <flo> Mook_as: it doesn't :(
23:43:43 <Mook_as> oh: the RE before: I can't tell if I'm serious either :(
23:43:55 <flo> and my attempt to get Even to fix it over the last 4 years haven't been very successful ;)
23:46:37 <-- ecaron has quit (Quit: Instantbird 1.1)
23:46:39 * aleth is reading https://developer.mozilla.org/en/Performance/Profiling_with_the_Built-in_Profiler
23:53:10 <-- EionRobb has quit (Ping timeout)
23:55:11 <flo> Good evening/night
23:55:12 <-- flo has quit (Quit: Instantbird 1.2a1pre)
23:59:06 --> EionRobb has joined #instantbird