#instantbird log on 01 25 2012

All times are UTC.

00:03:31 --> Tonnes has joined #instantbird
00:09:59 <-- ecaron has quit (Ping timeout)
00:14:06 <clokep> Mook_as: That actually took a youtube link and then embedded it, it wasn't allowing video tags through.
00:16:25 <Mook_as> clokep: right; some mac IRC client, linkinus or whatever, did similar things
00:16:41 <clokep> Mook_as: It's not uncommon to do.
00:16:53 <clokep> (Also to link to random imgage upload websites, etc.)
00:17:01 <clokep> Like to just include the image in imageshack.
00:18:05 <Mook_as> yeah, I think for a very short period of time, I ended up sending links that triggered rheet.wav :p
00:18:46 <clokep> Ah right, the songbird bot also sends a bunch of images and such, no?
00:21:41 <Mook_as> yeah, I think so.
00:21:54 <Mook_as> (except that it's MIA)
00:22:48 <aleth> Or one could do thumbnails on hover
00:41:35 --> ecaron has joined #instantbird
00:43:20 <-- ecaron has quit (Quit: Instantbird 1.1)
00:54:10 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
01:20:32 <-- EionRobb has quit (Connection reset by peer)
01:20:55 --> EionRobb has joined #instantbird
01:41:18 <-- Mook_as has quit (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner])
02:01:20 <-- Tobin has quit (Ping timeout)
02:03:03 --> Tobin has joined #instantbird
02:15:18 <-- Even has quit (Connection reset by peer)
03:10:00 <instant-buildbot> build #367 of macosx-nightly-default started, including []
03:10:00 <instant-buildbot> build #461 of win32-nightly-default started, including []
03:10:01 <instant-buildbot> build #376 of linux-nightly-default started, including []
03:38:48 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
04:01:29 <instant-buildbot> build #376 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/376
04:45:52 --> Draighth has joined #instantbird
04:51:15 <-- EionRobb has quit (Quit: Leaving.)
04:55:05 <-- Draighth has left #instantbird ()
05:39:14 --> jb has joined #instantbird
05:52:35 <-- chrisccoulson has quit (Client exited)
05:56:49 <-- jb has quit (Quit: Instantbird 1.2a1pre)
05:58:45 --> jb has joined #instantbird
06:13:12 <-- harisund has quit (Ping timeout)
06:13:16 --> harisund has joined #instantbird
06:20:10 <-- jb has quit (Ping timeout)
06:52:02 <instant-buildbot> build #367 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/367
06:54:09 <-- micahg has quit (Ping timeout)
06:56:19 <instant-buildbot> build #461 of win32-nightly-default is complete: Failure [failed shell_2]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/461
06:57:45 --> micahg has joined #instantbird
06:59:52 <-- micahg has quit (Ping timeout)
07:10:09 --> micahg has joined #instantbird
07:19:17 --> EionRobb has joined #instantbird
07:54:22 --> gerard-majax has joined #instantbird
08:05:20 <-- Even1 has quit (Input/output error)
08:07:11 <-- EionRobb has quit (Quit: Leaving.)
08:18:43 <-- Tomek has quit (Quit: Instantbird 1.1)
08:36:35 --> MadWookiee has joined #instantbird
08:50:30 --> jb has joined #instantbird
08:51:20 --> Even has joined #instantbird
08:51:20 * ChanServ sets mode +o Even 
09:07:01 --> Even1 has joined #instantbird
09:14:56 <-- Even1 has quit (Quit: Instantbird 1.2a1pre)
09:15:24 --> Even1 has joined #instantbird
09:23:55 --> Tomek has joined #instantbird
09:29:02 --> Mic has joined #instantbird
09:29:02 * ChanServ sets mode +h Mic 
09:35:06 <-- jb has quit (Ping timeout)
09:40:05 <Mic> clokep: one day, I'll create this '(pre)view' extension for pasted links :)
09:53:39 --> jb has joined #instantbird
09:55:22 --> mmkmou has joined #instantbird
10:14:17 --> flo has joined #instantbird
10:14:17 * ChanServ sets mode +qo flo flo 
10:15:00 <-- flo has quit (Quit: Instantbird 1.2a1pre)
10:15:14 --> flo has joined #instantbird
10:15:14 * ChanServ sets mode +qo flo flo 
10:32:41 <instantbot> florian@instantbird.org denied review for attachment 1132 on bug 1016.
10:32:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1016 nor, --, 1.2, aletheia2, ASSI, Quit warning is hidden when conversation window lacks focus
10:34:56 --> Mad_Maks has joined #instantbird
10:37:41 --> aleth has joined #instantbird
10:55:55 <flo> it sucks that the wizard binding eats the JS errors that happen during account creation :(
10:58:22 <-- Mad_Maks has quit (Quit: Instantbird 1.2a1pre)
11:01:06 --> Mad_Maks has joined #instantbird
11:05:17 --> jb1 has joined #instantbird
11:05:55 <-- jb has quit (Ping timeout)
11:13:47 <instantbot> florian@instantbird.org cancelled review?(clokep@gmail.com) for attachment 1130 on bug 434.
11:13:48 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1133 on bug 434.
11:13:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=434 enh, --, ---, florian, ASSI, Use toolkit password manager
11:18:33 <-- Mad_Maks has quit (Quit: Instantbird 1.2a1pre)
11:18:58 <-- Tomek has quit (Quit: Instantbird 1.1)
11:24:42 --> clokep has joined #instantbird
11:24:42 * ChanServ sets mode +h clokep 
11:24:55 <clokep> flo: I tested with a Google Talk account (so jsProtoHelper)
11:28:32 <flo> I guess we will need to fix that someday
11:29:29 <clokep> Yeah...
11:29:45 <flo> does it look ready to land otherwise?
11:29:51 <clokep> It does.
11:29:56 <clokep> Except the spelling error.
11:30:11 <clokep> (At least I think it's a spelling error? It might just be a non-US way to spell...)
11:30:31 <flo> which one? I've fixed the convertion -> conversion already (https://bugzilla.instantbird.org/attachment.cgi?id=1134&action=diff)
11:30:39 <clokep> Ah you fiixed that, yes. :)
11:31:09 <clokep> Then yes, it looks fine.
11:35:17 <clokep> flo: OK, so it seems to work OK with libpurple accounts, but my Google Talk account is still funky.
11:35:34 <clokep> It created OK w/o a password, but then never prompted me for one (so I get "Not authorized (wrong password)")
11:35:59 <flo> was this a duplicate account?
11:36:16 <flo> the password manager doesn't save per-account passwords
11:36:28 <flo> so if there's already a password stored for the same protocol and username, it will be used
11:36:49 <flo> I've just created a duplicate gtalk account without setting a password, and it connected just fine :)
11:38:57 <clokep> It's a "duplicate" account in that...it's one of the accounts I was trying to ste up before.
11:39:03 <clokep> So it was probably saved w/ a "" password?
11:39:20 <flo> the password manager can't save an empty password, so no
11:39:24 <clokep> Hmmm...yeah no.
11:39:33 <flo> if you got to the account properties of that new account, is there a password in the box?
11:39:48 <clokep> No.
11:40:03 <flo> and with a clean profile?
11:40:23 <clokep> Trying that now.
11:41:42 <clokep> flo: Still didn't prompt me.
11:42:10 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
11:42:40 <flo> ok
11:42:45 <flo> with a new profile it doesn't prompt me either
11:43:35 <flo> I suspect JS-XMPP doesn't have the passwordRequired flag
11:44:15 <flo> bah, jsProtoHelper defaults to get passwordOptional() true, http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#731
11:45:20 <clokep> Well that's an easy fix at least. :)
11:46:15 <clokep> I'd say feel free to commit it and give me another patch that fixes the jsProto stuff.
11:46:16 <flo> I'm not sure that default value in jsProtoHelper makes sense
11:46:33 <clokep> If that's easier.
11:46:40 <flo> http://pastebin.instantbird.com/9839
11:47:22 <clokep> I'm not sure which default makes sense either...I feel like most protocols DO require a password though.
11:47:45 <clokep> Does Twitter require a password? I forget how we save the oauth garbage.
11:47:52 <flo> twitter defines noPassword to true already
11:48:07 <flo> so I hope passwordOptional is ignored in that case :)
11:48:16 <clokep> OK! :) Then r+!
11:48:16 <flo> it seems only JS-IRC will want an optional password
11:48:36 <flo> so I could revert this latest patch and change the default value in jsProtoHelper
11:48:40 <flo> if that feels cleaner
11:49:33 <clokep> I think I would prefer that.
11:49:46 <clokep> (IRC & Omegle do not require passwords, I'm not sure if any other protocol doesn't.)
11:50:16 <flo> Omegle doesn't support passwords
11:50:23 <flo> so it will have noPassword to true
11:50:55 <clokep> Bah, you're right.
11:50:58 <clokep> So IRC then. :P
11:52:37 <flo> ah, I also need to change that comment: http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccount.idl#244
11:56:20 <clokep> Yes. :)
11:56:26 <clokep> I need to go to work. I'll be back in a bit!
11:56:30 <flo> https://bugzilla.instantbird.org/attachment.cgi?id=1133&action=edit
11:56:34 <flo> if you want to r+ ;)
11:57:18 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
12:30:50 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1135 on bug 1016.
12:30:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1016 nor, --, 1.2, aletheia2, ASSI, Quit warning is hidden when conversation window lacks focus
12:37:26 --> clokep_work has joined #instantbird
12:37:27 * ChanServ sets mode +h clokep_work 
12:41:39 <instantbot> clokep@gmail.com granted review for attachment 1133 on bug 434.
12:41:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=434 enh, --, ---, florian, ASSI, Use toolkit password manager
12:43:45 <clokep_work> :)
12:45:00 --> jb has joined #instantbird
12:46:03 <-- jb1 has quit (Ping timeout)
12:53:15 --> jb1 has joined #instantbird
12:54:09 <-- jb has quit (Ping timeout)
12:54:14 <flo> I almost wrote attachment 1135, so maybe clokep should review it again instead of me :-S
12:54:40 <flo> (it looks good from my point of view. I haven't tested it though :))
12:58:21 --> jb has joined #instantbird
12:58:49 <clokep_work> r- ;)
12:59:16 <flo> ? :)
12:59:29 <-- jb1 has quit (Ping timeout)
13:01:30 --> jb1 has joined #instantbird
13:01:33 <clokep_work> Just a nit.
13:02:17 <-- jb has quit (Ping timeout)
13:16:32 <flo> I dislike the few minutes while restoring a VM when VMWare competes with all other applications to get 1GB of memory :-/
13:22:09 <clokep_work> Testing something in Windows? :)
13:22:25 <flo> I would like to see if I can reproduce that shutdown crash on my Windows 7 VM
13:27:39 <clokep_work> Ah.
13:34:21 <aleth> I thought JS only had the Number type (which is floating point), so optimizing for integer arithmetic was pointless. Is this wrong?
13:35:16 <flo> I didn't mean to say it would execute faster
13:35:47 <aleth> flo: I didn't take it that way, but as I considered it originally I thought I would ask
13:35:52 <flo> the optimization is mostly in the time my brain takes to compute whether that line is likely to cause an issue or not ;)
13:36:10 <aleth> (old C habit of wondering about int vs float)
13:36:21 <flo> are we going to divide by zero? is the floating point value going to lead to rounding issues?
13:36:44 <clokep_work> aleth: I think you mean "(un)?signed (int|float|double|char|long)"? :P
13:37:05 <aleth> clokep_work: add some **s and &s :P
13:37:08 <flo> aleth: I think the JS engine stores Numbers as int until it's no longer possible and then falls back to storing in a floating point value.
13:37:24 <flo> I'm not sure though :)
13:41:12 <clokep_work> I think there's also some optimization about 64-bit vs. 32-bit numbers.
13:45:23 <Even1> flo: floating point?
13:45:29 <Even1> flo: looks strange to me...
13:45:40 <flo> https://bugzilla.mozilla.org/show_bug.cgi?id=675221 sounds like the update of purplexpcom for Mozilla 12 is going to be painful
13:45:58 <Even1> flo: is it not more likely for it to use a large number math library for those operations like PHP does ?
13:46:01 <Even1> (huge int = string)
13:46:13 <flo> Even1: no, it doesn't
13:46:22 <Even1> That's sad...
13:46:24 <flo> operations on large ints fail
13:46:31 <Even1> I prefer the PHP way then :P
13:46:40 <flo> as we have already suffered from for tweet ids...
13:46:50 <Even1> aouch
13:47:00 <Even1> You can store them in strings...
13:47:08 <flo> that's what we do
13:47:17 <Even1> Yeah, looks more logical.
13:47:22 <flo> but we need to carefully review the code to ensure they aren't converted to numbers
13:47:34 <flo> (when sorting for example...)
13:47:36 <Even1> I still thing that JS miss a bistro for large ints :)
13:47:53 <Even1> *think
13:48:20 <Even1> But if it doesn't, 10 is going to be between 1 and 2 isn't it ?
13:48:31 <Even1> (using a string sort)
13:49:04 <flo> Even1: the length needs to be compared first
13:49:12 <Even1> Looks slow...
13:49:23 <flo> slow, maybe. Painful, definitely!
13:49:44 <Even1> This is definitely silly :)
13:49:48 <Even1> We miss 64 bits integers :P
13:49:58 <Even1> (at least)
13:50:15 <flo> I can't find a place where we sort tweet ids though, so maybe we don't need it after all :)
13:50:41 <Even1> Hope so.
13:50:54 <Even1> Because sorting strings using an integer sort is a pain...
13:50:55 <flo> ahah http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#925
13:52:13 <Even1> ...
13:52:18 <Even1> Horrible :)
13:52:41 <flo> we survived ;)
13:54:47 <Even1> Hardly!
13:59:18 <clokep_work> Even1: Someone prefers PHP?! (I actually really like PHP, like what I learned to program on...)
13:59:35 <clokep_work> Also, Tweet IDs I believe overflowed 64-bit #s, so it's not just a matter of 64-bit ints.
14:49:30 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:04:01 <flo> is there a way on Windows to still see what was printed in the console (dump calls) after the process terminates?
15:04:42 <flo> if I start with -console the terminal is closed with the process so I can't see messages logged during shutdown :(
15:05:46 <-- mmkmou has quit (Ping timeout)
15:07:05 --> mmkmou has joined #instantbird
15:18:54 <Even1> flo: you can redirect the output to a file ?
15:19:00 <Even1> -console >out.log
15:19:04 <Even1> I suppose it should work :)
15:19:16 <flo> Even1: it's not the same console
15:19:26 <flo> nothing is printed in the console that I used to start the application
15:19:45 <Even1> I should have known that...
15:19:48 <Even1> So bad...
15:20:04 <Even1> For this console I don't know. But you should :P
15:20:26 <flo> of course debug builds don't have this problem...
15:21:16 <Even1> Hope so :)
15:22:13 <flo> but our buildbot doesn't produce debug build ;)
15:46:51 --> ecaron has joined #instantbird
15:47:57 <-- Even1 has quit (Ping timeout)
15:48:57 --> Mic has joined #instantbird
15:48:57 * ChanServ sets mode +h Mic 
15:54:16 <Mic> clokep: I think JS doesn't even support 64-bit integers.
15:56:07 <Mic> That's where I got this idea from: https://developer.mozilla.org/en/js-ctypes/js-ctypes_reference#64-Bit_integer_handling
16:01:39 --> igorko has joined #instantbird
16:07:08 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
16:13:18 --> igorko1 has joined #instantbird
16:15:12 <-- igorko1 has quit (Quit: Instantbird 1.1)
16:18:00 <flo> I have a js stack for that crash http://i.imgur.com/a1g2R.png
16:28:27 <flo> I can probably work around the crash by a trivial change in xmpp.jsm
16:28:58 <flo> but there's probably something wrong somewhere else, as I don't think these pointless notifications should cause a crash :)
16:29:17 <-- flo has quit (Quit: Instantbird 1.2a1pre)
16:34:56 --> igorko1 has joined #instantbird
16:36:06 <-- igorko1 has quit (Quit: Instantbird 1.1)
16:40:35 <-- micahg has quit (Ping timeout)
16:42:21 --> clokep_work has joined #instantbird
16:42:21 * ChanServ sets mode +h clokep_work 
16:43:02 --> wesj has joined #instantbird
16:48:20 <-- gerard-majax has quit (Ping timeout)
16:56:29 --> micahg has joined #instantbird
17:21:33 <-- igorko has quit (Ping timeout)
17:23:49 --> Even1 has joined #instantbird
17:39:00 <-- MadWookiee has quit (Quit: Instantbird 1.1)
17:40:46 --> Tomek has joined #instantbird
17:48:04 --> Mook_as has joined #instantbird
17:51:23 <-- jb1 has quit (Connection reset by peer)
17:59:42 --> jb has joined #instantbird
18:36:28 --> jb1 has joined #instantbird
18:36:48 <-- jb has quit (Ping timeout)
18:37:00 --> jb has joined #instantbird
18:38:11 <-- jb1 has quit (Ping timeout)
18:39:32 <-- jb has quit (Ping timeout)
18:44:28 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre)
18:57:34 --> jb has joined #instantbird
19:06:18 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1135 on bug 1016.
19:06:19 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1136 on bug 1016.
19:06:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1016 nor, --, 1.2, aletheia2, ASSI, Quit warning is hidden when conversation window lacks focus
19:10:21 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1131 on bug 1243.
19:10:22 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1137 on bug 1243.
19:10:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1243 nor, --, 1.2, aletheia2, ASSI, Only show progress bar when necessary
19:11:31 <instantbot> clokep@gmail.com granted review for attachment 1136 on bug 1016.
19:11:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1016 nor, --, 1.2, aletheia2, ASSI, Quit warning is hidden when conversation window lacks focus
19:19:06 <clokep_work> Thanks aleth .
19:19:52 <-- Even1 has quit (Quit: Instantbird 1.2a1pre)
19:19:55 <aleth> :)
19:20:05 * aleth wants a bugzilla interface for his editor
19:20:31 <clokep_work> What do you mean?
19:20:36 <clokep_work> There's an API. :P You could make one.
19:21:30 <aleth> I suppose :P I was thinking of the diff -> attach to bug and add comment steps
19:22:32 <clokep_work> I think there's some python scripts around that do that, but I'm not sure...
19:22:37 <aleth> Just hit a key and enter a 'commit' message ;)
19:22:56 <aleth> I might do a google and see if someone has done it for emacs :D
19:24:23 <clokep_work> Hahah.
19:24:24 <clokep_work> Probably.
19:24:42 <clokep_work> aleth: http://emacszilla.sourceforge.net/
19:24:56 <aleth> haha 
19:25:02 --> Mnyromyr has joined #instantbird
19:25:52 <aleth> There is also a bugzilla-submit script 
19:27:31 <aleth> emacszilla seems to be vapourware...
19:27:50 <clokep_work> Everything is vapourware. :P
19:28:06 <aleth> Well, IB also has some files :P
19:28:09 <aleth> for example
19:31:06 --> igorko has joined #instantbird
19:32:37 --> EionRobb has joined #instantbird
19:37:54 --> gerard-majax has joined #instantbird
19:38:36 <clokep_work> Has some files that are vapourware? ;)
19:38:38 <clokep_work> Probably.
19:38:48 <clokep_work> I generally just write scripts for my editor myself when I need them...
19:39:38 * Mook_as high-fives clokep_work
19:39:59 * clokep_work wonders if Mook_as has Bugzilla scripts for Komodo. ;)
19:40:00 <aleth> No, I meant emacszilla has no code... I also write scripts, but I don't think I'll bother with a bugzilla one myself
19:40:15 <clokep_work> Ah, nothing at all? That's a lame sourceforge project. :(
19:40:31 <Mook_as> no, all I have in terms of bugzilla customization is a user script to help with reviewing patches in the browser
19:40:44 <Mook_as> (~= splinter now on bugzilla.m.o)
19:41:28 <clokep_work> Right.
19:42:24 <Mook_as> I suppose if I get Infinite Time I should aim for better git integration in komodo (since that's how I get my patches, <3 git format-patch)
19:42:59 <clokep_work> Yeah...that infinite time hack...
19:43:20 <aleth> Yeah... add that as a feature FTW
19:44:08 <aleth> Just needs some new physics.
19:46:43 <aleth> clokep_work: You were right about python btw, someone is actually maintaining this: https://github.com/LegNeato/bztools
19:48:37 <clokep_work> Ah, yeah. That's the one I had thought of.
19:51:01 --> micahg_ has joined #instantbird
19:51:09 <-- micahg_ has quit (Client exited)
19:51:20 <aleth> Hmm, there is also git-send-bugzilla and git-bz. I wonder if they still work...
19:51:22 <-- micahg has quit (Ping timeout)
19:52:41 --> micahg has joined #instantbird
19:53:49 <aleth> Used by the gnome devs apparently https://live.gnome.org/Empathy/Git/description
19:55:53 <aleth> |git-send-bugzilla -m "Fix review comments of Alice" 12345 master| sounds rather nice
19:58:52 <clokep_work> :) Not too bad, yeah.
19:59:15 <clokep_work> But that means you check it into your own repo?
19:59:54 <aleth> No, it seems the diff of your repo (master) is submitted to bugzilla bug 12345
20:00:31 <aleth> But I haven't tried it yet
20:02:00 <clokep_work> Ah, nice.
20:02:16 <aleth> Hmm. There is something odd about mentioning 'master' though
20:02:59 <aleth> I'm not sure it does what I thought
20:03:18 <aleth> It may assume the project uses git
20:04:15 * aleth doesn't think he is going down that rabbithole tonight
20:06:38 <Mook_as> from the source, it looks like it wants "Usage: git-send-bugzilla [options] <bugid> <since>[..<until>]\n"
20:06:57 <Mook_as> so "master" there is "commit to diff from", I think?
20:08:52 <aleth> Yes, I think so.
20:09:34 <aleth> diff of branch with master
20:10:01 --> mmkmou has joined #instantbird
20:31:17 <-- igorko has quit (Connection reset by peer)
20:31:32 --> flo has joined #instantbird
20:31:32 * ChanServ sets mode +qo flo flo 
20:38:07 <-- jb has quit (Connection reset by peer)
20:38:17 <clokep_work> Good evening flo!
20:41:43 <flo> clokep_work: good afternoon :)
20:49:03 --> igorko has joined #instantbird
21:11:43 <-- mmkmou has quit (Ping timeout)
21:19:24 --> EionRobb1 has joined #instantbird
21:20:09 <-- EionRobb has quit (Ping timeout)
21:25:09 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:25:18 --> aleth has joined #instantbird
21:26:52 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:26:54 <-- Tomek has quit (Quit: Instantbird 1.1)
21:28:58 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:29:25 --> aleth has joined #instantbird
21:32:22 <-- igorko has quit (Connection reset by peer)
21:43:22 <-- micahg has quit (Input/output error)
21:44:16 --> micahg has joined #instantbird
22:03:38 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1138 on bug 1162.
22:03:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1162 nor, --, ---, nobody, NEW, Focus contact window on 'Restore' in tray context menu
22:10:31 <-- micahg has quit (Connection reset by peer)
22:11:09 --> micahg has joined #instantbird
22:34:40 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:37:06 --> chrisccoulson has joined #instantbird
22:42:51 <flo> aleth: I don't understand your latest comment in bug 1016
22:42:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1016 nor, --, 1.2, aletheia2, ASSI, Quit warning is hidden when conversation window lacks focus
22:44:40 <aleth> flo: I assume the desired behaviour has always been "if warnOnQuit is true, don't quit before the user has actually seen the warning." This was not the case before this patch
22:44:56 <aleth> But it doesn't matter
22:46:03 <flo> why wasn't it the case?
22:46:14 <flo> or was that a poor interaction with mintrayr?
22:46:44 <aleth> It's possible. There were certainly cases where IB just quit instantly and you never got the warning.
22:48:12 <flo> the warning is only when there are unread messages, right? :)
22:48:47 <aleth> sure :)
22:49:05 <flo> do you still don't want your patches to be commited with your real name?
22:49:21 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
22:49:36 --> aleth has joined #instantbird
22:50:02 <aleth> For example when the conv window was minimized, as mentioned in the bug. I don't think mintrayr played a role in that
22:50:48 <aleth> flo: not for now... thanks!
22:51:12 <flo> a modal dialog with a minimized parent isn't displayed at all? :-S
22:51:31 <aleth> yes :S
22:51:46 --> mmkmou has joined #instantbird
22:52:30 <flo> what does the ca. abbreviation mean?
22:52:48 <aleth> Come to think of it, that's probably a bug. It has nothing to do with cases where the window is null, so my comment that confused you doesn't apply then anyway
22:52:54 <aleth> circa
22:53:10 <aleth> https://en.wikipedia.org/wiki/Circa
22:54:20 <flo> thanks :)
22:54:38 <aleth> I thought it was a common one :|
22:55:26 <flo> maybe for native English speakers :)
22:56:03 <flo> I can assume you have tested the patch from bug 1243 and I can commit it without testing it myself?
22:56:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1243 nor, --, 1.2, aletheia2, ASSI, Only show progress bar when necessary
22:56:58 <aleth> Yes. The only thing you might want to test is the "feel" of it (ie. the progress bar criteria)
22:57:35 <flo> hmm, shouldn't the new variable also be reset in http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#607 ?
22:58:58 <aleth> Hmm. Probably. I didn't notice that section was relevant :(
22:59:31 <flo> probably a good indication that we need to add a comment about it ;)
23:01:53 <instantbot> florian@instantbird.org granted review for attachment 1137 on bug 1243.
23:01:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1243 nor, --, 1.2, aletheia2, ASSI, Only show progress bar when necessary
23:04:32 <flo> I don't know where to put a comment for this :-/
23:05:09 <aleth> Maybe after http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#567 ?
23:05:46 <flo> or maybe at line 602
23:06:17 <aleth> depending on the generality of the comment...
23:07:02 <flo> I could put there a comment explaining why we need to reset all these variables (it's because when the user switches to a different logged conversation before the previous one has been fully displayed, these variables end up in an inconsistent state if we don't reset them before displaying the new conversation)
23:07:30 <flo> but I was more concerned with preventing people writing a patch similar to yours from ignoring that they need to look somewhere else
23:08:24 <aleth> Maybe two comments? The first is the general warning, the second specific one at 602 
23:16:51 <flo> aleth: http://pastebin.instantbird.com/9922
23:18:26 <aleth> That looks good :)
23:18:32 <aleth> It is similar to the comment at http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#889
23:19:01 <aleth> Which was helpful, to me at least, as I recall.
23:20:41 <aleth> Should  the blank line 17 in the pastebin be removed? To make it clear the following two fields are also reset...
23:22:36 <aleth> Or maybe another  blank line after 19 would do it
23:24:20 <flo> the blank line at line 17 is because the 3 variables before it are used throughout the file and the 2 variables before the appendMessage method are used only (mostly?) in that method
23:27:44 <aleth> Yes, I understood the grouping. Anyway the comment should help either way
23:30:50 <flo> ok, I'll commit it as on the pastebin :)
23:31:37 <-- ecaron has quit (Quit: Instantbird 1.1)
23:44:31 <flo> I think I've found the cause of that shutdown crash :)
23:46:09 <flo> aleth: for bug 1234 if I've understood correctly, you would recommend taking the patch as is?
23:46:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1234 nor, --, ---, aletheia2, NEW, Improve keyboard navigation
23:48:11 <aleth> flo: Yes, unless you feel 2) or 4) in the last comment should be acted upon, in which case remove the relevant handle from the convbrowser section of the patch.
23:48:33 <aleth> I'm agnostic on those two.
23:49:39 <flo> I feel like this is already confusing enough, and if something really needs to be done for any of these, it could as well be in a separate bug with a clear explanation centered only on that specific point
23:50:58 <-- gerard-majax has quit (Ping timeout)
23:51:00 <aleth> I didn't expect it to get so confusing... the patch was trying to straighten things out
23:52:52 <aleth> Though I do think a decision on those points should be made before 1.2 to avoid changing things more than once for the users, the patch can land and then ppl can test it
23:55:47 <flo> keyboard mappings are generally confusing, it's not your fault :)
23:56:38 <flo> 2) is just keeping the current behavior, isn't it?
23:57:14 <aleth> The patch keeps the current behaviour, Mic suggested Sh-PgUp/Dn would be unnecessary in the future (2)
23:57:31 --> clokep has joined #instantbird
23:57:31 * ChanServ sets mode +h clokep