#instantbird log on 01 24 2012

All times are UTC.

00:21:51 --> clokep has joined #instantbird
00:21:51 * ChanServ sets mode +h clokep 
00:30:56 --> Mautematico has joined #instantbird
00:37:08 <-- myk has quit (Connection reset by peer)
00:55:32 <clokep> Mic: The goodnight was for you guys since I wouldn't be back before anyone went to sleep. ;)
00:55:50 <clokep> flo: And we use code from oauthorizer to do our oauth UI! :)
01:32:54 --> ecaron has joined #instantbird
01:34:13 <-- ecaron1 has quit (Ping timeout)
01:52:45 <-- Mook_as has quit (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner])
02:08:16 --> ecaron1 has joined #instantbird
02:08:53 <-- ecaron has quit (Ping timeout)
02:13:58 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
02:25:01 <-- wesj has quit (Input/output error)
02:49:58 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
02:52:39 <-- ecaron1 has quit (Quit: Instantbird 1.1)
03:09:54 <-- Mautematico has quit (Client exited)
03:10:00 <instant-buildbot> build #366 of macosx-nightly-default started, including []
03:10:01 <instant-buildbot> build #460 of win32-nightly-default started, including []
03:10:01 <instant-buildbot> build #375 of linux-nightly-default started, including []
03:10:33 --> Mook has joined #instantbird
03:47:50 <instant-buildbot> build #375 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/375
04:45:10 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603])
04:59:45 <instant-buildbot> build #460 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/460
05:03:40 <-- EionRobb has quit (Quit: Leaving.)
06:18:48 <-- Suiseiseki has quit (Connection reset by peer)
06:21:10 --> Suiseiseki has joined #instantbird
06:33:46 --> jb has joined #instantbird
06:37:41 --> Tomek has joined #instantbird
06:51:48 <instant-buildbot> build #366 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/366
06:57:12 <-- jb has quit (Ping timeout)
06:59:38 --> jb has joined #instantbird
07:31:38 <-- jb has quit (Ping timeout)
07:57:19 --> gerard-majax has joined #instantbird
08:13:34 <-- Tomek has quit (Quit: Instantbird 1.1)
08:16:59 --> jb has joined #instantbird
08:58:56 --> MadWookiee has joined #instantbird
09:01:41 --> Even has joined #instantbird
09:01:41 * ChanServ sets mode +o Even 
09:01:49 <-- Even has quit (Quit: Instantbird 1.2a1pre)
09:02:40 --> Even has joined #instantbird
09:02:40 * ChanServ sets mode +o Even 
09:18:48 --> EionRobb has joined #instantbird
09:28:17 <-- Tonnes has quit (Ping timeout)
09:29:32 --> Tonnes has joined #instantbird
09:35:02 --> mmkmou has joined #instantbird
09:38:17 <-- Even has quit (Quit: Instantbird 1.2a1pre)
09:42:09 --> go8765 has joined #instantbird
09:54:42 <-- EionRobb has quit (Quit: Leaving.)
10:02:23 --> flo has joined #instantbird
10:02:23 * ChanServ sets mode +qo flo flo 
10:16:48 --> Mic has joined #instantbird
10:16:48 * ChanServ sets mode +h Mic 
10:17:05 <Mic> Hi
10:20:25 <flo> hello :)
10:24:07 <-- go8765 has quit (Ping timeout)
10:24:46 --> go8765 has joined #instantbird
10:30:55 <go8765> !ping
10:34:33 <Mic> go8765: pong ;)
10:35:28 <go8765> :) i see message that my accout disabeled, so i want to check it)
10:36:04 <flo> clokep: when entering a wrong password, the same prompt opens again (without any indication that you entered a wrong password or anything...)
10:36:11 <flo> *wrong master password
10:38:25 --> Even has joined #instantbird
10:38:25 * ChanServ sets mode +o Even 
10:59:57 * flo discovers https://developer.mozilla.org/en/Components.Exception
11:02:10 <-- Tonnes has quit (Ping timeout)
11:03:23 --> Tonnes has joined #instantbird
11:04:20 <Even> 11:59:56 * flo discovers https://developer.mozilla.org/en/Components.Exception
11:04:20 <Even> => look good
11:04:23 <Even> *looks
11:09:58 <-- go8765 has left #instantbird ()
11:18:11 --> jb1 has joined #instantbird
11:18:31 --> clokep has joined #instantbird
11:18:31 * ChanServ sets mode +h clokep 
11:18:38 <-- jb has quit (Ping timeout)
11:21:12 <Mic> pff, that posting on bug 1234 took a lot of time to write :(
11:21:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1234 nor, --, ---, aletheia2, NEW, Improve keyboard navigation
11:35:06 <clokep> flo: That's unfortunate. :-/
11:41:54 --> go8765_ has joined #instantbird
11:44:52 <-- go8765_ has quit (Quit: Konversation terminated!)
11:46:33 <-- MadWookiee has quit (Ping timeout)
11:48:48 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
11:51:38 --> MadWookiee has joined #instantbird
12:10:05 <flo> is this too verbose? http://i.imgur.com/iHNlo.png
12:42:01 --> clokep_work has joined #instantbird
12:42:01 * ChanServ sets mode +h clokep_work 
12:42:45 <clokep_work> flo: I don't think so.
12:58:13 <clokep_work> That was a long comment Mic. :P
12:59:57 <Mic> I also hope it makes sense ;)
13:00:27 <clokep_work> Are the "WORKS/FAILS" with or without the patch?
13:05:27 <Mic> That's how I'd suggest it should work.
13:05:57 <Mic> The main point was supposed to be that we wouldn't lose much if we'd leave all the modifier-key bindings away.
13:06:32 <Mic> Seems the comment wasn't long enough :P
13:07:13 <clokep_work> I'm sure it was. I've just been pretty out of it recently. :)
13:07:26 <clokep_work> Then yes, I agree with you...I think most cases would be covered without adding crazy modifiers.
13:10:33 <flo> that key icon looks horrible :-S
13:11:07 <flo> I'm not even sure I would understand it's a key without the context
13:12:01 <flo> it makes me think of http://coloriages.dessins.free.fr/images/scie-egoine.JPG
13:13:20 --> jb has joined #instantbird
13:13:53 <-- jb1 has quit (Ping timeout)
13:17:24 --> deOmega1 has joined #instantbird
13:18:51 <deOmega1> good day.  I have been havingIB crash on me every time i restart it.  I already sent in 3 crash reports  since i started it this morning 
13:19:02 <-- micahg has quit (Ping timeout)
13:19:08 <deOmega1> restart of shut down
13:19:19 <flo> deOmega1: does it crash when starting or when shutting down?
13:19:50 <deOmega1> when shutting down
13:19:58 <deOmega1> here is the  report:  http://pastebin.com/VRfYV1Xc
13:23:52 <clokep_work> Do you have the crash ID? (Error Console > openDialog("about:crashes"))
13:24:15 <flo> http://crash-stats.instantbird.com/report/index/0b889fac-5a86-479e-a7cd-b1d542120121 uh :(
13:24:24 <flo> (not deOmega1's report, but still... uh :()
13:24:54 <flo> I guess I can reopen bug 1017 :-/
13:24:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1017 cri, --, 1.2, florian, RESO FIXED, Shutdown crash [@ purple_blist_node_set_ui_data ]
13:27:07 <clokep_work> :(
13:27:14 * clokep_work has been crashing with http://crash-stats.instantbird.com/report/list?product=Instantbird&platform=windows&query_search=signature&query_type=exact&query=&date=&range_value=1&range_unit=weeks&process_type=all&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&signature=purple_connection_get_state apparently.
13:27:35 <flo> yeah
13:27:44 <flo> it's the one we have been narrowing down with Even.
13:28:04 <flo> I still need to look more at the code to find how it can cause this, and fix it
13:31:07 <clokep_work> Ah OK. Do we have a bug open about that? Was a regression range found?
13:31:11 <Even> Yeah. This bug is really annoying ;). We spent a lot of time with flo looking for its cause. Hope flo will fix it soon ;)
13:31:42 --> jb1 has joined #instantbird
13:32:17 <Even> clokep_work: not really, we suspect it's something old that has been genealized since bug #759
13:32:17 <-- jb has quit (Ping timeout)
13:32:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, florian, RESO FIXED, Reorganize purplexpcom
13:32:50 <Even> (something like a race condition that was not happening before those changes but is now)
13:35:01 --> micahg has joined #instantbird
13:35:12 <deOmega1> clokep_work: did you need something from me or you got it?
13:35:33 <clokep_work> deOmega1: flo answered.
13:35:46 <clokep_work> Even: Ah, OK. :( Well let me know if you need me to try anything.
13:35:55 <deOmega1> ok, great
13:36:23 <flo> clokep_work: I currently suspect that during the uninitialization of the contact service we send notifications for some of the buddies, and then something receives these notifications and attempts to find a more available buddy (which is already uninitialized, but not fully, because we are still uninitializing contacts...)
13:36:27 <flo> it's not completely clear yet
13:36:51 <clokep_work> That sounds painful / confusing. :-/
13:37:00 <flo> clokep_work: what have I answered? I don't know which report deOmega1 has sent (I was just looking at the report received in the last 24 hours)
13:37:20 <clokep_work> Ah. I thought you were saying it was the same type of report...
13:37:41 <flo> clokep_work: what's especially confusing is that we crash in C/C++ code related to libpurple, but only if a JS-XMPP Gtalk account has been connected at least once during the session.
13:39:19 <clokep_work> What. (o_O)
13:39:46 <clokep_work> Does it happen if the JS-XMPP contact is grouped w/ another contact, perhaps?
13:39:54 <clokep_work> (w/ another *libpurple* contact)
13:39:59 <flo> clokep_work: of course :)
13:40:11 <flo> but it doesn't happen if the JS-XMPP account hasn't been connected
13:40:14 <clokep_work> Ah, OK. So it sounds like a bug in jsProtoHelper maybe?
13:40:21 <flo> maybe
13:40:33 <flo> or just a poor interaction between garbage collected and reference counted stuff
13:40:43 <clokep_work> :-/
13:42:54 <flo> that kind of things is all very confusing only we can point precisely to the exact cause of the problem ;)
13:43:46 <flo> sounds like a nice debug game ;). The real difficulty though is that it happens only on Windows, which isn't appropriate for debugging.
13:44:17 <-- deOmega1 has left #instantbird ()
13:48:46 <clokep_work> "game" sure...
14:04:57 --> Tomek has joined #instantbird
14:36:52 <-- MadWookiee has quit (Quit: Instantbird 1.1)
14:44:47 --> ecaron has joined #instantbird
14:44:49 <-- Tomek has quit (Quit: Instantbird 1.1)
15:05:19 --> MadWookiee has joined #instantbird
15:08:53 <-- jb1 has quit (Quit: Instantbird 1.2a1pre)
15:12:16 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 †1809))
15:18:02 --> SM0TVI has joined #instantbird
15:47:22 --> igorko has joined #instantbird
15:58:51 --> Mic1 has joined #instantbird
16:01:24 * Mic1 just spent nearly one and a half hour ordering train and entrance tickets for his parents. Why does internet ordering have to suck so much?
16:02:32 <flo> Mic1: it has to suck just a little less than moving to the train station to buy the tickets.
16:03:07 <Mic1> No, it doesn't. This special offer was only available on the internet :(
16:03:10 <flo> unfortunately, they seem to handle this condition by ensuring that buying tickets from the station sucks more, rather than fixing the online ordering process :(
16:04:28 <flo> like for example forcing the sellers to use crappy UIs that force them to click in lots of different places on the screen for each ticket...
16:04:59 <flo> + selecting people who have very low click rates. No more than 10 clicks per minute ;)
16:08:30 <flo> hmm, I wonder if we {c,s}hould overlay the password manager UI to hide the horrible im://prpl-aim URIs and display the protocol names instead
16:08:51 <-- Mic has quit (Connection reset by peer)
16:11:03 <Mic1> If it wasn't so sad it would have been funny: something like "to use this mode of payment for this order, go to your account and activate it".
16:11:25 <Mic1> With "activate" = "enter the details and wait for the SNAILMAIL to arrive that allows you to confirm it"!
16:11:31 <Mic1> Insane ...
16:13:09 <flo> they could also try sending a confirmation SMS :)
16:15:27 <flo> Mic1: the official website of the French train company does its best to sell you a flight, a taxi ride, or an hotel night. Trains are almost hidden, because they know it's what everybody's coming for, so they could as well search among the various ads.
16:22:14 <clokep_work> flo: That would probably be a good idea, but isn't necessary for landing IMO.
16:22:54 <flo> just when I thought my patch was ready for review/landing, I found another case that causes one master password prompt per account :(
16:23:00 <flo> (if the user cancels them of course)
16:23:21 <clokep_work> :(
16:23:44 <clokep_work> If I cancel all the prompts and I have an IRC account without a password, will it connect/
16:23:56 <flo> why not?
16:24:21 <flo> I'm working on the code converting the passwords stored in the prefs now :)
16:25:04 <clokep_work> It should! Just curious if that was tested. :)
16:25:38 <flo> I don't think I've tested this specific case, but I see no reason why it wouldn't work
16:26:37 <flo> the connect function doesn't do any password magic if !this._passwordRequired (which is !this.protocol.noPassword && !this.protocol.passwordOptional)
16:26:49 <clokep_work> OK. :)
16:26:51 --> jb has joined #instantbird
16:28:25 <flo> that password manager stuff would be so easy without the master password thing
16:32:18 <clokep_work> :)
16:32:41 <clokep_work> It'll give a new reason of why to use Instantbird over Pidgin. ;)
16:32:55 <flo> sure
16:33:32 <flo> but we aren't competing, are we? :-P
16:34:28 <clokep_work> :) Well...there's a new difference between Instantbird and Pidgin. ;)
16:51:57 <-- gerard-majax has quit (Ping timeout)
16:56:10 <flo> if the user cancels the master password prompt while deleting an account, should we delete the account anyway?
16:58:29 <clokep_work> :-/ I'm not sure. Shouldn't you need to authenticate to be able to delete?
16:58:49 <flo> it's the reason why there's a master password prompt in that case
16:59:42 <flo> but I think if I click "cancel", I would expect it to cancel the action I asked (delete the account), rather than just a sub task of it (remove the account's password from the password manager)
17:00:13 <clokep_work> Yes, I'd expect it to NOT delete the account.
17:00:34 <flo> that's the behavior I will have if I don't handle the exception :)
17:00:55 <clokep_work> Aka, it's easier. ;)
17:01:29 <flo> we could also handle the exception just to avoid showing something in the error console when there's nothing wrong in the code and the error is the result of the user's action
17:02:35 <flo> clokep_work: do you want to review the code? :)
17:02:49 <flo> 15 files changed, 322 insertions(+), 52 deletions(-)
17:02:53 <clokep_work> flo: Yes, do you need it done nowish?
17:03:21 <flo> I would like to land it either tonight or tomorrow morning
17:03:41 <flo> (more likely tomorrow)
17:03:48 <clokep_work> Ah, that's not terrible actually. I should be able to do it today.
17:04:23 <flo> well, the time before landing also includes the time to handle your comments and fix the patch if needed ;)
17:05:12 <clokep_work> True. :) You can r? me in the bug.
17:05:17 <flo> sure
17:07:01 * clokep_work is on lunch if you'd like him to take a look.
17:08:54 <flo> I'll read the comments I wrote in the bug months ago to ensure I haven't missed anything
17:11:32 <clokep_work> OK!
17:24:34 --> Draighth has joined #instantbird
17:25:14 <-- Draighth has left #instantbird ()
17:26:44 <flo> hmm, now is a good time to get rid of all the rememberPassword left-overs, right? http://lxr.instantbird.org/instantbird/search?string=rememberpass
17:28:01 <clokep_work> Probably.
17:30:55 * Mic1 is curious how things will change with this.
17:31:15 <Mic1> Don't bother explaining, I'll see it soon enough, hopefully ;)
17:31:24 <flo> in a few seconds I think ;)
17:32:03 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1130 on bug 434.
17:32:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=434 enh, --, ---, florian, ASSI, Use toolkit password manager
17:39:13 <clokep_work> flo: Why are there always loops when dealing with getting/setting passwords in the login manager?
17:39:39 <clokep_work> Is it just how the API works, but we're only expecting one?
17:39:54 <clokep_work> (The results of LoginManager.findLogins()...)
17:39:55 <flo> because we query the password manager for an URL, and it returns a list of username/password for that URL
17:40:22 <flo> we are clearly abusing an API that isn't designed at all for our use case
17:40:36 <flo> I did it exactly like Thunderbird, for consistency
17:40:45 <clokep_work> Alright.
17:40:51 <clokep_work> Yeah that's what I thought it was doing.
17:41:04 <flo> I could have put the username in the url, but then it wouldn't be encrypted
17:43:14 <Mic1> Isn't the username displayed on the account manager anyways?
17:43:47 <flo> hmm, it's stored in plain text in the prefs anyway, yes
17:44:32 <Mic1> bbl
17:44:34 <flo> we would still have a loop though, because of the API. The only difference is it would then return a single result (almost?) all the time
17:44:55 <clokep_work> Got it. :)
17:45:32 <Mic1> Is it canceled or cancelled by the way?
17:45:50 <Mic1> I thought it was the latter.
17:46:32 <Mic1> Maybe I should have added quotes around the words ;)
17:46:35 <flo> my spellchecker dictionary has both
17:46:41 <-- MadWookiee has quit (Quit: Instantbird 1.1)
17:46:47 <Mic1> Ah, OK then :)
17:46:50 <Mic1> bye
17:46:52 <-- Mic1 has quit (Quit: Instantbird 1.2a1pre)
17:47:24 <clokep_work> conversion is spelled as convertion though.
17:47:27 --> Mook_as has joined #instantbird
17:48:13 --> Draighth has joined #instantbird
17:50:35 <clokep_work> flo: It looks good, I'll try it when I get home today.
17:55:53 --> Tomek has joined #instantbird
18:02:12 <-- flo has quit (Quit: Instantbird 1.2a1pre)
18:51:08 <-- igorko has quit (Ping timeout)
18:57:48 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre)
19:11:38 --> aleth has joined #instantbird
19:24:58 --> igorko has joined #instantbird
19:31:04 --> Mic has joined #instantbird
19:31:04 * ChanServ sets mode +h Mic 
19:33:32 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
19:33:39 --> Mic has joined #instantbird
19:33:39 * ChanServ sets mode +h Mic 
19:37:18 <-- Tonnes has quit (Ping timeout)
19:38:48 --> gerard-majax has joined #instantbird
20:04:45 --> EionRobb has joined #instantbird
20:31:22 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
20:36:21 --> flo has joined #instantbird
20:36:21 * ChanServ sets mode +qo flo flo 
20:36:43 <Mic> "21:31:21 - igorko left the room (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)." :O
20:36:52 <Mic> I think we need to talk with him :P
20:39:00 <EionRobb> lol
20:39:30 <flo> Mic: isn't he our Ukrainian translator?
20:40:17 <Mic> Yes
20:44:42 <-- gerard-majax has quit (Ping timeout)
20:48:27 * clokep_work /bans igorko. ;)
20:49:28 <aleth> Or he should explain what he means by "smaller, faster, easier" ;)
20:49:44 <clokep_work> It's probably the default quit message.
20:49:52 <aleth> I kno
20:50:18 <EionRobb> we must extract a confession!  put him in.... the comfy chair!!!
20:57:00 <flo> I can understand "smaller"
20:57:05 <flo> faster, maybe
20:57:13 <flo> but easier... :-S
20:57:19 <Mook_as> I think they were comparing against things like ICQ2000 :p
20:57:59 <flo> Mook_as: last time I tried to use Miranda (just to see how it was), I haven't even managed to connect an AIM account, after several minutes of effort
20:58:06 <Mook_as> that, and msn messenger, were overly-graphical IM clients of the time
20:58:40 <Mook_as> huh, it worked fine for me when I tried it, IIRC, back at songbird... it's been a few years though :p
21:10:37 <clokep_work> flo: Are we (or Mozilla people) planning to integrate the changes to http.jsm and oauth.jsm back into Instantbird?
21:11:19 <flo> it sounds like something we will want to do
21:11:35 * flo wonders if he's in the "Mozilla people" category or not
21:13:49 <instantbot> New Instantbird (UI) bug 1243 filed by aletheia2@fastmail.fm.
21:13:50 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1131 on bug 1243.
21:13:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1243 nor, --, 1.2, nobody, NEW, Only show progress bar when necessary
21:15:26 <clokep_work> flo: No. I meant bienvenu? I think he's the one working on that bug.
21:15:39 <flo> he is no longer alone ;)
21:17:01 <clokep_work> Ah-ha.
21:18:43 <Mic> bye
21:18:47 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
21:19:00 <flo> I don't think the changes made in these files are big
21:19:06 <flo> but we'll need to check :)
21:19:24 <clokep_work> I'm a little scared they're using http.jsm. :-X I feel like that file needed a bit of work still. ;)
21:19:33 <clokep_work> The oauth changes are big in that...we should abstract it out of Twitter.
21:21:18 <flo> I'm not sure of how we can merge back though
21:21:50 <flo> as mail/ and mailnews/ probably won't want to include anything from chat/, and chat/ can't include something from mail/ or mailnews/
21:22:27 <Mook_as> <unrealistic>push it into m-c?
21:23:06 <flo> Mook_as: I agree with the first word of that sentence ;)
21:26:04 <clokep_work> flo: It could be worth suggesting...or at least keeping it in sync.
21:26:19 <clokep_work> (We probably want to abstract it anyway, so we can potentially support Facebook/Microsoft's auths.)
21:26:29 <flo> dropbox ;)
21:26:40 <clokep_work> Right. :)
21:28:29 <clokep_work> We could import comm-central instead of mozilla-central? :P
21:29:10 <Mook_as> there's also the option of using a subrepo from both sides, I guess
21:30:57 <flo> clokep_work: I think there's a plan to make comm-central a branch of mozilla-central at some point to simplify the build system, so the instantbird repo could become a branch of comm-central
21:31:17 <flo> this way we wouldn't import anything. Just merge updates from time to time.
21:31:29 <clokep_work> That would work well. :)
21:31:39 <clokep_work> But time to go home(ish)!
21:31:52 <-- clokep_work has quit (Quit: Instantbird FTW!)
21:32:17 <flo> it would become long to clone our repository, otherwise it would be easier :)
22:09:55 <flo> Good night
22:09:57 <-- flo has quit (Quit: Instantbird 1.2a1pre)
22:29:36 --> jb1 has joined #instantbird
22:30:08 <-- jb has quit (Ping timeout)
22:36:43 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1132 on bug 1016.
22:36:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1016 nor, --, 1.2, aletheia2, ASSI, Quit warning is hidden when conversation window lacks focus
22:55:37 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1132 on bug 1016.
22:55:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1016 nor, --, 1.2, aletheia2, ASSI, Quit warning is hidden when conversation window lacks focus
22:56:02 <aleth> Since flo's review queue is already so long ;)
23:03:34 <-- jb1 has quit (Ping timeout)
23:07:58 --> clokep has joined #instantbird
23:07:58 * ChanServ sets mode +h clokep 
23:12:24 * clokep thinks aleth likes papercuts. ;)
23:13:13 <aleth> It's more that I initially reported a long long list of them and now I kind of feel responsible for tidying them up ;)
23:14:14 <clokep> :)
23:14:37 <clokep> We're really sorry it takes so long to review all of these by the way. :-/
23:14:48 <clokep> (Although some of it is that you pick bugs with ill defined behavior. :P)
23:15:31 <aleth> Oh well, reviewing takes time.... so does discussing about what should be done :P
23:15:41 <clokep> :)
23:15:46 <clokep> I'll try to get to that review after I make dinner.
23:15:56 <clokep> (And eat it...)
23:15:56 <aleth> It should be an easy one ;)
23:16:40 <clokep> Oh that is easy hahah.
23:20:19 <instantbot> clokep@gmail.com granted review for attachment 1132 on bug 1016.
23:20:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1016 nor, --, 1.2, aletheia2, ASSI, Quit warning is hidden when conversation window lacks focus
23:20:26 <-- Draighth has quit (Quit: Leaving.)
23:20:54 <aleth> aaand that was quick :D
23:22:20 <clokep> Yes, I take my apology back.
23:22:37 <aleth> lol
23:32:54 <aleth> I suspect long discussions are the drawback of tackling UI 'bugs'... not that it doesn't often improve the end result
23:33:35 <aleth> in fact s/often/usually
23:34:31 <clokep> Yes.
23:34:37 <clokep> That's why I don't deal with the UI. :)
23:34:39 <clokep> And cause I hate CSS.
23:35:56 <aleth> Can't say I disagree about CSS from what I've seen...
23:36:35 <aleth> Anyway, some other things I wouldn't mind looking at kind of depend on JS-IRC ;)
23:37:47 <aleth> Mainly because I'm not really keen on delving into libpurple
23:39:17 <clokep> What's that?
23:39:29 <clokep> (What bug is it?)
23:39:58 <aleth> Well, overhauling 'join chat' for example...
23:40:57 <aleth> Just an example of course, I don't have any definite ideas
23:41:13 <aleth> just annoyances ;)
23:41:29 <clokep> Ah.
23:41:40 <clokep> You've seen the thing about being able to open a blank tab, right?
23:42:25 <aleth> Yes. It's a good idea but hard to get right. I haven't seen it implemented well yet in any browser for example
23:42:50 <aleth> (but maybe that's just me)
23:43:08 <clokep> You don't find Firefox's awesomebar to be awesome?
23:43:09 * clokep does.
23:43:27 <clokep> Anyway, that doesn't really require JS-IRC, it all deals with the prplIChatRoomFields.
23:43:30 <aleth> Oh, I couldn't live without it :D
23:44:01 <aleth> I thought you meant a non-blank about:blank new tab page
23:45:44 <aleth> it's true, some kind of awesomebarish memory of previously opened chats would go a long way
23:46:03 <clokep> Yeah, that's what has been discussed previously.
23:46:18 <clokep> And that /shouldn't/ really depend on JS-IRC. :)
23:46:45 <aleth> Yeah, bug 500
23:46:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=500 enh, --, ---, nobody, NEW, Autocomplete / drop down for chat rooms in Join Chat menu
23:47:42 * aleth just spotted your awesomebar comment ther
23:48:04 <clokep> Hah I filed that. :)
23:49:23 <clokep> I'd love for someone to look at that though. :)
23:49:42 <clokep> The part that would "involve" JS-IRC is probably implementing the list command...although libpurple has it too...
23:50:05 <aleth> I dimly remember someone saying the libpurple version of list was not ideal
23:50:36 <aleth> But it needs a good design and I certainly haven't come up with one yet
23:50:58 <aleth> (it-> the join chat box)
23:51:17 <Mook_as> could look at the chatzilla one for inspiration (though possibly not take it as-is)
23:51:43 <clokep> I think someone had a mock up of the idea at some point...
23:52:30 * clokep gueses Mic.
23:55:05 <clokep> (Not what I'm looking for...but awesome: https://wiki.instantbird.org/File:InlinePlayer.png)
23:56:09 <aleth> heh :D
23:56:47 <Mook_as> <video src="(linux iso)"> it is! :p
23:56:51 <clokep> Can't find it...
23:57:43 <clokep> aleth: I would suggest making some wireframe mock ups.
23:57:48 <clokep> And then we can give feedback on it.
23:57:54 <clokep> It'd be awesome if you could implement that. :)
23:58:21 <aleth> Mook_as: oh yea, the video tag :P