All times are UTC.
00:17:05 <-- go8765 has quit (Ping timeout) 00:19:26 --> go8765 has joined #instantbird 00:29:25 <-- chrisccoulson has quit (Quit: Ex-Chat) 01:01:54 <-- go8765 has quit (Quit: Konversation terminated!) 01:01:55 --> go8765 has joined #instantbird 01:34:40 <-- go8765 has quit (Quit: Instantbird 1.1) 01:58:41 --> Mook has joined #instantbird 02:50:25 <-- Tomek has quit (Quit: Instantbird 1.1) 02:52:46 <instant-buildbot> build #357 of macosx-nightly-default started, including [] 02:52:46 <instant-buildbot> build #449 of win32-nightly-default started, including [] 02:52:47 <instant-buildbot> build #366 of linux-nightly-default started, including [] 03:11:53 --> EionRobb has joined #instantbird 03:21:49 <instant-buildbot> build #366 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/366 03:27:44 <instant-buildbot> build #449 of win32-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/449 03:41:27 <-- EionRobb has quit (Connection reset by peer) 03:41:52 --> EionRobb has joined #instantbird 03:44:00 <-- Mautematico has quit (Client exited) 03:45:24 <-- EionRobb has quit (Connection reset by peer) 04:38:42 --> Mautematico has joined #instantbird 04:55:09 <-- micahg has quit (Ping timeout) 04:55:28 <-- Mautematico has quit (Ping timeout) 06:22:52 --> clokep has joined #instantbird 06:22:52 * ChanServ sets mode +h clokep 06:33:57 <-- clokep has quit (Quit: Instantbird 1.2a1pre) 06:34:44 <instant-buildbot> build #357 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/357 07:27:19 <-- DGMurdockIII has quit (Quit: get satisfied!  :: core-networks.de ««« (Gamers.IRC) »»» gamersirc.net ::) 08:50:48 --> Tomek has joined #instantbird 09:59:09 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603]) 10:42:30 --> chrisccoulson has joined #instantbird 10:45:16 --> tymerkaev has joined #instantbird 10:45:16 <-- tymerkaev has quit (Quit: Be back later) 10:53:40 <-- chrisccoulson has quit (Ping timeout) 11:32:27 <-- Tomek has quit (Ping timeout) 11:34:04 --> Tomek has joined #instantbird 12:32:48 --> Mic has joined #instantbird 12:32:48 * ChanServ sets mode +h Mic 13:09:05 <-- Mic has quit (Quit: Instantbird 1.2a1pre) 13:49:29 --> clokep has joined #instantbird 13:49:30 * ChanServ sets mode +h clokep 14:19:43 <-- clokep has quit (Ping timeout) 14:19:58 --> clokep has joined #instantbird 14:19:58 * ChanServ sets mode +h clokep 14:48:04 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1120 on bug 1178. 14:48:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1178 nor, --, ---, clokep, ASSI, Regression: renamed contacts disappear from list 14:49:27 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 14:49:37 --> aleth has joined #instantbird 15:01:54 <flo> yesterday I tried adding a CSS transition for when the textbox is automatically resized (the current jump is a bit ugly, especially when resizing the window). I haven't managed to get it to work in a reasonably short time so I gave up, but just in case anybody is interested in taking it over: http://pastebin.instantbird.com/8728 15:02:49 <clokep> Is that something we should file a bug on and attach? 15:03:09 <flo> maybe 15:03:18 <flo> if someone is interested in working on it I guess 15:03:44 <clokep> Right. :) 15:04:13 <flo> with that patch there's some kind of animation, but it doesn't fully work and the error console is spammed with "error in parsing CSS value for 'height'" messages. 15:04:31 <flo> also, the transition should obviously not last 2s, that was just to have something very visible for testing :) 15:05:24 <clokep> :) Easier to see while testing is very nice. 15:06:00 <flo> bug 1178 seems painful 15:06:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1178 nor, --, ---, clokep, ASSI, Regression: renamed contacts disappear from list 15:06:34 <clokep> flo: Yes! Did I explain the issue well enough? 15:06:55 <flo> clokep: probably well enough for someone who has read or is willing to read the related code 15:07:09 <clokep> OK. :) My understanding of how it all interacts isn't perfect either. :) 15:07:30 <flo> that is, the patch don't include enough context to understand your comments, but I'm afraid the amount of context needed to really understand is the whole file :-/ 15:07:50 <flo> clokep: that's the problem I think. When we can't fully understand how things work, we keep breaking them 15:08:17 <flo> sorting and reordering on the fly is difficult to get right. That's why I've avoided it for a long time ;) 15:09:04 <clokep> Haha. :) Well I have an extension for bug 701...which is blocked by bug 1178 and bug 1235 15:09:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=701 enh, --, ---, nobody, NEW, Sort buddies by status 15:09:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1178 nor, --, ---, clokep, ASSI, Regression: renamed contacts disappear from list 15:09:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1235 min, --, ---, clokep, ASSI, sortComparator is sometimes called with the contact element instead of the contact object 15:09:56 <-- clokep has left #instantbird () 15:09:59 --> clokep has joined #instantbird 15:09:59 * ChanServ sets mode +h clokep 15:10:16 <clokep> Bleh that message broke auto-link. :-/ 15:11:01 <flo> ah, I was wondering which add-on you were cooking :) 15:12:12 <clokep> It wasn't too bad to do! Be a lot easier if XBL could call it's super's methods. 15:12:28 <clokep> Or __proto__'s method in JS speak I guess. :P 15:13:22 <flo> I'm not sure why you need to mess with XBL for that 15:14:29 <clokep> I need to change the sortComparator function. 15:14:54 <clokep> I could override it whenever a new group is created, but that seemed annoying, so I'm inheriting the full group binding and replacing it. 15:15:14 <flo> so you can still call all other methods of the original group binding, can't you? 15:15:26 <clokep> Yes, but not when you override them: http://pastebin.instantbird.com/8729 15:15:33 <clokep> The issue is I needed to extend the observer. 15:16:03 <flo> ah 15:16:24 <flo> hmm, should we somehow add an extensibility hook there? 15:16:53 <clokep> I'm wondering if we should (call a list of observers?) 15:27:11 <instantbot> florian@instantbird.org granted review for attachment 1108 on bug 1225. 15:27:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1225 min, --, ---, nobody, ASSI, Support pymake (port mozbug 714178) 15:33:52 <flo> clokep: maybe we should do that for the second add-on that could benefit from it? 15:34:08 <flo> (as it seems your add-on is already done and works) 15:34:25 <clokep> I need to test it a bit more, but I think it's pretty much done. 15:43:16 <clokep> flo: Apparently I had solved this issue once before: https://bugzilla.mozilla.org/show_bug.cgi?id=373652#c7 15:44:19 <flo> nice :) 15:44:33 * clokep CCs himself to that bug. 15:44:43 <instantbot> florian@instantbird.org granted review for attachment 1111 on bug 1223. 15:44:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1223 nor, --, ---, nobody, NEW, Update XUL from 9.0b2 to 9.0.1 15:50:06 <flo> clokep: re bug 683, have you tested the different error situations? 15:50:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=683 enh, --, ---, clokep, ASSI, Handle deleted messages on twitter 15:50:29 <clokep> flo: I tested trying to delete a tweet I don't own. 15:50:38 <clokep> (Or a tweet you already deleted.) 15:51:24 <flo> and is that calling onDestroyCallback which throws, or going directly to onDestroyErrorCallback because of a non-200 HTTP result code? 15:52:06 <flo> ah, maybe _parseError accepts both JSON data and an exception object? 15:52:22 <clokep> It calls the onDestroyCallback. 15:52:35 <clokep> It isn't a non-200 result code. 15:52:42 <clokep> I get an actual JSON result back with an error property. 15:54:47 <flo> ok... can I just commit it without testing then? :) 15:56:07 <clokep> All the error code is stolen from one of the other actions we have for Twitter if that makes oyu feel better about it. :) 15:56:18 <clokep> I tested it a lot of times...didn't have any issues. :-D 15:56:43 <flo> I don't feel good about the error reporting in most of these methods ;) 15:57:09 <flo> I just tweaked them until it seemed to work in all cases I could test 15:58:34 <clokep> That's mostly what I did too. :-? 15:58:36 <clokep> :-S 15:58:57 <clokep> Which I'm sure my Twitter followers didn't appreciate btw. ;) 15:59:52 <flo> I guess the cause of the problem is that I'm not sure of what to expect from the twitter servers in error situations. We seem to usually get JSON objects containing the error, but also sometimes plain text, and more rarely HTML pages (I think it's in the overcapacity case) 16:01:30 <instantbot> florian@instantbird.org granted review for attachment 1113 on bug 683. 16:01:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=683 enh, --, ---, clokep, ASSI, Handle deleted messages on twitter 16:02:17 <clokep> Yes, there error handling situations is pretty atrocious. 16:02:33 <clokep> Did you get that email from sonny about the Facebook XMPP developers group by the way? 16:03:23 <flo> yes 16:03:38 <flo> you also received it? :) 16:04:20 <clokep> Yeah, he pinged me in their XMPP chat about it first, I asked him to forward it to me. 16:04:42 <clokep> I haven't heard back about it yet, but I assume the employee isn't working on the weekend. :) 16:06:26 <flo> have you just clicked the button on the page, or actually emailed them? 16:06:34 <clokep> Both. 16:09:04 <flo> how do you feel about the patch in bug 1213? 16:09:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1213 enh, --, ---, clokep, ASSI, Twitter should always have a topic (based on your last sent tweet) 16:09:23 * clokep looks. 16:10:16 <clokep> I like it, I think it's more elegant than the previous way of doing it. 16:10:28 <clokep> It /does/ increaseour usage of the API, but we're using it very little right now anyway. 16:10:36 <clokep> (The REST api, that is.) 16:11:20 <flo> do we really want to include retweets? 16:11:30 <flo> currently, are we displaying the latest RT as the topic, 16:11:30 <flo> ? 16:12:35 <clokep> I believe we would. 16:12:38 <flo> it seems to be fetching 20 tweets to display only one. Maybe you wanted to add count=1 ? 16:12:52 <clokep> flo: No the API is dumb.. 16:13:01 <clokep> It's 20 tweets...then they take away ones you've deleted. 16:13:06 <clokep> (And other situations?) 16:13:08 <flo> why does it need to delay the display of timelines when it doesn't contain any message that we are going to display there? 16:13:39 <clokep> It doesn't really need too, I was just setting it up the same way that we got all the other timelines. 16:13:56 <flo> uh? So if you have deleted your latest tweet and request user_timeline.json with count=1, they return an empty result?? 16:14:03 <clokep> Yes. 16:14:09 <clokep> That's my understanding of the documentation at least. 16:14:20 <flo> have you actually tried it? 16:14:31 <clokep> The patch or setting the count to 1? 16:14:59 <flo> "We include retweets in the count, even if include_rts is not supplied." 16:15:06 <flo> wow, they are morons... 16:15:37 <clokep> I agree. :-/ I think some of the other API we use also say that, but we provide the icnlude_rts parameters to those too. 16:16:30 <flo> we don't provide count, but instead "since_id", so that doesn't really matter I think 16:17:01 <clokep> OK. 16:25:11 <clokep> flo: I think I like http://pastebin.instantbird.com/8737 better for bug 1178 (my patch in there doesn't work right now, btw. I called a method with a wrong parameter. :() 16:25:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1178 nor, --, ---, clokep, ASSI, Regression: renamed contacts disappear from list 16:25:27 <clokep> Oops, http://pastebin.instantbird.com/8738 is a better pastebin 16:25:51 <instantbot> florian@instantbird.org denied review for attachment 1094 on bug 1213. 16:25:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1213 enh, --, ---, clokep, ASSI, Twitter should always have a topic (based on your last sent tweet) 16:26:22 <flo> clokep: is this removing the contact node immediately? 16:26:37 <clokep> You mean in terms of the animation? 16:26:58 <flo> if so, it breaks CSS the carefully crafted animation showed when contacts are reordered 16:27:01 <clokep> Yeah, it looks a little funky. :-/ 16:27:11 <clokep> Yeah, it does. 16:27:18 <clokep> Bah, I hate this bug already. 16:27:19 <flo> (* "CSS" isn't at the right place in that sentence) 16:27:33 <flo> clokep: now you understand why I avoided it :) 16:27:37 <clokep> http://pastebin.instantbird.com/8739 is what I have for reordering now though. :) 16:29:07 <flo> only 8 lines of code and the rest is XBL junk 16:29:40 <clokep> Yup! :) 16:30:19 <flo> :) 16:35:44 <clokep> All those review comments are fine by the way. I'll look at it again soon. :) 16:36:53 <flo> as you like. I'm not super excited by the change in that bug, so I'm not too worried if it collects some dust. But if you do care about it, don't let my lack of enthusiasm block you :) 16:37:51 <clokep> It annoys me when my timelines pop up without a tweet as a topic. :P 16:38:25 <clokep> But it doesn't excite me a huge deal either. ;) 16:38:52 <flo> aleth: ping 16:39:50 <flo> I'm trying to review the patch in bug 1209, so I more or less have to understand the code of scrollToPreviousSection/scrollToNextSection which at the time I r+ed without understanding (I only tested it). 16:39:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1209 nor, --, ---, nobody, NEW, Make section scroll symmetric 16:40:37 <aleth> hi flo 16:40:54 <clokep> Thanks for doing these reviews btw flo. :) 16:41:07 <flo> aleth: are you sure offsetTop does what you want? 16:42:11 <aleth> It should, unless there is some nesting I don't know about 16:42:37 <aleth> It seems to work, anyway 16:42:54 <flo> what happens if the message theme has a CSS that includes some margin for #Chat ? 16:45:14 <aleth> That sounds like it might cause problems... is there a better alternative? 16:45:23 <flo> that's what I'm looking for 16:45:53 <flo> and I'm getting annoyed by how difficult it is to find anything in MDN (if you don't already know the exact name of the API you want) and by the lack of JS debugger (again) 16:46:02 <aleth> Yes :( 16:46:30 <aleth> You find a method "by accident" and hope it is the best one 16:52:16 <flo> hmm, so it's not on the parent but on the nearest "positioned" containing element (https://developer.mozilla.org/en/OffsetParent) 16:52:29 <flo> so a margin-top on #Chat wouldn't change anything 16:52:46 <flo> but #Chat { position: absolute; top: 100px; } would probably be an issue :-/ 16:54:00 <flo> would .getBoundingClientRect().top work? 16:54:42 <aleth> that's an idea. 16:55:18 <flo> pff, this is all too complicated 16:55:28 <flo> let's ignore the issue until it actually breaks something :) 16:55:59 <aleth> Hmm, I didn't understand "positioned" that way at the time... that's good to know. 16:56:52 <aleth> I thought it simply meant "with a position, ie. displayed, ie not hidden etc" 16:58:02 <aleth> .getBoundingClientRect().top won't work because it is relative to the scroll position 16:58:31 <aleth> .getBoundingClientRect().top + ...scrollY would, I suppose 16:59:02 <aleth> Ok, lets ignore it for now :) 17:01:47 <flo> another way would bet getComputedStyle and then look at the value for "top" 17:01:57 <flo> *be 17:08:16 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1120 on bug 1178. 17:08:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1178 nor, --, ---, clokep, ASSI, Regression: renamed contacts disappear from list 17:08:40 <flo> aleth: can't "nonContextY - Math.round(this.clientHeight / 2)" be negative? 17:08:59 <flo> aleth: or do we just don't care because scrollTo will convert that to 0? 17:10:48 <aleth> If it's negative, scrollY won't be smaller than it 17:13:03 <flo> right :) 17:14:11 <instantbot> florian@instantbird.org granted review for attachment 1086 on bug 1209. 17:14:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1209 nor, --, ---, nobody, NEW, Make section scroll symmetric 17:21:20 <clokep> Looks like the next nightly is going to have a few new things to play w/. :) 17:27:42 <flo> possibly :) 17:41:04 <flo> aleth: http://pastebin.instantbird.com/8746 how does this feel? 17:42:14 <flo> very often when I scroll to the first non-context message on IRC, what I end up with in the middle of the window is a block of context system messages and a block of non-context system messages, and so the first interesting message bubble is not centered at all 17:42:29 <aleth> I like it, but people who think system messages are more important might not 17:43:13 <aleth> Personally I would prefer it that way I think 17:44:05 <clokep> FWIW I like that better as well. 17:45:47 <flo> this._lastMessageIsContext doesn't seem needed any more if we do that 17:46:33 <flo> hmm, or maybe it is, I don't know :-S 17:48:27 <flo> so it seems I should commit this if everybody likes it better :) 18:02:33 <clokep> flo: I was just approved to be in the XMPP group. 18:02:55 <flo> cool :) 18:02:59 <flo> facebook works on sunday :) 18:03:50 <clokep> I'm surprised too, tomorrow is (kind of?) a US holiday. 18:04:04 <clokep> I'm off at least...I know some others are too. 18:04:23 <clokep> Ah, EionRobb was approved at the same time. ;) 19:20:25 --> Mnyromyr has joined #instantbird 19:39:25 --> EionRobb has joined #instantbird 19:47:51 --> DGMurdockIII has joined #instantbird 20:07:01 --> Guido has joined #instantbird 20:14:36 --> chrisccoulson has joined #instantbird 20:27:56 <instantbot> New Instantbird (UI) bug 1236 filed by aletheia2@fastmail.fm. 20:27:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1236 nor, --, ---, nobody, NEW, JSON log viewer conversation bubbles all have the same colour 20:30:52 <flo> aleth: I don't understand that bug 20:31:28 <flo> errr, now I do :) 20:31:32 <aleth> Umm.... 'show log' for a normal conversation, and notice the messages are all the same colour? 20:31:51 <flo> the problem is libpurple giving the name of the contact we are talking to as "who" for IM conversations on almost all protocols 20:31:57 <flo> your bug can't be reproduced with JS-XMPP for example 20:32:19 <aleth> thank you, libpurple 20:32:51 <clokep> Are we not saving enough information then? 20:35:33 <flo> clokep: we save both "who" and the "alias" 20:35:42 <flo> "who" is wrong for libpurple IM conversations 20:35:57 <clokep> Ah. 20:36:15 <flo> so we could either fix that broken the libpurple function 20:36:52 <flo> or save the fact that a conversation is an IM conversation, and then rely only on the flags incoming/outgoing, so that we don't compute colors at all and redisplay exactly like when the conversation happened 20:36:55 <flo> or both :) 20:37:24 <aleth> using the flags would be consistent with the normal display 20:37:44 <flo> to do that we need to save the "isChat" value of the prplIConversation instance. 20:37:47 <aleth> (not that I am a fan of the adium incoming/outgoing thing) 20:42:41 --> ecaron has joined #instantbird 21:00:44 <aleth> I wonder if it might not be simpler to drop support for message style color variants and add a Default Incoming/Outgoing Color to Prefs/Content instead 21:01:42 <flo> simpler than what? 21:01:59 <aleth> The current variant system 21:02:35 <clokep> It'd be nice if they could actually have options instead of just variants. :) 21:02:43 <aleth> Yes :) 21:03:19 <aleth> It gets ridiculous when you see a long list of "x and y color - with/without avatars - large/small" 21:04:24 <aleth> Problem is, how do you transition... 21:05:08 <aleth> Message styles could come with inline options just like other add-ons, and be restartless 21:05:30 <flo> sounds to me like a lot of work, not simpler ;) 21:06:00 <aleth> Yep, simpler only afterwards ;) 21:06:56 <aleth> Anyway, you'd still have to save 'isChat' for the bug above... probably not a bad idea anyway for the future 21:11:34 <flo> fixing libpurple so that we don't save crap also sounds like something we should do ;) 21:19:21 <-- Guido has quit (Quit: Instantbird 1.1) 21:19:41 <flo> how does this feel? http://pastebin.instantbird.com/8772 21:22:51 <-- Suiseiseki has quit (Ping timeout) 21:23:17 <EionRobb> that's making an assumption that user ids are matched case insenstivly? 21:24:02 <clokep> Are you having an issue with the case? 21:24:28 <flo> yes, a channel I auto-join has changed in case. 21:25:12 <flo> it seems IRC channel names are case insensitive (when entering), but the channel has the case used by whoever entered first 21:26:25 <EionRobb> I was going to suggest you use the prpl_info->normalize() function, but I don't know if that extends to chat names 21:27:38 <clokep> Yeah they're case insensitive. I'm OK w/ that change though. 21:27:49 <clokep> Want to review / check-in bug 1215 at the same time? :) 21:27:49 <flo> it's just an add-on anyway :) 21:27:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1215 nor, --, ---, clokep, ASSI, Hide Auto-Joins broken for twitter 21:28:01 <flo> already done 21:28:06 <clokep> Awesome. :) 21:28:09 <flo> (the local commit) 21:28:31 <clokep> r=me on http://pastebin.instantbird.com/8772 if you'd like to share blame then. ;) 21:28:52 <flo> I'm listed as the author of that add-on anyway ;) 21:29:10 <flo> someday (soon) I'd like to make nickservkiller also silence out chanserv messages 21:29:37 <flo> I'm tired of seeing a chanserv tab each time I auto-join #frenchmoz 21:31:18 <-- ecaron has quit (Quit: Instantbird 1.1) 21:32:29 <clokep> Why's a chanserv tab come up? 21:32:43 <flo> because the channel is configured to have a welcome notice message 21:32:46 <EionRobb> just block chanserv ;) 21:33:04 <flo> I would like to have that message appear in the channel's tab, not a separate tab 21:33:59 <clokep> Ah, I see. 21:34:31 <clokep> Land JS-IRC and ask me nicely to make something to handle chanserv/nickserv? ;) 21:40:23 <flo> I would really like to know what's causing "components/logger.js, line 184: reference to undefined property aMessage[f]" 21:41:27 <flo> hmm, how will AIO handle it if I upload a new version of hide auto-joins that isn't compatible with the current release? :-S 21:43:45 <clokep> If the version numbers aren't there I don't think it'll let you upload it. 21:44:27 <aleth> clokep: I think his worry is, will 1.1 users still get the old version 21:44:52 <clokep> Probably not. 21:45:11 <flo> aleth: exactly! 21:45:39 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/1a4bc154d904 - Patrick Cloke - Bug 683 - Handle deleting messages on twitter, r=fqueze. 21:45:41 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4cd386fc148b - Florian Quèze - Add a way to build a Log from an nsIFile (useful for indexing logs by crawling the logs directory). 21:45:42 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/118139b13a08 - Florian Quèze - Avoid redefining errno constants which are already defined with MSVC10. 21:45:43 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a223d9bb1680 - Florian Quèze - Ensure scrolling to the previous section always centers a non system message. 21:45:44 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f569db453da4 - aleth - Bug 1209 - Make section scroll symmetric, r=fqueze. 21:45:45 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7c895c7b278c - Patrick Cloke - Bug 1225 - Define CPP in the build system for pymake support (port Mozilla bug 714178), r=fqueze. 21:45:46 <instant-buildbot> build #208 of linux-onCommit started, including [4cd386fc148b1c3a65dbdbe92470d55a35f58bc6, ef130d733809ff2cdb30b9712ca540deb3f03085, 118139b13a08156733a5b886500ced075ecb9c5e, 7c895c7b278c48d9e34ac1f6eea4677f3210ba3a, 734f05f0a6eb5075137ae619850744265ac1324f, 1a4bc154d904af0fba3f4cd5b8c876ad722150ce, f569db453da425be7191e04e1eada0e87484b5ab, 21:45:46 <instant-buildbot> a223d9bb168021658302699add38e6be3a7f4724] 21:45:47 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ef130d733809 - Florian Quèze - Return early instead of throwing when attempting to initialize the imCore several times (this simplifies some code for Thunderbird). 21:45:48 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/734f05f0a6eb - Quentin Raynaud - Bug 1223 - Update XUL from 9.0b2 to 9.0.1 - also pull the localized string from the release repositories, r=fqueze. 21:45:48 <instant-buildbot> build #177 of macosx-onCommit started, including [4cd386fc148b1c3a65dbdbe92470d55a35f58bc6, ef130d733809ff2cdb30b9712ca540deb3f03085, 118139b13a08156733a5b886500ced075ecb9c5e, 7c895c7b278c48d9e34ac1f6eea4677f3210ba3a, 734f05f0a6eb5075137ae619850744265ac1324f, 1a4bc154d904af0fba3f4cd5b8c876ad722150ce, f569db453da425be7191e04e1eada0e87484b5ab, 21:45:54 <instant-buildbot> a223d9bb168021658302699add38e6be3a7f4724] 21:46:00 <instant-buildbot> build #198 of win32-onCommit started, including [4cd386fc148b1c3a65dbdbe92470d55a35f58bc6, ef130d733809ff2cdb30b9712ca540deb3f03085, 118139b13a08156733a5b886500ced075ecb9c5e, 7c895c7b278c48d9e34ac1f6eea4677f3210ba3a, 734f05f0a6eb5075137ae619850744265ac1324f, 1a4bc154d904af0fba3f4cd5b8c876ad722150ce, f569db453da425be7191e04e1eada0e87484b5ab, 21:46:05 <instant-buildbot> a223d9bb168021658302699add38e6be3a7f4724] 21:50:23 <instantbot> clokep@gmail.com set the Resolution field on bug 1223 to FIXED. 21:50:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1223 nor, --, 1.2, raynaudquentin, RESO FIXED, Update XUL from 9.0b2 to 9.0.1 21:51:24 <instantbot> clokep@gmail.com set the Resolution field on bug 1209 to FIXED. 21:51:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1209 nor, --, 1.2, aletheia2, RESO FIXED, Make section scroll symmetric 21:52:25 <instantbot> clokep@gmail.com set the Resolution field on bug 1225 to FIXED. 21:52:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1225 min, --, 1.2, clokep, RESO FIXED, Support pymake (port mozbug 714178) 21:55:27 <instantbot> clokep@gmail.com set the Resolution field on bug 683 to FIXED. 21:55:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=683 enh, --, 1.2, clokep, RESO FIXED, Handle deleting messages on twitter 21:55:48 <instantbot> New purplexpcom - Twitter bug 1237 filed by clokep@gmail.com. 21:55:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1237 enh, --, ---, nobody, NEW, Handle deleted messages on twitter 21:57:47 <flo> hmm, so I'm typing something in French in Google Translate. Google detects it's some Italian and decides to translate it to French. Cool :-D 21:58:19 <instant-buildbot> build #208 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/208 21:58:29 <clokep> I've been a fan of Bing Translate actually. 21:58:45 <flo> clokep: for bug 1237, maybe we could strike through the deleted messages? 21:58:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1237 enh, --, ---, nobody, NEW, Handle deleted messages on twitter 21:59:13 <flo> obviously it would be better to find something that could work for all message themes at once :) 21:59:25 <clokep> flo: Well, we should probably add a "deleted" or "redacted" flag or something and then decide what we want to do for bubbles. 22:00:46 <flo> should we add "edit" in the context menu, that would paste in the input box the text of the original tweet, and then automatically delete the edited tweet when sending the new version? 22:00:52 <flo> (or maybe that's for an add-on) 22:01:31 <clokep> Sounds more like an add-on, but could be neat. 22:03:09 <aleth> flo: that is odd, must be line 189, but why? 22:03:47 <aleth> hey, buildbot looks nice these days :) 22:04:09 <flo> aleth: my guess is that jsProtoHelper misses one of these flags 22:04:21 <flo> but last time I checked they seemed to be all there 22:04:24 <flo> so probably a typo... 22:04:43 <clokep> Which file is this? 22:05:01 <flo> they are at http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#375 22:05:07 <flo> clokep: http://lxr.instantbird.org/instantbird/source/chat/components/src/logger.js#186 22:05:59 <clokep> flo: It's whispered. 22:06:25 <clokep> Not defined in jsProtoHelper. 22:06:58 <clokep> (What is a whispered message, anyway?) 22:07:00 <flo> ah, and the count is the same, because noLog isn't listed in logger.js as we obviously don't need to serialize these messages :) 22:07:28 <clokep> Yes. 22:07:58 <instant-buildbot> build #198 of win32-onCommit is complete: Failure [failed hg_1] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/198 blamelist: aleth <aletheia2@fastmail.fm>, Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com>, Quentin Raynaud <raynaudquentin@gmail.com> 22:08:22 <flo> it seems to be sending a private message to a participant of a chatroom, but with the message being displayed inside the chatroom rather than in the conversation 22:08:27 <flo> (sounds like a strange concept) 22:08:35 <aleth> bizarre 22:08:51 * clokep dislikes that concept. 22:08:52 --> Suiseiseki has joined #instantbird 22:09:22 <aleth> could be a legacy method of PM'ing? 22:09:26 <flo> only nullprpl seems to use it :-S 22:09:33 <flo> from what I remember it was used by the Yahoo prpl 22:10:03 <flo> the sametime prpl seems to implement it 22:10:22 <flo> http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/sametime/sametime.c#4828 lol 22:10:25 <clokep> Bleh. 22:10:43 <clokep> So by implements you mean it sends an IM? :P 22:11:04 <flo> hence the "lol" ;) 22:11:24 <flo> if it isn't used in any prpl we don't ship, we could maybe suggest it's removed for libpurple 3.0 22:11:25 <clokep> I feel like a lot of the prplIMessage flags aren't really handled in the UI, is that true? 22:11:38 <flo> feel like cleaning up? ;) 22:11:52 <clokep> Maybe. :) Do we have a bug on file? 22:12:07 <clokep> (I think that things like error and notification are good, but right now we don't style them.) 22:12:28 <clokep> Is a delayed message like an offline message? 22:12:36 <flo> error is inadvertently styled in bubbles :-D 22:12:52 <clokep> It shows up as black, which works well for it. :) 22:12:55 <flo> clokep: yes, it's supposed to be. (I don't think it really works correctly though) 22:13:06 <flo> we have a generic "redesign purpleIMessage interface" bug 22:13:07 <aleth> aren't these passed straight through to the mesage styles, who decide what to do with them? 22:13:33 * aleth should read before pressing rtn 22:14:05 <clokep> Not all of them are for formatting. 22:14:25 <flo> only the msn prpl uses noFormat (PURPLE_MESSAGE_RAW) 22:14:48 <flo> aleth: I don't think they are passed to message styles 22:16:46 <aleth> yeah, I just checked, only indirectly, e.g. containsNick -> action 22:17:31 <clokep> (o_O) containsNick makes messages bold, not an action... 22:19:50 <aleth> o yea, sorry 22:19:54 <aleth> my mistake 22:20:01 <aleth> I meant the right thing ;) 22:20:10 <clokep> Action isn't a flag, it's done by prefixing with "/me " which I don't really like personally. 22:20:42 <aleth> Yup. 22:20:59 <flo> listing all the things we "don't really like" about the message interface is discouraging ;) 22:21:04 <aleth> Certainly the styling of those in Bubbles could be better 22:21:14 <aleth> Hey, it's getting better all the time! ;) 22:21:25 <clokep> flo: I assume that you fixed the logger code and I don't need to give you a patch for that? ;) 22:21:39 <clokep> s/logger/jsProtoHelper/ 22:22:03 <flo> clokep: given that that flag is *never* used, I'm not sure if the fix is removing all instances, or adding it in jsProtoHelper 22:22:28 <clokep> Remove all instances. :) 22:23:12 <flo> aleth: well, the message interface isn't really getting better all the time. It's never been redesigned, and we keep adding more crap to it to accommodate new needs. 22:23:41 <aleth> Hence the ;) 22:25:35 <flo> http://pastebin.instantbird.com/8779 22:25:55 <clokep> flo: r+ 22:25:58 <flo> apparently http://lxr.instantbird.org/instantbird/source/tools/messagestyles/screenshot/preview.js#98 also missed that flag :-D 22:26:06 <clokep> (Considering I had just exported the same exact patch.) 22:27:14 <aleth> On the other hand, the adium compatibility means sometimes people convert their favourite style as they switch to IB... like the Ambiance message style recently 22:27:54 <flo> aleth: I'm not sure of what you are talking about 22:28:08 <flo> redesigning the prplIMessage interface has nothing to do with message themes 22:28:36 <flo> it's just the way protocol plugins exchange their messages with the UI (and the logger). 22:30:30 <aleth> I was in a different context (actions...) 22:30:35 <aleth> but yeah 22:34:33 <flo> clokep: re bug 1178, isn't it possible to just detect that the already existing contact is pending removal, and proceed as if it didn't exist? 22:34:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1178 nor, --, ---, clokep, ASSI, Regression: renamed contacts disappear from list 22:35:07 <clokep> flo: Probably. 22:35:17 <flo> (I haven't read carefully all your comments in the bug, so that may not be a good idea :)) 22:35:21 <clokep> Feel free to steal that bug if you have an idea. :) 22:35:31 <flo> nope, I'm avoiding that bug :) 22:35:33 <flo> :-D 22:35:47 <flo> well, I'll handle it if it's the last thing holding the release of course 22:36:06 <clokep> Right. 22:36:11 <clokep> I need to look at it again with a clearhead. 22:37:24 <clokep> I think we need to remove all references to the contact as soon as we attempt to remove the node, but let the transition finish and just disappear. 22:37:54 <flo> even after a few hours spent on it, the request queue doesn't seem to be getting any shorter: https://bugzilla.instantbird.org/request.cgi?action=queue&requester=&product=&type=all&requestee=&component=&group=type 22:38:35 <flo> is bug 1235 actually blocking your work? 22:38:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1235 min, --, ---, clokep, ASSI, sortComparator is sometimes called with the contact element instead of the contact object 22:38:57 <clokep> I can hack around it, but it's a pain. 22:39:13 <clokep> (I could also overwrite the method to the correct one. :P) 22:42:26 <instantbot> florian@instantbird.org granted review for attachment 1119 on bug 1235. 22:42:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1235 min, --, ---, clokep, ASSI, sortComparator is sometimes called with the contact element instead of the contact object 22:43:41 <flo> there you go :) 22:43:57 <clokep> Thanks flo! 22:44:32 <flo> thanks for working on all of this! :) 22:45:31 <instant-buildbot> build #209 of linux-onCommit started, including [c8bb92c8b50761e2cbd942460aa0c8f958d73f9d, 8cf5eb2a5ae647ed7eb0e106760acffef2051961] 22:45:32 <instant-buildbot> build #199 of win32-onCommit started, including [c8bb92c8b50761e2cbd942460aa0c8f958d73f9d, 8cf5eb2a5ae647ed7eb0e106760acffef2051961] 22:45:44 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8cf5eb2a5ae6 - Patrick Cloke - Bug 1235 - sortComparator is sometimes called with the contact element instead of the contact object, r=fqueze. 22:45:45 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c8bb92c8b507 - Florian Quèze - Remove the whispered prplIMessage attribute, as it wasn't used and caused a warning in logger.js (because jsProtoHelper didn't implement it), r=clokep. 22:49:49 <clokep> No problem. :) 22:49:52 <instant-buildbot> build #177 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/177 22:49:53 <instant-buildbot> build #178 of macosx-onCommit started, including [c8bb92c8b50761e2cbd942460aa0c8f958d73f9d, 8cf5eb2a5ae647ed7eb0e106760acffef2051961] 22:51:00 <flo> I'm down to less than 10 unread bugmail messages 22:51:12 <clokep> :) 22:51:15 <instantbot> clokep@gmail.com set the Resolution field on bug 1235 to FIXED. 22:51:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1235 min, --, 1.2, clokep, RESO FIXED, sortComparator is sometimes called with the contact element instead of the contact object 22:51:31 <instant-buildbot> build #209 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/209 22:51:38 <flo> there are still bug 1165 and bug 1165 that are getting old and haven't received any reply even though they seemed perfectly valid :-( 22:51:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1165 min, --, ---, nobody, UNCO, Accessibility: Add a title to the chat log document in the conversation window 22:52:41 <instant-buildbot> build #199 of win32-onCommit is complete: Failure [failed hg_1] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/199 blamelist: Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com> 22:52:43 <flo> * and I meant bug 1166 22:52:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1166 nor, --, ---, nobody, UNCO, Accessibility: status of the individual accounts in the accounts dialog is not available to the visu 22:53:26 <clokep> I'm always hesitant to respond to accessibility bugs as I know very little about it. :-/ 22:54:20 <flo> those 2 are quite easy to understand 22:58:19 <clokep> Alright. Maybe I'l llook at the in a bit. 22:58:29 <flo> but each time I open these bugs, I think "oh well, I should just do what he requests, that doesn't seem difficult. Hmm... or maybe I should rather do that later, hmm..." 22:59:25 <flo> the problem isn't really that we haven't fixed them though, it's rather that they are still unconfirmed and we haven't acknowledged at all that we appreciate these actionable bug reports... 23:02:07 <clokep> Yeah. 23:02:16 <clokep> I have a handful of mailing list emails I've been meaning to respond to. :-/ 23:14:00 <flo> Good evening/night/Holiday :) 23:14:09 <clokep> Good night! 23:14:09 <-- flo has quit (Quit: Instantbird 1.2a1pre) 23:28:42 <-- Tomek has quit (Ping timeout) 23:32:16 <clokep> Why'd the win32 nightly fail? Is that one we've seen before or? 23:39:28 --> Tomek has joined #instantbird 23:47:04 <-- Tomek has quit (Ping timeout) 23:48:52 <instant-buildbot> build #178 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/178 23:54:42 --> Tomek has joined #instantbird