#instantbird log on 01 02 2012

All times are UTC.

03:52:24 --> clokep has joined #instantbird
03:52:25 * ChanServ sets mode +h clokep 
04:03:48 --> EionRobb has joined #instantbird
04:06:46 <-- clokep has quit (Ping timeout)
04:13:58 <-- micahg has quit (Quit: Ex-Chat)
04:14:21 --> micahg has joined #instantbird
05:35:36 --> Plop has joined #instantbird
05:36:20 <-- Plop has quit (Quit: Instantbird 1.1)
05:36:31 --> Plop has joined #instantbird
05:55:23 <-- Plop has quit (Quit: Instantbird 1.1)
05:55:31 --> Plop has joined #instantbird
05:58:47 --> clokep has joined #instantbird
05:58:47 * ChanServ sets mode +h clokep 
06:09:33 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
06:11:34 <-- Plop has quit (Ping timeout)
06:12:45 --> Plop has joined #instantbird
08:17:24 --> MadWookiee has joined #instantbird
08:43:50 --> aleth has joined #instantbird
08:54:05 <-- MadWookiee has quit (Ping timeout)
08:58:46 --> MadWookiee has joined #instantbird
09:14:27 --> jb has joined #instantbird
09:32:03 <-- EionRobb has quit (Quit: Leaving.)
09:43:10 --> mmkmou has joined #instantbird
09:45:18 --> Even has joined #instantbird
09:45:18 * ChanServ sets mode +o Even 
09:48:38 <-- Even has quit (Quit: Instantbird 1.2a1pre)
09:49:27 --> Even has joined #instantbird
09:49:28 * ChanServ sets mode +o Even 
09:50:47 --> flo has joined #instantbird
09:50:47 * ChanServ sets mode +qo flo flo 
09:57:17 <-- MadWookiee has quit (Ping timeout)
10:05:28 --> MadWookiee has joined #instantbird
10:45:50 <-- MadWookiee has quit (Ping timeout)
10:54:10 --> MadWookiee has joined #instantbird
11:01:51 <-- chrisccoulson has quit (Ping timeout)
13:14:12 --> Tomek has joined #instantbird
14:12:09 --> chrisccoulson has joined #instantbird
14:13:26 <-- MadWookiee has quit (Ping timeout)
14:34:59 --> ecaron has joined #instantbird
14:57:07 * flo is working on JSON logs
15:10:52 <-- mmkmou has quit (Ping timeout)
15:11:51 * aleth likes the sound of that :)
15:13:13 <flo> the difficulty isn't where I thought it would be
15:13:45 <flo> I have a hard time swapping between fulltext and message themed conversations in the browser of the log viewer
15:14:46 <aleth> I'm not sure I understand. Shouldn't the logs ultimately be message themed too?
15:15:24 <flo> I don't know any way to parse the current plain text logs
15:15:37 <aleth> Oh, for the conversion
15:15:47 <flo> so I'm hacking the log viewer to display the current view for old logs, and a message themed view for new logs
15:16:16 <flo> and switching between the different types of logs doesn't work well in the same browser.
15:16:56 <flo> it seemed I would you have to change the type attribute between "content" and "content-conversation", but that's not enough
15:17:07 <flo> I think I'll end up with 2 completely separate browsers in a deck
15:18:04 <aleth> Or a separate div container?
15:18:21 <aleth> Sounds tricky anyway
15:19:24 <flo> I don't know what a separate div container is in the context of a XUL document :-S
15:19:41 <flo> if I use 2 different browser, I have to make the findbar swap between them too
15:22:50 <aleth> right :(
15:24:33 <aleth> Is there really no way to do a conversion of old logs? What is missing?
15:26:01 --> mmkmou has joined #instantbird
15:27:27 <flo> aleth: a way to know if a message is incoming or outgoing
15:27:44 <flo> a way to differentiate between several messages and a single message containing a quote of several messages
15:28:26 <flo> (when a human reads the log, the only way to know that is guessing, based on the timestamps)
15:33:50 <aleth> Sounds difficult.
15:35:18 <aleth> One might get around the incoming/outgoing distinction by using the coloring algorithm (MUC style) to assign colors instead
15:36:28 <aleth> But that's probably not all there is to it
15:36:39 <flo> in bubbles the queue aren't in the same direction
15:49:37 <aleth> If that was all, it would be a small price to pay compared to the overhead of two separate browsers...
15:52:49 --> MadWookiee has joined #instantbird
15:53:16 <aleth> Btw, I just looked at my patch queue to see what was left and I'd suggest landing bug 1074 and 1107 soon, so people can test them well before 1.2 and submit follow-up bugs/make changes if necessary
15:53:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1074 nor, --, ---, aletheia2, ASSI, Default message styles lack context message support and override font choice
15:53:56 <flo> bug 1107
15:54:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1107 nor, --, ---, aletheia2, ASSI, Contact list section header styling for Linux
15:55:32 <flo> doesn't that patch changes the appearance on Windows?
15:56:29 <aleth> Doesn't the XP in %ifndef XP_MACOSX stand for Windows?
15:56:38 <flo> no
15:56:47 <aleth> Ah. That would need to be changed then
15:56:49 <flo> it means "Cross Platform"
15:56:56 <aleth> Good to know.
15:57:04 <flo> (and is actually as meaningless these days as "NS" (NetScape))
15:57:33 <flo> I suspect it may have had a meaning at a time netscape was built from separate codebases for different OSes
15:58:09 <flo> but I don't really know :)
15:58:24 <aleth> archaic...
15:58:56 <flo> to ifdef for only linux, usually you need #ifdef XP_UNIX #ifndef XP_MACOSX  code #endif #endif
15:59:23 <aleth> Thanks, good to know for the future
16:00:00 <aleth> I did wonder at the time why XP and not WIN ;)
16:00:43 <flo> one can also wonder why there's no XP_LINUX
16:01:20 <flo> maybe to avoid causing pain for *BSD OSes
17:32:50 <-- MadWookiee has quit (Quit: Instantbird 1.1)
17:44:48 <-- Even has quit (Quit: Instantbird 1.2a1pre)
18:12:31 <-- jb has quit (Quit: Instantbird 1.2a1pre)
18:12:44 <-- Plop has quit (Ping timeout)
18:25:29 <instantbot> New purplexpcom - Twitter bug 1218 filed by florian@instantbird.org.
18:25:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1218 nor, --, ---, nobody, NEW, Search API queries need some escaping
18:48:46 --> Mnyromyr has joined #instantbird
18:57:12 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre)
19:08:40 <flo> I've just pushed my changes. Logs will be written by default in a JSON-based format starting with the next nightly.
19:09:17 <flo> if you don't want to help us test this, you can set "purple.logging.format" back to "txt" in about config
19:16:15 <-- flo has quit (Quit: Instantbird 1.2a1pre)
19:17:02 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/aad1e30b0622 - Florian Qu├Ęze - Log conversations in a JSON-based format.
19:17:03 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d9beafc51e18 - Patrick Cloke - Bug 1216 - update copyright year to 2012, r=fqueze.
19:29:29 --> clokep has joined #instantbird
19:29:29 * ChanServ sets mode +h clokep 
19:43:17 <clokep> I had briefly looked at the issue with escaping XHR stuff and I thought we /did/ escape them, but maybe not.
19:59:59 <clokep> ecaron: Wow, that was some in depth thoughts on the logo! :) Great job looking into all this.
20:13:02 <ecaron> clokep: I'll accept gratitude on the logo if progress ever gets made; I don't see how it will though.
20:14:10 <ecaron> We need a Jony Ive type person that is the alpha and omega on design decisions, and we need to acknowledge that the current core of developers aren't design/UI experts (which is not necessarily a bad thing)
20:35:24 --> flo has joined #instantbird
20:35:24 * ChanServ sets mode +qo flo flo 
20:38:38 <flo> ecaron: please, don't put graphics (logo, icons, colors, etc...) and UI/UX design in the same bag :).
20:39:30 <ecaron> How about UI is more like the boot/trunk of the car, and graphics are a bag in the boot
20:45:51 <flo> clokep: if you meant "twitter search" when you wrote "XHR", then I don't see any attempt at escaping here: http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#526
20:47:03 <flo> nor at http://lxr.instantbird.org/instantbird/source/chat/modules/http.jsm#55
20:47:19 <clokep> flo: You're right. I had been looking at http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#414 which is incorrect, we don't use signAndSend because it's a public method.
20:47:21 <flo> it seems necko automatically espcapes most characters for us
20:48:01 <flo> but # is used for anchors in URLs, so necko probably strips anything after the # character
20:48:39 <flo> "it seems necko automatically espcapes most characters for us" or maybe we are just lucky when sending unescaped spaces and it just works...
20:48:57 <flo> I'm not sure of which kind of escaping we need
20:49:28 <clokep> I think we need to percent encode it.
20:49:28 --> Plop has joined #instantbird
20:49:43 <clokep> But I'm not sure, hopefully the documentation would say. ;)
20:50:08 <flo> If I wanted to work on that bug, I would just try
20:50:19 <flo> (and maybe check what we are sending using wireshark
20:50:43 <clokep> I'll probably take a look at it this week if you don't get to it first. :)
21:20:39 --> mmkmou has joined #instantbird
21:27:34 <-- mmkmou has quit (Ping timeout)
21:27:59 <-- Tonnes has quit (Ping timeout)
21:30:14 --> mmkmou has joined #instantbird
21:36:18 --> Tonnes has joined #instantbird
21:45:14 <-- mmkmou has quit (Max SendQ exceeded)
21:45:18 --> mmkmou has joined #instantbird
22:16:59 * flo is looking at his todo list and doing some clean-up
22:17:39 <flo> apparently I still have a "instantbird" task, with a rational for why such a release would be desirable :-D
22:23:45 <aleth> now it would be a prequel ;)
22:24:28 <instantbot> New Instantbird (UI) bug 1219 filed by florian@instantbird.org.
22:24:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1219 tri, --, ---, nobody, NEW, Cleanup the account.xml binding
22:26:29 <flo> I'm wondering which bugs are worth filing
22:26:46 <flo> replacing clutter in my todo list with clutter in bugzilla doesn't seem like an improvement
22:26:50 <clokep> The ones that someone else might work on probably.
22:30:21 <aleth> The ones that dont take longer to transfer to bugzilla than to fix?
22:30:24 <instantbot> New Instantbird (UI) bug 1220 filed by florian@instantbird.org.
22:30:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1220 tri, --, ---, nobody, NEW, remove useless Mac-only instantbird.dtd include in aboutDialog.xul and other windows
22:32:31 <flo> aleth: if I take into account the likely review time for at least 2 iterations of a proposed patch, all trivial bugs take longer to file + review than to just fix :(.
22:33:06 <flo> is something like "the tags tooltip line added by updateTooltipForContact disappears after the observer is called for a presence change" worth filing?
22:33:54 <flo> I'm not sure the current tooltips are worth spending time on. They need a serious redesign.
22:35:57 <aleth> Yes, they have some cryptic features copied over from libpurple
22:36:07 <aleth> e.g. 'Subscription: both'
22:36:21 <flo> update your nightly! :-P
22:36:32 <flo> JS-XMPP doesn't display that line
22:36:36 <clokep> It'd be helpful for them to be able to have clickable links. :(
22:36:41 <flo> it's displayed only when the value isn't "both"
22:36:46 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
22:36:58 --> clokep has joined #instantbird
22:36:59 * ChanServ sets mode +h clokep 
22:37:04 <flo> we already have a bug on file to remove the pointless and confusing lines from the tooltips
22:37:31 <aleth> heh :)
22:37:52 <aleth> linux build must have failed.
22:37:58 <flo> but I would like us to redesign us, so that they don't look so bad
22:38:08 <flo> aleth: for weeks?
22:38:12 <aleth> What did you end up doing for the DNS SRV problem?
22:38:28 <flo> nothing
22:38:53 <aleth> I am seeing |Subscription: both| for XMPP with the current nightly
22:39:07 <clokep> aleth: For XMPP or for GTalk?Facebook?
22:39:11 <aleth> XMPP
22:39:16 <aleth> hence my question
22:39:39 <clokep> Yes, it'd still do that for straight XMPP.
22:40:24 <flo> ah, the reviewer has just refused to review the DNS SRV patch, and wants us to go bother the module owner instead
22:47:54 <aleth> could that be a good thing? or just delay?
22:48:23 <instantbot> New Instantbird (UI) bug 1221 filed by florian@instantbird.org.
22:48:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, ---, nobody, NEW, Redesign buddy tooltips
22:48:44 <flo> I don't know
22:49:16 <flo> but attempting to talk about it to biesi at FOSDEM sounds like something that could help move things forward
22:51:58 <-- mmkmou has quit (Ping timeout)
22:52:10 --> mmkmou has joined #instantbird
22:53:38 <instantbot> New Instantbird (UI) bug 1222 filed by florian@instantbird.org.
22:53:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1222 min, --, ---, nobody, NEW, the "tags" line of contact tooltips disappears after the status of the contact changes
22:55:06 <flo> aleth: do you know how much work is left to cleanup the CSS files we ship so that they match the recommendations from https://developer.mozilla.org/en/CSS/Writing_Efficient_CSS ?
22:56:25 <flo> if I remember correctly, Bubbles needs some cleanup. I don't remember if we have looked at other areas (out of those you have already cleaned up of course :))
23:04:07 <-- mmkmou has quit (Ping timeout)
23:07:26 <-- Plop has quit (Ping timeout)
23:08:54 --> Plop has joined #instantbird
23:10:09 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
23:17:24 <-- Plop has quit (Ping timeout)
23:19:03 --> Plop has joined #instantbird
23:19:25 --> mmkmou has joined #instantbird
23:26:05 <flo> by the way, the new log format contains just what I needed to be able to redisplay conversations (mostly) correctly. I'm open to discussion for additional things that should be logged
23:30:42 <flo> example of things that could be interesting to add: hostname of the machine where the conversation happened (may be useful when we will attempt to synchronize the data across several machines), list of participants when joining and then changes to that list (they are currently logged as unparsable localized system messages)
23:34:32 <flo> Good night :)
23:34:35 <-- flo has quit (Quit: Instantbird 1.2a1pre)
23:34:46 <-- ecaron has quit (Quit: Instantbird 1.1)
23:55:31 <-- Tomek has quit (Quit: Instantbird 1.1)