#instantbird log on 12 11 2011

All times are UTC.

00:34:48 <flo> Good night :)
00:50:32 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
00:52:01 --> aleth has joined #instantbird
00:54:58 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
01:20:52 --> FeuerFliege1 has joined #instantbird
01:21:23 <-- FeuerFliege has quit (Ping timeout)
02:03:32 <-- FeuerFliege1 has quit (Ping timeout)
05:35:47 <instantbot> New Instantbird (UI) bug 1204 filed by jahkae@gmail.com.
05:35:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1204 nor, --, ---, nobody, UNCO, buddy conversation missing in recent nightly builds.
05:37:23 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
06:30:59 <-- DGMurdockIII has quit (Ping timeout)
06:55:43 --> FeuerFliege has joined #instantbird
08:06:46 <-- Novarg has quit (Ping timeout)
08:06:48 --> Novarg has joined #instantbird
08:48:08 <-- Kagami has quit (Ping timeout)
08:49:48 --> aleth has joined #instantbird
08:51:47 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
08:51:55 --> aleth has joined #instantbird
08:52:28 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
08:52:34 --> aleth has joined #instantbird
08:54:06 --> Suiseiseki has joined #instantbird
08:56:12 <-- Suiseiseki has quit (Ping timeout)
08:56:53 --> Suiseiseki has joined #instantbird
09:06:30 <-- Suiseiseki has quit (Ping timeout)
09:18:15 --> Px has joined #instantbird
09:32:51 --> Mic has joined #instantbird
09:32:52 * ChanServ sets mode +h Mic 
09:49:27 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
10:44:42 <-- Px has quit (Quit: ChatZilla 0.9.87 [SeaMonkey 2.8a1/20111206003001])
11:19:09 --> Px has joined #instantbird
11:25:20 <Px> Hello. If anybody of developers have a free minute and can spend it on me, can you explain why is current logging system with each conversation as separate file and grouping logs by sender were choosed? Also, do you have plans for changing current logging system?
11:29:42 <flo> I don't really understand your first question; but the current logging system behaves like the Pidgin logs, so that once we implement something better (I guess that answers the second question) we have only one importer to write for the logs made by libpurple (old instantbird) and those made by instantbird (1.0 and newer)
11:32:03 <flo> "I don't really understand your first question" -> especially, what's wrong with grouping logs by sender or how would you do differently?
11:32:45 <Px> Thanks, can you explain, how this "something better" will looks like? Text or some king of sql?
11:32:58 <flo> JSON
11:33:25 <flo> + and sqlite index for fast (instant? :)) searches
11:33:35 <flo> s/and/an/
11:34:12 <Px> Differently: group logs by date, folder year\month\day and one file for one person logs for that day
11:35:03 <flo> is it better? (why? :))
11:35:29 <flo> how do you find quickly all the logs for a contact with that scheme?
11:38:21 <Px> That's make easy synchronization between several logs storage, in that scheme you just select couple of folders for missing dates and copy them, with current scheme you need to build files list from each contact's folder or use external sync tools.
11:39:18 <Px> File name = contact name/id, you just searches for file names with it via shell, file manager or what you like
11:41:26 <flo> I wouldn't call "select couple of folders" "easy synchronization" ;)
11:41:44 <flo> we also plan to add automatic synchronizations of logs between several machines
11:42:37 <Px> Em? Searching for changes in 100+ contacts folders looking more easy then selecting two or three folders?
11:43:03 <flo> having logs always synchronized without any user intervention seems easier to me
11:43:46 <Px> Via some external service, I suppose? Like Firefox Sync?
11:43:56 <flo> yes
11:44:07 <flo> although Firefox sync isn't well suited for large amounts of data
11:44:30 <Px> Doesn't fit for paranoids, like me :(
11:44:31 <flo> so I think we could rather put the logs on a file storage service (dropbox for example) after encrypting them
11:44:44 <flo> Px: Firefox Sync is perfect for paranoids
11:44:55 <flo> everything is encrypted locally before leaving your machine
11:46:47 <Px> Sorry, but I still doesn't trust it. Yes, I know that this is my problem, but anyway :)
11:48:34 <Px> But back to logs, I suppose I don't convince you that proposed scheme is better that current one and you don't plan to change it?
11:53:34 <flo> which OS do you use?
11:53:45 <Px> WinXP/Win7
11:53:49 <flo> if it's an Unix, you probably have the rsync command already installed
11:53:59 <flo> if it's Windows, Firefox Sync isn't the scariest part of your system :-P
11:55:30 <Px> Sync is disabled on my systems, they are serving for different purposes and there is no need to mix between them
11:57:01 <Px> And that's what I'm also pointing out, instead of just copying a couple of folders in shell, you need to set up some external tools
11:57:23 <flo> if you think that changing the way logs are stored is easier than fixing your assumption about what is secure or not, I guess you can quite easily write an add-on to store the logs (or a synchronizable copy of them) however you like.
11:58:30 <flo> Px: I still don't see the point. If you want to synchronize once, you can copy the whole log folder above another. Windows should be able to merge them without causing additional issues.
11:58:42 <flo> if you want to do it everyday, you definitely don't want to have to touch folders yourself
11:58:59 <flo> so setting up a (trivial) tool is way easier than whatever would force you to open the file explorer
12:00:33 <Px> You already planning to change logging system and I'm interesting in additional change among other, but I see that the answer is "No", that's a pity
12:00:55 <Px> "if you want to do it everyday, you definitely don't want to have to touch folders yourself"
12:00:56 <Px> That's wrong assumption
12:03:26 <flo> then I still don't know what you are actually wanting to do
12:09:50 <Px> :)
12:09:51 <Px> Ok, I'll try to explain how I see this: now logs folder have such structure, logs\<transport>\<transport name or id>\<buddy's id>\date.time+timezone.txt, I propose to change it to logs\<transport name or id>\<year>\<month>\<day>\buddy's id@transport.txt, time already in logs, timezone may be stored there also
12:11:25 <Px> one day = one conversation file, no need to split them
12:11:51 <Px> s/one conversation file/one conversation file for one buddy
12:15:26 <flo> I understand what you said you would like to see as the behavior. I haven't understood why this is the best way to help you in what you are actually trying to achieve
12:16:01 <flo> first, I don't see any good reason for you to look in the profile folder for something you do frequently
12:16:43 <flo> if you go look because you are curious, it's ok. If you have to do it, there's something wrong
12:22:08 <Px> I try to achieve easy sync without external tools. Jump to current month folder via link, select couple of folder and send them on flash stick/ftp/etc, restore them on "next" place, that's all. No external tools, no need to set up something, no need to bind to current internet state
12:22:37 <Px> s/internet state/internet connection state
12:23:33 <flo> if we do what  I described with dropbox but use your usb stick instead, that gives you what you want, right?
12:24:00 <flo> the usb stick would contain only encrypted data, and if you ever lose it, nobody could read your conversations
12:25:57 <Px> tool for encryption/decryption, time for doing it, is it really more appropriate way?
12:26:14 <flo> there's no tool for encryption
12:31:00 <Px> "if we do what I described with dropbox" - sync like on flash? Where you propose to store data for changes (how to determine what need to be copied on flash)?
12:31:31 <flo> what isn't there already :)
12:32:04 <Px> I'm not quite understand :(
12:35:57 <-- aleth has quit (Input/output error)
12:38:07 --> Tomek has joined #instantbird
12:50:35 --> hunsly has joined #instantbird
12:58:16 --> Suiseiseki has joined #instantbird
13:01:15 <-- Suiseiseki has quit (Ping timeout)
13:06:36 <-- FeuerFliege has quit (Ping timeout)
13:10:39 --> Andrey has joined #instantbird
13:34:15 <Px> Anyway, thanks for spend time on me, while I'll continue to search for im which fits me best...
13:39:02 --> mmkmou has joined #instantbird
13:39:27 <-- mmkmou has left #instantbird ()
13:42:59 --> Mic has joined #instantbird
13:42:59 * ChanServ sets mode +h Mic 
13:51:12 * Mic wonders what's so bad on Windows systems? I mean they don't even have an app store and a vendor that exactly knows what's good for you an what not :P
13:52:06 <Px> Windows Marketplace ;)
13:53:46 <Px> Heh, now it's Microsoft Store...
13:55:46 --> aleth has joined #instantbird
13:57:03 --> mmkmou has joined #instantbird
13:57:17 --> Suiseiseki has joined #instantbird
14:01:58 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
14:02:20 --> aleth has joined #instantbird
14:04:18 --> clokep has joined #instantbird
14:04:18 * ChanServ sets mode +h clokep 
14:04:43 --> FeuerFliege has joined #instantbird
14:07:32 <-- Suiseiseki has quit (Ping timeout)
14:09:31 <-- Mic has quit (Connection reset by peer)
14:09:36 <flo> Mic: look at the windows builder ;). Not being able to reliable delete a temporary file is a good example of what's bad on Windows :-P.
14:09:41 <flo> *reliably
14:13:30 <clokep> Px: It sounds like what you're doing you really /should/ use an "external" sync tool, but I'm not sure what you have against something that just searches for changes between two folders and syncs them.
14:14:27 <flo> clokep: good morning :)
14:14:36 <clokep> Good morning flo. :)
14:14:45 <flo> it's not morning any more for me ;)
14:14:50 <Px> If I can do this by myself within a couple of second, why I need to use some external tool? :)
14:14:56 <clokep> "Good afternoon flo. :)"
14:15:04 <Px> clokep: good morning :)
14:15:13 <clokep> You double click and icon and it does it in < a couple of seconds?
14:15:34 <flo> Px: because a couple of seconds everyday is several hours per year
14:15:54 <clokep> But setting it up once is like an hour and then it takes no time at all.
14:16:05 <aleth> Px: You would _still_ be better off writing a script to do it for you at least. It is a lot less hassle and less error-prone.
14:16:31 <flo> any manual intervention risks introducing errors, especially the days you are tired. And recovering from errors tend to waste minutes, if not hours
14:16:34 <Px> Well, I *cheat* having shortcuts to needed folders in my file manager :)
14:16:53 <flo> isn't that shortcut an external tool already?
14:18:05 <Px> Yup, but this *my* tool in which I spend most of my day already
14:19:04 <aleth> But if you are customizing your own things already, why not write your own script?
14:19:23 <Px> So, three keypress for folders setup (can be replaced with one with macro, but I'm lazy...), couple of selects and two for copy, job is done
14:19:24 <clokep> So I tried rewriting LJ Talk using JS-XMPP...but I always get a connection refused error now...I think I'm sending the wrong type of encryption, the old override was set to "Require encryption", what's equal to that now?
14:20:07 <flo> clokep: that's starttls
14:20:17 <clokep> flo: Thank you. :)
14:20:27 <flo> let me look at the file though
14:20:57 <flo> you are asking for what you should write in the connect: method, right?
14:21:13 <clokep> Yes.
14:21:58 <flo> "require_tls" is the value you need
14:22:43 <flo> the possible values are listed at http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.js#65
14:22:45 <clokep> OK.
14:25:10 <clokep> Bleh "Server closed the connection"
14:25:14 <Px> Well, I definitely can write a script that build a file list for current scheme, but just imagine how many time it spend traveling through 5+ years history? My current IM holds history for ~7 years, and manual sync still takes a couple of seconds (while creating new instance of backup is nightmare :D)
14:26:11 <flo> can't you just install rsync or equivalent?
14:26:45 <Px> No, I think that is bad approach :)
14:27:11 <clokep> Why is that a "bad" approach?
14:27:26 <clokep> (I'm fairly certain Windows has a built in tool for syncing files btw.)
14:28:20 <-- BlueMaxima has quit (Quit: Instantbird 1.1)
14:28:31 <clokep> (Sorry if it seems like we're being very difficult, but we really just don't understand...)
14:28:52 <Px> Because this yet another not needed 99,95% of time tool
14:29:49 <clokep> OK, why's that bad? Are you worried about storage space from it or?
14:30:35 <-- mmkmou has quit (Ping timeout)
14:30:40 --> mmkmou has joined #instantbird
14:32:31 <clokep> flo: So previously I had been getting a "SSL handshake failed" error, unless I shut off checking certs, which using what I think are all the same settings (I just made a raw xmpp account to check).
14:32:43 <clokep> Could this type of error manifest as a refused connection in the new code?
14:34:09 <flo> clokep: connecting the socket would definitely fail. I'm not show of which error message would appear. I'm just sure cleaning up the error handling of socket.jsm is still on my todo list ;
14:34:10 <flo> )
14:34:26 <flo> *I'm not sure of which error
14:34:47 <clokep> Got it. :) OK I'll check it out later if I can...but right now I'm going to look at Mic's "account is null" error I think.
14:35:31 <Px> Not space, but... well, can't properly translate it into English (it's not my native language), something like order/clearness on hard drive/system. No unnecessary things, if you can do same with often used tools in approximately same time
14:35:37 <flo> do you know anyway to reproduce the situation that causes this database corruption?
14:36:38 <clokep> Px: I agree, I try really hard to not install stuff I don't need, but I disagree on whether this is necessary for you or not. :)
14:36:53 <clokep> flo: No, but my developer profile has it pop up.
14:37:26 <flo> clokep: that error will appear if you remove an account from the preference files but keep its accountbuddies in blist.sqlite
14:37:33 <-- mmkmou has quit (Ping timeout)
14:37:55 <clokep> Ah, I see.
14:38:53 <aleth> Px: It is hard to imagine that it takes the same time (and is less likely to lead to errors) to manually sync by copying files every day than to use a standard tool like rsync to automate the job. But it is clearly a personal preference ;)
14:40:34 <Px> Most time on sync is taking data copy, "preparations" is less than 1% of total time :)
14:40:52 <clokep> flo: So I had made a Facebook account on my dev profile to test JS-XMPP...I deleted it via the interface, but it still seems listed in the accounts pref.
14:41:16 <clokep> ("deleted it via the interface" == using the UI to delete the account)
14:41:46 <flo> it's possible something is broken in the code path used to delete an account
14:41:50 <flo> I don't test that very frequently
14:42:32 <clokep> It's where I'm getting an account is null error at http://lxr.instantbird.org/instantbird/source/chat/components/src/imContacts.js#1254
14:45:44 <flo> I know
14:46:01 <flo> but that error is not the problem, it's the consequence
14:47:13 <clokep> Bleh, I lied anyway, removing that account from the list of accounts doesn't fix it.
14:54:45 <instantbot> New Instantbird (UI) bug 1205 filed by px@i.kiev.ua.
14:54:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1205 nor, --, ---, nobody, UNCO, Cyrillic support in alias and buddy list broken
14:55:25 <Px> clokep, that's what we talked about yesterday
14:57:49 <clokep> Great!
14:57:57 <clokep> Thanks.
15:01:48 --> mmkmou has joined #instantbird
15:13:10 <instantbot> New Instantbird (UI) bug 1206 filed by px@i.kiev.ua.
15:13:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1206 nor, --, ---, nobody, UNCO, Newly added contacts disappears until instantbird restart
15:29:20 <-- mmkmou has quit (Ping timeout)
15:42:07 <clokep> About the Facebook buddy list changes: http://developer.pidgin.im/ticket/14785
15:43:53 <flo> that doesn't contain much information though :(
15:44:29 <clokep> No, it doesn't...they also linked to http://developers.facebook.com/docs/chat/ in #pidgin.
15:44:43 <clokep> But that doesn't really have much information either.
15:53:38 --> mmkmou has joined #instantbird
16:05:38 --> Mic has joined #instantbird
16:05:38 * ChanServ sets mode +h Mic 
16:05:50 <Mic> Hi
16:08:11 <Andrey> hi
16:15:19 <-- Andrey has quit (Quit: )
16:32:19 <-- mmkmou has left #instantbird ()
16:48:04 --> Suiseiseki has joined #instantbird
16:59:14 <-- clokep has quit (Ping timeout)
17:00:18 <-- Suiseiseki has quit (Ping timeout)
17:00:51 --> Suiseiseki has joined #instantbird
17:04:08 <-- Suiseiseki has quit (Ping timeout)
17:22:34 <-- Mic has quit (Connection reset by peer)
17:33:22 --> Suiseiseki has joined #instantbird
17:53:35 --> clokep has joined #instantbird
17:53:35 * ChanServ sets mode +h clokep 
19:08:31 --> chrisccoulson has joined #instantbird
19:10:02 --> mmkmou has joined #instantbird
19:10:58 <-- mmkmou has left #instantbird ()
19:21:17 <-- Tomek has quit (Quit: Instantbird 1.1)
19:36:36 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
19:48:07 --> igorko has joined #instantbird
19:51:13 --> EionRobb has joined #instantbird
20:36:41 --> mmkmou has joined #instantbird
20:37:09 <clokep> Bleh http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#148 has improper spacing.
20:58:47 --> Tomek has joined #instantbird
21:04:55 <flo> :(
21:04:57 --> aleth has joined #instantbird
21:06:28 * clokep is trying to implement buddies.
21:11:22 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre)
21:17:16 <flo> https://bugzilla.instantbird.org/request.cgi?action=queue&requester=&product=&type=all&requestee=&component=&group=type that's too long :(
21:18:03 <clokep> You can just check mine in. ;)
21:18:03 <flo> but at least I'm not guilty for bug 1153 and bug 1186 :)
21:18:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1153 min, --, ---, nobody, NEW, German locale: string changes to "features" webpage
21:18:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1186 maj, --, ---, raynaudquentin, UNCO, "Redirect Loop" error for addons.instantbird.org
21:18:50 <flo> clokep: really? I thought you liked having people look at your code :-/
21:19:00 <flo> (I do! :))
21:19:04 <clokep> flo: Oh, I do absolutely. :)
21:19:13 <clokep> Was just teasing.
21:19:18 * clokep is going to look at bug 1202 for you.
21:19:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1202 nor, --, ---, nobody, NEW, Add inline options to select nick highlight style
21:29:15 <flo> aleth: I just looked at https://bugzilla.instantbird.org/attachment.cgi?id=1039&action=diff. Don't we have to do a similar thing for _cutBegin/end at line 856?
21:30:01 --> Mnyromyr has joined #instantbird
21:30:36 <flo> or change the comment at line 806 to say they are initialized only if _textSelected is true, and change the getCutBegin getter to return this._textSelected && this._cutBegin
21:32:26 <clokep> Let me read the code...
21:32:28 <instantbot> florian@instantbird.org granted review for attachment 1040 on bug 1182.
21:32:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
21:35:55 <clokep> Yes, we would need to do something similar in that case.
21:36:31 <instantbot> florian@instantbird.org granted review for attachment 1042 on bug 1182.
21:36:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
21:38:12 <instantbot> florian@instantbird.org granted review for attachment 1060 on bug 1182.
21:41:53 <flo> I said that mostly to see if aleth was here and wanted to look, but he doesn't seem here, so I guess I would better just fix it myself instead of letting this wait even more
21:44:18 <clokep> Oh OK. :)
21:45:38 <flo> but now that you have read that code, you are qualified to review my changes :-P
21:46:15 <flo> clokep: how about http://pastebin.instantbird.com/2562?
21:46:46 <clokep> Doh!
21:47:05 <flo> uh, 500 pastebin posts during the week-end? :-S I hope these spammers don't set the retention time to "forever" when posting their garbage :-/
21:48:02 <clokep> flo: Looks good, only comment would be using |return this._textSelected || "";| on line 74? I'm not positive that works or if it's clearer or if we care. :)
21:48:28 <flo> textSelected is a boolean, selectedText is the actual text
21:48:53 <flo> so no, that wouldn't work
21:49:37 <clokep> Eek. :-[
21:49:42 <clokep> Let me reaad that code again haha.
21:49:59 <clokep> Yes, of course that wouldn't work.
21:52:29 <flo> r+?
21:53:32 <clokep> Yes. :)
21:54:39 <aleth> hi :) yeah, I mentioned when I submitted it that I didn't know what the best way to handle the analagous issue for cutBegin/End was. Thanks for adding that.
21:57:03 <flo> I didn't remember that, sorry :-/
21:58:15 <instantbot> florian@instantbird.org denied review for attachment 1039 on bug 1182.
21:58:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
21:58:30 <flo> aleth: do you want to be mentioned as reviewer too? I guess you have looked at my pastebin too ;)
21:58:53 * clokep can never remember where imIStatusInfo is defined. :(
21:59:52 <flo> clokep: I've the same problem
22:00:00 <flo> do you want me to move it to a separate file now?
22:01:03 <flo> or do you want to file a bug to attach a patch addressing a few other similar cases?
22:01:11 <clokep> flo: it seems kind of arbitrarily placed and if we both can never find it...it probably doesn't belong where it is. :-D
22:01:17 <flo> I suspect it's not obvious either that imITagsService is in imIContactsService
22:01:58 <clokep> I could just attach a patch to bug 759. ;)
22:02:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, florian, ASSI, Reorganize purplexpcom
22:02:30 <flo> clokep: it's not really arbitrary, it's more an artifact of the past. It started as being somewhat internal to the js-blist code, it was a way to share common parts of the 3 interfaces I needed for imIContact, imIBuddy and prplIAccountBuddy.
22:02:46 <flo> but then for consistency we started using values from it for things that are completely unrelated to that code
22:03:01 <clokep> Ah, I see.
22:03:24 <-- mmkmou has quit (Ping timeout)
22:03:46 --> mmkmou has joined #instantbird
22:04:02 <flo> so yeah, that could go in bug 759 :)
22:04:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, florian, ASSI, Reorganize purplexpcom
22:04:12 <flo> I'm not sure if we want one file per interface
22:04:20 <flo> or just smaller more logical files
22:04:33 <aleth> flo: no worries. I should have added it in a comment to the bug rather than just mention it in here.
22:04:35 <clokep> I think some of them make sense together (All the conversation things, for example.)
22:04:38 <flo> but I think imITagsService and imITag could go in an imITagsService.idl file
22:04:47 <clokep> I agree.
22:05:00 <flo> so we need at least 2 new files here
22:05:12 <clokep> imIStatusInfo is the one I /really/ notice myself having trouble to find...but I rarely use the tags one. :)
22:05:31 <flo> yeah, tags aren't that interesting :)
22:05:47 <flo> the interface is useful, but it doesn't define interesting constants, and doesn't have comments we need to keep checking
22:06:07 <clokep> It's almost mostly handled for us AFAICT.
22:06:23 <flo> if "us" means "js-prpl authors", yeah
22:06:35 <clokep> Yup!
22:06:47 <clokep> !!! My buddy is now marked as available.
22:06:56 <clokep> But IRC has an atrocious mechanism for telling if users are online. :(
22:07:16 <flo> you need to keep pinging?
22:07:32 <-- mmkmou has quit (Ping timeout)
22:07:42 <clokep> That's the one in the spec. I think there's another mechanism, but I need to find a reference to it again...
22:07:54 <flo> are you moving these interfaces around or should I do it?
22:08:25 <clokep> I was about to do it.
22:08:48 <flo> ok :)
22:09:44 <flo> don't forget to fix the comment at http://lxr.instantbird.org/instantbird/source/chat/components/public/imIUserStatusInfo.idl#50
22:14:08 <clokep> OK!
22:15:57 <-- igorko has quit (Quit: Instantbird 1.1)
22:17:07 <clokep> flo: Should this also separate the definitions from imContacts.js?
22:17:46 <flo> you mean create an imTags.js?
22:17:57 <clokep> Yes, but I assume they both touch the same database, so Idk if it'd make sense.
22:18:16 <flo> your assumption is right
22:18:38 <flo> and I've (purposefully) not exposed the database connection outside of that file
22:19:12 <clokep> Alright! That's why I asked! :-D
22:21:03 <flo> hmm, it seems that adding an r- that risk causing the patch authors to update an attachment to a version I obviously won't like is a very effective way to make me add a review comment quickly :-S
22:21:55 --> mmkmou has joined #instantbird
22:23:02 <clokep> Sorry. :(
22:23:14 <clokep> flo: What is the interface commands at the top of IDLs?
22:23:43 <clokep> There was "interface imITag" but no "interface imITagsService" in imIContactsService.
22:23:46 <clokep> Why is that?
22:23:50 <flo> clokep: about https://bugzilla.instantbird.org/attachment.cgi?id=981&action=diff / bug 1098 Is this something we should check-in, or did we want to investigate the cause?
22:23:53 <-- mmkmou has quit (Ping timeout)
22:23:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1098 min, --, ---, clokep, ASSI, Authorization loop if lastMessageId is empty for a Twitter account
22:23:59 --> mmkmou has joined #instantbird
22:24:04 <flo> clokep: it's like forward references in C.
22:24:37 <flo> if you define a which needs b and b which needs a, you need to first tell that b is an interface, otherwise there'll be a parse error in a.
22:24:45 <clokep> (Let me re-read that bug.)
22:24:54 <clokep> Ohhhh, I see.
22:25:50 <clokep> flo: I would like to check that in, we should still investigate what the oauth code does with an empty parameter.
22:26:08 <flo> isn't that killing the only way to reproduce?
22:27:05 <flo> (and shouldn't that patch include an else\nWARN("invalid value for the lastMessageId preference: " + lastMsgId) ?)
22:27:33 <clokep> It should probably include a WARN, yes.
22:27:54 <clokep> If we're investigating we can comment out that code or put debug stateents in.
22:28:05 <-- mmkmou has left #instantbird ()
22:28:14 * flo investigates
22:28:32 <flo> *is investigating
22:30:22 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1072 on bug 759.
22:30:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, florian, ASSI, Reorganize purplexpcom
22:36:26 <flo> I hate that bug :(
22:36:33 <flo> and I really think it should cause a JS strict warning :(
22:36:59 <flo> see the semi colon at the end of http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#557 ?
22:37:16 <clokep> Gah, seriously?
22:37:23 <clokep> :(
22:37:51 <clokep> I agree that should cause a warning.
22:38:08 <clokep> (If you really want an empty if statement, you could still do {}.)
22:38:27 <flo> why would you want it?
22:38:52 <flo> I don't see how it could be possible, except with a silly ifdef
22:39:01 <flo> (and in that case you would have braces anyway)
22:40:31 <clokep> Is that the whole bug then? (I mean, we should verify what we're sending anyway, but is that the other issue?)
22:41:08 <flo> it's the other issue
22:41:30 <flo> by the way, what's the expected behavior if none of the timeline requests succeed?
22:41:47 <flo> should we disconnect the account with an error, or continue anyway, as long as opening the stream succeeds?
22:42:02 <flo> if we think we should continue anyway, then removing the semicolon is all we need to do
22:42:18 <flo> (hmm, and also filing a bug to get the warning added; I'm doing that right now)
22:43:54 <clokep> flo: I remember we struggled with this when we first made Twitter or soon afterward.
22:44:19 <clokep> I thought we defined the expected behavior as continuing anyway.
22:44:38 <flo> ok
22:44:52 <flo> then let's remove the semi-colon and check-in your patch with an added warning :)
22:45:05 <flo> https://bugzilla.mozilla.org/show_bug.cgi?id=709622
22:45:08 <clokep> Awesome, you want me to upload a new patch?
22:45:25 <flo> if you have nothing more useful to do, you can
22:45:37 <flo> otherwise, as I'm already editing that file... I'll finish the work
22:45:54 <clokep> flo: If you wouldn't mind doing it I'm about to cook dinner.
22:45:59 <flo> well, except if you want to change the wording of the warning :)
22:46:16 <clokep> Nah, I always choose bad warnings anyway. :)
22:46:28 <flo> in these cases I'm not sure any more of who is the author of the patch and who is the reviewer :-/
22:48:59 <clokep> It doesn't matter too much to me.
22:49:20 <flo> or, you are the reviewer then :-P
22:49:33 <flo> (that makes the hg commit command shorter :-D)
22:50:15 <-- chrisccoulson has quit (Quit: Ex-Chat)
22:50:21 --> chrisccoulson has joined #instantbird
22:51:44 <clokep> Haha, OK.
22:56:43 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:57:53 <flo> clokep: your regexp is broken :(
22:58:00 <flo> it matches test123
23:01:16 <clokep> flo: It should be /^\d+$/
23:01:21 <clokep> Sorry about that. :(
23:01:29 <flo> yes
23:02:42 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 981 on bug 1098.
23:02:43 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1073 on bug 1098.
23:02:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1098 min, --, ---, florian, ASSI, Authorization loop if lastMessageId is empty for a Twitter account
23:06:25 <instantbot> clokep@gmail.com granted review for attachment 1073 on bug 1098.
23:06:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1098 min, --, ---, florian, ASSI, Authorization loop if lastMessageId is empty for a Twitter account
23:16:28 --> BlueMaxima has joined #instantbird
23:17:14 <-- Px has left #instantbird ()
23:32:15 <instantbot> florian@instantbird.org denied review for attachment 1071 on bug 1199.
23:32:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1199 enh, --, ---, clokep, ASSI, Only notify prplIAccounts of status changes when enabled
23:34:51 <flo> clokep: have you looked at the first part of your patch? https://bugzilla.instantbird.org/attachment.cgi?id=1072&action=diff :-P
23:35:26 <clokep> I thought I checked that! :(
23:35:35 <clokep> Sorry. :-/
23:35:49 <clokep> I wonder if Komodo has a way to use the tab style that's in a file...
23:38:40 <flo> clokep: I'm almost sure you haven't tried to compile with your patch
23:39:00 <clokep> flo: I did a tier_app clean and a tier_app build.
23:39:12 <clokep> (Well a tier_app clean, being I cleaned chat and purple/libpurple)
23:39:51 <flo> purple/libpurple? what's the point?
23:40:09 <clokep> I wasn't sure if anything in there would break, it was a "just in case".
23:40:14 <clokep> Bah I got an error this time. :(
23:40:23 <flo> imIStatusInfo.idl uses prplIConversation which isn't defined anyway ;)
23:40:27 <flo> *anywhere
23:40:49 <flo> breaking something in purple/purplexpcom is much more likely than in purple/libpurple
23:41:03 <flo> should I finish the patch, or write down review comments?
23:41:19 <clokep> Is it more than the spacing and that one change?
23:42:18 <-- hunsly has quit (Ping timeout)
23:42:33 <flo> imIContact isn't defined either in imITagsService.idl
23:43:03 <flo> I don't think you need to define interface imITag; there. You can just have the imITag interface before the imITagsService interface
23:44:24 <clokep> I see.
23:45:24 <clokep> Thank you. :)
23:45:27 <clokep> I think I fixed everything locally.
23:46:03 <flo> I think I would have kept interface imITag; in imIContactsService.idl and not included #include "imITagsService.idl" but I don't see a good reason for it, so it's probably just a matter of personal preference.
23:47:02 <clokep> It seemed to make sense to me to include it if possible.
23:47:07 <flo> "See imIStatusInfo in imIStatusInfo.idl" I don't think I would have specified the file name, as it's obvious, but it doesn't matter
23:47:47 <flo> it's ok either way :)
23:48:10 <clokep> OK, well my build got past /chat, does that mean it worked? :)
23:48:25 <clokep> Ah it finished.
23:48:35 <flo> chat is built before purplexpcom I think
23:48:56 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1072 on bug 759.
23:48:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, florian, ASSI, Reorganize purplexpcom
23:49:09 <clokep> I think I forgot to set review on that...
23:54:30 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1074 on bug 759.
23:54:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, florian, ASSI, Reorganize purplexpcom
23:58:32 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1075 on bug 1199.
23:58:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1199 enh, --, ---, clokep, ASSI, Only notify prplIAccounts of status changes when enabled
23:58:36 <clokep> flo: Sorry for not letting your queue get shorter. :(
23:59:07 <flo> it's ok, I gave up on the idea of ever emptying it
23:59:19 <flo> I had 2 hours so I thought I could mostly empty it
23:59:29 <flo> 3 hours later, it looks like I haven't even started ;)
23:59:40 <clokep> You got rid of two patches at least!
23:59:44 <clokep> + added one