#instantbird log on 12 05 2011

All times are UTC.

00:01:42 <clokep> Shhhhh.
00:02:48 <flo> if you really need a default away message, maybe you can use the default localized message that we have in the preferences?
00:04:49 <clokep> That sounds like a better idea, yes.
00:05:07 <clokep> Is there always a message sent with a status change?
00:05:22 <clokep> (A "status message", that is.)
00:06:04 <EionRobb> flo: sure, might be fun to try write a js protocol plugin
00:06:33 <EionRobb> I was wanting to add a javascript plugin loader to libpurple (similar to the perl/mono ones) at some stage too
00:06:42 <EionRobb> conversely, how's the skype plugin going with IB at the moment? :)
00:07:05 <flo> clokep: no
00:08:05 <flo> EionRobb: I don't think you would be able to write a libpurple loader to insert our plugins there.
00:08:15 <clokep> EionRobb: I haven't looked again (besides downloading your current code & verifying it compiles).
00:10:49 <flo> Good night
00:11:11 <-- flo has quit (Quit: Instantbird 1.2a1pre)
00:12:34 <EionRobb> clokep: you said something about it crashing when you loaded it?
00:12:57 <clokep> EionRobb: Not crashing, it's not showing up in the account manager for some reason.
00:13:09 <clokep> (And the account manager throws errors)
00:17:19 <EionRobb> what kind of errors?
00:17:58 <clokep> Vague ones I think.
00:18:02 <clokep> Let me see if I can get it for you.
00:22:05 <clokep> EionRobb: I don't think http://pastebin.instantbird.com/1324 will mean much more to you then me. :(
00:22:41 <EionRobb> why is it called prpl-skype?
00:22:47 <EionRobb> is that what the wrapper is called?
00:23:02 <EionRobb> the prplid in the plugin is prpl-bigbrownchunx-skype
00:24:33 <clokep> Yeah, I called it just skype.
00:24:42 <EionRobb> k
00:24:48 <clokep> I don't think that that matters.
00:34:23 <clokep> Yeah I'm not sure. I changed it to that (and tried a couple of other things too.)
00:34:37 <clokep> I might need to give it to flo as a patch and see if he can figure it out. :) But that probably wouldn't be for a bit.
00:36:23 <aleth> so, is JS-* landing this week?
00:38:03 * clokep shrugs.
00:39:07 <aleth> it sounded close...
00:39:20 <clokep> I think flo wants to land JS-XMPP soon.
00:39:35 <clokep> I probably need to implement buddies in IRC first.
00:40:00 <EionRobb> with the js protocols, can you modify the js while IB is still running?
00:40:17 <clokep> Yes.
00:40:44 <clokep> I have IRC set up so you can add/remove a "handler" on the fly and intercept messages and start doing different things with them via restartless extensions.
00:41:14 <EionRobb> what if you have multiple copies of the same js file?
00:41:53 <clokep> What do you mean?
00:45:01 <clokep> It calls each handler successively based on a priority they order themselves with.
00:45:03 <EionRobb> is the js-irc protocol in one js file?
00:45:12 <clokep> It's split across a few files.
00:45:26 <EionRobb> what if you copy-pasted them so that there's 2 of each of the files in the same dir?
00:46:16 <clokep> I'm not sure why that would matter, they're called based on which one get's registered as prpl-irc.
00:46:27 <clokep> You could overwrite it if you wanted to, that's what my extension does to the libpurple one.
00:46:36 <EionRobb> ok, so there's a uniqueness check on the id?
00:46:59 <clokep> It's the last one registered with that ID.
00:51:48 --> DGMurdockIII has joined #instantbird
00:53:02 <clokep> If that makes any more sense.
00:53:28 <clokep> Extensions can do pretty much whatever you want, so if they register something with the same component ID, that one will be used instead.
00:53:40 <clokep> But it's all done via registering, not magic directory location stuff. :)
00:53:50 <clokep> (And a component can be in any language, not just JS.)
00:57:06 <EionRobb> interesting that it's the *last* one registered that you use
00:59:31 <clokep> I'm confused, are you talking about protocols in general (which is stuff handled by the Mozilla platform) or my IRC stuff?
00:59:42 <clokep> My IRC stuff you register a handler object, there can be many registered at the same time.
01:00:10 <clokep> They're ordered by a priority, I loop over them from highest to lowest until one of them says that they were able to do something with the received message or I run out of things to try.
01:01:54 <EionRobb> if you register two plugins with the same id, you're saying the last one is used
01:02:51 <clokep> "plugins" doesn't really make sense.
01:03:00 <clokep> Do you mean "protocol plug-ins"?
01:03:22 <clokep> Extensions are all assumed to have a unique ID, but that doesn't really matter much.
01:04:11 <EionRobb> plugins/addons/extensions  all mean the same thing to me :)
01:07:37 <clokep> OK, that's fine. But I don't know what you're talking about right now! :P Are you talking about how we register protocols?
01:08:23 <clokep> You could do something like http://hg.instantbird.org/experiments/file/tip/irc-js@patrick.cloke/chrome.manifest#l3 to totally replace a protocol implementation inside of Instantbird.
01:08:59 <clokep> (The first line points to the actual file, the second one overwrites the protocol ID, the third one registers that protocol ID into the new component category)
01:10:49 <EionRobb> where's your code for the IB skype wrapper code, btw?
01:11:07 <clokep> On my computer.
01:11:11 <clokep> It's not a wrapper, just a makefile.
01:11:22 <EionRobb> oh, you don't have to write any IB glue code?
01:11:27 <clokep> No.
01:11:31 <EionRobb> interesting
01:12:11 <clokep> EionRobb: I'll be embarrassed to show you this I'm sure: http://pastebin.instantbird.com/1331
01:12:29 <clokep> (And for other protocols: see http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/ )
01:12:42 <clokep> The wrapper code is auto-generated from http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/xpcomModule.cpp.in I believe
01:13:13 <-- EionRobb has quit (Ping timeout)
01:14:20 --> EionRobb has joined #instantbird
01:19:34 <-- Tomek has quit (Quit: Instantbird 1.1)
01:21:02 <clokep> So theoretically it should be a snap to add protocols from libpurple (if thye compile w/ MSVC :P), it was fairly easy for SIPE. But apparently both of yours are giving trouble.
01:21:25 <clokep> Doh, I think I had figured it out the other day though...I don't have any of the l10n files in there, I'm not sure if that would cause a crash or not though.
01:25:27 <clokep> Do we think this is spam? http://blog.instantbird.org/2011/05/status-update-april-2011-may-2011/#comments
01:28:54 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
02:49:32 --> Prescience500 has joined #instantbird
03:16:33 <-- Prescience500 has quit (Client exited)
03:21:56 --> Prescience500 has joined #instantbird
03:39:41 <clokep> With that newest patch (+ removing libpurple IRC) I'm at 33 files changed, 2824 insertions(+), 4523 deletions(-).
03:40:06 <EionRobb> looks like spam to me
03:56:47 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
04:03:11 --> hunsly has joined #instantbird
04:24:15 <-- hunsly has quit (Ping timeout)
04:52:11 <-- Prescience500 has quit (Client exited)
04:58:27 <-- EionRobb has quit (Quit: Leaving.)
05:56:47 <-- DGMurdockIII has quit (Quit: get satisfied! • :: core-networks.de ««« (Gamers.IRC) »»» gamersirc.net ::)
05:59:53 --> Mook has joined #instantbird
06:56:39 --> hunsly has joined #instantbird
06:57:54 <Mook> man, I'm not even sure if this is JS anymore: let { ircBase } = Cu.import("resource:///modules/ircBase.jsm", {});
07:01:57 <-- hunsly has quit (Ping timeout)
07:19:40 <-- skeledrew has quit (Ping timeout)
07:49:46 <-- Mook has quit (Ping timeout)
07:51:23 --> Mook has joined #instantbird
07:59:24 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603])
07:59:29 --> Mad_Maks has joined #instantbird
08:04:33 --> skeledrew has joined #instantbird
08:15:33 --> gerard-majax has joined #instantbird
08:16:40 <-- gerard-majax has quit (Connection reset by peer)
08:33:43 --> gerard-majax has joined #instantbird
08:34:48 --> jb has joined #instantbird
08:35:52 --> chrisccoulson has joined #instantbird
08:36:22 <-- gerard-majax has quit (Ping timeout)
08:39:19 --> gerard-majax has joined #instantbird
08:49:07 --> MadWookiee has joined #instantbird
08:52:50 --> Mic has joined #instantbird
08:52:50 * ChanServ sets mode +h Mic 
09:11:01 <-- gerard-majax has quit (Ping timeout)
09:24:55 --> aleth has joined #instantbird
09:25:24 <-- Even has quit (Quit: Instantbird 1.2a1pre)
09:25:33 --> Even has joined #instantbird
09:25:33 * ChanServ sets mode +o Even 
09:47:56 <-- Mic has quit (Ping timeout)
09:53:12 --> mmkmou has joined #instantbird
09:53:49 --> flo has joined #instantbird
09:53:49 * ChanServ sets mode +qo flo flo 
09:57:36 --> Mic has joined #instantbird
09:57:36 * ChanServ sets mode +h Mic 
09:57:57 <flo> hello :)
10:00:30 <-- mmkmou has left #instantbird ()
10:04:01 <Mic> hi
10:07:22 <Mic> Accounts are reconnecting after stand-by for me now.
10:08:23 <Mic> They aren't disconnecting when going into stand-by though but time-out after returning from stand-by and reconnect then.
10:08:56 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
10:09:02 --> aleth has joined #instantbird
10:13:10 <flo> I'm not sure if that's an improvement or just a different bug :-S
10:21:51 <flo> clokep: Components.classes["@instantbird.org/prpl-skype;1"].createInstance(Components.interfaces.prplIProtocol); is clearly not the right way to instantiate a libpurple prpl.
10:23:06 <flo> the component containing the libpurple prpl is Components.classes["@instantbird.org/prpl-@PROTOCOL@;1"].createInstance(Components.interfaces.purpleIPlugin);
10:23:19 <flo> that contains a single registerSelf method, used to make the plugin register itself with libpurple
10:25:48 <flo> then once the protocol plugin is known by libpurple, you can get an instance of prplIProtocol by calling: let prpl = Components.classes["@instantbird.org/purple/protocol;1"].createInstance(Components.interfaces.prplIProtocol).init("<prpl id known by libpurple, prpl-bigbrownchunx-skype in the case of skype>");
10:27:07 <flo> the reason the protocol doesn't appear in the account wizard is that the core calls the init method of prplIProtocol with what has been registered for the im-protocol-plugin category, and in your case it's prpl-skype
10:27:32 <flo> the two possible solutions are either to edit the prpl code to remove "bigbrownchunx-" from the prpl id
10:28:23 <flo> or to change http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/xpcomModule.cpp.in#52 to contain @PRPL_ID@ instead of @PROTOCOL@, and then add a replacement for PRPL_ID in the makefile (defaulting to the value of PROTOCOL if nothing has been specified)
10:55:10 <aleth> Is this a bug report? https://twitter.com/#!/mortonfox/status/142262484634570752
10:55:21 <aleth> Never happens to me fwiw
10:55:57 <aleth> Not sure how one would respond
10:58:02 <flo> I think we have a bug on file for it
10:58:07 <flo> or at least we discussed it in the past
10:59:16 <flo> bug 1113
10:59:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1113 nor, --, ---, nobody, NEW, Twitter should start from the last read tweet
11:00:21 <aleth> Oh OK. Another problem to be solved by better logging/always provide context
11:01:29 <aleth> I more often encounter the opposite "problem" due to IB not shutting down correctly.
11:14:46 --> clokep has joined #instantbird
11:14:46 * ChanServ sets mode +h clokep 
11:28:31 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 †1809))
11:29:12 <instantbot> New Instantbird (UI) bug 1191 filed by benediktp@ymail.com.
11:29:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1191 enh, --, ---, nobody, NEW, Make the user icon placeholder look even more like a placeholder
11:32:03 --> SM0TVI has joined #instantbird
11:54:22 <-- BlueMaxima has quit (Quit: Instantbird 1.1)
11:55:19 <instantbot> New purplexpcom - General bug 1192 filed by aletheia2@fastmail.fm.
11:55:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1192 nor, --, ---, nobody, NEW, MSN does not display user icons
11:59:20 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
12:07:35 <-- Mic has quit (Ping timeout)
12:10:06 * aleth is impressed pdf.js comes as a restartless add-on
12:19:33 --> gerard-majax has joined #instantbird
12:21:24 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
12:22:03 <-- Mad_Maks has quit (Ping timeout)
12:22:05 --> Mad_Maks has joined #instantbird
12:24:27 --> aleth has joined #instantbird
12:25:20 --> Mic has joined #instantbird
12:25:20 * ChanServ sets mode +h Mic 
12:47:15 --> clokep_work has joined #instantbird
12:47:16 * ChanServ sets mode +h clokep_work 
12:48:54 <clokep_work> aleth: Is there a libpurple bug on file as well? We should include that in the bug report, if so.
12:51:47 <aleth> clokep_work: I don't know how best to search for that. Also, flo mentioned IB was not using the same msn protocol version as the latest libpurple
12:52:01 <clokep_work> Ah, true. :(
12:52:10 <flo> clokep_work: do you mean for the broken buddy icons?
12:52:22 <flo> that was a known bug of the msn prpl for a long while
12:52:27 <flo> I don't know if it's fixed now
13:02:40 <-- gerard-majax has quit (Quit: Ex-Chat)
13:06:58 --> gerard-majax has joined #instantbird
13:13:11 <flo> clokep_work: do my comments earlier today clarify things with the prpl registration, or are you even more confused now?
13:17:02 <aleth> clokep_work: This one maybe http://developer.pidgin.im/ticket/12999
13:24:24 <flo> yes, it's this one.
13:24:54 <flo> with a status of "Any progress? -> Yes, but not enough to fix things yet. Our MSN developers are very busy at the moment. " for the last 9 months or so :)
13:25:30 <aleth> Doesn't look like anything will happen there. The bug is absent in the xmpp msn transport btw
13:26:22 <flo> which transport is that? The one developed by hanzz who said it works fine with msnp15?
13:27:19 <aleth> I'm not sure who developed it or if there are more than one.
13:29:46 <clokep_work> flo: Kind of, I had tried putting it as the @PROTOCOL@ but that of course doesn't work because variable names can't have a - in them. :)
13:31:06 <flo> variable names?
13:31:49 <flo> putting non [a-z0-9] characters inside the PROTOCOL variable seems like asking for trouble anyway
13:32:42 <clokep_work> Yes, doesn't @PROTOCOL@ get used as a class name inside of the xpcom*.in file? Well regardless, it caused a compile error.
13:32:56 <clokep_work> I think your comments made sense, the idea of having a PRPL_ID sounded best.
13:33:53 <clokep_work> (And thanks for checking over IRC again...apparently I was getting tired toward the end of the day. :( Some silly mistakes.)
13:37:12 <aleth> flo: this the one you mean? http://plone.lucidsolutions.co.nz/linux/im/python-msn-gateway
13:37:48 <flo> clokep_work: well, the really useful review comments about IRC came from Mook
13:38:04 <flo> I only read his review comments today ;)
13:38:33 <flo> I was quite surprised that he hasn't pointed out that you wanted to use getComplexValue
13:38:42 <flo> but it's possible that wasn't obvious without knowing what that pref contains
13:38:52 <aleth> There only seems to be one (pyMSNt)
13:38:54 <clokep_work> I need to look up what that does.
13:39:02 <clokep_work> I've seen it before but had no idea it had anything to do with what I was seeing.
13:39:28 <flo> aleth: no. I thought *you* had one in mind, as you said it works with it.
13:40:30 <aleth> flo: I could ask the guys running the server what they have installed if you are interested
13:40:34 <flo> aleth: the one I had in mind is http://spectrum.im/
13:41:21 <aleth> Hmm, interesting
13:47:34 <-- Mad_Maks has quit (Quit: Instantbird 1.2a1pre)
13:50:18 --> XaviorPenguin has joined #instantbird
13:50:26 <-- XaviorPenguin has left #instantbird ()
13:50:59 <flo> clokep_work: do you have any (good? :)) idea for a not-too-unpleasant API to indicate which value is the default for a preference that has a list of possible values?
13:51:47 <aleth> hanzz seems to be working on a version of it called libtransport atm (hard to tell exactly what it does without digging into the source)
13:52:21 <clokep_work> flo: Is it stored in an object or an array?
13:52:54 <flo> object
13:53:23 <clokep_work> You can give a defaultKey as something we pass also. :-/
13:55:07 <clokep_work> I have a meeting, need to go. :(
13:55:29 <flo> that code seems more broken than I thought
13:55:40 <flo> I guess I'll just have to redesign the part I don't like ;)
13:59:17 --> Mad_Maks has joined #instantbird
14:04:22 --> waynenguyen has joined #instantbird
14:15:49 <flo> hmm, apparently that poor API is inherited from libpurple :(
14:30:42 --> ecaron has joined #instantbird
14:41:53 <Mic> ecaron: did you hear anything from the Instantbird-page admin in Facebook?
14:41:58 <Mic> Hi, btw :)
14:43:03 <ecaron> no, i haven't yet.
14:45:33 <ecaron> flo: Are there any owned copyrights on the Instantbird name?
14:45:56 <flo> ecaron: I registered a trademark in France on the name and logo.
14:46:43 <flo> I've never extended it outside of France, as that was way to expensive
14:47:02 <Mic> If all else fails we could think about reporting the page at Facebook?
14:47:15 <Mic> Which would be very bad imo :(
14:47:39 <Mic> Since you don't create a page for a project if you don't like it :(
14:47:58 <ecaron> I think we need to proceed with reporting it.
14:48:12 <flo> is there any other way to contact the current owner?
14:48:13 <ecaron> Filling out Facebooks' "Notice of Intellectual Property Infringement" form is the proper step.
14:48:28 <ecaron> No, Facebook goes signficantly out of their way to hide it.
14:48:46 <ecaron> (They used to unintentionally make that available since it'd just be the first "fan" of a page is the admin)
14:48:50 <flo> Mic: yes, it's sad as all the content there seems friendly (even though outdated)
14:49:43 <ecaron> flo: Can you look at https://www.facebook.com/legal/copyright.php?noncopyright_notice=1 and see if you'd feel comfortable filling it out?
14:50:15 <ecaron> Does "Ignacio Vidal" ring a bell?
14:51:04 <flo> probably just a random fan... I've never seen that name before
14:51:59 <Mic> ecaron: I'm the other guy who asked on the facebook page btw ;)
14:52:13 <flo> ecaron: by the way, does it matter at all if we are the owner or not? Can't we just (like everybody else) write on the wall when we have something to announce?
14:53:14 <ecaron> That would work except the page defaults to showing Wall posts by "Instantbird", so the page will always look outdated. (Nobody would think to click "Everyone" to see the actual news updates.)
14:53:16 <flo> Mic: "I'm the other guy who asked on the facebook page btw ;)" where is that visible?
14:53:55 <flo> ah
14:53:58 <flo> is that a recent change?
14:53:59 <Mic> Go to the page and click "Show all" (?) on the top right over the news feed there
14:54:08 <flo> I think at the time I posted the link to the 1.1 announcement, it was visible
14:56:07 <ecaron> Might it have been created by "Alexandre Abraham"?
14:56:34 <flo> I don't think so but you can ask him
14:57:03 <ecaron> What's his handle?
14:57:14 <flo> at some time in the past our polish localizers were also active on facebook and created a translated website at instantbird.pl before we officially supported it, so they may also have done that page
14:57:48 <flo> I think the page he created has an "official" email address
14:57:52 <flo> (he = Alexandre)
14:59:12 <flo> https://www.facebook.com/group.php?gid=9091979396&v=info ->     iloveinstantbird @ instantbird.org
15:01:22 <flo> https://www.facebook.com/pages/Instantbird/107796122578527 seems to be the page made by the Polish team
15:01:26 <ecaron> Right, that's what made me wonder if he created both.
15:06:54 <flo> Alexandre confirmed on gtalk that he hasn't created that page
15:17:28 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
15:19:04 <ecaron> flo: Would you fill out that infringement page?
15:19:23 <flo> I think we should wait a few more days before becoming aggressive
15:20:09 <flo> how do their electronic signatures work?
15:20:48 <ecaron> Its just a gentleman's agreement.
15:20:52 <ecaron> You just type your name.
15:21:19 <flo> ecaron: shouldn't we try to email contact@ ib.org (the public mailing list) and the translator mailing list?
15:21:35 <flo> if the owner is a fan, he may be following us in some way :)
15:22:35 <ecaron> Are you ok with me writing that email?
15:22:49 <flo> sure
15:23:06 <flo> hmm, I'm not sure you are allowed to post to the translator mailing list, but if you aren't we should fix that
15:32:17 <flo> clokep_work: proposed change to the account options API: http://pastebin.instantbird.com/1454
15:35:45 <aleth> that should get rid of another one of those undefined warnings as a bonus :)
15:36:15 <flo> aleth: yes :)
15:36:50 <aleth> And is *much* nicer code
15:41:01 <-- Mad_Maks has quit (Quit: Instantbird 1.2a1pre)
15:41:10 <-- jb has quit (Connection reset by peer)
15:41:12 --> jb has joined #instantbird
15:44:24 <aleth> niggle: maybe move |this._defaultValue = aOption.default;| (and preceding) below the point where it is checked that aOption.default is actually valid
15:45:44 * aleth is never quite sure when |...| formatting will actually work
15:47:13 <flo> aleth: it doesn't work when we want it to ;)
15:48:50 <flo> aleth: I'm not completely sure that test is useful
15:49:00 <flo> the only invalid value it seems to catch is |undefined|
15:50:34 <aleth> Of course I don't know if that ever occurs, but it's a good reason to have the test above the point where one tries to get the value
15:51:18 <flo> I'm wondering if replacing that with "if (aOption.default === undefined || aOption.default === null) throw "The option need to have a default value for its type to be defined";" would be better
15:53:56 <flo> hmm, the |object: "List"| part doesn't make sense any more
15:54:26 <aleth> I was just trying to find a list of possible types in JS...
15:54:33 <aleth> Shouldn't the first condition be !(default in aOption)
15:55:10 <flo> I see no point in avoiding a JS strict warning when the next line will throw anyway ;)
15:55:32 <flo> avoiding warnings during correct execution is useful, but when there's some faulty code, warnings are good :)
15:55:46 <aleth> heh. true :)
15:56:42 <flo> aleth: how about http://pastebin.instantbird.com/1462 ?
15:57:30 <aleth> Does null have a type?
15:57:42 <flo> typeof(null) -> object
15:58:56 --> Mic has joined #instantbird
15:58:56 * ChanServ sets mode +h Mic 
15:59:38 <aleth> Looks good to me.
16:03:42 <flo> that .masked is never used
16:03:58 <flo> that's too bad, it would be nice in protocol overrides to be able to keep an option internally but hide it
16:04:08 <flo> that would make it easy to provide a default value
16:04:36 <Mic> ecaron: can you try contacting this "Ignacio Vidal"?
16:05:12 <flo> Mic: do you think that liking a random post on that page makes him more likely to be the owner than the other 100 or so fans?
16:05:13 <Mic> It seems the "Joined Facebook" message on the wall dates to 9:42:16 am UTC  |  Saturday, June 5, 2010
16:05:38 <Mic> And his "Like" is at 9:49:07 am UTC  |  Saturday, June 5, 2010
16:05:47 <flo> ah
16:05:53 <Mic> Seven minutes is pretty few to notice a new page ;)
16:06:11 <aleth> flo: What do you mean by "hide it"? Isn't it effectively hidden if you don't need to set it in aOption
16:06:28 <flo> aleth: what do you mean?
16:06:32 <Mic> I extracted the unix timestamps that sit on each wall entry and compared them, that's why I think it might be worth contacting him.
16:06:44 <aleth> flo: I didn't understand you, that's all
16:08:55 <flo> Mic: nice :)
16:30:51 <-- Mic has quit (Connection reset by peer)
16:49:25 <clokep_work> flo: Should I still look at http://pastebin.instantbird.com/1454 ?
16:50:02 <flo> only little error checking details in the purplePref constructor have been changed since that
16:51:07 <-- gerard-majax has quit (Ping timeout)
16:52:16 <clokep_work> flo: Is "masked" just that it's a hidden option?
16:55:19 <flo> it should be
16:55:24 <flo> currently it's unused
16:56:07 <clokep_work> I thought it was to mark something as a "password", i.e. to mask the characters.
16:56:20 <clokep_work> And that patch looks better. :) Not too much different, but a lot less magic.
16:56:22 <flo> hmm, maybe
16:56:49 <flo> let's see what pidgin does with it
16:58:17 <flo> clokep_work: you are right, it's to hide passwords
16:59:18 <flo> we could easily support that feature by setting the type attribute to password on the textbox for these options then.
16:59:33 <flo> That would be a nice improvement for the users of the *0* prpls using that feature :-P
17:02:15 <clokep_work> Hahah, yes. :)
17:03:32 <aleth> Would that be useful for identd?
17:03:57 <clokep_work> I have no idea how identd works yet, so...;)
17:04:06 <clokep_work> "No comment" I'll og with.
17:04:40 <aleth> Nor do I ;) Can't think of many instances where one would enter a password otherwise
17:07:01 <flo> do you all agree that we should provide an advanced account pref for the resource?
17:07:12 <flo> (I think we all agreed that the resource has nothing to do in the username at least)
17:07:51 <clokep_work> Yes.
17:08:08 <clokep_work> And it should default to Instantbird I assume?
17:08:20 <aleth> Good idea.
17:08:23 <flo> yes
17:08:46 <flo> the other option is to just not provide the option at all and always use "instantbird"
17:09:47 <clokep_work> I think it's reasonable as an option if someone uses Instantbird in two locations.
17:10:08 <flo> I'll hack things around so that if the user enters a full JID in the username field and hasn't changed the default value of the resource pref, what he entered will be used
17:10:28 <aleth> Tangentially related - advanced options should have explanatory tooltips, normal options shouldn't need them.
17:11:15 <flo> you can do that if you like
17:11:24 <flo> (file a bug and/or write patch...)
17:11:35 <flo> I'm not doing it :-P
17:12:49 <aleth> I might... it's only some which are not self-explanatory.
17:13:31 <flo> shouldn't they be fixed instead?
17:13:41 <aleth> If possible, of course
17:14:47 <aleth> I'm thinking of the case where e.g. someone does not quite know what 'resource' or 'alias' means but would easily understand a short answer
17:15:25 <aleth> Maybe it's illusory to think one can do that in a tooltip though
17:15:28 <flo> I would argue that someone who doesn't know what "resource" means should either Google it or not touch it
17:17:39 <aleth> You're probably right. I just remembered there is a separate new account wizard anyway which should handle that kind of thing for most people.
17:23:03 <clokep_work> Meeting today?
17:23:13 <flo> yes, 23 minutes ago :)
17:24:11 <flo> someone creates a pad?
17:27:42 <aleth> https://etherpad.mozilla.org/instantbird-weekly-meeting-20111205
17:33:06 <-- MadWookiee has quit (Quit: Instantbird 1.1)
17:41:05 <flo> aleth: ping Even if add-on review are waiting for too long
17:41:26 <clokep_work> flo: Is Evry in France?
17:41:38 <flo> clokep_work: yes, at the north of Paris I think
17:41:47 <clokep_work> OK. :)
17:41:53 <aleth> flo: I don't even know what is going on there behind the scenes, I just noticed the "2 add-ons in queue" hasn't changed in a while
17:42:04 <clokep_work> Was wondering what the other option of "understandable English" was. ;)
17:42:10 <flo> ah, no south
17:42:11 <flo> http://en.wikipedia.org/wiki/%C3%89vry,_Essonne
17:42:44 <flo> clokep_work: it can be nonsense in english, or nonsense in french ;)
17:43:01 <clokep_work> :) True. 
17:44:00 --> Mic has joined #instantbird
17:44:01 * ChanServ sets mode +h Mic 
17:44:27 <aleth> You work in shifts in your office? or why do you have to leave?
17:44:36 <Mic> Hi, I'm just 44 minutes late, ain't I?
17:45:29 <clokep_work> Who's leaving?
17:45:58 <aleth> flo -  "I have to leave at 7pm every day"
17:46:09 <flo> because people go home
17:46:15 <clokep_work> Ah.
17:46:17 <flo> and I don't have the key of the door (yet ;))
17:46:24 <aleth> Ah.
17:47:03 <flo> clokep_work: handling buddies shouldn't be difficult. Just look at JS-XMPP and copy/paste :-D
17:47:18 --> Mook_as has joined #instantbird
17:48:11 <clokep_work> flo: That was my plan. :)
17:48:33 <Mic> flo: what's the "this year" in context of the students? This and next term?
17:48:34 <clokep_work> I'll try to get it done tonight.
17:48:45 <clokep_work> Mic: As opposed to previous years?
17:48:55 <Mic> This calendar year isn't that long anymore
17:49:04 <flo> not calendar year :)
17:51:10 <clokep_work> Yes.
17:51:18 <clokep_work> I mean as opposed to the "last group" of people.
17:51:28 <Mic> Are they going to follow own ideas or should we think of nice things that could be appropriate for a given amount of time and knowledge?
17:51:44 <clokep_work> Mic: The wiki page for extensions was cleaned up by aleth.
17:51:44 <flo> both
17:51:59 <flo> clokep_work: I cleaned it up too yesterday evening
17:52:02 <aleth> not just by me
17:53:04 <Mic> Ah, cool, I'll have a look
17:53:06 <flo> Mic: I said I don't want to give them strictly defined projects but that they should work on something that they like. We provide a wiki page with a list of ideas that they can follow, but they are free to come up with other ideas
17:53:25 <Mic> I can image that there was quite some stuff that is either no longer interesting or already implemented
17:53:40 <flo> or plain nonsense
17:53:48 <flo> some of the points were rants rather than ideas
17:54:01 <Mook_as> bah, yeah, I missed where you want getComplexValue (since the string needs to be wide). I'm not catching enough l10n issues :p
17:54:29 <flo> the string needs to be wide??
17:57:02 <Mic> I need to go again :( Good luck with the meeting!
17:57:02 <Mook_as> the away message needs to be able to hold unicode
17:57:35 <flo> I still don't understand the issue/how this is related :-/
17:57:57 <Mook_as> oh, sorry, no, I was just reading through scrollback
18:01:28 <clokep_work> Thanks for the review though Mook_as. :)
18:01:52 <Mook_as> you're welcome - and thanks for having something for me to review ;)
18:02:04 <clokep_work> There's plenty there! Next I'll make you read the specs. :p
18:03:23 <Mook_as> no thanks, I'd like to keep what sanity I have left
18:03:26 <flo> Mook_as: would you like to review JS-XMPP too?
18:03:55 <aleth> Mook_as: or have a look at the regexps in message parsing to see what could be speeded up?
18:04:17 <Mook_as> flo: feel free to flag me; I can look when I have time. (just don't block checkin on me)
18:04:45 <Mook_as> aleth: please /memoserv send Mook with the relevant info (since I'd be doing any looking at home, where I wouldn't be _as)? :)
18:05:10 <flo> what about a r? flag in bugzilla? ;)
18:05:38 <Mook_as> flo: yeah, that's what I meant by flagging me; the regexp stuff sounds like it won't be a patch review :)
18:05:59 <flo> I haven't said anything about the regexp
18:06:13 <flo> except that if you have any idea of how we could profile them, that would be awesome :-D
18:06:16 <Mook_as> yeah, that was the bit to aleth :)
18:06:30 <flo> uh, sorry
18:06:54 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
18:06:59 <Mook_as> no problem. I'll assume you're having monday morning issues in sympathy ;)
18:07:25 <flo> "morning" at 7pm? :-P
18:07:46 <Mook_as> in sympathy to my time zone - it's morning here :p
18:08:03 <flo> ahah :)
18:08:22 <flo> it's evening here (already the night outside), and I'm hungry :-D
18:13:54 <clokep_work> Is the plan still js-xmpp for overrides only until we figure out DNS SRV?
18:14:10 <clokep_work> (Also...I don't remember there being a Facebook override? But I guess it's mostly the same sa the current one. :))
18:14:49 <flo> I still need to create a facebook override
18:15:08 <flo> the only difference in behavior will be that "chat.facebook.com" will no longer be part of the username
18:16:11 <flo> and in the future, if the user has entered an email address (that isn't @chat.facebook.com) we will attempt to authenticate through OAuth (and remove a stupid entry from our FAQ)
18:19:08 <clokep_work> :)
18:22:53 <flo> the Resource option doesn't make sense for facebook, right?
18:23:19 <clokep_work> Do they even support it?
18:23:43 <flo> I'm not completely sure, but I suspect it's not visible on the other side
18:24:30 <clokep_work> I don't think I've ever talked to anyone on FB chat that was also using an IM program. :P
18:25:15 <aleth> If they have one, they probably wouldn't be using FB chat to talk to you :P
18:27:51 <clokep_work> You never know. ;)
18:29:36 <flo> bah, I still have a bug with HTML escaping :(
18:29:51 <flo> clokep_work: and you may have it too now
18:30:05 <flo> if we tell the conv binding to not HTML escape the messages before sending them
18:30:17 <flo> then we need to escape them in the prpl code before displaying the outgoing messaegs in the converastion
18:30:50 <clokep_work> :( That's inconvenient.
18:30:56 <clokep_work> Can we put a corresponding if statement in there?
18:31:07 <flo> "in there" = ?
18:31:17 <clokep_work> In the message display code.
18:31:36 <flo> probably not a good idea
18:33:37 <clokep_work> OK. :(
18:33:59 <clokep_work> Could we put it into the writeMessage function of GenericConversationPrototype?
18:36:35 <flo> what about putting this in imXPCOMUtils or jsProtoHelper instead?     Components.classes["@mozilla.org/txttohtmlconv;1"]
18:36:36 <flo>               .getService(Ci.mozITXTToHTMLConv)
18:36:36 <flo>               .scanTXT(aText, Ci.mozITXTToHTMLConv.kEntities),
18:37:59 <clokep_work> Yes. :)
18:45:49 <flo> I've attached a new WIP
18:46:14 <flo> I'll add a facebook.js and maybe a few comments then I think it'll be ready to land :)
18:46:29 <-- flo has quit (Quit: Instantbird 1.2a1pre)
19:08:54 <clokep_work> Cool. :)
19:10:47 <-- Novarg has quit (Ping timeout)
19:10:53 --> Novarg has joined #instantbird
19:12:31 --> EionRobb has joined #instantbird
19:16:57 --> DGMurdockIII has joined #instantbird
19:24:21 --> gerard-majax has joined #instantbird
19:35:10 <-- DGMurdockIII has quit (Quit: get satisfied! • :: core-networks.de ««« (Gamers.IRC) »»» gamersirc.net ::)
20:05:47 --> flo has joined #instantbird
20:05:47 * ChanServ sets mode +qo flo flo 
20:08:07 <-- jb has quit (Quit: Instantbird 1.1)
20:19:41 --> BlueMaxima has joined #instantbird
20:19:42 --> Mnyromyr has joined #instantbird
20:33:05 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
20:33:14 --> aleth has joined #instantbird
20:34:18 <-- EionRobb has quit (Quit: Leaving.)
20:49:38 <flo> hmm, has the override protocol concept ever been useful for non-XMPP plugins?
20:52:28 --> EionRobb has joined #instantbird
20:53:17 --> Mic has joined #instantbird
20:53:17 * ChanServ sets mode +h Mic 
20:53:59 <clokep_work> flo: It could be for IRC I suppose, but besides that I'm not sure.
20:54:06 <clokep_work> (What else supports different "networks"?)
20:54:15 <flo> oscar
20:54:27 <flo> yahoo with yahoo japan
20:54:46 <flo> but the overrides for these are done at the libpurple level
20:54:51 <EionRobb> myspace
20:55:00 <flo> really?
20:55:10 <EionRobb> yeah, myspace and skype link together
20:56:29 <EionRobb> would you include the aim|gtalk link in that all too? :)
20:56:36 <flo> no
20:56:46 <flo> we were discussion protocols that were used for several different networks
20:56:50 <flo> *discussing
20:57:01 <flo> not different networks talking to each other
20:57:04 <EionRobb> ah
20:57:07 <EionRobb> oops, sorry :)
20:57:08 <clokep_work> Right, I assumed we ewren't including Oscar (AIM/ICQ) or Yahoo/Yahoo Japan.
20:57:29 <clokep_work> Since they're set up as different protocols (like gtalk and xmpp too actually?)
20:57:53 <flo> "like gtalk and xmpp too" uh??
20:58:42 <clokep_work> In libpurple, isn't GTalk set up as a separate protocol?
20:58:59 <flo> no
20:59:01 <EionRobb> not exactly
20:59:11 <flo> it's just a hack in the UI I think
20:59:25 <EionRobb> it (c|sh)ould be though
20:59:26 <flo> (it was the last time I looked at least)
20:59:32 <flo> hmm, bonjour?
20:59:39 <flo> but that's XMPP again
21:04:18 <clokep_work> Doesn't bonjour just show up as bonjour? :P
21:04:30 <clokep_work> Oh, is it really?
21:06:13 <flo> I think it's serverless XMPP (http://xmpp.org/extensions/xep-0174.html)
21:08:37 <EionRobb> that's the one
21:11:20 <clokep_work> Ah, interesting.
21:11:42 <clokep_work> Is the Apple Bonjour stuff do anything on top of that that makes it "proprietary" or not really?
21:12:12 <EionRobb> nope, all works together fairly well
21:12:17 <clokep_work> Ah, cool. :)
21:12:19 <flo> the stuff used from the apple sdk for the bonjour libpurple plugin is the DNS part
21:12:29 <flo> (on Windows)
21:12:37 <flo> on Linux there's an open source alternative
21:12:44 <flo> and on Mac everything is in the system already
21:13:50 <EionRobb> the library that adium uses for bonjour creates slightly different html than what libpurple does though
21:13:54 <aleth> Even Apple has opensourced it https://developer.apple.com/opensource/
21:14:09 <EionRobb> and I don't think the libpurple impl supports adium's formatting
21:14:33 <aleth> http://xmpp.org/2007/06/bonjour/
21:14:53 <aleth> ah, that's flo's link, basically
21:16:23 <flo> EionRobb: I remember Adium sending strange markup for AIM too. It basically wrapped each message in a <HTML><BODY> or something like that
21:16:34 <clokep_work> I was wondering what the Apple library provieded, thanks flo. :)
21:16:53 <clokep_work> (And I knew it was open source. ;) Although the license is kind of funky I thought.)
21:17:09 <flo> clokep_work: we already have a hard time getting DNS SRV in the platform, so supporting bonjour promises to be fun ;)
21:17:51 <Mook_as> clokep_work: apache2 + bsd for lgpl-equivalent is odd? ( http://opensource.apple.com/source/mDNSResponder/mDNSResponder-333.10/LICENSE )
21:18:52 <aleth> clokep_work: Yep, you have to send them a passed test before you download the bonjour logo ;)
21:20:09 <Mook_as> ah, the windows sdk bits come under a different license
21:20:15 <clokep_work> Yes. :P
21:20:42 <Mook_as> ship a mingw-compiled version of the source instead :p
21:22:54 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:22:59 --> aleth has joined #instantbird
21:25:32 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
21:28:28 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:33:46 <flo> bug 703929 is ready to land :)
21:38:31 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:38:34 --> aleth has joined #instantbird
21:39:24 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:39:28 --> aleth has joined #instantbird
21:44:08 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:44:11 --> aleth has joined #instantbird
21:45:35 <instantbot> New Instantbird (UI) bug 1193 filed by aletheia2@fastmail.fm.
21:45:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1193 nor, --, ---, nobody, NEW, Only the first IRC channel on hold automatically reconnects along with the account
21:47:56 <flo> aleth: only auto-joined chats are joined again when you reconnect
21:50:18 <aleth> That would explain it.
21:50:50 <aleth> Is that really the desired behaviour?
21:51:49 <flo> it's the expected behavior of the implementation. Probably not of the user ;)
22:05:47 <flo> JavaScript strict warning: chrome://instantbird/content/account.xml, line 248: reference to undefined property this.reconnectUpdateInterval
22:05:51 <flo> when deleting an account
22:09:56 --> clokep has joined #instantbird
22:09:56 * ChanServ sets mode +h clokep 
22:10:12 <aleth> I thought that was one of the ones with a fix committed :(
22:12:21 --> hunsly has joined #instantbird
22:12:40 <flo> aleth: we fixed an invalid caller of cancelReconnectTimer, but this time it's the destroy method
22:13:20 <flo> how can we comment out lines in .manifest files?
22:13:21 <aleth> Right, and it's exactly the same thing.
22:13:43 <flo> I would like to comment out "category im-protocol-plugin prpl-xmppjs @instantbird.org/purple/xmpp;1" before pushing ;)
22:13:50 <aleth> flo: #comment
22:14:14 <flo> aleth: I hesitated between # and //
22:14:50 <instantbot> clokep@gmail.com set the Resolution field on bug 1193 to DUPLICATE of bug 385.
22:14:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1193 nor, --, ---, nobody, RESO DUPLICATE, Only auto-joined IRC channels automatically reconnect along with the account
22:14:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, nobody, NEW, Rejoin IRC channels after reconnect
22:15:29 <aleth> js-irc to the rescue? ;)
22:17:20 <flo> maybe ^^
22:17:43 <clokep> It's blocking bug 507. ;)
22:17:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=507 enh, --, ---, clokep, ASSI, Implement IRC in JavaScript
22:17:50 <clokep> Sorry, I mean it depends on that bug.
22:18:02 <clokep> So it's on my todo list. :)
22:18:43 <-- Gizmokid2005 has quit (Ping timeout)
22:18:55 --> Gizmokid2005 has joined #instantbird
22:20:06 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1056 on bug 1182.
22:20:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
22:21:20 <clokep> Is BMO slow for everyone else?
22:22:15 <flo> aleth: why are you touching that method that we fixed already?
22:23:11 <flo> and the "// clearInterval is harmless if the timer doesn't exist." comment doesn't make sense any more with your change
22:23:21 <Mook_as> clokep: yes; the phoenix datacenter is having issues today
22:23:21 <aleth> You're absolutely right
22:23:31 <flo> I think I would just return early if (!this.reconnectUpdateInterval)
22:24:31 <aleth> Yes
22:24:54 <aleth> I clearly had my mind on something else I was doing ;)
22:27:24 <aleth> Neither of those were methods we had changed recently though
22:27:53 <flo> we changed the callers of the first method
22:29:02 <aleth> not here https://hg.instantbird.org/instantbird/diff/5558759bb593/instantbird/content/account.xml
22:29:10 <aleth> unless there was another commit
22:29:22 <clokep> Mook_as: I think you missed a null check in your function. ;)
22:29:42 <Mook_as> clokep: maybe! I also need to remove a +1 in the ctcp tag mashing function
22:29:49 <flo> aleth: this is exactly the caller we changed
22:29:49 <clokep> exec returns null if it's not found, is that correct?
22:29:54 <aleth> and "// clearInterval is harmless if the timer doesn't exist." is wrong in the sense that that's exactly what throws the warning
22:29:58 <Mook_as> (I was testing with "^B", "^U" etc instead of "\x02", etc.
22:30:06 <Mook_as> yeah, exec returns null on no match
22:30:25 <Mook_as> clokep: (also, which function? I think I wrote two :p )
22:30:55 <clokep> OK. :) the ctcpFormat one.
22:33:43 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1056 on bug 1182.
22:33:44 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1057 on bug 1182.
22:33:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
22:34:41 <Mook_as> clokep: so, which null check? the only exec I have there is a condition for a while loop?
22:35:00 <aleth> flo: Oh, I think I see what you mean
22:35:29 <aleth> I'd already forgotten about the call path there :/
22:36:14 <clokep> Mook_as: Ah, you're right. The loop won't even run when thta's null. :(
22:36:33 <Mook_as> however, that _does_ mean it's written unclearly and should be fixed :D
22:36:35 <flo> just when I was about to attach what I have and request review, I found 2 bugs
22:36:54 <Mook_as> flo: odd; for me, it's normally right after I attach things
22:36:58 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1057 on bug 1182.
22:36:59 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1058 on bug 1182.
22:37:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
22:37:20 <flo> Mook_as: I think I'll keep some for right after pushing ;)
22:37:47 <aleth> Mook_as: as I just demonstrated ;)
22:38:28 <Mook_as> aleth: no, getting somebody else to look is cheating :p
22:41:15 <clokep> Mook_as: Why |    input = input.substr(next.index + 2); // I'm using ^foo for now|?
22:41:18 <clokep> Why +2?
22:41:28 <Mook_as> clokep: because that should also be +1 and remove the comment :D
22:41:34 <flo> Mook_as: I haven't looked at attachment 1058
22:41:53 <Mook_as> (as I mentioned, I tested with ^B instead of \x02, and I don't think i cleaned up properly... oops)
22:41:55 <clokep> Mook_as: Ah you meant you were literally using the string "^B"?
22:41:58 <Mook_as> yep!
22:42:04 <clokep> Got it. :)
22:42:31 <Mook_as> (it was easier to type in js shell :p )
22:42:31 <flo> I meant 1057 of course :(
22:42:36 <flo> gmail displayed my bugmail in the wrong order :(
22:44:43 <clokep> I modified it slightly: http://pastebin.instantbird.com/1519
22:45:08 <Mook_as> clokep: please also remove +1 on line 20
22:45:29 <Mook_as> at least, I think that was the other spot I should have fixed in ^B -> \x02 change
22:45:35 <clokep> Ah, good catch. :)
22:45:47 <Mook_as> I cheated; I knew there were two spots, just not where :p
22:46:00 <clokep> I changed how you were closing tags off the stack btw. :)
22:46:19 <clokep> Starting at "offset" instead of "offset + 1" and then closing "offset" manually. ;)
22:46:51 <Mook_as> in that case, you can move the splice to before the re-opening?
22:47:48 <-- BlueMaxima has quit (Quit: Instantbird 1.1)
22:48:04 <clokep> And then just go from index again?
22:48:09 * flo likes when the bug he finds can be fixed in less than 30s :)
22:48:31 <clokep> Mook_as: I think I prefer it the way it is, instead of the index changing half way through the block.
22:48:31 <Mook_as> yep
22:48:42 <Mook_as> hmm, yeah, okay, that works too :)
22:50:25 <clokep> Mook_as: I don't think you can put a semicolon where you wanted one (at the end of |l10nHelper("chrome://instantbird/locale/instantbird.properties")|).
22:51:07 <Mook_as> clokep: oh, you're right
22:51:31 <clokep> :)
22:51:47 <clokep> flo: Did we decide about the HTML escapifying for message display? Or is that in your newest patch and didn't notice.
22:51:49 <Mook_as> (don't do this, but you can l10nHelper.bind(null, "chrome://...") - but that's stupid because it's even less readable)
22:52:09 <flo> It's in the new patch
22:52:18 <flo> in the xmpp code, not jsProtoHelper
22:52:20 <clokep> OK. I'll check it out.
22:52:31 <clokep> Alright.
22:53:08 <flo> clokep: you have removed that whole line (with the bundle), right?
22:53:16 --> XaviorPenguin has joined #instantbird
22:53:30 <-- XaviorPenguin has left #instantbird ()
22:53:57 <flo> private messages to MUC participants are broken, that's a known bug. I'm too tired to fix it this evening :-)
22:54:11 <clokep> flo: What line with the bundle?
22:54:35 <flo> the one were Mook wanted a semicolon
22:54:37 <flo> *where
22:55:26 <clokep> Ah, I actually read that as my other bundle (the code is exactly the same).
22:55:32 <clokep> I will remove that though, yes. :)
23:00:30 --> XaviorPenguin has joined #instantbird
23:00:48 <-- XaviorPenguin has left #instantbird ()
23:03:28 <-- Mook_as has quit (NickServ (GHOST command used by Mook_as_))
23:03:49 --> Mook_as has joined #instantbird
23:04:12 --> EionRobb1 has joined #instantbird
23:04:16 <-- EionRobb has quit (Ping timeout)
23:07:22 --> BlueMaxima has joined #instantbird
23:08:01 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
23:28:18 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1059 on bug 1171.
23:28:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1171 nor, --, ---, florian, ASSI, Replace the current binary XMPP plugin with a JS implementation
23:28:50 <clokep> flo: I'll apply that patch in a few minutes and give it a try! :)
23:29:19 <flo> it only replaces facebook and gtalk
23:29:34 <clokep> I use both of those.
23:29:46 <clokep> I'll just need to talk to random people on Facebook and they'll be like "Why are you talking to me?"
23:30:00 <clokep> Mook_as: That's a pretty slick way to pull out the CTCP messages while leaving any "other" content. :)
23:30:07 <flo> my main google talk account was added in Instantbird before we got the Gtalk override, so it's still using prpl-jabber :-/
23:30:23 <clokep> Why not change it over?
23:30:53 <flo> well, I would need to save blist.sqlite and prefs.js before ;)
23:31:22 <Mook_as> clokep: that came out of the other escaping thing ( /\x7f./ or whatever it was) we talked about earlier, actually :D
23:31:53 <-- ecaron has quit (Quit: Instantbird 1.1)
23:43:18 <-- hunsly has quit (Ping timeout)
23:46:28 <clokep> aleth: Not to make you cry...but I thnk your spacing is wrong in that newest patch.
23:47:32 <aleth> lol
23:48:52 <aleth> Am gonna beat the maximum number of resubmissions for the most trivial patch ;)
23:49:19 <aleth> Though in my defense the spacing is wrong in that entire file. Indent is not an even number of spaces.
23:51:15 <clokep> I don't know what's with that. :-/
23:51:26 <clokep> I think a lot of (our?) bindings are that way.
23:52:31 --> DGMurdockIII has joined #instantbird
23:53:12 --> hunsly has joined #instantbird
23:53:26 <aleth> clokep: Yes :( And it's really annoying.
23:54:27 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1058 on bug 1182.
23:54:28 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1060 on bug 1182.
23:54:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
23:58:21 <aleth> clokep: Should there be a twitter context menu option to block spam followers? Is there such a thing?
23:58:46 <clokep> aleth: You can "report people for spam" from the emails. I'm not sure if the API supports it or not.
23:59:05 <aleth> clokep: Is that the same as blocking them from following you?
23:59:49 <clokep> Yes.