#instantbird log on 12 02 2011

All times are UTC.

00:01:05 <flo> conversation.writeMessage(aMessage.nickname, joinMessage, {system: true}); feels like something that should be in jsProtoHelper
00:02:02 <clokep> What file are we in now? :)
00:02:45 <flo> ircRfc2812.jsm
00:03:36 <clokep> flo: Yes I feel like it should be.
00:03:48 <clokep> (Or in the core.)
00:03:57 <clokep> When we notify the conversation of a buddy joining.
00:03:59 <flo> uh, yeah, in the core
00:04:03 <flo> not jsProtoHelper
00:04:11 <flo> imConversations.js
00:04:27 <clokep> Yes, I think we had discussed this (there might even be a bug for it)
00:05:03 <flo> if we don't do it in the core, it will suck for my XMPP MUCs too!
00:05:44 <clokep> :) Yes.
00:05:45 <flo> + the way you are constructing strings by concatenating lots of small parts is crazy. :-P
00:06:14 <flo> like Mook mumbled about string concat being evil for user-visible things ;)
00:06:19 <-- Plop has quit (Quit: Instantbird 1.1)
00:06:21 <clokep> :-D
00:06:35 <clokep> I'll try to get all these "programming" stuff finished first, then do the l10n.
00:07:15 <flo> aren't you going to program the l10n too?
00:07:57 <clokep> Yes.
00:08:35 <flo> do you know how the core will decide if a system message is needed?
00:09:00 <clokep> When a user joins?
00:09:04 <flo> what's the difference between the nick list being loaded asynchronously after joining the room, and new people entering?
00:09:31 <clokep> I don't know.
00:09:40 <clokep> (Also something like Twitter you'd probably never want join messags.)
00:10:08 <flo> right
00:10:18 <flo> or some, but customized ("you are now following ...")
00:10:37 <flo> but twitter isn't a real muc :-S
00:12:07 <-- DGMurdockIII has quit (Quit: get satisfied! • :: core-networks.de ««« (Gamers.IRC) »»» gamersirc.net ::)
00:12:36 <flo> "this._account.connectionState == Ci.purpleIAccount.STATE_CONNECTED" uh ?
00:12:47 <flo> why not this._account.connected ?
00:13:46 <flo> the this._account = aAccount may be in jsProtoHelper soon. I have this change inside my xmpp patch
00:13:50 <clokep> I have no idea.
00:13:58 <clokep> Yes, I saw that. :)
00:14:34 <clokep> If we're not going to land JS-XMPP soon I'd appreciate if some of the socket/jsProtoHelper/other core changes land soonish.
00:15:20 <flo> define "soon" and "soonish"
00:16:55 <clokep> Next couple of weeks.
00:17:08 <flo> why do you have a setTopic method instead of using the jsProtoHelper one?
00:17:19 <clokep> Uhh...I think it was in IRC first. :)
00:17:28 <clokep> Is it the same?
00:18:38 <flo> it's very strange that the chat-update-topic has a null aSubject parameter, but purplexpcom does taht too
00:18:38 <clokep> bug 793 added it...
00:18:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=793 nor, --, 1.0, clokep, RESO FIXED, Twitter timeline should have a topic
00:18:42 <flo> no, it's not the same
00:18:50 <flo> but I suspect the difference is a bug
00:19:34 <clokep> Yes, I should remove it.
00:21:04 <flo> in this.onDataReceived, the handled variable doesn't seem useful
00:22:12 <clokep> You're right.
00:22:16 <flo> on the socket: |log: ERROR| really?
00:22:30 <clokep> It's good for debugging. ;)
00:23:17 <flo>       this._sendMessage("AWAY", [aMsg || "I am away from my computer."]);
00:23:23 <flo> why is there an hard coded message here?
00:23:33 <flo> how does it help for debugging? O_o
00:23:37 * Mook_as mumbles
00:23:58 <clokep> flo: Because LOG doesn't show up unless you put the verbosity level high enough in which case I get lot sof other crap.
00:24:05 <clokep> So I leave it on ERROR and only get those messages.
00:24:15 <flo> in disconnect: "} else" -> "}\nelse"
00:24:42 <clokep> I probably do that a lot. :(
00:24:54 <flo> only the second time I notice this evening
00:25:01 <clokep> I'll make a note to check that throughout my code though.
00:25:05 <flo> easy to search with an editor
00:25:16 <clokep> Mook_as: are you becoming like instantbot now? :)
00:25:29 <clokep> I don't know why I hardcoded a message there.
00:25:32 <Mook_as> clokep: only while I"m waiting for stuff to build :p
00:25:37 <Mook_as> ( warning: interface 'nsICache' not derived from nsISupports... wtf?)
00:25:37 <flo> "I get lot sof other crap" are you doing this to debug JS-IRC on your default profile?
00:25:53 <clokep> flo: No, it's my dev profile, but it has a few accounts in it.
00:25:57 <clokep> I could make a new one though.
00:26:07 <flo> right
00:26:13 <flo> that's what I did for js-xmpp
00:26:24 <flo> and now I have 6 or so accounts in it already :(
00:26:26 <clokep> K, I'll do thata.
00:26:27 <flo> (all XMPP though!)
00:27:00 <clokep> Same server? ;)
00:27:38 <flo> hmm, I should check that I don't have problems with < > & on XMPP
00:28:01 <clokep> Komodo tells me I have 14 occurences of } else in 6 files. ;)
00:28:06 <flo> various servers, various settings, ...
00:28:21 <Mook_as> does the logging not depend on the purple.debug.loglevel.irc pref?
00:28:38 <Mook_as> oh, nevermind, read the logger wrong
00:29:01 <flo> Mook_as: we could improve it :)
00:29:12 <Mook_as> yep
00:29:59 <clokep> I wish there was a .irc part of that pref. :)
00:30:31 <flo> you just volunteered to implement that
00:30:40 <Mook_as> gimme a minute
00:30:47 <flo> (I wish it was done based on environment variables though) :-D
00:30:57 <flo> (but I guess I've just volunteered for that part)
00:32:01 <Mook_as> untested: http://pastebin.mozilla.org/?diff=1389988
00:32:44 <clokep> I think that's what I was going for in bug 575 or bug 430, just some way to control/view it by protocol.
00:32:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=575 enh, --, ---, nobody, RESO DUPLICATE, Improve Error Console for Protocol/Account Errors
00:32:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=430 enh, --, ---, nobody, NEW, Error Console: filter by account/protocol
00:33:09 <flo> I definitely want a per account console
00:33:18 <flo> with syntax highlighting/pretty printing
00:33:24 <flo> and maybe a way to send raw data on the socket
00:33:25 <Mook_as> I want a pony
00:33:53 <Mook_as> (of course, I'd want one that doesn't need food, exercise, or cleanup)
00:34:20 <clokep> Mook_as: That looks good. Does getPrefType not throw errors if it doesn't exist?
00:34:36 <Mook_as> clokep: it returns PREF_INVALID instead
00:35:09 <flo> It's too late to review code :(
00:35:14 <flo> Good evening/night! :)
00:35:28 <Mook_as> good.. err, morning? it's morning _somewhere_ :p
00:35:29 <flo> I've an office to move tomorrow morning :(
00:36:00 <-- flo has quit (Quit: Instantbird 1.2a1pre)
00:36:23 <clokep> Thanks flo! That was very helpful. :)
01:05:06 <clokep> Mook_as: Does this look correct? (Do you see any issues w/ it)? http://pastebin.instantbird.com/1146
01:06:27 <Mook_as> yeah, but I'd be lazy and return replacements[aStr[1]] || aStr[1]
01:07:01 <clokep> :)
01:07:25 <clokep> We'll see how flo likes that. :)
01:08:10 <Mook_as> just remember, you need his r+, not mine :p
01:08:57 <Mook_as> oh, that pastebin has ads?
01:09:18 <Mook_as> (and spam, too!)
01:12:52 <clokep> Now the second questoin...can http://pastebin.instantbird.com/1147 be simplified?
01:13:30 <clokep> (It would seem like you could directly replace \x5Ca with \x01, but I also need to replace\x5C. with ., I guess I could do it as two replacements.)
01:13:37 <clokep> I'm not sure if that's "simpler" or not.
01:14:07 <clokep> And I think that might not work in some random situations.
01:28:10 <Mook_as> I think the as-pasted version will end up clearer
01:28:44 <clokep> The other way wouldn't replace \x5C\x5Ca correctly anyway.
01:28:51 <clokep> (Where a is meant to be a real character in this case.)
01:31:00 --> BlueMaxima has joined #instantbird
01:40:15 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
01:45:25 <-- Mook_as has quit (Quit: gone)
02:10:41 <clokep> flo: That's great that the Search API is almost the same as the other APIs.
02:20:14 <-- Tomek has quit (Ping timeout)
02:34:22 <-- Even has quit (Connection reset by peer)
02:35:00 --> Even has joined #instantbird
02:35:00 * ChanServ sets mode +o Even 
03:44:04 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
06:29:42 --> Guido has joined #instantbird
06:33:42 <-- BlueMaxima has quit (Quit: Instantbird 1.1)
06:38:15 --> hunsly has joined #instantbird
07:22:33 --> gerard-majax has joined #instantbird
07:28:02 <-- gerard-majax has quit (Ping timeout)
07:28:34 <-- hunsly has quit (Ping timeout)
07:36:48 --> gerard-majax has joined #instantbird
07:39:06 <-- gerard-majax has quit (Ping timeout)
08:23:51 <-- SM0TVI has quit (Ping timeout)
08:27:32 --> SM0TVI has joined #instantbird
08:54:41 --> Mic has joined #instantbird
08:54:41 * ChanServ sets mode +h Mic 
08:55:25 --> MadWookiee has joined #instantbird
08:59:07 --> XaviorPenguin has joined #instantbird
08:59:14 <-- XaviorPenguin has left #instantbird ()
09:13:36 <Mic> Hello
09:15:06 --> jb has joined #instantbird
09:16:46 --> BlueMaxima has joined #instantbird
09:28:44 --> Tomek has joined #instantbird
09:41:36 --> mmkmou has joined #instantbird
09:43:22 <-- mmkmou has left #instantbird ()
09:45:41 <-- Guido has quit (Quit: Instantbird 1.1)
09:51:49 <-- jb has quit (Quit: Instantbird 1.1)
09:54:58 --> flo has joined #instantbird
09:54:58 * ChanServ sets mode +qo flo flo 
09:56:41 <-- Tomek has quit (Quit: Instantbird 1.1)
10:02:51 <flo> hello :)
10:04:25 --> Guido has joined #instantbird
10:05:39 <-- chrisccoulson has quit (Quit: Ex-Chat)
10:05:44 --> chrisccoulson has joined #instantbird
10:09:42 --> jb has joined #instantbird
10:15:24 --> gerard-majax has joined #instantbird
10:35:08 <-- Guido has left #instantbird ()
10:41:08 <flo> clokep: are you going to work on making the necessary changes in the core so that we don't have to implement the "has left the room" / "entered the room" system messages in all js-prpls, or do I need to add that to my todo list
10:41:08 <flo> ?
10:41:18 <flo> (btw, XMPP mucs seem to work :))
11:01:31 <Mic> Seems like you're making good progress with JS-XMPP :)
11:01:41 <Mic> I thought you're going to move office today?
11:02:09 <flo> done
11:02:39 <flo> The Mac builder (powerbird) is offline because it's in my car currently 
11:16:46 --> clokep has joined #instantbird
11:16:46 * ChanServ sets mode +h clokep 
11:29:41 <clokep> flo: I can take a look at it, although wasn't there the issue of knowing whether we should show the message or not?
11:30:11 <flo> if we can't decide, you add add a flag somewhere on the method
11:30:31 <flo> s/add/can/1
11:32:28 <clokep> OK.
11:33:03 <clokep> Added it to my todo list.
11:33:45 <flo> and for your question about how soon I want to integrate JS-XMPP.
11:33:49 <flo> My target is this evening
11:33:57 <flo> although I may miss it if I discover serious bugs today
11:37:48 <clokep> Awesome! :-D
12:00:55 --> clokep1 has joined #instantbird
12:01:08 <-- clokep has quit (Ping timeout)
12:05:31 <-- clokep1 has quit (Quit: Instantbird 1.2a1pre)
12:06:09 --> hunsly has joined #instantbird
12:15:49 <-- gerard-majax has quit (Ping timeout)
12:45:20 --> clokep_work has joined #instantbird
12:45:20 * ChanServ sets mode +h clokep_work 
12:57:06 <-- hunsly has quit (Ping timeout)
12:59:12 --> aleth has joined #instantbird
13:01:34 --> Tomek has joined #instantbird
13:11:37 <flo> hmm, it seems the code doesn't escape the html special chars before sending :-S
13:17:41 <clokep_work> Is this the issue I was having previously in IRC? :P
13:20:46 <flo> no
13:20:57 <flo> well, I would have that issue if my code worked correctly
13:21:10 <flo> (or Varuna's code...)
13:21:54 <flo> hmm, should Components.classes["@mozilla.org/txttohtmlconv;1"].getService(Ci.mozITXTToHTMLConv) be added to imServices.jsm?
13:26:26 <clokep_work> That would probably be helpful. :)
13:34:44 <flo> by the way, how do < > & behave on twitter?
13:38:16 <clokep_work> I've never tested it. It's possible that the Twitter API handles it for us anyway.
13:40:55 <flo> sending &lt; inside a JSON string seems like a strange idea, so I don't think the API should handle it
13:42:41 <clokep_work> Wouldn't they want to make sure they handle it internally though as a security measure?
13:42:52 <clokep_work> Oh, wait.
13:42:59 <clokep_work> Never mind I was thinking of it the opposite way.
13:43:06 <clokep_work> We should be sending them < and they should make it into &lt;
13:43:15 <clokep_work> (Internally for display, etc. etc.)
13:43:22 <flo> why? They send us a JSON string
13:43:49 <clokep_work> Do we receive the entities already HTML escaped?
13:44:12 <flo> what are you talking about?
13:44:22 <flo> we use the JSON format, not XML
13:44:32 <flo> " characters are escaped with \
13:44:43 <flo> but I don't see why it would escape HTML (XML) special chars
13:47:31 <clokep_work> What are you talking about then?
13:47:38 <clokep_work> Why do we care about < > & on Twitter?
13:47:48 <flo> because the textbox is HTML escaped
13:48:00 <flo> twitter is in the same situation as IRC
13:48:03 <clokep_work> OK, that's what I'm talking about too.
13:48:29 <clokep_work> And I don't think we handle it on Twitter right now.
13:48:40 <flo> so it's likely broken
13:48:59 <flo> we'll need to test that soon ;)
13:50:11 --> XaviorPenguin has joined #instantbird
13:50:28 <-- XaviorPenguin has left #instantbird ()
13:52:16 <clokep_work> Yes. :(
13:52:25 <clokep_work> For XMPP they're just left escaped I assume?
13:52:27 <clokep_work> That's convenient. :P
13:52:47 <flo> right
13:52:55 <flo> that's why I haven't noticed the problem initially
13:53:08 <flo> (the problem is that xmpp-xml.jsm doesn't XML encode text node data)
13:53:22 <flo> just try to set a status message containing < and your connection is dead...
13:55:00 <clokep_work> :-/
13:55:40 <-- jb has quit (Quit: Instantbird 1.1)
13:59:01 <flo> hmm, I wonder if we should change the conversation API to not HTML escape things
14:01:28 <flo> clokep_work: by the way, the simplification Mook proposed seemed fine
14:02:17 <clokep_work> flo: Great, that's what I ended up using. :)
14:03:02 <clokep_work> My argument had been that the text returned by the textbox shouldn't be HTML escaped but after conversing with you and EionRobb, that's what Pidgin does...so that's probably why we did it to start with.
14:03:13 <clokep_work> (But I suppose we could just HTML escape before handing to prpls if that's what they expect.)
14:03:39 <flo> yeah, we could just call scanTXT from the C++ code
14:03:40 * instantbot frowns at flo
14:04:06 <flo> ah, no we can't :(
14:04:16 <flo> as we are adding HTML tags after that in the code
14:04:51 <flo> so... we could do it in conversation.xml only if account.HTMLenabled (I think this is the behavior you expected)
14:04:59 <flo> and do it from C++ if !account.HTMLEnabled
14:05:00 --> jb has joined #instantbird
14:06:53 <clokep_work> I think that's the behavior I expected, yes.
14:07:16 <flo> shouldn't we get rid of the account.noNewlines flag, and handle that internally?
14:10:46 <clokep_work> I'm not sure what that flag does actually.
14:10:55 <flo> it's for IRC
14:11:14 <flo> it makes the conversation binding send a message per line, rather than a message containing line breaks
14:11:47 <flo> I wouldn't be that surprised to discover it isn't a real limitation of the protocol though ;)
14:13:45 <clokep_work> It is a limitation of the protocol.
14:13:50 <clokep_work> Messages are separated by \r\n.
14:14:08 <clokep_work> I think it'd make more sense to handle it internally then.
14:14:19 <clokep_work> (We could choose to CTCP escape them then! :P)
14:14:54 <flo> can't we just put \r for line breaks?
14:15:04 <flo> I'm almost sure I've seen clients doing that
14:16:43 <clokep_work> I'm not sure if all clients would handle that, but possibly.
14:18:31 <flo> I'm not sure I want to know :-P
14:19:11 <flo> but I really think we need to clean up that method though :)
14:19:42 <clokep_work> Can you put me to this method? :)
14:20:00 <clokep_work> (Regardless of whether we send \r or break it up, etc...we should definitely handle it in IRC, not the UI.)
14:20:29 <flo> "put me to this method"?
14:21:12 <clokep_work> point me
14:21:37 <flo> http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#289
14:23:39 <flo> I'm pondering unescaping in js-xmpp for now, or doing a hack somewhere else (like for example adding another flag indicating that no HTML means no HTML escaping)
14:24:02 <flo> the hackish solution would let us avoid touching the twitter code
14:24:04 <clokep_work> Eek that handles a lot of protocol specific things. :(
14:24:43 <flo> I remember being really unhappy at the time of writing that formatting code
14:25:01 <flo> (I'll never use formatted messages anyway)
14:28:27 <clokep_work> Well we don't handle formatting right now anyway, do we?
14:28:42 <flo> we do :(
14:28:55 <clokep_work> Oh, right.
14:29:00 <clokep_work> You just can't set it in the text box.
14:29:06 <clokep_work> You have to ste it as your preference.
14:33:30 <flo> ok, I've decided to go for the hack ^^
14:34:27 <clokep_work> Alright.
14:34:43 <clokep_work> Are you going to special case prpl-xmppjs then?
14:36:40 <flo> oh, no
14:36:44 <flo> I'll special case libpurple :-P
14:38:13 <clokep_work> Ah-ha! :-D
14:38:46 <clokep_work> Just put a comment in saying what it sends to each prpl so I'll know what to use with IRC (I'll even except an r? for it. ;))
14:38:56 <flo> hmm, why does jsProtoHelper details HTMLEnabled to true?
14:43:48 <clokep_work> I don't know. One of us did that most likely, was it arbitrary?
14:46:28 <flo> clokep_work: http://pastebin.instantbird.com/1150
14:46:43 <flo> s/details/defaults/
14:47:43 <flo> I think it was arbitrary, yes
14:54:35 --> gerard-majax has joined #instantbird
14:55:51 <clokep_work> flo: That seems good! :)
14:56:15 <flo> it will probably let you remove a piece of unfortunate code in JS-IRC :)
14:56:41 <clokep_work> Yes, it should let me remove a few regexp replaces! :)
14:56:47 <-- gerard-majax has quit (Ping timeout)
14:56:49 <clokep_work> I always forget what HTMLEnabled actually does. :(
14:57:09 <flo> it tells the conversation binding to insert stupid formattings
14:57:12 <clokep_work> Ah, it treats things as HTML.
14:57:19 <clokep_work> As would be implied. :-S
14:57:30 <clokep_work> But now we're treating HTML entity escaping differently! Perfect. :)
15:06:31 <flo> wow, the API around the idle time is stupid :(
15:06:59 <clokep_work> Our API or the way XMPP treats it? :P
15:07:05 <flo> our API
15:07:22 <flo> which is partly inherited from what I needed to interact with libpurple
15:12:06 --> gerard-majax has joined #instantbird
15:13:52 <clokep_work> Yes, that hasn't been made prettier yet.
15:17:55 <-- gerard-majax has quit (Ping timeout)
15:19:11 <-- Tomek has quit (Ping timeout)
15:19:14 --> Tomek has joined #instantbird
15:20:08 --> ecaron has joined #instantbird
15:21:35 <-- Tomek has quit (Quit: Instantbird 1.1)
15:25:56 --> instantbot has joined #instantbird
15:25:57 topic changed by gravel.mozilla.org to "Ask questions about Instantbird (http://www.instantbird.com) here|Get Instantbird 1.1 while it's hot! :) |News: http://blog.instantbird.org/ |Nightlies: http://nightly.instantbird.im/ (testing purpose only) |IRC logs: http://log.bezut.info/ |Pastebin: http://pastebin.instantbird.org/"
15:25:57 * ChanServ sets mode +v instantbot 
15:39:23 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
15:39:24 <-- harisund has quit (Ping timeout)
15:44:48 --> harisund has joined #instantbird
15:51:46 <-- harisund has quit (Ping timeout)
15:57:37 --> harisund has joined #instantbird
16:00:26 <-- harisund has quit (Ping timeout)
16:04:10 --> harisund has joined #instantbird
16:20:13 <-- BlueMaxima has quit (Quit: Instantbird 1.1)
16:57:11 * flo has attached a new WIP in bug 1171
16:57:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1171 nor, --, ---, florian, ASSI, Replace the current binary XMPP plugin with a JS implementation
17:07:10 --> Mic1 has joined #instantbird
17:07:19 * Mic1 is now known as bp
17:08:57 <flo> clokep_work: is there an example somewhere of an option with a type list (using jsProtoHelper)?
17:10:06 <flo> ah; http://lxr.instantbird.org/instantbird/source/chat/protocols/jsTest/jsTestProtocol.js#114
17:10:27 <bp> I'm not sure if it's worth a comment on the bug but wouldn't it make sense to split the value of PROTOCOLS into several lines in Makefile.in? Adding/removing a protocol would been cleaner then (i.e. not affecting the unchanged parts of the string)
17:10:53 <flo> which string is that?
17:11:02 <bp> "PROTOCOLS = gtalk twitter overrides xmpp"
17:12:50 <flo> bp: done
17:13:09 <bp> :)
17:23:55 <flo> clokep_work: do you remember if there's a way to select a default value which isn't the first one for List options?
17:30:37 <-- MadWookiee has quit (Quit: Instantbird 1.1)
17:33:08 <-- micahg has quit (Connection reset by peer)
17:34:03 --> micahg has joined #instantbird
17:44:54 <clokep_work> flo: I don't think there's a way to preselect something that isn't the first value. I think we had no use case at the time.
17:45:14 <flo> after looking more, I think it's completely broken :(
17:45:22 <clokep_work> :(
17:46:04 <clokep_work> flo: As a total aside, we should probably have a list somewhere of what XEPs we support.
17:46:20 <flo> http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#626 especially seems broken
17:47:12 <flo> clokep_work: what's the use case?
17:48:36 <clokep_work> flo: People asking.
17:49:12 <flo> anybody should feel free to make that list on the wiki then :)
17:49:21 <flo> (= I'm not going to do that myself)
17:51:06 <-- chrisccoulson has quit (Client exited)
17:55:27 <clokep_work> Ah Iw as actually thinking that http://en.wikipedia.org/wiki/Comparison_of_XMPP_server_software existed for clients.
17:57:38 <clokep_work> It still could be useful to have though, but I'll let someone who cares more about XMPP build it. :P
17:57:42 <-- bp has quit (Ping timeout)
17:58:03 * clokep_work likes having references back to the documentation.
18:01:05 --> Mic1 has joined #instantbird
18:02:22 <clokep_work> We should get listed on http://xmpp.org/xmpp-software/clients/ I don't have XMPP here though. :(
18:03:36 --> aleth has joined #instantbird
18:06:36 <clokep_work> I can do it later on today I guess.
18:06:48 <-- Mic1 has quit (Quit: Instantbird 1.2a1pre)
18:13:50 --> chrisccoulson has joined #instantbird
18:20:17 <aleth> flo: re " http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#626 especially seems broken" - I looked at that code due to the options.maskesd undefined warning nearby and it confused me then. I put it down to not understanding the context
18:22:04 <flo> Good evening
18:22:05 <-- flo has quit (Quit: Instantbird 1.2a1pre)
18:25:40 <-- chrisccoulson has quit (Quit: Ex-Chat)
18:42:01 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
18:42:18 --> aleth has joined #instantbird
18:49:39 --> Mook has joined #instantbird
18:50:23 --> Mnyromyr has joined #instantbird
18:56:32 <-- gmoro_ has quit (Quit: Leaving)
18:57:07 --> gmoro_ has joined #instantbird
19:31:47 --> DGMurdockIII has joined #instantbird
19:35:19 --> igorko has joined #instantbird
20:14:39 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
20:17:22 <-- gmoro_ has quit (Ping timeout)
20:19:30 --> aleth has joined #instantbird
20:21:24 <-- Mook has quit (NickServ (GHOST command used by Mook_))
20:22:07 --> Mook has joined #instantbird
20:33:00 --> hunsly has joined #instantbird
20:36:07 --> gmoro_ has joined #instantbird
21:00:24 <-- skeledrew has quit (Ping timeout)
21:04:42 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:07:16 <-- ecaron has quit (Quit: Instantbird 1.1)
21:09:43 --> ecaron has joined #instantbird
21:10:29 <-- ecaron has quit (Quit: Instantbird 1.1)
22:03:17 * Mic just got a "Select your Add-ons"-screen for Instantbird. I can't remember that I saw that before?
22:03:33 <Mook> gecko 8?
22:03:54 <Mic> I definitely had updated to a Geck 8 or later based nightly before
22:04:20 <Mic> Maybe I haven't used the profile in question since then though.
22:04:48 <Mic> brb
22:04:59 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
22:05:33 --> Mic has joined #instantbird
22:05:33 * ChanServ sets mode +h Mic 
22:05:55 --> ecaron has joined #instantbird
22:07:06 --> ecaron1 has joined #instantbird
22:07:35 <-- ecaron has quit (Ping timeout)
22:09:11 <-- Mook has quit (Ping timeout)
22:10:12 --> Mook has joined #instantbird
22:19:02 <-- igorko has quit (Quit: Instantbird 1.1)
22:19:58 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:34:21 --> flo has joined #instantbird
22:34:21 * ChanServ sets mode +qo flo flo 
22:37:18 <-- jb has quit (Ping timeout)
22:41:45 --> XaviorPenguin has joined #instantbird
22:42:10 <-- XaviorPenguin has left #instantbird ()
23:00:21 <Mic> instantbot, when did you stop telling us about new attachments?
23:00:24 <instantbot> Mic: Sorry, I've no idea what 'when did you stop telling us about new attachments' might be.
23:01:17 <Mook> bugzilla upgrade, IIRC
23:13:12 --> clokep has joined #instantbird
23:13:12 * ChanServ sets mode +h clokep 
23:23:56 <clokep> Mic: That drop target is fineeeeee. :)
23:30:49 <aleth> Looks great! :)
23:35:15 <flo> Mic: yes, the bugzilla update changed the format of emails, and Morian had to hack the code of the bot to fix it for compatibility...
23:35:35 <flo> they made pointless changes like "flag" -> "flags" in the emails, so instantbot couldn't match things any more
23:37:56 <Mook> hmm, it seems to have also broken my bugzilla review script
23:39:00 --> BlueMaxima has joined #instantbird
23:39:30 <flo> Mic: I told Morian about it, he said he'll try to fix this during the week-end
23:41:27 <flo> Mic: what's the point of the stack with a single child node?
23:42:00 <flo> you know it's possible to put several classes on a single element, right? :)
23:42:37 <Mic> Yes, but there was still a problem with the bottom margin at least.
23:42:41 <flo> aleth: what's the relation between these 2 bugs?
23:43:18 <Mic> That's why I didn't falg it for review yet
23:43:23 <Mic> *flag
23:43:28 <flo> ok :)
23:43:41 <flo> I was about to ask if you intented to request review or if it was a WIP :)
23:44:25 <aleth> flo: It would need to be slightly modified after/when the statusicon/purpleicon css is moved to a separate css file
23:44:57 <aleth> Afaik that streamlining has been effectively r+ for a while now
23:46:01 <aleth> s/purpleicon/protoicon
23:46:42 <aleth> No substantial conflict there of course
23:46:54 --> clokep1 has joined #instantbird
23:47:16 <aleth> (Is there a better field for "patch would conflict with other patch"?
23:47:34 <-- clokep has quit (Ping timeout)
23:52:47 <flo> aleth: no. But a comment in either of the bug explaining the relationship is nice, when it's not obvious :)
23:53:22 <aleth> OK :)
23:59:05 <Mic> aleth: thanks for the heads-up. I didn't even know that there was such a bug.