#instantbird log on 11 28 2011

All times are UTC.

00:00:57 <flo> |undefined != null| -> false, though
00:01:51 <aleth> I wonder if undefined = null internally
00:02:00 <aleth> Shouldn't be really
00:06:21 <flo> I've done some work on https://bugzilla.mozilla.org/show_bug.cgi?id=14328 this evening
00:07:11 <aleth> yay :)
00:07:20 <aleth> That must be one of the very oldest bugs...
00:08:13 <aleth> I see people are offering cash :D
00:09:22 <aleth> Should it be marked as blocking something in IB?
00:10:31 <clokep> We have an instantbird bug in bmo aleth .
00:10:44 <clokep> https://bugzilla.mozilla.org/show_bug.cgi?id=instantbird
00:11:19 <clokep> So it could be made to block that if someone wanted to. :) Although you don't have editbugs on BMO probably.
00:11:20 <aleth> and 14328 is not listed there, that's what I meant
00:11:31 <flo> aleth: it should be blocking Thunderbird ;)
00:11:34 <clokep> I'll add it.
00:11:51 <flo> as its XMPP support will suck without DNS SRV queries ;)
00:12:54 <clokep> I don't think there's a general Thunderbird blocking bug. :P
00:14:37 <flo> bah...
00:14:48 * flo disliked comment 103
00:17:54 <clokep> That it was never mentioned before that point? :(
00:18:05 <-- Plop has quit (Ping timeout)
00:18:32 <flo> that the guy has done some incomplete work and would like people to adopt it instead of working on things that are likely to work
00:19:10 <flo> it's just a pure stop energy comment...
00:19:31 <flo> s/likely to work/likely to work soon/
00:20:43 <clokep> Yeah. :-/ I've found his attitude in the past to be a bit offsetting.
00:22:09 <flo> I hope my reply won't be perceived as too rude :)
00:23:18 <flo> anyway, good night! :)
00:23:20 <-- flo has quit (Quit: Instantbird 1.2a1pre)
00:24:02 <clokep> I think it was fine. :)
00:24:50 --> Plop has joined #instantbird
00:27:02 <-- Tomek has quit (Quit: Instantbird 1.1)
00:28:13 <-- Plop has quit (Quit: Instantbird 1.1)
00:28:35 <-- billysanca has quit (Connection reset by peer)
00:28:43 --> billysanca has joined #instantbird
00:49:03 --> franksouza1831 has joined #instantbird
00:53:44 <-- franksouza183 has left #instantbird ()
01:01:38 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
01:01:42 --> franksouza1831 has joined #instantbird
01:02:04 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
01:02:09 --> franksouza1831 has joined #instantbird
01:06:45 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
01:06:49 --> franksouza1831 has joined #instantbird
01:08:51 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
01:08:55 --> franksouza1831 has joined #instantbird
01:17:10 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
01:17:15 --> franksouza1831 has joined #instantbird
01:41:12 --> BlueMaxima has joined #instantbird
01:42:18 <BlueMaxima> What a coincidence that this IRC channel is the first thing to open when I start Instantbird :P
01:47:18 <clokep> They usually open in the order you type them into the auto-join. :P Or the order the server returns them.
01:48:57 <EionRobb> its the first for me too, but the last in my list of accounts (although I'm still using evil old pidgin)... maybe the mozilla irc servers are faster than others
01:49:54 <clokep> Ah, yes. The servers rae pretty fast and they've got a few different data centers. :)
01:51:00 <clokep> Btw EionRobb I was playing with compiling Skype, but you've got all your USE_VV ifdefs commented out! And then I got a strange error about accessing a struct in correctly. :-/
01:53:39 <clokep> I assume oyu compile w/ MinGW not MSVC though?
02:19:39 <-- skeledrew has quit (Quit: Instantbird 1.2a1pre)
02:23:42 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1033 on bug 1032.
02:23:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1032 enh, --, ---, nobody, NEW, Scroll to first unread message when opening hidden conversation
02:25:09 <-- billysanca has quit (Quit: Instantbird 1.2a1pre)
02:25:38 <clokep> aleth: Does that fix the issue with resizing?
02:25:50 <aleth> Yes
02:27:07 <aleth> Btw I can't test the mouse gesture part...
02:27:47 <clokep> I can't either. My laptop doesn't even have a mousepad (nor is it a Mac). :)
02:29:21 <aleth> Well, flo can test that bit then ;)
02:29:52 <aleth> I originally requested review from you because flo's backlog is long enough already... hope you don't mind
02:30:41 <clokep> No problem at all. :)
02:31:09 <clokep> I'm rebuilding my tree right now though. (Upgraded to MSVC 2010 this weekend) So it won't be until tomorrow. :-/ Sorry to keep you waiting for so long.
02:31:17 <aleth> No problem
02:32:56 <aleth> flo: Btw you were right about the _lastMessageIsContext in convbrowser of course :) I'd originally misunderstood what that was for.
02:33:37 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
02:34:11 <-- BlueMaxima has quit (Quit: Instantbird 1.1)
02:34:48 <clokep> Hmm...I wonder if a reaosnable context menu for tweets would be "Open tweet in external browser"?
02:34:57 <clokep> I wonder if that would be more useful then copying the Tweet URL.
02:45:08 <clokep> (Since every time I copy a tweet, I immediately paste it into Firefox...so...feel like it'd be more useful to just directly do that.)
03:02:53 <-- hunsly has quit (Ping timeout)
03:04:55 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
03:17:34 --> skeledrew has joined #instantbird
04:00:28 <-- EionRobb has quit (Quit: Leaving.)
06:23:20 --> BlueMaxima has joined #instantbird
08:36:40 <-- Even1 has quit (Ping timeout)
08:50:14 --> MadWookiee has joined #instantbird
09:13:00 <-- Even has quit (Quit: Instantbird 1.2a1pre)
09:13:07 --> Even has joined #instantbird
09:13:07 * ChanServ sets mode +o Even 
09:13:29 <-- Even has quit (Quit: Instantbird 1.2a1pre)
09:13:34 --> Even has joined #instantbird
09:13:34 * ChanServ sets mode +o Even 
09:14:39 <-- Even has quit (Quit: Instantbird 1.2a1pre)
09:14:47 --> Even has joined #instantbird
09:14:47 * ChanServ sets mode +o Even 
09:15:58 --> Mic has joined #instantbird
09:15:58 * ChanServ sets mode +h Mic 
09:23:51 <-- gerard-majax has quit (Ping timeout)
09:37:29 --> gerard-majax has joined #instantbird
09:40:53 --> mmkmou has joined #instantbird
09:46:45 --> aleth has joined #instantbird
09:49:06 <aleth> clokep: when I copy a tweet URL, I usually want to share it with someone who is not on twitter. So I don't tend to open it in FF
09:52:30 <franksouza1831> aleth: good morning
09:54:24 <-- gerard-majax has quit (Ping timeout)
09:54:31 <franksouza1831> Where do I find the external package to bubles theme?
09:54:53 <aleth> There isn't one. You can look at the code on LXR
09:55:11 <aleth> http://lxr.instantbird.org/instantbird/source/instantbird/themes/messages/bubbles/
09:55:59 <franksouza1831> ok
09:57:54 <-- MadWookiee has quit (Ping timeout)
10:07:34 <-- mmkmou has left #instantbird ()
10:21:02 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
10:21:09 --> franksouza1831 has joined #instantbird
10:27:41 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
10:27:45 --> franksouza1831 has joined #instantbird
10:30:24 <-- Mic has quit (Ping timeout)
10:30:48 --> gerard-majax has joined #instantbird
10:50:58 --> jb has joined #instantbird
11:03:16 --> Mic has joined #instantbird
11:03:16 * ChanServ sets mode +h Mic 
11:16:34 --> clokep has joined #instantbird
11:16:34 * ChanServ sets mode +h clokep 
11:30:48 <-- gerard-majax has quit (Quit: Ex-Chat)
11:31:23 --> gerard-majax has joined #instantbird
11:37:33 <Mic> I haven't seen the standby-reconnect problem since we had the talk about it recently :)
11:40:53 <Mic> flo: about restoring conversations, the idea was if we could do a test for that automatically. Generate lots of messages, write them into a conversation and time how long it takes to restore it.
11:42:18 <Mic> With "reactive" (might be difficult or impossible?) I meant that the conversation is displayed properly, can be scrolled smoothly, animations running as they should, ..
11:45:05 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
11:45:11 --> franksouza1831 has joined #instantbird
11:45:41 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
11:45:45 --> franksouza1831 has joined #instantbird
11:49:33 <clokep> Mic: fake.js has code to make a fake conversation, it could be modified to generate many messages.
11:50:03 --> MadWookiee has joined #instantbird
11:52:50 <aleth> One could add an event that fires at the end of conversation.xml _showFirstMessages, everything should be displayed and the UI should be responsive at that point.
11:57:28 <franksouza1831> aleth: is there any way to get just the color value?
11:57:45 <franksouza1831> without "color:" property
11:57:58 <franksouza1831> on %senderColor%
11:59:20 <franksouza1831> I'm trying get the color to apply as background color on a element
11:59:56 <franksouza1831> but I aways got "color:hsl(..."
12:02:15 <clokep> franksouza1831: Do style="%senderColor%"
12:03:00 <aleth> franksouza1831: If you want the hsl values, you have to write a JS function to extract that. I think Bubbles does this.
12:03:20 <franksouza1831> yes, I see that
12:03:58 <franksouza1831> but just thought there was a way without appeal to js
12:04:02 <franksouza1831> ok
12:04:06 <franksouza1831> thanx
12:04:56 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
12:12:54 --> flo has joined #instantbird
12:12:54 * ChanServ sets mode +qo flo flo 
12:14:07 <flo> hello :)
12:15:05 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
12:15:09 --> franksouza1831 has joined #instantbird
12:15:40 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
12:15:44 <flo> Mic: as far as I know, the conversation is reactive as soon as we have returned from the _showFirstMessages method of the conversation binding. (except if we are restoring another conversation at the same time of course)
12:15:44 --> franksouza1831 has joined #instantbird
12:16:01 <-- Mic has quit (Ping timeout)
12:16:30 <flo> "can be scrolled smoothly" I think this depends only on the general load of the machine (once the conversation has appeared)
12:16:56 <-- MadWookiee has quit (Ping timeout)
12:17:32 <flo> franksouza1831: if you want to use it for a background color, maybe you can just write style="background-%senderColor%"
12:17:45 <flo> that's obviously a ugly hack, but if it works... :)
12:17:49 <franksouza1831> oww yeah
12:17:52 <franksouza1831> great idea
12:17:55 <franksouza1831> thanks
12:19:07 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
12:19:11 --> franksouza1831 has joined #instantbird
12:19:35 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
12:19:38 --> franksouza1831 has joined #instantbird
12:20:15 <franksouza1831> testing, no reply
12:21:23 --> franksouza183 has joined #instantbird
12:21:57 <franksouza183> franksouza1831: testing color on chatroom
12:23:21 <franksouza1831> background-%senderColor% works
12:23:27 <franksouza1831> thanx
12:42:39 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
12:42:45 --> franksouza1831 has joined #instantbird
12:42:54 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
12:42:58 --> franksouza1831 has joined #instantbird
12:43:25 <franksouza183> franksouza1831: testing
12:44:51 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
12:44:56 --> franksouza1831 has joined #instantbird
12:52:38 --> clokep_work has joined #instantbird
12:52:38 * ChanServ sets mode +h clokep_work 
12:58:31 <flo> that discussion in bug 14328 feels so much like wasted energy for everybody :(
12:59:55 <aleth> huh.
13:00:02 --> Mic has joined #instantbird
13:00:02 * ChanServ sets mode +h Mic 
13:00:07 <aleth> Hopefully to be terminated by the reviewer reviewing the patch ;)
13:03:49 --> mmkmou has joined #instantbird
13:05:03 <-- mmkmou has left #instantbird ()
13:06:50 <flo> or any patch getting checked in to support the feature. I don't mind if it's not this patch. I just want to be able to use the feature for Thunderbird
13:07:26 <flo> for Instantbird I don't mind shipping a C++ (instantbot, shut up!) XPCOM component for it, as we will continue to ship binary code for libpurple anyway...
13:07:27 <instantbot> c++ is e-- ah, nevermind.
13:09:39 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
13:09:45 --> franksouza1831 has joined #instantbird
13:10:09 <franksouza1831> franksouza183: testing colors
13:10:31 <franksouza183> franksouza1831: reply testing colors
13:10:54 <franksouza183> success
13:10:57 <Mic> franksouza1831: you can always launch a second instance of Instantbird (use the "-P" and "-no-remote" parameters at start ) and try with a different profile
13:11:45 <Mic> You don't need to quit your instance that you use to chat (here for example) and won't lose the previous history of the conversation :)
13:12:26 <franksouza1831> yes, but I want testing message style on chat room that allow color on participants
13:13:14 <franksouza1831> this dont change message style theme without restart
13:14:23 <franksouza183> ow, sorry, think I'll create a room for testing, sorry to use this room for this
13:14:44 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
13:16:05 --> franksouza1831 has joined #instantbird
13:16:23 <-- franksouza1831 has left #instantbird ()
13:18:06 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
13:19:20 <clokep_work> flo: Yes, that conversation is fairly ridiculous. :-/
13:20:01 <clokep_work> You might want to say that that work is for Thunderbird also btw. ;)
13:20:11 * flo has just added one more comment.
13:20:17 <flo> saying exactly that :-P
13:21:00 <Mic> franksouza183: you can always go to #ubuntu, there's enough conversation going on there and I guess one join and leave more or less won't make a difference there? :P
13:22:24 <franksouza183> I really need a lot of conversation
13:23:37 <-- flo has quit (Ping timeout)
13:24:46 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
13:33:17 --> flo has joined #instantbird
13:33:17 * ChanServ sets mode +qo flo flo 
13:34:14 <flo> I think the social engineering part is what I dislike the most in the process to get a patch in Mozilla :(.
13:34:26 --> myk has joined #instantbird
13:34:50 --> franksouza1831 has joined #instantbird
13:36:21 --> hunsly has joined #instantbird
13:38:39 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
13:38:43 --> franksouza1831 has joined #instantbird
13:44:34 <franksouza183> aleth: hi
13:45:00 <franksouza183> you can test the theme again?
13:45:46 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
13:45:52 --> franksouza1831 has joined #instantbird
13:46:25 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
13:46:29 --> franksouza1831 has joined #instantbird
13:46:54 <clokep_work> flo: It makes it really hard for new contributors. :-/ A lot of my feeling about Mozilla being "too big".
13:49:11 <flo> MX was offtopic already (from my point of view). Now this is about office buildings...
13:51:03 <clokep_work> Yes. I haven't looked at the patches so I can't really comment...but it sounds like you're just adding something, he's reorganizing stuff...and that the reorganization could happen afterward.
13:53:23 <clokep_work> I'm glad I'm not CCed on that bug. :-D
13:53:24 <flo> clokep_work: he wants the addition of SRV support to be blocked on adding MX records, and for that change the API used by all existing consumers of the DNS API...
13:54:45 <-- BlueMaxima has quit (Quit: Instantbird 1.1)
13:55:16 <flo> but the more this discussion goes on, the less I think this is really what he wants. What he probably really wants is his hard (but unfinished) work he has done in a lonely corner to be acknowledged rather than shelved, and that someone thanks him for it.
13:55:39 <clokep_work> Probably. :(
14:06:12 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
14:06:18 --> franksouza1831 has joined #instantbird
14:06:36 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
14:06:40 --> franksouza1831 has joined #instantbird
14:10:00 <-- franksouza183 has left #instantbird ()
14:15:43 <flo> the reviewer has a slight preference for the API of the other patch, that he however doesn't want to consider as a patch as it's incomplete. And he thinks none of the patch does what should be done w.r.t caching. Fun :).
14:19:54 <franksouza1831> Anyone like to test the Ambiance message style theme?
14:20:53 --> MadWookiee has joined #instantbird
14:21:17 --> ecaron has joined #instantbird
14:21:49 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
14:21:55 --> franksouza1831 has joined #instantbird
14:22:06 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
14:22:11 --> franksouza1831 has joined #instantbird
14:24:40 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
14:24:44 --> franksouza1831 has joined #instantbird
14:29:09 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
14:29:14 --> franksouza1831 has joined #instantbird
14:42:08 <-- myk has quit (Ping timeout)
14:45:06 <flo> hmm, my socket connection fails with NS_ERROR_UNKNOWN_HOST (for some reason the DNS server here seems unable to give any result :(), and the error message JS XMPP displays is "The server closed the connection" :(
14:47:18 <flo> clokep_work: do you remember this part of the code? http://lxr.instantbird.org/instantbird/source/chat/modules/socket.jsm#398
14:47:38 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
14:47:43 --> franksouza1831 has joined #instantbird
14:47:47 <flo> I'm wondering why this._openStreams (which calls the onConnection callback saying the connection is successful) is called immediately
14:47:50 <-- franksouza1831 has quit (Quit: franksouza1831)
14:47:55 --> franksouza1831 has joined #instantbird
15:07:14 <clokep_work> flo: I'm in meetings all day.
15:08:56 <clokep_work> Well you have to open the streams to do anything.
15:09:12 <clokep_work> onConnection is supposed to occur immediately after you attempt connecting I believe.
15:09:22 <flo> what's the point then?
15:09:43 <flo> I don't want to send any data on the socket until I know it has actually been successfully opened
15:10:33 <flo> the JS-XMPP code currently sends "<?xml version="1.0"?><stream:stream to="instantbird.fr" xmlns="jabber:client" xmlns:stream="http://etherx.jabber.org/streams" version="1.0">" when onConnection is called
15:18:15 <flo> of course now that I've an idea of how I can improve this situation, the DNS server is back to normal and I can't test it any more :)
15:26:38 --> franksouza183 has joined #instantbird
15:40:15 --> Mic has joined #instantbird
15:40:15 * ChanServ sets mode +h Mic 
15:45:55 <flo> clokep_work: http://pastebin.instantbird.com/1123 with this change onConnection is called only when there's a connection, not when we are attempting to establish one. Isn't this the behavior you would expect?
15:56:14 <-- franksouza1831 has quit (Quit: Instantbird 1.1)
15:57:14 --> franksouza1831 has joined #instantbird
16:16:38 * Mic can't remember when he has seen such a page the last time: http://chatzilla.reslex.net/cz/chatzillapage_white.htm
16:17:02 <Mic> Tha must be ten to fifteen years now? Good old Geocities? :D
16:45:13 <-- wesj has quit (Quit: Instantbird 1.2a1pre)
16:45:17 --> wesj has joined #instantbird
16:45:49 --> aleth has joined #instantbird
16:46:09 <franksouza183> aleth: hello
16:46:25 <franksouza183> I have submited the addon
16:46:30 <aleth> Great :)
16:46:58 <franksouza183> fixed, bubble colors and fontsize
16:47:06 <franksouza183> but no font colors
16:47:28 <franksouza183> is not adequate
16:47:40 <aleth> What's it called now?
16:48:09 <franksouza183> Ambiance 1.8
16:48:26 <aleth> I can't find it
16:48:33 <franksouza183> I'm waiting for something to be activated
16:48:44 <franksouza183> I do not know what
16:48:46 <aleth> What's the link?
16:48:47 <franksouza183> :)
16:49:09 <franksouza183> no link yet
16:49:13 <franksouza183> "Several user reviews of the add-on (may be external reviews)."
16:49:17 <franksouza183> on add-on status
16:49:28 <franksouza183> "Add-on Status: In Sandbox; Public Nomination"
16:49:32 <aleth> Oh, but if you have uploaded it into the sandbox it is there, just marked as experimental.
16:49:50 <franksouza183> I don'n no
16:49:57 <franksouza183> I just upload
16:50:12 <flo> and you can clearly give a link ;)
16:50:17 <aleth> You should have a 'view listing' button to see how it appears on the site
16:50:26 <franksouza183> yes
16:50:27 <aleth> Then you nominate it to go public once you think it is stable.
16:50:30 <franksouza183> wait
16:50:46 <franksouza183> oops
16:50:49 <franksouza183> here
16:50:51 <franksouza183> https://addons.instantbird.org/en-US/instantbird/addon/311/
16:51:47 <aleth> Just FYI, you know you can have more than one screenshot if you like? Since you have many variants...
16:52:11 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
16:52:11 --> aleth has joined #instantbird
16:52:19 <franksouza183> oh yes yes
16:53:21 <aleth> Just trying it :) Looks much better now.
16:53:34 <franksouza183> yes
16:53:42 <franksouza183> same bugfixes on css
16:53:58 <franksouza183> test on chat rooms
16:54:17 <franksouza183> to see colored ballons
16:54:20 --> igorko has joined #instantbird
16:56:16 <aleth> There is a bug though on the sender balloon: http://minus.com/mWbasxAVe#
16:56:53 <franksouza183> humm
16:57:04 <franksouza183> I don't see that
16:57:06 <franksouza183> wait
16:57:45 <franksouza183> I have tested on 1.1 and 1.2a1pre on all variants
16:57:49 <franksouza183> and dont see this
16:58:01 <franksouza183> strange
16:58:36 <franksouza1831> this only dark variant ?
16:58:40 <aleth> It works for the other participants, maybe it's when the user has an icon set.
16:58:51 <franksouza1831> oopss
16:58:54 <franksouza1831> I see now
16:59:00 <aleth> No, same for all variants
16:59:33 <-- jb has quit (Ping timeout)
17:03:32 <-- Even has quit (Quit: Instantbird 1.2a1pre)
17:03:42 --> Even has joined #instantbird
17:03:42 * ChanServ sets mode +o Even 
17:19:04 --> jb has joined #instantbird
17:24:08 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
17:24:14 --> franksouza1831 has joined #instantbird
17:24:24 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
17:24:30 --> franksouza1831 has joined #instantbird
17:35:04 <-- flo has quit (Ping timeout)
17:39:57 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
17:40:03 --> franksouza1831 has joined #instantbird
17:40:16 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
17:40:20 --> franksouza1831 has joined #instantbird
17:42:01 <-- wesj has quit (Quit: Instantbird 1.2a1pre)
17:51:26 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
17:51:31 --> aleth has joined #instantbird
17:51:45 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
17:51:50 --> franksouza1831 has joined #instantbird
17:52:26 <aleth> Is there a meeting tonight?
17:55:37 --> flo has joined #instantbird
17:55:37 * ChanServ sets mode +qo flo flo 
17:56:05 <flo> aleth: I just wondered the same :-S.
17:57:33 <flo> I don't have much to say. My review work on JS-XMPP is making good but slow progress. DNS SRV support is uncertain at this time. And that's probably it.
17:57:41 --> jb1 has joined #instantbird
17:58:08 --> wesj has joined #instantbird
17:58:17 <-- jb has quit (Ping timeout)
17:58:21 <flo> also, I'm likely going to move my office this week to somewhere else, but I don't know where yet (I have an idea though :)).
17:58:44 <aleth> Thunderbird-related developments? ;)
17:58:58 <aleth> Well, you know what I've been doing...
17:59:11 <-- gerard-majax has quit (Ping timeout)
17:59:26 <flo> aleth: I'm not sure if that's completely public. But that's a public summary at https://wiki.mozilla.org/Features/Thunderbird/Instant_messaging_in_Thunderbird
17:59:38 <flo> *there's a public summary
18:00:30 <aleth> interesting :)
18:00:37 --> Mook_as has joined #instantbird
18:02:06 <aleth> As I mentioned before, I was wondering whether there shouldn't be an event/observer/something along those lines triggered after all the messages have displayed on opening a conversation. No idea what the best implementation for that would be.
18:02:13 <aleth> it would be useful for add-ons, and for performance testing
18:02:49 <flo> do you have more specific usecases in mind?
18:04:27 <aleth> Well, it occurred to me after your suggestion to do the 'scroll to first unread message' via add-on. And Mic was looking for something similar, not sure exactly what for.
18:04:29 <-- franksouza183 has left #instantbird ()
18:05:04 <aleth> But also you could have an add-on that measures and displays the time between conversation-loaded and conversation-ready (or whatever)
18:06:16 <aleth> Though there are other, possibly more convenient ways to do that for dev purposes I suppose.
18:06:28 <flo> if it's for performance testing, currently adding dumps in the code works
18:06:49 <flo> except if you want to use things like telemetry so that get can get reports from users
18:06:59 <flo> but I don't think we are there yet
18:07:36 <aleth> Not really. Many other things to do first...
18:08:05 <flo> I think Mic was complaining about the lack of a notification when a conversation has been detached, but I don't remember what the use case was
18:08:07 <-- MadWookiee has quit (Quit: Instantbird 1.1)
18:08:30 <aleth> But using 'scroll on opening' as an example, how would you do that without such an event?
18:09:51 <flo> I would modify a method of the conversation binding from the add-on
18:10:16 <aleth> flo: I ran into the same problem with an add-on a while ago. The problem is the XBL bindings are reset on detaching a tab
18:10:24 <flo> the part that was difficult as an add-on was storing a reference to the first non-context message
18:10:37 <aleth> That would have been a terrible hack.
18:11:09 <flo> modifying a method of the binding from the add-on? Bah... lots of add-ons already do that ;)
18:11:24 <aleth> No, I meant getting/storing the reference ;)
18:12:05 <aleth> Modifying a method isn't so bad, as long as you don't want to change the content section of an XBL overlays are OK.
18:12:26 <flo> changing the content isn't too bad either
18:12:42 <flo> you create a new xbl binding inheriting from the existing one, and you put a !important on the CSS rule
18:13:16 <aleth> And as long as you are the only add-on doing it, that works?
18:13:46 <flo> right
18:16:07 <aleth> I just did it via direct DOM modification, that allows the add-on to be restartless too
18:16:27 <aleth> But it has the problem Mic ran into.
18:23:04 <clokep_work> flo: r+ for http://pastebin.instantbird.com/1123
18:23:11 <clokep_work> That is what it should be doing. :)
18:23:53 <flo> :)
18:24:19 <flo> do I also have r+ for the sendUTF8 method I added Friday? :)
18:27:19 <clokep_work> If you answer my question about whether we want to support other encodings ever or not. ;)
18:27:19 * Mook_as wonders why that's not reading the constants off http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsISocketTransport.idl#131
18:27:42 <flo> clokep_work: I don't even understand what that question means
18:27:51 <flo> the converter takes UTF8 both as input and output
18:28:09 <clokep_work> Ah, yes...they probably should refer to the interface as Mook_as says.
18:28:57 <clokep_work> flo: Right, but it converts it to UTF-8, right? Would we want to convert it to other encodings? I think some random IRC channels use non-UTF-8 encodings.
18:29:26 <flo> Mook_as: to avoid an if/else for each. If we only care about the STATUS_CONNECTED_TO, I definitely will use the idl constant.
18:31:31 <clokep_work> flo: The "magic numbers" could still refer to the ones from nsISocketTransport though?
18:32:03 <flo> clokep_work: hmm, that should probably be a sendString(aString, aEncoding) method, converter.charset = aEncoding || "UTF-8"
18:32:43 <flo> clokep_work: can we put something that isn't a literal constant on the left side for object initializers?
18:33:04 <flo> I wasn't too worried because of http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsISocketTransport.idl#124
18:33:35 <clokep_work> flo: Yes, I suppose. I think it's just not as neat as say http://pastebin.instantbird.com/1124 but if we really only care about the one situation we should just if statement that off.
18:33:55 <clokep_work> flo: Yes, I was thinking aEncoding || "UTF-8", but I wasn't positive it was something we wanted to support.
18:34:09 <clokep_work> "can we put something that isn't a literal constant on the left side for object initializers?" I'm not sure what you mean. :-/
18:34:27 <flo> it's definitely not something we *want* to support, but it may be something we need :(
18:34:29 <Mook_as> hmm, yeah, http://pastebin.mozilla.org/1388711 isn't exactly readable :/
18:34:45 <-- jb1 has quit (Ping timeout)
18:35:15 <clokep_work> Mook_as: That is an r-. ;)
18:35:22 <flo> Mook_as: probably not even faster
18:35:30 <flo> (than the large if/else block)
18:35:35 <Mook_as> clokep_work: good thing I didn't plan on submitting it as a patch ;)
18:36:07 <Mook_as> flo: yeah, wasn't concerned about speed; was thinking readability, except I think that horrible three-line mess loses.
18:36:26 <flo> both on speed and readability :-P
18:36:52 <Mook_as> so, yeah: if you want eye-stabbing... otherwise, I can't help :p
18:37:17 <flo> I should really remove the shutdown errors someday :-S
18:38:51 <flo> the low hanging fruits to reduce the noise in my console is probably to review aleth's patches though :)
18:41:23 <clokep_work> flo: I'd like to see the encoding patch again, I think it might make more sense to just set an encoding for the socket in general and always use that instead of taking aEncoding as a parameter.
18:41:57 <flo> and if you have different encodings for different channels? :-P
18:42:09 <Mook_as> you cry
18:42:29 <flo> Mook_as: of I find someone to blame ;)
18:42:31 * clokep_work cries.
18:42:32 --> gerard-majax has joined #instantbird
18:42:51 <clokep_work> flo: You're right, it needs to be handled every time.
18:43:06 <clokep_work> (If I recall, that was only handling outgoing data, right?)
18:43:24 <flo> clokep_work: that's too bad, we could have kept the converter otherwise
18:43:30 <clokep_work> Although for a situation like IRC (anyway) I'd need to convert just the message payload to a different encoding anyway I think.
18:43:33 <flo> I feel a bit bad about creating a new one for each string
18:43:52 <clokep_work> Maybe it shouldn't be part of the socket? :-/
18:44:04 <flo> what do you mean?
18:44:15 <flo> that I should put it in my object that inherits from Socket?
18:44:29 <flo> I feel a bit bad about the access to this._outputStream in that case ;)
18:44:38 <clokep_work> Let me think.
18:44:57 <clokep_work> (I always assumed that something that inherits can use _ properties actually.)
18:45:04 --> Mnyromyr has joined #instantbird
18:45:04 <flo> it can
18:45:09 <flo> but that's not really clean
18:45:16 --> Tomek has joined #instantbird
18:45:18 <clokep_work> I mean philosophically, not technically. :)
18:45:29 <flo> when I change a thing named _something, I don't necessarily think to check if derivated objects were using it
18:45:30 <clokep_work> So, in XMPP the entire message is sent as UTF-8?
18:45:44 <clokep_work> (The XML, etc.)?
18:45:50 <clokep_work> And that's what you're trying to handle.
18:46:09 <flo> clokep_work: the encoding doesn't matter for parts that don't contain any non-US character
18:46:19 <flo> so sending the whole stanza as UTF8 doesn't hurt
18:46:20 <clokep_work> Oh, right. :-D
18:46:27 <clokep_work> Then yes, your solution seems good.
18:56:58 <flo> the patch in bug 1171 should be almost reviewable now
18:57:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1171 nor, --, ---, nobody, NEW, Replace the current binary XMPP plugin with a JS implementation
18:57:16 <flo> I'm not sure I want to ship the current content of gtalk.js, I may go for a more simple override for now.
18:57:25 <flo> and I still want to get rid of the utils file
18:57:46 <flo> xmpp-authmechs.jsm also need another cleanup pass
18:57:58 <flo> but otherwise I'm quite satisfied with the current state of the code
18:58:28 <clokep_work> flo: Do we want the gmail received mail conversation window?
18:58:40 <flo> do you want it?
18:58:54 <flo> I suspect it would quickly annoy me
18:59:43 * flo is away for dinner.
18:59:48 <flo> I'll be back in about an hour
19:00:58 <clokep_work> I don't think we should include it at first (at least so it's a separate changeset we could back out later. :))
19:01:18 <clokep_work> I.e. only have feature parity (or a subset) of libpurple's features before adding more.
19:02:44 --> franksouza183 has joined #instantbird
19:03:11 <-- franksouza183 has left #instantbird ()
19:13:35 <-- franksouza1831 has quit (Ping timeout)
19:20:08 --> EionRobb has joined #instantbird
19:49:12 <flo> clokep_work: ok, it's what I thought too :)
19:49:45 <clokep_work> flo: What's the difference between WIP 4 and 5 btw? Just the socket changes?
19:50:55 <flo> is 5 what I've just attached?
19:51:21 <clokep_work> Yes.
19:51:56 <flo> http://pastebin.instantbird.com/1125
19:53:38 <flo> I simplified the XML API, added connection progress messages, fixed a bug when disconnecting an account from the UI, and a few tiny details
19:56:50 <clokep_work> Ah I see. :) THanks.
20:01:09 --> devfil has joined #instantbird
20:03:32 --> jb has joined #instantbird
20:21:47 --> franksouza1831 has joined #instantbird
20:49:05 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
20:49:13 --> franksouza1831 has joined #instantbird
20:52:29 <-- Mic has quit (Ping timeout)
20:53:22 --> franksouza183 has joined #instantbird
20:54:26 <-- franksouza183 has left #instantbird ()
21:11:35 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
21:11:39 --> franksouza1831 has joined #instantbird
21:11:54 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
21:13:51 * flo wonders what we should reply to https://twitter.com/#!/rdlf2048/status/140980831568146434
21:15:01 --> franksouza183 has joined #instantbird
21:16:01 <clokep_work> flo: In less than 140 characters? Probably nothing. :(
21:16:17 --> franksouza1831 has joined #instantbird
21:16:58 <aleth> Expect awesomeness ;)             <-- certainly mozillaesque
21:18:00 <flo> I've no idea of what we can expect by the time we ship another version
21:26:30 <flo> by the way, anybody would like to drive the release?
21:27:08 <flo> this probably includes figuring out (and documenting) what that means :)
21:27:22 * clokep_work doesn't have his license. ;)
21:27:31 <clokep_work> When is the release again? January we decided?
21:27:43 <flo> yes, I think we decided January
21:27:49 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:27:59 --> aleth has joined #instantbird
21:29:00 <-- igorko has quit (Quit: Instantbird 1.1)
21:30:27 * Mook_as wonders when in january
21:30:35 <flo> Mook_as: later
21:33:41 <clokep_work> I'm not really sure what that means, but I'm sure I can help out more. :(
21:34:06 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:34:08 --> aleth has joined #instantbird
21:35:13 <flo> clokep_work: it would be nice if we could get involved with that people who aren't taking already coding for Instantbird
21:35:36 <flo> and that "job" doesn't necessarily require much technical skills
21:35:55 <clokep_work> Oh you  mean from like writing up release notes, making sure it goes through some QA, etc?
21:36:14 <EionRobb> clokep_work: oops, I didn't reply to your messages the other day.  yeah, I use mingw.  and the use_vv ifdefs don't need to be there as media.h is part of libpurple as of 2.6
21:36:34 <flo> clokep_work: that's the final parts
21:36:45 <flo> but before that, there's all the communication with translators
21:36:56 <flo> checking that things look alright on AIO
21:37:10 <flo> that we have done what we can with the crash reports we have received from the previous release and nightlies
21:37:21 <flo> managing the list of blockers/wanted bugs, etc...
21:38:45 <flo> EionRobb: libpurple still has the USE_VV ifdefs even though that's defined by default in the Pidgin build system, or isn't this the case any more?
21:42:14 <EionRobb> yes, the USE_VV ifdefs just turn a bunch of no-op functions into useful functions
21:42:20 <EionRobb> but the functions still exist
21:50:10 <clokep_work> flo: Ah, OK. :)
21:50:38 <clokep_work> EionRobb: It's OK. I was able to uncomment them. :P The bigger issue was the failure to compile! Which I don't have the error w/ me right now.
21:51:52 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
21:52:09 --> franksouza1831 has joined #instantbird
21:52:22 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:52:24 --> aleth has joined #instantbird
21:54:15 <EionRobb> stop missing out bits of libraries :)
21:54:46 <flo> EionRobb: by the way, why did you say Pidgin was evil?
21:55:11 <clokep_work> EionRobb: It's not a missing library, it's an MSVC vs. MingW issue I think.
21:55:20 <clokep_work> (It can't access SkypeBuddy or something. I forget. :()
21:56:23 <EionRobb> I think IB misses out parts of glib that the skype plugin uses too
21:56:34 <EionRobb> flo: are you trying to say Pidgin isn't? ;)
21:56:42 <clokep_work> flo: is bug 638 still applicable?
21:56:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=638 enh, --, ---, mook.moz+bugs.instantbird, ASSI, Split purpleInit.cpp into multiple files
21:56:50 <clokep_work> Not sure if that file was touched or not...
21:57:21 <clokep_work> EionRobb: I haven't found an unknown types yet. I'll get the real error later instead of speculating. :)
21:57:43 <flo> EionRobb: I think I've expressed myself on this topic at http://blog.instantbird.org/2011/07/why-should-i-switch-from-pidgin/ and that's all I have to say about it.
21:57:53 <flo> I was just wondering why *you* were saying that :-P.
21:58:38 <-- franksouza1831 has quit (Quit: Instantbird 1.2a1pre)
21:58:43 --> franksouza1831 has joined #instantbird
21:59:39 <-- clokep_work has quit (Quit: Instantbird 1-j)
22:09:40 <-- franksouza183 has left #instantbird ()
22:10:51 <-- devfil has quit (Client exited)
22:13:37 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
22:13:40 --> aleth has joined #instantbird
22:31:31 --> billysanca has joined #instantbird
22:51:30 --> BlueMaxima has joined #instantbird
22:52:06 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:55:12 <flo> clokep: this may be interesting for incoming data that isn't in UTF8: http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsIConverterInputStream.idl
22:58:58 <-- billysanca has quit (Quit: Instantbird 1.2a1pre)
22:59:08 --> billysanca has joined #instantbird
22:59:23 <-- flo has quit (Input/output error)
22:59:24 --> flo has joined #instantbird
22:59:24 * ChanServ sets mode +qo flo flo 
22:59:31 <-- flo has quit (Input/output error)
22:59:37 --> flo has joined #instantbird
22:59:37 * ChanServ sets mode +qo flo flo 
23:04:25 <flo> Good night :)
23:04:28 <-- flo has quit (Quit: Instantbird 1.2a1pre)
23:07:47 --> franksouza1832 has joined #instantbird
23:10:41 <-- jb has quit (Ping timeout)
23:30:10 <-- ecaron has quit (Quit: Instantbird 1.1)