#instantbird log on 11 23 2011

All times are UTC.

00:10:32 <flo> I think this is the fix for the this._findField / findbar.xml warning: http://pastebin.instantbird.com/1104
00:11:30 <flo> I remember we (= Moria n and me) struggled with that at the time :-/
00:17:37 <-- micahg has quit (Connection refused)
00:18:00 --> micahg_ has joined #instantbird
00:25:56 <aleth> subtle ;)
00:27:41 <aleth> So instead of an exception, it throws a warning.
00:27:57 <aleth> Or both? (In the current code)
00:30:04 --> BlueMaxima has joined #instantbird
00:31:01 <flo> aleth: we used to only get an exception, now we have both the warning (first) and then the exception, which is caught by the try/catch block.
00:31:21 <flo> with my patch I think it will just work
00:33:58 <flo> aleth: the warning about this._textSelected in Magic Copy (imThemes.jsm) looks like a real bug
00:37:13 <flo> probably harmless though. Just executing several times a function of the magic copy code instead of once in a specific and not very interesting case.
00:42:26 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a0365b25ff14 - Florian Quèze - Bug 1182 - Warning: reference to undefined property this._findField in findbar.xml.
00:42:28 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8c0b516103ed - aleth - Bug 1159 - Follow-up to bug 1112: names not matched when alias is set, r=fqueze.
00:42:29 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0348e9dfbce7 - Florian Quèze - Bug 968 - Avoid duplicating account_buddy database entries (with broken prpls) and ensure account-buddy notifications are always forwarded to a buddy.
00:42:30 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b16f72029cd9 - aleth - Bug 1177 - Remove occasional warning on tab completion, r=fqueze.
00:42:31 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8a1c7afa6ce4 - aleth - Bug 1184 - Warning: _showOffline undefined in group.xml, r=fqueze.
00:42:32 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/2a427d19b509 - aleth - Bug 1174 - Own nickname shouldn't block completion of another, r=fqueze.
00:42:33 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/fcccb00f9a8e - aleth - Bug 1183 - Warning: this.mCurrentConversation undefined, r=fqueze.
00:53:11 <flo> Good night :)
00:53:13 <-- flo has quit (Quit: Instantbird 1.2a1pre)
01:17:46 <-- devfil has quit (Ping timeout)
01:23:06 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
01:40:06 <-- Mook_as has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 1.9.2.13/20101203074205])
01:44:10 --> billysanca has joined #instantbird
02:14:03 <-- billysanca has quit (Quit: Instantbird 1.2a1pre)
02:14:10 --> billysanca has joined #instantbird
02:32:53 <-- billysanca has quit (Quit: Instantbird 1.2a1pre)
02:34:40 --> frank has joined #instantbird
02:37:48 <frank> aleth ?
02:38:06 <-- frank has left #instantbird ()
02:46:01 --> franksouza183 has joined #instantbird
03:09:45 --> Mook has joined #instantbird
04:24:33 --> clokep has joined #instantbird
04:24:33 * ChanServ sets mode +h clokep 
04:30:04 <clokep> flo: In your comment "broken" is spelled as "broen" ;)
04:30:58 <clokep> http://pastebin.instantbird.com/1105 fixes it.
04:30:59 <Mook> you have to admit, though, that spelling is broken ;)
04:31:16 <clokep> But it seems reasonable. I'll assume the database parts are correct. :)
04:31:27 <clokep> Yes Mook it's broken. :P No _as this week?
04:31:56 <Mook> umm? it's 8:30pm, I'm not at work anymore.
04:33:23 <clokep> Ah, right.
04:33:30 <clokep> Sorry I lost like 6 hours today driving.
04:33:37 <clokep> I still think it's 6:00 when I left work. ;)
04:33:51 <Mook> hah
04:34:06 <Mook> anyplace interesting?
04:38:08 <clokep> Back home to NY.
04:38:45 <Mook> oh, right, it's near thanksgiving over there
04:39:06 <Mook> at least, if I haven't gotten confused about where there is.
04:41:10 <-- EionRobb has quit (Quit: Leaving.)
04:41:44 <clokep> "there"? Where are you?
04:42:13 <Mook> a little to the northwest of you, I think.
04:42:55 <Mook> (actually, I guess a lot more west than north)
04:43:22 <instantbot> clokep@gmail.com set the Resolution field on bug 1159 to FIXED.
04:43:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1159 min, --, 1.2, aletheia2, RESO FIXED, Follow-up to bug 1112: names not matched when alias is set
04:43:51 <clokep> Did you have your Thanksgiving a few weeks ago? :P
04:44:37 <Mook> yes, where it's defined as "a day off in which I didn't eat turkey" :p
04:44:54 <instantbot> clokep@gmail.com set the Resolution field on bug 968 to FIXED.
04:44:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=968 maj, --, 1.2, florian, RESO FIXED, Friends shown offline in buddylist when are in fact, online.
04:45:46 <clokep> Hahah, but what else would you do? Eat turkey, watch some football...
04:46:25 <instantbot> clokep@gmail.com set the Resolution field on bug 1177 to FIXED.
04:46:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1177 nor, --, 1.2, aletheia2, RESO FIXED, Remove occasional warning on tab completion
04:47:05 <instantbot> clokep@gmail.com set the Resolution field on bug 1184 to FIXED.
04:47:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1184 nor, --, 1.2, aletheia2, RESO FIXED, Warning: _showOffline undefined in group.xml
04:47:45 <Mook> I think our national sport is supposed to involve sticks, though oddly they don't seem to hit people with it much
04:48:07 <instantbot> clokep@gmail.com set the Resolution field on bug 1174 to FIXED.
04:48:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1174 min, --, 1.2, aletheia2, RESO FIXED, Own nickname shouldn't block completion of another
04:48:41 <clokep> Ah, yes. A real sport. :) Unfortunately my team of choice is terrible. :(
04:49:08 <instantbot> clokep@gmail.com set the Resolution field on bug 1183 to FIXED.
04:49:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1183 nor, --, 1.2, aletheia2, RESO FIXED, Warning: this.mCurrentConversation undefined
04:56:11 <clokep> I don't suppose anyone in here know's ecaron's email address?
05:32:44 <instantbot> Just appeared in Blog@instantbird.org - http://blog.instantbird.org :
05:32:45 <instantbot> http://blog.instantbird.org/2011/11/weekly-meetings-november-7-14-and-21-2011/ - Weekly Meetings: November 7, 14 and 21, 2011
05:36:24 <-- skeledrew has quit (Quit: Instantbird 1.2a1pre)
05:37:56 --> skeledrew has joined #instantbird
05:47:50 <clokep> A-ha! I got SIPE to show up as a protocol. :)
05:47:54 <clokep> Just need to check connecting tomorrow!
05:48:09 <clokep> Goodnight. :)
05:48:10 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
05:59:50 <-- GeekShadow has quit (Ping timeout)
06:01:16 --> GeekShadow has joined #instantbird
06:05:08 <-- GeekShadow has quit (Ping timeout)
06:07:26 --> GeekShadow has joined #instantbird
08:01:32 <-- Mook has quit (Quit: z)
08:04:16 <-- gerard-majax has quit (Ping timeout)
08:07:16 --> jb has joined #instantbird
08:41:14 <-- jb has quit (Ping timeout)
08:41:44 --> gerard-majax has joined #instantbird
09:09:39 --> mmkmou has joined #instantbird
09:44:19 --> aleth has joined #instantbird
09:47:17 <-- mmkmou has quit (Ping timeout)
09:49:23 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
09:49:32 --> aleth has joined #instantbird
09:59:22 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 636 to INVALID.
09:59:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=636 nor, --, ---, nobody, RESO INVALID, Missing alias in participant list of MUCs
10:03:40 --> mmkmou has joined #instantbird
10:04:17 <-- mmkmou has left #instantbird ()
10:35:45 <franksouza183> hello aleth
10:40:15 <aleth> Welcome franksouza183 :)
10:40:42 <franksouza183> remember me?
10:40:59 <aleth> Sure..
10:41:15 <franksouza183> I anticipate that my English is bad
10:41:20 <franksouza183> so
10:41:52 <aleth> No problem
10:41:52 <franksouza183> I took a look at the themes of instantbird yesterday
10:42:08 --> flo has joined #instantbird
10:42:08 * ChanServ sets mode +qo flo flo 
10:42:23 <franksouza183> but I could not install the DOM Inspector to examine the structure of code
10:42:33 <franksouza183> compatibility problem
10:42:44 <franksouza183> some idea?
10:43:03 <aleth> You can turn off compatibility checking for add-ons. Then it works.
10:43:15 <franksouza183> well
10:43:20 <aleth> Really that should be updated.
10:43:21 <franksouza183> I'll try
10:43:31 <aleth> Are you using the nightly or 1.1?
10:43:49 <franksouza183> another thing ...
10:44:13 <franksouza183> on the visual identity of the application
10:44:40 <franksouza183> you intend to create another identity?
10:44:43 <aleth> The about.config flag to change for the nightly is extensions.checkCompatibility.nightly (set it to false)
10:44:48 <franksouza183> new logo?
10:45:03 <aleth> I think that has been discussed
10:45:07 <franksouza183> I'm using 1.1
10:45:31 <aleth> Then it should probably be extensions.checkCompatibility.1.1
10:45:57 <franksouza183> where?
10:46:21 <franksouza183> ops
10:46:23 <aleth> Preferences -> Advanced -> General -> Config editor
10:46:25 <franksouza183> i found it
10:46:27 <aleth> It's like in Firefox
10:46:29 <franksouza183> yes
10:46:35 <aleth> Not surprisingly...
10:47:13 <aleth> Re visual identity one guy to talk to is ecaron when he is around
10:47:54 <franksouza183> ok
10:47:59 <aleth> Suggestions are always welcome, I think there is a bug tracking logo suggestions for example
10:48:43 <aleth> (on https://bugzilla.instantbird.org/, which we also use for feature requests, enhancements etc)
10:49:21 <franksouza183> ok
10:49:26 <franksouza183> extensions.checkCompatibility.1.1
10:49:30 <franksouza183> not found
10:50:27 <aleth> Right click and add it
10:50:38 <franksouza183> ok
10:50:52 <aleth> flo: that is the right about:config entry to set, isn't it?
10:51:50 <flo> aleth: I can never remember that. I don't use it myself.
10:52:05 <franksouza183> do not work
10:52:09 <franksouza183> :(
10:52:23 <flo> I'm usually the author of add-ons I use, so when they are not compatible, having them disabled is a good intensive to get me to update them ;)
10:52:43 <flo> franksouza183: which version of DOMi are you attempting to install?
10:52:56 <franksouza183> https://addons.instantbird.org/en-US/instantbird/addon/210
10:53:01 <franksouza183> 2.0.9
10:54:11 <flo> I guess we could email FeuerFliege to get it updated
10:55:43 <flo> I bumped the maxVersion on the website, it should now be able to install fine
10:55:52 <franksouza183> ok
10:56:42 <franksouza183> ok its work
10:56:55 <flo> :)
10:57:32 <flo> are you trying to edit message styles?
10:57:41 <franksouza183> yes
10:58:17 <flo> Even: hmm, we are still recommending Tab Complete on AIO's home page? :-/
10:59:07 <flo> franksouza183: you may also like https://addons.instantbird.org/en-US/instantbird/addon/222
10:59:49 <franksouza183> yes
10:59:53 <franksouza183> i like
11:00:07 <franksouza183> eu realmente gostei do Instantbird
11:00:08 <franksouza183> Parece-me Muito promissor
11:00:10 <franksouza183> apenas uma Única Coisa Que nao me agradou o FOI visuais
11:00:12 <franksouza183> contudo irei Seguir SUA sugestão
11:00:16 <franksouza183> sorry
11:00:18 <franksouza183> I really liked the instantbird
11:00:20 <franksouza183> seems very promising
11:00:22 <franksouza183> only thing I did not like was the look
11:00:25 <franksouza183> But I will follow your suggestion
11:00:26 <franksouza183> google translate
11:00:28 <franksouza183> :)
11:01:49 <flo> when you said you don't like the look, is it the look of the default message theme? Of the logo? Or of the whole application on your system?
11:02:30 <aleth> flo, Even: there's a bug for that... one of those in bug 1111
11:02:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1111 enh, --, ---, raynaudquentin, NEW, [Meta] Improve add-on installation experience
11:03:43 <franksouza183> all
11:03:47 <franksouza183> I think the logo could be simpler
11:03:53 <franksouza183> message style
11:04:18 <franksouza183> and especially buddy list
11:04:40 <flo> which operating system do you use?
11:04:45 <franksouza183> ubuntu
11:05:27 <aleth> There is a small patch for the buddy list lined up already ;)
11:05:41 <franksouza183> :)
11:05:42 <aleth> I think there are ubuntu-specific add-ons too
11:05:51 <aleth> Have you tried those?
11:05:56 <franksouza183> no no
11:06:00 <franksouza183> i will
11:06:17 <franksouza183> yes
11:06:21 <franksouza183> i found
11:06:31 <franksouza183> *founded
11:06:41 <aleth> But yes, Instantbird could do with another couple of polished message styles, so there is more choice :)
11:06:57 <franksouza183> i agree
11:07:48 <aleth> A lot of the ones on the add-on site were converted by a script from adium, so don't actually mesh perfectly with all the Instantbird features
11:08:25 <aleth> (Those autoconverted ones are marked as such)
11:08:40 <franksouza183> let's start building dedicated to the instantbird
11:08:41 <franksouza183> no convertion
11:08:45 <franksouza183> :)
11:09:15 <franksouza183> well
11:09:31 <franksouza183> where are the script?
11:10:33 <aleth> When you download a message style, you get an .xpi file. This is just a zip file
11:10:50 <aleth> There is some documentation here https://wiki.instantbird.org/Instantbird:Message_Styles_reference
11:10:53 <franksouza183> o.o
11:10:56 <franksouza183> ok
11:11:11 <aleth> The code for the default message styles is here http://lxr.instantbird.org/instantbird/source/instantbird/themes/messages/
11:11:26 <franksouza183> that was what needed
11:11:27 <franksouza183> reference
11:11:32 <franksouza183> thanx
11:15:18 <franksouza183> I think that many have asked this question ...
11:15:22 --> Mic has joined #instantbird
11:15:22 * ChanServ sets mode +h Mic 
11:15:27 <franksouza183> cam support?
11:15:30 <franksouza183> msn ?
11:15:33 <franksouza183> gtalk ?
11:15:33 <Mic> Hi
11:16:27 <aleth> franksouza183: It has msn and gtalk support
11:16:31 <aleth> What do you mean by cam?
11:16:38 <aleth> Hi Mic
11:16:43 <franksouza183> webcam
11:16:54 <aleth> Ah... 
11:17:03 <aleth> That's not supported yet.
11:19:58 <Mic> Ah, great. The graphics glitch with the context bubbles is gone with moz9. :)
11:20:48 <flo> oh, really? :)
11:21:22 <franksouza183> Aleth, where are the current conversation themes
11:21:25 <franksouza183> ?
11:22:42 <franksouza183> directory
11:23:00 <franksouza183> I can not find them
11:23:11 <aleth> I gave you the link a couple of messages up
11:23:47 <franksouza183> o.o
11:23:52 <franksouza183> sorry
11:24:57 <aleth> franksouza183: On IB, a message style is a theme for the messages. A theme is a skin for the entire app. Those are two different things.
11:25:30 <aleth>  (They are sometimes confusingly labelled :/ )
11:25:39 <franksouza183> understood
11:26:03 <Mic> Message styles can be found here: https://addons.instantbird.org/en-US/instantbird/browse/type:1/cat:6?sort=rated
11:26:09 <Mic> Themes there: https://addons.instantbird.org/en-US/instantbird/browse/type:2
11:26:30 <Mic> Docs for creating a message style are on the wiki: https://wiki.instantbird.org/Main_Page
11:27:12 <franksouza183> yes, I'm reading
11:29:33 --> hunsly has joined #instantbird
11:31:02 <franksouza183> o.O
11:31:13 <franksouza183> I try to convert ambiance theme
11:31:21 <franksouza183> but give compatibility message
11:31:24 <franksouza183> :(
11:32:23 <Mic> If the extension is not compatible, change the install.rdf to have a matching maxVersion
11:32:32 <franksouza183> ok
11:33:08 <Mic> Have fun with it!
11:33:15 * Mic is away for lunch now.
11:34:07 <-- BlueMaxima has quit (Quit: Instantbird 1.1)
11:45:35 <franksouza183> hey dudo
11:45:54 <franksouza183> Now the problem is the script
11:46:22 <franksouza183> it does not create the xpi according to the link you gave me
11:46:29 <franksouza183> https://wiki.instantbird.org/Instantbird:Message_Styles:Conversion
11:46:58 <franksouza183> in the example he should give me the file vacation_5_17162_5829.xpi
11:47:33 <franksouza183> but he is giving me a file with no name, only with the extension .xpi
11:48:06 <franksouza183> Processing ./Vacation.AdiumMessageStyle:
11:48:08 <franksouza183>   Creating vacation.jar
11:48:10 <franksouza183>   Creating vacation.xpi
11:48:11 <franksouza183>  Moving to .xpi
11:48:13 <franksouza183> Done!
12:00:04 <flo> do you still have a vacation.xpi file somewhere?
12:00:13 <flo> if so, it doesn't matter :)
12:00:27 <franksouza183> no no
12:00:42 <franksouza183> anywhere
12:01:48 <franksouza183> only one file with no name, only with the extension .xpi
12:01:51 <franksouza183> ".xpi"
12:03:24 <flo> I guess you can rename it
12:03:37 <flo> (or figure out where the script breaks, if you know how to hack shell scripts)
12:03:44 * flo is away for lunch
12:03:59 <franksouza183> i tried to rename
12:04:11 <franksouza183> do not work
12:04:49 <franksouza183> I'll try to look at the script
12:34:11 <-- franksouza183 has quit (Quit: franksouza183)
12:49:24 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
13:25:47 <flo> I have some "Error: Unable to report telemetry. Source File: resource://gre/modules/PlacesDBUtils.jsm Line: 977" in the error console of my debug build.
13:25:58 <flo> does it happen in nightlies too?
13:26:32 <flo> the error console of my nightly is so flooded with debug libpurple messages that I can't notice occasional warnings from the Mozilla platform.
13:27:02 --> franksouza183 has joined #instantbird
13:52:32 --> jb has joined #instantbird
13:55:15 <-- skeledrew has quit (Quit: Instantbird 1.2a1pre)
14:07:39 <-- franksouza183 has quit (Ping timeout)
14:07:50 --> franksouza183 has joined #instantbird
14:13:50 --> clokep has joined #instantbird
14:13:50 * ChanServ sets mode +h clokep 
14:14:35 <flo> clokep: hello :)
14:15:04 <flo> I fixed that "broen" comment before pushing yesterday. I just didn't send another pastebin as it was "too late" anyway ;)
14:15:23 <clokep> flo: Great! (And hello.)
14:16:02 <flo> I also removed a leftover debugger; statement, and fixed another typo/spelling error in a comment
14:16:49 <clokep> Yeah I saw you pushed it, but didn't check if you had fixed the comment. :)
14:21:53 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
14:23:16 --> clokep has joined #instantbird
14:23:16 * ChanServ sets mode +h clokep 
14:23:50 <clokep> flo: I just got the start up error that asks you to check for an update.
14:24:09 <clokep> EVEN in safe mode or when I moved my extensiosn folder.
14:24:15 <flo> that's bad
14:24:20 <clokep> Forcing a rebuild of my buddy list fixed it. :-/
14:24:31 <flo> oh, it wasn't on a nightly?
14:24:37 <clokep> It was on a nightly.
14:24:41 <clokep> On my real profile.
14:24:52 <flo> you have kept the previous blist.sqlite file?
14:24:56 <clokep> (I renamed blist.sqlite to blist.sqlite.old, force the buddy list to rebuild.)
14:24:58 <clokep> Yes.
14:24:59 <clokep> Would you like it?
14:25:13 <flo> not really. I would prefer if you could investigate ;)
14:25:24 <clokep> Let me get sqlite explorer.
14:25:37 <flo> open both the old and the new file, and check for differences
14:25:47 <clokep> K.
14:25:47 <flo> maybe you can dump the whole content and then make a diff?
14:25:58 <-- franksouza183 has left #instantbird ()
14:26:01 <flo> what was the error?
14:26:11 --> franksouza183 has joined #instantbird
14:26:27 <flo> anything useful in the error console?
14:26:51 <clokep> The error was in buddy init
14:27:05 <clokep> I can get it for you in a second.
14:27:18 <flo> I think you have a debug build. If you copy that broken profile (you probably only need blist.sqlite and prefs.js) to a debug profile, are there descriptive errors in the terminal? :)
14:28:09 <flo> interesting errors in the terminal of debug builds were more frequent when the code was in C++ though (as it printed all the failures of the NS_ENSURE_* macros)
14:28:10 * instantbot mumbles something about c++ being evil
14:28:36 <clokep> flO: The error.
14:28:37 <clokep> http://pastebin.instantbird.com/1106
14:29:33 <flo> ahah
14:29:53 <flo> well, you can probably stop your investigations here :)
14:29:59 --> clokep1 has joined #instantbird
14:30:08 <flo> it's so nice when error messages explain the real problem :)
14:30:27 <clokep> Eek my debug build is taking over my computer. ;)
14:30:33 <-- clokep1 has quit (Connection reset by peer)
14:31:01 <clokep> You know what the problem is then?
14:31:12 <flo> your blist.sqlite is corrupted
14:31:20 <clokep> Well I figured that. :P
14:31:20 <flo> but in a different way that what I tracked down yesterday
14:31:25 <clokep> Ohhh OK.
14:31:31 <flo> and in a quite obvious way
14:32:13 <flo> and the corruption check I added yesterday throws an exception in your case
14:33:27 <clokep> Ah, anything I can do or just rebuild from scratch?
14:33:59 <flo> I'll give you a patch to try in a few seconds
14:34:58 <clokep> Cool.
14:36:39 <flo> let me test it in a debug profile with a large buddy list first though :)
14:37:15 <flo> bah, that was a good idea, my code prevents startup because of a typo on the case of a variable :)
14:37:40 <clokep> :( Those are the worst.
14:37:56 <clokep> (Well the worst is really if the typo is /another/ variable that's still valid.)
14:38:09 <flo> and that still doesn't work :(
14:38:51 <flo> [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: resource://gre/modules/XPCOMUtils.jsm :: XPCU_serviceLambda :: line 232"  data: no]
14:38:51 <flo> :(
14:39:14 <clokep> :-/ Which service?
14:39:24 <flo> ahah, that would be too easy ;)
14:40:40 <flo> I have the same startup error if I comment out the code I've just added, and the error is clearly after loading the buddy list, so I guess you can still try in a debug build
14:41:08 <flo> it's possible I broke something somewhere else just before you reported that error ;)
14:41:51 <clokep> I'm updating my debug build now. HOpefully it's in a state it can build. :(
14:43:21 <flo> I seem to be having a failure when creating a protocol plugin
14:43:44 <flo> if you can't test with a debug build, an unpacked nghtly will do
14:44:09 <flo> clokep: http://pastebin.instantbird.com/1107
14:46:56 <flo> ahah, would you have guessed that the broken prpl is @instantbird.org/purple/xmpp;1 ? ;)
14:47:46 <clokep> Haha, I could have guessed. :P
14:49:39 <flo> if only my debug build could tell me *any* thing about why it doesn't work :(
14:50:01 <flo> oooh!
14:50:09 <flo> xpcshell can import JS modules too :)
14:50:21 <flo> resource:///modules/jsProtoHelper.jsm:437: SyntaxError: property name account appears more than once in object literal
14:50:21 <flo> :)
14:51:36 <clokep> Ah, that's clever.
14:51:43 <clokep> I remember using xpcshell at some point, it's handy.
14:52:21 * flo should write an xpcshell user interface importing the instantbird core, and connecting the accounts
14:53:31 <-- jb has quit (Ping timeout)
14:53:39 --> clokep1 has joined #instantbird
14:53:50 <-- clokep1 has quit (Quit: Instantbird 1.2a1pre)
14:53:54 <clokep> flo: that patch worked.
14:54:05 <flo> how many corrupted entries are listed in your error console?
14:55:37 <clokep> A lot.
14:56:21 <flo> a lot = dozens, or rather hundreds/thousands?
14:56:34 <clokep> Probably around a hundred.
14:57:12 <clokep> About 130.
14:57:25 <clokep> All from the same account ID
14:57:37 <flo> does that account exist?
14:57:38 <-- GeekShadow has quit (Ping timeout)
14:57:43 <clokep> Yes.
14:57:48 <flo> which protocol?
14:57:50 <clokep> My MySpace account. ;)
14:57:54 <flo> ahah
14:57:59 <clokep> Not surprising.
14:58:12 <flo> I didn't even remember we had a prpl for that :)
14:58:15 <clokep> (For reference: I don't actually use myspace...I just have a really old account I connect to...:P)
14:58:17 <flo> does it work?
14:58:22 <clokep> I have no idea.
14:58:27 <clokep> I don't think I have any friends that use it. ;)
14:58:35 <flo> but it connects without crashing?
14:58:45 <clokep> Yes.
14:58:49 <clokep> It used to crash on status change.
14:58:59 <flo> and it doesn't any more?
14:59:00 <clokep> That no longer happens since we updated to libpurple 2.9 though?
14:59:26 <flo> Or is it just another nice benefit from my patch cancelling automatically timers/socket watches for disconnected libpurple accounts?
14:59:46 <clokep> No, it wasn't that.
15:00:11 <flo> so I guess I should check-in that patch? ;)
15:00:13 <clokep> bug 567
15:00:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=567 maj, --, ---, nobody, RESO WORKSFORME, Crash [@ msim_status_text ] in the myspace protocol plugin.
15:00:18 <clokep> Probably. :)
15:00:23 --> GeekShadow has joined #instantbird
15:00:28 <clokep> I'm going to rebuild my buddy list anyway...
15:00:54 <clokep> Ah, maybe it was the timers I say in that bug. :)
15:01:22 <flo> why do you need to rebuild it?
15:01:48 <flo> are there errors other corruptions (the corruption I detected yesterday for example)?
15:02:11 <clokep> I have all the buddies from a "missing" prpl (js-xmpp).
15:02:42 <flo> is this a problem?
15:03:06 <flo> if you delete the account, aren't they going to be removed?
15:03:57 <clokep> Yeah I could just do that.
15:06:09 <flo> by the way, wasn't the corruption we discovered today in your blist.sqlite file already causing lots of errors?
15:06:20 <clokep> I think it was, yes.
15:06:29 <clokep> Just previously non-fatal ones?
15:06:48 <flo> yeah... just you could have reported them ;)
15:06:58 <clokep> Oh.
15:07:06 <clokep> No it wasn't reporting an errors that popped up anywhere.
15:07:19 <clokep> I thought you meant the buddies randomly disappearing one.
15:07:20 <flo> they should have been in the error console
15:07:40 <clokep> Right, the only ones I ever had in there were buddies not being able ot load because of an unknown purple.
15:07:47 <flo> but if like me you have auto-login enabled on your usage profile, libpurple debug messages make real errors disappear very quickly :(
15:08:11 <flo> sure? They should have been on the same line of the same file. Just with a different error message.
15:08:37 <clokep> I didn't think it was actually an error though since I had removed that prpl. :P
15:08:45 <clokep> (I.e. I assumed it was "my fault", user error. ;))
15:10:24 <flo> anyway, it's fixed now!
15:10:32 <clokep> Yup! Thanks for looking at it. :)
15:13:15 <flo> it's amazing how many strange behaviors disappear once accountBuddy.normalizedName and conversation.normalizedName return the correct value :)
15:13:19 --> Tomek has joined #instantbird
15:13:22 <-- Tomek has quit (Connection reset by peer)
15:15:07 --> Tomek has joined #instantbird
15:22:42 --> jb has joined #instantbird
15:27:25 <-- jb has quit (Ping timeout)
15:44:51 --> ecaron has joined #instantbird
15:49:53 --> igorko has joined #instantbird
15:52:28 <-- franksouza183 has left #instantbird ()
16:28:07 <clokep> Hmm...new Mozilla Build released.
16:28:19 <clokep> Last time when I tried the release candidate...it didn't work. :(
16:28:27 <clokep> But I probably didn't clobber my trees.
16:28:41 <flo> why would you need to clobber trees for that?
16:29:02 <clokep> "3. Clobber (remove the object directory of) any trees you have. (If you don't do this you'll get weird build errors)."
16:29:16 <clokep> I'm not sure why, perhaps the upgrade in python?
16:40:34 <-- hunsly has quit (Ping timeout)
16:41:16 <clokep> So where does the installer end up if I |make package|?
16:41:35 <clokep> Bah I found it.
16:41:36 <clokep> Nveer mind.
16:41:42 <flo> mozilla/dist/
16:42:15 <clokep> I was expecting it in the "install" subdir of that. :) It's in the root.
16:42:53 <flo> of "review denied" is now "review not granted" on BMO :-D
16:43:11 <-- flo has quit (Quit: Instantbird 1.2a1pre)
16:46:17 --> hunsly has joined #instantbird
16:47:39 --> jb has joined #instantbird
16:47:39 <clokep> Hah, can bugs still be "invalid"?
17:23:31 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
17:24:41 --> clokep has joined #instantbird
17:24:41 * ChanServ sets mode +h clokep 
17:41:56 <-- gerard-majax has quit (Ping timeout)
17:53:57 --> Mook_as has joined #instantbird
18:03:36 <-- GeekShadow has quit (Ping timeout)
18:08:37 <-- Tomek has quit (Quit: Instantbird 1.1)
18:12:13 --> mikk_s has joined #instantbird
18:12:29 <-- mikk_s has quit (Quit: Instantbird 1.1)
18:19:20 --> GeekShadow has joined #instantbird
18:21:07 --> gerard-majax has joined #instantbird
18:23:09 --> Mic has joined #instantbird
18:23:09 * ChanServ sets mode +h Mic 
18:25:01 <-- clokep has quit (Ping timeout)
18:31:00 --> clokep has joined #instantbird
18:31:00 * ChanServ sets mode +h clokep 
18:54:09 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
19:01:26 <-- jb has quit (Ping timeout)
19:12:31 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
19:19:54 --> Tomek has joined #instantbird
19:25:11 <-- igorko has quit (Quit: Instantbird 1.1)
19:41:22 --> EionRobb has joined #instantbird
20:02:09 --> flo has joined #instantbird
20:02:09 * ChanServ sets mode +qo flo flo 
20:07:10 <-- clokep has quit (Ping timeout)
20:13:59 --> aleth has joined #instantbird
20:17:05 <-- chrisccoulson has quit (Client exited)
20:17:10 --> chrisccoulson has joined #instantbird
20:21:43 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
20:22:32 --> aleth has joined #instantbird
20:46:28 <-- ecaron has quit (Quit: Instantbird 1.1)
20:50:38 <flo> aleth: I also noticed some more of these warnings when editing the display name at the top of the contacts window
20:50:51 <flo> but I restarted before copying them :-/
20:50:59 <flo> (was debugging something else)
20:57:24 --> Mic has joined #instantbird
20:57:24 * ChanServ sets mode +h Mic 
21:02:12 <instantbot> New Instantbird (UI) bug 1185 filed by aletheia2@fastmail.fm.
21:02:13 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1015 on bug 1185.
21:02:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1185 nor, --, ---, nobody, NEW, No tab completion after brackets etc.
21:06:24 <aleth> I was amused to discover there was still a little tweak required on the regex, after all our testing yesterday... 
21:13:08 <flo> what did you have to change?
21:14:30 <flo> aleth: it looks good except for the double space before { and the 2 unwanted spaces before }
21:15:55 <aleth> huh, I wonder when those crept in
21:17:09 <aleth> The change is an ? after the ([\w-]+) to handle completion of nicks beginning with symbols
21:17:47 <aleth> e.g. |<tab> now works for those strange nicks...
21:18:35 <flo> ok :)
21:19:07 <flo> the nice thing is that it doesn't even add more code :)
21:19:27 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1015 on bug 1185.
21:19:28 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1016 on bug 1185.
21:19:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1185 nor, --, ---, nobody, NEW, No tab completion after brackets etc.
21:21:59 <Mic> Has anyone noticed this comment and checked? http://blog.instantbird.org/2011/11/weekly-meeting-october-31-2011/comment-page-1/#comment-1117
21:24:03 <flo> I've just marked it as spam
21:24:39 <aleth> Just got a strange new error: Error: elt.select is not a function Source File: chrome://instantbird/content/conversation.xml Line: 1520
21:24:41 <flo> it seems to be someone trying to get as many links as possible as quickly as possible pointing to his "security" blog
21:25:53 <flo> aleth: do you have steps to reproduce? Editing the IRC topic seems to work for me :-S
21:27:00 <aleth> It works for me too :S And I can't even remember touching the topic, that's the weird thing
21:27:24 <aleth> So far can't reproduce
21:28:02 <Mic> Ah yes, if I had checked the linked adress it should have been obvious.
21:29:58 <aleth> It happened again - on startup and autojoining conversations.
21:31:06 <aleth> Maybe if the method is called before initialization has finished?
21:32:24 <flo> is that line number in startEditTopic for you?
21:32:42 <aleth> Sure
21:32:51 <flo> that's really strange
21:33:03 <aleth> Yes
21:33:21 <aleth> (current unmodified nightly btw)
21:37:23 <Mic> Is the "Corrupted database" error as scary as it sounds?
21:40:41 <flo> you mean the error that prevents the application from starting, or the error you see in the error console?
21:42:11 <-- micahg_ has quit (Ping timeout)
21:42:17 <Mic> If it was the former I'd be running around screaming by now as it's happening on my everyday-use profile ;)
21:42:24 <Mic> Just on the console ..
21:42:38 --> micahg_ has joined #instantbird
21:42:55 <flo> well, clokep's everyday-use profile prevented the current nightly from starting today ;)
21:43:38 <flo> Mic: if the error count increases over time, it's scary (= we still have a bug somewhere corrupting the database that we should identify).
21:43:50 <flo> otherwise, it's just noise in the error console
21:44:18 <flo> if you could identify the protocol plugin related to these errors, that may be interesting
21:44:19 <Mic> OK, was there two times .. seems to be for an IRC contact, judging from the account id
21:45:51 <Mic> brb
21:45:53 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
21:46:33 --> Mic has joined #instantbird
21:46:33 * ChanServ sets mode +h Mic 
21:47:26 <flo> I wonder if these corruption on clokep's blist could be responsible for bug 1017.
21:47:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1017 cri, --, ---, florian, ASSI, Shutdown crash [@ purple_blist_node_set_ui_data ]
21:54:07 <Mic> What does the "buddy"  in the message represent?
21:54:30 <flo> paste the message?
21:54:48 <Mic> d'oh.
21:55:00 <Mic> It says account_buddy there, not buddy. Sorry.
21:55:10 <flo> "buddy_id" is the id in the buddy table
21:55:41 * flo is confused.
21:55:45 <flo> What's the question exactly?
21:56:31 <Mic> It's all right, I asked when I didn't have to.
21:58:14 <flo> those messages don't target end users, but people who have read the SQL schema
22:12:57 * Mic hates the illegal-character errors in lxr :(
22:13:03 --> clokep has joined #instantbird
22:13:03 * ChanServ sets mode +h clokep 
22:13:40 <Mic> Good night
22:13:45 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
22:24:35 --> jb has joined #instantbird
22:25:46 <clokep> It seems that very soon we're going to have an awesome tab-complete algorithm. :)
22:38:54 <flo> aleth: if I type <space><tab>, I have a system message listing all nicks.
22:40:56 <flo> + they are sorted case sensitively, so I have serious doubt on the common prefix detection code :(
22:42:38 <flo> s/doubt on/doubt on the case insensitiveness of/
22:43:54 <flo> aleth: it seems with the ? you added in the regexp, words[1] can now be an empty string
22:45:06 <clokep> Which bug is this?
22:45:11 --> billysanca has joined #instantbird
22:45:43 <flo> bug 1185
22:45:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1185 nor, --, ---, nobody, NEW, No tab completion after brackets etc.
22:46:07 <-- billysanca has quit (Quit: Instantbird 1.2a1pre)
22:47:05 <flo> clokep: I wonder if your shutdown crash could be caused by the blist.sqlite corruption. (not sure if you have seen that in the log)
22:47:23 <clokep> flo: I saw that.
22:47:36 <clokep> I haven't shut down today, only put my computer to sleep.
22:47:46 <clokep> So I don't know if I'm still crashing or not.
22:48:17 <clokep> So that regexp is trying to match any character followed by just word characters...and in order to do what?
22:50:10 <clokep> If it can't find a match with the whole string it tries just the second half?
22:50:14 <clokep> But what is this trying to solve?
22:51:02 <aleth> heh, clokep jinxed it ;)
22:51:13 <flo> aleth: hmm, with a ? on both parts of the regexp, it seems impossible to not match the whole regexp, so I suspect if (words) is always true, and you wanted to test if (word[0]) instead
22:52:20 <flo> clokep: yesterday I typed "Maybe we should blah blah (ec<tab>" and expected a completion
22:52:23 <aleth> You are right, the problem is that word[1] can be empty. And anything will complete that.
22:52:46 <flo> aleth: I think word[0] is empty too when the input box contains only a space
22:52:52 <-- Tobin has quit (Quit: Everything you do is to hurt me, leave me alone.)
22:52:54 <aleth> Should be.
22:53:05 <clokep> So you want to match anything? Shouldn't you just use \S then?
22:53:07 --> Tobin has joined #instantbird
22:53:14 <clokep> And if you can't find matches then skip the first letter and repeat. ;)
22:53:34 <aleth> clokep: That wouldn't be wise...
22:53:52 <flo> clokep:  we match \S and if there's no result, we skill all non alpha-num chars and try again
22:54:08 <flo> that's what the current patch is trying to do
22:54:14 <aleth> flo is right, it's the changed regex having new edge cases
22:54:27 <clokep> aleth: I agree it's not a good idea, but yes. ;)
22:54:50 <clokep> I need to think about it more...
22:55:07 <flo> want to review the next version of the patch?
22:55:20 <aleth> For some reason I wasn't thinking and assumed an empty string would match nothing ;) rather than everything...
22:56:03 <clokep> I can lookat it, yes.
22:56:19 <clokep> aleth: I'd suggest providing a list of nicks it's supposed to match btw.
22:56:26 <flo> this version looked good... until I tried it :-P
22:56:28 <clokep> (Also http://regexpal.com/ is a great tool.)
22:56:42 <flo> clokep: what do you mean?
22:56:43 <clokep> (Just tick of ^$ matches at line breaks)
22:56:43 <aleth> flo is edge case detector guru :)
22:57:00 <flo> the point of completing is that it needs to match *incomplete* nicks ;)
22:58:02 <flo> aleth: well, my ability to do that can vary widely, based for example on tiredness
22:58:57 <flo> the worst for reviews is falling in love. It's really a state of mind in which one should avoid r+'ing patches (it's almost guaranteed they'll need to be rewritten a few days or months later...)
22:59:03 <aleth> Tiredness gets anyone...
22:59:09 <aleth> lol
22:59:12 <aleth> interesting
23:00:33 <flo> Moria n got lots of r+es in that situation a few years ago. And then we had to rewrite the code of the magic textbox at least twice :-D.
23:00:59 <clokep> Good to know. ;)
23:02:17 <flo> clokep: I think the current textbox code is much more readable (even though it's still complicated... but the desired behavior isn't simple)
23:04:42 <clokep> flo: Right. You also told me once if you want a bug fixed to attach a bad patch to it and let you clean it up. ;)
23:05:35 <flo> isn't this what's happening with JS-XMPP?
23:06:43 <flo> clokep: anyway, getting an r+ by making me fall in love at the same time seems like a difficult process. Getting the r+ by attaching a correct patch sounds easier (to me at least).
23:07:10 <clokep> Yes, probably. :)
23:11:39 * Mook_as wonders if getting flo drunk will work too. that also seems harder, though, than a correct patch.
23:11:40 <clokep> Ah dinner time.
23:11:40 <clokep> Goodnight!
23:12:00 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
23:13:55 <flo> Mook_as: good luck! Nobody has succeeded in getting me drunk (yet?).
23:15:07 <flo> Mook_as: + yeah I think you definitely have the abilities to produce a correct patch without too much effort
23:15:17 <Mook_as> oh, I won't be the one trying it. I'm ridiculously easy to get drunk.
23:17:05 <flo> Mook_as: I didn't think you would be flying to France to try that. I thought you were imagining using someone else to do the dirty work, while you would be crafting your incorrect but "r+able" patch :-D.
23:17:50 <Mook_as> oh, I was hoping for "get william confused again and get shipped to a mozcamp eu" :p
23:18:03 <flo> "flying to France" includes implicitly "or waiting for me to fly to more or less where you live"
23:18:09 <-- jb has quit (Ping timeout)
23:18:18 <flo> uh?
23:18:35 <flo> Were you at MozCamp EU?
23:18:42 <Mook_as> two years back or so? (whichever one was in prague)
23:19:00 <flo> did we met? I think I attended the Songbird talk
23:19:11 <Mook_as> probably, yes.
23:19:25 <flo> I definitely brought home a songbird tshirt or two
23:19:34 <Mook_as> yeah, that should be the one I was at
23:21:21 <flo> so did you get william confused by getting him drunk?
23:22:35 <Mook_as> no, I think somebody else did; he thought we were in europe somewhere.
23:22:43 <Mook_as> (last I checked, san francisco wasn't.)
23:23:22 <Mook_as> it was nice showing up and meeting folks, though. :)
23:23:52 <flo> well, if MozCamp *Europe* is supposed to invite only people from Europe, then William got very drunk this year :-D.
23:25:47 <flo> this year there were people from various parts of Africa, Russia, Turkey, and lots of MoCo employees from north America...
23:33:45 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f7e273f69c46 - Florian Quèze - Report an error in the console for another kind of blist.sqlite corruption.
23:33:45 <flo> Good evening/night :)
23:33:45 <-- flo has quit (Quit: Instantbird 1.2a1pre)
23:40:49 <-- Tonnes has quit (Input/output error)
23:42:19 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1016 on bug 1185.
23:42:20 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1017 on bug 1185.
23:42:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1185 nor, --, ---, nobody, NEW, No tab completion after brackets etc.
23:44:11 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1017 on bug 1185.
23:44:12 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1018 on bug 1185.
23:54:45 --> Tonnes has joined #instantbird
23:54:52 <-- hunsly has quit (Ping timeout)