All times are UTC.
00:00:51 --> GeekShadow has joined #instantbird 00:03:22 <-- Tomek has quit (Quit: Instantbird 1.1) 00:10:15 --> clokep has joined #instantbird 00:10:15 * ChanServ sets mode +h clokep 00:12:49 <-- GeekShadow has quit (Ping timeout) 00:13:56 <-- chrisccoulson has quit (Ping timeout) 00:17:08 --> GeekShadow has joined #instantbird 00:29:19 <-- BlueMaxima has quit (Quit: Instantbird 1.1) 00:57:37 <-- GeekShadow has quit (Ping timeout) 01:07:39 --> GeekShadow has joined #instantbird 01:09:39 <-- aleth has quit (Input/output error) 01:32:34 <-- Mook_as has quit (Quit: gone) 01:57:07 --> billysanca has joined #instantbird 02:08:17 <-- EionRobb has quit (Quit: Leaving.) 02:09:27 --> EionRobb has joined #instantbird 02:11:00 <-- EionRobb has quit (Quit: Leaving.) 02:11:29 --> EionRobb has joined #instantbird 02:12:03 <-- EionRobb has quit (Quit: Leaving.) 02:12:23 --> EionRobb has joined #instantbird 02:17:34 <-- EionRobb has quit (Quit: Leaving.) 02:17:48 --> EionRobb has joined #instantbird 02:42:44 <-- billysanca has quit (Quit: Instantbird 1.2a1pre) 03:04:02 <-- Even has quit (Ping timeout) 03:08:42 --> Even has joined #instantbird 03:08:42 * ChanServ sets mode +o Even 03:12:46 <-- Even has quit (Input/output error) 03:12:47 --> Even has joined #instantbird 03:12:47 * ChanServ sets mode +o Even 03:15:55 <-- devfil has quit (Client exited) 03:16:04 <-- clokep has quit (Quit: Instantbird 1.2a1pre) 03:28:00 <-- Even has quit (Ping timeout) 04:49:13 --> skeledrew has joined #instantbird 04:59:08 <-- EionRobb has quit (Quit: Leaving.) 05:03:02 --> Mook has joined #instantbird 05:38:05 --> BlueMaxima has joined #instantbird 06:06:13 <-- gerard-majax has quit (Ping timeout) 06:29:22 --> Guido has joined #instantbird 07:05:02 <-- Guido has quit (Quit: Instantbird 1.1) 07:12:45 <-- Mook has quit (Quit: z) 07:23:14 --> Usul has joined #instantbird 07:24:12 --> Even has joined #instantbird 07:24:13 * ChanServ sets mode +o Even 07:50:09 --> chrisccoulson has joined #instantbird 08:22:57 --> MadWookiee has joined #instantbird 09:07:15 --> gerard-majax has joined #instantbird 09:14:00 --> aleth has joined #instantbird 09:33:35 --> hunsly has joined #instantbird 09:38:52 <-- hunsly has quit (Ping timeout) 09:39:56 --> hunsly has joined #instantbird 09:41:53 <-- hunsly has quit (Ping timeout) 09:44:46 --> hunsly has joined #instantbird 09:45:02 --> mmkmou has joined #instantbird 09:45:38 <Usul> !seen flo 09:45:39 <instantbot> flo was last seen 10 hours, 25 minutes and 12 seconds ago, saying 'Good night :)' in #instantbird. 09:47:29 <-- mmkmou has left #instantbird () 09:51:28 <-- hunsly has quit (Ping timeout) 09:53:14 --> Mic has joined #instantbird 09:53:14 * ChanServ sets mode +h Mic 09:55:06 <Mic> Good day 09:56:21 <-- Usul has left #instantbird () 09:59:43 <aleth> Hello :) 10:00:10 <aleth> The linux build failed again 10:00:26 --> gmoro_ has joined #instantbird 10:07:08 <Mic> aleth: the Windows nightly too but for both new ones are on their way. 10:08:22 --> flo has joined #instantbird 10:08:22 * ChanServ sets mode +qo flo flo 10:08:55 <flo> hello :) 10:09:02 <Mic> Salut 10:09:27 --> Even1 has joined #instantbird 10:21:29 <-- SM0TVI has quit (Connection reset by peer) 10:22:25 --> SM0TVI has joined #instantbird 10:50:25 <Mic> The Windows nightly failed again :( 10:50:38 <Mic> 'slave lostà 10:52:25 <flo> Mic: thanks 11:06:53 --> jb has joined #instantbird 11:12:15 --> mmkmou has joined #instantbird 11:14:29 --> clokep has joined #instantbird 11:14:29 * ChanServ sets mode +h clokep 11:16:38 <Mic> flo: and again :( 11:17:09 <flo> I hate buildbot 11:25:00 <aleth> What does 'slave lost' mean? What connection is being lost? 11:26:13 <-- mmkmou has left #instantbird () 11:27:09 <clokep> I believe it's the buildbot master not being able to connect to the buildbot slave. 11:27:38 <aleth> On the same machine? 11:28:25 <clokep> No? 11:28:32 <clokep> The Windows buildbot slave is a VM. 11:28:36 <Mic> I'm not sure it's the same machine. I think there's one master controlling different machines /Mac/Linux machinge/Windows VM to build and gathers the results 11:28:41 <clokep> (On the actual Linux machine, I believe). 11:29:06 <clokep> Yes. I don't know what machine the master is on actually, probably one of the servers. 11:29:28 <Mic> Check out the buildbot waterfall, there should be links to the output during the compilation 11:29:35 <aleth> Right. 11:29:42 <aleth> Mic: that's what I was looking at... 11:29:43 <Mic> You can see error messages and stuff there 11:29:52 <flo> There are 3 physical machines involved. One is a FreeBSD server hosting buildbot.instantbird.org (and lots of other services). One is an old PowerMac G5 hosting the mac buildbot slave. The third is a recent destkop linux machine in Even's appartment, running a Windows VM and a Linux VM that are the buildbot slaves. 11:30:26 <aleth> Quite intricate then. 11:31:00 <aleth> And unfortunately without auto-reconnect ;) 11:31:02 <flo> the slave lost errors are (most likely) related to instability of the DSL connection of Even's apartment 11:31:13 <flo> aleth: they totally auto reconnect 11:32:01 <aleth> oh, I misinterpreted the 'connection lost' error message then 11:32:03 <flo> it's just too bad that buildbot assumes a slave has stopped doing the work as soon as the network link with the master is broken 11:32:56 <flo> even if it's broken of only a couple of seconds, in the middle of a job taking hours... 11:33:01 <flo> *for only 11:35:22 <flo> aleth: you'll have a linux nightly soon. It's currently uploading 11:37:12 <aleth> flo: Ah, I didn't misunderstand after all then. 11:38:14 <aleth> And you don't do the whole thing in VMs on the same machine because it would take much longer that way. 11:38:39 <aleth> Or is it that Mac VMs are tricky? 11:38:39 <flo> if slaves didn't auto-reconnect, we would have to go kick them in the butt to get them to be available for new jobs again ;). 11:38:53 <flo> Mac VMs don't work 11:39:46 <flo> or didn't a few years ago :) 11:39:56 <flo> we tried before I bought the current mac build server 11:40:07 <aleth> flo: yeah, by 'auto-reconnect' I originally meant 'master doesn't assume build fail on connection failure'... 11:40:33 <flo> creating a build on that VM took ~6 hours (and that wasn't universal builds yet!) and the clock was always several hours or days off, causing problems for the uploaded files 11:40:54 <aleth> Whoa. That's long 11:40:57 <clokep> I think they work now OK, but the legality is dubious (at least in the US). 11:41:28 <flo> clokep: people alreayd pretended they worked at the time 11:41:55 <flo> but the disk access were extremely slow, and the clock was diverging 11:42:25 <clokep> Right. 11:42:35 <clokep> So they only workd for people to mess around on, not for production. 11:46:19 <Mic> d#oh. First result when typing "Compiling" into Google is .. xkcd comic #303 :D 11:48:13 <aleth> Well, the nightyl is ready :) 11:48:31 <aleth> Here goes 11:48:33 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 11:48:35 --> hunsly has joined #instantbird 11:48:46 --> aleth has joined #instantbird 11:49:41 <-- clokep has quit (Quit: Instantbird 1.2a1pre) 11:50:23 <aleth> flo: Is there anywhere you are compiling a list of undefined properties? 11:50:50 <aleth> Or won't that be necessary 11:50:51 <flo> no(t yet) 11:51:11 <flo> you can file a bug and start listing/fixing them if you want :) 11:52:14 <aleth> O hai twitter is back :) 11:55:30 <aleth> What is nice is that displaying a reasonably long conv from hold is noticeably faster 11:57:02 <flo> really? 11:57:43 <aleth> If I am not imagining things ;) 11:57:47 <flo> the biggest conv on hold I have to test right now has only ~120 messages, so I can't tell for sure 11:58:17 <aleth> was ~400 tweets 12:46:15 <-- hunsly has quit (Ping timeout) 12:51:52 --> clokep_work has joined #instantbird 12:51:52 * ChanServ sets mode +h clokep_work 12:56:39 --> ironhead has joined #instantbird 13:08:46 * flo has just wasted some more time (at least half an hour, maybe an hour) because of poor error reporting of the JS engine :( 13:12:27 <clokep_work> :-/ Speaking of which, a reduced test case for that component bug...I assume it should be a Firefox component? 13:12:53 <flo> yeah... 13:13:09 <flo> and I should try to create a reduced testcase for the thing on which I just wasted time 13:13:11 --> devfil has joined #instantbird 13:14:34 <-- jb has quit (Ping timeout) 13:15:01 --> deOmega has joined #instantbird 13:15:38 --> jb has joined #instantbird 13:17:49 <deOmega> good morning.. The nightly from sunday I suppose (Sorry) broke twitter. I have not been able to connect so had to revert to an older copy 13:19:28 <deOmega> only ones I could have found on the web site are from nove 22 and oct 13 13:19:32 <clokep_work> deOmega: It should be fixed if today's ever gets uploaded. 13:19:48 <clokep_work> / built 13:20:02 <clokep_work> What are the only ones you could find? 13:20:12 <deOmega> tried installing nov 22 and that caised some sort of dll file to be missing and so the program was not working... so went to oct 13, which is version 1.1 and that works 13:20:32 <deOmega> clokep_work: Thank you. How have you been? 13:20:36 <clokep_work> I'm OK. 13:20:44 <clokep_work> deOmega: Yes, that's why we shut off updates to that version. ;) 13:20:57 <clokep_work> The last working version w/ Twitter should be November 20th until today's works. (I think.) 13:21:05 <clokep_work> Busy recently. :( 13:22:06 <deOmega> Ok, i do not see any for nov 20th, http://ftp.instantbird.com/instantbird/nightly/ 13:22:20 <deOmega> Busy is good.. I suppose 13:22:37 <clokep_work> deOmega: That only lists the newest for each, you have to browse by year, month, date: http://ftp.instantbird.org/instantbird/nightly/2011/11/ 13:22:56 <clokep_work> http://ftp.instantbird.org/instantbird/nightly/2011/11/2011-11-20-06-instantbird/ specifically I guess. 13:23:04 <clokep_work> (And if the 20th doesn't work, it should be the 19th. :-D) 13:23:26 <clokep_work> I don't think we ever filed a bug on the issue though. 13:24:02 <deOmega> haha, one of these days i will get it straight lol. Thank you 13:26:41 <deOmega> Thank you aleth for the new message style 13:27:22 <deOmega> brb 13:27:41 <-- deOmega has quit (Quit: Instantbird 1.1a1pre) 13:27:50 <Mic> psst, you can always try the super secret http://ftp.instantbird.com/instantbird/nightly/lastknowngood/ adress (and no, it does not really exist;) 13:29:20 <Mic> Maybe that wouldn't be such a bad idea ;) 13:30:39 --> deOmega has joined #instantbird 13:31:12 <deOmega> ok, just came in to let u know that the nov 19th is the last working version date. 13:32:06 <deOmega> thanks for everything clokep... take care of yourself and hae a fantastic Thanksgiving. bye. 13:32:35 <clokep_work> deOmega: Thanks, you too! Thanks for letting us know. :) 13:32:59 <-- deOmega has quit (Quit: Instantbird 1.2a1pre) 13:42:10 <-- Mic has quit (Connection reset by peer) 13:49:13 <-- Even1 has quit (Quit: Instantbird 1.2a1pre) 13:49:20 --> Even1 has joined #instantbird 13:49:42 <Even1> Last win32 nightly on XUL 9 is ok. 13:52:14 <-- ironhead has quit (Quit: leaving) 13:55:32 <clokep_work> Great! Thanks Even1! 14:00:19 <-- aleth has quit (Input/output error) 14:00:58 <-- jb has quit (Ping timeout) 14:02:14 --> aleth has joined #instantbird 14:38:30 --> Plop has joined #instantbird 14:55:25 --> Tomek has joined #instantbird 15:06:57 <-- BlueMaxima has quit (Quit: Instantbird 1.1) 15:08:27 <flo> DOMi and Venkman seem incompatible with toolkit v9 :( 15:09:59 <flo> hmm, that's strange, the maxVersion in the file seems <em:maxVersion>11.0a1</em:maxVersion>, that should be compatible :-S 15:13:51 <flo> removing extensions.sqlite in the profile folder "fixes" it 15:15:18 --> ecaron has joined #instantbird 15:15:28 <clokep_work> Wasn't there a bug in 8.0 that messed up extensions being compatible for some people? 15:17:02 <flo> I suspect I'm suffering from a bug only affecting built-in add-ons 15:17:39 <flo> the add-on manager doesn't check for updates for them, but when they are updated locally (because the application they ship with has been updated), it should detect the update :-/ 15:59:46 <clokep_work> Sounds like a deal breaker for SeaMonkey. 16:21:06 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 16:21:33 --> aleth has joined #instantbird 16:45:58 --> igorko has joined #instantbird 16:55:48 <-- aleth has quit (Quit: Instantbird 1.2a1pre) 16:56:59 --> aleth has joined #instantbird 17:02:27 --> jb has joined #instantbird 17:29:32 --> hunsly has joined #instantbird 17:32:03 <-- gerard-majax has quit (Ping timeout) 17:33:45 --> Mook_as has joined #instantbird 18:00:14 <-- devfil has quit (Client exited) 18:01:58 <instantbot> florian@instantbird.org set the Resolution field on bug 726 to DUPLICATE of bug 675. 18:02:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=726 nor, --, ---, nobody, RESO DUPLICATE, Invisible contacts in the "new" buddy list 18:02:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=675 nor, --, 1.0, florian, RESO FIXED, Sign off transition not starting/finishing 18:02:25 <flo> hmm, I seem to be in the situation of bug 968 in my debug profile :-S 18:02:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=968 maj, --, ---, nobody, NEW, Friends shown offline in buddylist when are in fact, online. 18:02:51 <clokep_work> That's good...you can debug it. ;) 18:03:17 <flo> I guess... 18:04:25 <flo> I wanted to debug the buddy statuses on JS-XMPP (it current mixes UNKNOWN and OFFLINE), but now I see unknown even when the code sent AVAILABLE :-D 18:05:01 <-- jb has quit (Ping timeout) 18:05:55 --> jb has joined #instantbird 18:07:35 <flo> hmm, deleting a JS-XMPP account doesn't remove the associated buddies from the contact list :-S 18:07:58 <clokep_work> Yes; I actually have JS-XMPP buddies in mybuddy list.... 18:08:08 <flo> without account? 18:08:09 <clokep_work> I ran it on my real profile by mistake once. :-X 18:08:12 <clokep_work> Yes. 18:08:16 <clokep_work> No extension anymore either. 18:08:39 <flo> did you delete the account before the extension? 18:08:49 <clokep_work> I think so. 18:09:16 <flo> after a restart they are gone (for me) 18:10:22 <clokep_work> Ah OK. Maybe I messed up then. :) 18:10:52 <flo> it's also possible that bug 759 improved the situation 18:10:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, florian, ASSI, Reorganize purplexpcom 18:10:59 <flo> as I've rewritten the core part of the code deleting accounts 18:11:08 <flo> and it's that code that removes the buddies from the sqlite database 18:11:16 <clokep_work> Ah, OK. 18:11:53 <flo> hmm, each time I connect my gtalk account, I get an additional entry for the online account_buddy 18:13:21 --> gerard-majax has joined #instantbird 18:16:34 <-- jb has quit (Ping timeout) 18:25:16 <flo> it's not the real cause, but this can at least prevent broken prpls from corrupting the database this way: http://pastebin.instantbird.com/1102 18:25:44 <-- Tomek has quit (Quit: Instantbird 1.1) 18:27:01 <-- Tonnes has quit (Quit: ChatZilla 0.9.87 [Firefox 8.0/20111104165243]) 18:27:46 <-- MadWookiee has quit (Quit: Instantbird 1.1) 18:29:06 <clokep_work> Right. Database bugs are a pain cause you want to handle the already corrupted cases. :( 18:30:58 <flo> I'm starting by stopping the corruption :) 18:31:04 <flo> and then figure out how we can cleanup the mess 18:48:28 --> jb has joined #instantbird 19:00:51 <-- flo has quit (Quit: Instantbird 1.2a1pre) 19:08:28 --> Tonnes has joined #instantbird 19:23:30 <-- Plop has quit (Quit: Instantbird 1.1) 20:00:34 --> flo has joined #instantbird 20:00:34 * ChanServ sets mode +qo flo flo 20:04:11 <-- chrisccoulson has quit (Ping timeout) 20:05:04 <-- hunsly has quit (Ping timeout) 20:06:14 <-- jb has quit (Connection reset by peer) 20:06:17 --> jb has joined #instantbird 20:15:00 --> chrisccoulson has joined #instantbird 20:18:05 --> EionRobb has joined #instantbird 20:23:46 <flo> a JS debugger would be so useful sometimes :( 20:25:33 <aleth> yeah... the dump() school of debugging is so very 1980s... 20:26:43 <flo> aleth: it's even worse when you used to have it ;). 20:27:27 <flo> I started playing with Mozilla front-end code in 2004 by putting more or less random break points with venkman, and stepping into functions, looking at the code that was being executed for various parts of the UI 20:27:27 <aleth> ? was there a proper JS debugger once? 20:27:50 <flo> absolutely. Venkman was super useful, at the time it worked. 20:27:56 <aleth> Oh, I wondered what venkman (depreciated) referred to on MDN 20:28:34 <flo> it was also a JS profiler. 20:28:47 <flo> when something is slow, it's so nice to know in which functions the time is spent ;). 20:28:51 <aleth> *sigh* 20:28:58 <Mook_as> it was probably more useful as a coverage analyzer than a profiler :) 20:29:03 <aleth> Yeah, especially as JS is interpreted, it should really have tools like python... 20:30:42 <flo> Mook_as: only a coverage analyzer? The times were interesting to read too 20:30:57 <Mook_as> I didn't trust that part much ;) 20:31:06 <flo> I feel old when I miss venkman :(. 20:32:09 <flo> Mook_as: well, the call counts then ;) 20:32:21 <Mook_as> sure, that's useful too :) 20:32:41 <aleth> What happened to venkman? It's not like nobody uses JS anymore... 20:32:59 <Mook_as> the js engine changed 20:33:08 <Mook_as> and nobody was around to fix the debugger :( 20:33:19 <flo> aleth: people started to care more about JS engine speed than about not breaking the old tools, especially those that didn't have any test suite 20:33:57 <flo> I suspect most people working on the JS engine today have never seen venkman running in a useful way 20:34:43 <flo> aleth: if you compile instantbird with --enable-debug, you will have venkman included by default. The code still exists. But good luck getting anything valuable out of the broken versions we have these days... :'( 20:34:44 <Mook_as> also non-jseng bits... venkman was always iffy when dealing with xbl, for example 20:35:22 <flo> right, that has never worked very well, but it did work sometimes a few years ago. 20:35:38 <Mook_as> yeah, used it a bit for songbird 20:35:40 <flo> getting it to recognize JS XPCOM component was tricky too 20:35:49 <Mook_as> then it went... downhill. (it wasn't a very large hill.) 20:36:03 <flo> Mook_as: from what I remember, putting a debugger; keyword in the middle of the code (even XBL) worked all the time. 20:36:11 <Mook_as> yep! 20:36:22 <Mook_as> (at least on 1.8/1.9 branches) 20:36:28 <flo> currently it prints a stack in my terminal 20:36:35 <flo> without even the method names :( 20:36:40 <Mook_as> haha 20:36:45 <flo> but at least the line number are right! 20:36:50 <Mook_as> so, in two months, it'll just call abort()? 20:37:43 * flo opens venkman to see how bad it is now 20:43:12 <flo> wow. It *almost* works! 20:43:16 <flo> I can't believe it 20:44:38 <-- igorko has quit (Quit: Instantbird 1.1) 20:48:07 --> devfil has joined #instantbird 20:50:14 <flo> crashed :-| 20:50:30 <flo> when it should have entered an XBL binding 20:50:39 <flo> it took longer than usual before crashing though! :) 20:55:45 --> mmkmou has joined #instantbird 20:56:43 <-- mmkmou has left #instantbird () 21:09:35 <-- Tobin has quit (Quit: Everything you do is to hurt me, leave me alone.) 21:09:54 --> Tobin has joined #instantbird 21:11:58 --> mmkmou has joined #instantbird 21:13:15 <-- jb has quit (Ping timeout) 21:17:44 <flo> contacts that are in several groups on the server are annoying :-/ 21:22:01 <-- mmkmou has left #instantbird () 21:36:22 <clokep_work> flo: Isn't that why we have tags!? :) 21:36:46 <flo> ... 21:37:01 <clokep_work> Oh I'm sure it's still annoying. 21:37:19 <clokep_work> Wasn't there some talk recently of rewriting venkman from the ground up with the new JS debugger 2 api or something? 21:37:37 <flo> recently = 2 years ago ? 21:37:46 <clokep_work> recently = 2 months ago? 21:37:55 <flo> I haven't seen that then 21:37:58 <clokep_work> It popped by on PMO, it was < 1 year ago. 21:38:03 <clokep_work> But it could have been like a year ago. :-/ 21:38:03 <flo> there are talks of replacing Firebug 21:39:39 <flo> clokep_work: the problem with buddies in several groups on the server is that we want to keep track of that, so just keeping a list of tags on the contact isn't enough. 21:40:00 <clokep_work> Oh. I see. 21:40:10 <clokep_work> Is there a way to search planet? 21:41:17 <flo> the current implementation has one account buddy instance per (account,buddy,server tag) combination. 21:41:33 <clokep_work> flo: http://weblogs.mozillazine.org/weirdal/archives/020974.html 21:41:52 <flo> of course, the XMPP account implementation has an object hashing based on the JID. So I can store there only one instance for all tags. 21:42:40 <flo> and when a presence change is received, the XMPP account sends a notification on that instance. But the imIBuddy implementation doesn't necessarily track status changes on that specific instance. And things are just broken :(. 21:43:01 <flo> I've just added an uggly hack in the imIBuddy implementation to workaround that 21:43:23 <clokep_work> My brain can't wrap itself around that right now. :( But it sounds bad. 21:45:09 <aleth> https://wiki.mozilla.org/DevTools/Features/Debugger 21:46:00 <aleth> looks a fair way off... 21:46:26 <clokep_work> Not sure if that's for Chrome code or not either. :-/ 21:46:55 <aleth> It's listed right at the bottom under "More milestones" :/ 22:20:06 <aleth> The moz9 IB is running fine :) Maybe flo can get some sleep now... 22:20:32 <flo> aleth: I wasn't worried for the linux version ;) 22:20:55 <aleth> Fingers crossed in that case ;) 22:21:26 <flo> Even said it worked on Windows too earlier this afternoon 22:22:14 --> hunsly has joined #instantbird 22:22:27 <flo> if anybody wants to resolve as fixed bugs 1161, 1179 and 1180 with the changeset urls and 1.2 as target milestone... I think that's all there is left to do for that update :) 22:22:37 <flo> hmm, file the bug for the new warnings also :) 22:26:08 <aleth> The speed improvement isn't as dramatic as I first thought, but it's probably there... 22:27:38 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1180 to FIXED. 22:27:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1180 nor, --, ---, nobody, RESO FIXED, Errors on opening add-on manager 22:28:49 <flo> clokep_work: this is what I currently have for bug 968 http://pastebin.instantbird.com/1103 22:28:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=968 maj, --, ---, nobody, NEW, Friends shown offline in buddylist when are in fact, online. 22:29:09 <aleth> I won't do the other two as I'm not sure quite which of the many checkins apply to each 22:31:35 <flo> aleth: there's only one check-in for 1179 22:33:33 <instantbot> New Instantbird (UI) bug 1182 filed by aletheia2@fastmail.fm. 22:33:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings 22:34:37 <flo> has a bug been filed on bug 1161 comment 23 (= display glitches on the Bubbles theme on Windows)? I'm not sure how far Mic is in his investigations 22:34:38 <aleth> flo: just the one you labelled as such then, OK 22:34:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1161 nor, --, 1.2, nobody, REOP, Update XUL from 7.0.1 to 9.0 22:35:43 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 22:35:56 <instantbot> aletheia2@fastmail.fm set the Resolution field on bug 1179 to FIXED. 22:35:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1179 blo, --, 1.2, nobody, RESO FIXED, System error about "mozutils.dll missing", preventing Instantbird from starting 22:37:00 <flo> aleth: are you interested in fixing these warnings? (or just the easy ones?) 22:37:37 <flo> the Components.classes['@mozilla.org/privatebrowsing;1'] warning has been there for years. 22:38:16 <flo> there was a fix for it in a mozilla bug, but it hasn't landed because the same patch was also fixing something else, and finally it was decided that that other thing wasn't actually wanted :-/ 22:38:58 <aleth> Maybe it needs reactivating somehow like that DNS Serv patch you are waiting for :/ 22:39:27 <aleth> flo: It would take me forever for the ones where I don't know the code in question, just to find my way around. Probably a learning experience but I won't manage this week 22:40:51 <flo> yeah, it's a great way to learn / discover new code areas, while knowing you will find at least something to change there :) 22:41:06 <flo> that's why I asked :) 22:41:09 <aleth> This is true :) 22:41:46 <aleth> But I won't manage it soon 22:41:47 <flo> those in accounts.js/account.xml/group.xml/tabbrowser.xml sound easy 22:42:12 <aleth> What did you think of the candidate culprit I suggested for the types[type] one? 22:42:15 <flo> some seem like Mozilla bugs 22:42:20 <aleth> I didn't know how to track it down 22:42:32 <flo> nothing. I don't know that code. 22:42:57 <flo> it's in Mossop's land (he reviews patches and answers questions quickly) 22:47:33 <aleth> What's the correct way to fix something like http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#266 - set a default value (null) in the constructor or check if the property exists yet? 22:51:20 <flo> this one looks like a real bug :-/ 22:51:35 <flo> http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#1355 set a value here 22:52:26 <flo> just add this.mCurrentConversation = this.mPanelContainer.childNodes[0]; 22:54:34 <flo> so that wasn't actually an easy one 22:54:48 <aleth> and then replace this.mPanelContainer.childNodes[0] with this.mCurrentConversation in line 1360ff ? 22:54:51 <flo> (+ the code of that constructor is absolutely horrible. Lot of code duplication. I wouldn't r+ that) 22:55:02 <aleth> Yes it's ugly 22:55:38 <flo> well, either completely cleanup that method, or don't touch anything except adding the missing line (= keep the crappy code style) 22:56:28 <-- hunsly has quit (Ping timeout) 22:56:42 <flo> if you want to clean it up, you need to create a currentConversation variable and replace all occurrences of "this.mPanelContainer.childNodes[0]" 22:57:23 <flo> and do the same with currentTab / this.mTabContainer.childNodes[0] 22:57:44 <aleth> isn't this.mCurrentConversation the currentConversation variable? 22:57:52 <flo> and childNodes[0] may be replaced with firstChild 22:58:03 <aleth> I was wondering about that 22:58:22 <flo> that's acceptable too. It repeats the this. thing lots of time, but that's probably cheap :) 22:58:24 <aleth> since firstChild is used in 1356 22:59:00 <aleth> Well, I guess that shows how useful those warnings can be ;) 23:00:14 <flo> so when I said those were the easy ones, I had in mind things like http://lxr.instantbird.org/instantbird/source/instantbird/content/group.xml#113 23:00:14 <flo> where the only missing thing is something like http://lxr.instantbird.org/instantbird/source/instantbird/content/group.xml#136 (initialized to false in that case) 23:00:52 <aleth> There is something about the design of XBLs that leads to somewhat windy code (parent.parent.ownerdoc.getelement type stuff) :/ 23:01:01 <flo> aleth: it also shows how useful it is to fix harmless warnings, so that we don't ignore the real problems in the middle of tones of pointless junk ;) 23:04:00 <instantbot> florian@instantbird.org granted review for attachment 1007 on bug 1159. 23:04:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1159 min, --, ---, aletheia2, ASSI, Follow-up to bug 1112: names not matched when alias is set 23:05:47 <-- ecaron has quit (Quit: Instantbird 1.1) 23:07:03 <instantbot> florian@instantbird.org granted review for attachment 1008 on bug 1174. 23:07:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1174 min, --, ---, aletheia2, ASSI, Own nickname shouldn't block completion of another 23:09:33 <instantbot> florian@instantbird.org granted review for attachment 1009 on bug 1177. 23:09:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1177 nor, --, ---, aletheia2, ASSI, Remove occasional warning on tab completion 23:13:06 <instantbot> New Instantbird (UI) bug 1183 filed by aletheia2@fastmail.fm. 23:13:07 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1012 on bug 1183. 23:13:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1183 nor, --, 1.2, nobody, NEW, Warning: this.mCurrentConversation undefined 23:15:13 <flo> it's just so much more readable this way :) 23:15:45 <aleth> Yes :) 23:17:03 <flo> I think something like this.mCurrentTab.linkedPanel = this.mCurrentConversation.id = "panel" + Date.now(); could work 23:17:28 <flo> not necessarily more readable 23:18:32 <aleth> flo: Re "where the only missing thing is something like http://lxr.instantbird.org/instantbird/source/instantbird/content/group.xml#136 (initialized to false in that case)": but if you add a default value via a field you make it accessible from the outside. Is that desired? 23:19:38 <flo> it's already accessible from the outside 23:19:48 <aleth> i.e. is it nice to have a showOffline property if you expose _showOffline ;) 23:20:09 <flo> the point is that the setter does something 23:20:38 <aleth> I thought if not explicitly added as a field everything in an XBL is private? 23:20:55 <aleth> (unless you trick around with the instance like add-ons must) 23:21:23 <flo> no, it's just a JS object, like on any other DOM node 23:22:22 <flo> what's not really visible from the outside is the anonymous DOM nodes. 23:22:58 <instantbot> florian@instantbird.org granted review for attachment 1012 on bug 1183. 23:22:59 <aleth> So there is no similar mechanism for the JS part. Good to know 23:23:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1183 nor, --, 1.2, nobody, NEW, Warning: this.mCurrentConversation undefined 23:23:22 <aleth> Well, it's hard to have private anything in JS I suppose 23:25:21 <flo> it's possible, for example by wrapping some code inside a function. 23:25:52 <flo> (function() { /* some code */ })(); 23:26:23 <aleth> I see. 23:26:59 * flo is still pondering pushing that fix for bug 968 this evening or not. 23:27:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=968 maj, --, ---, nobody, NEW, Friends shown offline in buddylist when are in fact, online. 23:28:09 <aleth> Do you expect it to break something? 23:29:29 <aleth> Btw I responded to an Empathy message style designer who was looking for other clients that used more or less the adium format... 23:36:25 <flo> where? 23:37:05 <aleth> Responded where? on gnome-look.org via PM 23:39:14 <flo> was he lookings for other places where he could see his creations used, or for places where he could find stuff to reuse? 23:39:18 <flo> *looking 23:39:32 <aleth> the former I think 23:39:55 <aleth> Anyway, I thought raising awareness of IB among message style developers in a small way would be no bad thing 23:40:46 <flo> sure :) 23:42:35 <aleth> Though I'm happy with Bubbles for myself, I got the bugfixed minimal2 uploaded to AIO and it's amazing to see how relatively often message styles are downloaded... 23:43:18 <instantbot> New Instantbird (UI) bug 1184 filed by aletheia2@fastmail.fm. 23:43:19 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1013 on bug 1184. 23:43:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1184 nor, --, 1.2, nobody, NEW, Warning: _showOffline undefined in group.xml 23:43:56 <flo> there's a relatively large set of people who don't like having a software that looks like it does by default for everybody else 23:44:30 <flo> I think they are typically the target for features like Personas 23:45:04 <aleth> And all those who want their software to "blend in" with their heavily personalized desktop... 23:55:29 <flo> aleth: you don't have to file a bug per warning. (the 3 warnings in the account manager can probably be fixed together for example :)) 23:56:30 <aleth> OK, I was thinking a bug per file 23:57:07 <flo> even attaching patches to the tracking bug would be acceptable, as long as it's obvious which warning they are fixing :) 23:59:41 <instantbot> florian@instantbird.org granted review for attachment 1013 on bug 1184. 23:59:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1184 nor, --, 1.2, nobody, NEW, Warning: _showOffline undefined in group.xml