#instantbird log on 11 16 2011

All times are UTC.

00:16:55 <clokep> :) IRC-JS is working after flo's changes!
00:17:00 <clokep> Some errors still, but mostly working.
00:20:10 <aleth> almost there then :)
00:21:53 <EionRobb> & ?
00:22:28 <EionRobb> any more entities problems?
00:23:26 <clokep> EionRobb: Yes, there was one. :) But I fixed it.
00:23:32 <clokep> (I had missed the global flag on my regex!)
00:23:53 <EionRobb> show me! :)
00:24:27 <clokep> Uhh...I'm not using it right now. :( Trying to get it to work still...
00:24:38 <EionRobb> aww
00:24:40 <clokep> We changed the way protocols register so I need to update a bunch of my code.
00:27:12 <EionRobb> alright, lemme know when you're ready.  I want to see some &☃& ! :)
00:27:19 <clokep> Haha, OK. :)
00:37:04 <-- pvagner has quit (Connection reset by peer)
00:45:13 <-- devfil has quit (Client exited)
00:51:13 --> BlueMaxima has joined #instantbird
01:00:35 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
01:01:14 --> aleth has joined #instantbird
01:01:27 --> Tonnes has joined #instantbird
01:01:46 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
01:15:03 <-- myk has quit (Ping timeout)
01:41:43 <-- GeekShadow has quit (Client exited)
01:43:31 <-- Mook_as has quit (Quit: gone)
01:49:31 --> myk has joined #instantbird
01:50:52 <-- Tomek has quit (Quit: Instantbird 1.1)
02:10:49 <-- billysanca has quit (Quit: Instantbird 1.2a1pre)
02:19:59 <-- myk has quit (Ping timeout)
02:20:42 --> myk has joined #instantbird
02:28:15 <-- myk has quit (Ping timeout)
03:07:11 <-- micahg has quit (Ping timeout)
03:09:44 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
03:18:59 --> myk has joined #instantbird
03:30:21 --> micahg has joined #instantbird
03:41:20 <-- myk has quit (Quit: Instantbird 1.1)
03:49:55 <-- jb has quit (Ping timeout)
04:07:07 <-- Even has quit (Ping timeout)
04:07:16 <-- Even2 has quit (Ping timeout)
04:29:57 <-- BlueMaxima has quit (Connection reset by peer)
04:30:00 --> BlueMaxima has joined #instantbird
04:49:14 --> jb has joined #instantbird
05:03:12 <-- EionRobb has quit (Quit: Leaving.)
05:07:11 --> Even has joined #instantbird
05:07:12 * ChanServ sets mode +o Even 
05:07:17 --> Even2 has joined #instantbird
05:08:15 <-- jb has quit (Ping timeout)
05:11:43 --> jb has joined #instantbird
05:21:44 <-- jb has quit (Ping timeout)
05:33:06 --> jb has joined #instantbird
06:04:00 <-- jb has quit (Ping timeout)
06:06:49 --> jb has joined #instantbird
06:43:47 <-- jb has quit (Ping timeout)
06:44:13 --> jb has joined #instantbird
07:09:45 <-- jb has quit (Connection reset by peer)
07:09:48 --> jb has joined #instantbird
07:12:51 --> debor_ has joined #instantbird
07:13:06 <-- debor has quit (Ping timeout)
07:13:17 * debor_ is now known as debor
07:16:05 --> debor_ has joined #instantbird
07:17:10 <-- debor has quit (Ping timeout)
07:17:15 * debor_ is now known as debor
07:22:01 <-- jb has quit (Ping timeout)
07:24:23 --> jb has joined #instantbird
07:26:49 <-- jb has quit (Ping timeout)
07:29:18 --> jb has joined #instantbird
07:36:16 <-- jb has quit (Ping timeout)
07:42:14 --> jb has joined #instantbird
07:54:03 <-- jb has quit (Ping timeout)
07:56:35 --> jb has joined #instantbird
08:53:47 --> Mic has joined #instantbird
08:53:47 * ChanServ sets mode +h Mic 
08:55:58 <Mic> Good morning
08:59:54 <-- jb has quit (Ping timeout)
09:07:11 --> jb has joined #instantbird
09:12:59 <-- gerard-majax has quit (Ping timeout)
09:35:57 <-- jb has quit (Ping timeout)
09:44:56 --> hunsly has joined #instantbird
09:55:42 --> gerard-majax has joined #instantbird
10:17:47 --> Guido has joined #instantbird
10:18:36 <Guido> hello
10:18:36 <Guido> i nthink i wil change from windows to linux, but is ther a possibility to move the history from instantbird?
10:18:43 --> GeekShadow has joined #instantbird
10:20:25 --> pvagner has joined #instantbird
10:20:44 <Mic> Guido: everything necessary is in the profile folder. Do you know how to find it?
10:21:06 <-- pvagner has quit (Quit: Instantbird 1.2a1pre)
10:21:09 <Guido> okee, so just coppy it and ready
10:21:50 <Mic> Yes, you might have to reinstall your add-ons though.
10:23:02 <Guido> okee. than i only have to find out in wich folder the programs are usualy by linux
10:23:55 <Mic> http://www.instantbird.com/faq.html#profilefolder
10:25:19 <Guido> oh, thanks :-)
10:28:45 <Mic> You're welcome
10:29:15 --> aleth has joined #instantbird
10:30:33 <Guido> is it possible to "instal" instantbird, so that i can replace the standard chat program form linux? (linux 10.04)
10:33:13 <Mic> I think there's something on the web. Try searching for ubuntu (I guess you're using Ubuntu when you say "10.04") and Instantbird.
10:34:01 <Guido> yes, i'm using ubunt
10:34:19 <aleth> What do you mean by "install"?
10:34:43 <Guido> i hope i can keep the version, cause 11.10 i don't like
10:34:43 <Guido> so that ubunto knows that ther is an alternativ for the chat program
10:35:18 <aleth> Oh, so you know how to run it, but you mean you would like to integrate it with the ubuntu special menus?
10:37:08 <Guido> yes, i think so - didn't try until now - and ther is already a messanger pingu or something like that and on the right on the top you can change the status, but i want ther instantbird
10:38:56 <aleth> I don't know if someone has packaged it up for ubuntu - Mic?
10:39:09 <aleth> But anyway, it doesn't really matter. All you have to do is download it from the website. You will get an archive file. Unpack it into a new directory of your choice and then type "./instantbird" from the command line in that directory.
10:39:28 <aleth> Then, this might help https://addons.instantbird.org/en-US/instantbird/addon/273
10:40:22 <Mic> I think chris coulson maintained a package for a while but doesn't any more 
10:40:39 <Mic> This still doesn't integrate Instantbird in Ubuntu's menus though.
10:40:53 <Guido> looks goed
10:41:08 <Mic> It only makes it available in the package manager.
10:41:35 <Mic> Take this with a grain of salt, I'm not a Linux person
10:41:36 <aleth> No, but it seems there is an add-on for that. Though I haven't tried it (am not on ubuntu)
10:43:18 <Guido> i'm just by acciedent by ubuntu
10:43:57 <aleth> Well, getting instantbird to run should be really easy. How well it integrates with unity will depend on the add-on.
10:45:20 <Guido> yes
11:00:21 <Mic> Bug 564
11:00:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=564 enh, --, ---, nobody, NEW, Integrate into messaging menu on Ubuntu
11:01:20 <Mic> If you have an account on Bugzilla, you can add yourself to the CC list to get emails when something happens there.
11:01:46 <Mic> There hasn't been much activity on it though.
11:07:10 <Mic> This was for you, Guido, by the way.
11:08:34 <Guido> i don't have an account on Bugzilla
11:08:56 <Guido> but i wil chek the link some time
11:13:51 --> clokep has joined #instantbird
11:13:51 * ChanServ sets mode +h clokep 
11:15:46 <aleth> Mic: maybe the author of the add-on would like to add that functionality to it if it isn't already there?
11:17:45 --> ironhead has joined #instantbird
11:18:57 <-- Even1 has quit (Quit: Instantbird 1.2a1pre)
11:19:05 --> Even1 has joined #instantbird
11:26:42 <-- hunsly has quit (Connection reset by peer)
11:28:18 <Mic> aleth: ask him ;)
11:30:09 <clokep> Bleh Windows nightly failed.
11:37:48 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
11:45:53 <aleth> Mic: isn't idechix another alias for Even?
11:46:23 <Mic> No
11:46:50 <aleth> Hmm. I thought it was. 
11:46:59 <Mic> I guess you got confused because they have the same first name
11:47:00 <aleth> ah, too many Quentins ;)
11:47:54 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
11:48:03 --> aleth has joined #instantbird
11:56:20 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
11:56:25 * Mic accidently short-circuited a lamp socket with the tip of a neon test light screwdriver. I guess that also answers the question if the socket was OK :D
11:56:39 --> aleth has joined #instantbird
11:57:49 <Mic> And the burnt look of the tip makes clear that the last thing you want use to short-circuit is yourself;)
11:58:18 <aleth> ouch :)
12:01:51 <aleth> lamp sockets can be tricky to get a good look at while they are still in place...
12:03:53 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
12:03:55 --> aleth has joined #instantbird
12:05:26 --> flo has joined #instantbird
12:05:26 * ChanServ sets mode +qo flo flo 
12:07:59 <flo> hello :)
12:11:39 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
12:11:40 --> aleth has joined #instantbird
12:13:03 <aleth> flo: re the change to the fake account handler yesterday - I am now seeing a new warning, "Warning: Expected ':' but found 'undefined'.  Declaration dropped. Source File: chrome://instantbird/content/preferences/preferences.xul Line: 0". Is that related?
12:13:24 <aleth> (I see it on opening Preferences/message styles)
12:13:27 <flo> I don't know
12:13:56 <flo> I don't see it
12:14:05 <aleth> Not a very helpful message unfortunately
12:15:12 <aleth> It probably has something to do with Minimal 2 then
12:16:48 <Mic> Can a message theme possibly generate an error or warning in chrome code? Only if we have a bug there.. I guess?
12:16:57 --> devfil has joined #instantbird
12:17:07 <aleth> I can trigger it by toggling the 'Show header' preference
12:17:42 <aleth> Anyway, I'll investigate where that is handled. 
12:18:10 <-- Guido has quit (Quit: Instantbird 1.1)
12:18:45 <Mic> aleth: I'm seeing it when changing to the papersheets or simple message style theme
12:19:31 <flo> so it's when changing to a different theme?
12:19:37 <aleth> That's helpful. So it doesn't depend on Minimal 2
12:19:53 <Mic> No, when changing to Papersheets or Simple  for me
12:20:10 <Mic> The warning appears two times for papersheets and three times for simple
12:20:12 <aleth> It is certainly fairly recent. Never noticed it before while testing message styles
12:20:44 <flo> I see it twice when changing to papersheets, and 3 times when changing to Simple
12:20:46 <flo> hmm
12:21:11 * flo should have read what had just been said before typing the exact same thing
12:22:01 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
12:22:02 --> aleth has joined #instantbird
12:23:40 <Mic> The first two messages are grouped in Papersheets, maybe this is related (two instead of three sections -> two instead of three problems)?
12:25:18 <flo> maybe
12:25:34 <aleth> But the warnings are new. I would have noticed when I last edited those styles.
12:25:47 <flo> My guess would rather be 3 broken rules inside http://lxr.instantbird.org/instantbird/source/instantbird/themes/messages/simple/main.css and 2 in http://lxr.instantbird.org/instantbird/source/instantbird/themes/messages/papersheets/main.css
12:25:58 <flo> but until we know the real cause, any hypothesis is possible :)
12:26:16 <aleth> I don't have a hypothesis, it's quite possible some rules are broken ;)
12:26:39 <flo> to debug this, I would try to comment out the whole file to check that the problem was actually there
12:26:47 <flo> then, uncomment some parts
12:26:51 <flo> until I'm sure of which rule this is
12:27:10 <flo> of course, having a file name/line number information would dramatically help here
12:27:12 <flo> again...
12:27:42 <Mic> http://lxr.instantbird.org/instantbird/source/instantbird/themes/messages/papersheets/main.css#174
12:27:48 <Mic> Isn't it "::after"?
12:28:17 <flo> I don't think so
12:28:55 <flo> but that would be a possible explanation, as there's also a :before in the same file
12:28:57 <Mic> It's not a pseudo-class, it should have two :
12:29:19 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
12:29:21 --> aleth has joined #instantbird
12:29:25 <Mic> Both seems to work: https://developer.mozilla.org/en/CSS/:after
12:29:36 <flo> but there are 3 :before and 2 :after in simple/main.css
12:29:46 <Mic> "The ::after notation was introduced in CSS 3 in order to establish a discrimination between pseudo-classes and pseudo-elements. Browsers also accept the notation :after introduced in CSS 2."
12:30:22 <flo> I read that already
12:30:36 <aleth> But if there was an error in the message style, it should also show up in a conversation, right? Which it doesn't seem to.
12:31:04 <flo> do you still expect consistent error reporting? ;)
12:31:36 <aleth> somewhat ;) I have given up on line numbers though
12:34:31 <flo> http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSScanner.cpp#623 "// 0 is a magical line number meaning that we don't know (i.e., script)"
12:35:11 <flo> so, is it possible these message themes contain scripts inserting crappy |.style.propertyName = rule| rules?
12:35:19 <flo> that's surprising for simple :-S
12:36:32 --> Wolfeh has joined #instantbird
12:36:34 <aleth> That error message can apparently also be produced by a style="" tag
12:39:06 <flo> hmm, yeah
12:39:37 <aleth> Maybe %senderColor% is not set in Preferences preview
12:39:40 <flo> style="%senderColor%"
12:39:41 <aleth> ?
12:39:50 <flo> that's possible
12:40:59 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
12:41:02 --> aleth has joined #instantbird
12:42:08 <flo> it seems the color property is missing in http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#326
12:42:52 <flo> so clokep should also have this warning on private messages on JS-IRC, when using these themes.
12:44:07 --> clokep_work has joined #instantbird
12:44:07 * ChanServ sets mode +h clokep_work 
12:46:54 <flo> aleth: the fix is just http://pastebin.instantbird.com/1074
12:48:08 <aleth> looks straightforward :) So just another missing default value.
12:48:59 <clokep_work> flo: I probably have them, but it's not quite usable again yet. :P My commands aren't working.
12:49:22 <flo> ^^
12:51:15 <clokep_work> flo: Seems good.
12:51:24 * clokep_work always gets confused whether things are in chat or purplexpcom now. :(
12:51:42 <flo> clokep_work: my awesomebar keeps sending me in purplexpcom/ :(
12:51:55 <aleth> I'll still clean up minimal2 a bit and then send it to Even.
12:52:16 --> Asch has joined #instantbird
12:52:22 <aleth> It's quite a popular message style and there aren't that many of those that are half decent.
12:52:24 <clokep_work> flo: Yesterday I deleted my entire Firefox history of lxr.instantbird :(
12:52:54 <clokep_work> (Which took about 3 minutes to complete I might add. :P)
12:53:02 <Asch> Hello InstandBird people.
12:53:12 <flo> clokep_work: telling Firefox to forget a website is super slow :(
12:53:15 <aleth> clokep_work: Losing the whole places.sql is faster
12:53:23 <aleth> (unfortunately also happens)
12:53:38 <clokep_work> aleth: But I didn't want to lose my whole history! :P
12:53:47 <aleth> ;)
12:53:56 <clokep_work> Would anyone be willing to write up weekly meeting stuff from the last two weeks? It can be one entry.
13:03:29 <flo> I don't know if I should post my slides as is ASAP, or take some time to write down a summary of what I said
13:03:35 <flo> (like I did for the FOSDEM slide)
13:04:03 <flo> a third option is to write a blog post expressing the same message in a correct blog post format, and giving the link to the slides at the end of the post
13:07:38 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
13:07:40 --> aleth has joined #instantbird
13:11:36 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
13:11:37 --> aleth has joined #instantbird
13:13:43 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
13:13:45 --> aleth has joined #instantbird
13:22:12 <-- Asch has quit (Quit: http://www.mibbit.com ajax IRC Client)
13:23:27 --> jb has joined #instantbird
13:26:25 <-- BlueMaxima has quit (Connection reset by peer)
13:31:26 <-- wesj has quit (Ping timeout)
13:31:50 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
13:31:52 --> aleth has joined #instantbird
13:33:23 <clokep_work> Either way could be nice, something saying you were there is good of course. :-D
13:39:03 --> mmkmou has joined #instantbird
13:41:13 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
13:41:14 --> aleth has joined #instantbird
13:46:18 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
13:46:20 --> aleth has joined #instantbird
13:54:02 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
13:54:04 --> aleth has joined #instantbird
14:05:46 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
14:05:49 --> aleth has joined #instantbird
14:08:27 <-- Mic has left #instantbird ()
14:09:19 <flo> new windows nightly ready for testing :)
14:12:23 <clokep_work> So people can test putting their computers to sleep and waking them again? :p
14:12:54 <flo> if that's the way they have fun with their computers, they should totally feel free to do so :P
14:16:11 <-- jb has quit (Ping timeout)
14:20:22 --> Asch has joined #instantbird
14:31:42 --> wesj has joined #instantbird
14:35:56 <-- GeekShadow has quit (Ping timeout)
14:58:31 <clokep_work> So what's "next"? :P Landing more patches? Updating to Moz 8? Or is there more reoganization happening?
14:59:17 <flo> I'm hesitating between finishing bug 759 (the xpcom interface renames + purpleIAccount inheriting from prplIAccount with only the purple proxy thing added)
14:59:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, florian, ASSI, Reorganize purplexpcom
14:59:22 <flo> or integrating js xmpp
14:59:46 <flo> I'm currently looking at xmpp to attempt to understand how much work there's ahead in that direction
15:00:11 <flo> I'm afraid Varuna won't address the review comments I wrote back in august
15:00:26 <clokep_work> (You might also need to start integrating that to figure out what's left to do for bug 759?)
15:00:34 <clokep_work> Yes, I don't think so either. :-/
15:07:31 * flo dislikes files named "utils.<extension>"
15:07:46 <flo> they usually aren't all that useful, and tend to contain lots of duplicated code
15:08:09 * clokep_work goes to rename his utils.jsm in JS-IRC. ;)
15:08:18 <clokep_work> Isn't the point of utils to avoid duplicated code? :(
15:09:40 <flo> rarely
15:10:29 <flo> it's usually "let's stuff everything I'll need several times in a half global (= I can include everywhere) / half locale (= I fully control it) location, instead of figuring out where that code should actually live"
15:11:18 <flo> if you wanted to use an MD5 function somewhere in your code, would you think of looking for it in chat/protocols/xmpp/utils.jsm ? ;)
15:12:48 <flo> (by the way, I made that mistake in the past, and haven't managed yet to fully get rid of http://lxr.instantbird.org/instantbird/source/instantbird/content/utilities.js)
15:17:26 <clokep_work> Yeah, I guess that makes sense. :)
15:17:31 <clokep_work> At least have a "securityUtils" file. ;)
15:19:27 <flo> MD5 is just a hash, it's not necessarily for security
15:19:53 <flo> but yeah, that could go into a cryptoUtils.jsm file somewhere
15:19:57 <flo> shared by all prpls
15:21:20 <flo> clokep_work: I'm trying to merge back the changes made to our jsm files
15:22:10 <flo> http://pastebin.instantbird.com/1075 I don't remember very well what these changes are for / if they work / if we have changed something since Varuna forked that file
15:25:07 <flo> is the method at line 25 something I need to add to our code?
15:25:29 <flo> what's the if (aStatus == 0) this.onConnectionReset(); at line 69 for?
15:26:15 <flo> the thing at line 106 seems like a more complicated version of what we added at line 74, so I guess I don't need that part
15:29:55 --> Tomek has joined #instantbird
15:33:07 --> ecaron has joined #instantbird
15:33:42 <flo> ecaron: Hello :) https://twitter.com/#!/Tardisandyou/status/136624971203088384 seems like something you may want to RT
15:34:03 <ecaron> flo: Will do. Can we talk about the PNGs on the site for a bit?
15:34:50 <flo> if you (or someone else) has/have something interesting to say about them, why not? :)
15:36:05 <ecaron> aleth pointed out that a bunch of them have a color space profile embedded, which is what makes the page look different in opera vs firefox
15:36:40 <flo> should they all have one, or should none of them have one?
15:36:47 <ecaron> I can fix them all by checking out everything from hg, running them through optipng (or pngcrush), and submitting a patch, but I was wondering if you might think of a more automated process that'd help this from happening again
15:36:50 <ecaron> They should not have one.
15:37:54 <flo> the only way to automate this would be to put a hook on hg (on the server side) for hg to reject changes that would insert color profiles
15:38:06 <flo> I'm not sure that's worth the effort
15:38:25 <flo> (if someone wants to play with hg hooks right now, fixing the en-US repository sounds like a more pressing issue ;))
15:39:48 <ecaron> Good point.
15:40:06 <ecaron> Alright, I'll just go ahead with a patch since the images don't change that much anyway.
15:42:08 <clokep_work> flo: I already merged those changes in.
15:42:10 <clokep_work> They're in a bug.
15:42:34 <clokep_work> flo: Line 25 I don't know about.
15:42:44 <flo> clokep_work: I looked at bug 673, but it didn't help me
15:42:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=673 nor, --, 0.3a2, clokep, RESO FIXED, Implement a general Sockets object for JavaScript protocols
15:43:23 <clokep_work> flo: Wrong bug.
15:43:36 <clokep_work> bug 761
15:43:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=761 nor, --, ---, clokep, ASSI, JS-Socket fails to properly handle SSL errors
15:44:12 <-- devfil has quit (Client exited)
15:45:35 <clokep_work> flo: https://bugzilla.instantbird.org/attachment.cgi?id=948&action=diff should have all those changes integrated.
15:45:43 <clokep_work> I have a meeting now though, I'll be back soon.
15:46:01 <flo> I was looking at that patch
15:46:09 <clokep_work> (Also I'd like the startTLS method to be called internally, not sure if that's done in that patch or not.)
15:46:28 <flo> it looks good
15:46:34 <flo> I wonder why it hasn't been reviewed/landed
15:47:05 <flo> "it looks good" <- although I don't know exactly what it does :-D. But the changes looks like they have been thought through :-D
15:48:37 <clokep_work> flo: I never had a good way to test it, so I didn't want to ask you to review it without some "STR" for testing. :-/
15:48:55 <flo> ok, so it may not work
15:49:46 <clokep_work> I had done some testing with varuna's XMPP code and it worked OK.
15:50:05 <clokep_work> (They way you can test if it "works", I guess...is run his code with our standard socket code now, see that it breaks, add my patch ot it and run it again)
15:51:04 <flo> when should it break?
15:51:13 <flo> (when calling into startSSL I guess :-D)
16:06:15 <-- Wolfeh has quit (Quit: Instantbird 1.1)
16:23:16 --> devfil has joined #instantbird
16:26:07 --> mistraven has joined #instantbird
16:26:09 <-- mistraven has left #instantbird ()
16:39:45 <-- Tobin has quit (Ping timeout)
16:43:25 <instantbot> New purplexpcom - General bug 1171 filed by florian@instantbird.org.
16:43:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1171 nor, --, ---, nobody, NEW, Replace the current binary XMPP plugin with a JS implementation
16:43:49 --> mistraven has joined #instantbird
16:44:09 <-- flo has quit (Quit: Instantbird 1.2a1pre)
16:44:30 <-- mistraven has left #instantbird ()
16:45:36 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a82483046e4d - Florian Quèze - Add a default value for the color attribute in GenericMessagePrototype (fixes a CSS warning visible in Simple and Papersheets message style previews), r=clokep.
16:52:19 <-- wesj has quit (Quit: Instantbird 1.2a1pre)
16:52:22 --> wesj has joined #instantbird
17:00:57 --> igorko has joined #instantbird
17:21:20 <clokep_work> flo: Yes, when trying to make the SSL connection to Gtalk, because the cert is invalid on that domain.
17:21:37 <igorko> hi
17:22:02 <igorko> please add irc rank sorting so i can get nightly build ;)
17:25:01 <clokep_work> igorko: Someone needs to implement it then, it shouldn't be too hard.
17:25:40 <igorko> as i saw sorter core is already done
17:25:57 <igorko> so i hope so too
17:25:58 <-- ecaron has quit (Quit: Instantbird 1.1)
17:26:11 <clokep_work> What?
17:26:24 <igorko> there was commit few days ago
17:26:33 <igorko> for sorting algorhitm
17:26:42 <igorko> algoritm*
17:27:22 <clokep_work> For the contact list.
17:27:47 <igorko> :(
17:29:03 <clokep_work> It shouldn't be difficult, but someone has to do it.
17:29:15 <clokep_work> If you're interested we can walk you through parts of it.
17:31:20 <igorko> have no time...
17:31:39 <clokep_work> Sorry.
17:31:50 <igorko> me too
17:31:58 <clokep_work> I'm sure it'll be done eventually.
17:32:10 <clokep_work> Maybe aleth would be interested, he's been working on the participants list. ;)
17:33:56 --> Mook_as has joined #instantbird
17:38:59 <-- Even1 has quit (Quit: Instantbird 1.2a1pre)
17:39:12 --> Even1 has joined #instantbird
17:40:24 <-- chrisccoulson has quit (Quit: Ex-Chat)
17:42:33 --> chrisccoulson has joined #instantbird
17:55:14 <-- gerard-majax has quit (Ping timeout)
18:06:41 --> Guido has joined #instantbird
18:17:05 <-- Asch has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:37:46 <-- Tomek has quit (Quit: Instantbird 1.1)
18:40:14 --> gerard-majax has joined #instantbird
18:43:43 <-- devfil has quit (Client exited)
19:17:40 <-- Guido has quit (Quit: Instantbird 1.1)
19:26:50 <-- Tonnes has quit (Ping timeout)
19:30:28 --> Tonnes has joined #instantbird
19:31:37 <-- Even2 has quit (Quit: Instantbird 1.2a1pre)
19:34:39 --> BlueMaxima has joined #instantbird
19:37:26 <-- chrisccoulson has quit (Ping timeout)
19:38:14 --> chrisccoulson has joined #instantbird
19:53:19 --> igorko1 has joined #instantbird
19:53:34 <-- igorko has quit (Ping timeout)
19:54:13 <-- ironhead has quit (Quit: leaving)
19:57:46 --> flo has joined #instantbird
19:57:46 * ChanServ sets mode +qo flo flo 
19:59:35 --> EionRobb has joined #instantbird
20:13:47 <clokep_work> flo: So I tried to recompile SIPE with the new directory structure and I'm getting errors that a bunch of methods were already defined in the simple directory.  They both have the same name but different definitions (AFAIK).
20:14:13 <clokep_work> I thought each protocol was compiled without reference to other protocols? Is this assumption wrong?
20:14:20 <clokep_work> (Or did my makefile get messed up somehow maybe?)
20:15:26 <flo> hmm, that's surprising
20:15:56 <flo> all protocol plugins should export only one symbol
20:16:33 <flo> is it failing when linking purple.dll? or before?
20:16:43 <clokep_work> I think before.
20:16:51 <clokep_work> I shold have pastebined the results. :-/ Sorry.
20:24:35 <-- Tonnes has quit (Quit: ChatZilla 0.9.87 [Firefox 7.0.1/20110928134238])
20:28:07 <-- Even has quit (Input/output error)
20:28:51 <-- gerard-majax has quit (Ping timeout)
20:37:56 <-- BlueMaxima has quit (Quit: Instantbird 1.1)
20:43:43 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
20:43:46 --> aleth has joined #instantbird
20:46:36 --> devfil has joined #instantbird
20:48:31 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
20:48:33 --> aleth has joined #instantbird
21:00:21 * flo removes unhelpful comments from the XMPP code
21:00:50 <flo> "/* Coneversation for chats with buddies */" above |function Conversation(aAccount, aBuddy)| isn't helpful at all from my point of view
21:01:21 <flo> as I'm almost sure it's also used for IM conversations (= not chat) and for conversations with unknown buddies (= not with buddies)
21:03:44 <flo> I've actually removed all comments from xmpp.js :-S (except the license header)
21:04:04 <EionRobb> put all the code on one line while you're at it
21:04:12 <clokep_work> flo: Were none helpful? :(
21:04:18 <flo> clokep_work: exactly
21:04:27 <clokep_work> Were they all just description what the classes/functions describe already instead of implementation details?
21:04:31 <aleth> Even worse if they are misleading like you say
21:04:55 <flo>  /* Account Buddy */\n function AccountBuddy(...) { ... } isn't helpful from my point of view
21:06:39 <-- mmkmou has quit (Ping timeout)
21:13:42 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:13:45 --> aleth has joined #instantbird
21:16:43 <clokep_work> I agree. :)
21:17:32 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:17:34 --> aleth has joined #instantbird
21:17:51 <flo>  /* GTalk protocol */ function GTalkProtocol() {
21:17:52 <flo> :(
21:18:57 <aleth> oh dear...
21:20:47 <Mook_as> Would /* The forty-second digit of Pi is 6 */ function GTalkProtocol() { be more useful? :p
21:22:23 <flo> Mook_as: I think I would prefer some ascii art
21:22:33 <clokep_work> Mook_as: Is that the 42nd digit or the 42nd decimal digit?
21:23:05 <clokep_work> (Also, I've been told it's 0, not 6.)
21:23:46 <flo>   /* This funciton should be overridden */
21:23:48 <Mook_as> dunno, it's just whatever http://www.wolframalpha.com/input/?i=forty-second+digit+of+pi spit back
21:23:59 <flo> why don't code editors have built in spellcheckers? :(
21:24:12 <aleth> at least  /* 42 = 6 * 7 */ is full of meaning
21:24:30 <Mook_as> flo: you tell me; I checked in something with <statisbarpanel/> :(
21:24:31 <flo> I don't even know why that function (err, sorry, I meant funciton) exists
21:25:19 <clokep_work> Mook_as: Ah you're right. :)
21:25:50 <clokep_work> flo: Which function is it?
21:26:02 <aleth> flo: what are you reviewing?
21:26:11 <clokep_work> varuna's XMPP code
21:26:28 <Mook_as> well, at least it's not alone. http://lxr.instantbird.org/instantbird/source/purple/libraries/glib/gslice.c#212
21:26:28 <flo>   getConnectionParameters: function() {
21:26:42 <flo> clokep_work: I really don't get the point of that function
21:26:58 <Mook_as> ( http://mxr.mozilla.org/mozilla-central/search?string=funciton is a little bigger)
21:27:42 <flo> how having each XMPP derived protocol implementing a getConnectionParameters function that returns an object is more useful than just having the prototype using sensible defaults, and the derived protocols overriding only what they need
21:28:43 * clokep_work doesn't know.
21:28:51 <clokep_work> We're bad reviewers? :-/
21:29:21 <flo> Mook_as: have you noticed that in debug_module.c it's not even in a comment?
21:29:41 <Mook_as> flo: yep! but at least it's consistent! :D
21:29:56 <flo> editors at least have completion ;)
21:30:33 <flo> clokep_work: I think it's hard for people to write simple code.
21:30:51 <flo> the first time I review a patch, it's often way more complicated than it needs to be
21:32:40 <clokep_work> flo: You usually simplify my code a lot. :) Probably because people write code before they know what they're writing.
21:33:14 <aleth> Or they write code before finishing learning the language ;)
21:34:25 <flo> maybe just because having simple ideas is harder than creating a complicated thing, especially when people only have a blurry understanding of the problem they are trying to address
21:35:03 --> mistraven has joined #instantbird
21:35:05 <aleth> simple always requires a deeper understanding
21:36:08 <-- mistraven has left #instantbird ()
21:38:04 <flo> helper functions that don't help at all are as common as pointless comments
21:38:38 --> ecaron has joined #instantbird
21:38:58 <flo> example: http://pastebin.instantbird.com/1076
21:39:21 <flo> (I've verified that _createTag isn't called from anywhere else)
21:39:35 <clokep_work> :(
21:39:48 <clokep_work> I'm curious to run a diff against your code after you're done w/ it. ;)
21:40:06 <clokep_work> I think there's an excessive use of self = this in that code too btw.
21:40:34 <flo> I've attached a patch with as little modifications as I could (just made what was needed to compile/start), so that we can then generate interdiffs ;)
21:40:47 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:40:50 --> aleth has joined #instantbird
21:40:56 <clokep_work> Do interdiffs work now!?
21:41:12 <flo> on bugzilla I don't think
21:41:19 <flo> but in my terminal, they have always worked :-P
21:41:53 <flo> anyway, I'm currently resisting the temptation of cleaning up everything that's not really as I would write it
21:41:57 <flo> I would like to get to a working version before that
21:42:09 <flo> so that I can then test that my changes don't break it too badly
21:42:52 <aleth> why would you do "let self = this"? /puzzled
21:43:29 <clokep_work> aleth: So you can then use "self" inside of an encapsulated function.
21:43:33 <clokep_work> But I prefer using .bind()
21:43:40 <clokep_work> flo: interdiff doesn't seem tow ork sitll.
21:43:47 <clokep_work> Time to go home. :)
21:43:52 <aleth> Yes, I thought that's what bind was for too
21:43:58 <-- clokep_work has quit (Quit: 1+j4)
21:44:15 <Mook_as> self is from before bind existed, pretty much
21:44:32 <-- flo has quit (Ping timeout)
21:46:48 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:46:50 --> aleth has joined #instantbird
21:48:00 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:48:02 --> aleth has joined #instantbird
21:48:18 --> flo has joined #instantbird
21:48:18 * ChanServ sets mode +qo flo flo 
21:48:45 <flo> clokep_work: I agree that "there's an excessive use of self = this in that code". What's even worse is that I've no idea of why these setTimeout( ... , 0) are even needed :(
21:50:21 <flo> while disconnected, I said:
21:50:22 <flo> 22:43:35 - flo: aleth: because you learnt JS at a time when Function.bind() didn't exist
21:50:22 <flo> 22:44:04 - flo: aleth: the goal is to make "this" have a fixed values in callback functions
21:50:23 <flo> 22:46:43 - flo: hmm, helper functions that are never called may be even more useful than helper functions containing only one line and called only once ;)
21:50:36 <flo> but I see clokep and Mook basically said the same thing for self :)
21:57:55 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
21:57:57 --> aleth has joined #instantbird
21:58:26 <-- igorko1 has quit (Quit: Instantbird 1.1)
22:00:27 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
22:00:29 --> aleth has joined #instantbird
22:01:58 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
22:02:00 --> aleth has joined #instantbird
22:02:09 --> Tobin has joined #instantbird
22:04:04 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
22:04:06 --> aleth has joined #instantbird
22:05:24 <flo>   /* Set the user statue on the server */
22:05:25 <flo> Nice typo :)
22:06:25 <flo>     /* TODO: Chat statues */
22:06:26 <flo> :)
22:07:59 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
22:08:01 --> aleth has joined #instantbird
22:09:57 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
22:09:59 --> aleth has joined #instantbird
22:15:18 --> Tonnes has joined #instantbird
22:23:42 --> hunsly has joined #instantbird
22:40:04 <flo>         charset = "utf-9",
22:40:05 <flo> hmm
22:43:44 <EionRobb> wow
22:44:26 <EionRobb> http://en.wikipedia.org/wiki/UTF-9_and_UTF-18 lol
22:49:01 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
22:49:02 --> aleth has joined #instantbird
23:08:07 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
23:08:09 --> aleth has joined #instantbird
23:20:24 --> jb has joined #instantbird
23:21:04 --> Tomek has joined #instantbird
23:47:12 <flo> Good night
23:47:14 <-- flo has quit (Quit: Instantbird 1.2a1pre)
23:59:51 --> clokep has joined #instantbird
23:59:51 * ChanServ sets mode +h clokep