#instantbird log on 10 14 2011

All times are UTC.

00:07:05 <clokep> v17al: It's generally easier for me if you talk to me in the chat, minimizes my tabs open. :)
00:07:36 <v17al> clokep: Just trying to avoid plugging the logs with my nonsense :)
00:07:52 <clokep> We have plenty of nonsense in it anyway! :)
00:07:57 <v17al> haha ok
00:09:51 <clokep> The sort comparator bug is a good one. :)Glad to see someone's working on it.
00:10:44 <Mook_as> I would expect there to be few items to sort? (it's a contact list, a few hundred is a lot)
00:11:10 <v17al> A few hundred is a load but I usually have about 50
00:11:12 <clokep> Yes, are you referring to the binary search?
00:11:43 * v17al v17al has too many unknowns on his facebook friends list
00:11:57 <Mook_as> right, I was just thinking that with that few, it _doesn't_ matter if you just throw everything in and sort once at the end
00:11:59 * v17al also needs to learn how to use irc properly
00:12:04 <clokep> I think Test Pilot would be useful to know how many buddies &amp; how many contacts people have. :)
00:12:21 <Mook_as> (assuming we don't actually reflow after each sort)
00:12:33 <v17al> &
00:12:45 <v17al> why did & turn out like that cloke?
00:12:52 <clokep> Mook_as: I think that's how it works, but the case they're discussing is when you're signed on and a new buddy signs in.
00:12:57 <clokep> v17al: Cause my code sucks. :P
00:13:10 <v17al> Ooh your using your new IRC code?
00:13:30 <Mook_as> clokep: okay. while insertion sort would be best, just tacking it at the end and sorting normally shouldn't be that bad either... :p
00:13:32 <clokep> Yes. It's a bug that people keep complaining about...I think it's an Instantbird bug though. ;)
00:13:52 <v17al> That's exciting :) (not the bug)
00:14:05 <clokep> Mook_as: I'll take your word. All i remember about sorting is "use the inbuilt routines, if you have to roll your own, use quick sort"
00:14:33 <Mook_as> my rule of thumb is "if it's less than 10k, whatever"
00:15:04 <Mook_as> but that might be because I used to that stuff in c... :p
00:15:21 <v17al> lol
00:19:07 <-- mmkmou has quit (Input/output error)
00:19:11 <-- v17al has quit (Quit: Instantbird 1.1a1pre)
00:19:14 <-- aleth has quit (Ping timeout)
00:19:29 --> v17al has joined #instantbird
00:24:31 <-- v17al has quit (Quit: Instantbird 1.1a1pre)
00:27:28 --> ironhead has joined #instantbird
00:32:06 --> v17al has joined #instantbird
00:32:53 <v17al> Anyone seen this error before? http://pastebin.instantbird.com/1017
00:33:43 <Mook_as> yep; that seems to happen when you close the error console, have an error, then open it again
00:34:09 <Mook_as> as far as I know it's harmless
00:34:26 <v17al> OK
00:37:05 <-- clokep has left #instantbird ()
00:37:08 --> clokep has joined #instantbird
00:37:08 * ChanServ sets mode +h clokep 
00:42:25 <instantbot> mattdentremont@gmail.com added attachment 891 to bug 772.
00:42:27 <instantbot> mattdentremont@gmail.com requested review from florian@instantbird .org for attachment 891 on bug 772.
00:42:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=772 enh, --, ---, nobody, NEW, Use a sortComparator function on groups to allow easy changing of the order of contacts
00:43:35 <-- Mook_as has quit (Quit: gone)
00:50:55 <clokep> v17al: Does it take two contact elements as defined in contact.xml or is it imIContact objects?
00:52:57 <v17al> Not entirely sure, from what I saw they magically come from this.contacts
00:53:28 <v17al> And I handled them as they were handled previously in the code
00:54:59 <v17al> Originates from: http://pastebin.instantbird.com/1018
00:58:28 <v17al> Man I wish jscript would have better debugging. I need a breakpoint!
01:00:25 <v17al> clokep: Actually now that I thought a bit more I'm pretty sure it's contacts.xml.. I remember using it as a reference (to check out its properties) while I was reading through the code.
01:00:51 <v17al> contact.xml*
01:01:16 <clokep> Hm. OK.
01:01:47 <v17al> Just took a look and it is contact.xml
01:02:34 <clokep> Cool. :) Thanks.
01:02:42 <instantbot> clokep@gmail.com denied review for attachment 891 on bug 772.
01:02:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=772 enh, --, ---, nobody, NEW, Use a sortComparator function on groups to allow easy changing of the order of contacts
01:03:25 <-- clokep has left #instantbird ()
01:03:29 --> clokep has joined #instantbird
01:03:29 * ChanServ sets mode +h clokep 
01:06:11 <clokep> PS Let us know if our comments don't make sense or whatever.
01:08:20 --> Prescience500 has joined #instantbird
01:08:29 <-- Prescience500 has quit (Client exited)
01:10:20 <v17al> They are great so far!
01:18:54 <instantbot> mattdentremont@gmail.com added attachment 892 to bug 772.
01:18:55 <instantbot> mattdentremont@gmail.com requested review from florian@instantbird .org for attachment 892 on bug 772.
01:18:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=772 enh, --, ---, nobody, NEW, Use a sortComparator function on groups to allow easy changing of the order of contacts
01:21:23 <clokep> Looks pretty good, but as I said, I didn't test it. :)
01:27:00 <v17al> Thanks :)
01:51:20 --> Mook has joined #instantbird
02:03:34 <-- Mook has quit (Ping timeout)
02:04:41 --> Mook has joined #instantbird
02:16:10 --> rikki has joined #instantbird
02:17:43 <-- Mook has quit (Ping timeout)
02:19:06 --> Mook has joined #instantbird
02:26:17 <-- ironhead has quit (Quit: leaving)
02:33:06 <-- Mook has quit (Ping timeout)
02:33:58 --> Mook has joined #instantbird
02:35:53 --> v17al1 has joined #instantbird
02:36:26 <-- v17al has quit (Ping timeout)
02:43:47 <-- clokep has left #instantbird ()
02:45:35 <-- skeledrew1 has quit (Quit: Instantbird 1.1a1pre)
02:46:09 --> skeledrew has joined #instantbird
02:46:20 <-- skeledrew has quit (Quit: Instantbird 1.1a1pre)
02:51:10 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603])
02:52:38 --> Prescience500 has joined #instantbird
02:52:38 <-- Prescience500 has quit (Connection reset by peer)
03:16:52 --> napoleon has joined #instantbird
03:16:58 * napoleon is now known as Nakp
03:17:05 <-- Nakp has quit (Quit: http://www.mibbit.com ajax IRC Client)
04:57:48 --> alfredkayser has joined #instantbird
05:04:58 <-- EionRobb has quit (Quit: Leaving.)
05:10:18 <-- alfredkayser has quit (Quit: Instantbird 1.1a1pre)
06:05:40 --> myk has joined #instantbird
06:05:50 <-- myk has quit (Quit: Instantbird 1.0)
06:43:54 --> Mic has joined #instantbird
06:43:54 * ChanServ sets mode +h Mic 
06:44:29 <Mic> Hi
06:45:45 <Mic> v17al1: you renamed the method too when you changed the parameter names in bug 772
06:45:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=772 enh, --, ---, nobody, NEW, Use a sortComparator function on groups to allow easy changing of the order of contacts
06:46:51 <Mic> Only the parameter names start with "a", the old name was fine for the method.
07:00:27 <-- Even has quit (Quit: Instantbird 1.1a1pre)
07:05:07 <instantbot> New Instantbird (UI) bug 1073 filed by benediktp@ymail.com.
07:05:09 <instantbot> benediktp@ymail.com added attachment 893 to bug 1073.
07:05:10 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 893 on bug 1073.
07:05:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1073 min, --, ---, benediktp, ASSI, Follow-up to bug 504: remove a now unused field from group.xml
07:18:50 <-- vicnet has quit (Ping timeout)
07:19:44 --> vicnet has joined #instantbird
07:35:10 <instantbot> benediktp@ymail.com added attachment 894 to bug 1031.
07:35:11 <instantbot> benediktp@ymail.com requested review from clokep@gmail.com for attachment 894 on bug 1031.
07:35:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1031 tri, --, ---, nobody, NEW, Remove the optional last parameter from addEventListener calls
07:37:04 --> gerard-majax has joined #instantbird
07:51:33 <instantbot> benediktp@ymail.com set the Resolution field on bug 501 to INVALID.
07:51:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=501 tri, --, ---, nobody, RESO INVALID, Graph view on hg.instantbird.org contains duplicated 'ago'
07:57:25 <Mic> flo: do you have data on the OS distribution of IB users?
08:13:52 <-- Mic has quit (Quit: Instantbird 1.1a1pre)
08:43:28 --> flo has joined #instantbird
08:43:29 * ChanServ sets mode +qo flo flo 
08:44:57 <-- flo has quit (Quit: Instantbird 1.1)
08:45:05 --> flo has joined #instantbird
08:45:05 * ChanServ sets mode +qo flo flo 
08:48:13 <flo> hello :)
08:48:26 * flo is using the Mac 1.1 rc2 in French
08:54:48 <flo> Mic: the update pings contain the user agent, so we could show the OS distribution, if someone bothered with doing that :)
08:56:30 --> Mad_Maks has joined #instantbird
08:57:37 --> Mic has joined #instantbird
08:57:37 * ChanServ sets mode +h Mic 
09:00:56 <flo> The insertion of contacts uses a binary search because there are not 50 or so contacts to insert, but thousands
09:01:31 <flo> (this happens in the case of someone with lots of facebook friends turning on the "Show offline contacts" option)
09:01:50 --> aleth has joined #instantbird
09:11:04 <instantbot> florian@instantbird.org granted review for attachment 893 on bug 1073.
09:11:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1073 min, --, ---, benediktp, ASSI, Follow-up to bug 504: remove a now unused field from group.xml
09:11:48 <Mic> flo: I haven't actually tested the patch for bug 1031, I forgot to post that in the comment :(
09:11:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1031 tri, --, ---, nobody, NEW, Remove the optional last parameter from addEventListener calls
09:12:44 <Mic> Oh, .. your not the right reviewer anyways :D
09:13:18 <flo> It's too bad we can't do it for addObserver calls too yet
09:16:59 <flo> Mic: http://lxr.instantbird.org/instantbird/search?string=addEventListener is this your lxr query?
09:17:22 <flo> if so, no love for the instantbird/themes/messages/ folder?
09:19:03 <Mic> I haven't fixed the message style themes, let me check how many that were
09:21:36 <Mic> Just five at it seems ..
09:22:49 <flo> My French sametime testers tested today the chatrooms and... it crashed :(
09:23:13 <flo> I think the related reports are http://crash-stats.instantbird.com/report/index/9d195f8d-ddd8-4cfd-a223-defa12111013 and http://crash-stats.instantbird.com/report/index/b7581e83-6e38-481a-97fb-9a5512111013
09:23:51 --> mmkmou has joined #instantbird
09:24:25 <-- mmkmou has quit (Connection reset by peer)
09:25:45 --> mmkmou has joined #instantbird
09:29:41 <Mic> I'll update the patch soon
09:29:59 <flo> no rush, we aren't taking that until 1.1 is released ;)
09:39:19 <Mic> The patches I attached recently weren't intended to be for 1.1 anyways.
09:39:28 <flo> :)
09:39:29 <Mic> The thing is that it done if I do it now ;)
09:39:39 <Mic> *it is
09:39:57 <Mic> What about the mintrayr code? Should I change it there too?
09:43:41 <flo> that's a single line, right?
09:44:06 <flo> and this file is already very different from the upstream mintrayr code
09:44:11 <flo> yes, go ahead :)
09:48:38 <flo> http://developer.pidgin.im/ticket/12637 Seems to be about the same crash :-S
09:50:02 <aleth> Just noticed the other three default message styles lack context message support as far as I can tell
09:50:33 <flo> if you want to fix that, that would be great. (just filing a bug is fine too)
09:51:27 <aleth> The question is, is it a bug? It's not obvious how one would implement them design-wise for some of the styles (e.g. Simple)
09:52:18 <flo> maybe like on Bubbles? (e.g just desaturate the usernames?)
09:54:08 <aleth> I suppose one could do the Minimal2 thing and change the text colour to dark gray too
09:54:09 <-- mmkmou has quit (Client exited)
09:54:46 <aleth> Desaturation is probably too subtle due to the lack of solid coloured background
09:55:08 <flo> if you have ideas of what to do, just go ahea ;)
09:55:11 <flo> *ahead
09:55:26 <aleth> Yes, if I can think of a good solution I will stick it in
09:56:24 <flo> even if you have solutions you aren't fully satisfied of, showing them will save time for the next person thinking about it (to not experiment again the exact same thing leading to the same disappointing result)
09:56:28 --> mmkmou has joined #instantbird
09:58:08 <instantbot> New Instantbird (UI) bug 1074 filed by aletheia2@fastmail.fm.
09:58:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1074 nor, --, ---, nobody, NEW, Default message styles lack context message support
10:05:55 <Mic> flo, do you want to review the patch for 1031 or should I request it from clokep instead?
10:06:32 <flo> I looked at the previous iteration, it seemed good to me.
10:07:23 <flo> Anyway, before pushing it, I'll check that my debug build still works with it, and grep the source code to see if I can find more occurences ;)
10:07:45 <instantbot> benediktp@ymail.com added attachment 895 to bug 1031.
10:07:46 <instantbot> benediktp@ymail.com cancelled review?(clokep@gmail.com) for attachment 894 on bug 1031.
10:07:47 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 895 on bug 1031.
10:07:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1031 tri, --, ---, nobody, NEW, Remove the optional last parameter from addEventListener calls
10:08:27 <Mic> Yes, that would be great. Checking that without compiling would be tedious
10:08:56 <instantbot> New purplexpcom - General bug 1075 filed by florian@instantbird.org.
10:08:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1075 cri, --, ---, nobody, NEW, Sametime crash [@ purple_conv_chat_add_users ]
10:11:09 --> clokep has joined #instantbird
10:11:09 * ChanServ sets mode +h clokep 
10:14:46 <flo> my review queue is getting long ;)
10:15:54 <flo> is there anything I should change before starting the compilation of the 4th set release candidates?
10:16:20 <flo> Mac builds from the 3rd set: http://ftp.instantbird.com/instantbird/releases/1.1-candidates/2011-10-14-00-instantbird/
10:16:41 <flo> Windows and Linux: http://ftp.instantbird.com/instantbird/releases/1.1-candidates/2011-10-13-23-instantbird/
10:17:06 <instantbot> clokep@gmail.com denied review for attachment 892 on bug 772.
10:17:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=772 enh, --, ---, nobody, NEW, Use a sortComparator function on groups to allow easy changing of the order of contacts
10:22:11 <clokep> What's wrong w/ the third set? L10N stuff?
10:22:28 <flo> no updates from 1.0
10:22:30 <flo> :(
10:23:41 <clokep> Oh. :(
10:25:22 <clokep> That Sametime crash is unfortunate. :-/
10:25:26 <flo> yeah...
10:25:40 <flo> but it's too late to do something about it (and Pidgin crashes too)
10:25:52 <flo> so... yeah, that's just bad luck
10:26:05 <flo> what's the state of release notes / website changes? Where is that blocked?
10:26:40 <flo> it would be nice to give translators the whole week-end + Monday to take care of them (we are releasing Tuesday)
10:31:21 <clokep> I worked on them a bit more, had one of my "user" friends read them and fixed it a bit based on some comments.
10:31:30 <clokep> It needs a bit more work + being put into the website.
10:31:30 <Mic> flo: how does one override a method defined in a binding in a good way by the way?
10:32:33 <clokep> Mic: I do it in Vertical Tabs using onload listeners.
10:32:37 <flo> maybe create another binding that extends this one and implements only that method?
10:32:55 <flo> or with JS, in which case you have to detect each time a new binding of that kind is created
10:33:08 <clokep> Mic: http://code.google.com/p/vertical-tabs/source/browse/chrome/content/instantbird.js#47
10:33:14 <clokep> Is the JS method.
10:34:02 <clokep> flo: This is what I had for the website, but it's not done / some pages are copies of 1.0. :-X
10:34:04 <clokep> http://pastebin.instantbird.com/1019
10:37:46 <flo> hmm ok.
10:38:04 <clokep> Just so you have it. (I'm away this weekend)
10:38:14 <flo> do you plan to work on that more / finish it in the next 10 hours, or should I take it over?
10:40:49 <clokep> I have meetings from 8 - 2 + driving to work...which is the first 7 of the next 10 hours. :(
10:40:58 <clokep> So I probably won't finish it. Sorry! I was hoping to take that off your plate.
10:41:36 <flo> I was hoping to finish it this morning :(
10:41:54 <flo> but nothing is getting done as I wasted time with that update issue (which still isn't fixed!) and the sametime crash
10:48:53 <clokep> :-/
10:52:02 <clokep> I will not get to it "this morning" even if this morning is here and not in France. ;) So yeah, I'd say you should take a look at it.
10:59:31 <-- clokep has left #instantbird ()
11:15:20 <Mic> I'd try a simple add-on for bug 701 when bug 772 is fixed and if it works we can put it on the add-ons repository as an example for this sort of thing.
11:15:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=701 enh, --, ---, nobody, NEW, Sort buddies by status
11:15:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=772 enh, --, ---, nobody, NEW, Use a sortComparator function on groups to allow easy changing of the order of contacts
11:42:57 --> clokep_work has joined #instantbird
11:42:57 * ChanServ sets mode +h clokep_work 
11:44:16 * clokep_work is now known as clokep_meeting
11:45:31 * clokep_meeting is not really here but...
11:45:40 <clokep_meeting> Mic: I'd suggest sort by status, then by name. It's one that's been suggested. :)
11:46:35 <Mic> Yes, that's the one that looked useful to me ;)
11:48:45 --> gerard-majax_ has joined #instantbird
11:49:12 <-- gerard-majax has quit (Ping timeout)
11:51:07 <flo> Mic: yeah, so we will keep r-'ing that patch until it's acceptably easy to make that add-on ;)
12:09:24 * gerard-majax_ is now known as gerard-majax
12:09:55 <-- mmkmou has quit (Ping timeout)
12:14:59 --> ironhead has joined #instantbird
12:16:46 <-- ironhead has quit (Quit: leaving)
12:19:16 --> ironhead has joined #instantbird
12:24:39 --> mmkmou has joined #instantbird
12:35:06 <-- Mad_Maks has quit (Ping timeout)
12:35:57 <-- ironhead has quit (Quit: leaving)
12:57:07 <-- clokep_meeting has quit (Quit: http://www.mibbit.com ajax IRC Client)
12:57:22 --> jb has joined #instantbird
13:05:58 <v17al1> Mic: A cool way to do it could be to have a new menu item on the contact list which would just say sort by-> [name, status, ...]
13:06:24 <flo> that menu item can be part of the add-on :)
13:06:32 <v17al1> Definitely :)
13:07:15 <flo> also note that if the sort order can change at runtime (rather than only at startup when the addon enters into effect), you have to handle moving contacts around
13:07:36 <v17al1> Maybe a resort method?
13:08:04 <v17al1> Well, you could just change the sortComparator and then call sort on contacts if you can get access to it
13:09:10 <v17al1> Maybe we should use a changeComparator method that takes in a sort function as input and then swaps the comparator then calls sort. Would make sure the change is done properly
13:09:12 <flo> that won't work. You can't call .sort on the childNodes of a DOM node; .sort is only for JS arrays
13:10:02 <flo> (that was replying to "call sort on contacts if you can get access to it")
13:10:42 <v17al1> Would the changeComparator method be a good idea?
13:11:11 * Mic tries to get the hg extension of Bug 1037 to work on his repository
13:11:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1037 enh, --, ---, nobody, NEW, Link "bug xxx" to bugzilla in hgweb
13:11:52 <Mic> Is there any trick one should know? It seems that the script properly loads but to no effect when viewing it on the local webserver :(
13:14:02 <flo> I can't help for this, sorry :-/.
13:48:01 --> mokush has joined #instantbird
14:02:13 <-- jb has quit (Quit: Instantbird 1.0)
14:02:14 --> jb has joined #instantbird
14:05:55 --> MattATobin has joined #instantbird
14:18:30 <Mic> :)
14:18:35 <Mic> It finally works :)
14:18:50 --> clokep_work has joined #instantbird
14:18:50 * ChanServ sets mode +h clokep_work 
14:19:31 <clokep_work> Mic: You could task ted in #developers.
14:19:44 <Mic> I just made it.
14:19:48 <flo> clokep_work: it seems you are a few seconds late ;)
14:20:24 <clokep_work> :(
14:20:58 <Mic> bbl
14:25:23 --> ecaron has joined #instantbird
14:27:05 <Mic> It required modifying the style templates btw .. I've no idea if that'll work with our hg version too but I'll diff my original theme and the modified one later.
14:29:18 <ecaron> Is there any way to get links in a message to NOT open within instantbird?
14:29:41 <flo> err
14:29:46 <flo> are you on 1.0?
14:29:56 <ecaron> for like another 3 minutes
14:30:22 <flo> 2 solutions: 1. Upgrade. 2. Disable formattings in messages (from the "Contents" prefpane)
14:30:36 <ecaron> I'll take #1
14:30:39 <flo> (you don't need to apply the two of course, just one of them is enough)
14:30:55 <-- ecaron has quit (Quit: Instantbird 1.0)
14:31:19 --> ecaron has joined #instantbird
14:31:32 <flo> ecaron: I was going to ask if you wanted a nightly or a 1.1 release candidate ;)
14:32:05 <ecaron> Which would you prefer I try?
14:32:40 <flo> nightly everyday. But as soon as we have release candidates for all OSes and locales, I'll ask everybody to test them ;)
14:33:13 <ecaron> Sounds good. I'm also hoping that the background-messages bugs somehow magically got fixed along the way too.
14:33:24 <ecaron> Turning off the system tray option didn't fix it.
14:39:19 <clokep_work> ecaron: Be more specific please.
14:40:32 <ecaron> clokep: I talked it out the flo earlier. I can't reliably reproduce it yet. Basically ib decides to occassionally background an incoming message and I only see it when I try to close the program and it tells me I have unread messages.
14:40:54 <clokep_work> Oh, that's weird.
14:40:56 <ecaron> We first thought msn protocol might be messing things up, then maybe the close-to-system-tray option. But its still happening.
14:41:00 <ecaron> Win7x64
14:41:31 <flo> random bugs are painful :(
14:48:44 <clokep_work> Might be good to do a bug report though and keep track so everyone can see what's up and what you've already tried, etc.
14:48:47 <clokep_work> Bugs are cheap. ;)
14:56:59 <ecaron> Alright, I'll post the bug report.
15:02:34 --> myk has joined #instantbird
15:07:53 <clokep_work> Thanks! :)
15:16:00 <-- Mic has quit (Ping timeout)
15:17:59 <-- myk has quit (Ping timeout)
15:30:57 --> myk has joined #instantbird
15:36:34 <-- myk has quit (Ping timeout)
15:37:04 --> myk has joined #instantbird
15:46:51 <-- myk has quit (Ping timeout)
15:47:50 <-- gerard-majax has quit (Ping timeout)
15:48:17 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:00:17 <-- v17al1 has quit (Ping timeout)
16:06:09 --> FeuerFliege has joined #instantbird
16:11:53 <flo> Linux/Windows rc4 ready. Mac is still has a few hundred megabytes to upload
16:27:46 --> Mook_as has joined #instantbird
16:28:56 --> clokep_work has joined #instantbird
16:28:56 * ChanServ sets mode +h clokep_work 
16:29:43 <FeuerFliege> flo: Will the nightly autoupdate to the same version?
16:29:54 <clokep_work> Nightlies will not update to the RC.
16:29:58 <flo> they will update to 1.2a1pre
16:30:10 <flo> (which I decided not to build today)
16:32:09 --> igorko has joined #instantbird
16:33:06 --> clokep has joined #instantbird
16:33:06 * ChanServ sets mode +h clokep 
16:33:19 <FeuerFliege> clokep_work: I know, but it would have been possible, that the next nightly is build from the same source (except branding)
16:33:50 <flo> FeuerFliege: the version number is also different
16:33:58 <flo> "pre" at the end ;)
16:34:38 <FeuerFliege> ;)
16:34:59 --> Mic has joined #instantbird
16:34:59 * ChanServ sets mode +h Mic 
16:35:02 <flo> and so it's not the exact same source changeset
16:35:32 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:51:06 <-- mmkmou has quit (Ping timeout)
16:53:08 <-- FeuerFliege has quit (Quit: Instantbird 1.1a1pre)
16:53:24 --> myk has joined #instantbird
16:53:44 <-- mokush has quit (Client exited)
17:05:26 --> hunsly has joined #instantbird
17:08:12 --> mmkmou has joined #instantbird
17:16:45 <clokep> flo: Are the release notes looking fine or does anything need to be written still for those?
17:20:26 <flo> maybe in the tray icon part say that it's for Windows/Linux
17:23:19 <flo> "    Each event can be filtered based on the event type or which sources to customize what actions are allowed to happen." doesn't seem to make sense, especially the "or which sources" part
17:24:40 <flo> is the order of the points good?
17:29:09 <clokep> Yes, that sentence could use some help. :-/
17:31:20 <flo> is it better now?
17:31:51 <clokep> Yes, that's much better. :)
17:32:10 <clokep> Also the # of changes needs to be filled in. ;)
17:33:17 <flo> that number isn't localizable IIRC
17:33:23 <flo> so it doesn't block us ;)
17:33:38 <flo> I'm going home. I'll be back online in a few hours
17:33:39 <-- flo has quit (Quit: Instantbird 1.1)
18:26:30 <Mic> "19:33:40 - flo left the room (Quit: Instantbird 1.1)."
18:26:39 <Mic> I thought we didn't want to show the version number there?
18:27:05 <Mic> Or was _that_ ok because the user is gone alreadyß 
18:27:30 <Mic> And we didn't want to report it at another place?
18:36:34 <aleth> Mic: no, you're right, I think the convention is no version numbers for security reasons
18:37:41 <aleth> Mic: Do you have a finished version of your aero blist/conversation css files? If so I might experiment with them over the weekend on Linux
18:46:54 <Mic> "Mic: Do you have a finished version of your aero blist/conversation css files?" - what do you mean?
18:47:58 --> gerard-majax has joined #instantbird
18:52:27 <aleth> Mic: You had a couple of patches on the go in the last few days (section headers, drop contact here, etc)
18:53:16 <-- mmkmou has quit (Client exited)
18:53:32 <aleth> If this is still work in progress, then it makes no sense for me to try to port it
18:55:45 <Mic> There's http://hg.instantbird.org/instantbird/rev/07440638cc63 and http://hg.instantbird.org/instantbird/rev/cc60b3d4e6b3
18:55:56 <Mic> And the drop contact target is a WIP
18:57:14 <Mic> Ah, the patch for bug 986 affects you already. It wasn't an OS-specific change.
18:57:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=986 nor, --, 1.1, benediktp, RESO FIXED, Improve theming of the "unread count"
18:57:32 <aleth> OK thanks :)
18:57:51 <aleth> Yes, 986 is already in the nightly and looking good if I may say so
19:00:44 <clokep> Mic: Did he change his quite message to it?
19:12:08 <-- jb has left #instantbird ()
19:13:08 <ecaron> Could somebody close bug 282, bug 518, bug 854 and bug 1069? (All are either fixed by the new blog or were fixed by flo within the last year)
19:13:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=282 nor, --, ---, nobody, RESO DUPLICATE, http://ftp.instantbird.com/instantbird/nightly/latest-trunk/ shows obsolete nightly builds
19:13:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=518 min, --, ---, nobody, NEW, The blog and wiki have no link to main instantbird.com website
19:13:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=854 nor, --, ---, nobody, NEW, Blog: "comment added" notification
19:13:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1069 nor, --, ---, nobody, NEW, 'What's new" feed display broken
19:13:30 <ecaron> Sorry, I meant bug 283, not 282
19:13:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=283 nor, --, ---, nobody, NEW, Bug on the blog
19:14:37 <Mic> ecaron: OK, I'll do that in a minute
19:14:42 <Mic> Thanks for reporting :)
19:16:31 <aleth> I don't think bug 1069 is fixed
19:16:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1069 nor, --, ---, nobody, NEW, 'What's new" feed display broken
19:17:05 <aleth> At least it isn't if under "What's new" the intended feed is the blog feed
19:17:05 <Mic> aleth: don't worry, I'm checking each bug if it's fixed
19:17:09 <ecaron> Damn it. I swore the new post showed up.
19:17:17 <ecaron> Thanks Mic & aleth
19:17:28 --> DGMurdockIII has joined #instantbird
19:18:17 <Mic> Bug 518 also asks for a link from the wiki to the homepage.
19:18:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=518 min, --, ---, nobody, NEW, The blog and wiki have no link to main instantbird.com website
19:18:34 <instantbot> New Instantbird (UI) bug 1076 filed by eric.caron@gmail.com.
19:18:35 <aleth> ecaron: Another little detail while you're at it is a slight mismatch in the top nav bar between ib.com and ib.org ("News" vs "Blog")
19:18:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1076 nor, --, ---, nobody, UNCO, Messages randomly getting lost in the background
19:18:36 <Mic> There's one on the "related links" subpage if that counts ;)
19:19:14 <ecaron> ib.org needs to become a 301 redirect to ib.com, but I can't really start harassing flo about those changes til 1.1 lands.
19:19:59 * ecaron dreams of access to the ib.com and .org sites...
19:20:45 <DGMurdockIII> who owns ib.org?
19:20:52 --> ecaron1 has joined #instantbird
19:22:09 <-- ecaron has quit (Ping timeout)
19:23:36 <-- ecaron1 has quit (Quit: Instantbird 1.1a1pre)
19:24:30 <instantbot> benediktp@ymail.com set the Resolution field on bug 854 to WORKSFORME.
19:24:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=854 nor, --, ---, nobody, RESO WORKSFORME, Blog: "comment added" notification
19:25:24 --> v17al has joined #instantbird
19:25:41 <instantbot> benediktp@ymail.com changed the Resolution on bug 854 from WORKSFORME to DUPLICATE.
19:26:22 <instantbot> benediktp@ymail.com set the Resolution field on bug 283 to WORKSFORME.
19:26:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=283 nor, --, ---, nobody, RESO WORKSFORME, Bug on the blog
19:27:50 <Mic> Bug 1086 still occurs as it seems.
19:27:52 <Mic> bbl
19:36:28 <-- chrisccoulson has quit (No route to host)
19:38:21 --> chrisccoulson has joined #instantbird
20:14:36 <-- clokep has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:19:34 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:19:38 --> aleth has joined #instantbird
20:23:42 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:23:44 --> aleth has joined #instantbird
20:27:31 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:27:33 --> aleth has joined #instantbird
20:31:51 --> flo has joined #instantbird
20:31:51 * ChanServ sets mode +qo flo flo 
20:32:57 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:33:00 --> aleth has joined #instantbird
20:35:16 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:35:19 --> aleth has joined #instantbird
20:37:08 --> ecaron has joined #instantbird
20:37:29 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:37:30 --> aleth has joined #instantbird
20:39:22 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:39:24 --> aleth has joined #instantbird
20:42:00 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:42:02 --> aleth has joined #instantbird
20:45:37 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:45:40 --> aleth has joined #instantbird
20:47:33 <flo> Mic: the version number is ok in the quit message
20:48:10 <flo> what is not OK is to have a potential attacker being able to query everybody in a room to know their client/version and then select targets based on their versions.
20:49:41 <aleth> Can't a potential attacker simply query the logs if the version number is in the quit message, since channels have regulars? (Of course this seems a bit far-fetched)
20:51:55 <flo> ecaron: access to ib.com and ib.org may be an accessible dream. They are handled with mercurial (https://hg.instantbird.org/websites/www.instantbird.com/ ) Everybody can make patches. And we could grant commit access to a few people (FeuerFliege already has commit access there, as he worked on updating the screenshots for the 1.0 release), as long as people only push reviewed changes.
20:52:29 * ecaron overjoyed
20:54:02 <flo> I'm not really sure you have convinced me about redirecting ib.org to ib.com though. (but that's not related to whether it's possible or not to have access).
20:54:18 --> pudgetta has joined #instantbird
20:54:27 <ecaron> I'm still working on that. Logo first. Then site structure.
20:54:47 <flo> and if we want to follow the mozilla lead on that, everything should rather be moved to .org
20:54:59 <pudgetta> so on my instantbird, the accounts window pops up seemingly randomly AND really small 
20:55:07 <pudgetta> any suggestions
20:55:08 <flo> and you can also make an argument for moving to instantbird.im, as all other IM clients seem to be using .im domains
20:55:29 <pudgetta> I'm on Windows 7. 
20:55:33 <Mook_as> and ib.im is one character shorter
20:55:33 <pudgetta> I can't tell what initiates it.
20:55:47 * Mook_as has seen the accounts window pop up on account disconnect/reconnect
20:55:57 <Mook_as> but usually not tiny
20:56:06 <flo> Mook_as: it's also twice as expensive, but that doesn't really matter anyway, as we pay for them all ;)
20:56:31 <Mook_as> that's okay, I'm not paying for it :p
20:56:45 <Mook_as> (or .com or .org or .xxx)
20:56:55 <-- MattATobin has quit (Quit: I'm a trifle deaf in this ear. Speak a little louder next time.)
20:56:57 <pudgetta> should I do a screen capture and document a bug. It seems to persist
20:57:09 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:57:10 <flo> pudgetta: the "it's tiny" part is a known bug (bug 584). 
20:57:11 --> aleth has joined #instantbird
20:57:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=584 nor, --, ---, nobody, NEW, Account manager window 0px height following a connexion error
20:57:15 <pudgetta> small annoyance, not a show stopper. Window comes hiding it's own title bar
20:57:36 <pudgetta> it's like 25 pixles high by 200 pixels wide total
20:57:46 <pudgetta> you can see the x to close it and you can expand it.
20:58:14 <flo> I've been told it's quite random (and annoying).
20:58:24 <flo> I've no idea of the cause :-/
20:59:07 <pudgetta> I'm so happy it's not just me.  So is instantbot a user? 
20:59:16 <pudgetta> or an extremely smart chatbot?
20:59:20 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
20:59:22 --> aleth has joined #instantbird
20:59:38 * ecaron hugs instantbot
20:59:39 <instantbot> I love you too, ecaron.
20:59:49 <-- hunsly has quit (Ping timeout)
20:59:58 <pudgetta> that answers that.
21:00:03 <ecaron> pudgetta: We'd call him a chatbot, but his feelings are a bit fragile:)
21:00:25 <flo> and the reason why the account manager pops up is that all your accounts are disconnected. If this is only temporary and you are getting automatically reconnected, it's a bug, it shouldn't popup.
21:00:49 <pudgetta> sweet. glad to know it's recorded.
21:00:57 <pudgetta> have a good weekdn
21:01:01 <-- pudgetta has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:01:20 <flo> and that's bug 1046
21:01:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1046 min, --, ---, nobody, NEW, Account window shows up on disconnect/reconnect
21:01:25 <flo> but I said that too late
21:01:34 <ecaron> i heard you
21:01:38 <ecaron> his loss
21:01:58 <flo> well, are you interested in that bug?
21:02:06 <ecaron> ... good point.
21:02:24 <flo> I know it's Mook's pet bug, but I didn't know you liked it too. I thought you preferred petting instantbot. ;)
21:02:39 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
21:02:41 --> aleth has joined #instantbird
21:02:42 <ecaron> Does that work?
21:02:48 * ecaron pets instantbot
21:02:49 <instantbot> :)
21:02:53 <ecaron> NICE!!!!
21:03:14 <Mook_as> instantbot: botsnack
21:03:15 * instantbot smiles
21:03:20 * ecaron vaccinates instantbot
21:03:31 <ecaron> ... disappointing.
21:04:05 <flo> having fun with instantbot seems to be a rite of passage here. Every geek here has done it at least once :-D
21:16:53 <flo> so buildbot decided the upload timeouted 24 minutes before it actually finished :-D
21:17:14 <flo> these uploads are insanely long though :(
21:17:27 <flo> we push 1.8GB of data to the server for each release candidate.
21:19:31 <Mook_as> how do you do the upload? rsync? ftp?
21:19:40 <flo> scp
21:19:58 <flo> and I really miss the internet connection I had at the previous office :(
21:20:51 <flo> 100Mbps symetric was way more confortable than the crappy 20Mbps down / 1 up I currently have at the new office :-/
21:21:55 <flo> Mook_as: the good thing about this timeout is that buildbot also forget to kill the job... so it finishes peacefully even though buildbot reports on the web UI that it has failed :).
21:22:03 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
21:22:05 --> aleth has joined #instantbird
21:22:07 <Mook_as> haha
21:23:41 <Mook_as> consider using rsync-over-ssh with --progress - as long as the connection doesn't stall it should let buildbot think stuff isn't hung
21:23:59 --> jb has joined #instantbird
21:24:45 <flo> sounds like something to investigate :)
21:25:10 <Mook_as> that assumes you have rsync available of course (could be a problem on windows)
21:29:54 <flo> ah, I didn't remember that thing you call windows existed :-D
21:31:52 <Mook_as> you need them to let sunlight through.
21:35:14 <-- Mic has quit (Quit: Instantbird 1.1a1pre)
21:40:25 <v17al> Hey guys, I just wanted to let you know I had a great time working on this project (although for a very short time). I just got offered a job and I will need to spend the next couple weeks learning new languages for it and they don't allow their developers to code elsewhere unfortunately.
21:40:59 <v17al> I will finish up the bugs currently opened, and will also submit my sound control addon, but I don't think I'll be able to do much more :(.
21:41:29 <v17al> Thanks again (especially to flo and clokep) for all the great advice and help!
21:42:00 <flo> "they don't allow their developers to code elsewhere" really?
21:42:51 <Mook_as> I've heard people that do that. RIM, apparently, may be one of them.
21:45:28 <v17al> Yeah, they don't want you to "innovate" elsewhere
21:46:04 --> mmkmou has joined #instantbird
21:46:22 <v17al> The job is exactly what I wanted though (did a co-op there), so it's definitely worth it.
21:46:26 <flo> if you go to another employer later, you will be welcome back here ;)
21:47:04 <flo> but you can still stay around here and report bugs that annoy you, right? ;)
21:47:57 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
21:47:59 --> aleth has joined #instantbird
22:07:14 <-- mmkmou has quit (Ping timeout)
22:07:50 --> mmkmou has joined #instantbird
22:12:58 <-- ecaron has quit (Quit: Instantbird 1.1a1pre)
22:13:50 <-- jb has quit (Ping timeout)
22:20:24 <-- mmkmou has quit (Ping timeout)
22:21:58 --> mmkmou has joined #instantbird
22:27:26 <-- igorko has quit (Connection reset by peer)
22:27:58 --> igorko has joined #instantbird
22:31:55 <flo> 138 code changes between 1.0 and 1.1
22:34:46 <Mook_as> hg diff --stat?
22:37:32 <v17al> Definitely flo :)
22:38:22 <flo> Mook_as: thanks for that! I didn't know hg supported that, I've typed hg diff |diffstat hundreds of times! :-X
22:38:33 <-- mmkmou has quit (Ping timeout)
22:38:43 <Mook_as> I knew git did, so I just looked at hg diff --help ;)
22:38:56 <flo>  341 files changed, 45966 insertions(+), 9083 deletions(-)
22:39:05 <Mook_as> that's... a big number.
22:39:18 --> mmkmou has joined #instantbird
22:39:24 <flo> exclude the " 43 files changed, 27632 insertions(+), 0 deletions(-)" from the sametime folder for more realistic stats.
22:39:47 <Mook_as> still a pretty big number. 10kish?
22:40:01 <Mook_as> ah, 20k.
22:40:19 <flo>  199 files changed, 40297 insertions(+), 7728 deletions(-) in purple/libpurple
22:40:48 <flo> ah, there are lots of changes in libqq too
22:41:08 <flo> and upstream libpurple has upgraded libgadugadu
22:41:28 <Mook_as> I wonder if hg diff -X would help
22:43:14 <flo> anyway, instantbird/ ->  63 files changed, 1620 insertions(+), 441 deletions(-)
22:43:30 <flo> purple/purplexpcom/ ->  44 files changed, 1483 insertions(+), 483 deletions(-)
22:47:33 <-- igorko has quit (Quit: Instantbird 1.1a1pre)
22:47:38 <-- mmkmou has quit (Ping timeout)
22:48:11 --> mmkmou has joined #instantbird
22:52:37 <-- mmkmou has quit (Ping timeout)
22:53:21 --> mmkmou has joined #instantbird
22:55:26 <-- mmkmou has quit (Ping timeout)
22:56:07 --> mmkmou has joined #instantbird
23:02:26 <-- mmkmou has quit (Ping timeout)
23:03:53 --> mmkmou has joined #instantbird
23:10:37 <-- mmkmou has quit (Ping timeout)
23:11:20 --> mmkmou has joined #instantbird
23:14:15 <-- mmkmou has quit (Ping timeout)
23:17:44 --> clokep_ has joined #instantbird
23:21:48 <flo> I'm tempted to replace:
23:21:48 <flo>     Use of Mozilla 7.0.1 brings great new possibilities for add-on developers (https://developer.mozilla.org/en/Firefox_5_for_developers, https://developer.mozilla.org/en/Firefox_6_for_developers and  https://developer.mozilla.org/en/Firefox_7_for_developers); for example, extensions can now display options right in the add-on manager (https://developer.mozilla.org/en/Extensions/Inline_Options)."
23:21:48 <flo> with just: "Updated: Instantbird 1.1 is based on libpurple 2.10.0 and Mozilla 7.0.1 which brings great new possibilities for add-on developers." so that I don't have to figure out how to localize that :-/
23:22:32 <clokep_> It's kind of verbose anyway.
23:22:55 <flo> I don't think add-on authors really read that ;)
23:23:06 <clokep_> Congratulations on your job v17al! Sticks you can't code elsewhere though. :( Please do report bugs and stuff though if you can! :)
23:24:19 <v17al> Thanks clokep, I'll see what my contract says, but I doubt I can keep coding. I'll definitely report anything if I see it
23:26:58 <clokep_> :) Great!
23:27:20 <flo> clokep_: http://pastebin.instantbird.com/1021 here are the website changes I have
23:27:46 <flo> v17al: fixing bugs isn't innovating ;)
23:28:00 <flo> adding a nice new feature may be though :(
23:28:11 <clokep_> flo: You could have not included the changesets. ;)
23:28:31 <flo> you mean the changelog ?
23:29:01 <clokep_> Yes, sorry.
23:29:30 <flo> you did earlier today, so I put it too :-P
23:29:58 <clokep_> Payback? ;)
23:30:16 <clokep_> Do we want to include the Firefox 5 and Firefox 6 changes for developers?
23:31:08 <clokep_> Although the 7 page includes links to 5 & 6, so it's probably fine.
23:31:08 <flo> I wanted until I realised I didn't know how to do it :-D
23:31:46 <clokep_> :) Alright.
23:31:56 <flo> so that's good to go? :)
23:31:57 <clokep_> Those look good, at least looking at it by hand and not trying it.
23:32:15 <flo> I'll try to put up a staging website asap
23:32:57 <flo> I need to figure out which mess I made of that just before the 1.0 release and after the traffic peak of the lifehacker article :)
23:33:37 --> mmkmou has joined #instantbird
23:33:54 <clokep_> Good luck!
23:37:25 <clokep_> So my flight is delayed 2 hours which sucks...but you guys are in luck now that I have no excuse to not write a blog post.
23:37:36 <flo> ahah
23:37:52 <flo> hmm, the l10n hook doesn't work :(
23:38:29 <flo> by the way, how easy is it to code during flights? Are there usable power outlets?
23:39:51 <v17al> Ys
23:39:54 <v17al> but only 75 watts
23:40:01 <clokep_> In the US there are not outlets, Idk about international.
23:40:05 <v17al> I think I blew one with my monster 150
23:40:13 <clokep_> And depending on your airport outlets are hard to find too. ;)
23:40:13 <v17al> Oh all Canadian flights do my bad
23:41:28 <clokep_> Where do you fly through flo?
23:41:45 <clokep_> (Also it's not hard to code on flights...but it's hard to test things like say....connecting to IRC servers in flight. :P)
23:42:12 <flo> clokep_: next week-end, from Paris to San Francisco (= lot of free disturbance free time to do reviews ;))
23:42:24 <clokep_> Direct?!
23:42:30 <flo> sure
23:42:31 <clokep_> That's long!
23:42:50 <clokep_> I figured you'd fly through Logan or JFK or maybe one of the DC airports.
23:43:00 <flo> what would I do there?
23:43:03 <clokep_> (Aka Boston, NYC or DC.)
23:43:16 <clokep_> Nothing? I just didn't realize they had direct flights from Paris to the west coast. :)
23:43:20 <flo> Air France has a direct flight between CDG and SFO, it's easier ;)
23:43:25 <-- mmkmou has quit (Ping timeout)
23:43:50 <clokep_> I agree. :)
23:44:17 <clokep_> ecaron: Is there a way for WP to show the # of comments on the summary page?
23:44:42 --> mmkmou has joined #instantbird
23:45:49 <clokep_> Anyone have an opinion about what I shuld write about?
23:48:14 <flo> something you like?
23:49:02 <clokep_> Yes. I'm debating...
23:55:54 <-- gerard-majax has quit (Ping timeout)
23:56:24 --> gerard-majax has joined #instantbird
23:56:47 * clokep_ is writing about the interruptions manager, but isn't fully sure what to say...:P