#instantbird log on 09 27 2011

All times are UTC.

00:38:31 <-- Mook_as has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner])
00:51:05 <-- devfil has quit (Client exited)
01:53:40 <-- linuxwizard has left #instantbird ()
01:57:00 --> DetoritLibertyPenguin has joined #instantbird
02:28:07 <-- DetoritLibertyPenguin has quit (Quit: Instantbird 0.3pre)
03:09:10 <-- werwolf has quit (Quit: '< auuuuuuuuuuuuuuu)
03:22:57 --> Mook has joined #instantbird
03:50:07 <-- Mook has quit (NickServ (GHOST command used by Mook_))
03:50:47 --> Mook has joined #instantbird
04:13:58 <-- EionRobb has quit (Quit: Leaving.)
04:59:35 --> clokep has joined #instantbird
04:59:35 * ChanServ sets mode +h clokep 
04:59:57 <clokep> Flo, I was also annoyed at testing that RT patch...probably the kind of thing we should make tests for. :(
05:07:22 <-- clokep has left #instantbird ()
05:29:58 --> FeuerFliege has joined #instantbird
06:20:51 <-- Mook has quit (Ping timeout)
06:21:17 --> Mook has joined #instantbird
06:38:07 --> Mad_Maks has joined #instantbird
06:47:02 <-- Mook has quit (Quit: zzz)
06:54:32 --> mokush has joined #instantbird
07:09:04 <-- Mad_Maks has quit (Connection reset by peer)
07:10:51 --> gerard-majax has joined #instantbird
07:11:04 --> Mad_Maks has joined #instantbird
07:47:25 <-- Mad_Maks has left #instantbird ()
08:23:32 --> jb has joined #instantbird
08:25:59 --> hunsly has joined #instantbird
08:46:17 --> flo has joined #instantbird
08:46:17 * ChanServ sets mode +qo flo flo 
09:12:16 <-- jb has quit (Ping timeout)
09:12:58 --> jb has joined #instantbird
09:25:11 --> mmkmou has joined #instantbird
09:42:51 <-- mmkmou has quit (Ping timeout)
09:59:51 --> mmkmou has joined #instantbird
10:07:39 <-- micahg has quit (Connection reset by peer)
10:07:48 --> micahg has joined #instantbird
10:12:27 <-- jb has quit (Ping timeout)
10:12:42 --> jb has joined #instantbird
10:14:24 <instantbot> florian@instantbird.org added attachment 847 to bug 990.
10:14:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=990 nor, --, ---, florian, ASSI, Closing a conversation window with unread messages should give a hint about the "hidden conversation
10:16:26 <instantbot> florian@instantbird.org set the Resolution field on bug 980 to DUPLICATE of bug 981.
10:16:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=980 enh, --, ---, nobody, RESO DUPLICATE, Allow to close conversation from the "hidden conversation" list
10:16:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=981 enh, --, ---, florian, NEW, Context menu for "hidden conversations"-list items.
10:19:21 <instantbot> florian@instantbird.org set the Resolution field on bug 985 to DUPLICATE of bug 981.
10:19:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=985 enh, --, ---, nobody, RESO DUPLICATE, Add "Leave conversation" to the context menu of tabs
10:19:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=981 enh, --, ---, florian, NEW, Adapt context menus for the "hidden conversations" feature (+address localizability issues)
10:25:49 --> aleth has joined #instantbird
11:03:44 <instantbot> New Instantbird (UI) bug 1051 filed by florian@instantbird.org.
11:03:45 <instantbot> florian@instantbird.org added attachment 848 to bug 1051.
11:03:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1051 enh, --, 1.1a1, florian, ASSI, Sort hidden conversations
11:08:16 <flo> reviews/comments welcome/wanted on bug 981, bug 990 and bug 1051. I think that's all we need to land before turning on the hidden conversations feature by default (bug 978).
11:08:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=981 enh, --, ---, florian, ASSI, Adapt context menus for the "hidden conversations" feature (+address localizability issues)
11:08:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=990 nor, --, ---, florian, ASSI, Closing a conversation window with unread messages shouldn't warn if the "hidden conversations" feat
11:08:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1051 enh, --, 1.1a1, florian, ASSI, Sort hidden conversations
11:08:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=978 nor, --, ---, nobody, NEW, Tracking bug for enabling "Hiding conversations" by default
11:09:22 <aleth> Another naming idea: "Paused conversations"?
11:09:28 <aleth> just throwing these out there
11:13:39 <lewellyn> flo: sorry i couldn't get to qq yet :(
11:17:28 <aleth> "Conversations pending"?
11:18:32 <aleth> Or, really they are just minimized... one could just call it that
11:24:14 --> werwolf has joined #instantbird
11:58:47 <flo> aleth: in the patch I used the "Conversations on hold" suggestion
12:00:19 <aleth> Ah, that's good too :)
12:00:57 --> Andrey has joined #instantbird
12:16:24 --> clokep has joined #instantbird
12:16:24 * ChanServ sets mode +h clokep 
12:33:44 <instantbot> New purplexpcom - Twitter bug 1052 filed by clokep@gmail.com.
12:33:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1052 enh, --, ---, nobody, NEW, Generate Twitter entities if not available
12:38:08 <-- clokep has quit (Ping timeout)
12:40:10 --> devfil has joined #instantbird
12:45:45 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
12:57:11 <-- hunsly has quit (Ping timeout)
13:44:15 <-- FeuerFliege has quit (Ping timeout)
13:44:28 --> FeuerFliege has joined #instantbird
13:45:27 --> Mic has joined #instantbird
13:45:27 * ChanServ sets mode +h Mic 
13:46:09 <Mic> Hi
13:46:20 <flo> Mic: hello :)
13:46:55 <Mic> I guess the interruptions manager, as it currently is, is going to make it into 1.1 ?
13:47:29 <flo> probably yes. I haven't been able to decide what could be a better API for it
13:47:59 <-- FeuerFliege has quit (Ping timeout)
13:48:47 <Mic> OK :)
13:53:14 <flo> did you hope for some changes?
13:53:24 <Mic> I was hoping to use it ;)
13:53:36 <flo> I'm already using it everyday ;)
13:54:07 <flo> hmm, I don't remember if I uploaded somewhere the add-on to hide auto-joined rooms by default
13:54:18 <Mic> I wanted to split the logic of Buddy Status (which notification to show, based on the preferences) off into a interruptions manager 'module'
13:54:37 <Mic> and the other code just asks for permission to show one and generates the alert popup based on this.
13:55:17 <flo> is this just code refactoring, or are there related user-visible features?
13:55:32 <Mic> No user-facing changes related to this.
13:55:34 <flo> or is it for better interactions with other future add-ons? :)
13:57:16 <Mic> I think I should check if it's ok to show a notification. Additionally the code would decide based on the settings if it's ok to do so.
13:57:23 --> aleth has joined #instantbird
13:58:30 <flo> do you want to review any of the recently-attached patches related to the hidden conversations feature before I land them?
13:58:45 <flo> I still need to write an AIM-spam silencer add-on :-S
13:58:48 <Mic> (so I figured I could as well make it into a interruptions manager 'module')
13:58:59 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
13:59:16 <Mic> I haven't really checked the logs yet, how many patches are waiting there?
13:59:28 <flo> 3 I think
13:59:37 <flo> but I combined some of the bugs together
14:00:12 * Mic goes to check bugmail. Since I most likely filed them, I should have new mails;)
14:00:41 <flo> yeah, there was a bug spam morning today ;)
14:01:42 <Mic> I see, 17 new mails there.
14:01:49 <Mic> That was worse already ;)
14:22:44 <-- Mic has quit (Quit: Instantbird 1.1a1pre)
14:22:53 --> Mic has joined #instantbird
14:22:54 * ChanServ sets mode +h Mic 
14:31:29 <instantbot> New Instantbird (UI) bug 1053 filed by benediktp@ymail.com.
14:31:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1053 nor, --, ---, nobody, NEW, Closing first tab using the [x]-icon doesn't remove unread status of second tab
14:32:37 <-- Mic has quit (Quit: Instantbird 1.1a1pre)
14:57:35 <-- mokush has quit (Client exited)
15:09:35 <-- ecaron has quit (Ping timeout)
15:19:12 <-- Andrey has quit (Quit: )
15:20:05 <-- mmkmou has quit (Ping timeout)
15:23:37 --> em3 has joined #instantbird
15:25:29 <em3> hello
15:25:45 <em3> can instantbird be used to open IRC URIs?
15:26:01 <em3> (from hyperlink, for example)
15:27:01 <flo> hello. That's not currently possible (I think we want to add this in the future though :)).
15:29:17 <-- micahg has quit (Quit: Ex-Chat)
15:29:30 --> micahg has joined #instantbird
15:37:04 --> mmkmou has joined #instantbird
15:47:50 --> igorko has joined #instantbird
15:54:59 <-- gerard-majax has quit (Ping timeout)
15:57:59 --> hunsly has joined #instantbird
15:59:21 <-- micahg has quit (Input/output error)
16:00:08 --> micahg has joined #instantbird
16:05:18 <-- jb has quit (Ping timeout)
16:06:04 --> jb has joined #instantbird
16:09:24 --> aleth has joined #instantbird
16:10:01 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
16:15:27 --> Mook_as has joined #instantbird
16:17:29 <-- micahg has quit (Input/output error)
16:20:34 --> micahg has joined #instantbird
16:31:19 <-- hunsly has quit (Connection reset by peer)
16:42:38 <-- devfil has quit (Connection reset by peer)
16:55:36 --> hunsly has joined #instantbird
16:56:13 <-- em3 has left #instantbird ()
17:03:08 <-- jb has quit (Ping timeout)
17:04:16 --> jb has joined #instantbird
17:04:55 --> hicham has joined #instantbird
17:09:02 <-- jb has left #instantbird ()
17:17:17 <-- mmkmou has quit (Ping timeout)
17:33:58 --> mmkmou has joined #instantbird
17:34:57 <-- flo has quit (Quit: Instantbird 1.1a1pre)
17:56:29 --> aleth has joined #instantbird
18:02:37 --> ecaron has joined #instantbird
18:18:18 <-- mmkmou has left #instantbird ()
18:22:59 --> clokep has joined #instantbird
18:22:59 * ChanServ sets mode +h clokep 
18:40:41 <-- hunsly has quit (Connection reset by peer)
18:45:08 --> gerard-majax has joined #instantbird
18:55:17 --> mistraven has joined #instantbird
18:55:29 <-- mistraven has left #instantbird ()
19:00:11 --> devfil has joined #instantbird
19:03:24 --> hunsly has joined #instantbird
19:04:40 <-- Tonnes has quit (Quit: ChatZilla 0.9.87 [Firefox 6.0.2/20110902133214])
19:05:39 --> flo has joined #instantbird
19:05:39 * ChanServ sets mode +qo flo flo 
19:05:58 <flo> Good evening :)
19:06:59 <clokep> Good night.
19:07:18 <Mook_as> good noon!
19:08:44 <flo> clokep: it's already the night for you? :-O
19:08:55 <clokep> No, it's like 3:00. :p
19:09:11 <clokep> Was that a "good evening" as a hello or a goodbye? ;)
19:09:19 <flo> a hello :)
19:09:26 <flo> it's only 9pm
19:10:18 <flo> clokep: would you like some time to look at the recently attached patches or should I just land them this evening before going to bed?
19:10:42 <clokep> flo: I did look over a couple of them quickly, but I didn't fully check over them...
19:12:08 <-- igorko has quit (Ping timeout)
19:12:16 <flo> the code is probably ok, except for what I commented in bug 1051, and the strings from bug 981 could maybe get slightly improved after a bikesheding session.
19:12:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1051 enh, --, 1.1a1, florian, ASSI, Sort hidden conversations
19:12:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=981 enh, --, ---, florian, ASSI, Adapt context menus for the "hidden conversations" feature (+address localizability issues)
19:14:23 <clokep> OK. I'll check 'em.
19:14:24 <flo> if we expect someone will ever have hundreds of hidden conversations at once, the perf issue may be real
19:14:52 <clokep> Bug 990 I didn't see anything in.
19:14:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=990 nor, --, ---, florian, ASSI, Closing a conversation window with unread messages shouldn't warn if the "hidden conversations" feat
19:15:18 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
19:15:32 --> aleth has joined #instantbird
19:15:38 <flo> it's a bit trivial. Just sad that the warning code gets fixed only once the warning becomes disabled by default ;)
19:16:26 <flo> AIM spammers have the good taste of reminding me several times a day that I need to write an add-on for them :)
19:16:31 <clokep> My only comment on bug 1051 is whether wanted to make a separatte function to sort them, but it probably doesn't matter (and if someone really wants it, they can make a patch).
19:16:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1051 enh, --, 1.1a1, florian, ASSI, Sort hidden conversations
19:16:35 <flo> I don't even need to bother putting it in the todo list
19:16:55 <clokep> Haha.
19:21:06 <flo> clokep: so you mean a function to customize the order?
19:21:25 <flo> I would take a patch for that, not write it myself :).
19:21:57 <clokep> Something akin to bug 772.
19:22:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=772 enh, --, ---, nobody, NEW, Use a sortComparator function on groups to allow easy changing of the order of contacts
19:22:52 <flo> ok
19:23:21 <flo> wanna r+ the patchs you've already looked at and that seem ok?
19:24:03 <flo> aleth: how are you testing it?
19:24:50 <aleth> 1) close conv window so there are hidden conv with unread messages 2) quit IB
19:25:20 <aleth> I suspect it is not sensitive to unread messages in hidden conv (but should be)
19:25:39 <flo> aleth: we used to have that bug, but it's been fixed weeks ago
19:26:18 <flo> (and I've just tested it, with one hidden conversation with unread messages and no conversation window, the warning does appear)
19:26:25 <clokep> flo: Will do the r+s in a second.
19:26:34 <aleth> flo: strange, I am on the latest nightly
19:27:28 <flo> aleth: unread messages that don't contain your nick don't count in chatrooms.
19:27:41 <flo> (but that's always been the case for all our warnings)
19:28:27 <aleth> that explains it then
19:43:18 <instantbot> florian@instantbird.org added attachment 849 to bug 1027.
19:43:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1027 nor, --, ---, florian, ASSI, Allow to turn off the "double click to reply to <someone>" feature
19:43:20 <flo> this one is totally trivial :)
19:44:28 <instantbot> clokep@gmail.com granted review for attachment 848 on bug 1051.
19:44:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1051 enh, --, 1.1a1, florian, ASSI, Sort hidden conversations
19:47:48 <flo> clokep: https://bugzilla.instantbird.org/attachment.cgi?id=849&action=edit this one is really easy ;)
19:48:06 <clokep> flo: I just opened that one. :p
19:49:03 <instantbot> clokep@gmail.com granted review for attachment 849 on bug 1027.
19:49:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1027 nor, --, ---, florian, ASSI, Allow to turn off the "double click to reply to <someone>" feature
19:49:18 --> EionRobb has joined #instantbird
19:49:30 <clokep> And get what preference I just made and set to false? ;)
19:50:36 <flo> you couldn't wait for the next nightly so that you would just have had to double click it? ;)
19:50:48 <flo> have you disabled tab complete? :)
19:51:14 <clokep> It's easy enough to copy and paste. :)
19:51:35 <clokep> I just removed tab compolete right now flo!
19:52:03 <flo> so it seems we are making good progress on that sw:1.1 list :)
19:52:10 <flo> maybe we should add some more? ;)
19:52:14 <clokep> Yes, we are. :)
19:52:15 <clokep> Hah.
19:53:10 <flo> I would like that twitter entity bug fixed :)
19:53:30 <instantbot> clokep@gmail.com granted review for attachment 847 on bug 990.
19:53:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=990 nor, --, ---, florian, ASSI, Closing a conversation window with unread messages shouldn't warn if the "hidden conversations" feat
19:53:42 <flo> especially if we claim in the release notes that we now support entities, it's sad that the first messages that will appear in everybody's timeline won't have them
19:53:52 <clokep> flo: Yes, that would be nice. I really just didn't want to wrap it up in the other big since that one would never get fixed now. :P
19:54:47 <flo> I would also like us to reshow the OAuth dialog if we receive "401 - Unauthorized" errors
19:55:28 <flo> and maybe bug 1038, but that's less important
19:55:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1038 enh, --, ---, nobody, NEW, Add followed people to the participants timeline
19:55:46 <clokep> Twitter is defintiely a lot more usable now though. :)
19:56:05 <flo> yes :)
19:56:26 <flo> and still has a lot of possible progress for 1.2 or later :)
19:59:14 <flo> it's probably almost time to start thinking about what we want to blog to announce the release ;)
20:00:38 <flo> we probably need at least a post showing how nice twitter is now (or how broken it was in 1.0), a post about hidden conversations, and a post about the interruptions manager (with links to the 3 add-ons I'm cooking that take advantage of it).
20:00:46 <flo> + a general release announce post
20:01:16 <clokep> flo: So the libqq stuff...it uses a guintptr, which needs &gt;2.18 according to http://developer.gnome.org/glib/2.29/glib-Basic-Types.html#guintptr
20:01:31 <clokep> Is it better to just #define it away or to upgrade?
20:01:54 <flo> typedef unsigned long guintptr;
20:02:06 <flo> you just linked to the line you need to add ;)
20:02:28 <clokep> Oh, is that really it? :-[
20:02:53 <clokep> Where do typedefs usually go in C code? near the top i assume?
20:02:58 <flo> upgrading glib is a lot of work. We will have to get to it eventually, but as long as we can avoid it... :)
20:03:04 <clokep> Ah never mind, there's another one there I'll put it near.
20:03:07 <flo> yeah, near the top, after the includes
20:06:39 <flo> so there's still bug 891 that doesn't have a review
20:06:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=891 tri, --, ---, nobody, NEW, Add-Ons Window Doesn't Close CMD+W
20:07:33 <flo> bug 981 of course
20:07:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=981 enh, --, ---, florian, ASSI, Adapt context menus for the "hidden conversations" feature (+address localizability issues)
20:07:43 <flo> 891 doesn't have a patch either ;)
20:07:44 <clokep> "doesn't have a review"?
20:07:49 <clokep> Ah, OK. :)
20:08:01 <flo> that I shouldn't commit yet
20:08:34 <flo> I'll probably resolve bug 978 just after that (= toggle that pref value in all-instantbird.js)
20:08:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=978 nor, --, ---, nobody, NEW, Tracking bug for enabling "Hiding conversations" by default
20:10:51 <clokep> Alright.
20:11:39 --> igorko has joined #instantbird
20:14:00 <clokep> Bah libqq also uses GDate, which I don't think we've included...
20:14:38 <EionRobb> why not just include all of glib and be done with it
20:16:18 <flo> EionRobb: some parts are dangerous and clearly unwanted (the g_spawn_* functions especially).
20:16:39 <flo> + in the past, we used to built Instantbird for Windows CE, and some parts of glib don't compile for it.
20:16:46 <flo> *build
20:19:16 <flo> If I could remove the functions that to disk access, that would be nice too :)
20:19:18 <flo> *do
20:19:59 <flo> but our libpurple still writes the buddy icon files to disk itself, so it's not possible yet
20:20:27 <EionRobb> make a virtual disk for libpurple to write to ;)
20:20:52 --> harlock has joined #instantbird
20:21:26 <flo> if we could also remove the g_thread family of functions, that would also make me happier ;)
20:21:40 <clokep> flo: Well...my main point being libqq needs a bunch of work to make it happen then. :P
20:21:50 <clokep> More than just a few defines and such.
20:22:08 <flo> pastebin an error log? :)
20:22:32 <flo> gdate may not be too painful to add back
20:23:23 --> harlock1 has joined #instantbird
20:23:38 <clokep> (This is after the typedef I already fixed: http://pastebin.instantbird.com/969)
20:24:01 <-- harlock has quit (Ping timeout)
20:24:35 <EionRobb> don't get rid of gthread :(
20:25:00 <flo> I would prefer if you could make -k -C purple/libpurple/protocols/qq/
20:25:20 <flo> EionRobb: libpurple isn't thread safe.
20:25:43 <EionRobb> and gspawn is useful too :(
20:25:56 <EionRobb> the skype plugin uses both gthread and gspawn
20:26:20 <flo> you start the skype process yourself?
20:26:32 <EionRobb> yeah, optionally
20:26:39 <clokep> What does -k do?
20:26:54 <flo> clokep: continue even when there are errors
20:27:20 <flo> so that we see the errors in the other files too, and can decide how close to fixing all of them you are ;)
20:27:28 <clokep> flo: "No targets specified and no makefile found. Stop."
20:27:29 <clokep> :)
20:27:39 <flo> fix the path
20:27:56 <flo> if you are already in the purple folder, obviously you shouldn't include it in the -C argument
20:28:12 <clokep> If I'm in the root?
20:28:36 <clokep> Bah nvm, I had gone up too high.
20:28:59 --> Tonnes has joined #instantbird
20:30:19 <flo> EionRobb: well, the skype plugin is clearly a very special case :-/
20:30:20 <hicham> good evening everybody
20:32:04 <clokep> Uhhh...is there a better way to save it to a file than just using &gt;? I'm just getting two lines out saying it entered the directory and left again.
20:32:32 <flo> you still haven't fixed that encoding issue? :-(
20:32:34 <EionRobb> clokep: you're still outputting xml entities instead of the greaterthan sign :)
20:33:33 <flo> clokep: the error messages are most likely on stderr
20:33:42 <flo> so that's 2>filename for the error messages
20:34:05 <clokep> EionRobb: flo: I added the flag you said to not get HTML encoding, but that didn't fix it and I haven't debugged it yet.
20:34:09 <clokep> Been fixing stuff for 1.1. :P
20:34:23 <flo> right, that's for 1.2
20:35:05 <flo> clokep, try: 2>&1 >filename
20:35:06 <flo> to have both stdout and stderr in the same file
20:35:13 <-- harlock1 has quit (Quit: Baibai)
20:35:14 <-- rikki has quit (Ping timeout)
20:35:15 <clokep> flo: I got it. :)
20:35:56 <clokep> flo: http://pastebin.instantbird.com/971
20:36:29 --> rikki has joined #instantbird
20:37:20 <flo> g_timeout_add_seconds :(
20:37:33 <flo> EionRobb: that's also something we need to remove ;)
20:38:34 <flo> clokep: you still have lots of guintptr errors in there
20:39:23 <clokep> flo: I only fixed it in the one file.
20:39:38 <flo> isn't there a header included by all these files?
20:41:05 <clokep> flo: http://pastebin.instantbird.com/972
20:41:08 <flo> have you tried to take some of our existing patches against the old qq plugin?
20:41:10 <clokep> Yes, I just didn't find it yt.
20:41:14 <clokep> No. Not yet.
20:41:31 <clokep> Literally I did was try to compile it and then fix that guintptr error. :P
20:41:51 <flo> cool, it's not as bad as it used to be then :)
20:42:07 <flo> there used to be several unconditional unistd.h includes
20:42:47 <flo> the code calling wpurple_install_dir/g_build_filename should most likely be ifdef'ed out.
20:42:51 <clokep> Ah, OK. :)
20:43:30 <clokep> Yeah, it actually doesn't look totally terrible...
20:43:44 <clokep> Bah you had given a diff at some point of our changes to make QQ compile...I don't suppose that ended up in the bug...
20:44:23 <flo> here is what we used to have: http://pastebin.instantbird.com/973
20:44:25 <clokep> Ah, ha it did. :)
20:44:32 <EionRobb> other than the windows ce compilation thing (are you doing that at the moment though?) I really don't see a good reason not to include all of gli
20:44:33 <EionRobb> b
20:45:16 <flo> EionRobb: we don't use the glib event loop. Anything attempting to call functions relying on the glib event loop is just broken.
20:45:42 <EionRobb> unless something wanted to run the glib event loop seperately
20:45:47 <flo> + mozilla has threading code that may not be super happy with other threading libraries messing with threads in the process.
20:46:05 <EionRobb> but you haven't tried?
20:46:35 <flo> EionRobb: it currently happens to work (libpurple makes some unfortunate uses of g_thread on Windows only)
20:47:30 <flo> clokep: "buddy_info.c(433) : warning C4244: '=' : conversion from 'time_t' to 'guint32', possible loss of data" this is listed as a warning, but it's a guaranteed bug, and used to cause crashes. MSVC time_t are 64 bit.
20:48:54 <clokep> Yeah. I'm guessing that's another ifdef I see.
20:48:57 <flo> clokep: also, all the #if !defined(_MSC_VER) || defined(_USE_32BIT_TIME_T) are there to avoid crashes
20:49:19 <flo> localtime on MSVC expects a pointer to a 64 bits value.
20:49:32 <flo> qd->login_time used to be (in the previous code) 32 bit ints.
20:51:05 <clokep> Got it.
20:51:20 <flo> so all the localtime calls need to be carefully checked. If the value given is a 32 bit pointer, something needs to be modified. In the past, we were lucky, the code using that was only used for purple_debug_info calls that would be ifdef'd out without causing additional issues.
20:51:44 <Mook_as> does that need to be checking _MSC_VER or _WIN32?
20:51:48 <flo> obviously a far better fix would be to change all the structures to use time_t rather than int in their definitions, but IIRC there were other implications
20:52:25 <flo> Mook_as: the |if !defined(_MSC_VER) || defined(_USE_32BIT_TIME_T)| check is right. Mingw uses 32 bit time_t values.
20:52:49 <Mook_as> okay, I'll need to check what mingw-w64 does.
20:54:06 <Mook_as> http://mingw-w64.svn.sourceforge.net/viewvc/mingw-w64/trunk/mingw-w64-headers/crt/time.h?revision=4481&view=markup#l40 - because I hang out with odd people :p
20:54:53 <flo> is it specifically for the 64bit version or has it changed since the last time I debugged that crappy code? :)
20:55:10 <Mook_as> (this is obviously going on whatever long queue you have for fixing things when you feel like it. not going to actually build on that any time soon, anyway)
20:55:29 <Mook_as> that has gcc/toolchains targeting both 32bit and 64bit windows.
20:57:50 <flo> by the way, it's possible the QQ code has been fixed to handle the 64 bit values already
20:58:48 <-- clokep has quit (Ping timeout)
20:59:12 --> Mic has joined #instantbird
20:59:12 * ChanServ sets mode +h Mic 
21:03:41 <flo> Mic: would you have some time this evening to test a diff I have for bug 979 to tell me if it improves the situation or doesn't help on Windows?
21:03:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=979 nor, --, ---, nobody, NEW, Fix look for "Hidden conversations" /"Contacts" contact list sections and their headers
21:03:51 <flo> I'm trying this on Mac: http://pastebin.instantbird.com/974
21:06:11 <Mic> OK
21:08:16 <flo> another possible patch that may look better: http://pastebin.instantbird.com/975
21:08:41 <flo> the first one makes the header look like toolbars. The second patch copies the theme of the infobar we have at the top of conversations
21:09:21 <flo> For Mac I think I prefer the result given by the second patch
21:09:34 <flo> although a border is missing, but I can add it :)
21:12:42 <-- Mic has quit (Quit: Instantbird 1.1a1pre)
21:19:20 --> Mic has joined #instantbird
21:19:21 * ChanServ sets mode +h Mic 
21:19:50 <Mic> http://img192.imageshack.us/img192/2634/ibbug979.png
21:19:50 --> clokep has joined #instantbird
21:19:50 * ChanServ sets mode +h clokep 
21:21:20 <clokep> So if I had gdate, I have to add it to both the CSRCS and the exports section?
21:22:09 <flo> if you are adding in the purple/libraries/glib folder, yes. With the .h file in the exports of course
21:22:22 <flo> if possible, pick it from the same version as the glib we currently have
21:22:33 <clokep> I did (2.16.1)
21:22:38 <clokep> But I got crazy errors.
21:22:43 <clokep> (I think that's what we're using at least...)
21:23:14 <flo> crazy?
21:23:31 <clokep> = I don't understand.
21:24:20 <flo> Mic: so it seems pastebin 975 is a small improvement? But it would need an aero-specific version I guess :-/.
21:24:26 <flo> clokep: and you can't pastebin them either? ;)
21:24:46 <clokep> flo: I can, but it takes a minute :P http://pastebin.instantbird.com/976
21:25:32 <clokep> Where that is roughly http://git.gnome.org/browse/glib/tree/glib/gdate.c#n61 (although not exactly the same)
21:26:16 <Mic> Yes, it looks a bit better now :)
21:26:23 <flo> and the gdate.h file doesn't define GDate?
21:26:31 <Mic> i'm not sure how we should style that for Aero, though
21:26:38 <flo> Mic: it seems only the color is wrong, but I assume you have changed the color for the other parts for aero
21:27:07 <flo> I'm still struggling with that border on Mac :-D
21:27:07 <clokep> So the Gdate.c that I hvae doesn't include GDate.h...
21:27:49 <flo> can you grep the extracted glib for "gdate.h" to see if somehow it used to be included from another more generic header but where I may have removed a line at the time?
21:27:58 <clokep> flo: Adding it to the top fixed it.
21:28:34 <Mic> The status area on top and the status bar at the bottom are partially transparent, we can't do that for the section headers since they're inside of the opaque richlistbox
21:29:24 <flo> did you mean notificationbox?
21:30:27 <-- igorko has quit (Quit: Instantbird 1.1a1pre)
21:30:35 <-- clokep has quit (Ping timeout)
21:31:22 --> clokep has joined #instantbird
21:31:23 * ChanServ sets mode +h clokep 
21:31:33 <clokep> flo: gdate.h is only in the changelog, glib.h, and Makefiles.
21:33:34 <Mic> No, I didn't but I've seen now that there are two listboxes with labels now.
21:33:43 <Mic> That's not how it initially landed, is it?
21:34:03 <-- ecaron has left #instantbird ()
21:34:22 <flo> clokep: is it in our glib.h?
21:34:28 <flo> you probably need to add it back there
21:35:08 <flo> Mic: the labels don't have the background of the listboxs, there aren't inside them.
21:35:32 <flo> but the notificationbox may have the background you were talking about
21:36:01 <Mic> Yes, I already replaced it with the same as the two other parts on top and bottom have
21:36:48 <-- gerard-majax has quit (Ping timeout)
21:38:29 <clokep> flo: It builds!
21:38:40 <flo> cool :)
21:38:42 <flo> congrats
21:38:57 <flo> how well does it crash? :-P
21:39:21 <Mic> That's what it looks like when contacts section is partially filled: http://img189.imageshack.us/img189/5623/ibbug9792.png (I moved the window over a desktop background image to make the transparency more visible here)
21:40:03 <flo> Mic: sounds like something that should be fixed, doesn't it?
21:41:39 <clokep> flo: Well I can make an account...
21:41:45 <Mic> I already did, flo.
21:42:09 <flo> without breaking the context menu? :)
21:42:32 <Mic> I put a flex attribute on the buddylistbox, so far I haven't noticed anything out of the ordinary
21:43:06 <Mic> hmm, but now I do :(
21:43:33 <Mic> The scrollbar only affects the lower list only now :(
21:43:39 <Mic> Would have been too easy ;)
21:45:17 <flo> you can try adding a <spacer flex="1"/>
21:45:32 <Mic> I'm already at it ;)
21:47:23 <instantbot> clokep@gmail.com added attachment 850 to bug 1021.
21:47:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1021 maj, --, ---, clokep, ASSI, Replace unsupported libpurple QQ with libqq-pidgin
21:48:42 <Mic> The spacer itself doesn't help but it's working when I manually set it's background color
21:48:48 <Mic> *its
21:48:52 <clokep> Bah, my editor made a bunch of white space changes again.
21:48:58 <clokep> /me shakes fist at Komodo.
21:55:46 <Mic> flo: I only added a spacer with an id and styled it from blist.css and used background-color: white for the sake of simplicity.
21:55:56 <flo> clokep: when you say "the tip of the libqq repo", is that a version they have released?
21:56:26 <flo> Mic: does the context menu still work on that area?
21:56:53 <Mic> Yes
21:57:03 <clokep> flo: I don't think there's any tags in the repository.
21:57:14 <clokep> Dinner time though. I'll check later if I can figure out what it is.
21:57:54 <flo> the authors can probably help to know which version is in a shippable state :)
22:02:29 <-- Mic has quit (Quit: Instantbird 1.1a1pre)
22:02:43 --> Mic has joined #instantbird
22:02:43 * ChanServ sets mode +h Mic 
22:02:56 <Mic> Oops, wrong window;)
22:03:45 <Mic> flo: I double checked and it was really the spacer that was below when I opened the context menu there.
22:03:48 <Mic> so yes, it works.
22:06:30 <Mic> The correct background color is -moz-Field by the way, I checked in richlistbox.css
22:06:34 <Mic> Good night now
22:07:09 <Mic> (that is for the Aero theme, of course)
22:08:19 <-- Mic has quit (Quit: Instantbird 1.1a1pre)
22:13:23 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
22:35:53 <-- micahg has quit (Ping timeout)
22:40:07 <instantbot> florian@instantbird.org set the Resolution field on bug 978 to FIXED.
22:40:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=978 nor, --, 1.1a1, florian, RESO FIXED, Tracking bug for enabling "Hiding conversations" by default
22:42:29 <instantbot> florian@instantbird.org set the Resolution field on bug 981 to FIXED.
22:42:32 --> micahg has joined #instantbird
22:42:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=981 enh, --, 1.1a1, florian, RESO FIXED, Adapt context menus for the "hidden conversations" feature (+address localizability issues)
22:43:09 <instantbot> florian@instantbird.org set the Resolution field on bug 990 to FIXED.
22:43:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=990 nor, --, 1.1a1, florian, RESO FIXED, Closing a conversation window with unread messages shouldn't warn if the "hidden conversations" feat
22:43:40 <instantbot> florian@instantbird.org set the Resolution field on bug 1051 to FIXED.
22:43:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1051 enh, --, 1.1a1, florian, RESO FIXED, Sort hidden conversations
22:44:20 <instantbot> florian@instantbird.org set the Resolution field on bug 1027 to FIXED.
22:44:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1027 nor, --, 1.1a1, florian, RESO FIXED, Allow to turn off the "double click to reply to <someone>" feature
22:47:38 <-- clokep has quit (Ping timeout)
22:48:42 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9b9834f033a8 - Florian Quèze - Bug 979 - Fix appearance of section headers in the Contacts window (at least on Mac).
22:48:44 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ed670a422deb - Florian Quèze - Bug 1027 - Allow to turn off the 'double click to reply' feature, r=clokep.
22:48:45 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/5203d4f68899 - Florian Quèze - Bug 978 - turn on the 'hidden conversations' feature by default.
22:48:46 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c1a81cf5a48f - Florian Quèze - Adapt context menus for the 'hidden conversations' feature and address localizability issues of related strings.
22:48:47 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/2c34416f6fb2 - Florian Quèze - Avoid showing buddytooltip above a context menu (workaround a mozilla7 regression).
22:48:48 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/55aed291f827 - Florian Quèze - Bug 1051 - Sort hidden conversations, r=clokep.
22:48:49 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b0fb5e01dcc6 - Florian Quèze - Bug 990 - Closing conversation tabs with unread messages shouldn't warn if the 'hidden conversations' feature is enabled, r=clokep.
22:51:04 <-- devfil has quit (Client exited)
22:51:47 <EionRobb> that's a lot of changes
22:51:52 <EionRobb> that's terrible.  don't do that ;)
22:52:12 <-- douglaswth has quit (Connection reset by peer)
22:53:38 <flo> EionRobb: what's the problem?
22:53:49 <EionRobb> too much code!
22:53:59 <flo> right, we should remove some
22:54:06 <EionRobb> yes.  every second line.
22:54:08 <flo> where's that g_thread file, again? ;)
22:54:15 <EionRobb> touché 
22:54:26 <flo> :)
22:55:22 <flo> more code, but that list of bugs for 1.1 shrinks though https://bugzilla.instantbird.org/buglist.cgi?quicksearch=sw%3A1.1 :)
22:55:55 <EionRobb> if you don't have bugs, you won't have people appreciate it when you fix them and thus won't give you as many donations :)
22:56:23 --> douglaswth has joined #instantbird
22:56:41 * flo should file a bug for adding a "donate" button
22:57:04 <flo> now that we have a bank account!
22:57:08 <EionRobb> oh nice
22:57:11 <EionRobb> in what country?
22:57:15 <flo> France
22:57:20 <EionRobb> interesting
22:57:24 <EionRobb> and a paypal account?
22:57:30 <flo> we should create one
22:57:50 <flo> I assume paypal is the "common" way to make direct donations
22:57:58 <EionRobb> yeah
22:58:04 <EionRobb> seems to be
22:58:10 <flo> I'm also very interested in the indirect ones :)
22:58:13 <EionRobb> or bitcoins :D
22:58:55 <flo> like "install that add-on in your Firefox, and each time you buy something on <some list of only shops>, we will get a small percentage of the money you spend there"
22:59:09 <flo> *online
22:59:45 <EionRobb> oh those ones
22:59:50 <EionRobb> yeah I have one of those for Skype
23:00:01 <EionRobb> people who download skype through my link give me 25% of their purchases
23:00:28 <flo> their skype purchases?
23:00:41 <EionRobb> yeah, buying skype credit, or buying things in the skype store
23:01:32 <flo> well, when I say it's an "indirect donation", I mean the user actually wanted to give us that referral commission. If we get a commission for something that the user does as part of using Instantbird, it's not a donation but just some money we earned
23:01:55 <EionRobb> ah, now I remember who I use: http://www.cj.com/
23:01:56 <flo> have you collected a significant amount of money through this?
23:02:09 <EionRobb> a few hundred every 6 months or so?
23:02:31 <EionRobb> *few hundred NZ dollars
23:02:59 <flo> any idea of the user count to get this?
23:05:16 <EionRobb> lemme just pull up the stats
23:08:12 <flo> how is the skype download link from your website linked to the things people buy on skype after that? Or does it work only if they also create a skype account when downloading?
23:08:16 <EionRobb> I've had 90,000 'absolute unique visitors' in 6 months
23:08:33 <EionRobb> have a look at http://eion.robbmob.com/  there's a link there to 'Download Skype'
23:08:58 <EionRobb> but it could potentailly be a link from within the plugin saying 'Add Skype Credit'
23:09:00 <flo> yes, I saw that link already
23:09:42 <flo> what I'm not seeing is how it knows you need to touch that 25% of things people buy if at the time of clicking the link they only download the free version
23:10:05 <EionRobb> oh, if they click that link, they get a browser cookie
23:10:33 <EionRobb> if they buy anything in the store, it checks if they have the cookie, and I get 25% of their purchase $
23:11:27 <flo> ok :)
23:23:02 <flo> thanks for the information about the Skype affiliate program :)
23:28:28 <flo> good night :)
23:28:30 <-- flo has quit (Quit: Instantbird 1.1a1pre)
23:47:31 --> clokep has joined #instantbird
23:47:31 * ChanServ sets mode +h clokep