#instantbird log on 05 30 2011

All times are UTC.

10:14:04 --> instantbot has joined #instantbird
10:14:04 topic changed by sand.mozilla.org to "Ask questions about Instantbird here. Official website: http://www.instantbird.com. Latest release: 0.2. Read http://blog.instantbird.org/. Nightlies: http://nightly.instantbird.im/ (testing purpose only), IRC logs: http://log.bezut.info/"
10:14:04 * ChanServ sets mode +v instantbot 
10:14:10 <flo> ok to commit that? Not sure who's the author of the changes :-S
10:14:15 <Mic> In short: it fixes all the borders around the conversation in the middle
10:14:19 <Mic> Wait
10:14:28 <flo> "this.base.getAccount" I prefer not duplicating, as it's something I would like to make disappear soon after the release
10:15:24 <Mic> Shall the remove-unnecessary-options-from-facebook-account-preferences-change go in the same patch?
10:16:15 <Mic> It also adds the missing border on top of the input field.. this sort of things
10:16:33 <flo> Mic: "It also adds the missing border on top of the input field.. this sort of things" which is a Win7 only issue, isn't it?
10:16:52 <flo> so yeah, I guess the question is "what was broken before these changes?" :)
10:17:07 <Mic> bah :P
10:17:12 <Mic> I'll look into it
10:17:28 <Mic> I'm back later
10:17:29 <-- Mic has left #instantbird ()
10:18:00 <flo> so basically, none of the facebook options make any sense?
10:26:35 <instantbot> florian@instantbird.org added attachment 664 to bug 532.
10:26:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=532 nor, --, ---, nobody, REOP, Disable "Join chat" for protocol overrides that don't support it (Facebook)
10:33:11 <-- chrisccoulson has quit (Ping timeout)
10:39:26 <instantbot> New Instantbird (UI) bug 808 filed by florian@instantbird.org.
10:39:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=808 enh, --, ---, nobody, NEW, UI to add/remove tags
10:40:21 --> Mic has joined #instantbird
10:40:21 * ChanServ sets mode +h Mic 
10:41:28 <instantbot> New purplexpcom - General bug 809 filed by florian@instantbird.org.
10:41:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=809 nor, --, ---, nobody, NEW, Handle removing a tag from a buddy even when the server ignores our request
10:44:22 <instantbot> New Instantbird (UI) bug 810 filed by florian@instantbird.org.
10:44:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=810 enh, --, ---, nobody, NEW, Add a 'Favorite' special tag
10:45:42 <instantbot> New Instantbird (UI) bug 811 filed by florian@instantbird.org.
10:45:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=811 enh, --, ---, nobody, NEW, List the tags a contact have in the UI
10:55:41 <instantbot> New Instantbird (UI) bug 812 filed by florian@instantbird.org.
10:55:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=812 enh, --, ---, nobody, NEW, Display the character count while typing a tweet
11:01:29 <flo> I'm trying to file everything that's left on the 0.3 roadmap but has no bug, so that we can track what's holding the 0.3 releases by looking only at bugzilla.
11:06:28 --> chrisccoulson has joined #instantbird
11:07:58 <-- chrisccoulson has quit (Client exited)
11:08:12 --> chrisccoulson_ has joined #instantbird
11:09:38 <-- chrisccoulson_ has quit (Client exited)
11:09:42 --> chrisccoulson has joined #instantbird
11:13:31 --> sonny has joined #instantbird
11:17:03 --> Even has joined #instantbird
11:17:03 * ChanServ sets mode +o Even 
11:23:04 --> waynenguyen has joined #instantbird
11:25:48 --> skeledrew has joined #instantbird
11:27:27 <-- Mic has quit (Quit: Instantbird 0.3a3pre)
11:29:29 <-- varuna has quit (Ping timeout)
11:36:10 <-- mepine has quit (Ping timeout)
11:43:39 --> varuna has joined #instantbird
12:14:21 <-- waynenguyen has left #instantbird ()
12:15:37 <flo> anybody has strong feelings for/against integrating the "Reply to Nick" add-on by default?
12:38:47 --> clokep has joined #instantbird
12:38:47 * ChanServ sets mode +h clokep 
12:40:41 <flo> clokep: hello :)
12:40:52 <clokep> Good morning flo.
12:41:19 --> igorko has joined #instantbird
12:41:55 <clokep> deOmega: You cannot set privacy per person for chat in Facebook AFAIK. You're either offline or online for all your buddies.
12:41:58 <-- igorko has left #instantbird ()
12:45:39 <flo> clokep: have you ever noticed any useful advanced option in either the facebook or twitter protocol override?
12:46:02 <clokep> Every option in Facebook should be removed I believe. I don't even think you can choose to connect over SSL or not.
12:46:29 <clokep> You can't change the server, you can't use custom smilies, etc.
12:46:33 <clokep> All the options are bogus.
12:46:42 <clokep> Which is reply-to-nick? ;)
12:46:51 <clokep> (I also missed a bunch of log since instantbot left. :P)
12:47:06 <flo> double click on a bubble to add the <nick>: at the beginning of the text box.
12:47:27 <flo> hmm, I can pastebin what I have :)
12:48:08 <flo> clokep: http://pastebin.instantbird.com/707
12:48:13 <clokep> Ah OK. I'm OK w/ that. I don't personally use it (I have Mook's tab complete add-on in.)
12:48:23 <clokep> Ah, thank you. :)
12:48:47 <flo> if someone said something earlier today, I haven't seen it either ;)
12:56:55 --> Mic2 has joined #instantbird
12:57:00 <Mic2> Hi
12:57:44 <Mic2> I'm not using reply-to-nick either
12:57:56 <Mic2> I wouldn't mind tab-completion though :P
12:57:59 <clokep> In terms of bug 532, the patch looks good, some of the options ofr GTalk might be valid though.
12:58:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=532 nor, --, ---, nobody, REOP, Improve Facebook override protocol: disable "Join chat" option, remove advanced options
12:58:29 <clokep> (You might be able to toggle SSL or not?)
12:59:55 <flo> I wonder if the "connect server" field is still useful there
13:00:11 <-- rikki has quit (Connection reset by peer)
13:00:18 --> rikki has joined #instantbird
13:00:52 <-- clokep has quit (Ping timeout)
13:02:38 <flo> hmm, we will probaby need to remove/fix the facebook/gtalk specific code there: http://lxr.instantbird.org/instantbird/source/instantbird/content/accountWizard.js#316
13:07:02 <flo> probably better to set these proto specific prefs in the getAccount function
13:07:31 <flo> gtalk supports SSL so I don't see why one would want to connect without encryption
13:17:18 <Mic2> 29 bugs are tagged with "0.3" on the whiteboard..
13:17:46 <Mic2> ..11 of them are blocking either beta or final.
13:17:46 <-- skeledrew has quit (Ping timeout)
13:19:09 <flo> bug 718 and 783 are blocking-beta but don't block the string freeze
13:19:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=718 nor, --, ---, nobody, NEW, Error console links to libpurple source code are broken
13:23:19 <instantbot> New Instantbird (UI) bug 813 filed by benediktp@ymail.com.
13:23:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=813 enh, --, ---, nobody, NEW, Allow to copy status text from the "conv-top-info"
13:24:35 <Mic2> Judging by this bug summary I've been digging through the CSS of this bar for too long already :D
13:25:08 <-- rikki has quit (Connection reset by peer)
13:25:16 --> rikki has joined #instantbird
13:25:40 <flo> I'm trying to integrate time bubbles
13:26:00 <flo> and struggling with the localization ;)
13:26:44 <Mic2> clokep and you are using it already, aren't you?
13:27:00 <flo> I've been using it for over a year, but only in english
13:27:23 <Mic2> What needs localization there?
13:27:37 <flo> and as message themes are not localizable, I need to have the localizable strings come from the theme system
13:27:37 <Mic2> I thought it only changes the spaces between bubbles?
13:27:43 <flo> the time units
13:34:16 <flo> hmm, should I be surprised that it works at the first attempt? :-S
13:37:43 --> clokep has joined #instantbird
13:37:43 * ChanServ sets mode +h clokep 
13:38:23 <clokep> Yes I'm using time bubbles flo.
13:39:47 <clokep> flo: Although GTalk supports SSL, there's an overhead so some people might connect w/o it since they'll be able to maintian a connection better?
13:40:38 <clokep> (And I meant Mic2: Yes I'm using Time Bubbles.)
13:40:56 <flo> "they'll be able to maintian a connection better" really? Or is it just what they believe?
13:41:07 <clokep> In terms of the account Wizard stuff, we should definitely change the protocol to use SSL instead of automatically checking it. :)
13:41:21 <clokep> flo: Maybe it's what they believe. I know i Have a better connection to moznet without SSL than with it.
13:41:54 <flo> that may be a server issue
13:43:37 <clokep> A touche.
13:43:41 <clokep> *Ah
13:44:34 <flo> by the way, I maintain a better connection if I add some encryption overhead with an SSH tunnel to a stable and reliably connected server ;)
13:45:16 --> waynenguyen has joined #instantbird
13:45:56 <clokep> :) Fair enough.
13:46:03 <clokep> I withdraw my objection!
13:46:16 <clokep> Is there a bug about having links in status messages? (Is that even possible?)
13:46:31 <flo> we can still revert the change between the beta and final if there are too many upset people
13:46:52 <flo> yes. I think it contains the word "interactive" in its summary
13:46:56 <clokep> Breakfast bbl
13:54:02 <Mic2> flo: are you going to replace the Bubble theme by Time Bubbles theme?
13:54:10 <Mic2> I thought you'd just add it as extra theme
13:54:12 <flo> yes
13:54:31 <flo> I would like to add an option for the feature
13:54:46 <flo> but the option system for message themes is currently more or less inexistant (+ it would require localization :())
13:56:09 <Mic2> If you'll make it a separate theme you'd be able to fix these problems later
14:05:28 <flo> whatever we do, we can fix it later :)
14:11:59 <Mic2> I meant: you can have both already without having to fix localization or options first.. ;)
14:14:45 <flo> I don't need the old one
14:15:11 <flo> the option would be mostly for people with the "OMG change" reaction
14:17:11 <Mic2> https://wiki.instantbird.org/File:IbTags.PNG
14:17:45 <-- clokep has quit (Ping timeout)
14:31:59 <Mic2> hmm, I think I can turn this into a patch later .. currently it lists all the tags between the top of the contact and the buddies and breaks them into new lines if the width is too low to put them all into one line
14:32:08 <Mic2> If there's interest to do it this way
14:45:07 <-- waynenguyen has quit (Ping timeout)
15:10:52 <-- GeekShadow has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:13:14 <flo> it would be nice to be listed on https://www.facebook.com/sitetour/chat.php
15:18:24 --> clokep has joined #instantbird
15:18:25 * ChanServ sets mode +h clokep 
15:18:35 --> GeekShadow has joined #instantbird
15:20:36 <Mic2> Do you think so..? It's only clients that have no 'Facebook Chat' protocol in their lists.. we'd be out-of-place there ;)
15:31:01 <flo> it's still facebook promoting clients, with a nice download link ;)
15:36:23 <instantbot> florian@instantbird.org added attachment 665 to bug 532.
15:36:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=532 nor, --, ---, nobody, REOP, Improve Facebook override protocol: disable "Join chat" option, remove advanced options
15:36:28 <flo> feedback welcome on that patch ;)
15:42:48 <Mic2> bye
15:42:54 <-- Mic2 has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:54:44 --> igorko has joined #instantbird
16:00:42 <-- clokep has quit (Ping timeout)
16:01:13 <flo> arg, I didn't even respect the coding style on that file for the space between the color components :( http://lxr.instantbird.org/instantbird/source/instantbird/themes/blist.css#268
16:07:06 <-- Even has quit (Quit: Instantbird 0.3a3pre)
16:17:23 --> DetroitLibertyPenguin has joined #instantbird
16:17:26 --> clokep has joined #instantbird
16:17:27 * ChanServ sets mode +h clokep 
16:55:56 <-- clokep has quit (Ping timeout)
17:19:31 <-- sonny has left #instantbird ()
17:22:22 --> sonny has joined #instantbird
17:22:39 <-- sonny has left #instantbird ()
17:58:19 <instantbot> florian@instantbird.org set the Resolution field on bug 504 to FIXED.
17:58:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=504 enh, --, 0.3a3, florian, RESO FIXED, Use CSS3
17:59:20 <instantbot> florian@instantbird.org set the Resolution field on bug 532 to FIXED.
17:59:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=532 nor, --, 0.3a3, florian, RESO FIXED, Improve Facebook override protocol: disable "Join chat" option, remove advanced options
18:02:36 <-- varuna has quit (Quit: ChatZilla [Firefox 3.6.16/20110323163108])
18:04:14 <-- flo has quit (Quit: Instantbird 0.3a3pre)
18:04:17 <-- igorko has quit (Quit: Instantbird 0.3a3pre)
18:04:33 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b4caa7cf3f8b - Florian Quèze - Port 'Bug 517097 - make enabling debug symbols more sane' and 'Bug 554024 - switch mozilla-central Linux builds to use -gdwarf-2 instead of -gstabs' changes to mozconfig
18:04:34 <instantbot> files.
18:04:35 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/5e3af713ee10 - Florian Quèze - Make sound for contact events rather than buddy events to reduce pointless noise for contacts with several buddies.
18:04:36 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/1023849b0d65 - Florian Quèze - Bug 532 - Disable advanced options for the Facebook and Google Talk protocol overrides, and disable 'Join Chat' for Facebook.
18:04:37 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b06de022100f - Florian Quèze - Integrate Time Bubbles' features into the default Bubbles message theme.
18:04:38 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/07fab1b2715e - Florian Quèze - Follow-up to bug 649 - purple proxies should not be in the way of JavaScript protocols: override protocols should have the same proxy behavior as their base.
18:04:39 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/3a3d0e64df1b - Florian Quèze - Bug 504 - Use the CSS3 name (without the '-moz' prefix) of the border-radius, box-shadow and background-origin properties.
18:04:40 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0cade9d0f74e - Florian Quèze - [Mac] Disable history in the hidden window to avoid a warning.
18:38:40 <-- micahg has quit (Connection reset by peer)
18:39:33 --> micahg has joined #instantbird
18:46:44 --> Even has joined #instantbird
18:46:44 * ChanServ sets mode +o Even 
18:54:30 --> mokush has joined #instantbird
19:21:23 --> clokep has joined #instantbird
19:21:23 * ChanServ sets mode +h clokep 
19:29:14 --> sonny has joined #instantbird
19:29:52 <-- sonny has left #instantbird ()
19:32:49 <clokep> Uhh...should I be disabling Time Bubbles then? :P
19:32:54 --> linuxwizard has joined #instantbird
19:34:58 <-- clokep has quit (Quit: Instantbird 0.3a3pre)
19:35:04 --> clokep has joined #instantbird
19:35:04 * ChanServ sets mode +h clokep 
19:54:44 --> flo has joined #instantbird
19:54:44 * ChanServ sets mode +qo flo flo 
20:00:13 <flo> clokep: you can switch the preference back to Bubbles, it should continue to display the times correctly tomorrow :)
20:02:21 <clokep> flo: Oh true! I forgot I was technically adding another theme.
20:02:30 <clokep> You guys got a lot done this weekend!
20:03:34 <flo> "weekend"... pfff
20:03:58 <flo> Thursday is a holiday in France though :-P
20:04:41 <clokep> I've been busy. :P
20:04:49 <clokep> Off today though. Gonna start looking at some stuff.
20:06:27 <flo> I cleaned up my todo list, hence the small unimportant commits
20:11:39 <flo> triaging the bugs, especially deciding which things we shouldn't hope to have time do any more is frustrating :-S
20:16:49 <-- mokush has quit (Client exited)
20:39:30 <-- Even has quit (Ping timeout)
20:44:43 --> EionRobb has joined #instantbird
20:48:14 <-- GeekShadow has quit (Quit: The cake is a lie !)
20:50:23 --> sonny has joined #instantbird
20:56:57 <-- clokep has quit (Quit: Instantbird 0.3a3pre)
20:57:21 --> clokep has joined #instantbird
20:57:21 * ChanServ sets mode +h clokep 
21:08:17 <instantbot> clokep@gmail.com added attachment 666 to bug 618.
21:08:18 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 666 on bug 618.
21:08:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=618 enh, --, ---, clokep, ASSI, Basic Jump List support on Windows 7
21:14:17 <flo> clokep: what happens with the default action if the user has both -status <something> and -preferences on the command line?
21:14:42 <clokep> flo: To start Instantbird or with Instantbird already running?
21:14:52 <flo> to start it
21:15:16 <clokep> flo: I get a core not initialized error. :-/
21:15:25 <clokep> I didn't try that one. :(
21:15:38 <flo> ahah, that's not what I expected :-D
21:16:14 <flo> where do you see that error by the way?
21:16:28 <clokep> http://pastebin.instantbird.com/708 is the error
21:16:56 <flo> the error is good :)
21:17:12 <flo> have you added -jsconsole to the command line too or something to see it?
21:17:34 <clokep> C:\Users\clokep\instantbird\objdir-ib-release\mozilla\dist\bin>instantbird.exe -
21:17:34 <clokep> P dev -no-remote -status offline -jsconsole -preferences
21:17:56 <flo> ok :)
21:18:09 <clokep> Is this something I need to change or...?
21:18:37 <clokep> (As in, is it an error in my code or somewhere else.)
21:18:50 <flo> I was wondering if in a case where something else prevented the default action already, your cmdLine.preventDefault =(cmdLine.state != Ci.nsICommandLine.STATE_INITIAL_LAUNCH); would accidentally restore the default action or not
21:19:34 <clokep> Ah, OK.
21:19:48 <clokep> So it's working as it should! :)
21:20:02 <flo> it's failing before that line :-D
21:20:14 <flo> because the 2 options I mentioned are incompatible
21:20:24 <clokep> Right.
21:20:42 <flo> but if someday we add an option to start minimized to the tray (which is not the default action), it may make sense to specify the status at the same time
21:21:24 <flo> I was basically wondering if we should change that line to if (cmdLine.state != Ci.nsICommandLine.STATE_INITIAL_LAUNCH)\ncmdLine.preventDefault = true;
21:22:03 <clokep> Ah, so that way you leave it alone if it's already set?
21:22:44 <clokep> I originally had that and changed it since it seemed simpler the way I have it now, I didn't realize there could be other issues.
21:23:00 <flo> yes
21:23:26 <flo> I'm not sure of how this value is handled
21:24:45 <flo> you put 2 spaces instead of the tab on the new line in jar.mn
21:25:36 <clokep> Bah I just fixed that I thought.
21:25:54 <clokep> Bleh apparently I need to copy and paste a tab to put it into that file.
21:26:02 <clokep> Sorry about that.
21:26:06 <flo> you used a getter for the first description property, and forgot for the next 2
21:26:59 <clokep> Dammit.
21:27:08 --> Mic has joined #instantbird
21:27:08 * ChanServ sets mode +h Mic 
21:27:23 <-- Mic has left #instantbird ()
21:27:24 <clokep> Fixed all of that.
21:27:31 --> Mic has joined #instantbird
21:27:31 * ChanServ sets mode +h Mic 
21:27:53 <Mic> clokep: thanks for taking the localization on bug 620
21:27:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=620 enh, --, ---, benediktp, ASSI, Use Glass on Aero (Windows Vista and 7)
21:28:09 <Mic> hmm, the other bug.. not this one :D
21:28:12 <flo> should it be tested on XP to check that the "Return early if we can't use the jumplist service" code works without causing trouble, or are you already sure of it? :)
21:28:15 <clokep> bug 618?
21:28:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=618 enh, --, ---, clokep, ASSI, Basic Jump List support on Windows 7
21:28:28 <clokep> flo: I believe Mic tested on Windows XP.
21:31:13 <Mic> Maybe with a very early version
21:31:20 <Mic> I certainly haven't in the last week
21:31:29 * clokep doesn't have access to an XP machine anymore.
21:31:33 <clokep> I don't even have a disk with it. :-/
21:31:49 <Mic> I think I'll have access to one tomorrow in a library ;)
21:32:16 <Mic> Do you have a build with jumplist support that you could upload somewhere?
21:32:16 <flo> http://mxr.mozilla.org/mozilla-central/source/widget/public/nsIWinTaskbar.idl#89
21:33:08 <Mic> I think I copied the "available-check from Firefox jumplist handling module
21:33:57 <flo> it's not clear to me why there's an available property on both the nsIWinTaskbar and the nsIJumpListBuilder interfaces
21:34:12 <Mic> http://mxr.mozilla.org/mozilla-central/source/browser/components/wintaskbar/WindowsJumpLists.jsm#203
21:35:15 <clokep> Maybe in case only one is supported? I'm not sure when that would occur though.
21:35:29 <clokep> Mic: I can upload a build if need be. :)
21:35:36 <flo> I'm looking at the code
21:36:06 <flo> the first one is implemented at http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/WinTaskbar.cpp#348
21:36:25 <Mic> Would be great if it's not too inconvenient for you
21:37:17 <clokep> Mic: Of course, just need to find somewhere to do it. :)
21:39:12 <Mic> You can always send it to my ymail adress
21:39:27 <Mic> Yahoo mail can receive attachments upto 25MB if I'm not mistaken
21:40:28 * flo opens the XP VM
21:40:36 <Mic> Or any of the file hosting services .. into a dropbox .. whatever ;)
21:40:39 <flo> it will be faster to just try the code in the error console than to understand it
21:41:17 <clokep> Mic: Yup! Gonna wait until flo's comments first.
21:42:48 <flo> Warning: reference to undefined property Components.classes['@mozilla.org/windows-taskbar;1']
21:42:56 <flo> Source File: javascript:%20Components.classes["@mozilla.org/windows-taskbar;1"].getService(Components.interfaces.nsIWinTaskbar).createJumpListBuilder();
21:43:13 <flo> Error: Components.classes['@mozilla.org/windows-taskbar;1'] is undefined
21:43:45 <flo> of course the Win7 SDK is not installed in my VM... :-/
21:47:21 <flo> Firefox has a check for that: http://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#371
21:48:01 <clokep> Hmm...I see.
21:48:08 <flo> clokep: I think you need a similar code
21:48:46 <clokep> flo: Yes, probably. In the module or in ibCore?
21:49:53 <flo> I would put it in ibCore and move down the Cu.import call (inside the test) so that there's a single ifdef
21:50:01 <flo> but if you prefer in the module, it's fine too
21:51:07 <clokep> OK.
21:53:47 <clokep> flo: http://pastebin.instantbird.com/709 is what I have for ibCore now.
21:54:34 <flo> Nit: for consistency, add a name (WJL_<property name>) to the init and reset methods, or remove it on _getSeparatorItem/_getHandlerAppItem
21:55:34 <clokep> OK.
21:55:43 <clokep> Those have two __ in them, is that for a reason Mic?
21:56:37 <flo> clokep: it's WJL + "_" + name (which starts with an _)
21:56:52 <clokep> Ah, :) Right. I had figured that out last time haha.
21:57:11 <Mic> I'd rename the init method to "set" or something..
21:57:14 <flo> clokep: the pastebined code looks good.
21:57:27 <Mic> (btw)
21:57:41 <clokep> Mic: It's "init" to match the other methods in ibCore.
21:57:47 <flo> wasn't it named like this so that it looks similar to the other methods in ibCore?
21:57:53 <clokep> Yes.
21:58:35 <flo> but Mic has a good point. If reset is supposed to be used by add-ons, you need another method for them
21:59:01 <flo> you need the createJumpListBuilder call only once
21:59:09 <flo> but add-ons may need the following code several times
21:59:24 <clokep> So there should be an init which calls set. ;)
21:59:31 <Mic> That's what I was thinking
21:59:41 <flo> exactly
22:01:03 <clokep> Got it. :)
22:01:24 <clokep> And I should probably sav ethe output of !this.winJumpListBuilder || !this.winJumpListBuilder.available so I can check in both methods?
22:02:56 <flo> you can put the result of winTaskbar.createJumpListBuilder() in a local variable and put it in this.winJumpListBuilder only if winJumpListBuilder.available is true
22:03:23 <flo> and then you need to test only that this.winJumpListBuilder is not null, in both set and reset
22:04:28 <clokep> :) Much cleaner than how I was going to do it!
22:04:34 <flo> there are lots of comments that are sentences that could benefit from receiving a point at their end.
22:04:43 <flo> and after that, I'm out of improvement ideas
22:05:45 <clokep> I'll read over the comments again then and add periods.
22:06:14 <flo> the è in my name doesn't seem to be in UTF8, but I assume you tested it and it compiles, so it really doesn't matter :)
22:07:02 <clokep> In splash.rc?
22:07:07 <Mic> good night
22:07:18 <clokep> 'night Mic.
22:08:12 <-- Mic has quit (Quit: Instantbird 0.3a3pre)
22:08:24 <flo> clokep: yes
22:08:41 <clokep> Yeah, the file wasn't UTF-8, just changed it and it still compiles. :)
22:10:24 <instantbot> florian@instantbird.org denied review for attachment 666 on bug 618.
22:10:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=618 enh, --, ---, clokep, ASSI, Basic Jump List support on Windows 7
22:10:48 <clokep> Posting another one now. just trying to make the diff from the latest to show my changes.
22:11:27 <clokep> Which, isn't Bugzilla able to do that? :P
22:11:54 <-- sonny has quit (Quit: Leaving.)
22:12:03 <flo> because Even still hasn't fixed that
22:12:47 <clokep> Mmhmm.
22:13:02 <clokep> Is there an easy way to make a diff like that?
22:14:20 <flo> interdiff patch1 patch2
22:14:50 <clokep> I'm guessing that's a *nix command? :)
22:15:05 <clokep> Or just that I would need to have committed in between?
22:15:09 <flo> it's part of diffutils I think
22:15:11 <clokep> Wait no...
22:15:13 <clokep> Ah. OK.
22:16:38 <flo> hmm, if you commit the first patch, then unapply it (patch -R) then apply the second one, you can hg diff and see it :-D (and then you hg rollback the useless commit)
22:20:35 <-- linuxwizard has left #instantbird ()
22:22:16 <instantbot> clokep@gmail.com added attachment 667 to bug 618.
22:22:17 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 667 on bug 618.
22:22:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=618 enh, --, ---, clokep, ASSI, Basic Jump List support on Windows 7
22:23:38 <instantbot> clokep@gmail.com added attachment 668 to bug 618.
22:25:48 <flo> that's not an interdiff
22:25:58 <flo> it's a diff of 2 patch files
22:29:09 <flo> you have not changed the cmdLine.preventDefault = line
22:29:31 <flo> another nit: helpInfo : <-- no space between helpInfo and ':'
22:30:12 <clokep> I know it's not a real interdiff. I don't have diffutils.
22:30:23 <clokep> Ah, I didn't realize we had decided to change that one.
22:31:49 <flo> I don't understand your init/set split
22:32:42 <flo> http://log.bezut.info/instantbird/today#m307 it's not like I suggested at least
22:35:24 <clokep> Ahhh, that shouldn't work. I fixed it.
22:36:18 <clokep> Sorry for that. :-/
22:37:24 <flo> what I suggested would look like http://pastebin.instantbird.com/710
22:38:40 <clokep> Yeah what I had changed it to mostly.
22:38:50 <clokep> I read it wrong, sorry.
22:39:00 <clokep> (Plus wrote code that doesn't even make sense.)
22:39:03 <flo> if you feel that we need to avoid double initialization (I don't think so), you can add if (this.winJumpListBuilder) throw Cr.NS_ERROR_ALREADY_INITIALIZED;
22:40:12 <clokep> I had thought of that, although i wasn't sure what to throw exactly. But I don't thik there's really any code that will die if you run it twice.
22:41:46 <flo> and throwing may be destructive if for some reason the second code is ibCore and the first one was a broken add-on ;)
22:42:21 <clokep> Yeah, I think it's fine to just re-init. :) Should I add a comment saying that this is called by the core and add-ons shouldn't call it?
22:49:17 <flo> doesn't hurt :)
22:50:27 <clokep> :)
22:55:38 <flo> I'm attempting to fix the "display character count in twitter conversations" bug
22:56:29 <clokep> Ah, I see. Protocol specific UI is very....bleh. :(
22:58:15 <flo> that part already works
22:58:37 <flo> I'm stuck on handling keyboard events :-D (yes, this is stupid)
22:59:48 <clokep> So it updates when you type? That sounds like an important part. :P
23:00:05 <flo> yeah
23:00:34 <flo> the problem is... it updates before the typed character is taken into account, because adding the character is the default action for the event... so custom handlers are processed first
23:01:25 <flo> we already had the same issue when trying to send typing notifications. We handled that with a setTimeout (bleh... x-()
23:08:16 <clokep> Oh. :-/ Yes. And there's too many ways to edit the text.
23:08:39 <clokep> (Backspace, pasting, adding text, deleting, deleting multiple characters at once.)
23:09:53 <flo> dragging!
23:14:54 <clokep> :(
23:15:00 <clokep> Sounds like set timeout is the way to go.
23:16:07 <flo> O_o why do I have to add a .bind(this) to make something that used to already work work again :-S
23:16:51 <clokep> That's probably not good. :-/
23:18:01 <-- chrisccoulson has quit (Ping timeout)
23:24:10 <flo> bah, it works. Too good to be true :)
23:30:24 <flo> clokep: are you going to attach another diff soon (= before I go to bed)?
23:31:06 <clokep> flo: I can, yes. :) I was reheating some salmon and asparagus. ;)
23:32:06 <clokep> I need to test it. I'll be back.
23:33:12 <-- clokep has quit (Quit: Instantbird 0.3a3pre)
23:33:23 --> clokep has joined #instantbird
23:33:23 * ChanServ sets mode +h clokep 
23:33:24 <-- clokep has quit (Connection reset by peer)
23:34:18 --> clokep has joined #instantbird
23:34:18 * ChanServ sets mode +h clokep 
23:34:53 --> sonny has joined #instantbird
23:41:16 <instantbot> clokep@gmail.com added attachment 669 to bug 618.
23:41:17 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 667 on bug 618.
23:41:18 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 669 on bug 618.
23:41:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=618 enh, --, ---, clokep, ASSI, Basic Jump List support on Windows 7
23:49:06 <flo> clokep: want to review that twitter thing? :)
23:49:11 <instantbot> florian@instantbird.org added attachment 670 to bug 812.
23:49:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=812 enh, --, ---, florian, ASSI, Display the character count while typing a tweet
23:50:56 <-- flo has quit (Input/output error)
23:51:19 <clokep> flo: Sure.
23:51:41 --> flo has joined #instantbird
23:51:41 * ChanServ sets mode +qo flo flo 
23:53:41 <clokep> flo: Where does this._statusTextEnd = left < 200 ? left.toString() : ""; come from?
23:53:44 <clokep> The 200 I mean.
23:53:53 <flo> magic :)
23:54:12 <flo> I don't want to display huge numbers in the status bar
23:54:20 <flo> and I would like in the future if we could set the values for other protocols too
23:54:38 <flo> (on IRC I think you receive it from the server at connect-time)
23:55:10 <flo> a comment above/around it may be a good idea
23:56:09 <flo> clokep: when should this.reset be called exactly?
23:56:14 <clokep> Yes, there's one for IRC...although for IRC it's the command + user name + a few spaces + what you wrote. ;) So it's awfully complicated.
23:56:51 <clokep> flo: I call this.reset to delete any current jump list that is set for Instantbird (which generally will just clean up any garbage left from a previous run, etc. if we ever change what the jump list does)
23:57:17 <flo> shouldn't it be called before each set call?
23:57:34 <clokep> Hmmm...let me think.
23:57:40 <flo> in my pastebined example the .reset call was inside the set method rather than init
23:58:16 <clokep> Well, you can actually add multiple jump lists, so not necessarily. But I guess it should probably be in the set method.
23:59:20 <clokep> flo: I'd r+ that with a comment saying the 200 is magic to prevent large numbers from showing. :) (And I think I'd increase it to at least a number over 255 since I think that's the default IRC one.)
23:59:57 <flo> ah, I thought it was much more on IRC