#instantbird log on 04 21 2011

All times are UTC.

00:16:18 <-- clokep has quit (Quit: Instantbird 0.3a3pre)
00:16:22 --> clokep has joined #instantbird
00:16:22 * ChanServ sets mode +h clokep 
00:30:48 <-- skeledrew1 has quit (Ping timeout)
01:35:02 --> mepine has joined #instantbird
02:15:38 <-- clokep has quit (Ping timeout)
02:17:32 --> Mook has joined #instantbird
02:22:10 --> clokep has joined #instantbird
02:22:10 * ChanServ sets mode +h clokep 
02:27:58 <-- clokep has quit (Quit: Instantbird 0.3a3pre)
03:51:05 --> micahg has joined #instantbird
03:52:56 --> linuxwizard has joined #instantbird
03:54:25 <-- Mathnerd314 has quit (Ping timeout)
06:56:14 <-- Mook has quit (Quit: z)
06:57:34 <-- micahg has quit (Ping timeout)
06:58:13 --> micahg has joined #instantbird
07:23:42 --> Even has joined #instantbird
07:23:43 * ChanServ sets mode +o Even 
08:10:33 <-- linuxwizard has left #instantbird ()
08:26:52 <-- micahg has quit (Ping timeout)
08:27:24 --> flo has joined #instantbird
08:27:24 * ChanServ sets mode +qo flo flo 
08:27:52 <flo> hello :)
08:41:34 --> micahg has joined #instantbird
08:42:54 <-- sabret00the_ has quit (Quit: Leaving)
08:49:55 --> sabret00the has joined #instantbird
09:35:09 --> waynenguyen has joined #instantbird
09:39:20 --> jdt has joined #instantbird
09:42:56 <-- chrisccoulson has quit (Quit: Ex-Chat)
09:45:22 <-- waynenguyen has quit (Ping timeout)
09:51:06 --> chrisccoulson has joined #instantbird
09:55:45 --> GeekShadow has joined #instantbird
09:59:32 --> waynenguyen has joined #instantbird
10:01:37 --> varuna has joined #instantbird
10:16:02 --> clokep has joined #instantbird
10:16:02 * ChanServ sets mode +h clokep 
10:33:14 --> sonny has joined #instantbird
10:55:44 <-- clokep has quit (Quit: Instantbird 0.3a3pre)
11:19:39 <-- mepine has quit (Quit: 隨緣也)
11:38:24 --> clokep_work has joined #instantbird
11:38:24 * ChanServ sets mode +h clokep_work 
11:38:39 <-- varuna has quit (Quit: ChatZilla [Firefox 3.6.16/20110323163108])
11:38:46 <clokep_work> Hello.
12:13:33 --> tymerkaev has joined #instantbird
12:36:07 --> skeledrew has joined #instantbird
13:01:34 <-- skeledrew has quit (Ping timeout)
13:15:42 <-- clokep_work has quit (Connection timed out)
13:30:55 --> clokep_work has joined #instantbird
13:30:55 * ChanServ sets mode +h clokep_work 
13:36:44 <-- DGMurdockIII has quit (Ping timeout)
13:44:33 <-- sonny has quit (Connection reset by peer)
13:46:00 * flo wonders if bug 760 should be resolved as WFM now or later :-D
13:46:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=760 nor, --, ---, nobody, UNCO, Growl Notifications
13:46:35 <clokep_work> Is it probably just a problem w/ Growl misconfiguration?
13:46:58 <flo> or a mozilla bug that annoys me
13:47:11 <clokep_work> Ah, yes. Just read your comment. That sounds awfully dumb.
13:48:28 <flo> I can't find anything related in mozilla's bugzilla though :(
13:49:34 <clokep_work> Could ask in #developers whether that's the correct behavior. ;)
13:49:39 <flo> or maybe the OS just doesn't allow raising a window above the active one, to not interrupt users. (in that case, the focus call should be done before the growl popup is removed for it to work)
13:50:13 <clokep_work> flo: https://developer.mozilla.org/en/DOM/window.focus
13:50:31 <clokep_work> "window isn't guaranteed to be frontmost before this method returns"
13:50:48 <clokep_work> Although that vaguely implies it will eventually be frontmost. ;)
13:51:11 <flo> and also, that documentation is targeted at content authors
13:51:24 <flo> it could behave differently on a XUL chrome window
13:51:24 <clokep_work> True.
13:55:09 <clokep_work> I give up then. :D
14:02:21 <flo> just for information, changing this doesn't change the behavior at all: http://pastebin.instantbird.com/656
14:02:49 <clokep_work> I'd guess it's an OS thing then not allowing an application to steal focus then.
14:04:47 <flo> by the way, the OS where system notifications were not clickable was ubuntu with the first version of NotifyOSD.
14:06:28 <clokep_work> Alright.
14:11:19 <flo> the OS-specific code seems to be: http://mxr.mozilla.org/mozilla-central/source/widget/src/cocoa/nsCocoaWindow.mm#1417
14:17:01 <clokep_work> I see it's trying to set the z-level. ;)
14:18:46 <flo> the SendSetZLevelEvent part seems like dead code to me when reading the comment at http://mxr.mozilla.org/mozilla-central/source/view/src/nsViewManager.cpp#979
14:19:18 <flo> I think the [mWindow makeKeyAndOrderFront:nil]; is what's supposed to focus the window
14:19:19 <-- Even has quit (Quit: Instantbird 0.3a3pre)
14:19:30 <flo> the documentation from Apple says "Moves the window to the front of the screen list, within its level, and makes it the key window; that is, it shows the window."
14:21:34 --> clokep_ has joined #instantbird
14:22:32 <clokep_> So it's possible you've found a bug then.
14:24:24 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:27:06 <flo> from some of the google results for that method not working, it seems there should be [NSApp activateIgnoringOtherApps:YES]; before
14:29:20 <flo> http://mxr.mozilla.org/mozilla-central/source/widget/src/cocoa/nsMacDockSupport.mm#64 hmm, interesting
14:30:40 <clokep_> So you'd need to focus it, and if on Mac focus the application.
14:31:14 <flo> yes
14:31:21 <flo> we had just removed the last ifdef in that file recently :(
14:31:56 <clokep_> :(
14:32:17 <clokep_> So that bug just went from WFM to a real bug, eh? :)
14:32:48 <flo> maybe I can fix it even though it works for me? :-D
14:33:14 * flo was about to say "bah, it doesn't work"
14:33:26 <flo> but I have that in the terminal :-D JavaScript Error: "Cc is not defined" {file: "resource:///modules/imWindows.jsm" line: 105
14:35:02 <flo> and now it does work :)
14:35:17 <clokep_> :)
14:35:51 <flo> http://pastebin.instantbird.com/657
14:37:20 <flo> I also see WARNING: NS_ENSURE_TRUE(window) failed: file /Users/florian/buildhg/hg.instantbird.org/mozilla/toolkit/components/alerts/src/mac/mozGrowlDelegate.mm, line 94 in the terminal
14:37:29 <clokep_> Why'd you move the imWindows.jsm? Whats the difference between EXTRA_JS_MODULES and EXTRA_PP_JS_MODULES?
14:37:30 <flo> that may be another cause of brokenness
14:37:42 <flo> PP = PreProcessed
14:37:47 <clokep_> Ohhhh, OK.
14:37:50 <clokep_> r+ then. :)
14:38:35 <clokep_> My next question is why are Objective-C files using .mm as an extension. :P
14:40:53 <flo> ok, that warning is just noise
14:41:05 --> varuna has joined #instantbird
14:41:17 <flo> the comment above the method says "Returns the DOM window that owns the given observer in the case that the observer is implemented in JS and was created in a DOM window's scope."
14:41:30 <flo> our observer is in a JS module, not a DOM window, so it's expected that the window is null
14:42:06 <clokep_> So that's an expected warning then.
14:42:43 <flo> there's still a coding error
14:42:44 <flo> http://mxr.mozilla.org/mozilla-central/source/toolkit/components/alerts/mac/mozGrowlDelegate.mm#52
14:42:59 <flo> at lines 66 it returns null if the object is not implemented in JS
14:43:14 <flo> and at line 94 it warns if it's in JS but not in a window...
14:45:37 <clokep_> So in the case that it's JS and not in a window it should just return nothing?
14:45:44 <instantbot> florian@instantbird.org added attachment 594 to bug 760.
14:45:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=760 nor, --, ---, florian, ASSI, Growl Notifications
14:45:47 <flo> just return null, yeah
14:46:24 <flo> clokep_: https://bugzilla.instantbird.org/attachment.cgi?id=594&action=edit if you want to r+ :)
14:47:00 <flo> uh, that was supposed to be a quick comment to close the report, and more than an hour later I'm still on that bug :-S
14:51:29 <clokep_> Strange...that actually opens kdiff for me or whatever comes w/ TortoiseSVN.
14:53:26 --> Andrey has joined #instantbird
14:57:25 <-- DetroitLibertyPenguin has left #instantbird ()
14:58:14 <instantbot> clokep@gmail.com granted review for attachment 594 on bug 760.
14:58:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=760 nor, --, ---, florian, ASSI, Growl Notifications
15:00:45 --> skeledrew has joined #instantbird
15:02:25 --> DetroitLibertyPenguin has joined #instantbird
15:02:51 <-- DetroitLibertyPenguin has left #instantbird ()
15:03:52 --> Tonnes_ has joined #instantbird
15:03:54 <clokep_> So, sorry if I'm being thick, but did we decide that the this.contacts[index - 1] from the buddy list was a real bug or no? Was it a trivial fix or should I be filing a bug for that?
15:03:59 <-- Tonnes has quit (Ping timeout)
15:04:05 * Tonnes_ is now known as Tonnes
15:04:07 <flo> ahah
15:04:13 --> DetroitLibertyPenguin has joined #instantbird
15:04:36 <flo> I thought about it less than 10s before seeing your message "I should include that trivial fix at the same time as pushing that new patch" :)
15:06:09 <clokep_> :)
15:08:51 <clokep_> So Disgby was bought by another company.
15:09:07 <flo> http://pastebin.instantbird.com/658 r?
15:09:09 <flo> oh really?
15:09:19 <clokep_> flo: http://blog.digsby.com/archives/1819
15:09:21 <flo> too bad we couldn't by it ourselves :-D
15:10:17 <clokep_> Yes, r+. Although I'm pretty sure you don't need one for that fix. :P
15:10:30 <clokep_> That won't mess things up with offline contact sorting though, right?
15:10:40 <clokep_> (I.e. if you show offline contacts.)
15:10:49 <flo> no
15:10:53 --> wesj has joined #instantbird
15:11:07 <flo> it will just ignore the notification if it's for a contact not currently displayed by that group
15:11:17 <flo> "We are removing all bundled offers shown during installation of Digsby. "
15:13:15 <flo> too bad we can tell all those "Linux version!" digsby enthusiasts to try Instantbird ;)
15:13:43 <clokep_> It's what I did w/ my friend that uses Digsby.
15:13:53 <clokep_> Also how I heard about the announcement btw. :) They messaged all their users.
15:14:39 <clokep_> Also had a conversation about why he thinks Digsby > Instantbird...I don't remember htem though except not being able to block people on Instantbird.
15:15:15 <flo> their marketing is definitely better
15:16:35 <clokep_> Yes...though people thinking it's made by Mozilla might help us out a bit.
15:18:21 <clokep_> Tagged will probably come out w/ a proprietary protocol as part of Digsby now. ;)
15:18:47 <flo> I'd never heard of Tagged before
15:18:59 <-- Andrey has quit (Quit: )
15:19:14 <clokep_> I'd herad of it, didn't know what it was though. Wikipedia'd it. :)
15:19:20 <-- DetroitLibertyPenguin has left #instantbird ()
15:20:05 <flo> "Financial terms of the acquisition were not disclosed." boo, the interesting part :(
15:20:46 <clokep_> Yeah, I thought that too. :-/
15:20:52 <clokep_> Maybe they'll open-source it. :P
15:21:06 <-- rikki has quit (Connection reset by peer)
15:21:14 --> rikki has joined #instantbird
15:21:19 <clokep_> So now that unknown data being beamed off to Digsby is going to go to Tagged...
15:22:13 <flo> when I go to "www.tagged.com", I see a huge translation mistake
15:23:17 <flo> "Get Tagged!" (I guess) is translated with "Obtenir Tagged !" (Obtain/acquire tagged), which doesn't make much sense...
15:23:32 <clokep_> No...definitely not.
15:23:43 <flo> I said "huge" because it's with a big font
15:23:50 <clokep_> :)
15:24:51 <flo> actually, I only see that, 2 Meetic ads (aren't they competing by the way? :)) and a form requesting an awful lot of data and to read the terms of service, without even knowing what I'd get :-D
15:25:41 <-- rikki has quit (Connection reset by peer)
15:25:48 --> rikki has joined #instantbird
15:29:53 <flo> (wikipedia) "As of April 2011, Alexa rankings suggest the popularity of Tagged peaked in early 2009 and has been declining since"
15:33:02 <clokep_> Mmhmm. But they say they have an overlap of 80% with Facebook...I doubt that.
15:33:17 <flo> that just means 80% of their users also have a facebook account
15:33:21 <flo> not the other way around ;)
15:37:15 <clokep_> Touche.
15:37:40 <clokep_> So apparently we need to change some strings from Group > Tag, if you saw. :)
15:39:49 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/86841bb8b4c9 - Florian Quèze - Bug 760 - [Mac only] Clicking a growl notification should activate the application, r=clokep.
15:39:50 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/01e84d49d021 - Florian Quèze - Avoid a JS error when libpurple sends a display-name-changed signal for an offline buddy, r=clokep.
15:40:17 <flo> it's just the "move to" thing that is confusing :)
15:44:01 <clokep_> Yes, I suppose. :)
15:53:01 --> igorko has joined #instantbird
15:54:49 <clokep_> flo: bug 760...he wasn't on a nightly to start w/ so...not sure he'll switch to one. :)
15:54:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=760 nor, --, 0.3a3, florian, ASSI, Clicking a growl notification should activate the application
15:55:01 <flo> why not?
15:55:06 <flo> he can read english :-P
15:55:21 <igorko> hi
15:55:31 <flo> hello :)
15:55:37 <igorko> will buddy status be integrated in 0.3?
15:55:38 <clokep_> Haha, maybe. :)
15:56:11 <flo> what's that?
15:56:32 <igorko> buddy status?
15:56:43 <igorko> notifications in tray
15:56:47 <clokep_> (My reply was to flo from above.)
15:57:13 <igorko> and i would be nice also to recieve messages in tray
15:58:05 <clokep_> igorko: I found out yesterday you can receive messages in the tray!
15:58:13 <clokep_> There's an option for it in the prefs.
15:58:20 <igorko> really? lol
15:58:36 <clokep_> And Buddy Status is Mic's extension...it hasn't been updated for Moz2, or is lost on hi sold computer or something.
15:59:09 <-- skeledrew has quit (Ping timeout)
15:59:15 <igorko> send me something in 10 seconds
15:59:18 <flo> clokep_: was it for moz2 or for the new js-blist?
15:59:44 <clokep_> flo: I think you're right, the new js-blist and notifications...I have a version that works on Moz2 I think.
15:59:44 --> skeledrew has joined #instantbird
16:03:17 <clokep_> igorko: So I think that that means "no" it won't be included. ;)
16:06:06 <igorko> i used it in 0.3a1 as i remember
16:06:12 <igorko> now it doesn't work
16:06:38 <clokep_> Yeah, it's from the js-blist / contact support / new notification messages.
16:08:44 <clokep_> Mic also said he had a ton of updates from that version (I think he said buddy icon support) that he doesn't want to rewrite...but hasn't recovered his crashed computer yet.
16:11:08 <flo> clokep_: I just commented in bug 759. I hope it helps, even though it doesn't really help to figure out what the next step is :-/.
16:11:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, nobody, NEW, Reorganize purplexpcom
16:13:10 <flo> ah, I should have pushed the patch from bug 754 at the same time :-/
16:13:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=754 nor, --, ---, clokep, ASSI, Restart button on notification bar of add-ons window does not work
16:13:23 <clokep_> flo: I'll think about it a bit more and maybe come up w/ a plan.
16:13:41 <clokep_> Would it make sense to do bug 759 or bug 758 first? :-D
16:13:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=759 min, --, ---, nobody, NEW, Reorganize purplexpcom
16:13:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=758 min, --, ---, nobody, NEW, Clean up jsProtoHelper
16:13:45 <clokep_> Or maybe all at once in a monster patch?
16:14:06 <flo> either way works.
16:14:18 <clokep_> And that would require three top level directories... instantbird/ purple/ and mozillaim/ ? :P
16:14:31 <flo> if you do 758 first, the new files will be temporarily in a bad place but not worse than the current state
16:14:45 <clokep_> Right, but 758 is easier I think. :)
16:14:58 <clokep_> Easier as in...I more of know what to do...
16:15:07 <flo> but more likely to break add-ons
16:16:14 <clokep_> What add-on uses jsProtoHelper except mine?
16:16:20 <flo> omegle
16:16:25 <flo> ok, we don't care :)
16:16:26 <clokep_> Ah, right. :)
16:16:46 <clokep_> OK let me rephrase...who uses jsProtoHelper besides you and me? :P
16:16:55 <clokep_> (Preferences uses it and Twitter uses it too...)
16:17:02 <flo> maybe varuna will? :)
16:17:34 <clokep_> Maybe. :) I'm acutally using my own right now anyway...so I don't care if we break the one in core. :)
16:17:51 <flo> http://lxr.instantbird.org/instantbird/search?string=jsProtoHel
16:18:01 <flo> you forgot gtalk, facebook, jsTest and imConversations.js
16:18:20 <clokep_> Ohh...I forgot overrides use it.
16:18:25 <flo> (the latter just uses ClassInfo)
16:18:31 <clokep_> I didn't realize imConversations does...
16:18:38 <clokep_> Ah, OK. :) ClassInfo...
16:18:47 <flo> it's even the first motivation for the split ;)
16:18:49 <clokep_> Have a suggestion for a name instead of XPCOMUtils then?
16:18:57 <flo> no :-/
16:19:27 <flo> my first thought was imXPCOMUtils (as we have imServices that reexports Services already), but the things we add have really nothing to do with IM...
16:19:29 <clokep_> ibXPCOMUtils.jsm? :-D
16:19:54 <clokep_> We could just do ibUtils.jsm or something.
16:20:08 <flo> isn't that reusable? :-P
16:20:33 <clokep_> What do you mean?
16:21:03 <flo> in the "im" bucket rather than "ib" :-D
16:21:25 <flo> by the way about mozillaim, wouldn't we be sued by AOL like they did for Gaim ? :-D
16:21:43 <clokep_> Ohhhh. Haha, yes. :)
16:22:04 <clokep_> I noticed that too. :) immozilla :P
16:22:23 <flo> mozim ?
16:22:42 --> sonny has joined #instantbird
16:22:52 <clokep_> mozim is reasonable.
16:23:07 <clokep_> We could even just do Utils.jsm and not have a prefix.
16:23:29 <flo> (in french "immo" is a shortened version of "immobilier" (= Real Estate))
16:25:26 <clokep_> Also doXHRequest has always been a funky name to me. :) But I can't think of a better one...
16:25:38 <flo> HTTP
16:25:56 <clokep_> That's it, just HTTP?
16:25:58 <flo> I wanted at some point to change that into an HTTP objects with various methods (.get .post, ...)
16:26:10 <clokep_> Ah, more in line w/ my socket type implementation?
16:26:35 <clokep_> (Meaning...so you could create an HTTP object then get, post, etc. with it)
16:26:57 <flo> it would be even nicer if you could avoid the new keyword :)
16:28:35 <clokep_> Well...I wil not be tackling that in this bug. :)
16:28:54 <clokep_> But I can move it to an http.jsm file if you want.
16:29:29 <flo> deciding file names has an incredible potential for bikeshedding discussions ;).
16:30:19 <clokep_> Yes, why I'm asking you and just going to go w/ whatever you say. :-D
16:30:47 <flo> nah, that's too easy :-P
16:36:48 <flo> clokep_: I just gave Mic and you write access to the addons repository in addition as to the experiments repository
16:36:56 <flo> (same login/password)
16:38:02 <clokep_> flo: Cool. Thanks. What am I doing w/ it? :)
16:38:51 <flo> I don't know. Just I don't want to be pushing things like bug 752 myself
16:38:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=752 min, --, ---, clokep, NEW, Double-clicking on system-tray icon also launches another icon.
16:39:46 <clokep_> OK. :)
16:39:58 <clokep_> Doesn't necessarily even need to go in there, just figured I'd make a patch to attach.
16:41:01 <flo> it's a good place to not lose our stuff ;)
16:42:34 <clokep_> True. :)
16:42:46 <clokep_> Plus another example for a restartless add-on.
16:43:29 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 591 on bug 752.
16:43:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=752 min, --, ---, clokep, NEW, Double-clicking on system-tray icon also launches another icon.
16:45:36 <clokep_> SO I found a better way to follow all bugs than the newsgroup was to stalk to Google Group's bugzilla account. :)
16:45:47 <clokep_> That way I don't get the same email twice.
16:45:49 <clokep_> And I can still control what I see.
16:46:41 <flo> ah? I didn't know watching a global watcher would send all the bugmail
16:47:07 <clokep_> I think it will at least. I'm still testing it out. :)
16:47:58 <flo> if I remember well, the watch feature is described as "send you the emails you would received with your current email settings if you were that person"
16:48:10 <clokep_> Yes. That's almost it word for word.
16:50:01 <clokep_> Well. Ill let you know how it goes. :0
16:57:27 <clokep_> flo: Rebug 757, that's what I think it should be too actually.
17:03:57 <-- GeekShadow has quit (Quit: The cake is a lie !)
17:05:37 <-- wesj has left #instantbird ()
17:20:16 <-- waynenguyen has quit (Quit: Instantbird 0.2)
17:20:30 --> waynenguyen has joined #instantbird
17:30:26 <instantbot> New purplexpcom - General bug 761 filed by clokep@gmail.com.
17:30:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=761 nor, --, ---, nobody, NEW, JS-Socket fails to properly handle SSL errors
17:31:48 <clokep_> varuna: ^ ^ what we discussed a few days ago.
17:33:47 <varuna> hey
17:33:50 <varuna> just saw
17:34:18 <varuna> :)
17:34:19 <clokep_> Just filed it so that I don't forget about it. :)
17:34:26 <varuna> k :)
17:51:47 <-- chrisccoulson has quit (Quit: Ex-Chat)
17:54:34 --> chrisccoulson has joined #instantbird
17:59:52 <clokep_> So...Linux compiles Instantbird in 15 minutes and Windows in 53? That might be enough to get me to dualboot my old laptop. :)
18:00:36 <flo> Even cheats on the linux slave with ccache which saves time
18:00:52 <flo> but 2-3 times faster is likely true
18:02:07 <clokep_> Ah, I see. But I could do that too, no? :)
18:02:15 <flo> sure
18:07:36 <-- varuna has quit (Quit: ChatZilla [Firefox 3.6.16/20110323163108])
18:14:25 <flo> clokep_: I'm looking at bug 741 again. I'm not sure I remember the comments I had. There was the problem of keeping the pending requests in an array to be able to cancel them. Was there anything else?
18:14:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=741 nor, --, ---, clokep, ASSI, Fetch the tweets with @ mentions and tracked keywords when connecting a twitter account.
18:14:46 <clokep_> No, I think that was it.
18:14:46 <-- sonny has quit (Connection reset by peer)
18:15:01 <flo> we should really lxr-index the irc logs :)
18:15:13 <clokep_> Google updates so rarely. :(
18:15:32 <flo> it would probably do better with a good robots.txt file
18:17:50 <clokep_> I couldn't find out conversaiton about it either. Not with my brief keyword search at least. :)
18:20:14 <flo> or we could index the logs locally :)
18:20:24 <flo> that would actually be much better I think :)
18:21:11 <clokep_> locally...meaning in Instantbird?
18:21:14 <clokep_> Yes, we should do that. :)
18:21:24 <clokep_> Also make some way to share logs so we can get missing chunks. :P
18:21:45 <flo> yeah :)
18:21:57 <flo> P2P log sharing? :)
18:22:29 <clokep_> Oh oh oh! I know how to do it...
18:22:38 <clokep_> I'll make up some CTCP commands! :-D
18:23:16 <clokep_> PRIVMSG :GETLOG <format> <timestamp start> <timestamp end>
18:23:28 <flo> that's another very complicated thing to do ;). (how do you handle the cases where the messages didn't arrive in the same order? The cases of bad timestamps (if the local clock of someone is way wrong)? ...)
18:23:42 <clokep_> Shhh...
18:23:46 <clokep_> IRC is bad enough as is...
18:24:23 <flo> if someone's clock is as wrong as it was when the logs were written, you can fix it with a CTCP time request :).
18:24:35 <flo> if the clock is back on time, the data is lost :-D
18:24:40 <clokep_> Hahah, yes. You can. :)
18:24:53 <clokep_> And the response is a DCC SEND request with the file. :)
18:26:22 --> linuxwizard has joined #instantbird
18:26:30 <flo> so we decided none of the timeline requests are fatal, right?
18:26:48 <clokep_> You suggested home timeland is fatal.
18:26:53 <clokep_> *timeline.
18:26:57 <clokep_> I don't know what a timeland is...
18:27:09 <flo> raaah, I always have bad ideas to suggest :(
18:27:32 <-- chrisccoulson has quit (Quit: Ex-Chat)
18:28:33 <clokep_> Could leave it for a follow up.
18:28:42 <clokep_> I think the easiest way might be to have two different error functions.
18:28:55 <clokep_> A fatal one cancels all the other requests, disconnects, etc.
18:29:01 <clokep_> The nonfatal one just throws a warning.
18:29:13 <flo> we need that anyway for the errors in auth requests
18:29:42 <flo> but if we have some fatal timelines, we need a third onError function to still remove that request from the pending request array before canceling the others
18:29:52 <flo> hmm, or maybe we can cancel it again and it won't matter
18:29:58 --> DGMurdockIII has joined #instantbird
18:30:59 --> chrisccoulson has joined #instantbird
18:31:03 <-- tymerkaev has quit (Ping timeout)
18:31:12 <-- rikki has quit (Connection reset by peer)
18:31:19 --> rikki has joined #instantbird
18:31:26 <clokep_> I was hoping for being able to cancel ita gain and it wouldn't matter, but didn't look that far into it.
18:39:33 <flo> http://pastebin.instantbird.com/659 completely untested for now
18:41:05 <clokep_> I left a dump in there btw.
18:41:09 <clokep_> If you didn't add that. :)
18:41:11 <flo> I saw that
18:42:30 <clokep_> That looks much more elegant than mine.
18:42:42 <flo> come on, it's almost the same!
18:43:03 <-- rikki has quit (Connection reset by peer)
18:43:10 --> rikki has joined #instantbird
18:46:35 <flo> http://pastebin.instantbird.com/660 :'(
18:47:10 <flo> it's the same as https://hg.instantbird.org/instantbird/rev/887d961a59fc, but worse :(
18:52:18 <flo> clokep_: you haven't tested this (the track keyword part at least), right?
18:57:04 <clokep_> flo: Yes, I tested that.
18:57:15 <flo> and did it display anything?
18:57:25 <clokep_> Yes, I tracked Instantbird and it worked.
18:57:39 <clokep_> flo: What's with the malformed XML? You got that error?
18:57:49 <flo> it's unrelated
18:57:56 <flo> it's the string XML parsing again
18:57:58 <clokep_> Oh I see.
18:58:00 <flo> *strict
18:58:02 <clokep_> Another XML parsing error.
18:58:13 <clokep_> That's bad though, we can't try to fix all of them. There needs to be a better way. :-/
18:58:41 <clokep_> (besides .replace(/&/g, "&amp;") :P)
18:58:46 <flo> but what makes me believe you haven't tested the query is that the results are in a JSON string that can't be parsed as the other results
18:59:16 <flo> clokep_: that & amp ; was displayed as just & here :(
19:01:02 <flo> got to go. Back soon.
19:01:03 <-- flo has quit (Quit: Instantbird 0.3a3pre)
19:01:44 <clokep_> flo: I'm like 90% sure I tested it on the track word of Instantbird, I remember getting back a result and having random people's stuff show up in my timeline.
19:04:54 --> Even has joined #instantbird
19:04:54 * ChanServ sets mode +o Even 
19:05:24 <clokep_> I suppose it's possible I was getting a different result or that I didn't test it then. Sorry if that's the case. :(
19:17:54 --> flo has joined #instantbird
19:17:54 * ChanServ sets mode +qo flo flo 
19:20:38 <flo> it's possible I'm wrong too :)
19:21:34 <flo> the result I have, one beautified, is: http://pastebin.instantbird.com/661
19:22:07 <clokep_> I also remember testing it just in Firefox and got something nice.
19:23:06 <clokep_> Hmmm...
19:23:48 <flo> s/one/once/
19:23:51 <clokep_> Which part of that doesn't it like.
19:26:02 <flo> I'll tell you for sure once I get something that works ;)
19:27:17 <clokep_> :)
19:30:21 <clokep_> Bleh do you just need to grab the results part of that structure?
19:30:50 <flo> I've already tried using the results part, and mapping user to from_user, but it still doesn't work
19:30:57 <flo> I've probably an error in the code somewhere else :)
19:32:27 * clokep_ also thinks it's possible they've changed their API. ;)
19:34:05 <flo> isn't the problem rather that they haven't changed it to harmonize their crap between the REST and search APIs? ;)
19:35:14 <clokep_> Yeah, probably. :)
19:36:10 * clokep_ writes an angry letter to them.
19:36:41 <flo> ahah
19:36:47 --> igorko1 has joined #instantbird
19:37:33 <-- igorko has quit (Ping timeout)
19:40:46 <clokep_> Found it?
19:42:23 <flo> I found one error
19:42:34 <flo> but there's still something wrong somewhere as the displayed conversation is broken
19:47:16 <flo> ah, it's .user.screen_name on regular tweets
19:53:45 <flo> what's the best way to show the error in the console?
19:53:50 <flo> when a timeline request fails?
19:53:57 <flo> just keep the "// TODO" comment? :-D
19:54:08 <clokep_> Yes, until one of us redoes the logger.
19:54:17 <clokep_> Or maybe a reportError?
19:54:22 <clokep_> But it should really be a warning.
19:54:30 <clokep_> Could also be a system message?
19:55:22 <flo> in a conversation we don't have yet?
19:56:10 <clokep_> Yes. :-D
19:56:49 <flo> grrr, it doesn't seem ready yet :(
19:57:12 <flo> I have all the results from the track keyword, and then the results from the @mentions and the home_timeline together
19:58:21 <flo> hmm, do you have a test twitter account that you could post uninteresting messages in for me?
19:58:43 <clokep_> No.
19:58:48 <flo> I would need a message with an @mention of testib, and when mentionning "instantbird" my tracked keyword), to see if they are sorted correctly
19:58:52 <clokep_> I could post it on my real one though. Not that many people feel me. :)
19:59:04 <clokep_> One of each?
19:59:07 <flo> yes
19:59:13 <flo> I need to know from which request I received it
19:59:34 <flo> but if it's to post crap on a real account I can do it on mine too ;)
20:00:04 <clokep_> Touche. :)
20:00:11 * clokep_ should really make a clokep account for this stuff.
20:01:40 <flo> hmm, I tweeted "hey @testib!" on my real account, but it doesn't appear on the other. Shouldn't that appear immediately with the stream?
20:02:18 --> DGMurdock has joined #instantbird
20:02:21 <flo> at, it's just extremely slow
20:03:29 <-- DGMurdockIII has quit (Ping timeout)
20:03:45 <DGMurdock> hi
20:04:03 <-- igorko1 has left #instantbird ()
20:04:16 <DGMurdock> flo whats you twitter name
20:04:28 <DGMurdock> \i can send you a message if you need to to
20:05:11 --> wesj has joined #instantbird
20:05:57 <flo> all right, sorting works
20:06:16 <flo> it was just that the home timeline displayed only messages that were newer than the ones found by the track keyword
20:06:19 <clokep_> My sorting?
20:06:27 <clokep_> On the dates I mean? Or did you change it to strings?
20:06:31 <flo> DGMurdock: thanks! But I just managed to test myself what I needed
20:06:41 <clokep_> Yeah, that was the issue I had too. All my @replies were super old.
20:06:51 <flo> clokep_: yes. I haven't changed it. Just wanted to check things worked correctly and I didn't need to change another attribute of the results :)
20:07:28 <DGMurdock> 2(flo2): are you using this api- http://apiwiki.twitter.com or this one http://dev.twitter.com/doc witch is the current one
20:08:03 <flo> clokep_: shouldn't we mark the account as connected only once the stream is open?
20:09:36 <clokep_> flo: Yes, do we not?
20:09:53 <clokep_> DGMurdock: We're using the current one.
20:10:24 <flo> err, we used to do it once the timeline was received
20:11:05 <clokep_> Oh...what happens if we receive the timeline OK and the stream fails to open? You'd be offline but receive messages? Hmmm...that's weird.
20:11:17 <DGMurdock> ok
20:12:33 <flo> onStreamError would mark you as disconnected
20:15:23 <clokep_> OK.
20:15:26 <clokep_> Makes sense then.
20:15:31 <clokep_> (To do it on stream connect)
20:15:47 <clokep_> Otherwise we'd mark you connected when you get the timeline...then mark you disconnected almost immediately, so...not a big deal.
20:16:58 <flo> I won't change this now. Currently the account is marked connected just before displaying messages, that makes sense too, as there needed to be some sort of connection to get them
20:19:14 <instantbot> florian@instantbird.org added attachment 595 to bug 741.
20:19:16 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 588 on bug 741.
20:19:17 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 595 on bug 741.
20:19:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=741 nor, --, ---, clokep, ASSI, Fetch the tweets with @ mentions and tracked keywords when connecting a twitter account.
20:19:40 <flo> if you review it in <1h or don't want to review it at all, I can push it this evening
20:20:05 <-- sabret00the has quit (Quit: Leaving)
20:21:22 <clokep_> flo: Why does the error have aResponseText if it's always null?
20:21:41 <clokep_> Oh, it's called twice.
20:21:43 <clokep_> Never mind. :)
20:22:05 <flo> ugly and confusing, isn't it? ;)
20:22:12 <clokep_> Yes. :(
20:22:33 <clokep_> Confusing how you're passing "this" but binding it to a different thing too.
20:22:39 <flo> someone will have fun someday cleaning up that code
20:25:04 <-- wesj has left #instantbird ()
20:25:14 <clokep_> Yes, looks good though.
20:26:24 <instantbot> clokep@gmail.com granted review for attachment 595 on bug 741.
20:26:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=741 nor, --, ---, clokep, ASSI, Fetch the tweets with @ mentions and tracked keywords when connecting a twitter account.
20:29:06 <flo> I don't even know who's the patch author for the commit :-S
20:31:03 <clokep_> Doesn't really matter, just use the other for r=.
20:31:19 <clokep_> Depends whether you want to be blamed or pass the blame when it breaks the nightly for people. ;)
20:32:00 <flo> the reviewer gets half of the blame when something breaks. That's the point of reviews :-P.
20:33:22 <flo> I think I'll also commit http://pastebin.instantbird.com/662
20:33:42 <clokep_> Yes, good idea.
20:33:53 <clokep_> Also my addons window fix?
20:33:56 <clokep_> 752 or something?
20:34:15 <flo> already commited locally
20:34:28 <flo> bug 754
20:34:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=754 nor, --, ---, clokep, ASSI, Restart button on notification bar of add-ons window does not work
20:35:28 <clokep_> Yes. :) OK!
20:36:50 <flo> hmm, I'm wondering if I should try to fix the "the 'Disconnect' button should close the OAuth dialog" issue this evening too, or just wait for someone to do it for me :-D
20:38:13 <clokep_> Don't we pretty much just close the window? How hard can it be? :P
20:39:16 <flo> we do nothing with the request window, and then when the user closed it or completes the request, it will do things in the twitter code even though the account is supposed to be disconnected
20:40:42 <clokep_> Ah, I see.
20:41:03 <clokep_> Check if the account is still connected before taking anything from that frame.
20:41:58 <flo> and we should really close it :)
20:44:29 <clokep_> Yes.
20:54:51 --> wesj has joined #instantbird
20:56:16 * clokep_ thinks he should probably go home.
20:57:23 <clokep_> Be back later!
20:57:26 <DGMurdock> where has mic been?
20:57:35 <clokep_> Trying to cut down his online time.
20:57:41 <clokep_> He's in and out though.
20:57:49 <clokep_> He reads the logs at least it seems.
20:57:55 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:59:58 <DGMurdock> ok
21:38:15 <instantbot> florian@instantbird.org set the Resolution field on bug 741 to FIXED.
21:38:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=741 nor, --, 0.3a3, florian, RESO FIXED, Fetch the tweets with @ mentions and tracked keywords when connecting a twitter account.
21:39:06 <instantbot> florian@instantbird.org set the Resolution field on bug 754 to FIXED.
21:39:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=754 nor, --, 0.3a3, clokep, RESO FIXED, Restart button on notification bar of add-ons window does not work
21:40:06 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f36be683de49 - Patrick Cloke - Bug 754 - Restart button on notification bar of add-ons window does not work, f=fqueze.
21:40:07 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e28ebc05a613 - Florian Quèze - Remove the 'Your account is disconnected.' system message from the twitter code (follow-up to c9c8b62ed323).
21:40:08 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/3a7219369759 - Florian Quèze - Discard the OAuth authorization dialog if the user clicks on the 'Disconnect' button of the account manager (+ some simplification/dead code removal).
21:40:09 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/14c07721ccdd - Florian Quèze - Bug 741 - Fetch the tweets with @ mentions and tracked keywords when connecting a twitter account. Original version and review: clokep.
21:42:07 <flo> Good night! :)
21:47:20 <-- flo has quit (Quit: Instantbird 0.3a3pre)
21:51:37 <-- linuxwizard has left #instantbird ()
22:11:00 --> clokep has joined #instantbird
22:11:00 * ChanServ sets mode +h clokep 
22:19:24 <-- wesj has left #instantbird ()
22:29:36 --> GeekShadow has joined #instantbird
22:39:01 --> chrisccoulson_ has joined #instantbird
22:39:12 <-- chrisccoulson_ has quit (Connection reset by peer)
23:04:40 <-- jdt has quit (Ping timeout)
23:08:48 --> jdt has joined #instantbird
23:14:08 --> linuxwizard has joined #instantbird