#instantbird log on 04 12 2011

All times are UTC.

00:02:28 <-- wesj has quit (Ping timeout)
00:02:28 <-- chrisccoulson has quit (Ping timeout)
00:31:44 --> zachlr has joined #instantbird
01:00:16 <instantbot> clokep@gmail.com added attachment 582 to bug 712.
01:00:18 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 582 on bug 712.
01:00:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=712 maj, --, ---, clokep, ASSI, No UI feedback when attempting to install an incompatible add-on
01:15:38 <-- yan has quit (Ping timeout)
01:15:52 --> yan has joined #instantbird
01:29:45 <-- sabret00the has quit (Ping timeout)
01:32:21 <-- linuxwizard has left #instantbird ()
01:48:43 <-- zachlr has quit (Quit: http://www.mibbit.com ajax IRC Client)
02:03:55 --> Mook has joined #instantbird
02:10:00 --> zachlr has joined #instantbird
02:31:46 <-- clokep has quit (Quit: Instantbird 0.3a2pre)
02:46:45 --> mepine has joined #instantbird
02:49:35 <-- Mook has quit (Ping timeout)
02:50:39 --> Mook has joined #instantbird
02:54:53 <Mook> flo / clokep: rather than #ifdef XP_MACOSX / <?xul-overlay ... ?> / #endif, you can also do it via chrome.manifest (overlay chrome://target chrome://overlay-file os=darwin)
02:56:36 <Mook> err, in the context of bug 712. I'll just go comment on it.
02:56:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=712 maj, --, ---, clokep, ASSI, No UI feedback when attempting to install an incompatible add-on
03:08:09 <-- skeledrew has quit (Ping timeout)
03:11:59 <-- zachlr has quit (Connection timed out)
03:14:22 --> skeledrew has joined #instantbird
03:15:51 <-- yan has quit (Ping timeout)
03:19:39 --> yan has joined #instantbird
03:19:59 --> linuxwizard has joined #instantbird
03:28:14 <-- skeledrew has quit (Ping timeout)
03:29:05 --> skeledrew has joined #instantbird
03:34:34 <-- micahg_ has quit (Ping timeout)
03:48:39 <-- skeledrew has quit (Ping timeout)
03:49:39 --> skeledrew has joined #instantbird
03:52:55 --> micahg_ has joined #instantbird
03:56:40 <-- yan has quit (Ping timeout)
03:56:54 --> yan has joined #instantbird
04:10:19 <-- Mathnerd314 has quit (Ping timeout)
04:19:53 <-- yan has quit (Ping timeout)
04:20:01 --> kaie has joined #instantbird
04:24:07 --> yan has joined #instantbird
04:26:48 <-- yan has quit (Ping timeout)
04:29:41 <-- linuxwizard has left #instantbird ()
04:30:41 --> yan has joined #instantbird
04:39:20 <-- yan has quit (Ping timeout)
04:45:04 --> yan has joined #instantbird
04:48:21 <-- skeledrew has quit (Ping timeout)
04:48:45 --> skeledrew has joined #instantbird
04:48:49 <-- yan has quit (Ping timeout)
04:52:19 <-- skeledrew has quit (Ping timeout)
04:52:21 --> skeledrew has joined #instantbird
04:52:37 --> yan has joined #instantbird
05:07:17 <-- DGMurdockIII has quit (Ping timeout)
05:12:42 <-- skeledrew has quit (Ping timeout)
05:12:53 --> skeledrew has joined #instantbird
05:55:42 <-- mepine has quit (Quit: mepine)
05:56:32 --> mepine has joined #instantbird
06:03:02 --> waynenguyen has joined #instantbird
06:19:13 --> DGMurdockIII has joined #instantbird
06:20:57 <-- rikki has quit (Quit: Instantbird 0.2)
06:42:59 --> rikki has joined #instantbird
07:01:07 --> Ornthalas has joined #instantbird
07:02:01 <-- waynenguyen has quit (Ping timeout)
07:06:04 --> waynenguyen has joined #instantbird
07:15:58 --> chrisccoulson has joined #instantbird
07:16:27 <-- waynenguyen has left #instantbird ()
07:29:19 <-- DGMurdockIII has quit (Quit: get satisfied! • :: core-networks.de ««« (Gamers.IRC) »»» gamersirc.net ::)
07:32:10 <-- kaie has quit (Ping timeout)
07:36:31 --> kaie has joined #instantbird
07:56:45 <-- Mook has quit (Quit: ChatZilla 0.9.86-xr [XULRunner 2.0b13pre/20110304030406])
08:09:40 <-- kaie has quit (Ping timeout)
08:11:13 --> kaie has joined #instantbird
08:13:21 --> Even1 has joined #instantbird
08:17:30 <-- Ornthalas has quit (Quit: KTHXBYE)
08:21:57 --> waynenguyen has joined #instantbird
08:33:41 --> sabret00the has joined #instantbird
08:44:48 --> tymerkaev has joined #instantbird
09:12:32 --> Andrey has joined #instantbird
09:22:49 --> igorko has joined #instantbird
09:49:11 <-- mepine has quit (Input/output error)
09:49:16 --> mepine has joined #instantbird
10:08:17 --> Mic has joined #instantbird
10:08:17 * ChanServ sets mode +h Mic 
10:08:33 <Mic> Hi
10:15:10 --> clokep has joined #instantbird
10:15:11 * ChanServ sets mode +h clokep 
10:30:15 <-- chrisccoulson has quit (Quit: Ex-Chat)
10:36:20 --> sonny has joined #instantbird
10:38:05 --> chrisccoulson has joined #instantbird
10:47:52 <-- Mic has quit (Quit: Instantbird 0.3a2pre)
10:54:47 <-- Even1 has quit (Quit: Instantbird 0.3a2pre)
10:54:57 --> Even1 has joined #instantbird
11:01:10 <-- clokep has quit (Quit: Instantbird 0.3a2pre)
11:30:23 <-- waynenguyen has quit (Ping timeout)
11:30:41 --> waynenguyen has joined #instantbird
11:45:22 <-- Even1 has quit (Ping timeout)
11:47:37 --> clokep_work has joined #instantbird
11:47:38 * ChanServ sets mode +h clokep_work 
11:49:43 --> flo has joined #instantbird
11:49:43 * ChanServ sets mode +qo flo flo 
11:50:40 --> Even1 has joined #instantbird
11:51:39 <clokep_work> Good morning.
11:51:58 <flo> hello :)
11:57:46 <-- mepine has quit (Ping timeout)
12:01:03 <igorko> hiya
12:01:51 <clokep_work> No comments on the blog? Lame. :P Figured people would be excited.
12:04:54 <clokep_work> flo: I'm gonna file a bug about commands not working...that'd be blocking 0.3 I assume?
12:07:21 <flo> yes
12:14:24 <instantbot> New purplexpcom - General bug 751 filed by clokep@gmail.com.
12:14:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=751 maj, --, ---, nobody, NEW, Commands not working
12:16:11 --> Mic has joined #instantbird
12:16:11 * ChanServ sets mode +h Mic 
12:18:59 * clokep_work is now known as clokep_meeting
12:37:54 --> kaie2 has joined #instantbird
12:38:51 <-- kaie has quit (Ping timeout)
12:38:52 * kaie2 is now known as kaie
12:47:18 <-- skeledrew has quit (Quit: Instantbird 0.3a2pre)
12:47:42 --> skeledrew has joined #instantbird
12:53:45 <-- igorko has quit (Quit: Instantbird 0.3a2pre)
13:08:57 * clokep_meeting is now known as cloke_work
13:09:27 --> mepine has joined #instantbird
13:11:32 <flo> http://pastebin.instantbird.com/642 is this really an improvement? (each pair of line contains the old system message and the one we would have if I check-in what I currently have)
13:12:14 <flo> I can't seem to find a good wording that still works when the status type is "unknown" :(
13:15:00 <cloke_work> flo: First of all I don't like that those messages are ambiguous.
13:15:07 <cloke_work> Who's status is now away? Mine or there's?
13:16:49 <cloke_work> flo: Maybe something like this? http://pastebin.instantbird.com/643
13:19:58 <flo> so 2 localizable strings per status type?
13:21:18 <cloke_work> I didn't think of that.
13:21:58 <cloke_work> :(
13:22:09 <flo> if it's the only way to not hurt our eyes every day, we'll do that :-D
13:23:22 <flo> cloke_work: [Exception... "'[JavaScript Error: "aMessage.trim is not a function" {file: "file:///Users/florian/buildhg/obj-instantbird-dbg/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/extensions/irc-js@patrick.cloke/components/ircProtocol.js" line: 323}]' when calling method: [nsIProtocolProxyCallback::onProxyAvailable]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
13:24:37 <flo> "'[JavaScript Error: "this._socket.close is not a function" {file: "file:///Users/florian/buildhg/obj-instantbird-dbg/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/extensions/irc-js@patrick.cloke/components/ircProtocol.js" line: 341}]' when calling method: [purpleIAccount::disconnect]"
13:27:16 <cloke_work> You're out of date. ;)
13:28:56 <cloke_work> flo: Fixed in http://hg.instantbird.org/experiments/rev/ae3b95074256 and http://hg.instantbird.org/experiments/rev/ae3b95074256
13:29:08 <cloke_work> Or rather http://hg.instantbird.org/experiments/rev/19a8b35587ec to not give the same link twice. :)
13:30:28 <flo> ok :)
13:30:29 <cloke_work> Also http://hg.instantbird.org/experiments/rev/86b8792d6e4d fixes a pretty guaranteed crash when people don't use all lower case letters in their name. :P
13:30:45 <flo> crash? :-P
13:31:22 <flo> /me just noticed that clicking the "disconnect" button of the account manager while the OAuth dialog is visible doesn't produce the expected result :(
13:31:46 <cloke_work> "crash" as in the protocol will stop working, Instantbird itself doesn't crash.
13:31:55 * cloke_work really needs to put a try/catch in.
13:32:06 <cloke_work> Hey flo, you just used a /me, right?
13:32:19 <flo> yes, why?
13:32:43 <cloke_work> Showed up as plaintext for me.
13:32:48 <cloke_work> flo /me just noticed that clicking the "disconnect" button of the account manager while the OAuth dialog is visible doesn't produce the expected result :( 
13:32:59 <cloke_work> So that's broken also...I thought that was working. :( Guess it makes more sense that way.
13:33:28 <cloke_work> I Ithought for some reason only /me was working...but I think it just shows it that way for us as part of the formatting, but not acutally executing the command.
13:35:17 <flo> I suspect this is another purpleConv/UIConv mismatch :(
13:35:26 <-- chrisccoulson has quit (Quit: Ex-Chat)
13:36:13 <cloke_work> Right. Yeah, well I mean it's bug 751 which I just filed...I just had written something incorrect about it. Are you running js-irc, or just iny our debug.
13:36:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=751 maj, --, ---, nobody, NEW, Commands not working
13:37:19 <flo> it was still there from that trailing comma debugging party ;)
13:38:10 <cloke_work> Yes. :) My other protocol I'm randomly working on had an even better error...I was getting a race condition (I think) between a Service loading and me actually using it...was causing the same error.
13:38:35 <-- tymerkaev has quit (Client exited)
13:38:35 <flo> other protocol? :)
13:38:44 --> chrisccoulson has joined #instantbird
13:40:27 <cloke_work> Not really a protocol, more of just trying (and failing) to get buddy list stuff to work.
13:40:58 <cloke_work> Just grabbing a page and parsing it for information to add to the buddy list as a "contact", wouldn't be able to talk to them though.
13:43:29 <cloke_work> I can go into details if you want, but it's not too interesting. ;)
13:43:45 <flo> don't bother looking for a regression range
13:43:54 <flo> it's definitely the UI Conversation stuff
13:45:49 <cloke_work> Ah OK. :)
13:46:13 <instantbot> florian@instantbird.org added attachment 583 to bug 751.
13:46:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=751 maj, --, ---, nobody, NEW, Commands not working
13:46:20 <flo> I don't like that patch, but it works :)
13:50:09 <-- chrisccoulson has quit (Quit: Ex-Chat)
13:51:00 --> chrisccoulson has joined #instantbird
13:51:17 <cloke_work> Why don't you like it? Cause it makes the UI depend more on the purple stuff?
13:51:45 <flo> because it prevents commands from doing things related to the UI conversations.
13:52:02 <flo> (as only the purpleConversation will be available to them)
13:52:44 <flo> a better patch (which I don't know how to write) would make this change only for protocol-specific commands (which logically want the purpleConversation and don't care about the UI)
13:55:04 <cloke_work> I see. :-(
13:55:48 <flo> I think the patch is acceptable though, as it's not a regression: commands were not able to access UI conversations before they existed :)
13:56:30 <cloke_work> I agree, and I need to stop typing /join in #developers.
13:56:49 <cloke_work> OMG are we gonna update to Gecko 6.0 soon?! http://hg.mozilla.org/mozilla-central/rev/a95d42642281 :P
13:57:05 <flo> you joined something embarrassing? :-P
13:57:26 <-- mepine has quit (Quit: 隨緣也)
13:57:27 <cloke_work> Nah, I typed /join #introduction,#coding last night and it sent.
13:57:52 <flo> that probable helped a few people find what they wanted to type :)
13:58:59 <flo> maybe we should just follow the move and release Instantbird 6.0 :)
13:59:52 <-- chrisccoulson has quit (Quit: Ex-Chat)
14:00:07 <cloke_work> Haha.
14:00:59 --> chrisccoulson has joined #instantbird
14:13:43 <-- chrisccoulson has quit (Quit: Ex-Chat)
14:17:16 --> chrisccoulson has joined #instantbird
14:28:07 <-- sonny has left #instantbird ()
14:28:24 --> sonny has joined #instantbird
14:53:44 <-- chrisccoulson has quit (Quit: Ex-Chat)
14:56:29 <-- sabret00the has quit (Quit: Leaving)
14:56:43 --> chrisccoulson has joined #instantbird
14:59:29 <-- chrisccoulson has quit (Quit: Ex-Chat)
15:00:16 --> chrisccoulson has joined #instantbird
15:10:46 <flo> hmm, even if we use 2 strings per status type, a change from away without message to away with a message would be strange if reported as "<contact> has gone away: <message>"
15:16:42 --> DGMurdockIII has joined #instantbird
15:40:42 --> sabret00the has joined #instantbird
15:43:26 <-- flo has quit (Quit: Instantbird 0.3a2pre)
16:03:11 <-- Even1 has quit (Quit: Instantbird 0.3a2pre)
16:05:05 --> wesj has joined #instantbird
16:15:44 <-- Andrey has quit (Quit: )
16:16:47 <Mic> I agree with clokep_work. The messages also looked ambiguous to me.
16:17:06 <Mic> The latest two at least ;)
16:24:39 <cloke_work> flo: You can have one extra string which is "Joe has changed their status message to: Goin' fishing."
16:24:50 <cloke_work> Which is used whenever the status doesn't change, but the status message does.
16:47:13 <-- micahg_ has quit (Ping timeout)
16:49:05 --> micahg has joined #instantbird
16:53:57 <-- Mic has quit (Ping timeout)
16:54:58 --> Mic has joined #instantbird
16:54:58 * ChanServ sets mode +h Mic 
17:12:29 <-- Tonnes has quit (Ping timeout)
17:12:56 --> Tonnes has joined #instantbird
17:19:26 --> tymerkaev has joined #instantbird
17:25:12 <-- waynenguyen has quit (Ping timeout)
18:26:33 --> linuxwizard has joined #instantbird
18:30:31 <-- tymerkaev has quit (Client exited)
19:21:14 --> waynenguyen has joined #instantbird
19:22:12 --> Ornthalas has joined #instantbird
20:00:26 <-- chrisccoulson has quit (Quit: Ex-Chat)
20:08:53 --> chrisccoulson has joined #instantbird
20:29:33 <-- cloke_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:40:35 --> flo has joined #instantbird
20:40:35 * ChanServ sets mode +qo flo flo 
21:01:47 <-- Mic has quit (Quit: Instantbird 0.3a2pre)
21:04:02 <-- DGMurdockIII has quit (Quit: get satisfied! • :: core-networks.de ««« (Gamers.IRC) »»» gamersirc.net ::)
21:09:45 <-- sonny has quit (Connection reset by peer)
21:14:45 <-- waynenguyen has quit (Connection reset by peer)
21:19:25 --> sonny has joined #instantbird
21:19:55 <-- sonny has left #instantbird ()
21:39:41 --> Mathnerd314 has joined #instantbird
21:45:13 <instantbot> florian@instantbird.org denied review for attachment 582 on bug 712.
21:45:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=712 maj, --, ---, clokep, ASSI, No UI feedback when attempting to install an incompatible add-on
21:50:08 --> clokep has joined #instantbird
21:50:08 * ChanServ sets mode +h clokep 
22:06:54 <-- Mathnerd314 has quit (Ping timeout)
22:17:49 <flo> /me wonders how soon we will be ready to build 0.3a2
22:23:31 <instantbot> florian@instantbird.org set the Resolution field on bug 751 to FIXED.
22:23:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=751 maj, --, 0.3a2, florian, RESO FIXED, libpurple commands not working
22:25:59 <-- Ornthalas has quit (Ping timeout)
22:27:55 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/40334b5c913e - Florian Quèze - Bug 751 - libpurple commands not working.
22:33:27 <clokep> Soon!
22:44:32 --> Mathnerd314 has joined #instantbird
22:50:27 --> Ornthalas has joined #instantbird
23:18:43 --> Orn has joined #instantbird
23:18:57 <-- sabret00the has quit (Ping timeout)
23:19:29 <-- Ornthalas has quit (Ping timeout)
23:21:01 <-- chrisccoulson has quit (Quit: Ex-Chat)
23:22:43 --> chrisccoulson has joined #instantbird
23:26:43 --> sonny has joined #instantbird
23:27:03 <clokep> /me hates the new Minefield icon.
23:30:11 <clokep> Arg, sorry flo that I'm an idiot.
23:30:26 <clokep> I keep forgetting to copy files over between my build and my hg repo (to be in my patches).
23:30:34 <clokep> This time being extensions.properties.
23:31:16 <flo> /me wonders how many additional versions will be needed :-D
23:32:02 <clokep> I think my average is like 5 or so. :P
23:32:23 <clokep> /me thinks you could probably write my patches in the time it takes you to review them.
23:32:34 --> mepine has joined #instantbird
23:33:07 <-- mepine has quit (Quit: 隨緣也)
23:33:42 <-- wesj has left #instantbird ()
23:33:53 <-- Orn has quit (Quit: KTHXBYE)
23:34:01 <flo> clokep: and you could probably write mine in the time it takes me to decide the wording ;)
23:35:15 <clokep> You decide that wording yet anyway? :-D
23:35:33 <clokep> You see my other comment about using a separate string for if the status message changes but not the status.
23:36:41 <flo> here's what I currently have: http://pastebin.instantbird.com/644
23:37:49 <clokep> That seems pretty reasonable.
23:38:06 <flo> yes, but I don't think that's useful. I don't really mind duplicating the status type information in that case. Especially if your string to display the new status message without the status type is longer than the string displaying both :-P.
23:38:07 <clokep> And what will happen if I'm away, then go away with a new message?
23:38:21 <clokep> Haha.
23:38:50 <clokep> Makes sense though.
23:39:19 <flo> If you go from "Available: I love Instantbird." to "Away: I love Instantbird.", maybe we should avoid displaying the status text again, as it's obviously not related to the status change
23:39:23 <flo> but I'm not sure that really matters
23:39:33 <-- sonny has left #instantbird ()
23:40:29 <-- clokep has quit (Ping timeout)
23:40:42 --> clokep has joined #instantbird
23:40:42 * ChanServ sets mode +h clokep 
23:41:00 <flo> and that could be misleading (some users could believe that if we display a status type without a status message, it means there's no status message).
23:41:35 <clokep> I think it's better / simpler to just redisplay it.
23:43:30 <flo> I still need to make the new "Your account is disconnected" work in MUCs (and more generally all contact-less conversations). And then to remove the old code.
23:46:14 <clokep> Right.
23:46:47 <flo> and move imStatusUtils.jsm to purple/
23:47:07 <flo> as using something from instantbird/modules/ in purple/purplexpcom/src/ is really not ok :)
23:47:50 <-- Mathnerd314 has quit (Ping timeout)
23:48:33 <flo> Mic: by the way, thanks for https://wiki.instantbird.org/index.php?title=Instantbird%3ARoadmap%3A0.3&diff=1331&oldid=1330 :)
23:49:03 --> Mathnerd314_ has joined #instantbird
23:49:04 * Mathnerd314_ is now known as Mathnerd314
23:49:25 <clokep> flo: http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties has no license on it...?
23:49:54 <flo> we rarely put license headers in string files.
23:50:28 <clokep> Ah, I see.
23:50:33 <flo> it's not a mistake to add one, but there's no real code there :)
23:50:49 <-- Mathnerd314 has quit (Ping timeout)
23:51:11 <flo> and it's not really usable without the code that does have license header in its files :)
23:52:04 <flo> so if you want to nuke the header in extensions.properties, go ahead :)
23:52:32 <flo> I almost suggested it while reviewing, and then decided I didn't want to discuss that, ahah :)
23:53:41 --> mepine has joined #instantbird
23:53:52 <clokep> I nuked it. :)
23:54:22 <-- chrisccoulson has quit (Quit: Ex-Chat)
23:55:34 --> chrisccoulson has joined #instantbird
23:59:57 <flo> Good night :)