#instantbird log on 03 18 2011

All times are UTC.

00:39:17 <-- skeledrew has quit (Ping timeout)
00:39:27 --> skeledrew has joined #instantbird
00:41:39 <-- micahg has quit (Ping timeout)
00:42:32 <-- skeledrew has quit (Ping timeout)
00:42:37 --> skeledrew has joined #instantbird
00:42:58 <-- Ornthalas has quit (Quit: KTHXBYE)
00:44:39 --> micahg has joined #instantbird
00:47:17 <-- zachlr has quit (Connection timed out)
00:47:55 <-- skeledrew has quit (Ping timeout)
00:47:56 --> skeledrew has joined #instantbird
01:11:23 <instantbot> clokep@gmail.com added attachment 559 to bug 673.
01:11:24 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 558 on bug 673.
01:11:25 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 559 on bug 673.
01:11:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=673 nor, --, ---, clokep, ASSI, Implement a general Sockets object for JavaScript protocols
01:13:57 <-- chrisccoulson has quit (Quit: Ex-Chat)
01:19:26 --> chrisccoulson has joined #instantbird
01:24:34 <-- skeledrew has quit (Ping timeout)
01:31:06 <instantbot> clokep@gmail.com added attachment 560 to bug 618.
01:31:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=618 enh, --, ---, nobody, NEW, Use Jump-Lists on Windows 7
01:31:11 <clokep> instantbot: uuid
01:31:12 <instantbot> 36203acb-f276-445c-bb50-a7fd47e39c92 (/msg instantbot cid for CID form)
01:41:54 --> skeledrew has joined #instantbird
02:00:37 <-- clokep has quit (Quit: Instantbird 0.3a2pre)
02:29:07 --> mepine has joined #instantbird
02:49:55 <-- Tonnes has quit (Ping timeout)
02:51:49 --> Tonnes has joined #instantbird
02:52:39 <-- skeledrew has quit (Ping timeout)
02:53:41 --> skeledrew has joined #instantbird
03:46:07 --> tymerkaev has joined #instantbird
04:05:18 --> Mook has joined #instantbird
04:52:42 <-- Mook has quit (Ping timeout)
04:53:53 --> Mook has joined #instantbird
04:54:21 * tymerkaev is now known as tymerkaev_away
05:11:57 * tymerkaev_away is now known as tymerkaev
05:13:08 <-- tymerkaev has quit (Client exited)
06:43:12 <-- micahg has quit (Ping timeout)
06:57:58 --> micahg has joined #instantbird
07:01:29 --> mokush has joined #instantbird
07:30:25 <-- chrisccoulson has quit (Ping timeout)
08:01:15 <-- Mook has quit (Quit: ChatZilla 0.9.86-xr [XULRunner 2.0b13pre/20110304030406])
08:01:50 --> chrisccoulson has joined #instantbird
08:09:18 <-- micahg has quit (Ping timeout)
08:10:36 <-- mepine has quit (Quit: mepine)
08:10:37 --> micahg has joined #instantbird
08:11:57 --> Ornthalas has joined #instantbird
08:13:08 --> mepine has joined #instantbird
08:15:44 <-- mepine has quit (Quit: mepine)
08:19:37 --> GeekShadow has joined #instantbird
08:20:57 --> mepine has joined #instantbird
08:30:18 --> igorko has joined #instantbird
08:33:24 <igorko> hi guys
08:33:36 <igorko> windows buildbot sucks again
08:33:40 <igorko> :(
08:48:22 <-- mepine has quit (Quit: mepine)
08:57:20 <-- GeekShadow has quit (Connection timed out)
09:00:06 <igorko> what means Windows Socket error #10022 ?
09:03:14 --> mepine has joined #instantbird
09:12:55 --> GeekShadow has joined #instantbird
09:16:33 <-- Ornthalas has quit (Quit: KTHXBYE)
09:19:42 --> Even1 has joined #instantbird
09:21:35 --> igorko1 has joined #instantbird
09:22:37 <-- igorko1 has quit (Quit: Instantbird 0.3a2pre)
09:24:14 --> igorko1 has joined #instantbird
09:25:08 <-- igorko1 has quit (Client exited)
09:25:25 <-- GeekShadow has quit (Quit: http://www.mibbit.com ajax IRC Client)
09:25:37 --> GeekShadow has joined #instantbird
09:28:22 <-- mokush has quit (Client exited)
09:29:50 <-- igorko has left #instantbird ()
09:36:53 --> igorko has joined #instantbird
09:48:46 <-- GeekShadow has quit (Connection reset by peer)
09:49:02 --> GeekShad0w has joined #instantbird
09:55:27 <-- GeekShad0w has quit (Ping timeout)
09:55:54 --> GeekShad0w has joined #instantbird
10:00:56 <-- igorko has quit (Quit: Instantbird 0.3a2pre)
10:04:34 <-- mepine has quit (Quit: mepine)
10:17:59 --> clokep has joined #instantbird
10:17:59 * ChanServ sets mode +h clokep 
10:27:09 <instantbot> clokep@gmail.com added attachment 561 to bug 673.
10:27:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=673 nor, --, ---, clokep, ASSI, Implement a general Sockets object for JavaScript protocols
10:34:28 <-- GeekShad0w has quit (Ping timeout)
10:37:53 <-- clokep has quit (Quit: Instantbird 0.3a2pre)
10:37:56 --> clokep has joined #instantbird
10:37:56 * ChanServ sets mode +h clokep 
10:40:05 <-- clokep has quit (Quit: Instantbird 0.3a2pre)
10:40:14 --> clokep has joined #instantbird
10:40:15 * ChanServ sets mode +h clokep 
11:06:53 <-- clokep has quit (Quit: Instantbird 0.3a2pre)
11:39:12 --> clokep_work has joined #instantbird
11:39:12 * ChanServ sets mode +h clokep_work 
12:20:02 --> rikki has joined #instantbird
12:20:24 <-- rikki1 has quit (Connection reset by peer)
12:25:41 --> sonny has joined #instantbird
12:25:42 <-- sonny has quit (Connection reset by peer)
12:25:44 --> sonny has joined #instantbird
12:25:52 <-- sonny has left #instantbird ()
12:25:53 --> sonny has joined #instantbird
12:26:01 <-- sonny has left #instantbird ()
12:36:21 --> kaie2 has joined #instantbird
12:37:16 <-- kaie has quit (Ping timeout)
12:37:17 * kaie2 is now known as kaie
12:43:03 --> sonny has joined #instantbird
12:47:32 --> flo has joined #instantbird
12:47:32 * ChanServ sets mode +qo flo flo 
12:48:10 <clokep_work> Good afternoon flo.
12:48:48 <flo> hello :)
12:49:27 --> Mic has joined #instantbird
12:49:27 * ChanServ sets mode +h Mic 
12:50:17 <Mic> Hello
12:50:56 <clokep_work> Hey Mic.
12:51:34 <clokep_work> flo: So I was looking at the jump list stuff briefly...but (this may be a dumb question), how can I get something to run once on app start up? Is there a way to do that through a component or should I just load it into blist.xul via an overlay?
12:54:22 <flo> something like what?
12:54:42 <clokep_work> Something like a function.
12:54:52 <flo> heh, first time I use Instantbird without buddy list! :)
12:55:40 <flo> a function to do what?
12:55:49 <clokep_work> To run at start up. :P
12:55:50 <flo> I don't really see how this relates to jump list stuff
12:56:02 <clokep_work> I was attempting to hack together adding the jump list code.
12:56:12 <clokep_work> So I need a function to run at start up.
12:56:24 <flo> is this the code to insert the jump list, or code to execute the actions?
12:56:47 <clokep_work> And I feel like I always do crazy things to just get a function to run (i.e. make an overlay that includes the js + a separate js file), I'm wondering if there's a "better" or "easier" way.
12:57:05 <clokep_work> To insert the jump list, but it really doesn't have anything to do with jump lists per say, more of just a xulrunner question.
12:57:43 <flo> I think there's some way to make a JS XPCOM component that is run at startup, by just adding it in a special category
12:57:58 * Mic was just looking up docs on categories ;)
12:58:49 <clokep_work> Alright, and that would probably be the "proper" way to do something like this?
12:59:45 <Mic> It seems that there is a start-up category
12:59:54 <flo> https://developer.mozilla.org/en/XPCOM/Receiving_startup_notifications
13:00:10 <clokep_work> How come I couldn't find that when searching? :(
13:00:31 <Mic> If I understood the conecpt correctly, then categories are used to find components that you don't know exactly (ie contract id and such) but  want to find and use anyways
13:00:46 <clokep_work> Also for the "category" part of the chrome manifest, what is the second parameter? (In the example it says "MyComponent")
13:01:04 <flo> Mic: yes categories are often used to get a list of components
13:01:15 <flo> we use them to get the list of protocol plugins for example :)
13:02:04 <flo> clokep_work: by the way, this is the generic XUL Runner app answer.
13:02:20 <flo> but you may be interested in something more specific, like a notification (which maybe we should add?) after the core as started
13:02:44 <clokep_work> Yeah, possibly.
13:03:51 <clokep_work> So if I register for profile-after-change, my "observe" function would be called, correct?
13:05:09 <-- flo has quit (Ping timeout)
13:06:06 <clokep_work> I never really god the hang of XPCOM. :(
13:06:14 <clokep_work> Mic: Any ideas for categories?
13:06:25 --> flo has joined #instantbird
13:06:26 * ChanServ sets mode +qo flo flo 
13:07:57 <Mic> No, not yet, let me check, I think I saw some examples somewhere
13:09:24 <clokep_work> The bug has a few ideas. And I put a screenshot from the Pidgin plug-in and from Skype.
13:09:37 <-- flo has quit (Ping timeout)
13:10:16 <Mic> Ah, we're not talking about category-manager-categories anymore but the jumplist categories?
13:10:55 --> flo has joined #instantbird
13:10:55 * ChanServ sets mode +qo flo flo 
13:11:21 <clokep_work> Oh, I misunderstood you. :) I thought you meant you were looking at that. :-D
13:11:28 <clokep_work> Sorry, my bad.
13:12:11 <-- Even1 has quit (Quit: Instantbird 0.3a2pre)
13:12:21 --> Even1 has joined #instantbird
13:12:30 <-- Even1 has left #instantbird ()
13:13:28 --> Even1 has joined #instantbird
13:13:29 --> rikki1 has joined #instantbird
13:13:45 <-- rikki has quit (Connection reset by peer)
13:14:07 <Mic> Does that help: http://www.mozilla.org/projects/embedding/observer-topics.html
13:14:23 <clokep_work> flo Even: Seems that the blog is done?
13:15:25 <clokep_work> That does help, thanks Mic.
13:15:52 <flo> clokep_work: my server is overloaded (hence my timeout disconnections...). I don't know/understand why yet.
13:16:16 <clokep_work> Ah. Well I'll make sure not to try to load any page then. :)
13:16:49 <-- Even1 has quit (Quit: Instantbird 0.3a2pre)
13:17:02 --> Even1 has joined #instantbird
13:17:35 <-- Even1 has quit (Quit: Instantbird 0.3a2pre)
13:17:47 --> Even1 has joined #instantbird
13:17:50 <-- Even1 has quit (Quit: Even1)
13:17:58 --> Even1 has joined #instantbird
13:18:02 <-- Even1 has quit (Quit: Even1)
13:18:14 <flo> hard disk full. Pfff.
13:18:51 --> Even1 has joined #instantbird
13:18:56 <-- Even1 has quit (Quit: Even1)
13:19:07 --> Even1 has joined #instantbird
13:20:22 <clokep_work> :( Have an extra IDE slot? I have a hard drive sitting around. :P
13:20:32 <clokep_work> Although it'd probably be cheaper to buy a new one than to ship it haha.
13:20:33 <Mic> rm -rf /
13:20:54 <flo> clokep_work: it's in a data center
13:21:23 <flo> and I have 94GB free on the other partition
13:22:20 <clokep_work> I can send them the drive. ;)
13:22:29 * clokep_work think it's like a 20 GB drive anyway.
13:22:35 <clokep_work> Hence why it's sitting around.
13:23:48 <flo> I have a 500GB unused sataII drive somewhere ;)
13:24:10 <flo> and a few small (<80GB) IDE drives too
13:25:26 <flo> is the blog back?
13:25:35 <Mic> hmm, it's the 21st century already. There should be a fancy button to simply extend your diskspace in the cloud.
13:26:00 <flo> gzipping the httpd access log freed over 300MB. That will be enough for now :)
13:26:02 --> igorko has joined #instantbird
13:27:45 <flo> hmm, it seems I interrupted more productive discussions with my server mess, sorry :-S
13:28:20 <igorko> someone must change cpyright year in about instantbird window
13:28:33 <igorko> to 2011
13:28:59 <igorko> hi btw ;)
13:29:08 <flo> is the encoding change successful?
13:29:32 <igorko> yust updated
13:29:37 <clokep_work> flo: Yes the blog is working.
13:29:38 <igorko> testing...
13:31:13 <clokep_work> :)
13:32:37 --> tymerkaev has joined #instantbird
13:35:48 <igorko> all works fine
13:35:51 <igorko> weeeee
13:35:55 <flo> great :)
13:38:28 <clokep_work> Mic: You're on Win 7 now, right? What do you think would be appropriate for a jump list?
13:54:25 <Mic> I've been using Win 7 frequently lately, yes
13:54:54 <-- tymerkaev has quit (Client exited)
13:55:38 <clokep_work> That pidgin plug-in has links to the account manager, etc. in the jump -list, I'm not sure that'd be appropriate, however.
13:56:11 <clokep_work> Usually things including are more of like "New something..." ("New email", "New event", "New tab", etc.)
13:56:13 <Mic> I don't like the menu either
13:56:21 <Mic> *menu items
13:56:35 <clokep_work> I think "Join chat" needs to go there (and if we had a "New IM" :P)
13:56:43 <Mic> I think we should have recent + most frequent conversations?
13:57:13 <Mic> or 'Favourites' as flo called it iirc
13:57:15 <clokep_work> I agree, to fill out the space (although idk if we can get that data yet), but I'm talking more about the "Tasks" part of it right now.
13:57:19 <clokep_work> Yes. :)
13:57:58 <flo> Mic: "Favorite" is contacts on which the user put himself a specific "favorite" tag. "frequent" is more interesting, but probably not something we can have for 0.3
13:58:30 <Mic> Ah, I thought favourites would be automatically generated depending on how often the user is contacted.
13:58:58 <Mic> brb
14:03:24 <igorko> i have duplicated contacts in buddy list after merging? it's not good?
14:04:11 --> tymerkaev has joined #instantbird
14:05:43 <flo> igorko: in the same group?
14:05:56 <igorko> in another
14:06:08 <-- Even1 has quit (Quit: Instantbird 0.3a2pre)
14:06:12 <igorko> waut
14:06:15 <igorko> wait*
14:06:18 <-- igorko has quit (Quit: Instantbird 0.3a2pre)
14:06:24 --> igorko has joined #instantbird
14:06:48 --> mepine has joined #instantbird
14:07:26 <igorko> i put duplicated contacts in the same group where first is
14:07:34 <igorko> and now it's broken
14:07:52 <igorko> those contacts are unclickable
14:09:19 <igorko> there is bug- now i need to find out when it happens
14:09:44 --> DetroitLibertyPenguin has joined #instantbird
14:09:55 <clokep_work> You mean that you combined two buddies in the same group and it's appearing twice in that group now but only one is clickable?
14:10:50 <igorko> it appears twice but in different groups
14:11:34 <igorko> and than i dragged firts combination in another group(where second group is located)
14:11:50 <igorko> after than it's broken
14:12:04 <clokep_work> If you combine buddies in different groups then the contact will appear in both groups because it has both tags.
14:12:16 <clokep_work> But the contact should /work/ in both groups. :-D
14:12:20 <clokep_work> Are there errors in the console?
14:12:27 <igorko> yes
14:12:36 <igorko> Помилка: this._preferredAccount is null
14:12:36 <igorko> Джерело: resource://gre/components/imContacts.js
14:12:36 <igorko> Рядок: 858
14:13:03 <igorko> deleting all atm
14:13:20 <clokep_work> The most annoying with the two groups thing is Facebook though, since they all appear in "Buddies" by default. ;)
14:14:22 <flo> and we can't move them out...
14:14:56 <-- igorko has quit (Quit: Instantbird 0.3a2pre)
14:16:15 <clokep_work> Yeah, I just moved my other buddies into it...and then made groups for other things.
14:16:33 --> igorko has joined #instantbird
14:16:44 <clokep_work> (I.e. I have a "Family" group on my buddy list...and I had one on Facebook, so I just went into the web interface and clicked the "Show group in chat" and voila they wree all in one group)
14:19:00 <igorko> i deleted one contact now all works by i still have one contact in two groups
14:19:20 <clokep_work> igorko: It's SUPPOSED to work like that. It's NOT a bug.
14:19:28 <clokep_work> I think from what you're saying at least. :)
14:19:40 <igorko> there are no combinations at all
14:20:24 <igorko> and i can't remove one of them without deleting both?
14:21:14 <clokep_work> If I have Buddy1 in Group1 and Buddy2 in Group2 and I merge them into a contact, then I'll have Contact12 (which contains Buddy1 and Buddy2) and will appear in both Group1 and Group2.
14:21:35 <clokep_work> If I then move Buddy2 into Group1, I'll have Contact12 (which contains Buddy1 and Buddy2) in only Group1.
14:21:45 <clokep_work> (Is that a valid statement flo?)
14:22:28 <igorko> yeah- seems this is ok
14:22:40 <igorko> but i had some bug
14:22:47 <igorko> i'll try to reproduce
14:24:27 <flo> clokep_work: yes
14:26:44 <igorko> like this:
14:26:45 <igorko> Помилка: uncaught exception: [Exception... "'[JavaScript Error: "observer is undefined" {file: "resource://gre/components/imContacts.js" line: 875}]' when calling method: [imIContact::mergeContact]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://instantbird/content/contact.xml :: onxbldrop :: line 445"  data: yes]
14:26:45 <clokep_work> I'm glad I understand that. :-) (I should start writing an FAQ for all the questions we'll get about that. :P)
14:27:10 <flo> Even better would be to find what we need to change so that there's no longer a bug
14:27:20 <igorko> it's when moving Contact into buddy from another group
14:27:32 <flo> a bug in the sense a difference between the user's expectation and the behavior
14:27:32 <igorko> or something like this
14:27:53 <flo> (even though the current behavior is the expected (by the developer) behavior)
14:28:30 <flo> I know the cause of the "JavaScript Error: "observer is undefined"" error.
14:28:58 <flo> it happens when you move a buddy from/into a contact which is visible (and expanded?) in several groups
14:29:04 <igorko> and now i can'r disconnetc buddy from contact
14:29:13 <igorko> Помилка: invalid 'instanceof' operand Components.interfaces.purpleIAccountBuddy
14:29:13 <igorko> Джерело: chrome://buddystatus/content/buddystatus.js
14:29:13 <igorko> Рядок: 228
14:29:36 <flo> that's probably not my bug :)
14:29:44 <flo> it's an error from an add-on
14:30:12 <igorko> yeah- this two errors happen when trying o disconnect the same buddy from contacts in both groups
14:31:41 <-- micahg has quit (Ping timeout)
14:32:33 <-- mepine has quit (Ping timeout)
14:33:12 --> micahg has joined #instantbird
14:33:21 <igorko> those broken contacts are fixed by moving buddies in one group (i mean the same buddy, present in two groups)
14:44:01 --> zachlr has joined #instantbird
14:44:40 <flo> clokep_work: the imServices -> Services change is because you haven't used any instantbird specific service?
14:45:00 <-- igorko has quit (Quit: Instantbird 0.3a2pre)
14:45:05 <clokep_work> flo: Yes. Just made more sense to me.
14:45:13 --> igorko has joined #instantbird
14:45:20 <clokep_work> I'm fine changing it back to imServices though.
14:45:29 <flo> the indent is wrong on BinaryInputStream and the next 2 constructors. (a tab is used)
14:45:56 <clokep_work> Really? That's weird. My editor isn't every supposed to use tabs anymore.
14:45:57 <flo> nah, Services is fine. Just wanted to be sure the change wasn't because there was an issue that I should be aware of with imServices :)
14:46:02 * clokep_work waggles his finger at Komodo.
14:46:12 <flo> look in https://bugzilla.instantbird.org/attachment.cgi?id=561&action=diff if you aren't sure ;)
14:46:56 <clokep_work> I believe you. :) Just surprised.
14:47:31 <-- Mic has quit (Ping timeout)
14:48:47 <-- DetroitLibertyPenguin has quit (Ping timeout)
14:49:57 <flo> is isAlive expected to return a boolean?
14:50:17 <clokep_work> Yes, it needs a !! in front, doesn't it?
14:50:37 <clokep_work> (so if this.transport is null, it's !!null)
14:51:03 <flo> or write if (!this.transport) return false; return this.transport.isAlive(); (with the usual line breaks and indent of course)
14:54:33 <clokep_work> Alright.
15:00:19 * flo ponders being annoying about the code duplication in onDataAvailable
15:02:08 --> Mic has joined #instantbird
15:02:08 * ChanServ sets mode +h Mic 
15:02:10 <Mic> oh, Buddy status doesn't work with nightlies .. I should fix that
15:03:57 --> DetroitLibertyPenguin has joined #instantbird
15:04:23 <clokep_work> flo: If you want me to reduce it...I need some help figure out how.
15:04:30 <clokep_work> You mean only in the binary section, right?
15:04:36 <flo> yes
15:05:37 <flo> 324 	        buffer = new ArrayBuffer(data.length); <- where is the data variable defined?
15:06:14 <flo> should it be this._incomingDataBuffer ?
15:06:18 <clokep_work> Oops, that's supposed to refer to the this._incomingDataBuffer 
15:06:19 <clokep_work> Yes.
15:06:41 <flo> and you want to remove cleanup the array after that, right?
15:06:54 <flo> s/remove//
15:07:19 <clokep_work> Yes, you can just empty it.
15:09:13 <flo> does the onBinaryDataReceived method expect an ArrayBuffer?
15:09:24 <flo> forget that question :)
15:11:15 <clokep_work> Yes. ;)
15:11:32 <clokep_work> I think that's pretty clear. :P
15:12:31 <flo> http://pastebin.instantbird.com/604 does this look correct?
15:13:04 <flo> I should have removed the "// If we're looking for a certain amount of data" comment
15:15:20 <clokep_work> flo: Line 40 - 41 of that doesn't look good.
15:15:39 <clokep_work> this.inputSegmentSize might not exist, it would need to be size instead I think.
15:16:10 <flo> sure
15:16:20 <flo> that's nice (it fits on a single 80 columns line :))
15:17:22 <clokep_work> So if it's not defined, after the splice that should be empty...
15:17:49 <clokep_work> And the length will be less than size, right. :)
15:18:12 <clokep_work> Bah, why couldn't I come up w/ that?
15:18:19 <clokep_work> Thanks though. :)
15:21:11 <Mic> clokep_work: I can't think of anything but "Join chat..." for the jump list
15:22:47 <Mic> Have a good weekened
15:22:50 <Mic> *weekend
15:22:57 <clokep_work> Bye!
15:23:08 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
15:25:46 --> Even1 has joined #instantbird
15:27:05 --> Wolfy|Sajber has joined #instantbird
15:31:13 <flo> clokep_work: do you have a working example of code that works using this module?
15:31:38 <clokep_work> Uhhh...my IRC uses it, I don't remember if I pushed or not. :-/
15:31:43 <flo> are there any cases where the "" default value of uriScheme will work?
15:32:07 <clokep_work> It will work if the "host" is a full URL for some reason.
15:32:16 <clokep_work> Which doesn't relaly make sense.
15:32:26 <clokep_work> But the code will work I guess.
15:32:40 <clokep_work> I didn't push my code last night.
15:32:43 <flo> you think it will resolve the proxy correctly without a scheme?
15:33:28 <clokep_work> It throws an error.
15:33:39 <clokep_work> I believe.
15:33:51 <flo> so what about putting a scheme by default then?
15:34:35 <clokep_work> You mean make the default "http://"? I'd like to keep it as a variable still though.
15:35:17 <flo> sure, keep the variable so that objects inheriting it can change the default
15:35:27 <clokep_work> That's fine w/ me.
15:41:02 <flo> is there a way to cancel a pending connection?
15:41:11 <-- igorko has quit (Quit: Instantbird 0.3a2pre)
15:42:16 <clokep_work> What do you mean by "pending connection"?
15:42:23 <clokep_work> You can cancel while listening by calling stop listening.
15:42:42 <clokep_work> I think you just call close on it to cancel it.
15:42:51 <flo> suppose I called connect on 3 different servers and want to use only the server that replies first
15:43:02 <flo> what do I do with the other 2 sockets to avoid wasting resources?
15:43:14 <clokep_work> (And by "close" i mean "disconnect")
15:43:23 <clokep_work> You disconnect them.
15:43:40 <clokep_work> Then after disconnect you would delete them. :P
15:43:56 <flo> right. r- :-P
15:44:14 <flo> (you need to cancel the asyncProxy request too :-P)
15:44:46 <clokep_work> As part of disconnect?
15:45:18 * clokep_work also just realized onconnectiontimedout is unused.
15:46:09 <clokep_work> I have no idea how to cancel the asyncProxy request. I don't remember seeing anything about that.
15:46:27 <flo> you'll read the review comment then :)
15:47:07 <clokep_work> Ah, I see it returns an nsICancelable or something.
15:47:12 <flo> yes
15:47:18 <clokep_work> Bah I need to store that value then.
15:47:25 <flo> you just need to store the result of the call and then .cancel() it
15:47:25 <clokep_work> OK. I'll fix that.
15:48:17 <clokep_work> Well I learned something important from this...if I want to get crappy code checked in, I need to request review about an hour before you go to bed. :)
15:48:29 <clokep_work> Not after you go to bed. ;)
15:48:44 <flo> haha
15:49:08 <flo> Morian is doing a better job than you do at getting r+ on crappy code ;)
15:49:53 <-- zachlr has quit (Connection timed out)
15:50:37 <flo> just request the review in a period when I'm madly in love :-D.
15:50:48 <flo> that happened for some of the account manager patches :-D
15:51:14 <clokep_work> Oh? It seems to work well though. :)
15:51:53 <flo> after half a dozen follow ups ;)
15:52:29 <flo> and an almost complete rewrite of the textbox resizing code because a few months after neither him nor I could understand it :-D
15:52:52 <clokep_work> For the input textbox? I can't understand it now even. :P
15:53:01 <flo> hehe
15:54:02 <flo> and it's not as crappy as it used to be. It's just the real complexity of what it should do (or I think so at least).
15:54:19 <flo> but the markup it deals with in conversation.xml is crappy!
15:58:19 --> zachlr has joined #instantbird
15:59:20 <clokep_work> conversation.xml definitely needs a rewrite.
15:59:26 <clokep_work> Which you're doing, no? ;)
15:59:33 <clokep_work> For contact support. :-D
16:00:41 <flo> nope
16:00:48 <flo> for richtext
16:01:08 <flo> for contacts I'll probably just drop the topic notificationbar
16:02:28 <clokep_work> Ah, you don't like the notification bar?
16:03:05 <flo> how is it a notification (which are supposed to require an action)?
16:03:27 <flo> I'll put a bar with information about the conversation for contacts (which buddy is used, what's its status, etc...)
16:03:42 <flo> The topic of a room is very similar to a contact's status
16:04:01 <clokep_work> Ah, that's true. :)
16:04:23 <-- micahg has quit (Connection timed out)
16:04:32 <flo> I don't think it would make sense to have something with a different appearance for the topic bar
16:04:59 --> micahg has joined #instantbird
16:05:06 <flo> I'm not sure if I should keep the notification box for future use (notifications about file transfers maybe?) or just remove it for the sake of simplicity
16:05:37 <clokep_work> I think file transfers should be in context anyway.
16:05:53 <flo> the progress should be
16:06:10 <flo> but what about the "... is offering to send you a file, accept [yes] [no]"?
16:06:26 <clokep_work> That could go either way I suppose.
16:06:27 <flo> (when the contact is not trusted, or even a complete stranger...
16:06:42 <flo> we need to finish action messages anyway
16:06:46 <clokep_work> People would say the progress shoudl be somewhere else too...so if I'm transferring a huge file I can see it eve nas we talk.
16:07:08 <flo> I'm not sure if I completely destroyed Mook's motivation with my review comments or if he's just having very little time these days
16:07:29 --> Mic has joined #instantbird
16:07:30 * ChanServ sets mode +h Mic 
16:07:32 <clokep_work> Maybe both? :)
16:08:00 <clokep_work> I think it's just the lack of a good UI for it.
16:08:13 <Mic> about conversation.xml how much change is to be expected when?
16:08:25 <flo> when it's ready
16:08:37 <Mic> I'm currently working on this file (moving the participant list to a separate file)
16:08:50 <flo> I don't plan to touch that part of the file
16:10:04 <Mic> ah, ok
16:10:12 <Mic> well, gtg again ;)
16:10:19 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
16:10:33 <flo> Mic has a radar for conversation.xml changes discussions ;)
16:11:49 <instantbot> florian@instantbird.org denied review for attachment 559 on bug 673.
16:11:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=673 nor, --, ---, clokep, ASSI, Implement a general Sockets object for JavaScript protocols
16:13:31 <instantbot> florian@instantbird.org added attachment 562 to bug 673.
16:26:18 <-- micahg has quit (Ping timeout)
16:39:55 <-- sonny has left #instantbird ()
16:44:49 --> sonny has joined #instantbird
16:45:40 --> micahg has joined #instantbird
16:47:11 <-- flo has quit (Quit: Instantbird 0.3a2pre)
16:51:11 <-- zachlr has quit (Connection timed out)
16:57:19 * clokep_work is now known as clokep_away
17:08:06 <-- Even1 has quit (Quit: Instantbird 0.3a2pre)
17:32:58 * clokep_away is now known as clokep_work
17:55:43 --> linuxwizard has joined #instantbird
18:42:50 * tymerkaev is now known as tymerkaev_away
18:47:38 * tymerkaev_away is now known as tymerkaev
18:53:37 --> GeekShadow has joined #instantbird
18:59:13 <-- GeekShadow has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:30:02 <-- skeledrew has quit (Ping timeout)
19:30:11 --> skeledrew has joined #instantbird
19:40:50 --> igorko has joined #instantbird
19:56:17 <-- tymerkaev has quit (Client exited)
19:59:49 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:14:01 --> Ornthalas has joined #instantbird
20:14:16 --> GeekShadow has joined #instantbird
20:25:07 --> flo has joined #instantbird
20:25:07 * ChanServ sets mode +qo flo flo 
20:49:05 --> clokep has joined #instantbird
20:49:05 * ChanServ sets mode +h clokep 
20:49:49 <flo> hmm, the next step in cleaning up my screen is to remove the conversation window too :)
20:50:22 <clokep> Hah, I'd like to hear your plans for that.
20:51:25 <flo> separate the displayed conversations from the core conversations, so that the conversation window is only a way to view them. List the current conversations in a group in the buddy list, with the unread message count
20:51:44 <flo> popup the conversation window whenever something needs my attention
20:52:17 <flo> (an IM from someone I care about, or someone pinging me in a MUC)
20:52:52 <flo> or don't. Just get attention from the jumping dock, and display the conversations when I click it.
20:53:39 <clokep> Hah.
20:53:59 <clokep> Could work I suppose. :P
20:54:01 <flo> sounds crazy? :)
20:54:14 <clokep> A bit.
20:55:08 <flo> clicking on the tabs each time they turn red just to see what people are discussing is a waste of time in chatrooms where I don't reply. It shouldn't be displayed in a way that continuously attracts my attention
20:56:37 <clokep> Fair enough.
20:57:31 <clokep> flo: You want unix line endings?
20:57:33 <clokep> Or Mac? ;)
20:57:41 <flo> pfff
20:58:06 <flo> that's not a serious question, is it? :-P
20:59:01 <clokep> It sort of was actually. :( I never worried about line endings before.
21:01:44 <clokep> Bah those lines don't have tabs in my editor.
21:02:09 <flo> one of the student put Mac line endings in the addon's files. That made them very unreadable in the terminal...
21:02:52 <clokep> That's ironic. :(
21:03:20 <flo> because I'm on a mac?
21:03:30 <clokep> Yes.
21:03:42 <flo> "mac" line endings are for Macs before Mac OS X.
21:03:50 <clokep> Ah, I see.
21:03:56 <clokep> Was Mac OS before X unix based or no?
21:04:03 <flo> Mac OS X is just an unix with some fancy UI :)
21:04:28 <flo> I don't think it was. I've never used it.
21:05:01 <clokep> Right.
21:17:58 <clokep> Done making changes I think....need to test.
21:22:13 <-- Even has quit (Quit: Instantbird 0.3a2pre)
21:35:36 <clokep> flo Any idea what I should pass to the cancel function when I cancel a the asyncProxy?
21:35:47 <clokep> It wants an nsresult aReason
21:37:36 <flo> ah?
21:37:53 <clokep> https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsICancelable
21:38:22 <flo> probably NS_ERROR_FAILURE
21:38:31 * flo reads the code
21:41:57 <flo> clokep: http://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsProtocolProxyService.cpp#121
21:42:26 <clokep> OK....:-/ What's that mean?
21:42:33 <clokep> That I just have to give an error?
21:43:19 <-- igorko has quit (Quit: Instantbird 0.3a2pre)
21:43:34 <flo> yes
21:43:40 <flo> ensure it's not NS_OK :)
21:43:45 <clokep> Hahaha. OK.
21:43:54 <clokep> NS_ERROR_FAILURE probably sounds best.
21:44:02 <clokep> Is there a certain way to get to that or...?
21:44:13 <flo> Cr.NS_ERROR_FAILURE
21:44:22 <clokep> Thanks. :)
21:45:59 <flo> NS_ERROR_ABORT may be good too
21:46:03 <flo> I've never seen it used
21:46:51 <flo> http://mxr.mozilla.org/mozilla-central/ident?i=NS_ERROR_ABORT yeah, it's used in network code for cancelled request. You definitely want this one :)
21:47:45 <clokep> Ah, yes. :) That makes more sense.
21:48:33 <clokep> Bah I'm getting a listen error now.
21:53:03 <-- clokep has quit (Ping timeout)
21:53:09 --> clokep has joined #instantbird
21:53:09 * ChanServ sets mode +h clokep 
21:58:39 <-- Wolfy|Sajber has quit (Connection reset by peer)
21:59:11 <-- flo has quit (Ping timeout)
22:07:09 --> flo has joined #instantbird
22:07:09 * ChanServ sets mode +qo flo flo 
22:16:56 <-- sonny has left #instantbird ()
22:22:04 <-- chrisccoulson has quit (Quit: Ex-Chat)
22:23:33 <instantbot> clokep@gmail.com added attachment 563 to bug 673.
22:23:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=673 nor, --, ---, clokep, ASSI, Implement a general Sockets object for JavaScript protocols
22:24:14 <instantbot> clokep@gmail.com added attachment 564 to bug 673.
22:24:15 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 564 on bug 673.
22:25:11 <clokep> And that's used in https://hg.instantbird.org/experiments/file/3a8bbbdbc29f/components/ircProtocol.js which I probably should have included in the bug. :(
22:25:24 <clokep> https://hg.instantbird.org/experiments/file/3a8bbbdbc29f/components/ircProtocol.js#l173 rather.
22:26:29 --> sonny has joined #instantbird
22:27:03 --> chrisccoulson has joined #instantbird
22:32:26 <flo> clokep: should _inputStream, _outputStream, transport and proxyCancel have default null values? or should we do "... in this" checks rather than "!..." checks?
22:32:54 <clokep> Uhhh...doesn't it return null anyway if it's undefined?
22:33:17 <flo> it returns undefined + outputs a warning if you have JS string warnings enabled
22:33:35 <flo> (undefined evaluates to false so your code probably works)
22:33:58 <clokep> You know I don't know if I have strict set on that profile or not. I tend to trash that profile a lot and recreate it.
22:34:01 <flo> what will happen if disconnect is called several time? What does closing an already closed stream do?
22:34:37 <flo> "this.proxyCancel.close(Cr.NS_ERROR_ABORT);" did you mean .cancel here (or have I missed something)?
22:34:39 <clokep> "Note: The close method may be called more than once, but subsequent calls are ignored." :)
22:34:51 <clokep> I did mean cancel, blah. :-/
22:34:58 <clokep> I must have copied from above.
22:35:11 <flo> on all the 3 things where close is called?
22:35:57 <clokep> No, the other two are correct.
22:36:03 <clokep> I think.
22:36:06 <clokep> Sorry, what do you mean?
22:36:31 <flo> clokep: ""Note: The close method may be called more than once, but subsequent calls are ignored." :)
22:36:45 <clokep> Are you repeating me now? ;)
22:37:11 * flo hates IM conversations :-P
22:37:25 <flo> I was asking if that note applies to both streams + the transport.
22:37:32 <clokep> Oh, that refers to streams.
22:37:56 <clokep> Transport doesn't have a note, which doesn't mean it'll error necessarily...
22:37:58 <clokep> I'll try it.
22:38:25 <-- chrisccoulson has quit (Quit: Ex-Chat)
22:40:26 <clokep> flo: No errors from closing it multiple times.
22:40:32 <flo> cool
22:42:34 <clokep> I could always delete them after if you want. :P
22:43:28 <flo> I think checking "<...> in this" instead of this.<...> and deleting them after closing would be cleaner, yes :)
22:44:08 <flo> the same thing may apply to stopListening
22:44:23 <clokep> Alright.
22:44:42 <flo> but you already delete it in onStopListening
22:45:11 <clokep> That should be OK. (When you call stopListening(), onStopListening() gets called.)
22:45:58 --> chrisccoulson has joined #instantbird
22:46:06 <flo> but should you add a if (... in this) check in onStopListening too then?
22:46:30 <flo> this.proxyCancel.cancel(Cr.NS_ERROR_ABORT); // Has to be a failure code
22:46:30 <flo> I think I would prefer it like this with the comment on the same line. (it's not something "returned" anyway).
22:47:00 <flo> and I think that's enough nit picking for that patch. r+ with the above changed :).
22:47:43 <flo> oh, you forgot to add it in the makefile!
22:48:04 <flo> if I check it in and your new file is not packaged, you'll be disappointed ;)
22:48:50 <clokep> Hahah, yes. I will. :)
22:49:07 <clokep> That would also be like the 5th file in a row we forgot to package. :)
22:50:14 <flo> I did package ibCore.jsm! :)
22:55:15 <clokep> True. :)
22:56:20 <flo> hmm, how come I suddenly have vertical tabs?
22:56:42 <clokep> Oh, you didn't see me include that in that patch? ;)
22:57:25 <flo> ah, I'm on an old debug profile
22:58:02 <flo> for some reason, it has exactly the same buddy list as my current debug profile
23:03:47 <clokep> Ah, that's...unlucky.
23:11:34 <clokep> Hmm....I think I got everything.
23:13:36 <-- GeekShadow has quit (Connection reset by peer)
23:13:49 --> GeekShad0w has joined #instantbird
23:13:55 <flo> hint: I'm almost ready to push the cleanup patch I'm working on, and I'll go to bed soon after that (so if you want it checked in this evening, don't wait half an hour :))
23:14:20 <clokep> I'm about to upload. :)
23:14:29 * GeekShad0w is now known as GeekShadow
23:16:00 <flo> ahah, it's even going to fix a bug that I had sometimes but had never clearly identified :)
23:16:35 <flo> the popup notifications sometimes didn't work for incoming messages. It was for incoming messages that caused a new conversation window to open.
23:19:34 <instantbot> clokep@gmail.com added attachment 565 to bug 673.
23:19:35 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 564 on bug 673.
23:19:36 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 565 on bug 673.
23:19:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=673 nor, --, ---, clokep, ASSI, Implement a general Sockets object for JavaScript protocols
23:20:04 <instantbot> clokep@gmail.com added attachment 566 to bug 673.
23:20:31 <clokep> That interdiff does not include the manifest change, you'll have to look in the real patch for that. ;)
23:20:41 <clokep> Since the interdiffs are from my extension repo.
23:23:55 <-- flo has quit (Quit: Instantbird 0.3a2pre)
23:24:10 --> flo has joined #instantbird
23:24:10 * ChanServ sets mode +qo flo flo 
23:24:13 * clokep really hopes he doesn't need to redo that version again.
23:24:31 <flo> oops, Command+Q on the wrong instantbird...
23:28:57 <flo> wow, I thought the proxyCancel -> _proxyCancel change so loud that you heard it?
23:29:05 <flo> I didn't want to bikeshed on a variable name
23:30:44 <clokep> Haha I was thinking it when I was rereading. :)
23:32:05 <-- sonny has left #instantbird ()
23:36:31 <instantbot> florian@instantbird.org granted review for attachment 565 on bug 673.
23:36:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=673 nor, --, ---, clokep, ASSI, Implement a general Sockets object for JavaScript protocols
23:38:44 <-- micahg has quit (Ping timeout)
23:38:55 <instantbot> florian@instantbird.org set the Resolution field on bug 673 to FIXED.
23:38:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=673 nor, --, 0.3a2, clokep, RESO FIXED, Implement a general Sockets object for JavaScript protocols
23:39:09 <clokep> :)
23:45:37 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/03d3b86d2a27 - Florian Quèze - Move the notification code out of imWindows.jsm (new ibNotifications.jsm module).
23:45:38 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/804ac6412670 - Patrick Cloke - Bug 673 - Implement a general Sockets object for JavaScript protocols, r=fqueze.
23:46:05 <flo> I still have the code related to the mac dock to move out of imWindows.jsm
23:47:34 <clokep> So it's getting there. :)
23:48:18 * clokep goes to file follow ups. ;)
23:48:50 <flo> yeah, I hope I'll soon have only the code related to handling the list of conversation windows there :)
23:50:25 <instantbot> New purplexpcom - General bug 733 filed by clokep@gmail.com.
23:50:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=733 enh, --, ---, clokep, ASSI, JS-Socket should automatically handle flood control
23:51:43 <flo> when is this needed?
23:52:13 <clokep> Some IRC servers will kick you for flooding and give you a timeout on how often you should send messages.
23:52:25 <clokep> (Of course if you send 3 messages quickly they might not kick you, but if you send A LOT, they will.)
23:52:39 <clokep> And once things like CTCP are done where responses are done automatically, it's necessary.
23:52:56 <clokep> If it's not done. I can ask you for your CTCP version 15 times and then you'll get kicked.
23:52:57 <flo> isn't this something at the protocol level rather than at the network code level?
23:54:57 <clokep> Hmm....maybe. But it'd be something simpler for the socket code to handle so when I connect a socket I can say "Don't send more than once every 200 ms" and then just keep sendData as often as I want.
23:55:04 <clokep> + it'd be more reusable.
23:56:42 <flo> well, as long as it's not enabled by default, ok :)
23:56:58 <clokep> Yup, if you give a timeout of 0 it would send immediately. ;)
23:57:10 <clokep> (timeout is a poor choice of word)
23:59:03 * flo just looked at ircProtocol.js and can't resist proposing some changes