#instantbird log on 12 23 2010

All times are UTC.

00:15:29 * flo has an access token saved in the preferences by his code. :)
00:22:17 <flo> Mic: the "fake" add-on(?) is useful to make screenshots and decide what the actual content of the windows will be.
00:22:27 --> clokep has joined #instantbird
00:22:27 * ChanServ sets mode +h clokep 
00:23:04 <Mic> Does it work on nightlies?
00:23:10 <flo> hmm
00:23:18 <flo> I should probably fix it for the new buddy list :(
00:41:05 <-- clokep has quit (Ping timeout)
00:46:37 <Mic> flo: on bug 434 you tried to find a way to get it working with both the new an the old system
00:46:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=434 enh, --, ---, nobody, NEW, Use toolkit password manager
00:46:52 <flo> yes
00:47:38 <Mic> Would be installing a compatibility extension for the old release be an option?
00:47:50 <Mic> One that does exactly the same thing, only as extension?
00:48:51 <flo> so we would alter the profil in a backward incompatible way, and ask the user to install and add-on when going back to the old version?
00:50:18 <Mic> Maybe even installing it right away, making it only compatible to 0.2 (maybe that's ugly, though)
00:50:40 --> clokep has joined #instantbird
00:50:40 * ChanServ sets mode +h clokep 
00:50:58 <flo> we would install it and make it invisible? :-D
00:51:23 <Mic> If that's possible then it would be a good solution in my opinion
00:51:50 <flo> if I'm not the one coding it, yeah, could be almost perfect :)
00:53:05 <flo> hmm, what about shipping a compatible with both storage, and auto-updating 0.2 users to it?
00:53:37 <clokep> Mic: Trying which fixes?
00:53:44 <clokep> Just everythign I've been doing?
00:53:48 <clokep> Yes it's been on unpacked ones.
00:54:25 <Mic> My last suggestion was having a release that does nothing but adding this new storage, since everything else would stay the same, there would be no reason to not like this update
00:54:55 <Mic> clokep: you only unpacked omni.jar and fixed the components registration?
00:55:11 <clokep> Yes.
00:55:37 <Mic> ok, then I'll try that again tomorrow. With everything as new and clean as possible
00:55:48 <Mic> Maybe I just broke something
00:56:34 <clokep> What are you trying to run of mine though?
00:56:58 <Mic> I'm sorry I don't understand
00:57:15 <Mic> What do you mean by *run of mine*
00:57:27 <clokep> Are you trying to run some of my code or are you just wondering if unpacking omni.jar has been working for me?
00:58:07 <Mic> I only wanted to know if it should work
00:58:31 <clokep> Ah, OK. :) Yes it should.
00:58:37 <clokep> I had problems wiht it at one point and had to reinstall though.
01:00:47 <clokep> Mic: Nice blog post! You should update the about page though. ;)
01:01:47 <clokep> And I'm out again! Ciao.
01:01:56 <Mic> bye
01:04:36 <-- micahg has quit (Ping timeout)
01:04:55 <-- clokep has quit (Ping timeout)
01:12:53 <Mic> Good night
01:13:04 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
01:24:54 <-- skeledrew has quit (Ping timeout)
01:26:30 --> skeledrew has joined #instantbird
01:29:14 <flo> http://queze.net/goinfre/Screenshot-Twitter%20timeline%20-%20Instantbird.png almost too easy ;)
01:38:46 <hicham> great !
01:44:01 <-- hicham has quit (Client exited)
01:47:59 --> mepine has joined #instantbird
01:50:52 <flo> Good night! :)
01:51:06 <-- mepine has quit (Ping timeout)
01:54:42 --> hicham has joined #instantbird
02:00:07 --> mepine has joined #instantbird
02:07:22 --> micahg has joined #instantbird
02:13:59 <-- skeledrew has quit (Ping timeout)
02:15:07 --> skeledrew has joined #instantbird
03:21:27 <-- micahg has quit (Quit: Leaving.)
03:21:31 --> micahg has joined #instantbird
03:27:21 <-- skeledrew has quit (Ping timeout)
03:31:08 <-- mepine has quit (Quit: mepine)
03:34:38 --> skeledrew has joined #instantbird
03:36:24 --> mepine has joined #instantbird
03:47:51 <-- skeledrew has quit (Ping timeout)
03:49:09 --> skeledrew has joined #instantbird
03:52:26 <-- hicham has quit (Client exited)
03:54:59 <-- GeekShadow has quit (Quit: The cake is a lie !)
04:08:56 <-- skeledrew has quit (Ping timeout)
04:13:54 --> skeledrew has joined #instantbird
04:20:00 <-- skeledrew has quit (Ping timeout)
04:22:36 --> skeledrew has joined #instantbird
04:45:27 <-- DGMurdockIII has quit (Quit: get satisfied! • :: www.unitedservers.de ««« (Gamers.IRC) »»» gamersirc.net ::)
04:48:07 --> clokep has joined #instantbird
04:48:07 * ChanServ sets mode +h clokep 
05:04:30 --> tymerkaev has joined #instantbird
05:04:46 <-- Mook has quit (Ping timeout)
05:12:18 <instantbot> mook.moz+bugs.instantbird@gmail.com added attachment 441 to bug 638.
05:12:19 <instantbot> mook.moz+bugs.instantbird@gmail.com requested review from florian@instantbird .org for attachment 441 on bug 638.
05:12:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=638 enh, --, ---, mook.moz+bugs.instantbird, NEW, Split purpleInit.cpp into multiple files
05:21:03 --> Mook has joined #instantbird
05:32:13 <-- tymerkaev has quit (Ping timeout)
05:39:29 <Mook> hm, can't quite decide where http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleInit.cpp#1271 should go. account stuff?
06:14:45 <-- Mook has quit (Ping timeout)
06:19:46 <-- clokep has quit (Quit: Instantbird 0.3a1pre)
06:32:07 --> Mook has joined #instantbird
07:18:51 <-- Mook has quit (Ping timeout)
07:33:06 --> Mook has joined #instantbird
07:38:14 --> mokush has joined #instantbird
07:52:11 --> Ornthalas has joined #instantbird
08:20:36 <-- Ornthalas has quit (Quit: KTHXBYE)
08:41:53 <-- skeledrew has quit (Ping timeout)
08:42:30 --> skeledrew has joined #instantbird
09:08:46 <Mook> http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/jabber/si.c#502 - it just never frees | host | ?
09:08:55 <Mook> is it expecting it to be a static memory?
09:09:10 <Mook> err. pretend that was in English that made sense :)
09:24:18 <-- skeledrew has quit (Ping timeout)
09:27:10 --> skeledrew has joined #instantbird
09:39:04 <Mook> man, how does libpurple deal with failure in general? how do I, from http://lxr.instantbird.org/instantbird/source/purple/libpurple/request.h#210 , report that I failed?
10:00:18 <-- skeledrew has quit (Ping timeout)
10:00:43 <flo> Mook: purpleInit.cpp#1271 is just "random stuff". We need to rewrite the command system to be compatible with JS protocol plugins anyway...
10:01:21 <Mook> okay, so leave it in that file, for now
10:01:28 <Mook> incremental improvements, please :)
10:01:31 <-- chrisccoulson has quit (Connection reset by peer)
10:02:28 <Mook> (I do want to rewrite large swaths of it, but getting stuff in-tree is more important)
10:02:32 <flo> Mook: jabber/si.c#502 - it just never frees | host | ?  <- It's static memory in http://lxr.instantbird.org/instantbird/source/purple/libpurple/network.c#164
10:02:53 <flo> just totally undocumented, the kind of thing that forces you to read the code before using any function of libpurple
10:03:21 <Mook> unless you happen to be going down http://lxr.instantbird.org/instantbird/source/purple/libpurple/network.c#299 ...
10:04:14 <Mook> ( http://lxr.instantbird.org/instantbird/source/purple/libpurple/network.c#158  , http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleInit.cpp#1013
10:04:18 --> skeledrew has joined #instantbird
10:04:31 <flo> Mook: "how do I, from http://lxr.instantbird.org/instantbird/source/purple/libpurple/request.h#210 , report that I failed?" I suspect you just don't.
10:04:40 <Mook> haha
10:04:50 <flo> Mook: "how does libpurple deal with failure in general?" no general way, but crashing is relatively common.
10:04:59 <Mook> awesome!
10:05:10 <flo> ok, just kidding (or not so much :-S)
10:05:15 <Mook> that's what I look for in an app accepting input from the network, right?
10:05:33 <flo> sure ;)
10:06:17 <-- mokush has quit (Ping timeout)
10:06:20 <flo> Mook: "purple_prefs_get_string" is supposed to be static memory too
10:06:40 <Mook> well, right now it's calling an XPCOM API, which uses NS_Alloc...
10:06:42 <flo> I just never found a way to do it using the Mozilla preferences
10:06:47 <Mook> right
10:07:06 <flo> and it's totally stupid for that API to not duplicate the string
10:07:07 <Mook> okay, so at least it's known to leak like a sieve ;)
10:07:54 <flo> if you request the value of a string preference and someone changes the value just after, you end up pointing to freed memory and... boom
10:08:52 <flo> Mook: yeah, that specific leak is known as mine. However on debug builds it prints a warning to stderr each time that leak happens, so I know it's like 3 or 4 times during the application lifetime. I rewrote the code that repeatedly accessed string preferences.
10:09:28 <Mook> ah, that's nice :)
10:09:53 <Mook> as long as you don't use a random prpl that calls it, I guess ;)
10:10:39 <flo> Mook: random prpls would crash before exhausting the memory :)
10:11:07 <Mook> true. perhaps a very carefully written prpl? :p
10:11:12 <Mook> (okay, that's a silly thuoght)
10:11:42 * Mook tries to figure out how the lifetimes of the various things for http://lxr.instantbird.org/instantbird/source/purple/libpurple/request.h#254 works
10:11:44 <flo> carefully crafted to get the value of a string preference in a loop, and do nothing else to avoid crashing?
10:12:01 <flo> yeah, that would work, but I think it could do better and just call malloc in the loop :)
10:12:57 <Mook> or poll a pref every second and if it changes, send it out, possibly as /playing for IRC-things
10:13:10 <flo> nothing looks IRC, or even conversation-invitation specific in that mess
10:13:21 <flo> how will you know which requests are acceptable to present to the user?
10:13:31 <Mook> for now, I'd just present everything
10:13:45 <Mook> err, the action things, anyway
10:13:53 <Mook> then we can see when things make no sense and disable them ;)
10:14:05 <flo> I hate that API
10:14:56 <Mook> purple_request_fields might be the worst. yay random structures.
10:15:38 <flo> by the way, feel free to patch around when you are in libpurple if something related to what you are doing is non sense
10:15:54 <flo> it's not like I haven't done it already :)
10:16:11 <flo> all the  PURPLE_REQUEST_NO_OPS calls look like mine :)
10:16:29 <Mook> yep, that they are
10:17:00 <Mook> since all I care about right now is request_action, I'll implement only that :D
10:17:18 <flo> we have lxr on the official libpurple/pidgin too
10:17:30 <flo> it's often useful when trying to understand how an API is supposed to be used
10:17:47 <flo> http://lxr.instantbird.org/pidgin2.6.3/
10:18:14 <flo> I don't have it (yet?) for Adium though :-|
10:18:58 <Mook> if you get _lots_ of spare time, consider going to mxr
10:19:18 <Mook> ( http://hg.mozilla.org/webtools/mxr/ )
10:19:37 <Mook> it's timeless's fork of lxr, has some nice things like showing the line in ident search
10:19:38 <Mook> also has some bugs :p
10:20:15 <flo> I see a dozen calls for purple_request_action, but none from IRC. http://lxr.instantbird.org/instantbird/search?string=request_action
10:20:28 <flo> Mook: Yeah, I've meant to do it for years
10:20:36 <Mook> no, no, I was just kidding with that. don't worry about it.
10:20:59 <Mook> oh. I need to implement close_request
10:21:04 <flo> being able to restrict the search to files whose name match something is really useful/needed
10:21:27 <flo> where's the IRC call you are interested int?
10:21:29 <flo> *in
10:21:41 <Mook> it's the channel invite one
10:22:00 <Mook> the other thing was just theoretical :p
10:23:50 <-- Jan has quit (Ping timeout)
10:25:04 --> Jan has joined #instantbird
10:25:30 * Jan is now known as IRCMonkey58341
10:28:35 <flo> Mook: how did you decide which headers are needed where? You tried removing each of them and added them back when something broke, or just removed the ones that seemed completely useless?
10:29:01 <Mook> yep, added things back when stuff broke
10:29:12 <Mook> but paying attention what broke, so that they sort of made sense
10:29:31 <Mook> (e.g. IIRC one of them randomly included nsServiceManagerUtils... I grabbed that instead.)
10:30:45 <flo> I was wondering what requires libpurple/log.h
10:31:26 <Mook> oh. I can't remember, maybe i just didn't try removing that oen
10:31:35 <Mook> it looked like it made sense to be everywhere :P
10:32:10 <flo> that's not debug logs ;)
10:33:01 <flo> http://lxr.instantbird.org/instantbird/source/purple/libpurple/log.h best header ever :)
10:35:08 <Mook> hahaha
11:00:33 <-- skeledrew has quit (Ping timeout)
11:01:14 --> Mic has joined #instantbird
11:01:15 * ChanServ sets mode +h Mic 
11:01:24 <-- Mic has quit (Connection reset by peer)
11:02:49 --> Mic has joined #instantbird
11:02:50 * ChanServ sets mode +h Mic 
11:02:54 <-- Mic has quit (Connection reset by peer)
11:03:50 --> skeledrew has joined #instantbird
11:08:32 --> Mic has joined #instantbird
11:08:32 * ChanServ sets mode +h Mic 
11:09:07 <Mic> hi
11:10:09 <Mook> hola
11:13:20 <Mic> ah, Mook! 
11:14:21 <Mook> it does appear to be a Mook.
11:14:44 <Mic> I was doing to say something else ;)
11:15:41 <Mic> Do you want to keep this open space left of the application button by the way? In my opinion it looks strange and it's not as beneficial as on Explorer, as most people I've seen keep their instantmessengers usually narrow and tall (needs to display only the list). That means the normal close button is near anyways
11:15:54 <Mic> Instead of being on the other side of the screen as with Explorer
11:16:10 <Mook> Mic: it's gone in git, IIRC :)
11:16:52 <Mook> https://github.com/mook/bucktooth/commit/491c2e0dd16c30ec4ecf3ac11e3eb27716d49569
11:18:30 --> tymerkaev has joined #instantbird
11:20:53 <flo> what are the minimal things that should work in a twitter protocol plugin before I can commit it and we can release an alpha including it?
11:28:34 * IRCMonkey58341 is now known as Jan
11:34:38 --> Even has joined #instantbird
11:34:38 * ChanServ sets mode +o Even 
11:37:00 <flo> Mook: does this look good to you: http://pastebin.instantbird.com/510 ?
11:37:40 <Mook> assuming xpcom-config.h still comes from somewhere, yes
11:38:03 <flo> is that file actually useful?
11:38:15 <flo> http://mxr.mozilla.org/mozilla-central/source/xpcom/xpcom-config.h.in
11:38:35 <Mook> oh, actually, I tihnk you're okay
11:38:40 <Mook> -FI ../../../comm-config.h
11:39:48 <flo> that's the file written by configure, isn't it?
11:39:52 <Mook> yeah
11:40:41 <Mook> xpcom-config was, too
11:40:43 <flo> http://lxr.instantbird.org/instantbird/search?string=xpcom-config purpleInit is the only place where we include xpcom-config
11:40:59 <Mook> it tells you things like "this compiler has supports a 2 byte wchar_t"
11:41:08 <Mook> yep, I assume comm-config takes its place
11:41:22 <flo> isn't there a mozilla-config too somewhere?
11:42:12 <Mook> ugh. configure.in is... 10k lines long? :(
11:42:21 <flo> yes, mozilla-config and comm-config are equivalents, written by the m-c and c-c configures
11:42:50 <flo> Mook: yeah, that makes the autoconf generated configure completely unreadable :)
11:43:54 <flo> ok, so can I go ahead an commit my changes pretending they were yours? ;)
11:46:12 <Mook> sure!
11:47:02 <Mook> (you're also free to commit my changes as if they were yours; I'm not too worried about that. I just want this stuff to work.)
11:47:08 <-- mepine has quit (Quit: 隨緣也)
11:47:20 <flo> you will own the breakage if it doesn't compile on Windows or Linux :-P
11:47:26 <flo> (I tested only with a Mac debug build)
11:47:46 <Mook> the result, of course, will be that it works everywhere.. but debug only :p
11:47:58 <Mook> also: ha! since I don't have commit access... :p
11:48:54 <flo> bah, Even should start investigating how we can grant commit access :)
11:50:16 <Mook> no, this is easier for me :p
11:52:55 <-- skeledrew has quit (Ping timeout)
11:53:10 <Mic> Funny, Microsoft release a HTML5 compatibility extension to bring h.264 support to Firefox
11:53:14 --> skeledrew has joined #instantbird
11:54:06 <Mic> *released
11:54:47 <Mook> a npapi plugin, yeah
11:55:14 <Mook> I haven't looked, but I wouldn't be too surprised if it's a beefed up version of their old WMP plugin
11:56:59 <instantbot> florian@instantbird.org set the Resolution field on bug 593 to FIXED.
11:57:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=593 tri, --, 0.3a1, clokep, RESO FIXED, JavaScript component does not have a method named: "onBeforeLinkTraversal"
11:57:55 <-- skeledrew has quit (Ping timeout)
11:58:31 --> skeledrew has joined #instantbird
11:58:40 <instantbot> florian@instantbird.org granted review for attachment 441 on bug 638.
11:58:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=638 enh, --, ---, mook.moz+bugs.instantbird, NEW, Split purpleInit.cpp into multiple files
11:59:14 <Mook> okay. so I should clean things up and post the next two patches. maybe tomorrow :p
11:59:41 <flo> tomorrow may be today, with the timezone difference :)
11:59:56 <flo> isn't it 4am for you now?
12:00:42 <Mook> yep!
12:00:46 <Mook> no work ftw :)
12:01:22 <flo> I played with my twitter code until 3am this night :)
12:03:33 --> Even1 has joined #instantbird
12:04:01 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/bdb42edd2287 - Mook - Bug 638 - Split purpleInit.cpp into multiple files: move conversation uiops and signals to purpleInitConv.cpp, r=fqueze.
12:04:02 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/1b75f9fa4859 - Patrick Cloke - Bug 593 - JavaScript component does not have a method named: 'onBeforeLinkTraversal', r=fqueze.
12:04:58 <-- Even has quit (Ping timeout)
12:04:59 <-- Even1 has quit (Connection reset by peer)
12:05:25 --> Even has joined #instantbird
12:05:25 * ChanServ sets mode +o Even 
12:10:07 <Mook> hrm. I can't tell a purpleIConversation to notifyObservers.
12:11:26 --> rikki has joined #instantbird
12:11:40 <-- rikki1 has quit (Connection reset by peer)
12:13:22 <Mook> ah, it's not on the idl, but it's on the concrete impl. which I can't stuff into a nsCOMPtr. hmm.
12:18:06 <flo> really?
12:19:16 <flo> why can't you put it in a nsCOMPtr?
12:21:59 <Mook> it hasn't got an IID, has it?
12:23:18 <flo> nsCOMPtr only requires that the thing implements nsISupports, doesn't it?
12:23:28 <flo> as long as it can addref/release, you are OK I think
12:23:51 --> GeekShadow has joined #instantbird
12:23:52 <Mook> that's nsRefPtr
12:24:02 <Mook> nsCOMPtr does QI for you, so it needs an IID to do that bit
12:25:41 <flo> how come this works then? http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleInit.cpp#373
12:26:03 <Mook> hmm. now i'm all confused :p
12:26:50 <flo> it's very possible I should have used nsRefPtr there though.
12:28:39 <Mook> right, but _it compiles_
12:28:46 <Mook> which really confuses me, so I'm looking now :)
12:30:33 <flo> it seems we will both learn something today ;)
12:35:56 <Mook> http://pastebin.mozilla.org/897299 - no template iid there...
12:37:26 <flo> it inherits from purpleIConversation, maybe that's enough for nsCOMPtr to work?
12:38:27 <Mook> http://pastebin.mozilla.org/897300 - yeah
12:38:45 <Mook> (line 18)
12:39:08 <Mook> maybe it's because it hasn't got multiple inheritance?
12:49:13 <Mook> hmm. the API I'm writing is no good, making the request synchronous is stupid (I can't click that fast) :p
12:49:58 <Mook> I think that's a good sign I should sleep. good night!
12:50:46 <flo> Good night :)
12:50:54 <-- Mook has quit (Quit: ChatZilla 0.9.86-rdmsoft [XULRunner])
12:51:37 <-- GeekShadow has quit (Quit: The cake is a lie !)
13:34:12 <-- skeledrew has quit (Ping timeout)
13:35:59 --> skeledrew has joined #instantbird
13:37:32 --> hicham has joined #instantbird
13:50:58 <-- hicham has quit (Client exited)
13:51:18 --> hicham has joined #instantbird
13:55:48 --> Even1 has joined #instantbird
13:57:01 <-- Even has quit (Ping timeout)
13:57:57 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
14:09:34 <-- skeledrew has quit (Ping timeout)
14:18:07 --> skeledrew has joined #instantbird
14:22:39 --> Mic has joined #instantbird
14:22:39 * ChanServ sets mode +h Mic 
14:36:32 <-- skeledrew has quit (Ping timeout)
14:40:50 --> skeledrew has joined #instantbird
14:43:39 --> Even has joined #instantbird
14:43:40 * ChanServ sets mode +o Even 
14:44:02 <-- skeledrew has quit (Ping timeout)
14:44:52 <-- Even1 has quit (Ping timeout)
14:50:15 --> skeledrew has joined #instantbird
14:53:03 --> Mic2 has joined #instantbird
14:53:15 <-- skeledrew has quit (Ping timeout)
15:01:18 --> skeledrew has joined #instantbird
15:02:56 --> clokep has joined #instantbird
15:02:56 * ChanServ sets mode +h clokep 
15:11:20 <clokep> flo: I think you neeed the general timeline working and maybe @s or DMs? That's probably it.
15:11:32 <clokep> (How ar eyou doing @s & DMs anyway?)
15:19:40 <-- skeledrew has quit (Ping timeout)
15:19:46 <-- Even has quit (Quit: Instantbird 0.3a1pre)
15:19:49 --> Even has joined #instantbird
15:19:49 * ChanServ sets mode +o Even 
15:19:55 <-- Even has quit (Quit: Even)
15:20:00 --> Even has joined #instantbird
15:20:00 * ChanServ sets mode +o Even 
15:20:21 <-- Even has quit (Quit: Instantbird 0.3a1pre)
15:20:28 --> Even has joined #instantbird
15:20:28 * ChanServ sets mode +o Even 
15:21:00 --> skeledrew has joined #instantbird
15:25:31 <-- skeledrew has quit (Ping timeout)
15:29:07 <-- clokep has quit (Quit: Instantbird 0.3a1pre)
15:31:49 --> skeledrew has joined #instantbird
15:34:59 <-- skeledrew has quit (Ping timeout)
15:38:03 <-- Mic2 has left #instantbird ()
15:44:27 <Mic> flo: Twitter's the thing you're waiting for the alpha then
15:45:57 --> skeledrew has joined #instantbird
15:51:12 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
15:51:51 <-- skeledrew has quit (Ping timeout)
15:56:05 --> Mic has joined #instantbird
15:56:05 * ChanServ sets mode +h Mic 
15:57:24 --> skeledrew has joined #instantbird
16:02:48 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
16:03:00 --> Mic has joined #instantbird
16:03:00 * ChanServ sets mode +h Mic 
16:03:42 <-- hicham has quit (Client exited)
16:10:17 --> hicham has joined #instantbird
16:12:04 <instantbot> New Websites - Addons.instantbird.org bug 639 filed by michal.stanke@mikk.cz.
16:12:05 <instantbot> michal.stanke@mikk.cz added attachment 442 to bug 639.
16:12:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=639 min, --, ---, raynaudquentin, UNCO, Download button is strangely moving after a click
16:15:47 <instantbot> benediktp@ymail.com added attachment 443 to bug 441.
16:15:48 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 443 on bug 441.
16:15:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=441 enh, --, ---, benediktp, ASSI, minimize with ESC key
16:17:41 <flo> Mic: well, something visible.
16:17:50 <flo> twitter is the way to show that js-proto works.
16:20:11 <-- skeledrew has quit (Ping timeout)
16:24:45 <flo> clokep: "(How ar eyou doing @s & DMs anyway?)" Not doing anything yet. The screenshot is the result of a single API call to show the home timeline
16:31:34 --> skeledrew has joined #instantbird
16:33:17 <-- Mic has left #instantbird ()
16:34:36 --> Even1 has joined #instantbird
16:35:07 --> Mic has joined #instantbird
16:35:07 * ChanServ sets mode +h Mic 
16:35:40 <-- Even has quit (Ping timeout)
16:37:25 <-- skeledrew has quit (Ping timeout)
16:38:14 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
16:38:24 --> Mic has joined #instantbird
16:38:24 * ChanServ sets mode +h Mic 
16:39:56 <flo> Mic: I don't understand why your patch works on Mac where there's already a <key id="key_minimizeWindow" (http://mxr.mozilla.org/mozilla-central/source/toolkit/content/macWindowMenu.inc#11), but it does :)
16:39:56 <-- Even1 has quit (Connection reset by peer)
16:40:21 <Mic> Oh, I didn't know that
16:41:16 <flo> both Command+M and Escape minimize the conversation window, and the menu still shows Commmand+M as the key
16:41:27 --> Even has joined #instantbird
16:41:27 * ChanServ sets mode +o Even 
16:43:47 <Mic> Should I investigate or change this?
16:44:06 <flo> it's not broken, we don't have to fix it :)
16:46:10 <-- Mic has left #instantbird ()
16:47:01 <instantbot> florian@instantbird.org granted review for attachment 443 on bug 441.
16:47:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=441 enh, --, ---, benediktp, ASSI, minimize with ESC key
16:49:02 --> Mic has joined #instantbird
16:49:02 * ChanServ sets mode +h Mic 
16:50:26 --> rikki1 has joined #instantbird
16:50:53 <-- rikki has quit (Connection reset by peer)
16:51:18 <-- Glards has quit (Ping timeout)
16:51:20 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
16:51:44 --> Mic has joined #instantbird
16:51:44 * ChanServ sets mode +h Mic 
16:51:56 <instantbot> raynaudquentin@gmail.com set the Resolution field on bug 639 to WONTFIX.
16:51:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=639 min, --, ---, raynaudquentin, RESO WONTFIX, Download button is strangely moving after a click
16:54:13 --> Glards has joined #instantbird
16:56:48 <Mic> The menu and command includes are still bad :S
16:59:45 --> skeledrew has joined #instantbird
17:00:25 <Mic> I want to add commands and keys that work on both the conversation window and the buddy list
17:01:06 <Mic> Right now I did it similar to what Mook did and created an overlay that I include from the instantbird.xul and blist.xul
17:02:11 <Mic> It works but it complains about redefining const's because I included menus.js from my overlay again.
17:02:40 <Mic> flo: should I remove the include of menus.js from the other places? (I don't like this)
17:02:44 <-- skeledrew has quit (Ping timeout)
17:03:34 <flo> menus.js is needed on all windows on Mac
17:04:38 <Mic> ah, so I can add the include of this file to the other OS versions of this file and be done?
17:04:54 <Mic> I didn't like this idea either
17:05:09 <-- Even has quit (Connection reset by peer)
17:05:25 <flo> Mic: I'm out of clean ideas to do this :(
17:06:01 --> Even has joined #instantbird
17:06:01 * ChanServ sets mode +o Even 
17:07:13 <-- Even has quit (Quit: Instantbird 0.3a1pre)
17:07:58 --> clokep has joined #instantbird
17:07:58 * ChanServ sets mode +h clokep 
17:08:02 <Mic> There's no way to 'require' a js file instead of 'include'-ing it, is there?
17:08:16 <Mic> umm, no
17:08:28 <Mic> That's not what I mean. "include_once" or something like that
17:08:36 <clokep> I didn't know you used PHP. ;)
17:09:08 <Mic> Everyone has a skeleton in the closet, hasn't he?
17:09:51 <Mic> Maybe including the menus script from all places is not that bad
17:09:54 <clokep> I practically learned to program on PHP, it's fine. :)
17:10:24 <Mic> That was QBasic for me ;)
17:10:33 <Mic> So I'm indeed a bit older;)
17:10:53 <-- Mic has left #instantbird ()
17:11:07 --> Mic has joined #instantbird
17:11:08 * ChanServ sets mode +h Mic 
17:11:12 <clokep> Ah. I formally was taught to program on QBasic, than Visual Basic, but most of what I know is self taught on PHP. I have a bad-ass battleship game in QBasic somewhere...
17:11:49 <Mic> Opening the account manager from the conversation window is nice :)
17:12:05 <Mic> Same for 'join chat'
17:12:18 <Mic> accel + "J" seemd ok for the latter
17:12:25 <clokep> :)
17:12:53 <clokep> Mic
17:13:00 <clokep> Check if the variable exists, if it does not exist.
17:13:03 <clokep> Then include menu.js
17:14:34 <Mic> I was using <script ..> to include it
17:14:52 <clokep> :-\ Idk.
17:17:42 <flo> so you just need it in instantbird.xul?
17:17:52 <flo> ifndef XP_MACOSX <script ...
17:19:25 <clokep> Did win32 fail again?
17:20:51 <flo> yes and no
17:21:11 <-- Mic has left #instantbird ()
17:21:13 <flo> it failed to upload because it built successfully and was trying to upload at the same time as linux...
17:21:29 --> Mic has joined #instantbird
17:21:29 * ChanServ sets mode +h Mic 
17:21:32 <flo> (and hadn't finished after an hour -_-)
17:22:24 <clokep> Bah. :(
17:23:26 <clokep> flo: If you want/need someone else to Try Twitter let me know! :)
17:23:34 <clokep> But I have to go pick up more food for Christmas. :P
17:23:57 <flo> clokep: it's not really in a try-able state yet
17:24:14 <clokep> OK! Well...when it is...You know where to find me. ;)
17:24:16 <flo> not even reviewable as there's a lot of redundancy
17:24:28 --> kaie has joined #instantbird
17:24:53 <flo> I've almost copy/pasted the oauth signature code 3 times because there are very little variations in each requests and I wanted to have all the possible variations working well before trying to make a function to abstract that part
17:25:49 <flo> (but even with 3 copies of the oauth signature code, the twitter.js file is only 300 lines long :))
17:26:09 <clokep> :)
17:26:15 <clokep> A bit shorter than IRC I think!
17:26:34 <flo> but in IRC you do more than "authenticate" ;)
17:27:06 <flo> I've less than 20 lines doing "really things"
17:28:26 --> rikki has joined #instantbird
17:28:33 <-- rikki1 has quit (Connection reset by peer)
17:37:10 <instantbot> benediktp@ymail.com added attachment 444 to bug 418.
17:37:11 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 444 on bug 418.
17:37:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=418 enh, --, ---, benediktp, ASSI, Keyboard shortcut to open "Join chat" dialog from conversation windows
17:40:41 <instantbot> benediktp@ymail.com added attachment 445 to bug 418.
17:40:42 <instantbot> benediktp@ymail.com cancelled review?(florian@instantbird .org) for attachment 444 on bug 418.
17:40:43 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 445 on bug 418.
17:40:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=418 enh, --, ---, benediktp, ASSI, Keyboard shortcut to open "Join chat" dialog from conversation windows
17:41:14 <Mic> Sorry for the bugspam
17:43:17 <Mic> It's messy, I know
17:48:11 --> Ornthalas has joined #instantbird
18:09:11 <-- clokep has quit (Ping timeout)
18:17:56 <flo> Mic: I'm a bit lost in all these menu overlays, but removing <key id="accountsetup"... from menus.xul doesn't seem right is menus.xul is the file included in all Windows on Mac
18:18:08 <flo> (and it seems it is: http://lxr.instantbird.org/instantbird/search?string=menus.xul)
18:36:23 --> clokep has joined #instantbird
18:36:24 * ChanServ sets mode +h clokep 
19:02:17 <-- Ornthalas has quit (Ping timeout)
19:23:16 <-- Jan has quit (Ping timeout)
19:29:17 --> Ornthalas has joined #instantbird
19:34:14 --> Jan has joined #instantbird
19:35:38 --> GeekShadow has joined #instantbird
20:06:13 * tymerkaev is now known as tymerkaev_away
20:18:09 <flo> pfff, I forgot to recompile before launching during at least my last 5 attempts to tweet something :(
20:21:04 <clokep> :( Now you have to try all 5 again? ;)
20:27:44 <flo> no, I was just adding "dump" calls every where trying to understand why nothing appeared in my terminal
20:28:14 <flo> now I have to figure out the meaning of "Incorrect signature" as a reply to my tweet attempts ;)
20:28:36 <clokep> Haha, I feel like you could write a book on how to connect to the Twitter API.
20:29:26 <flo> I guess that was the last part I needed to figure out: how to sign a request that actually has some POST parameters
20:31:23 * clokep really hates the Skype interface.
20:31:43 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
20:35:09 * tymerkaev_away is now known as tymerkaev
20:42:16 <clokep> flo: Something I ran into the other day, does the core handle whether a message contains your name or no is that up to protocol plug-ins?
20:45:57 <-- tymerkaev has quit (Ping timeout)
20:48:43 --> Mic has joined #instantbird
20:48:43 * ChanServ sets mode +h Mic 
20:56:31 --> mokush has joined #instantbird
21:34:03 <flo> clokep: I think it's the core
21:34:15 <clokep> OK. :) I'll give it a try.
21:36:42 --> Mook has joined #instantbird
21:39:00 <-- clokep has quit (Quit: Instantbird 0.3a1pre)
21:39:05 --> clokep has joined #instantbird
21:39:06 * ChanServ sets mode +h clokep 
22:03:59 <flo> uh, the signature was good. I was just missing the content-type header :-S
22:06:33 <flo> http://twitter.com/testib/status/18064192032477184 my first tweet from Instantbird / using the Instantbird key :).
22:11:02 <-- clokep has quit (Ping timeout)
22:16:30 <-- Mook has quit (Ping timeout)
22:31:29 --> Mook has joined #instantbird
22:41:29 <-- Mook has quit (Ping timeout)
22:42:54 <-- mokush has quit (Client exited)
22:45:07 --> mokush has joined #instantbird
23:05:01 --> Mook has joined #instantbird
23:06:30 <Mook> hmm, how do you build a debug instantbird?
23:06:46 <Mook> DEBUG=1 make -f client.mk build ... breaks configure :(
23:07:40 <flo> maybe export DEBUG=1 and . ./mozconfig in a .mozconfig file
23:09:07 <flo> or just edit the current mozconfig file and add export DEBUG=1 at the top
23:12:36 <-- Mook has quit (Ping timeout)
23:13:40 <flo> ahah, I managed to tweet the example that contains unicode characters: http://twitter.com/testib/status/18081649543610368 :)
23:15:20 --> Mook has joined #instantbird
23:16:23 <Mook> nevermind. I had a typo in $MSYSTEM from yesterday while doing something else... :p
23:20:04 <-- mokush has quit (Client exited)
23:22:29 <-- Mook has quit (Ping timeout)
23:28:44 <hicham> flo : would linux distros be able to use the key ?
23:29:00 <flo> not the xAuth enabled one
23:29:14 <flo> except if they request one and get an exception
23:29:32 <flo> but currently I haven't used xAuth at all (even though my key has permissions to do so)
23:30:37 <hicham> flo : imageshack requests that you ask for a key to be able to build their uploader/upload their images, but debian's key is freely available
23:30:42 <hicham> which is weird IMHO
23:31:26 <flo> have they asked the permission to do so, or just decided that whole key thing was stupid and ignored the problem?
23:32:06 --> rikki1 has joined #instantbird
23:32:44 <-- rikki has quit (Connection reset by peer)
23:38:12 --> Mook has joined #instantbird
23:42:44 <Mic> Maybe the second way is the better, just ignore and proceed until they're tired of it ;)
23:43:13 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
23:45:11 <flo> apparently I can now post all the problematic characters: http://twitter.com/testib
23:47:20 <Mook> try for some non-BMP things? :)
23:48:25 <flo> I'll give you the code to try and break it in a few hours, once it's a bit cleaner ;)
23:50:27 <Mook> re: keys: they mainly just want something to revoke if it becomes a problem anyway...
23:51:25 <flo> if you wanted to spam, wouldn't you use the (reverse engineered) key of their own application, so that they can't revoke it?
23:51:46 --> Mic has joined #instantbird
23:51:46 * ChanServ sets mode +h Mic 
23:51:56 <Mook> well, they could, eventually. but they needed some sort of auth :)
23:53:56 <flo> Mook: I think you know the menu code at least as well as I do. Could you please look at Mic's patch in bug 418? :)
23:54:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=418 enh, --, ---, benediktp, ASSI, Keyboard shortcut to open "Join chat" dialog from conversation windows
23:54:18 <Mook> sure. assuming my internet connection cooperates.... :)
23:57:11 <Mook> looks fine; the real solution is to clean up menu.js, of course ;)
23:57:33 <flo> I was wondering if it's fine to remove things from menus.xul
23:57:46 <Mook> no particular reason not to, I tihnk
23:58:01 <flo> isn't that used as an overlay almost everywhere on Mac?
23:58:45 <Mook> sure.
23:59:08 <Mook> it may make sense to pull sharedKeyboardShortcuts.xul from within menus.xul, but that needs testing
23:59:32 <Mook> hmm, it looks like menus.js shouldn't be too hard to wallpaper...
23:59:45 <Mook> (remove the consts and have them be properties of | menus |