All times are UTC.
00:00:26 <clokep> I know. :) 00:01:20 <flo> I think you need to call this.base.disconnecting(aError, aErrorMessage); before this.base.disconnected 00:02:02 <clokep> aError? aErrorMessage? 00:02:04 <flo> so this.base.disconnecting(this._base.NO_ERROR, ""); 00:03:05 <flo> I'm not really sure because all these .base and ._base are very confusing, but I think it's to inform the core of the reason why the account is ending up in the "disconnected" situation 00:03:16 <clokep> I probably shouldn't disconnect until I receive a "QUIT" back from the server? I'm not sure. 00:03:23 <clokep> Right. 00:03:44 <flo> you won't receive anything after you closed the sockets 00:03:50 <clokep> Very true. :) 00:04:18 <clokep> Probably should wait...or after a certain amount of time just close the connection. 00:04:43 <flo> by the way, you have some trailing whitespace (and DOS line endings) 00:05:08 <flo> closing the connection seems OK to me, except if the RFC says you should wait 00:05:58 <clokep> "A client session is terminated with a quit message. The server acknowledges this by sending an ERROR message to the client." 00:06:15 <clokep> So I should probably wait. :) 00:07:24 <flo> I think a comment with an example of matched string would be useful above those big regexps 00:08:03 <flo> and to understand what the various indexes inside the "temp" array refer to 00:09:32 <clokep> flo: Sorry, what are you looking for? An "example of a matched string"? Just like any command or a more general "formula" for it? 00:09:33 <Mic> I was thinking the same when I looked over the code 00:09:59 <flo> a more general formula 00:10:01 <Mic> I wasn't exactly thinking of an example though 00:10:14 <flo> like <nick>[@<server>]? ... 00:10:35 <clokep> So just copy this paragraph: http://tools.ietf.org/html/rfc2812#section-2.3.1 ;) 00:10:38 <flo> well, a comment! :) 00:11:02 <flo> bleah, that's not even more readable than the regexp 00:12:02 <flo> // Report the error 00:12:07 <flo> in the error console? 00:12:15 <clokep> Where am I looking? 00:12:18 <clokep> What function? 00:12:25 <flo> _handleMessage 00:13:02 <flo> I gave up the idea of reviewing _parseMessage... and I think we've already discussed that code for a while 00:13:06 <clokep> Each case is set up as: the line from the RFC as the first comment, then a description of what I'm doing as the second comment. 00:13:20 <clokep> Yes I'll add some comments to it though. 00:14:03 <Mic> clokep: is ERROR what's returned when e.g. trying to chose an already taken name? 00:14:20 <Mic> If yes it shouldn't only go to the error console 00:14:23 <Mic> imo 00:14:38 <flo> let aChannelName let aConversation 00:14:39 <Mic> maybe displaying it on a per case basis? 00:14:55 <clokep> Mic: "The ERROR command is for use by servers when reporting a serious or fatal error to its peers. It may also be sent from one server to another but MUST NOT be accepted from any normal unknown clients." 00:15:07 <flo> names beginning by "a" are for function arguments. local variables usually don't need a prefix 00:15:23 <clokep> flo: OK, I can change all those throughout that function 00:15:46 <clokep> I might just might a few var variables up top too instead of redeclaring each time. 00:15:48 <flo> but maybe you did that because you wanted to handle that as separate functions? ;) 00:16:14 <clokep> Yes, I want to handle it as a separate case. But Mic is right, I probably want to do something besides just report the error. 00:16:37 <clokep> (My guess is I need to disconnect.) 00:16:38 <flo> sure 00:16:50 <flo> depending on how fatal the error is 00:17:49 <clokep> flo: "The ERROR message is also used before terminating a client connection." -- That sounds pretty fatal to me. :) 00:18:03 <flo> ok! 00:18:25 <flo> the "[nickname] entered the room." messages should really be added by the core 00:18:49 <flo> something I'll do as part of the rewrite of the conversation handling 00:19:21 <clokep> Meaning all I would do is notify and the conversation would handle the rest? 00:19:31 <flo> that's what libpurple plugins do 00:19:45 <flo> the current message is written by the libpurple core, not the protocol plugins 00:19:55 <clokep> Ah OK. 00:21:39 <flo> are the "NOTICE" things always system messages? 00:22:03 <clokep> NOTICE is just a private message you can't automatically respond to I believe. 00:22:48 <flo> "You have left the room" ... All these messages will need to be localized. 00:23:23 <clokep> I know. 00:23:29 <flo> :) 00:23:43 <clokep> That should be handled in the core too though? :) 00:24:09 <flo> hmm... maybe 00:25:11 <flo> delete aConversation._getParticipant(aMessage.nickname); <-- what is this doing, or supposed to do? 00:25:38 <clokep> Once the buddy leaves the room I'm trying to delete the reference/property of them in the Chat object. 00:25:43 <clokep> Idk if that line actually works or not. 00:25:55 <flo> I would be surprised if it worked 00:26:40 <flo> delete is not used to call a destructor, like in C++ (and Java?) 00:26:41 * instantbot mumbles something about c++ being evil 00:27:02 <clokep> I looked it up on MDC? But it's quite possible I got confused. :( 00:27:11 <flo> it removes a reference. So you can delete a variable, or a property of an object. Not just a value or an object 00:27:33 <clokep> I want to delete the entire propery? 00:27:41 <clokep> s/propery/property/ 00:28:08 <flo> you want to call delete o this._participants[nick] where this is the Chat object 00:28:16 <flo> *on 00:28:42 <flo> add a _removeParticipant method 00:29:01 <clokep> OK. 00:29:16 <flo> + this will avoid creating a new ConvChatBuddy if you call this on a nick that isn't known yet :) 00:30:27 <clokep> Yes, should I return the result of the delete you think? 00:30:35 <flo> no 00:30:41 <flo> I'm not sure if there's even a result 00:31:10 <flo> it seems it always returns true 00:31:57 <clokep> OK. 00:35:14 <flo> in case "301": // RPL_AWAY, there's a missing ; at the end of the line starting with var aConversation 00:36:51 <clokep> Speaking of which...how would I know when to send the "away" command to the server or anything? Would I have to listen for notification from the core? 00:37:25 <flo> currently yes. But it's not a good way to do it, and we should rewrite that. 00:38:14 <clokep> I agree. :) 00:38:55 <clokep> When I write something like that though should I add it to the account in jsProtoHelper? Like observer and on going away call som efunction which each protocol could overwrite? 00:43:07 <flo> do what sounds good to you :) 00:43:59 <flo> missing ; at the end of let aNormalizedConversationName = normalize(aConversationName) in _getConversation 00:44:23 <clokep> And I switched that to use hasOwnProperty also. 00:44:34 <flo> cool 00:44:38 <flo> I was about to say that 00:45:04 <clokep> Yes. :) 00:45:58 <flo> aMessage += " " + aParams.slice(0,-1).join(" ") + " :" + aParams.slice(-1); 00:46:13 <flo> one space will be enough between " " and + 00:46:24 <flo> and one after , would be nicer :) 00:46:56 <clokep> Alright. :) Didn't even notice I had an extra hah. 00:47:27 <flo> I don't understand that line by the way 00:47:53 <clokep> Join the parameters except the last one, then join the last one w/ a ":" before it. 00:47:56 <flo> I've never managed to remember what the parameters of String.splice do 00:48:09 <clokep> slice, not splice. ;) They do different things. 00:48:18 <clokep> slice(0,-1) takes from 0 to the second to last one. 00:48:23 <clokep> And slice(-1) takes just the last one. 00:48:33 <flo> ok :) 00:49:15 <clokep> I added a comment above the if block. 00:49:41 <flo> can we edit aParams? 00:50:24 <clokep> What do you mean? 00:50:26 <flo> if we could, it would be so much clearer to just prepend ":" to the last parameter 00:51:14 <clokep> aParams = aParams.push(":" + aParams.pop())? 00:51:44 <clokep> Let me think about that. 00:51:52 <flo> yeah, but aParams would be modified; I don't know if that's desirable 00:52:19 <clokep> Does that mean it would be modified from the caller to? 00:52:28 <flo> yes 00:53:16 <clokep> I could copy it to a new array, not sure it would be shorter or not. 00:54:39 <flo> wait, what about for (let i = 0; i < aParams.length - 1; ++i) aMessage += " " + aParams[i]; aMessage += " :" + aParams[aParams.length - 1]; ? 00:55:32 <clokep> Is that less confusing? 00:55:44 <flo> to me it is. I don't know if it is to others too 00:56:35 <clokep> Wait...Apparently slice(0, -1).join(" ") returns empty for an array of length 1. 00:56:39 <clokep> So...I can remove the if statement. 00:56:41 <flo> clokep: either that, or add "Join the parameters except the last one, then join the last one w/ a ":" before it." as a comment before the current code 00:56:50 <clokep> I have that. :) 00:57:01 <flo> ok! 00:57:43 <flo> we are at the end of the file. And I'm too tired to provide useful ideas about how to factor out the socket code today. 00:58:00 <flo> I hope this first review pass has been helpful. 00:58:09 <flo> can you still connect to IRC? :-D 00:58:18 <clokep> Hahah. 01:01:33 <clokep> Yes, it was helpful. Thanks a lot. :) 01:01:42 <flo> you are welcome 01:01:55 <flo> you've done some great work on this! :) 01:02:03 <flo> aaaah, I wanted to post that blog post 01:02:37 <clokep> Ah, I can't connect anymore! :) Got a 461 error. 01:08:34 --> clokep_dev has joined #instantbird 01:08:44 <clokep_dev> I think it's still working flo. :) 01:09:23 <clokep> And I'm gonna test if part works... 01:09:40 <-- clokep has left #instantbird () 01:09:50 --> clokep has joined #instantbird 01:09:50 * ChanServ sets mode +h clokep 01:10:00 <clokep> :) Removed some bugs for me too! Awesome. 01:10:01 <-- clokep_dev has quit (Client exited) 01:10:38 <Mic> Nice :) 01:12:05 <clokep> Haha, I don't handle "JOIN" yet? Apparently? 01:12:07 <clokep> Oops. :) 01:16:36 <flo> I'm going to post https://wiki.instantbird.org/User:Mic/Announcing_clokeps_blog_posting 01:17:13 <clokep> Sounds good. I should probably push these changes then. :P 01:18:12 <flo> the post doesn't say anything about today's review ;) 01:19:56 <clokep> Just realized I should notify the observer of removing buddies in the function. :) 01:25:55 <Mic> flo: mine of clokep's? 01:26:12 <flo> both 01:26:36 <instantbot> Just appeared in Blog@instantbird.org - http://blog.instantbird.org/ : 01:26:37 <instantbot> http://blog.instantbird.org/n34-irc-in-javascript-a-contributor-s-work.html - IRC in Javascript - a contributor's work 01:28:59 <Mic> I think it rather fits in clokep's 01:29:44 <Mic> *fits better 01:30:33 <Mic> Good night, though 01:31:59 <-- Mic has left #instantbird () 01:33:36 <flo> Mic: I wasn't saying someone should add something. Just that the post being posted didn't mean clokep had to rush to commit the changes discussed today because the post doesn't say anything about this 01:33:58 <-- chrisccoulson has quit (Quit: Ex-Chat) 01:35:30 <clokep> Well I'm getting an exception now. :-\ 01:47:08 <-- Ornthalas has quit (Quit: KTHXBYE) 01:55:37 <flo> Good night! 02:04:11 <clokep> Goodnight. :) Thanks for the help! 02:22:13 <-- hicham has quit (Ping timeout) 02:29:14 --> hicham has joined #instantbird 03:06:49 <-- hicham has quit (Client exited) 03:48:54 --> ircjimhall has joined #instantbird 04:23:23 <-- DGMurdockIII has quit (Quit: get satisfied! :: www.unitedservers.de ««« (Gamers.IRC) »»» gamersirc.net ::) 04:46:28 <-- zachlr has quit (Ping timeout) 04:48:01 --> Mook has joined #instantbird 05:02:14 <Mook> hmm. all the things for the UI are done via observer topics? 05:02:54 <clokep> Hey Mook, are you talking about how protocols talk to the UI? yes. 05:03:03 <clokep> https://wiki.instantbird.org/Instantbird:Notifications lists the possible events. 05:03:45 <Mook> yep, on that page, and that's how I came to the conclusion :) 05:04:27 <clokep> Keeps the code separate, which is nice. :) 05:04:46 <Mook> definitely! say, if I wanted a chatzilla-style UI... :p 05:04:58 <Mook> (just poking about because I saw your thing about IRC in JS, actually) 05:05:05 <clokep> I figured. :) 05:05:16 <clokep> If you wanted a chatzille-style UI...I'd say make a theme/extension. ;) 05:05:27 <Mook> yep, probably going to be targetting that 05:05:41 <Mook> just looking at the API first to see if it seems doable (certainly seems to be) 05:06:08 <clokep> Mostly it would just be replacing the tabbrowser binding w/ a new one I thik. 05:06:29 <clokep> Since the conversation binding includes the input box, the html output and the conversation list, etc. 05:06:40 <Mook> well, _I_ want a single-window interface, which incidentally is listed on the "wanted extensions" page... ;) 05:06:49 <clokep> Well if you do, definitely let us know! 05:07:10 <Mook> no promises yet. need to find the time. 05:07:22 <clokep> :) flo has some sample code which adds conversations to the buddy list? I think its borked now though since we upgraded to Mozilla 2 and libpurple 2.7.* 05:07:42 <Mook> I'm sure I can figure things out, it'll be fine :) 05:08:01 <clokep> I'm sure. You seem to know your way around! 05:10:35 <Mook> ah. need to pull m-c. this will take a while... I guess I can grab a nightly and play with that while it does things 05:17:02 <clokep> Yup, m-c. It takes a while. :( 05:17:19 <Mook> well, it's more the whole "build m-c. on windows. on a laptop." 05:17:36 <Mook> I think I'll start by playing with a nightly instead :p 05:18:12 <clokep> :) At least they're zips so you don't need to install. 05:18:44 <Mook> but maybe I should start submitting patches... :p http://sprunge.us/SMGT?diff 05:19:01 <Mook> (windows = mozillabuild = python isn't in /usr/bin) 05:21:56 <clokep> That client.py works for me w/ mozillabuild. 05:22:38 <Mook> hmm. odd. /usr/bin/python exists for you? 05:22:58 <Mook> oh. I ran ./client.py rather than python client.py 05:23:18 <clokep> Yeah I always run python client.py 05:24:11 <-- ircjimhall has left #instantbird () 05:24:12 --> Mook_ib has joined #instantbird 05:25:30 <clokep> Well any feedback would be good or file bugs. :) 05:25:35 <-- Mook_ib has quit (Quit: Instantbird 0.3a1pre) 05:27:14 --> ircjimhall has joined #instantbird 05:38:53 <ircjimhall> /help 05:39:22 <clokep> Hello. 05:40:39 --> tymerkaev has joined #instantbird 05:41:06 <ircjimhall> Hi, I'm new to Instantbird but really like it and it's been a while since I've done IRC so I'm re-learning commands. 05:41:25 <clokep> Ah, I see. :) Good luck. ;) 05:42:23 <ircjimhall> I'm kinda technical but not a programmer but would like to help any way if I can. 05:43:03 <clokep> Well one thing that's a big help is whenever you find a bug, file them in https://bugzilla.instantbird.org 05:43:28 <ircjimhall> OK... I'm using Instantbird on Windows XP and it's working great so far. 05:43:43 <clokep> :) I'm glad! 05:44:39 <ircjimhall> I'm really into the multi-IM thing and just discovered Instantbird but have to say I really like it over Trillian, Pidgin, Miranda, etc. 05:44:47 <ircjimhall> Great work guys! 05:44:56 <clokep> :) Tell your friends! Get more people to use it! :-D 05:44:57 <ircjimhall> Thanks, 05:45:07 <ircjimhall> Will do. 05:45:34 <clokep> :) Definitely let us know if you have any ideas or questions too. :) 05:45:45 <clokep> (Too many smiles, sorry.) 05:49:26 <ircjimhall> LOL 05:50:25 --> rikki1 has joined #instantbird 05:50:35 <-- rikki has quit (Connection reset by peer) 05:50:44 <Mook> hmm, do you guys have a code search (lxr, opengrok, whatever) available? 05:51:18 <clokep> Mook: http://lxr.instantbird.org 05:52:22 <Mook> ah, thanks 05:53:10 <clokep> That should probably be on the developer page on the wiki. :) 06:05:40 <clokep> flo: I'm seeing a weird regression on the findbar which I think might be related to the textbox styling? Too late to file a bug, will do it tomorrow. 06:06:05 <clokep> (When a search fails the box goes red w/ a weird white box inside of it and no text.) 06:07:04 <clokep> nn 06:08:51 <-- clokep has quit (Quit: Instantbird 0.3a1pre) 06:15:15 <Mook> well, white-on-white text, but yes 06:17:23 <Mook> hmm. the tabbrowser probably wouldn't like non-conversation things in there very much 06:18:55 --> Mook_ib has joined #instantbird 06:18:59 <-- Mook_ib has left #instantbird () 06:24:32 <-- tymerkaev has quit (Ping timeout) 06:25:58 --> Mook_ib has joined #instantbird 06:26:35 <-- Mook_ib has left #instantbird () 06:36:15 --> Mook_ib has joined #instantbird 06:36:27 <-- Mook_ib has quit (Quit: Instantbird 0.3a1pre) 06:42:31 --> tymerkaev has joined #instantbird 07:17:41 <-- tymerkaev has quit (Ping timeout) 07:23:54 <-- ircjimhall has quit (Quit: Instantbird 0.2) 07:24:43 --> ircjimhall has joined #instantbird 07:44:03 * zz_auscompgeek is now known as auscompgeek 07:54:31 <auscompgeek> heh i'm still here 08:04:09 --> Mook_ib has joined #instantbird 08:04:43 <-- Mook_ib has left #instantbird () 08:08:11 --> tymerkaev has joined #instantbird 08:21:16 <-- tymerkaev has quit (Ping timeout) 08:41:00 <ircjimhall> Is there anything I should do for now to connect to ICQ network? 09:14:41 --> tymerkaev has joined #instantbird 09:15:23 <-- tymerkaev has quit (Quit: I must go. Good bye!) 09:15:38 --> tymerkaev has joined #instantbird 09:23:14 <flo> Mook: the tabbrowser currently doesn't like non-conversation things, but it's something we want to fix someday. 09:24:27 <Mook> flo: seems reasonable :) 09:24:42 <Mook> I'm trying to decide between sticking instantbird.xul in an iframe or overlaying it. 09:24:49 <flo> heh, I thought you would be asleep ;) 09:25:11 <Mook> well. I _should_ be, yes... but I usually quit IRC when I'm not around. 09:25:33 <-- ircjimhall has quit (Ping timeout) 09:27:27 <flo> I'm curious of what you are trying to do, and what is great about the ChatZilla UI 09:28:11 <Mook> try to do: single-window (incl. buddy and accounts). 09:28:52 <Mook> CZ UI: basically, it's oriented for IRC (mostly fixed number of views, each has stuff going by all the time). also, really just familiarity. 09:29:46 <Mook> (it's actually set up to look more like xchat, with a vertical tab-ish thing) 09:32:50 <flo> I know 2 ways to do a all in one UI 09:33:08 <flo> you can either put the buddy list, and account manager, and the other less interesting windows in tabs in a conversation window 09:33:24 --> Ornthalas has joined #instantbird 09:33:32 <Mook> yeah, that first way is basically what I'm aiming for at the moment 09:33:52 <flo> or decide to put the conversations and other things in the buddy list, by adding a "fake group" that lists the conversations and allow you to switch between them (that's what my all-in-one add-on did) 09:35:56 <Mook> ah, you mean, as impl 09:36:43 <flo> as implementation, but also as appearance (except if you do a heave CSS lifting, the buddy list and the tab list look very different) 09:57:30 --> mepine has joined #instantbird 10:16:01 --> Mook_ib has joined #instantbird 10:17:44 <Mook> wip, still full of holes, but vaguely works: http://i.imgur.com/ly8Ia.png 10:17:59 <-- Mook_ib has left #instantbird () 10:29:50 <-- Mook has quit (Quit: zzz) 10:39:50 --> Mic has joined #instantbird 10:39:50 * ChanServ sets mode +h Mic 10:40:24 <-- Mic has left #instantbird () 10:40:30 --> Mic has joined #instantbird 10:40:30 * ChanServ sets mode +h Mic 10:40:36 <Mic> Hi 11:29:44 <Mic> Hmm :) 11:30:40 <Mic> Nice to see that it attracted someone :) 11:43:19 * auscompgeek is now known as zz_auscompgeek 11:45:28 --> mepine_ has joined #instantbird 11:48:06 <-- mepine has quit (Ping timeout) 11:48:07 * mepine_ is now known as mepine 11:56:40 --> GeekShadow has joined #instantbird 12:27:01 <-- tymerkaev has quit (Ping timeout) 12:30:43 --> hicham has joined #instantbird 12:42:31 --> tymerkaev has joined #instantbird 13:10:44 --> Mic1 has joined #instantbird 13:12:08 <-- Mic has quit (Ping timeout) 13:13:59 <-- Mic1 has quit (Connection reset by peer) 13:17:06 --> Mic has joined #instantbird 13:17:06 * ChanServ sets mode +h Mic 14:06:25 --> Andrey has joined #instantbird 14:07:32 --> Mic1 has joined #instantbird 14:07:33 <-- Mic has quit (Connection reset by peer) 14:29:35 <-- mepine has quit (Quit: é¨ç·£ä¹) 14:51:27 --> zachlr has joined #instantbird 14:52:50 <-- GeekShadow has quit (Ping timeout) 14:56:04 --> clokep has joined #instantbird 14:56:04 * ChanServ sets mode +h clokep 15:15:21 <clokep> Good morning! 15:20:51 <-- hicham has quit (Client exited) 15:21:35 <Mic1> Good morning 15:23:18 <clokep> (Well it's barely morning here still, much less for you guys! 15:23:51 <clokep> Apparently Mook was able to make something akin to Vertical Tabs in like an hour. :P That took me days haha. 15:25:48 <-- clokep has quit (Quit: Instantbird 0.3a1pre) 15:25:54 --> clokep has joined #instantbird 15:25:54 * ChanServ sets mode +h clokep 15:26:07 <Mic1> Yes, I read the logs and it seems he knows what he's doing 15:26:37 <clokep> He's one of the guys from songbird I believe. 15:27:01 <Mic1> Ah, ok. I guess it's different if you've got some practice with the platform already 15:27:17 <clokep> Yeah, that was my first real foray. 15:27:32 <clokep> I guess that's why he didn't have m-c downloaded. ;) Songbird is still using 1.9.1? 1.92? 15:27:46 <Mic1> When I started it took me ages to get the "Join chat" extension done. And it doesn't really do anything but catching a double click on the tab bar and calling a method :D 15:28:18 <Mic1> Packaging an extension by hand is so painful, especially if you're not exactly sure what you're doing :D 15:28:28 <clokep> Hahah. Yes. :) 15:29:07 <clokep> We really need a better way to open conversations from the IM window btw. 15:31:40 <clokep> Quite a few people read it though -- I've had >100 hits in the 12 hours it was posted. 15:33:51 <Mic1> I didn't expect it to have such an impact 15:34:12 <clokep> Makes me think we should try to do something more technical/in-depth once a month perhaps? 15:34:55 <clokep> Then maybe a couple of quick "status update" type posts (just like a list with bug numbers and ideas)? and the last week a more "end-user" focused post of what we've been working on and why people care? 15:36:27 * Mic1 is now known as Mic 15:37:50 <Mic> I wouldn't mind a few more posts, even though I'm not sure if we have enough stuff that's interesting enough to post frequently 15:38:31 <Mic> "Cleaned up makefiles", "Fixed border on whatsoever box", "Changed wording on preferences" are not that interesting imo 15:39:30 <Mic> On the other hand it also displays activity on something 15:42:12 <clokep> I'm going for activity more than interesting. ;) 16:47:05 <-- Tonnes has quit (Quit: ChatZilla 0.9.86 [Firefox 3.6.13/20101203075014]) 16:49:03 --> GeekShadow has joined #instantbird 17:06:48 <-- clokep has quit (Quit: Instantbird 0.3a1pre) 17:59:07 * flo is looking at clokep's changes following yesterday evening's review 18:07:24 * tymerkaev is now known as tymerkaev_away 18:07:27 --> hicham has joined #instantbird 18:21:46 * tymerkaev_away is now known as tymerkaev 18:33:59 <-- Andrey has quit (Quit: ) 18:42:50 <-- Ornthalas has quit (Quit: KTHXBYE) 19:04:06 <Mic> flo: do we have statistics how often blog entries are read by the way? 19:04:42 <flo> no. We would need to include an email in each blog entry to be able to do stats 19:04:44 <Mic> clokep said he had about a hundred views in 12 hours, which is not to bad in my opinion 19:04:54 <flo> we can only know how many people get the rss feed, and how many read the post from our site 19:05:14 <flo> s/email/image/ of course :) 19:05:16 <Mic> That's what I meant by the way 19:05:55 <flo> that's not very relevant stats anyway, because there are rss feeds which include our feed (like the planet mozilla feed!) 19:27:14 --> Mook has joined #instantbird 19:28:41 * tymerkaev is now known as tymerkaev_away 19:28:45 * tymerkaev_away is now known as tymerkaev 19:35:00 <-- Mic has left #instantbird () 19:35:17 --> Mic has joined #instantbird 19:35:17 * ChanServ sets mode +h Mic 19:38:42 * tymerkaev is now known as tymerkaev_away 19:40:16 <Mic> Mook: hi, if you're looking for any other page of the project, check out https://wiki.instantbird.org/Instantbird:related_links#Things_for_developers 19:41:18 * tymerkaev_away is now known as tymerkaev 19:41:31 <Mook> Mic: thanks! you guys have your own pastebin too? hehe 19:42:01 * tymerkaev gets back 19:42:27 <tymerkaev> bah... Mook, hi. 19:42:38 <Mic> I added a link from the developer article on the wiki, so hopefully this page will be more discoverable now 19:43:04 <Mook> tymerkaev: hello :) 19:43:27 <Mook> sigh, I wish menus.xul.inc was an overlay rather than a preprocessor include 19:43:32 --> clokep has joined #instantbird 19:43:33 * ChanServ sets mode +h clokep 19:47:47 <flo> Mook: that's something we should fix 19:48:19 <clokep> flo: Looked over the changes they look good. I'll patch my build, test it later today and push them. :) 19:48:32 <flo> clokep: ok :) 19:50:15 <clokep> I actually added pastebin to that article yesterday night btw. :) It wasn't in there. 19:50:25 <clokep> (The related links article.) 19:50:45 <clokep> And yeah, Mic and flo -- those states don't mean anything since it wouldn't account for RSS reads. 19:51:07 <clokep> But...it kind of means something since people would have to actually go ot mine, since mine wasn't included in the RSS for planet. 19:51:42 <clokep> And I have to go for a bit. :) 19:53:29 <Mic> It's a lower bound/conservative estimate 19:53:36 <Mic> It only gets better 19:54:44 <-- clokep has quit (Ping timeout) 19:56:08 --> matt_ has joined #instantbird 20:00:01 --> clokep has joined #instantbird 20:00:01 * ChanServ sets mode +h clokep 20:28:53 * tymerkaev is now known as tymerkaev_away 20:36:07 --> chrisccoulson has joined #instantbird 20:37:31 <-- matt_ has quit (Client exited) 20:45:53 * tymerkaev_away is now known as tymerkaev 20:45:55 <-- GeekShadow has quit (Quit: The cake is a lie !) 20:49:33 <-- clokep has quit (Ping timeout) 20:55:49 * tymerkaev is now known as tymerkaev_away 20:56:53 --> DGMurdockIII has joined #instantbird 20:58:36 * tymerkaev_away is now known as tymerkaev 21:16:02 * zz_auscompgeek is now known as auscompgeek 21:25:22 --> Ornthalas has joined #instantbird 21:29:58 <Mook> hmm. anybody running a nightly (or equivalent) willing to try out my giant hack to see if it works vaguely okay-ish? 21:30:28 <flo> Mook: I can try in a mac debug build if you want 21:30:39 <Mic> Sure 21:30:54 <Mook> hmm, probably would look all sorts of wrong (windows styling), but that'd help, thanks. https://github.com/downloads/mook/unibrow/unibrow.RELEASE_0_0_0_20101211.xpi 21:31:44 <Mook> oops. damn, forgot to implement window closing. 21:32:41 <flo> wow, I attempted to install it by mistake on Firefox. Just when I tried to click "cancel" on the add-on install prompt, the "Install (time)" button changed to "Install Now" which takes more space and was under my mouse cursor during the click! 21:33:05 <Mook> hahah, that's awesome 21:33:19 <Mook> at least install.rdf should have prevented serious breakage in this cas 21:33:27 <flo> sure, it did! :) 21:33:44 <Mook> (I set toolkit.defaultChromeURI - you would *not* have been happy!) 21:33:46 <flo> but that seems like a serious security issue to me 21:33:51 <flo> ahah 21:34:00 <flo> well, safe mode ;) 21:34:47 <DGMurdockIII> id try it if i could download the file 21:35:15 <Mook> you can also try the downloads link on https://github.com/mook/unibrow of course 21:35:20 --> micahg has joined #instantbird 21:35:36 <flo> actually, the bug doesn't really exist in en-US because "Install Now" as almost the same length as "Install (<one digit>)" 21:35:38 <Mook> hmm. probably need to figure out how to deal with disabling tabbed conversations 21:35:50 <flo> but in french "Installer maintenant" is much longer than "Installer (<one digit>)" 21:36:15 <DGMurdockIII> ty 21:37:38 <DGMurdockIII> ui looks werid 21:37:38 <-- tymerkaev has quit (Ping timeout) 21:37:46 <flo> Mook: on mac the menus are wrong with your add-on 21:38:19 <Mook> ah. yeah, that makes sense 21:38:35 <flo> and trying to open the preference window with Command+, crashes (!) 21:38:35 <Mook> does it get inside the window in a funny way? 21:38:41 <Mook> huh! 21:38:45 <flo> yes, they are inside the window 21:39:05 <Mook> yeah, I basically need to re-implement blist.xul rather than just framing it like that 21:40:44 <flo> if you want to patch the menus so that they are in an overlay and the included file only contains the minimal keyset commandset, ... empty tags, I can probably review and commit it quickly (if it works right on Mac) 21:41:25 <flo> in the terminal I see "JavaScript error: chrome://instantbird/content/conversation.xml, line 585: TextboxSize is not defined" 21:41:43 <flo> you probably missed a Components.utils.import("resource:///modules/imTextboxUtils.jsm"); somewhere 21:42:01 <Mook> hmm. probably. but that scares me, because I'm not using the binding directly... 21:42:12 <Mook> (I'm using <browser src="instantbird.xul"> basically) 21:42:22 <flo> ah 21:42:40 --> Mic2 has joined #instantbird 21:42:52 <Mook> DOMi-from-AMO seems to work for me, btw :) 21:42:54 <Mic2> Interesting 21:43:07 <hicham> shouldn't that be blist.xul ? 21:44:10 <flo> Mook: great! That will be useful if I ever need to debug something theme related thing in a nightly 21:44:19 <Mook> hicham: well. that goes into a _different_ <browser>m but yes ;) 21:44:42 <flo> in debug builds DOMi and venkman are checkouted from their hg repositories and built in 21:45:11 <Mook> flo: if https://github.com/mook/unibrow/blob/master/content/menu-overlay.xul#L23 seems useful, feel free to lift the code 21:45:18 <Mic> flo: if you had asked.. DOMI was always working on Nihgtlies for me 21:45:27 <flo> the crash is at http://mxr.mozilla.org/mozilla-central/source/widget/src/cocoa/nsMenuBarX.mm#857 21:45:30 <Mic> *Nightlies 21:46:01 <Mook> okay, so basically, "wtf, where did my menu go". probably because my toplevel window hasn't got one 21:46:03 <-- micahg has quit (Ping timeout) 21:47:19 <Mic2> It's not possible yet to close the error console and add-ons manager again, is it? 21:47:24 <flo> Mook: the application menu is empty. 21:47:33 <Mook> hmm. things got really confused when I closed the last conversation. instantbird.xul tried to close itself, but it won't be able to... 21:48:02 <Mook> Mic2: no, none of the window closing is implemented yet. will need to get to https://github.com/mook/unibrow/issues#issue/2 at some point :) 21:48:15 <Mook> flo: yep, makes sense. thanks :) 21:48:34 <-- Mic2 has quit (Quit: Instantbird 0.3a1pre) 21:48:41 --> Tonnes has joined #instantbird 21:49:24 <Mic> Very interesting but I guess I'll stick with separate windows though 21:49:42 <Mic> The unified window was exactly the reason I didn't upgrade to Skype 4 back then ;) 21:49:47 <Mook> yep, it's nowhere near actually usable yet. just kinda excited about how quickly I hacked things up ;) 21:49:57 <flo> :) 21:51:53 <flo> that "JavaScript error: chrome://instantbird/content/conversation.xml, line 585: TextboxSize is not defined" is strange, it happens when I have no conversation at all. How come there's a conversation binding in use? 21:52:01 <flo> the real conversations work correctly 21:53:15 <Mook> yeah, I end up pre-loading a instantbird.xul in a frame so I can hack its <conversations>.addConversation to always re-use the window 21:53:23 <Mook> (and other fun things of that nature) 21:53:48 <flo> ah, ok 21:54:01 <flo> I think there's a better (and easy) way to do that 21:55:10 <Mook> probably, yes. I basically need to start implementing my own things rather than hijacking the existing stuff in unexpected ways :) 21:55:38 <flo> you need to call Conversations.registerWindow 21:57:01 <flo> and then look at http://lxr.instantbird.org/instantbird/source/instantbird/modules/imWindows.jsm#333 , the "addConversation" method will be called on a "conversations" tag of the window you have registered 21:58:03 <flo> you may be interested in copying some code from https://hg.instantbird.org/addons/file/f58ea2b90918/allinone/content/allinone.js (the experiment I did a while ago about creating an "all-in-one" add-on that basically created a fake group in the buddy list with all the current conversations 21:58:03 <Mook> ah. okay, yeah, that sounds a lot less painful :) 21:58:41 <flo> :) 21:59:01 <flo> my experiment looked like this: http://queze.net/goinfre/allinone2.png 22:00:05 <Mook> that certainly looks more like an IM client and less like an IRC licent ;) 22:01:03 <flo> it was a quick hack, adding stuff inside blist.xul 22:01:08 <-- DGMurdockIII has quit (Quit: get satisfied! :: www.unitedservers.de ««« (Gamers.IRC) »»» gamersirc.net ::) 22:01:38 <flo> I gave up because I had problems with the tooltip and context menus of the content area, and didn't want to copy/paste a whole lot of code from instantbird.xul/instantbird.js 22:01:38 <Mic> flo: if the participants list wouldn't be part of the conversation binding, you could have moved the participants to the buddy list in all in one 22:01:52 <Mic> e.g. as children of the conversation's group 22:02:22 <flo> yeah... Would not be very easy because the list is a richlistbox and not a tree, but we can fake it 22:02:31 <Mic> (I think separating the participants list from the actual conversation was discussed recently) 22:04:16 <flo> yes, we said it could/should be in a separate binding loaded by the css when the conversation element has the "chat" attribute iirc 22:04:40 <Mook> and the context menu would basically involve moving that to an overlay again.. :) 22:05:29 <flo> Mook: es 22:05:30 <flo> *yes 22:06:58 <flo> the tooltip could be fixed relatively easily (moving the JS code related to it into an XBL binding, and have the event handler inside the conversation binding, that creates the element in the window if it's missing) 22:14:31 * auscompgeek is now known as zz_auscompgeek 22:26:31 <flo> Mook: I think you want to hide the "close" button of the account manager 22:31:32 <Mook> flo: I do, yes. eventually. 22:31:44 <Mook> since it's just broken and does nothing at the moment, I'll do more important things first ;) 22:39:26 <flo> :) 22:41:46 <Mic> Bugzilla could really need a "Related" field 22:42:13 <Mic> (in addition to "Depends on" and "Blocks") 23:06:16 <Mic> flo: minimize to tray (as idea, not the extension) doesn't work on MacOS (since there's no tray?), does it? 23:06:49 <flo> there's a tray, but minimizing to it doesn't really make sense 23:07:01 <flo> we should just not close the application when the buddy list is closed 23:07:14 <flo> and reopen the buddy list when someone clicks on the dock icon and no window is visible 23:07:27 <flo> and make sure the menu from all windows allow to reopen it 23:07:57 <flo> putting an icon with the current status and a way to change it in the tray would make sense though 23:09:24 <Mook> the mac way was to put a little status thing on the dock icon, right? 23:09:31 <Mook> (and now, win7) 23:10:21 <Mic> I'm about to file a tracking bug for OS integration, it should depend on the messaging menu for ubuntu, tray icon for Windows pre-7 and jump lists for Windows 7 so far 23:10:37 <Mic> It's quite general but I have no better idea how to name it 23:12:26 <flo> are you trying to track all the OS specific very annoying issues? 23:12:45 <flo> if so you can add "closing the last window should not quit" for Mac, and "sounds should not freeze the UI" for Linux ;) 23:13:04 <Mic> "Application should be awesome on all OS" as well? ;) 23:13:27 <flo> including Android? :-P 23:13:51 <flo> Mook: we currently put the number of unread messages on the dock, not the status 23:14:18 <Mook> ah, okay 23:14:54 --> clokep has joined #instantbird 23:14:54 * ChanServ sets mode +h clokep 23:15:08 <Mic> Not exactly annoying issues but for tighter integration with the OS's: e.g. using the messaging menu on Ubuntu, which is intended for IM application and similiar 23:16:05 <Mic> Jump lists are the new thing on Windows 7, and might allow to put a list with open conversations or at least unread messages to it (useful if we'd allow to close conversation windows completely) 23:16:11 <Mic> This sort of thing 23:17:55 <Mic> Tray functionality and these have in common that they could/should allow to access functions and/or display the status without having to open an Instantbird window 23:19:32 <Mic> ah! "OS specific status displays and shortcut menus" 23:20:00 <Mic> Sorry for thinking in your ear :S 23:20:36 <instantbot> New Instantbird (UI) bug 618 filed by benediktp@ymail.com. 23:20:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=618 enh, --, ---, nobody, NEW, Use Jump-Lists on Windows 7 23:24:17 <instantbot> New Instantbird (UI) bug 619 filed by benediktp@ymail.com. 23:24:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=619 enh, --, ---, nobody, NEW, OS specific status display and shortcut menus 23:24:43 <clokep> Mic if you file more Windows ones, just CC me. :) 23:25:03 <Mic> Shall I cc you on any Windows bugs from now on? 23:25:37 <clokep> If they're UI enhancements sure. :) 23:25:43 <clokep> (Like using Win7 features.) 23:26:05 <clokep> flo: You saw I lost another piece of my chrome yesterday? :( 23:26:53 <flo> clokep: still losing one everyday? :-P 23:27:05 <clokep> So far today I'm OK. :) 23:37:13 <clokep> flo: One of your hunks failed. :( 23:37:25 <flo> ah? 23:38:34 <Mic> clokep: does "Glass" count as feature? ;) 23:38:40 <clokep> Yes! :-D 23:41:33 <Mic> I feel bad filing bugs without fixing any 23:41:52 <Mic> It's like piling up work without getting any done 23:42:08 <clokep> flo: You have a bug, array.push returns the new length I believe. 23:42:22 <flo> ah 23:43:09 <flo> Mic: getting things out of your head will help you focus on the things you really want to do, and additionally will let others work on the ones you don't want to do yourself :) 23:43:39 --> clokep_dev has joined #instantbird 23:44:10 <clokep_dev> Looks like it's working well. :) 23:44:29 <clokep> Yeah just that one thing flo, thanks. I'm gonna commit it. 23:44:45 <-- clokep_dev has left #instantbird () 23:45:50 <clokep> I really like the way you had it handle the input stream buffer btw. :) 23:47:14 <instantbot> New Instantbird (UI) bug 620 filed by benediktp@ymail.com. 23:47:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=620 enh, --, ---, nobody, NEW, Maybe Instantbird could look nicer using Glass on Windows Vista and 7 23:47:31 <flo> clokep: :). That code seemed clearer :) 23:47:41 <clokep> Mic that's actually one of the ones I've been meaning to file. (Use Glass.) 23:48:35 <Mic> MDC suggests it could be easy to do this. If I had Vista/7 I would have tried instead of filign this bug;) 23:48:55 <flo> someone should probably give some loving care to the appearance on Windows (and Linux too (Mic :-P)). 23:49:00 <flo> I've almost done it for Mac already 23:49:59 <clokep> CSS kind of scares me. ;) 23:50:07 <clokep> Even though I used a lot in Vertical Tabs. 23:53:36 <-- clokep has quit (Quit: Instantbird 0.3a1pre) 23:53:39 --> clokep has joined #instantbird 23:53:39 * ChanServ sets mode +h clokep 23:54:40 <-- clokep has quit (Quit: Instantbird 0.3a1pre) 23:54:44 --> clokep has joined #instantbird 23:54:44 * ChanServ sets mode +h clokep 23:55:10 <clokep> Pretty cool extension Mook! :) Impressive how quickly you made that. 23:55:28 <hicham> which extension ? 23:55:35 <instantbot> New Websites - www.instantbird.com bug 621 filed by benediktp@ymail.com. 23:55:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=621 enh, --, ---, nobody, NEW, Windows Screenshot using Windows Vista or 7 23:57:23 <clokep> hicham: https://github.com/mook/unibrow 23:57:43 <clokep> (Check logs for more info -- I need to step away right now.)