#instantbird log on 11 20 2010

All times are UTC.

00:15:29 <-- hicham has quit (Client exited)
00:16:55 --> clokep has joined #instantbird
00:16:55 * ChanServ sets mode +h clokep 
00:18:54 --> hicham has joined #instantbird
00:41:08 <clokep> Mic: What about changing to tabs? :(
01:01:06 <-- GeekShadow has quit (Quit: The cake is a lie !)
01:15:16 --> mepine has joined #instantbird
01:37:49 <-- mepine has quit (Quit: mepine)
01:44:07 --> mepine has joined #instantbird
01:45:05 <-- Ornthalas has quit (Quit: KTHXBYE)
01:53:06 <-- clokep has quit (Ping timeout)
02:19:42 <-- hicham has quit (Client exited)
04:41:55 <-- mepine has quit (Quit: mepine)
04:47:50 --> clokep has joined #instantbird
04:47:50 * ChanServ sets mode +h clokep 
05:04:41 --> tymerkaev_away has joined #instantbird
06:02:33 <-- tymerkaev_away has quit (Ping timeout)
06:29:38 <-- clokep has quit (Quit: Instantbird 0.3a1pre)
07:10:32 --> mepine has joined #instantbird
07:15:43 <-- mepine has quit (Quit: mepine)
08:16:06 --> mepine has joined #instantbird
08:16:40 --> mepine_ has joined #instantbird
08:16:40 <-- mepine_ has quit (Quit: mepine_)
08:19:12 <-- mepine has quit (Ping timeout)
08:44:34 --> Ornthalas has joined #instantbird
08:54:34 --> Mitch_ has joined #instantbird
08:54:59 <-- Mitch has quit (Ping timeout)
08:55:14 * Mitch_ is now known as Mitch
09:06:15 --> mepine has joined #instantbird
09:29:53 <-- mepine has quit (Quit: mepine)
10:29:32 --> GeekShadow has joined #instantbird
10:31:03 --> tymerkaev has joined #instantbird
10:38:09 --> Even has joined #instantbird
10:38:09 * ChanServ sets mode +o Even 
11:08:04 --> Mic has joined #instantbird
11:08:04 * ChanServ sets mode +h Mic 
11:08:45 <Mic> hi
11:27:06 --> kaie2 has joined #instantbird
11:29:12 <-- kaie has quit (Ping timeout)
11:29:13 * kaie2 is now known as kaie
11:40:22 <-- Ornthalas has quit (Quit: KTHXBYE)
12:15:27 <-- tymerkaev has quit (Client exited)
12:16:27 --> hicham has joined #instantbird
12:18:23 <hicham> Good Morning flo :)
12:18:33 <flo> Hello
12:18:36 * flo goes away for lunch
12:45:35 --> tymerkaev has joined #instantbird
12:49:20 <-- kaie has quit (Quit: Leaving)
12:52:08 <-- hicham has quit (Ping timeout)
12:58:23 <-- tymerkaev has quit (Ping timeout)
12:59:30 --> tymerkaev has joined #instantbird
13:04:44 <-- tymerkaev has quit (Ping timeout)
13:08:23 --> hicham has joined #instantbird
13:34:30 <-- GeekShadow has quit (Connection reset by peer)
13:35:52 --> GeekShadow has joined #instantbird
14:17:36 --> tymerkaev_away has joined #instantbird
14:18:13 * tymerkaev_away is now known as tymerkaev
14:31:07 <-- chrisccoulson has quit (Ping timeout)
14:31:57 --> chrisccoulson has joined #instantbird
14:34:14 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
14:35:55 --> Mic has joined #instantbird
14:35:55 * ChanServ sets mode +h Mic 
14:39:38 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
14:54:17 --> Mic has joined #instantbird
14:54:17 * ChanServ sets mode +h Mic 
14:55:10 <Mic> flo: right now each buddy on the list has its own contact and is set as preferredbuddy of it, is that true?
14:57:55 --> Ornthalas has joined #instantbird
14:58:47 <-- chrisccoulson has quit (Ping timeout)
15:02:20 --> chrisccoulson has joined #instantbird
15:02:25 <Mic> ok, that's not the real problem. I checked with DOM Inspector and it turns out all the buddyIconFilename's on contacts and buddies are null.
15:02:42 <Mic> It's still working on the tooltips though. I'm a bit lost right now.
15:04:25 <Mic> (null or undefined)
15:09:33 <-- chrisccoulson has quit (Ping timeout)
15:09:52 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
15:11:51 --> chrisccoulson has joined #instantbird
15:16:39 --> Mic has joined #instantbird
15:16:39 * ChanServ sets mode +h Mic 
15:20:46 <flo> Mic: "all the buddyIconFilename's on contacts and buddies are null" if it's true it's a bug.
15:21:01 <flo> the tooltip seem to use .buddyIconFilename on the accountBuddy
15:21:12 <Mic> Yes, that's why I'm lost ..
15:23:11 <Mic> wait, yes. It*s set on the account buddy. I've been using "contact.preferredBuddy.preferredAccountBuddy.buddyIconFilename" but it wasn't exactly my first choice
15:28:28 <Mic> Except for that it looks nice to have buddy icons on the status notifications.
15:28:31 <Mic> :)
15:28:38 <Mic> *for this
15:31:12 <-- Mic has left #instantbird ()
15:32:51 --> Mic has joined #instantbird
15:32:51 * ChanServ sets mode +h Mic 
15:36:10 <instantbot> New Instantbird (UI) bug 588 filed by benediktp@ymail.com.
15:36:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=588 nor, --, ---, nobody, NEW, Error when clicking new message notifications
15:40:30 <-- chrisccoulson has quit (Ping timeout)
15:46:47 <flo> I don't understand why "contact.preferredBuddy.preferredAccountBuddy.buddyIconFilename" would give a different result than contact.buddyIconFilename :-S
15:51:24 <Mic> I went through the code (imContacts.js) and couldn't find an obvious problem either
15:54:51 <Mic> http://pastebin.instantbird.com/484
15:55:01 <Mic> I don't know how I triggered this though
15:55:35 <Mic> ah, it's an upper/lowercase typo maybe?
15:58:02 <Mic> Yes, the getter on Buddy has a lower case "name" in "Filename"
15:58:20 --> chrisccoulson has joined #instantbird
16:00:17 <-- Mic has left #instantbird ()
16:10:53 <-- Ornthalas has quit (Ping timeout)
16:14:32 --> mokush has joined #instantbird
16:18:39 <flo> Mic: easy to fix then :)
16:20:05 --> Mic has joined #instantbird
16:20:06 * ChanServ sets mode +h Mic 
16:20:18 <Mic> ok, looks like I fixed it
16:22:01 <-- Mic has left #instantbird ()
16:25:37 --> Mic has joined #instantbird
16:25:37 * ChanServ sets mode +h Mic 
16:27:25 <Mic> that is at least DOMi showing the right path now for contacts and buddies
16:27:41 <Mic> Which said null or undefined before
16:31:35 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
16:31:45 --> Mic has joined #instantbird
16:31:45 * ChanServ sets mode +h Mic 
16:32:28 <-- chrisccoulson has quit (Ping timeout)
16:40:01 --> Ornthalas has joined #instantbird
16:42:28 <instantbot> New purplexpcom - General bug 589 filed by benediktp@ymail.com.
16:42:30 <instantbot> benediktp@ymail.com added attachment 399 to bug 589.
16:42:31 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 399 on bug 589.
16:42:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=589 nor, --, ---, benediktp, ASSI, Contacts and Buddies have null/undefined buddyIconFilename
16:53:49 --> clokep has joined #instantbird
16:53:50 * ChanServ sets mode +h clokep 
17:06:23 <Mic> hi clokep
17:07:52 <instantbot> florian@instantbird.org granted review for attachment 399 on bug 589.
17:07:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=589 nor, --, ---, benediktp, ASSI, Contacts and Buddies have null/undefined buddyIconFilename
17:09:11 <-- mokush has quit (Connection reset by peer)
17:10:30 --> mokush has joined #instantbird
17:16:15 <-- Even has quit (Ping timeout)
17:16:50 <instantbot> florian@instantbird.org set the Resolution field on bug 589 to FIXED.
17:16:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=589 nor, --, 0.3a1, benediktp, RESO FIXED, Contacts and Buddies have null/undefined buddyIconFilename
17:21:47 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b22cea94b111 - Benedikt P. - Bug 589 - Contacts and Buddies have null/undefined buddyIconFilename.
17:23:27 --> chrisccoulson has joined #instantbird
17:25:17 <-- chrisccoulson has quit (Connection reset by peer)
18:00:02 <clokep> flo: Did you figure out the differences between oauth and regular twitterhelper?
18:03:49 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
18:04:07 --> Mic has joined #instantbird
18:04:07 * ChanServ sets mode +h Mic 
18:08:45 --> chrisccoulson has joined #instantbird
18:18:49 <flo> clokep: hello :)
18:18:56 <flo> mostly.
18:19:37 <flo> I changed the tabs to 2 spaces and all occurences of oauthTwitterHelper to TwitterHelper and got something that I could diff against the original twitterhelper.jsm file
18:19:54 <clokep> flo: Oh, OK. I could probably give a real diff somewher.
18:20:16 <flo> I think I have got an almost correct one
18:20:44 <clokep> :)
18:20:46 <flo> the coding style change (removing the line breaks before "{" ) is annoying too for the diff (even though I prefer the changed version :-])
18:21:55 <flo> the diff I have look like this: http://pastebin.instantbird.com/485
18:22:50 <clokep> flo: Looks reasonable. ;) I changed  alot.
18:23:44 <flo> I'm not sure yet of how to work on this
18:24:09 <flo> not sure exactly how much I want to fork this code, and if I take glazou's version as a base or yours
18:24:14 <-- hicham has quit (Client exited)
18:24:30 <clokep> flo: The issue I had with glazou's is that it makes the requests directly -- i.e. no oauth.
18:24:53 <flo> there are parts of the code that I really can't accept as they are. _localizedError is the most obvious example
18:26:58 <flo> clokep: by the way, why have you decided to make the HTTP requests outside of the twitter code instead of changing the behavior of _sendRequest / _sendPostRequest? (it's possible that the the answer would be obvious if I was more familiar with OAuth, but I guess you can save me some time :))
18:28:09 <clokep> flo: I did it so I could use the oauthorizer routines that will make the request automatically for me.
18:28:49 <flo> oauthconsumer.js seemed to me like we would need to rewrite it completely and use oauth.js directly instead
18:29:23 <clokep> Probably.
18:29:28 <clokep> One second. I'm trying to find some code.
18:29:38 <flo> it touches things in preferences, has a list of services that should instead be in each protocol plugin, ...
18:29:57 <clokep> flo: https://hg.instantbird.org/experiments/file/148985b3be02/microblog-instantbird%40patrick.cloke/chrome/content/blist.xul#l20
18:30:01 <clokep> That's why I had it set up the way I did.
18:30:48 <flo> to be able to use "OAuthConsumer.call" without modification?
18:30:52 <clokep> Yes.
18:31:14 <flo> if we rewrite OAuthConsumer that may no longer be relevant then
18:31:19 <clokep> Since the OAuth code scared me a lot more than the Twitter code, I modified the twitter code.
18:31:23 <clokep> Yes. I agree.
18:31:59 <flo> both codes scare me currently, but we can't check them in (and be the de facto maintainer for them) without reviewing and understanding them first
18:32:25 <clokep> :) I agree.
18:32:48 <clokep> I think you're right though that it might be better to use glazou's code & patch those two functions.
18:32:50 <flo> I still need to learn/read a lot about OAuth to be confortable with it
18:33:03 <clokep> Twitter has some good tutorials on the process?
18:33:47 <flo> something I'm also wondering is if we should try to be as close as possible to glazou's code, or fork it liberally to suit our own coding style preferences
18:34:27 <flo> I don't like all the TwitterHelper.prototype.<name> = \nfunction(...) for example
18:34:40 <clokep> I hate his coding style. Almost everything about it.
18:34:53 <clokep> If the changes we make can be taken upstream we should keep his style, if not. I think ew should change it.
18:34:58 <flo> I would write TwitterHelper.prototype = {\n <name>: function(...) ...
18:35:26 <flo> ok, so the next action then is "ask glazou if he wants our changes"
18:36:10 <flo> even if he accepts the oauth changes we make, I don't think he would accept the changes to for example _localizedError
18:36:45 <flo> sorry, phone...
18:37:05 <clokep> Possibly not.
18:37:25 <clokep> And then the other question would be do we keep it as a patch to his original or do we just put it in and make changes.
18:39:49 <Mic> Sounds like the problem I have with Firefox Sync .. I'd like to change it but want to include their improvements as well
18:48:15 <flo> it's the problem we have with libpurple, glib, libxml2, and several smaller parts of the code too
18:48:22 <flo> the comm-central build system too!
18:49:22 <clokep> :(
18:52:56 <Mic> We should discuss this one day..
18:53:23 <clokep> We could use client.py to pull in more and do more as patches if we wanted?
18:53:31 <flo> Mic: you mean this problem with regards to Firefox Sync, or more generally?
18:53:36 <Mic> Don't you think he might understand if you reason how localization is done with the framework
18:53:50 <flo> Mic: "he" = ?
18:54:04 <Mic> Glazou is Daniel Glazman, isn't he?
18:54:11 <clokep> Yes.
18:54:16 <flo> yeah, I know him, we talk in French in #XulFr
18:54:38 <flo> I was just not sure if you were still talking about twitter helper or some other code
18:55:05 <Mic> Sorry for the interjection
18:55:20 <flo> Mic: the biggest problem of the current  _localizedError method is that it popups errors, instead of giving them back to the calling code
18:55:35 <flo> I think it should throw an exception instead of putting a modal dialog in front of the user
18:58:59 <Mic> hmm, I didn't pay attention to what it did with the strings. :(
18:59:10 <Mic> I thought it would just return them
19:02:15 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
19:02:25 --> Mic has joined #instantbird
19:02:25 * ChanServ sets mode +h Mic 
19:02:59 <flo> Mic: the way it's implemented with a switch case is also very suboptimal ;)
19:03:27 <Mic> Where is this code supposed to be included?
19:03:27 <flo> but it's not performance critical code so it doesn't really matter
19:03:50 <Mic> (from his point of view)
19:04:23 <clokep> flo: We'll run into this issue more if we include a couple of things from songbird.
19:04:28 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
19:04:36 --> Mic has joined #instantbird
19:04:37 * ChanServ sets mode +h Mic 
19:05:57 <-- GeekShadow has quit (Quit: The cake is a lie !)
19:07:09 <flo> we can add tabbrowser.xml and a big part of the preference window code in the list of stuff we have copied and modified ;)
19:07:33 <clokep> Should we actually have a list of this somewhere?
19:07:57 <flo> it wouldn't hurt
19:08:07 <flo> but wouldn't help if we don't plan to periodically look for updates
19:08:07 <Mic> Sounds like Frankenstein :P
19:08:31 <flo> we could setup something to watch the changes in hg on the files we have copied and be notified when something was changed
19:09:14 <flo> I think KaiRo has such a system to keep track of the changes of the mozilla-central build system and file bug to port changes to comm-central
19:10:10 <clokep> :)
19:19:05 <-- mokush has quit (Client exited)
19:20:18 <Mic> Where does the Twitter/oAuth code come from? Does he have an own client?
19:20:27 * tymerkaev is now known as tymerkaev_away
19:20:59 <clokep> Yes Mic.
19:21:01 <clokep> twitFactory.
19:23:20 <Mic> I know what feature I'll turn off once that Buddy Icons are working :D
19:23:33 <clokep> ?
19:23:34 <Mic> (on the notifications)
19:23:39 <Mic> Buddy Icons :P
19:23:59 <Mic> It almost always looks awkward
19:25:03 <Mic> hmm :) Maybe some people would like the exact opposite: an icon-only mode
19:25:40 <Mic> No text, no messages, only the buddy icon and the status icon
19:29:41 <Mic> Good evening.
19:30:15 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
19:31:47 * tymerkaev_away is now known as tymerkaev
19:47:18 * tymerkaev is now known as tymerkaev_away
19:49:12 --> hicham has joined #instantbird
19:51:42 <-- auscompgeek has quit (Ping timeout)
19:56:27 --> auscompgeek has joined #instantbird
20:00:20 * tymerkaev_away is now known as tymerkaev
20:05:29 <-- tymerkaev has quit (Ping timeout)
20:17:53 * Jan is now known as Jannenbaum
20:24:02 <-- auscompgeek has quit (Ping timeout)
20:26:59 --> auscompgeek has joined #instantbird
20:30:22 --> eka-tristan has joined #instantbird
20:30:29 <-- eka-tristan has quit (Quit: Chatzilla [SeaMonkey 1.1.17/2009060500])
21:20:51 <-- hicham has quit (Client exited)
21:25:18 --> hicham has joined #instantbird
22:21:45 --> DGMurdockIII has joined #instantbird
22:51:27 <-- chrisccoulson has quit (Ping timeout)
22:59:15 <-- hicham has quit (Ping timeout)
23:04:24 --> GeekShadow has joined #instantbird
23:19:17 --> micahg has joined #instantbird
23:20:52 <-- micahg has quit (Input/output error)
23:21:10 --> hicham has joined #instantbird
23:48:35 --> rikki has joined #instantbird
23:49:27 <-- rikki has quit (Quit: Instantbird 0.2)